4a53209e30ad9e960b86a2089618073e60e0d471
[WebKit.git] / Tools / ChangeLog
1 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Unreviewed, rolling out r220393.
4
5         This patch regresses the performance of WebPage::editorState.
6
7         Reverted changeset:
8
9         "[iOS WK2] WKWebView schedules nonstop layout after pressing
10         cmb+b,i,u inside a contenteditable div"
11         https://bugs.webkit.org/show_bug.cgi?id=175116
12         http://trac.webkit.org/changeset/220393
13
14 2017-08-08  obinna obike  <oobike@apple.com>
15
16         Created Individual EWS Pages
17         https://bugs.webkit.org/show_bug.cgi?id=174477
18
19         Reviewed by Aakash Jain.
20
21         Created individual pages for each EWS. Changed the link within each status bubble
22         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
23
24         * QueueStatusServer/handlers/patch.py:
25         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
26         * QueueStatusServer/handlers/statusbubble.py:
27         (StatusBubble._build_bubble): Updated url for specific EWS.
28         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
29         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
30         all ews queues.
31         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
32         takes you directly to the individual ews page.
33
34 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
35
36         Separate jsc stress test script writer from run-jsc-stress-tests
37         https://bugs.webkit.org/show_bug.cgi?id=175216
38
39         Reviewed by Mark Lam.
40
41         * Scripts/run-jsc-stress-tests:
42         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
43
44 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
45
46         Unreviewed, fix Ubuntu LTS build
47         https://bugs.webkit.org/show_bug.cgi?id=174490
48
49         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
50
51 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
52
53         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
54         https://bugs.webkit.org/show_bug.cgi?id=175302
55         <rdar://problem/33762116>
56
57         Reviewed by Tim Horton.
58
59         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
60         See WebKit ChangeLog for more details.
61
62         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
63         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
64         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
65         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
66         (-[SlowTextInputContext handleEvent:completionHandler:]):
67         (-[SlowInputWebView inputContext]):
68         (-[SlowInputWebView _web_superInputContext]):
69         (TEST):
70
71 2017-08-08  John Wilander  <wilander@apple.com>
72
73         Resource Load Statistics: Clear web processes' state on history removal
74         https://bugs.webkit.org/show_bug.cgi?id=175271
75         <rdar://problem/33756560>
76
77         Reviewed by Chris Dumez.
78
79         Test infrastructure for asynchronous tests of website data
80         removal for _WKWebsiteDataTypeResourceLoadStatistics.
81
82         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
83         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
84         (WTR::InjectedBundle::didReceiveMessageToPage):
85         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
86         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
87         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
88         * WebKitTestRunner/InjectedBundle/TestRunner.h:
89         * WebKitTestRunner/TestController.cpp:
90         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
91         * WebKitTestRunner/TestController.h:
92         * WebKitTestRunner/TestInvocation.cpp:
93         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
94         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
95         * WebKitTestRunner/TestInvocation.h:
96         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
97         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
98
99 2017-08-08  Alicia Boya García  <aboya@igalia.com>
100
101         Add Alicia Boya García as contributor
102         https://bugs.webkit.org/show_bug.cgi?id=175326
103
104         Reviewed by Michael Catanzaro.
105
106         * Scripts/webkitpy/common/config/contributors.json:
107
108 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
109
110         [CMake] Properly test if compiler supports compiler flags
111         https://bugs.webkit.org/show_bug.cgi?id=174490
112
113         Reviewed by Konstantin Tokarev.
114
115         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
116         * MiniBrowser/gtk/CMakeLists.txt:
117         * TestRunnerShared/Bindings/JSWrapper.cpp:
118         (WTR::JSWrapper::initialize):
119         * TestWebKitAPI/CMakeLists.txt:
120         * TestWebKitAPI/PlatformGTK.cmake:
121         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
122         (TestWebKitAPI::CheckedArithmeticTester::run):
123         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
124         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
125         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
126         (formControlsAssociatedCallback):
127         * TestWebKitAPI/glib/CMakeLists.txt:
128         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
129         (Test::getResourcesDir):
130         * WebKitTestRunner/CMakeLists.txt:
131         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
132         (WTR::menuItemClickCallback):
133         (WTR::staticConvertMenuItemToType):
134         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
135         (WTR::TestRunner::setUseDashboardCompatibilityMode):
136         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
137         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
138         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
139         (WTR::AccessibilityUIElement::helpText const):
140         (WTR::AccessibilityUIElement::attributedStringForRange):
141         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
142         (WTR::EventSenderProxy::updateTouchPoint):
143         (WTR::EventSenderProxy::releaseTouchPoint):
144
145 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
146
147         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
148         https://bugs.webkit.org/show_bug.cgi?id=175116
149         <rdar://problem/28279301>
150
151         Reviewed by Darin Adler and Ryosuke Niwa.
152
153         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
154         EditorStateTests run on both iOS and Mac.
155
156         * TestWebKitAPI/EditingTestHarness.h: Added.
157         * TestWebKitAPI/EditingTestHarness.mm: Added.
158
159         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
160         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
161         the state of the latest observed EditorState.
162
163         (-[EditingTestHarness initWithWebView:]):
164         (-[EditingTestHarness dealloc]):
165         (-[EditingTestHarness webView]):
166         (-[EditingTestHarness latestEditorState]):
167         (-[EditingTestHarness editorStateHistory]):
168         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
169         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
170         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
171         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
172         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
173         (-[EditingTestHarness toggleBold]):
174         (-[EditingTestHarness toggleItalic]):
175         (-[EditingTestHarness toggleUnderline]):
176         (-[EditingTestHarness setForegroundColor:]):
177         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
178         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
179         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
180         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
181         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
182         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
183         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
184
185         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
186         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
187         keys and values.
188
189         (-[EditingTestHarness latestEditorStateContains:]):
190         (-[EditingTestHarness _webView:editorStateDidChange:]):
191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
192         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
193         (TestWebKitAPI::setUpEditorStateTestHarness):
194         (TestWebKitAPI::TEST):
195         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
196
197 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
198
199         Prevent domain from being set to a TLD
200         https://bugs.webkit.org/show_bug.cgi?id=175226
201         <rdar://problem/11079948>
202
203         Reviewed by Chris Dumez.
204
205         Extend the public suffix tests to include cases used by the
206         Public Domain 'Public Suffix List'.
207
208         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
209         (TestWebKitAPI::TEST):
210
211 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
212
213         [XCode] webkit-patch should run sort-Xcode-project-file
214         https://bugs.webkit.org/show_bug.cgi?id=174036
215         <rdar://problem/33732709>
216
217         Reviewed by Simon Fraser.
218
219         * Scripts/webkitpy/common/config/ports.py:
220         * Scripts/webkitpy/tool/commands/download.py:
221         * Scripts/webkitpy/tool/commands/download_unittest.py:
222         * Scripts/webkitpy/tool/commands/upload.py:
223         * Scripts/webkitpy/tool/commands/upload_unittest.py:
224         * Scripts/webkitpy/tool/steps/__init__.py:
225         * Scripts/webkitpy/tool/steps/options.py:
226         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
227
228 2017-08-07  Devin Rousso  <drousso@apple.com>
229
230         Web Inspector: Preview Canvas path when viewing a recording
231         https://bugs.webkit.org/show_bug.cgi?id=174967
232
233         Reviewed by Brian Burg.
234
235         * DumpRenderTree/TestOptions.h:
236         * DumpRenderTree/TestOptions.mm:
237         (TestOptions::TestOptions):
238         * DumpRenderTree/mac/DumpRenderTree.mm:
239         (setWebPreferencesForTestOptions):
240         * WebKitTestRunner/TestController.cpp:
241         (WTR::TestController::resetPreferencesToConsistentValues):
242         (WTR::updateTestOptionsFromTestHeader):
243         * WebKitTestRunner/TestOptions.h:
244         (WTR::TestOptions::hasSameInitializationOptions const):
245         Add plumbing for new InspectorAdditions runtime flag.
246
247 2017-08-07  obinna obike  <oobike@apple.com>
248
249         Sorted EWS Queues on Patch page
250         https://bugs.webkit.org/show_bug.cgi?id=173667
251
252         Reviewed by Aakash Jain.
253
254         * QueueStatusServer/handlers/patch.py:
255         (Patch.get): Sorted queue_status.
256         * QueueStatusServer/templates/patch.html:
257         Changed queue_status.items to queue_status because it's a list.
258
259 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
260
261         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
262         https://bugs.webkit.org/show_bug.cgi?id=175286
263
264         Reviewed by Myles C. Maxfield.
265
266         * Scripts/webkitpy/style/checkers/cpp.py:
267         (check_braces):
268         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
269         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
270         (WebKitStyleTest.test_braces):
271         (WebKitStyleTest.test_braces.NS_OPTIONS):
272
273 2017-08-07  Brian Burg  <bburg@apple.com>
274
275         Remove CANVAS_PATH compilation guard
276         https://bugs.webkit.org/show_bug.cgi?id=175207
277
278         Reviewed by Sam Weinig.
279
280         * Scripts/webkitperl/FeatureList.pm:
281         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
282
283 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
284
285         [Win] Use Visual Studio 2017 if installed.
286         https://bugs.webkit.org/show_bug.cgi?id=175188
287
288         Reviewed by Sam Weinig.
289
290         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
291
292         * Scripts/webkitdirs.pm:
293         (visualStudioInstallDir):
294         (msBuildInstallDir):
295
296 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
297
298         [GTK][WPE] Add API to provide browser information required by automation
299         https://bugs.webkit.org/show_bug.cgi?id=175130
300
301         Reviewed by Michael Catanzaro.
302
303         * MiniBrowser/gtk/main.c:
304         (automationStartedCallback): Set browser information when a new automation session is started.
305         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
306         (testAutomationSessionApplicationInfo):
307         (beforeAll):
308
309 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
310
311         Unreviewed, rolling out r220295.
312
313         This change introduced 4 errors in webkitpy tests.
314
315         Reverted changeset:
316
317         "[XCode] webkit-patch should run sort-Xcode-project-file"
318         https://bugs.webkit.org/show_bug.cgi?id=174036
319         http://trac.webkit.org/changeset/220295
320
321 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
322
323         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
324
325         Unreviewed test gardening.
326
327         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
328         (TestWebKitAPI::TEST):
329
330 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
331
332         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
333         https://bugs.webkit.org/show_bug.cgi?id=175083
334
335         Reviewed by Oliver Hunt.
336         
337         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
338         to wait for VM destructions to finish before running the next test. This makes it easier to 
339         understand leaks results from workers tests, and leads to fewer reported leaks.
340
341         * DumpRenderTree/mac/DumpRenderTree.mm:
342         (runTest):
343
344 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
345
346         check-webkit-style: fix path-specific rules for WebKit2 rename
347         https://bugs.webkit.org/show_bug.cgi?id=175182
348
349         Reviewed by David Kilzer.
350
351         * Scripts/webkitpy/style/checker.py:
352
353 2017-08-04  Youenn Fablet  <youenn@apple.com>
354
355         [Cache API] Add Cache and CacheStorage IDL definitions
356         https://bugs.webkit.org/show_bug.cgi?id=175201
357
358         Reviewed by Brady Eidson.
359
360         * DumpRenderTree/mac/DumpRenderTree.mm:
361         (enableExperimentalFeatures):
362         (resetWebPreferencesToConsistentValues):
363         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
364         (WTR::InjectedBundle::beginTesting):
365         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
366         (WTR::TestRunner::setCacheAPIEnabled):
367         * WebKitTestRunner/InjectedBundle/TestRunner.h:
368
369 2017-08-04  John Wilander  <wilander@apple.com>
370
371         Resource Load Statistics: Report user interaction immediately, but only when needed
372         https://bugs.webkit.org/show_bug.cgi?id=175090
373         <rdar://problem/33685546>
374
375         Reviewed by Chris Dumez.
376
377         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
378         (WTR::InjectedBundle::beginTesting):
379             Now calls WebCore::ResourceLoadObserver::clearState().
380
381 2017-08-04  Tim Horton  <timothy_horton@apple.com>
382
383         Add an API test for r220286
384         https://bugs.webkit.org/show_bug.cgi?id=175206
385
386         Reviewed by Simon Fraser.
387
388         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
389         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
390         (createAnimatedResizeWebView):
391         (TEST):
392         Add a test to ensure that we don't call
393         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
394         animated resize.
395
396 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
397
398         [XCode] webkit-patch should run sort-Xcode-project-file
399         https://bugs.webkit.org/show_bug.cgi?id=174036
400
401         Reviewed by Simon Fraser.
402
403         * Scripts/webkitpy/common/config/ports.py:
404         * Scripts/webkitpy/tool/commands/download.py:
405         * Scripts/webkitpy/tool/commands/upload.py:
406         * Scripts/webkitpy/tool/steps/__init__.py:
407         * Scripts/webkitpy/tool/steps/options.py:
408         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
409
410 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
411
412         REGRESSION(r219857): run-benchmark --allplans broken
413         https://bugs.webkit.org/show_bug.cgi?id=175186
414
415         Reviewed by Saam Barati.
416
417         r219857 forgot to update also the calls to BenchmarkRunner() that
418         is done when the script is run with --allplans.
419
420         To fix this (and avoid future issues like this), let's factorize
421         the calls to the benchhmark runner in a run_benchmark_plan()
422         function.
423
424         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
425         (run_benchmark_plan):
426         (start):
427
428 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
429
430         Dashboard bubbles sometimes show failure count instead of crash count
431         https://bugs.webkit.org/show_bug.cgi?id=175157
432         <rdar://problem/33709009>
433
434         Reviewed by Alexey Proskuryakov.
435
436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
437         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
438
439 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
440
441         Add tests for NeverDestroyed
442         https://bugs.webkit.org/show_bug.cgi?id=175146
443
444         Reviewed by Darin Adler.
445
446         * CMakeLists.txt:
447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
448         New files and sort.
449
450         * TestWebKitAPI/Tests/WTF/Logger.h:
451         * TestWebKitAPI/Tests/WTF/Logger.cpp:
452         (TestWebKitAPI::log):
453         (TestWebKitAPI::takeLogStr):
454         * TestWebKitAPI/Tests/WTF/RefLogger.h:
455         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
456         (TestWebKitAPI::log): Deleted.
457         (TestWebKitAPI::takeLogStr): Deleted.
458         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
459
460         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
461         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
462         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
463         (TestWebKitAPI::LifecycleLogger::operator=):
464         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
465         (TestWebKitAPI::LifecycleLogger::setName):
466         (TestWebKitAPI::TEST):
467         Add a class that logs construction / assignment / modifications.
468
469         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
470         (TestWebKitAPI::TEST):
471         (TestWebKitAPI::list):
472         Test construction behavior is as expected both directly and using makeNeverDestroyed.
473
474 2017-08-04  Lucas Forschler  <lforschler@apple.com>
475
476         minification logic is not implemented for ios builds
477         <rdar://problem/33726561>
478
479         Reviewed by Dean Johnson
480
481         * BuildSlaveSupport/built-product-archive:
482         (minifyDirectory): refactor minifySource -> minifyDirectory
483         (archiveBuiltProduct): add ios minification logic
484         (minifySource): Deleted.
485
486 2017-08-04  Matt Lewis  <jlewis3@apple.com>
487
488         Unreviewed, rolling out r220271.
489
490         Rolling out due to Layout Test failing on iOS Simulator.
491
492         Reverted changeset:
493
494         "Remove STREAMS_API compilation guard"
495         https://bugs.webkit.org/show_bug.cgi?id=175165
496         http://trac.webkit.org/changeset/220271
497
498 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
499
500         Unreviewed, rolling out r220268.
501
502         This change caused assertion failures on macOS and iOS Debug
503         WK2.
504
505         Reverted changeset:
506
507         "Resource Load Statistics: Report user interaction
508         immediately, but only when needed"
509         https://bugs.webkit.org/show_bug.cgi?id=175090
510         http://trac.webkit.org/changeset/220268
511
512 2017-08-04  Youenn Fablet  <youenn@apple.com>
513
514         Remove STREAMS_API compilation guard
515         https://bugs.webkit.org/show_bug.cgi?id=175165
516
517         Reviewed by Darin Adler.
518
519         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
520
521 2017-08-04  John Wilander  <wilander@apple.com>
522
523         Resource Load Statistics: Report user interaction immediately, but only when needed
524         https://bugs.webkit.org/show_bug.cgi?id=175090
525         <rdar://problem/33685546>
526
527         Reviewed by Chris Dumez.
528
529         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
530         (WTR::InjectedBundle::beginTesting):
531             Now calls WebCore::ResourceLoadObserver::clearState().
532
533 2017-08-03  Brian Burg  <bburg@apple.com>
534
535         Remove ENABLE(WEB_SOCKET) guards
536         https://bugs.webkit.org/show_bug.cgi?id=167044
537
538         Reviewed by Joseph Pecoraro.
539
540         * Scripts/webkitperl/FeatureList.pm:
541         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
542
543 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
544
545         REGRESSION(r219850): run-benchmark script broken on Linux
546         https://bugs.webkit.org/show_bug.cgi?id=175126
547
548         Reviewed by Stephanie Lewis.
549
550         The run-benchmark script dynamically generates the list of supported
551         browsers and platforms (currently Linux and OSX) by loading all
552         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
553         and getting the browser_name and platform variables from the
554         classes defined there.
555
556         This means that this classes should not raise an exception when
557         loaded on other platforms or otherwise they will broke the whole
558         script. Its fine if they raise an exception when executing any of
559         the methods they implement, but not when just loading/importing
560         the class.
561
562         Move the argument variable definitions that call on the platform
563         specific OSXBrowserDriver._screen_size() function from beeing
564         variables that are evaluated when loading the file, to be functions
565         that are only evaluated when the actual functionality needs to be
566         executed.
567
568         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
569         (OSXChromeDriver.launch_url):
570         (OSXChromeCanaryDriver.launch_url):
571         (create_args):
572         (create_chrome_options):
573         (create_window_size_arg):
574         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
575         (OSXFirefoxDriver.launch_url):
576         (OSXFirefoxNightlyDriver.launch_url):
577         (OSXFirefoxNightlyDriver.launch_driver):
578         (create_args):
579
580 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
581
582         [PAL] Move spi/cf directory into PAL
583         https://bugs.webkit.org/show_bug.cgi?id=175057
584
585         Reviewed by Antti Koivisto.
586
587         * Scripts/webkitpy/style/checker.py:
588         * Scripts/webkitpy/style/checker_unittest.py:
589         (GlobalVariablesTest.test_path_rules_specifier):
590
591         Ignore "readability/naming/underscores" style errors for sources
592         under the WebCore/PAL/pal/spi directory.
593
594         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
595
596 2017-08-03  Youenn Fablet  <youenn@apple.com>
597
598         Remove FETCH_API compilation guard
599         https://bugs.webkit.org/show_bug.cgi?id=175154
600
601         Reviewed by Chris Dumez.
602
603         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
604
605 2017-08-03  Lucas Forschler  <lforschler@apple.com>
606
607         Enable archive minification on iOS builds
608         https://bugs.webkit.org/show_bug.cgi?id=174718
609         
610         Reviewed by Aakash Jain.
611
612         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
613         (BuildFactory.__init__):
614
615 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
616
617         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
618         https://bugs.webkit.org/show_bug.cgi?id=175140
619
620         Reviewed by Alexey Proskuryakov.
621
622         We are having lately issues with JSC tests causing problems on
623         the GTK+ and WPE bots due to the high amount of memory some tests
624         need to run.
625
626         The best thing we can do now is to workaround this by disabling
627         all the tests marked as memoryLimited on the GTK and WPE bots.
628         We may revise this on the future.
629
630         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
631         (RunJavaScriptCoreTests.start):
632
633 2017-08-03  Brady Eidson  <beidson@apple.com>
634
635         Add SW IDLs and stub out basic functionality.
636         https://bugs.webkit.org/show_bug.cgi?id=175115
637
638         Reviewed by Chris Dumez.
639
640         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
641
642         * Scripts/webkitpy/bindings/main.py:
643
644 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
645
646         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
647         https://bugs.webkit.org/show_bug.cgi?id=159510
648
649         Reviewed by Daniel Bates.
650
651         Allow any https certificate when running tests.
652
653         * DumpRenderTree/win/DumpRenderTree.cpp:
654         (runTest):
655
656 2017-08-02  Youenn Fablet  <youenn@apple.com>
657
658         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
659         https://bugs.webkit.org/show_bug.cgi?id=175089
660
661         Reviewed by Chris Dumez.
662
663         * DumpRenderTree/TestOptions.mm:
664         (TestOptions::TestOptions): Using absolutePath if available.
665         * DumpRenderTree/mac/DumpRenderTree.mm:
666         (computeTestURL): Removing http/tests/ specific URL computation.
667         * Scripts/webkitpy/port/driver.py:
668         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
669
670 2017-08-02  Lucas Forschler  <lforschler@apple.com>
671
672         download-built-product should allow for a proxy option
673         https://bugs.webkit.org/show_bug.cgi?id=174875
674
675         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
676
677         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
678         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
679         
680
681 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
682
683         check-webkit-style: deleting lines in a file runs the linter on the whole file
684         https://bugs.webkit.org/show_bug.cgi?id=175078
685
686         Reviewed by David Kilzer.
687
688         Deleting lines in a file should not cause linter errors to be blamed on the patch.
689         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
690
691         * Scripts/webkitpy/style/checkers/test_expectations.py:
692         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
693         * Scripts/webkitpy/style/main_unittest.py:
694         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
695         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
696         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
697
698 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
699
700         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
701         https://bugs.webkit.org/show_bug.cgi?id=175075
702
703         Reviewed by David Kilzer.
704
705         We have no way of handling text files with illegal unicode characters. Allow the callers of
706         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
707         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
708
709         * Scripts/webkitpy/common/system/filesystem.py:
710         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
711         (FileSystem.write_text_file): Ditto.
712         * Scripts/webkitpy/common/system/filesystem_mock.py:
713         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
714         (MockFileSystem.write_text_file): Ditto.
715         * Scripts/webkitpy/common/system/filesystem_unittest.py:
716         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
717         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
718
719 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
720
721         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
722         https://bugs.webkit.org/show_bug.cgi?id=175072
723
724         Reviewed by Alexey Proskuryakov.
725
726         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
727         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
728
729 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
730
731         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
732         https://bugs.webkit.org/show_bug.cgi?id=175019
733
734         Reviewed by Darin Adler.
735
736         * TestWebKitAPI/CMakeLists.txt:
737
738 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
739
740         Enabling uploading archives to S3
741         https://bugs.webkit.org/show_bug.cgi?id=174198
742
743         Unreviewed unit test fix after r219235.
744
745         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
746
747 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
748
749         Fix JSCOnly ARM buildbots after r220047
750         https://bugs.webkit.org/show_bug.cgi?id=174993
751
752         Unreviewed fix after r220087.
753
754         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
755         (BuildAndRemoteJSCTestsFactory.__init__):
756
757 2017-08-01  Chris Dumez  <cdumez@apple.com>
758
759         Add initial support for navigator.sendBeacon
760         https://bugs.webkit.org/show_bug.cgi?id=175007
761         <rdar://problem/33547728>
762
763         Reviewed by Sam Weinig.
764
765         Enable the Beacon API at runtime in the context of layout tests since the
766         feature is currently disabled by default.
767
768         * DumpRenderTree/mac/DumpRenderTree.mm:
769         (enableExperimentalFeatures):
770         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
771         (WTR::InjectedBundle::beginTesting):
772         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
773         (WTR::TestRunner::setModernMediaControlsEnabled):
774         (WTR::TestRunner::setBeaconAPIEnabled):
775         * WebKitTestRunner/InjectedBundle/TestRunner.h:
776
777 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
778
779         Update Bot Watcher's Dashboard for Buildbot 0.9
780         https://bugs.webkit.org/show_bug.cgi?id=174777
781
782         Reviewed by Daniel Bates.
783
784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
785         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
786         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
787         in a dictionary.
788         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
789         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
790         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
791         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
792         (parseRevisionProperty): Ditto.
793         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
794         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
795         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
796         have changed in Buildbot 0.9.
797         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
798         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
799         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
800         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
801         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
802         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
803         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
804         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
805         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
806         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
807         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
808         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
809         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
810         (BuildbotQueue.prototype.get overviewURL): Ditto.
811         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
812         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
813         Buildbot 0.8 or 0.9.
814         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
815         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
816         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
817         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
818         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
819         Therefore we are fetching information for fixed number of build. 
820         Also iterating the loop incrementally since the build data is already reverse sorted.
821         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
822         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
823         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
824         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
825         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
826
827 2017-08-01  Devin Rousso  <drousso@apple.com>
828
829         Web Inspector: simplify WebInspector with WI
830         https://bugs.webkit.org/show_bug.cgi?id=175058
831
832         Reviewed by Joseph Pecoraro.
833
834         * Scripts/check-inspector-strings:
835         (extract_ui_strings):
836         * Scripts/extract-localizable-js-strings:
837
838 2017-08-01  Youenn Fablet  <youenn@apple.com>
839
840         Layout tests with 'https' suffix should be run over HTTPS
841         https://bugs.webkit.org/show_bug.cgi?id=174992
842
843         Reviewed by Chris Dumez.
844
845         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
846         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
847         Covered by corresponding unit tests.
848
849         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
850         (run_server):
851         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
852         (base_http_url):
853         (base_https_url):
854         (base_url): Deleted.
855         * Scripts/webkitpy/port/base.py:
856         (Port.to.web_platform_test_server_base_http_url):
857         (Port.to):
858         (Port.to.web_platform_test_server_base_https_url):
859         (Port.to.web_platform_test_server_base_url): Deleted.
860         * Scripts/webkitpy/port/driver.py:
861         (Driver.__init__):
862         (Driver.wpt_test_path_to_uri):
863         (Driver):
864         (Driver.http_test_path_to_uri):
865         (Driver.test_to_uri):
866         (Driver.uri_to_test):
867         * Scripts/webkitpy/port/driver_unittest.py:
868         (DriverTest.test_test_to_uri):
869         (DriverTest.test_uri_to_test):
870
871 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
872
873         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
874         https://bugs.webkit.org/show_bug.cgi?id=173998
875
876         Reviewed by Darin Adler.
877
878         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
879         detect mistakes in backward compatibility in the future when we change it.
880
881         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
882         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
883         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
884         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
885         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
886         internal key data slot.
887
888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
889         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
890         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
891         (getNextMessage):
892         (TEST):
893         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
894         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
895         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
896         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
897         These are the pre-baked databases.
898         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
899         This is the actual test that do all the reads and comparisons.
900         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
901         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
902         IndexedDB new stuffs. Then it can be used to bake the database again.
903
904 2017-08-01  Brady Eidson  <beidson@apple.com>
905
906         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
907         https://bugs.webkit.org/show_bug.cgi?id=175030
908
909         Reviewed by Andy Estes.
910
911         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
912         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
913
914 2017-08-01  Brady Eidson  <beidson@apple.com>
915
916         Part 2 of: Rename DatabaseProcess to StorageProcess.
917         https://bugs.webkit.org/show_bug.cgi?id=174880
918
919         Reviewed by Andy Estes.
920
921         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
922         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
923         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
924         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
925         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
926         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
927         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
928         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
929
930 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
931
932         Fix JSCOnly ARM buildbots after r220047
933         https://bugs.webkit.org/show_bug.cgi?id=174993
934
935         Reviewed by Saam Barati.
936
937         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
938         (BuildAndRemoteJSCTestsFactory.__init__):
939
940 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
941
942         [WTF] Introduce Private Symbols
943         https://bugs.webkit.org/show_bug.cgi?id=174935
944
945         Reviewed by Darin Adler.
946
947         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
948         (TestWebKitAPI::TEST):
949
950 2017-07-30  Darin Adler  <darin@apple.com>
951
952         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
953         https://bugs.webkit.org/show_bug.cgi?id=130653
954
955         Reviewed by Antti Koivisto.
956
957         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
958         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
959         when calling frameDidChangeLocation.
960         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
961         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
962         thus causing mysterious failures of a couple of tests. There are two remaining issues:
963         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
964         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
965         same logic flaw that causes "top loading frame" to get set to one of the subframes in
966         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
967         loading, subframe starts loading. It would be good to clean that up some day, but for now
968         this patch makes the two work identically rather than changing both.
969         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
970
971 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
972
973         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
974         https://bugs.webkit.org/show_bug.cgi?id=174963
975
976         Reviewed by Darin Adler.
977
978         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
979         RetainPtr<>. This patch changes them to all use auto.
980
981         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
982         (TestWebKitAPI::TEST):
983
984 2017-07-30  Brady Eidson  <beidson@apple.com>
985
986         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
987         https://bugs.webkit.org/show_bug.cgi?id=174958
988
989         Reviewed by Darin Adler.
990
991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
992         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
993         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
994         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
995         (runUntilTasksInFlight):
996         (TEST):
997
998 2017-07-28  Commit Queue  <commit-queue@webkit.org>
999
1000         Unreviewed, rolling out r219990.
1001         https://bugs.webkit.org/show_bug.cgi?id=174961
1002
1003         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
1004         estes on #webkit).
1005
1006         Reverted changeset:
1007
1008         "Part 2 of: Rename DatabaseProcess to StorageProcess."
1009         https://bugs.webkit.org/show_bug.cgi?id=174880
1010         http://trac.webkit.org/changeset/219990
1011
1012 2017-07-28  Brady Eidson  <beidson@apple.com>
1013
1014         API tests that use URLSchemeHandler are failing.
1015         https://bugs.webkit.org/show_bug.cgi?id=174950
1016
1017         Reviewed by Alex Christensen.
1018
1019         Fix the NoMIMEType test to be correct.
1020
1021         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1022         (-[SchemeHandler initWithData:mimeType:]):
1023         (-[SchemeHandler webView:startURLSchemeTask:]):
1024         (TEST):
1025
1026 2017-07-28  Daniel Bates  <dabates@apple.com>
1027
1028         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
1029         https://bugs.webkit.org/show_bug.cgi?id=174876
1030
1031         Reviewed by Alex Christensen.
1032
1033         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
1034         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
1035         they provide a more direct way to test the platform abstraction.
1036
1037         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
1038
1039         * Scripts/prepare-ChangeLog:
1040         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
1041         of the current working directory.
1042
1043 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
1044
1045         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1046         https://bugs.webkit.org/show_bug.cgi?id=174930
1047
1048         Unreviewed test fix.
1049
1050         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
1051
1052         * Scripts/prepare-ChangeLog:
1053         (get_function_line_ranges_for_cpp):
1054
1055 2017-07-28  JF Bastien  <jfbastien@apple.com>
1056
1057         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1058         https://bugs.webkit.org/show_bug.cgi?id=174930
1059
1060         Reviewed by Daniel Bates.
1061
1062         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
1063         here also teach it about const and volatile overloads. I didn't do
1064         reference and rvalue reference overloads because we don't really
1065         use them, and the current parser throws away those characters and
1066         it doesn't seem worth making it more complex.
1067
1068         * Scripts/prepare-ChangeLog:
1069         (get_function_line_ranges_for_cpp):
1070         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1071         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
1072         (Foo::Arrow::arrow):
1073         (Foo::Arrow::otherArrow):
1074         (Foo::Arrow::otherArrow const):
1075         (Foo::Arrow::otherArrow volatile):
1076         (Foo::Arrow::otherArrow const volatile):
1077
1078 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
1079
1080         [GTK] Building with ENABLE_VIDEO=OFF fails
1081         https://bugs.webkit.org/show_bug.cgi?id=174940
1082
1083         Reviewed by Alex Christensen.
1084
1085         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
1086         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
1087
1088         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1089         (methodCallCallback): Add missing USE(GSTREAMER) guard.
1090
1091 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
1092
1093         [WPE] Implement EventSenderProxy in WTR
1094         https://bugs.webkit.org/show_bug.cgi?id=173419
1095
1096         Reviewed by Žan Doberšek.
1097
1098         Add the implementation of EventSenderProxy to the WTR. This
1099         allows us to extend the coverage of the test suite in WKWPE.
1100
1101         * WebKitTestRunner/EventSenderProxy.h:
1102         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
1103         libxkbcommon needed to deal with key events.
1104         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1105         (WTR::EventSenderProxy::EventSenderProxy):
1106         (WTR::senderButtonToWPEButton):
1107         (WTR::EventSenderProxy::mouseDown):
1108         (WTR::EventSenderProxy::mouseUp):
1109         (WTR::EventSenderProxy::mouseMoveTo):
1110         (WTR::EventSenderProxy::mouseScrollBy):
1111         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1112         (WTR::EventSenderProxy::leapForward):
1113         (WTR::wkEventModifiersToWPE):
1114         (WTR::getXKBKeySymForKeyRef):
1115         (WTR::EventSenderProxy::keyDown):
1116         (WTR::EventSenderProxy::addTouchPoint):
1117         (WTR::EventSenderProxy::updateTouchPoint):
1118         (WTR::EventSenderProxy::setTouchModifier):
1119         (WTR::EventSenderProxy::setTouchPointRadius):
1120         (WTR::EventSenderProxy::getUpdatedTouchEvents):
1121         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
1122         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1123         (WTR::EventSenderProxy::touchStart):
1124         (WTR::EventSenderProxy::touchMove):
1125         (WTR::EventSenderProxy::touchEnd):
1126         (WTR::EventSenderProxy::touchCancel):
1127         (WTR::EventSenderProxy::clearTouchPoints):
1128         (WTR::EventSenderProxy::releaseTouchPoint):
1129         (WTR::EventSenderProxy::cancelTouchPoint):
1130
1131 2017-07-27  Brady Eidson  <beidson@apple.com>
1132
1133         Part 2 of: Rename DatabaseProcess to StorageProcess.
1134         https://bugs.webkit.org/show_bug.cgi?id=174880
1135
1136         Reviewed by Andy Estes.
1137
1138         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1139         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1140         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1141         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1142         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1143         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1144         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1145         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1146
1147 2017-07-26  Mark Lam  <mark.lam@apple.com>
1148
1149         Add ability to only run specific tests in run-javascriptcore-tests.
1150         https://bugs.webkit.org/show_bug.cgi?id=174884
1151
1152         Reviewed by Saam Barati.
1153
1154         For example, if we only want to run testapi, we can do so as follows:
1155             $ run-javascriptcore-tests --testapi
1156
1157         Previously, specifying --testapi effectively does nothing because we run all tests
1158         by default.  Only --no-testapi had the effect of disabling the test set.  This
1159         old behavior for --testapi is not very useful or meaningful.  We're now changing
1160         it to mean that we will only run that test.
1161
1162         With this change, we can also run more than one set of tests.  For example, if we
1163         only want to run testmasm and testair, we can do so as follows:
1164             $ run-javascriptcore-tests --testmasm --testair
1165
1166         By default, if no specific test option is specified, run-javascriptcore-tests will
1167         run all tests.
1168
1169         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
1170         the mozilla tests (--mozilla-tests) even though both are run via the lower level
1171         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
1172         the other set will not run.  For example, the following only runs the mozilla tests:
1173             $ run-javascriptcore-tests --mozilla-tests
1174
1175         Note also that --jit-stress-tests is not for choosing a different set of tests.
1176         Instead, it is used for determining whether we run JIT'ed test configurations
1177         on the jsc stress tests and mozilla tests.  As a result, specifying
1178         --jit-stress-tests will not omit other tests.  For example, the following still
1179         runs all tests:
1180             $ run-javascriptcore-tests --jit-stress-tests
1181
1182         * Scripts/run-javascriptcore-tests:
1183         (defaultStringForTestState):
1184         (enableTestOrNot):
1185         (runJSCStressTests):
1186
1187 2017-07-26  Mark Lam  <mark.lam@apple.com>
1188
1189         Make run-javascriptcore-test run testair, testb3, and testmasm.
1190         https://bugs.webkit.org/show_bug.cgi?id=174837
1191         <rdar://problem/33522927>
1192
1193         Reviewed by Saam Barati and Filip Pizlo.
1194
1195         1. Refactors code for running testapi so that we can use it to run other tests.
1196         2. Added running of testmasm, testair, testb3.
1197
1198         Note: the existing testapi invocation code does not support remote invocation of
1199         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
1200         and testb3 also do not support remote invocation.  If we wish to add remote
1201         invocation support, we should do that in a separate patch.
1202
1203         * Scripts/run-javascriptcore-tests:
1204         (testPath):
1205         (runTest):
1206         (testapiPath): Deleted.
1207
1208 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
1209
1210         Remove duplicate code from Buildbot.js in dashboard
1211         https://bugs.webkit.org/show_bug.cgi?id=174870
1212
1213         Reviewed by Daniel Bates.
1214
1215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1216         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
1217         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
1218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
1219         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
1220
1221 2017-07-26  Brady Eidson  <beidson@apple.com>
1222
1223         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
1224         https://bugs.webkit.org/show_bug.cgi?id=174851
1225
1226         Reviewed by Chris Dumez.
1227
1228         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1229         (TEST):
1230
1231 2017-07-26  Brian Burg  <bburg@apple.com>
1232
1233         Remove WEB_TIMING feature flag
1234         https://bugs.webkit.org/show_bug.cgi?id=174795
1235
1236         Reviewed by Alex Christensen.
1237
1238         * Scripts/webkitperl/FeatureList.pm:
1239         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1240
1241 2017-07-26  Chris Dumez  <cdumez@apple.com>
1242
1243         Pressing the Escape key should not be a valid user gesture to enter fullscreen
1244         https://bugs.webkit.org/show_bug.cgi?id=174864
1245         <rdar://problem/33009088>
1246
1247         Reviewed by Geoffrey Garen.
1248
1249         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
1250         WKTR.
1251
1252         * DumpRenderTree/mac/EventSendingController.mm:
1253         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1254
1255 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
1256
1257         Unreviewed, added Romain Bellessort to contributors.json.
1258
1259         * Scripts/webkitpy/common/config/contributors.json:
1260
1261 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
1262
1263         [WPE] WebGL2 support
1264         https://bugs.webkit.org/show_bug.cgi?id=174249
1265
1266         Reviewed by Alex Christensen.
1267
1268         * Scripts/webkitperl/FeatureList.pm:
1269         Enable WebGL2 for WPE when building through build-webkit.
1270
1271 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1272
1273         Unreviewed. Fix GTK distcheck.
1274
1275         * gtk/make-dist.py:
1276         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
1277
1278 2017-07-25  Brady Eidson  <beidson@apple.com>
1279
1280         ResourceLoadStatistics grandfathering happens much too often.
1281         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
1282
1283         Reviewed by Chris Dumez.
1284
1285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1286         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
1287         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
1288         (TEST):
1289
1290 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
1291
1292         Fix autoinstaller failing on autoinstall_everything
1293         https://bugs.webkit.org/show_bug.cgi?id=174830
1294
1295         Reviewed by Joseph Pecoraro.
1296
1297         * Scripts/webkitpy/thirdparty/__init__.py:
1298         (AutoinstallImportHook.find_module):
1299         (AutoinstallImportHook.install_chromedriver):
1300         (AutoinstallImportHook.install_geckodriver):
1301         (AutoinstallImportHook._install_chromedriver): Deleted.
1302         (AutoinstallImportHook._install_geckodriver): Deleted.
1303
1304 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
1305
1306         Replace --runtime with something for both ios-simulator and ios-device
1307         https://bugs.webkit.org/show_bug.cgi?id=173775
1308         <rdar://problem/32952164>
1309
1310         Reviewed by Aakash Jain.
1311
1312         Add --version flag for both iOS simulator and iOS device.
1313
1314         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1315         (parse_args): Add --version flag and move --no-install.
1316         * Scripts/webkitpy/port/factory.py:
1317         (platform_options): Move --no-intall to run_webkit_tests.py.
1318         * Scripts/webkitpy/port/ios.py:
1319         (IOSPort):
1320         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
1321         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
1322         * Scripts/webkitpy/port/ios_device.py:
1323         (IOSDevicePort.ios_version): Consult --version flag before checking connected
1324         devices for iOS version.
1325         * Scripts/webkitpy/port/ios_device_unittest.py:
1326         (IOSDeviceTest.make_port): Set --version option so that we can generate test
1327         expectation paths without devices connected.
1328         (IOSDeviceTest.test_additional_platform_directory): Deleted.
1329         (IOSDeviceTest.test_baseline_searchpath): Deleted.
1330         (IOSDeviceTest.test_expectations_ordering): Deleted.
1331         * Scripts/webkitpy/port/ios_simulator.py:
1332         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
1333         flag to specify a runtime.
1334         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
1335         flag and then use the default runtime.
1336
1337 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1338
1339         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
1340         https://bugs.webkit.org/show_bug.cgi?id=174815
1341
1342         Reviewed by Carlos Alberto Lopez Perez.
1343
1344         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
1345         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
1346         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
1347         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
1348         think), probably because of a newer CMake version.
1349
1350         * CMakeLists.txt:
1351         * TestWebKitAPI/CMakeLists.txt:
1352         * TestWebKitAPI/PlatformGTK.cmake:
1353
1354 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1355
1356         Fix BenchmarkRunner to only import selenium when needed
1357         https://bugs.webkit.org/show_bug.cgi?id=174808
1358
1359         Reviewed by Stephanie Lewis.
1360
1361         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1362         (LinuxChromeDriver.launch_driver):
1363         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1364         (LinuxFirefoxDriver.launch_driver):
1365         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1366         (OSXChromeDriver.launch_driver):
1367         (OSXChromeCanaryDriver.launch_driver):
1368         (create_chrome_options):
1369         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1370         (OSXFirefoxDriver.launch_driver):
1371         (OSXFirefoxNightlyDriver.launch_driver):
1372         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1373         (OSXSafariDriver.launch_driver):
1374         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
1375         (WebDriverBenchmarkRunner._run_one_test):
1376
1377 2017-07-23  Darin Adler  <darin@apple.com>
1378
1379         More NeverDestroyed and related cleanup
1380         https://bugs.webkit.org/show_bug.cgi?id=174745
1381
1382         Reviewed by Alex Christensen.
1383
1384         * DumpRenderTree/JavaScriptThreading.cpp:
1385         (javaScriptThreadsMutex): Use NeverDestroyed instead of
1386         DEPRECATED_DEFINE_STATIC_LOCAL.
1387         (javaScriptThreads): Ditto.
1388
1389 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1390
1391         Subclass Benchmark Runner script for WebDriver support
1392         https://bugs.webkit.org/show_bug.cgi?id=174390
1393
1394         Reviewed by Dewei Zhu, Stephanie Lewis.
1395
1396         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
1397
1398         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1399         (BenchmarkBuilder.__init__):
1400         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1401         (BenchmarkRunner.__init__):
1402         (BenchmarkRunner._find_plan_file):
1403         (BenchmarkRunner._run_one_test.and):
1404         (BenchmarkRunner.execute):
1405         (BenchmarkRunner._get_result): Deleted.
1406         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1407         (parse_args):
1408         (start):
1409         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
1410         (WebDriverBenchmarkRunner):
1411         (WebDriverBenchmarkRunner._get_result):
1412         (WebDriverBenchmarkRunner._run_one_test):
1413         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
1414         (WebServerBenchmarkRunner):
1415         (WebServerBenchmarkRunner.__init__):
1416         (WebServerBenchmarkRunner._get_result):
1417         (WebServerBenchmarkRunner._run_one_test):
1418
1419 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1420
1421         Add BenchmarkRunner patches with WebDriver support for each testing plan
1422         https://bugs.webkit.org/show_bug.cgi?id=174443
1423
1424         Reviewed by Dewei Zhu, Stephanie Lewis.
1425
1426         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1427         (BenchmarkBuilder.__enter__):
1428         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
1429         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
1430         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
1431         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
1432         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
1433         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
1434         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
1435         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
1436         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
1437         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
1438         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
1439         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
1440         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
1441         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
1442         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
1443         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
1444         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
1445         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
1446         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
1447         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
1448         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
1449         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
1450         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1451         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
1452         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
1453         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
1454         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1455         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
1456         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
1457         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1458         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
1459         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
1460         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1461
1462 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1463
1464         Add functions to autoinstaller needed for Benchmark Runner script
1465         https://bugs.webkit.org/show_bug.cgi?id=174331
1466
1467         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
1468
1469         Adds autoinstaller functions to install selenium and webdriver binaries
1470         which will be used by the browser driver part of Benchmark Runner.
1471
1472         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1473         (BrowserDriver.restore_env):
1474         (BrowserDriver):
1475         (BrowserDriver.get_webdriver_binary_path):
1476         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1477         (LinuxChromeDriver.launch_driver):
1478         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1479         (LinuxFirefoxDriver.launch_driver):
1480         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1481         (OSXChromeDriver.launch_driver):
1482         (OSXChromeCanaryDriver.launch_driver):
1483         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1484         (OSXFirefoxDriver.launch_driver):
1485         (OSXFirefoxNightlyDriver.launch_driver):
1486         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1487         * Scripts/webkitpy/benchmark_runner/utils.py:
1488         (get_driver_binary_path):
1489         * Scripts/webkitpy/common/system/autoinstall.py:
1490         (AutoInstaller._unzip):
1491         * Scripts/webkitpy/thirdparty/__init__.py:
1492         (AutoinstallImportHook.find_module):
1493         (AutoinstallImportHook._install_selenium):
1494         (AutoinstallImportHook):
1495         (AutoinstallImportHook._install_chromedriver):
1496         (AutoinstallImportHook._install_geckodriver):
1497         (AutoinstallImportHook.get_latest_pypi_url):
1498         (AutoinstallImportHook.install_binary):
1499         (autoinstall_everything):
1500         (get_driver_filename):
1501         (get_os_info):
1502
1503 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1504
1505         Add WebDriver support in browser driver part of BenchmarkRunner
1506         https://bugs.webkit.org/show_bug.cgi?id=174445
1507
1508         Reviewed by Stephanie Lewis.
1509
1510         Adds a launch_driver function to each BrowserDriver subclass. This
1511         function sets up the arguments for the webdriver and launches the
1512         webdriver specific to that browser.
1513
1514         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1515         (BrowserDriver.launch_webdriver):
1516         (BrowserDriver):
1517         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1518         (LinuxBrowserDriver.launch_webdriver):
1519         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1520         (LinuxChromeDriver.launch_url):
1521         (LinuxChromeDriver):
1522         (LinuxChromeDriver.launch_driver):
1523         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
1524         (EpiphanyBrowserDriver.launch_url):
1525         (EpiphanyBrowserDriver):
1526         (EpiphanyBrowserDriver.launch_driver):
1527         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1528         (LinuxFirefoxDriver):
1529         (LinuxFirefoxDriver.launch_url):
1530         (LinuxFirefoxDriver.launch_driver):
1531         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
1532         (GTKMiniBrowserDriver.launch_url):
1533         (GTKMiniBrowserDriver):
1534         (GTKMiniBrowserDriver.launch_driver):
1535         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1536         (OSXBrowserDriver._launch_webdriver):
1537         (OSXBrowserDriver):
1538         (OSXBrowserDriver._screen_size):
1539         (OSXBrowserDriver._insert_url):
1540         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1541         (OSXChromeDriver):
1542         (OSXChromeDriver.launch_url):
1543         (OSXChromeDriver.launch_driver):
1544         (OSXChromeCanaryDriver):
1545         (OSXChromeCanaryDriver.launch_url):
1546         (OSXChromeCanaryDriver.launch_driver):
1547         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1548         (OSXFirefoxDriver):
1549         (OSXFirefoxDriver.launch_url):
1550         (OSXFirefoxDriver.launch_driver):
1551         (OSXFirefoxNightlyDriver):
1552         (OSXFirefoxNightlyDriver.launch_url):
1553         (OSXFirefoxNightlyDriver.launch_driver):
1554         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1555         (OSXSafariDriver.launch_driver):
1556
1557 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1558
1559         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
1560         https://bugs.webkit.org/show_bug.cgi?id=174793
1561
1562         Reviewed by Tim Horton.
1563
1564         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
1565         down. Without r219765, this test will dereference null and crash.
1566
1567         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1568         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
1569         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
1570         (TEST):
1571
1572 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1573
1574         [Win] Implement Authentication dialog in MiniBrowser
1575         https://bugs.webkit.org/show_bug.cgi?id=174662
1576
1577         Reviewed by Alex Christensen.
1578
1579         * MiniBrowser/win/Common.cpp:
1580         (CustomUserAgent):
1581         (DisplayAuthDialog):
1582         (AuthDialogProc):
1583         * MiniBrowser/win/MiniBrowserLib.rc:
1584         * MiniBrowser/win/MiniBrowserLibResource.h:
1585         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1586         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1587
1588 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
1589
1590         Handle case where line_numbers is None instead of an array of line numbers
1591         https://bugs.webkit.org/show_bug.cgi?id=174775
1592
1593         Reviewed by Aakash Jain.
1594
1595         Added files set line_numbers to None in process_file.
1596
1597         * Scripts/webkitpy/style/filereader.py:
1598         (TextFileReader.process_file): Handle case where line_number is set to None.
1599         * Scripts/webkitpy/style/main_unittest.py:
1600         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
1601
1602 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1603
1604         [WPE] Add libepoxy to the Jhbuild moduleset
1605         https://bugs.webkit.org/show_bug.cgi?id=174711
1606
1607         Reviewed by Carlos Alberto Lopez Perez.
1608
1609         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
1610
1611 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1612
1613         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
1614         https://bugs.webkit.org/show_bug.cgi?id=174780
1615
1616         Reviewed by Carlos Garcia Campos.
1617
1618         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1619         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
1620         in case the eglplatform.h header doesn't provide that macro. This replicates
1621         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
1622
1623 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1624
1625         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
1626         https://bugs.webkit.org/show_bug.cgi?id=174758
1627
1628         Reviewed by Dan Bernstein.
1629
1630         Migrate position-information-related unit tests from the PositionInformationTests suite to
1631         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
1632
1633         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1634         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
1635         (TestWebKitAPI::checkElementTypeAndBoundingRect):
1636         (TestWebKitAPI::TEST):
1637         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
1638         * TestWebKitAPI/cocoa/TestWKWebView.h:
1639         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1640         (-[TestWKWebView activatedElementAtPosition:]):
1641
1642 2017-07-22  Chris Dumez  <cdumez@apple.com>
1643
1644         REGRESSION(r204565): WKObject is broken
1645         https://bugs.webkit.org/show_bug.cgi?id=174736
1646         <rdar://problem/33246169>
1647
1648         Reviewed by Dan Bernstein.
1649
1650         Add API test that used to crash.
1651
1652         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1653         (TestWebKitAPI::TEST):
1654
1655 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1656
1657         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
1658         https://bugs.webkit.org/show_bug.cgi?id=174705
1659
1660         Reviewed by Mark Lam.
1661
1662         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1663         (TestWebKitAPI::testThreadGroup):
1664         (TestWebKitAPI::TEST):
1665
1666 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
1667
1668         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
1669         https://bugs.webkit.org/show_bug.cgi?id=174724
1670
1671         Reviewed by Aakash Jain.
1672
1673         * Scripts/webkitpy/port/ios_simulator.py:
1674         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
1675         simulator. Errors here should be treated the same as no simulators found.
1676
1677 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
1678
1679         [CMake] Add an option to stop build after generating project files
1680         https://bugs.webkit.org/show_bug.cgi?id=174664
1681
1682         Reviewed by Konstantin Tokarev.
1683
1684         Add "--generate-project-only" to stop build after generating project files.
1685
1686         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
1687         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
1688         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
1689         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
1690         (isGenerateProjectOnly): ditto
1691
1692 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1693
1694         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1695         https://bugs.webkit.org/show_bug.cgi?id=174501
1696
1697         Reviewed by Darin Adler.
1698
1699         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1700         (TestWebKitAPI::TEST):
1701
1702 2017-07-20  David Quesada  <david_quesada@apple.com>
1703
1704         Add SPI to notify WKNavigationDelegate about client redirects
1705         https://bugs.webkit.org/show_bug.cgi?id=174680
1706         rdar://problem/33184886
1707
1708         Reviewed by Brady Eidson.
1709
1710         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1711         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
1712         (TEST):
1713         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
1714
1715 2017-07-20  Brady Eidson  <beidson@apple.com>
1716
1717         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
1718         https://bugs.webkit.org/show_bug.cgi?id=174685
1719
1720         Reviewed by Andy Estes.
1721
1722         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1723         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
1724
1725 2017-07-20  Brady Eidson  <beidson@apple.com>
1726
1727         Deprecate WebIconDatabase in WebKitLegacy/mac.
1728         https://bugs.webkit.org/show_bug.cgi?id=174607
1729
1730         Reviewed by Alex Christensen.
1731
1732         * DumpRenderTree/mac/TestRunnerMac.mm:
1733
1734 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
1735
1736         lint-test-expectations should be run during style checking
1737         https://bugs.webkit.org/show_bug.cgi?id=173559
1738         <rdar://problem/32854941>
1739
1740         Reviewed by Aakash Jain.
1741
1742         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1743         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
1744         prevents identifying errors on specific lines in a file.
1745         * Scripts/webkitpy/style/main_unittest.py:
1746         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
1747         case where a linter error is in the file modified, but the line modified is not related to
1748         the linter error.
1749
1750 2017-07-20  Brady Eidson  <beidson@apple.com>
1751
1752         Remove WebIconDatabase from WebKitLegacy/win.
1753         https://bugs.webkit.org/show_bug.cgi?id=174608
1754
1755         Reviewed by Alex Christensen.
1756
1757         * DumpRenderTree/win/DumpRenderTree.cpp:
1758         (main):
1759         * DumpRenderTree/win/TestRunnerWin.cpp:
1760         (TestRunner::setIconDatabaseEnabled):
1761
1762 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
1763
1764         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
1765         https://bugs.webkit.org/show_bug.cgi?id=174671
1766
1767         Reviewed by Carlos Garcia Campos.
1768
1769         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1770         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
1771         priority for this source in order to have it dispatched on the same
1772         priority as the other WebKit-controlled GSource objects.
1773
1774 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1775
1776         lint-test-expectations should be run during style checking
1777         https://bugs.webkit.org/show_bug.cgi?id=173559
1778         <rdar://problem/32854941>
1779
1780         Reviewed by Daniel Bates.
1781
1782         Follow up fix addressing style and a few minor bugs.
1783
1784         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1785         (TestExpectationParser.__init__): Use lambda x: x instead of str
1786         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
1787         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
1788         reduce the calls of _shorten_filename, fix minor bug in appending the current
1789         expectation's line number instead of the previous ones, clarify treatment of None
1790         in file-to-line-number mapping.
1791         (TestExpectations._report_warnings): Collapse call.
1792         * Scripts/webkitpy/style/checkers/test_expectations.py:
1793         (TestExpectationsChecker.lint_test_expectations):
1794         * Scripts/webkitpy/style/filereader.py: Re-write comment.
1795         (TextFileReader.process_file): Add comment explaining treatment of None in
1796         file-to-line-number mapping.
1797         (TextFileReader.delete_file): Collapse call.
1798
1799 2017-07-19  Chris Dumez  <cdumez@apple.com>
1800
1801         Unreviewed attempt to fix API test failure after r219663.
1802
1803         The test was hard-coding an exception string and the string has changed slightly
1804         in r219663.
1805
1806         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1807         (TEST):
1808
1809 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
1810
1811         Don't write file URLs to iOS Pasteboard
1812         https://bugs.webkit.org/show_bug.cgi?id=174647
1813         <rdar://problem/33199730>
1814
1815         Reviewed by Wenson Hsieh.
1816
1817         Updating tests to reflect the lack of file URLs for images.
1818
1819         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1820         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
1821         (checkEstimatedSize):
1822         (TestWebKitAPI::TEST):
1823
1824 2017-07-19  Brady Eidson  <beidson@apple.com>
1825
1826         iBooks sometimes crashes when closing a book.
1827         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
1828
1829         Reviewed by Oliver Hunt.
1830
1831         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1832         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
1833         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
1834         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
1835         (TestWebKitAPI::TEST):
1836
1837         Add a "spin the runloop X number of times" utility:
1838         * TestWebKitAPI/Utilities.h:
1839         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1840         (TestWebKitAPI::Util::spinRunLoop):
1841
1842 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1843
1844         lint-test-expectations should be run during style checking
1845         https://bugs.webkit.org/show_bug.cgi?id=173559
1846         <rdar://problem/32854941>
1847
1848         Reviewed by David Kilzer.
1849
1850         Running the test expectation linter requires reading both files and lines not in the
1851         patch because, for example, deletion of a test can cause a lint failure even though
1852         no test expectations where modified. This means that the linter will occasionally warn
1853         about lines which were not changed in a given patch but whose error is related to a
1854         change made in that patch.
1855
1856         * Scripts/webkitpy/common/system/filesystem_mock.py:
1857         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
1858         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1859         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
1860         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
1861         content, description of the error and the name of the associated test.
1862         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
1863         (TestExpectationParser.__init__): Pass shorten_filename function to
1864         TestExpectationsParser to add a deleted file to the related_files dictionary.
1865         (TestExpectationParser._check_test_exists): If the test does not exist, add the
1866         missing path to the related_files dictionary.
1867         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
1868         files and line numbers related to this test expectation line. This will allow
1869         tracking linter errors in the style checker occurring across multiple files.
1870         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
1871         lines to related_files dictionary.
1872         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
1873         (TestExpectations._report_warnings): Construct warning object instead of string
1874         when adding to warnings list.
1875         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
1876         clean-up log.
1877         * Scripts/webkitpy/style/checker.py:
1878         (ProcessorBase.do_association_check): Add required function for processor classes.
1879         (StyleProcessor):
1880         (StyleProcessor.do_association_check): Run the TestExpectations linter when
1881         checking for errors between associated files.
1882         * Scripts/webkitpy/style/checkers/test_expectations.py:
1883         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
1884         (TestExpectationsChecker):
1885         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
1886         of modified files, the current working directory and the host, determine if the linter
1887         warning is associated with the changes.
1888         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
1889         style checker.
1890         * Scripts/webkitpy/style/filereader.py:
1891         (TextFileReader):
1892         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
1893         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
1894         (TextFileReader.process_file): Track both the number of files changed and which lines
1895         in those files were changed.
1896         (TextFileReader.do_association_check): Run the processor's association check on all
1897         modified or deleted files processed by TextFileReader.
1898         (TextFileReader.delete_file): Track deleted files in _files dictionary.
1899         (TextFileReader.count_delete_only_file): Deleted.
1900         * Scripts/webkitpy/style/filereader_unittest.py:
1901         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
1902         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
1903         * Scripts/webkitpy/style/main.py:
1904         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
1905         explicitly run the association check on the file reader.
1906         * Scripts/webkitpy/style/main_unittest.py:
1907         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
1908         embedded in the style checker.
1909         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
1910         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
1911         construct the TextFileReader object with a StyleProcessor used to run style checks on
1912         specific files.
1913         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
1914         testing the test expectation linter inside the style checker. This host must contain a
1915         mock file system with the basic structure of test expectations.
1916         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
1917         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
1918         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
1919         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
1920         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
1921         * Scripts/webkitpy/style/patchreader.py:
1922         (PatchReader.check): Specify which file was deleted, run the association check.
1923         * Scripts/webkitpy/style/patchreader_unittest.py:
1924         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
1925         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
1926         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
1927
1928 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1929
1930         [WTF] Implement WTF::ThreadGroup
1931         https://bugs.webkit.org/show_bug.cgi?id=174081
1932
1933         Reviewed by Mark Lam.
1934
1935         Add WTF::ThreadGroup tests.
1936
1937         * TestWebKitAPI/CMakeLists.txt:
1938         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1939         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1940         (TestWebKitAPI::testThreadGroup):
1941         (TestWebKitAPI::TEST):
1942
1943 2017-07-18  Andy Estes  <aestes@apple.com>
1944
1945         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1946         https://bugs.webkit.org/show_bug.cgi?id=174631
1947
1948         Reviewed by Tim Horton.
1949
1950         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1951         * MiniBrowser/Configurations/Base.xcconfig:
1952         * MobileMiniBrowser/Configurations/Base.xcconfig:
1953         * TestWebKitAPI/Configurations/Base.xcconfig:
1954         * WebKitTestRunner/Configurations/Base.xcconfig:
1955
1956 2017-07-18  Andy Estes  <aestes@apple.com>
1957
1958         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1959         https://bugs.webkit.org/show_bug.cgi?id=174631
1960
1961         Reviewed by Sam Weinig.
1962
1963         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1964         * MiniBrowser/Configurations/Base.xcconfig:
1965         * MobileMiniBrowser/Configurations/Base.xcconfig:
1966         * TestWebKitAPI/Configurations/Base.xcconfig:
1967         * WebKitTestRunner/Configurations/Base.xcconfig:
1968
1969 2017-07-18  Daniel Bates  <dabates@apple.com>
1970
1971         lldb: Add type summary for StringView
1972         https://bugs.webkit.org/show_bug.cgi?id=174637
1973
1974         Reviewed by Sam Weinig.
1975
1976         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
1977         StringView object will print output that has the form:
1978
1979             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
1980               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
1981               m_length = 2
1982               m_is8Bit = true
1983               m_underlyingString = 0x0000614000000a90
1984             }
1985
1986         * lldb/lldb_webkit.py:
1987         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
1988         (WTFStringView_SummaryProvider):
1989         (WTFStringViewProvider):
1990         (WTFStringViewProvider.__init__):
1991         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
1992         (WTFStringViewProvider.get_length): Access field StringView.m_length.
1993         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
1994         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
1995
1996 2017-07-18  Andy Estes  <aestes@apple.com>
1997
1998         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
1999         https://bugs.webkit.org/show_bug.cgi?id=174631
2000
2001         Reviewed by Dan Bernstein.
2002
2003         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2004         * MiniBrowser/Configurations/Base.xcconfig:
2005         * MobileMiniBrowser/Configurations/Base.xcconfig:
2006         * TestWebKitAPI/Configurations/Base.xcconfig:
2007         * WebKitTestRunner/Configurations/Base.xcconfig:
2008
2009 2017-07-18  Devin Rousso  <drousso@apple.com>
2010
2011         Web Inspector: Add memoryCost to Inspector Protocol objects
2012         https://bugs.webkit.org/show_bug.cgi?id=174478
2013
2014         Reviewed by Joseph Pecoraro.
2015
2016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2017         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
2018         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
2019         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
2020         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
2021         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
2022         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
2023         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
2024         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
2025         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
2026         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
2027         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
2028         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
2029         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
2030         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
2031         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
2032         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
2033
2034 2017-07-18  Andy Estes  <aestes@apple.com>
2035
2036         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2037         https://bugs.webkit.org/show_bug.cgi?id=174631
2038
2039         Reviewed by Darin Adler.
2040
2041         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2042         * MiniBrowser/Configurations/Base.xcconfig:
2043         * MobileMiniBrowser/Configurations/Base.xcconfig:
2044         * TestWebKitAPI/Configurations/Base.xcconfig:
2045         * WebKitTestRunner/Configurations/Base.xcconfig:
2046
2047 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2048
2049         Unreviewed, fix the iOS build.
2050
2051         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
2052
2053         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2054         (TestWebKitAPI::TEST):
2055
2056 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2057
2058         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
2059         https://bugs.webkit.org/show_bug.cgi?id=174585
2060         <rdar://problem/33302541>
2061
2062         Reviewed by Tim Horton.
2063
2064         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
2065         being dragged when initiating a drag.
2066
2067         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2068         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
2069         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2070         (TestWebKitAPI::TEST):
2071         * TestWebKitAPI/cocoa/TestWKWebView.h:
2072
2073         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
2074
2075         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2076         (-[TestWKWebView synchronouslyLoadHTMLString:]):
2077
2078 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2079
2080         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
2081         https://bugs.webkit.org/show_bug.cgi?id=174547
2082
2083         Reviewed by Alex Christensen.
2084
2085         * DumpRenderTree/PlatformWin.cmake:
2086         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2087
2088 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2089
2090         Update style checker to deal with "final"
2091         https://bugs.webkit.org/show_bug.cgi?id=174528
2092
2093         Reviewed by Alex Christensen.
2094         
2095         check-webkit-style shouldn't complain about an open brace to start a
2096         line after a function definition with "final" or "const final".
2097
2098         * Scripts/webkitpy/style/checkers/cpp.py:
2099         (check_braces):
2100         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2101         (CppStyleTest.test_brace_at_begin_of_line):
2102
2103 2017-07-17  Alex Christensen  <achristensen@webkit.org>
2104
2105         Modernize content extension code
2106         https://bugs.webkit.org/show_bug.cgi?id=174588
2107
2108         Reviewed by Sam Weinig.
2109
2110         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2111         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2112         (TestWebKitAPI::testRequest):
2113         (TestWebKitAPI::makeBackend):
2114         (TestWebKitAPI::TEST_F):
2115
2116 2017-07-17  Brady Eidson  <beidson@apple.com>
2117
2118         WKHTTPCookieStore observing only works on the default cookie store.
2119         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
2120
2121         Reviewed by Sam Weinig.
2122
2123         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2124         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
2125           called for the default store, a non-persistent store, and a custom store.
2126         (TEST):
2127
2128 2017-07-16  Sam Weinig  <sam@webkit.org>
2129
2130         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
2131         https://bugs.webkit.org/show_bug.cgi?id=174575
2132
2133         Reviewed by Brady Eidson.
2134
2135         * Scripts/svn-create-patch:
2136         (findModificationType):
2137         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
2138         default value of "unknown".
2139
2140         (generateFileList):
2141         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
2142         for untracked, which matches our old behavior.
2143
2144 2017-07-17  Charlie Turner  <cturner@igalia.com>
2145
2146         Add some missing build dependencies on Fedora
2147         https://bugs.webkit.org/show_bug.cgi?id=174578
2148
2149         Unreviewed dependency update.
2150
2151         * gtk/install-dependencies:
2152
2153 2017-07-16  Brady Eidson  <beidson@apple.com>
2154
2155         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
2156         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
2157
2158         Reviewed by Tim Horton.
2159
2160         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2161         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
2162         (TEST):
2163
2164 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
2165
2166         [GTK] Sort inspector GResource manifest to ensure reproducible builds
2167         https://bugs.webkit.org/show_bug.cgi?id=174540
2168
2169         Reviewed by Michael Catanzaro.
2170
2171         * gtk/generate-inspector-gresource-manifest.py:
2172         (get_filenames): sort list of input files
2173
2174 2017-07-15  Brady Eidson  <beidson@apple.com>
2175
2176         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
2177         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
2178
2179         Reviewed by Tim Horton.
2180
2181         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2182         (TEST): Make this test more reliable by clearing everything beforehand.
2183
2184 2017-07-15  David Kilzer  <ddkilzer@apple.com>
2185
2186         Make it possible to extend check-webkit-style with Apple-internal checkers
2187         <https://webkit.org/b/174464>
2188         <rdar://problem/25564402>
2189
2190         Reviewed by Darin Adler.
2191
2192         * Scripts/webkitpy/style/checker.py: Import apple_additions.
2193         (_all_categories): Add categories from apple_additions() if it
2194         exists.
2195         (CheckerDispatcher._create_checker): Create python checker
2196         from apple_additions() if it exists.
2197
2198 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2199
2200         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
2201         https://bugs.webkit.org/show_bug.cgi?id=174539
2202         <rdar://problem/33307395>
2203
2204         Reviewed by Darin Adler.
2205
2206         Adds a new unit test suite to cover action sheet popover presentation.
2207
2208         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2209         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
2210         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
2211         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
2212
2213         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
2214
2215         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
2216         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2217
2218         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
2219
2220         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2221         (TestWebKitAPI::TEST):
2222
2223 2017-07-15  Sam Weinig  <sam@webkit.org>
2224
2225         [Scripts] Make svn-create-patch work better when called in sub directories
2226         https://bugs.webkit.org/show_bug.cgi?id=174551
2227
2228         Reviewed by Darin Adler.
2229
2230         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
2231           by ensuring that the prefix is applied as is done in generateDiff.
2232         - Silence output of explanatory lines from svn stat (" > move to ...")
2233           that show up in STDERR when running svn-create-patch.
2234         - Add verbose logging that I found useful while debugging this issue.
2235
2236         * Scripts/svn-create-patch:
2237         (findBaseUrl):
2238         (findMimeType):
2239         (findSourceFileAndRevision):
2240         (generateDiff):
2241         (generateFileList):
2242         (manufacturePatchForAdditionWithHistory):
2243
2244 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
2245
2246         Unreviewed build fix after r219537.
2247
2248         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2249
2250 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2251
2252         Add iOS 11 SPI
2253         https://bugs.webkit.org/show_bug.cgi?id=174430
2254         <rdar://problem/33269288>
2255
2256         Reviewed by Tim Horton.
2257
2258         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
2259         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
2260         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
2261
2262 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2263
2264         Failing to install on iPad simulators
2265         https://bugs.webkit.org/show_bug.cgi?id=174532
2266         <rdar://problem/33328347>
2267
2268         Reviewed by Stephanie Lewis.
2269
2270         * Scripts/webkitpy/xcode/simulated_device.py:
2271         (SimulatedDevice.install_app): Place install command in retry try-except block.
2272
2273 2017-07-14  Jeff Miller  <jeffm@apple.com>
2274
2275         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
2276         https://bugs.webkit.org/show_bug.cgi?id=174524
2277
2278         Reviewed by Sam Weinig.
2279
2280         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
2281         (TEST):
2282         Renamed TestParameter to TestParameter1.
2283         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
2284
2285         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2286         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2287         Observe changes for two bundle parameters.
2288
2289         (-[BundleParametersPlugIn dealloc]):
2290         Remove observers for two bundle parameters.
2291
2292 2017-07-14  Commit Queue  <commit-queue@webkit.org>
2293
2294         Unreviewed, rolling out r219510.
2295         https://bugs.webkit.org/show_bug.cgi?id=174525
2296
2297         Need to revert length() == 0 check for null string (Requested
2298         by yusukesuzuki on #webkit).
2299
2300         Reverted changeset:
2301
2302         "[WTF] Newly added AtomicStringImpl should use BufferInternal
2303         static string if StringImpl is static"
2304         https://bugs.webkit.org/show_bug.cgi?id=174501
2305         http://trac.webkit.org/changeset/219510
2306
2307 2017-07-14  Jer Noble  <jer.noble@apple.com>
2308
2309         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
2310         https://bugs.webkit.org/show_bug.cgi?id=174514
2311
2312         Reviewed by Sam Weinig.
2313
2314         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
2315         (TestWebKitAPI::TEST_F):
2316
2317 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2318
2319         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2320         https://bugs.webkit.org/show_bug.cgi?id=174501
2321
2322         Reviewed by Darin Adler.
2323
2324         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2325         (TestWebKitAPI::TEST):
2326
2327 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2328
2329         Bring mac expectations in-line with other platforms
2330         https://bugs.webkit.org/show_bug.cgi?id=174472
2331         <rdar://problem/33297388>
2332
2333         Reviewed by David Kilzer.
2334
2335         The override order for Mac test expectations does not conform to the pattern used by iOS,
2336         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
2337
2338             platform/mac-wk2
2339             platform/wk2
2340             platform/mac-elcapitan
2341             platform/mac-sierra
2342             generic
2343
2344         After this change, El Capitan's baseline search path looks like this:
2345
2346             platform/mac-sierra-wk2
2347             platform/mac-sierra
2348             platform/mac-wk2
2349             platform/wk2
2350             generic
2351
2352         * Scripts/webkitpy/port/mac.py:
2353         (MacPort.__init__): If a specific version is specified in the port name, use that
2354         as the os version.
2355         (MacPort.default_baseline_search_path): Expectation search paths should work the
2356         same way they do on other ports. Port + version overrides port, port overrides generic
2357         and wk1/wk2 should override expectations for the two combined.
2358         * Scripts/webkitpy/port/mac_unittest.py:
2359         (MacTest.test_tests_for_other_platforms): Deleted.
2360         (MacTest._assert_search_path): Deleted.
2361         (MacTest.test_baseline_search_path): Deleted.
2362         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2363         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
2364         (test_rebaseline_test_and_print_scm_changes): Ditto.
2365         (test_rebaseline_and_copy_test): Ditto.
2366         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
2367         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
2368         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
2369
2370 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2371
2372         Fix style checker unit test
2373
2374         Unreviewed WebKit2 => WebKit fixup.
2375
2376         * Scripts/webkitpy/style/checker_unittest.py:
2377         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
2378
2379 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2380
2381         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
2382
2383         Unreviewed build fix.
2384
2385         r219492 missed one hunk from its partial revert of r219489.
2386         This patch reverts that hunk.
2387
2388         * TestWebKitAPI/CMakeLists.txt:
2389
2390 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2391
2392         Use the old WebKit/WebKit2 targets for CMake builds.
2393
2394         Unreviewed build fix.
2395
2396         We can update the target names to match the Framework names in a future patch.
2397         This is a partial revert of r219489.
2398
2399         * TestWebKitAPI/CMakeLists.txt:
2400         WebKitLegacy => WebKit
2401         WebKit => WebKit2
2402
2403 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2404
2405         Fix TestWebKit API.
2406         https://bugs.webkit.org/show_bug.cgi?id=174164
2407         rdar://problem/33137595
2408
2409         Reviewed by Dan Bernstein.
2410
2411         * TestWebKitAPI/CMakeLists.txt:
2412         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2413         * TestWebKitAPI/PlatformGTK.cmake:
2414
2415 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2416
2417         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
2418         https://bugs.webkit.org/show_bug.cgi?id=174164
2419         rdar://problem/33137595
2420
2421         Reviewed by Dan Bernstein.
2422
2423         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2424         (ShouldBuildTest):
2425         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2426         * Scripts/build-webkit:
2427         * Scripts/do-file-rename:
2428         * Scripts/do-webcore-rename:
2429         * Scripts/update-webkit-localizable-strings:
2430         * Scripts/webkitpy/common/config/watchlist:
2431         * Scripts/webkitpy/style/checker.py:
2432         * Scripts/webkitpy/style/checkers/featuredefines.py:
2433         * gtk/make-dist.py:
2434         (ensure_version_if_possible):
2435         * gtk/manifest.txt.in:
2436
2437 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
2438
2439         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
2440         https://bugs.webkit.org/show_bug.cgi?id=174162
2441         rdar://problem/33137594
2442
2443         Reviewed by Dan Bernstein.
2444
2445         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
2446
2447         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2448         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2449         * EWSTools/configure-clang-linux.sh:
2450         * Scripts/build-webkit:
2451         * Scripts/do-file-rename:
2452         * Scripts/do-webcore-rename:
2453         * Scripts/update-webkit-localizable-strings:
2454         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2455         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2456         * Scripts/webkitpy/style/checkers/featuredefines.py:
2457         * gtk/manifest.txt.in:
2458
2459 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
2460
2461         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
2462         https://bugs.webkit.org/show_bug.cgi?id=174438
2463         <rdar://problem/33277112>
2464
2465         Reviewed by Aakash Jain.
2466
2467         Given a patch, this will convert the changes from the path to the new directory structure.
2468
2469         * Scripts/rebase-patch-after-webkit-move: Added.
2470         (append_source): Append 'Source' to the provided path.
2471         (is_editable_line): Return true if a line the script expects to modify.
2472         (needs_rebase): Return if a line needs to be rebased based on it's content.
2473         (rebase_line): Rebase the provided line.
2474         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
2475         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
2476         were provided.
2477
2478 2017-07-12  Nan Wang  <n_wang@apple.com>
2479
2480         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2481         https://bugs.webkit.org/show_bug.cgi?id=174393
2482         <rdar://problem/33248006>
2483
2484         Reviewed by Chris Fleizach.
2485
2486         * DumpRenderTree/AccessibilityUIElement.cpp:
2487         (textMarkerRangeMatchesTextNearMarkersCallback):
2488         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2489         (AccessibilityUIElement::getJSClass):
2490         * DumpRenderTree/AccessibilityUIElement.h:
2491         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2492         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2493         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2494         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2495         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2496         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2497         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2498         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2499
2500 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2501
2502         Unreviewed, rolling out r219409.
2503
2504         The revision caused the Windows builds to fail.
2505
2506         Reverted changeset:
2507
2508         "AX: [iOS] Implement a way to retrieve a text marker range
2509         with desired text that is closest to a position"
2510         https://bugs.webkit.org/show_bug.cgi?id=174393
2511         http://trac.webkit.org/changeset/219409
2512
2513 2017-07-12  Nan Wang  <n_wang@apple.com>
2514
2515         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2516         https://bugs.webkit.org/show_bug.cgi?id=174393
2517         <rdar://problem/33248006>
2518
2519         Reviewed by Chris Fleizach.
2520
2521         * DumpRenderTree/AccessibilityUIElement.cpp:
2522         (textMarkerRangeMatchesTextNearMarkersCallback):
2523         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2524         (AccessibilityUIElement::getJSClass):
2525         * DumpRenderTree/AccessibilityUIElement.h:
2526         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2527         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2528         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2529         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2530         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2531         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2532         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2533         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2534
2535 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
2536
2537         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
2538         https://bugs.webkit.org/show_bug.cgi?id=174197
2539
2540         Reviewed by Darin Adler.
2541
2542         This bit me the first time I tried to submit a patch to WebKit, and still I have
2543         to manually edit the ChangeLog every time I use the script.
2544
2545         This generates a more convenient and standard ChangeLog entry.
2546
2547         * Scripts/prepare-ChangeLog:
2548         (generateNewChangeLogs):
2549
2550 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2551
2552         Unreviewed, rolling out r219401.
2553
2554         This revision rolled out the previous patch, but after talking
2555         with reviewer, a rebaseline is what was needed.Rolling back in
2556         before rebaseline.
2557
2558         Reverted changeset:
2559
2560         "Unreviewed, rolling out r219379."
2561         https://bugs.webkit.org/show_bug.cgi?id=174400
2562         http://trac.webkit.org/changeset/219401
2563
2564 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2565
2566         Unreviewed, rolling out r219379.
2567
2568         This revision caused a consistent failure in the test
2569         fast/dom/Window/property-access-on-cached-window-after-frame-
2570         removed.html.
2571
2572         Reverted changeset:
2573
2574         "Remove NAVIGATOR_HWCONCURRENCY"
2575         https://bugs.webkit.org/show_bug.cgi?id=174400
2576         http://trac.webkit.org/changeset/219379
2577
2578 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2579
2580         [WPE] Use libepoxy
2581         https://bugs.webkit.org/show_bug.cgi?id=172104
2582
2583         Reviewed by Michael Catanzaro.
2584
2585         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
2586         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
2587
2588 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2589
2590         [GTK][WPE] Align Jhbuild patches for GStreamer packages
2591         https://bugs.webkit.org/show_bug.cgi?id=174363
2592
2593         Reviewed by Michael Catanzaro.
2594
2595         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
2596         between the GTK+ and WPE port. There's no reason for the two ports to apply
2597         different patches over same versions of GStreamer releases.
2598
2599         This aligns the two ports on this specific issue. Next we'll look into
2600         creating a single GStreamer-specific Jhbuild moduleset that will allow us
2601         to keep these patches in a single place, avoiding duplicate files.
2602
2603         * gtk/jhbuild.modules:
2604         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2605         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
2606         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2607         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
2608
2609 2017-07-11  Dean Jackson  <dino@apple.com>
2610
2611         Remove NAVIGATOR_HWCONCURRENCY
2612         https://bugs.webkit.org/show_bug.cgi?id=174400
2613
2614         Reviewed by Sam Weinig.
2615
2616         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2617
2618 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
2619
2620         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
2621         https://bugs.webkit.org/show_bug.cgi?id=174239
2622
2623         Reviewed by Brady Eidson.
2624
2625         Create windows with specific features set and make sure those are properly reflected in the
2626         WKWindowFeatures object.
2627
2628         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2629         (resetToConsistentState):
2630         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2631         (TEST):
2632
2633 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
2634
2635         Do not duplicate files when deleting directories with svn 1.9
2636         https://bugs.webkit.org/show_bug.cgi?id=174339
2637         <rdar://problem/33226781>
2638
2639         Reviewed by David Kilzer.
2640
2641         * Scripts/svn-create-patch:
2642         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
2643         (generateFileList): Determine which files are deleted because they are part of a
2644         directory being deleted.
2645
2646 2017-07-11  Dean Jackson  <dino@apple.com>
2647
2648         Rolling out r219372.
2649
2650         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2651
2652 2017-07-11  Dean Jackson  <dino@apple.com>
2653
2654         Remove NAVIGATOR_HWCONCURRENCY
2655         https://bugs.webkit.org/show_bug.cgi?id=174400
2656
2657         Reviewed by Sam Weinig.
2658
2659         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2660
2661 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2662
2663         Teach build workers to fetch archives from S3.
2664         https://bugs.webkit.org/show_bug.cgi?id=174384
2665
2666         Reviewed by Aakash Jain.
2667
2668         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2669         (DownloadBuiltProduct):
2670
2671 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2672
2673         Configure buildbot to transfer all archives to S3.
2674         Previously this was Mac only, but it's time to expand!
2675         https://bugs.webkit.org/show_bug.cgi?id=174378
2676         
2677         Reviewed by Aakash Jain.
2678
2679         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2680         (BuildFactory.__init__):
2681
2682 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
2683
2684         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
2685         https://bugs.webkit.org/show_bug.cgi?id=174350
2686
2687         Reviewed by Xabier Rodriguez-Calvar.
2688
2689         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
2690         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
2691         patches are removed. The patches for gst-plugins-good are updated, removing
2692         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
2693         rtpbin elements that will help with the EMEv3 development.
2694
2695         * wpe/jhbuild.modules:
2696         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
2697         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
2698         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
2699         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2700         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2701         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2702         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2703         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2704         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2705
2706 2017-07-10  John Wilander  <wilander@apple.com>
2707
2708         Resource Load Statistics: Prune statistics in orders of importance
2709         https://bugs.webkit.org/show_bug.cgi?id=174215
2710         <rdar://problem/33164403>
2711
2712         Reviewed by Chris Dumez.
2713
2714         Nest infrastructure. Adds these functions:
2715         1. testRunner.setStatisticsLastSeen()
2716         2. setStatisticsMaxStatisticsEntries()
2717         3. setStatisticsPruneEntriesDownTo()
2718
2719         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2720         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2721         (WTR::TestRunner::setStatisticsLastSeen):
2722         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2723         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2724         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2725         * WebKitTestRunner/TestController.cpp:
2726         (WTR::TestController::setStatisticsLastSeen):
2727         (WTR::TestController::setMaxStatisticsEntries):
2728         (WTR::TestController::setPruneEntriesDownTo):
2729         * WebKitTestRunner/TestController.h:
2730         * WebKitTestRunner/TestInvocation.cpp:
2731         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2732         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2733         (WTR::TestController::setStatisticsLastSeen):
2734         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2735         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2736
2737 2017-07-03  Brian Burg  <bburg@apple.com>
2738
2739         Web Replay: remove some unused code
2740         https://bugs.webkit.org/show_bug.cgi?id=173903
2741
2742         Rubber-stamped by Joseph Pecoraro.
2743
2744         * Scripts/run-input-generator-tests: Removed.
2745         * Scripts/webkitpy/replay/__init__.py: Removed.
2746         * Scripts/webkitpy/replay/main.py: Removed.
2747
2748 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
2749
2750         [WPE] Fix layout test baseline and TestExpectations hierarchy
2751         https://bugs.webkit.org/show_bug.cgi?id=174092
2752
2753         Reviewed by Michael Catanzaro.
2754
2755         Like for the GTK+ port, override the default_baseline_search_path() and
2756         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
2757         Both methods operate on a short list of search paths that defaults to 'wpe' and
2758         'wk2', along with any other user-specified platform directory.
2759
2760         The test_expectations_file_position() method is overridden for testing purposes,
2761         and relevant unit tests are added.
2762
2763         * Scripts/webkitpy/port/wpe.py:
2764         (WPEPort._search_paths):
2765         (WPEPort):
2766         (WPEPort.default_baseline_search_path):
2767         (WPEPort._port_specific_expectations_files):
2768         (WPEPort.test_expectations_file_position):
2769         * Scripts/webkitpy/port/wpe_unittest.py:
2770         (WPEPortTest.test_default_baseline_search_path):
2771         (WPEPortTest):
2772         (WPEPortTest.test_port_specific_expectations_files):
2773
2774 2017-07-10  Chris Dumez  <cdumez@apple.com>
2775
2776         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
2777         https://bugs.webkit.org/show_bug.cgi?id=174301
2778
2779         Reviewed by Brent Fulgham.
2780
2781         Rename some of the testRunner API for clarity and to better match what it calls
2782         internally.
2783
2784         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2785         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2786         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2787         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2788         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2789         * WebKitTestRunner/TestController.cpp:
2790         (WTR::TestController::statisticsUpdateCookiePartitioning):
2791         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2792         * WebKitTestRunner/TestController.h:
2793         * WebKitTestRunner/TestInvocation.cpp:
2794         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2795         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2796         (WTR::TestController::statisticsUpdateCookiePartitioning):
2797         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2798
2799 2017-07-10  Charlie Turner  <cturner@igalia.com>
2800
2801         [GStreamer] Live twitch.tv videos do not play
2802         https://bugs.webkit.org/show_bug.cgi?id=174222
2803
2804         Reviewed by Michael Catanzaro.
2805
2806         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
2807         fixes videos not playing on twitch.tv.
2808
2809         * gtk/jhbuild.modules:
2810
2811 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
2812
2813         Add WebGL2 configuration option to build-webkit
2814         https://bugs.webkit.org/show_bug.cgi?id=174251
2815
2816         Reviewed by Michael Catanzaro.
2817
2818         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
2819         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
2820         is marked as enabled for the Apple Cocoa ports.
2821
2822 2017-07-08  Chris Dumez  <cdumez@apple.com>
2823
2824         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
2825         https://bugs.webkit.org/show_bug.cgi?id=174290
2826
2827         Reviewed by Brent Fulgham.
2828
2829         Rename testRunner API to match the new internal API names.
2830
2831         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2832         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2833         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2834         (WTR::TestRunner::statisticsSubmitTelemetry):
2835         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2836         * WebKitTestRunner/TestController.cpp:
2837         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2838         (WTR::TestController::statisticsSubmitTelemetry):
2839         * WebKitTestRunner/TestController.h:
2840         * WebKitTestRunner/TestInvocation.cpp:
2841         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2842         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2843         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2844         (WTR::TestController::statisticsSubmitTelemetry):
2845
2846 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2847
2848         Drop NOSNIFF compile flag
2849         https://bugs.webkit.org/show_bug.cgi?id=174289
2850
2851         Reviewed by Michael Catanzaro.
2852
2853         * Scripts/webkitperl/FeatureList.pm:
2854         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2855
2856 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2857
2858         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
2859         https://bugs.webkit.org/show_bug.cgi?id=174219
2860         <rdar://problem/32083177>
2861
2862         Reviewed by Ryosuke Niwa.
2863
2864         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
2865         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
2866         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
2867         place.
2868
2869         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
2870         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
2871         no action is taken when dropping.
2872
2873         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
2874         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2875         (TestWebKitAPI::TEST):
2876         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2877         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2878         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
2879         (-[MockDragDropSession allowsMoveOperation]):
2880         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
2881         (-[MockDataInteractionSession initWithWindow:allowMove:]):
2882         (-[DataInteractionSimulator initWithWebView:]):
2883         (-[DataInteractionSimulator runFrom:to:]):
2884         (-[DataInteractionSimulator _advanceProgress]):
2885         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
2886         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
2887         (-[MockDataInteractionSession initWithWindow:]): Deleted.
2888
2889 2017-07-07  Commit Queue  <commit-queue@webkit.org>
2890
2891         Unreviewed, rolling out r219238, r219239, and r219241.
2892         https://bugs.webkit.org/show_bug.cgi?id=174265
2893
2894         "fast/workers/dedicated-worker-lifecycle.html is flaky"
2895         (Requested by yusukesuzuki on #webkit).
2896
2897         Reverted changesets:
2898
2899         "[WTF] Implement WTF::ThreadGroup"
2900         https://bugs.webkit.org/show_bug.cgi?id=174081
2901         http://trac.webkit.org/changeset/219238
2902
2903         "Unreviewed, build fix after r219238"
2904         https://bugs.webkit.org/show_bug.cgi?id=174081
2905         http://trac.webkit.org/changeset/219239
2906
2907         "Unreviewed, CLoop build fix after r219238"
2908         https://bugs.webkit.org/show_bug.cgi?id=174081
2909         http://trac.webkit.org/changeset/219241
2910
2911 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2912
2913         [GTK][WPE] Enable X-Content-Type-Options: nosniff
2914         https://bugs.webkit.org/show_bug.cgi?id=174250
2915
2916         Reviewed by Carlos Alberto Lopez Perez.
2917
2918         * Scripts/webkitperl/FeatureList.pm:
2919
2920 2017-07-07  Charlie Turner  <cturner@igalia.com>
2921         [GStreamer] vid.me videos do not play
2922         https://bugs.webkit.org/show_bug.cgi?id=172240
2923
2924         Reviewed by Xabier Rodriguez-Calvar.
2925
2926         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2927         have the existing libsoup build against GNOME to avoid header drift
2928         against GStreamer's linked Soup library.
2929
2930         * gtk/jhbuild.modules:
2931
2932 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2933
2934         Write a support script to enable buildbot to upload to S3
2935         https://bugs.webkit.org/show_bug.cgi?id=174196
2936         
2937         Reviewed by Stephanie Lewis.
2938
2939         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
2940         (uploadToS3):
2941         (archiveExists):
2942
2943 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2944
2945         Enabling uploading archives to S3.
2946         https://bugs.webkit.org/show_bug.cgi?id=174198
2947         
2948         Reviewed by Stephanie Lewis.
2949
2950         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2951         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2952         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2953         (TransferToS3): Transfer full and minified archives to S3
2954
2955 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2956
2957         [WTF] Implement WTF::ThreadGroup
2958         https://bugs.webkit.org/show_bug.cgi?id=174081
2959
2960         Reviewed by Mark Lam.
2961
2962         Add WTF::ThreadGroup tests.
2963
2964         * TestWebKitAPI/CMakeLists.txt:
2965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2966         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2967         (TestWebKitAPI::TEST):
2968
2969 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2970
2971         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2972         https://bugs.webkit.org/show_bug.cgi?id=174150
2973
2974         Reviewed by Mark Lam.
2975
2976         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2977         (TestWebKitAPI::TEST):
2978         * TestWebKitAPI/TestsController.cpp:
2979         (TestWebKitAPI::TestsController::TestsController):
2980
2981 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2982
2983         Enabling uploading archives to S3.
2984         https://bugs.webkit.org/show_bug.cgi?id=174198
2985         
2986         Reviewed by Lucas Forschler.
2987
2988         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2989         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2990         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2991         (TransferToS3): Transfer full and minified archives to S3
2992
2993 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2994
2995         [GTK][WPE] kill-old-process should kill more webkit related process
2996         https://bugs.webkit.org/show_bug.cgi?id=174220
2997
2998         Reviewed by Michael Catanzaro.
2999
3000         Generate list of possible webkit-related process names and add
3001         them to the list of process to kill.
3002         Also update the possible system related process for GTK+/WPE.
3003
3004         * BuildSlaveSupport/kill-old-processes:
3005         (listAllWebKitPrograms):
3006         (main):
3007
3008 2017-07-06  Chris Dumez  <cdumez@apple.com>
3009
3010         FileMonitor should not be ref counted
3011         https://bugs.webkit.org/show_bug.cgi?id=174166
3012
3013         Reviewed by Brent Fulgham.
3014
3015         Update the API tests to reflect the API change.
3016
3017         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3018         (TestWebKitAPI::TEST_F):
3019
3020 2017-07-06  Commit Queue  <commit-queue@webkit.org>
3021
3022         Unreviewed, rolling out r219194.
3023         https://bugs.webkit.org/show_bug.cgi?id=174207
3024
3025         it broke some layout tests (Requested by clopez on #webkit).
3026
3027         Reverted changeset:
3028
3029         "[GStreamer] vid.me videos do not play"
3030         https://bugs.webkit.org/show_bug.cgi?id=172240
3031         http://trac.webkit.org/changeset/219194
3032
3033 2017-07-06  Matt Lewis  <jlewis3@apple.com>
3034
3035         Unreviewed, rolling out r219178.
3036
3037         This caused a consistent failure with the API test
3038         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
3039
3040         Reverted changeset:
3041
3042         "[WTF] Clean up StringStatics.cpp by using
3043         LazyNeverDestroyed<> for Atoms"
3044         https://bugs.webkit.org/show_bug.cgi?id=174150
3045         http://trac.webkit.org/changeset/219178
3046
3047 2017-07-06  Alicia Boya García  <aboya@igalia.com>
3048
3049         Add CWD to Perl library path (no longer the default since 5.26.0)
3050         https://bugs.webkit.org/show_bug.cgi?id=174200
3051
3052         Reviewed by Michael Catanzaro.
3053
3054         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3055         (SetupGitClone._get_username_and_email):
3056
3057 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3058
3059         Unreviewed, update my email address.
3060
3061         * Scripts/webkitpy/common/config/contributors.json:
3062
3063 2017-07-06  Charlie Turner  <cturner@igalia.com>
3064         [GStreamer] vid.me videos do not play
3065         https://bugs.webkit.org/show_bug.cgi?id=172240
3066
3067         Reviewed by Xabier Rodriguez-Calvar.
3068
3069         Build httpsoupsrc again for use in adaptive streaming pipelines, and
3070         have the existing libsoup build against GNOME to avoid header drift
3071         against GStreamer's linked Soup library.
3072
3073         * gtk/jhbuild.modules:
3074
3075 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3076
3077         [WTF] Move SoftLinking.h into WTF
3078         https://bugs.webkit.org/show_bug.cgi?id=174000
3079
3080         Reviewed by Alex Christensen.
3081
3082         * DumpRenderTree/mac/TestRunnerMac.mm:
3083         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3084         (test_primary_header):
3085         (ErrorCollector.__init__): Deleted.
3086         (ErrorCollector.__call__): Deleted.
3087         (ErrorCollector.results): Deleted.
3088         (ErrorCollector.result_list): Deleted.
3089         (ErrorCollector.verify_all_categories_are_seen): Deleted.
3090         (MockIo.open): Deleted.
3091         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
3092         (CppFunctionsTest.test_create_acronym): Deleted.
3093         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
3094         (CppFunctionsTest.test_parameter): Deleted.
3095         (CppFunctionsTest.test_single_line_view): Deleted.
3096         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
3097         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
3098         (CppFunctionsTest.test_parameter_list): Deleted.
3099         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
3100         (CppStyleTestBase.process_file_data): Deleted.
3101         (CppStyleTestBase.perform_lint): Deleted.
3102         (CppStyleTestBase.perform_single_line_lint): Deleted.
3103         (CppStyleTestBase.perform_multi_line_lint): Deleted.
3104         (CppStyleTestBase.perform_language_rules_check): Deleted.
3105         (CppStyleTestBase.perform_function_lengths_check): Deleted.
3106         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
3107         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
3108         (CppStyleTestBase.perform_include_what_you_use): Deleted.
3109         (CppStyleTestBase.perform_header_guard_check): Deleted.
3110         (CppStyleTestBase.assert_lint): Deleted.
3111         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
3112         (CppStyleTestBase.assert_multi_line_lint): Deleted.
3113         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
3114         (CppStyleTestBase.assert_language_rules_check): Deleted.
3115         (CppStyleTestBase.assert_include_what_you_use): Deleted.
3116         (CppStyleTestBase.assert_header_guard): Deleted.
3117         (CppStyleTestBase.assert_blank_lines_check): Deleted.
3118         (CppStyleTestBase.assert_positions_equal): Deleted.
3119         (FunctionDetectionTest.test_basic_function_detection): Deleted.
3120         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
3121         (FunctionDetectionTest.test_pure_function_detection): Deleted.
3122         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
3123         (FunctionDetectionTest.test_ignore_macros): Deleted.
3124         (FunctionDetectionTest.test_non_functions): Deleted.
3125         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
3126         (FunctionDetectionTest.test_parameter_list): Deleted.
3127         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
3128         (CppStyleTest.test_asm_lines_ignored): Deleted.
3129         (CppStyleTest.test_get_line_width): Deleted.
3130         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
3131         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
3132         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
3133         (CppStyleTest.test_position): Deleted.
3134         (CppStyleTest.test_rfind_in_lines): Deleted.
3135         (CppStyleTest.test_close_expression): Deleted.
3136         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
3137         (CppStyleTest.test_cstyle_cast): Deleted.
3138         (CppStyleTest.test_runtime_casting): Deleted.
3139         (CppStyleTest.test_runtime_selfinit): Deleted.
3140         (CppStyleTest.test_runtime_rtti): Deleted.
3141         (CppStyleTest.test_static_cast_readability): Deleted.
3142         (CppStyleTest.test_check_for_unnamed_params): Deleted.
3143         (CppStyleTest.void): Deleted.
3144         (CppStyleTest.test_deprecated_cast): Deleted.
3145         (CppStyleTest.test_mock_method): Deleted.
3146         (CppStyleTest.test_sizeof_type): Deleted.
3147         (CppStyleTest.cases): Deleted.
3148         (CppStyleTest.for): Deleted.
3149         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
3150         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
3151         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
3152         (CppStyleTest.test_include_what_you_use): Deleted.
3153         (CppStyleTest.test_files_belong_to_same_module): Deleted.
3154         (CppStyleTest.test_cleanse_line): Deleted.
3155         (CppStyleTest.test_multi_line_comments): Deleted.
3156         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
3157         (CppStyleTest.test_multiline_strings): Deleted.
3158         (CppStyleTest.test_platformh_comments): Deleted.
3159         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
3160         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
3161         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
3162         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
3163         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
3164         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
3165         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
3166         (CppStyleTest.test_check_posix_threading): Deleted.
3167         (CppStyleTest.test_insecure_string_operations): Deleted.
3168         (CppStyleTest.test_format_strings): Deleted.
3169         (CppStyleTest.test_insecure_temp_file): Deleted.
3170         (CppStyleTest.test_variable_length_array_detection): Deleted.
3171         (CppStyleTest.test_braces): Deleted.
3172         (CppStyleTest.test_check_check): Deleted.
3173         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
3174         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
3175         (CppStyleTest.test_spacing_for_fncall): Deleted.
3176         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
3177         (CppStyleTest.test_spacing_before_braces): Deleted.
3178         (CppStyleTest.test_spacing_between_braces): Deleted.
3179         (CppStyleTest.test_spacing_before_brackets): Deleted.
3180         (CppStyleTest.test_cpp_lambda_functions): Deleted.
3181         (CppStyleTest.test_objective_c_block): Deleted.
3182         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
3183         (CppStyleTest.test_spacing_around_else): Deleted.
3184         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
3185         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
3186         (CppStyleTest.test_operator_methods): Deleted.
3187         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
3188         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
3189         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
3190         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
3191         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
3192         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
3193         (CppStyleTest.test_space_after_comment_marker): Deleted.
3194         (CppStyleTest.test_newline_at_eof): Deleted.
3195         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
3196         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
3197         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
3198         (CppStyleTest.test_invalid_utf8): Deleted.
3199         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
3200         (CppStyleTest.test_is_blank_line): Deleted.
3201         (CppStyleTest.test_blank_lines_check): Deleted.
3202         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
3203         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
3204         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
3205         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
3206         (CppStyleTest.test_comma): Deleted.
3207         (CppStyleTest.test_declaration): Deleted.
3208         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
3209         (CppStyleTest.test_indent): Deleted.
3210         (CppStyleTest.test_indent.Foo): Deleted.
3211         (CppStyleTest.test_not_alabel): Deleted.
3212         (CppStyleTest.test_tab): Deleted.
3213         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
3214         (CppStyleTest.test_build_class): Deleted.
3215         (CppStyleTest.test_build_class.definitions): Deleted.
3216         (CppStyleTest.test_build_class.Foo): Deleted.
3217         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
3218         (CppStyleTest.test_build_end_comment): Deleted.
3219         (CppStyleTest.test_build_forward_decl): Deleted.
3220         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
3221         (CppStyleTest.test_build_header_guard): Deleted.
3222         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
3223         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
3224         (CppStyleTest.test_build_printf_format): Deleted.
3225         (CppStyleTest.test_runtime_printf_format): Deleted.
3226         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
3227         (CppStyleTest.test_build_storage_class): Deleted.
3228         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
3229         (CppStyleTest.test_build_storage_class.declaration): Deleted.
3230         (CppStyleTest.test_build_storage_class.after): Deleted.
3231         (CppStyleTest.test_build_storage_class.is): Deleted.
3232         (CppStyleTest.test_legal_copyright): Deleted.
3233         (CppStyleTest.test_invalid_increment): Deleted.
3234         (CppStyleTest.test_enum_bitfields): Deleted.
3235         (CppStyleTest.test_plain_integral_bitfields): Deleted.
3236         (CleansedLinesTest.test_init_empty): Deleted.
3237         (CleansedLinesTest.test_collapse_strings): Deleted.
3238         (OrderOfIncludesTest.tearDown): Deleted.
3239         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
3240         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
3241         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
3242         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
3243         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
3244         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
3245         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
3246         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
3247         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
3248         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
3249         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
3250         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
3251         (OrderOfIncludesTest.test_primary_header): Deleted.
3252         (OrderOfIncludesTest.test_public_primary_header): Deleted.
3253         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
3254         (OrderOfIncludesTest.test_classify_include): Deleted.
3255         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
3256         (CheckForFunctionLengthsTest.tearDown): Deleted.
3257         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
3258         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
3259         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
3260         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
3261         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
3262         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
3263         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
3264         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
3265         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
3266         (CheckForFunctionLengthsTest.function_body): Deleted.
3267         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
3268         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
3269         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
3270         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
3271         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
3272         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
3273         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
3274         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
3275         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
3276         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
3277         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
3278         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
3279         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
3280         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
3281         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
3282         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
3283         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
3284         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
3285         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
3286         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
3287         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
3288         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
3289         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
3290         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
3291         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
3292         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
3293         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
3294         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
3295         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
3296         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
3297         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
3298         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
3299         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
3300         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
3301         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
3302         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
3303         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
3304         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
3305         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
3306         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
3307         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
3308         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
3309         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
3310         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
3311         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
3312         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
3313         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
3314         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
3315         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
3316         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
3317         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
3318         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
3319         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
3320         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
3321         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
3322         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
3323         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
3324         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
3325         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
3326         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
3327         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
3328         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
3329         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
3330         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
3331         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
3332         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
3333         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
3334         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
3335         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
3336         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
3337         (LeakyPatternTest.test_get_dc): Deleted.
3338         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
3339         (LeakyPatternTest.test_own_get_dc): Deleted.
3340         (LeakyPatternTest.test_create_dc): Deleted.
3341         (LeakyPatternTest.test_create_compatible_dc): Deleted.
3342         (WebKitStyleTest.test_indentation): Deleted.
3343         (WebKitStyleTest.test_indentation.Foo): Deleted.
3344         (WebKitStyleTest.test_indentation.Document): Deleted.
3345         (WebKitStyleTest.test_spacing): Deleted.
3346         (WebKitStyleTest.test_line_breaking): Deleted.
3347         (WebKitStyleTest.test_braces): Deleted.
3348         (WebKitStyleTest.test_braces.MyClass): Deleted.
3349         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
3350         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
3351         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
3352         (WebKitStyleTest.test_null_false_zero): Deleted.
3353         (WebKitStyleTest.test_directive_indentation): Deleted.
3354         (WebKitStyleTest.test_using_std): Deleted.
3355         (WebKitStyleTest.test_using_namespace): Deleted.
3356         (WebKitStyleTest.test_max_macro): Deleted.
3357         (WebKitStyleTest.test_min_macro): Deleted.
3358         (WebKitStyleTest.test_wtf_move): Deleted.
3359         (WebKitStyleTest.test_ctype_fucntion): Deleted.
3360         (WebKitStyleTest.test_names): Deleted.
3361         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
3362         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
3363         (WebKitStyleTest.test_names.declarations): Deleted.
3364         (WebKitStyleTest.test_names.struct): Deleted.
3365         (WebKitStyleTest.test_names.VectorType): Deleted.
3366         (WebKitStyleTest.test_parameter_names): Deleted.
3367         (WebKitStyleTest.test_comments): Deleted.
3368         (WebKitStyleTest.test_webkit_export_check): Deleted.
3369         (WebKitStyleTest.test_member_initialization_list): Deleted.
3370         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
3371         (WebKitStyleTest.test_other): Deleted.
3372         (CppCheckerTest.mock_handle_style_error): Deleted.
3373         (CppCheckerTest._checker): Deleted.
3374         (CppCheckerTest.test_init): Deleted.
3375         (CppCheckerTest.test_eq): Deleted.
3376         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
3377         (CppCheckerTest.test_ne): Deleted.
3378         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3379         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3380         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3381         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3382         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3383         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3384
3385 2017-07-05  Saam Barati  <sbarati@apple.com>
3386
3387         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
3388         https://bugs.webkit.org/show_bug.cgi?id=174188
3389         <rdar://problem/30581423>
3390
3391         Reviewed by Mark Lam.
3392
3393         * Scripts/run-jsc-stress-tests:
3394
3395 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3396
3397         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3398         https://bugs.webkit.org/show_bug.cgi?id=174150
3399
3400         Reviewed by Mark Lam.
3401
3402         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3403         (TestWebKitAPI::TEST):
3404
3405 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3406
3407         Remove copy of ICU headers from WebKit
3408         https://bugs.webkit.org/show_bug.cgi?id=116407
3409
3410         Reviewed by Alex Christensen.
3411
3412         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3413         * TestWebKitAPI/Configurations/Base.xcconfig:
3414         * WebKitTestRunner/Configurations/Base.xcconfig:
3415
3416 2017-07-05  Chris Dumez  <cdumez@apple.com>
3417
3418         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
3419         https://bugs.webkit.org/show_bug.cgi?id=174163
3420         <rdar://problem/33067518>
3421
3422         Reviewed by Alex Christensen.
3423
3424         Add API test coverage.
3425
3426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3427         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
3428         (TEST):
3429
3430 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3431
3432         When dragging a selection, clearing the selection in dragstart should not crash the web process
3433         https://bugs.webkit.org/show_bug.cgi?id=174142
3434         <rdar://problem/33067501>
3435
3436         Reviewed by Tim Horton.
3437
3438         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
3439         drag is starting up.
3440
3441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3442         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
3443         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3444         (TestWebKitAPI::TEST):
3445
3446 2017-07-05  Daniel Bates  <dabates@apple.com>
3447
3448         Do not pass API::FrameInfo for source frame or clear out page of target frame on
3449         API navigation
3450         https://bugs.webkit.org/show_bug.cgi?id=174170
3451         <rdar://problem/33140328>
3452
3453         Reviewed by Brady Eidson.
3454
3455         Update tests as needed for the behavior change.
3456
3457         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
3458         (TEST):
3459
3460 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3461
3462         Add WebKitPrivateFrameworkStubs for iOS 11
3463         https://bugs.webkit.org/show_bug.cgi?id=173988
3464
3465         Reviewed by David Kilzer.
3466
3467         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
3468         should use the same directory for private framework stubs.
3469         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3470
3471 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
3472
3473         [MediaStream] Protect request and web view during gUM client callback
3474         https://bugs.webkit.org/show_bug.cgi?id=174096
3475         <rdar://problem/32833102>
3476
3477         Reviewed by Youenn Fablet.
3478
3479         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3480         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3481
3482 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3483
3484         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
3485
3486         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3487
3488 2017-07-05  Matt Lewis  <jlewis3@apple.com>
3489
3490         Unreviewed, rolling out r219128.
3491
3492         Spoke with engineer who originally submitted, Patch for APi
3493         test to follow.
3494
3495         Reverted changeset:
3496
3497         "Unreviewed, rolling out r219070."
3498         https://bugs.webkit.org/show_bug.cgi?id=174082
3499         http://trac.webkit.org/changeset/219128
3500
3501 2017-07-05  Matt Lewis  <jlewis3@apple.com>
3502
3503         Unreviewed, rolling out r219070.
3504
3505         This revision caused consistent failures of the API test
3506         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
3507
3508         Reverted changeset:
3509
3510         "Pasting single words copied to UIPasteboard inserts URLs in
3511         editable areas"
3512         https://bugs.webkit.org/show_bug.cgi?id=174082
3513         http://trac.webkit.org/changeset/219070
3514
3515 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3516
3517         Remove unused EFL logo from bot watcher dashboard
3518         https://bugs.webkit.org/show_bug.cgi?id=174136
3519
3520         Reviewed by Alexey Proskuryakov.
3521
3522         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
3523         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
3524
3525 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3526
3527         [GTK] Add more GTK bots to dashboard
3528         https://bugs.webkit.org/show_bug.cgi?id=174129
3529
3530         Reviewed by Carlos Alberto Lopez Perez.
3531
3532         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
3533         them.
3534
3535         This also changes the sort order to put WPE above GTK so that it's not buried under all the
3536         less-essential GTK bots.
3537
3538         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3539         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3540         (WebKitBuildbot):
3541
3542 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3543
3544         [WPE] Add WPE to bot watcher dashboard
3545         https://bugs.webkit.org/show_bug.cgi?id=174119
3546
3547         Reviewed by Alexey Proskuryakov.
3548
3549         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
3550         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
3551         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
3552         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3553         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3554         (WebKitBuildbot):
3555         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3556         (table.queue-grid tr.platform.linux-wpe img.logo):
3557
3558 2017-07-03  Lucas Forschler  <lforschler@apple.com>
3559
3560         https://bugs.webkit.org/show_bug.cgi?id=174105
3561         
3562         Reviewed by Stephanie Lewis.
3563
3564         * BuildSlaveSupport/built-product-archive:
3565         (main): Add a -minify parser option
3566         (createZip): Pass along the optional Minify argument if requested
3567         (minifySource): This will trim down archives, logic limited to Mac platform.
3568
3569 2017-07-03  Matt Rajca  <mrajca@apple.com>
3570
3571         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
3572         https://bugs.webkit.org/show_bug.cgi?id=174103
3573
3574         Reviewed by Alex Christensen.
3575
3576         Added an API test.
3577
3578         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
3579         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3580         (TEST): Added test.
3581         * TestWebKitAPI/cocoa/TestWKWebView.h:
3582         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3583         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
3584
3585 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3586
3587         Unreviewed, rolling out r219103.
3588
3589         Caused multiple build failures.
3590
3591         Reverted changeset:
3592
3593         "Remove copy of ICU headers from WebKit"
3594         https://bugs.webkit.org/show_bug.cgi?id=116407
3595         http://trac.webkit.org/changeset/219103
3596
3597 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3598
3599         Remove copy of ICU headers from WebKit
3600         https://bugs.webkit.org/show_bug.cgi?id=116407
3601
3602         Reviewed by Alex Christensen.
3603
3604         Use WTF's copy of ICU headers.
3605
3606         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3607         * TestWebKitAPI/Configurations/Base.xcconfig:
3608         * WebKitTestRunner/Configurations/Base.xcconfig:
3609
3610 2017-07-03  Brady Eidson  <beidson@apple.com>
3611
3612         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3613         https://bugs.webkit.org/show_bug.cgi?id=174073
3614
3615         Reviewed by Andy Estes.
3616
3617         * DumpRenderTree/mac/TestRunnerMac.mm:
3618         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
3619
3620         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
3621         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3622
3623 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3624
3625         Unreviewed, rolling out r219083.
3626
3627         The revision caused an API failure on all testing platforms.
3628
3629         Reverted changeset:
3630
3631         "[MediaStream] Protect request and web view during gUM client
3632         callback"
3633         https://bugs.webkit.org/show_bug.cgi?id=174096
3634         http://trac.webkit.org/changeset/219083
3635
3636 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
3637
3638         webkitpy: Properly number duplicated crashlogs
3639         https://bugs.webkit.org/show_bug.cgi?id=172002
3640
3641         Reviewed by Aakash Jain.
3642
3643         * Scripts/webkitpy/common/system/crashlogs.py:
3644         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
3645         an increasing integer.
3646         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3647         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
3648         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
3649         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
3650
3651 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
3652
3653         WebContent processes crash when the network process crashes with pending connection requests
3654         https://bugs.webkit.org/show_bug.cgi?id=174065
3655         <rdar://problem/30359835>
3656
3657         Reviewed by Tim Horton.
3658
3659         Add a API to ensure UI process tries to relaunch a new network process when the network process
3660         crashes with pending network connection requests.
3661
3662         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3663         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
3664         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3665         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3666         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
3667
3668 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
3669
3670         [MediaStream] Protect request and web view during gUM client callback
3671         https://bugs.webkit.org/show_bug.cgi?id=174096
3672         <rdar://problem/32833102>
3673
3674         Reviewed by Youenn Fablet.
3675
3676         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3677         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3678
3679 2017-07-03  Andy Estes  <aestes@apple.com>
3680
3681         [Xcode] Add an experimental setting to build with ccache
3682         https://bugs.webkit.org/show_bug.cgi?id=173875
3683
3684         Reviewed by Tim Horton.
3685
3686         On systems that already have ccache(1) installed, this patch adds experimental support for
3687         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
3688
3689         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
3690         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
3691         find the toolchain from which to run clang, and then invokes ccache with the required
3692         arguments.
3693
3694         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
3695         precompiled headers to work properly [1].
3696
3697         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
3698         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
3699         during linking.
3700         
3701         [1] https://ccache.samba.org/manual.html#_precompiled_headers
3702
3703         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3704         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3705         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3706         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
3707         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
3708         * ccache/README.md: Added.
3709         * ccache/ccache-clang: Added.
3710         * ccache/ccache-clang++: Added.
3711         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
3712
3713 2017-07-03  Alex Christensen  <achristensen@webkit.org>
3714
3715         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3716         https://bugs.webkit.org/show_bug.cgi?id=174051
3717
3718         Reviewed by Tim Horton.
3719
3720         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3721         (TestWebKitAPI::TEST_F):
3722
3723 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3724
3725         Unreviewed, rolling out r219024.
3726
3727         This patch cause 3 didferent test to fail.
3728
3729         Reverted changeset:
3730
3731         "REGRESSION(r215096) Queries of URLs with non-special schemes
3732         should not percent-encode single quotes"
3733         https://bugs.webkit.org/show_bug.cgi?id=174051
3734         http://trac.webkit.org/changeset/219024
3735
3736 2017-07-03  Chris Dumez  <cdumez@apple.com>
3737
3738         Drop ResourceLoadStatisticsStore's statisticsLock
3739         https://bugs.webkit.org/show_bug.cgi?id=174080
3740
3741         Reviewed by Brent Fulgham.
3742
3743         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
3744
3745         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3746         (WTR::TestController::isStatisticsPrevalentResource):
3747         (WTR::TestController::isStatisticsHasHadUserInteraction):
3748         (WTR::TestController::isStatisticsGrandfathered):
3749
3750 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3751
3752         Pasting single words copied to UIPasteboard inserts URLs in editable areas
3753         https://bugs.webkit.org/show_bug.cgi?id=174082
3754         <rdar://problem/33046992>
3755
3756         Reviewed by Tim Horton.
3757
3758         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
3759
3760         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3761         (TestWebKitAPI::setUpWebViewForPasteboardTests):
3762         (TestWebKitAPI::TEST):
3763
3764 2017-07-02  Brady Eidson  <beidson@apple.com>
3765
3766         Add API test for all parts of WebKit1 API related to favicons.
3767         https://bugs.webkit.org/show_bug.cgi?id=174069
3768
3769         Reviewed by Andy Estes.
3770
3771         These two API tests cover all WebKit1 API related to icons.
3772         
3773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3774         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
3775         (mainResourceData):
3776         (defaultFaviconData):
3777         (customFaviconData):
3778         (imageFromData):
3779         (+[IconLoadingProtocol canInitWithRequest:]):
3780         (+[IconLoadingProtocol canonicalRequestForRequest:]):
3781         (-[IconLoadingProtocol startLoading]):
3782         (-[IconLoadingProtocol stopLoading]):
3783         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3784         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3785         (TestWebKitAPI::TEST):
3786
3787 2017-07-01  Dan Bernstein  <mitz@apple.com>
3788
3789         [iOS] Remove code only needed when building for iOS 9.x
3790         https://bugs.webkit.org/show_bug.cgi?id=174068
3791
3792         Reviewed by Tim Horton.
3793
3794         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3795         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3796         (WTR::initializeWebViewConfiguration):
3797         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3798         (-[HIDEventGenerator _createIOHIDEventType:]):
3799
3800 2017-07-01  Brady Eidson  <beidson@apple.com>
3801
3802         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
3803         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
3804
3805         Reviewed by Alex Christensen.
3806
3807         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3808
3809 2017-07-01  Dan Bernstein  <mitz@apple.com>
3810
3811         [macOS] Remove code only needed when building for OS X Yosemite
3812         https://bugs.webkit.org/show_bug.cgi?id=174067
3813
3814         Reviewed by Tim Horton.
3815
3816         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3817         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3818         * DumpRenderTree/mac/DumpRenderTree.mm:
3819         (setDefaultsToConsistentValuesForTesting):
3820         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3821         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3822         * MiniBrowser/Configurations/Base.xcconfig:
3823         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3824         * TestWebKitAPI/Configurations/Base.xcconfig:
3825         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3826         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3827         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
3828         (TestWebKitAPI::TEST_F):
3829         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
3830         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3831         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3832         (TestWebKitAPI::TEST_F):
3833         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3834         (TestWebKitAPI::TEST):
3835         * WebKitTestRunner/Configurations/Base.xcconfig:
3836         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3837         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3838         (WTR::InjectedBundle::platformInitialize):
3839         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3840         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3841
3842 2017-07-01  Chris Dumez  <cdumez@apple.com>
3843
3844         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
3845         https://bugs.webkit.org/show_bug.cgi?id=174060
3846
3847         Reviewed by Brent Fulgham.
3848
3849         Port WebKitTestRunner over to the new Cocoa SPI.
3850
3851         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3852         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3853         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3854         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
3855         no-ops since this code runs in the WebContent process, not the
3856         UIProcess.
3857
3858         * WebKitTestRunner/TestController.cpp:
3859         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3860
3861 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3862
3863         Unreviewed mac build fix.
3864
3865         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
3866         (TestWebKitAPI::TEST):
3867
3868 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3869
3870         Add API to get WKActivatedElementInfo
3871         https://bugs.webkit.org/show_bug.cgi?id=174001
3872         <rdar://problem/29165518>
3873         
3874         Tests for now SPI to get activatedElementInfo.
3875
3876         Reviewed by Tim Horton.
3877
3878         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3879         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
3880         (TestWebKitAPI::TEST):
3881
3882 2017-06-30  Chris Dumez  <cdumez@apple.com>
3883
3884         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
3885         https://bugs.webkit.org/show_bug.cgi?id=174038
3886
3887         Reviewed by Brent Fulgham.
3888
3889         Fix typo in API name.
3890
3891         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3892         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3893         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3894         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3895         * WebKitTestRunner/TestController.cpp:
3896         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3897         * WebKitTestRunner/TestController.h:
3898         * WebKitTestRunner/TestInvocation.cpp:
3899         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3900
3901 2017-06-30  Alex Christensen  <achristensen@webkit.org>
3902
3903         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3904         https://bugs.webkit.org/show_bug.cgi?id=174051
3905         <rdar://problem/33002846>
3906
3907         Reviewed by Tim Horton.
3908
3909         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3910         (TestWebKitAPI::TEST_F):
3911
3912 2017-06-30  Daniel Bates  <dabates@apple.com>
3913
3914         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3915         https://bugs.webkit.org/show_bug.cgi?id=165160
3916         <rdar://problem/29451999>
3917
3918         Reviewed by Brady Eidson.
3919
3920         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
3921         for navigations and window creation.
3922
3923         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3924         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
3925         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3926         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
3927         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3928         (TEST):
3929
3930 2017-06-29  Jer Noble  <jer.noble@apple.com>
3931
3932         Make Legacy EME API controlled by RuntimeEnabled setting.
3933         https://bugs.webkit.org/show_bug.cgi?id=173994
3934
3935         Reviewed by Sam Weinig.
3936
3937         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3938
3939 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3940
3941         Follow-up fix for r218996
3942
3943         Unreviewed infrastructure fix.
3944
3945         Repeated calls to 'ios_version' make the log noisy, memoize the function.
3946
3947         * Scripts/webkitpy/port/ios_simulator.py:
3948         (IOSSimulatorPort): Memoize ios_version().
3949
3950 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3951
3952         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3953         https://bugs.webkit.org/show_bug.cgi?id=174017
3954         <rdar://problem/32959782>
3955
3956         Reviewed by Simon Fraser.
3957
3958         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
3959         changes, the caret would appear outside of the iframe.
3960
3961         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3962         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
3963         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3964         (checkDragCaretRectIsContainedInRect):
3965         (TestWebKitAPI::TEST):
3966         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3967         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3968         (-[DataInteractionSimulator _resetSimulatedState]):
3969         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3970         (-[DataInteractionSimulator _advanceProgress]):
3971         (-[DataInteractionSimulator lastKnownDragCaretRect]):
3972
3973 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3974
3975         Add support for different versions of iOS when loading test expectations
3976         https://bugs.webkit.org/show_bug.cgi?id=173774
3977         <rdar://problem/32951132>
3978
3979         Rubber-stamped by Aakash Jain.
3980
3981         When running layout tests, we should support multiple version of iOS the same way we do Mac.
3982
3983         * Scripts/webkitpy/port/ios.py:
3984         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
3985         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
3986         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
3987         * Scripts/webkitpy/port/ios_device.py:
3988         (IOSDevicePort.ios_version): Ask connected devices for implementation.
3989         * Scripts/webkitpy/port/ios_device_unittest.py:
3990         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
3991         (IOSDeviceTest.test_baseline_searchpath): Ditto.
3992         (IOSDeviceTest.test_expectations_ordering): Ditto.
3993         * Scripts/webkitpy/port/ios_simulator.py:
3994         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
3995         ask the platform.
3996
3997 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
3998
3999         Fontconfig build breaks with glibc 2.15+
4000         https://bugs.webkit.org/show_bug.cgi?id=174019
4001
4002         Reviewed by Carlos Alberto Lopez Perez.
4003
4004         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
4005
4006         * wpe/jhbuild.modules:
4007         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
4008
4009 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
4010
4011         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
4012         https://bugs.webkit.org/show_bug.cgi?id=174010
4013         <rdar://problem/32597802>
4014
4015         Reviewed by Tim Horton.
4016
4017         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
4018         snapshot fails for any reason.
4019
4020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4021         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
4022         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4023         (TestWebKitAPI::TEST):
4024
4025 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
4026
4027         AX: Cannot call setValue() on contenteditable or ARIA text controls
4028         https://bugs.webkit.org/show_bug.cgi?id=173520
4029
4030         Reviewed by Ryosuke Niwa.
4031
4032         Add setValue() method to WKTR (already existed in DRT).
4033
4034         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4035         (WTR::AccessibilityUIElement::setValue):
4036         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4037         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4038         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4039         (WTR::AccessibilityUIElement::setValue):
4040
4041 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
4042
4043         getBoundingClientRect returns wrong value for combination of page zoom and scroll
4044         https://bugs.webkit.org/show_bug.cgi?id=173841
4045         rdar://problem/32983841
4046
4047         Reviewed by Dean Jackson.
4048
4049         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
4050         always did text zooming.
4051
4052         * MiniBrowser/mac/WK1BrowserWindowController.m:
4053         (-[WK1BrowserWindowController zoomIn:]):
4054         (-[WK1BrowserWindowController zoomOut:]):
4055         (-[WK1BrowserWindowController canResetZoom]):
4056         (-[WK1BrowserWindowController resetZoom:]):
4057
4058 2017-06-29  John Wilander  <wilander@apple.com>
4059
4060         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
4061         https://bugs.webkit.org/show_bug.cgi?id=173940
4062         <rdar://problem/33018125>
4063
4064         Reviewed by Brent Fulgham.
4065
4066         This change allows the TestController to turn off
4067         regular resource load statistics telemetry submission
4068         and to manually control when telemetry is calculated
4069         and submitted.
4070
4071         * WebKitTestRunner/TestController.cpp:
4072         (WTR::TestController::initialize):
4073             Turns off automatic resource load statistics telemetry submission.
4074
4075 2017-06-29  Commit Queue  <commit-queue@webkit.org>
4076
4077         Unreviewed, rolling out r218512.
4078         https://bugs.webkit.org/show_bug.cgi?id=173981
4079
4080         "It changes the behavior of the JS API's JSEvaluateScript
4081         which breaks TurboTax" (Requested by saamyjoon on #webkit).
4082
4083         Reverted changeset:
4084
4085         "test262: Completion values for control flow do not match the
4086         spec"
4087         https://bugs.webkit.org/show_bug.cgi?id=171265
4088         http://trac.webkit.org/changeset/218512
4089
4090 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
4091
4092         Add WebKitSystemInterface for iOS 11
4093         https://bugs.webkit.org/show_bug.cgi?id=173936
4094
4095         Reviewed by Lucas Forschler.
4096
4097         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
4098
4099 2017-06-28  Keith Miller  <keith_miller@apple.com>
4100
4101         VMTraps has some races
4102         https://bugs.webkit.org/show_bug.cgi?id=173941
4103
4104         Reviewed by Michael Saboff.
4105
4106         Add new testing mode for testing the Watchdog with our stress
4107         tests.
4108
4109         * Scripts/run-jsc-stress-tests:
4110
4111 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
4112
4113         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
4114         https://bugs.webkit.org/show_bug.cgi?id=173877
4115
4116         Reviewed by Brady Eidson.
4117
4118         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
4119         the next tests.
4120
4121         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
4122         (testGetFavicon):
4123
4124 2017-06-28  Tim Horton  <timothy_horton@apple.com>
4125
4126         MobileSafari was constantly using 10-15% CPU viewing a PDF
4127         https://bugs.webkit.org/show_bug.cgi?id=173944
4128         <rdar://problem/33039910>
4129
4130         Reviewed by Simon Fraser.
4131
4132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4133         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
4134         Add a test that we ever call the stable presentation update callback
4135         when we have a WKPDFView up, instead of infinitely looping.
4136
4137 2017-06-28  Alex Christensen  <achristensen@webkit.org>
4138
4139         Prevent displaying URLs with small capital letters
4140         https://bugs.webkit.org/show_bug.cgi?id=173949
4141         <rdar://problem/32952058>
4142
4143         Reviewed by Brent Fulgham.
4144
4145         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
4146         (TestWebKitAPI::TEST):
4147
4148 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
4149
4150         Unreviewed test fix.
4151
4152         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
4153
4154         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
4155
4156 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
4157
4158         Teach ResourceLoadStatistics to recognize changes in the file system
4159         https://bugs.webkit.org/show_bug.cgi?id=173800
4160         <rdar://problem/32937842>
4161
4162         Reviewed by Chris Dumez.
4163
4164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4165         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
4166         (TestWebKitAPI::FileMonitorTest::tempFilePath):
4167         (TestWebKitAPI::handleFileModification):
4168         (TestWebKitAPI::handleFileDeletion):
4169         (TestWebKitAPI::resetTestState):
4170         (TestWebKitAPI::TEST_F):
4171
4172 2017-06-28  Brady Eidson  <beidson@apple.com>
4173
4174         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
4175         https://bugs.webkit.org/show_bug.cgi?id=173874
4176
4177         Reviewed by Alex Christensen.
4178
4179         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
4180
4181 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
4182
4183         Unreviewed, adding Don Olmstead to contributors.json
4184
4185         * Scripts/webkitpy/common/config/contributors.json:
4186
4187 2017-06-28  Alex Christensen  <achristensen@webkit.org>
4188
4189         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
4190         https://bugs.webkit.org/show_bug.cgi?id=173886
4191         <rdar://problem/32543191>
4192
4193         Reviewed by Andy Estes.
4194
4195         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
4196         (ParsedRange::ParsedRange):
4197         (-[TestSchemeHandler initWithVideoData:]):
4198         (-[TestSchemeHandler webView:startURLSchemeTask:]):
4199         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
4200         (TEST):
4201
4202 2017-06-27  JF Bastien  <jfbastien@apple.com>
4203
4204         WebAssembly: running out of executable memory should throw OoM
4205         https://bugs.webkit.org/show_bug.cgi?id=171537
4206         <rdar://problem/32963338>
4207
4208         Reviewed by Saam Barati.
4209
4210         * Scripts/run-jsc-stress-tests: add a configuration which runs the
4211         tests under limited executable memory and avoids non-WebAssembly
4212         code generation so that we more reliably run out of executable
4213         memory in WebAssembly.
4214
4215 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
4216
4217         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
4218         https://bugs.webkit.org/show_bug.cgi?id=173854
4219         <rdar://problem/32236827>
4220
4221         Reviewed by Ryosuke Niwa and Tim Horton.
4222
4223         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
4224
4225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4226         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
4227         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4228         (TestWebKitAPI::TEST):
4229
4230 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
4231
4232         [PAL] Add symbol export macros for PAL
4233         https://bugs.webkit.org/show_bug.cgi?id=171519
4234
4235         Reviewed by Konstantin Tokarev.
4236
4237         * DumpRenderTree/config.h:
4238         * TestWebKitAPI/CMakeLists.txt:
4239         * TestWebKitAPI/config.h:
4240         * WebKitTestRunner/config.h:
4241
4242 2017-06-27  John Wilander  <wilander@apple.com>
4243
4244         Resource Load Statistics: Add telemetry
4245         https://bugs.webkit.org/show_bug.cgi?id=173499
4246         <rdar://problem/32826094>
4247
4248         Reviewed by Brent Fulgham.
4249
4250         Adds three new testRunner functions:
4251         - installStatisticsDidRunTelemetryCallback()
4252         - statisticsFireTelemetryHandler()
4253         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
4254
4255         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4256         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4257         (WTR::InjectedBundle::didReceiveMessageToPage):
4258         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4259         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
4260         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
4261         (WTR::TestRunner::statisticsFireTelemetryHandler):
4262         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
4263         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4264         * WebKitTestRunner/TestController.cpp:
4265         (WTR::TestController::resetStateToConsistentValues):
4266         (WTR::TestController::statisticsFireTelemetryHandler):
4267         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
4268         * WebKitTestRunner/TestController.h:
4269         * WebKitTestRunner/TestInvocation.cpp:
4270         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4271
4272 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
4273
4274         Add missing includes to fix compilation error on FreeBSD
4275         https://bugs.webkit.org/show_bug.cgi?id=172919
4276
4277         Reviewed by Mark Lam.
4278
4279         * ImageDiff/cairo/PlatformImageCairo.cpp:
4280
4281 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
4282
4283         Unreviewed, rolling out r218783.
4284
4285         Causing accessibility/mac/setting-attributes-is-
4286         asynchronous.html to crash consistently on mac-wk2 Debug
4287
4288         Reverted changeset:
4289
4290         "AX: Cannot call setValue() on contenteditable or ARIA text
4291         controls"
4292         https://bugs.webkit.org/show_bug.cgi?id=173520
4293         http://trac.webkit.org/changeset/218783
4294
4295 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
4296
4297         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
4298         https://bugs.webkit.org/show_bug.cgi?id=173825
4299
4300         Reviewed by Saam Barati.
4301
4302         * DumpRenderTree/JavaScriptThreading.cpp:
4303         (runJavaScriptThread):
4304         (startJavaScriptThreads):
4305         * DumpRenderTree/mac/DumpRenderTree.mm:
4306         (runThread):
4307         (runPthread):
4308         (testThreadIdentifierMap):
4309
4310 2017-06-26  David Kilzer  <ddkilzer@apple.com>
4311
4312         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
4313         <https://webkit.org/b/173837>
4314
4315         Reviewed by Geoffrey Garen.
4316
4317         The clang static analyzer can't reason about objects that are
4318         assigned to a delegate as +1 retained, and then released
4319         later in a different method when the delegate is cleared.
4320
4321         Instead, use a common idiom where the object setting the
4322         delegate retains it as an instance variable on initialization.
4323         Then the same object clears the delegate and releases its
4324         instance variable during teardown.
4325
4326         Also add EXPECT_TRUE() tests to make sure the delegate objects
4327         match before teardown.
4328
4329         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
4330         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
4331         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
4332         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
4333         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
4334         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
4335
4336 2017-06-26  David Kilzer  <ddkilzer@apple.com>
4337
4338         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
4339         <https://webkit.org/b/173836>
4340
4341         Reviewed by Brady Eidson.
4342
4343         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
4344         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
4345         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
4346         objects in this test.
4347
4348 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
4349
4350         [ATK] Add support for aria-details and aria-errormessage
4351         https://bugs.webkit.org/show_bug.cgi?id=172588
4352
4353         Reviewed by Chris Fleizach.
4354
4355         Add additional methods to test ARIA properties which are exposed via
4356         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
4357         to versions which support the details and error-message relation types.
4358
4359         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4360         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
4361         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
4362         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
4363         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
4364         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4365         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4366         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
4367         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):