Not reviewed. Bot fix.
[WebKit.git] / Tools / ChangeLog
1 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2
3         Not reviewed. Bot fix.
4
5         Remove an inadvertently committed debugging print.
6
7         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
8         (LayoutTestController::notifyDone):
9
10 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
11
12         Reviewed by Sam Weinig.
13
14         WebKitTestRunner should track loading more like DumpRenderTree
15         https://bugs.webkit.org/show_bug.cgi?id=52692
16
17         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
18         This makes some tests that call notifyDone multiple times pass.
19         
20         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
21         (WTR::InjectedBundle::InjectedBundle):
22         (WTR::InjectedBundle::done):
23         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
24         (WTR::InjectedBundle::topLoadingFrame):
25         (WTR::InjectedBundle::setTopLoadingFrame):
26         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
27         (WTR::InjectedBundlePage::InjectedBundlePage):
28         (WTR::InjectedBundlePage::stopLoading):
29         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
30         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
31         (WTR::InjectedBundlePage::didFinishLoadForFrame):
32         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
33         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
34         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
35         (WTR::LayoutTestController::notifyDone):
36         * WebKitTestRunner/TestController.cpp:
37         (WTR::TestController::didReceiveMessageFromInjectedBundle):
38
39 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
40
41         Reviewed by Kent Tamura.
42
43         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
44         https://bugs.webkit.org/show_bug.cgi?id=52678
45         
46         Update path now that WebKit is inside Source.
47
48         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
49
50 2011-01-18  Robert Hogan  <robert@webkit.org>
51
52         Reviewed by Simon Hausmann.
53
54         [Qt] http/tests/incremental/slow-utf8-text.pl fails
55         https://bugs.webkit.org/show_bug.cgi?id=44282
56
57         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
58         (WebCore::DumpRenderTree::dump):
59
60 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
61
62         Reviewed by Mihai Parparita.
63
64         Fix a small race condition that could cause the unit tests for
65         new-run-webkit-tests to fail in a multithreaded environment.
66         There was a small window in the code where one thread would
67         check to see if a thread had raised an exception, do something,
68         and then check to see if the thread was alive. If the other
69         thread raised an exception and exited in between these two
70         steps, the exception would be lost. Flipping the order of the
71         two checks fixes the race, since we will now always check for an
72         exception on the thread before exiting.
73
74         https://bugs.webkit.org/show_bug.cgi?id=51579
75
76         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
77
78 2011-01-18  Eric Seidel  <eric@webkit.org>
79
80         Reviewed by Adam Barth.
81
82         commit-queue dies when test archiving fails
83         https://bugs.webkit.org/show_bug.cgi?id=52617
84
85         I looked at the machine and it had 10 archives already
86         thus find_unused_name was returning None.  I've upped
87         the limit to 100 (per bug) and tested the case where
88         find_unused_name returns None (making archive return None).
89
90         * Scripts/webkitpy/common/system/workspace.py:
91         * Scripts/webkitpy/common/system/workspace_unittest.py:
92         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
93         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
94         * Scripts/webkitpy/tool/commands/queues.py:
95
96 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
97
98         Reviewed by Ojan Vafai.
99
100         Update rebaseline-chromium-webkit-tests unit tests to use a mock
101         filesystem. Also fix a couple of "with" statements missed by
102         r76050.
103
104         https://bugs.webkit.org/show_bug.cgi?id=52487
105
106         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
107
108 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
109
110         Reviewed by Martin Robinson.
111
112         [Gtk] Build fixes for gtk3 build
113         https://bugs.webkit.org/show_bug.cgi?id=52648
114
115         * DumpRenderTree/gtk/EventSender.cpp:
116         (beginDragWithFilesCallback):
117
118 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
119
120         Reviewed by Mihai Parparita.
121
122         Update rebaseline-chromium-webkit-tests to use filesystem objects
123         instead of direct references to os.path, shutil, tempfile, etc.
124
125         This patch doesn't change anything, but will allow subsequent
126         patches to change the unit tests to no longer use the real
127         filesystem.
128
129         This patch adds a bunch more methods to the filesystem object as
130         well.
131
132         https://bugs.webkit.org/show_bug.cgi?id=52482
133
134         * Scripts/webkitpy/common/system/filesystem.py:
135         * Scripts/webkitpy/common/system/filesystem_mock.py:
136         * Scripts/webkitpy/tool/commands/queues.py:
137         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
138         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
139
140 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
141
142         Reviewed by Mihai Parparita.
143
144         new-run-webkit-tests shouldn't crash when you try to run a
145         directory containing only skipped files.
146
147         https://bugs.webkit.org/show_bug.cgi?id=52478
148         
149         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
150         * Scripts/webkitpy/layout_tests/port/test.py:
151         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
152
153 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
154
155         Reviewed by Gustavo Noronha Silva.
156
157         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
158         https://bugs.webkit.org/show_bug.cgi?id=40833
159
160         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
161         GTK+ event sender.
162         (dragWithFilesDragDataGetCallback): Added.
163         (dragWithFilesDragEndCallback): Added.
164         (beginDragWithFilesCallback): Added.
165
166 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
167
168         Reviewed by Adam Barth.
169
170         ews: Add additional watcher to efl ews
171         https://bugs.webkit.org/show_bug.cgi?id=52613
172
173         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
174
175         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
176
177 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
178
179         Reviewed by Alexey Proskuryakov.
180
181         Fix some headers with missing or misspelled #ifndef guards
182         https://bugs.webkit.org/show_bug.cgi?id=52545
183
184         * DumpRenderTree/chromium/TestEventPrinter.h:
185         * DumpRenderTree/chromium/WebPreferences.h:
186
187 2011-01-17  Jessie Berlin  <jberlin@apple.com>
188
189         Reviewed by Anders Carlsson.
190
191         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
192         navigating back to an unreachable URL
193         https://bugs.webkit.org/show_bug.cgi?id=52388
194
195         Add a third parameter (unreachableURL) to queueLoadHTMLString.
196
197         * DumpRenderTree/LayoutTestController.cpp:
198         (queueLoadHTMLStringCallback):
199         (LayoutTestController::queueLoadHTMLString):
200         (LayoutTestController::queueLoadAlternateHTMLString):
201         * DumpRenderTree/LayoutTestController.h:
202
203         * DumpRenderTree/WorkQueueItem.h:
204         (LoadHTMLStringItem::LoadHTMLStringItem):
205
206         * DumpRenderTree/chromium/LayoutTestController.cpp:
207         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
208         (WorkItemLoadHTMLString::run):
209         (LayoutTestController::queueLoadHTMLString):
210
211         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
212         (LoadHTMLStringItem::invoke):
213         * DumpRenderTree/mac/WorkQueueItemMac.mm:
214         (LoadHTMLStringItem::invoke):
215         * DumpRenderTree/win/WorkQueueItemWin.cpp:
216         (LoadHTMLStringItem::invoke):
217
218 2011-01-17  Dan Bernstein  <mitz@apple.com>
219
220         Rubber-stamped by Mark Rowe.
221
222         Update xcodeproj svn:ignore to include xcuserdata.
223
224         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
225         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
226         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
227         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
228         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
229
230 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
231
232         Unreviewed fix after r75908.
233
234         Move WebKit into Source
235         https://bugs.webkit.org/show_bug.cgi?id=52530
236
237         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
238
239 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
240
241         Unreviewed.
242
243         Remove accidentally committed debug printing after r75908.
244
245         * Scripts/webkitdirs.pm:
246
247 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
248
249         Unreviewed.
250
251         Add myself to committers list
252         https://bugs.webkit.org/show_bug.cgi?id=52566
253
254         * Scripts/webkitpy/common/config/committers.py:
255
256 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
257
258         Reviewed by Jeremy Orlow.
259
260         GeolocationController should call stopUpdating on destruction
261         https://bugs.webkit.org/show_bug.cgi?id=52216
262
263         fast/dom/Geolocation/window-close-crash.html requires that a
264         Geolocation watch be started in a secondary window. Consequently,
265         we need to allow geolocation permission and provide a mock
266         geolocation position for the secondary window's
267         GeolocationClientMock.
268
269         * DumpRenderTree/chromium/LayoutTestController.cpp:
270         (LayoutTestController::setGeolocationPermission):
271         (LayoutTestController::setMockGeolocationPosition):
272         (LayoutTestController::setMockGeolocationError):
273         * DumpRenderTree/chromium/TestShell.h:
274         (TestShell::windowList):
275
276 2011-01-16  Adam Barth  <abarth@webkit.org>
277
278         Update more include paths to reflect WebKit move.
279
280         * DumpRenderTree/chromium/EventSender.cpp:
281         (EventSender::keyDown):
282         (EventSender::needsShiftModifier):
283         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
284         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
285
286 2011-01-16  Kent Tamura  <tkent@chromium.org>
287
288         Unreviewed, Chromium build fix.
289
290         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
291
292 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
293
294         Build fix for GTK+ after source directory movement.
295
296         * GNUmakefile.am: Correct include paths.
297
298 2011-01-16  Adam Barth  <abarth@webkit.org>
299
300         Teach svn-apply about WebKit move.
301
302         * Scripts/VCSUtils.pm:
303
304 2011-01-16  Adam Barth  <abarth@webkit.org>
305
306         Rubber-stamped by Eric Seidel.
307
308         Move WebKit into Source
309         https://bugs.webkit.org/show_bug.cgi?id=52530
310
311         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
312         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
313         * DumpRenderTree/qt/DumpRenderTreeQt.h:
314         * DumpRenderTree/qt/GCControllerQt.cpp:
315         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
316         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
317         * DumpRenderTree/qt/TextInputControllerQt.cpp:
318         * DumpRenderTree/wscript:
319         * QtTestBrowser/launcherwindow.h:
320         * Scripts/build-webkit:
321         * Scripts/webkitdirs.pm:
322
323 2011-01-15  Adam Barth  <abarth@webkit.org>
324
325         Teach svn-apply about WebKit2 move.
326
327         * Scripts/VCSUtils.pm:
328
329 2011-01-15  Adam Barth  <abarth@webkit.org>
330
331         Rubber-stamped by Eric Seidel.
332
333         Move WebKit2 into Source
334         https://bugs.webkit.org/show_bug.cgi?id=52438
335
336         * MiniBrowser/qt/MiniBrowser.pro:
337         * Scripts/build-webkit:
338         * Scripts/do-file-rename:
339         * Scripts/do-webcore-rename:
340         * Scripts/test-webkitpy:
341         * Scripts/webkitdirs.pm:
342         * Scripts/webkitpy/style/checker.py:
343         * WebKitTestRunner/DerivedSources.pro:
344         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
345         * WebKitTestRunner/qt/WebKitTestRunner.pro:
346
347 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
348
349         Reviewed by David Levin.
350
351         [chromium] remove obsolete createView method
352         https://bugs.webkit.org/show_bug.cgi?id=52437
353
354         * DumpRenderTree/chromium/WebViewHost.cpp:
355         (WebViewHost::createView):
356         * DumpRenderTree/chromium/WebViewHost.h:
357
358 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
359
360         Reviewed by Geoff Garen.
361
362         ShouldLoadResourceForFrame should use strings, not URLs.
363         https://bugs.webkit.org/show_bug.cgi?id=52476
364
365         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
366         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
367         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
368
369 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
370
371         Reviewed by David Levin.
372
373         Add Tony Gentilcore as a reviewer
374         https://bugs.webkit.org/show_bug.cgi?id=52480
375
376         * Scripts/webkitpy/common/config/committers.py:
377
378 2011-01-14  David Levin  <levin@chromium.org>
379
380         Reviewed by Eric Seidel.
381
382         check-webkit-style: _FunctionState should keep track of where the function name starts.
383         https://bugs.webkit.org/show_bug.cgi?id=52454
384
385         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
386         _FunctionState and logic for setting it correctly.
387         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
388
389 2011-01-14  Vincent Scheib  <scheib@chromium.org>
390
391         Reviewed by David Levin.
392
393         Add support to DumpRenderTree to use the GPU rather than software renderer
394         https://bugs.webkit.org/show_bug.cgi?id=52333
395
396         * DumpRenderTree/chromium/DumpRenderTree.cpp:
397         (main):
398         * Scripts/webkitpy/layout_tests/port/chromium.py:
399         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
400
401 2011-01-14  Tony Chang  <tony@chromium.org>
402
403         Reviewed by Kent Tamura.
404
405         [chromium] update fonts.conf to fix 6 linux tests in drt
406         https://bugs.webkit.org/show_bug.cgi?id=52411
407
408         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
409             chromium's src/webkit/tools/test_shell/resources/fonts.conf
410
411 2011-01-14  Eric Seidel  <eric@webkit.org>
412
413         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
414
415         Reviewed by Adam Barth.
416
417         Fix when running Tools/Scripts/check-webkit-style without arguments.
418         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
419
420         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
421         * Scripts/webkitpy/common/checkout/scm_unittest.py:
422
423 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
424
425         Reviewed by David Levin.
426
427         Store the tempdir object in a variable so it doesn't get deleted too early.
428         https://bugs.webkit.org/show_bug.cgi?id=51875
429
430         * Scripts/update-webkit-auxiliary-libs:
431         * Scripts/update-webkit-support-libs:
432
433 2011-01-14  Eric Seidel  <eric@webkit.org>
434
435         Unreviewed.  Make it work in python 2.5.
436
437         webkit-patch suggest-reviewers dies when ChangeLogs are missing
438         https://bugs.webkit.org/show_bug.cgi?id=49158
439
440         * Scripts/webkitpy/common/checkout/api_unittest.py:
441
442 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
443
444         Unreviewed, rolling out r75774.
445         http://trac.webkit.org/changeset/75774
446         https://bugs.webkit.org/show_bug.cgi?id=52431
447
448         gtk builds were broken (Requested by loislo2 on #webkit).
449
450         * Scripts/webkitpy/common/checkout/scm.py:
451
452 2011-01-14  David Levin  <levin@chromium.org>
453
454         Reviewed by Shinichiro Hamaji.
455
456         check-webkit-style: _FunctionState should detect pure functions.
457         https://bugs.webkit.org/show_bug.cgi?id=52428
458
459         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
460         is a pure virtual function.
461         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
462         virtual functions are correctly detected.
463
464 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
465
466         Reviewed by Yury Semikhatsky.
467
468         Just small fix for problem with check-webkit-style.
469         It just didn't work for this patch.
470         Old code can't concatenate a list of strings with None.
471
472         * Scripts/webkitpy/common/checkout/scm.py:
473
474 2011-01-13  David Levin  <levin@chromium.org>
475
476         Reviewed by Shinichiro Hamaji.
477
478         check-webkit-style: _FunctionState should use Position to know where items are.
479         https://bugs.webkit.org/show_bug.cgi?id=52424
480
481         * Scripts/webkitpy/style/checkers/cpp.py:
482         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
483         (detect_functions): Changed to pass Position's to _FunctionState.begin and
484         did some minor clean-up.
485         (*): Other changes are simply about converting to use the Position's in_FunctionState
486         instead of line numbers.
487         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
488         to verify the positions stored in _FunctionState.
489
490 2011-01-13  Eric Seidel  <eric@webkit.org>
491
492         Reviewed by David Levin.
493
494         webkit-patch suggest-reviewers dies when ChangeLogs are missing
495         https://bugs.webkit.org/show_bug.cgi?id=49158
496
497         This is not the most elegant, but it is a very safe fix to this bug.
498         One advantage of catching ScriptError like this instead of adding a
499         new added_or_modified_files or fixing all changed_files callers
500         to use a more specific change_files variant, is that we catch
501         all kinds of ScriptErrors which might cause our (non-essential)
502         suggest-reviewers code to fail out.  This should make passing
503         --suggest-reviewers to webkit-patch upload much more robust
504         and may even make it possible for us to make it default.
505
506         The root of the problem here is that SCM.changed_files includes
507         deleted ChangeLog paths (from moves, etc) which then when we ask
508         SVN/Git for the contents of the file at that revision, the command
509         errors out and Executive.run_command raises a ScriptError.
510
511         In the future we might fix this differently by making all current
512         callers of chagned_files use a more specific method for requesting
513         what types of changes they're interested in (adds, modifies, deletes, etc.)
514
515         * Scripts/webkitpy/common/checkout/api.py:
516         * Scripts/webkitpy/common/checkout/api_unittest.py:
517
518 2011-01-13  Dan Bernstein  <mitz@apple.com>
519
520         Reviewed by Alexey Proskuryakov.
521
522         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
523         https://bugs.webkit.org/show_bug.cgi?id=52419
524
525         Allow to further control the behavior of the willSendRequest delegate callback by making it
526         set a different URL in the new request.
527
528         * DumpRenderTree/LayoutTestController.cpp:
529         (addURLToRedirectCallback): Added.
530         (LayoutTestController::staticFunctions): Added addURLToRedirect.
531         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
532         (LayoutTestController::redirectionDestinationForURL): Added this getter.
533         * DumpRenderTree/LayoutTestController.h:
534         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
535         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
536         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
537         change the URL in the new request to the redirect destination.
538
539 2011-01-13  Eric Seidel  <eric@webkit.org>
540
541         Reviewed by Mihai Parparita.
542
543         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
544         https://bugs.webkit.org/show_bug.cgi?id=52416
545
546         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
547         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
548
549         I also added FIXMEs about the changed_files returning deleted files problem
550         which is causing the other most common exception for suggest-reviewers
551         (and is probably breaking sheriff-bots blame detection).
552
553         * Scripts/webkitpy/common/checkout/api.py:
554         * Scripts/webkitpy/common/checkout/api_unittest.py:
555         * Scripts/webkitpy/common/checkout/scm.py:
556
557 2011-01-13  Eric Seidel  <eric@webkit.org>
558
559         Reviewed by Adam Barth.
560
561         results archives from commit-queue are too large to upload
562         https://bugs.webkit.org/show_bug.cgi?id=52405
563
564         * Scripts/webkitpy/common/system/filesystem.py:
565         * Scripts/webkitpy/common/system/filesystem_mock.py:
566         * Scripts/webkitpy/tool/commands/queues.py:
567
568 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
569
570         Reviewed by Martin Robinson.
571
572         [gtk] Zero-sized font does not yet work
573         https://bugs.webkit.org/show_bug.cgi?id=49793
574
575         Set minimum-font-size to 0 for the DRT.
576
577         * DumpRenderTree/gtk/DumpRenderTree.cpp:
578         (resetDefaultsToConsistentValues):
579
580 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
581
582         Reviewed by Darin Adler.
583
584         Make old-run-webkit-tests more robust on buildbots
585         https://bugs.webkit.org/show_bug.cgi?id=52364
586
587         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
588
589 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
590
591         Reviewed by Darin Adler.
592
593         Make old-run-webkit-tests more robust on buildbots
594         https://bugs.webkit.org/show_bug.cgi?id=52364
595
596         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
597
598 2011-01-13  Tony Chang  <tony@chromium.org>
599
600         Reviewed by Kent Tamura.
601
602         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
603         https://bugs.webkit.org/show_bug.cgi?id=52332
604
605         Forked Info.plist is not longer needed.
606
607         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
608
609 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
610
611         Reviewed by Timothy Hatcher.
612
613         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
614         to be passed directly to WebInspector.UIString
615
616         https://bugs.webkit.org/show_bug.cgi?id=52365
617
618         * Scripts/check-inspector-strings:
619
620 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
621
622         Unreviewed, rolling out r74881.
623         http://trac.webkit.org/changeset/74881
624         https://bugs.webkit.org/show_bug.cgi?id=52357
625
626         The EFL builder has been red for days (Requested by abarth on
627         #webkit).
628
629         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
630         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
631
632 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
633
634         Reviewed by David Levin.
635
636         Add beforeunload support to WebKitTestRunner
637         https://bugs.webkit.org/show_bug.cgi?id=52353
638         
639         This makes a number of currently failing tests pass.
640
641         * WebKitTestRunner/TestController.cpp:
642         (WTR::runBeforeUnloadConfirmPanel):
643         (WTR::createOtherPage):
644         (WTR::TestController::initialize):
645
646 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
647
648         Reviewed by Sam Weinig.
649
650         Detect, identify and recover from WebProcess crashes in run-webkit-tests
651         https://bugs.webkit.org/show_bug.cgi?id=52330
652
653         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
654         a web process crash.
655         * WebKitTestRunner/TestController.cpp:
656         (WTR::TestController::initialize): Set up a processDidCrash
657         callback.
658         (WTR::TestController::processDidCrash): Report that the Web process
659         crashed.
660         * WebKitTestRunner/TestController.h:
661
662 2011-01-12  David Levin  <levin@chromium.org>
663
664         Reviewed by Shinichiro Hamaji.
665
666         check-webkit-style -- close_expression function doesn't work correctly.
667         https://bugs.webkit.org/show_bug.cgi?id=52272
668
669         * Scripts/webkitpy/style/checkers/cpp.py:
670         (Position.__str__): Added a way to convert it to a string which is useful in tests.
671         (Position.__cmp__): Added a way to compare Position which is useful in tests and
672         generally useful (for upcoming code changes).
673         (close_expression): Changed to use Position for input and output.
674         Also, fixed many bugs such as only working correctly for parenthesis,
675         not working correctly if given an offset in a line and not finding
676         the real closing element if there were multiple closing elements in
677         the same line.
678         (detect_functions): Adjusted due to the change in arguments for
679         close_expression.
680         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
681         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
682         two positions are the same.
683         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
684         (CppStyleTest.test_close_expression): Added tests to catch the issues
685         that were fixed.
686
687 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
688
689         Unreviewed, rolling out r75576.
690         http://trac.webkit.org/changeset/75576
691         https://bugs.webkit.org/show_bug.cgi?id=52304
692
693         broke rebaseline-chromium-webkit-test (Requested by thakis on
694         #webkit).
695
696         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
697         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
698         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
699         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
700         * Scripts/webkitpy/layout_tests/port/base.py:
701         * Scripts/webkitpy/layout_tests/port/chromium.py:
702         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
703         * Scripts/webkitpy/layout_tests/port/test.py:
704         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
705         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
706         * Scripts/webkitpy/style/checkers/test_expectations.py:
707         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
708
709 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
710
711         Reviewed by Darin Adler.
712
713         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
714         https://bugs.webkit.org/show_bug.cgi?id=52307
715
716         * Scripts/old-run-webkit-tests:
717
718 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
719
720         Reviewed by Martin Robinson.
721
722         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
723         https://bugs.webkit.org/show_bug.cgi?id=50867
724
725         Fixed library extention for Mac in webkitdirs.pm and type conflict in
726         TestNetscapePlugin.cpp 
727
728         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
729         * Scripts/webkitdirs.pm:
730
731 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
732
733         Reviewed by Pavel Feldman.
734
735         Add check-inspector-strings script.
736
737         https://bugs.webkit.org/show_bug.cgi?id=52295
738
739         * Scripts/check-inspector-strings: Added.
740
741 2011-01-12  Adam Roben  <aroben@apple.com>
742
743         Advertise the .testnetscape file extension on Windows
744
745         Fixes <http://webkit.org/b/52298>
746         plugins/no-mime-with-valid-extension.html fails on Windows
747
748         Reviewed by Dan Bernstein.
749
750         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
751         FileExtents field to map the .testnetscape file extension to the
752         application/x-webkit-test-netscape MIME type, just as we do on Mac.
753
754 2011-01-12  Adam Barth  <abarth@webkit.org>
755
756         Reviewed by Eric Seidel.
757
758         Make webkit-patch support subdirectories for SVN checkouts
759         https://bugs.webkit.org/show_bug.cgi?id=52261
760
761         os.relpath does not exist on Python 2.5, so we need to call our version
762         of the API.
763
764         * Scripts/webkitpy/common/checkout/scm.py:
765
766 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
767
768         Reviewed by Eric Seidel.
769
770         Close additional pages opened during a test once the test completes.
771         https://bugs.webkit.org/show_bug.cgi?id=52276
772
773         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
774         (WTR::InjectedBundle::done):
775
776 2011-01-11  David Levin  <levin@chromium.org>
777
778         Reviewed by Eric Seidel.
779
780         Errors should be separated from the command line in bot messages.
781         https://bugs.webkit.org/show_bug.cgi?id=52275
782
783         * Scripts/webkitpy/common/system/executive.py:
784         (ScriptError.message_with_output): Added a newline to separate the command
785         line from the errors.
786         * Scripts/webkitpy/common/system/executive_unittest.py:
787         (ScriptErrorTest.test_message_with_output): Added tests for the various code
788         paths in message_with_output.
789
790 2011-01-11  Eric Seidel  <eric@webkit.org>
791
792         Unreviewed.
793
794         commit-queue should know how to upload archived results (for test flakes or general failures)
795         https://bugs.webkit.org/show_bug.cgi?id=52048
796
797         The zips are mostly empty due to forgetting -r.
798         Expected diffs were not being pulled from the archive due
799         to the archive having longer paths than I realized.
800
801         * Scripts/webkitpy/common/system/workspace.py:
802         * Scripts/webkitpy/common/system/workspace_unittest.py:
803         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
804         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
805
806 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
807
808         Reviewed by Ojan Vafai.
809
810         The current modifier parsing code in test_expectations is
811         fragile and hard-coded, so it's not easy to understand the logic
812         or easily add new types of modifiers (like GPU vs. CPU testing
813         for graphics tests, or 32-bit vs. 64-bit differences).
814
815         This is the first of two patches that will add in more generic
816         support and then eliminate the GPU-specific test expectations
817         files for Chromium.
818
819         This patch adds two standalone objects for handling modifiers. The
820         rules for interpreting modifiers, precedence, and conflicts are
821         given in the docstring to the ModifierMatcher class, which
822         returns ModifierMatchResult objects.
823         
824         This patch also adds routines to the Port interface and a
825         default set of values in the base object, in order to obtain the
826         values needed on a given test run. These values are then passed
827         to the expectation parser. This also allows us to clean up the
828         logic used to lint all of the different configurations in a
829         single test_expectations.txt file.
830
831         The next patch will merge in the separate GPU expectations file.
832
833         https://bugs.webkit.org/show_bug.cgi?id=51222
834
835         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
836         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
837         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
838         * Scripts/webkitpy/layout_tests/port/base.py:
839         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
840         * Scripts/webkitpy/layout_tests/port/chromium.py:
841         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
842         * Scripts/webkitpy/layout_tests/port/test.py:
843         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
844         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
845
846 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
847
848         Reviewed by Adam Barth.
849
850         Make webkit-patch support subdirectories for SVN checkouts
851         https://bugs.webkit.org/show_bug.cgi?id=52261
852
853         * Scripts/webkitpy/common/checkout/scm.py:
854         * Scripts/webkitpy/style_references.py:
855         * Scripts/webkitpy/tool/main.py:
856         * Scripts/webkitpy/tool/steps/preparechangelog.py:
857
858 2011-01-11  Eric Seidel  <eric@webkit.org>
859
860         Unreviewed.
861
862         commit-queue should know how to upload archived results (for test flakes or general failures)
863         https://bugs.webkit.org/show_bug.cgi?id=52048
864
865         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
866         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
867
868         * Scripts/webkitpy/common/system/workspace.py:
869         * Scripts/webkitpy/common/system/workspace_unittest.py:
870         * Scripts/webkitpy/tool/commands/queues.py:
871
872 2011-01-11  Sam Weinig  <sam@webkit.org>
873
874         Roll r75474 back in.
875
876 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
877
878         Reviewed by Kenneth Rohde Christiansen.
879
880         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
881         https://bugs.webkit.org/show_bug.cgi?id=51204
882
883         * QtTestBrowser/webpage.h:
884         (QtNAMThread::QtNAMThread):
885         (QtNAMThread::networkAccessManager):
886         (QtNAMThread::run):
887
888 2011-01-11  Peter Varga  <pvarga@webkit.org>
889
890         Unreviewed.
891
892         Add myself to committers' list.
893
894         * Scripts/webkitpy/common/config/committers.py:
895
896 2011-01-11  Eric Seidel  <eric@webkit.org>
897
898         Reviewed by Adam Barth.
899
900         commit-queue should know how to upload archived results (for test flakes or general failures)
901         https://bugs.webkit.org/show_bug.cgi?id=52048
902
903         Now the queue will always upload results.  Either the entire zip, or just
904         the diffs.txt in the case of text failures.
905
906         This should make understanding flakes much easier, and paves the way
907         for having the EWS run layout tests (and upload failures).
908
909         In order to upload .zip files I had to teach bugzilla.py to autodetect
910         mime types from the filename.  Since mimetypes.py doesn't include a mapping
911         for .patch files, I have it add one before calling guess_type.
912
913         We may find that always uploading the whole zip instead of just the -diffs.txt
914         file is preferable, but for now I'm keeping the old behavior because it makes
915         quickly understanding text failures easy.
916
917         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
918         * Scripts/webkitpy/common/system/workspace.py: Added.
919         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
920         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
921         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
922         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
923         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
924         * Scripts/webkitpy/tool/commands/queues.py:
925         * Scripts/webkitpy/tool/commands/queues_unittest.py:
926
927 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
928
929         Unreviewed, rolling out r75464.
930         http://trac.webkit.org/changeset/75464
931         https://bugs.webkit.org/show_bug.cgi?id=52193
932
933         Followup rollout for 75474 (Requested by Ossy on #webkit).
934
935         * MiniBrowser/mac/BrowserWindowController.m:
936         (-[BrowserWindowController awakeFromNib]):
937         * MiniBrowser/win/BrowserView.cpp:
938         (BrowserView::create):
939         * WebKitTestRunner/TestController.cpp:
940         (WTR::createOtherPage):
941         (WTR::TestController::initialize):
942
943 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
944
945         Reviewed by Csaba Osztrogonác.
946
947         [Qt] Baseline qt_minimal configuration
948         https://bugs.webkit.org/show_bug.cgi?id=51313
949
950         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
951         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
952         QT_NO_UNDOSTACK guard.
953
954         * QtTestBrowser/launcherwindow.cpp:
955         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
956         guards.
957         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
958         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
959         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
960         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
961
962         * QtTestBrowser/launcherwindow.h:
963         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
964         * QtTestBrowser/locationedit.h: Ditto.
965
966         * QtTestBrowser/mainwindow.cpp:
967         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
968         QT_NO_UNDOSTACK guards.
969         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
970         (MainWindow::changeLocation): Ditto.
971         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
972         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
973
974         * QtTestBrowser/webpage.cpp:
975         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
976         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
977
978         * QtTestBrowser/webview.cpp:
979         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
980         (WebViewGraphicsBased::animatedYFlip): Ditto.
981
982 2011-01-10  Sam Weinig  <sam@webkit.org>
983
984         Fix build.
985
986         * MiniBrowser/mac/BrowserWindowController.m:
987         (-[BrowserWindowController awakeFromNib]):
988         * MiniBrowser/win/BrowserView.cpp:
989         (BrowserView::create):
990         * WebKitTestRunner/TestController.cpp:
991         (WTR::createOtherPage):
992         (WTR::TestController::initialize):
993
994 2011-01-10  Eric Seidel  <eric@webkit.org>
995
996         Reviewed by Ojan Vafai.
997
998         style-queue messages are way too long for big patches
999         https://bugs.webkit.org/show_bug.cgi?id=52161
1000
1001         We definitely could build much fancier list-to-string-with-limit functions
1002         but this should be sufficient for our needs at the moment.
1003
1004         * Scripts/webkitpy/common/system/executive.py:
1005         * Scripts/webkitpy/common/system/executive_unittest.py:
1006
1007 2011-01-10  Tony Chang  <tony@chromium.org>
1008
1009         Unreviewed, rolling out r75398.
1010         http://trac.webkit.org/changeset/75398
1011         https://bugs.webkit.org/show_bug.cgi?id=52008
1012
1013         Some layout tests are crashing on Chromium Win.
1014
1015         * DumpRenderTree/chromium/WebViewHost.cpp:
1016         (WebViewHost::updatePaintRect):
1017         * DumpRenderTree/chromium/WebViewHost.h:
1018
1019 2011-01-10  Adam Roben  <aroben@apple.com>
1020
1021         Roll out r75392
1022
1023         It isn't needed now that r75289 has been rolled out.
1024
1025         * Scripts/run-javascriptcore-tests:
1026
1027 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1028
1029         Reviewed by Anders Carlsson.
1030
1031         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1032         https://bugs.webkit.org/show_bug.cgi?id=52160
1033
1034         * WebKitTestRunner/mac/TestControllerMac.mm:
1035         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1036         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1037         anyway.
1038
1039 2011-01-10  Tony Chang  <tony@chromium.org>
1040
1041         Reviewed by Mihai Parparita.
1042
1043         [chromium] fix for animated gif layout tests
1044         https://bugs.webkit.org/show_bug.cgi?id=52008
1045
1046         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1047             to trigger gif animations.
1048         (WebViewHostPaintTask::WebViewHostPaintTask):
1049         (WebViewHostPaintTask::runIfValid):
1050         (WebViewHost::updatePaintRect):
1051         * DumpRenderTree/chromium/WebViewHost.h:
1052         (WebViewHost::taskList):
1053
1054 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1055
1056         Reviewed by Xan Lopez.
1057
1058         [GTK] Fix gtk2 compilation for master
1059         https://bugs.webkit.org/show_bug.cgi?id=51885
1060
1061         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1062         (createBitmapContextFromWebView): Replaced the old
1063         gdk_drawable_get_size with gdk_pixmap_get_size.
1064
1065 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1066
1067         Reviewed by Laszlo Gombos.
1068
1069         [WINCE] Reenable NPAPI after r75203
1070         https://bugs.webkit.org/show_bug.cgi?id=52109
1071
1072         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1073         it with !isEfl(), because EFL port does not support NPAPI (yet).
1074
1075         * Scripts/build-webkit:
1076
1077 2011-01-10  Adam Roben  <aroben@apple.com>
1078
1079         Skip some asserting JS tests
1080
1081         See <http://webkit.org/b/52156>.
1082
1083         * Scripts/run-javascriptcore-tests:
1084
1085 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1086
1087         Reviewed by Xan Lopez.
1088
1089         [GTK] build-webkit disable Blob support via arguments passed to automake
1090         https://bugs.webkit.org/show_bug.cgi?id=52097
1091
1092         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1093         build-webkit.
1094
1095 2011-01-10  Adam Roben  <aroben@apple.com>
1096
1097         Use the same name and description for TestNetscapePlugin on Windows and
1098         Mac
1099
1100         Fixes <http://webkit.org/b/52151>
1101         fast/frames/iframe-reparenting-plugins.html fails on Windows
1102
1103         Reviewed by Steve Falkenburg.
1104
1105         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1106         the name and description from Mac's Info.plist.
1107
1108 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1109
1110         Reviewed by Laszlo Gombos.
1111
1112         [Qt][WK2] Guard gcc-specific syntax
1113
1114         Non-gcc based compliers choke on the "-include"
1115         syntax for preinclude, place guard around it.
1116
1117         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1118         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1119
1120 2011-01-10  Andreas Kling  <kling@webkit.org>
1121
1122         Reviewed by Simon Hausmann.
1123
1124         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1125         https://bugs.webkit.org/show_bug.cgi?id=52111
1126
1127         When getting a createNewPage() callback from QWKPage, create the
1128         new page with the same QWKContext as the page that is passed to
1129         the callback.
1130
1131         * MiniBrowser/qt/BrowserView.h:
1132         * MiniBrowser/qt/BrowserWindow.cpp:
1133         (newPageFunction):
1134         (BrowserWindow::BrowserWindow):
1135         * MiniBrowser/qt/BrowserWindow.h:
1136
1137 2011-01-10  Andreas Kling  <kling@webkit.org>
1138
1139         Reviewed by Kenneth Rohde Christiansen.
1140
1141         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1142
1143         BrowserView set its own useless createNewPage() callback on QWKPage.
1144         This was immediately overridden by BrowserWindow anyway, so remove
1145         the BrowserView one.
1146
1147         * MiniBrowser/qt/BrowserView.cpp:
1148         (BrowserView::BrowserView):
1149
1150 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1151
1152         Reviewed by Jeremy Orlow.
1153
1154         [Chromium] Remove non-client-based Geolocation code
1155         https://bugs.webkit.org/show_bug.cgi?id=50921
1156
1157         * DumpRenderTree/chromium/LayoutTestController.cpp:
1158         (LayoutTestController::setGeolocationPermission):
1159         (LayoutTestController::setMockGeolocationPosition):
1160         (LayoutTestController::setMockGeolocationError):
1161         * DumpRenderTree/chromium/WebViewHost.cpp:
1162         (WebViewHost::geolocationClientMock):
1163         (WebViewHost::reset):
1164         * DumpRenderTree/chromium/WebViewHost.h:
1165
1166 2011-01-10  Eric Seidel  <eric@webkit.org>
1167
1168         Reviewed by Adam Barth.
1169
1170         Commit bot tried to land r? cq+ patch
1171         https://bugs.webkit.org/show_bug.cgi?id=36638
1172
1173         It should now be possible to post a patch with r? and cq+ and the
1174         commit-queue will correctly wait for the r+ before attempting to land the patch.
1175         (This was a feature requested by several users.)
1176
1177         One caveat: We don't actually reject r-, cq+ patches from the queue
1178         (we just ignore them), but I think that's OK for now.
1179
1180         I also noticed that setting r- once a commit-queue node had grabbed
1181         a patch would not properly cancel the landing.  That's fixed and
1182         tested in this patch.
1183
1184         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1185         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1186         * Scripts/webkitpy/tool/bot/feeders.py:
1187         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1188
1189 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1190
1191         Reviewed by Kenneth Rohde Christiansen.
1192
1193         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1194         https://bugs.webkit.org/show_bug.cgi?id=51934
1195
1196         When accessing the network from the destructor of QWebPage, the network access manager
1197         was already deleted because the object WebPage was already destructed.
1198
1199         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1200         The object is now destructed in the destructor of QObject.
1201
1202         * QtTestBrowser/webpage.cpp:
1203         (WebPage::WebPage):
1204         (WebPage::setQnamThreaded):
1205         * QtTestBrowser/webpage.h:
1206         (QtNAMThread::QtNAMThread):
1207
1208 2011-01-08  Eric Seidel  <eric@webkit.org>
1209
1210         Reviewed by Ojan Vafai.
1211
1212         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1213         https://bugs.webkit.org/show_bug.cgi?id=52067
1214
1215         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1216         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1217
1218         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1219
1220 2011-01-08  Eric Seidel  <eric@webkit.org>
1221
1222         Reviewed by Mihai Parparita.
1223
1224         commit-queue hangs when the ChangeLog diff is bad
1225         https://bugs.webkit.org/show_bug.cgi?id=52072
1226
1227         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1228         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1229
1230 2011-01-08  Adam Barth  <abarth@webkit.org>
1231
1232         Teach svn-apply how to re-write WebCore to Source/WebCore.
1233
1234         * Scripts/VCSUtils.pm:
1235
1236 2011-01-07  Adam Barth  <abarth@webkit.org>
1237
1238         Rubber-stamped by Eric Seidel.
1239
1240         Move WebCore to Source
1241         https://bugs.webkit.org/show_bug.cgi?id=52050
1242
1243         Update the tools to understand WebCore's new location.
1244
1245         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1246         * DumpRenderTree/wscript:
1247         * GNUmakefile.am:
1248         * Scripts/build-webkit:
1249         * Scripts/do-file-rename:
1250         * Scripts/do-webcore-rename:
1251         * Scripts/generate-qt-inspector-resource:
1252         * Scripts/prepare-ChangeLog:
1253         * Scripts/run-bindings-tests:
1254         * Scripts/update-iexploder-cssproperties:
1255         * Scripts/update-sources-list.py:
1256         * Scripts/update-webkit-localizable-strings:
1257         * Scripts/webkitdirs.pm:
1258         * Scripts/webkitpy/common/config/build.py:
1259         * Scripts/webkitpy/common/config/build_unittest.py:
1260         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1261         * Scripts/webkitpy/style/checker.py:
1262         * Scripts/webkitpy/style/checker_unittest.py:
1263         * WebKitTestRunner/DerivedSources.pro:
1264         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1265         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1266         * wx/browser/wscript:
1267         * wx/build/settings.py:
1268
1269 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1270
1271         Reviewed by Sam Weinig.
1272
1273         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1274         https://bugs.webkit.org/show_bug.cgi?id=52086
1275
1276         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1277         (WTR::InjectedBundle::didReceiveMessage):
1278         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1279         (WTR::LayoutTestController::notifyDone):
1280         * WebKitTestRunner/TestController.cpp:
1281         (WTR::TestController::resetStateToConsistentValues):
1282         (WTR::TestController::run):
1283
1284 2011-01-07  James Robinson  <jamesr@chromium.org>
1285
1286         Revert "Implement mozilla's animationTime property"
1287         https://bugs.webkit.org/show_bug.cgi?id=51952
1288
1289         This approach isn't quite right.
1290
1291         * DumpRenderTree/chromium/WebViewHost.cpp:
1292         (WebViewHost::paintInvalidatedRegion):
1293
1294 2011-01-07  Adam Roben  <aroben@apple.com>
1295
1296         Build master fix
1297
1298         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1299         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1300
1301 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1302
1303         Reviewed by Csaba Osztrogonác.
1304
1305         run-qtwebkit-tests should be able to kill a testsuite.
1306
1307         Add new option in the script that can setup a timeout for a test.
1308         If the test execution takes more then specified time then the test
1309         would be terminated.
1310
1311         [Qt] run-qtwebkit-tests needs timeout
1312         https://bugs.webkit.org/show_bug.cgi?id=51894
1313
1314         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1315         * Scripts/run-qtwebkit-tests:
1316
1317 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1318
1319         Unreviewed fix after r75233.
1320
1321         Based on idea from Eric Seidel.
1322
1323         Add remote zip file handling to webkitpy.
1324         https://bugs.webkit.org/show_bug.cgi?id=50901
1325
1326         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1327
1328 2011-01-07  Shane Stephens  <shanestephens@google.com>
1329
1330         Reviewed by Eric Seidel.
1331
1332         svn-apply: should support git binary delta diffs
1333         https://bugs.webkit.org/show_bug.cgi?id=38864
1334
1335         * Scripts/VCSUtils.pm:
1336         * Scripts/svn-apply:
1337
1338 2011-01-06  Julie Parent  <jparent@chromium.org>
1339
1340         Reviewed by Eric Seidel.
1341
1342         Test Result Server not removing old results.
1343         https://bugs.webkit.org/show_bug.cgi?id=52012
1344
1345         * TestResultServer/model/jsonresults.py:
1346         Fix off-by-one: Truncate if >= num_runs, not just >.
1347         * TestResultServer/model/jsonresults_unittest.py:
1348         Add unit test to test that merging in a new result with the same value
1349         as the last result causes previous result to fall off.
1350
1351 2011-01-06  James Kozianski  <koz@chromium.org>
1352
1353         Reviewed by Mihai Parparita.
1354
1355         Add classes to provide a consistent interface to a set of files.
1356         https://bugs.webkit.org/show_bug.cgi?id=50901
1357
1358         These classes allow us to write code that is agnostic to whether a
1359         particular set of files resides in a local directory or in a zip file
1360         on a remote machine.
1361
1362         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1363         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1364         * Scripts/webkitpy/common/system/fileset.py: Added.
1365         * Scripts/webkitpy/common/system/filesystem.py:
1366         * Scripts/webkitpy/common/system/filesystem_mock.py:
1367         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1368         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1369
1370 2011-01-06  Eric Seidel  <eric@webkit.org>
1371
1372         Reviewed by Adam Barth.
1373
1374         NetworkTransaction should log the url it is retrying
1375         https://bugs.webkit.org/show_bug.cgi?id=52043
1376
1377         * Scripts/webkitpy/common/net/networktransaction.py:
1378         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1379
1380 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1381
1382         Windows build fix.
1383         Import os before using it.
1384
1385         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1386
1387 2011-01-06  Eric Seidel  <eric@webkit.org>
1388
1389         Reviewed by Adam Barth.
1390
1391         StyleQueue fails to report errors when patches have many files
1392         https://bugs.webkit.org/show_bug.cgi?id=52042
1393
1394         This is one of at least two errors preventing style error reporting at the moment.
1395         When we moved to passing the list of files to check explicitly,
1396         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1397         We could change the type of the QueueStatus.message type, or we could
1398         just teach statusserver.py how to clamp values (and warn when it does).
1399         I chose the latter path.
1400
1401         * Scripts/webkitpy/common/net/statusserver.py:
1402
1403 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1404
1405         Reviewed by Stephanie Lewis.
1406         
1407         Fix syntax error in script.
1408
1409         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1410         https://bugs.webkit.org/show_bug.cgi?id=51996
1411
1412         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1413
1414 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1415
1416         Unreviewed, fixing WinCE build after r75196.
1417
1418         WinCE port does not (yet) support NPAPI.
1419
1420         * Scripts/build-webkit:
1421
1422 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1423
1424         Reviewed by Darin Adler.
1425
1426         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1427         https://bugs.webkit.org/show_bug.cgi?id=52015
1428
1429         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1430         after the platform has been detected, otherwise the script will
1431         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1432         detection.
1433
1434 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1435
1436         Reviewed by Eric Seidel.
1437
1438         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1439         https://bugs.webkit.org/show_bug.cgi?id=51346
1440
1441         * Scripts/build-webkit:
1442
1443 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1444
1445         Reviewed by Adam Roben.
1446
1447         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1448         https://bugs.webkit.org/show_bug.cgi?id=51996
1449         
1450         After the configuration directory change, we were archiving the incorrect directory for
1451         build product, so we were running tests on the wrong binaries.
1452         
1453         This change archives the correct directory, and also unarchives it into a configuration-
1454         specific directory.
1455
1456         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1457         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1458
1459 2011-01-06  Eric Seidel  <eric@webkit.org>
1460
1461         Reviewed by Mihai Parparita.
1462
1463         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1464         https://bugs.webkit.org/show_bug.cgi?id=52002
1465
1466         See an example of this here:
1467         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1468
1469         It's due to the fact that we pass around TestFailure() instance
1470         objects and yet expect them to all compare to be the same.
1471
1472         This is bad.  We should either have shared instances of these values
1473         or we should just pass around the class names.  There are already hacks
1474         in place to make TestFailure objects pass equality tests, I just added
1475         a __hash__ implementation so they can be used in sets as expected.
1476
1477         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1478         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1479
1480 2011-01-06  Evan Martin  <evan@chromium.org>
1481
1482         Reviewed by Tony Chang.
1483
1484         [gdb] handle inaccessible memory and UChar*
1485         https://bugs.webkit.org/show_bug.cgi?id=52003
1486
1487         To pretty-print a UChar*, we just grope around in the memory
1488         looking for a terminating NUL.  We need to handle the exception
1489         that can occur when we poke into an invalid location.
1490
1491         Additionally, the logic for choosing which pretty-printer would
1492         early return before hitting the point where we'd use the UChar*
1493         printer.  (Did this ever work?  How did it regress?)
1494
1495         * gdb/webkit.py:
1496
1497 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1498
1499         Reviewed by Ada Chan.
1500
1501         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1502         https://bugs.webkit.org/show_bug.cgi?id=51969
1503         
1504         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1505
1506         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1507         (WTR::InjectedBundlePage::InjectedBundlePage):
1508         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1509         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1510
1511 2011-01-06  James Robinson  <jamesr@chromium.org>
1512
1513         Reviewed by Simon Fraser.
1514
1515         Implement mozilla's animationTime property
1516         https://bugs.webkit.org/show_bug.cgi?id=51952
1517
1518         Chromium DRT support for webkitAnimationTime.
1519
1520         * DumpRenderTree/chromium/WebViewHost.cpp:
1521         (WebViewHost::paintInvalidatedRegion):
1522
1523 2011-01-06  Julie Parent  <jparent@chromium.org>
1524
1525         Reviewed by Tony Chang.
1526
1527         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1528         https://bugs.webkit.org/show_bug.cgi?id=51217
1529
1530         * TestResultServer/model/jsonresults.py:
1531         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1532         Adds missing documentation.
1533         * TestResultServer/model/jsonresults_unittest.py:
1534         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1535         Update test_merge to take a number of builds to truncate at.
1536
1537 2011-01-06  Adam Barth  <abarth@webkit.org>
1538
1539         Reviewed by Eric Seidel.
1540
1541         The EWS should log outside of the working directory
1542         https://bugs.webkit.org/show_bug.cgi?id=51986
1543
1544         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1545         script, which will actually clean the working copy back to a pristine
1546         state instead of leaving untracked directories and ignored files.
1547
1548         * Scripts/webkitpy/tool/commands/queues.py:
1549         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1550
1551 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1552
1553         Windows build fix.
1554         Back out attempted change to built-product-archive.
1555
1556         * BuildSlaveSupport/built-product-archive:
1557
1558 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1559
1560         Windows build fix.
1561         Include configuration name when unpacking a build archive.
1562
1563         Needed, since we split Windows build results into configuration-specific directories
1564         under WebKitOutputDir.
1565
1566         * BuildSlaveSupport/built-product-archive:
1567
1568 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1569
1570         Reviewed by Darin Adler.
1571
1572         Debug and Release builds on Windows clobber each other
1573         https://bugs.webkit.org/show_bug.cgi?id=49185
1574
1575         Changes the structure of WebKitBuild build products directory so we
1576         completely separate each build configuration into independent directories.
1577         
1578         Although we previously had per-configuration directories for obj, this change adds
1579         per-configuration directories for bin, lib, obj, and include. Each configuration's
1580         build products are stored within a directory inside of WebKitBuild.
1581         
1582         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1583         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1584
1585         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1586         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1587         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1588         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1589         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1590         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1591         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1592         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1593         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1594         * FindSafari/FindSafari.vcproj:
1595         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1596         * MiniBrowser/MiniBrowserPostBuild.cmd:
1597         * MiniBrowser/MiniBrowserPreBuild.cmd:
1598         * Scripts/webkitdirs.pm:
1599         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1600         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1601         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1602         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1603         * TestWebKitAPI/win/copy-resources.cmd:
1604         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1605         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1606         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1607         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1608         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1609         * WebKitTestRunner/win/InjectedBundle.vcproj:
1610         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1611         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1612         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1613         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1614         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1615         * WinLauncher/WinLauncherCommon.vsprops:
1616         * WinLauncher/WinLauncherPostBuild.cmd:
1617         * WinLauncher/WinLauncherPreBuild.cmd:
1618
1619 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1620
1621         Reviewed by Ariya Hidayat.
1622
1623         [Qt] TestNetscapePlugin doesn't link on OS X
1624         https://bugs.webkit.org/show_bug.cgi?id=51948
1625
1626         Only add a dependency on libX11 on X11 systems
1627
1628         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1629
1630 2011-01-05  Jeff Miller  <jeffm@apple.com>
1631
1632         Reviewed by Adam Roben.
1633
1634         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1635         https://bugs.webkit.org/show_bug.cgi?id=51970
1636
1637         * Scripts/webkitpy/style/checker.py:
1638         Add -readability/naming for WebKit2 C API directories.
1639
1640 2011-01-05  Eric Seidel  <eric@webkit.org>
1641
1642         Unreviewed, just fixing one more log error from my previous python patch.
1643
1644         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1645         https://bugs.webkit.org/show_bug.cgi?id=51802
1646
1647         webkit-patch failure-reason was logging about parsing errors
1648         due to my misunderstanding of how BeautifulSoup.findAll worked.
1649
1650         Fixed, and added a unit test.
1651
1652         * Scripts/webkitpy/common/net/layouttestresults.py:
1653         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1654
1655 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1656
1657         Reviewed by Kenneth Rohde Christiansen.
1658
1659         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1660         https://bugs.webkit.org/show_bug.cgi?id=51951
1661
1662         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1663         to create new window from WebKit.
1664
1665         * MiniBrowser/qt/BrowserWindow.cpp:
1666         (newPageFunction):
1667         (BrowserWindow::BrowserWindow):
1668         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1669         (BrowserWindow::newWindow):
1670         (BrowserWindow::updateUserAgentList):
1671         (BrowserWindow::showUserAgentDialog):
1672         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1673         define the type of the backing store used for new windows.
1674         * MiniBrowser/qt/main.cpp:
1675         (main):
1676
1677 2011-01-05  Eric Seidel  <eric@webkit.org>
1678
1679         Reviewed by Ojan Vafai.
1680
1681         commit-queue should report failure type when reporting flaky tests
1682         https://bugs.webkit.org/show_bug.cgi?id=51900
1683
1684         This patch was a ridiculous amount of plumbing.  In the end I like
1685         the NRWT-style TestResult class even less.  But now we're passing
1686         a list of TestResult objects from the queue to the FlakyTestReporter.
1687         Thus the FlakyTestReporter can more easily report what type of failure
1688         occurred.
1689
1690         In the process, I found that I was not alone in finding TestResult
1691         cumbersome to use.  A bunch of code was trying to create a TestResult
1692         object with default values.  However since the constructor didn't make
1693         this easy, some places were getting it wrong (including the TestResult unit test)!
1694         I've fixed the TestResult constructor to have default values for non-essential
1695         arguments.
1696
1697         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1698         * Scripts/webkitpy/common/net/layouttestresults.py:
1699         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1700         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1701         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1702         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1703         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1704         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1705         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1706         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1707         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1708         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1709         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1710         * Scripts/webkitpy/tool/commands/queues.py:
1711         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1712
1713 2011-01-05  Eric Seidel  <eric@webkit.org>
1714
1715         Unreviewed.
1716
1717         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1718         https://bugs.webkit.org/show_bug.cgi?id=51802
1719
1720         Add another unit test to cover a previously missing import.
1721
1722         * Scripts/webkitpy/common/net/layouttestresults.py:
1723         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1724
1725 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1726
1727         Reviewed by David Levin.
1728
1729         Add mihaip@chromium.org as a reviewer
1730         https://bugs.webkit.org/show_bug.cgi?id=51966
1731         
1732         Add myself as a reviewer.
1733
1734         * Scripts/webkitpy/common/config/committers.py:
1735
1736 2011-01-05  James Simonsen  <simonjam@chromium.org>
1737
1738         Unreviewed. Adding myself to the list of committers.
1739
1740         * Scripts/webkitpy/common/config/committers.py:
1741
1742 2011-01-05  Eric Seidel  <eric@webkit.org>
1743
1744         Unreviewed.
1745
1746         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1747         https://bugs.webkit.org/show_bug.cgi?id=51802
1748
1749         Fix two exceptions seen on the bots after my original commit.
1750
1751         * Scripts/webkitpy/common/net/layouttestresults.py:
1752         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1753
1754 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1755
1756         Reviewed by Andreas Kling.
1757
1758         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1759         https://bugs.webkit.org/show_bug.cgi?id=51750
1760
1761         * QtTestBrowser/main.cpp:
1762         (LauncherApplication::handleUserOptions):
1763          Local storage settings can be enable form command line arguments for
1764          QtTestBrowser.
1765
1766 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1767
1768         Reviewed by Martin Robinson.
1769
1770         GTK: AX: DRT needs to use correct root object method.
1771         https://bugs.webkit.org/show_bug.cgi?id=51911
1772
1773         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1774         (AccessibilityController::rootElement):
1775
1776 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1777
1778         Rubber-stamped by Csaba Osztrogonác.
1779
1780         Based on idea from Péter Gál.
1781
1782         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1783
1784 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1785
1786         Reviewed by Adam Barth.
1787
1788         sheriff-bot should be able to do multi-revision rollouts
1789         https://bugs.webkit.org/show_bug.cgi?id=51176
1790
1791         * Scripts/webkitpy/tool/bot/irc_command.py:
1792         * Scripts/webkitpy/tool/bot/sheriff.py:
1793         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1794
1795 2011-01-05  Eric Seidel  <eric@webkit.org>
1796
1797         Reviewed by Adam Barth.
1798
1799         queues.webkit.org should have per-bot status pages
1800         https://bugs.webkit.org/show_bug.cgi?id=51906
1801
1802         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1803         statuses from a single queue.  Now that we have many bots servicing
1804         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1805         you care about scroll off the end of the 15-message limit on the main page.
1806
1807         Eventually we should probably rename /queue-status to /queue or /queues,
1808         but that's fodder for another patch.
1809
1810         * QueueStatusServer/handlers/queuestatus.py:
1811         * QueueStatusServer/index.yaml:
1812         * QueueStatusServer/main.py:
1813         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1814          - This probably should use a custom filter instead of hard-coding
1815            the URL scheme here, but I couldn't figure out how to easily
1816            create such a filter.  Most filters work with "strings" so we can't
1817            pass the status object.  We could add a method to the status
1818            object and call that, but that seemed a bit strange too.
1819         * QueueStatusServer/templates/queuestatus.html:
1820
1821 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1822
1823         Unreviewed. Adding myself to the list of committers.
1824
1825         * Scripts/webkitpy/common/config/committers.py:
1826
1827 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1828
1829         Reviewed by David Levin.
1830
1831         check-webkit-style treated some macros with parentheses after #elif as function calls
1832         https://bugs.webkit.org/show_bug.cgi?id=51695
1833
1834         Ingore function call space checking in any preprocessor directives
1835         (things starting with #). Change search() to match() because 
1836         preprocessor directives are supposed to be in the beginning of lines.
1837
1838         * Scripts/webkitpy/style/checkers/cpp.py:
1839         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1840
1841 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1842
1843         Reviewed by Tony Chang.
1844
1845         Change the --multi-load test option to --stress-opt
1846         https://bugs.webkit.org/show_bug.cgi?id=50751
1847
1848         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1849         (runTest):
1850         (main):
1851         * DumpRenderTree/chromium/TestShell.cpp:
1852         (TestShell::TestShell):
1853         * DumpRenderTree/chromium/TestShell.h:
1854         (TestShell::stressOpt):
1855         (TestShell::setStressOpt):
1856         (TestShell::stressDeopt):
1857         (TestShell::setStressDeopt):
1858         (TestShell::javaScriptFlags):
1859         (TestShell::setJavaScriptFlags):
1860         * Scripts/webkitpy/layout_tests/port/chromium.py:
1861         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1862
1863 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1864
1865         Reviewed by Sam Weinig.
1866
1867         WK2: Support Accessibility
1868         https://bugs.webkit.org/show_bug.cgi?id=51859
1869
1870         Use rootObject() method to get top of accessibility tree.
1871
1872         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1873         (AccessibilityController::focusedElement):
1874         (AccessibilityController::rootElement):
1875
1876 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1877
1878         Reviewed by Darin Adler.
1879
1880         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1881         https://bugs.webkit.org/show_bug.cgi?id=51846
1882
1883         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1884         back to GRefPtr.
1885
1886 2011-01-04  Zhe Su  <suzhe@chromium.org>
1887
1888         Reviewed by Kenneth Russell.
1889
1890         Fix insertText, setMarkedText and unmarkText methods of
1891         TextInputController to call corresponding methods of WebKit::WebView
1892         rather than WebKit::WebFrame. This change matches the behavior of
1893         chromium browser.
1894         insertText corresponds to WebView::confirmComposition(text)
1895         setMarkedText corresponds to WebView::setComposition(...)
1896         unmarkText corresponds to WebView::confirmComposition()
1897         https://bugs.webkit.org/show_bug.cgi?id=51693
1898
1899         * DumpRenderTree/chromium/TextInputController.cpp:
1900         (TextInputController::insertText):
1901         (TextInputController::setMarkedText):
1902         (TextInputController::unmarkText):
1903
1904 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1905
1906         Reviewed by Laszlo Gombos.
1907
1908         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1909
1910         On Symbian productDir points to the source directory. Removing all the
1911         empty files from the productDir directory corrupts the svn repository.
1912
1913         * Scripts/build-webkit:
1914
1915 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1916
1917         Reviewed by Adam Barth.
1918
1919         [Qt] Add SelectAll option to the context menu for the editor
1920         https://bugs.webkit.org/show_bug.cgi?id=50049
1921
1922         Set shortcut for the SelectAll action.
1923
1924         * QtTestBrowser/mainwindow.cpp:
1925         (MainWindow::buildUI):
1926
1927 2011-01-03  David Levin  <levin@chromium.org>
1928
1929         Reviewed by Eric Seidel.
1930
1931         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1932         https://bugs.webkit.org/show_bug.cgi?id=51842
1933
1934         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1935         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1936
1937 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1938
1939         Reviewed by David Kilzer.
1940
1941         [WINCE] Adds a build slave.
1942         https://bugs.webkit.org/show_bug.cgi?id=50523
1943
1944         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1945         entry for a release build of the WinCE port.
1946         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1947         flag to build the WinCE port.
1948
1949 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1950
1951         Reviewed by David Kilzer.
1952
1953         Add WinCE support to build-webkit
1954         https://bugs.webkit.org/show_bug.cgi?id=51642
1955
1956         * Scripts/build-webkit:
1957         * Scripts/webkitdirs.pm:
1958
1959 2011-01-03  Eric Seidel  <eric@webkit.org>
1960
1961         Reviewed by Adam Barth.
1962
1963         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1964         https://bugs.webkit.org/show_bug.cgi?id=51802
1965
1966         I'm not the biggest fan of the test_failures or test_results classes,
1967         but it's better to have one shared set of classes, than separate ones
1968         for new vs. old run-webkit-test result handling.
1969
1970         This moves the ORWT results class "LayoutTestResults" over to using
1971         TestResult and TestFailure classes, making it easy for us to
1972         make all our sheriff-bot and other webkitpy code NRWT ready.
1973
1974         This also makes it a trivial patch to generate results.json information
1975         from ORWT results.html files (for flaky test analysis, etc.) as well
1976         as making it a one-liner to report test failure types when the
1977         commit-queue sees flaky tests.
1978
1979         This patch tried not to add new functionality, but only to replace
1980         the guts of LayoutTestResults, while adding unit tests and hoping
1981         not to break anything.
1982
1983         I also moved callers which assumed User.prompt* were static/class methods
1984         to using them as instance methods (since we'll eventually want to make them such).
1985
1986         In the process of re-writing things, I broke the rebaseline command, so I wrote
1987         a unit test to catch my breakage were I do do so again in the future.
1988
1989         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1990         * Scripts/webkitpy/common/net/layouttestresults.py:
1991         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1992         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1993         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1994         * Scripts/webkitpy/tool/commands/queries.py:
1995         * Scripts/webkitpy/tool/commands/rebaseline.py:
1996         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1997         * Scripts/webkitpy/tool/mocktool.py:
1998
1999 2011-01-03  Adam Barth  <abarth@webkit.org>
2000
2001         Reviewed by Simon Fraser.
2002
2003         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2004         https://bugs.webkit.org/show_bug.cgi?id=51840
2005
2006         * Scripts/webkitpy/common/checkout/scm.py:
2007
2008 2011-01-03  Adam Barth  <abarth@webkit.org>
2009
2010         Reviewed by Simon Fraser.
2011
2012         webkit-patch should only hide update output if --quiet
2013         https://bugs.webkit.org/show_bug.cgi?id=51838
2014
2015         As requested by smfr.
2016
2017         * Scripts/webkitpy/tool/steps/update.py:
2018
2019 2011-01-03  Adam Barth  <abarth@webkit.org>
2020
2021         Reviewed by David Levin.
2022
2023         commit-queue shouldn't reject patches twice if two bots process the same patch
2024         https://bugs.webkit.org/show_bug.cgi?id=51805
2025
2026         Before raising an error, we first check whether the patch is still in
2027         the commit-queue.  This check is still racy, of course, but the time
2028         window is much smaller.
2029
2030         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2031
2032 2011-01-03  Sam Weinig  <sam@webkit.org>
2033
2034         Reviewed by Anders Carlsson.
2035
2036         Make run-api-tests less chatty.
2037         https://bugs.webkit.org/show_bug.cgi?id=51831
2038
2039         - Make script quiet by default and add --verbose option (replacing --quiet).
2040         - When not verbose, pipe stdout and stderr to devnull.
2041
2042         * Scripts/run-api-tests:
2043
2044 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2045
2046         Unreviewed. Adding myself to committers.py.
2047
2048         * Scripts/webkitpy/common/config/committers.py:
2049
2050 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2051
2052         Reviewed by Xan Lopez.
2053
2054         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2055         https://bugs.webkit.org/show_bug.cgi?id=51806
2056
2057         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2058         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2059         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2060         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2061         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2062         so make it 'WebKitBuild/Release/.libs'
2063
2064         * Scripts/webkitdirs.pm: 
2065
2066 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2067
2068         Reviewed by Adam Barth.
2069
2070         Make EFL a core builder
2071         https://bugs.webkit.org/show_bug.cgi?id=51804
2072
2073         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2074         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2075
2076 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2077
2078         [Qt] Unreviewed fix after r74855 and r74875.
2079
2080         * BuildSlaveSupport/built-product-archive:
2081          - Create directories explicitly.
2082          - Pass shell=True to subprocess.call().
2083
2084 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2085
2086         [Qt] Unreviewed fix after r74855.
2087
2088         Move JavaScriptCore to Source
2089         https://bugs.webkit.org/show_bug.cgi?id=51604
2090
2091         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2092
2093 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2094
2095         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2096
2097         Move JavaScriptCore to Source
2098         https://bugs.webkit.org/show_bug.cgi?id=51604
2099
2100         * Scripts/webkitdirs.pm:
2101
2102 2011-01-02  Robert Hogan  <robert@webkit.org>
2103
2104         Unreviewed, build fix.
2105
2106         [Qt] Fix DRT build after 74855
2107
2108         * DumpRenderTree/qt/DumpRenderTree.pro:
2109
2110 2011-01-01  Adam Barth  <abarth@webkit.org>
2111
2112         Remove the assumption from the Qt and Gtk builds that every project is
2113         in the root directory.
2114
2115         * Scripts/build-webkit:
2116
2117 2011-01-01  Adam Barth  <abarth@webkit.org>
2118
2119         Reviewed by Eric Seidel.
2120
2121         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2122         https://bugs.webkit.org/show_bug.cgi?id=51796
2123
2124         After this change, svn-apply will magically apply patches to
2125         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2126
2127         * Scripts/VCSUtils.pm:
2128
2129 2011-01-01  Adam Barth  <abarth@webkit.org>
2130
2131         Reviewed by Eric Seidel.
2132
2133         Move JavaScriptCore to Source
2134         https://bugs.webkit.org/show_bug.cgi?id=51604
2135
2136         Update references to JavaScriptCore to point to the new location.
2137
2138         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2139         * DumpRenderTree/qt/DumpRenderTree.pro:
2140         * DumpRenderTree/qt/ImageDiff.pro:
2141         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2142         * DumpRenderTree/wscript:
2143         * Scripts/build-jsc:
2144         * Scripts/build-webkit:
2145         * Scripts/do-file-rename:
2146         * Scripts/do-webcore-rename:
2147         * Scripts/run-javascriptcore-tests:
2148         * Scripts/update-javascriptcore-test-results:
2149         * Scripts/webkitdirs.pm:
2150         * Scripts/webkitpy/common/config/build_unittest.py:
2151         * Scripts/webkitpy/style/checker.py:
2152         * Scripts/webkitpy/style/checker_unittest.py:
2153         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2154         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2155         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2156         * wx/build/settings.py:
2157
2158 2011-01-01  Adam Barth  <abarth@webkit.org>
2159
2160         Reviewed by Eric Seidel.
2161
2162         Move Sources to Source
2163         https://bugs.webkit.org/show_bug.cgi?id=51794
2164
2165         Update scripts to point to the new location.
2166
2167         * Scripts/build-webkit:
2168         * Scripts/do-file-rename:
2169         * Scripts/do-webcore-rename:
2170         * Scripts/webkitpy/common/config/build.py:
2171         * Scripts/webkitpy/common/config/build_unittest.py:
2172
2173 2010-12-31  Kent Tamura  <tkent@chromium.org>
2174
2175         Reviewed by Eric Seidel.
2176
2177         [DRT/Chromium] Enable mock spell checker on non-OSX
2178         https://bugs.webkit.org/show_bug.cgi?id=51401
2179
2180         * DumpRenderTree/chromium/WebViewHost.cpp:
2181         (WebViewHost::spellCheck):
2182
2183 2010-12-31  Adam Barth  <abarth@webkit.org>
2184
2185         Reviewed by Ariya Hidayat.
2186
2187         Remove Tools/Scripts/wkstyle
2188         https://bugs.webkit.org/show_bug.cgi?id=51774
2189
2190         This script appears to not have been touched in a while and seems to
2191         have been replaced by check-webkit-style.
2192
2193         * Scripts/wkstyle: Removed.
2194
2195 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2196
2197         Unreviewed. Coding style fix.
2198
2199         * DumpRenderTree/chromium/TestShell.h:
2200
2201 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2202
2203         Reviewed by Pavel Feldman.
2204
2205         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2206
2207         It was a problem with Chromium DRT. DevToolsAgent object instance was
2208         attached not only to the inspected page but to the DevTools window too.
2209         As result all the inspector files were interpreted as a content of inspected page
2210         and were transfered to the DevTools scripts panel for debugging etc.
2211
2212         https://bugs.webkit.org/show_bug.cgi?id=51735
2213
2214         * DumpRenderTree/chromium/TestShell.cpp:
2215         (TestShell::TestShell):
2216         (TestShell::bindJSObjectsToWindow):
2217         (TestShell::createNewWindow):
2218         * DumpRenderTree/chromium/TestShell.h:
2219
2220 2010-12-31  Adam Barth  <abarth@webkit.org>
2221
2222         Rubber-stamped by Eric Seidel.
2223
2224         Move PageLoadTests to PerformanceTests/PageLoad
2225         https://bugs.webkit.org/show_bug.cgi?id=51771
2226
2227         Update references to PageLoadTests to point to the new location.
2228
2229         * Scripts/run-pageloadtest:
2230         * Scripts/webkitpy/common/config/build.py:
2231
2232 2010-12-31  Adam Barth  <abarth@webkit.org>
2233
2234         Rubber-stamped by Eric Seidel.
2235
2236         Move SunSpider into PerformanceTests
2237         https://bugs.webkit.org/show_bug.cgi?id=51769
2238
2239         Update these scripts to point to the new location.
2240
2241         * Scripts/run-sunspider:
2242         * Scripts/sunspider-compare-results:
2243
2244 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2245
2246         Reviewed by Kent Tamura.
2247
2248         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2249         https://bugs.webkit.org/show_bug.cgi?id=51728
2250         
2251         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2252         to render top-level scrollbars. This makes them match the Mac port's
2253         use of an NSScrollView, which means that we'll be able to share more
2254         pixel baselines.
2255         
2256         The new rendering code will not be activated until the 
2257         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2258         ScrollbarThemeChromiumMac.
2259
2260         * DumpRenderTree/DumpRenderTree.gypi:
2261         * DumpRenderTree/chromium/TestShellMac.mm:
2262         (platformInit):
2263         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2264         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2265         (+[FakeActiveWindow alwaysActiveWindow]):
2266         (+[FakeActiveWindow alwaysInactiveWindow]):
2267         (-[FakeActiveWindow initWithActiveControls:]):
2268         (-[FakeActiveWindow _hasActiveControls]):
2269         (WebThemeEngineDRTMac::paintScrollbarThumb):
2270         (stateToHIEnableState):
2271         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2272         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2273
2274 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2275
2276         Reviewed by David Kilzer.
2277
2278         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2279         used
2280         https://bugs.webkit.org/show_bug.cgi?id=51672
2281
2282         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2283         with USE_SYSTEM_MALLOC=1
2284         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2285         with USE_SYSTEM_MALLOC=1
2286
2287 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2288
2289         Reviewed by David Kilzer.
2290
2291         [Qt] [Symbian] Fix build-webkit script for Symbian
2292         https://bugs.webkit.org/show_bug.cgi?id=51509
2293
2294         Set the OUTPUT_DIR for Symbian to be the same as the source
2295         directory.
2296
2297         * Scripts/webkitdirs.pm:
2298
2299 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2300
2301         Reviewed by Darin Adler.
2302
2303         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2304         https://bugs.webkit.org/show_bug.cgi?id=51758
2305
2306         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2307
2308         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2309         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2310
2311 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2312
2313         Unreviewed WinCE buildfix.
2314
2315         * WinCELauncher/main.cpp: Add missing include.
2316
2317 2010-12-29  Daniel Bates  <dbates@rim.com>
2318
2319         Reviewed by Darin Adler.
2320
2321         svn-apply updates date of wrong change log entry for a change log diff that
2322         contains two consecutive entries with the same author and date
2323         https://bugs.webkit.org/show_bug.cgi?id=46061
2324
2325         Fixes an issue where the date of the wrong change log entry may be modified.
2326         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2327         in a ChangeLog file to the top of the file.
2328
2329         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2330         diff when it detects that the diff inserts a change log entry earlier in a
2331         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2332         change. With the advent of the commit-queue this functionality of bailing out
2333         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2334         Instead, we should always move the change log entry to the top of the ChangeLog file.
2335
2336         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2337         the date line of the correct change log entry in a ChangeLog diff.
2338
2339         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2340
2341         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2342           Updated the following unit tests now that we move entries inserted earlier to the top:
2343           - "fixChangeLogPatch: New entry inserted in middle."
2344             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2345
2346           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2347             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2348
2349         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2350
2351 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2352
2353         Reviewed by Eric Seidel.
2354
2355         [Qt] Fixed compatibility with gold linker on X11 platforms
2356         https://bugs.webkit.org/show_bug.cgi?id=51700
2357
2358         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2359         Linked TestNetscapePlugin with libX11 on Unix platforms
2360
2361 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2362
2363         Reviewed by Darin Adler.
2364
2365         Circular dependency in webkitpy.common.checkout.changelog module
2366         https://bugs.webkit.org/show_bug.cgi?id=50475
2367
2368         Remove automatic import of api.Checkout module when any checkout/
2369         submodule is imported (e.g.: when checkout.scm.Git is imported).
2370
2371         * Scripts/webkitpy/common/checkout/__init__.py:
2372
2373 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2374
2375         Reviewed by Ojan Vafai.
2376
2377         prepare-ChangeLog should support the -g option for specifying the git-commit
2378         https://bugs.webkit.org/show_bug.cgi?id=51708
2379
2380         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2381         webkit-patch, though the exact meaning of the two options remain different.
2382
2383         * Scripts/prepare-ChangeLog: Add -g.
2384
2385 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2386
2387         Reviewed by Simon Hausmann.
2388
2389         [Qt] Fix compilation with Qt in namespace
2390         https://bugs.webkit.org/show_bug.cgi?id=51701
2391
2392         * QtTestBrowser/webview.h:
2393
2394 2010-12-28  Daniel Bates  <dbates@rim.com>
2395
2396         Reviewed by Sam Weinig.
2397
2398         Substitute // MARK: for compiler-specific #pragma mark
2399         https://bugs.webkit.org/show_bug.cgi?id=51657
2400
2401         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2402         substituting  "// MARK:" for "#pragma mark", which provides
2403         analogous code-bookmarking functionality under Xcode.
2404
2405         Also, for consistency, we should substitute "// MARK:" for compiler-
2406         specific "#pragma mark" in the source files for the Mac port.
2407
2408         * DumpRenderTree/AccessibilityTextMarker.cpp:
2409         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2410         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2411         * DumpRenderTree/mac/ObjCController.m:
2412         * MiniBrowser/mac/AppDelegate.m:
2413         * MiniBrowser/mac/BrowserWindowController.m:
2414
2415 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2416
2417         Reviewed by Eric Seidel.
2418
2419         Add --no-build option to run-sunspider
2420         https://bugs.webkit.org/show_bug.cgi?id=51658
2421
2422         * Scripts/run-sunspider: add --no-build flag to skip building
2423         phase.
2424
2425 2010-12-27  Daniel Bates  <dbates@rim.com>
2426
2427         Rubber-stamped by Martin Robinson.
2428
2429         Append the directory Tools/DumpRenderTree to the list of directories that
2430         do-webcore-rename should search so that it can rename DRT files and
2431         source code.
2432
2433         * Scripts/do-webcore-rename:
2434
2435 2010-12-27  Eric Seidel  <eric@webkit.org>
2436
2437         Reviewed by Adam Barth.
2438
2439         build-webkit should detect missing Java SDK and explain how to install it
2440         https://bugs.webkit.org/show_bug.cgi?id=51651
2441
2442         * Scripts/build-webkit:
2443
2444 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2445
2446         Reviewed by Daniel Bates.
2447
2448         [GTK] Add support for build-jsc
2449         https://bugs.webkit.org/show_bug.cgi?id=51625
2450
2451         Add GTK+ support to build-jsc now that building the jsc executable as
2452         a standalone target is easy.
2453
2454         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2455         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2456         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2457         and pass it along to buildAutotoolsProject.
2458
2459 2010-12-27  David Levin  <levin@chromium.org>
2460
2461         Reviewed by Eric Seidel.
2462
2463         check-webkit-style check for meaningless variable names in function declarations.
2464         https://bugs.webkit.org/show_bug.cgi?id=51523
2465
2466         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2467         from the new check and whitespace/parens because the syntax is unusual and
2468         produced a fair number of positives for these checks.
2469         * Scripts/webkitpy/style/checkers/cpp.py:
2470         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2471         and parameter names when determining if the parameter name is useless.
2472         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2473         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2474         format.
2475         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2476         text or an acronym of it.
2477         (check_function_definition): Checks function definitions for meaningless variable names.
2478         (process_line): Added call to check_function_definition.
2479         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2480         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2481         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2482         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2483         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2484         because when only checking a snippet, there are a lot of bogus functions.
2485         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2486         that I put there previously and just noticed.
2487         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2488         check_function_definition and process_line.
2489
2490 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2491
2492         Reviewed by Martin Robinson.
2493
2494         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2495         https://bugs.webkit.org/show_bug.cgi?id=51591
2496
2497         Flash plugin uses gtk2 that is incompatible with gtk3 making
2498         webkit crash when it's built with gtk3.
2499
2500         * GtkLauncher/main.c:
2501         (main):
2502
2503 2010-12-25  Adam Barth  <abarth@webkit.org>
2504
2505         Reviewed by Eric Seidel.
2506
2507         Move ANGLE to Sources/ThirdParty
2508         https://bugs.webkit.org/show_bug.cgi?id=51605
2509
2510         * Scripts/build-webkit:
2511           - Point to the new ANGLE location.
2512
2513 2010-12-26  David Levin  <levin@chromium.org>
2514
2515         Reviewed by Eric Seidel.
2516
2517         check-webkit-style should be able to parse function declaration parameters.
2518         https://bugs.webkit.org/show_bug.cgi?id=51451
2519
2520         * Scripts/webkitpy/style/checkers/cpp.py:
2521         (Position.__init__): Holds simple position information (row, column).
2522         (Parameter.__init__): Holds information about a parameter.
2523         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2524         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2525         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2526         (find_parameter_name_index): Finds where the parameter name is.
2527         (parameter_list): Generates the list of parameters for a function.
2528         (_FunctionState.begin): Added information to allow determining the parameters
2529         on demand.
2530         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2531         (detect_functions): Improve function detection for operator functions and
2532         determine where the parameters end and pass that to _FunctionState.begin.
2533         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2534         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2535         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2536         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2537         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2538         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2539         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2540         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2541         the parameters found.
2542         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2543         detection test to verify that we catch the operator functions.
2544         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2545         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2546         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2547         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2548         test_function_length_check_definition_severity1_for_test.
2549
2550 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2551
2552         Unreviewed WinCE buildfix after r74334.
2553
2554         * CMakeListsWinCE.txt:
2555
2556 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2557
2558         Unreviewed, rolling out r74632.
2559         http://trac.webkit.org/changeset/74632
2560         https://bugs.webkit.org/show_bug.cgi?id=51600
2561
2562         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2563         on #webkit).
2564
2565         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2566         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2567
2568 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2569
2570         Reviewed by Kenneth Rohde Christiansen.
2571
2572         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2573         https://bugs.webkit.org/show_bug.cgi?id=43528
2574
2575         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2576         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2577         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2578         called.
2579
2580         * EWebLauncher/main.c:
2581         (browserCreate):
2582
2583 2010-12-24  Eric Seidel  <eric@webkit.org>
2584
2585         Reviewed by Adam Barth.
2586
2587         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2588         https://bugs.webkit.org/show_bug.cgi?id=28291
2589
2590         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2591         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2592         to strings with find in the diff.
2593         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2594
2595         * Scripts/webkitpy/common/checkout/api.py:
2596         * Scripts/webkitpy/common/checkout/diff_parser.py:
2597         * Scripts/webkitpy/tool/steps/abstractstep.py:
2598         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2599         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2600         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2601         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2602
2603 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2604
2605         Reviewed by Kenneth Russell.
2606
2607         Modify new-run-webkit-tests to shut up and exit when all the threads
2608         are wedged so that test runs complete faster and we don't end up
2609         w/ enormous log files.
2610
2611         https://bugs.webkit.org/show_bug.cgi?id=51572
2612
2613         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2614         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2615
2616 2010-12-24  Eric Seidel  <eric@webkit.org>
2617
2618         Reviewed by David Levin.
2619
2620         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2621         https://bugs.webkit.org/show_bug.cgi?id=51549
2622
2623         I've had multiple people ask me about the commit-queue's behavior
2624         regarding reporting flaky tests.  I figured it would be best to just
2625         have the queue explain itself in the bugs it files.
2626
2627         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2628         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2629
2630 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2631
2632         Reviewed by Eric Seidel.
2633
2634         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2635         https://bugs.webkit.org/show_bug.cgi?id=51467
2636
2637         * Scripts/webkitpy/style/checker.py:
2638         * Scripts/webkitpy/style/checker_unittest.py:
2639
2640 2010-12-23  Adam Barth  <abarth@webkit.org>
2641
2642         Rubber-stamped by Eric Seidel.
2643
2644         Move JavaScriptGlue into Sources
2645         https://bugs.webkit.org/show_bug.cgi?id=51583
2646
2647         These tools refer to JavaScriptGlue and need to be updated to its new
2648         location.
2649
2650         * Scripts/build-webkit:
2651         * Scripts/do-file-rename:
2652         * Scripts/do-webcore-rename:
2653         * Scripts/webkitpy/common/config/build.py:
2654         * Scripts/webkitpy/common/config/build_unittest.py:
2655
2656 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2657
2658         Reviewed by Eric Seidel.
2659
2660         Bug 51539 - update iexploder scripts to point to new location
2661
2662         * Scripts/run-iexploder-tests:
2663         * Scripts/update-iexploder-cssproperties:
2664
2665 2010-12-23  Evan Martin  <evan@chromium.org>
2666
2667         Reviewed by Ryosuke Niwa.
2668
2669         [chromium] LayoutTestController warning in float->int conversion
2670         https://bugs.webkit.org/show_bug.cgi?id=51553
2671
2672         Rather than reading an int, converting to a float, then getting a compiler
2673         warning on passing the float to something that expects an int, instead
2674         just pass around ints.
2675
2676         No tests, fixes a compiler warning.
2677
2678         * DumpRenderTree/chromium/LayoutTestController.cpp:
2679         (parsePageSizeParameters):
2680         (LayoutTestController::pageNumberForElementById):
2681         (LayoutTestController::numberOfPages):
2682
2683 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2684
2685         Reviewed by Darin Adler.
2686
2687         Bug 51537 - iexploder needs cleanup
2688         
2689         * iExploder/htdocs: Removed.
2690         * iExploder/htdocs/config.rb: Removed.
2691         * iExploder/htdocs/cssproperties.in: Removed.
2692         * iExploder/htdocs/cssvalues.in: Removed.
2693         * iExploder/htdocs/htmlattrs.in: Removed.
2694         * iExploder/htdocs/htmltags.in: Removed.
2695         * iExploder/htdocs/htmlvalues.in: Removed.
2696         * iExploder/htdocs/iexploder.cgi: Removed.
2697         * iExploder/htdocs/iexploder.rb: Removed.
2698         * iExploder/htdocs/index.html: Removed.
2699         * iExploder/htdocs/webserver.rb: Removed.
2700         * iExploder/iexploder-1.7.2/output: Removed.
2701         * iExploder/tools: Removed.
2702         * iExploder/tools/lasthit.rb: Removed.
2703         * iExploder/tools/osx_last_crash.rb: Removed.
2704         * iExploder/tools/showtest.rb: Removed.
2705
2706 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2707
2708         Reviewed by Kenneth Rohde Christiansen.
2709
2710         [EFL] Make 'single' the default backing store in EWebLauncher
2711         https://bugs.webkit.org/show_bug.cgi?id=51534
2712
2713         'single' is the simplest backing store and the one intended to be the
2714         default in the test browser. By mistake the tiled backing store was
2715         left as default in r72617.
2716
2717         * EWebLauncher/main.c:
2718         (browserCreate): ditto.
2719
2720 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2721
2722         Reviewed by Kenneth Rohde Christiansen.
2723
2724         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2725         https://bugs.webkit.org/show_bug.cgi?id=51533
2726
2727         There's no point in concatenating env("HOME") with "blah", so remove
2728         option from EWebLauncher.
2729
2730         * EWebLauncher/main.c:
2731         (main): ditto.
2732
2733 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2734
2735         Reviewed by Eric Seidel.
2736
2737         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2738
2739         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2740         I just discovered that we have two additional GC runs per each WebViewHost.
2741         Test_shell had no such calls.
2742         These gc runs eat 15% of cpu time.
2743
2744         https://bugs.webkit.org/show_bug.cgi?id=51479
2745
2746         * DumpRenderTree/chromium/WebViewHost.cpp:
2747         (WebViewHost::~WebViewHost):
2748
2749 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2750
2751         Reviewed by Ojan Vafai.
2752
2753         This change splits out the TestRunner class into its own file.
2754         When we fork the code for message passing, we will create a new
2755         TestRunner, and this change will allow that to be more modular.
2756
2757         While we're at it, split out TestInput and ResultSummary into
2758         their own files, to reduce the size of run_webkit_tests to
2759         something more managable.
2760
2761         https://bugs.webkit.org/show_bug.cgi?id=51092
2762
2763         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2764         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2765         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2766         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2767         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2768         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2769         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2770
2771  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2772
2773         Reviewed by Ojan Vafai.
2774
2775         nrwt multiprocessing - start over, prepare to fork the code
2776  
2777         This code cleans up the signatures and implementation of the
2778         TestRunner class so we can easily fork it to run either the
2779         stable implementation or the new, unstable message-passing
2780         implementation. The two variants will have different
2781         implementations of the run_tests() method. We will switch
2782         between the two based on the setting for the '--worker-model'
2783         switch. We rename the two currently valid values to 'old-inline'
2784         and 'old-threads'.
2785
2786         https://bugs.webkit.org/show_bug.cgi?id=51081
2787
2788         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2789         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2790
2791 2010-12-22  Victor Wang  <victorw@chromium.org>
2792
2793         Reviewed by Darin Fisher.
2794
2795         [Chromium] Update chromium archive test result url in rebaseline script.
2796
2797         https://bugs.webkit.org/show_bug.cgi?id=51503
2798
2799         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2800
2801 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2802
2803         Reviewed by Alice Liu.
2804
2805         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2806         Verified on Chrome, Safari, and IE.
2807         With this change, we will record memory from a parent browser window and all child processes.
2808
2809         * record-memory-win/main.cpp:
2810         (ProcessArgs):
2811         (PrintUsage):
2812         (getMemoryInfo):
2813         (printProcessInfo):
2814         (evalProcesses):
2815         (UseImage):
2816         (QueryContinuously):
2817         (ElapsedTime):
2818
2819 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2820
2821         Unreviewed rollout r74489, because it was missing changelog.
2822
2823         * record-memory-win/main.cpp:
2824         
2825 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2826
2827         Adding myself as a reviewer.
2828
2829         * Scripts/webkitpy/common/config/committers.py:
2830
2831 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2832
2833         Unreviewed.  Adding myself to committers.py.
2834
2835         * Scripts/webkitpy/common/config/committers.py:
2836
2837 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2838
2839         Reviewed by Kenneth Rohde Christiansen.
2840
2841         TestNetscapePlugIn should use #if defined
2842         https://bugs.webkit.org/show_bug.cgi?id=51471
2843
2844         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2845         (NP_Initialize):
2846         (NPP_New):
2847
2848 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2849
2850         Reviewed by Yury Semikhatsky.
2851
2852         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2853
2854         DevTools window should be closed explicitly because it has custom deinitialization code.
2855
2856         https://bugs.webkit.org/show_bug.cgi?id=50722
2857
2858         * DumpRenderTree/chromium/TestShell.cpp:
2859         (TestShell::closeRemainingWindows):
2860
2861 2010-12-22  David Levin  <levin@chromium.org>
2862
2863         Reviewed by Shinichiro Hamaji.
2864
2865         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2866         https://bugs.webkit.org/show_bug.cgi?id=51452
2867
2868         * Scripts/webkitpy/style/checkers/cpp.py:
2869         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2870         Using the file extension if possible but falling back to the file contents if we have a header file.
2871         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2872         (_FileState.is_c_or_objective_c):
2873         (check_using_std): Changed to using _FileState to determine the file type.
2874         (check_max_min_macros): Ditto.
2875         (check_for_null): Ditto.
2876         (check_style): Changed the parameters to various calls since they now need _FileState
2877         to determine the file type.
2878         (check_language): Added the file_state parameter so it could be passed
2879         to check_identifier_name_in_declaration.
2880         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2881         this is an Objective C file.
2882         (_process_lines): Added information for the _FileState constructor (and moved the
2883         call to a place that had the information).
2884         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2885         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2886         its functionality.
2887         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2888
2889 2010-12-21  Andy Estes  <aestes@apple.com>
2890
2891         Reviewed by Mark Rowe.
2892
2893         Do not build non-Intel architectures for WebKit2-related projects.
2894         https://bugs.webkit.org/show_bug.cgi?id=51440
2895
2896         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2897         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2898         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2899
2900 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2901
2902         Reviewed by Darin Fisher.
2903
2904         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2905         https://bugs.webkit.org/show_bug.cgi?id=51406 
2906         
2907         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2908         to WebThemeEngineDRTWin and update references everywhere.
2909
2910         * DumpRenderTree/DumpRenderTree.gypi:
2911         * DumpRenderTree/chromium/TestShellWin.cpp:
2912         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2913         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2914         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2915         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2916
2917 2010-12-21  Anders Carlsson  <andersca@apple.com>
2918
2919         Reviewed by John Sullivan.
2920
2921         Clicking missing plug-in text does not show a sheet
2922         https://bugs.webkit.org/show_bug.cgi?id=51403
2923
2924         Update for changes to the WebPageUIClient.
2925
2926         * MiniBrowser/mac/BrowserWindowController.m:
2927         (-[BrowserWindowController awakeFromNib]):
2928         * WebKitTestRunner/TestController.cpp:
2929         (WTR::createOtherPage):
2930         (WTR::TestController::initialize):
2931
2932 2010-12-21  Eric Seidel  <eric@webkit.org>
2933
2934         Reviewed by Adam Barth.
2935
2936         commit-queue will report constant failures as flaky if other tests flake
2937         https://bugs.webkit.org/show_bug.cgi?id=51272
2938
2939         This patch just removes functionality and adds testing.
2940         Previously we attempted to report flaky tests when we had
2941         two different tests fail in a row.  However, since we stop
2942         running the tests at the first failure, our code was wrong in
2943         trying to determine flakiness from the incomplete runs.
2944
2945         Originally I posted an alternate patch:
2946         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2947         which fixed our flaky logic in this case, however it was decided
2948         that that patch would be too difficult to maintain, so now
2949         I'm just removing the broken logic.
2950
2951         This will dramatically cut-down on our flaky-test false positives
2952         at the (small) cost of the queues being unable to report
2953         any flakiness if the tree is very flaky.  (With at least one test
2954         flaking on every run, we'll never report failures anymore.)  I think
2955         this is a tradeoff worth making.
2956
2957         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2958         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2959
2960 2010-12-20  Eric Seidel  <eric@webkit.org>
2961
2962         Reviewed by Adam Barth.
2963
2964         commit-queue wrongly rejects patches when it can't update itself
2965         https://bugs.webkit.org/show_bug.cgi?id=46636
2966
2967         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2968         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2969         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2970
2971 2010-12-20  Adam Barth  <abarth@webkit.org>
2972
2973         Move web sites to Websites directory
2974         https://bugs.webkit.org/show_bug.cgi?id=51323
2975
2976         Update references to BugsSite to point to the new location.
2977
2978         This patch was never officially reviewed (because it was too large to
2979         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2980         Rowe gave me the green light.
2981
2982         * Scripts/old-run-webkit-tests:
2983         * Scripts/webkitpy/common/config/build.py:
2984         * Scripts/webkitpy/common/config/build_unittest.py:
2985         * Scripts/webkitpy/common/prettypatch.py:
2986         * Scripts/webkitpy/layout_tests/port/base.py:
2987         * Scripts/webkitpy/style/main.py:
2988
2989 2010-12-20  Adrienne Walker  <enne@google.com>
2990
2991         Unreviewed. Adding myself to the list of committers.
2992
2993         * webkitpy/common/config/committers.py:
2994
2995 2010-12-20  Mark Rowe  <mrowe@apple.com>
2996
2997         Reviewed by Dan Bernstein.
2998
2999         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3000
3001         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3002         Resources directory.
3003
3004 2010-12-20  Eric Seidel  <eric@webkit.org>
3005
3006         Reviewed by Adam Barth.
3007
3008         commit-queue should include bot id when attaching failure diffs
3009         https://bugs.webkit.org/show_bug.cgi?id=51280
3010
3011         This is a tiny change to include the bot id in the name of the attachment.
3012         Most of this diff is just changing the unit test expectations
3013         now that I hid the comment printing when the comment is None.
3014
3015         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3016         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3017         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3018         * Scripts/webkitpy/tool/mocktool.py:
3019
3020 2010-12-20  Jeff Miller  <jeffm@apple.com>
3021
3022         Reviewed by Dan Bernstein.
3023
3024         Tools/vcbin/midl.exe needs to be rebuilt
3025         https://bugs.webkit.org/show_bug.cgi?id=51347
3026
3027         * vcbin/midl.exe: Rebuilt.
3028
3029 2010-12-20  David Levin  <levin@chromium.org>
3030
3031         Reviewed by Ariya Hidayat.
3032
3033         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3034         https://bugs.webkit.org/show_bug.cgi?id=51343
3035
3036         Follow up from the WebKitTools -> Tools rename.
3037
3038         * Scripts/webkit-tools-completion.sh:
3039
3040 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3041
3042         Reviewed by James Robinson.
3043
3044         new-run-webkit-tests ignores trailing EOL differences in text tests
3045         https://bugs.webkit.org/show_bug.cgi?id=36983
3046
3047         Changed the handling of new-line characters within new-run-webkit-tests
3048         to match old-run-webkit-tests.  Differences in leading and trailing empty
3049         lines in text expectation files are no longer ignored.
3050
3051         * Scripts/webkitpy/layout_tests/port/base.py:
3052         * Scripts/webkitpy/layout_tests/port/test.py:
3053         Added unit tests.  Removed old duplicate unit test entries.
3054         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3055
3056 2010-12-20  David Levin  <levin@chromium.org>
3057
3058         Reviewed by Shinichiro Hamaji.
3059
3060         check-webkit-style should detect function declarations (and trivial functions).
3061         https://bugs.webkit.org/show_bug.cgi?id=51303
3062
3063         * Scripts/webkitpy/style/checkers/cpp.py:
3064         (_FunctionState.begin): Add is_declaration and changed the line count
3065         start to begin at -1 (which will keep the results consistent, since
3066         the starting line number passed in is one less in this change).
3067         (detect_functions): changed function detection to now catch trivial
3068         functions and declarations.
3069         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3070         of the function as this may look at return values (when processing
3071         a declaration).
3072         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3073         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3074         of testing the function detection.
3075         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3076         function.
3077         (FunctionDetectionTest.test_function_declaration_detection): Test a
3078         declaration.
3079         (FunctionDetectionTest.test_non_functions): A test case for a case
3080         that caused the code to fail due to the { being in quotes.
3081         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3082         cases to help catch false alarms for return values.
3083         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3084         we don't get false alarms for member variables either.
3085
3086 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3087
3088         Reviewed by Antonio Gomes.
3089
3090         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3091         https://bugs.webkit.org/show_bug.cgi?id=51319
3092
3093         * CMakeListsEfl.txt:
3094
3095 2010-12-18  Adam Barth  <abarth@webkit.org>
3096
3097         Reviewed by Sam Weinig.
3098
3099         Move WebKitExamplePlugins to Examples
3100         https://bugs.webkit.org/show_bug.cgi?id=51291
3101
3102         * Scripts/webkitpy/common/config/build.py:
3103
3104 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3105
3106         Unreviewed Qt buildfix after r74301.
3107
3108         Rename WebKitTools to Tools
3109         https://bugs.webkit.org/show_bug.cgi?id=49861
3110
3111         * MiniBrowser/DerivedSources.pro:
3112         * MiniBrowser/qt/MiniBrowser.pro:
3113
3114 2010-12-17  Dan Bernstein  <mitz@apple.com>
3115
3116         Reviewed by Simon Fraser.
3117
3118         Rename WebKitTools to Tools
3119         https://bugs.webkit.org/show_bug.cgi?id=49861
3120
3121         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3122         * CodeCoverage/README:
3123         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3124         (WebCore::DumpRenderTree::initializeFonts):
3125         * EWSTools/start-commit-queue.sh:
3126         * EWSTools/start-queue.sh:
3127         * GNUmakefile.am:
3128         * MIDLWrapper/MIDLWrapper.cpp:
3129         (wmain):
3130         * MiniBrowser/qt/MiniBrowser.pro:
3131         * Scripts/build-api-tests:
3132         * Scripts/build-dumprendertree:
3133         * Scripts/build-webkit:
3134         * Scripts/build-webkittestrunner:
3135         * Scripts/generate-coverage-data:
3136         * Scripts/old-run-webkit-tests:
3137         * Scripts/run-api-tests:
3138         * Scripts/run-iexploder-tests:
3139         * Scripts/run-javascriptcore-tests:
3140         * Scripts/run-mangleme-tests:
3141         * Scripts/run-sunspider:
3142         * Scripts/run-webkit-websocketserver:
3143         * Scripts/sunspider-compare-results:
3144         * Scripts/test-webkitperl:
3145         * Scripts/test-webkitpy:
3146         * Scripts/update-iexploder-cssproperties:
3147         * Scripts/update-webkit:
3148         * Scripts/update-webkit-localizable-strings:
3149         * Scripts/webkitdirs.pm:
3150         * Scripts/webkitpy/common/checkout/scm.py:
3151         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3152         * Scripts/webkitpy/common/config/committervalidator.py:
3153         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3154         * Scripts/webkitpy/common/config/ports.py:
3155         * Scripts/webkitpy/common/config/ports_unittest.py:
3156         * Scripts/webkitpy/common/system/logutils_unittest.py:
3157         * Scripts/webkitpy/common/system/ospath_unittest.py:
3158         * Scripts/webkitpy/layout_tests/port/chromium.py:
3159         * Scripts/webkitpy/layout_tests/port/config.py:
3160         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3161         * Scripts/webkitpy/layout_tests/port/http_server.py:
3162         * Scripts/webkitpy/layout_tests/port/test.py:
3163         * Scripts/webkitpy/style/checker.py:
3164         * Scripts/webkitpy/style/checker_unittest.py:
3165         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3166         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3167         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3168         * WebKitTestRunner/DerivedSources.pro:
3169         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3170         (WTR::activateFonts):
3171         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3172         * wx/build/build_utils.py:
3173
3174 2010-12-16  Antonio Gomes  <agomes@rim.com>
3175
3176         Reviewed by Martin Robinson.
3177
3178         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3179         https://bugs.webkit.org/show_bug.cgi?id=51163
3180
3181         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3182         GTK+'s DRT should also reset to UNIX after each test execution.
3183
3184         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3185         (resetDefaultsToConsistentValues):
3186
3187 2010-12-17  David Levin  <levin@chromium.org>
3188
3189         Reviewed by Eric Seidel.
3190
3191         check-webkit-style should understand WTF #include guards
3192         https://bugs.webkit.org/show_bug.cgi?id=44911
3193
3194         * Scripts/webkitpy/style/checkers/cpp.py:
3195         (get_header_guard_cpp_variable): modify to suggest the WTF style
3196         of header guard when appropriate.
3197         (check_for_header_guard): handle multiple return values from
3198         get_header_guard_cpp_variable
3199         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3200         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3201         header style.
3202
3203 2010-12-16  David Levin  <levin@chromium.org>
3204
3205         Reviewed by Eric Seidel.
3206
3207         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3208         https://bugs.webkit.org/show_bug.cgi?id=51210
3209
3210         The error only shows up when using python 2.6 or later.
3211
3212         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3213         the decprecated field error,message with something equivalent.
3214
3215 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3216
3217         Reviewed by Eric Seidel.
3218
3219         Add --exit-after-n-failures/crashes to NRWT
3220         https://bugs.webkit.org/show_bug.cgi?id=51160
3221         
3222         Abort test run (in a similar way to how control-C is handled) when
3223         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3224         that number of unexpected failures/crashes/timeouts.
3225
3226         * Scripts/webkitpy/layout_tests/port/test.py:
3227         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3228         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3229
3230 2010-12-16  David Levin  <levin@chromium.org>
3231
3232         Reviewed by Shinichiro Hamaji.
3233
3234         check-webkit-style unit tests has some duplicate boilerplate code.
3235         https://bugs.webkit.org/show_bug.cgi?id=49519
3236
3237         * Scripts/webkitpy/style/checkers/cpp.py:
3238         (update_include_state): Replaced the "io" parameter with the global
3239         configuration _unit_test_config. This allowed not calling into
3240         functions at a low level and also not plumbing through the injection
3241         information through many levels of code.
3242         (check_for_include_what_you_use): Ditto.
3243         (process_file_data): Added the ability to set up the unit test config
3244         to allow for injection.
3245         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3246         (ErrorCollector.__init__): Added support for having a filter for errors.
3247         (ErrorCollector.__call__): Ditto.
3248         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3249         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3250         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3251         functions in the cpp.py with generic processing and a filter that
3252         indicates what errors should be kept.
3253         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3254         (CppStyleTestBase.perform_language_rules_check): Ditto.
3255         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3256         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3257         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3258         (CppStyleTest.test_multi_line_comments): Added another
3259         error message which applies to the test case.
3260         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3261         to not have config.h, since it is processed as a header file.
3262         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3263         style and indentation in checked code.
3264         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3265         Fixed line number.
3266         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3267         Ditto.
3268
3269 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3270
3271         Unreviewed, rolling out r74136.
3272         http://trac.webkit.org/changeset/74136
3273         https://bugs.webkit.org/show_bug.cgi?id=51135
3274
3275         r74136 breaks chromium canary bots because some tests are not
3276         rebaselined correctly to resolve EOL differences (Requested by
3277         jianli on #webkit).
3278
3279         * Scripts/webkitpy/layout_tests/port/base.py:
3280         * Scripts/webkitpy/layout_tests/port/test.py:
3281         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3282
3283 2010-12-15  Adam Roben  <aroben@apple.com>
3284
3285         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3286         syntax errors
3287
3288         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3289         XML syntax errors in .vcproj/.vsprops files
3290
3291         Reviewed by Dave Levin.
3292
3293         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3294         that should be treated as XML and that should be allowed to contain
3295         carriage returns. (These lists happen to be identical currently.)
3296         (FileType): Added a new XML type.
3297         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3298         Just does a simple file extension check.
3299         (CheckerDispatcher._file_type): Added a case for XML files.
3300         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3301         files (surprise!).
3302         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3303         lines through the carriage checker.
3304
3305         * Scripts/webkitpy/style/checker_unittest.py:
3306         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3307         Added. Checks a few file names to see if carriage returns are allowed
3308         or not.
3309         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3310         other assert_checker_* functions.
3311         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3312         test_*_paths functions.
3313         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3314         test_*_paths functions.
3315         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3316         file from this test case, as vcproj files now have a type.
3317         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3318         Added. Similar to the other should_* functions.
3319         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3320         Added. Checks that carriage returns aren't checked for or stripped for
3321         allowed files.
3322
3323         * Scripts/webkitpy/style/checkers/xml.py: Added.
3324         (XMLChecker.__init__): Simple init method.
3325         (XMLChecker.check): Pass each line through the expat parser, and record
3326         a style error for any errors thrown by the parser.
3327
3328         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3329         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3330         produce a style error.
3331         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3332         error of the given category on the given line.
3333         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3334         checking that the XMLChecker constructor works properly.
3335         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3336         cause a style error (see, e.g., r73887).
3337         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3338         cause a style error (see, e.g., r73773).
3339         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3340         properly.
3341         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3342         tags cause a style error (see, e.g., r72795).
3343         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3344         style error.
3345
3346 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3347
3348         Reviewed by Stephanie Lewis.
3349
3350         https://bugs.webkit.org/show_bug.cgi?id=51117
3351         Add a new leopard test bot
3352         really really commit to trunk this time.
3353
3354         * BuildSlaveSupport/build.webkit.org-config/config.json:
3355
3356 2010-12-15  Sam Weinig  <sam@webkit.org>
3357
3358         Reviewed by Anders Carlsson.
3359
3360         WebKit2: Can't add files to an <input type=file>
3361         https://bugs.webkit.org/show_bug.cgi?id=51087
3362
3363         * MiniBrowser/mac/BrowserWindowController.m:
3364         (runOpenPanel):
3365         (-[BrowserWindowController awakeFromNib]):
3366         Add simple implementation of runOpenPanel callback.
3367
3368         * MiniBrowser/win/BrowserView.cpp:
3369         (BrowserView::create):
3370         * WebKitTestRunner/TestController.cpp:
3371         (WTR::createOtherPage):
3372         (WTR::TestController::initialize):
3373         Stub out runOpenPanel callback. 
3374
3375 2010-12-14  Eric Seidel  <eric@webkit.org>
3376
3377         Reviewed by Adam Barth.
3378
3379         commit-queue should upload failure diffs when tests flake
3380         https://bugs.webkit.org/show_bug.cgi?id=51051
3381
3382         To make this testable I needed to pipe FileSystem down onto tool.
3383         We've wanted it there for a long time anyway.
3384
3385         This patch is kinda a big hack.  But we don't have a nice
3386         way to read results.html files.  I think this will need further
3387         revision before this code actually feels clean.
3388
3389         As part of testing this change, I had to make MockBugzilla.create_bug
3390         actually return an id (like it should) which required updating
3391         a few other unit test results (for the better).
3392
3393         The results_matching_keys change in layouttestresults/rebasline
3394         was an alternate path which I decided not to use in the end, but
3395         I left the change as it seemed an improvement.
3396
3397         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3398         * Scripts/webkitpy/common/net/layouttestresults.py:
3399         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3400         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3401         * Scripts/webkitpy/tool/commands/queues.py:
3402         * Scripts/webkitpy/tool/commands/rebaseline.py:
3403         * Scripts/webkitpy/tool/main.py:
3404         * Scripts/webkitpy/tool/mocktool.py:
3405
3406 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3407
3408         Reviewed by James Robinson.
3409
3410         new-run-webkit-tests ignores trailing EOL differences in text tests
3411         https://bugs.webkit.org/show_bug.cgi?id=36983
3412
3413         Changed the handling of new-line characters within new-run-webkit-tests
3414         to match old-run-webkit-tests.  Differences in leading and trailing empty
3415         lines in text expectation files are no longer ignored.
3416
3417         * Scripts/webkitpy/layout_tests/port/base.py:
3418         * Scripts/webkitpy/layout_tests/port/test.py:
3419         Added unit tests.  Removed old duplicate unit test entries.
3420         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3421
3422 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3423
3424         Reviewed by Adam Barth.
3425
3426         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3427         https://bugs.webkit.org/show_bug.cgi?id=51149
3428
3429         * QueueStatusServer/templates/statusbubble.html:
3430
3431 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3432
3433         Reviewed by Adam Barth.
3434
3435         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3436         https://bugs.webkit.org/show_bug.cgi?id=51125
3437
3438         * QueueStatusServer/templates/statusbubble.html:
3439
3440 2010-12-15  Darin Adler  <darin@apple.com>
3441
3442         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3443
3444 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3445
3446         Unreviewed, rolling out r74117.
3447         http://trac.webkit.org/changeset/74117
3448         https://bugs.webkit.org/show_bug.cgi?id=51113
3449
3450         This broke the GTK1 build. (Requested by mrobinson on
3451         #webkit).
3452
3453         * Scripts/webkitdirs.pm:
3454
3455 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3456
3457         Reviewed by Martin Robinson.
3458
3459         Change generate-forwarding-headers.pl for GTK port usage 
3460         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3461
3462         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3463
3464 2010-12-14  Kent Tamura  <tkent@chromium.org>
3465
3466         Reviewed by Jian Li.
3467
3468         [DRT/Chromium] Remove another unnecessary error message
3469         https://bugs.webkit.org/show_bug.cgi?id=51083
3470
3471         * DumpRenderTree/chromium/WebViewHost.cpp:
3472         (WebViewHost::didInvalidateRect):
3473
3474 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3475
3476         Reviewed by Stephanie Lewis.
3477
3478         Add a new Leopard Debug Test WK2 Bot
3479
3480         * BuildSlaveSupport/build.webkit.org-config/config.json:
3481
3482 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3483
3484         Fix python unittests after http://trac.webkit.org/changeset/74070.
3485
3486         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3487
3488 2010-12-14  Kent Tamura  <tkent@chromium.org>
3489
3490         Reviewed by Jian Li.
3491
3492         [DRT/Chromium] Remove a unnecessary error message
3493         https://bugs.webkit.org/show_bug.cgi?id=51069
3494
3495         * DumpRenderTree/chromium/WebViewHost.cpp:
3496         (WebViewHost::paintInvalidatedRegion):
3497
3498 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3499
3500         Reviewed by Ojan Vafai.
3501
3502         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3503         https://bugs.webkit.org/show_bug.cgi?id=48926
3504
3505         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3506         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3507
3508 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3509
3510         Reviewed by Eric Seidel.
3511
3512         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3513         https://bugs.webkit.org/show_bug.cgi?id=50231
3514
3515         Guard CONFIG+=link_pkgconfig with !symbian.
3516
3517         * DumpRenderTree/qt/DumpRenderTree.pro:
3518         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3519         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3520
3521 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3522
3523         Reviewed by Ojan Vafai.
3524
3525         [new-run-webkit-tests] expectations parsing is slow
3526         https://bugs.webkit.org/show_bug.cgi?id=50635
3527
3528         Avoid expensive iteration of all the tests when checking if a test
3529         file is to be skipped or not.
3530
3531         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3532         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3533         * Scripts/webkitpy/layout_tests/port/test.py:
3534
3535 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3536
3537         Reviewed by Xan Lopez.
3538
3539         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3540         https://bugs.webkit.org/show_bug.cgi?id=27048
3541
3542         Add support in DRT for checking whether an accessibility UI
3543         element is focusable and/or focused. Implemented for GTK.
3544
3545         * DumpRenderTree/AccessibilityUIElement.cpp:
3546         (getIsFocusedCallback): New.
3547         (getIsFocusableCallback): New.
3548         (AccessibilityUIElement::getJSClass): Add the new available
3549         callbacks for isFocused and isFocusable.
3550         * DumpRenderTree/AccessibilityUIElement.h:
3551         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3552         (AccessibilityUIElement::isFocused): New, implemented by checking
3553         whether the related AtkState value is in the object's state set.
3554         (AccessibilityUIElement::isFocusable): Ditto.
3555         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3556         (AccessibilityUIElement::isFocused): New, dummy implementation.
3557         (AccessibilityUIElement::isFocusable): Ditto.
3558         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3559         (AccessibilityUIElement::isFocused): Ditto.
3560         (AccessibilityUIElement::isFocusable): Ditto.
3561
3562 2010-12-14  Eric Seidel  <eric@webkit.org>
3563
3564         Reviewed by Ojan Vafai.
3565
3566         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3567         https://bugs.webkit.org/show_bug.cgi?id=50715
3568
3569         This patch makes webkit-patch print the following:
3570
3571         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3572         Install a 64-bit git for better performance, see:
3573         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3574
3575         I wrote this mostly because I have approximately 8 machines that I use
3576         and making sure each one is using a good Git install seemed folly.
3577         webkit-patch makes a lot of git calls, so using a fast git can shave
3578         several seconds in every invocation.  See the webkit-dev thread for more info.
3579
3580         This message will print twice during 'webkit-patch upload',
3581         once from webkit-patch and once from check-webkit-style.
3582
3583         Unfortunately there is no good way to test this due to how machine-dependent
3584         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3585
3586         * Scripts/webkitpy/common/checkout/scm.py:
3587
3588 2010-12-13  Eric Seidel  <eric@webkit.org>
3589
3590         Reviewed by Adam Barth.
3591
3592         FlakyTestReporter doesn't understand bots running from multiple email addresses
3593         https://bugs.webkit.org/show_bug.cgi?id=50960
3594
3595         This explains at least one of the dupes of:
3596         https://bugs.webkit.org/show_bug.cgi?id=50863
3597         that we saw filed by the commit-queue this morning.
3598         I think the other one was explained by my previous fix to result counting code.
3599
3600         Since this is really hard to test with a unit test, instead I
3601         create a new (possibly useful in the future) command
3602         which given a layout test path will return you
3603         the one bug which our tools would assume it the flaky test bug.
3604         If some other script wants to use bug-for-test we'll
3605         need to extend it with some options like --create-if-missing or similar.
3606
3607         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3608         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3609         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3610         * Scripts/webkitpy/tool/commands/__init__.py:
3611         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3612
3613 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3614
3615         Reviewed by James Robinson.
3616
3617         Add option to build-webkit to not build WebKit2
3618         https://bugs.webkit.org/show_bug.cgi?id=50988
3619         
3620         Add support for a --no-webkit2 option to build-webkit. It seems to save
3621         ~1 minute from clean builds and ~10 seconds from no-op builds.
3622
3623         * Scripts/build-webkit:
3624
3625 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3626
3627         Reviewed by Dave Kilzer.
3628
3629         Update iexploder from 1.3.2 to 1.7.2
3630         Move 1.3.2 into its own subdir
3631         Add 1.7.2 into its own subdir
3632         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3633
3634         * Scripts/run-iexploder-tests:
3635         * Scripts/update-iexploder-cssproperties:
3636         * iExploder/CHANGELOG.txt: Removed.
3637         * iExploder/LICENSE.txt: Removed.
3638         * iExploder/README.txt: Removed.
3639         * iExploder/htdocs: Removed.
3640         * iExploder/iexploder-1.3.2: Added.
3641         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3642         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3643         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3644         * iExploder/iexploder-1.3.2/htdocs: Added.
3645         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3646         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3647         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3648         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3649         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3650         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3651         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3652         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3653         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3654         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3655         * iExploder/iexploder-1.3.2/tools: Added.
3656         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3657         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3658         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3659         * iExploder/iexploder-1.7.2: Added.
3660         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3661         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3662         * iExploder/iexploder-1.7.2/README.txt: Added.
3663         * iExploder/iexploder-1.7.2/output: Added.
3664         * iExploder/iexploder-1.7.2/src: Added.
3665         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3666         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3667         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3668         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3669         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3670         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3671         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3672         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3673         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3674         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3675         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3676         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3677         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3678         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3679         * iExploder/iexploder-1.7.2/src/css-values: Added.
3680         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3681         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3682         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3683         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3684         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3685         * iExploder/iexploder-1.7.2/src/headers: Added.
3686         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3687         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3688         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3689         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3690         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3691         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3692         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3693         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3694         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3695         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3696         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3697         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3698         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3699         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3700         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3701         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3702         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3703         * iExploder/iexploder-1.7.2/src/html-values: Added.
3704         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3705         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3706         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3707         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3708         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3709         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3710         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3711         * iExploder/iexploder-1.7.2/src/index.html: Added.
3712         * iExploder/iexploder-1.7.2/src/media: Added.
3713         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3714         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3715         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3716         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3717         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3718         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3719         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3720         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3721         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3722         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3723         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3724         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3725         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3726         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3727         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3728         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3729         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3730         * iExploder/iexploder-1.7.2/src/protocols: Added.
3731         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3732         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3733         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3734         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3735         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3736         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3737         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3738         * iExploder/iexploder-1.7.2/testcases: Added.
3739         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3740         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3741     &nb