2011-02-04 Mikhail Naganov <mnaganov@chromium.org>
[WebKit.git] / Tools / ChangeLog
1 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
2
3         Reviewed by Pavel Feldman.
4
5         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
6         https://bugs.webkit.org/show_bug.cgi?id=53781
7
8         * Scripts/check-inspector-strings:
9
10 2011-02-04  Adam Roben  <aroben@apple.com>
11
12         Include the crashing function in the link to a crash log on Mac
13
14         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
15         function that crashed on Mac
16
17         Reviewed by David Kilzer.
18
19         * Scripts/old-run-webkit-tests:
20         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
21         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
22         the crash log.
23
24 2011-02-04  Adam Roben  <aroben@apple.com>
25
26         Link to Mac crash logs from results.html
27
28         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
29         results.html
30
31         Reviewed by David Kilzer.
32
33         * Scripts/old-run-webkit-tests:
34         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
35         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
36
37 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
38
39         Reviewed by Dan Bernstein.
40
41         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
42         https://bugs.webkit.org/show_bug.cgi?id=52897
43         <rdar://problem/8898294>
44
45         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
46         (WTR::InjectedBundlePage::InjectedBundlePage):
47         (WTR::InjectedBundlePage::willSendRequestForFrame):
48         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
49
50 2011-02-03  Ivan Krstić  <ike@apple.com>
51
52         Unreviewed.
53
54         Adding myself to committers.py.
55
56         * Scripts/webkitpy/common/config/committers.py:
57
58 2011-02-03  James Kozianski  <koz@chromium.org>
59
60         Reviewed by Dimitri Glazkov.
61
62         Add navigator.registerProtocolHandler behind a flag.
63         https://bugs.webkit.org/show_bug.cgi?id=52609
64
65         * Scripts/build-webkit:
66
67 2011-02-03  Hayato Ito  <hayato@chromium.org>
68
69         Reviewed by Eric Seidel.
70
71         [NRWT] Remove TestArgs class, which is wrongly used.
72
73         https://bugs.webkit.org/show_bug.cgi?id=53063
74
75         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
76         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
77         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
78         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
79         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
80         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
81
82 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
83
84         Reviewed by Kenneth Russell.
85
86         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
87         https://bugs.webkit.org/show_bug.cgi?id=53714
88
89         * Scripts/build-webkit: change --3d-canvas build option
90           to set ENABLE_WEBGL
91
92 2011-02-03  Hayato Ito  <hayato@chromium.org>
93
94         Reviewed by Tony Chang.
95
96         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
97         move _run_single_test() and _process_output() functions from
98         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
99
100         This is clean up and acts as a preparation for elimination of test_types/*
101         classes. These classes will move to the single_test_runner module introduced
102         in this patch.
103
104         https://bugs.webkit.org/show_bug.cgi?id=53004
105
106         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
107         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
108         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
109         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
110         * Scripts/webkitpy/layout_tests/port/base.py:
111         * Scripts/webkitpy/layout_tests/port/chromium.py:
112         * Scripts/webkitpy/layout_tests/port/dryrun.py:
113         * Scripts/webkitpy/layout_tests/port/test.py:
114         * Scripts/webkitpy/layout_tests/port/webkit.py:
115         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
116         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
117         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
118
119 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
120
121         Unreviewed, build fix.
122
123         Delete a line that was accidentally missed in r77586; without it
124         there is still a race between the two threads.
125
126         https://bugs.webkit.org/show_bug.cgi?id=51572
127
128         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
129
130 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
131
132         Reviewed by Tony Chang.
133
134         nrwt: handle "broken pipe" notifications from DRT more cleanly.
135
136         https://bugs.webkit.org/show_bug.cgi?id=52927
137
138         * Scripts/webkitpy/layout_tests/port/server_process.py:
139         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
140
141 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
142
143         Reviewed by Kenneth Russell.
144
145         Update, resubmit change to bug 51572. I think the race that was
146         fixed in r76703 caused the hang that caused us to roll this
147         patch out before, so I'd like to try again.
148
149         https://bugs.webkit.org/show_bug.cgi?id=51572
150
151         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
152         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
153
154 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
155
156         Unreviewed.
157
158         Adding myself to committers.py.
159
160         * Scripts/webkitpy/common/config/committers.py:
161
162 2011-02-03  Adam Roben  <aroben@apple.com>
163
164         Include the crashing function in the link to a crash log
165
166         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
167         function that crashed
168
169         Reviewed by David Kilzer.
170
171         * Scripts/old-run-webkit-tests:
172         (crashLocation): Added. Returns the location of the crash.
173         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
174         could be determined.
175
176 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
177
178         Unreviewed, build fix.
179
180         Actually make the changes suggested by Mihai in his review
181         of bug 53720 :(
182
183         https://bugs.webkit.org/show_bug.cgi?id=53720
184
185         * Scripts/webkitpy/layout_tests/port/test_files.py:
186         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
187
188 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
189
190         Reviewed by Mihai Parparita.
191
192         new-run-webkit-tests: Fix bug introduced in r77434 that was
193         causing us to run the canvas GPU tests on the Mac GPU port. This
194         bug revealed that we were not setting the port.name() field
195         properly in many cases, so I've cleaned up all of that code, and
196         removed a few comments about "version-specific" GPU ports that
197         don't exist and just confused things.
198
199         Testing also revealed that port.abspath_for_test() wasn't
200         normalizing paths on Windows properly, so I fixed that as well.
201
202         https://bugs.webkit.org/show_bug.cgi?id=53719
203
204         * Scripts/webkitpy/layout_tests/port/base.py:
205         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
206         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
207
208 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
209
210         Reviewed by Mihai Parparita.
211
212         new-run-webkit-tests: fix normalization of paths on windows when gathering files
213
214         r77434 introduced a bug that was causing the test expectations
215         for the GPU ports to not be treated properly. It turns out that
216         when we gathered the list of test files on Windows, we would
217         return paths of the form "c:\LayoutTests/fast/canvas", and the
218         mixture of backslashes and forward slashes was confusing things.
219
220         This patch normalizes all of the filenames returned from
221         test_files.find(), and adds better tests for this (fixing a
222         couple of other bugs found in the meantime).
223
224         https://bugs.webkit.org/show_bug.cgi?id=53720
225
226         * Scripts/webkitpy/layout_tests/port/test.py:
227         * Scripts/webkitpy/layout_tests/port/test_files.py:
228         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
229
230 2011-02-03  Adam Roben  <aroben@apple.com>
231
232         Add links to Windows crash logs in results.html
233
234         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
235         results.html
236
237         Reviewed by David Kilzer.
238
239         * Scripts/old-run-webkit-tests:
240         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
241         createDebuggerCommandFile).
242         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
243         tool has exited.
244         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
245         it into the test results directory tree. Only implemented for Cygwin currently.
246         (findNewestFileMatchingGlob): Added. Does what it says.
247         (htmlForResultsSection): Only link to files that exist.
248         (linksForErrorTest): Add a link to the crash log.
249         (deleteExpectedAndActualResults): Delete any old crash log for this test.
250         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
251         hardcoding it here.
252
253 2011-02-03  Adam Roben  <aroben@apple.com>
254
255         Tell the debugger the path to the WebKit source tree when saving a crash log
256
257         This allows the debugger to include the crashing line of code in the log.
258
259         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
260         of code
261
262         Reviewed by Sam Weinig.
263
264         * Scripts/old-run-webkit-tests:
265         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
266         file and returns the path to that file. The commands we pass came from
267         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
268         WebKit source code lives.
269         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
270         line using -c, save them to a file and specify the path to that file using -cf. This works
271         around what is presumably a bug in Windows's command line parsing, where having multiple
272         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
273         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
274         together to make them easier to modify in the future.
275
276 2011-02-02  Sam Weinig  <sam@webkit.org>
277
278         Reviewed by Anders Carlsson.
279
280         Add notification of the end of a rubber band.
281         <rdar://problem/8940648>
282
283         * MiniBrowser/mac/BrowserWindowController.m:
284         (-[BrowserWindowController awakeFromNib]):
285         * WebKitTestRunner/TestController.cpp:
286         (WTR::TestController::createOtherPage):
287         (WTR::TestController::initialize):
288         Stub out the new WKUIClient function.
289
290 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
291
292         Unreviewed.
293
294         Adding myself to committers.py.
295
296         * Scripts/webkitpy/common/config/committers.py:
297
298 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
299
300         Reviewed by Csaba Osztrogonác.
301
302         [Qt][WK2] MiniBrowser's window size should be 800x600
303         https://bugs.webkit.org/show_bug.cgi?id=53670
304
305         Make layout test failure debugging easier.
306         * MiniBrowser/qt/BrowserWindow.cpp:
307         (BrowserWindow::BrowserWindow):
308
309 2011-02-02  Andy Estes  <aestes@apple.com>
310
311         Reviewed by Mark Rowe.
312
313         'update-webkit' should handle OpenSource and Internal using different
314         VCSs.
315
316         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
317         Internal directory.
318
319 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
320
321         Reviewed by Mihai Parparita.
322
323         new-run-webkit-tests: hardcode the directories to scan for tests
324         for GPU bots instead of SKIPping them. See bug 53562 for some
325         context, but we will now hard-code the list of directories to
326         use by default instead of skipping over directories in the
327         expectations file. We do this so that we will be able to merge
328         the expectations files without getting conflicting SKIP
329         directives. Note that this change will reduce the # of tests
330         being run on the Mac GPU bots, because we're accidentally
331         including some today.
332
333         https://bugs.webkit.org/show_bug.cgi?id=53631
334
335         * Scripts/webkitpy/layout_tests/port/base.py:
336         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
337         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
338
339 2011-02-02  Sam Weinig  <sam@webkit.org>
340
341         Reviewed by Beth Dakin.
342
343         Add ChromeClient function to paint custom overhang areas.
344         https://bugs.webkit.org/show_bug.cgi?id=53639
345
346         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
347         (WTR::InjectedBundlePage::InjectedBundlePage):
348         Stub out new callback.
349
350 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
351
352         Reviewed by Tony Chang.
353
354         new-run-webkit-tests: support chromium code paths in mock_drt
355
356         https://bugs.webkit.org/show_bug.cgi?id=53471
357
358         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
359         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
360
361 2011-02-02  Adam Klein  <adamk@chromium.org>
362
363         Reviewed by Tony Chang.
364
365         Update new-run-webkit-tests --chromium to put output under Source/...
366         https://bugs.webkit.org/show_bug.cgi?id=53612
367
368         * BuildSlaveSupport/test-result-archive:
369         * Scripts/webkitpy/layout_tests/port/chromium.py:
370
371 2011-01-28  Tony Chang  <tony@chromium.org>
372
373         Reviewed by Eric Seidel.
374
375         [chromium] remove --use-test-shell from NRWT
376         https://bugs.webkit.org/show_bug.cgi?id=53346
377
378         I've already started removing some of the bindings like eventSender so
379         this already doesn't work isn't useful.  Also updated some comments to
380         refer to DRT instead of test_shell.
381
382         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
383         * Scripts/webkitpy/layout_tests/port/chromium.py:
384         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
385         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
386         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
387         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
388         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
389         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
390
391 2011-02-02  Steve Lacey  <sjl@chromium.org>
392
393         Reviewed by Eric Carlson.
394
395         Implement basic media statistics on media elements.
396         https://bugs.webkit.org/show_bug.cgi?id=53322
397
398         * Scripts/build-webkit:
399
400 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
401
402         [wx] Build fixes for wxWebKit.
403
404         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
405         (LayoutTestController::setSerializeHTTPLoads):
406         * wx/browser/wscript:
407         * wx/build/build_utils.py:
408         * wx/build/settings.py:
409
410 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
411
412         Reviewed by Mihai Parparita.
413
414         new-run-webkit-tests: stop skipping so many tests
415
416         r77163 introduced a regression where we weren't resetting test
417         expectations properly and were skipping too many tests as a
418         result. This patch fixes that and adds a test for it.
419
420         https://bugs.webkit.org/show_bug.cgi?id=53551
421
422         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
423         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
424
425 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
426
427         Reviewed by Tony Chang.
428
429         new-run-webkit-tests: add first stub of test_runner2. This
430         will add support for the 'inline', 'threads', and 'processes'
431         flags to --worker-model, but for now the implementatios just
432         fall back on the old ones.
433
434         https://bugs.webkit.org/show_bug.cgi?id=53157
435
436         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
437         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
438
439 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
440
441         Reviewed by James Robinson.
442
443         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
444         https://bugs.webkit.org/show_bug.cgi?id=53522
445
446         * Scripts/run-chromium-webkit-unit-tests:
447
448 2011-02-01  Adam Barth  <abarth@webkit.org>
449
450         Reviewed by Mihai Parparita.
451
452         Using Control-C to cancel webkit-patch or other python tools causes
453         unpleasant traceback console spew
454         https://bugs.webkit.org/show_bug.cgi?id=53462
455
456         Catch the exception and don't print the stack trace.
457
458         * Scripts/webkit-patch:
459
460 2011-02-01  Scott Cameron  <sccameron@rim.com>
461
462         Reviewed by Daniel Bates.
463
464         Use Windows format for MinGW HTTPD path.
465         https://bugs.webkit.org/show_bug.cgi?id=53503
466
467         * Scripts/webkitperl/httpd.pm:
468           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
469             so that we don't have to escape the space characters in the path. Also,
470             changed path to Windows-style path and removed FIXME comment.
471
472 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
473
474         Reviewed by Andreas Kling.
475
476         [Qt][WK2] Add a way to use shared process model in MiniBrowser
477         https://bugs.webkit.org/show_bug.cgi?id=53090
478
479         * MiniBrowser/qt/BrowserView.cpp:
480         (BrowserView::BrowserView): Removed the m_context member.
481         From now the context is guaranteed to be non-null and we
482         don't need to store that in the object.
483         * MiniBrowser/qt/BrowserView.h:
484         * MiniBrowser/qt/BrowserWindow.cpp:
485         Added static bool to determine that new windows need to be
486         created with their own context or not. Use the same context
487         and web process by default to be inilne with the other ports.
488         (BrowserWindow::BrowserWindow):
489         (BrowserWindow::newWindow):
490         * MiniBrowser/qt/BrowserWindow.h:
491         * MiniBrowser/qt/main.cpp:
492         (main): Added command line switch to be able to use the
493         non-shared process model. Simplify the handling of the command line
494         switches a little bit.
495
496 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
497
498         Reviewed by Andreas Kling.
499
500         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
501         https://bugs.webkit.org/show_bug.cgi?id=53491
502
503         * MiniBrowser/qt/BrowserWindow.cpp:
504         (BrowserWindow::BrowserWindow):
505         (BrowserWindow::toggleFullScreenMode):
506         * MiniBrowser/qt/BrowserWindow.h:
507
508 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
509
510         Reviewed by Andreas Kling.
511
512         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
513         https://bugs.webkit.org/show_bug.cgi?id=53489
514
515         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
516         to Settings menu.
517
518         * MiniBrowser/qt/BrowserWindow.cpp:
519         (BrowserWindow::BrowserWindow):
520         (BrowserWindow::toggleFrameFlattening):
521         (BrowserWindow::toggleDisableJavaScript):
522         (BrowserWindow::toggleAutoLoadImages):
523         * MiniBrowser/qt/BrowserWindow.h:
524
525 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
526
527         Reviewed by Tony Chang.
528
529         [Chromium] Switch chromium-mac to use ChromiumDriver
530         https://bugs.webkit.org/show_bug.cgi?id=53461
531         
532         For the sake of consistency with the other Chromium platforms (and so
533         that chromium-mac picks up special flags like --enable-hardware-gpu),
534         switch chromium-mac from the WebKitDriver to ChromiumDriver.
535
536         * Scripts/webkitpy/layout_tests/port/chromium.py:
537
538 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
539
540         Reviewed by Mihai Parparita.
541
542         The current modifier parsing code in test_expectations is
543         fragile and hard-coded, so it's not easy to understand the logic
544         or easily add new types of modifiers (like GPU vs. CPU testing
545         for graphics tests, or 32-bit vs. 64-bit differences).
546
547         This is the first of two patches that will add in more generic
548         support and then eliminate the GPU-specific test expectations
549         files for Chromium.
550
551         This patch adds two standalone objects for handling modifiers. The
552         rules for interpreting modifiers, precedence, and conflicts are
553         given in the docstring to the ModifierMatcher class, which
554         returns ModifierMatchResult objects.
555         
556         This patch also adds routines to the Port interface and a
557         default set of values in the base object, in order to obtain the
558         values needed on a given test run. These values are then passed
559         to the expectation parser. This also allows us to clean up the
560         logic used to lint all of the different configurations in a
561         single test_expectations.txt file.
562
563         The next patch will merge in the separate GPU expectations file.
564
565         https://bugs.webkit.org/show_bug.cgi?id=51222
566
567         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
568         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
569         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
570         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
571         * Scripts/webkitpy/layout_tests/port/base.py:
572         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
573         * Scripts/webkitpy/layout_tests/port/chromium.py:
574         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
575         * Scripts/webkitpy/layout_tests/port/test.py:
576         * Scripts/webkitpy/layout_tests/port/webkit.py:
577         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
578         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
579         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
580         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
581         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
582
583 2011-01-31  Scott Cameron  <sccameron@rim.com>
584
585         Reviewed by Daniel Bates.
586
587         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
588         https://bugs.webkit.org/show_bug.cgi?id=50036
589
590         This will add an Apache2.2 configuration file and modifies scripts to allow
591         running an httpd server in an MSYS environment.
592
593         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
594         in order to allow for simple installation/execution.  Simply install the latest
595         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
596         be able to execute run-webkit-httpd.
597         
598
599         * Scripts/run-webkit-httpd:
600         * Scripts/webkitperl/httpd.pm:
601
602 2011-01-31  Tony Chang  <tony@chromium.org>
603
604         Reviewed by Eric Seidel.
605
606         mac DRT should report RTL scroll offset relative to top right corner
607         https://bugs.webkit.org/show_bug.cgi?id=53324
608
609         * DumpRenderTree/mac/DumpRenderTree.mm:
610         (dumpFrameScrollPosition):
611
612 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
613
614         Reviewed by Andreas Kling.
615
616         [Qt] Add Take Screen Shot action to MiniBrowser
617         https://bugs.webkit.org/show_bug.cgi?id=53422
618
619         Add Take Screen Shot action to MiniBrowser's view menu.
620
621         * MiniBrowser/qt/BrowserWindow.cpp:
622         (BrowserWindow::BrowserWindow):
623         (BrowserWindow::screenshot):
624         * MiniBrowser/qt/BrowserWindow.h:
625
626 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
627
628         Reviewed by Xan Lopez.
629
630         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
631         https://bugs.webkit.org/show_bug.cgi?id=53379
632
633         Remove left over #ifdef's. I thought all of the conditional code
634         had been freed from the condition, but I forgot to check DRT.
635
636         * DumpRenderTree/gtk/DumpRenderTree.cpp:
637         (resetDefaultsToConsistentValues):
638         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
639         (LayoutTestController::setAlwaysAcceptCookies):
640
641 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
642
643         Unreviewed, build fix.
644
645         Fix regression introduced in r77093 - path.rsplit() doesn't
646         take keyword arguments.
647
648         https://bugs.webkit.org/show_bug.cgi?id=53326
649
650         * Scripts/webkitpy/common/system/filesystem_mock.py:
651
652 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
653
654         Reviewed by Mihai Parparita.
655
656         Add more unit tests for rebaseline-chromium-webkit-tests. This
657         change involves restructuring a bunch of r-c-w-t code to make it
658         more testable as well. We also add wrapper classes for handling
659         testing zip files and fetching URLs.
660
661         https://bugs.webkit.org/show_bug.cgi?id=53040
662
663         * Scripts/webkitpy/common/system/urlfetcher.py:
664         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
665         * Scripts/webkitpy/common/system/zipfileset_mock.py:
666         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
667         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
668         * Scripts/webkitpy/tool/mocktool.py:
669
670 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
671
672         Reviewed by Eric Seidel.
673
674         Clean up of the filesystem-related modules used in webkitpy.
675         I've added relpath() to the filesystem interface, modified
676         ospath.relpath() so that it could work with the filesystem
677         interface, and modified the fileset* routines to use the
678         filesystem interface consistently.
679
680         This patch also adds a close() routine to the fileset routines
681         to indicate that the caller is done with the fileset. This
682         allows zipfileset to clean up after itself when it creates
683         tempfiles to store downloads.
684
685         https://bugs.webkit.org/show_bug.cgi?id=53326
686
687         * Scripts/webkitpy/common/system/directoryfileset.py:
688         * Scripts/webkitpy/common/system/fileset.py:
689         * Scripts/webkitpy/common/system/filesystem.py:
690         * Scripts/webkitpy/common/system/filesystem_mock.py:
691         * Scripts/webkitpy/common/system/filesystem_unittest.py:
692         * Scripts/webkitpy/common/system/ospath.py:
693         * Scripts/webkitpy/common/system/zipfileset.py:
694         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
695
696 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
697
698         Reviewed by Csaba Osztrogonác.
699
700         [Qt][WK2]REGRESSION (r76991): Fix build errors
701         https://bugs.webkit.org/show_bug.cgi?id=53400
702
703         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
704         and remove WebKit2Prefix.h from the build.
705         * MiniBrowser/qt/MiniBrowser.pro:
706
707 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
708
709         Unreviewed.
710
711         [Qt][WK2] Buildfix.
712
713         * MiniBrowser/qt/MiniBrowser.pro:
714
715 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
716
717         Reviewed by Adam Roben.
718         
719         define NOMINMAX when building ImageDiff, as we do elsewhere.
720
721         Add various clampToInt() methods to MathExtras.h
722         https://bugs.webkit.org/show_bug.cgi?id=52910
723
724         * DumpRenderTree/win/ImageDiffCommon.vsprops:
725
726 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
727
728         Reviewed by Darin Adler.
729
730         WebKitTestRunner needs layoutTestController.setPOSIXLocale
731         https://bugs.webkit.org/show_bug.cgi?id=42682
732
733         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
734         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
735         (WTR::InjectedBundle::resetLocalSettings):
736         (WTR::InjectedBundle::didReceiveMessage):
737         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
738         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
739         (WTR::LayoutTestController::setPOSIXLocale):
740         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
741
742 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
743  
744          Reviewed by Mihai Parparita.
745  
746          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
747  
748          This patch re-enables this test and changes it to
749          handle all of the mac platform versions, not just the one
750          it is running on.
751  
752          https://bugs.webkit.org/show_bug.cgi?id=53356
753  
754          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
755  
756 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
757
758         Unreviewed, build fix.
759
760         Take two. The fix in 77023 didn't work, because we were
761         still calling path.abspath_to_uri, which calls _cygpath under
762         the covers, and it appears the cygpath on the bots does
763         something different than it does on my machine. This patch
764         removes the calls to path.abspath_to_uri, so it should be safe.
765         If it doesn't work, I'll roll it out along with r76982 and 77023.
766
767         https://bugs.webkit.org/show_bug.cgi?id=53126
768
769         * Scripts/webkitpy/layout_tests/port/test.py:
770
771 2011-01-28  David Kilzer  <ddkilzer@apple.com>
772
773         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
774         <http://webkit.org/b/53353>
775
776         Reviewed by Mark Rowe.
777
778         * Scripts/webkitdirs.pm:
779         (checkRequiredSystemConfig): Check the Xcode marketing version
780         in addition to the DevCoreTools build version before complaining
781         about an old version of Xcode.  Also make the Mac OS X version
782         check use Perl's built-in version string comparitor.
783
784 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
785
786         Unreviewed, build fix.
787
788         Work around breakage on Win 7 Release bot caused by r76982
789         and the fact that windows ports use "file:////" instead of
790         "file:///". Ideally the test code should be isolated from
791         this, but it isn't yet. Will fix properly in a bit.
792
793         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
794
795 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
796
797         Reviewed by Tony Chang.
798
799         new-run-webkit-tests: change worker model values to
800         "old-inline", "old-threads" in preparation for test_runner2 /
801         multiprocessing changes.
802
803         https://bugs.webkit.org/show_bug.cgi?id=53156
804
805         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
806         * Scripts/webkitpy/layout_tests/port/base.py:
807         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
808         * Scripts/webkitpy/layout_tests/port/mac.py:
809         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
810
811 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
812
813         Reviewed by Tony Chang.
814
815         committers.py - add an IRC nickname for dpranke
816         https://bugs.webkit.org/show_bug.cgi?id=53335
817
818         * Scripts/webkitpy/common/config/committers.py:
819
820 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
821
822         Reviewed by Tony Chang.
823
824         new-run-webkit-tests: add a "mock DRT" port implementation
825         and a separate class that emulates what we expect the
826         DumpRenderTree behavior to be.
827
828         This will eventually replace port/dryrun.py and allow us to get
829         better test coverage of the new-run-webkit-tests code as well as
830         a reference for what new-run-webkit-tests expects from DRT.
831
832         This is the first attempt at this, and it is pretty bare-boned. It
833         really only has been tested on the 'mac' port (and a little on
834         the 'chromium-mac' port.
835
836         https://bugs.webkit.org/show_bug.cgi?id=53126
837
838         * Scripts/webkitpy/common/system/filesystem_mock.py:
839         * Scripts/webkitpy/layout_tests/port/dryrun.py:
840         * Scripts/webkitpy/layout_tests/port/factory.py:
841         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
842         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
843         * Scripts/webkitpy/layout_tests/port/test.py:
844
845 2011-01-28  Pratik Solanki  <psolanki@apple.com>
846
847         Unreviewed. Removing .swp file checked in by mistake.
848
849         * Scripts/.webkitdirs.pm.swp: Removed.
850
851 2011-01-28  Pratik Solanki  <psolanki@apple.com>
852
853         Reviewed by David Kilzer.
854
855         Space not necessary for undefined feature
856         https://bugs.webkit.org/show_bug.cgi?id=53317
857
858         * Scripts/build-webkit:
859
860 2011-01-28  Chang Shu  <chang.shu@nokia.com>
861
862         Reviewed by Andreas Kling.
863
864         Reset NetworkAccessManager to clean up credentials from previous tests.
865         This change causes no performance overhead either.
866         https://bugs.webkit.org/show_bug.cgi?id=36688
867
868         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
869         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
870         (WebCore::DumpRenderTree::open):
871         * DumpRenderTree/qt/DumpRenderTreeQt.h:
872
873 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
874
875         Reviewed by Andreas Kling.
876
877         [Qt] Add Zoom Text Only action to MiniBrowser
878         https://bugs.webkit.org/show_bug.cgi?id=53297
879
880         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
881
882         * MiniBrowser/qt/BrowserWindow.cpp:
883         (BrowserWindow::BrowserWindow):
884         (BrowserWindow::zoomIn):
885         (BrowserWindow::zoomOut):
886         (BrowserWindow::resetZoom):
887         (BrowserWindow::toggleZoomTextOnly):
888         (BrowserWindow::applyZoom):
889         * MiniBrowser/qt/BrowserWindow.h:
890
891 2011-01-28  Adam Barth  <abarth@webkit.org>
892
893         Reviewed by Eric Seidel.
894
895         Add webkit-patch roll-chromium-deps
896         https://bugs.webkit.org/show_bug.cgi?id=53288
897
898         This command updates the Source/WebKit/chromium/DEPS file with the
899         last-known good revision of Chromium (or a revision specified on the
900         command line).  I'd eventually like to turn this into a SheriffBot
901         command, but this is the first step.
902
903         This patch somewhat sprawled because I needed to move a bunch of code
904         out of ChangeLog that should never have been there in the first place.
905         Also, I had to fix a bug in MockUser in order to test the new command.
906
907         * Scripts/webkitpy/common/checkout/api.py:
908         * Scripts/webkitpy/common/checkout/changelog.py:
909         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
910         * Scripts/webkitpy/common/checkout/deps.py: Added.
911         * Scripts/webkitpy/common/config/urls.py:
912         * Scripts/webkitpy/tool/commands/__init__.py:
913         * Scripts/webkitpy/tool/commands/download_unittest.py:
914         * Scripts/webkitpy/tool/commands/roll.py: Added.
915         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
916         * Scripts/webkitpy/tool/commands/upload_unittest.py:
917         * Scripts/webkitpy/tool/mocktool.py:
918         * Scripts/webkitpy/tool/steps/__init__.py:
919         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
920         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
921         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
922         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
923         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
924         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
925
926 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
927
928         Reviewed by Laszlo Gombos.
929
930         Get rid of prefix header dependency for WebKit2 build system
931         https://bugs.webkit.org/show_bug.cgi?id=50174
932
933         Change the style checker so that it enforces config.h include for
934         WebKit2.
935
936         * Scripts/webkitpy/style/checker.py:
937
938 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
939
940         Reviewed by Darin Adler.
941
942         execCommand("Paste") doesn't work in WebKitTestRunner
943         https://bugs.webkit.org/show_bug.cgi?id=52785
944
945         Enable both of the settings needed to allow paste.
946         
947         * WebKitTestRunner/TestController.cpp:
948         (WTR::TestController::resetStateToConsistentValues):
949
950 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
951
952         Reviewed by Andreas Kling.
953
954         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
955         https://bugs.webkit.org/show_bug.cgi?id=48440
956
957         Preserve user input when toggling use of QGraphicsView
958
959         * QtTestBrowser/launcherwindow.cpp:
960         (LauncherWindow::initializeView):
961         (LauncherWindow::loadFinished):
962         * QtTestBrowser/launcherwindow.h:
963         * QtTestBrowser/mainwindow.cpp:
964         (MainWindow::addressUrl):
965         * QtTestBrowser/mainwindow.h:
966
967 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
968
969         Reviewed by Mihai Parparita.
970
971         new-run-webkit-tests: turn off pixel tests correctly by default
972         for webkit-based ports. r70013 (bug 47510) used
973         port.set_option_default() to attempt to set default values, but
974         that didn't work correctly. I have removed set_option_default
975         for now since it was only being used in two places and in three
976         useless unit tests. There is a separate bug open to fix the
977         option parsing (48095), so this workaround is fine for now.
978
979         https://bugs.webkit.org/show_bug.cgi?id=53217
980
981         * Scripts/webkitpy/layout_tests/port/webkit.py:
982         * Scripts/webkitpy/layout_tests/port/base.py:
983         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
984
985 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
986
987         Rubber-stamped by Ariya Hidayat.
988
989         Trivial crash fix in WTR.
990
991         * WebKitTestRunner/TestController.cpp:
992         (WTR::TestController::initialize): Increase the size
993         of the vector by one to be able to store the null character.
994
995 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
996
997         Reviewed by Csaba Osztrogonác.
998
999         [Qt][WK2] WTR should be initialized in the same way as DRT
1000         https://bugs.webkit.org/show_bug.cgi?id=53240
1001
1002         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1003         (WTR::activateFonts): Added missing initialization steps.
1004
1005 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1006
1007         Unreviewed. 
1008
1009         Adding myself to committers.py.
1010
1011         * Scripts/webkitpy/common/config/committers.py:
1012
1013 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1014
1015         Reviewed by Csaba Osztrogonác.
1016
1017         [Qt] [Symbian] Move project files into Source
1018         https://bugs.webkit.org/show_bug.cgi?id=52891
1019
1020         Fix the Symbian build after the project files
1021         are moved to Source directory. On Symbian qmake
1022         needs to run in the same directory where the main
1023         pro files (WebKit.pro, Tools.pro) are located.
1024
1025         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1026         is located before running qmake for Symbian. Qmake on Symbian
1027         does not properly honor the "-o" option, work it around by setting
1028         the name of the Makefile to bld.inf.
1029
1030 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1031
1032         Reviewed by Andreas Kling.
1033
1034         [Qt] Add simple zooming features to MiniBrowser
1035         https://bugs.webkit.org/show_bug.cgi?id=53231
1036
1037         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1038
1039         * MiniBrowser/qt/BrowserWindow.cpp:
1040         (BrowserWindow::BrowserWindow):
1041         (BrowserWindow::zoomIn):
1042         (BrowserWindow::zoomOut):
1043         (BrowserWindow::resetZoom):
1044         (BrowserWindow::updateUserAgentList):
1045         (BrowserWindow::applyZoom):
1046         * MiniBrowser/qt/BrowserWindow.h:
1047
1048 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1049
1050         Reviewed by Dan Bernstein.
1051
1052         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1053         https://bugs.webkit.org/show_bug.cgi?id=42319
1054         
1055         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1056
1057         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1058         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1059         (WTR::LayoutTestController::showWebInspector):
1060         (WTR::LayoutTestController::closeWebInspector):
1061         (WTR::LayoutTestController::evaluateInWebInspector):
1062         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1063         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1064         * WebKitTestRunner/TestInvocation.cpp:
1065         (WTR::shouldOpenWebInspector):
1066         (WTR::TestInvocation::invoke):
1067         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1068
1069 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1070
1071         Reviewed by Xan Lopez.
1072
1073         [GTK] Pixel dumps do not include scrollbars in output images
1074         https://bugs.webkit.org/show_bug.cgi?id=53216
1075
1076         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1077         that have scrollbars.
1078
1079         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1080         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1081         instead of the web view itself.
1082
1083 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1084
1085         Reviewed by Mihai Parparita.
1086
1087         Fix regression introduced in r76322 ... new-run-webkit-tests
1088         was attempting to save the image diff output as a UTF-8-encoded
1089         file.
1090
1091         https://bugs.webkit.org/show_bug.cgi?id=53210
1092
1093         * Scripts/webkitpy/layout_tests/port/webkit.py:
1094
1095 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1096
1097         Unreviewed, rolling out r76709.
1098         http://trac.webkit.org/changeset/76709
1099         https://bugs.webkit.org/show_bug.cgi?id=53194
1100
1101         "broke python tests on non-snowleopard platforms" (Requested
1102         by dpranke on #webkit).
1103
1104         * Scripts/webkitpy/layout_tests/port/factory.py:
1105         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1106         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1107
1108 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1109
1110         Reviewed by Tony Chang.
1111
1112         new-run-webkit-tests: add a "mock DRT" port implementation
1113         and a separate class that emulates what we expect the
1114         DumpRenderTree behavior to be.
1115
1116         This will eventually replace port/dryrun.py and allow us to get
1117         better test coverage of the new-run-webkit-tests code as well as
1118         a reference for what new-run-webkit-tests expects from DRT.
1119
1120         This is the first attempt at this, and it is pretty bare-boned. It
1121         really only has been tested on the 'mac' port (and a little on
1122         the 'chromium-mac' port.
1123
1124         https://bugs.webkit.org/show_bug.cgi?id=53126
1125
1126         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1127         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1128         * Scripts/webkitpy/layout_tests/port/factory.py:
1129
1130 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1131
1132         Reviewed by Tony Chang.
1133
1134         Add '--no-timeout' option to Chromium DRT to ease debugging.
1135         https://bugs.webkit.org/show_bug.cgi?id=52873
1136
1137         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1138         (main):
1139
1140 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1141
1142         Reviewed by Andreas Kling.
1143
1144         [Qt] Fix qt_minimal build
1145         https://bugs.webkit.org/show_bug.cgi?id=53172
1146
1147         * QtTestBrowser/locationedit.h:
1148
1149 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1150
1151         Reviewed by Antonio Gomes.
1152
1153         QtTestBrowser should have a UI Setting to disable plugins
1154         https://bugs.webkit.org/show_bug.cgi?id=52408
1155         
1156         Added a new action item named "Disable Plugins"
1157         under the "Settings" menu. 
1158
1159         * QtTestBrowser/launcherwindow.cpp:
1160         (LauncherWindow::createChrome):
1161         (LauncherWindow::togglePlugins):
1162         * QtTestBrowser/launcherwindow.h:
1163
1164 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1165
1166         Reviewed by Adam Barth.
1167
1168         Move main CMakeLists.txt into Source directory
1169         https://bugs.webkit.org/show_bug.cgi?id=52888
1170
1171         * Scripts/webkitdirs.pm:
1172
1173 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1174
1175         Reviewed by Eric Seidel.
1176
1177         Improve label text in submit-to-ews
1178         https://bugs.webkit.org/show_bug.cgi?id=53130
1179
1180         * QueueStatusServer/templates/submittoews.html:
1181
1182 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1183
1184         Reviewed by Antonio Gomes.
1185
1186         QtTestBrowser should have a UI Settings to prevent loading images
1187         https://bugs.webkit.org/show_bug.cgi?id=52409
1188         
1189         Added a new action item named "DisableAutoLoadImages"
1190         under the "Settings" menu 
1191
1192         * QtTestBrowser/launcherwindow.cpp:
1193         (LauncherWindow::createChrome):
1194         (LauncherWindow::toggleAutoLoadImages):
1195         * QtTestBrowser/launcherwindow.h:
1196
1197 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1198
1199         Reviewed by Tony Chang.
1200
1201         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1202         classes, test_expectations.py. This change adds "test-win" and
1203         "test-mac" variants to the test port so that we can better test
1204         rebaselining, and adds a MockUser() object for reuse in testing.
1205
1206         https://bugs.webkit.org/show_bug.cgi?id=53036
1207
1208         * Scripts/webkitpy/common/system/filesystem.py:
1209         * Scripts/webkitpy/common/system/filesystem_mock.py:
1210         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1211         * Scripts/webkitpy/layout_tests/port/factory.py:
1212         * Scripts/webkitpy/layout_tests/port/base.py:
1213         * Scripts/webkitpy/layout_tests/port/test.py:
1214         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1215         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1216         * Scripts/webkitpy/tool/mocktool.py:
1217
1218 2011-01-25  Tony Chang  <tony@chromium.org>
1219
1220         Reviewed by Dimitri Glazkov.
1221
1222         [chromium] remove unused layoutTestController callback
1223         https://bugs.webkit.org/show_bug.cgi?id=53103
1224
1225         This method is used by a test_shell_test, but not needed by DRT.
1226
1227         * DumpRenderTree/chromium/LayoutTestController.cpp:
1228         (LayoutTestController::LayoutTestController):
1229         * DumpRenderTree/chromium/LayoutTestController.h:
1230
1231 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1232
1233         Reviewed by Andreas Kling.
1234
1235         [GTK] Remove 64 bits release bot from the buildbot master
1236         https://bugs.webkit.org/show_bug.cgi?id=52899
1237
1238         Removes the 64 bits release slave from the buildbot configuration,
1239         so that we can use it as an EWS.
1240
1241         * BuildSlaveSupport/build.webkit.org-config/config.json:
1242
1243 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1244
1245         Reviewed by Dan Bernstein.
1246
1247         Implement database quota callback to fix storage tests on WebKit2 bot
1248         https://bugs.webkit.org/show_bug.cgi?id=53064
1249
1250         * WebKitTestRunner/TestController.cpp:
1251         (WTR::exceededDatabaseQuota):
1252         (WTR::TestController::createOtherPage):
1253         (WTR::TestController::initialize):
1254
1255 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1256
1257         Reviewed by Anders Carlsson.
1258
1259         Use designated temp directory for the database for WebKit2
1260         https://bugs.webkit.org/show_bug.cgi?id=53052
1261         
1262         Adopt the new WK2 API for this.
1263
1264         * WebKitTestRunner/TestController.cpp:
1265         (WTR::TestController::libraryPathForTesting):
1266         (WTR::TestController::initialize):
1267         * WebKitTestRunner/TestController.h:
1268         * WebKitTestRunner/mac/TestControllerMac.mm:
1269         (WTR::TestController::platformLibraryPathForTesting):
1270         * WebKitTestRunner/qt/TestControllerQt.cpp:
1271         (WTR::TestController::platformLibraryPathForTesting):
1272         * WebKitTestRunner/win/TestControllerWin.cpp:
1273         (WTR::TestController::platformLibraryPathForTesting):
1274
1275 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1276
1277         Reviewed by Stephanie Lewis.
1278
1279         Add a new Leopard test bot.
1280
1281         * BuildSlaveSupport/build.webkit.org-config/config.json:
1282
1283 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1284
1285         Reviewed by Adam Barth.
1286
1287         Add EFL Builder to core waterfall
1288         https://bugs.webkit.org/show_bug.cgi?id=52704
1289
1290         Add EFL Builder to the core waterfall again.
1291
1292         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1293         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1294
1295 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1296
1297         Reviewed by Tony Chang.
1298
1299         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1300         https://bugs.webkit.org/show_bug.cgi?id=52872
1301
1302         Force disabling proxy to resolve the problem.
1303
1304         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1305         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1306
1307 2011-01-24  Andreas Kling  <kling@webkit.org>
1308
1309         Reviewed by Darin Adler.
1310
1311         check-webkit-style: Update exemptions following Source/ move.
1312         https://bugs.webkit.org/show_bug.cgi?id=53017
1313
1314         * Scripts/webkitpy/style/checker.py:
1315         * Scripts/webkitpy/style/checker_unittest.py:
1316
1317 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1318
1319         Rubber-stamped by Csaba Osztrogonác.
1320
1321         [Qt] Move project files into Source
1322         https://bugs.webkit.org/show_bug.cgi?id=52891
1323
1324         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1325
1326 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1327
1328         Reviewed by Yury Semikhatsky.
1329
1330         Web Inspector: Find duplicate strings in localizedStrings.js
1331
1332         https://bugs.webkit.org/show_bug.cgi?id=53005
1333
1334         * Scripts/check-inspector-strings:
1335
1336 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1337
1338         Reviewed by Andreas Kling.
1339
1340         [Qt] Regroup MiniBrowser's menubar and add open file action
1341         https://bugs.webkit.org/show_bug.cgi?id=53000
1342
1343         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1344
1345         * MiniBrowser/qt/BrowserWindow.cpp:
1346         (BrowserWindow::BrowserWindow):
1347         (BrowserWindow::openFile):
1348         (BrowserWindow::~BrowserWindow):
1349         * MiniBrowser/qt/BrowserWindow.h:
1350
1351 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1352
1353         Unreviewed fix after r76496
1354
1355         [Qt] Move project files into Source
1356         https://bugs.webkit.org/show_bug.cgi?id=52891
1357
1358         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1359         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1360         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1361
1362 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1363
1364         Reviewed by Csaba Osztrogonác.
1365
1366         [Qt] Move project files into Source
1367         https://bugs.webkit.org/show_bug.cgi?id=52891
1368
1369         * DerivedSources.pro: Renamed from DerivedSources.pro.
1370         * DumpRenderTree/qt/DumpRenderTree.pro:
1371         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1372         * MiniBrowser/DerivedSources.pro:
1373         * MiniBrowser/qt/MiniBrowser.pro:
1374         * QtTestBrowser/QtTestBrowser.pro:
1375         * Scripts/webkitdirs.pm:
1376         * Tools.pro: Added.
1377         * WebKitTestRunner/DerivedSources.pro:
1378         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1379         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1380
1381 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1382
1383         Reviewed by Dan Bernstein.
1384
1385         Beefed up --threaded mode to catch even more kinds of errors.
1386         https://bugs.webkit.org/show_bug.cgi?id=52971
1387
1388         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1389         context group to force JSC to mark multiple threads. (This used to be
1390         the default, but it changed in SnowLeopard.)
1391         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1392         to give threading mistakes more chances to show themselves.
1393         (startJavaScriptThreads):
1394         (stopJavaScriptThreads):
1395
1396 2011-01-22  Robert Hogan  <robert@webkit.org>
1397
1398         Reviewed by Andreas Kling.
1399
1400         [Qt] Support layoutTestController.addURLToRedirect()
1401         https://bugs.webkit.org/show_bug.cgi?id=52956
1402
1403         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1404         (LayoutTestController::addURLToRedirect):
1405         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1406
1407 2011-01-22  Robert Hogan  <robert@webkit.org>
1408
1409         Reviewed by Kenneth Rohde Christiansen.
1410
1411         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1412         https://bugs.webkit.org/show_bug.cgi?id=49802
1413
1414         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1415         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1416         (WebCore::DumpRenderTree::open):
1417
1418 2011-01-21  Adam Barth  <abarth@webkit.org>
1419
1420         Reviewed by Maciej Stachowiak.
1421
1422         Disable mac_unittest.py that fails on some of the Mac bots
1423         https://bugs.webkit.org/show_bug.cgi?id=52947
1424
1425         As noted in the comment, this test does not appear to be correct
1426         because the function this test is testing returns different results
1427         depending on which flavor of Mac the test is run on.  This patch
1428         disable the test.  Hopefully we can re-enable the test once we've
1429         probably insulated the test from its environment.
1430
1431         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1432
1433 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1434
1435         Reviewed by Mihai Parparita.
1436
1437         Fix bug introduced in r76322 that caused NRWT to not actually
1438         read the Skipped files properly.
1439
1440         https://bugs.webkit.org/show_bug.cgi?id=52771
1441
1442         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1443         * Scripts/webkitpy/layout_tests/port/webkit.py:
1444         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1445
1446 2011-01-21  Sam Weinig  <sam@webkit.org>
1447
1448         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1449
1450         WebKitTestRunner needs the HOME environment variable to be set.
1451         <rdar://problem/8896573>
1452
1453         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1454         it exists.
1455
1456 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1457
1458         Reviewed by Eric Seidel.
1459
1460         Suppress a few remaining integration tests so that none of the
1461         layout_test unit tests ever read from the filesystem or launch
1462         subprocesses that aren't part of the unit tests.
1463
1464         Also fix a minor bug in the printing unit tests that was
1465         incorrectly relying on sys.argv.
1466
1467         https://bugs.webkit.org/show_bug.cgi?id=52863
1468
1469         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1470         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1471         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1472
1473 2011-01-21  Darin Adler  <darin@apple.com>
1474
1475        Fix Mac build.
1476
1477         * MiniBrowser/mac/BrowserWindowController.m:
1478         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1479
1480 2011-01-20  Darin Adler  <darin@apple.com>
1481
1482         Reviewed by Dan Bernstein.
1483
1484         WebKit2: Implement showModalDialog
1485         https://bugs.webkit.org/show_bug.cgi?id=52855
1486
1487         This fixes WebKitTestRunner to compile, but more work is probably
1488         needed to get it to pass the tests.
1489
1490         * WebKitTestRunner/TestController.cpp:
1491         (WTR::TestController::runModal): Added. Calls through to the
1492         platform-specific version of runModal.
1493         (WTR::TestController::createOtherPage): Changed to be a private
1494         static member function so it can refer to runModal, which is
1495         a private static member function.
1496         (WTR::TestController::initialize): Pass 0 for the runModal
1497         function since we don't need to run the main window modal.
1498         I suspect this is wrong and will need to change.
1499         * WebKitTestRunner/TestController.h: Added declarations for
1500         the functions added above.
1501         * WebKitTestRunner/mac/TestControllerMac.mm:
1502         (WTR::TestController::runModal): Added. Untested implementation.
1503         * WebKitTestRunner/qt/TestControllerQt.cpp:
1504         (WTR::TestController::runModal): Added.
1505         * WebKitTestRunner/win/TestControllerWin.cpp:
1506         (WTR::TestController::runModal): Added.
1507
1508 2011-01-21  Eric Seidel  <eric@webkit.org>
1509
1510         Reviewed by Adam Barth.
1511
1512         Split Host object off from WebKitPatch for easier re-use
1513         https://bugs.webkit.org/show_bug.cgi?id=52284
1514
1515         new-run-webkit-tests and other tools are eventually going to want one of these.
1516         Basically you need to inherit from this class if you want to pretend to be a
1517         self.tool object for Steps/Commands.
1518
1519         * Scripts/webkitpy/common/host.py: Added.
1520         * Scripts/webkitpy/tool/main.py:
1521
1522 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1523
1524         Reviewed by Adam Barth.
1525
1526         Disable the tests that start and stop the http server and web
1527         server, so that we don't have to worry about port collisions on
1528         the bots.
1529
1530         https://bugs.webkit.org/show_bug.cgi?id=52861
1531
1532         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1533
1534 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1535
1536         Reviewed by Eric Seidel.
1537
1538         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1539         
1540         https://bugs.webkit.org/show_bug.cgi?id=52772
1541         
1542         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1543
1544 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1545
1546         Reviewed by Eric Siedel.
1547
1548         nrwt: clean up almost all remaining port references, remove
1549         unnecessary import clauses. The only remaining references are
1550         in places where a mock filesystem makes no sense or can't be
1551         used, and in one routine in port/google_chrome_unittest that
1552         I'll rewrite in a separate patch.
1553
1554         https://bugs.webkit.org/show_bug.cgi?id=52771
1555
1556         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1557         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1558         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1559         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1560         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1561         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1562         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1563         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1564         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1565         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1566         * Scripts/webkitpy/layout_tests/port/gtk.py:
1567         * Scripts/webkitpy/layout_tests/port/mac.py:
1568         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1569         * Scripts/webkitpy/layout_tests/port/qt.py:
1570         * Scripts/webkitpy/layout_tests/port/webkit.py:
1571         * Scripts/webkitpy/layout_tests/port/win.py:
1572         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1573
1574 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1575
1576         Reviewed by Mihai Parparita.
1577
1578         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1579
1580         https://bugs.webkit.org/show_bug.cgi?id=52762
1581
1582         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1583         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1584
1585 2011-01-20  Tony Chang  <tony@chromium.org>
1586
1587         Reviewed by Ojan Vafai.
1588
1589         [chromium] fix the paths used for the rebaseline tool
1590         https://bugs.webkit.org/show_bug.cgi?id=52857
1591
1592         Some of the bots were renamed so the path to grab the results zip
1593         file has changed.
1594
1595         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1596
1597 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1598
1599         Reviewed by Tony Chang.
1600
1601         Fix bug introduced in r72688 / bug 52768 that broke the
1602         generation of the output filename links in the results.html
1603         output. Apparently none of the unit tests actually checked to
1604         make sure the generated links were correct :(
1605
1606         https://bugs.webkit.org/show_bug.cgi?id=52854
1607
1608         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1609         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1610
1611 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1612
1613         Reviewed by Darin Adler.
1614
1615         https://bugs.webkit.org/show_bug.cgi?id=52849
1616         Make window.print work with WebKit2
1617
1618         * MiniBrowser/mac/BrowserWindowController.m:
1619         (-[BrowserWindowController awakeFromNib]):
1620         * WebKitTestRunner/TestController.cpp:
1621         (WTR::createOtherPage):
1622         (WTR::TestController::initialize):
1623         Added zeroes to WKPageUIClient structures to avoid build failures.
1624
1625 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1626
1627         Reviewed by Eric Seidel.
1628
1629         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1630
1631         https://bugs.webkit.org/show_bug.cgi?id=52756
1632
1633         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1634         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1635         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1636         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1637         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1638         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1639
1640 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1641
1642         Reviewed by Antonio Gomes.
1643
1644         QtTestBrowser should have a seperate menu for Settings
1645         https://bugs.webkit.org/show_bug.cgi?id=52817
1646         
1647         Added a new menu item named "Settings"
1648         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1649
1650         * QtTestBrowser/launcherwindow.cpp:
1651         (LauncherWindow::createChrome):
1652
1653 2011-01-20  Sam Weinig  <sam@webkit.org>
1654
1655         Reviewed by John Sullivan.
1656
1657         Update update-webkit-localizable-strings with new path to WebKit.
1658
1659         * Scripts/update-webkit-localizable-strings:
1660
1661 2011-01-20  James Robinson  <jamesr@chromium.org>
1662
1663         Reviewed by Darin Fisher.
1664
1665         Implement mozilla's requestAnimationFrame API
1666         https://bugs.webkit.org/show_bug.cgi?id=51218
1667
1668         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1669
1670         * DumpRenderTree/chromium/WebViewHost.cpp:
1671         (invokeScheduleComposite):
1672         (WebViewHost::scheduleAnimation):
1673         (WebViewHost::paintInvalidatedRegion):
1674         * DumpRenderTree/chromium/WebViewHost.h:
1675
1676 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1677
1678         Reviewed by Adam Roben.
1679
1680         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1681         https://bugs.webkit.org/show_bug.cgi?id=42327
1682
1683         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1684         for methods that take their normal arguments but also a JSContextRef.
1685         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1686         for evaluateScriptInIsolatedWorld.
1687         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1688         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1689         this call is for an isolated world.
1690         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1691         (WTR::worldMap): Helper to create a world map.
1692         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1693         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1694         added LayoutTestController API.
1695         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1696
1697 2011-01-19  Adam Roben  <aroben@apple.com>
1698
1699         Convert paths in environment variables back to msys-style inside commit-log-editor
1700
1701         When this script gets run from inside git commit, msys-style paths in the environment will
1702         have been turned into Windows-style paths with forward slashes. This screws up functions
1703         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1704         the paths back to msys-style before doing anything else.
1705
1706         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1707         using msysgit's Perl and multiple ChangeLogs have been edited
1708
1709         Reviewed by David Kilzer.
1710
1711         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1712         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1713         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1714
1715 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1716
1717         [Win] Unreviewed build fix after r76248.
1718
1719         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1720
1721 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1722
1723         Reviewed by Csaba Osztrogonác.
1724
1725         Refactoring of the custom allocation framework
1726         https://bugs.webkit.org/show_bug.cgi?id=49897
1727
1728         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1729         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1730         equivalent macro implementation at the necessary places.
1731 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1732
1733         Unreviewed. 
1734
1735         Adding myself to committers.py.
1736
1737         * Scripts/webkitpy/common/config/committers.py:
1738
1739 2011-01-20  Adam Barth  <abarth@webkit.org>
1740
1741         Reviewed by Tony Chang.
1742
1743         Chromium builders don't delete unversioned directories when DEPS change
1744         https://bugs.webkit.org/show_bug.cgi?id=52745
1745
1746         If we pass this option to gclient sync, gclient will delete directories
1747         that are no longer part of DEPS instead of leaving them around to
1748         confuse us later.  Apparently, the downstream buildbots use this option
1749         already.
1750
1751         * Scripts/update-webkit-chromium:
1752
1753 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1754
1755         Unreviewed, build fix - I pulled this patch in to fix an issue
1756         revealed by r76195 running on some new bots). Also fix a couple
1757         of other issues revealed in testing.
1758
1759         nrwt: remove fs refs from layout_package/json*
1760
1761         https://bugs.webkit.org/show_bug.cgi?id=52754
1762
1763         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1764         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1765         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1766         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1767         * Scripts/webkitpy/layout_tests/port/base.py:
1768
1769 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1770
1771         Unreviewed, build fix.
1772
1773         Fix a couple of minor bugs discovered while bringing up new bots
1774         for testing.
1775
1776         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1777         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1778
1779 2011-01-19  James Robinson  <jamesr@chromium.org>
1780
1781         Unreviewed, rolling out r76194.
1782         http://trac.webkit.org/changeset/76194
1783         https://bugs.webkit.org/show_bug.cgi?id=51218
1784
1785         Caused mysterious compile failure on the chromium win
1786         build.webkit.org bots
1787
1788         * DumpRenderTree/chromium/WebViewHost.cpp:
1789         (WebViewHost::paintInvalidatedRegion):
1790         * DumpRenderTree/chromium/WebViewHost.h:
1791
1792 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1793
1794         Reviewed by Mihai Parparita.
1795
1796         remove fs refs from test_runner, dump_render_tree_thread
1797
1798         https://bugs.webkit.org/show_bug.cgi?id=52753
1799
1800         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1801         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1802         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1803         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1804
1805 2011-01-19  James Robinson  <jamesr@chromium.org>
1806
1807         Reviewed by Darin Fisher.
1808
1809         Implement mozilla's requestAnimationFrame API
1810         https://bugs.webkit.org/show_bug.cgi?id=51218
1811
1812         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1813
1814         * DumpRenderTree/chromium/WebViewHost.cpp:
1815         (invokeScheduleComposite):
1816         (WebViewHost::scheduleAnimation):
1817         (WebViewHost::paintInvalidatedRegion):
1818         * DumpRenderTree/chromium/WebViewHost.h:
1819
1820 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1821
1822         Unreviewed, build fix.
1823
1824         Fix a few incorrect "self._filesystem" references introduced in
1825         r76184.
1826
1827         * Scripts/webkitpy/layout_tests/port/chromium.py:
1828         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1829
1830 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1831
1832         Reviewed by Mihai Parparita.
1833
1834         add a .sep property, abspath(), isabs(), mtime(), and
1835         open_text_file_for_writing() to filesystem modules. Some of
1836         these properties are not needed in this patch but will be needed
1837         in subsequent patches (I'm doing this to avoid having to track
1838         multiple versions of a single file).
1839
1840         Also, change most of the port/* modules to use the filesystem
1841         objects instead of referencing the filesystem directly.
1842
1843         https://bugs.webkit.org/show_bug.cgi?id=52748
1844
1845         * Scripts/webkitpy/common/system/filesystem.py:
1846         * Scripts/webkitpy/common/system/filesystem_mock.py:
1847         * Scripts/webkitpy/layout_tests/port/__init__.py:
1848         * Scripts/webkitpy/layout_tests/port/base.py:
1849         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1850         * Scripts/webkitpy/layout_tests/port/chromium.py:
1851         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1852         * Scripts/webkitpy/layout_tests/port/config.py:
1853         * Scripts/webkitpy/layout_tests/port/test.py:
1854         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1855
1856 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1857
1858         Reviewed by Anders Carlsson.
1859
1860         If resetting between tests times out, treat it as a WebProcess crash
1861         https://bugs.webkit.org/show_bug.cgi?id=52757
1862
1863         * WebKitTestRunner/TestController.cpp:
1864         (WTR::TestController::runTest):
1865
1866 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1867
1868         Reviewed by Darin Adler.
1869
1870         https://bugs.webkit.org/show_bug.cgi?id=52739
1871         Make it possible for a WebKit2 client to print headers and footers
1872
1873         Added dummy implementations for new printing UIClient calls.
1874
1875         * MiniBrowser/mac/BrowserWindowController.m:
1876         (-[BrowserWindowController awakeFromNib]):
1877         * WebKitTestRunner/TestController.cpp:
1878         (WTR::createOtherPage):
1879         (WTR::TestController::initialize):
1880
1881 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1882
1883         Reviewed by Ojan Vafai.
1884
1885         Change webkitpy/layout_tests/port/test.py to use the
1886         in-memory filesystem for cleaner unit testing. This
1887         change allows us to kill a lot of code that was
1888         specific to the test port, at the cost of being a
1889         little less clear about how things would work if
1890         you didn't have a filesystem.
1891
1892         https://bugs.webkit.org/show_bug.cgi?id=52605
1893
1894         * Scripts/webkitpy/layout_tests/port/test.py:
1895
1896 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1897
1898         Unreviewed, build fix.
1899
1900         Fix test failure caused by committing attachment 79368 instead
1901         of attachment 79461 on bug 52604.
1902
1903         * Scripts/webkitpy/common/system/filesystem_mock.py:
1904
1905 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1906
1907         Reviewed by Mihai Parparita.
1908
1909         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1910         unit testing. os.walk() is too much of a hassle to implement on
1911         top of the in-memory mock filesystem and adding the necessary
1912         interface to files_under() gives clients a cleaner API anyway
1913         (for this particular usage model).
1914
1915         https://bugs.webkit.org/show_bug.cgi?id=52691
1916
1917         * Scripts/webkitpy/common/system/filesystem.py:
1918         * Scripts/webkitpy/common/system/filesystem_mock.py:
1919         * Scripts/webkitpy/layout_tests/port/test_files.py:
1920         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1921
1922 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1923
1924         Reviewed by Tony Chang.
1925
1926         Change more modules in the layout-tests code to use the
1927         filesystem wrapper for cleaner unit testing.
1928
1929         This patch also adds the glob() wrapper to the filesystem
1930         abstraction.
1931         
1932         https://bugs.webkit.org/show_bug.cgi?id=52604
1933
1934         * Scripts/webkitpy/layout_tests/port/test_files.py:
1935         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1936         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1937         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1938         * Scripts/webkitpy/common/system/filesystem.py:
1939         * Scripts/webkitpy/common/system/filesystem_mock.py:
1940
1941 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1942
1943         Unreviewed.
1944
1945         Updating my email addresses and irc nick.
1946
1947         * Scripts/webkitpy/common/config/committers.py:
1948
1949 2011-01-19  Tony Chang  <tony@chromium.org>
1950
1951         Reviewed by Mihai Parparita.
1952
1953         [chromium] [linux] if check-sys-deps fails, output the failure reason
1954         https://bugs.webkit.org/show_bug.cgi?id=52671
1955
1956         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1957             error handler functions.
1958         * Scripts/webkitpy/layout_tests/port/chromium.py:
1959             output the error text from --check-sys-deps
1960         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1961
1962 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1963
1964         Reviewed by Andreas Kling.
1965
1966         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1967         https://bugs.webkit.org/show_bug.cgi?id=52554
1968         
1969         QtNetworkAccessManager is created in a thread and set as
1970         member variable in QWebPage. When the thread is destroyed
1971         the object is still used. So fix will set the object to
1972         NULL once the thread is destroyed.
1973
1974         * QtTestBrowser/launcherwindow.cpp:
1975         (LauncherWindow::~LauncherWindow):
1976
1977 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1978
1979         Rubber stamped by Csaba Osztrogonac
1980
1981         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1982
1983 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1984
1985         Reviewed by Tony Chang.
1986
1987         new-run-webkit-tests: add a --build-directory command line argument
1988
1989         Official Google Chrome builds use a non-standard build directory
1990         location. This patch adds a --build-directory argument that
1991         allows that location to be specified on the command line. Only
1992         Chromium-based builds will use this flag for now, but anyone can
1993         in the future.
1994
1995         There are no unit tests for this since it's difficult to test
1996         until mock filesystems are fully supported in the code. This was
1997         tested by hand for now.
1998
1999         https://bugs.webkit.org/show_bug.cgi?id=52694
2000
2001         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2002         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2003         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2004         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2005
2006 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2007
2008         Not reviewed. Bot fix.
2009
2010         Remove an inadvertently committed debugging print.
2011
2012         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2013         (LayoutTestController::notifyDone):
2014
2015 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2016
2017         Reviewed by Sam Weinig.
2018
2019         WebKitTestRunner should track loading more like DumpRenderTree
2020         https://bugs.webkit.org/show_bug.cgi?id=52692
2021
2022         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2023         This makes some tests that call notifyDone multiple times pass.
2024         
2025         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2026         (WTR::InjectedBundle::InjectedBundle):
2027         (WTR::InjectedBundle::done):
2028         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2029         (WTR::InjectedBundle::topLoadingFrame):
2030         (WTR::InjectedBundle::setTopLoadingFrame):
2031         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2032         (WTR::InjectedBundlePage::InjectedBundlePage):
2033         (WTR::InjectedBundlePage::stopLoading):
2034         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2035         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2036         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2037         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2038         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2039         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2040         (WTR::LayoutTestController::notifyDone):
2041         * WebKitTestRunner/TestController.cpp:
2042         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2043
2044 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2045
2046         Reviewed by Kent Tamura.
2047
2048         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2049         https://bugs.webkit.org/show_bug.cgi?id=52678
2050         
2051         Update path now that WebKit is inside Source.
2052
2053         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2054
2055 2011-01-18  Robert Hogan  <robert@webkit.org>
2056
2057         Reviewed by Simon Hausmann.
2058
2059         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2060         https://bugs.webkit.org/show_bug.cgi?id=44282
2061
2062         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2063         (WebCore::DumpRenderTree::dump):
2064
2065 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2066
2067         Reviewed by Mihai Parparita.
2068
2069         Fix a small race condition that could cause the unit tests for
2070         new-run-webkit-tests to fail in a multithreaded environment.
2071         There was a small window in the code where one thread would
2072         check to see if a thread had raised an exception, do something,
2073         and then check to see if the thread was alive. If the other
2074         thread raised an exception and exited in between these two
2075         steps, the exception would be lost. Flipping the order of the
2076         two checks fixes the race, since we will now always check for an
2077         exception on the thread before exiting.
2078
2079         https://bugs.webkit.org/show_bug.cgi?id=51579
2080
2081         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2082
2083 2011-01-18  Eric Seidel  <eric@webkit.org>
2084
2085         Reviewed by Adam Barth.
2086
2087         commit-queue dies when test archiving fails
2088         https://bugs.webkit.org/show_bug.cgi?id=52617
2089
2090         I looked at the machine and it had 10 archives already
2091         thus find_unused_name was returning None.  I've upped
2092         the limit to 100 (per bug) and tested the case where
2093         find_unused_name returns None (making archive return None).
2094
2095         * Scripts/webkitpy/common/system/workspace.py:
2096         * Scripts/webkitpy/common/system/workspace_unittest.py:
2097         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2098         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2099         * Scripts/webkitpy/tool/commands/queues.py:
2100
2101 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2102
2103         Reviewed by Ojan Vafai.
2104
2105         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2106         filesystem. Also fix a couple of "with" statements missed by
2107         r76050.
2108
2109         https://bugs.webkit.org/show_bug.cgi?id=52487
2110
2111         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2112
2113 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2114
2115         Reviewed by Martin Robinson.
2116
2117         [Gtk] Build fixes for gtk3 build
2118         https://bugs.webkit.org/show_bug.cgi?id=52648
2119
2120         * DumpRenderTree/gtk/EventSender.cpp:
2121         (beginDragWithFilesCallback):
2122
2123 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2124
2125         Reviewed by Mihai Parparita.
2126
2127         Update rebaseline-chromium-webkit-tests to use filesystem objects
2128         instead of direct references to os.path, shutil, tempfile, etc.
2129
2130         This patch doesn't change anything, but will allow subsequent
2131         patches to change the unit tests to no longer use the real
2132         filesystem.
2133
2134         This patch adds a bunch more methods to the filesystem object as
2135         well.
2136
2137         https://bugs.webkit.org/show_bug.cgi?id=52482
2138
2139         * Scripts/webkitpy/common/system/filesystem.py:
2140         * Scripts/webkitpy/common/system/filesystem_mock.py:
2141         * Scripts/webkitpy/tool/commands/queues.py:
2142         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2143         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2144
2145 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2146
2147         Reviewed by Mihai Parparita.
2148
2149         new-run-webkit-tests shouldn't crash when you try to run a
2150         directory containing only skipped files.
2151
2152         https://bugs.webkit.org/show_bug.cgi?id=52478
2153         
2154         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2155         * Scripts/webkitpy/layout_tests/port/test.py:
2156         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2157
2158 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2159
2160         Reviewed by Gustavo Noronha Silva.
2161
2162         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2163         https://bugs.webkit.org/show_bug.cgi?id=40833
2164
2165         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2166         GTK+ event sender.
2167         (dragWithFilesDragDataGetCallback): Added.
2168         (dragWithFilesDragEndCallback): Added.
2169         (beginDragWithFilesCallback): Added.
2170
2171 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2172
2173         Reviewed by Adam Barth.
2174
2175         ews: Add additional watcher to efl ews
2176         https://bugs.webkit.org/show_bug.cgi?id=52613
2177
2178         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2179
2180         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2181
2182 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2183
2184         Reviewed by Alexey Proskuryakov.
2185
2186         Fix some headers with missing or misspelled #ifndef guards
2187         https://bugs.webkit.org/show_bug.cgi?id=52545
2188
2189         * DumpRenderTree/chromium/TestEventPrinter.h:
2190         * DumpRenderTree/chromium/WebPreferences.h:
2191
2192 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2193
2194         Reviewed by Anders Carlsson.
2195
2196         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2197         navigating back to an unreachable URL
2198         https://bugs.webkit.org/show_bug.cgi?id=52388
2199
2200         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2201
2202         * DumpRenderTree/LayoutTestController.cpp:
2203         (queueLoadHTMLStringCallback):
2204         (LayoutTestController::queueLoadHTMLString):
2205         (LayoutTestController::queueLoadAlternateHTMLString):
2206         * DumpRenderTree/LayoutTestController.h:
2207
2208         * DumpRenderTree/WorkQueueItem.h:
2209         (LoadHTMLStringItem::LoadHTMLStringItem):
2210
2211         * DumpRenderTree/chromium/LayoutTestController.cpp:
2212         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2213         (WorkItemLoadHTMLString::run):
2214         (LayoutTestController::queueLoadHTMLString):
2215
2216         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2217         (LoadHTMLStringItem::invoke):
2218         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2219         (LoadHTMLStringItem::invoke):
2220         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2221         (LoadHTMLStringItem::invoke):
2222
2223 2011-01-17  Dan Bernstein  <mitz@apple.com>
2224
2225         Rubber-stamped by Mark Rowe.
2226
2227         Update xcodeproj svn:ignore to include xcuserdata.
2228
2229         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2230         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2231         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2232         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2233         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2234
2235 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2236
2237         Unreviewed fix after r75908.
2238
2239         Move WebKit into Source
2240         https://bugs.webkit.org/show_bug.cgi?id=52530
2241
2242         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2243
2244 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2245
2246         Unreviewed.
2247
2248         Remove accidentally committed debug printing after r75908.
2249
2250         * Scripts/webkitdirs.pm:
2251
2252 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2253
2254         Unreviewed.
2255
2256         Add myself to committers list
2257         https://bugs.webkit.org/show_bug.cgi?id=52566
2258
2259         * Scripts/webkitpy/common/config/committers.py:
2260
2261 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2262
2263         Reviewed by Jeremy Orlow.
2264
2265         GeolocationController should call stopUpdating on destruction
2266         https://bugs.webkit.org/show_bug.cgi?id=52216
2267
2268         fast/dom/Geolocation/window-close-crash.html requires that a
2269         Geolocation watch be started in a secondary window. Consequently,
2270         we need to allow geolocation permission and provide a mock
2271         geolocation position for the secondary window's
2272         GeolocationClientMock.
2273
2274         * DumpRenderTree/chromium/LayoutTestController.cpp:
2275         (LayoutTestController::setGeolocationPermission):
2276         (LayoutTestController::setMockGeolocationPosition):
2277         (LayoutTestController::setMockGeolocationError):
2278         * DumpRenderTree/chromium/TestShell.h:
2279         (TestShell::windowList):
2280
2281 2011-01-16  Adam Barth  <abarth@webkit.org>
2282
2283         Update more include paths to reflect WebKit move.
2284
2285         * DumpRenderTree/chromium/EventSender.cpp:
2286         (EventSender::keyDown):
2287         (EventSender::needsShiftModifier):
2288         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2289         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2290
2291 2011-01-16  Kent Tamura  <tkent@chromium.org>
2292
2293         Unreviewed, Chromium build fix.
2294
2295         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2296
2297 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2298
2299         Build fix for GTK+ after source directory movement.
2300
2301         * GNUmakefile.am: Correct include paths.
2302
2303 2011-01-16  Adam Barth  <abarth@webkit.org>
2304
2305         Teach svn-apply about WebKit move.
2306
2307         * Scripts/VCSUtils.pm:
2308
2309 2011-01-16  Adam Barth  <abarth@webkit.org>
2310
2311         Rubber-stamped by Eric Seidel.
2312
2313         Move WebKit into Source
2314         https://bugs.webkit.org/show_bug.cgi?id=52530
2315
2316         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2317         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2318         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2319         * DumpRenderTree/qt/GCControllerQt.cpp:
2320         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2321         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2322         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2323         * DumpRenderTree/wscript:
2324         * QtTestBrowser/launcherwindow.h:
2325         * Scripts/build-webkit:
2326         * Scripts/webkitdirs.pm:
2327
2328 2011-01-15  Adam Barth  <abarth@webkit.org>
2329
2330         Teach svn-apply about WebKit2 move.
2331
2332         * Scripts/VCSUtils.pm:
2333
2334 2011-01-15  Adam Barth  <abarth@webkit.org>
2335
2336         Rubber-stamped by Eric Seidel.
2337
2338         Move WebKit2 into Source
2339         https://bugs.webkit.org/show_bug.cgi?id=52438
2340
2341         * MiniBrowser/qt/MiniBrowser.pro:
2342         * Scripts/build-webkit:
2343         * Scripts/do-file-rename:
2344         * Scripts/do-webcore-rename:
2345         * Scripts/test-webkitpy:
2346         * Scripts/webkitdirs.pm:
2347         * Scripts/webkitpy/style/checker.py:
2348         * WebKitTestRunner/DerivedSources.pro:
2349         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2350         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2351
2352 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2353
2354         Reviewed by David Levin.
2355
2356         [chromium] remove obsolete createView method
2357         https://bugs.webkit.org/show_bug.cgi?id=52437
2358
2359         * DumpRenderTree/chromium/WebViewHost.cpp:
2360         (WebViewHost::createView):
2361         * DumpRenderTree/chromium/WebViewHost.h:
2362
2363 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2364
2365         Reviewed by Geoff Garen.
2366
2367         ShouldLoadResourceForFrame should use strings, not URLs.
2368         https://bugs.webkit.org/show_bug.cgi?id=52476
2369
2370         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2371         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2372         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2373
2374 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2375
2376         Reviewed by David Levin.
2377
2378         Add Tony Gentilcore as a reviewer
2379         https://bugs.webkit.org/show_bug.cgi?id=52480
2380
2381         * Scripts/webkitpy/common/config/committers.py:
2382
2383 2011-01-14  David Levin  <levin@chromium.org>
2384
2385         Reviewed by Eric Seidel.
2386
2387         check-webkit-style: _FunctionState should keep track of where the function name starts.
2388         https://bugs.webkit.org/show_bug.cgi?id=52454
2389
2390         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2391         _FunctionState and logic for setting it correctly.
2392         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2393
2394 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2395
2396         Reviewed by David Levin.
2397
2398         Add support to DumpRenderTree to use the GPU rather than software renderer
2399         https://bugs.webkit.org/show_bug.cgi?id=52333
2400
2401         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2402         (main):
2403         * Scripts/webkitpy/layout_tests/port/chromium.py:
2404         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2405
2406 2011-01-14  Tony Chang  <tony@chromium.org>
2407
2408         Reviewed by Kent Tamura.
2409
2410         [chromium] update fonts.conf to fix 6 linux tests in drt
2411         https://bugs.webkit.org/show_bug.cgi?id=52411
2412
2413         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2414             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2415
2416 2011-01-14  Eric Seidel  <eric@webkit.org>
2417
2418         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2419
2420         Reviewed by Adam Barth.
2421
2422         Fix when running Tools/Scripts/check-webkit-style without arguments.
2423         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2424
2425         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2426         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2427
2428 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2429
2430         Reviewed by David Levin.
2431
2432         Store the tempdir object in a variable so it doesn't get deleted too early.
2433         https://bugs.webkit.org/show_bug.cgi?id=51875
2434
2435         * Scripts/update-webkit-auxiliary-libs:
2436         * Scripts/update-webkit-support-libs:
2437
2438 2011-01-14  Eric Seidel  <eric@webkit.org>
2439
2440         Unreviewed.  Make it work in python 2.5.
2441
2442         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2443         https://bugs.webkit.org/show_bug.cgi?id=49158
2444
2445         * Scripts/webkitpy/common/checkout/api_unittest.py:
2446
2447 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2448
2449         Unreviewed, rolling out r75774.
2450         http://trac.webkit.org/changeset/75774
2451         https://bugs.webkit.org/show_bug.cgi?id=52431
2452
2453         gtk builds were broken (Requested by loislo2 on #webkit).
2454
2455         * Scripts/webkitpy/common/checkout/scm.py:
2456
2457 2011-01-14  David Levin  <levin@chromium.org>
2458
2459         Reviewed by Shinichiro Hamaji.
2460
2461         check-webkit-style: _FunctionState should detect pure functions.
2462         https://bugs.webkit.org/show_bug.cgi?id=52428
2463
2464         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2465         is a pure virtual function.
2466         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2467         virtual functions are correctly detected.
2468
2469 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2470
2471         Reviewed by Yury Semikhatsky.
2472
2473         Just small fix for problem with check-webkit-style.
2474         It just didn't work for this patch.
2475         Old code can't concatenate a list of strings with None.
2476
2477         * Scripts/webkitpy/common/checkout/scm.py:
2478
2479 2011-01-13  David Levin  <levin@chromium.org>
2480
2481         Reviewed by Shinichiro Hamaji.
2482
2483         check-webkit-style: _FunctionState should use Position to know where items are.
2484         https://bugs.webkit.org/show_bug.cgi?id=52424
2485
2486         * Scripts/webkitpy/style/checkers/cpp.py:
2487         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2488         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2489         did some minor clean-up.
2490         (*): Other changes are simply about converting to use the Position's in_FunctionState
2491         instead of line numbers.
2492         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2493         to verify the positions stored in _FunctionState.
2494
2495 2011-01-13  Eric Seidel  <eric@webkit.org>
2496
2497         Reviewed by David Levin.
2498
2499         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2500         https://bugs.webkit.org/show_bug.cgi?id=49158
2501
2502         This is not the most elegant, but it is a very safe fix to this bug.
2503         One advantage of catching ScriptError like this instead of adding a
2504         new added_or_modified_files or fixing all changed_files callers
2505         to use a more specific change_files variant, is that we catch
2506         all kinds of ScriptErrors which might cause our (non-essential)
2507         suggest-reviewers code to fail out.  This should make passing
2508         --suggest-reviewers to webkit-patch upload much more robust
2509         and may even make it possible for us to make it default.
2510
2511         The root of the problem here is that SCM.changed_files includes
2512         deleted ChangeLog paths (from moves, etc) which then when we ask
2513         SVN/Git for the contents of the file at that revision, the command
2514         errors out and Executive.run_command raises a ScriptError.
2515
2516         In the future we might fix this differently by making all current
2517         callers of chagned_files use a more specific method for requesting
2518         what types of changes they're interested in (adds, modifies, deletes, etc.)
2519
2520         * Scripts/webkitpy/common/checkout/api.py:
2521         * Scripts/webkitpy/common/checkout/api_unittest.py:
2522
2523 2011-01-13  Dan Bernstein  <mitz@apple.com>
2524
2525         Reviewed by Alexey Proskuryakov.
2526
2527         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2528         https://bugs.webkit.org/show_bug.cgi?id=52419
2529
2530         Allow to further control the behavior of the willSendRequest delegate callback by making it
2531         set a different URL in the new request.
2532
2533         * DumpRenderTree/LayoutTestController.cpp:
2534         (addURLToRedirectCallback): Added.
2535         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2536         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2537         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2538         * DumpRenderTree/LayoutTestController.h:
2539         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2540         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2541         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2542         change the URL in the new request to the redirect destination.
2543
2544 2011-01-13  Eric Seidel  <eric@webkit.org>
2545
2546         Reviewed by Mihai Parparita.
2547
2548         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2549         https://bugs.webkit.org/show_bug.cgi?id=52416
2550
2551         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2552         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2553
2554         I also added FIXMEs about the changed_files returning deleted files problem
2555         which is causing the other most common exception for suggest-reviewers
2556         (and is probably breaking sheriff-bots blame detection).
2557
2558         * Scripts/webkitpy/common/checkout/api.py:
2559         * Scripts/webkitpy/common/checkout/api_unittest.py:
2560         * Scripts/webkitpy/common/checkout/scm.py:
2561
2562 2011-01-13  Eric Seidel  <eric@webkit.org>
2563
2564         Reviewed by Adam Barth.
2565
2566         results archives from commit-queue are too large to upload
2567         https://bugs.webkit.org/show_bug.cgi?id=52405
2568
2569         * Scripts/webkitpy/common/system/filesystem.py:
2570         * Scripts/webkitpy/common/system/filesystem_mock.py:
2571         * Scripts/webkitpy/tool/commands/queues.py:
2572
2573 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2574
2575         Reviewed by Martin Robinson.
2576
2577         [gtk] Zero-sized font does not yet work
2578         https://bugs.webkit.org/show_bug.cgi?id=49793
2579
2580         Set minimum-font-size to 0 for the DRT.
2581
2582         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2583         (resetDefaultsToConsistentValues):
2584
2585 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2586
2587         Reviewed by Darin Adler.
2588
2589         Make old-run-webkit-tests more robust on buildbots
2590         https://bugs.webkit.org/show_bug.cgi?id=52364
2591
2592         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2593
2594 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2595
2596         Reviewed by Darin Adler.
2597
2598         Make old-run-webkit-tests more robust on buildbots
2599         https://bugs.webkit.org/show_bug.cgi?id=52364
2600
2601         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2602
2603 2011-01-13  Tony Chang  <tony@chromium.org>
2604
2605         Reviewed by Kent Tamura.
2606
2607         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2608         https://bugs.webkit.org/show_bug.cgi?id=52332
2609
2610         Forked Info.plist is not longer needed.
2611
2612         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2613
2614 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2615
2616         Reviewed by Timothy Hatcher.
2617
2618         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2619         to be passed directly to WebInspector.UIString
2620
2621         https://bugs.webkit.org/show_bug.cgi?id=52365
2622
2623         * Scripts/check-inspector-strings:
2624
2625 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2626
2627         Unreviewed, rolling out r74881.
2628         http://trac.webkit.org/changeset/74881
2629         https://bugs.webkit.org/show_bug.cgi?id=52357
2630
2631         The EFL builder has been red for days (Requested by abarth on
2632         #webkit).
2633
2634         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2635         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2636
2637 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2638
2639         Reviewed by David Levin.
2640
2641         Add beforeunload support to WebKitTestRunner
2642         https://bugs.webkit.org/show_bug.cgi?id=52353
2643         
2644         This makes a number of currently failing tests pass.
2645
2646         * WebKitTestRunner/TestController.cpp:
2647         (WTR::runBeforeUnloadConfirmPanel):
2648         (WTR::createOtherPage):
2649         (WTR::TestController::initialize):
2650
2651 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2652
2653         Reviewed by Sam Weinig.
2654
2655         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2656         https://bugs.webkit.org/show_bug.cgi?id=52330
2657
2658         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2659         a web process crash.
2660         * WebKitTestRunner/TestController.cpp:
2661         (WTR::TestController::initialize): Set up a processDidCrash
2662         callback.
2663         (WTR::TestController::processDidCrash): Report that the Web process
2664         crashed.
2665         * WebKitTestRunner/TestController.h:
2666
2667 2011-01-12  David Levin  <levin@chromium.org>
2668
2669         Reviewed by Shinichiro Hamaji.
2670
2671         check-webkit-style -- close_expression function doesn't work correctly.
2672         https://bugs.webkit.org/show_bug.cgi?id=52272
2673
2674         * Scripts/webkitpy/style/checkers/cpp.py:
2675         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2676         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2677         generally useful (for upcoming code changes).
2678         (close_expression): Changed to use Position for input and output.
2679         Also, fixed many bugs such as only working correctly for parenthesis,
2680         not working correctly if given an offset in a line and not finding
2681         the real closing element if there were multiple closing elements in
2682         the same line.
2683         (detect_functions): Adjusted due to the change in arguments for
2684         close_expression.
2685         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2686         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2687         two positions are the same.
2688         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2689         (CppStyleTest.test_close_expression): Added tests to catch the issues
2690         that were fixed.
2691
2692 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2693
2694         Unreviewed, rolling out r75576.
2695         http://trac.webkit.org/changeset/75576
2696         https://bugs.webkit.org/show_bug.cgi?id=52304
2697
2698         broke rebaseline-chromium-webkit-test (Requested by thakis on
2699         #webkit).
2700
2701         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2702         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2703         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2704         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2705         * Scripts/webkitpy/layout_tests/port/base.py:
2706         * Scripts/webkitpy/layout_tests/port/chromium.py:
2707         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2708         * Scripts/webkitpy/layout_tests/port/test.py:
2709         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2710         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2711         * Scripts/webkitpy/style/checkers/test_expectations.py:
2712         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2713
2714 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2715
2716         Reviewed by Darin Adler.
2717
2718         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2719         https://bugs.webkit.org/show_bug.cgi?id=52307
2720
2721         * Scripts/old-run-webkit-tests:
2722
2723 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2724
2725         Reviewed by Martin Robinson.
2726
2727         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2728         https://bugs.webkit.org/show_bug.cgi?id=50867
2729
2730         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2731         TestNetscapePlugin.cpp 
2732
2733         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2734         * Scripts/webkitdirs.pm:
2735
2736 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2737
2738         Reviewed by Pavel Feldman.
2739
2740         Add check-inspector-strings script.
2741
2742         https://bugs.webkit.org/show_bug.cgi?id=52295
2743
2744         * Scripts/check-inspector-strings: Added.
2745
2746 2011-01-12  Adam Roben  <aroben@apple.com>
2747
2748         Advertise the .testnetscape file extension on Windows
2749
2750         Fixes <http://webkit.org/b/52298>
2751         plugins/no-mime-with-valid-extension.html fails on Windows
2752
2753         Reviewed by Dan Bernstein.
2754
2755         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2756         FileExtents field to map the .testnetscape file extension to the
2757         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2758
2759 2011-01-12  Adam Barth  <abarth@webkit.org>
2760
2761         Reviewed by Eric Seidel.
2762
2763         Make webkit-patch support subdirectories for SVN checkouts
2764         https://bugs.webkit.org/show_bug.cgi?id=52261
2765
2766         os.relpath does not exist on Python 2.5, so we need to call our version
2767         of the API.
2768
2769         * Scripts/webkitpy/common/checkout/scm.py:
2770
2771 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2772
2773         Reviewed by Eric Seidel.
2774
2775         Close additional pages opened during a test once the test completes.
2776         https://bugs.webkit.org/show_bug.cgi?id=52276
2777
2778         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2779         (WTR::InjectedBundle::done):
2780
2781 2011-01-11  David Levin  <levin@chromium.org>
2782
2783         Reviewed by Eric Seidel.
2784
2785         Errors should be separated from the command line in bot messages.
2786         https://bugs.webkit.org/show_bug.cgi?id=52275
2787
2788         * Scripts/webkitpy/common/system/executive.py:
2789         (ScriptError.message_with_output): Added a newline to separate the command
2790         line from the errors.
2791         * Scripts/webkitpy/common/system/executive_unittest.py:
2792         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2793         paths in message_with_output.
2794
2795 2011-01-11  Eric Seidel  <eric@webkit.org>
2796
2797         Unreviewed.
2798
2799         commit-queue should know how to upload archived results (for test flakes or general failures)
2800         https://bugs.webkit.org/show_bug.cgi?id=52048
2801
2802         The zips are mostly empty due to forgetting -r.
2803         Expected diffs were not being pulled from the archive due
2804         to the archive having longer paths than I realized.
2805
2806         * Scripts/webkitpy/common/system/workspace.py:
2807         * Scripts/webkitpy/common/system/workspace_unittest.py:
2808         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2809         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2810
2811 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2812
2813         Reviewed by Ojan Vafai.
2814
2815         The current modifier parsing code in test_expectations is
2816         fragile and hard-coded, so it's not easy to understand the logic
2817         or easily add new types of modifiers (like GPU vs. CPU testing
2818         for graphics tests, or 32-bit vs. 64-bit differences).
2819
2820         This is the first of two patches that will add in more generic
2821         support and then eliminate the GPU-specific test expectations
2822         files for Chromium.
2823
2824         This patch adds two standalone objects for handling modifiers. The
2825         rules for interpreting modifiers, precedence, and conflicts are
2826         given in the docstring to the ModifierMatcher class, which
2827         returns ModifierMatchResult objects.
2828         
2829         This patch also adds routines to the Port interface and a
2830         default set of values in the base object, in order to obtain the
2831         values needed on a given test run. These values are then passed
2832         to the expectation parser. This also allows us to clean up the
2833         logic used to lint all of the different configurations in a
2834         single test_expectations.txt file.
2835
2836         The next patch will merge in the separate GPU expectations file.
2837
2838         https://bugs.webkit.org/show_bug.cgi?id=51222
2839
2840         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2841         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2842         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2843         * Scripts/webkitpy/layout_tests/port/base.py:
2844         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2845         * Scripts/webkitpy/layout_tests/port/chromium.py:
2846         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2847         * Scripts/webkitpy/layout_tests/port/test.py:
2848         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2849         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2850
2851 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2852
2853         Reviewed by Adam Barth.
2854
2855         Make webkit-patch support subdirectories for SVN checkouts
2856         https://bugs.webkit.org/show_bug.cgi?id=52261
2857
2858         * Scripts/webkitpy/common/checkout/scm.py:
2859         * Scripts/webkitpy/style_references.py:
2860         * Scripts/webkitpy/tool/main.py:
2861         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2862
2863 2011-01-11  Eric Seidel  <eric@webkit.org>
2864
2865         Unreviewed.
2866
2867         commit-queue should know how to upload archived results (for test flakes or general failures)
2868         https://bugs.webkit.org/show_bug.cgi?id=52048
2869
2870         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2871         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2872
2873         * Scripts/webkitpy/common/system/workspace.py:
2874         * Scripts/webkitpy/common/system/workspace_unittest.py:
2875         * Scripts/webkitpy/tool/commands/queues.py:
2876
2877 2011-01-11  Sam Weinig  <sam@webkit.org>
2878
2879         Roll r75474 back in.
2880
2881 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2882
2883         Reviewed by Kenneth Rohde Christiansen.
2884
2885         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2886         https://bugs.webkit.org/show_bug.cgi?id=51204
2887
2888         * QtTestBrowser/webpage.h:
2889         (QtNAMThread::QtNAMThread):
2890         (QtNAMThread::networkAccessManager):
2891         (QtNAMThread::run):
2892
2893 2011-01-11  Peter Varga  <pvarga@webkit.org>
2894
2895         Unreviewed.
2896
2897         Add myself to committers' list.
2898
2899         * Scripts/webkitpy/common/config/committers.py:
2900
2901 2011-01-11  Eric Seidel  <eric@webkit.org>
2902
2903         Reviewed by Adam Barth.
2904
2905         commit-queue should know how to upload archived results (for test flakes or general failures)
2906         https://bugs.webkit.org/show_bug.cgi?id=52048
2907
2908         Now the queue will always upload results.  Either the entire zip, or just
2909         the diffs.txt in the case of text failures.
2910
2911         This should make understanding flakes much easier, and paves the way
2912         for having the EWS run layout tests (and upload failures).
2913
2914         In order to upload .zip files I had to teach bugzilla.py to autodetect
2915         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2916         for .patch files, I have it add one before calling guess_type.
2917
2918         We may find that always uploading the whole zip instead of just the -diffs.txt
2919         file is preferable, but for now I'm keeping the old behavior because it makes
2920         quickly understanding text failures easy.
2921
2922         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2923         * Scripts/webkitpy/common/system/workspace.py: Added.
2924         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2925         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2926         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2927         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2928         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2929         * Scripts/webkitpy/tool/commands/queues.py:
2930         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2931
2932 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2933
2934         Unreviewed, rolling out r75464.
2935         http://trac.webkit.org/changeset/75464
2936         https://bugs.webkit.org/show_bug.cgi?id=52193
2937
2938         Followup rollout for 75474 (Requested by Ossy on #webkit).
2939
2940         * MiniBrowser/mac/BrowserWindowController.m:
2941         (-[BrowserWindowController awakeFromNib]):
2942         * MiniBrowser/win/BrowserView.cpp:
2943         (BrowserView::create):
2944         * WebKitTestRunner/TestController.cpp:
2945         (WTR::createOtherPage):
2946         (WTR::TestController::initialize):
2947
2948 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2949
2950         Reviewed by Csaba Osztrogonác.
2951
2952         [Qt] Baseline qt_minimal configuration
2953         https://bugs.webkit.org/show_bug.cgi?id=51313
2954
2955         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2956         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2957         QT_NO_UNDOSTACK guard.
2958
2959         * QtTestBrowser/launcherwindow.cpp:
2960         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2961         guards.
2962         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2963         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2964         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2965         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2966
2967         * QtTestBrowser/launcherwindow.h:
2968         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2969         * QtTestBrowser/locationedit.h: Ditto.
2970
2971         * QtTestBrowser/mainwindow.cpp:
2972         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2973         QT_NO_UNDOSTACK guards.
2974         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2975         (MainWindow::changeLocation): Ditto.
2976         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2977         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2978
2979         * QtTestBrowser/webpage.cpp:
2980         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2981         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2982
2983         * QtTestBrowser/webview.cpp:
2984         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2985         (WebViewGraphicsBased::animatedYFlip): Ditto.
2986
2987 2011-01-10  Sam Weinig  <sam@webkit.org>
2988
2989         Fix build.
2990
2991         * MiniBrowser/mac/BrowserWindowController.m:
2992         (-[BrowserWindowController awakeFromNib]):
2993         * MiniBrowser/win/BrowserView.cpp:
2994         (BrowserView::create):
2995         * WebKitTestRunner/TestController.cpp:
2996         (WTR::createOtherPage):
2997         (WTR::TestController::initialize):
2998
2999 2011-01-10  Eric Seidel  <eric@webkit.org>
3000
3001         Reviewed by Ojan Vafai.
3002
3003         style-queue messages are way too long for big patches
3004         https://bugs.webkit.org/show_bug.cgi?id=52161
3005
3006         We definitely could build much fancier list-to-string-with-limit functions
3007         but this should be sufficient for our needs at the moment.
3008
3009         * Scripts/webkitpy/common/system/executive.py:
3010         * Scripts/webkitpy/common/system/executive_unittest.py:
3011
3012 2011-01-10  Tony Chang  <tony@chromium.org>
3013
3014         Unreviewed, rolling out r75398.
3015         http://trac.webkit.org/changeset/75398
3016         https://bugs.webkit.org/show_bug.cgi?id=52008
3017
3018         Some layout tests are crashing on Chromium Win.
3019
3020         * DumpRenderTree/chromium/WebViewHost.cpp:
3021         (WebViewHost::updatePaintRect):
3022         * DumpRenderTree/chromium/WebViewHost.h:
3023
3024 2011-01-10  Adam Roben  <aroben@apple.com>
3025
3026         Roll out r75392
3027
3028         It isn't needed now that r75289 has been rolled out.
3029
3030         * Scripts/run-javascriptcore-tests:
3031
3032 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3033
3034         Reviewed by Anders Carlsson.
3035
3036         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3037         https://bugs.webkit.org/show_bug.cgi?id=52160
3038
3039         * WebKitTestRunner/mac/TestControllerMac.mm:
3040         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3041         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3042         anyway.
3043
3044 2011-01-10  Tony Chang  <tony@chromium.org>
3045
3046         Reviewed by Mihai Parparita.
3047
3048         [chromium] fix for animated gif layout tests
3049         https://bugs.webkit.org/show_bug.cgi?id=52008
3050
3051         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3052             to trigger gif animations.
3053         (WebViewHostPaintTask::WebViewHostPaintTask):
3054         (WebViewHostPaintTask::runIfValid):
3055         (WebViewHost::updatePaintRect):
3056         * DumpRenderTree/chromium/WebViewHost.h:
3057         (WebViewHost::taskList):
3058
3059 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3060
3061         Reviewed by Xan Lopez.
3062
3063         [GTK] Fix gtk2 compilation for master
3064         https://bugs.webkit.org/show_bug.cgi?id=51885
3065
3066         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3067         (createBitmapContextFromWebView): Replaced the old
3068         gdk_drawable_get_size with gdk_pixmap_get_size.
3069
3070 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3071
3072         Reviewed by Laszlo Gombos.
3073
3074         [WINCE] Reenable NPAPI after r75203
3075         https://bugs.webkit.org/show_bug.cgi?id=52109
3076
3077         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3078         it with !isEfl(), because EFL port does not support NPAPI (yet).
3079
3080         * Scripts/build-webkit:
3081
3082 2011-01-10  Adam Roben  <aroben@apple.com>
3083
3084         Skip some asserting JS tests
3085
3086         See <http://webkit.org/b/52156>.
3087
3088         * Scripts/run-javascriptcore-tests:
3089
3090 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3091
3092         Reviewed by Xan Lopez.
3093
3094         [GTK] build-webkit disable Blob support via arguments passed to automake
3095         https://bugs.webkit.org/show_bug.cgi?id=52097
3096
3097         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3098         build-webkit.
3099
3100 2011-01-10  Adam Roben  <aroben@apple.com>
3101
3102         Use the same name and description for TestNetscapePlugin on Windows and
3103         Mac
3104
3105         Fixes <http://webkit.org/b/52151>
3106         fast/frames/iframe-reparenting-plugins.html fails on Windows
3107
3108         Reviewed by Steve Falkenburg.
3109
3110         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3111         the name and description from Mac's Info.plist.
3112
3113 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3114
3115         Reviewed by Laszlo Gombos.
3116
3117         [Qt][WK2] Guard gcc-specific syntax
3118
3119         Non-gcc based compliers choke on the "-include"
3120         syntax for preinclude, place guard around it.
3121
3122         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3123         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3124
3125 2011-01-10  Andreas Kling  <kling@webkit.org>
3126
3127         Reviewed by Simon Hausmann.
3128
3129         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3130         https://bugs.webkit.org/show_bug.cgi?id=52111
3131
3132         When getting a createNewPage() callback from QWKPage, create the
3133         new page with the same QWKContext as the page that is passed to
3134         the callback.
3135
3136         * MiniBrowser/qt/BrowserView.h:
3137         * MiniBrowser/qt/BrowserWindow.cpp:
3138         (newPageFunction):
3139         (BrowserWindow::BrowserWindow):
3140         * MiniBrowser/qt/BrowserWindow.h:
3141
3142 2011-01-10  Andreas Kling  <kling@webkit.org>
3143
3144         Reviewed by Kenneth Rohde Christiansen.
3145
3146         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3147
3148         BrowserView set its own useless createNewPage() callback on QWKPage.
3149         This was immediately overridden by BrowserWindow anyway, so remove
3150         the BrowserView one.
3151
3152         * MiniBrowser/qt/BrowserView.cpp:
3153         (BrowserView::BrowserView):
3154
3155 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3156
3157         Reviewed by Jeremy Orlow.
3158
3159         [Chromium] Remove non-client-based Geolocation code
3160         https://bugs.webkit.org/show_bug.cgi?id=50921
3161
3162         * DumpRenderTree/chromium/LayoutTestController.cpp:
3163         (LayoutTestController::setGeolocationPermission):
3164         (LayoutTestController::setMockGeolocationPosition):
3165         (LayoutTestController::setMockGeolocationError):
3166         * DumpRenderTree/chromium/WebViewHost.cpp:
3167         (WebViewHost::geolocationClientMock):
3168         (WebViewHost::reset):
3169         * DumpRenderTree/chromium/WebViewHost.h:
3170
3171 2011-01-10  Eric Seidel  <eric@webkit.org>
3172
3173         Reviewed by Adam Barth.
3174
3175         Commit bot tried to land r? cq+ patch
3176         https://bugs.webkit.org/show_bug.cgi?id=36638
3177
3178         It should now be possible to post a patch with r? and cq+ and the
3179         commit-queue will correctly wait for the r+ before attempting to land the patch.
3180         (This was a feature requested by several users.)
3181
3182         One caveat: We don't actually reject r-, cq+ patches from the queue
3183         (we just ignore them), but I think that's OK for now.
3184
3185         I also noticed that setting r- once a commit-queue node had grabbed
3186         a patch would not properly cancel the landing.  That's fixed and
3187         tested in this patch.
3188
3189         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3190         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3191         * Scripts/webkitpy/tool/bot/feeders.py:
3192         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3193
3194 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3195
3196         Reviewed by Kenneth Rohde Christiansen.
3197
3198         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3199         https://bugs.webkit.org/show_bug.cgi?id=51934
3200
3201         When accessing the network from the destructor of QWebPage, the network access manager
3202         was already deleted because the object WebPage was already destructed.
3203
3204         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3205         The object is now destructed in the destructor of QObject.
3206
3207         * QtTestBrowser/webpage.cpp:
3208         (WebPage::WebPage):
3209         (WebPage::setQnamThreaded):
3210         * QtTestBrowser/webpage.h:
3211         (QtNAMThread::QtNAMThread):
3212
3213 2011-01-08  Eric Seidel  <eric@webkit.org>
3214
3215         Reviewed by Ojan Vafai.
3216
3217         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3218         https://bugs.webkit.org/show_bug.cgi?id=52067
3219
3220         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3221         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3222
3223         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3224
3225 2011-01-08  Eric Seidel  <eric@webkit.org>
3226
3227         Reviewed by Mihai Parparita.
3228
3229         commit-queue hangs when the ChangeLog diff is bad
3230         https://bugs.webkit.org/show_bug.cgi?id=52072
3231
3232         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3233         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3234
3235 2011-01-08  Adam Barth  <abarth@webkit.org>
3236
3237         Teach svn-apply how to re-write WebCore to Source/WebCore.
3238
3239         * Scripts/VCSUtils.pm:
3240
3241 2011-01-07  Adam Barth  <abarth@webkit.org>
3242
3243         Rubber-stamped by Eric Seidel.
3244
3245         Move WebCore to Source
3246         https://bugs.webkit.org/show_bug.cgi?id=52050
3247
3248         Update the tools to understand WebCore's new location.
3249
3250         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3251         * DumpRenderTree/wscript:
3252         * GNUmakefile.am:
3253         * Scripts/build-webkit:
3254         * Scripts/do-file-rename:
3255         * Scripts/do-webcore-rename:
3256         * Scripts/generate-qt-inspector-resource:
3257         * Scripts/prepare-ChangeLog:
3258         * Scripts/run-bindings-tests:
3259         * Scripts/update-iexploder-cssproperties:
3260         * Scripts/update-sources-list.py:
3261         * Scripts/update-webkit-localizable-strings:
3262         * Scripts/webkitdirs.pm:
3263         * Scripts/webkitpy/common/config/build.py:
3264         * Scripts/webkitpy/common/config/build_unittest.py:
3265         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3266         * Scripts/webkitpy/style/checker.py:
3267         * Scripts/webkitpy/style/checker_unittest.py:
3268         * WebKitTestRunner/DerivedSources.pro:
3269         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3270         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3271         * wx/browser/wscript:
3272         * wx/build/settings.py:
3273
3274 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3275
3276         Reviewed by Sam Weinig.
3277
3278         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3279         https://bugs.webkit.org/show_bug.cgi?id=52086
3280
3281         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3282         (WTR::InjectedBundle::didReceiveMessage):
3283         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3284         (WTR::LayoutTestController::notifyDone):
3285         * WebKitTestRunner/TestController.cpp:
3286         (WTR::TestController::resetStateToConsistentValues):
3287         (WTR::TestController::run):
3288
3289 2011-01-07  James Robinson  <jamesr@chromium.org>
3290
3291         Revert "Implement mozilla's animationTime property"
3292         https://bugs.webkit.org/show_bug.cgi?id=51952
3293
3294         This approach isn't quite right.
3295
3296         * DumpRenderTree/chromium/WebViewHost.cpp:
3297         (WebViewHost::paintInvalidatedRegion):
3298
3299 2011-01-07  Adam Roben  <aroben@apple.com>
3300
3301         Build master fix
3302
3303         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3304         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3305
3306 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3307
3308         Reviewed by Csaba Osztrogonác.
3309
3310         run-qtwebkit-tests should be able to kill a testsuite.
3311
3312         Add new option in the script that can setup a timeout for a test.
3313         If the test execution takes more then specified time then the test
3314         would be terminated.
3315
3316         [Qt] run-qtwebkit-tests needs timeout
3317         https://bugs.webkit.org/show_bug.cgi?id=51894
3318
3319         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3320         * Scripts/run-qtwebkit-tests:
3321
3322 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3323
3324         Unreviewed fix after r75233.
3325
3326         Based on idea from Eric Seidel.
3327
3328         Add remote zip file handling to webkitpy.
3329         https://bugs.webkit.org/show_bug.cgi?id=50901
3330
3331         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3332
3333 2011-01-07  Shane Stephens  <shanestephens@google.com>
3334
3335         Reviewed by Eric Seidel.
3336
3337         svn-apply: should support git binary delta diffs
3338         https://bugs.webkit.org/show_bug.cgi?id=38864
3339
3340         * Scripts/VCSUtils.pm:
3341         * Scripts/svn-apply:
3342
3343 2011-01-06  Julie Parent  <jparent@chromium.org>
3344
3345         Reviewed by Eric Seidel.
3346
3347         Test Result Server not removing old results.
3348         https://bugs.webkit.org/show_bug.cgi?id=52012
3349
3350         * TestResultServer/model/jsonresults.py:
3351         Fix off-by-one: Truncate if >= num_runs, not just >.
3352         * TestResultServer/model/jsonresults_unittest.py:
3353         Add unit test to test that merging in a new result with the same value
3354         as the last result causes previous result to fall off.
3355
3356 2011-01-06  James Kozianski  <koz@chromium.org>
3357
3358         Reviewed by Mihai Parparita.
3359
3360         Add classes to provide a consistent interface to a set of files.
3361         https://bugs.webkit.org/show_bug.cgi?id=50901
3362
3363         These classes allow us to write code that is agnostic to whether a
3364         particular set of files resides in a local directory or in a zip file
3365         on a remote machine.
3366
3367         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3368         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3369         * Scripts/webkitpy/common/system/fileset.py: Added.
3370         * Scripts/webkitpy/common/system/filesystem.py:
3371         * Scripts/webkitpy/common/system/filesystem_mock.py:
3372         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3373         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3374
3375 2011-01-06  Eric Seidel  <eric@webkit.org>
3376
3377         Reviewed by Adam Barth.
3378
3379         NetworkTransaction should log the url it is retrying
3380         https://bugs.webkit.org/show_bug.cgi?id=52043
3381
3382         * Scripts/webkitpy/common/net/networktransaction.py:
3383         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3384
3385 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3386
3387         Windows build fix.
3388         Import os before using it.
3389
3390         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3391
3392 2011-01-06  Eric Seidel  <eric@webkit.org>
3393
3394         Reviewed by Adam Barth.
3395
3396         StyleQueue fails to report errors when patches have many files
3397         https://bugs.webkit.org/show_bug.cgi?id=52042
3398
3399         This is one of at least two errors preventing style error reporting at the moment.
3400         When we moved to passing the list of files to check explicitly,
3401         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3402         We could change the type of the QueueStatus.message type, or we could
3403         just teach statusserver.py how to clamp values (and warn when it does).
3404         I chose the latter path.
3405
3406         * Scripts/webkitpy/common/net/statusserver.py:
3407
3408 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3409
3410         Reviewed by Stephanie Lewis.
3411         
3412         Fix syntax error in script.
3413
3414         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3415         https://bugs.webkit.org/show_bug.cgi?id=51996
3416
3417         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3418
3419 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3420
3421         Unreviewed, fixing WinCE build after r75196.
3422
3423         WinCE port does not (yet) support NPAPI.
3424
3425         * Scripts/build-webkit:
3426
3427 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3428
3429         Reviewed by Darin Adler.
3430
3431         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3432         https://bugs.webkit.org/show_bug.cgi?id=52015
3433
3434         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3435         after the platform has been detected, otherwise the script will
3436         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3437         detection.
3438
3439 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3440
3441         Reviewed by Eric Seidel.
3442
3443         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3444         https://bugs.webkit.org/show_bug.cgi?id=51346
3445
3446         * Scripts/build-webkit:
3447
3448 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3449
3450         Reviewed by Adam Roben.
3451
3452         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3453         https://bugs.webkit.org/show_bug.cgi?id=51996
3454         
3455         After the configuration directory change, we were archiving the incorrect directory for
3456         build product, so we were running tests on the wrong binaries.
3457         
3458         This change archives the correct directory, and also unarchives it into a configuration-
3459         specific directory.
3460
3461         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3462         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3463
3464 2011-01-06  Eric Seidel  <eric@webkit.org>
3465
3466         Reviewed by Mihai Parparita.
3467
3468         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3469         https://bugs.webkit.org/show_bug.cgi?id=52002
3470
3471         See an example of this here:
3472         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3473
3474         It's due to the fact that we pass around TestFailure() instance
3475         objects and yet expect them to all compare to be the same.
3476
3477         This is bad.  We should either have shared instances of these values
3478         or we should just pass around the class names.  There are already hacks
3479         in place to make TestFailure objects pass equality tests, I just added
3480         a __hash__ implementation so they can be used in sets as expected.
3481
3482         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3483         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3484
3485 2011-01-06  Evan Martin  <evan@chromium.org>
3486
3487         Reviewed by Tony Chang.
3488
3489         [gdb] handle inaccessible memory and UChar*
3490         https://bugs.webkit.org/show_bug.cgi?id=52003
3491
3492         To pretty-print a UChar*, we just grope around in the memory
3493         looking for a terminating NUL.  We need to handle the exception
3494         that can occur when we poke into an invalid location.
3495
3496         Additionally, the logic for choosing which pretty-printer would
3497         early return before hitting the point where we'd use the UChar*
3498         printer.  (Did this ever work?  How did it regress?)
3499
3500         * gdb/webkit.py:
3501
3502 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3503
3504         Reviewed by Ada Chan.
3505
3506         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3507         https://bugs.webkit.org/show_bug.cgi?id=51969
3508         
3509         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3510
3511         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3512         (WTR::InjectedBundlePage::InjectedBundlePage):
3513         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3514         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3515
3516 2011-01-06  James Robinson  <jamesr@chromium.org>
3517
3518         Reviewed by Simon Fraser.
3519
3520         Implement mozilla's animationTime property
3521         https://bugs.webkit.org/show_bug.cgi?id=51952
3522
3523         Chromium DRT support for webkitAnimationTime.
3524
3525         * DumpRenderTree/chromium/WebViewHost.cpp:
3526         (WebViewHost::paintInvalidatedRegion):
3527
3528 2011-01-06  Julie Parent  <jparent@chromium.org>
3529
3530         Reviewed by Tony Chang.
3531
3532         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3533         https://bugs.webkit.org/show_bug.cgi?id=51217
3534
3535         * TestResultServer/model/jsonresults.py:
3536         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3537         Adds missing documentation.
3538         * TestResultServer/model/jsonresults_unittest.py:
3539         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3540         Update test_merge to take a number of builds to truncate at.
3541
3542 2011-01-06  Adam Barth  <abarth@webkit.org>
3543
3544         Reviewed by Eric Seidel.
3545
3546         The EWS should log outside of the working directory
3547         https://bugs.webkit.org/show_bug.cgi?id=51986
3548
3549         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3550         script, which will actually clean the working copy back to a pristine
3551         state instead of leaving untracked directories and ignored files.
3552
3553         * Scripts/webkitpy/tool/commands/queues.py:
3554         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3555
3556 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3557
3558         Windows build fix.
3559         Back out attempted change to built-product-archive.
3560
3561         * BuildSlaveSupport/built-product-archive:
3562
3563 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3564
3565         Windows build fix.
3566         Include configuration name when unpacking a build archive.
3567
3568         Needed, since we split Windows build results into configuration-specific directories
3569         under WebKitOutputDir.
3570
3571         * BuildSlaveSupport/built-product-archive:
3572
3573 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3574
3575         Reviewed by Darin Adler.
3576
3577         Debug and Release builds on Windows clobber each other
3578         https://bugs.webkit.org/show_bug.cgi?id=49185
3579
3580         Changes the structure of WebKitBuild build products directory so we
3581         completely separate each build configuration into independent directories.
3582         
3583         Although we previously had per-configuration directories for obj, this change adds
3584         per-configuration directories for bin, lib, obj, and include. Each configuration's
3585         build products are stored within a directory inside of WebKitBuild.
3586         
3587         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3588         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3589
3590         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3591         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3592         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3593         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3594         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3595         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3596         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3597         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3598         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3599         * FindSafari/FindSafari.vcproj:
3600         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3601         * MiniBrowser/MiniBrowserPostBuild.cmd:
3602         * MiniBrowser/MiniBrowserPreBuild.cmd:
3603         * Scripts/webkitdirs.pm:
3604         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3605         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3606         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3607         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3608         * TestWebKitAPI/win/copy-resources.cmd:
3609         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3610         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3611         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3612         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3613         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3614         * WebKitTestRunner/win/InjectedBundle.vcproj:
3615         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3616         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3617         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3618         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3619         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3620         * WinLauncher/WinLauncherCommon.vsprops:
3621         * WinLauncher/WinLauncherPostBuild.cmd:
3622         * WinLauncher/WinLauncherPreBuild.cmd:
3623
3624 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3625
3626         Reviewed by Ariya Hidayat.
3627
3628         [Qt] TestNetscapePlugin doesn't link on OS X
3629         https://bugs.webkit.org/show_bug.cgi?id=51948
3630
3631         Only add a dependency on libX11 on X11 systems
3632
3633         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3634
3635 2011-01-05  Jeff Miller  <jeffm@apple.com>
3636
3637         Reviewed by Adam Roben.
3638
3639         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3640         https://bugs.webkit.org/show_bug.cgi?id=51970
3641
3642         * Scripts/webkitpy/style/checker.py:
3643         Add -readability/naming for WebKit2 C API directories.
3644
3645 2011-01-05  Eric Seidel  <eric@webkit.org>
3646
3647         Unreviewed, just fixing one more log error from my previous python patch.
3648
3649         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3650         https://bugs.webkit.org/show_bug.cgi?id=51802
3651
3652         webkit-patch failure-reason was logging about parsing errors
3653         due to my misunderstanding of how BeautifulSoup.findAll worked.
3654
3655         Fixed, and added a unit test.
3656
3657         * Scripts/webkitpy/common/net/layouttestresults.py:
3658         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3659
3660 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3661
3662         Reviewed by Kenneth Rohde Christiansen.
3663
3664         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3665         https://bugs.webkit.org/show_bug.cgi?id=51951
3666
3667         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3668         to create new window from WebKit.
3669
3670         * MiniBrowser/qt/BrowserWindow.cpp:
3671         (newPageFunction):
3672         (BrowserWindow::BrowserWindow):
3673         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3674         (BrowserWindow::newWindow):
3675         (BrowserWindow::updateUserAgentList):
3676         (BrowserWindow::showUserAgentDialog):
3677         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3678         define the type of the backing store used for new windows.
3679         * MiniBrowser/qt/main.cpp:
3680         (main):
3681
3682 2011-01-05  Eric Seidel  <eric@webkit.org>
3683
3684         Reviewed by Ojan Vafai.
3685
3686         commit-queue should report failure type when reporting flaky tests
3687         https://bugs.webkit.org/show_bug.cgi?id=51900
3688
3689         This patch was a ridiculous amount of plumbing.  In the end I like
3690         the NRWT-style TestResult class even less.  But now we're passing
3691         a list of TestResult objects from the queue to the FlakyTestReporter.
3692         Thus the FlakyTestReporter can more easily report what type of failure
3693         occurred.
3694
3695         In the process, I found that I was not alone in finding TestResult
3696         cumbersome to use.  A bunch of code was trying to create a TestResult
3697         object with default values.  However since the constructor didn't make
3698         this easy, some places were getting it wrong (including the TestResult unit test)!
3699         I've fixed the TestResult constructor to have default values for non-essential
3700         arguments.
3701
3702         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3703         * Scripts/webkitpy/common/net/layouttestresults.py:
3704         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3705         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3706         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3707         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3708         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3709         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3710         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3711         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3712         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3713         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3714         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3715         * Scripts/webkitpy/tool/commands/queues.py:
3716         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3717
3718 2011-01-05  Eric Seidel  <eric@webkit.org>
3719
3720         Unreviewed.
3721
3722         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3723         https://bugs.webkit.org/show_bug.cgi?id=51802
3724
3725         Add another unit test to cover a previously missing import.
3726
3727         * Scripts/webkitpy/common/net/layouttestresults.py:
3728         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3729
3730 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3731
3732         Reviewed by David Levin.
3733
3734         Add mihaip@chromium.org as a reviewer
3735         https://bugs.webkit.org/show_bug.cgi?id=51966
3736         
3737         Add myself as a reviewer.
3738
3739         * Scripts/webkitpy/common/config/committers.py:
3740
3741 2011-01-05  James Simonsen  <simonjam@chromium.org>
3742
3743         Unreviewed. Adding myself to the list of committers.
3744
3745         * Scripts/webkitpy/common/config/committers.py:
3746
3747 2011-01-05  Eric Seidel  <eric@webkit.org>
3748
3749         Unreviewed.
3750
3751         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3752         https://bugs.webkit.org/show_bug.cgi?id=51802
3753
3754         Fix two exceptions seen on the bots after my original commit.
3755
3756         * Scripts/webkitpy/common/net/layouttestresults.py:
3757         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3758
3759 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3760
3761         Reviewed by Andreas Kling.
3762
3763         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3764         https://bugs.webkit.org/show_bug.cgi?id=51750
3765
3766         * QtTestBrowser/main.cpp:
3767         (LauncherApplication::handleUserOptions):
3768          Local storage settings can be enable form command line arguments for
3769          QtTestBrowser.
3770
3771 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3772
3773         Reviewed by Martin Robinson.
3774
3775         GTK: AX: DRT needs to use correct root object method.
3776         https://bugs.webkit.org/show_bug.cgi?id=51911
3777
3778         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3779         (AccessibilityController::rootElement):
3780
3781 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3782
3783         Rubber-stamped by Csaba Osztrogonác.
3784
3785         Based on idea from Péter Gál.
3786
3787         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.