Tools/ChangeLog

   1 2011-01-21  Sam Weinig  <sam@webkit.org>
   2
   3         Reviewed by Geoffrey Sean Garen and Mark Rowe.
   4
   5         WebKitTestRunner needs the HOME environment variable to be set.
   6         <rdar://problem/8896573>
   7
   8         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
   9         it exists.
  10
  11 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
  12
  13         Reviewed by Eric Seidel.
  14
  15         Suppress a few remaining integration tests so that none of the
  16         layout_test unit tests ever read from the filesystem or launch
  17         subprocesses that aren't part of the unit tests.
  18
  19         Also fix a minor bug in the printing unit tests that was
  20         incorrectly relying on sys.argv.
  21
  22         https://bugs.webkit.org/show_bug.cgi?id=52863
  23
  24         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  25         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  26         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  27
  28 2011-01-21  Darin Adler  <darin@apple.com>
  29
  30        Fix Mac build.
  31
  32         * MiniBrowser/mac/BrowserWindowController.m:
  33         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
  34
  35 2011-01-20  Darin Adler  <darin@apple.com>
  36
  37         Reviewed by Dan Bernstein.
  38
  39         WebKit2: Implement showModalDialog
  40         https://bugs.webkit.org/show_bug.cgi?id=52855
  41
  42         This fixes WebKitTestRunner to compile, but more work is probably
  43         needed to get it to pass the tests.
  44
  45         * WebKitTestRunner/TestController.cpp:
  46         (WTR::TestController::runModal): Added. Calls through to the
  47         platform-specific version of runModal.
  48         (WTR::TestController::createOtherPage): Changed to be a private
  49         static member function so it can refer to runModal, which is
  50         a private static member function.
  51         (WTR::TestController::initialize): Pass 0 for the runModal
  52         function since we don't need to run the main window modal.
  53         I suspect this is wrong and will need to change.
  54         * WebKitTestRunner/TestController.h: Added declarations for
  55         the functions added above.
  56         * WebKitTestRunner/mac/TestControllerMac.mm:
  57         (WTR::TestController::runModal): Added. Untested implementation.
  58         * WebKitTestRunner/qt/TestControllerQt.cpp:
  59         (WTR::TestController::runModal): Added.
  60         * WebKitTestRunner/win/TestControllerWin.cpp:
  61         (WTR::TestController::runModal): Added.
  62
  63 2011-01-21  Eric Seidel  <eric@webkit.org>
  64
  65         Reviewed by Adam Barth.
  66
  67         Split Host object off from WebKitPatch for easier re-use
  68         https://bugs.webkit.org/show_bug.cgi?id=52284
  69
  70         new-run-webkit-tests and other tools are eventually going to want one of these.
  71         Basically you need to inherit from this class if you want to pretend to be a
  72         self.tool object for Steps/Commands.
  73
  74         * Scripts/webkitpy/common/host.py: Added.
  75         * Scripts/webkitpy/tool/main.py:
  76
  77 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
  78
  79         Reviewed by Adam Barth.
  80
  81         Disable the tests that start and stop the http server and web
  82         server, so that we don't have to worry about port collisions on
  83         the bots.
  84
  85         https://bugs.webkit.org/show_bug.cgi?id=52861
  86
  87         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  88
  89 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
  90
  91         Reviewed by Eric Seidel.
  92
  93         nrwt: rewrite google_chrome_unittest to use mock filesystem.
  94
  95         https://bugs.webkit.org/show_bug.cgi?id=52772
  96
  97         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  98
  99 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
 100
 101         Reviewed by Eric Siedel.
 102
 103         nrwt: clean up almost all remaining port references, remove
 104         unnecessary import clauses. The only remaining references are
 105         in places where a mock filesystem makes no sense or can't be
 106         used, and in one routine in port/google_chrome_unittest that
 107         I'll rewrite in a separate patch.
 108
 109         https://bugs.webkit.org/show_bug.cgi?id=52771
 110
 111         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 112         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
 113         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
 114         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 115         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 116         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 117         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 118         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
 119         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
 120         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
 121         * Scripts/webkitpy/layout_tests/port/gtk.py:
 122         * Scripts/webkitpy/layout_tests/port/mac.py:
 123         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 124         * Scripts/webkitpy/layout_tests/port/qt.py:
 125         * Scripts/webkitpy/layout_tests/port/webkit.py:
 126         * Scripts/webkitpy/layout_tests/port/win.py:
 127         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
 128
 129 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
 130
 131         Reviewed by Mihai Parparita.
 132
 133         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
 134
 135         https://bugs.webkit.org/show_bug.cgi?id=52762
 136
 137         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 138         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 139
 140 2011-01-20  Tony Chang  <tony@chromium.org>
 141
 142         Reviewed by Ojan Vafai.
 143
 144         [chromium] fix the paths used for the rebaseline tool
 145         https://bugs.webkit.org/show_bug.cgi?id=52857
 146
 147         Some of the bots were renamed so the path to grab the results zip
 148         file has changed.
 149
 150         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 151
 152 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
 153
 154         Reviewed by Tony Chang.
 155
 156         Fix bug introduced in r72688 / bug 52768 that broke the
 157         generation of the output filename links in the results.html
 158         output. Apparently none of the unit tests actually checked to
 159         make sure the generated links were correct :(
 160
 161         https://bugs.webkit.org/show_bug.cgi?id=52854
 162
 163         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
 164         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
 165
 166 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
 167
 168         Reviewed by Darin Adler.
 169
 170         https://bugs.webkit.org/show_bug.cgi?id=52849
 171         Make window.print work with WebKit2
 172
 173         * MiniBrowser/mac/BrowserWindowController.m:
 174         (-[BrowserWindowController awakeFromNib]):
 175         * WebKitTestRunner/TestController.cpp:
 176         (WTR::createOtherPage):
 177         (WTR::TestController::initialize):
 178         Added zeroes to WKPageUIClient structures to avoid build failures.
 179
 180 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
 181
 182         Reviewed by Eric Seidel.
 183
 184         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
 185
 186         https://bugs.webkit.org/show_bug.cgi?id=52756
 187
 188         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
 189         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 190         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 191         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 192         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
 193         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
 194
 195 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
 196
 197         Reviewed by Antonio Gomes.
 198
 199         QtTestBrowser should have a seperate menu for Settings
 200         https://bugs.webkit.org/show_bug.cgi?id=52817
 201
 202         Added a new menu item named "Settings"
 203         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu
 204
 205         * QtTestBrowser/launcherwindow.cpp:
 206         (LauncherWindow::createChrome):
 207
 208 2011-01-20  Sam Weinig  <sam@webkit.org>
 209
 210         Reviewed by John Sullivan.
 211
 212         Update update-webkit-localizable-strings with new path to WebKit.
 213
 214         * Scripts/update-webkit-localizable-strings:
 215
 216 2011-01-20  James Robinson  <jamesr@chromium.org>
 217
 218         Reviewed by Darin Fisher.
 219
 220         Implement mozilla's requestAnimationFrame API
 221         https://bugs.webkit.org/show_bug.cgi?id=51218
 222
 223         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
 224
 225         * DumpRenderTree/chromium/WebViewHost.cpp:
 226         (invokeScheduleComposite):
 227         (WebViewHost::scheduleAnimation):
 228         (WebViewHost::paintInvalidatedRegion):
 229         * DumpRenderTree/chromium/WebViewHost.h:
 230
 231 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
 232
 233         Reviewed by Adam Roben.
 234
 235         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
 236         https://bugs.webkit.org/show_bug.cgi?id=42327
 237
 238         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
 239         for methods that take their normal arguments but also a JSContextRef.
 240         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
 241         for evaluateScriptInIsolatedWorld.
 242         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 243         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
 244         this call is for an isolated world.
 245         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 246         (WTR::worldMap): Helper to create a world map.
 247         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
 248         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
 249         added LayoutTestController API.
 250         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 251
 252 2011-01-19  Adam Roben  <aroben@apple.com>
 253
 254         Convert paths in environment variables back to msys-style inside commit-log-editor
 255
 256         When this script gets run from inside git commit, msys-style paths in the environment will
 257         have been turned into Windows-style paths with forward slashes. This screws up functions
 258         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
 259         the paths back to msys-style before doing anything else.
 260
 261         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
 262         using msysgit's Perl and multiple ChangeLogs have been edited
 263
 264         Reviewed by David Kilzer.
 265
 266         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
 267         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
 268         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
 269
 270 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
 271
 272         [Win] Unreviewed build fix after r76248.
 273
 274         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
 275
 276 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
 277
 278         Reviewed by Csaba Osztrogonác.
 279
 280         Refactoring of the custom allocation framework
 281         https://bugs.webkit.org/show_bug.cgi?id=49897
 282
 283         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
 284         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
 285         equivalent macro implementation at the necessary places.
 286 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
 287
 288         Unreviewed.
 289
 290         Adding myself to committers.py.
 291
 292         * Scripts/webkitpy/common/config/committers.py:
 293
 294 2011-01-20  Adam Barth  <abarth@webkit.org>
 295
 296         Reviewed by Tony Chang.
 297
 298         Chromium builders don't delete unversioned directories when DEPS change
 299         https://bugs.webkit.org/show_bug.cgi?id=52745
 300
 301         If we pass this option to gclient sync, gclient will delete directories
 302         that are no longer part of DEPS instead of leaving them around to
 303         confuse us later.  Apparently, the downstream buildbots use this option
 304         already.
 305
 306         * Scripts/update-webkit-chromium:
 307
 308 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 309
 310         Unreviewed, build fix - I pulled this patch in to fix an issue
 311         revealed by r76195 running on some new bots). Also fix a couple
 312         of other issues revealed in testing.
 313
 314         nrwt: remove fs refs from layout_package/json*
 315
 316         https://bugs.webkit.org/show_bug.cgi?id=52754
 317
 318         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
 319         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
 320         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
 321         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 322         * Scripts/webkitpy/layout_tests/port/base.py:
 323
 324 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 325
 326         Unreviewed, build fix.
 327
 328         Fix a couple of minor bugs discovered while bringing up new bots
 329         for testing.
 330
 331         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
 332         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 333
 334 2011-01-19  James Robinson  <jamesr@chromium.org>
 335
 336         Unreviewed, rolling out r76194.
 337         http://trac.webkit.org/changeset/76194
 338         https://bugs.webkit.org/show_bug.cgi?id=51218
 339
 340         Caused mysterious compile failure on the chromium win
 341         build.webkit.org bots
 342
 343         * DumpRenderTree/chromium/WebViewHost.cpp:
 344         (WebViewHost::paintInvalidatedRegion):
 345         * DumpRenderTree/chromium/WebViewHost.h:
 346
 347 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 348
 349         Reviewed by Mihai Parparita.
 350
 351         remove fs refs from test_runner, dump_render_tree_thread
 352
 353         https://bugs.webkit.org/show_bug.cgi?id=52753
 354
 355         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
 356         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 357         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
 358         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 359
 360 2011-01-19  James Robinson  <jamesr@chromium.org>
 361
 362         Reviewed by Darin Fisher.
 363
 364         Implement mozilla's requestAnimationFrame API
 365         https://bugs.webkit.org/show_bug.cgi?id=51218
 366
 367         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
 368
 369         * DumpRenderTree/chromium/WebViewHost.cpp:
 370         (invokeScheduleComposite):
 371         (WebViewHost::scheduleAnimation):
 372         (WebViewHost::paintInvalidatedRegion):
 373         * DumpRenderTree/chromium/WebViewHost.h:
 374
 375 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 376
 377         Unreviewed, build fix.
 378
 379         Fix a few incorrect "self._filesystem" references introduced in
 380         r76184.
 381
 382         * Scripts/webkitpy/layout_tests/port/chromium.py:
 383         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 384
 385 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 386
 387         Reviewed by Mihai Parparita.
 388
 389         add a .sep property, abspath(), isabs(), mtime(), and
 390         open_text_file_for_writing() to filesystem modules. Some of
 391         these properties are not needed in this patch but will be needed
 392         in subsequent patches (I'm doing this to avoid having to track
 393         multiple versions of a single file).
 394
 395         Also, change most of the port/* modules to use the filesystem
 396         objects instead of referencing the filesystem directly.
 397
 398         https://bugs.webkit.org/show_bug.cgi?id=52748
 399
 400         * Scripts/webkitpy/common/system/filesystem.py:
 401         * Scripts/webkitpy/common/system/filesystem_mock.py:
 402         * Scripts/webkitpy/layout_tests/port/__init__.py:
 403         * Scripts/webkitpy/layout_tests/port/base.py:
 404         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 405         * Scripts/webkitpy/layout_tests/port/chromium.py:
 406         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 407         * Scripts/webkitpy/layout_tests/port/config.py:
 408         * Scripts/webkitpy/layout_tests/port/test.py:
 409         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
 410
 411 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
 412
 413         Reviewed by Anders Carlsson.
 414
 415         If resetting between tests times out, treat it as a WebProcess crash
 416         https://bugs.webkit.org/show_bug.cgi?id=52757
 417
 418         * WebKitTestRunner/TestController.cpp:
 419         (WTR::TestController::runTest):
 420
 421 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
 422
 423         Reviewed by Darin Adler.
 424
 425         https://bugs.webkit.org/show_bug.cgi?id=52739
 426         Make it possible for a WebKit2 client to print headers and footers
 427
 428         Added dummy implementations for new printing UIClient calls.
 429
 430         * MiniBrowser/mac/BrowserWindowController.m:
 431         (-[BrowserWindowController awakeFromNib]):
 432         * WebKitTestRunner/TestController.cpp:
 433         (WTR::createOtherPage):
 434         (WTR::TestController::initialize):
 435
 436 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 437
 438         Reviewed by Ojan Vafai.
 439
 440         Change webkitpy/layout_tests/port/test.py to use the
 441         in-memory filesystem for cleaner unit testing. This
 442         change allows us to kill a lot of code that was
 443         specific to the test port, at the cost of being a
 444         little less clear about how things would work if
 445         you didn't have a filesystem.
 446
 447         https://bugs.webkit.org/show_bug.cgi?id=52605
 448
 449         * Scripts/webkitpy/layout_tests/port/test.py:
 450
 451 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 452
 453         Unreviewed, build fix.
 454
 455         Fix test failure caused by committing attachment 79368 instead
 456         of attachment 79461 on bug 52604.
 457
 458         * Scripts/webkitpy/common/system/filesystem_mock.py:
 459
 460 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 461
 462         Reviewed by Mihai Parparita.
 463
 464         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
 465         unit testing. os.walk() is too much of a hassle to implement on
 466         top of the in-memory mock filesystem and adding the necessary
 467         interface to files_under() gives clients a cleaner API anyway
 468         (for this particular usage model).
 469
 470         https://bugs.webkit.org/show_bug.cgi?id=52691
 471
 472         * Scripts/webkitpy/common/system/filesystem.py:
 473         * Scripts/webkitpy/common/system/filesystem_mock.py:
 474         * Scripts/webkitpy/layout_tests/port/test_files.py:
 475         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
 476
 477 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 478
 479         Reviewed by Tony Chang.
 480
 481         Change more modules in the layout-tests code to use the
 482         filesystem wrapper for cleaner unit testing.
 483
 484         This patch also adds the glob() wrapper to the filesystem
 485         abstraction.
 486
 487         https://bugs.webkit.org/show_bug.cgi?id=52604
 488
 489         * Scripts/webkitpy/layout_tests/port/test_files.py:
 490         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
 491         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
 492         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
 493         * Scripts/webkitpy/common/system/filesystem.py:
 494         * Scripts/webkitpy/common/system/filesystem_mock.py:
 495
 496 2011-01-19  Levi Weintraub  <leviw@chromium.org>
 497
 498         Unreviewed.
 499
 500         Updating my email addresses and irc nick.
 501
 502         * Scripts/webkitpy/common/config/committers.py:
 503
 504 2011-01-19  Tony Chang  <tony@chromium.org>
 505
 506         Reviewed by Mihai Parparita.
 507
 508         [chromium] [linux] if check-sys-deps fails, output the failure reason
 509         https://bugs.webkit.org/show_bug.cgi?id=52671
 510
 511         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
 512             error handler functions.
 513         * Scripts/webkitpy/layout_tests/port/chromium.py:
 514             output the error text from --check-sys-deps
 515         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 516
 517 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
 518
 519         Reviewed by Andreas Kling.
 520
 521         [Qt] QtTestBrowser crashes when closing if Facebook is opened
 522         https://bugs.webkit.org/show_bug.cgi?id=52554
 523
 524         QtNetworkAccessManager is created in a thread and set as
 525         member variable in QWebPage. When the thread is destroyed
 526         the object is still used. So fix will set the object to
 527         NULL once the thread is destroyed.
 528
 529         * QtTestBrowser/launcherwindow.cpp:
 530         (LauncherWindow::~LauncherWindow):
 531
 532 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
 533
 534         Rubber stamped by Csaba Osztrogonac
 535
 536         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
 537
 538 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 539
 540         Reviewed by Tony Chang.
 541
 542         new-run-webkit-tests: add a --build-directory command line argument
 543
 544         Official Google Chrome builds use a non-standard build directory
 545         location. This patch adds a --build-directory argument that
 546         allows that location to be specified on the command line. Only
 547         Chromium-based builds will use this flag for now, but anyone can
 548         in the future.
 549
 550         There are no unit tests for this since it's difficult to test
 551         until mock filesystems are fully supported in the code. This was
 552         tested by hand for now.
 553
 554         https://bugs.webkit.org/show_bug.cgi?id=52694
 555
 556         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 557         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 558         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 559         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 560
 561 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
 562
 563         Not reviewed. Bot fix.
 564
 565         Remove an inadvertently committed debugging print.
 566
 567         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 568         (LayoutTestController::notifyDone):
 569
 570 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
 571
 572         Reviewed by Sam Weinig.
 573
 574         WebKitTestRunner should track loading more like DumpRenderTree
 575         https://bugs.webkit.org/show_bug.cgi?id=52692
 576
 577         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
 578         This makes some tests that call notifyDone multiple times pass.
 579
 580         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 581         (WTR::InjectedBundle::InjectedBundle):
 582         (WTR::InjectedBundle::done):
 583         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 584         (WTR::InjectedBundle::topLoadingFrame):
 585         (WTR::InjectedBundle::setTopLoadingFrame):
 586         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 587         (WTR::InjectedBundlePage::InjectedBundlePage):
 588         (WTR::InjectedBundlePage::stopLoading):
 589         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
 590         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
 591         (WTR::InjectedBundlePage::didFinishLoadForFrame):
 592         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
 593         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 594         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 595         (WTR::LayoutTestController::notifyDone):
 596         * WebKitTestRunner/TestController.cpp:
 597         (WTR::TestController::didReceiveMessageFromInjectedBundle):
 598
 599 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
 600
 601         Reviewed by Kent Tamura.
 602
 603         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
 604         https://bugs.webkit.org/show_bug.cgi?id=52678
 605
 606         Update path now that WebKit is inside Source.
 607
 608         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 609
 610 2011-01-18  Robert Hogan  <robert@webkit.org>
 611
 612         Reviewed by Simon Hausmann.
 613
 614         [Qt] http/tests/incremental/slow-utf8-text.pl fails
 615         https://bugs.webkit.org/show_bug.cgi?id=44282
 616
 617         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 618         (WebCore::DumpRenderTree::dump):
 619
 620 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 621
 622         Reviewed by Mihai Parparita.
 623
 624         Fix a small race condition that could cause the unit tests for
 625         new-run-webkit-tests to fail in a multithreaded environment.
 626         There was a small window in the code where one thread would
 627         check to see if a thread had raised an exception, do something,
 628         and then check to see if the thread was alive. If the other
 629         thread raised an exception and exited in between these two
 630         steps, the exception would be lost. Flipping the order of the
 631         two checks fixes the race, since we will now always check for an
 632         exception on the thread before exiting.
 633
 634         https://bugs.webkit.org/show_bug.cgi?id=51579
 635
 636         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
 637
 638 2011-01-18  Eric Seidel  <eric@webkit.org>
 639
 640         Reviewed by Adam Barth.
 641
 642         commit-queue dies when test archiving fails
 643         https://bugs.webkit.org/show_bug.cgi?id=52617
 644
 645         I looked at the machine and it had 10 archives already
 646         thus find_unused_name was returning None.  I've upped
 647         the limit to 100 (per bug) and tested the case where
 648         find_unused_name returns None (making archive return None).
 649
 650         * Scripts/webkitpy/common/system/workspace.py:
 651         * Scripts/webkitpy/common/system/workspace_unittest.py:
 652         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 653         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 654         * Scripts/webkitpy/tool/commands/queues.py:
 655
 656 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 657
 658         Reviewed by Ojan Vafai.
 659
 660         Update rebaseline-chromium-webkit-tests unit tests to use a mock
 661         filesystem. Also fix a couple of "with" statements missed by
 662         r76050.
 663
 664         https://bugs.webkit.org/show_bug.cgi?id=52487
 665
 666         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
 667
 668 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
 669
 670         Reviewed by Martin Robinson.
 671
 672         [Gtk] Build fixes for gtk3 build
 673         https://bugs.webkit.org/show_bug.cgi?id=52648
 674
 675         * DumpRenderTree/gtk/EventSender.cpp:
 676         (beginDragWithFilesCallback):
 677
 678 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 679
 680         Reviewed by Mihai Parparita.
 681
 682         Update rebaseline-chromium-webkit-tests to use filesystem objects
 683         instead of direct references to os.path, shutil, tempfile, etc.
 684
 685         This patch doesn't change anything, but will allow subsequent
 686         patches to change the unit tests to no longer use the real
 687         filesystem.
 688
 689         This patch adds a bunch more methods to the filesystem object as
 690         well.
 691
 692         https://bugs.webkit.org/show_bug.cgi?id=52482
 693
 694         * Scripts/webkitpy/common/system/filesystem.py:
 695         * Scripts/webkitpy/common/system/filesystem_mock.py:
 696         * Scripts/webkitpy/tool/commands/queues.py:
 697         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 698         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
 699
 700 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 701
 702         Reviewed by Mihai Parparita.
 703
 704         new-run-webkit-tests shouldn't crash when you try to run a
 705         directory containing only skipped files.
 706
 707         https://bugs.webkit.org/show_bug.cgi?id=52478
 708
 709         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 710         * Scripts/webkitpy/layout_tests/port/test.py:
 711         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 712
 713 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
 714
 715         Reviewed by Gustavo Noronha Silva.
 716
 717         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
 718         https://bugs.webkit.org/show_bug.cgi?id=40833
 719
 720         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
 721         GTK+ event sender.
 722         (dragWithFilesDragDataGetCallback): Added.
 723         (dragWithFilesDragEndCallback): Added.
 724         (beginDragWithFilesCallback): Added.
 725
 726 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 727
 728         Reviewed by Adam Barth.
 729
 730         ews: Add additional watcher to efl ews
 731         https://bugs.webkit.org/show_bug.cgi?id=52613
 732
 733         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
 734
 735         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 736
 737 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
 738
 739         Reviewed by Alexey Proskuryakov.
 740
 741         Fix some headers with missing or misspelled #ifndef guards
 742         https://bugs.webkit.org/show_bug.cgi?id=52545
 743
 744         * DumpRenderTree/chromium/TestEventPrinter.h:
 745         * DumpRenderTree/chromium/WebPreferences.h:
 746
 747 2011-01-17  Jessie Berlin  <jberlin@apple.com>
 748
 749         Reviewed by Anders Carlsson.
 750
 751         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
 752         navigating back to an unreachable URL
 753         https://bugs.webkit.org/show_bug.cgi?id=52388
 754
 755         Add a third parameter (unreachableURL) to queueLoadHTMLString.
 756
 757         * DumpRenderTree/LayoutTestController.cpp:
 758         (queueLoadHTMLStringCallback):
 759         (LayoutTestController::queueLoadHTMLString):
 760         (LayoutTestController::queueLoadAlternateHTMLString):
 761         * DumpRenderTree/LayoutTestController.h:
 762
 763         * DumpRenderTree/WorkQueueItem.h:
 764         (LoadHTMLStringItem::LoadHTMLStringItem):
 765
 766         * DumpRenderTree/chromium/LayoutTestController.cpp:
 767         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
 768         (WorkItemLoadHTMLString::run):
 769         (LayoutTestController::queueLoadHTMLString):
 770
 771         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
 772         (LoadHTMLStringItem::invoke):
 773         * DumpRenderTree/mac/WorkQueueItemMac.mm:
 774         (LoadHTMLStringItem::invoke):
 775         * DumpRenderTree/win/WorkQueueItemWin.cpp:
 776         (LoadHTMLStringItem::invoke):
 777
 778 2011-01-17  Dan Bernstein  <mitz@apple.com>
 779
 780         Rubber-stamped by Mark Rowe.
 781
 782         Update xcodeproj svn:ignore to include xcuserdata.
 783
 784         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
 785         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
 786         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
 787         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
 788         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
 789
 790 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
 791
 792         Unreviewed fix after r75908.
 793
 794         Move WebKit into Source
 795         https://bugs.webkit.org/show_bug.cgi?id=52530
 796
 797         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
 798
 799 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
 800
 801         Unreviewed.
 802
 803         Remove accidentally committed debug printing after r75908.
 804
 805         * Scripts/webkitdirs.pm:
 806
 807 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
 808
 809         Unreviewed.
 810
 811         Add myself to committers list
 812         https://bugs.webkit.org/show_bug.cgi?id=52566
 813
 814         * Scripts/webkitpy/common/config/committers.py:
 815
 816 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
 817
 818         Reviewed by Jeremy Orlow.
 819
 820         GeolocationController should call stopUpdating on destruction
 821         https://bugs.webkit.org/show_bug.cgi?id=52216
 822
 823         fast/dom/Geolocation/window-close-crash.html requires that a
 824         Geolocation watch be started in a secondary window. Consequently,
 825         we need to allow geolocation permission and provide a mock
 826         geolocation position for the secondary window's
 827         GeolocationClientMock.
 828
 829         * DumpRenderTree/chromium/LayoutTestController.cpp:
 830         (LayoutTestController::setGeolocationPermission):
 831         (LayoutTestController::setMockGeolocationPosition):
 832         (LayoutTestController::setMockGeolocationError):
 833         * DumpRenderTree/chromium/TestShell.h:
 834         (TestShell::windowList):
 835
 836 2011-01-16  Adam Barth  <abarth@webkit.org>
 837
 838         Update more include paths to reflect WebKit move.
 839
 840         * DumpRenderTree/chromium/EventSender.cpp:
 841         (EventSender::keyDown):
 842         (EventSender::needsShiftModifier):
 843         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
 844         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
 845
 846 2011-01-16  Kent Tamura  <tkent@chromium.org>
 847
 848         Unreviewed, Chromium build fix.
 849
 850         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
 851
 852 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
 853
 854         Build fix for GTK+ after source directory movement.
 855
 856         * GNUmakefile.am: Correct include paths.
 857
 858 2011-01-16  Adam Barth  <abarth@webkit.org>
 859
 860         Teach svn-apply about WebKit move.
 861
 862         * Scripts/VCSUtils.pm:
 863
 864 2011-01-16  Adam Barth  <abarth@webkit.org>
 865
 866         Rubber-stamped by Eric Seidel.
 867
 868         Move WebKit into Source
 869         https://bugs.webkit.org/show_bug.cgi?id=52530
 870
 871         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
 872         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 873         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 874         * DumpRenderTree/qt/GCControllerQt.cpp:
 875         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 876         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
 877         * DumpRenderTree/qt/TextInputControllerQt.cpp:
 878         * DumpRenderTree/wscript:
 879         * QtTestBrowser/launcherwindow.h:
 880         * Scripts/build-webkit:
 881         * Scripts/webkitdirs.pm:
 882
 883 2011-01-15  Adam Barth  <abarth@webkit.org>
 884
 885         Teach svn-apply about WebKit2 move.
 886
 887         * Scripts/VCSUtils.pm:
 888
 889 2011-01-15  Adam Barth  <abarth@webkit.org>
 890
 891         Rubber-stamped by Eric Seidel.
 892
 893         Move WebKit2 into Source
 894         https://bugs.webkit.org/show_bug.cgi?id=52438
 895
 896         * MiniBrowser/qt/MiniBrowser.pro:
 897         * Scripts/build-webkit:
 898         * Scripts/do-file-rename:
 899         * Scripts/do-webcore-rename:
 900         * Scripts/test-webkitpy:
 901         * Scripts/webkitdirs.pm:
 902         * Scripts/webkitpy/style/checker.py:
 903         * WebKitTestRunner/DerivedSources.pro:
 904         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 905         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 906
 907 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
 908
 909         Reviewed by David Levin.
 910
 911         [chromium] remove obsolete createView method
 912         https://bugs.webkit.org/show_bug.cgi?id=52437
 913
 914         * DumpRenderTree/chromium/WebViewHost.cpp:
 915         (WebViewHost::createView):
 916         * DumpRenderTree/chromium/WebViewHost.h:
 917
 918 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
 919
 920         Reviewed by Geoff Garen.
 921
 922         ShouldLoadResourceForFrame should use strings, not URLs.
 923         https://bugs.webkit.org/show_bug.cgi?id=52476
 924
 925         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 926         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
 927         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 928
 929 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
 930
 931         Reviewed by David Levin.
 932
 933         Add Tony Gentilcore as a reviewer
 934         https://bugs.webkit.org/show_bug.cgi?id=52480
 935
 936         * Scripts/webkitpy/common/config/committers.py:
 937
 938 2011-01-14  David Levin  <levin@chromium.org>
 939
 940         Reviewed by Eric Seidel.
 941
 942         check-webkit-style: _FunctionState should keep track of where the function name starts.
 943         https://bugs.webkit.org/show_bug.cgi?id=52454
 944
 945         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
 946         _FunctionState and logic for setting it correctly.
 947         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
 948
 949 2011-01-14  Vincent Scheib  <scheib@chromium.org>
 950
 951         Reviewed by David Levin.
 952
 953         Add support to DumpRenderTree to use the GPU rather than software renderer
 954         https://bugs.webkit.org/show_bug.cgi?id=52333
 955
 956         * DumpRenderTree/chromium/DumpRenderTree.cpp:
 957         (main):
 958         * Scripts/webkitpy/layout_tests/port/chromium.py:
 959         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 960
 961 2011-01-14  Tony Chang  <tony@chromium.org>
 962
 963         Reviewed by Kent Tamura.
 964
 965         [chromium] update fonts.conf to fix 6 linux tests in drt
 966         https://bugs.webkit.org/show_bug.cgi?id=52411
 967
 968         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
 969             chromium's src/webkit/tools/test_shell/resources/fonts.conf
 970
 971 2011-01-14  Eric Seidel  <eric@webkit.org>
 972
 973         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
 974
 975         Reviewed by Adam Barth.
 976
 977         Fix when running Tools/Scripts/check-webkit-style without arguments.
 978         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
 979
 980         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
 981         * Scripts/webkitpy/common/checkout/scm_unittest.py:
 982
 983 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
 984
 985         Reviewed by David Levin.
 986
 987         Store the tempdir object in a variable so it doesn't get deleted too early.
 988         https://bugs.webkit.org/show_bug.cgi?id=51875
 989
 990         * Scripts/update-webkit-auxiliary-libs:
 991         * Scripts/update-webkit-support-libs:
 992
 993 2011-01-14  Eric Seidel  <eric@webkit.org>
 994
 995         Unreviewed.  Make it work in python 2.5.
 996
 997         webkit-patch suggest-reviewers dies when ChangeLogs are missing
 998         https://bugs.webkit.org/show_bug.cgi?id=49158
 999
1000         * Scripts/webkitpy/common/checkout/api_unittest.py:
1001
1002 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1003
1004         Unreviewed, rolling out r75774.
1005         http://trac.webkit.org/changeset/75774
1006         https://bugs.webkit.org/show_bug.cgi?id=52431
1007
1008         gtk builds were broken (Requested by loislo2 on #webkit).
1009
1010         * Scripts/webkitpy/common/checkout/scm.py:
1011
1012 2011-01-14  David Levin  <levin@chromium.org>
1013
1014         Reviewed by Shinichiro Hamaji.
1015
1016         check-webkit-style: _FunctionState should detect pure functions.
1017         https://bugs.webkit.org/show_bug.cgi?id=52428
1018
1019         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1020         is a pure virtual function.
1021         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1022         virtual functions are correctly detected.
1023
1024 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1025
1026         Reviewed by Yury Semikhatsky.
1027
1028         Just small fix for problem with check-webkit-style.
1029         It just didn't work for this patch.
1030         Old code can't concatenate a list of strings with None.
1031
1032         * Scripts/webkitpy/common/checkout/scm.py:
1033
1034 2011-01-13  David Levin  <levin@chromium.org>
1035
1036         Reviewed by Shinichiro Hamaji.
1037
1038         check-webkit-style: _FunctionState should use Position to know where items are.
1039         https://bugs.webkit.org/show_bug.cgi?id=52424
1040
1041         * Scripts/webkitpy/style/checkers/cpp.py:
1042         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1043         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1044         did some minor clean-up.
1045         (*): Other changes are simply about converting to use the Position's in_FunctionState
1046         instead of line numbers.
1047         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1048         to verify the positions stored in _FunctionState.
1049
1050 2011-01-13  Eric Seidel  <eric@webkit.org>
1051
1052         Reviewed by David Levin.
1053
1054         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1055         https://bugs.webkit.org/show_bug.cgi?id=49158
1056
1057         This is not the most elegant, but it is a very safe fix to this bug.
1058         One advantage of catching ScriptError like this instead of adding a
1059         new added_or_modified_files or fixing all changed_files callers
1060         to use a more specific change_files variant, is that we catch
1061         all kinds of ScriptErrors which might cause our (non-essential)
1062         suggest-reviewers code to fail out.  This should make passing
1063         --suggest-reviewers to webkit-patch upload much more robust
1064         and may even make it possible for us to make it default.
1065
1066         The root of the problem here is that SCM.changed_files includes
1067         deleted ChangeLog paths (from moves, etc) which then when we ask
1068         SVN/Git for the contents of the file at that revision, the command
1069         errors out and Executive.run_command raises a ScriptError.
1070
1071         In the future we might fix this differently by making all current
1072         callers of chagned_files use a more specific method for requesting
1073         what types of changes they're interested in (adds, modifies, deletes, etc.)
1074
1075         * Scripts/webkitpy/common/checkout/api.py:
1076         * Scripts/webkitpy/common/checkout/api_unittest.py:
1077
1078 2011-01-13  Dan Bernstein  <mitz@apple.com>
1079
1080         Reviewed by Alexey Proskuryakov.
1081
1082         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1083         https://bugs.webkit.org/show_bug.cgi?id=52419
1084
1085         Allow to further control the behavior of the willSendRequest delegate callback by making it
1086         set a different URL in the new request.
1087
1088         * DumpRenderTree/LayoutTestController.cpp:
1089         (addURLToRedirectCallback): Added.
1090         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1091         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1092         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1093         * DumpRenderTree/LayoutTestController.h:
1094         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1095         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1096         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1097         change the URL in the new request to the redirect destination.
1098
1099 2011-01-13  Eric Seidel  <eric@webkit.org>
1100
1101         Reviewed by Mihai Parparita.
1102
1103         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1104         https://bugs.webkit.org/show_bug.cgi?id=52416
1105
1106         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717
1107         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1108
1109         I also added FIXMEs about the changed_files returning deleted files problem
1110         which is causing the other most common exception for suggest-reviewers
1111         (and is probably breaking sheriff-bots blame detection).
1112
1113         * Scripts/webkitpy/common/checkout/api.py:
1114         * Scripts/webkitpy/common/checkout/api_unittest.py:
1115         * Scripts/webkitpy/common/checkout/scm.py:
1116
1117 2011-01-13  Eric Seidel  <eric@webkit.org>
1118
1119         Reviewed by Adam Barth.
1120
1121         results archives from commit-queue are too large to upload
1122         https://bugs.webkit.org/show_bug.cgi?id=52405
1123
1124         * Scripts/webkitpy/common/system/filesystem.py:
1125         * Scripts/webkitpy/common/system/filesystem_mock.py:
1126         * Scripts/webkitpy/tool/commands/queues.py:
1127
1128 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1129
1130         Reviewed by Martin Robinson.
1131
1132         [gtk] Zero-sized font does not yet work
1133         https://bugs.webkit.org/show_bug.cgi?id=49793
1134
1135         Set minimum-font-size to 0 for the DRT.
1136
1137         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1138         (resetDefaultsToConsistentValues):
1139
1140 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1141
1142         Reviewed by Darin Adler.
1143
1144         Make old-run-webkit-tests more robust on buildbots
1145         https://bugs.webkit.org/show_bug.cgi?id=52364
1146
1147         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1148
1149 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1150
1151         Reviewed by Darin Adler.
1152
1153         Make old-run-webkit-tests more robust on buildbots
1154         https://bugs.webkit.org/show_bug.cgi?id=52364
1155
1156         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1157
1158 2011-01-13  Tony Chang  <tony@chromium.org>
1159
1160         Reviewed by Kent Tamura.
1161
1162         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1163         https://bugs.webkit.org/show_bug.cgi?id=52332
1164
1165         Forked Info.plist is not longer needed.
1166
1167         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1168
1169 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1170
1171         Reviewed by Timothy Hatcher.
1172
1173         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1174         to be passed directly to WebInspector.UIString
1175
1176         https://bugs.webkit.org/show_bug.cgi?id=52365
1177
1178         * Scripts/check-inspector-strings:
1179
1180 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1181
1182         Unreviewed, rolling out r74881.
1183         http://trac.webkit.org/changeset/74881
1184         https://bugs.webkit.org/show_bug.cgi?id=52357
1185
1186         The EFL builder has been red for days (Requested by abarth on
1187         #webkit).
1188
1189         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1190         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1191
1192 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1193
1194         Reviewed by David Levin.
1195
1196         Add beforeunload support to WebKitTestRunner
1197         https://bugs.webkit.org/show_bug.cgi?id=52353
1198
1199         This makes a number of currently failing tests pass.
1200
1201         * WebKitTestRunner/TestController.cpp:
1202         (WTR::runBeforeUnloadConfirmPanel):
1203         (WTR::createOtherPage):
1204         (WTR::TestController::initialize):
1205
1206 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1207
1208         Reviewed by Sam Weinig.
1209
1210         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1211         https://bugs.webkit.org/show_bug.cgi?id=52330
1212
1213         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1214         a web process crash.
1215         * WebKitTestRunner/TestController.cpp:
1216         (WTR::TestController::initialize): Set up a processDidCrash
1217         callback.
1218         (WTR::TestController::processDidCrash): Report that the Web process
1219         crashed.
1220         * WebKitTestRunner/TestController.h:
1221
1222 2011-01-12  David Levin  <levin@chromium.org>
1223
1224         Reviewed by Shinichiro Hamaji.
1225
1226         check-webkit-style -- close_expression function doesn't work correctly.
1227         https://bugs.webkit.org/show_bug.cgi?id=52272
1228
1229         * Scripts/webkitpy/style/checkers/cpp.py:
1230         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1231         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1232         generally useful (for upcoming code changes).
1233         (close_expression): Changed to use Position for input and output.
1234         Also, fixed many bugs such as only working correctly for parenthesis,
1235         not working correctly if given an offset in a line and not finding
1236         the real closing element if there were multiple closing elements in
1237         the same line.
1238         (detect_functions): Adjusted due to the change in arguments for
1239         close_expression.
1240         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1241         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1242         two positions are the same.
1243         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1244         (CppStyleTest.test_close_expression): Added tests to catch the issues
1245         that were fixed.
1246
1247 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1248
1249         Unreviewed, rolling out r75576.
1250         http://trac.webkit.org/changeset/75576
1251         https://bugs.webkit.org/show_bug.cgi?id=52304
1252
1253         broke rebaseline-chromium-webkit-test (Requested by thakis on
1254         #webkit).
1255
1256         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1257         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1258         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1259         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1260         * Scripts/webkitpy/layout_tests/port/base.py:
1261         * Scripts/webkitpy/layout_tests/port/chromium.py:
1262         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1263         * Scripts/webkitpy/layout_tests/port/test.py:
1264         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1265         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1266         * Scripts/webkitpy/style/checkers/test_expectations.py:
1267         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1268
1269 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1270
1271         Reviewed by Darin Adler.
1272
1273         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1274         https://bugs.webkit.org/show_bug.cgi?id=52307
1275
1276         * Scripts/old-run-webkit-tests:
1277
1278 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1279
1280         Reviewed by Martin Robinson.
1281
1282         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1283         https://bugs.webkit.org/show_bug.cgi?id=50867
1284
1285         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1286         TestNetscapePlugin.cpp
1287
1288         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1289         * Scripts/webkitdirs.pm:
1290
1291 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1292
1293         Reviewed by Pavel Feldman.
1294
1295         Add check-inspector-strings script.
1296
1297         https://bugs.webkit.org/show_bug.cgi?id=52295
1298
1299         * Scripts/check-inspector-strings: Added.
1300
1301 2011-01-12  Adam Roben  <aroben@apple.com>
1302
1303         Advertise the .testnetscape file extension on Windows
1304
1305         Fixes <http://webkit.org/b/52298>
1306         plugins/no-mime-with-valid-extension.html fails on Windows
1307
1308         Reviewed by Dan Bernstein.
1309
1310         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1311         FileExtents field to map the .testnetscape file extension to the
1312         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1313
1314 2011-01-12  Adam Barth  <abarth@webkit.org>
1315
1316         Reviewed by Eric Seidel.
1317
1318         Make webkit-patch support subdirectories for SVN checkouts
1319         https://bugs.webkit.org/show_bug.cgi?id=52261
1320
1321         os.relpath does not exist on Python 2.5, so we need to call our version
1322         of the API.
1323
1324         * Scripts/webkitpy/common/checkout/scm.py:
1325
1326 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1327
1328         Reviewed by Eric Seidel.
1329
1330         Close additional pages opened during a test once the test completes.
1331         https://bugs.webkit.org/show_bug.cgi?id=52276
1332
1333         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1334         (WTR::InjectedBundle::done):
1335
1336 2011-01-11  David Levin  <levin@chromium.org>
1337
1338         Reviewed by Eric Seidel.
1339
1340         Errors should be separated from the command line in bot messages.
1341         https://bugs.webkit.org/show_bug.cgi?id=52275
1342
1343         * Scripts/webkitpy/common/system/executive.py:
1344         (ScriptError.message_with_output): Added a newline to separate the command
1345         line from the errors.
1346         * Scripts/webkitpy/common/system/executive_unittest.py:
1347         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1348         paths in message_with_output.
1349
1350 2011-01-11  Eric Seidel  <eric@webkit.org>
1351
1352         Unreviewed.
1353
1354         commit-queue should know how to upload archived results (for test flakes or general failures)
1355         https://bugs.webkit.org/show_bug.cgi?id=52048
1356
1357         The zips are mostly empty due to forgetting -r.
1358         Expected diffs were not being pulled from the archive due
1359         to the archive having longer paths than I realized.
1360
1361         * Scripts/webkitpy/common/system/workspace.py:
1362         * Scripts/webkitpy/common/system/workspace_unittest.py:
1363         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1364         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1365
1366 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1367
1368         Reviewed by Ojan Vafai.
1369
1370         The current modifier parsing code in test_expectations is
1371         fragile and hard-coded, so it's not easy to understand the logic
1372         or easily add new types of modifiers (like GPU vs. CPU testing
1373         for graphics tests, or 32-bit vs. 64-bit differences).
1374
1375         This is the first of two patches that will add in more generic
1376         support and then eliminate the GPU-specific test expectations
1377         files for Chromium.
1378
1379         This patch adds two standalone objects for handling modifiers. The
1380         rules for interpreting modifiers, precedence, and conflicts are
1381         given in the docstring to the ModifierMatcher class, which
1382         returns ModifierMatchResult objects.
1383
1384         This patch also adds routines to the Port interface and a
1385         default set of values in the base object, in order to obtain the
1386         values needed on a given test run. These values are then passed
1387         to the expectation parser. This also allows us to clean up the
1388         logic used to lint all of the different configurations in a
1389         single test_expectations.txt file.
1390
1391         The next patch will merge in the separate GPU expectations file.
1392
1393         https://bugs.webkit.org/show_bug.cgi?id=51222
1394
1395         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1396         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1397         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1398         * Scripts/webkitpy/layout_tests/port/base.py:
1399         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1400         * Scripts/webkitpy/layout_tests/port/chromium.py:
1401         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1402         * Scripts/webkitpy/layout_tests/port/test.py:
1403         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1404         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1405
1406 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1407
1408         Reviewed by Adam Barth.
1409
1410         Make webkit-patch support subdirectories for SVN checkouts
1411         https://bugs.webkit.org/show_bug.cgi?id=52261
1412
1413         * Scripts/webkitpy/common/checkout/scm.py:
1414         * Scripts/webkitpy/style_references.py:
1415         * Scripts/webkitpy/tool/main.py:
1416         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1417
1418 2011-01-11  Eric Seidel  <eric@webkit.org>
1419
1420         Unreviewed.
1421
1422         commit-queue should know how to upload archived results (for test flakes or general failures)
1423         https://bugs.webkit.org/show_bug.cgi?id=52048
1424
1425         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1426         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1427
1428         * Scripts/webkitpy/common/system/workspace.py:
1429         * Scripts/webkitpy/common/system/workspace_unittest.py:
1430         * Scripts/webkitpy/tool/commands/queues.py:
1431
1432 2011-01-11  Sam Weinig  <sam@webkit.org>
1433
1434         Roll r75474 back in.
1435
1436 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1437
1438         Reviewed by Kenneth Rohde Christiansen.
1439
1440         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1441         https://bugs.webkit.org/show_bug.cgi?id=51204
1442
1443         * QtTestBrowser/webpage.h:
1444         (QtNAMThread::QtNAMThread):
1445         (QtNAMThread::networkAccessManager):
1446         (QtNAMThread::run):
1447
1448 2011-01-11  Peter Varga  <pvarga@webkit.org>
1449
1450         Unreviewed.
1451
1452         Add myself to committers' list.
1453
1454         * Scripts/webkitpy/common/config/committers.py:
1455
1456 2011-01-11  Eric Seidel  <eric@webkit.org>
1457
1458         Reviewed by Adam Barth.
1459
1460         commit-queue should know how to upload archived results (for test flakes or general failures)
1461         https://bugs.webkit.org/show_bug.cgi?id=52048
1462
1463         Now the queue will always upload results.  Either the entire zip, or just
1464         the diffs.txt in the case of text failures.
1465
1466         This should make understanding flakes much easier, and paves the way
1467         for having the EWS run layout tests (and upload failures).
1468
1469         In order to upload .zip files I had to teach bugzilla.py to autodetect
1470         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1471         for .patch files, I have it add one before calling guess_type.
1472
1473         We may find that always uploading the whole zip instead of just the -diffs.txt
1474         file is preferable, but for now I'm keeping the old behavior because it makes
1475         quickly understanding text failures easy.
1476
1477         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1478         * Scripts/webkitpy/common/system/workspace.py: Added.
1479         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1480         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1481         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1482         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1483         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1484         * Scripts/webkitpy/tool/commands/queues.py:
1485         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1486
1487 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1488
1489         Unreviewed, rolling out r75464.
1490         http://trac.webkit.org/changeset/75464
1491         https://bugs.webkit.org/show_bug.cgi?id=52193
1492
1493         Followup rollout for 75474 (Requested by Ossy on #webkit).
1494
1495         * MiniBrowser/mac/BrowserWindowController.m:
1496         (-[BrowserWindowController awakeFromNib]):
1497         * MiniBrowser/win/BrowserView.cpp:
1498         (BrowserView::create):
1499         * WebKitTestRunner/TestController.cpp:
1500         (WTR::createOtherPage):
1501         (WTR::TestController::initialize):
1502
1503 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1504
1505         Reviewed by Csaba Osztrogonác.
1506
1507         [Qt] Baseline qt_minimal configuration
1508         https://bugs.webkit.org/show_bug.cgi?id=51313
1509
1510         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1511         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1512         QT_NO_UNDOSTACK guard.
1513
1514         * QtTestBrowser/launcherwindow.cpp:
1515         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1516         guards.
1517         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1518         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1519         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1520         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1521
1522         * QtTestBrowser/launcherwindow.h:
1523         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1524         * QtTestBrowser/locationedit.h: Ditto.
1525
1526         * QtTestBrowser/mainwindow.cpp:
1527         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1528         QT_NO_UNDOSTACK guards.
1529         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1530         (MainWindow::changeLocation): Ditto.
1531         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1532         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1533
1534         * QtTestBrowser/webpage.cpp:
1535         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1536         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1537
1538         * QtTestBrowser/webview.cpp:
1539         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1540         (WebViewGraphicsBased::animatedYFlip): Ditto.
1541
1542 2011-01-10  Sam Weinig  <sam@webkit.org>
1543
1544         Fix build.
1545
1546         * MiniBrowser/mac/BrowserWindowController.m:
1547         (-[BrowserWindowController awakeFromNib]):
1548         * MiniBrowser/win/BrowserView.cpp:
1549         (BrowserView::create):
1550         * WebKitTestRunner/TestController.cpp:
1551         (WTR::createOtherPage):
1552         (WTR::TestController::initialize):
1553
1554 2011-01-10  Eric Seidel  <eric@webkit.org>
1555
1556         Reviewed by Ojan Vafai.
1557
1558         style-queue messages are way too long for big patches
1559         https://bugs.webkit.org/show_bug.cgi?id=52161
1560
1561         We definitely could build much fancier list-to-string-with-limit functions
1562         but this should be sufficient for our needs at the moment.
1563
1564         * Scripts/webkitpy/common/system/executive.py:
1565         * Scripts/webkitpy/common/system/executive_unittest.py:
1566
1567 2011-01-10  Tony Chang  <tony@chromium.org>
1568
1569         Unreviewed, rolling out r75398.
1570         http://trac.webkit.org/changeset/75398
1571         https://bugs.webkit.org/show_bug.cgi?id=52008
1572
1573         Some layout tests are crashing on Chromium Win.
1574
1575         * DumpRenderTree/chromium/WebViewHost.cpp:
1576         (WebViewHost::updatePaintRect):
1577         * DumpRenderTree/chromium/WebViewHost.h:
1578
1579 2011-01-10  Adam Roben  <aroben@apple.com>
1580
1581         Roll out r75392
1582
1583         It isn't needed now that r75289 has been rolled out.
1584
1585         * Scripts/run-javascriptcore-tests:
1586
1587 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1588
1589         Reviewed by Anders Carlsson.
1590
1591         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1592         https://bugs.webkit.org/show_bug.cgi?id=52160
1593
1594         * WebKitTestRunner/mac/TestControllerMac.mm:
1595         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1596         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1597         anyway.
1598
1599 2011-01-10  Tony Chang  <tony@chromium.org>
1600
1601         Reviewed by Mihai Parparita.
1602
1603         [chromium] fix for animated gif layout tests
1604         https://bugs.webkit.org/show_bug.cgi?id=52008
1605
1606         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1607             to trigger gif animations.
1608         (WebViewHostPaintTask::WebViewHostPaintTask):
1609         (WebViewHostPaintTask::runIfValid):
1610         (WebViewHost::updatePaintRect):
1611         * DumpRenderTree/chromium/WebViewHost.h:
1612         (WebViewHost::taskList):
1613
1614 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1615
1616         Reviewed by Xan Lopez.
1617
1618         [GTK] Fix gtk2 compilation for master
1619         https://bugs.webkit.org/show_bug.cgi?id=51885
1620
1621         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1622         (createBitmapContextFromWebView): Replaced the old
1623         gdk_drawable_get_size with gdk_pixmap_get_size.
1624
1625 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1626
1627         Reviewed by Laszlo Gombos.
1628
1629         [WINCE] Reenable NPAPI after r75203
1630         https://bugs.webkit.org/show_bug.cgi?id=52109
1631
1632         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1633         it with !isEfl(), because EFL port does not support NPAPI (yet).
1634
1635         * Scripts/build-webkit:
1636
1637 2011-01-10  Adam Roben  <aroben@apple.com>
1638
1639         Skip some asserting JS tests
1640
1641         See <http://webkit.org/b/52156>.
1642
1643         * Scripts/run-javascriptcore-tests:
1644
1645 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1646
1647         Reviewed by Xan Lopez.
1648
1649         [GTK] build-webkit disable Blob support via arguments passed to automake
1650         https://bugs.webkit.org/show_bug.cgi?id=52097
1651
1652         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1653         build-webkit.
1654
1655 2011-01-10  Adam Roben  <aroben@apple.com>
1656
1657         Use the same name and description for TestNetscapePlugin on Windows and
1658         Mac
1659
1660         Fixes <http://webkit.org/b/52151>
1661         fast/frames/iframe-reparenting-plugins.html fails on Windows
1662
1663         Reviewed by Steve Falkenburg.
1664
1665         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1666         the name and description from Mac's Info.plist.
1667
1668 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1669
1670         Reviewed by Laszlo Gombos.
1671
1672         [Qt][WK2] Guard gcc-specific syntax
1673
1674         Non-gcc based compliers choke on the "-include"
1675         syntax for preinclude, place guard around it.
1676
1677         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1678         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1679
1680 2011-01-10  Andreas Kling  <kling@webkit.org>
1681
1682         Reviewed by Simon Hausmann.
1683
1684         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1685         https://bugs.webkit.org/show_bug.cgi?id=52111
1686
1687         When getting a createNewPage() callback from QWKPage, create the
1688         new page with the same QWKContext as the page that is passed to
1689         the callback.
1690
1691         * MiniBrowser/qt/BrowserView.h:
1692         * MiniBrowser/qt/BrowserWindow.cpp:
1693         (newPageFunction):
1694         (BrowserWindow::BrowserWindow):
1695         * MiniBrowser/qt/BrowserWindow.h:
1696
1697 2011-01-10  Andreas Kling  <kling@webkit.org>
1698
1699         Reviewed by Kenneth Rohde Christiansen.
1700
1701         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1702
1703         BrowserView set its own useless createNewPage() callback on QWKPage.
1704         This was immediately overridden by BrowserWindow anyway, so remove
1705         the BrowserView one.
1706
1707         * MiniBrowser/qt/BrowserView.cpp:
1708         (BrowserView::BrowserView):
1709
1710 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1711
1712         Reviewed by Jeremy Orlow.
1713
1714         [Chromium] Remove non-client-based Geolocation code
1715         https://bugs.webkit.org/show_bug.cgi?id=50921
1716
1717         * DumpRenderTree/chromium/LayoutTestController.cpp:
1718         (LayoutTestController::setGeolocationPermission):
1719         (LayoutTestController::setMockGeolocationPosition):
1720         (LayoutTestController::setMockGeolocationError):
1721         * DumpRenderTree/chromium/WebViewHost.cpp:
1722         (WebViewHost::geolocationClientMock):
1723         (WebViewHost::reset):
1724         * DumpRenderTree/chromium/WebViewHost.h:
1725
1726 2011-01-10  Eric Seidel  <eric@webkit.org>
1727
1728         Reviewed by Adam Barth.
1729
1730         Commit bot tried to land r? cq+ patch
1731         https://bugs.webkit.org/show_bug.cgi?id=36638
1732
1733         It should now be possible to post a patch with r? and cq+ and the
1734         commit-queue will correctly wait for the r+ before attempting to land the patch.
1735         (This was a feature requested by several users.)
1736
1737         One caveat: We don't actually reject r-, cq+ patches from the queue
1738         (we just ignore them), but I think that's OK for now.
1739
1740         I also noticed that setting r- once a commit-queue node had grabbed
1741         a patch would not properly cancel the landing.  That's fixed and
1742         tested in this patch.
1743
1744         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1745         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1746         * Scripts/webkitpy/tool/bot/feeders.py:
1747         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1748
1749 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1750
1751         Reviewed by Kenneth Rohde Christiansen.
1752
1753         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1754         https://bugs.webkit.org/show_bug.cgi?id=51934
1755
1756         When accessing the network from the destructor of QWebPage, the network access manager
1757         was already deleted because the object WebPage was already destructed.
1758
1759         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1760         The object is now destructed in the destructor of QObject.
1761
1762         * QtTestBrowser/webpage.cpp:
1763         (WebPage::WebPage):
1764         (WebPage::setQnamThreaded):
1765         * QtTestBrowser/webpage.h:
1766         (QtNAMThread::QtNAMThread):
1767
1768 2011-01-08  Eric Seidel  <eric@webkit.org>
1769
1770         Reviewed by Ojan Vafai.
1771
1772         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1773         https://bugs.webkit.org/show_bug.cgi?id=52067
1774
1775         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1776         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1777
1778         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1779
1780 2011-01-08  Eric Seidel  <eric@webkit.org>
1781
1782         Reviewed by Mihai Parparita.
1783
1784         commit-queue hangs when the ChangeLog diff is bad
1785         https://bugs.webkit.org/show_bug.cgi?id=52072
1786
1787         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1788         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1789
1790 2011-01-08  Adam Barth  <abarth@webkit.org>
1791
1792         Teach svn-apply how to re-write WebCore to Source/WebCore.
1793
1794         * Scripts/VCSUtils.pm:
1795
1796 2011-01-07  Adam Barth  <abarth@webkit.org>
1797
1798         Rubber-stamped by Eric Seidel.
1799
1800         Move WebCore to Source
1801         https://bugs.webkit.org/show_bug.cgi?id=52050
1802
1803         Update the tools to understand WebCore's new location.
1804
1805         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1806         * DumpRenderTree/wscript:
1807         * GNUmakefile.am:
1808         * Scripts/build-webkit:
1809         * Scripts/do-file-rename:
1810         * Scripts/do-webcore-rename:
1811         * Scripts/generate-qt-inspector-resource:
1812         * Scripts/prepare-ChangeLog:
1813         * Scripts/run-bindings-tests:
1814         * Scripts/update-iexploder-cssproperties:
1815         * Scripts/update-sources-list.py:
1816         * Scripts/update-webkit-localizable-strings:
1817         * Scripts/webkitdirs.pm:
1818         * Scripts/webkitpy/common/config/build.py:
1819         * Scripts/webkitpy/common/config/build_unittest.py:
1820         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1821         * Scripts/webkitpy/style/checker.py:
1822         * Scripts/webkitpy/style/checker_unittest.py:
1823         * WebKitTestRunner/DerivedSources.pro:
1824         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1825         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1826         * wx/browser/wscript:
1827         * wx/build/settings.py:
1828
1829 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1830
1831         Reviewed by Sam Weinig.
1832
1833         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1834         https://bugs.webkit.org/show_bug.cgi?id=52086
1835
1836         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1837         (WTR::InjectedBundle::didReceiveMessage):
1838         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1839         (WTR::LayoutTestController::notifyDone):
1840         * WebKitTestRunner/TestController.cpp:
1841         (WTR::TestController::resetStateToConsistentValues):
1842         (WTR::TestController::run):
1843
1844 2011-01-07  James Robinson  <jamesr@chromium.org>
1845
1846         Revert "Implement mozilla's animationTime property"
1847         https://bugs.webkit.org/show_bug.cgi?id=51952
1848
1849         This approach isn't quite right.
1850
1851         * DumpRenderTree/chromium/WebViewHost.cpp:
1852         (WebViewHost::paintInvalidatedRegion):
1853
1854 2011-01-07  Adam Roben  <aroben@apple.com>
1855
1856         Build master fix
1857
1858         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1859         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1860
1861 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1862
1863         Reviewed by Csaba Osztrogonác.
1864
1865         run-qtwebkit-tests should be able to kill a testsuite.
1866
1867         Add new option in the script that can setup a timeout for a test.
1868         If the test execution takes more then specified time then the test
1869         would be terminated.
1870
1871         [Qt] run-qtwebkit-tests needs timeout
1872         https://bugs.webkit.org/show_bug.cgi?id=51894
1873
1874         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1875         * Scripts/run-qtwebkit-tests:
1876
1877 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1878
1879         Unreviewed fix after r75233.
1880
1881         Based on idea from Eric Seidel.
1882
1883         Add remote zip file handling to webkitpy.
1884         https://bugs.webkit.org/show_bug.cgi?id=50901
1885
1886         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1887
1888 2011-01-07  Shane Stephens  <shanestephens@google.com>
1889
1890         Reviewed by Eric Seidel.
1891
1892         svn-apply: should support git binary delta diffs
1893         https://bugs.webkit.org/show_bug.cgi?id=38864
1894
1895         * Scripts/VCSUtils.pm:
1896         * Scripts/svn-apply:
1897
1898 2011-01-06  Julie Parent  <jparent@chromium.org>
1899
1900         Reviewed by Eric Seidel.
1901
1902         Test Result Server not removing old results.
1903         https://bugs.webkit.org/show_bug.cgi?id=52012
1904
1905         * TestResultServer/model/jsonresults.py:
1906         Fix off-by-one: Truncate if >= num_runs, not just >.
1907         * TestResultServer/model/jsonresults_unittest.py:
1908         Add unit test to test that merging in a new result with the same value
1909         as the last result causes previous result to fall off.
1910
1911 2011-01-06  James Kozianski  <koz@chromium.org>
1912
1913         Reviewed by Mihai Parparita.
1914
1915         Add classes to provide a consistent interface to a set of files.
1916         https://bugs.webkit.org/show_bug.cgi?id=50901
1917
1918         These classes allow us to write code that is agnostic to whether a
1919         particular set of files resides in a local directory or in a zip file
1920         on a remote machine.
1921
1922         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1923         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1924         * Scripts/webkitpy/common/system/fileset.py: Added.
1925         * Scripts/webkitpy/common/system/filesystem.py:
1926         * Scripts/webkitpy/common/system/filesystem_mock.py:
1927         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1928         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1929
1930 2011-01-06  Eric Seidel  <eric@webkit.org>
1931
1932         Reviewed by Adam Barth.
1933
1934         NetworkTransaction should log the url it is retrying
1935         https://bugs.webkit.org/show_bug.cgi?id=52043
1936
1937         * Scripts/webkitpy/common/net/networktransaction.py:
1938         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1939
1940 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1941
1942         Windows build fix.
1943         Import os before using it.
1944
1945         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1946
1947 2011-01-06  Eric Seidel  <eric@webkit.org>
1948
1949         Reviewed by Adam Barth.
1950
1951         StyleQueue fails to report errors when patches have many files
1952         https://bugs.webkit.org/show_bug.cgi?id=52042
1953
1954         This is one of at least two errors preventing style error reporting at the moment.
1955         When we moved to passing the list of files to check explicitly,
1956         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1957         We could change the type of the QueueStatus.message type, or we could
1958         just teach statusserver.py how to clamp values (and warn when it does).
1959         I chose the latter path.
1960
1961         * Scripts/webkitpy/common/net/statusserver.py:
1962
1963 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1964
1965         Reviewed by Stephanie Lewis.
1966
1967         Fix syntax error in script.
1968
1969         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1970         https://bugs.webkit.org/show_bug.cgi?id=51996
1971
1972         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1973
1974 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1975
1976         Unreviewed, fixing WinCE build after r75196.
1977
1978         WinCE port does not (yet) support NPAPI.
1979
1980         * Scripts/build-webkit:
1981
1982 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1983
1984         Reviewed by Darin Adler.
1985
1986         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1987         https://bugs.webkit.org/show_bug.cgi?id=52015
1988
1989         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1990         after the platform has been detected, otherwise the script will
1991         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1992         detection.
1993
1994 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1995
1996         Reviewed by Eric Seidel.
1997
1998         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1999         https://bugs.webkit.org/show_bug.cgi?id=51346
2000
2001         * Scripts/build-webkit:
2002
2003 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2004
2005         Reviewed by Adam Roben.
2006
2007         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2008         https://bugs.webkit.org/show_bug.cgi?id=51996
2009
2010         After the configuration directory change, we were archiving the incorrect directory for
2011         build product, so we were running tests on the wrong binaries.
2012
2013         This change archives the correct directory, and also unarchives it into a configuration-
2014         specific directory.
2015
2016         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2017         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2018
2019 2011-01-06  Eric Seidel  <eric@webkit.org>
2020
2021         Reviewed by Mihai Parparita.
2022
2023         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2024         https://bugs.webkit.org/show_bug.cgi?id=52002
2025
2026         See an example of this here:
2027         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2028
2029         It's due to the fact that we pass around TestFailure() instance
2030         objects and yet expect them to all compare to be the same.
2031
2032         This is bad.  We should either have shared instances of these values
2033         or we should just pass around the class names.  There are already hacks
2034         in place to make TestFailure objects pass equality tests, I just added
2035         a __hash__ implementation so they can be used in sets as expected.
2036
2037         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2038         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2039
2040 2011-01-06  Evan Martin  <evan@chromium.org>
2041
2042         Reviewed by Tony Chang.
2043
2044         [gdb] handle inaccessible memory and UChar*
2045         https://bugs.webkit.org/show_bug.cgi?id=52003
2046
2047         To pretty-print a UChar*, we just grope around in the memory
2048         looking for a terminating NUL.  We need to handle the exception
2049         that can occur when we poke into an invalid location.
2050
2051         Additionally, the logic for choosing which pretty-printer would
2052         early return before hitting the point where we'd use the UChar*
2053         printer.  (Did this ever work?  How did it regress?)
2054
2055         * gdb/webkit.py:
2056
2057 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2058
2059         Reviewed by Ada Chan.
2060
2061         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2062         https://bugs.webkit.org/show_bug.cgi?id=51969
2063
2064         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2065
2066         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2067         (WTR::InjectedBundlePage::InjectedBundlePage):
2068         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2069         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2070
2071 2011-01-06  James Robinson  <jamesr@chromium.org>
2072
2073         Reviewed by Simon Fraser.
2074
2075         Implement mozilla's animationTime property
2076         https://bugs.webkit.org/show_bug.cgi?id=51952
2077
2078         Chromium DRT support for webkitAnimationTime.
2079
2080         * DumpRenderTree/chromium/WebViewHost.cpp:
2081         (WebViewHost::paintInvalidatedRegion):
2082
2083 2011-01-06  Julie Parent  <jparent@chromium.org>
2084
2085         Reviewed by Tony Chang.
2086
2087         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2088         https://bugs.webkit.org/show_bug.cgi?id=51217
2089
2090         * TestResultServer/model/jsonresults.py:
2091         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2092         Adds missing documentation.
2093         * TestResultServer/model/jsonresults_unittest.py:
2094         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2095         Update test_merge to take a number of builds to truncate at.
2096
2097 2011-01-06  Adam Barth  <abarth@webkit.org>
2098
2099         Reviewed by Eric Seidel.
2100
2101         The EWS should log outside of the working directory
2102         https://bugs.webkit.org/show_bug.cgi?id=51986
2103
2104         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2105         script, which will actually clean the working copy back to a pristine
2106         state instead of leaving untracked directories and ignored files.
2107
2108         * Scripts/webkitpy/tool/commands/queues.py:
2109         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2110
2111 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2112
2113         Windows build fix.
2114         Back out attempted change to built-product-archive.
2115
2116         * BuildSlaveSupport/built-product-archive:
2117
2118 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2119
2120         Windows build fix.
2121         Include configuration name when unpacking a build archive.
2122
2123         Needed, since we split Windows build results into configuration-specific directories
2124         under WebKitOutputDir.
2125
2126         * BuildSlaveSupport/built-product-archive:
2127
2128 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2129
2130         Reviewed by Darin Adler.
2131
2132         Debug and Release builds on Windows clobber each other
2133         https://bugs.webkit.org/show_bug.cgi?id=49185
2134
2135         Changes the structure of WebKitBuild build products directory so we
2136         completely separate each build configuration into independent directories.
2137
2138         Although we previously had per-configuration directories for obj, this change adds
2139         per-configuration directories for bin, lib, obj, and include. Each configuration's
2140         build products are stored within a directory inside of WebKitBuild.
2141
2142         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2143         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2144
2145         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2146         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2147         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2148         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2149         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2150         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2151         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2152         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2153         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2154         * FindSafari/FindSafari.vcproj:
2155         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2156         * MiniBrowser/MiniBrowserPostBuild.cmd:
2157         * MiniBrowser/MiniBrowserPreBuild.cmd:
2158         * Scripts/webkitdirs.pm:
2159         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2160         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2161         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2162         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2163         * TestWebKitAPI/win/copy-resources.cmd:
2164         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2165         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2166         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2167         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2168         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2169         * WebKitTestRunner/win/InjectedBundle.vcproj:
2170         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2171         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2172         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2173         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2174         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2175         * WinLauncher/WinLauncherCommon.vsprops:
2176         * WinLauncher/WinLauncherPostBuild.cmd:
2177         * WinLauncher/WinLauncherPreBuild.cmd:
2178
2179 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2180
2181         Reviewed by Ariya Hidayat.
2182
2183         [Qt] TestNetscapePlugin doesn't link on OS X
2184         https://bugs.webkit.org/show_bug.cgi?id=51948
2185
2186         Only add a dependency on libX11 on X11 systems
2187
2188         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2189
2190 2011-01-05  Jeff Miller  <jeffm@apple.com>
2191
2192         Reviewed by Adam Roben.
2193
2194         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2195         https://bugs.webkit.org/show_bug.cgi?id=51970
2196
2197         * Scripts/webkitpy/style/checker.py:
2198         Add -readability/naming for WebKit2 C API directories.
2199
2200 2011-01-05  Eric Seidel  <eric@webkit.org>
2201
2202         Unreviewed, just fixing one more log error from my previous python patch.
2203
2204         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2205         https://bugs.webkit.org/show_bug.cgi?id=51802
2206
2207         webkit-patch failure-reason was logging about parsing errors
2208         due to my misunderstanding of how BeautifulSoup.findAll worked.
2209
2210         Fixed, and added a unit test.
2211
2212         * Scripts/webkitpy/common/net/layouttestresults.py:
2213         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2214
2215 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2216
2217         Reviewed by Kenneth Rohde Christiansen.
2218
2219         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2220         https://bugs.webkit.org/show_bug.cgi?id=51951
2221
2222         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2223         to create new window from WebKit.
2224
2225         * MiniBrowser/qt/BrowserWindow.cpp:
2226         (newPageFunction):
2227         (BrowserWindow::BrowserWindow):
2228         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2229         (BrowserWindow::newWindow):
2230         (BrowserWindow::updateUserAgentList):
2231         (BrowserWindow::showUserAgentDialog):
2232         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2233         define the type of the backing store used for new windows.
2234         * MiniBrowser/qt/main.cpp:
2235         (main):
2236
2237 2011-01-05  Eric Seidel  <eric@webkit.org>
2238
2239         Reviewed by Ojan Vafai.
2240
2241         commit-queue should report failure type when reporting flaky tests
2242         https://bugs.webkit.org/show_bug.cgi?id=51900
2243
2244         This patch was a ridiculous amount of plumbing.  In the end I like
2245         the NRWT-style TestResult class even less.  But now we're passing
2246         a list of TestResult objects from the queue to the FlakyTestReporter.
2247         Thus the FlakyTestReporter can more easily report what type of failure
2248         occurred.
2249
2250         In the process, I found that I was not alone in finding TestResult
2251         cumbersome to use.  A bunch of code was trying to create a TestResult
2252         object with default values.  However since the constructor didn't make
2253         this easy, some places were getting it wrong (including the TestResult unit test)!
2254         I've fixed the TestResult constructor to have default values for non-essential
2255         arguments.
2256
2257         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2258         * Scripts/webkitpy/common/net/layouttestresults.py:
2259         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2260         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2261         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2262         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2263         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2264         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2265         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2266         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2267         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2268         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2269         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2270         * Scripts/webkitpy/tool/commands/queues.py:
2271         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2272
2273 2011-01-05  Eric Seidel  <eric@webkit.org>
2274
2275         Unreviewed.
2276
2277         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2278         https://bugs.webkit.org/show_bug.cgi?id=51802
2279
2280         Add another unit test to cover a previously missing import.
2281
2282         * Scripts/webkitpy/common/net/layouttestresults.py:
2283         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2284
2285 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2286
2287         Reviewed by David Levin.
2288
2289         Add mihaip@chromium.org as a reviewer
2290         https://bugs.webkit.org/show_bug.cgi?id=51966
2291
2292         Add myself as a reviewer.
2293
2294         * Scripts/webkitpy/common/config/committers.py:
2295
2296 2011-01-05  James Simonsen  <simonjam@chromium.org>
2297
2298         Unreviewed. Adding myself to the list of committers.
2299
2300         * Scripts/webkitpy/common/config/committers.py:
2301
2302 2011-01-05  Eric Seidel  <eric@webkit.org>
2303
2304         Unreviewed.
2305
2306         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2307         https://bugs.webkit.org/show_bug.cgi?id=51802
2308
2309         Fix two exceptions seen on the bots after my original commit.
2310
2311         * Scripts/webkitpy/common/net/layouttestresults.py:
2312         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2313
2314 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2315
2316         Reviewed by Andreas Kling.
2317
2318         [Qt]Add local storage settings to QtTestBrowser command line arguments
2319         https://bugs.webkit.org/show_bug.cgi?id=51750
2320
2321         * QtTestBrowser/main.cpp:
2322         (LauncherApplication::handleUserOptions):
2323          Local storage settings can be enable form command line arguments for
2324          QtTestBrowser.
2325
2326 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2327
2328         Reviewed by Martin Robinson.
2329
2330         GTK: AX: DRT needs to use correct root object method.
2331         https://bugs.webkit.org/show_bug.cgi?id=51911
2332
2333         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2334         (AccessibilityController::rootElement):
2335
2336 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2337
2338         Rubber-stamped by Csaba Osztrogonác.
2339
2340         Based on idea from Péter Gál.
2341
2342         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2343
2344 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2345
2346         Reviewed by Adam Barth.
2347
2348         sheriff-bot should be able to do multi-revision rollouts
2349         https://bugs.webkit.org/show_bug.cgi?id=51176
2350
2351         * Scripts/webkitpy/tool/bot/irc_command.py:
2352         * Scripts/webkitpy/tool/bot/sheriff.py:
2353         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2354
2355 2011-01-05  Eric Seidel  <eric@webkit.org>
2356
2357         Reviewed by Adam Barth.
2358
2359         queues.webkit.org should have per-bot status pages
2360         https://bugs.webkit.org/show_bug.cgi?id=51906
2361
2362         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2363         statuses from a single queue.  Now that we have many bots servicing
2364         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2365         you care about scroll off the end of the 15-message limit on the main page.
2366
2367         Eventually we should probably rename /queue-status to /queue or /queues,
2368         but that's fodder for another patch.
2369
2370         * QueueStatusServer/handlers/queuestatus.py:
2371         * QueueStatusServer/index.yaml:
2372         * QueueStatusServer/main.py:
2373         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2374          - This probably should use a custom filter instead of hard-coding
2375            the URL scheme here, but I couldn't figure out how to easily
2376            create such a filter.  Most filters work with "strings" so we can't
2377            pass the status object.  We could add a method to the status
2378            object and call that, but that seemed a bit strange too.
2379         * QueueStatusServer/templates/queuestatus.html:
2380
2381 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2382
2383         Unreviewed. Adding myself to the list of committers.
2384
2385         * Scripts/webkitpy/common/config/committers.py:
2386
2387 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2388
2389         Reviewed by David Levin.
2390
2391         check-webkit-style treated some macros with parentheses after #elif as function calls
2392         https://bugs.webkit.org/show_bug.cgi?id=51695
2393
2394         Ingore function call space checking in any preprocessor directives
2395         (things starting with #). Change search() to match() because
2396         preprocessor directives are supposed to be in the beginning of lines.
2397
2398         * Scripts/webkitpy/style/checkers/cpp.py:
2399         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2400
2401 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2402
2403         Reviewed by Tony Chang.
2404
2405         Change the --multi-load test option to --stress-opt
2406         https://bugs.webkit.org/show_bug.cgi?id=50751
2407
2408         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2409         (runTest):
2410         (main):
2411         * DumpRenderTree/chromium/TestShell.cpp:
2412         (TestShell::TestShell):
2413         * DumpRenderTree/chromium/TestShell.h:
2414         (TestShell::stressOpt):
2415         (TestShell::setStressOpt):
2416         (TestShell::stressDeopt):
2417         (TestShell::setStressDeopt):
2418         (TestShell::javaScriptFlags):
2419         (TestShell::setJavaScriptFlags):
2420         * Scripts/webkitpy/layout_tests/port/chromium.py:
2421         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2422
2423 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2424
2425         Reviewed by Sam Weinig.
2426
2427         WK2: Support Accessibility
2428         https://bugs.webkit.org/show_bug.cgi?id=51859
2429
2430         Use rootObject() method to get top of accessibility tree.
2431
2432         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2433         (AccessibilityController::focusedElement):
2434         (AccessibilityController::rootElement):
2435
2436 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2437
2438         Reviewed by Darin Adler.
2439
2440         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2441         https://bugs.webkit.org/show_bug.cgi?id=51846
2442
2443         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2444         back to GRefPtr.
2445
2446 2011-01-04  Zhe Su  <suzhe@chromium.org>
2447
2448         Reviewed by Kenneth Russell.
2449
2450         Fix insertText, setMarkedText and unmarkText methods of
2451         TextInputController to call corresponding methods of WebKit::WebView
2452         rather than WebKit::WebFrame. This change matches the behavior of
2453         chromium browser.
2454         insertText corresponds to WebView::confirmComposition(text)
2455         setMarkedText corresponds to WebView::setComposition(...)
2456         unmarkText corresponds to WebView::confirmComposition()
2457         https://bugs.webkit.org/show_bug.cgi?id=51693
2458
2459         * DumpRenderTree/chromium/TextInputController.cpp:
2460         (TextInputController::insertText):
2461         (TextInputController::setMarkedText):
2462         (TextInputController::unmarkText):
2463
2464 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2465
2466         Reviewed by Laszlo Gombos.
2467
2468         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2469
2470         On Symbian productDir points to the source directory. Removing all the
2471         empty files from the productDir directory corrupts the svn repository.
2472
2473         * Scripts/build-webkit:
2474
2475 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2476
2477         Reviewed by Adam Barth.
2478
2479         [Qt] Add SelectAll option to the context menu for the editor
2480         https://bugs.webkit.org/show_bug.cgi?id=50049
2481
2482         Set shortcut for the SelectAll action.
2483
2484         * QtTestBrowser/mainwindow.cpp:
2485         (MainWindow::buildUI):
2486
2487 2011-01-03  David Levin  <levin@chromium.org>
2488
2489         Reviewed by Eric Seidel.
2490
2491         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2492         https://bugs.webkit.org/show_bug.cgi?id=51842
2493
2494         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2495         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2496
2497 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2498
2499         Reviewed by David Kilzer.
2500
2501         [WINCE] Adds a build slave.
2502         https://bugs.webkit.org/show_bug.cgi?id=50523
2503
2504         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2505         entry for a release build of the WinCE port.
2506         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2507         flag to build the WinCE port.
2508
2509 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2510
2511         Reviewed by David Kilzer.
2512
2513         Add WinCE support to build-webkit
2514         https://bugs.webkit.org/show_bug.cgi?id=51642
2515
2516         * Scripts/build-webkit:
2517         * Scripts/webkitdirs.pm:
2518
2519 2011-01-03  Eric Seidel  <eric@webkit.org>
2520
2521         Reviewed by Adam Barth.
2522
2523         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2524         https://bugs.webkit.org/show_bug.cgi?id=51802
2525
2526         I'm not the biggest fan of the test_failures or test_results classes,
2527         but it's better to have one shared set of classes, than separate ones
2528         for new vs. old run-webkit-test result handling.
2529
2530         This moves the ORWT results class "LayoutTestResults" over to using
2531         TestResult and TestFailure classes, making it easy for us to
2532         make all our sheriff-bot and other webkitpy code NRWT ready.
2533
2534         This also makes it a trivial patch to generate results.json information
2535         from ORWT results.html files (for flaky test analysis, etc.) as well
2536         as making it a one-liner to report test failure types when the
2537         commit-queue sees flaky tests.
2538
2539         This patch tried not to add new functionality, but only to replace
2540         the guts of LayoutTestResults, while adding unit tests and hoping
2541         not to break anything.
2542
2543         I also moved callers which assumed User.prompt* were static/class methods
2544         to using them as instance methods (since we'll eventually want to make them such).
2545
2546         In the process of re-writing things, I broke the rebaseline command, so I wrote
2547         a unit test to catch my breakage were I do do so again in the future.
2548
2549         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2550         * Scripts/webkitpy/common/net/layouttestresults.py:
2551         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2552         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2553         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2554         * Scripts/webkitpy/tool/commands/queries.py:
2555         * Scripts/webkitpy/tool/commands/rebaseline.py:
2556         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2557         * Scripts/webkitpy/tool/mocktool.py:
2558
2559 2011-01-03  Adam Barth  <abarth@webkit.org>
2560
2561         Reviewed by Simon Fraser.
2562
2563         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2564         https://bugs.webkit.org/show_bug.cgi?id=51840
2565
2566         * Scripts/webkitpy/common/checkout/scm.py:
2567
2568 2011-01-03  Adam Barth  <abarth@webkit.org>
2569
2570         Reviewed by Simon Fraser.
2571
2572         webkit-patch should only hide update output if --quiet
2573         https://bugs.webkit.org/show_bug.cgi?id=51838
2574
2575         As requested by smfr.
2576
2577         * Scripts/webkitpy/tool/steps/update.py:
2578
2579 2011-01-03  Adam Barth  <abarth@webkit.org>
2580
2581         Reviewed by David Levin.
2582
2583         commit-queue shouldn't reject patches twice if two bots process the same patch
2584         https://bugs.webkit.org/show_bug.cgi?id=51805
2585
2586         Before raising an error, we first check whether the patch is still in
2587         the commit-queue.  This check is still racy, of course, but the time
2588         window is much smaller.
2589
2590         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2591
2592 2011-01-03  Sam Weinig  <sam@webkit.org>
2593
2594         Reviewed by Anders Carlsson.
2595
2596         Make run-api-tests less chatty.
2597         https://bugs.webkit.org/show_bug.cgi?id=51831
2598
2599         - Make script quiet by default and add --verbose option (replacing --quiet).
2600         - When not verbose, pipe stdout and stderr to devnull.
2601
2602         * Scripts/run-api-tests:
2603
2604 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2605
2606         Unreviewed. Adding myself to committers.py.
2607
2608         * Scripts/webkitpy/common/config/committers.py:
2609
2610 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2611
2612         Reviewed by Xan Lopez.
2613
2614         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2615         https://bugs.webkit.org/show_bug.cgi?id=51806
2616
2617         Originally, the $libraryName is 'JavaScriptCore'. When building release
2618         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2619         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2620         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and
2621         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2622         so make it 'WebKitBuild/Release/.libs'
2623
2624         * Scripts/webkitdirs.pm:
2625
2626 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2627
2628         Reviewed by Adam Barth.
2629
2630         Make EFL a core builder
2631         https://bugs.webkit.org/show_bug.cgi?id=51804
2632
2633         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2634         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2635
2636 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2637
2638         [Qt] Unreviewed fix after r74855 and r74875.
2639
2640         * BuildSlaveSupport/built-product-archive:
2641          - Create directories explicitly.
2642          - Pass shell=True to subprocess.call().
2643
2644 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2645
2646         [Qt] Unreviewed fix after r74855.
2647
2648         Move JavaScriptCore to Source
2649         https://bugs.webkit.org/show_bug.cgi?id=51604
2650
2651         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2652
2653 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2654
2655         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2656
2657         Move JavaScriptCore to Source
2658         https://bugs.webkit.org/show_bug.cgi?id=51604
2659
2660         * Scripts/webkitdirs.pm:
2661
2662 2011-01-02  Robert Hogan  <robert@webkit.org>
2663
2664         Unreviewed, build fix.
2665
2666         [Qt] Fix DRT build after 74855
2667
2668         * DumpRenderTree/qt/DumpRenderTree.pro:
2669
2670 2011-01-01  Adam Barth  <abarth@webkit.org>
2671
2672         Remove the assumption from the Qt and Gtk builds that every project is
2673         in the root directory.
2674
2675         * Scripts/build-webkit:
2676
2677 2011-01-01  Adam Barth  <abarth@webkit.org>
2678
2679         Reviewed by Eric Seidel.
2680
2681         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2682         https://bugs.webkit.org/show_bug.cgi?id=51796
2683
2684         After this change, svn-apply will magically apply patches to
2685         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2686
2687         * Scripts/VCSUtils.pm:
2688
2689 2011-01-01  Adam Barth  <abarth@webkit.org>
2690
2691         Reviewed by Eric Seidel.
2692
2693         Move JavaScriptCore to Source
2694         https://bugs.webkit.org/show_bug.cgi?id=51604
2695
2696         Update references to JavaScriptCore to point to the new location.
2697
2698         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2699         * DumpRenderTree/qt/DumpRenderTree.pro:
2700         * DumpRenderTree/qt/ImageDiff.pro:
2701         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2702         * DumpRenderTree/wscript:
2703         * Scripts/build-jsc:
2704         * Scripts/build-webkit:
2705         * Scripts/do-file-rename:
2706         * Scripts/do-webcore-rename:
2707         * Scripts/run-javascriptcore-tests:
2708         * Scripts/update-javascriptcore-test-results:
2709         * Scripts/webkitdirs.pm:
2710         * Scripts/webkitpy/common/config/build_unittest.py:
2711         * Scripts/webkitpy/style/checker.py:
2712         * Scripts/webkitpy/style/checker_unittest.py:
2713         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2714         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2715         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2716         * wx/build/settings.py:
2717
2718 2011-01-01  Adam Barth  <abarth@webkit.org>
2719
2720         Reviewed by Eric Seidel.
2721
2722         Move Sources to Source
2723         https://bugs.webkit.org/show_bug.cgi?id=51794
2724
2725         Update scripts to point to the new location.
2726
2727         * Scripts/build-webkit:
2728         * Scripts/do-file-rename:
2729         * Scripts/do-webcore-rename:
2730         * Scripts/webkitpy/common/config/build.py:
2731         * Scripts/webkitpy/common/config/build_unittest.py:
2732
2733 2010-12-31  Kent Tamura  <tkent@chromium.org>
2734
2735         Reviewed by Eric Seidel.
2736
2737         [DRT/Chromium] Enable mock spell checker on non-OSX
2738         https://bugs.webkit.org/show_bug.cgi?id=51401
2739
2740         * DumpRenderTree/chromium/WebViewHost.cpp:
2741         (WebViewHost::spellCheck):
2742
2743 2010-12-31  Adam Barth  <abarth@webkit.org>
2744
2745         Reviewed by Ariya Hidayat.
2746
2747         Remove Tools/Scripts/wkstyle
2748         https://bugs.webkit.org/show_bug.cgi?id=51774
2749
2750         This script appears to not have been touched in a while and seems to
2751         have been replaced by check-webkit-style.
2752
2753         * Scripts/wkstyle: Removed.
2754
2755 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2756
2757         Unreviewed. Coding style fix.
2758
2759         * DumpRenderTree/chromium/TestShell.h:
2760
2761 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2762
2763         Reviewed by Pavel Feldman.
2764
2765         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2766
2767         It was a problem with Chromium DRT. DevToolsAgent object instance was
2768         attached not only to the inspected page but to the DevTools window too.
2769         As result all the inspector files were interpreted as a content of inspected page
2770         and were transfered to the DevTools scripts panel for debugging etc.
2771
2772         https://bugs.webkit.org/show_bug.cgi?id=51735
2773
2774         * DumpRenderTree/chromium/TestShell.cpp:
2775         (TestShell::TestShell):
2776         (TestShell::bindJSObjectsToWindow):
2777         (TestShell::createNewWindow):
2778         * DumpRenderTree/chromium/TestShell.h:
2779
2780 2010-12-31  Adam Barth  <abarth@webkit.org>
2781
2782         Rubber-stamped by Eric Seidel.
2783
2784         Move PageLoadTests to PerformanceTests/PageLoad
2785         https://bugs.webkit.org/show_bug.cgi?id=51771
2786
2787         Update references to PageLoadTests to point to the new location.
2788
2789         * Scripts/run-pageloadtest:
2790         * Scripts/webkitpy/common/config/build.py:
2791
2792 2010-12-31  Adam Barth  <abarth@webkit.org>
2793
2794         Rubber-stamped by Eric Seidel.
2795
2796         Move SunSpider into PerformanceTests
2797         https://bugs.webkit.org/show_bug.cgi?id=51769
2798
2799         Update these scripts to point to the new location.
2800
2801         * Scripts/run-sunspider:
2802         * Scripts/sunspider-compare-results:
2803
2804 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2805
2806         Reviewed by Kent Tamura.
2807
2808         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2809         https://bugs.webkit.org/show_bug.cgi?id=51728
2810
2811         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2812         to render top-level scrollbars. This makes them match the Mac port's
2813         use of an NSScrollView, which means that we'll be able to share more
2814         pixel baselines.
2815
2816         The new rendering code will not be activated until the
2817         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2818         ScrollbarThemeChromiumMac.
2819
2820         * DumpRenderTree/DumpRenderTree.gypi:
2821         * DumpRenderTree/chromium/TestShellMac.mm:
2822         (platformInit):
2823         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2824         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2825         (+[FakeActiveWindow alwaysActiveWindow]):
2826         (+[FakeActiveWindow alwaysInactiveWindow]):
2827         (-[FakeActiveWindow initWithActiveControls:]):
2828         (-[FakeActiveWindow _hasActiveControls]):
2829         (WebThemeEngineDRTMac::paintScrollbarThumb):
2830         (stateToHIEnableState):
2831         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2832         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2833
2834 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2835
2836         Reviewed by David Kilzer.
2837
2838         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2839         used
2840         https://bugs.webkit.org/show_bug.cgi?id=51672
2841
2842         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2843         with USE_SYSTEM_MALLOC=1
2844         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2845         with USE_SYSTEM_MALLOC=1
2846
2847 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2848
2849         Reviewed by David Kilzer.
2850
2851         [Qt] [Symbian] Fix build-webkit script for Symbian
2852         https://bugs.webkit.org/show_bug.cgi?id=51509
2853
2854         Set the OUTPUT_DIR for Symbian to be the same as the source
2855         directory.
2856
2857         * Scripts/webkitdirs.pm:
2858
2859 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2860
2861         Reviewed by Darin Adler.
2862
2863         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2864         https://bugs.webkit.org/show_bug.cgi?id=51758
2865
2866         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2867
2868         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2869         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2870
2871 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2872
2873         Unreviewed WinCE buildfix.
2874
2875         * WinCELauncher/main.cpp: Add missing include.
2876
2877 2010-12-29  Daniel Bates  <dbates@rim.com>
2878
2879         Reviewed by Darin Adler.
2880
2881         svn-apply updates date of wrong change log entry for a change log diff that
2882         contains two consecutive entries with the same author and date
2883         https://bugs.webkit.org/show_bug.cgi?id=46061
2884
2885         Fixes an issue where the date of the wrong change log entry may be modified.
2886         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2887         in a ChangeLog file to the top of the file.
2888
2889         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2890         diff when it detects that the diff inserts a change log entry earlier in a
2891         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2892         change. With the advent of the commit-queue this functionality of bailing out
2893         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2894         Instead, we should always move the change log entry to the top of the ChangeLog file.
2895
2896         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2897         the date line of the correct change log entry in a ChangeLog diff.
2898
2899         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2900
2901         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2902           Updated the following unit tests now that we move entries inserted earlier to the top:
2903           - "fixChangeLogPatch: New entry inserted in middle."
2904             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2905
2906           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2907             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2908
2909         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2910
2911 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2912
2913         Reviewed by Eric Seidel.
2914
2915         [Qt] Fixed compatibility with gold linker on X11 platforms
2916         https://bugs.webkit.org/show_bug.cgi?id=51700
2917
2918         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2919         Linked TestNetscapePlugin with libX11 on Unix platforms
2920
2921 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2922
2923         Reviewed by Darin Adler.
2924
2925         Circular dependency in webkitpy.common.checkout.changelog module
2926         https://bugs.webkit.org/show_bug.cgi?id=50475
2927
2928         Remove automatic import of api.Checkout module when any checkout/
2929         submodule is imported (e.g.: when checkout.scm.Git is imported).
2930
2931         * Scripts/webkitpy/common/checkout/__init__.py:
2932
2933 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2934
2935         Reviewed by Ojan Vafai.
2936
2937         prepare-ChangeLog should support the -g option for specifying the git-commit
2938         https://bugs.webkit.org/show_bug.cgi?id=51708
2939
2940         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2941         webkit-patch, though the exact meaning of the two options remain different.
2942
2943         * Scripts/prepare-ChangeLog: Add -g.
2944
2945 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2946
2947         Reviewed by Simon Hausmann.
2948
2949         [Qt] Fix compilation with Qt in namespace
2950         https://bugs.webkit.org/show_bug.cgi?id=51701
2951
2952         * QtTestBrowser/webview.h:
2953
2954 2010-12-28  Daniel Bates  <dbates@rim.com>
2955
2956         Reviewed by Sam Weinig.
2957
2958         Substitute // MARK: for compiler-specific #pragma mark
2959         https://bugs.webkit.org/show_bug.cgi?id=51657
2960
2961         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2962         substituting  "// MARK:" for "#pragma mark", which provides
2963         analogous code-bookmarking functionality under Xcode.
2964
2965         Also, for consistency, we should substitute "// MARK:" for compiler-
2966         specific "#pragma mark" in the source files for the Mac port.
2967
2968         * DumpRenderTree/AccessibilityTextMarker.cpp:
2969         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2970         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2971         * DumpRenderTree/mac/ObjCController.m:
2972         * MiniBrowser/mac/AppDelegate.m:
2973         * MiniBrowser/mac/BrowserWindowController.m:
2974
2975 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2976
2977         Reviewed by Eric Seidel.
2978
2979         Add --no-build option to run-sunspider
2980         https://bugs.webkit.org/show_bug.cgi?id=51658
2981
2982         * Scripts/run-sunspider: add --no-build flag to skip building
2983         phase.
2984
2985 2010-12-27  Daniel Bates  <dbates@rim.com>
2986
2987         Rubber-stamped by Martin Robinson.
2988
2989         Append the directory Tools/DumpRenderTree to the list of directories that
2990         do-webcore-rename should search so that it can rename DRT files and
2991         source code.
2992
2993         * Scripts/do-webcore-rename:
2994
2995 2010-12-27  Eric Seidel  <eric@webkit.org>
2996
2997         Reviewed by Adam Barth.
2998
2999         build-webkit should detect missing Java SDK and explain how to install it
3000         https://bugs.webkit.org/show_bug.cgi?id=51651
3001
3002         * Scripts/build-webkit:
3003
3004 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3005
3006         Reviewed by Daniel Bates.
3007
3008         [GTK] Add support for build-jsc
3009         https://bugs.webkit.org/show_bug.cgi?id=51625
3010
3011         Add GTK+ support to build-jsc now that building the jsc executable as
3012         a standalone target is easy.
3013
3014         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3015         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3016         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3017         and pass it along to buildAutotoolsProject.
3018
3019 2010-12-27  David Levin  <levin@chromium.org>
3020
3021         Reviewed by Eric Seidel.
3022
3023         check-webkit-style check for meaningless variable names in function declarations.
3024         https://bugs.webkit.org/show_bug.cgi?id=51523
3025
3026         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3027         from the new check and whitespace/parens because the syntax is unusual and
3028         produced a fair number of positives for these checks.
3029         * Scripts/webkitpy/style/checkers/cpp.py:
3030         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3031         and parameter names when determining if the parameter name is useless.
3032         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3033         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3034         format.
3035         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3036         text or an acronym of it.
3037         (check_function_definition): Checks function definitions for meaningless variable names.
3038         (process_line): Added call to check_function_definition.
3039         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3040         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3041         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3042         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3043         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3044         because when only checking a snippet, there are a lot of bogus functions.
3045         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3046         that I put there previously and just noticed.
3047         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3048         check_function_definition and process_line.
3049
3050 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3051
3052         Reviewed by Martin Robinson.
3053
3054         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3055         https://bugs.webkit.org/show_bug.cgi?id=51591
3056
3057         Flash plugin uses gtk2 that is incompatible with gtk3 making
3058         webkit crash when it's built with gtk3.
3059
3060         * GtkLauncher/main.c:
3061         (main):
3062
3063 2010-12-25  Adam Barth  <abarth@webkit.org>
3064
3065         Reviewed by Eric Seidel.
3066
3067         Move ANGLE to Sources/ThirdParty
3068         https://bugs.webkit.org/show_bug.cgi?id=51605
3069
3070         * Scripts/build-webkit:
3071           - Point to the new ANGLE location.
3072
3073 2010-12-26  David Levin  <levin@chromium.org>
3074
3075         Reviewed by Eric Seidel.
3076
3077         check-webkit-style should be able to parse function declaration parameters.
3078         https://bugs.webkit.org/show_bug.cgi?id=51451
3079
3080         * Scripts/webkitpy/style/checkers/cpp.py:
3081         (Position.__init__): Holds simple position information (row, column).
3082         (Parameter.__init__): Holds information about a parameter.
3083         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3084         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3085         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3086         (find_parameter_name_index): Finds where the parameter name is.
3087         (parameter_list): Generates the list of parameters for a function.
3088         (_FunctionState.begin): Added information to allow determining the parameters
3089         on demand.
3090         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3091         (detect_functions): Improve function detection for operator functions and
3092         determine where the parameters end and pass that to _FunctionState.begin.
3093         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3094         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3095         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3096         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3097         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3098         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3099         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3100         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3101         the parameters found.
3102         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3103         detection test to verify that we catch the operator functions.
3104         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3105         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3106         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3107         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3108         test_function_length_check_definition_severity1_for_test.
3109
3110 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3111
3112         Unreviewed WinCE buildfix after r74334.
3113
3114         * CMakeListsWinCE.txt:
3115
3116 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3117
3118         Unreviewed, rolling out r74632.
3119         http://trac.webkit.org/changeset/74632
3120         https://bugs.webkit.org/show_bug.cgi?id=51600
3121
3122         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3123         on #webkit).
3124
3125         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3126         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3127
3128 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3129
3130         Reviewed by Kenneth Rohde Christiansen.
3131
3132         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3133         https://bugs.webkit.org/show_bug.cgi?id=43528
3134
3135         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3136         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3137         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3138         called.
3139
3140         * EWebLauncher/main.c:
3141         (browserCreate):
3142
3143 2010-12-24  Eric Seidel  <eric@webkit.org>
3144
3145         Reviewed by Adam Barth.
3146
3147         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3148         https://bugs.webkit.org/show_bug.cgi?id=28291
3149
3150         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3151         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3152         to strings with find in the diff.
3153         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3154
3155         * Scripts/webkitpy/common/checkout/api.py:
3156         * Scripts/webkitpy/common/checkout/diff_parser.py:
3157         * Scripts/webkitpy/tool/steps/abstractstep.py:
3158         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3159         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3160         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3161         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3162
3163 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3164
3165         Reviewed by Kenneth Russell.
3166
3167         Modify new-run-webkit-tests to shut up and exit when all the threads
3168         are wedged so that test runs complete faster and we don't end up
3169         w/ enormous log files.
3170
3171         https://bugs.webkit.org/show_bug.cgi?id=51572
3172
3173         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3174         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3175
3176 2010-12-24  Eric Seidel  <eric@webkit.org>
3177
3178         Reviewed by David Levin.
3179
3180         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3181         https://bugs.webkit.org/show_bug.cgi?id=51549
3182
3183         I've had multiple people ask me about the commit-queue's behavior
3184         regarding reporting flaky tests.  I figured it would be best to just
3185         have the queue explain itself in the bugs it files.
3186
3187         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3188         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3189
3190 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3191
3192         Reviewed by Eric Seidel.
3193
3194         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3195         https://bugs.webkit.org/show_bug.cgi?id=51467
3196
3197         * Scripts/webkitpy/style/checker.py:
3198         * Scripts/webkitpy/style/checker_unittest.py:
3199
3200 2010-12-23  Adam Barth  <abarth@webkit.org>
3201
3202         Rubber-stamped by Eric Seidel.
3203
3204         Move JavaScriptGlue into Sources
3205         https://bugs.webkit.org/show_bug.cgi?id=51583
3206
3207         These tools refer to JavaScriptGlue and need to be updated to its new
3208         location.
3209
3210         * Scripts/build-webkit:
3211         * Scripts/do-file-rename:
3212         * Scripts/do-webcore-rename:
3213         * Scripts/webkitpy/common/config/build.py:
3214         * Scripts/webkitpy/common/config/build_unittest.py:
3215
3216 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3217
3218         Reviewed by Eric Seidel.
3219
3220         Bug 51539 - update iexploder scripts to point to new location
3221
3222         * Scripts/run-iexploder-tests:
3223         * Scripts/update-iexploder-cssproperties:
3224
3225 2010-12-23  Evan Martin  <evan@chromium.org>
3226
3227         Reviewed by Ryosuke Niwa.
3228
3229         [chromium] LayoutTestController warning in float->int conversion
3230         https://bugs.webkit.org/show_bug.cgi?id=51553
3231
3232         Rather than reading an int, converting to a float, then getting a compiler
3233         warning on passing the float to something that expects an int, instead
3234         just pass around ints.
3235
3236         No tests, fixes a compiler warning.
3237
3238         * DumpRenderTree/chromium/LayoutTestController.cpp:
3239         (parsePageSizeParameters):
3240         (LayoutTestController::pageNumberForElementById):
3241         (LayoutTestController::numberOfPages):
3242
3243 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3244
3245         Reviewed by Darin Adler.
3246
3247         Bug 51537 - iexploder needs cleanup
3248
3249         * iExploder/htdocs: Removed.
3250         * iExploder/htdocs/config.rb: Removed.
3251         * iExploder/htdocs/cssproperties.in: Removed.
3252         * iExploder/htdocs/cssvalues.in: Removed.
3253         * iExploder/htdocs/htmlattrs.in: Removed.
3254         * iExploder/htdocs/htmltags.in: Removed.
3255         * iExploder/htdocs/htmlvalues.in: Removed.
3256         * iExploder/htdocs/iexploder.cgi: Removed.
3257         * iExploder/htdocs/iexploder.rb: Removed.
3258         * iExploder/htdocs/index.html: Removed.
3259         * iExploder/htdocs/webserver.rb: Removed.
3260         * iExploder/iexploder-1.7.2/output: Removed.
3261         * iExploder/tools: Removed.
3262         * iExploder/tools/lasthit.rb: Removed.
3263         * iExploder/tools/osx_last_crash.rb: Removed.
3264         * iExploder/tools/showtest.rb: Removed.
3265
3266 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3267
3268         Reviewed by Kenneth Rohde Christiansen.
3269
3270         [EFL] Make 'single' the default backing store in EWebLauncher
3271         https://bugs.webkit.org/show_bug.cgi?id=51534
3272
3273         'single' is the simplest backing store and the one intended to be the
3274         default in the test browser. By mistake the tiled backing store was
3275         left as default in r72617.
3276
3277         * EWebLauncher/main.c:
3278         (browserCreate): ditto.
3279
3280 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3281
3282         Reviewed by Kenneth Rohde Christiansen.
3283
3284         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3285         https://bugs.webkit.org/show_bug.cgi?id=51533
3286
3287         There's no point in concatenating env("HOME") with "blah", so remove
3288         option from EWebLauncher.
3289
3290         * EWebLauncher/main.c:
3291         (main): ditto.
3292
3293 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3294
3295         Reviewed by Eric Seidel.
3296
3297         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3298
3299         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3300         I just discovered that we have two additional GC runs per each WebViewHost.
3301         Test_shell had no such calls.
3302         These gc runs eat 15% of cpu time.
3303
3304         https://bugs.webkit.org/show_bug.cgi?id=51479
3305
3306         * DumpRenderTree/chromium/WebViewHost.cpp:
3307         (WebViewHost::~WebViewHost):
3308
3309 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3310
3311         Reviewed by Ojan Vafai.
3312
3313         This change splits out the TestRunner class into its own file.
3314         When we fork the code for message passing, we will create a new
3315         TestRunner, and this change will allow that to be more modular.
3316
3317         While we're at it, split out TestInput and ResultSummary into
3318         their own files, to reduce the size of run_webkit_tests to
3319         something more managable.
3320
3321         https://bugs.webkit.org/show_bug.cgi?id=51092
3322
3323         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3324         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3325         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3326         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3327         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3328         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3329         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3330
3331  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3332
3333         Reviewed by Ojan Vafai.
3334
3335         nrwt multiprocessing - start over, prepare to fork the code
3336
3337         This code cleans up the signatures and implementation of the
3338         TestRunner class so we can easily fork it to run either the
3339         stable implementation or the new, unstable message-passing
3340         implementation. The two variants will have different
3341         implementations of the run_tests() method. We will switch
3342         between the two based on the setting for the '--worker-model'
3343         switch. We rename the two currently valid values to 'old-inline'
3344         and 'old-threads'.
3345
3346         https://bugs.webkit.org/show_bug.cgi?id=51081
3347
3348         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3349         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3350
3351 2010-12-22  Victor Wang  <victorw@chromium.org>
3352
3353         Reviewed by Darin Fisher.
3354
3355         [Chromium] Update chromium archive test result url in rebaseline script.
3356
3357         https://bugs.webkit.org/show_bug.cgi?id=51503
3358
3359         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3360
3361 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3362
3363         Reviewed by Alice Liu.
3364
3365         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3366         Verified on Chrome, Safari, and IE.
3367         With this change, we will record memory from a parent browser window and all child processes.
3368
3369         * record-memory-win/main.cpp:
3370         (ProcessArgs):
3371         (PrintUsage):
3372         (getMemoryInfo):
3373         (printProcessInfo):
3374         (evalProcesses):
3375         (UseImage):
3376         (QueryContinuously):
3377         (ElapsedTime):
3378
3379 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3380
3381         Unreviewed rollout r74489, because it was missing changelog.
3382
3383         * record-memory-win/main.cpp:
3384
3385 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3386
3387         Adding myself as a reviewer.
3388
3389         * Scripts/webkitpy/common/config/committers.py:
3390
3391 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3392
3393         Unreviewed.  Adding myself to committers.py.
3394
3395         * Scripts/webkitpy/common/config/committers.py:
3396
3397 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3398
3399         Reviewed by Kenneth Rohde Christiansen.
3400
3401         TestNetscapePlugIn should use #if defined
3402         https://bugs.webkit.org/show_bug.cgi?id=51471
3403
3404         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3405         (NP_Initialize):
3406         (NPP_New):
3407
3408 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3409
3410         Reviewed by Yury Semikhatsky.
3411
3412         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3413
3414         DevTools window should be closed explicitly because it has custom deinitialization code.
3415
3416         https://bugs.webkit.org/show_bug.cgi?id=50722
3417
3418         * DumpRenderTree/chromium/TestShell.cpp:
3419         (TestShell::closeRemainingWindows):
3420
3421 2010-12-22  David Levin  <levin@chromium.org>
3422
3423         Reviewed by Shinichiro Hamaji.
3424
3425         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3426         https://bugs.webkit.org/show_bug.cgi?id=51452
3427
3428         * Scripts/webkitpy/style/checkers/cpp.py:
3429         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3430         Using the file extension if possible but falling back to the file contents if we have a header file.
3431         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3432         (_FileState.is_c_or_objective_c):
3433         (check_using_std): Changed to using _FileState to determine the file type.
3434         (check_max_min_macros): Ditto.
3435         (check_for_null): Ditto.
3436         (check_style): Changed the parameters to various calls since they now need _FileState
3437         to determine the file type.
3438         (check_language): Added the file_state parameter so it could be passed
3439         to check_identifier_name_in_declaration.
3440         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3441         this is an Objective C file.
3442         (_process_lines): Added information for the _FileState constructor (and moved the
3443         call to a place that had the information).
3444         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3445         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3446         its functionality.
3447         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3448
3449 2010-12-21  Andy Estes  <aestes@apple.com>
3450
3451         Reviewed by Mark Rowe.
3452
3453         Do not build non-Intel architectures for WebKit2-related projects.
3454         https://bugs.webkit.org/show_bug.cgi?id=51440
3455
3456         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3457         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3458         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3459
3460 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3461
3462         Reviewed by Darin Fisher.
3463
3464         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3465         https://bugs.webkit.org/show_bug.cgi?id=51406
3466
3467         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3468         to WebThemeEngineDRTWin and update references everywhere.
3469
3470         * DumpRenderTree/DumpRenderTree.gypi:
3471         * DumpRenderTree/chromium/TestShellWin.cpp:
3472         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3473         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3474         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3475         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3476
3477 2010-12-21  Anders Carlsson  <andersca@apple.com>
3478
3479         Reviewed by John Sullivan.
3480
3481         Clicking missing plug-in text does not show a sheet
3482         https://bugs.webkit.org/show_bug.cgi?id=51403
3483
3484         Update for changes to the WebPageUIClient.
3485
3486         * MiniBrowser/mac/BrowserWindowController.m:
3487         (-[BrowserWindowController awakeFromNib]):
3488         * WebKitTestRunner/TestController.cpp:
3489         (WTR::createOtherPage):
3490         (WTR::TestController::initialize):
3491
3492 2010-12-21  Eric Seidel  <eric@webkit.org>
3493
3494         Reviewed by Adam Barth.
3495
3496         commit-queue will report constant failures as flaky if other tests flake
3497         https://bugs.webkit.org/show_bug.cgi?id=51272
3498
3499         This patch just removes functionality and adds testing.
3500         Previously we attempted to report flaky tests when we had
3501         two different tests fail in a row.  However, since we stop
3502         running the tests at the first failure, our code was wrong in
3503         trying to determine flakiness from the incomplete runs.
3504
3505         Originally I posted an alternate patch:
3506         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3507         which fixed our flaky logic in this case, however it was decided
3508         that that patch would be too difficult to maintain, so now
3509         I'm just removing the broken logic.
3510
3511         This will dramatically cut-down on our flaky-test false positives
3512         at the (small) cost of the queues being unable to report
3513         any flakiness if the tree is very flaky.  (With at least one test
3514         flaking on every run, we'll never report failures anymore.)  I think
3515         this is a tradeoff worth making.
3516
3517         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3518         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3519
3520 2010-12-20  Eric Seidel  <eric@webkit.org>
3521
3522         Reviewed by Adam Barth.
3523
3524         commit-queue wrongly rejects patches when it can't update itself
3525         https://bugs.webkit.org/show_bug.cgi?id=46636
3526
3527         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3528         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3529         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3530
3531 2010-12-20  Adam Barth  <abarth@webkit.org>
3532
3533         Move web sites to Websites directory
3534         https://bugs.webkit.org/show_bug.cgi?id=51323
3535
3536         Update references to BugsSite to point to the new location.
3537
3538         This patch was never officially reviewed (because it was too large to
3539         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3540         Rowe gave me the green light.
3541
3542         * Scripts/old-run-webkit-tests:
3543         * Scripts/webkitpy/common/config/build.py:
3544         * Scripts/webkitpy/common/config/build_unittest.py:
3545         * Scripts/webkitpy/common/prettypatch.py:
3546         * Scripts/webkitpy/layout_tests/port/base.py:
3547         * Scripts/webkitpy/style/main.py:
3548
3549 2010-12-20  Adrienne Walker  <enne@google.com>
3550
3551         Unreviewed. Adding myself to the list of committers.
3552
3553         * webkitpy/common/config/committers.py:
3554
3555 2010-12-20  Mark Rowe  <mrowe@apple.com>
3556
3557         Reviewed by Dan Bernstein.
3558
3559         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3560
3561         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3562         Resources directory.
3563
3564 2010-12-20  Eric Seidel  <eric@webkit.org>
3565
3566         Reviewed by Adam Barth.
3567
3568         commit-queue should include bot id when attaching failure diffs
3569         https://bugs.webkit.org/show_bug.cgi?id=51280
3570
3571         This is a tiny change to include the bot id in the name of the attachment.
3572         Most of this diff is just changing the unit test expectations
3573         now that I hid the comment printing when the comment is None.
3574
3575         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3576         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3577         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3578         * Scripts/webkitpy/tool/mocktool.py:
3579
3580 2010-12-20  Jeff Miller  <jeffm@apple.com>
3581
3582         Reviewed by Dan Bernstein.
3583
3584         Tools/vcbin/midl.exe needs to be rebuilt
3585         https://bugs.webkit.org/show_bug.cgi?id=51347
3586
3587         * vcbin/midl.exe: Rebuilt.
3588
3589 2010-12-20  David Levin  <levin@chromium.org>
3590
3591         Reviewed by Ariya Hidayat.
3592
3593         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3594         https://bugs.webkit.org/show_bug.cgi?id=51343
3595
3596         Follow up from the WebKitTools -> Tools rename.
3597
3598         * Scripts/webkit-tools-completion.sh:
3599
3600 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3601
3602         Reviewed by James Robinson.
3603
3604         new-run-webkit-tests ignores trailing EOL differences in text tests
3605         https://bugs.webkit.org/show_bug.cgi?id=36983
3606
3607         Changed the handling of new-line characters within new-run-webkit-tests
3608         to match old-run-webkit-tests.  Differences in leading and trailing empty
3609         lines in text expectation files are no longer ignored.
3610
3611         * Scripts/webkitpy/layout_tests/port/base.py:
3612         * Scripts/webkitpy/layout_tests/port/test.py:
3613         Added unit tests.  Removed old duplicate unit test entries.
3614         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3615
3616 2010-12-20  David Levin  <levin@chromium.org>
3617
3618         Reviewed by Shinichiro Hamaji.
3619
3620         check-webkit-style should detect function declarations (and trivial functions).
3621         https://bugs.webkit.org/show_bug.cgi?id=51303
3622
3623         * Scripts/webkitpy/style/checkers/cpp.py:
3624         (_FunctionState.begin): Add is_declaration and changed the line count
3625         start to begin at -1 (which will keep the results consistent, since
3626         the starting line number passed in is one less in this change).
3627         (detect_functions): changed function detection to now catch trivial
3628         functions and declarations.
3629         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3630         of the function as this may look at return values (when processing
3631         a declaration).
3632         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3633         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3634         of testing the function detection.
3635         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3636         function.
3637         (FunctionDetectionTest.test_function_declaration_detection): Test a
3638         declaration.
3639         (FunctionDetectionTest.test_non_functions): A test case for a case
3640         that caused the code to fail due to the { being in quotes.
3641         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3642         cases to help catch false alarms for return values.
3643         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3644         we don't get false alarms for member variables either.
3645
3646 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3647
3648         Reviewed by Antonio Gomes.
3649
3650         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3651         https://bugs.webkit.org/show_bug.cgi?id=51319
3652
3653         * CMakeListsEfl.txt:
3654
3655 2010-12-18  Adam Barth  <abarth@webkit.org>
3656
3657         Reviewed by Sam Weinig.
3658
3659         Move WebKitExamplePlugins to Examples
3660         https://bugs.webkit.org/show_bug.cgi?id=51291
3661
3662         * Scripts/webkitpy/common/config/build.py:
3663
3664 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3665
3666         Unreviewed Qt buildfix after r74301.
3667
3668         Rename WebKitTools to Tools
3669         https://bugs.webkit.org/show_bug.cgi?id=49861
3670
3671         * MiniBrowser/DerivedSources.pro:
3672         * MiniBrowser/qt/MiniBrowser.pro:
3673
3674 2010-12-17  Dan Bernstein  <mitz@apple.com>
3675
3676         Reviewed by Simon Fraser.
3677
3678         Rename WebKitTools to Tools
3679         https://bugs.webkit.org/show_bug.cgi?id=49861
3680
3681         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3682         * CodeCoverage/README:
3683         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3684         (WebCore::DumpRenderTree::initializeFonts):
3685         * EWSTools/start-commit-queue.sh:
3686         * EWSTools/start-queue.sh:
3687         * GNUmakefile.am:
3688         * MIDLWrapper/MIDLWrapper.cpp:
3689         (wmain):
3690         * MiniBrowser/qt/MiniBrowser.pro:
3691         * Scripts/build-api-tests:
3692         * Scripts/build-dumprendertree:
3693         * Scripts/build-webkit:
3694         * Scripts/build-webkittestrunner:
3695         * Scripts/generate-coverage-data:
3696         * Scripts/old-run-webkit-tests:
3697         * Scripts/run-api-tests:
3698         * Scripts/run-iexploder-tests:
3699         * Scripts/run-javascriptcore-tests:
3700         * Scripts/run-mangleme-tests:
3701         * Scripts/run-sunspider:
3702         * Scripts/run-webkit-websocketserver:
3703         * Scripts/sunspider-compare-results:
3704         * Scripts/test-webkitperl:
3705         * Scripts/test-webkitpy:
3706         * Scripts/update-iexploder-cssproperties:
3707         * Scripts/update-webkit:
3708         * Scripts/update-webkit-localizable-strings:
3709         * Scripts/webkitdirs.pm:
3710         * Scripts/webkitpy/common/checkout/scm.py:
3711         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3712         * Scripts/webkitpy/common/config/committervalidator.py:
3713         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3714         * Scripts/webkitpy/common/config/ports.py:
3715         * Scripts/webkitpy/common/config/ports_unittest.py:
3716         * Scripts/webkitpy/common/system/logutils_unittest.py:
3717         * Scripts/webkitpy/common/system/ospath_unittest.py:
3718         * Scripts/webkitpy/layout_tests/port/chromium.py:
3719         * Scripts/webkitpy/layout_tests/port/config.py:
3720         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3721         * Scripts/webkitpy/layout_tests/port/http_server.py:
3722         * Scripts/webkitpy/layout_tests/port/test.py:
3723         * Scripts/webkitpy/style/checker.py:
3724         * Scripts/webkitpy/style/checker_unittest.py:
3725         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3726         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3727         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3728         * WebKitTestRunner/DerivedSources.pro:
3729         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3730         (WTR::activateFonts):
3731         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3732         * wx/build/build_utils.py:
3733
3734 2010-12-16  Antonio Gomes  <agomes@rim.com>
3735
3736         Reviewed by Martin Robinson.
3737
3738         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3739         https://bugs.webkit.org/show_bug.cgi?id=51163
3740
3741         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3742         GTK+'s DRT should also reset to UNIX after each test execution.
3743
3744         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3745         (resetDefaultsToConsistentValues):
3746
3747 2010-12-17  David Levin  <levin@chromium.org>
3748
3749         Reviewed by Eric Seidel.
3750
3751         check-webkit-style should understand WTF #include guards
3752         https://bugs.webkit.org/show_bug.cgi?id=44911
3753
3754         * Scripts/webkitpy/style/checkers/cpp.py:
3755         (get_header_guard_cpp_variable): modify to suggest the WTF style
3756         of header guard when appropriate.
3757         (check_for_header_guard): handle multiple return values from
3758         get_header_guard_cpp_variable
3759         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3760         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3761         header style.
3762
3763 2010-12-16  David Levin  <levin@chromium.org>
3764
3765         Reviewed by Eric Seidel.
3766
3767         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3768         https://bugs.webkit.org/show_bug.cgi?id=51210
3769
3770         The error only shows up when using python 2.6 or later.
3771
3772         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3773         the decprecated field error,message with something equivalent.
3774
3775 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3776
3777         Reviewed by Eric Seidel.
3778
3779         Add --exit-after-n-failures/crashes to NRWT
3780         https://bugs.webkit.org/show_bug.cgi?id=51160
3781
3782         Abort test run (in a similar way to how control-C is handled) when
3783         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3784         that number of unexpected failures/crashes/timeouts.
3785
3786         * Scripts/webkitpy/layout_tests/port/test.py:
3787         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3788         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3789
3790 2010-12-16  David Levin  <levin@chromium.org>
3791
3792         Reviewed by Shinichiro Hamaji.
3793
3794         check-webkit-style unit tests has some duplicate boilerplate code.
3795         https://bugs.webkit.org/show_bug.cgi?id=49519
3796
3797         * Scripts/webkitpy/style/checkers/cpp.py:
3798         (update_include_state): Replaced the "io" parameter with the global
3799         configuration _unit_test_config. This allowed not calling into
3800         functions at a low level and also not plumbing through the injection
3801         information through many levels of code.
3802         (check_for_include_what_you_use): Ditto.
3803         (process_file_data): Added the ability to set up the unit test config
3804         to allow for injection.
3805         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3806         (ErrorCollector.__init__): Added support for having a filter for errors.
3807         (ErrorCollector.__call__): Ditto.
3808         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3809         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3810         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3811         functions in the cpp.py with generic processing and a filter that
3812         indicates what errors should be kept.
3813         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3814         (CppStyleTestBase.perform_language_rules_check): Ditto.
3815         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3816         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3817         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3818         (CppStyleTest.test_multi_line_comments): Added another
3819         error message which applies to the test case.
3820         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3821         to not have config.h, since it is processed as a header file.
3822         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3823         style and indentation in checked code.
3824         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3825         Fixed line number.
3826         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3827         Ditto.
3828
3829 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3830
3831         Unreviewed, rolling out r74136.
3832         http://trac.webkit.org/changeset/74136
3833         https://bugs.webkit.org/show_bug.cgi?id=51135
3834
3835         r74136 breaks chromium canary bots because some tests are not
3836         rebaselined correctly to resolve EOL differences (Requested by
3837         jianli on #webkit).
3838
3839         * Scripts/webkitpy/layout_tests/port/base.py:
3840         * Scripts/webkitpy/layout_tests/port/test.py:
3841         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3842
3843 2010-12-15  Adam Roben  <aroben@apple.com>
3844
3845         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3846         syntax errors
3847
3848         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3849         XML syntax errors in .vcproj/.vsprops files
3850
3851         Reviewed by Dave Levin.
3852
3853         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3854         that should be treated as XML and that should be allowed to contain
3855         carriage returns. (These lists happen to be identical currently.)
3856         (FileType): Added a new XML type.
3857         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3858         Just does a simple file extension check.
3859         (CheckerDispatcher._file_type): Added a case for XML files.
3860         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3861         files (surprise!).
3862         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3863         lines through the carriage checker.
3864
3865         * Scripts/webkitpy/style/checker_unittest.py:
3866         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3867         Added. Checks a few file names to see if carriage returns are allowed
3868         or not.
3869         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3870         other assert_checker_* functions.
3871         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3872         test_*_paths functions.
3873         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3874         test_*_paths functions.
3875         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3876         file from this test case, as vcproj files now have a type.
3877         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3878         Added. Similar to the other should_* functions.
3879         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3880         Added. Checks that carriage returns aren't checked for or stripped for
3881         allowed files.
3882
3883         * Scripts/webkitpy/style/checkers/xml.py: Added.
3884         (XMLChecker.__init__): Simple init method.
3885         (XMLChecker.check): Pass each line through the expat parser, and record
3886         a style error for any errors thrown by the parser.
3887
3888         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3889         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3890         produce a style error.
3891         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3892         error of the given category on the given line.
3893         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3894         checking that the XMLChecker constructor works properly.
3895         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3896         cause a style error (see, e.g., r73887).
3897         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3898         cause a style error (see, e.g., r73773).
3899         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3900         properly.
3901         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3902         tags cause a style error (see, e.g., r72795).
3903         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3904         style error.
3905
3906 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3907
3908         Reviewed by Stephanie Lewis.
3909
3910         https://bugs.webkit.org/show_bug.cgi?id=51117
3911         Add a new leopard test bot
3912         really really commit to trunk this time.
3913
3914         * BuildSlaveSupport/build.webkit.org-config/config.json:
3915
3916 2010-12-15  Sam Weinig  <sam@webkit.org>
3917
3918         Reviewed by Anders Carlsson.
3919
3920         WebKit2: Can't add files to an <input type=file>
3921         https://bugs.webkit.org/show_bug.cgi?id=51087
3922
3923         * MiniBrowser/mac/BrowserWindowController.m:
3924         (runOpenPanel):
3925         (-[BrowserWindowController awakeFromNib]):
3926         Add simple implementation of runOpenPanel callback.
3927
3928         * MiniBrowser/win/BrowserView.cpp:
3929         (BrowserView::create):
3930         * WebKitTestRunner/TestController.cpp:
3931         (WTR::createOtherPage):
3932         (WTR::TestController::initialize):
3933         Stub out runOpenPanel callback.
3934
3935 2010-12-14  Eric Seidel  <eric@webkit.org>
3936
3937         Reviewed by Adam Barth.
3938
3939         commit-queue should upload failure diffs when tests flake
3940         https://bugs.webkit.org/show_bug.cgi?id=51051
3941
3942         To make this testable I needed to pipe FileSystem down onto tool.
3943         We've wanted it there for a long time anyway.
3944
3945         This patch is kinda a big hack.  But we don't have a nice
3946         way to read results.html files.  I think this will need further
3947         revision before this code actually feels clean.
3948
3949         As part of testing this change, I had to make MockBugzilla.create_bug
3950         actually return an id (like it should) which required updating
3951         a few other unit test results (for the better).
3952
3953         The results_matching_keys change in layouttestresults/rebasline
3954         was an alternate path which I decided not to use in the end, but
3955         I left the change as it seemed an improvement.
3956
3957         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3958         * Scripts/webkitpy/common/net/layouttestresults.py:
3959         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3960         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3961         * Scripts/webkitpy/tool/commands/queues.py:
3962         * Scripts/webkitpy/tool/commands/rebaseline.py:
3963         * Scripts/webkitpy/tool/main.py:
3964         * Scripts/webkitpy/tool/mocktool.py:
3965
3966 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3967
3968         Reviewed by James Robinson.
3969
3970         new-run-webkit-tests ignores trailing EOL differences in text tests
3971         https://bugs.webkit.org/show_bug.cgi?id=36983
3972
3973         Changed the handling of new-line characters within new-run-webkit-tests
3974         to match old-run-webkit-tests.  Differences in leading and trailing empty
3975         lines in text expectation files are no longer ignored.
3976
3977         * Scripts/webkitpy/layout_tests/port/base.py:
3978         * Scripts/webkitpy/layout_tests/port/test.py:
3979         Added unit tests.  Removed old duplicate unit test entries.
3980         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3981
3982 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3983
3984         Reviewed by Adam Barth.
3985
3986         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3987         https://bugs.webkit.org/show_bug.cgi?id=51149
3988
3989         * QueueStatusServer/templates/statusbubble.html:
3990
3991 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3992
3993         Reviewed by Adam Barth.
3994
3995         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3996         https://bugs.webkit.org/show_bug.cgi?id=51125
3997
3998         * QueueStatusServer/templates/statusbubble.html:
3999
4000 2010-12-15  Darin Adler  <darin@apple.com>
4001
4002         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
4003
4004 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
4005
4006         Unreviewed, rolling out r74117.
4007         http://trac.webkit.org/changeset/74117
4008         https://bugs.webkit.org/show_bug.cgi?id=51113
4009
4010         This broke the GTK1 build. (Requested by mrobinson on
4011         #webkit).
4012
4013         * Scripts/webkitdirs.pm:
4014
4015 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
4016
4017         Reviewed by Martin Robinson.
4018
4019         Change generate-forwarding-headers.pl for GTK port usage
4020         (https://bugs.webkit.org/show_bug.cgi?id=37369)
4021
4022         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
4023
4024 2010-12-14  Kent Tamura  <tkent@chromium.org>
4025
4026         Reviewed by Jian Li.
4027
4028         [DRT/Chromium] Remove another unnecessary error message
4029         https://bugs.webkit.org/show_bug.cgi?id=51083
4030
4031         * DumpRenderTree/chromium/WebViewHost.cpp:
4032         (WebViewHost::didInvalidateRect):
4033
4034 2010-12-14  Lucas Forschler  <lforschler@apple.com>
4035
4036         Reviewed by Stephanie Lewis.
4037
4038         Add a new Leopard Debug Test WK2 Bot
4039
4040         * BuildSlaveSupport/build.webkit.org-config/config.json:
4041
4042 2010-12-14  Ojan Vafai  <ojan@chromium.org>
4043
4044         Fix python unittests after http://trac.webkit.org/changeset/74070.
4045
4046         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4047
4048 2010-12-14  Kent Tamura  <tkent@chromium.org>
4049
4050         Reviewed by Jian Li.
4051
4052         [DRT/Chromium] Remove a unnecessary error message
4053         https://bugs.webkit.org/show_bug.cgi?id=51069
4054
4055         * DumpRenderTree/chromium/WebViewHost.cpp:
4056         (WebViewHost::paintInvalidatedRegion):
4057
4058 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
4059
4060         Reviewed by Ojan Vafai.
4061
4062         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
4063         https://bugs.webkit.org/show_bug.cgi?id=48926
4064
4065         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
4066         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
4067
4068 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4069
4070         Reviewed by Eric Seidel.
4071
4072         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
4073         https://bugs.webkit.org/show_bug.cgi?id=50231
4074
4075         Guard CONFIG+=link_pkgconfig with !symbian.
4076
4077         * DumpRenderTree/qt/DumpRenderTree.pro:
4078         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4079         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4080
4081 2010-12-14  Philippe Normand  <pnormand@igalia.com>
4082
4083         Reviewed by Ojan Vafai.
4084
4085         [new-run-webkit-tests] expectations parsing is slow
4086         https://bugs.webkit.org/show_bug.cgi?id=50635
4087
4088         Avoid expensive iteration of all the tests when checking if a test
4089         file is to be skipped or not.
4090
4091         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
4092         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
4093         * Scripts/webkitpy/layout_tests/port/test.py:
4094
4095 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
4096
4097         Reviewed by Xan Lopez.
4098
4099         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
4100         https://bugs.webkit.org/show_bug.cgi?id=27048
4101
4102         Add support in DRT for checking whether an accessibility UI
4103         element is focusable and/or focused. Implemented for GTK.
4104
4105         * DumpRenderTree/AccessibilityUIElement.cpp:
4106         (getIsFocusedCallback): New.
4107         (getIsFocusableCallback): New.
4108         (AccessibilityUIElement::getJSClass): Add the new available
4109         callbacks for isFocused and isFocusable.
4110         * DumpRenderTree/AccessibilityUIElement.h:
4111         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4112         (AccessibilityUIElement::isFocused): New, implemented by checking
4113         whether the related AtkState value is in the object's state set.
4114         (AccessibilityUIElement::isFocusable): Ditto.
4115         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4116         (AccessibilityUIElement::isFocused): New, dummy implementation.
4117         (AccessibilityUIElement::isFocusable): Ditto.
4118         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4119         (AccessibilityUIElement::isFocused): Ditto.
4120         (AccessibilityUIElement::isFocusable): Ditto.
4121
4122 2010-12-14  Eric Seidel  <eric@webkit.org>
4123
4124         Reviewed by Ojan Vafai.
4125
4126         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
4127         https://bugs.webkit.org/show_bug.cgi?id=50715
4128
4129         This patch makes webkit-patch print the following:
4130
4131         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
4132         Install a 64-bit git for better performance, see:
4133         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
4134
4135         I wrote this mostly because I have approximately 8 machines that I use
4136         and making sure each one is using a good Git install seemed folly.
4137         webkit-patch makes a lot of git calls, so using a fast git can shave
4138         several seconds in every invocation.  See the webkit-dev thread for more info.
4139
4140         This message will print twice during 'webkit-patch upload',
4141         once from webkit-patch and once from check-webkit-style.
4142
4143         Unfortunately there is no good way to test this due to how machine-dependent
4144         the code is.  I considered writing a test for the log message, but it seemed not worth it.
4145
4146         * Scripts/webkitpy/common/checkout/scm.py:
4147
4148 2010-12-13  Eric Seidel  <eric@webkit.org>
4149
4150         Reviewed by Adam Barth.
4151
4152         FlakyTestReporter doesn't understand bots running from multiple email addresses
4153         https://bugs.webkit.org/show_bug.cgi?id=50960
4154
4155         This explains at least one of the dupes of:
4156         https://bugs.webkit.org/show_bug.cgi?id=50863
4157         that we saw filed by the commit-queue this morning.
4158         I think the other one was explained by my previous fix to result counting code.
4159
4160         Since this is really hard to test with a unit test, instead I
4161         create a new (possibly useful in the future) command
4162         which given a layout test path will return you
4163         the one bug which our tools would assume it the flaky test bug.
4164         If some other script wants to use bug-for-test we'll
4165         need to extend it with some options like --create-if-missing or similar.
4166
4167         * Scripts/webkitpy/common/net/bugzilla/bug.py:
4168         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4169         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4170         * Scripts/webkitpy/tool/commands/__init__.py:
4171         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
4172
4173 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
4174
4175         Reviewed by James Robinson.
4176
4177         Add option to build-webkit to not build WebKit2
4178         https://bugs.webkit.org/show_bug.cgi?id=50988
4179
4180         Add support for a --no-webkit2 option to build-webkit. It seems to save
4181         ~1 minute from clean builds and ~10 seconds from no-op builds.
4182
4183         * Scripts/build-webkit:
4184
4185 2010-12-13  Lucas Forschler  <lforschler@apple.com>
4186
4187         Reviewed by Dave Kilzer.
4188
4189         Update iexploder from 1.3.2 to 1.7.2
4190         Move 1.3.2 into its own subdir
4191         Add 1.7.2 into its own subdir
4192         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
4193
4194         * Scripts/run-iexploder-tests:
4195         * Scripts/update-iexploder-cssproperties:
4196         * iExploder/CHANGELOG.txt: Removed.
4197         * iExploder/LICENSE.txt: Removed.
4198         * iExploder/README.txt: Removed.
4199         * iExploder/htdocs: Removed.
4200         * iExploder/iexploder-1.3.2: Added.
4201         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
4202         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
4203         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
4204         * iExploder/iexploder-1.3.2/htdocs: Added.
4205         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
4206         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
4207         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
4208         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
4209         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
4210         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
4211         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
4212         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
4213         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
4214         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
4215         * iExploder/iexploder-1.3.2/tools: Added.
4216         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
4217         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
4218         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
4219         * iExploder/iexploder-1.7.2: Added.
4220         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
4221         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
4222         * iExploder/iexploder-1.7.2/README.txt: Added.
4223         * iExploder/iexploder-1.7.2/output: Added.
4224         * iExploder/iexploder-1.7.2/src: Added.
4225         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
4226         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
4227         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
4228         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
4229         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
4230         * iExploder/iexploder-1.7.2/src/css-properties: Added.
4231         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
4232         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
4233         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
4234         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
4235         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
4236         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
4237         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
4238         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
4239         * iExploder/iexploder-1.7.2/src/css-values: Added.
4240         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
4241         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
4242         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
4243         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
4244         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
4245         * iExploder/iexploder-1.7.2/src/headers: Added.
4246         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
4247         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
4248         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
4249         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
4250         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
4251         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
4252         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
4253         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
4254         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
4255         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
4256         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
4257         * iExploder/iexploder-1.7.2/src/html-tags: Added.
4258         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
4259         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
4260         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
4261         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
4262         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
4263         * iExploder/iexploder-1.7.2/src/html-values: Added.
4264         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
4265         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
4266         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
4267         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
4268         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
4269         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
4270         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
4271         * iExploder/iexploder-1.7.2/src/index.html: Added.
4272         * iExploder/iexploder-1.7.2/src/media: Added.
4273         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
4274         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
4275         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
4276         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
4277         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
4278         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
4279         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
4280         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
4281         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
4282         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
4283         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
4284         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
4285         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
4286         * iExploder/iexploder-1.7.2/src/mime-types: Added.
4287         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
4288         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
4289         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
4290         * iExploder/iexploder-1.7.2/src/protocols: Added.
4291         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
4292         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
4293         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
4294         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
4295         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
4296         * iExploder/iexploder-1.7.2/src/version.rb: Added.
4297         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
4298         * iExploder/iexploder-1.7.2/testcases: Added.
4299         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
4300         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
4301         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
4302         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
4303         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
4304         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
4305         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
4306         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
4307         * iExploder/iexploder-1.7.2/tools: Added.
4308         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
4309         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
4310         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
4311         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
4312         * iExploder/tools: Removed.
4313
4314 2010-12-13  Sam Weinig  <sam@webkit.org>
4315
4316         Reviewed by Anders Carlsson.
4317
4318         Remove associated page concept from WKView constructor
4319         https://bugs.webkit.org/show_bug.cgi?id=50983
4320
4321         Step 1: Remove associate page constructors from WKView and make
4322         all views use the shared namespace for the context.
4323
4324         * TestWebKitAPI/PlatformWebView.h:
4325         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4326         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
4327         * WebKitTestRunner/PlatformWebView.h:
4328         * WebKitTestRunner/TestController.cpp:
4329         (WTR::createOtherPage):
4330         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4331         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4332         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4333
4334 2010-12-13  Sam Weinig  <sam@webkit.org>
4335
4336         Reviewed by Anders Carlsson.
4337
4338         Change the WebKit2 public API so there is no explicit WKPageNamespace object
4339         https://bugs.webkit.org/show_bug.cgi?id=50898
4340
4341         * MiniBrowser/mac/AppDelegate.h:
4342         * MiniBrowser/mac/AppDelegate.m:
4343         * MiniBrowser/mac/BrowserWindowController.h:
4344         * MiniBrowser/mac/BrowserWindowController.m:
4345         * MiniBrowser/win/BrowserView.cpp:
4346         Convert MiniBrowser to not use PageNamespaces.
4347
4348         * TestWebKitAPI/PlatformWebView.h:
4349         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
4350         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
4351         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
4352         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
4353         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
4354         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
4355         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
4356         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
4357         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
4358         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
4359         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
4360         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
4361         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
4362         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4363         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
4364         Convert TestWebKitAPI to not use PageNamespaces.
4365
4366         * WebKitTestRunner/PlatformWebView.h:
4367         * WebKitTestRunner/TestController.cpp:
4368         * WebKitTestRunner/TestController.h:
4369         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4370         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4371         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4372         Convert WebKitTestRunner to not use PageNamespaces.
4373
4374 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4375
4376         Reviewed by Eric Seidel.
4377
4378         webkit-patch rollout should be able to do multi-revision rollouts
4379         https://bugs.webkit.org/show_bug.cgi?id=33336
4380
4381         Make it possible to pass more than one revision to webkit-patch.
4382
4383         * Scripts/webkitpy/common/checkout/api.py:
4384         * Scripts/webkitpy/common/checkout/changelog.py:
4385         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4386         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
4387         * Scripts/webkitpy/tool/commands/download.py:
4388         * Scripts/webkitpy/tool/commands/download_unittest.py:
4389         * Scripts/webkitpy/tool/mocktool.py:
4390         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4391         * Scripts/webkitpy/tool/steps/revertrevision.py:
4392
4393 2010-12-13  Eric Seidel  <eric@webkit.org>
4394
4395         Unreviewed.
4396
4397         Teach webkit-patch how to search bugzilla
4398         https://bugs.webkit.org/show_bug.cgi?id=50500
4399
4400         webkit-patch bug-search fails when there is only one result.
4401         Turns out we needed a bit more logic in our result count parsing code.
4402
4403         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4404         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4405
4406 2010-12-13  Antti Koivisto  <antti@apple.com>
4407
4408         Reviewed by Alexey Proskuryakov.
4409
4410         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
4411         https://bugs.webkit.org/show_bug.cgi?id=50758
4412
4413         * DumpRenderTree/LayoutTestController.cpp:
4414         (setSerializeHTTPLoadsCallback):
4415         (LayoutTestController::staticFunctions):
4416         * DumpRenderTree/LayoutTestController.h:
4417         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4418         (LayoutTestController::setSerializeHTTPLoads):
4419         * DumpRenderTree/mac/DumpRenderTree.mm:
4420         (resetDefaultsToConsistentValues):
4421         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4422         (LayoutTestController::setSerializeHTTPLoads):
4423         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4424         (LayoutTestController::setSerializeHTTPLoads):
4425
4426 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
4427
4428         Reviewed by Ojan Vafai.
4429
4430         Remove "use-drt" option from test step command line, since the option was removed in r73748.
4431         https://bugs.webkit.org/show_bug.cgi?id=50936
4432
4433         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
4434
4435 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
4436
4437         Reviewed by Csaba Osztrogonác.
4438
4439         Add revlink to BuildBot status
4440         https://bugs.webkit.org/show_bug.cgi?id=50914
4441
4442         This adds a hyperlink to trac changeset on the revision numbers.
4443
4444         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4445
4446 2010-12-13  Andras Becsi  <abecsi@webkit.org>