3a011c7539dba1c560fd148ae8e1b521406ced74
[WebKit.git] / Tools / ChangeLog
1 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Mihai Parparita.
4
5         Update rebaseline-chromium-webkit-tests to use filesystem objects
6         instead of direct references to os.path, shutil, tempfile, etc.
7
8         This patch doesn't change anything, but will allow subsequent
9         patches to change the unit tests to no longer use the real
10         filesystem.
11
12         This patch adds a bunch more methods to the filesystem object as
13         well.
14
15         https://bugs.webkit.org/show_bug.cgi?id=52482
16
17         * Scripts/webkitpy/common/system/filesystem.py:
18         * Scripts/webkitpy/common/system/filesystem_mock.py:
19         * Scripts/webkitpy/tool/commands/queues.py:
20         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
21         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
22
23 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
24
25         Reviewed by Mihai Parparita.
26
27         new-run-webkit-tests shouldn't crash when you try to run a
28         directory containing only skipped files.
29
30         https://bugs.webkit.org/show_bug.cgi?id=52478
31         
32         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
33         * Scripts/webkitpy/layout_tests/port/test.py:
34         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
35
36 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
37
38         Reviewed by Gustavo Noronha Silva.
39
40         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
41         https://bugs.webkit.org/show_bug.cgi?id=40833
42
43         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
44         GTK+ event sender.
45         (dragWithFilesDragDataGetCallback): Added.
46         (dragWithFilesDragEndCallback): Added.
47         (beginDragWithFilesCallback): Added.
48
49 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
50
51         Reviewed by Adam Barth.
52
53         ews: Add additional watcher to efl ews
54         https://bugs.webkit.org/show_bug.cgi?id=52613
55
56         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
57
58         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
59
60 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
61
62         Reviewed by Alexey Proskuryakov.
63
64         Fix some headers with missing or misspelled #ifndef guards
65         https://bugs.webkit.org/show_bug.cgi?id=52545
66
67         * DumpRenderTree/chromium/TestEventPrinter.h:
68         * DumpRenderTree/chromium/WebPreferences.h:
69
70 2011-01-17  Jessie Berlin  <jberlin@apple.com>
71
72         Reviewed by Anders Carlsson.
73
74         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
75         navigating back to an unreachable URL
76         https://bugs.webkit.org/show_bug.cgi?id=52388
77
78         Add a third parameter (unreachableURL) to queueLoadHTMLString.
79
80         * DumpRenderTree/LayoutTestController.cpp:
81         (queueLoadHTMLStringCallback):
82         (LayoutTestController::queueLoadHTMLString):
83         (LayoutTestController::queueLoadAlternateHTMLString):
84         * DumpRenderTree/LayoutTestController.h:
85
86         * DumpRenderTree/WorkQueueItem.h:
87         (LoadHTMLStringItem::LoadHTMLStringItem):
88
89         * DumpRenderTree/chromium/LayoutTestController.cpp:
90         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
91         (WorkItemLoadHTMLString::run):
92         (LayoutTestController::queueLoadHTMLString):
93
94         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
95         (LoadHTMLStringItem::invoke):
96         * DumpRenderTree/mac/WorkQueueItemMac.mm:
97         (LoadHTMLStringItem::invoke):
98         * DumpRenderTree/win/WorkQueueItemWin.cpp:
99         (LoadHTMLStringItem::invoke):
100
101 2011-01-17  Dan Bernstein  <mitz@apple.com>
102
103         Rubber-stamped by Mark Rowe.
104
105         Update xcodeproj svn:ignore to include xcuserdata.
106
107         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
108         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
109         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
110         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
111         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
112
113 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
114
115         Unreviewed fix after r75908.
116
117         Move WebKit into Source
118         https://bugs.webkit.org/show_bug.cgi?id=52530
119
120         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
121
122 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
123
124         Unreviewed.
125
126         Remove accidentally committed debug printing after r75908.
127
128         * Scripts/webkitdirs.pm:
129
130 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
131
132         Unreviewed.
133
134         Add myself to committers list
135         https://bugs.webkit.org/show_bug.cgi?id=52566
136
137         * Scripts/webkitpy/common/config/committers.py:
138
139 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
140
141         Reviewed by Jeremy Orlow.
142
143         GeolocationController should call stopUpdating on destruction
144         https://bugs.webkit.org/show_bug.cgi?id=52216
145
146         fast/dom/Geolocation/window-close-crash.html requires that a
147         Geolocation watch be started in a secondary window. Consequently,
148         we need to allow geolocation permission and provide a mock
149         geolocation position for the secondary window's
150         GeolocationClientMock.
151
152         * DumpRenderTree/chromium/LayoutTestController.cpp:
153         (LayoutTestController::setGeolocationPermission):
154         (LayoutTestController::setMockGeolocationPosition):
155         (LayoutTestController::setMockGeolocationError):
156         * DumpRenderTree/chromium/TestShell.h:
157         (TestShell::windowList):
158
159 2011-01-16  Adam Barth  <abarth@webkit.org>
160
161         Update more include paths to reflect WebKit move.
162
163         * DumpRenderTree/chromium/EventSender.cpp:
164         (EventSender::keyDown):
165         (EventSender::needsShiftModifier):
166         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
167         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
168
169 2011-01-16  Kent Tamura  <tkent@chromium.org>
170
171         Unreviewed, Chromium build fix.
172
173         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
174
175 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
176
177         Build fix for GTK+ after source directory movement.
178
179         * GNUmakefile.am: Correct include paths.
180
181 2011-01-16  Adam Barth  <abarth@webkit.org>
182
183         Teach svn-apply about WebKit move.
184
185         * Scripts/VCSUtils.pm:
186
187 2011-01-16  Adam Barth  <abarth@webkit.org>
188
189         Rubber-stamped by Eric Seidel.
190
191         Move WebKit into Source
192         https://bugs.webkit.org/show_bug.cgi?id=52530
193
194         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
195         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
196         * DumpRenderTree/qt/DumpRenderTreeQt.h:
197         * DumpRenderTree/qt/GCControllerQt.cpp:
198         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
199         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
200         * DumpRenderTree/qt/TextInputControllerQt.cpp:
201         * DumpRenderTree/wscript:
202         * QtTestBrowser/launcherwindow.h:
203         * Scripts/build-webkit:
204         * Scripts/webkitdirs.pm:
205
206 2011-01-15  Adam Barth  <abarth@webkit.org>
207
208         Teach svn-apply about WebKit2 move.
209
210         * Scripts/VCSUtils.pm:
211
212 2011-01-15  Adam Barth  <abarth@webkit.org>
213
214         Rubber-stamped by Eric Seidel.
215
216         Move WebKit2 into Source
217         https://bugs.webkit.org/show_bug.cgi?id=52438
218
219         * MiniBrowser/qt/MiniBrowser.pro:
220         * Scripts/build-webkit:
221         * Scripts/do-file-rename:
222         * Scripts/do-webcore-rename:
223         * Scripts/test-webkitpy:
224         * Scripts/webkitdirs.pm:
225         * Scripts/webkitpy/style/checker.py:
226         * WebKitTestRunner/DerivedSources.pro:
227         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
228         * WebKitTestRunner/qt/WebKitTestRunner.pro:
229
230 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
231
232         Reviewed by David Levin.
233
234         [chromium] remove obsolete createView method
235         https://bugs.webkit.org/show_bug.cgi?id=52437
236
237         * DumpRenderTree/chromium/WebViewHost.cpp:
238         (WebViewHost::createView):
239         * DumpRenderTree/chromium/WebViewHost.h:
240
241 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
242
243         Reviewed by Geoff Garen.
244
245         ShouldLoadResourceForFrame should use strings, not URLs.
246         https://bugs.webkit.org/show_bug.cgi?id=52476
247
248         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
249         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
250         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
251
252 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
253
254         Reviewed by David Levin.
255
256         Add Tony Gentilcore as a reviewer
257         https://bugs.webkit.org/show_bug.cgi?id=52480
258
259         * Scripts/webkitpy/common/config/committers.py:
260
261 2011-01-14  David Levin  <levin@chromium.org>
262
263         Reviewed by Eric Seidel.
264
265         check-webkit-style: _FunctionState should keep track of where the function name starts.
266         https://bugs.webkit.org/show_bug.cgi?id=52454
267
268         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
269         _FunctionState and logic for setting it correctly.
270         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
271
272 2011-01-14  Vincent Scheib  <scheib@chromium.org>
273
274         Reviewed by David Levin.
275
276         Add support to DumpRenderTree to use the GPU rather than software renderer
277         https://bugs.webkit.org/show_bug.cgi?id=52333
278
279         * DumpRenderTree/chromium/DumpRenderTree.cpp:
280         (main):
281         * Scripts/webkitpy/layout_tests/port/chromium.py:
282         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
283
284 2011-01-14  Tony Chang  <tony@chromium.org>
285
286         Reviewed by Kent Tamura.
287
288         [chromium] update fonts.conf to fix 6 linux tests in drt
289         https://bugs.webkit.org/show_bug.cgi?id=52411
290
291         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
292             chromium's src/webkit/tools/test_shell/resources/fonts.conf
293
294 2011-01-14  Eric Seidel  <eric@webkit.org>
295
296         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
297
298         Reviewed by Adam Barth.
299
300         Fix when running Tools/Scripts/check-webkit-style without arguments.
301         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
302
303         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
304         * Scripts/webkitpy/common/checkout/scm_unittest.py:
305
306 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
307
308         Reviewed by David Levin.
309
310         Store the tempdir object in a variable so it doesn't get deleted too early.
311         https://bugs.webkit.org/show_bug.cgi?id=51875
312
313         * Scripts/update-webkit-auxiliary-libs:
314         * Scripts/update-webkit-support-libs:
315
316 2011-01-14  Eric Seidel  <eric@webkit.org>
317
318         Unreviewed.  Make it work in python 2.5.
319
320         webkit-patch suggest-reviewers dies when ChangeLogs are missing
321         https://bugs.webkit.org/show_bug.cgi?id=49158
322
323         * Scripts/webkitpy/common/checkout/api_unittest.py:
324
325 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
326
327         Unreviewed, rolling out r75774.
328         http://trac.webkit.org/changeset/75774
329         https://bugs.webkit.org/show_bug.cgi?id=52431
330
331         gtk builds were broken (Requested by loislo2 on #webkit).
332
333         * Scripts/webkitpy/common/checkout/scm.py:
334
335 2011-01-14  David Levin  <levin@chromium.org>
336
337         Reviewed by Shinichiro Hamaji.
338
339         check-webkit-style: _FunctionState should detect pure functions.
340         https://bugs.webkit.org/show_bug.cgi?id=52428
341
342         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
343         is a pure virtual function.
344         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
345         virtual functions are correctly detected.
346
347 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
348
349         Reviewed by Yury Semikhatsky.
350
351         Just small fix for problem with check-webkit-style.
352         It just didn't work for this patch.
353         Old code can't concatenate a list of strings with None.
354
355         * Scripts/webkitpy/common/checkout/scm.py:
356
357 2011-01-13  David Levin  <levin@chromium.org>
358
359         Reviewed by Shinichiro Hamaji.
360
361         check-webkit-style: _FunctionState should use Position to know where items are.
362         https://bugs.webkit.org/show_bug.cgi?id=52424
363
364         * Scripts/webkitpy/style/checkers/cpp.py:
365         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
366         (detect_functions): Changed to pass Position's to _FunctionState.begin and
367         did some minor clean-up.
368         (*): Other changes are simply about converting to use the Position's in_FunctionState
369         instead of line numbers.
370         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
371         to verify the positions stored in _FunctionState.
372
373 2011-01-13  Eric Seidel  <eric@webkit.org>
374
375         Reviewed by David Levin.
376
377         webkit-patch suggest-reviewers dies when ChangeLogs are missing
378         https://bugs.webkit.org/show_bug.cgi?id=49158
379
380         This is not the most elegant, but it is a very safe fix to this bug.
381         One advantage of catching ScriptError like this instead of adding a
382         new added_or_modified_files or fixing all changed_files callers
383         to use a more specific change_files variant, is that we catch
384         all kinds of ScriptErrors which might cause our (non-essential)
385         suggest-reviewers code to fail out.  This should make passing
386         --suggest-reviewers to webkit-patch upload much more robust
387         and may even make it possible for us to make it default.
388
389         The root of the problem here is that SCM.changed_files includes
390         deleted ChangeLog paths (from moves, etc) which then when we ask
391         SVN/Git for the contents of the file at that revision, the command
392         errors out and Executive.run_command raises a ScriptError.
393
394         In the future we might fix this differently by making all current
395         callers of chagned_files use a more specific method for requesting
396         what types of changes they're interested in (adds, modifies, deletes, etc.)
397
398         * Scripts/webkitpy/common/checkout/api.py:
399         * Scripts/webkitpy/common/checkout/api_unittest.py:
400
401 2011-01-13  Dan Bernstein  <mitz@apple.com>
402
403         Reviewed by Alexey Proskuryakov.
404
405         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
406         https://bugs.webkit.org/show_bug.cgi?id=52419
407
408         Allow to further control the behavior of the willSendRequest delegate callback by making it
409         set a different URL in the new request.
410
411         * DumpRenderTree/LayoutTestController.cpp:
412         (addURLToRedirectCallback): Added.
413         (LayoutTestController::staticFunctions): Added addURLToRedirect.
414         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
415         (LayoutTestController::redirectionDestinationForURL): Added this getter.
416         * DumpRenderTree/LayoutTestController.h:
417         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
418         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
419         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
420         change the URL in the new request to the redirect destination.
421
422 2011-01-13  Eric Seidel  <eric@webkit.org>
423
424         Reviewed by Mihai Parparita.
425
426         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
427         https://bugs.webkit.org/show_bug.cgi?id=52416
428
429         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
430         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
431
432         I also added FIXMEs about the changed_files returning deleted files problem
433         which is causing the other most common exception for suggest-reviewers
434         (and is probably breaking sheriff-bots blame detection).
435
436         * Scripts/webkitpy/common/checkout/api.py:
437         * Scripts/webkitpy/common/checkout/api_unittest.py:
438         * Scripts/webkitpy/common/checkout/scm.py:
439
440 2011-01-13  Eric Seidel  <eric@webkit.org>
441
442         Reviewed by Adam Barth.
443
444         results archives from commit-queue are too large to upload
445         https://bugs.webkit.org/show_bug.cgi?id=52405
446
447         * Scripts/webkitpy/common/system/filesystem.py:
448         * Scripts/webkitpy/common/system/filesystem_mock.py:
449         * Scripts/webkitpy/tool/commands/queues.py:
450
451 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
452
453         Reviewed by Martin Robinson.
454
455         [gtk] Zero-sized font does not yet work
456         https://bugs.webkit.org/show_bug.cgi?id=49793
457
458         Set minimum-font-size to 0 for the DRT.
459
460         * DumpRenderTree/gtk/DumpRenderTree.cpp:
461         (resetDefaultsToConsistentValues):
462
463 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
464
465         Reviewed by Darin Adler.
466
467         Make old-run-webkit-tests more robust on buildbots
468         https://bugs.webkit.org/show_bug.cgi?id=52364
469
470         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
471
472 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
473
474         Reviewed by Darin Adler.
475
476         Make old-run-webkit-tests more robust on buildbots
477         https://bugs.webkit.org/show_bug.cgi?id=52364
478
479         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
480
481 2011-01-13  Tony Chang  <tony@chromium.org>
482
483         Reviewed by Kent Tamura.
484
485         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
486         https://bugs.webkit.org/show_bug.cgi?id=52332
487
488         Forked Info.plist is not longer needed.
489
490         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
491
492 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
493
494         Reviewed by Timothy Hatcher.
495
496         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
497         to be passed directly to WebInspector.UIString
498
499         https://bugs.webkit.org/show_bug.cgi?id=52365
500
501         * Scripts/check-inspector-strings:
502
503 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
504
505         Unreviewed, rolling out r74881.
506         http://trac.webkit.org/changeset/74881
507         https://bugs.webkit.org/show_bug.cgi?id=52357
508
509         The EFL builder has been red for days (Requested by abarth on
510         #webkit).
511
512         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
513         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
514
515 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
516
517         Reviewed by David Levin.
518
519         Add beforeunload support to WebKitTestRunner
520         https://bugs.webkit.org/show_bug.cgi?id=52353
521         
522         This makes a number of currently failing tests pass.
523
524         * WebKitTestRunner/TestController.cpp:
525         (WTR::runBeforeUnloadConfirmPanel):
526         (WTR::createOtherPage):
527         (WTR::TestController::initialize):
528
529 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
530
531         Reviewed by Sam Weinig.
532
533         Detect, identify and recover from WebProcess crashes in run-webkit-tests
534         https://bugs.webkit.org/show_bug.cgi?id=52330
535
536         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
537         a web process crash.
538         * WebKitTestRunner/TestController.cpp:
539         (WTR::TestController::initialize): Set up a processDidCrash
540         callback.
541         (WTR::TestController::processDidCrash): Report that the Web process
542         crashed.
543         * WebKitTestRunner/TestController.h:
544
545 2011-01-12  David Levin  <levin@chromium.org>
546
547         Reviewed by Shinichiro Hamaji.
548
549         check-webkit-style -- close_expression function doesn't work correctly.
550         https://bugs.webkit.org/show_bug.cgi?id=52272
551
552         * Scripts/webkitpy/style/checkers/cpp.py:
553         (Position.__str__): Added a way to convert it to a string which is useful in tests.
554         (Position.__cmp__): Added a way to compare Position which is useful in tests and
555         generally useful (for upcoming code changes).
556         (close_expression): Changed to use Position for input and output.
557         Also, fixed many bugs such as only working correctly for parenthesis,
558         not working correctly if given an offset in a line and not finding
559         the real closing element if there were multiple closing elements in
560         the same line.
561         (detect_functions): Adjusted due to the change in arguments for
562         close_expression.
563         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
564         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
565         two positions are the same.
566         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
567         (CppStyleTest.test_close_expression): Added tests to catch the issues
568         that were fixed.
569
570 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
571
572         Unreviewed, rolling out r75576.
573         http://trac.webkit.org/changeset/75576
574         https://bugs.webkit.org/show_bug.cgi?id=52304
575
576         broke rebaseline-chromium-webkit-test (Requested by thakis on
577         #webkit).
578
579         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
580         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
581         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
582         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
583         * Scripts/webkitpy/layout_tests/port/base.py:
584         * Scripts/webkitpy/layout_tests/port/chromium.py:
585         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
586         * Scripts/webkitpy/layout_tests/port/test.py:
587         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
588         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
589         * Scripts/webkitpy/style/checkers/test_expectations.py:
590         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
591
592 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
593
594         Reviewed by Darin Adler.
595
596         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
597         https://bugs.webkit.org/show_bug.cgi?id=52307
598
599         * Scripts/old-run-webkit-tests:
600
601 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
602
603         Reviewed by Martin Robinson.
604
605         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
606         https://bugs.webkit.org/show_bug.cgi?id=50867
607
608         Fixed library extention for Mac in webkitdirs.pm and type conflict in
609         TestNetscapePlugin.cpp 
610
611         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
612         * Scripts/webkitdirs.pm:
613
614 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
615
616         Reviewed by Pavel Feldman.
617
618         Add check-inspector-strings script.
619
620         https://bugs.webkit.org/show_bug.cgi?id=52295
621
622         * Scripts/check-inspector-strings: Added.
623
624 2011-01-12  Adam Roben  <aroben@apple.com>
625
626         Advertise the .testnetscape file extension on Windows
627
628         Fixes <http://webkit.org/b/52298>
629         plugins/no-mime-with-valid-extension.html fails on Windows
630
631         Reviewed by Dan Bernstein.
632
633         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
634         FileExtents field to map the .testnetscape file extension to the
635         application/x-webkit-test-netscape MIME type, just as we do on Mac.
636
637 2011-01-12  Adam Barth  <abarth@webkit.org>
638
639         Reviewed by Eric Seidel.
640
641         Make webkit-patch support subdirectories for SVN checkouts
642         https://bugs.webkit.org/show_bug.cgi?id=52261
643
644         os.relpath does not exist on Python 2.5, so we need to call our version
645         of the API.
646
647         * Scripts/webkitpy/common/checkout/scm.py:
648
649 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
650
651         Reviewed by Eric Seidel.
652
653         Close additional pages opened during a test once the test completes.
654         https://bugs.webkit.org/show_bug.cgi?id=52276
655
656         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
657         (WTR::InjectedBundle::done):
658
659 2011-01-11  David Levin  <levin@chromium.org>
660
661         Reviewed by Eric Seidel.
662
663         Errors should be separated from the command line in bot messages.
664         https://bugs.webkit.org/show_bug.cgi?id=52275
665
666         * Scripts/webkitpy/common/system/executive.py:
667         (ScriptError.message_with_output): Added a newline to separate the command
668         line from the errors.
669         * Scripts/webkitpy/common/system/executive_unittest.py:
670         (ScriptErrorTest.test_message_with_output): Added tests for the various code
671         paths in message_with_output.
672
673 2011-01-11  Eric Seidel  <eric@webkit.org>
674
675         Unreviewed.
676
677         commit-queue should know how to upload archived results (for test flakes or general failures)
678         https://bugs.webkit.org/show_bug.cgi?id=52048
679
680         The zips are mostly empty due to forgetting -r.
681         Expected diffs were not being pulled from the archive due
682         to the archive having longer paths than I realized.
683
684         * Scripts/webkitpy/common/system/workspace.py:
685         * Scripts/webkitpy/common/system/workspace_unittest.py:
686         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
687         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
688
689 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
690
691         Reviewed by Ojan Vafai.
692
693         The current modifier parsing code in test_expectations is
694         fragile and hard-coded, so it's not easy to understand the logic
695         or easily add new types of modifiers (like GPU vs. CPU testing
696         for graphics tests, or 32-bit vs. 64-bit differences).
697
698         This is the first of two patches that will add in more generic
699         support and then eliminate the GPU-specific test expectations
700         files for Chromium.
701
702         This patch adds two standalone objects for handling modifiers. The
703         rules for interpreting modifiers, precedence, and conflicts are
704         given in the docstring to the ModifierMatcher class, which
705         returns ModifierMatchResult objects.
706         
707         This patch also adds routines to the Port interface and a
708         default set of values in the base object, in order to obtain the
709         values needed on a given test run. These values are then passed
710         to the expectation parser. This also allows us to clean up the
711         logic used to lint all of the different configurations in a
712         single test_expectations.txt file.
713
714         The next patch will merge in the separate GPU expectations file.
715
716         https://bugs.webkit.org/show_bug.cgi?id=51222
717
718         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
719         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
720         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
721         * Scripts/webkitpy/layout_tests/port/base.py:
722         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
723         * Scripts/webkitpy/layout_tests/port/chromium.py:
724         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
725         * Scripts/webkitpy/layout_tests/port/test.py:
726         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
727         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
728
729 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
730
731         Reviewed by Adam Barth.
732
733         Make webkit-patch support subdirectories for SVN checkouts
734         https://bugs.webkit.org/show_bug.cgi?id=52261
735
736         * Scripts/webkitpy/common/checkout/scm.py:
737         * Scripts/webkitpy/style_references.py:
738         * Scripts/webkitpy/tool/main.py:
739         * Scripts/webkitpy/tool/steps/preparechangelog.py:
740
741 2011-01-11  Eric Seidel  <eric@webkit.org>
742
743         Unreviewed.
744
745         commit-queue should know how to upload archived results (for test flakes or general failures)
746         https://bugs.webkit.org/show_bug.cgi?id=52048
747
748         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
749         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
750
751         * Scripts/webkitpy/common/system/workspace.py:
752         * Scripts/webkitpy/common/system/workspace_unittest.py:
753         * Scripts/webkitpy/tool/commands/queues.py:
754
755 2011-01-11  Sam Weinig  <sam@webkit.org>
756
757         Roll r75474 back in.
758
759 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
760
761         Reviewed by Kenneth Rohde Christiansen.
762
763         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
764         https://bugs.webkit.org/show_bug.cgi?id=51204
765
766         * QtTestBrowser/webpage.h:
767         (QtNAMThread::QtNAMThread):
768         (QtNAMThread::networkAccessManager):
769         (QtNAMThread::run):
770
771 2011-01-11  Peter Varga  <pvarga@webkit.org>
772
773         Unreviewed.
774
775         Add myself to committers' list.
776
777         * Scripts/webkitpy/common/config/committers.py:
778
779 2011-01-11  Eric Seidel  <eric@webkit.org>
780
781         Reviewed by Adam Barth.
782
783         commit-queue should know how to upload archived results (for test flakes or general failures)
784         https://bugs.webkit.org/show_bug.cgi?id=52048
785
786         Now the queue will always upload results.  Either the entire zip, or just
787         the diffs.txt in the case of text failures.
788
789         This should make understanding flakes much easier, and paves the way
790         for having the EWS run layout tests (and upload failures).
791
792         In order to upload .zip files I had to teach bugzilla.py to autodetect
793         mime types from the filename.  Since mimetypes.py doesn't include a mapping
794         for .patch files, I have it add one before calling guess_type.
795
796         We may find that always uploading the whole zip instead of just the -diffs.txt
797         file is preferable, but for now I'm keeping the old behavior because it makes
798         quickly understanding text failures easy.
799
800         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
801         * Scripts/webkitpy/common/system/workspace.py: Added.
802         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
803         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
804         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
805         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
806         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
807         * Scripts/webkitpy/tool/commands/queues.py:
808         * Scripts/webkitpy/tool/commands/queues_unittest.py:
809
810 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
811
812         Unreviewed, rolling out r75464.
813         http://trac.webkit.org/changeset/75464
814         https://bugs.webkit.org/show_bug.cgi?id=52193
815
816         Followup rollout for 75474 (Requested by Ossy on #webkit).
817
818         * MiniBrowser/mac/BrowserWindowController.m:
819         (-[BrowserWindowController awakeFromNib]):
820         * MiniBrowser/win/BrowserView.cpp:
821         (BrowserView::create):
822         * WebKitTestRunner/TestController.cpp:
823         (WTR::createOtherPage):
824         (WTR::TestController::initialize):
825
826 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
827
828         Reviewed by Csaba Osztrogonác.
829
830         [Qt] Baseline qt_minimal configuration
831         https://bugs.webkit.org/show_bug.cgi?id=51313
832
833         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
834         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
835         QT_NO_UNDOSTACK guard.
836
837         * QtTestBrowser/launcherwindow.cpp:
838         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
839         guards.
840         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
841         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
842         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
843         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
844
845         * QtTestBrowser/launcherwindow.h:
846         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
847         * QtTestBrowser/locationedit.h: Ditto.
848
849         * QtTestBrowser/mainwindow.cpp:
850         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
851         QT_NO_UNDOSTACK guards.
852         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
853         (MainWindow::changeLocation): Ditto.
854         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
855         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
856
857         * QtTestBrowser/webpage.cpp:
858         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
859         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
860
861         * QtTestBrowser/webview.cpp:
862         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
863         (WebViewGraphicsBased::animatedYFlip): Ditto.
864
865 2011-01-10  Sam Weinig  <sam@webkit.org>
866
867         Fix build.
868
869         * MiniBrowser/mac/BrowserWindowController.m:
870         (-[BrowserWindowController awakeFromNib]):
871         * MiniBrowser/win/BrowserView.cpp:
872         (BrowserView::create):
873         * WebKitTestRunner/TestController.cpp:
874         (WTR::createOtherPage):
875         (WTR::TestController::initialize):
876
877 2011-01-10  Eric Seidel  <eric@webkit.org>
878
879         Reviewed by Ojan Vafai.
880
881         style-queue messages are way too long for big patches
882         https://bugs.webkit.org/show_bug.cgi?id=52161
883
884         We definitely could build much fancier list-to-string-with-limit functions
885         but this should be sufficient for our needs at the moment.
886
887         * Scripts/webkitpy/common/system/executive.py:
888         * Scripts/webkitpy/common/system/executive_unittest.py:
889
890 2011-01-10  Tony Chang  <tony@chromium.org>
891
892         Unreviewed, rolling out r75398.
893         http://trac.webkit.org/changeset/75398
894         https://bugs.webkit.org/show_bug.cgi?id=52008
895
896         Some layout tests are crashing on Chromium Win.
897
898         * DumpRenderTree/chromium/WebViewHost.cpp:
899         (WebViewHost::updatePaintRect):
900         * DumpRenderTree/chromium/WebViewHost.h:
901
902 2011-01-10  Adam Roben  <aroben@apple.com>
903
904         Roll out r75392
905
906         It isn't needed now that r75289 has been rolled out.
907
908         * Scripts/run-javascriptcore-tests:
909
910 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
911
912         Reviewed by Anders Carlsson.
913
914         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
915         https://bugs.webkit.org/show_bug.cgi?id=52160
916
917         * WebKitTestRunner/mac/TestControllerMac.mm:
918         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
919         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
920         anyway.
921
922 2011-01-10  Tony Chang  <tony@chromium.org>
923
924         Reviewed by Mihai Parparita.
925
926         [chromium] fix for animated gif layout tests
927         https://bugs.webkit.org/show_bug.cgi?id=52008
928
929         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
930             to trigger gif animations.
931         (WebViewHostPaintTask::WebViewHostPaintTask):
932         (WebViewHostPaintTask::runIfValid):
933         (WebViewHost::updatePaintRect):
934         * DumpRenderTree/chromium/WebViewHost.h:
935         (WebViewHost::taskList):
936
937 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
938
939         Reviewed by Xan Lopez.
940
941         [GTK] Fix gtk2 compilation for master
942         https://bugs.webkit.org/show_bug.cgi?id=51885
943
944         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
945         (createBitmapContextFromWebView): Replaced the old
946         gdk_drawable_get_size with gdk_pixmap_get_size.
947
948 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
949
950         Reviewed by Laszlo Gombos.
951
952         [WINCE] Reenable NPAPI after r75203
953         https://bugs.webkit.org/show_bug.cgi?id=52109
954
955         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
956         it with !isEfl(), because EFL port does not support NPAPI (yet).
957
958         * Scripts/build-webkit:
959
960 2011-01-10  Adam Roben  <aroben@apple.com>
961
962         Skip some asserting JS tests
963
964         See <http://webkit.org/b/52156>.
965
966         * Scripts/run-javascriptcore-tests:
967
968 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
969
970         Reviewed by Xan Lopez.
971
972         [GTK] build-webkit disable Blob support via arguments passed to automake
973         https://bugs.webkit.org/show_bug.cgi?id=52097
974
975         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
976         build-webkit.
977
978 2011-01-10  Adam Roben  <aroben@apple.com>
979
980         Use the same name and description for TestNetscapePlugin on Windows and
981         Mac
982
983         Fixes <http://webkit.org/b/52151>
984         fast/frames/iframe-reparenting-plugins.html fails on Windows
985
986         Reviewed by Steve Falkenburg.
987
988         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
989         the name and description from Mac's Info.plist.
990
991 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
992
993         Reviewed by Laszlo Gombos.
994
995         [Qt][WK2] Guard gcc-specific syntax
996
997         Non-gcc based compliers choke on the "-include"
998         syntax for preinclude, place guard around it.
999
1000         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1001         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1002
1003 2011-01-10  Andreas Kling  <kling@webkit.org>
1004
1005         Reviewed by Simon Hausmann.
1006
1007         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1008         https://bugs.webkit.org/show_bug.cgi?id=52111
1009
1010         When getting a createNewPage() callback from QWKPage, create the
1011         new page with the same QWKContext as the page that is passed to
1012         the callback.
1013
1014         * MiniBrowser/qt/BrowserView.h:
1015         * MiniBrowser/qt/BrowserWindow.cpp:
1016         (newPageFunction):
1017         (BrowserWindow::BrowserWindow):
1018         * MiniBrowser/qt/BrowserWindow.h:
1019
1020 2011-01-10  Andreas Kling  <kling@webkit.org>
1021
1022         Reviewed by Kenneth Rohde Christiansen.
1023
1024         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1025
1026         BrowserView set its own useless createNewPage() callback on QWKPage.
1027         This was immediately overridden by BrowserWindow anyway, so remove
1028         the BrowserView one.
1029
1030         * MiniBrowser/qt/BrowserView.cpp:
1031         (BrowserView::BrowserView):
1032
1033 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1034
1035         Reviewed by Jeremy Orlow.
1036
1037         [Chromium] Remove non-client-based Geolocation code
1038         https://bugs.webkit.org/show_bug.cgi?id=50921
1039
1040         * DumpRenderTree/chromium/LayoutTestController.cpp:
1041         (LayoutTestController::setGeolocationPermission):
1042         (LayoutTestController::setMockGeolocationPosition):
1043         (LayoutTestController::setMockGeolocationError):
1044         * DumpRenderTree/chromium/WebViewHost.cpp:
1045         (WebViewHost::geolocationClientMock):
1046         (WebViewHost::reset):
1047         * DumpRenderTree/chromium/WebViewHost.h:
1048
1049 2011-01-10  Eric Seidel  <eric@webkit.org>
1050
1051         Reviewed by Adam Barth.
1052
1053         Commit bot tried to land r? cq+ patch
1054         https://bugs.webkit.org/show_bug.cgi?id=36638
1055
1056         It should now be possible to post a patch with r? and cq+ and the
1057         commit-queue will correctly wait for the r+ before attempting to land the patch.
1058         (This was a feature requested by several users.)
1059
1060         One caveat: We don't actually reject r-, cq+ patches from the queue
1061         (we just ignore them), but I think that's OK for now.
1062
1063         I also noticed that setting r- once a commit-queue node had grabbed
1064         a patch would not properly cancel the landing.  That's fixed and
1065         tested in this patch.
1066
1067         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1068         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1069         * Scripts/webkitpy/tool/bot/feeders.py:
1070         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1071
1072 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1073
1074         Reviewed by Kenneth Rohde Christiansen.
1075
1076         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1077         https://bugs.webkit.org/show_bug.cgi?id=51934
1078
1079         When accessing the network from the destructor of QWebPage, the network access manager
1080         was already deleted because the object WebPage was already destructed.
1081
1082         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1083         The object is now destructed in the destructor of QObject.
1084
1085         * QtTestBrowser/webpage.cpp:
1086         (WebPage::WebPage):
1087         (WebPage::setQnamThreaded):
1088         * QtTestBrowser/webpage.h:
1089         (QtNAMThread::QtNAMThread):
1090
1091 2011-01-08  Eric Seidel  <eric@webkit.org>
1092
1093         Reviewed by Ojan Vafai.
1094
1095         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1096         https://bugs.webkit.org/show_bug.cgi?id=52067
1097
1098         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1099         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1100
1101         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1102
1103 2011-01-08  Eric Seidel  <eric@webkit.org>
1104
1105         Reviewed by Mihai Parparita.
1106
1107         commit-queue hangs when the ChangeLog diff is bad
1108         https://bugs.webkit.org/show_bug.cgi?id=52072
1109
1110         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1111         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1112
1113 2011-01-08  Adam Barth  <abarth@webkit.org>
1114
1115         Teach svn-apply how to re-write WebCore to Source/WebCore.
1116
1117         * Scripts/VCSUtils.pm:
1118
1119 2011-01-07  Adam Barth  <abarth@webkit.org>
1120
1121         Rubber-stamped by Eric Seidel.
1122
1123         Move WebCore to Source
1124         https://bugs.webkit.org/show_bug.cgi?id=52050
1125
1126         Update the tools to understand WebCore's new location.
1127
1128         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1129         * DumpRenderTree/wscript:
1130         * GNUmakefile.am:
1131         * Scripts/build-webkit:
1132         * Scripts/do-file-rename:
1133         * Scripts/do-webcore-rename:
1134         * Scripts/generate-qt-inspector-resource:
1135         * Scripts/prepare-ChangeLog:
1136         * Scripts/run-bindings-tests:
1137         * Scripts/update-iexploder-cssproperties:
1138         * Scripts/update-sources-list.py:
1139         * Scripts/update-webkit-localizable-strings:
1140         * Scripts/webkitdirs.pm:
1141         * Scripts/webkitpy/common/config/build.py:
1142         * Scripts/webkitpy/common/config/build_unittest.py:
1143         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1144         * Scripts/webkitpy/style/checker.py:
1145         * Scripts/webkitpy/style/checker_unittest.py:
1146         * WebKitTestRunner/DerivedSources.pro:
1147         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1148         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1149         * wx/browser/wscript:
1150         * wx/build/settings.py:
1151
1152 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1153
1154         Reviewed by Sam Weinig.
1155
1156         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1157         https://bugs.webkit.org/show_bug.cgi?id=52086
1158
1159         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1160         (WTR::InjectedBundle::didReceiveMessage):
1161         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1162         (WTR::LayoutTestController::notifyDone):
1163         * WebKitTestRunner/TestController.cpp:
1164         (WTR::TestController::resetStateToConsistentValues):
1165         (WTR::TestController::run):
1166
1167 2011-01-07  James Robinson  <jamesr@chromium.org>
1168
1169         Revert "Implement mozilla's animationTime property"
1170         https://bugs.webkit.org/show_bug.cgi?id=51952
1171
1172         This approach isn't quite right.
1173
1174         * DumpRenderTree/chromium/WebViewHost.cpp:
1175         (WebViewHost::paintInvalidatedRegion):
1176
1177 2011-01-07  Adam Roben  <aroben@apple.com>
1178
1179         Build master fix
1180
1181         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1182         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1183
1184 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1185
1186         Reviewed by Csaba Osztrogonác.
1187
1188         run-qtwebkit-tests should be able to kill a testsuite.
1189
1190         Add new option in the script that can setup a timeout for a test.
1191         If the test execution takes more then specified time then the test
1192         would be terminated.
1193
1194         [Qt] run-qtwebkit-tests needs timeout
1195         https://bugs.webkit.org/show_bug.cgi?id=51894
1196
1197         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1198         * Scripts/run-qtwebkit-tests:
1199
1200 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1201
1202         Unreviewed fix after r75233.
1203
1204         Based on idea from Eric Seidel.
1205
1206         Add remote zip file handling to webkitpy.
1207         https://bugs.webkit.org/show_bug.cgi?id=50901
1208
1209         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1210
1211 2011-01-07  Shane Stephens  <shanestephens@google.com>
1212
1213         Reviewed by Eric Seidel.
1214
1215         svn-apply: should support git binary delta diffs
1216         https://bugs.webkit.org/show_bug.cgi?id=38864
1217
1218         * Scripts/VCSUtils.pm:
1219         * Scripts/svn-apply:
1220
1221 2011-01-06  Julie Parent  <jparent@chromium.org>
1222
1223         Reviewed by Eric Seidel.
1224
1225         Test Result Server not removing old results.
1226         https://bugs.webkit.org/show_bug.cgi?id=52012
1227
1228         * TestResultServer/model/jsonresults.py:
1229         Fix off-by-one: Truncate if >= num_runs, not just >.
1230         * TestResultServer/model/jsonresults_unittest.py:
1231         Add unit test to test that merging in a new result with the same value
1232         as the last result causes previous result to fall off.
1233
1234 2011-01-06  James Kozianski  <koz@chromium.org>
1235
1236         Reviewed by Mihai Parparita.
1237
1238         Add classes to provide a consistent interface to a set of files.
1239         https://bugs.webkit.org/show_bug.cgi?id=50901
1240
1241         These classes allow us to write code that is agnostic to whether a
1242         particular set of files resides in a local directory or in a zip file
1243         on a remote machine.
1244
1245         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1246         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1247         * Scripts/webkitpy/common/system/fileset.py: Added.
1248         * Scripts/webkitpy/common/system/filesystem.py:
1249         * Scripts/webkitpy/common/system/filesystem_mock.py:
1250         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1251         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1252
1253 2011-01-06  Eric Seidel  <eric@webkit.org>
1254
1255         Reviewed by Adam Barth.
1256
1257         NetworkTransaction should log the url it is retrying
1258         https://bugs.webkit.org/show_bug.cgi?id=52043
1259
1260         * Scripts/webkitpy/common/net/networktransaction.py:
1261         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1262
1263 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1264
1265         Windows build fix.
1266         Import os before using it.
1267
1268         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1269
1270 2011-01-06  Eric Seidel  <eric@webkit.org>
1271
1272         Reviewed by Adam Barth.
1273
1274         StyleQueue fails to report errors when patches have many files
1275         https://bugs.webkit.org/show_bug.cgi?id=52042
1276
1277         This is one of at least two errors preventing style error reporting at the moment.
1278         When we moved to passing the list of files to check explicitly,
1279         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1280         We could change the type of the QueueStatus.message type, or we could
1281         just teach statusserver.py how to clamp values (and warn when it does).
1282         I chose the latter path.
1283
1284         * Scripts/webkitpy/common/net/statusserver.py:
1285
1286 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1287
1288         Reviewed by Stephanie Lewis.
1289         
1290         Fix syntax error in script.
1291
1292         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1293         https://bugs.webkit.org/show_bug.cgi?id=51996
1294
1295         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1296
1297 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1298
1299         Unreviewed, fixing WinCE build after r75196.
1300
1301         WinCE port does not (yet) support NPAPI.
1302
1303         * Scripts/build-webkit:
1304
1305 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1306
1307         Reviewed by Darin Adler.
1308
1309         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1310         https://bugs.webkit.org/show_bug.cgi?id=52015
1311
1312         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1313         after the platform has been detected, otherwise the script will
1314         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1315         detection.
1316
1317 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1318
1319         Reviewed by Eric Seidel.
1320
1321         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1322         https://bugs.webkit.org/show_bug.cgi?id=51346
1323
1324         * Scripts/build-webkit:
1325
1326 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1327
1328         Reviewed by Adam Roben.
1329
1330         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1331         https://bugs.webkit.org/show_bug.cgi?id=51996
1332         
1333         After the configuration directory change, we were archiving the incorrect directory for
1334         build product, so we were running tests on the wrong binaries.
1335         
1336         This change archives the correct directory, and also unarchives it into a configuration-
1337         specific directory.
1338
1339         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1340         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1341
1342 2011-01-06  Eric Seidel  <eric@webkit.org>
1343
1344         Reviewed by Mihai Parparita.
1345
1346         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1347         https://bugs.webkit.org/show_bug.cgi?id=52002
1348
1349         See an example of this here:
1350         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1351
1352         It's due to the fact that we pass around TestFailure() instance
1353         objects and yet expect them to all compare to be the same.
1354
1355         This is bad.  We should either have shared instances of these values
1356         or we should just pass around the class names.  There are already hacks
1357         in place to make TestFailure objects pass equality tests, I just added
1358         a __hash__ implementation so they can be used in sets as expected.
1359
1360         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1361         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1362
1363 2011-01-06  Evan Martin  <evan@chromium.org>
1364
1365         Reviewed by Tony Chang.
1366
1367         [gdb] handle inaccessible memory and UChar*
1368         https://bugs.webkit.org/show_bug.cgi?id=52003
1369
1370         To pretty-print a UChar*, we just grope around in the memory
1371         looking for a terminating NUL.  We need to handle the exception
1372         that can occur when we poke into an invalid location.
1373
1374         Additionally, the logic for choosing which pretty-printer would
1375         early return before hitting the point where we'd use the UChar*
1376         printer.  (Did this ever work?  How did it regress?)
1377
1378         * gdb/webkit.py:
1379
1380 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1381
1382         Reviewed by Ada Chan.
1383
1384         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1385         https://bugs.webkit.org/show_bug.cgi?id=51969
1386         
1387         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1388
1389         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1390         (WTR::InjectedBundlePage::InjectedBundlePage):
1391         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1392         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1393
1394 2011-01-06  James Robinson  <jamesr@chromium.org>
1395
1396         Reviewed by Simon Fraser.
1397
1398         Implement mozilla's animationTime property
1399         https://bugs.webkit.org/show_bug.cgi?id=51952
1400
1401         Chromium DRT support for webkitAnimationTime.
1402
1403         * DumpRenderTree/chromium/WebViewHost.cpp:
1404         (WebViewHost::paintInvalidatedRegion):
1405
1406 2011-01-06  Julie Parent  <jparent@chromium.org>
1407
1408         Reviewed by Tony Chang.
1409
1410         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1411         https://bugs.webkit.org/show_bug.cgi?id=51217
1412
1413         * TestResultServer/model/jsonresults.py:
1414         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1415         Adds missing documentation.
1416         * TestResultServer/model/jsonresults_unittest.py:
1417         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1418         Update test_merge to take a number of builds to truncate at.
1419
1420 2011-01-06  Adam Barth  <abarth@webkit.org>
1421
1422         Reviewed by Eric Seidel.
1423
1424         The EWS should log outside of the working directory
1425         https://bugs.webkit.org/show_bug.cgi?id=51986
1426
1427         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1428         script, which will actually clean the working copy back to a pristine
1429         state instead of leaving untracked directories and ignored files.
1430
1431         * Scripts/webkitpy/tool/commands/queues.py:
1432         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1433
1434 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1435
1436         Windows build fix.
1437         Back out attempted change to built-product-archive.
1438
1439         * BuildSlaveSupport/built-product-archive:
1440
1441 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1442
1443         Windows build fix.
1444         Include configuration name when unpacking a build archive.
1445
1446         Needed, since we split Windows build results into configuration-specific directories
1447         under WebKitOutputDir.
1448
1449         * BuildSlaveSupport/built-product-archive:
1450
1451 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1452
1453         Reviewed by Darin Adler.
1454
1455         Debug and Release builds on Windows clobber each other
1456         https://bugs.webkit.org/show_bug.cgi?id=49185
1457
1458         Changes the structure of WebKitBuild build products directory so we
1459         completely separate each build configuration into independent directories.
1460         
1461         Although we previously had per-configuration directories for obj, this change adds
1462         per-configuration directories for bin, lib, obj, and include. Each configuration's
1463         build products are stored within a directory inside of WebKitBuild.
1464         
1465         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1466         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1467
1468         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1469         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1470         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1471         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1472         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1473         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1474         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1475         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1476         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1477         * FindSafari/FindSafari.vcproj:
1478         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1479         * MiniBrowser/MiniBrowserPostBuild.cmd:
1480         * MiniBrowser/MiniBrowserPreBuild.cmd:
1481         * Scripts/webkitdirs.pm:
1482         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1483         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1484         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1485         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1486         * TestWebKitAPI/win/copy-resources.cmd:
1487         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1488         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1489         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1490         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1491         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1492         * WebKitTestRunner/win/InjectedBundle.vcproj:
1493         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1494         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1495         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1496         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1497         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1498         * WinLauncher/WinLauncherCommon.vsprops:
1499         * WinLauncher/WinLauncherPostBuild.cmd:
1500         * WinLauncher/WinLauncherPreBuild.cmd:
1501
1502 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1503
1504         Reviewed by Ariya Hidayat.
1505
1506         [Qt] TestNetscapePlugin doesn't link on OS X
1507         https://bugs.webkit.org/show_bug.cgi?id=51948
1508
1509         Only add a dependency on libX11 on X11 systems
1510
1511         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1512
1513 2011-01-05  Jeff Miller  <jeffm@apple.com>
1514
1515         Reviewed by Adam Roben.
1516
1517         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1518         https://bugs.webkit.org/show_bug.cgi?id=51970
1519
1520         * Scripts/webkitpy/style/checker.py:
1521         Add -readability/naming for WebKit2 C API directories.
1522
1523 2011-01-05  Eric Seidel  <eric@webkit.org>
1524
1525         Unreviewed, just fixing one more log error from my previous python patch.
1526
1527         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1528         https://bugs.webkit.org/show_bug.cgi?id=51802
1529
1530         webkit-patch failure-reason was logging about parsing errors
1531         due to my misunderstanding of how BeautifulSoup.findAll worked.
1532
1533         Fixed, and added a unit test.
1534
1535         * Scripts/webkitpy/common/net/layouttestresults.py:
1536         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1537
1538 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1539
1540         Reviewed by Kenneth Rohde Christiansen.
1541
1542         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1543         https://bugs.webkit.org/show_bug.cgi?id=51951
1544
1545         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1546         to create new window from WebKit.
1547
1548         * MiniBrowser/qt/BrowserWindow.cpp:
1549         (newPageFunction):
1550         (BrowserWindow::BrowserWindow):
1551         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1552         (BrowserWindow::newWindow):
1553         (BrowserWindow::updateUserAgentList):
1554         (BrowserWindow::showUserAgentDialog):
1555         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1556         define the type of the backing store used for new windows.
1557         * MiniBrowser/qt/main.cpp:
1558         (main):
1559
1560 2011-01-05  Eric Seidel  <eric@webkit.org>
1561
1562         Reviewed by Ojan Vafai.
1563
1564         commit-queue should report failure type when reporting flaky tests
1565         https://bugs.webkit.org/show_bug.cgi?id=51900
1566
1567         This patch was a ridiculous amount of plumbing.  In the end I like
1568         the NRWT-style TestResult class even less.  But now we're passing
1569         a list of TestResult objects from the queue to the FlakyTestReporter.
1570         Thus the FlakyTestReporter can more easily report what type of failure
1571         occurred.
1572
1573         In the process, I found that I was not alone in finding TestResult
1574         cumbersome to use.  A bunch of code was trying to create a TestResult
1575         object with default values.  However since the constructor didn't make
1576         this easy, some places were getting it wrong (including the TestResult unit test)!
1577         I've fixed the TestResult constructor to have default values for non-essential
1578         arguments.
1579
1580         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1581         * Scripts/webkitpy/common/net/layouttestresults.py:
1582         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1583         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1584         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1585         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1586         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1587         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1588         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1589         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1590         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1591         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1592         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1593         * Scripts/webkitpy/tool/commands/queues.py:
1594         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1595
1596 2011-01-05  Eric Seidel  <eric@webkit.org>
1597
1598         Unreviewed.
1599
1600         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1601         https://bugs.webkit.org/show_bug.cgi?id=51802
1602
1603         Add another unit test to cover a previously missing import.
1604
1605         * Scripts/webkitpy/common/net/layouttestresults.py:
1606         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1607
1608 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1609
1610         Reviewed by David Levin.
1611
1612         Add mihaip@chromium.org as a reviewer
1613         https://bugs.webkit.org/show_bug.cgi?id=51966
1614         
1615         Add myself as a reviewer.
1616
1617         * Scripts/webkitpy/common/config/committers.py:
1618
1619 2011-01-05  James Simonsen  <simonjam@chromium.org>
1620
1621         Unreviewed. Adding myself to the list of committers.
1622
1623         * Scripts/webkitpy/common/config/committers.py:
1624
1625 2011-01-05  Eric Seidel  <eric@webkit.org>
1626
1627         Unreviewed.
1628
1629         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1630         https://bugs.webkit.org/show_bug.cgi?id=51802
1631
1632         Fix two exceptions seen on the bots after my original commit.
1633
1634         * Scripts/webkitpy/common/net/layouttestresults.py:
1635         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1636
1637 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1638
1639         Reviewed by Andreas Kling.
1640
1641         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1642         https://bugs.webkit.org/show_bug.cgi?id=51750
1643
1644         * QtTestBrowser/main.cpp:
1645         (LauncherApplication::handleUserOptions):
1646          Local storage settings can be enable form command line arguments for
1647          QtTestBrowser.
1648
1649 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1650
1651         Reviewed by Martin Robinson.
1652
1653         GTK: AX: DRT needs to use correct root object method.
1654         https://bugs.webkit.org/show_bug.cgi?id=51911
1655
1656         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1657         (AccessibilityController::rootElement):
1658
1659 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1660
1661         Rubber-stamped by Csaba Osztrogonác.
1662
1663         Based on idea from Péter Gál.
1664
1665         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1666
1667 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1668
1669         Reviewed by Adam Barth.
1670
1671         sheriff-bot should be able to do multi-revision rollouts
1672         https://bugs.webkit.org/show_bug.cgi?id=51176
1673
1674         * Scripts/webkitpy/tool/bot/irc_command.py:
1675         * Scripts/webkitpy/tool/bot/sheriff.py:
1676         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1677
1678 2011-01-05  Eric Seidel  <eric@webkit.org>
1679
1680         Reviewed by Adam Barth.
1681
1682         queues.webkit.org should have per-bot status pages
1683         https://bugs.webkit.org/show_bug.cgi?id=51906
1684
1685         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1686         statuses from a single queue.  Now that we have many bots servicing
1687         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1688         you care about scroll off the end of the 15-message limit on the main page.
1689
1690         Eventually we should probably rename /queue-status to /queue or /queues,
1691         but that's fodder for another patch.
1692
1693         * QueueStatusServer/handlers/queuestatus.py:
1694         * QueueStatusServer/index.yaml:
1695         * QueueStatusServer/main.py:
1696         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1697          - This probably should use a custom filter instead of hard-coding
1698            the URL scheme here, but I couldn't figure out how to easily
1699            create such a filter.  Most filters work with "strings" so we can't
1700            pass the status object.  We could add a method to the status
1701            object and call that, but that seemed a bit strange too.
1702         * QueueStatusServer/templates/queuestatus.html:
1703
1704 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1705
1706         Unreviewed. Adding myself to the list of committers.
1707
1708         * Scripts/webkitpy/common/config/committers.py:
1709
1710 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1711
1712         Reviewed by David Levin.
1713
1714         check-webkit-style treated some macros with parentheses after #elif as function calls
1715         https://bugs.webkit.org/show_bug.cgi?id=51695
1716
1717         Ingore function call space checking in any preprocessor directives
1718         (things starting with #). Change search() to match() because 
1719         preprocessor directives are supposed to be in the beginning of lines.
1720
1721         * Scripts/webkitpy/style/checkers/cpp.py:
1722         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1723
1724 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1725
1726         Reviewed by Tony Chang.
1727
1728         Change the --multi-load test option to --stress-opt
1729         https://bugs.webkit.org/show_bug.cgi?id=50751
1730
1731         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1732         (runTest):
1733         (main):
1734         * DumpRenderTree/chromium/TestShell.cpp:
1735         (TestShell::TestShell):
1736         * DumpRenderTree/chromium/TestShell.h:
1737         (TestShell::stressOpt):
1738         (TestShell::setStressOpt):
1739         (TestShell::stressDeopt):
1740         (TestShell::setStressDeopt):
1741         (TestShell::javaScriptFlags):
1742         (TestShell::setJavaScriptFlags):
1743         * Scripts/webkitpy/layout_tests/port/chromium.py:
1744         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1745
1746 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1747
1748         Reviewed by Sam Weinig.
1749
1750         WK2: Support Accessibility
1751         https://bugs.webkit.org/show_bug.cgi?id=51859
1752
1753         Use rootObject() method to get top of accessibility tree.
1754
1755         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1756         (AccessibilityController::focusedElement):
1757         (AccessibilityController::rootElement):
1758
1759 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1760
1761         Reviewed by Darin Adler.
1762
1763         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1764         https://bugs.webkit.org/show_bug.cgi?id=51846
1765
1766         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1767         back to GRefPtr.
1768
1769 2011-01-04  Zhe Su  <suzhe@chromium.org>
1770
1771         Reviewed by Kenneth Russell.
1772
1773         Fix insertText, setMarkedText and unmarkText methods of
1774         TextInputController to call corresponding methods of WebKit::WebView
1775         rather than WebKit::WebFrame. This change matches the behavior of
1776         chromium browser.
1777         insertText corresponds to WebView::confirmComposition(text)
1778         setMarkedText corresponds to WebView::setComposition(...)
1779         unmarkText corresponds to WebView::confirmComposition()
1780         https://bugs.webkit.org/show_bug.cgi?id=51693
1781
1782         * DumpRenderTree/chromium/TextInputController.cpp:
1783         (TextInputController::insertText):
1784         (TextInputController::setMarkedText):
1785         (TextInputController::unmarkText):
1786
1787 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1788
1789         Reviewed by Laszlo Gombos.
1790
1791         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1792
1793         On Symbian productDir points to the source directory. Removing all the
1794         empty files from the productDir directory corrupts the svn repository.
1795
1796         * Scripts/build-webkit:
1797
1798 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1799
1800         Reviewed by Adam Barth.
1801
1802         [Qt] Add SelectAll option to the context menu for the editor
1803         https://bugs.webkit.org/show_bug.cgi?id=50049
1804
1805         Set shortcut for the SelectAll action.
1806
1807         * QtTestBrowser/mainwindow.cpp:
1808         (MainWindow::buildUI):
1809
1810 2011-01-03  David Levin  <levin@chromium.org>
1811
1812         Reviewed by Eric Seidel.
1813
1814         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1815         https://bugs.webkit.org/show_bug.cgi?id=51842
1816
1817         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1818         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1819
1820 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1821
1822         Reviewed by David Kilzer.
1823
1824         [WINCE] Adds a build slave.
1825         https://bugs.webkit.org/show_bug.cgi?id=50523
1826
1827         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1828         entry for a release build of the WinCE port.
1829         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1830         flag to build the WinCE port.
1831
1832 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1833
1834         Reviewed by David Kilzer.
1835
1836         Add WinCE support to build-webkit
1837         https://bugs.webkit.org/show_bug.cgi?id=51642
1838
1839         * Scripts/build-webkit:
1840         * Scripts/webkitdirs.pm:
1841
1842 2011-01-03  Eric Seidel  <eric@webkit.org>
1843
1844         Reviewed by Adam Barth.
1845
1846         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1847         https://bugs.webkit.org/show_bug.cgi?id=51802
1848
1849         I'm not the biggest fan of the test_failures or test_results classes,
1850         but it's better to have one shared set of classes, than separate ones
1851         for new vs. old run-webkit-test result handling.
1852
1853         This moves the ORWT results class "LayoutTestResults" over to using
1854         TestResult and TestFailure classes, making it easy for us to
1855         make all our sheriff-bot and other webkitpy code NRWT ready.
1856
1857         This also makes it a trivial patch to generate results.json information
1858         from ORWT results.html files (for flaky test analysis, etc.) as well
1859         as making it a one-liner to report test failure types when the
1860         commit-queue sees flaky tests.
1861
1862         This patch tried not to add new functionality, but only to replace
1863         the guts of LayoutTestResults, while adding unit tests and hoping
1864         not to break anything.
1865
1866         I also moved callers which assumed User.prompt* were static/class methods
1867         to using them as instance methods (since we'll eventually want to make them such).
1868
1869         In the process of re-writing things, I broke the rebaseline command, so I wrote
1870         a unit test to catch my breakage were I do do so again in the future.
1871
1872         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1873         * Scripts/webkitpy/common/net/layouttestresults.py:
1874         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1875         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1876         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1877         * Scripts/webkitpy/tool/commands/queries.py:
1878         * Scripts/webkitpy/tool/commands/rebaseline.py:
1879         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1880         * Scripts/webkitpy/tool/mocktool.py:
1881
1882 2011-01-03  Adam Barth  <abarth@webkit.org>
1883
1884         Reviewed by Simon Fraser.
1885
1886         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1887         https://bugs.webkit.org/show_bug.cgi?id=51840
1888
1889         * Scripts/webkitpy/common/checkout/scm.py:
1890
1891 2011-01-03  Adam Barth  <abarth@webkit.org>
1892
1893         Reviewed by Simon Fraser.
1894
1895         webkit-patch should only hide update output if --quiet
1896         https://bugs.webkit.org/show_bug.cgi?id=51838
1897
1898         As requested by smfr.
1899
1900         * Scripts/webkitpy/tool/steps/update.py:
1901
1902 2011-01-03  Adam Barth  <abarth@webkit.org>
1903
1904         Reviewed by David Levin.
1905
1906         commit-queue shouldn't reject patches twice if two bots process the same patch
1907         https://bugs.webkit.org/show_bug.cgi?id=51805
1908
1909         Before raising an error, we first check whether the patch is still in
1910         the commit-queue.  This check is still racy, of course, but the time
1911         window is much smaller.
1912
1913         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1914
1915 2011-01-03  Sam Weinig  <sam@webkit.org>
1916
1917         Reviewed by Anders Carlsson.
1918
1919         Make run-api-tests less chatty.
1920         https://bugs.webkit.org/show_bug.cgi?id=51831
1921
1922         - Make script quiet by default and add --verbose option (replacing --quiet).
1923         - When not verbose, pipe stdout and stderr to devnull.
1924
1925         * Scripts/run-api-tests:
1926
1927 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1928
1929         Unreviewed. Adding myself to committers.py.
1930
1931         * Scripts/webkitpy/common/config/committers.py:
1932
1933 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1934
1935         Reviewed by Xan Lopez.
1936
1937         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1938         https://bugs.webkit.org/show_bug.cgi?id=51806
1939
1940         Originally, the $libraryName is 'JavaScriptCore'. When building release 
1941         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1942         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1943         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
1944         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1945         so make it 'WebKitBuild/Release/.libs'
1946
1947         * Scripts/webkitdirs.pm: 
1948
1949 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1950
1951         Reviewed by Adam Barth.
1952
1953         Make EFL a core builder
1954         https://bugs.webkit.org/show_bug.cgi?id=51804
1955
1956         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1957         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1958
1959 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1960
1961         [Qt] Unreviewed fix after r74855 and r74875.
1962
1963         * BuildSlaveSupport/built-product-archive:
1964          - Create directories explicitly.
1965          - Pass shell=True to subprocess.call().
1966
1967 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1968
1969         [Qt] Unreviewed fix after r74855.
1970
1971         Move JavaScriptCore to Source
1972         https://bugs.webkit.org/show_bug.cgi?id=51604
1973
1974         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1975
1976 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1977
1978         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1979
1980         Move JavaScriptCore to Source
1981         https://bugs.webkit.org/show_bug.cgi?id=51604
1982
1983         * Scripts/webkitdirs.pm:
1984
1985 2011-01-02  Robert Hogan  <robert@webkit.org>
1986
1987         Unreviewed, build fix.
1988
1989         [Qt] Fix DRT build after 74855
1990
1991         * DumpRenderTree/qt/DumpRenderTree.pro:
1992
1993 2011-01-01  Adam Barth  <abarth@webkit.org>
1994
1995         Remove the assumption from the Qt and Gtk builds that every project is
1996         in the root directory.
1997
1998         * Scripts/build-webkit:
1999
2000 2011-01-01  Adam Barth  <abarth@webkit.org>
2001
2002         Reviewed by Eric Seidel.
2003
2004         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2005         https://bugs.webkit.org/show_bug.cgi?id=51796
2006
2007         After this change, svn-apply will magically apply patches to
2008         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2009
2010         * Scripts/VCSUtils.pm:
2011
2012 2011-01-01  Adam Barth  <abarth@webkit.org>
2013
2014         Reviewed by Eric Seidel.
2015
2016         Move JavaScriptCore to Source
2017         https://bugs.webkit.org/show_bug.cgi?id=51604
2018
2019         Update references to JavaScriptCore to point to the new location.
2020
2021         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2022         * DumpRenderTree/qt/DumpRenderTree.pro:
2023         * DumpRenderTree/qt/ImageDiff.pro:
2024         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2025         * DumpRenderTree/wscript:
2026         * Scripts/build-jsc:
2027         * Scripts/build-webkit:
2028         * Scripts/do-file-rename:
2029         * Scripts/do-webcore-rename:
2030         * Scripts/run-javascriptcore-tests:
2031         * Scripts/update-javascriptcore-test-results:
2032         * Scripts/webkitdirs.pm:
2033         * Scripts/webkitpy/common/config/build_unittest.py:
2034         * Scripts/webkitpy/style/checker.py:
2035         * Scripts/webkitpy/style/checker_unittest.py:
2036         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2037         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2038         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2039         * wx/build/settings.py:
2040
2041 2011-01-01  Adam Barth  <abarth@webkit.org>
2042
2043         Reviewed by Eric Seidel.
2044
2045         Move Sources to Source
2046         https://bugs.webkit.org/show_bug.cgi?id=51794
2047
2048         Update scripts to point to the new location.
2049
2050         * Scripts/build-webkit:
2051         * Scripts/do-file-rename:
2052         * Scripts/do-webcore-rename:
2053         * Scripts/webkitpy/common/config/build.py:
2054         * Scripts/webkitpy/common/config/build_unittest.py:
2055
2056 2010-12-31  Kent Tamura  <tkent@chromium.org>
2057
2058         Reviewed by Eric Seidel.
2059
2060         [DRT/Chromium] Enable mock spell checker on non-OSX
2061         https://bugs.webkit.org/show_bug.cgi?id=51401
2062
2063         * DumpRenderTree/chromium/WebViewHost.cpp:
2064         (WebViewHost::spellCheck):
2065
2066 2010-12-31  Adam Barth  <abarth@webkit.org>
2067
2068         Reviewed by Ariya Hidayat.
2069
2070         Remove Tools/Scripts/wkstyle
2071         https://bugs.webkit.org/show_bug.cgi?id=51774
2072
2073         This script appears to not have been touched in a while and seems to
2074         have been replaced by check-webkit-style.
2075
2076         * Scripts/wkstyle: Removed.
2077
2078 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2079
2080         Unreviewed. Coding style fix.
2081
2082         * DumpRenderTree/chromium/TestShell.h:
2083
2084 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2085
2086         Reviewed by Pavel Feldman.
2087
2088         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2089
2090         It was a problem with Chromium DRT. DevToolsAgent object instance was
2091         attached not only to the inspected page but to the DevTools window too.
2092         As result all the inspector files were interpreted as a content of inspected page
2093         and were transfered to the DevTools scripts panel for debugging etc.
2094
2095         https://bugs.webkit.org/show_bug.cgi?id=51735
2096
2097         * DumpRenderTree/chromium/TestShell.cpp:
2098         (TestShell::TestShell):
2099         (TestShell::bindJSObjectsToWindow):
2100         (TestShell::createNewWindow):
2101         * DumpRenderTree/chromium/TestShell.h:
2102
2103 2010-12-31  Adam Barth  <abarth@webkit.org>
2104
2105         Rubber-stamped by Eric Seidel.
2106
2107         Move PageLoadTests to PerformanceTests/PageLoad
2108         https://bugs.webkit.org/show_bug.cgi?id=51771
2109
2110         Update references to PageLoadTests to point to the new location.
2111
2112         * Scripts/run-pageloadtest:
2113         * Scripts/webkitpy/common/config/build.py:
2114
2115 2010-12-31  Adam Barth  <abarth@webkit.org>
2116
2117         Rubber-stamped by Eric Seidel.
2118
2119         Move SunSpider into PerformanceTests
2120         https://bugs.webkit.org/show_bug.cgi?id=51769
2121
2122         Update these scripts to point to the new location.
2123
2124         * Scripts/run-sunspider:
2125         * Scripts/sunspider-compare-results:
2126
2127 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2128
2129         Reviewed by Kent Tamura.
2130
2131         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2132         https://bugs.webkit.org/show_bug.cgi?id=51728
2133         
2134         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2135         to render top-level scrollbars. This makes them match the Mac port's
2136         use of an NSScrollView, which means that we'll be able to share more
2137         pixel baselines.
2138         
2139         The new rendering code will not be activated until the 
2140         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2141         ScrollbarThemeChromiumMac.
2142
2143         * DumpRenderTree/DumpRenderTree.gypi:
2144         * DumpRenderTree/chromium/TestShellMac.mm:
2145         (platformInit):
2146         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2147         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2148         (+[FakeActiveWindow alwaysActiveWindow]):
2149         (+[FakeActiveWindow alwaysInactiveWindow]):
2150         (-[FakeActiveWindow initWithActiveControls:]):
2151         (-[FakeActiveWindow _hasActiveControls]):
2152         (WebThemeEngineDRTMac::paintScrollbarThumb):
2153         (stateToHIEnableState):
2154         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2155         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2156
2157 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2158
2159         Reviewed by David Kilzer.
2160
2161         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2162         used
2163         https://bugs.webkit.org/show_bug.cgi?id=51672
2164
2165         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2166         with USE_SYSTEM_MALLOC=1
2167         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2168         with USE_SYSTEM_MALLOC=1
2169
2170 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2171
2172         Reviewed by David Kilzer.
2173
2174         [Qt] [Symbian] Fix build-webkit script for Symbian
2175         https://bugs.webkit.org/show_bug.cgi?id=51509
2176
2177         Set the OUTPUT_DIR for Symbian to be the same as the source
2178         directory.
2179
2180         * Scripts/webkitdirs.pm:
2181
2182 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2183
2184         Reviewed by Darin Adler.
2185
2186         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2187         https://bugs.webkit.org/show_bug.cgi?id=51758
2188
2189         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2190
2191         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2192         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2193
2194 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2195
2196         Unreviewed WinCE buildfix.
2197
2198         * WinCELauncher/main.cpp: Add missing include.
2199
2200 2010-12-29  Daniel Bates  <dbates@rim.com>
2201
2202         Reviewed by Darin Adler.
2203
2204         svn-apply updates date of wrong change log entry for a change log diff that
2205         contains two consecutive entries with the same author and date
2206         https://bugs.webkit.org/show_bug.cgi?id=46061
2207
2208         Fixes an issue where the date of the wrong change log entry may be modified.
2209         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2210         in a ChangeLog file to the top of the file.
2211
2212         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2213         diff when it detects that the diff inserts a change log entry earlier in a
2214         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2215         change. With the advent of the commit-queue this functionality of bailing out
2216         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2217         Instead, we should always move the change log entry to the top of the ChangeLog file.
2218
2219         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2220         the date line of the correct change log entry in a ChangeLog diff.
2221
2222         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2223
2224         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2225           Updated the following unit tests now that we move entries inserted earlier to the top:
2226           - "fixChangeLogPatch: New entry inserted in middle."
2227             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2228
2229           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2230             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2231
2232         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2233
2234 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2235
2236         Reviewed by Eric Seidel.
2237
2238         [Qt] Fixed compatibility with gold linker on X11 platforms
2239         https://bugs.webkit.org/show_bug.cgi?id=51700
2240
2241         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2242         Linked TestNetscapePlugin with libX11 on Unix platforms
2243
2244 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2245
2246         Reviewed by Darin Adler.
2247
2248         Circular dependency in webkitpy.common.checkout.changelog module
2249         https://bugs.webkit.org/show_bug.cgi?id=50475
2250
2251         Remove automatic import of api.Checkout module when any checkout/
2252         submodule is imported (e.g.: when checkout.scm.Git is imported).
2253
2254         * Scripts/webkitpy/common/checkout/__init__.py:
2255
2256 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2257
2258         Reviewed by Ojan Vafai.
2259
2260         prepare-ChangeLog should support the -g option for specifying the git-commit
2261         https://bugs.webkit.org/show_bug.cgi?id=51708
2262
2263         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2264         webkit-patch, though the exact meaning of the two options remain different.
2265
2266         * Scripts/prepare-ChangeLog: Add -g.
2267
2268 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2269
2270         Reviewed by Simon Hausmann.
2271
2272         [Qt] Fix compilation with Qt in namespace
2273         https://bugs.webkit.org/show_bug.cgi?id=51701
2274
2275         * QtTestBrowser/webview.h:
2276
2277 2010-12-28  Daniel Bates  <dbates@rim.com>
2278
2279         Reviewed by Sam Weinig.
2280
2281         Substitute // MARK: for compiler-specific #pragma mark
2282         https://bugs.webkit.org/show_bug.cgi?id=51657
2283
2284         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2285         substituting  "// MARK:" for "#pragma mark", which provides
2286         analogous code-bookmarking functionality under Xcode.
2287
2288         Also, for consistency, we should substitute "// MARK:" for compiler-
2289         specific "#pragma mark" in the source files for the Mac port.
2290
2291         * DumpRenderTree/AccessibilityTextMarker.cpp:
2292         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2293         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2294         * DumpRenderTree/mac/ObjCController.m:
2295         * MiniBrowser/mac/AppDelegate.m:
2296         * MiniBrowser/mac/BrowserWindowController.m:
2297
2298 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2299
2300         Reviewed by Eric Seidel.
2301
2302         Add --no-build option to run-sunspider
2303         https://bugs.webkit.org/show_bug.cgi?id=51658
2304
2305         * Scripts/run-sunspider: add --no-build flag to skip building
2306         phase.
2307
2308 2010-12-27  Daniel Bates  <dbates@rim.com>
2309
2310         Rubber-stamped by Martin Robinson.
2311
2312         Append the directory Tools/DumpRenderTree to the list of directories that
2313         do-webcore-rename should search so that it can rename DRT files and
2314         source code.
2315
2316         * Scripts/do-webcore-rename:
2317
2318 2010-12-27  Eric Seidel  <eric@webkit.org>
2319
2320         Reviewed by Adam Barth.
2321
2322         build-webkit should detect missing Java SDK and explain how to install it
2323         https://bugs.webkit.org/show_bug.cgi?id=51651
2324
2325         * Scripts/build-webkit:
2326
2327 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2328
2329         Reviewed by Daniel Bates.
2330
2331         [GTK] Add support for build-jsc
2332         https://bugs.webkit.org/show_bug.cgi?id=51625
2333
2334         Add GTK+ support to build-jsc now that building the jsc executable as
2335         a standalone target is easy.
2336
2337         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2338         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2339         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2340         and pass it along to buildAutotoolsProject.
2341
2342 2010-12-27  David Levin  <levin@chromium.org>
2343
2344         Reviewed by Eric Seidel.
2345
2346         check-webkit-style check for meaningless variable names in function declarations.
2347         https://bugs.webkit.org/show_bug.cgi?id=51523
2348
2349         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2350         from the new check and whitespace/parens because the syntax is unusual and
2351         produced a fair number of positives for these checks.
2352         * Scripts/webkitpy/style/checkers/cpp.py:
2353         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2354         and parameter names when determining if the parameter name is useless.
2355         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2356         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2357         format.
2358         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2359         text or an acronym of it.
2360         (check_function_definition): Checks function definitions for meaningless variable names.
2361         (process_line): Added call to check_function_definition.
2362         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2363         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2364         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2365         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2366         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2367         because when only checking a snippet, there are a lot of bogus functions.
2368         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2369         that I put there previously and just noticed.
2370         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2371         check_function_definition and process_line.
2372
2373 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2374
2375         Reviewed by Martin Robinson.
2376
2377         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2378         https://bugs.webkit.org/show_bug.cgi?id=51591
2379
2380         Flash plugin uses gtk2 that is incompatible with gtk3 making
2381         webkit crash when it's built with gtk3.
2382
2383         * GtkLauncher/main.c:
2384         (main):
2385
2386 2010-12-25  Adam Barth  <abarth@webkit.org>
2387
2388         Reviewed by Eric Seidel.
2389
2390         Move ANGLE to Sources/ThirdParty
2391         https://bugs.webkit.org/show_bug.cgi?id=51605
2392
2393         * Scripts/build-webkit:
2394           - Point to the new ANGLE location.
2395
2396 2010-12-26  David Levin  <levin@chromium.org>
2397
2398         Reviewed by Eric Seidel.
2399
2400         check-webkit-style should be able to parse function declaration parameters.
2401         https://bugs.webkit.org/show_bug.cgi?id=51451
2402
2403         * Scripts/webkitpy/style/checkers/cpp.py:
2404         (Position.__init__): Holds simple position information (row, column).
2405         (Parameter.__init__): Holds information about a parameter.
2406         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2407         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2408         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2409         (find_parameter_name_index): Finds where the parameter name is.
2410         (parameter_list): Generates the list of parameters for a function.
2411         (_FunctionState.begin): Added information to allow determining the parameters
2412         on demand.
2413         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2414         (detect_functions): Improve function detection for operator functions and
2415         determine where the parameters end and pass that to _FunctionState.begin.
2416         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2417         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2418         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2419         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2420         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2421         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2422         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2423         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2424         the parameters found.
2425         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2426         detection test to verify that we catch the operator functions.
2427         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2428         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2429         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2430         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2431         test_function_length_check_definition_severity1_for_test.
2432
2433 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2434
2435         Unreviewed WinCE buildfix after r74334.
2436
2437         * CMakeListsWinCE.txt:
2438
2439 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2440
2441         Unreviewed, rolling out r74632.
2442         http://trac.webkit.org/changeset/74632
2443         https://bugs.webkit.org/show_bug.cgi?id=51600
2444
2445         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2446         on #webkit).
2447
2448         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2449         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2450
2451 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2452
2453         Reviewed by Kenneth Rohde Christiansen.
2454
2455         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2456         https://bugs.webkit.org/show_bug.cgi?id=43528
2457
2458         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2459         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2460         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2461         called.
2462
2463         * EWebLauncher/main.c:
2464         (browserCreate):
2465
2466 2010-12-24  Eric Seidel  <eric@webkit.org>
2467
2468         Reviewed by Adam Barth.
2469
2470         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2471         https://bugs.webkit.org/show_bug.cgi?id=28291
2472
2473         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2474         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2475         to strings with find in the diff.
2476         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2477
2478         * Scripts/webkitpy/common/checkout/api.py:
2479         * Scripts/webkitpy/common/checkout/diff_parser.py:
2480         * Scripts/webkitpy/tool/steps/abstractstep.py:
2481         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2482         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2483         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2484         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2485
2486 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2487
2488         Reviewed by Kenneth Russell.
2489
2490         Modify new-run-webkit-tests to shut up and exit when all the threads
2491         are wedged so that test runs complete faster and we don't end up
2492         w/ enormous log files.
2493
2494         https://bugs.webkit.org/show_bug.cgi?id=51572
2495
2496         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2497         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2498
2499 2010-12-24  Eric Seidel  <eric@webkit.org>
2500
2501         Reviewed by David Levin.
2502
2503         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2504         https://bugs.webkit.org/show_bug.cgi?id=51549
2505
2506         I've had multiple people ask me about the commit-queue's behavior
2507         regarding reporting flaky tests.  I figured it would be best to just
2508         have the queue explain itself in the bugs it files.
2509
2510         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2511         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2512
2513 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2514
2515         Reviewed by Eric Seidel.
2516
2517         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2518         https://bugs.webkit.org/show_bug.cgi?id=51467
2519
2520         * Scripts/webkitpy/style/checker.py:
2521         * Scripts/webkitpy/style/checker_unittest.py:
2522
2523 2010-12-23  Adam Barth  <abarth@webkit.org>
2524
2525         Rubber-stamped by Eric Seidel.
2526
2527         Move JavaScriptGlue into Sources
2528         https://bugs.webkit.org/show_bug.cgi?id=51583
2529
2530         These tools refer to JavaScriptGlue and need to be updated to its new
2531         location.
2532
2533         * Scripts/build-webkit:
2534         * Scripts/do-file-rename:
2535         * Scripts/do-webcore-rename:
2536         * Scripts/webkitpy/common/config/build.py:
2537         * Scripts/webkitpy/common/config/build_unittest.py:
2538
2539 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2540
2541         Reviewed by Eric Seidel.
2542
2543         Bug 51539 - update iexploder scripts to point to new location
2544
2545         * Scripts/run-iexploder-tests:
2546         * Scripts/update-iexploder-cssproperties:
2547
2548 2010-12-23  Evan Martin  <evan@chromium.org>
2549
2550         Reviewed by Ryosuke Niwa.
2551
2552         [chromium] LayoutTestController warning in float->int conversion
2553         https://bugs.webkit.org/show_bug.cgi?id=51553
2554
2555         Rather than reading an int, converting to a float, then getting a compiler
2556         warning on passing the float to something that expects an int, instead
2557         just pass around ints.
2558
2559         No tests, fixes a compiler warning.
2560
2561         * DumpRenderTree/chromium/LayoutTestController.cpp:
2562         (parsePageSizeParameters):
2563         (LayoutTestController::pageNumberForElementById):
2564         (LayoutTestController::numberOfPages):
2565
2566 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2567
2568         Reviewed by Darin Adler.
2569
2570         Bug 51537 - iexploder needs cleanup
2571         
2572         * iExploder/htdocs: Removed.
2573         * iExploder/htdocs/config.rb: Removed.
2574         * iExploder/htdocs/cssproperties.in: Removed.
2575         * iExploder/htdocs/cssvalues.in: Removed.
2576         * iExploder/htdocs/htmlattrs.in: Removed.
2577         * iExploder/htdocs/htmltags.in: Removed.
2578         * iExploder/htdocs/htmlvalues.in: Removed.
2579         * iExploder/htdocs/iexploder.cgi: Removed.
2580         * iExploder/htdocs/iexploder.rb: Removed.
2581         * iExploder/htdocs/index.html: Removed.
2582         * iExploder/htdocs/webserver.rb: Removed.
2583         * iExploder/iexploder-1.7.2/output: Removed.
2584         * iExploder/tools: Removed.
2585         * iExploder/tools/lasthit.rb: Removed.
2586         * iExploder/tools/osx_last_crash.rb: Removed.
2587         * iExploder/tools/showtest.rb: Removed.
2588
2589 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2590
2591         Reviewed by Kenneth Rohde Christiansen.
2592
2593         [EFL] Make 'single' the default backing store in EWebLauncher
2594         https://bugs.webkit.org/show_bug.cgi?id=51534
2595
2596         'single' is the simplest backing store and the one intended to be the
2597         default in the test browser. By mistake the tiled backing store was
2598         left as default in r72617.
2599
2600         * EWebLauncher/main.c:
2601         (browserCreate): ditto.
2602
2603 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2604
2605         Reviewed by Kenneth Rohde Christiansen.
2606
2607         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2608         https://bugs.webkit.org/show_bug.cgi?id=51533
2609
2610         There's no point in concatenating env("HOME") with "blah", so remove
2611         option from EWebLauncher.
2612
2613         * EWebLauncher/main.c:
2614         (main): ditto.
2615
2616 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2617
2618         Reviewed by Eric Seidel.
2619
2620         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2621
2622         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2623         I just discovered that we have two additional GC runs per each WebViewHost.
2624         Test_shell had no such calls.
2625         These gc runs eat 15% of cpu time.
2626
2627         https://bugs.webkit.org/show_bug.cgi?id=51479
2628
2629         * DumpRenderTree/chromium/WebViewHost.cpp:
2630         (WebViewHost::~WebViewHost):
2631
2632 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2633
2634         Reviewed by Ojan Vafai.
2635
2636         This change splits out the TestRunner class into its own file.
2637         When we fork the code for message passing, we will create a new
2638         TestRunner, and this change will allow that to be more modular.
2639
2640         While we're at it, split out TestInput and ResultSummary into
2641         their own files, to reduce the size of run_webkit_tests to
2642         something more managable.
2643
2644         https://bugs.webkit.org/show_bug.cgi?id=51092
2645
2646         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2647         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2648         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2649         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2650         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2651         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2652         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2653
2654  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2655
2656         Reviewed by Ojan Vafai.
2657
2658         nrwt multiprocessing - start over, prepare to fork the code
2659  
2660         This code cleans up the signatures and implementation of the
2661         TestRunner class so we can easily fork it to run either the
2662         stable implementation or the new, unstable message-passing
2663         implementation. The two variants will have different
2664         implementations of the run_tests() method. We will switch
2665         between the two based on the setting for the '--worker-model'
2666         switch. We rename the two currently valid values to 'old-inline'
2667         and 'old-threads'.
2668
2669         https://bugs.webkit.org/show_bug.cgi?id=51081
2670
2671         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2672         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2673
2674 2010-12-22  Victor Wang  <victorw@chromium.org>
2675
2676         Reviewed by Darin Fisher.
2677
2678         [Chromium] Update chromium archive test result url in rebaseline script.
2679
2680         https://bugs.webkit.org/show_bug.cgi?id=51503
2681
2682         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2683
2684 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2685
2686         Reviewed by Alice Liu.
2687
2688         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2689         Verified on Chrome, Safari, and IE.
2690         With this change, we will record memory from a parent browser window and all child processes.
2691
2692         * record-memory-win/main.cpp:
2693         (ProcessArgs):
2694         (PrintUsage):
2695         (getMemoryInfo):
2696         (printProcessInfo):
2697         (evalProcesses):
2698         (UseImage):
2699         (QueryContinuously):
2700         (ElapsedTime):
2701
2702 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2703
2704         Unreviewed rollout r74489, because it was missing changelog.
2705
2706         * record-memory-win/main.cpp:
2707         
2708 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2709
2710         Adding myself as a reviewer.
2711
2712         * Scripts/webkitpy/common/config/committers.py:
2713
2714 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2715
2716         Unreviewed.  Adding myself to committers.py.
2717
2718         * Scripts/webkitpy/common/config/committers.py:
2719
2720 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2721
2722         Reviewed by Kenneth Rohde Christiansen.
2723
2724         TestNetscapePlugIn should use #if defined
2725         https://bugs.webkit.org/show_bug.cgi?id=51471
2726
2727         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2728         (NP_Initialize):
2729         (NPP_New):
2730
2731 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2732
2733         Reviewed by Yury Semikhatsky.
2734
2735         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2736
2737         DevTools window should be closed explicitly because it has custom deinitialization code.
2738
2739         https://bugs.webkit.org/show_bug.cgi?id=50722
2740
2741         * DumpRenderTree/chromium/TestShell.cpp:
2742         (TestShell::closeRemainingWindows):
2743
2744 2010-12-22  David Levin  <levin@chromium.org>
2745
2746         Reviewed by Shinichiro Hamaji.
2747
2748         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2749         https://bugs.webkit.org/show_bug.cgi?id=51452
2750
2751         * Scripts/webkitpy/style/checkers/cpp.py:
2752         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2753         Using the file extension if possible but falling back to the file contents if we have a header file.
2754         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2755         (_FileState.is_c_or_objective_c):
2756         (check_using_std): Changed to using _FileState to determine the file type.
2757         (check_max_min_macros): Ditto.
2758         (check_for_null): Ditto.
2759         (check_style): Changed the parameters to various calls since they now need _FileState
2760         to determine the file type.
2761         (check_language): Added the file_state parameter so it could be passed
2762         to check_identifier_name_in_declaration.
2763         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2764         this is an Objective C file.
2765         (_process_lines): Added information for the _FileState constructor (and moved the
2766         call to a place that had the information).
2767         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2768         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2769         its functionality.
2770         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2771
2772 2010-12-21  Andy Estes  <aestes@apple.com>
2773
2774         Reviewed by Mark Rowe.
2775
2776         Do not build non-Intel architectures for WebKit2-related projects.
2777         https://bugs.webkit.org/show_bug.cgi?id=51440
2778
2779         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2780         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2781         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2782
2783 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2784
2785         Reviewed by Darin Fisher.
2786
2787         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2788         https://bugs.webkit.org/show_bug.cgi?id=51406 
2789         
2790         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2791         to WebThemeEngineDRTWin and update references everywhere.
2792
2793         * DumpRenderTree/DumpRenderTree.gypi:
2794         * DumpRenderTree/chromium/TestShellWin.cpp:
2795         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2796         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2797         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2798         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2799
2800 2010-12-21  Anders Carlsson  <andersca@apple.com>
2801
2802         Reviewed by John Sullivan.
2803
2804         Clicking missing plug-in text does not show a sheet
2805         https://bugs.webkit.org/show_bug.cgi?id=51403
2806
2807         Update for changes to the WebPageUIClient.
2808
2809         * MiniBrowser/mac/BrowserWindowController.m:
2810         (-[BrowserWindowController awakeFromNib]):
2811         * WebKitTestRunner/TestController.cpp:
2812         (WTR::createOtherPage):
2813         (WTR::TestController::initialize):
2814
2815 2010-12-21  Eric Seidel  <eric@webkit.org>
2816
2817         Reviewed by Adam Barth.
2818
2819         commit-queue will report constant failures as flaky if other tests flake
2820         https://bugs.webkit.org/show_bug.cgi?id=51272
2821
2822         This patch just removes functionality and adds testing.
2823         Previously we attempted to report flaky tests when we had
2824         two different tests fail in a row.  However, since we stop
2825         running the tests at the first failure, our code was wrong in
2826         trying to determine flakiness from the incomplete runs.
2827
2828         Originally I posted an alternate patch:
2829         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2830         which fixed our flaky logic in this case, however it was decided
2831         that that patch would be too difficult to maintain, so now
2832         I'm just removing the broken logic.
2833
2834         This will dramatically cut-down on our flaky-test false positives
2835         at the (small) cost of the queues being unable to report
2836         any flakiness if the tree is very flaky.  (With at least one test
2837         flaking on every run, we'll never report failures anymore.)  I think
2838         this is a tradeoff worth making.
2839
2840         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2841         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2842
2843 2010-12-20  Eric Seidel  <eric@webkit.org>
2844
2845         Reviewed by Adam Barth.
2846
2847         commit-queue wrongly rejects patches when it can't update itself
2848         https://bugs.webkit.org/show_bug.cgi?id=46636
2849
2850         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2851         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2852         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2853
2854 2010-12-20  Adam Barth  <abarth@webkit.org>
2855
2856         Move web sites to Websites directory
2857         https://bugs.webkit.org/show_bug.cgi?id=51323
2858
2859         Update references to BugsSite to point to the new location.
2860
2861         This patch was never officially reviewed (because it was too large to
2862         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2863         Rowe gave me the green light.
2864
2865         * Scripts/old-run-webkit-tests:
2866         * Scripts/webkitpy/common/config/build.py:
2867         * Scripts/webkitpy/common/config/build_unittest.py:
2868         * Scripts/webkitpy/common/prettypatch.py:
2869         * Scripts/webkitpy/layout_tests/port/base.py:
2870         * Scripts/webkitpy/style/main.py:
2871
2872 2010-12-20  Adrienne Walker  <enne@google.com>
2873
2874         Unreviewed. Adding myself to the list of committers.
2875
2876         * webkitpy/common/config/committers.py:
2877
2878 2010-12-20  Mark Rowe  <mrowe@apple.com>
2879
2880         Reviewed by Dan Bernstein.
2881
2882         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2883
2884         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2885         Resources directory.
2886
2887 2010-12-20  Eric Seidel  <eric@webkit.org>
2888
2889         Reviewed by Adam Barth.
2890
2891         commit-queue should include bot id when attaching failure diffs
2892         https://bugs.webkit.org/show_bug.cgi?id=51280
2893
2894         This is a tiny change to include the bot id in the name of the attachment.
2895         Most of this diff is just changing the unit test expectations
2896         now that I hid the comment printing when the comment is None.
2897
2898         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2899         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2900         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2901         * Scripts/webkitpy/tool/mocktool.py:
2902
2903 2010-12-20  Jeff Miller  <jeffm@apple.com>
2904
2905         Reviewed by Dan Bernstein.
2906
2907         Tools/vcbin/midl.exe needs to be rebuilt
2908         https://bugs.webkit.org/show_bug.cgi?id=51347
2909
2910         * vcbin/midl.exe: Rebuilt.
2911
2912 2010-12-20  David Levin  <levin@chromium.org>
2913
2914         Reviewed by Ariya Hidayat.
2915
2916         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2917         https://bugs.webkit.org/show_bug.cgi?id=51343
2918
2919         Follow up from the WebKitTools -> Tools rename.
2920
2921         * Scripts/webkit-tools-completion.sh:
2922
2923 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2924
2925         Reviewed by James Robinson.
2926
2927         new-run-webkit-tests ignores trailing EOL differences in text tests
2928         https://bugs.webkit.org/show_bug.cgi?id=36983
2929
2930         Changed the handling of new-line characters within new-run-webkit-tests
2931         to match old-run-webkit-tests.  Differences in leading and trailing empty
2932         lines in text expectation files are no longer ignored.
2933
2934         * Scripts/webkitpy/layout_tests/port/base.py:
2935         * Scripts/webkitpy/layout_tests/port/test.py:
2936         Added unit tests.  Removed old duplicate unit test entries.
2937         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2938
2939 2010-12-20  David Levin  <levin@chromium.org>
2940
2941         Reviewed by Shinichiro Hamaji.
2942
2943         check-webkit-style should detect function declarations (and trivial functions).
2944         https://bugs.webkit.org/show_bug.cgi?id=51303
2945
2946         * Scripts/webkitpy/style/checkers/cpp.py:
2947         (_FunctionState.begin): Add is_declaration and changed the line count
2948         start to begin at -1 (which will keep the results consistent, since
2949         the starting line number passed in is one less in this change).
2950         (detect_functions): changed function detection to now catch trivial
2951         functions and declarations.
2952         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2953         of the function as this may look at return values (when processing
2954         a declaration).
2955         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2956         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2957         of testing the function detection.
2958         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2959         function.
2960         (FunctionDetectionTest.test_function_declaration_detection): Test a
2961         declaration.
2962         (FunctionDetectionTest.test_non_functions): A test case for a case
2963         that caused the code to fail due to the { being in quotes.
2964         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2965         cases to help catch false alarms for return values.
2966         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2967         we don't get false alarms for member variables either.
2968
2969 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2970
2971         Reviewed by Antonio Gomes.
2972
2973         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2974         https://bugs.webkit.org/show_bug.cgi?id=51319
2975
2976         * CMakeListsEfl.txt:
2977
2978 2010-12-18  Adam Barth  <abarth@webkit.org>
2979
2980         Reviewed by Sam Weinig.
2981
2982         Move WebKitExamplePlugins to Examples
2983         https://bugs.webkit.org/show_bug.cgi?id=51291
2984
2985         * Scripts/webkitpy/common/config/build.py:
2986
2987 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2988
2989         Unreviewed Qt buildfix after r74301.
2990
2991         Rename WebKitTools to Tools
2992         https://bugs.webkit.org/show_bug.cgi?id=49861
2993
2994         * MiniBrowser/DerivedSources.pro:
2995         * MiniBrowser/qt/MiniBrowser.pro:
2996
2997 2010-12-17  Dan Bernstein  <mitz@apple.com>
2998
2999         Reviewed by Simon Fraser.
3000
3001         Rename WebKitTools to Tools
3002         https://bugs.webkit.org/show_bug.cgi?id=49861
3003
3004         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3005         * CodeCoverage/README:
3006         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3007         (WebCore::DumpRenderTree::initializeFonts):
3008         * EWSTools/start-commit-queue.sh:
3009         * EWSTools/start-queue.sh:
3010         * GNUmakefile.am:
3011         * MIDLWrapper/MIDLWrapper.cpp:
3012         (wmain):
3013         * MiniBrowser/qt/MiniBrowser.pro:
3014         * Scripts/build-api-tests:
3015         * Scripts/build-dumprendertree:
3016         * Scripts/build-webkit:
3017         * Scripts/build-webkittestrunner:
3018         * Scripts/generate-coverage-data:
3019         * Scripts/old-run-webkit-tests:
3020         * Scripts/run-api-tests:
3021         * Scripts/run-iexploder-tests:
3022         * Scripts/run-javascriptcore-tests:
3023         * Scripts/run-mangleme-tests:
3024         * Scripts/run-sunspider:
3025         * Scripts/run-webkit-websocketserver:
3026         * Scripts/sunspider-compare-results:
3027         * Scripts/test-webkitperl:
3028         * Scripts/test-webkitpy:
3029         * Scripts/update-iexploder-cssproperties:
3030         * Scripts/update-webkit:
3031         * Scripts/update-webkit-localizable-strings:
3032         * Scripts/webkitdirs.pm:
3033         * Scripts/webkitpy/common/checkout/scm.py:
3034         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3035         * Scripts/webkitpy/common/config/committervalidator.py:
3036         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3037         * Scripts/webkitpy/common/config/ports.py:
3038         * Scripts/webkitpy/common/config/ports_unittest.py:
3039         * Scripts/webkitpy/common/system/logutils_unittest.py:
3040         * Scripts/webkitpy/common/system/ospath_unittest.py:
3041         * Scripts/webkitpy/layout_tests/port/chromium.py:
3042         * Scripts/webkitpy/layout_tests/port/config.py:
3043         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3044         * Scripts/webkitpy/layout_tests/port/http_server.py:
3045         * Scripts/webkitpy/layout_tests/port/test.py:
3046         * Scripts/webkitpy/style/checker.py:
3047         * Scripts/webkitpy/style/checker_unittest.py:
3048         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3049         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3050         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3051         * WebKitTestRunner/DerivedSources.pro:
3052         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3053         (WTR::activateFonts):
3054         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3055         * wx/build/build_utils.py:
3056
3057 2010-12-16  Antonio Gomes  <agomes@rim.com>
3058
3059         Reviewed by Martin Robinson.
3060
3061         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3062         https://bugs.webkit.org/show_bug.cgi?id=51163
3063
3064         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3065         GTK+'s DRT should also reset to UNIX after each test execution.
3066
3067         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3068         (resetDefaultsToConsistentValues):
3069
3070 2010-12-17  David Levin  <levin@chromium.org>
3071
3072         Reviewed by Eric Seidel.
3073
3074         check-webkit-style should understand WTF #include guards
3075         https://bugs.webkit.org/show_bug.cgi?id=44911
3076
3077         * Scripts/webkitpy/style/checkers/cpp.py:
3078         (get_header_guard_cpp_variable): modify to suggest the WTF style
3079         of header guard when appropriate.
3080         (check_for_header_guard): handle multiple return values from
3081         get_header_guard_cpp_variable
3082         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3083         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3084         header style.
3085
3086 2010-12-16  David Levin  <levin@chromium.org>
3087
3088         Reviewed by Eric Seidel.
3089
3090         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3091         https://bugs.webkit.org/show_bug.cgi?id=51210
3092
3093         The error only shows up when using python 2.6 or later.
3094
3095         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3096         the decprecated field error,message with something equivalent.
3097
3098 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3099
3100         Reviewed by Eric Seidel.
3101
3102         Add --exit-after-n-failures/crashes to NRWT
3103         https://bugs.webkit.org/show_bug.cgi?id=51160
3104         
3105         Abort test run (in a similar way to how control-C is handled) when
3106         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3107         that number of unexpected failures/crashes/timeouts.
3108
3109         * Scripts/webkitpy/layout_tests/port/test.py:
3110         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3111         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3112
3113 2010-12-16  David Levin  <levin@chromium.org>
3114
3115         Reviewed by Shinichiro Hamaji.
3116
3117         check-webkit-style unit tests has some duplicate boilerplate code.
3118         https://bugs.webkit.org/show_bug.cgi?id=49519
3119
3120         * Scripts/webkitpy/style/checkers/cpp.py:
3121         (update_include_state): Replaced the "io" parameter with the global
3122         configuration _unit_test_config. This allowed not calling into
3123         functions at a low level and also not plumbing through the injection
3124         information through many levels of code.
3125         (check_for_include_what_you_use): Ditto.
3126         (process_file_data): Added the ability to set up the unit test config
3127         to allow for injection.
3128         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3129         (ErrorCollector.__init__): Added support for having a filter for errors.
3130         (ErrorCollector.__call__): Ditto.
3131         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3132         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3133         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3134         functions in the cpp.py with generic processing and a filter that
3135         indicates what errors should be kept.
3136         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3137         (CppStyleTestBase.perform_language_rules_check): Ditto.
3138         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3139         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3140         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3141         (CppStyleTest.test_multi_line_comments): Added another
3142         error message which applies to the test case.
3143         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3144         to not have config.h, since it is processed as a header file.
3145         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3146         style and indentation in checked code.
3147         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3148         Fixed line number.
3149         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3150         Ditto.
3151
3152 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3153
3154         Unreviewed, rolling out r74136.
3155         http://trac.webkit.org/changeset/74136
3156         https://bugs.webkit.org/show_bug.cgi?id=51135
3157
3158         r74136 breaks chromium canary bots because some tests are not
3159         rebaselined correctly to resolve EOL differences (Requested by
3160         jianli on #webkit).
3161
3162         * Scripts/webkitpy/layout_tests/port/base.py:
3163         * Scripts/webkitpy/layout_tests/port/test.py:
3164         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3165
3166 2010-12-15  Adam Roben  <aroben@apple.com>
3167
3168         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3169         syntax errors
3170
3171         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3172         XML syntax errors in .vcproj/.vsprops files
3173
3174         Reviewed by Dave Levin.
3175
3176         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3177         that should be treated as XML and that should be allowed to contain
3178         carriage returns. (These lists happen to be identical currently.)
3179         (FileType): Added a new XML type.
3180         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3181         Just does a simple file extension check.
3182         (CheckerDispatcher._file_type): Added a case for XML files.
3183         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3184         files (surprise!).
3185         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3186         lines through the carriage checker.
3187
3188         * Scripts/webkitpy/style/checker_unittest.py:
3189         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3190         Added. Checks a few file names to see if carriage returns are allowed
3191         or not.
3192         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3193         other assert_checker_* functions.
3194         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3195         test_*_paths functions.
3196         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3197         test_*_paths functions.
3198         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3199         file from this test case, as vcproj files now have a type.
3200         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3201         Added. Similar to the other should_* functions.
3202         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3203         Added. Checks that carriage returns aren't checked for or stripped for
3204         allowed files.
3205
3206         * Scripts/webkitpy/style/checkers/xml.py: Added.
3207         (XMLChecker.__init__): Simple init method.
3208         (XMLChecker.check): Pass each line through the expat parser, and record
3209         a style error for any errors thrown by the parser.
3210
3211         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3212         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3213         produce a style error.
3214         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3215         error of the given category on the given line.
3216         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3217         checking that the XMLChecker constructor works properly.
3218         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3219         cause a style error (see, e.g., r73887).
3220         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3221         cause a style error (see, e.g., r73773).
3222         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3223         properly.
3224         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3225         tags cause a style error (see, e.g., r72795).
3226         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3227         style error.
3228
3229 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3230
3231         Reviewed by Stephanie Lewis.
3232
3233         https://bugs.webkit.org/show_bug.cgi?id=51117
3234         Add a new leopard test bot
3235         really really commit to trunk this time.
3236
3237         * BuildSlaveSupport/build.webkit.org-config/config.json:
3238
3239 2010-12-15  Sam Weinig  <sam@webkit.org>
3240
3241         Reviewed by Anders Carlsson.
3242
3243         WebKit2: Can't add files to an <input type=file>
3244         https://bugs.webkit.org/show_bug.cgi?id=51087
3245
3246         * MiniBrowser/mac/BrowserWindowController.m:
3247         (runOpenPanel):
3248         (-[BrowserWindowController awakeFromNib]):
3249         Add simple implementation of runOpenPanel callback.
3250
3251         * MiniBrowser/win/BrowserView.cpp:
3252         (BrowserView::create):
3253         * WebKitTestRunner/TestController.cpp:
3254         (WTR::createOtherPage):
3255         (WTR::TestController::initialize):
3256         Stub out runOpenPanel callback. 
3257
3258 2010-12-14  Eric Seidel  <eric@webkit.org>
3259
3260         Reviewed by Adam Barth.
3261
3262         commit-queue should upload failure diffs when tests flake
3263         https://bugs.webkit.org/show_bug.cgi?id=51051
3264
3265         To make this testable I needed to pipe FileSystem down onto tool.
3266         We've wanted it there for a long time anyway.
3267
3268         This patch is kinda a big hack.  But we don't have a nice
3269         way to read results.html files.  I think this will need further
3270         revision before this code actually feels clean.
3271
3272         As part of testing this change, I had to make MockBugzilla.create_bug
3273         actually return an id (like it should) which required updating
3274         a few other unit test results (for the better).
3275
3276         The results_matching_keys change in layouttestresults/rebasline
3277         was an alternate path which I decided not to use in the end, but
3278         I left the change as it seemed an improvement.
3279
3280         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3281         * Scripts/webkitpy/common/net/layouttestresults.py:
3282         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3283         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3284         * Scripts/webkitpy/tool/commands/queues.py:
3285         * Scripts/webkitpy/tool/commands/rebaseline.py:
3286         * Scripts/webkitpy/tool/main.py:
3287         * Scripts/webkitpy/tool/mocktool.py:
3288
3289 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3290
3291         Reviewed by James Robinson.
3292
3293         new-run-webkit-tests ignores trailing EOL differences in text tests
3294         https://bugs.webkit.org/show_bug.cgi?id=36983
3295
3296         Changed the handling of new-line characters within new-run-webkit-tests
3297         to match old-run-webkit-tests.  Differences in leading and trailing empty
3298         lines in text expectation files are no longer ignored.
3299
3300         * Scripts/webkitpy/layout_tests/port/base.py:
3301         * Scripts/webkitpy/layout_tests/port/test.py:
3302         Added unit tests.  Removed old duplicate unit test entries.
3303         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3304
3305 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3306
3307         Reviewed by Adam Barth.
3308
3309         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3310         https://bugs.webkit.org/show_bug.cgi?id=51149
3311
3312         * QueueStatusServer/templates/statusbubble.html:
3313
3314 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3315
3316         Reviewed by Adam Barth.
3317
3318         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3319         https://bugs.webkit.org/show_bug.cgi?id=51125
3320
3321         * QueueStatusServer/templates/statusbubble.html:
3322
3323 2010-12-15  Darin Adler  <darin@apple.com>
3324
3325         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3326
3327 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3328
3329         Unreviewed, rolling out r74117.
3330         http://trac.webkit.org/changeset/74117
3331         https://bugs.webkit.org/show_bug.cgi?id=51113
3332
3333         This broke the GTK1 build. (Requested by mrobinson on
3334         #webkit).
3335
3336         * Scripts/webkitdirs.pm:
3337
3338 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3339
3340         Reviewed by Martin Robinson.
3341
3342         Change generate-forwarding-headers.pl for GTK port usage 
3343         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3344
3345         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3346
3347 2010-12-14  Kent Tamura  <tkent@chromium.org>
3348
3349         Reviewed by Jian Li.
3350
3351         [DRT/Chromium] Remove another unnecessary error message
3352         https://bugs.webkit.org/show_bug.cgi?id=51083
3353
3354         * DumpRenderTree/chromium/WebViewHost.cpp:
3355         (WebViewHost::didInvalidateRect):
3356
3357 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3358
3359         Reviewed by Stephanie Lewis.
3360
3361         Add a new Leopard Debug Test WK2 Bot
3362
3363         * BuildSlaveSupport/build.webkit.org-config/config.json:
3364
3365 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3366
3367         Fix python unittests after http://trac.webkit.org/changeset/74070.
3368
3369         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3370
3371 2010-12-14  Kent Tamura  <tkent@chromium.org>
3372
3373         Reviewed by Jian Li.
3374
3375         [DRT/Chromium] Remove a unnecessary error message
3376         https://bugs.webkit.org/show_bug.cgi?id=51069
3377
3378         * DumpRenderTree/chromium/WebViewHost.cpp:
3379         (WebViewHost::paintInvalidatedRegion):
3380
3381 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3382
3383         Reviewed by Ojan Vafai.
3384
3385         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3386         https://bugs.webkit.org/show_bug.cgi?id=48926
3387
3388         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3389         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3390
3391 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3392
3393         Reviewed by Eric Seidel.
3394
3395         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3396         https://bugs.webkit.org/show_bug.cgi?id=50231
3397
3398         Guard CONFIG+=link_pkgconfig with !symbian.
3399
3400         * DumpRenderTree/qt/DumpRenderTree.pro:
3401         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3402         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3403
3404 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3405
3406         Reviewed by Ojan Vafai.
3407
3408         [new-run-webkit-tests] expectations parsing is slow
3409         https://bugs.webkit.org/show_bug.cgi?id=50635
3410
3411         Avoid expensive iteration of all the tests when checking if a test
3412         file is to be skipped or not.
3413
3414         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3415         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3416         * Scripts/webkitpy/layout_tests/port/test.py:
3417
3418 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3419
3420         Reviewed by Xan Lopez.
3421
3422         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3423         https://bugs.webkit.org/show_bug.cgi?id=27048
3424
3425         Add support in DRT for checking whether an accessibility UI
3426         element is focusable and/or focused. Implemented for GTK.
3427
3428         * DumpRenderTree/AccessibilityUIElement.cpp:
3429         (getIsFocusedCallback): New.
3430         (getIsFocusableCallback): New.
3431         (AccessibilityUIElement::getJSClass): Add the new available
3432         callbacks for isFocused and isFocusable.
3433         * DumpRenderTree/AccessibilityUIElement.h:
3434         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3435         (AccessibilityUIElement::isFocused): New, implemented by checking
3436         whether the related AtkState value is in the object's state set.
3437         (AccessibilityUIElement::isFocusable): Ditto.
3438         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3439         (AccessibilityUIElement::isFocused): New, dummy implementation.
3440         (AccessibilityUIElement::isFocusable): Ditto.
3441         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3442         (AccessibilityUIElement::isFocused): Ditto.
3443         (AccessibilityUIElement::isFocusable): Ditto.
3444
3445 2010-12-14  Eric Seidel  <eric@webkit.org>
3446
3447         Reviewed by Ojan Vafai.
3448
3449         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3450         https://bugs.webkit.org/show_bug.cgi?id=50715
3451
3452         This patch makes webkit-patch print the following:
3453
3454         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3455         Install a 64-bit git for better performance, see:
3456         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3457
3458         I wrote this mostly because I have approximately 8 machines that I use
3459         and making sure each one is using a good Git install seemed folly.
3460         webkit-patch makes a lot of git calls, so using a fast git can shave
3461         several seconds in every invocation.  See the webkit-dev thread for more info.
3462
3463         This message will print twice during 'webkit-patch upload',
3464         once from webkit-patch and once from check-webkit-style.
3465
3466         Unfortunately there is no good way to test this due to how machine-dependent
3467         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3468
3469         * Scripts/webkitpy/common/checkout/scm.py:
3470
3471 2010-12-13  Eric Seidel  <eric@webkit.org>
3472
3473         Reviewed by Adam Barth.
3474
3475         FlakyTestReporter doesn't understand bots running from multiple email addresses
3476         https://bugs.webkit.org/show_bug.cgi?id=50960
3477
3478         This explains at least one of the dupes of:
3479         https://bugs.webkit.org/show_bug.cgi?id=50863
3480         that we saw filed by the commit-queue this morning.
3481         I think the other one was explained by my previous fix to result counting code.
3482
3483         Since this is really hard to test with a unit test, instead I
3484         create a new (possibly useful in the future) command
3485         which given a layout test path will return you
3486         the one bug which our tools would assume it the flaky test bug.
3487         If some other script wants to use bug-for-test we'll
3488         need to extend it with some options like --create-if-missing or similar.
3489
3490         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3491         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3492         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3493         * Scripts/webkitpy/tool/commands/__init__.py:
3494         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3495
3496 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3497
3498         Reviewed by James Robinson.
3499
3500         Add option to build-webkit to not build WebKit2
3501         https://bugs.webkit.org/show_bug.cgi?id=50988
3502         
3503         Add support for a --no-webkit2 option to build-webkit. It seems to save
3504         ~1 minute from clean builds and ~10 seconds from no-op builds.
3505
3506         * Scripts/build-webkit:
3507
3508 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3509
3510         Reviewed by Dave Kilzer.
3511
3512         Update iexploder from 1.3.2 to 1.7.2
3513         Move 1.3.2 into its own subdir
3514         Add 1.7.2 into its own subdir
3515         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3516
3517         * Scripts/run-iexploder-tests:
3518         * Scripts/update-iexploder-cssproperties:
3519         * iExploder/CHANGELOG.txt: Removed.
3520         * iExploder/LICENSE.txt: Removed.
3521         * iExploder/README.txt: Removed.
3522         * iExploder/htdocs: Removed.
3523         * iExploder/iexploder-1.3.2: Added.
3524         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3525         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3526         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3527         * iExploder/iexploder-1.3.2/htdocs: Added.
3528         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3529         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3530         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3531         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3532         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3533         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3534         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3535         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3536         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3537         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3538         * iExploder/iexploder-1.3.2/tools: Added.
3539         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3540         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3541         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3542         * iExploder/iexploder-1.7.2: Added.
3543         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3544         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3545         * iExploder/iexploder-1.7.2/README.txt: Added.
3546         * iExploder/iexploder-1.7.2/output: Added.
3547         * iExploder/iexploder-1.7.2/src: Added.
3548         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3549         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3550         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3551         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3552         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3553         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3554         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3555         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3556         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3557         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3558         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3559         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3560         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3561         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3562         * iExploder/iexploder-1.7.2/src/css-values: Added.
3563         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3564         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3565         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3566         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3567         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3568         * iExploder/iexploder-1.7.2/src/headers: Added.
3569         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3570         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3571         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3572         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3573         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3574         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3575         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3576         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3577         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3578         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3579         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3580         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3581         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3582         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3583         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3584         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3585         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3586         * iExploder/iexploder-1.7.2/src/html-values: Added.
3587         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3588         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3589         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3590         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3591         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3592         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3593         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3594         * iExploder/iexploder-1.7.2/src/index.html: Added.
3595         * iExploder/iexploder-1.7.2/src/media: Added.
3596         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3597         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3598         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3599         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3600         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3601         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3602         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3603         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3604         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3605         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3606         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3607         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3608         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3609         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3610         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3611         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3612         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3613         * iExploder/iexploder-1.7.2/src/protocols: Added.
3614         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3615         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3616         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3617         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3618         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3619         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3620         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3621         * iExploder/iexploder-1.7.2/testcases: Added.
3622         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3623         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3624         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3625         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3626         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3627         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3628         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3629         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3630         * iExploder/iexploder-1.7.2/tools: Added.
3631         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3632         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3633         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3634         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3635         * iExploder/tools: Removed.
3636
3637 2010-12-13  Sam Weinig  <sam@webkit.org>
3638
3639         Reviewed by Anders Carlsson.
3640
3641         Remove associated page concept from WKView constructor
3642         https://bugs.webkit.org/show_bug.cgi?id=50983
3643
3644         Step 1: Remove associate page constructors from WKView and make
3645         all views use the shared namespace for the context.
3646
3647         * TestWebKitAPI/PlatformWebView.h:
3648         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3649         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3650         * WebKitTestRunner/PlatformWebView.h:
3651         * WebKitTestRunner/TestController.cpp:
3652         (WTR::createOtherPage):
3653         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3654         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3655         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3656
3657 2010-12-13  Sam Weinig  <sam@webkit.org>
3658
3659         Reviewed by Anders Carlsson.
3660
3661         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3662         https://bugs.webkit.org/show_bug.cgi?id=50898
3663
3664         * MiniBrowser/mac/AppDelegate.h:
3665         * MiniBrowser/mac/AppDelegate.m:
3666         * MiniBrowser/mac/BrowserWindowController.h:
3667         * MiniBrowser/mac/BrowserWindowController.m:
3668         * MiniBrowser/win/BrowserView.cpp:
3669         Convert MiniBrowser to not use PageNamespaces.
3670
3671         * TestWebKitAPI/PlatformWebView.h:
3672         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3673         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3674         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3675         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3676         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3677         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3678         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3679         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3680         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3681         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3682         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3683         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3684         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3685         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3686         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3687         Convert TestWebKitAPI to not use PageNamespaces.
3688
3689         * WebKitTestRunner/PlatformWebView.h:
3690         * WebKitTestRunner/TestController.cpp:
3691         * WebKitTestRunner/TestController.h:
3692         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3693         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3694         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3695         Convert WebKitTestRunner to not use PageNamespaces.
3696
3697 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3698
3699         Reviewed by Eric Seidel.
3700
3701         webkit-patch rollout should be able to do multi-revision rollouts
3702         https://bugs.webkit.org/show_bug.cgi?id=33336
3703
3704         Make it possible to pass more than one revision to webkit-patch.
3705
3706         * Scripts/webkitpy/common/checkout/api.py:
3707         * Scripts/webkitpy/common/checkout/changelog.py:
3708         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3709         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3710         * Scripts/webkitpy/tool/commands/download.py:
3711         * Scripts/webkitpy/tool/commands/download_unittest.py:
3712         * Scripts/webkitpy/tool/mocktool.py:
3713         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3714         * Scripts/webkitpy/tool/steps/revertrevision.py:
3715
3716 2010-12-13  Eric Seidel  <eric@webkit.org>
3717
3718         Unreviewed.
3719
3720         Teach webkit-patch how to search bugzilla
3721         https://bugs.webkit.org/show_bug.cgi?id=50500
3722
3723         webkit-patch bug-search fails when there is only one result.
3724         Turns out we needed a bit more logic in our result count parsing code.
3725
3726         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3727         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3728
3729 2010-12-13  Antti Koivisto  <antti@apple.com>
3730
3731         Reviewed by Alexey Proskuryakov.
3732
3733         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3734         https://bugs.webkit.org/show_bug.cgi?id=50758
3735
3736         * DumpRenderTree/LayoutTestController.cpp:
3737         (setSerializeHTTPLoadsCallback):
3738         (LayoutTestController::staticFunctions):
3739         * DumpRenderTree/LayoutTestController.h:
3740