387c520aba19f2465392b5b6d5a7e4ad9f56308e
[WebKit.git] / Tools / ChangeLog
1 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Daniel Bates.
4
5         Add WebKit2 bot to list of expected builders in Python regression test results.
6         https://bugs.webkit.org/show_bug.cgi?id=53905
7
8         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
9
10 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
11
12         Reviewed by Ryosuke Niwa.
13
14         Update test expectations for new core builder
15         https://bugs.webkit.org/show_bug.cgi?id=53904
16
17         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
18
19 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
20
21         Reviewed by David Levin.
22
23         Add WebKit2 test bot to core builders
24         https://bugs.webkit.org/show_bug.cgi?id=53901
25
26         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
27
28 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
29
30         Another unreviewed Chromium build fix.
31
32         * DumpRenderTree/chromium/LayoutTestController.cpp:
33         (LayoutTestController::pathToLocalResource):
34
35 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
36
37         Unreviewed Chromium build fix.
38
39         * DumpRenderTree/chromium/LayoutTestController.cpp:
40         (LayoutTestController::pathToLocalResource):
41
42 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
43
44         Reviewed by Darin Adler.
45
46         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
47         https://bugs.webkit.org/show_bug.cgi?id=52867
48
49         * DumpRenderTree/chromium/ImageDiff.cpp:
50         (Image::craeteFromStdin): Call adoptArrayPtr.
51
52 2011-02-06  James Kozianski  <koz@chromium.org>
53
54         Reviewed by Ojan Vafai.
55
56         Add classes for representing test outputs.
57         https://bugs.webkit.org/show_bug.cgi?id=52136
58
59         These classes will make it easier to write scripts that deal with test
60         outputs such as rebaselining and deduping scripts. The intent is that
61         eventually we will be have buildbot return TestOutputs for a
62         particular build which can be compared with TestOutputs derived from a
63         local LayoutTests directory.
64
65         * Scripts/webkitpy/common/net/testoutput.py: Added.
66         * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
67         * Scripts/webkitpy/common/net/testoutputset.py: Added.
68         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
69         * Scripts/webkitpy/common/system/zip_mock.py: Added.
70
71 2011-02-06  Robert Hogan  <robert@webkit.org>
72
73         Reviewed by Andreas Kling.
74
75         [Qt] Clear page's groupName even when not in DRT
76         https://bugs.webkit.org/show_bug.cgi?id=53874
77
78         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
79         (WebCore::DumpRenderTree::windowCloseRequested):
80
81 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
82
83         Reviewed by Andreas Kling.
84
85         [CMake] Add dependencies for Visual Studio projects
86         https://bugs.webkit.org/show_bug.cgi?id=53773
87
88         Add a WebKit dependecy to WinCELauncher, so CMake can 
89         generate the correct build order for the solution.
90
91         * CMakeListsWinCE.txt:
92
93 2011-02-06  Andreas Kling  <kling@webkit.org>
94
95         Reviewed by Antonio Gomes.
96
97         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
98         https://bugs.webkit.org/show_bug.cgi?id=53869
99
100         * MiniBrowser/qt/BrowserView.cpp:
101         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
102         * MiniBrowser/qt/BrowserWindow.cpp:
103         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
104         * MiniBrowser/qt/BrowserWindow.h:
105
106 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
107
108         Reviewed by Dan Bernstein.
109
110         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
111         https://bugs.webkit.org/show_bug.cgi?id=42690
112         <rdar://problem/8213851>
113
114         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
115         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
116         (WTR::InjectedBundlePage::willSendRequestForFrame):
117         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
118         (WTR::LayoutTestController::LayoutTestController):
119         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
120         (WTR::LayoutTestController::willSendRequestReturnsNull):
121         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
122
123 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
124
125         Unreviewed, rolling out r77720.
126         http://trac.webkit.org/changeset/77720
127         https://bugs.webkit.org/show_bug.cgi?id=53854
128
129         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
130         #webkit).
131
132         * Scripts/webkitpy/common/system/executive.py:
133
134 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
135
136         Unreviewed, rolling out r77725.
137         http://trac.webkit.org/changeset/77725
138         https://bugs.webkit.org/show_bug.cgi?id=53844
139
140         It broke Qt minimal build (Requested by Ossy_ on #webkit).
141
142         * QtTestBrowser/launcherwindow.cpp:
143         (LauncherWindow::createChrome):
144         * QtTestBrowser/launcherwindow.h:
145         (WindowOptions::WindowOptions):
146         * QtTestBrowser/main.cpp:
147         (LauncherApplication::handleUserOptions):
148
149 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
150
151         Reviewed by Adam Barth.
152
153         [GTK] plugins/plugin-document-back-forward.html fails
154         https://bugs.webkit.org/show_bug.cgi?id=53833
155
156         Add the new "alert on load" functionality for the Unix version of the
157         test plugin. This functionality was originally introduced in r77706.
158
159         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
160         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
161
162 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
163
164         Reviewed by Andreas Kling.
165
166         Local Storage settings can be enable/disable from "Develop" menu
167         https://bugs.webkit.org/show_bug.cgi?id=52296
168
169         * QtTestBrowser/launcherwindow.cpp:
170         (LauncherWindow::createChrome):
171         (LauncherWindow::toggleLocalStorage):
172         (LauncherWindow::toggleOfflineStorageDatabase):
173         (LauncherWindow::toggleOfflineWebApplicationCache):
174         (LauncherWindow::setOfflineStorageDefaultQuota):
175         * QtTestBrowser/launcherwindow.h:
176         (WindowOptions::WindowOptions):
177         * QtTestBrowser/main.cpp:
178         (LauncherApplication::handleUserOptions):
179
180 2011-02-04  Tony Chang  <tony@chromium.org>
181
182         Reviewed by Eric Seidel.
183
184         get test-webkitpy running on win32 python
185         https://bugs.webkit.org/show_bug.cgi?id=53822
186
187         The test harness crashes with a WindowsError because it can't find
188         'svn' when using subprocess.Popen.  This gets us past the error
189         so we can see the failing tests on the Chromium Win Release Tests
190         bot.
191
192         * Scripts/webkitpy/common/system/executive.py:
193
194 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
195
196         Reviewed by Gustavo Noronha Silva.
197
198         [GTK] fast/events/pagehide-timeout.html fails
199         https://bugs.webkit.org/show_bug.cgi?id=53771
200
201         Add knowledge of the document browser cache model the DRT. When resetting
202         WebKit settings to consistent values between tests, default to the document
203         browser cache model.
204
205         * DumpRenderTree/gtk/DumpRenderTree.cpp:
206         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
207         cache model between tests.
208         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
209         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
210         document browser cache model.
211
212 2011-02-04  Adam Barth  <abarth@webkit.org>
213
214         Reviewed by Eric Seidel.
215
216         PluginDocuments don't create widgets for plugins on back/forward
217         https://bugs.webkit.org/show_bug.cgi?id=53474
218
219         Teach the test plugin how to call alert on load.
220
221         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
222         (NPP_New):
223
224 2011-02-04  Adam Roben  <aroben@apple.com>
225
226         Add a test case for encode/decode of FormData/FormDataElement
227
228         If the fix made in r77401 is broken, this new test will crash.
229
230         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
231
232         Reviewed by Sam Weinig.
233
234         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
235         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
236
237         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
238         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
239         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
240         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
241         form, an return the session state data.
242         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
243         and restore it into another WKPage.
244
245         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
246
247         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
248         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
249         * TestWebKitAPI/win/copy-resources.cmd:
250         Added new files.
251
252 2011-02-04  Adam Roben  <aroben@apple.com>
253
254         Move code to run JavaScript tests into its own files
255
256         This will allow other tests to use this mechanism.
257
258         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
259         world
260
261         Reviewed by Sam Weinig.
262
263         * TestWebKitAPI/JavaScriptTest.cpp: Added.
264         * TestWebKitAPI/JavaScriptTest.h: Added.
265         Moved code here...
266
267         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
268
269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
270         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
271         Added the new files.
272
273 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
274
275         Reviewed by Mihai Parparita.
276
277         merge test expectations for chromium, chromium-gpu. The
278         chromium-gpu port will no longer maintain its own
279         test expectations file.
280
281         Also add in a graphics_type() call on the port object to
282         determine what graphics type to use in the test configuration,
283         and log the configuration as a config setting.
284
285         https://bugs.webkit.org/show_bug.cgi?id=53562
286
287         * Scripts/webkitpy/layout_tests/port/base.py:
288         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
289         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
290         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
291
292 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
293
294         Reviewed by Pavel Feldman.
295
296         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
297         https://bugs.webkit.org/show_bug.cgi?id=53781
298
299         * Scripts/check-inspector-strings:
300
301 2011-02-04  Adam Roben  <aroben@apple.com>
302
303         Include the crashing function in the link to a crash log on Mac
304
305         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
306         function that crashed on Mac
307
308         Reviewed by David Kilzer.
309
310         * Scripts/old-run-webkit-tests:
311         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
312         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
313         the crash log.
314
315 2011-02-04  Adam Roben  <aroben@apple.com>
316
317         Link to Mac crash logs from results.html
318
319         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
320         results.html
321
322         Reviewed by David Kilzer.
323
324         * Scripts/old-run-webkit-tests:
325         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
326         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
327
328 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
329
330         Reviewed by Dan Bernstein.
331
332         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
333         https://bugs.webkit.org/show_bug.cgi?id=52897
334         <rdar://problem/8898294>
335
336         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
337         (WTR::InjectedBundlePage::InjectedBundlePage):
338         (WTR::InjectedBundlePage::willSendRequestForFrame):
339         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
340
341 2011-02-03  Ivan Krstić  <ike@apple.com>
342
343         Unreviewed.
344
345         Adding myself to committers.py.
346
347         * Scripts/webkitpy/common/config/committers.py:
348
349 2011-02-03  James Kozianski  <koz@chromium.org>
350
351         Reviewed by Dimitri Glazkov.
352
353         Add navigator.registerProtocolHandler behind a flag.
354         https://bugs.webkit.org/show_bug.cgi?id=52609
355
356         * Scripts/build-webkit:
357
358 2011-02-03  Hayato Ito  <hayato@chromium.org>
359
360         Reviewed by Eric Seidel.
361
362         [NRWT] Remove TestArgs class, which is wrongly used.
363
364         https://bugs.webkit.org/show_bug.cgi?id=53063
365
366         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
367         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
368         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
369         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
370         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
371         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
372
373 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
374
375         Reviewed by Kenneth Russell.
376
377         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
378         https://bugs.webkit.org/show_bug.cgi?id=53714
379
380         * Scripts/build-webkit: change --3d-canvas build option
381           to set ENABLE_WEBGL
382
383 2011-02-03  Hayato Ito  <hayato@chromium.org>
384
385         Reviewed by Tony Chang.
386
387         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
388         move _run_single_test() and _process_output() functions from
389         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
390
391         This is clean up and acts as a preparation for elimination of test_types/*
392         classes. These classes will move to the single_test_runner module introduced
393         in this patch.
394
395         https://bugs.webkit.org/show_bug.cgi?id=53004
396
397         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
398         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
399         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
400         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
401         * Scripts/webkitpy/layout_tests/port/base.py:
402         * Scripts/webkitpy/layout_tests/port/chromium.py:
403         * Scripts/webkitpy/layout_tests/port/dryrun.py:
404         * Scripts/webkitpy/layout_tests/port/test.py:
405         * Scripts/webkitpy/layout_tests/port/webkit.py:
406         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
407         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
408         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
409
410 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
411
412         Unreviewed, build fix.
413
414         Delete a line that was accidentally missed in r77586; without it
415         there is still a race between the two threads.
416
417         https://bugs.webkit.org/show_bug.cgi?id=51572
418
419         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
420
421 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
422
423         Reviewed by Tony Chang.
424
425         nrwt: handle "broken pipe" notifications from DRT more cleanly.
426
427         https://bugs.webkit.org/show_bug.cgi?id=52927
428
429         * Scripts/webkitpy/layout_tests/port/server_process.py:
430         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
431
432 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
433
434         Reviewed by Kenneth Russell.
435
436         Update, resubmit change to bug 51572. I think the race that was
437         fixed in r76703 caused the hang that caused us to roll this
438         patch out before, so I'd like to try again.
439
440         https://bugs.webkit.org/show_bug.cgi?id=51572
441
442         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
443         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
444
445 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
446
447         Unreviewed.
448
449         Adding myself to committers.py.
450
451         * Scripts/webkitpy/common/config/committers.py:
452
453 2011-02-03  Adam Roben  <aroben@apple.com>
454
455         Include the crashing function in the link to a crash log
456
457         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
458         function that crashed
459
460         Reviewed by David Kilzer.
461
462         * Scripts/old-run-webkit-tests:
463         (crashLocation): Added. Returns the location of the crash.
464         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
465         could be determined.
466
467 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
468
469         Unreviewed, build fix.
470
471         Actually make the changes suggested by Mihai in his review
472         of bug 53720 :(
473
474         https://bugs.webkit.org/show_bug.cgi?id=53720
475
476         * Scripts/webkitpy/layout_tests/port/test_files.py:
477         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
478
479 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
480
481         Reviewed by Mihai Parparita.
482
483         new-run-webkit-tests: Fix bug introduced in r77434 that was
484         causing us to run the canvas GPU tests on the Mac GPU port. This
485         bug revealed that we were not setting the port.name() field
486         properly in many cases, so I've cleaned up all of that code, and
487         removed a few comments about "version-specific" GPU ports that
488         don't exist and just confused things.
489
490         Testing also revealed that port.abspath_for_test() wasn't
491         normalizing paths on Windows properly, so I fixed that as well.
492
493         https://bugs.webkit.org/show_bug.cgi?id=53719
494
495         * Scripts/webkitpy/layout_tests/port/base.py:
496         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
497         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
498
499 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
500
501         Reviewed by Mihai Parparita.
502
503         new-run-webkit-tests: fix normalization of paths on windows when gathering files
504
505         r77434 introduced a bug that was causing the test expectations
506         for the GPU ports to not be treated properly. It turns out that
507         when we gathered the list of test files on Windows, we would
508         return paths of the form "c:\LayoutTests/fast/canvas", and the
509         mixture of backslashes and forward slashes was confusing things.
510
511         This patch normalizes all of the filenames returned from
512         test_files.find(), and adds better tests for this (fixing a
513         couple of other bugs found in the meantime).
514
515         https://bugs.webkit.org/show_bug.cgi?id=53720
516
517         * Scripts/webkitpy/layout_tests/port/test.py:
518         * Scripts/webkitpy/layout_tests/port/test_files.py:
519         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
520
521 2011-02-03  Adam Roben  <aroben@apple.com>
522
523         Add links to Windows crash logs in results.html
524
525         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
526         results.html
527
528         Reviewed by David Kilzer.
529
530         * Scripts/old-run-webkit-tests:
531         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
532         createDebuggerCommandFile).
533         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
534         tool has exited.
535         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
536         it into the test results directory tree. Only implemented for Cygwin currently.
537         (findNewestFileMatchingGlob): Added. Does what it says.
538         (htmlForResultsSection): Only link to files that exist.
539         (linksForErrorTest): Add a link to the crash log.
540         (deleteExpectedAndActualResults): Delete any old crash log for this test.
541         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
542         hardcoding it here.
543
544 2011-02-03  Adam Roben  <aroben@apple.com>
545
546         Tell the debugger the path to the WebKit source tree when saving a crash log
547
548         This allows the debugger to include the crashing line of code in the log.
549
550         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
551         of code
552
553         Reviewed by Sam Weinig.
554
555         * Scripts/old-run-webkit-tests:
556         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
557         file and returns the path to that file. The commands we pass came from
558         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
559         WebKit source code lives.
560         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
561         line using -c, save them to a file and specify the path to that file using -cf. This works
562         around what is presumably a bug in Windows's command line parsing, where having multiple
563         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
564         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
565         together to make them easier to modify in the future.
566
567 2011-02-02  Sam Weinig  <sam@webkit.org>
568
569         Reviewed by Anders Carlsson.
570
571         Add notification of the end of a rubber band.
572         <rdar://problem/8940648>
573
574         * MiniBrowser/mac/BrowserWindowController.m:
575         (-[BrowserWindowController awakeFromNib]):
576         * WebKitTestRunner/TestController.cpp:
577         (WTR::TestController::createOtherPage):
578         (WTR::TestController::initialize):
579         Stub out the new WKUIClient function.
580
581 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
582
583         Unreviewed.
584
585         Adding myself to committers.py.
586
587         * Scripts/webkitpy/common/config/committers.py:
588
589 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
590
591         Reviewed by Csaba Osztrogonác.
592
593         [Qt][WK2] MiniBrowser's window size should be 800x600
594         https://bugs.webkit.org/show_bug.cgi?id=53670
595
596         Make layout test failure debugging easier.
597         * MiniBrowser/qt/BrowserWindow.cpp:
598         (BrowserWindow::BrowserWindow):
599
600 2011-02-02  Andy Estes  <aestes@apple.com>
601
602         Reviewed by Mark Rowe.
603
604         'update-webkit' should handle OpenSource and Internal using different
605         VCSs.
606
607         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
608         Internal directory.
609
610 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
611
612         Reviewed by Mihai Parparita.
613
614         new-run-webkit-tests: hardcode the directories to scan for tests
615         for GPU bots instead of SKIPping them. See bug 53562 for some
616         context, but we will now hard-code the list of directories to
617         use by default instead of skipping over directories in the
618         expectations file. We do this so that we will be able to merge
619         the expectations files without getting conflicting SKIP
620         directives. Note that this change will reduce the # of tests
621         being run on the Mac GPU bots, because we're accidentally
622         including some today.
623
624         https://bugs.webkit.org/show_bug.cgi?id=53631
625
626         * Scripts/webkitpy/layout_tests/port/base.py:
627         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
628         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
629
630 2011-02-02  Sam Weinig  <sam@webkit.org>
631
632         Reviewed by Beth Dakin.
633
634         Add ChromeClient function to paint custom overhang areas.
635         https://bugs.webkit.org/show_bug.cgi?id=53639
636
637         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
638         (WTR::InjectedBundlePage::InjectedBundlePage):
639         Stub out new callback.
640
641 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
642
643         Reviewed by Tony Chang.
644
645         new-run-webkit-tests: support chromium code paths in mock_drt
646
647         https://bugs.webkit.org/show_bug.cgi?id=53471
648
649         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
650         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
651
652 2011-02-02  Adam Klein  <adamk@chromium.org>
653
654         Reviewed by Tony Chang.
655
656         Update new-run-webkit-tests --chromium to put output under Source/...
657         https://bugs.webkit.org/show_bug.cgi?id=53612
658
659         * BuildSlaveSupport/test-result-archive:
660         * Scripts/webkitpy/layout_tests/port/chromium.py:
661
662 2011-01-28  Tony Chang  <tony@chromium.org>
663
664         Reviewed by Eric Seidel.
665
666         [chromium] remove --use-test-shell from NRWT
667         https://bugs.webkit.org/show_bug.cgi?id=53346
668
669         I've already started removing some of the bindings like eventSender so
670         this already doesn't work isn't useful.  Also updated some comments to
671         refer to DRT instead of test_shell.
672
673         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
674         * Scripts/webkitpy/layout_tests/port/chromium.py:
675         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
676         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
677         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
678         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
679         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
680         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
681
682 2011-02-02  Steve Lacey  <sjl@chromium.org>
683
684         Reviewed by Eric Carlson.
685
686         Implement basic media statistics on media elements.
687         https://bugs.webkit.org/show_bug.cgi?id=53322
688
689         * Scripts/build-webkit:
690
691 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
692
693         [wx] Build fixes for wxWebKit.
694
695         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
696         (LayoutTestController::setSerializeHTTPLoads):
697         * wx/browser/wscript:
698         * wx/build/build_utils.py:
699         * wx/build/settings.py:
700
701 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
702
703         Reviewed by Mihai Parparita.
704
705         new-run-webkit-tests: stop skipping so many tests
706
707         r77163 introduced a regression where we weren't resetting test
708         expectations properly and were skipping too many tests as a
709         result. This patch fixes that and adds a test for it.
710
711         https://bugs.webkit.org/show_bug.cgi?id=53551
712
713         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
714         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
715
716 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
717
718         Reviewed by Tony Chang.
719
720         new-run-webkit-tests: add first stub of test_runner2. This
721         will add support for the 'inline', 'threads', and 'processes'
722         flags to --worker-model, but for now the implementatios just
723         fall back on the old ones.
724
725         https://bugs.webkit.org/show_bug.cgi?id=53157
726
727         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
728         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
729
730 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
731
732         Reviewed by James Robinson.
733
734         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
735         https://bugs.webkit.org/show_bug.cgi?id=53522
736
737         * Scripts/run-chromium-webkit-unit-tests:
738
739 2011-02-01  Adam Barth  <abarth@webkit.org>
740
741         Reviewed by Mihai Parparita.
742
743         Using Control-C to cancel webkit-patch or other python tools causes
744         unpleasant traceback console spew
745         https://bugs.webkit.org/show_bug.cgi?id=53462
746
747         Catch the exception and don't print the stack trace.
748
749         * Scripts/webkit-patch:
750
751 2011-02-01  Scott Cameron  <sccameron@rim.com>
752
753         Reviewed by Daniel Bates.
754
755         Use Windows format for MinGW HTTPD path.
756         https://bugs.webkit.org/show_bug.cgi?id=53503
757
758         * Scripts/webkitperl/httpd.pm:
759           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
760             so that we don't have to escape the space characters in the path. Also,
761             changed path to Windows-style path and removed FIXME comment.
762
763 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
764
765         Reviewed by Andreas Kling.
766
767         [Qt][WK2] Add a way to use shared process model in MiniBrowser
768         https://bugs.webkit.org/show_bug.cgi?id=53090
769
770         * MiniBrowser/qt/BrowserView.cpp:
771         (BrowserView::BrowserView): Removed the m_context member.
772         From now the context is guaranteed to be non-null and we
773         don't need to store that in the object.
774         * MiniBrowser/qt/BrowserView.h:
775         * MiniBrowser/qt/BrowserWindow.cpp:
776         Added static bool to determine that new windows need to be
777         created with their own context or not. Use the same context
778         and web process by default to be inilne with the other ports.
779         (BrowserWindow::BrowserWindow):
780         (BrowserWindow::newWindow):
781         * MiniBrowser/qt/BrowserWindow.h:
782         * MiniBrowser/qt/main.cpp:
783         (main): Added command line switch to be able to use the
784         non-shared process model. Simplify the handling of the command line
785         switches a little bit.
786
787 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
788
789         Reviewed by Andreas Kling.
790
791         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
792         https://bugs.webkit.org/show_bug.cgi?id=53491
793
794         * MiniBrowser/qt/BrowserWindow.cpp:
795         (BrowserWindow::BrowserWindow):
796         (BrowserWindow::toggleFullScreenMode):
797         * MiniBrowser/qt/BrowserWindow.h:
798
799 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
800
801         Reviewed by Andreas Kling.
802
803         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
804         https://bugs.webkit.org/show_bug.cgi?id=53489
805
806         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
807         to Settings menu.
808
809         * MiniBrowser/qt/BrowserWindow.cpp:
810         (BrowserWindow::BrowserWindow):
811         (BrowserWindow::toggleFrameFlattening):
812         (BrowserWindow::toggleDisableJavaScript):
813         (BrowserWindow::toggleAutoLoadImages):
814         * MiniBrowser/qt/BrowserWindow.h:
815
816 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
817
818         Reviewed by Tony Chang.
819
820         [Chromium] Switch chromium-mac to use ChromiumDriver
821         https://bugs.webkit.org/show_bug.cgi?id=53461
822         
823         For the sake of consistency with the other Chromium platforms (and so
824         that chromium-mac picks up special flags like --enable-hardware-gpu),
825         switch chromium-mac from the WebKitDriver to ChromiumDriver.
826
827         * Scripts/webkitpy/layout_tests/port/chromium.py:
828
829 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
830
831         Reviewed by Mihai Parparita.
832
833         The current modifier parsing code in test_expectations is
834         fragile and hard-coded, so it's not easy to understand the logic
835         or easily add new types of modifiers (like GPU vs. CPU testing
836         for graphics tests, or 32-bit vs. 64-bit differences).
837
838         This is the first of two patches that will add in more generic
839         support and then eliminate the GPU-specific test expectations
840         files for Chromium.
841
842         This patch adds two standalone objects for handling modifiers. The
843         rules for interpreting modifiers, precedence, and conflicts are
844         given in the docstring to the ModifierMatcher class, which
845         returns ModifierMatchResult objects.
846         
847         This patch also adds routines to the Port interface and a
848         default set of values in the base object, in order to obtain the
849         values needed on a given test run. These values are then passed
850         to the expectation parser. This also allows us to clean up the
851         logic used to lint all of the different configurations in a
852         single test_expectations.txt file.
853
854         The next patch will merge in the separate GPU expectations file.
855
856         https://bugs.webkit.org/show_bug.cgi?id=51222
857
858         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
859         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
860         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
861         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
862         * Scripts/webkitpy/layout_tests/port/base.py:
863         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
864         * Scripts/webkitpy/layout_tests/port/chromium.py:
865         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
866         * Scripts/webkitpy/layout_tests/port/test.py:
867         * Scripts/webkitpy/layout_tests/port/webkit.py:
868         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
869         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
870         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
871         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
872         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
873
874 2011-01-31  Scott Cameron  <sccameron@rim.com>
875
876         Reviewed by Daniel Bates.
877
878         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
879         https://bugs.webkit.org/show_bug.cgi?id=50036
880
881         This will add an Apache2.2 configuration file and modifies scripts to allow
882         running an httpd server in an MSYS environment.
883
884         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
885         in order to allow for simple installation/execution.  Simply install the latest
886         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
887         be able to execute run-webkit-httpd.
888         
889
890         * Scripts/run-webkit-httpd:
891         * Scripts/webkitperl/httpd.pm:
892
893 2011-01-31  Tony Chang  <tony@chromium.org>
894
895         Reviewed by Eric Seidel.
896
897         mac DRT should report RTL scroll offset relative to top right corner
898         https://bugs.webkit.org/show_bug.cgi?id=53324
899
900         * DumpRenderTree/mac/DumpRenderTree.mm:
901         (dumpFrameScrollPosition):
902
903 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
904
905         Reviewed by Andreas Kling.
906
907         [Qt] Add Take Screen Shot action to MiniBrowser
908         https://bugs.webkit.org/show_bug.cgi?id=53422
909
910         Add Take Screen Shot action to MiniBrowser's view menu.
911
912         * MiniBrowser/qt/BrowserWindow.cpp:
913         (BrowserWindow::BrowserWindow):
914         (BrowserWindow::screenshot):
915         * MiniBrowser/qt/BrowserWindow.h:
916
917 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
918
919         Reviewed by Xan Lopez.
920
921         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
922         https://bugs.webkit.org/show_bug.cgi?id=53379
923
924         Remove left over #ifdef's. I thought all of the conditional code
925         had been freed from the condition, but I forgot to check DRT.
926
927         * DumpRenderTree/gtk/DumpRenderTree.cpp:
928         (resetDefaultsToConsistentValues):
929         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
930         (LayoutTestController::setAlwaysAcceptCookies):
931
932 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
933
934         Unreviewed, build fix.
935
936         Fix regression introduced in r77093 - path.rsplit() doesn't
937         take keyword arguments.
938
939         https://bugs.webkit.org/show_bug.cgi?id=53326
940
941         * Scripts/webkitpy/common/system/filesystem_mock.py:
942
943 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
944
945         Reviewed by Mihai Parparita.
946
947         Add more unit tests for rebaseline-chromium-webkit-tests. This
948         change involves restructuring a bunch of r-c-w-t code to make it
949         more testable as well. We also add wrapper classes for handling
950         testing zip files and fetching URLs.
951
952         https://bugs.webkit.org/show_bug.cgi?id=53040
953
954         * Scripts/webkitpy/common/system/urlfetcher.py:
955         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
956         * Scripts/webkitpy/common/system/zipfileset_mock.py:
957         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
958         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
959         * Scripts/webkitpy/tool/mocktool.py:
960
961 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
962
963         Reviewed by Eric Seidel.
964
965         Clean up of the filesystem-related modules used in webkitpy.
966         I've added relpath() to the filesystem interface, modified
967         ospath.relpath() so that it could work with the filesystem
968         interface, and modified the fileset* routines to use the
969         filesystem interface consistently.
970
971         This patch also adds a close() routine to the fileset routines
972         to indicate that the caller is done with the fileset. This
973         allows zipfileset to clean up after itself when it creates
974         tempfiles to store downloads.
975
976         https://bugs.webkit.org/show_bug.cgi?id=53326
977
978         * Scripts/webkitpy/common/system/directoryfileset.py:
979         * Scripts/webkitpy/common/system/fileset.py:
980         * Scripts/webkitpy/common/system/filesystem.py:
981         * Scripts/webkitpy/common/system/filesystem_mock.py:
982         * Scripts/webkitpy/common/system/filesystem_unittest.py:
983         * Scripts/webkitpy/common/system/ospath.py:
984         * Scripts/webkitpy/common/system/zipfileset.py:
985         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
986
987 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
988
989         Reviewed by Csaba Osztrogonác.
990
991         [Qt][WK2]REGRESSION (r76991): Fix build errors
992         https://bugs.webkit.org/show_bug.cgi?id=53400
993
994         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
995         and remove WebKit2Prefix.h from the build.
996         * MiniBrowser/qt/MiniBrowser.pro:
997
998 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
999
1000         Unreviewed.
1001
1002         [Qt][WK2] Buildfix.
1003
1004         * MiniBrowser/qt/MiniBrowser.pro:
1005
1006 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
1007
1008         Reviewed by Adam Roben.
1009         
1010         define NOMINMAX when building ImageDiff, as we do elsewhere.
1011
1012         Add various clampToInt() methods to MathExtras.h
1013         https://bugs.webkit.org/show_bug.cgi?id=52910
1014
1015         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1016
1017 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
1018
1019         Reviewed by Darin Adler.
1020
1021         WebKitTestRunner needs layoutTestController.setPOSIXLocale
1022         https://bugs.webkit.org/show_bug.cgi?id=42682
1023
1024         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1025         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1026         (WTR::InjectedBundle::resetLocalSettings):
1027         (WTR::InjectedBundle::didReceiveMessage):
1028         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1029         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1030         (WTR::LayoutTestController::setPOSIXLocale):
1031         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1032
1033 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1034  
1035          Reviewed by Mihai Parparita.
1036  
1037          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
1038  
1039          This patch re-enables this test and changes it to
1040          handle all of the mac platform versions, not just the one
1041          it is running on.
1042  
1043          https://bugs.webkit.org/show_bug.cgi?id=53356
1044  
1045          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1046  
1047 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1048
1049         Unreviewed, build fix.
1050
1051         Take two. The fix in 77023 didn't work, because we were
1052         still calling path.abspath_to_uri, which calls _cygpath under
1053         the covers, and it appears the cygpath on the bots does
1054         something different than it does on my machine. This patch
1055         removes the calls to path.abspath_to_uri, so it should be safe.
1056         If it doesn't work, I'll roll it out along with r76982 and 77023.
1057
1058         https://bugs.webkit.org/show_bug.cgi?id=53126
1059
1060         * Scripts/webkitpy/layout_tests/port/test.py:
1061
1062 2011-01-28  David Kilzer  <ddkilzer@apple.com>
1063
1064         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
1065         <http://webkit.org/b/53353>
1066
1067         Reviewed by Mark Rowe.
1068
1069         * Scripts/webkitdirs.pm:
1070         (checkRequiredSystemConfig): Check the Xcode marketing version
1071         in addition to the DevCoreTools build version before complaining
1072         about an old version of Xcode.  Also make the Mac OS X version
1073         check use Perl's built-in version string comparitor.
1074
1075 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1076
1077         Unreviewed, build fix.
1078
1079         Work around breakage on Win 7 Release bot caused by r76982
1080         and the fact that windows ports use "file:////" instead of
1081         "file:///". Ideally the test code should be isolated from
1082         this, but it isn't yet. Will fix properly in a bit.
1083
1084         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1085
1086 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1087
1088         Reviewed by Tony Chang.
1089
1090         new-run-webkit-tests: change worker model values to
1091         "old-inline", "old-threads" in preparation for test_runner2 /
1092         multiprocessing changes.
1093
1094         https://bugs.webkit.org/show_bug.cgi?id=53156
1095
1096         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1097         * Scripts/webkitpy/layout_tests/port/base.py:
1098         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1099         * Scripts/webkitpy/layout_tests/port/mac.py:
1100         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1101
1102 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1103
1104         Reviewed by Tony Chang.
1105
1106         committers.py - add an IRC nickname for dpranke
1107         https://bugs.webkit.org/show_bug.cgi?id=53335
1108
1109         * Scripts/webkitpy/common/config/committers.py:
1110
1111 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1112
1113         Reviewed by Tony Chang.
1114
1115         new-run-webkit-tests: add a "mock DRT" port implementation
1116         and a separate class that emulates what we expect the
1117         DumpRenderTree behavior to be.
1118
1119         This will eventually replace port/dryrun.py and allow us to get
1120         better test coverage of the new-run-webkit-tests code as well as
1121         a reference for what new-run-webkit-tests expects from DRT.
1122
1123         This is the first attempt at this, and it is pretty bare-boned. It
1124         really only has been tested on the 'mac' port (and a little on
1125         the 'chromium-mac' port.
1126
1127         https://bugs.webkit.org/show_bug.cgi?id=53126
1128
1129         * Scripts/webkitpy/common/system/filesystem_mock.py:
1130         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1131         * Scripts/webkitpy/layout_tests/port/factory.py:
1132         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1133         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1134         * Scripts/webkitpy/layout_tests/port/test.py:
1135
1136 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1137
1138         Unreviewed. Removing .swp file checked in by mistake.
1139
1140         * Scripts/.webkitdirs.pm.swp: Removed.
1141
1142 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1143
1144         Reviewed by David Kilzer.
1145
1146         Space not necessary for undefined feature
1147         https://bugs.webkit.org/show_bug.cgi?id=53317
1148
1149         * Scripts/build-webkit:
1150
1151 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1152
1153         Reviewed by Andreas Kling.
1154
1155         Reset NetworkAccessManager to clean up credentials from previous tests.
1156         This change causes no performance overhead either.
1157         https://bugs.webkit.org/show_bug.cgi?id=36688
1158
1159         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1160         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1161         (WebCore::DumpRenderTree::open):
1162         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1163
1164 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1165
1166         Reviewed by Andreas Kling.
1167
1168         [Qt] Add Zoom Text Only action to MiniBrowser
1169         https://bugs.webkit.org/show_bug.cgi?id=53297
1170
1171         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1172
1173         * MiniBrowser/qt/BrowserWindow.cpp:
1174         (BrowserWindow::BrowserWindow):
1175         (BrowserWindow::zoomIn):
1176         (BrowserWindow::zoomOut):
1177         (BrowserWindow::resetZoom):
1178         (BrowserWindow::toggleZoomTextOnly):
1179         (BrowserWindow::applyZoom):
1180         * MiniBrowser/qt/BrowserWindow.h:
1181
1182 2011-01-28  Adam Barth  <abarth@webkit.org>
1183
1184         Reviewed by Eric Seidel.
1185
1186         Add webkit-patch roll-chromium-deps
1187         https://bugs.webkit.org/show_bug.cgi?id=53288
1188
1189         This command updates the Source/WebKit/chromium/DEPS file with the
1190         last-known good revision of Chromium (or a revision specified on the
1191         command line).  I'd eventually like to turn this into a SheriffBot
1192         command, but this is the first step.
1193
1194         This patch somewhat sprawled because I needed to move a bunch of code
1195         out of ChangeLog that should never have been there in the first place.
1196         Also, I had to fix a bug in MockUser in order to test the new command.
1197
1198         * Scripts/webkitpy/common/checkout/api.py:
1199         * Scripts/webkitpy/common/checkout/changelog.py:
1200         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1201         * Scripts/webkitpy/common/checkout/deps.py: Added.
1202         * Scripts/webkitpy/common/config/urls.py:
1203         * Scripts/webkitpy/tool/commands/__init__.py:
1204         * Scripts/webkitpy/tool/commands/download_unittest.py:
1205         * Scripts/webkitpy/tool/commands/roll.py: Added.
1206         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1207         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1208         * Scripts/webkitpy/tool/mocktool.py:
1209         * Scripts/webkitpy/tool/steps/__init__.py:
1210         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1211         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1212         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1213         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1214         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1215         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1216
1217 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1218
1219         Reviewed by Laszlo Gombos.
1220
1221         Get rid of prefix header dependency for WebKit2 build system
1222         https://bugs.webkit.org/show_bug.cgi?id=50174
1223
1224         Change the style checker so that it enforces config.h include for
1225         WebKit2.
1226
1227         * Scripts/webkitpy/style/checker.py:
1228
1229 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1230
1231         Reviewed by Darin Adler.
1232
1233         execCommand("Paste") doesn't work in WebKitTestRunner
1234         https://bugs.webkit.org/show_bug.cgi?id=52785
1235
1236         Enable both of the settings needed to allow paste.
1237         
1238         * WebKitTestRunner/TestController.cpp:
1239         (WTR::TestController::resetStateToConsistentValues):
1240
1241 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1242
1243         Reviewed by Andreas Kling.
1244
1245         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1246         https://bugs.webkit.org/show_bug.cgi?id=48440
1247
1248         Preserve user input when toggling use of QGraphicsView
1249
1250         * QtTestBrowser/launcherwindow.cpp:
1251         (LauncherWindow::initializeView):
1252         (LauncherWindow::loadFinished):
1253         * QtTestBrowser/launcherwindow.h:
1254         * QtTestBrowser/mainwindow.cpp:
1255         (MainWindow::addressUrl):
1256         * QtTestBrowser/mainwindow.h:
1257
1258 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1259
1260         Reviewed by Mihai Parparita.
1261
1262         new-run-webkit-tests: turn off pixel tests correctly by default
1263         for webkit-based ports. r70013 (bug 47510) used
1264         port.set_option_default() to attempt to set default values, but
1265         that didn't work correctly. I have removed set_option_default
1266         for now since it was only being used in two places and in three
1267         useless unit tests. There is a separate bug open to fix the
1268         option parsing (48095), so this workaround is fine for now.
1269
1270         https://bugs.webkit.org/show_bug.cgi?id=53217
1271
1272         * Scripts/webkitpy/layout_tests/port/webkit.py:
1273         * Scripts/webkitpy/layout_tests/port/base.py:
1274         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1275
1276 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1277
1278         Rubber-stamped by Ariya Hidayat.
1279
1280         Trivial crash fix in WTR.
1281
1282         * WebKitTestRunner/TestController.cpp:
1283         (WTR::TestController::initialize): Increase the size
1284         of the vector by one to be able to store the null character.
1285
1286 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1287
1288         Reviewed by Csaba Osztrogonác.
1289
1290         [Qt][WK2] WTR should be initialized in the same way as DRT
1291         https://bugs.webkit.org/show_bug.cgi?id=53240
1292
1293         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1294         (WTR::activateFonts): Added missing initialization steps.
1295
1296 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1297
1298         Unreviewed. 
1299
1300         Adding myself to committers.py.
1301
1302         * Scripts/webkitpy/common/config/committers.py:
1303
1304 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1305
1306         Reviewed by Csaba Osztrogonác.
1307
1308         [Qt] [Symbian] Move project files into Source
1309         https://bugs.webkit.org/show_bug.cgi?id=52891
1310
1311         Fix the Symbian build after the project files
1312         are moved to Source directory. On Symbian qmake
1313         needs to run in the same directory where the main
1314         pro files (WebKit.pro, Tools.pro) are located.
1315
1316         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1317         is located before running qmake for Symbian. Qmake on Symbian
1318         does not properly honor the "-o" option, work it around by setting
1319         the name of the Makefile to bld.inf.
1320
1321 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1322
1323         Reviewed by Andreas Kling.
1324
1325         [Qt] Add simple zooming features to MiniBrowser
1326         https://bugs.webkit.org/show_bug.cgi?id=53231
1327
1328         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1329
1330         * MiniBrowser/qt/BrowserWindow.cpp:
1331         (BrowserWindow::BrowserWindow):
1332         (BrowserWindow::zoomIn):
1333         (BrowserWindow::zoomOut):
1334         (BrowserWindow::resetZoom):
1335         (BrowserWindow::updateUserAgentList):
1336         (BrowserWindow::applyZoom):
1337         * MiniBrowser/qt/BrowserWindow.h:
1338
1339 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1340
1341         Reviewed by Dan Bernstein.
1342
1343         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1344         https://bugs.webkit.org/show_bug.cgi?id=42319
1345         
1346         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1347
1348         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1349         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1350         (WTR::LayoutTestController::showWebInspector):
1351         (WTR::LayoutTestController::closeWebInspector):
1352         (WTR::LayoutTestController::evaluateInWebInspector):
1353         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1354         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1355         * WebKitTestRunner/TestInvocation.cpp:
1356         (WTR::shouldOpenWebInspector):
1357         (WTR::TestInvocation::invoke):
1358         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1359
1360 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1361
1362         Reviewed by Xan Lopez.
1363
1364         [GTK] Pixel dumps do not include scrollbars in output images
1365         https://bugs.webkit.org/show_bug.cgi?id=53216
1366
1367         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1368         that have scrollbars.
1369
1370         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1371         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1372         instead of the web view itself.
1373
1374 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1375
1376         Reviewed by Mihai Parparita.
1377
1378         Fix regression introduced in r76322 ... new-run-webkit-tests
1379         was attempting to save the image diff output as a UTF-8-encoded
1380         file.
1381
1382         https://bugs.webkit.org/show_bug.cgi?id=53210
1383
1384         * Scripts/webkitpy/layout_tests/port/webkit.py:
1385
1386 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1387
1388         Unreviewed, rolling out r76709.
1389         http://trac.webkit.org/changeset/76709
1390         https://bugs.webkit.org/show_bug.cgi?id=53194
1391
1392         "broke python tests on non-snowleopard platforms" (Requested
1393         by dpranke on #webkit).
1394
1395         * Scripts/webkitpy/layout_tests/port/factory.py:
1396         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1397         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1398
1399 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1400
1401         Reviewed by Tony Chang.
1402
1403         new-run-webkit-tests: add a "mock DRT" port implementation
1404         and a separate class that emulates what we expect the
1405         DumpRenderTree behavior to be.
1406
1407         This will eventually replace port/dryrun.py and allow us to get
1408         better test coverage of the new-run-webkit-tests code as well as
1409         a reference for what new-run-webkit-tests expects from DRT.
1410
1411         This is the first attempt at this, and it is pretty bare-boned. It
1412         really only has been tested on the 'mac' port (and a little on
1413         the 'chromium-mac' port.
1414
1415         https://bugs.webkit.org/show_bug.cgi?id=53126
1416
1417         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1418         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1419         * Scripts/webkitpy/layout_tests/port/factory.py:
1420
1421 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1422
1423         Reviewed by Tony Chang.
1424
1425         Add '--no-timeout' option to Chromium DRT to ease debugging.
1426         https://bugs.webkit.org/show_bug.cgi?id=52873
1427
1428         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1429         (main):
1430
1431 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1432
1433         Reviewed by Andreas Kling.
1434
1435         [Qt] Fix qt_minimal build
1436         https://bugs.webkit.org/show_bug.cgi?id=53172
1437
1438         * QtTestBrowser/locationedit.h:
1439
1440 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1441
1442         Reviewed by Antonio Gomes.
1443
1444         QtTestBrowser should have a UI Setting to disable plugins
1445         https://bugs.webkit.org/show_bug.cgi?id=52408
1446         
1447         Added a new action item named "Disable Plugins"
1448         under the "Settings" menu. 
1449
1450         * QtTestBrowser/launcherwindow.cpp:
1451         (LauncherWindow::createChrome):
1452         (LauncherWindow::togglePlugins):
1453         * QtTestBrowser/launcherwindow.h:
1454
1455 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1456
1457         Reviewed by Adam Barth.
1458
1459         Move main CMakeLists.txt into Source directory
1460         https://bugs.webkit.org/show_bug.cgi?id=52888
1461
1462         * Scripts/webkitdirs.pm:
1463
1464 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1465
1466         Reviewed by Eric Seidel.
1467
1468         Improve label text in submit-to-ews
1469         https://bugs.webkit.org/show_bug.cgi?id=53130
1470
1471         * QueueStatusServer/templates/submittoews.html:
1472
1473 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1474
1475         Reviewed by Antonio Gomes.
1476
1477         QtTestBrowser should have a UI Settings to prevent loading images
1478         https://bugs.webkit.org/show_bug.cgi?id=52409
1479         
1480         Added a new action item named "DisableAutoLoadImages"
1481         under the "Settings" menu 
1482
1483         * QtTestBrowser/launcherwindow.cpp:
1484         (LauncherWindow::createChrome):
1485         (LauncherWindow::toggleAutoLoadImages):
1486         * QtTestBrowser/launcherwindow.h:
1487
1488 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1489
1490         Reviewed by Tony Chang.
1491
1492         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1493         classes, test_expectations.py. This change adds "test-win" and
1494         "test-mac" variants to the test port so that we can better test
1495         rebaselining, and adds a MockUser() object for reuse in testing.
1496
1497         https://bugs.webkit.org/show_bug.cgi?id=53036
1498
1499         * Scripts/webkitpy/common/system/filesystem.py:
1500         * Scripts/webkitpy/common/system/filesystem_mock.py:
1501         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1502         * Scripts/webkitpy/layout_tests/port/factory.py:
1503         * Scripts/webkitpy/layout_tests/port/base.py:
1504         * Scripts/webkitpy/layout_tests/port/test.py:
1505         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1506         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1507         * Scripts/webkitpy/tool/mocktool.py:
1508
1509 2011-01-25  Tony Chang  <tony@chromium.org>
1510
1511         Reviewed by Dimitri Glazkov.
1512
1513         [chromium] remove unused layoutTestController callback
1514         https://bugs.webkit.org/show_bug.cgi?id=53103
1515
1516         This method is used by a test_shell_test, but not needed by DRT.
1517
1518         * DumpRenderTree/chromium/LayoutTestController.cpp:
1519         (LayoutTestController::LayoutTestController):
1520         * DumpRenderTree/chromium/LayoutTestController.h:
1521
1522 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1523
1524         Reviewed by Andreas Kling.
1525
1526         [GTK] Remove 64 bits release bot from the buildbot master
1527         https://bugs.webkit.org/show_bug.cgi?id=52899
1528
1529         Removes the 64 bits release slave from the buildbot configuration,
1530         so that we can use it as an EWS.
1531
1532         * BuildSlaveSupport/build.webkit.org-config/config.json:
1533
1534 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1535
1536         Reviewed by Dan Bernstein.
1537
1538         Implement database quota callback to fix storage tests on WebKit2 bot
1539         https://bugs.webkit.org/show_bug.cgi?id=53064
1540
1541         * WebKitTestRunner/TestController.cpp:
1542         (WTR::exceededDatabaseQuota):
1543         (WTR::TestController::createOtherPage):
1544         (WTR::TestController::initialize):
1545
1546 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1547
1548         Reviewed by Anders Carlsson.
1549
1550         Use designated temp directory for the database for WebKit2
1551         https://bugs.webkit.org/show_bug.cgi?id=53052
1552         
1553         Adopt the new WK2 API for this.
1554
1555         * WebKitTestRunner/TestController.cpp:
1556         (WTR::TestController::libraryPathForTesting):
1557         (WTR::TestController::initialize):
1558         * WebKitTestRunner/TestController.h:
1559         * WebKitTestRunner/mac/TestControllerMac.mm:
1560         (WTR::TestController::platformLibraryPathForTesting):
1561         * WebKitTestRunner/qt/TestControllerQt.cpp:
1562         (WTR::TestController::platformLibraryPathForTesting):
1563         * WebKitTestRunner/win/TestControllerWin.cpp:
1564         (WTR::TestController::platformLibraryPathForTesting):
1565
1566 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1567
1568         Reviewed by Stephanie Lewis.
1569
1570         Add a new Leopard test bot.
1571
1572         * BuildSlaveSupport/build.webkit.org-config/config.json:
1573
1574 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1575
1576         Reviewed by Adam Barth.
1577
1578         Add EFL Builder to core waterfall
1579         https://bugs.webkit.org/show_bug.cgi?id=52704
1580
1581         Add EFL Builder to the core waterfall again.
1582
1583         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1584         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1585
1586 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1587
1588         Reviewed by Tony Chang.
1589
1590         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1591         https://bugs.webkit.org/show_bug.cgi?id=52872
1592
1593         Force disabling proxy to resolve the problem.
1594
1595         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1596         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1597
1598 2011-01-24  Andreas Kling  <kling@webkit.org>
1599
1600         Reviewed by Darin Adler.
1601
1602         check-webkit-style: Update exemptions following Source/ move.
1603         https://bugs.webkit.org/show_bug.cgi?id=53017
1604
1605         * Scripts/webkitpy/style/checker.py:
1606         * Scripts/webkitpy/style/checker_unittest.py:
1607
1608 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1609
1610         Rubber-stamped by Csaba Osztrogonác.
1611
1612         [Qt] Move project files into Source
1613         https://bugs.webkit.org/show_bug.cgi?id=52891
1614
1615         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1616
1617 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1618
1619         Reviewed by Yury Semikhatsky.
1620
1621         Web Inspector: Find duplicate strings in localizedStrings.js
1622
1623         https://bugs.webkit.org/show_bug.cgi?id=53005
1624
1625         * Scripts/check-inspector-strings:
1626
1627 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1628
1629         Reviewed by Andreas Kling.
1630
1631         [Qt] Regroup MiniBrowser's menubar and add open file action
1632         https://bugs.webkit.org/show_bug.cgi?id=53000
1633
1634         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1635
1636         * MiniBrowser/qt/BrowserWindow.cpp:
1637         (BrowserWindow::BrowserWindow):
1638         (BrowserWindow::openFile):
1639         (BrowserWindow::~BrowserWindow):
1640         * MiniBrowser/qt/BrowserWindow.h:
1641
1642 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1643
1644         Unreviewed fix after r76496
1645
1646         [Qt] Move project files into Source
1647         https://bugs.webkit.org/show_bug.cgi?id=52891
1648
1649         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1650         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1651         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1652
1653 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1654
1655         Reviewed by Csaba Osztrogonác.
1656
1657         [Qt] Move project files into Source
1658         https://bugs.webkit.org/show_bug.cgi?id=52891
1659
1660         * DerivedSources.pro: Renamed from DerivedSources.pro.
1661         * DumpRenderTree/qt/DumpRenderTree.pro:
1662         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1663         * MiniBrowser/DerivedSources.pro:
1664         * MiniBrowser/qt/MiniBrowser.pro:
1665         * QtTestBrowser/QtTestBrowser.pro:
1666         * Scripts/webkitdirs.pm:
1667         * Tools.pro: Added.
1668         * WebKitTestRunner/DerivedSources.pro:
1669         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1670         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1671
1672 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1673
1674         Reviewed by Dan Bernstein.
1675
1676         Beefed up --threaded mode to catch even more kinds of errors.
1677         https://bugs.webkit.org/show_bug.cgi?id=52971
1678
1679         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1680         context group to force JSC to mark multiple threads. (This used to be
1681         the default, but it changed in SnowLeopard.)
1682         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1683         to give threading mistakes more chances to show themselves.
1684         (startJavaScriptThreads):
1685         (stopJavaScriptThreads):
1686
1687 2011-01-22  Robert Hogan  <robert@webkit.org>
1688
1689         Reviewed by Andreas Kling.
1690
1691         [Qt] Support layoutTestController.addURLToRedirect()
1692         https://bugs.webkit.org/show_bug.cgi?id=52956
1693
1694         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1695         (LayoutTestController::addURLToRedirect):
1696         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1697
1698 2011-01-22  Robert Hogan  <robert@webkit.org>
1699
1700         Reviewed by Kenneth Rohde Christiansen.
1701
1702         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1703         https://bugs.webkit.org/show_bug.cgi?id=49802
1704
1705         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1706         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1707         (WebCore::DumpRenderTree::open):
1708
1709 2011-01-21  Adam Barth  <abarth@webkit.org>
1710
1711         Reviewed by Maciej Stachowiak.
1712
1713         Disable mac_unittest.py that fails on some of the Mac bots
1714         https://bugs.webkit.org/show_bug.cgi?id=52947
1715
1716         As noted in the comment, this test does not appear to be correct
1717         because the function this test is testing returns different results
1718         depending on which flavor of Mac the test is run on.  This patch
1719         disable the test.  Hopefully we can re-enable the test once we've
1720         probably insulated the test from its environment.
1721
1722         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1723
1724 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1725
1726         Reviewed by Mihai Parparita.
1727
1728         Fix bug introduced in r76322 that caused NRWT to not actually
1729         read the Skipped files properly.
1730
1731         https://bugs.webkit.org/show_bug.cgi?id=52771
1732
1733         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1734         * Scripts/webkitpy/layout_tests/port/webkit.py:
1735         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1736
1737 2011-01-21  Sam Weinig  <sam@webkit.org>
1738
1739         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1740
1741         WebKitTestRunner needs the HOME environment variable to be set.
1742         <rdar://problem/8896573>
1743
1744         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1745         it exists.
1746
1747 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1748
1749         Reviewed by Eric Seidel.
1750
1751         Suppress a few remaining integration tests so that none of the
1752         layout_test unit tests ever read from the filesystem or launch
1753         subprocesses that aren't part of the unit tests.
1754
1755         Also fix a minor bug in the printing unit tests that was
1756         incorrectly relying on sys.argv.
1757
1758         https://bugs.webkit.org/show_bug.cgi?id=52863
1759
1760         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1761         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1762         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1763
1764 2011-01-21  Darin Adler  <darin@apple.com>
1765
1766        Fix Mac build.
1767
1768         * MiniBrowser/mac/BrowserWindowController.m:
1769         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1770
1771 2011-01-20  Darin Adler  <darin@apple.com>
1772
1773         Reviewed by Dan Bernstein.
1774
1775         WebKit2: Implement showModalDialog
1776         https://bugs.webkit.org/show_bug.cgi?id=52855
1777
1778         This fixes WebKitTestRunner to compile, but more work is probably
1779         needed to get it to pass the tests.
1780
1781         * WebKitTestRunner/TestController.cpp:
1782         (WTR::TestController::runModal): Added. Calls through to the
1783         platform-specific version of runModal.
1784         (WTR::TestController::createOtherPage): Changed to be a private
1785         static member function so it can refer to runModal, which is
1786         a private static member function.
1787         (WTR::TestController::initialize): Pass 0 for the runModal
1788         function since we don't need to run the main window modal.
1789         I suspect this is wrong and will need to change.
1790         * WebKitTestRunner/TestController.h: Added declarations for
1791         the functions added above.
1792         * WebKitTestRunner/mac/TestControllerMac.mm:
1793         (WTR::TestController::runModal): Added. Untested implementation.
1794         * WebKitTestRunner/qt/TestControllerQt.cpp:
1795         (WTR::TestController::runModal): Added.
1796         * WebKitTestRunner/win/TestControllerWin.cpp:
1797         (WTR::TestController::runModal): Added.
1798
1799 2011-01-21  Eric Seidel  <eric@webkit.org>
1800
1801         Reviewed by Adam Barth.
1802
1803         Split Host object off from WebKitPatch for easier re-use
1804         https://bugs.webkit.org/show_bug.cgi?id=52284
1805
1806         new-run-webkit-tests and other tools are eventually going to want one of these.
1807         Basically you need to inherit from this class if you want to pretend to be a
1808         self.tool object for Steps/Commands.
1809
1810         * Scripts/webkitpy/common/host.py: Added.
1811         * Scripts/webkitpy/tool/main.py:
1812
1813 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1814
1815         Reviewed by Adam Barth.
1816
1817         Disable the tests that start and stop the http server and web
1818         server, so that we don't have to worry about port collisions on
1819         the bots.
1820
1821         https://bugs.webkit.org/show_bug.cgi?id=52861
1822
1823         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1824
1825 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1826
1827         Reviewed by Eric Seidel.
1828
1829         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1830         
1831         https://bugs.webkit.org/show_bug.cgi?id=52772
1832         
1833         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1834
1835 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1836
1837         Reviewed by Eric Siedel.
1838
1839         nrwt: clean up almost all remaining port references, remove
1840         unnecessary import clauses. The only remaining references are
1841         in places where a mock filesystem makes no sense or can't be
1842         used, and in one routine in port/google_chrome_unittest that
1843         I'll rewrite in a separate patch.
1844
1845         https://bugs.webkit.org/show_bug.cgi?id=52771
1846
1847         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1848         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1849         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1850         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1851         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1852         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1853         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1854         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1855         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1856         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1857         * Scripts/webkitpy/layout_tests/port/gtk.py:
1858         * Scripts/webkitpy/layout_tests/port/mac.py:
1859         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1860         * Scripts/webkitpy/layout_tests/port/qt.py:
1861         * Scripts/webkitpy/layout_tests/port/webkit.py:
1862         * Scripts/webkitpy/layout_tests/port/win.py:
1863         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1864
1865 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1866
1867         Reviewed by Mihai Parparita.
1868
1869         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1870
1871         https://bugs.webkit.org/show_bug.cgi?id=52762
1872
1873         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1874         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1875
1876 2011-01-20  Tony Chang  <tony@chromium.org>
1877
1878         Reviewed by Ojan Vafai.
1879
1880         [chromium] fix the paths used for the rebaseline tool
1881         https://bugs.webkit.org/show_bug.cgi?id=52857
1882
1883         Some of the bots were renamed so the path to grab the results zip
1884         file has changed.
1885
1886         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1887
1888 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1889
1890         Reviewed by Tony Chang.
1891
1892         Fix bug introduced in r72688 / bug 52768 that broke the
1893         generation of the output filename links in the results.html
1894         output. Apparently none of the unit tests actually checked to
1895         make sure the generated links were correct :(
1896
1897         https://bugs.webkit.org/show_bug.cgi?id=52854
1898
1899         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1900         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1901
1902 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1903
1904         Reviewed by Darin Adler.
1905
1906         https://bugs.webkit.org/show_bug.cgi?id=52849
1907         Make window.print work with WebKit2
1908
1909         * MiniBrowser/mac/BrowserWindowController.m:
1910         (-[BrowserWindowController awakeFromNib]):
1911         * WebKitTestRunner/TestController.cpp:
1912         (WTR::createOtherPage):
1913         (WTR::TestController::initialize):
1914         Added zeroes to WKPageUIClient structures to avoid build failures.
1915
1916 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1917
1918         Reviewed by Eric Seidel.
1919
1920         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1921
1922         https://bugs.webkit.org/show_bug.cgi?id=52756
1923
1924         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1925         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1926         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1927         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1928         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1929         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1930
1931 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1932
1933         Reviewed by Antonio Gomes.
1934
1935         QtTestBrowser should have a seperate menu for Settings
1936         https://bugs.webkit.org/show_bug.cgi?id=52817
1937         
1938         Added a new menu item named "Settings"
1939         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1940
1941         * QtTestBrowser/launcherwindow.cpp:
1942         (LauncherWindow::createChrome):
1943
1944 2011-01-20  Sam Weinig  <sam@webkit.org>
1945
1946         Reviewed by John Sullivan.
1947
1948         Update update-webkit-localizable-strings with new path to WebKit.
1949
1950         * Scripts/update-webkit-localizable-strings:
1951
1952 2011-01-20  James Robinson  <jamesr@chromium.org>
1953
1954         Reviewed by Darin Fisher.
1955
1956         Implement mozilla's requestAnimationFrame API
1957         https://bugs.webkit.org/show_bug.cgi?id=51218
1958
1959         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1960
1961         * DumpRenderTree/chromium/WebViewHost.cpp:
1962         (invokeScheduleComposite):
1963         (WebViewHost::scheduleAnimation):
1964         (WebViewHost::paintInvalidatedRegion):
1965         * DumpRenderTree/chromium/WebViewHost.h:
1966
1967 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1968
1969         Reviewed by Adam Roben.
1970
1971         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1972         https://bugs.webkit.org/show_bug.cgi?id=42327
1973
1974         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1975         for methods that take their normal arguments but also a JSContextRef.
1976         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1977         for evaluateScriptInIsolatedWorld.
1978         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1979         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1980         this call is for an isolated world.
1981         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1982         (WTR::worldMap): Helper to create a world map.
1983         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1984         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1985         added LayoutTestController API.
1986         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1987
1988 2011-01-19  Adam Roben  <aroben@apple.com>
1989
1990         Convert paths in environment variables back to msys-style inside commit-log-editor
1991
1992         When this script gets run from inside git commit, msys-style paths in the environment will
1993         have been turned into Windows-style paths with forward slashes. This screws up functions
1994         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1995         the paths back to msys-style before doing anything else.
1996
1997         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1998         using msysgit's Perl and multiple ChangeLogs have been edited
1999
2000         Reviewed by David Kilzer.
2001
2002         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
2003         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
2004         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
2005
2006 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2007
2008         [Win] Unreviewed build fix after r76248.
2009
2010         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
2011
2012 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2013
2014         Reviewed by Csaba Osztrogonác.
2015
2016         Refactoring of the custom allocation framework
2017         https://bugs.webkit.org/show_bug.cgi?id=49897
2018
2019         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
2020         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
2021         equivalent macro implementation at the necessary places.
2022 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
2023
2024         Unreviewed. 
2025
2026         Adding myself to committers.py.
2027
2028         * Scripts/webkitpy/common/config/committers.py:
2029
2030 2011-01-20  Adam Barth  <abarth@webkit.org>
2031
2032         Reviewed by Tony Chang.
2033
2034         Chromium builders don't delete unversioned directories when DEPS change
2035         https://bugs.webkit.org/show_bug.cgi?id=52745
2036
2037         If we pass this option to gclient sync, gclient will delete directories
2038         that are no longer part of DEPS instead of leaving them around to
2039         confuse us later.  Apparently, the downstream buildbots use this option
2040         already.
2041
2042         * Scripts/update-webkit-chromium:
2043
2044 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2045
2046         Unreviewed, build fix - I pulled this patch in to fix an issue
2047         revealed by r76195 running on some new bots). Also fix a couple
2048         of other issues revealed in testing.
2049
2050         nrwt: remove fs refs from layout_package/json*
2051
2052         https://bugs.webkit.org/show_bug.cgi?id=52754
2053
2054         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2055         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2056         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2057         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2058         * Scripts/webkitpy/layout_tests/port/base.py:
2059
2060 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2061
2062         Unreviewed, build fix.
2063
2064         Fix a couple of minor bugs discovered while bringing up new bots
2065         for testing.
2066
2067         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2068         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2069
2070 2011-01-19  James Robinson  <jamesr@chromium.org>
2071
2072         Unreviewed, rolling out r76194.
2073         http://trac.webkit.org/changeset/76194
2074         https://bugs.webkit.org/show_bug.cgi?id=51218
2075
2076         Caused mysterious compile failure on the chromium win
2077         build.webkit.org bots
2078
2079         * DumpRenderTree/chromium/WebViewHost.cpp:
2080         (WebViewHost::paintInvalidatedRegion):
2081         * DumpRenderTree/chromium/WebViewHost.h:
2082
2083 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2084
2085         Reviewed by Mihai Parparita.
2086
2087         remove fs refs from test_runner, dump_render_tree_thread
2088
2089         https://bugs.webkit.org/show_bug.cgi?id=52753
2090
2091         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2092         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2093         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2094         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2095
2096 2011-01-19  James Robinson  <jamesr@chromium.org>
2097
2098         Reviewed by Darin Fisher.
2099
2100         Implement mozilla's requestAnimationFrame API
2101         https://bugs.webkit.org/show_bug.cgi?id=51218
2102
2103         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2104
2105         * DumpRenderTree/chromium/WebViewHost.cpp:
2106         (invokeScheduleComposite):
2107         (WebViewHost::scheduleAnimation):
2108         (WebViewHost::paintInvalidatedRegion):
2109         * DumpRenderTree/chromium/WebViewHost.h:
2110
2111 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2112
2113         Unreviewed, build fix.
2114
2115         Fix a few incorrect "self._filesystem" references introduced in
2116         r76184.
2117
2118         * Scripts/webkitpy/layout_tests/port/chromium.py:
2119         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2120
2121 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2122
2123         Reviewed by Mihai Parparita.
2124
2125         add a .sep property, abspath(), isabs(), mtime(), and
2126         open_text_file_for_writing() to filesystem modules. Some of
2127         these properties are not needed in this patch but will be needed
2128         in subsequent patches (I'm doing this to avoid having to track
2129         multiple versions of a single file).
2130
2131         Also, change most of the port/* modules to use the filesystem
2132         objects instead of referencing the filesystem directly.
2133
2134         https://bugs.webkit.org/show_bug.cgi?id=52748
2135
2136         * Scripts/webkitpy/common/system/filesystem.py:
2137         * Scripts/webkitpy/common/system/filesystem_mock.py:
2138         * Scripts/webkitpy/layout_tests/port/__init__.py:
2139         * Scripts/webkitpy/layout_tests/port/base.py:
2140         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2141         * Scripts/webkitpy/layout_tests/port/chromium.py:
2142         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2143         * Scripts/webkitpy/layout_tests/port/config.py:
2144         * Scripts/webkitpy/layout_tests/port/test.py:
2145         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2146
2147 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2148
2149         Reviewed by Anders Carlsson.
2150
2151         If resetting between tests times out, treat it as a WebProcess crash
2152         https://bugs.webkit.org/show_bug.cgi?id=52757
2153
2154         * WebKitTestRunner/TestController.cpp:
2155         (WTR::TestController::runTest):
2156
2157 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2158
2159         Reviewed by Darin Adler.
2160
2161         https://bugs.webkit.org/show_bug.cgi?id=52739
2162         Make it possible for a WebKit2 client to print headers and footers
2163
2164         Added dummy implementations for new printing UIClient calls.
2165
2166         * MiniBrowser/mac/BrowserWindowController.m:
2167         (-[BrowserWindowController awakeFromNib]):
2168         * WebKitTestRunner/TestController.cpp:
2169         (WTR::createOtherPage):
2170         (WTR::TestController::initialize):
2171
2172 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2173
2174         Reviewed by Ojan Vafai.
2175
2176         Change webkitpy/layout_tests/port/test.py to use the
2177         in-memory filesystem for cleaner unit testing. This
2178         change allows us to kill a lot of code that was
2179         specific to the test port, at the cost of being a
2180         little less clear about how things would work if
2181         you didn't have a filesystem.
2182
2183         https://bugs.webkit.org/show_bug.cgi?id=52605
2184
2185         * Scripts/webkitpy/layout_tests/port/test.py:
2186
2187 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2188
2189         Unreviewed, build fix.
2190
2191         Fix test failure caused by committing attachment 79368 instead
2192         of attachment 79461 on bug 52604.
2193
2194         * Scripts/webkitpy/common/system/filesystem_mock.py:
2195
2196 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2197
2198         Reviewed by Mihai Parparita.
2199
2200         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2201         unit testing. os.walk() is too much of a hassle to implement on
2202         top of the in-memory mock filesystem and adding the necessary
2203         interface to files_under() gives clients a cleaner API anyway
2204         (for this particular usage model).
2205
2206         https://bugs.webkit.org/show_bug.cgi?id=52691
2207
2208         * Scripts/webkitpy/common/system/filesystem.py:
2209         * Scripts/webkitpy/common/system/filesystem_mock.py:
2210         * Scripts/webkitpy/layout_tests/port/test_files.py:
2211         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2212
2213 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2214
2215         Reviewed by Tony Chang.
2216
2217         Change more modules in the layout-tests code to use the
2218         filesystem wrapper for cleaner unit testing.
2219
2220         This patch also adds the glob() wrapper to the filesystem
2221         abstraction.
2222         
2223         https://bugs.webkit.org/show_bug.cgi?id=52604
2224
2225         * Scripts/webkitpy/layout_tests/port/test_files.py:
2226         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2227         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2228         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2229         * Scripts/webkitpy/common/system/filesystem.py:
2230         * Scripts/webkitpy/common/system/filesystem_mock.py:
2231
2232 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2233
2234         Unreviewed.
2235
2236         Updating my email addresses and irc nick.
2237
2238         * Scripts/webkitpy/common/config/committers.py:
2239
2240 2011-01-19  Tony Chang  <tony@chromium.org>
2241
2242         Reviewed by Mihai Parparita.
2243
2244         [chromium] [linux] if check-sys-deps fails, output the failure reason
2245         https://bugs.webkit.org/show_bug.cgi?id=52671
2246
2247         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2248             error handler functions.
2249         * Scripts/webkitpy/layout_tests/port/chromium.py:
2250             output the error text from --check-sys-deps
2251         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2252
2253 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2254
2255         Reviewed by Andreas Kling.
2256
2257         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2258         https://bugs.webkit.org/show_bug.cgi?id=52554
2259         
2260         QtNetworkAccessManager is created in a thread and set as
2261         member variable in QWebPage. When the thread is destroyed
2262         the object is still used. So fix will set the object to
2263         NULL once the thread is destroyed.
2264
2265         * QtTestBrowser/launcherwindow.cpp:
2266         (LauncherWindow::~LauncherWindow):
2267
2268 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2269
2270         Rubber stamped by Csaba Osztrogonac
2271
2272         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2273
2274 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2275
2276         Reviewed by Tony Chang.
2277
2278         new-run-webkit-tests: add a --build-directory command line argument
2279
2280         Official Google Chrome builds use a non-standard build directory
2281         location. This patch adds a --build-directory argument that
2282         allows that location to be specified on the command line. Only
2283         Chromium-based builds will use this flag for now, but anyone can
2284         in the future.
2285
2286         There are no unit tests for this since it's difficult to test
2287         until mock filesystems are fully supported in the code. This was
2288         tested by hand for now.
2289
2290         https://bugs.webkit.org/show_bug.cgi?id=52694
2291
2292         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2293         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2294         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2295         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2296
2297 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2298
2299         Not reviewed. Bot fix.
2300
2301         Remove an inadvertently committed debugging print.
2302
2303         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2304         (LayoutTestController::notifyDone):
2305
2306 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2307
2308         Reviewed by Sam Weinig.
2309
2310         WebKitTestRunner should track loading more like DumpRenderTree
2311         https://bugs.webkit.org/show_bug.cgi?id=52692
2312
2313         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2314         This makes some tests that call notifyDone multiple times pass.
2315         
2316         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2317         (WTR::InjectedBundle::InjectedBundle):
2318         (WTR::InjectedBundle::done):
2319         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2320         (WTR::InjectedBundle::topLoadingFrame):
2321         (WTR::InjectedBundle::setTopLoadingFrame):
2322         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2323         (WTR::InjectedBundlePage::InjectedBundlePage):
2324         (WTR::InjectedBundlePage::stopLoading):
2325         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2326         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2327         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2328         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2329         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2330         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2331         (WTR::LayoutTestController::notifyDone):
2332         * WebKitTestRunner/TestController.cpp:
2333         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2334
2335 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2336
2337         Reviewed by Kent Tamura.
2338
2339         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2340         https://bugs.webkit.org/show_bug.cgi?id=52678
2341         
2342         Update path now that WebKit is inside Source.
2343
2344         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2345
2346 2011-01-18  Robert Hogan  <robert@webkit.org>
2347
2348         Reviewed by Simon Hausmann.
2349
2350         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2351         https://bugs.webkit.org/show_bug.cgi?id=44282
2352
2353         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2354         (WebCore::DumpRenderTree::dump):
2355
2356 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2357
2358         Reviewed by Mihai Parparita.
2359
2360         Fix a small race condition that could cause the unit tests for
2361         new-run-webkit-tests to fail in a multithreaded environment.
2362         There was a small window in the code where one thread would
2363         check to see if a thread had raised an exception, do something,
2364         and then check to see if the thread was alive. If the other
2365         thread raised an exception and exited in between these two
2366         steps, the exception would be lost. Flipping the order of the
2367         two checks fixes the race, since we will now always check for an
2368         exception on the thread before exiting.
2369
2370         https://bugs.webkit.org/show_bug.cgi?id=51579
2371
2372         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2373
2374 2011-01-18  Eric Seidel  <eric@webkit.org>
2375
2376         Reviewed by Adam Barth.
2377
2378         commit-queue dies when test archiving fails
2379         https://bugs.webkit.org/show_bug.cgi?id=52617
2380
2381         I looked at the machine and it had 10 archives already
2382         thus find_unused_name was returning None.  I've upped
2383         the limit to 100 (per bug) and tested the case where
2384         find_unused_name returns None (making archive return None).
2385
2386         * Scripts/webkitpy/common/system/workspace.py:
2387         * Scripts/webkitpy/common/system/workspace_unittest.py:
2388         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2389         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2390         * Scripts/webkitpy/tool/commands/queues.py:
2391
2392 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2393
2394         Reviewed by Ojan Vafai.
2395
2396         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2397         filesystem. Also fix a couple of "with" statements missed by
2398         r76050.
2399
2400         https://bugs.webkit.org/show_bug.cgi?id=52487
2401
2402         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2403
2404 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2405
2406         Reviewed by Martin Robinson.
2407
2408         [Gtk] Build fixes for gtk3 build
2409         https://bugs.webkit.org/show_bug.cgi?id=52648
2410
2411         * DumpRenderTree/gtk/EventSender.cpp:
2412         (beginDragWithFilesCallback):
2413
2414 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2415
2416         Reviewed by Mihai Parparita.
2417
2418         Update rebaseline-chromium-webkit-tests to use filesystem objects
2419         instead of direct references to os.path, shutil, tempfile, etc.
2420
2421         This patch doesn't change anything, but will allow subsequent
2422         patches to change the unit tests to no longer use the real
2423         filesystem.
2424
2425         This patch adds a bunch more methods to the filesystem object as
2426         well.
2427
2428         https://bugs.webkit.org/show_bug.cgi?id=52482
2429
2430         * Scripts/webkitpy/common/system/filesystem.py:
2431         * Scripts/webkitpy/common/system/filesystem_mock.py:
2432         * Scripts/webkitpy/tool/commands/queues.py:
2433         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2434         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2435
2436 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2437
2438         Reviewed by Mihai Parparita.
2439
2440         new-run-webkit-tests shouldn't crash when you try to run a
2441         directory containing only skipped files.
2442
2443         https://bugs.webkit.org/show_bug.cgi?id=52478
2444         
2445         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2446         * Scripts/webkitpy/layout_tests/port/test.py:
2447         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2448
2449 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2450
2451         Reviewed by Gustavo Noronha Silva.
2452
2453         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2454         https://bugs.webkit.org/show_bug.cgi?id=40833
2455
2456         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2457         GTK+ event sender.
2458         (dragWithFilesDragDataGetCallback): Added.
2459         (dragWithFilesDragEndCallback): Added.
2460         (beginDragWithFilesCallback): Added.
2461
2462 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2463
2464         Reviewed by Adam Barth.
2465
2466         ews: Add additional watcher to efl ews
2467         https://bugs.webkit.org/show_bug.cgi?id=52613
2468
2469         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2470
2471         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2472
2473 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2474
2475         Reviewed by Alexey Proskuryakov.
2476
2477         Fix some headers with missing or misspelled #ifndef guards
2478         https://bugs.webkit.org/show_bug.cgi?id=52545
2479
2480         * DumpRenderTree/chromium/TestEventPrinter.h:
2481         * DumpRenderTree/chromium/WebPreferences.h:
2482
2483 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2484
2485         Reviewed by Anders Carlsson.
2486
2487         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2488         navigating back to an unreachable URL
2489         https://bugs.webkit.org/show_bug.cgi?id=52388
2490
2491         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2492
2493         * DumpRenderTree/LayoutTestController.cpp:
2494         (queueLoadHTMLStringCallback):
2495         (LayoutTestController::queueLoadHTMLString):
2496         (LayoutTestController::queueLoadAlternateHTMLString):
2497         * DumpRenderTree/LayoutTestController.h:
2498
2499         * DumpRenderTree/WorkQueueItem.h:
2500         (LoadHTMLStringItem::LoadHTMLStringItem):
2501
2502         * DumpRenderTree/chromium/LayoutTestController.cpp:
2503         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2504         (WorkItemLoadHTMLString::run):
2505         (LayoutTestController::queueLoadHTMLString):
2506
2507         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2508         (LoadHTMLStringItem::invoke):
2509         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2510         (LoadHTMLStringItem::invoke):
2511         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2512         (LoadHTMLStringItem::invoke):
2513
2514 2011-01-17  Dan Bernstein  <mitz@apple.com>
2515
2516         Rubber-stamped by Mark Rowe.
2517
2518         Update xcodeproj svn:ignore to include xcuserdata.
2519
2520         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2521         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2522         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2523         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2524         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2525
2526 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2527
2528         Unreviewed fix after r75908.
2529
2530         Move WebKit into Source
2531         https://bugs.webkit.org/show_bug.cgi?id=52530
2532
2533         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2534
2535 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2536
2537         Unreviewed.
2538
2539         Remove accidentally committed debug printing after r75908.
2540
2541         * Scripts/webkitdirs.pm:
2542
2543 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2544
2545         Unreviewed.
2546
2547         Add myself to committers list
2548         https://bugs.webkit.org/show_bug.cgi?id=52566
2549
2550         * Scripts/webkitpy/common/config/committers.py:
2551
2552 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2553
2554         Reviewed by Jeremy Orlow.
2555
2556         GeolocationController should call stopUpdating on destruction
2557         https://bugs.webkit.org/show_bug.cgi?id=52216
2558
2559         fast/dom/Geolocation/window-close-crash.html requires that a
2560         Geolocation watch be started in a secondary window. Consequently,
2561         we need to allow geolocation permission and provide a mock
2562         geolocation position for the secondary window's
2563         GeolocationClientMock.
2564
2565         * DumpRenderTree/chromium/LayoutTestController.cpp:
2566         (LayoutTestController::setGeolocationPermission):
2567         (LayoutTestController::setMockGeolocationPosition):
2568         (LayoutTestController::setMockGeolocationError):
2569         * DumpRenderTree/chromium/TestShell.h:
2570         (TestShell::windowList):
2571
2572 2011-01-16  Adam Barth  <abarth@webkit.org>
2573
2574         Update more include paths to reflect WebKit move.
2575
2576         * DumpRenderTree/chromium/EventSender.cpp:
2577         (EventSender::keyDown):
2578         (EventSender::needsShiftModifier):
2579         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2580         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2581
2582 2011-01-16  Kent Tamura  <tkent@chromium.org>
2583
2584         Unreviewed, Chromium build fix.
2585
2586         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2587
2588 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2589
2590         Build fix for GTK+ after source directory movement.
2591
2592         * GNUmakefile.am: Correct include paths.
2593
2594 2011-01-16  Adam Barth  <abarth@webkit.org>
2595
2596         Teach svn-apply about WebKit move.
2597
2598         * Scripts/VCSUtils.pm:
2599
2600 2011-01-16  Adam Barth  <abarth@webkit.org>
2601
2602         Rubber-stamped by Eric Seidel.
2603
2604         Move WebKit into Source
2605         https://bugs.webkit.org/show_bug.cgi?id=52530
2606
2607         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2608         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2609         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2610         * DumpRenderTree/qt/GCControllerQt.cpp:
2611         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2612         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2613         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2614         * DumpRenderTree/wscript:
2615         * QtTestBrowser/launcherwindow.h:
2616         * Scripts/build-webkit:
2617         * Scripts/webkitdirs.pm:
2618
2619 2011-01-15  Adam Barth  <abarth@webkit.org>
2620
2621         Teach svn-apply about WebKit2 move.
2622
2623         * Scripts/VCSUtils.pm:
2624
2625 2011-01-15  Adam Barth  <abarth@webkit.org>
2626
2627         Rubber-stamped by Eric Seidel.
2628
2629         Move WebKit2 into Source
2630         https://bugs.webkit.org/show_bug.cgi?id=52438
2631
2632         * MiniBrowser/qt/MiniBrowser.pro:
2633         * Scripts/build-webkit:
2634         * Scripts/do-file-rename:
2635         * Scripts/do-webcore-rename:
2636         * Scripts/test-webkitpy:
2637         * Scripts/webkitdirs.pm:
2638         * Scripts/webkitpy/style/checker.py:
2639         * WebKitTestRunner/DerivedSources.pro:
2640         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2641         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2642
2643 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2644
2645         Reviewed by David Levin.
2646
2647         [chromium] remove obsolete createView method
2648         https://bugs.webkit.org/show_bug.cgi?id=52437
2649
2650         * DumpRenderTree/chromium/WebViewHost.cpp:
2651         (WebViewHost::createView):
2652         * DumpRenderTree/chromium/WebViewHost.h:
2653
2654 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2655
2656         Reviewed by Geoff Garen.
2657
2658         ShouldLoadResourceForFrame should use strings, not URLs.
2659         https://bugs.webkit.org/show_bug.cgi?id=52476
2660
2661         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2662         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2663         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2664
2665 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2666
2667         Reviewed by David Levin.
2668
2669         Add Tony Gentilcore as a reviewer
2670         https://bugs.webkit.org/show_bug.cgi?id=52480
2671
2672         * Scripts/webkitpy/common/config/committers.py:
2673
2674 2011-01-14  David Levin  <levin@chromium.org>
2675
2676         Reviewed by Eric Seidel.
2677
2678         check-webkit-style: _FunctionState should keep track of where the function name starts.
2679         https://bugs.webkit.org/show_bug.cgi?id=52454
2680
2681         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2682         _FunctionState and logic for setting it correctly.
2683         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2684
2685 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2686
2687         Reviewed by David Levin.
2688
2689         Add support to DumpRenderTree to use the GPU rather than software renderer
2690         https://bugs.webkit.org/show_bug.cgi?id=52333
2691
2692         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2693         (main):
2694         * Scripts/webkitpy/layout_tests/port/chromium.py:
2695         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2696
2697 2011-01-14  Tony Chang  <tony@chromium.org>
2698
2699         Reviewed by Kent Tamura.
2700
2701         [chromium] update fonts.conf to fix 6 linux tests in drt
2702         https://bugs.webkit.org/show_bug.cgi?id=52411
2703
2704         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2705             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2706
2707 2011-01-14  Eric Seidel  <eric@webkit.org>
2708
2709         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2710
2711         Reviewed by Adam Barth.
2712
2713         Fix when running Tools/Scripts/check-webkit-style without arguments.
2714         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2715
2716         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2717         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2718
2719 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2720
2721         Reviewed by David Levin.
2722
2723         Store the tempdir object in a variable so it doesn't get deleted too early.
2724         https://bugs.webkit.org/show_bug.cgi?id=51875
2725
2726         * Scripts/update-webkit-auxiliary-libs:
2727         * Scripts/update-webkit-support-libs:
2728
2729 2011-01-14  Eric Seidel  <eric@webkit.org>
2730
2731         Unreviewed.  Make it work in python 2.5.
2732
2733         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2734         https://bugs.webkit.org/show_bug.cgi?id=49158
2735
2736         * Scripts/webkitpy/common/checkout/api_unittest.py:
2737
2738 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2739
2740         Unreviewed, rolling out r75774.
2741         http://trac.webkit.org/changeset/75774
2742         https://bugs.webkit.org/show_bug.cgi?id=52431
2743
2744         gtk builds were broken (Requested by loislo2 on #webkit).
2745
2746         * Scripts/webkitpy/common/checkout/scm.py:
2747
2748 2011-01-14  David Levin  <levin@chromium.org>
2749
2750         Reviewed by Shinichiro Hamaji.
2751
2752         check-webkit-style: _FunctionState should detect pure functions.
2753         https://bugs.webkit.org/show_bug.cgi?id=52428
2754
2755         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2756         is a pure virtual function.
2757         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2758         virtual functions are correctly detected.
2759
2760 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2761
2762         Reviewed by Yury Semikhatsky.
2763
2764         Just small fix for problem with check-webkit-style.
2765         It just didn't work for this patch.
2766         Old code can't concatenate a list of strings with None.
2767
2768         * Scripts/webkitpy/common/checkout/scm.py:
2769
2770 2011-01-13  David Levin  <levin@chromium.org>
2771
2772         Reviewed by Shinichiro Hamaji.
2773
2774         check-webkit-style: _FunctionState should use Position to know where items are.
2775         https://bugs.webkit.org/show_bug.cgi?id=52424
2776
2777         * Scripts/webkitpy/style/checkers/cpp.py:
2778         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2779         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2780         did some minor clean-up.
2781         (*): Other changes are simply about converting to use the Position's in_FunctionState
2782         instead of line numbers.
2783         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2784         to verify the positions stored in _FunctionState.
2785
2786 2011-01-13  Eric Seidel  <eric@webkit.org>
2787
2788         Reviewed by David Levin.
2789
2790         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2791         https://bugs.webkit.org/show_bug.cgi?id=49158
2792
2793         This is not the most elegant, but it is a very safe fix to this bug.
2794         One advantage of catching ScriptError like this instead of adding a
2795         new added_or_modified_files or fixing all changed_files callers
2796         to use a more specific change_files variant, is that we catch
2797         all kinds of ScriptErrors which might cause our (non-essential)
2798         suggest-reviewers code to fail out.  This should make passing
2799         --suggest-reviewers to webkit-patch upload much more robust
2800         and may even make it possible for us to make it default.
2801
2802         The root of the problem here is that SCM.changed_files includes
2803         deleted ChangeLog paths (from moves, etc) which then when we ask
2804         SVN/Git for the contents of the file at that revision, the command
2805         errors out and Executive.run_command raises a ScriptError.
2806
2807         In the future we might fix this differently by making all current
2808         callers of chagned_files use a more specific method for requesting
2809         what types of changes they're interested in (adds, modifies, deletes, etc.)
2810
2811         * Scripts/webkitpy/common/checkout/api.py:
2812         * Scripts/webkitpy/common/checkout/api_unittest.py:
2813
2814 2011-01-13  Dan Bernstein  <mitz@apple.com>
2815
2816         Reviewed by Alexey Proskuryakov.
2817
2818         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2819         https://bugs.webkit.org/show_bug.cgi?id=52419
2820
2821         Allow to further control the behavior of the willSendRequest delegate callback by making it
2822         set a different URL in the new request.
2823
2824         * DumpRenderTree/LayoutTestController.cpp:
2825         (addURLToRedirectCallback): Added.
2826         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2827         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2828         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2829         * DumpRenderTree/LayoutTestController.h:
2830         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2831         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2832         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2833         change the URL in the new request to the redirect destination.
2834
2835 2011-01-13  Eric Seidel  <eric@webkit.org>
2836
2837         Reviewed by Mihai Parparita.
2838
2839         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2840         https://bugs.webkit.org/show_bug.cgi?id=52416
2841
2842         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2843         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2844
2845         I also added FIXMEs about the changed_files returning deleted files problem
2846         which is causing the other most common exception for suggest-reviewers
2847         (and is probably breaking sheriff-bots blame detection).
2848
2849         * Scripts/webkitpy/common/checkout/api.py:
2850         * Scripts/webkitpy/common/checkout/api_unittest.py:
2851         * Scripts/webkitpy/common/checkout/scm.py:
2852
2853 2011-01-13  Eric Seidel  <eric@webkit.org>
2854
2855         Reviewed by Adam Barth.
2856
2857         results archives from commit-queue are too large to upload
2858         https://bugs.webkit.org/show_bug.cgi?id=52405
2859
2860         * Scripts/webkitpy/common/system/filesystem.py:
2861         * Scripts/webkitpy/common/system/filesystem_mock.py:
2862         * Scripts/webkitpy/tool/commands/queues.py:
2863
2864 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2865
2866         Reviewed by Martin Robinson.
2867
2868         [gtk] Zero-sized font does not yet work
2869         https://bugs.webkit.org/show_bug.cgi?id=49793
2870
2871         Set minimum-font-size to 0 for the DRT.
2872
2873         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2874         (resetDefaultsToConsistentValues):
2875
2876 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2877
2878         Reviewed by Darin Adler.
2879
2880         Make old-run-webkit-tests more robust on buildbots
2881         https://bugs.webkit.org/show_bug.cgi?id=52364
2882
2883         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2884
2885 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2886
2887         Reviewed by Darin Adler.
2888
2889         Make old-run-webkit-tests more robust on buildbots
2890         https://bugs.webkit.org/show_bug.cgi?id=52364
2891
2892         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2893
2894 2011-01-13  Tony Chang  <tony@chromium.org>
2895
2896         Reviewed by Kent Tamura.
2897
2898         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2899         https://bugs.webkit.org/show_bug.cgi?id=52332
2900
2901         Forked Info.plist is not longer needed.
2902
2903         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2904
2905 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2906
2907         Reviewed by Timothy Hatcher.
2908
2909         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2910         to be passed directly to WebInspector.UIString
2911
2912         https://bugs.webkit.org/show_bug.cgi?id=52365
2913
2914         * Scripts/check-inspector-strings:
2915
2916 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2917
2918         Unreviewed, rolling out r74881.
2919         http://trac.webkit.org/changeset/74881
2920         https://bugs.webkit.org/show_bug.cgi?id=52357
2921
2922         The EFL builder has been red for days (Requested by abarth on
2923         #webkit).
2924
2925         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2926         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2927
2928 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2929
2930         Reviewed by David Levin.
2931
2932         Add beforeunload support to WebKitTestRunner
2933         https://bugs.webkit.org/show_bug.cgi?id=52353
2934         
2935         This makes a number of currently failing tests pass.
2936
2937         * WebKitTestRunner/TestController.cpp:
2938         (WTR::runBeforeUnloadConfirmPanel):
2939         (WTR::createOtherPage):
2940         (WTR::TestController::initialize):
2941
2942 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2943
2944         Reviewed by Sam Weinig.
2945
2946         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2947         https://bugs.webkit.org/show_bug.cgi?id=52330
2948
2949         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2950         a web process crash.
2951         * WebKitTestRunner/TestController.cpp:
2952         (WTR::TestController::initialize): Set up a processDidCrash
2953         callback.
2954         (WTR::TestController::processDidCrash): Report that the Web process
2955         crashed.
2956         * WebKitTestRunner/TestController.h:
2957
2958 2011-01-12  David Levin  <levin@chromium.org>
2959
2960         Reviewed by Shinichiro Hamaji.
2961
2962         check-webkit-style -- close_expression function doesn't work correctly.
2963         https://bugs.webkit.org/show_bug.cgi?id=52272
2964
2965         * Scripts/webkitpy/style/checkers/cpp.py:
2966         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2967         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2968         generally useful (for upcoming code changes).
2969         (close_expression): Changed to use Position for input and output.
2970         Also, fixed many bugs such as only working correctly for parenthesis,
2971         not working correctly if given an offset in a line and not finding
2972         the real closing element if there were multiple closing elements in
2973         the same line.
2974         (detect_functions): Adjusted due to the change in arguments for
2975         close_expression.
2976         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2977         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2978         two positions are the same.
2979         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2980         (CppStyleTest.test_close_expression): Added tests to catch the issues
2981         that were fixed.
2982
2983 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2984
2985         Unreviewed, rolling out r75576.
2986         http://trac.webkit.org/changeset/75576
2987         https://bugs.webkit.org/show_bug.cgi?id=52304
2988
2989         broke rebaseline-chromium-webkit-test (Requested by thakis on
2990         #webkit).
2991
2992         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2993         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2994         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2995         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2996         * Scripts/webkitpy/layout_tests/port/base.py:
2997         * Scripts/webkitpy/layout_tests/port/chromium.py:
2998         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2999         * Scripts/webkitpy/layout_tests/port/test.py:
3000         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3001         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3002         * Scripts/webkitpy/style/checkers/test_expectations.py:
3003         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3004
3005 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3006
3007         Reviewed by Darin Adler.
3008
3009         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
3010         https://bugs.webkit.org/show_bug.cgi?id=52307
3011
3012         * Scripts/old-run-webkit-tests:
3013
3014 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
3015
3016         Reviewed by Martin Robinson.
3017
3018         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
3019         https://bugs.webkit.org/show_bug.cgi?id=50867
3020
3021         Fixed library extention for Mac in webkitdirs.pm and type conflict in
3022         TestNetscapePlugin.cpp 
3023
3024         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
3025         * Scripts/webkitdirs.pm:
3026
3027 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
3028
3029         Reviewed by Pavel Feldman.
3030
3031         Add check-inspector-strings script.
3032
3033         https://bugs.webkit.org/show_bug.cgi?id=52295
3034
3035         * Scripts/check-inspector-strings: Added.
3036
3037 2011-01-12  Adam Roben  <aroben@apple.com>
3038
3039         Advertise the .testnetscape file extension on Windows
3040
3041         Fixes <http://webkit.org/b/52298>
3042         plugins/no-mime-with-valid-extension.html fails on Windows
3043
3044         Reviewed by Dan Bernstein.
3045
3046         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
3047         FileExtents field to map the .testnetscape file extension to the
3048         application/x-webkit-test-netscape MIME type, just as we do on Mac.
3049
3050 2011-01-12  Adam Barth  <abarth@webkit.org>
3051
3052         Reviewed by Eric Seidel.
3053
3054         Make webkit-patch support subdirectories for SVN checkouts
3055         https://bugs.webkit.org/show_bug.cgi?id=52261
3056
3057         os.relpath does not exist on Python 2.5, so we need to call our version
3058         of the API.
3059
3060         * Scripts/webkitpy/common/checkout/scm.py:
3061
3062 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3063
3064         Reviewed by Eric Seidel.
3065
3066         Close additional pages opened during a test once the test completes.
3067         https://bugs.webkit.org/show_bug.cgi?id=52276
3068
3069         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3070         (WTR::InjectedBundle::done):
3071
3072 2011-01-11  David Levin  <levin@chromium.org>
3073
3074         Reviewed by Eric Seidel.
3075
3076         Errors should be separated from the command line in bot messages.
3077         https://bugs.webkit.org/show_bug.cgi?id=52275
3078
3079         * Scripts/webkitpy/common/system/executive.py:
3080         (ScriptError.message_with_output): Added a newline to separate the command
3081         line from the errors.
3082         * Scripts/webkitpy/common/system/executive_unittest.py:
3083         (ScriptErrorTest.test_message_with_output): Added tests for the various code
3084         paths in message_with_output.
3085
3086 2011-01-11  Eric Seidel  <eric@webkit.org>
3087
3088         Unreviewed.
3089
3090         commit-queue should know how to upload archived results (for test flakes or general failures)
3091         https://bugs.webkit.org/show_bug.cgi?id=52048
3092
3093         The zips are mostly empty due to forgetting -r.
3094         Expected diffs were not being pulled from the archive due
3095         to the archive having longer paths than I realized.
3096
3097         * Scripts/webkitpy/common/system/workspace.py:
3098         * Scripts/webkitpy/common/system/workspace_unittest.py:
3099         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3100         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3101
3102 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
3103
3104         Reviewed by Ojan Vafai.
3105
3106         The current modifier parsing code in test_expectations is
3107         fragile and hard-coded, so it's not easy to understand the logic
3108         or easily add new types of modifiers (like GPU vs. CPU testing
3109         for graphics tests, or 32-bit vs. 64-bit differences).
3110
3111         This is the first of two patches that will add in more generic
3112         support and then eliminate the GPU-specific test expectations
3113         files for Chromium.
3114
3115         This patch adds two standalone objects for handling modifiers. The
3116         rules for interpreting modifiers, precedence, and conflicts are
3117         given in the docstring to the ModifierMatcher class, which
3118         returns ModifierMatchResult objects.
3119         
3120         This patch also adds routines to the Port interface and a
3121         default set of values in the base object, in order to obtain the
3122         values needed on a given test run. These values are then passed
3123         to the expectation parser. This also allows us to clean up the
3124         logic used to lint all of the different configurations in a
3125         single test_expectations.txt file.
3126
3127         The next patch will merge in the separate GPU expectations file.
3128
3129         https://bugs.webkit.org/show_bug.cgi?id=51222
3130
3131         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3132         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3133         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3134         * Scripts/webkitpy/layout_tests/port/base.py:
3135         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3136         * Scripts/webkitpy/layout_tests/port/chromium.py:
3137         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3138         * Scripts/webkitpy/layout_tests/port/test.py:
3139         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3140         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3141
3142 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3143
3144         Reviewed by Adam Barth.
3145
3146         Make webkit-patch support subdirectories for SVN checkouts
3147         https://bugs.webkit.org/show_bug.cgi?id=52261
3148
3149         * Scripts/webkitpy/common/checkout/scm.py:
3150         * Scripts/webkitpy/style_references.py:
3151         * Scripts/webkitpy/tool/main.py:
3152         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3153
3154 2011-01-11  Eric Seidel  <eric@webkit.org>
3155
3156         Unreviewed.
3157
3158         commit-queue should know how to upload archived results (for test flakes or general failures)
3159         https://bugs.webkit.org/show_bug.cgi?id=52048
3160
3161         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3162         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3163
3164         * Scripts/webkitpy/common/system/workspace.py:
3165         * Scripts/webkitpy/common/system/workspace_unittest.py:
3166         * Scripts/webkitpy/tool/commands/queues.py:
3167
3168 2011-01-11  Sam Weinig  <sam@webkit.org>
3169
3170         Roll r75474 back in.
3171
3172 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3173
3174         Reviewed by Kenneth Rohde Christiansen.
3175
3176         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3177         https://bugs.webkit.org/show_bug.cgi?id=51204
3178
3179         * QtTestBrowser/webpage.h:
3180         (QtNAMThread::QtNAMThread):
3181         (QtNAMThread::networkAccessManager):
3182         (QtNAMThread::run):
3183
3184 2011-01-11  Peter Varga  <pvarga@webkit.org>
3185
3186         Unreviewed.
3187
3188         Add myself to committers' list.
3189
3190         * Scripts/webkitpy/common/config/committers.py:
3191
3192 2011-01-11  Eric Seidel  <eric@webkit.org>
3193
3194         Reviewed by Adam Barth.
3195
3196         commit-queue should know how to upload archived results (for test flakes or general failures)
3197         https://bugs.webkit.org/show_bug.cgi?id=52048
3198
3199         Now the queue will always upload results.  Either the entire zip, or just
3200         the diffs.txt in the case of text failures.
3201
3202         This should make understanding flakes much easier, and paves the way
3203         for having the EWS run layout tests (and upload failures).
3204
3205         In order to upload .zip files I had to teach bugzilla.py to autodetect
3206         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3207         for .patch files, I have it add one before calling guess_type.
3208
3209         We may find that always uploading the whole zip instead of just the -diffs.txt
3210         file is preferable, but for now I'm keeping the old behavior because it makes
3211         quickly understanding text failures easy.
3212
3213         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3214         * Scripts/webkitpy/common/system/workspace.py: Added.
3215         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3216         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3217         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3218         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3219         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3220         * Scripts/webkitpy/tool/commands/queues.py:
3221         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3222
3223 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3224
3225         Unreviewed, rolling out r75464.
3226         http://trac.webkit.org/changeset/75464
3227         https://bugs.webkit.org/show_bug.cgi?id=52193
3228
3229         Followup rollout for 75474 (Requested by Ossy on #webkit).
3230
3231         * MiniBrowser/mac/BrowserWindowController.m:
3232         (-[BrowserWindowController awakeFromNib]):
3233         * MiniBrowser/win/BrowserView.cpp:
3234         (BrowserView::create):
3235         * WebKitTestRunner/TestController.cpp:
3236         (WTR::createOtherPage):
3237         (WTR::TestController::initialize):
3238
3239 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3240
3241         Reviewed by Csaba Osztrogonác.
3242
3243         [Qt] Baseline qt_minimal configuration
3244         https://bugs.webkit.org/show_bug.cgi?id=51313
3245
3246         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3247         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3248         QT_NO_UNDOSTACK guard.
3249
3250         * QtTestBrowser/launcherwindow.cpp:
3251         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3252         guards.
3253         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3254         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3255         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3256         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3257
3258         * QtTestBrowser/launcherwindow.h:
3259         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3260         * QtTestBrowser/locationedit.h: Ditto.
3261
3262         * QtTestBrowser/mainwindow.cpp:
3263         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3264         QT_NO_UNDOSTACK guards.
3265         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3266         (MainWindow::changeLocation): Ditto.
3267         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3268         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3269
3270         * QtTestBrowser/webpage.cpp:
3271         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3272         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3273
3274         * QtTestBrowser/webview.cpp:
3275         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3276         (WebViewGraphicsBased::animatedYFlip): Ditto.
3277
3278 2011-01-10  Sam Weinig  <sam@webkit.org>
3279
3280         Fix build.
3281
3282         * MiniBrowser/mac/BrowserWindowController.m:
3283         (-[BrowserWindowController awakeFromNib]):
3284         * MiniBrowser/win/BrowserView.cpp:
3285         (BrowserView::create):
3286         * WebKitTestRunner/TestController.cpp:
3287         (WTR::createOtherPage):
3288         (WTR::TestController::initialize):
3289
3290 2011-01-10  Eric Seidel  <eric@webkit.org>
3291
3292         Reviewed by Ojan Vafai.
3293
3294         style-queue messages are way too long for big patches
3295         https://bugs.webkit.org/show_bug.cgi?id=52161
3296
3297         We definitely could build much fancier list-to-string-with-limit functions
3298         but this should be sufficient for our needs at the moment.
3299
3300         * Scripts/webkitpy/common/system/executive.py:
3301         * Scripts/webkitpy/common/system/executive_unittest.py:
3302
3303 2011-01-10  Tony Chang  <tony@chromium.org>
3304
3305         Unreviewed, rolling out r75398.
3306         http://trac.webkit.org/changeset/75398
3307         https://bugs.webkit.org/show_bug.cgi?id=52008
3308
3309         Some layout tests are crashing on Chromium Win.
3310
3311         * DumpRenderTree/chromium/WebViewHost.cpp:
3312         (WebViewHost::updatePaintRect):
3313         * DumpRenderTree/chromium/WebViewHost.h:
3314
3315 2011-01-10  Adam Roben  <aroben@apple.com>
3316
3317         Roll out r75392
3318
3319         It isn't needed now that r75289 has been rolled out.
3320
3321         * Scripts/run-javascriptcore-tests:
3322
3323 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3324
3325         Reviewed by Anders Carlsson.
3326
3327         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3328         https://bugs.webkit.org/show_bug.cgi?id=52160
3329
3330         * WebKitTestRunner/mac/TestControllerMac.mm:
3331         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3332         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3333         anyway.
3334
3335 2011-01-10  Tony Chang  <tony@chromium.org>
3336
3337         Reviewed by Mihai Parparita.
3338
3339         [chromium] fix for animated gif layout tests
3340         https://bugs.webkit.org/show_bug.cgi?id=52008
3341
3342         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3343             to trigger gif animations.
3344         (WebViewHostPaintTask::WebViewHostPaintTask):
3345         (WebViewHostPaintTask::runIfValid):
3346         (WebViewHost::updatePaintRect):
3347         * DumpRenderTree/chromium/WebViewHost.h:
3348         (WebViewHost::taskList):
3349
3350 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3351
3352         Reviewed by Xan Lopez.
3353
3354         [GTK] Fix gtk2 compilation for master
3355         https://bugs.webkit.org/show_bug.cgi?id=51885
3356
3357         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3358         (createBitmapContextFromWebView): Replaced the old
3359         gdk_drawable_get_size with gdk_pixmap_get_size.
3360
3361 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3362
3363         Reviewed by Laszlo Gombos.
3364
3365         [WINCE] Reenable NPAPI after r75203
3366         https://bugs.webkit.org/show_bug.cgi?id=52109
3367
3368         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3369         it with !isEfl(), because EFL port does not support NPAPI (yet).
3370
3371         * Scripts/build-webkit:
3372
3373 2011-01-10  Adam Roben  <aroben@apple.com>
3374
3375         Skip some asserting JS tests
3376
3377         See <http://webkit.org/b/52156>.
3378
3379         * Scripts/run-javascriptcore-tests:
3380
3381 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3382
3383         Reviewed by Xan Lopez.
3384
3385         [GTK] build-webkit disable Blob support via arguments passed to automake
3386         https://bugs.webkit.org/show_bug.cgi?id=52097
3387
3388         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3389         build-webkit.
3390
3391 2011-01-10  Adam Roben  <aroben@apple.com>
3392
3393         Use the same name and description for TestNetscapePlugin on Windows and
3394         Mac
3395
3396         Fixes <http://webkit.org/b/52151>
3397         fast/frames/iframe-reparenting-plugins.html fails on Windows
3398
3399         Reviewed by Steve Falkenburg.
3400
3401         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3402         the name and description from Mac's Info.plist.
3403
3404 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3405
3406         Reviewed by Laszlo Gombos.
3407
3408         [Qt][WK2] Guard gcc-specific syntax
3409
3410         Non-gcc based compliers choke on the "-include"
3411         syntax for preinclude, place guard around it.
3412
3413         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3414         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3415
3416 2011-01-10  Andreas Kling  <kling@webkit.org>
3417
3418         Reviewed by Simon Hausmann.
3419
3420         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3421         https://bugs.webkit.org/show_bug.cgi?id=52111
3422
3423         When getting a createNewPage() callback from QWKPage, create the
3424         new page with the same QWKContext as the page that is passed to
3425         the callback.
3426
3427         * MiniBrowser/qt/BrowserView.h:
3428         * MiniBrowser/qt/BrowserWindow.cpp:
3429         (newPageFunction):
3430         (BrowserWindow::BrowserWindow):
3431         * MiniBrowser/qt/BrowserWindow.h:
3432
3433 2011-01-10  Andreas Kling  <kling@webkit.org>
3434
3435         Reviewed by Kenneth Rohde Christiansen.
3436
3437         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3438
3439         BrowserView set its own useless createNewPage() callback on QWKPage.
3440         This was immediately overridden by BrowserWindow anyway, so remove
3441         the BrowserView one.
3442
3443         * MiniBrowser/qt/BrowserView.cpp:
3444         (BrowserView::BrowserView):
3445
3446 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3447
3448         Reviewed by Jeremy Orlow.
3449
3450         [Chromium] Remove non-client-based Geolocation code
3451         https://bugs.webkit.org/show_bug.cgi?id=50921
3452
3453         * DumpRenderTree/chromium/LayoutTestController.cpp:
3454         (LayoutTestController::setGeolocationPermission):
3455         (LayoutTestController::setMockGeolocationPosition):
3456         (LayoutTestController::setMockGeolocationError):
3457         * DumpRenderTree/chromium/WebViewHost.cpp:
3458         (WebViewHost::geolocationClientMock):
3459         (WebViewHost::reset):
3460         * DumpRenderTree/chromium/WebViewHost.h:
3461
3462 2011-01-10  Eric Seidel  <eric@webkit.org>
3463
3464         Reviewed by Adam Barth.
3465
3466         Commit bot tried to land r? cq+ patch
3467         https://bugs.webkit.org/show_bug.cgi?id=36638
3468
3469         It should now be possible to post a patch with r? and cq+ and the
3470         commit-queue will correctly wait for the r+ before attempting to land the patch.
3471         (This was a feature requested by several users.)
3472
3473         One caveat: We don't actually reject r-, cq+ patches from the queue
3474         (we just ignore them), but I think that's OK for now.
3475
3476         I also noticed that setting r- once a commit-queue node had grabbed
3477         a patch would not properly cancel the landing.  That's fixed and
3478         tested in this patch.
3479
3480         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3481         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3482         * Scripts/webkitpy/tool/bot/feeders.py:
3483         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3484
3485 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3486
3487         Reviewed by Kenneth Rohde Christiansen.
3488
3489         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3490         https://bugs.webkit.org/show_bug.cgi?id=51934
3491
3492         When accessing the network from the destructor of QWebPage, the network access manager
3493         was already deleted because the object WebPage was already destructed.
3494
3495         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3496         The object is now destructed in the destructor of QObject.
3497
3498         * QtTestBrowser/webpage.cpp:
3499         (WebPage::WebPage):
3500         (WebPage::setQnamThreaded):
3501         * QtTestBrowser/webpage.h:
3502         (QtNAMThread::QtNAMThread):
3503
3504 2011-01-08  Eric Seidel  <eric@webkit.org>
3505
3506         Reviewed by Ojan Vafai.
3507
3508         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3509         https://bugs.webkit.org/show_bug.cgi?id=52067
3510
3511         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3512         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3513
3514         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3515
3516 2011-01-08  Eric Seidel  <eric@webkit.org>
3517
3518         Reviewed by Mihai Parparita.
3519
3520         commit-queue hangs when the ChangeLog diff is bad
3521         https://bugs.webkit.org/show_bug.cgi?id=52072
3522
3523         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3524         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3525
3526 2011-01-08  Adam Barth  <abarth@webkit.org>
3527
3528         Teach svn-apply how to re-write WebCore to Source/WebCore.
3529
3530         * Scripts/VCSUtils.pm:
3531
3532 2011-01-07  Adam Barth  <abarth@webkit.org>
3533
3534         Rubber-stamped by Eric Seidel.
3535
3536         Move WebCore to Source
3537         https://bugs.webkit.org/show_bug.cgi?id=52050
3538
3539         Update the tools to understand WebCore's new location.
3540
3541         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3542         * DumpRenderTree/wscript:
3543         * GNUmakefile.am:
3544         * Scripts/build-webkit:
3545         * Scripts/do-file-rename:
3546         * Scripts/do-webcore-rename:
3547         * Scripts/generate-qt-inspector-resource:
3548         * Scripts/prepare-ChangeLog:
3549         * Scripts/run-bindings-tests:
3550         * Scripts/update-iexploder-cssproperties:
3551         * Scripts/update-sources-list.py:
3552         * Scripts/update-webkit-localizable-strings:
3553         * Scripts/webkitdirs.pm:
3554         * Scripts/webkitpy/common/config/build.py:
3555         * Scripts/webkitpy/common/config/build_unittest.py:
3556         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3557         * Scripts/webkitpy/style/checker.py:
3558         * Scripts/webkitpy/style/checker_unittest.py:
3559         * WebKitTestRunner/DerivedSources.pro:
3560         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3561         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3562         * wx/browser/wscript:
3563         * wx/build/settings.py:
3564
3565 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3566
3567         Reviewed by Sam Weinig.
3568
3569         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3570         https://bugs.webkit.org/show_bug.cgi?id=52086
3571
3572         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3573         (WTR::InjectedBundle::didReceiveMessage):
3574         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3575         (WTR::LayoutTestController::notifyDone):
3576         * WebKitTestRunner/TestController.cpp:
3577         (WTR::TestController::resetStateToConsistentValues):
3578         (WTR::TestController::run):
3579
3580 2011-01-07  James Robinson  <jamesr@chromium.org>
3581
3582         Revert "Implement mozilla's animationTime property"
3583         https://bugs.webkit.org/show_bug.cgi?id=51952
3584
3585         This approach isn't quite right.
3586
3587         * DumpRenderTree/chromium/WebViewHost.cpp:
3588         (WebViewHost::paintInvalidatedRegion):
3589
3590 2011-01-07  Adam Roben  <aroben@apple.com>
3591
3592         Build master fix
3593
3594         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3595         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3596
3597 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3598
3599         Reviewed by Csaba Osztrogonác.
3600
3601         run-qtwebkit-tests should be able to kill a testsuite.
3602
3603         Add new option in the script that can setup a timeout for a test.
3604         If the test execution takes more then specified time then the test
3605         would be terminated.
3606
3607         [Qt] run-qtwebkit-tests needs timeout
3608         https://bugs.webkit.org/show_bug.cgi?id=51894
3609
3610         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3611         * Scripts/run-qtwebkit-tests:
3612
3613 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3614
3615         Unreviewed fix after r75233.
3616
3617         Based on idea from Eric Seidel.
3618
3619         Add remote zip file handling to webkitpy.
3620         https://bugs.webkit.org/show_bug.cgi?id=50901
3621
3622         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3623
3624 2011-01-07  Shane Stephens  <shanestephens@google.com>
3625
3626         Reviewed by Eric Seidel.
3627
3628         svn-apply: should support git binary delta diffs
3629         https://bugs.webkit.org/show_bug.cgi?id=38864
3630
3631         * Scripts/VCSUtils.pm:
3632         * Scripts/svn-apply:
3633
3634 2011-01-06  Julie Parent  <jparent@chromium.org>
3635
3636         Reviewed by Eric Seidel.
3637
3638         Test Result Server not removing old results.
3639         https://bugs.webkit.org/show_bug.cgi?id=52012
3640
3641         * TestResultServer/model/jsonresults.py:
3642         Fix off-by-one: Truncate if >= num_runs, not just >.
3643         * TestResultServer/model/jsonresults_unittest.py:
3644         Add unit test to test that merging in a new result with the same value
3645         as the last result causes previous result to fall off.
3646
3647 2011-01-06  James Kozianski  <koz@chromium.org>
3648
3649         Reviewed by Mihai Parparita.
3650
3651         Add classes to provide a consistent interface to a set of files.
3652         https://bugs.webkit.org/show_bug.cgi?id=50901
3653
3654         These classes allow us to write code that is agnostic to whether a
3655         particular set of files resides in a local directory or in a zip file
3656         on a remote machine.
3657
3658         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3659         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3660         * Scripts/webkitpy/common/system/fileset.py: Added.
3661         * Scripts/webkitpy/common/system/filesystem.py:
3662         * Scripts/webkitpy/common/system/filesystem_mock.py:
3663         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3664         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3665
3666 2011-01-06  Eric Seidel  <eric@webkit.org>
3667
3668         Reviewed by Adam Barth.
3669
3670         NetworkTransaction should log the url it is retrying
3671         https://bugs.webkit.org/show_bug.cgi?id=52043
3672
3673         * Scripts/webkitpy/common/net/networktransaction.py:
3674         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3675
3676 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3677
3678         Windows build fix.
3679         Import os before using it.
3680
3681         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3682
3683 2011-01-06  Eric Seidel  <eric@webkit.org>
3684
3685         Reviewed by Adam Barth.
3686
3687         StyleQueue fails to report errors when patches have many files
3688         https://bugs.webkit.org/show_bug.cgi?id=52042
3689
3690         This is one of at least two errors preventing style error reporting at the moment.
3691         When we moved to passing the list of files to check explicitly,
3692         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3693         We could change the type of the QueueStatus.message type, or we could
3694         just teach statusserver.py how to clamp values (and warn when it does).
3695         I chose the latter path.
3696
3697         * Scripts/webkitpy/common/net/statusserver.py:
3698
3699 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3700
3701         Reviewed by Stephanie Lewis.
3702         
3703         Fix syntax error in script.
3704
3705         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3706         https://bugs.webkit.org/show_bug.cgi?id=51996
3707
3708         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3709
3710 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3711
3712         Unreviewed, fixing WinCE build after r75196.
3713
3714         WinCE port does not (yet) support NPAPI.
3715
3716         * Scripts/build-webkit:
3717
3718 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3719
3720         Reviewed by Darin Adler.
3721
3722         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3723         https://bugs.webkit.org/show_bug.cgi?id=52015
3724
3725         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3726         after the platform has been detected, otherwise the script will
3727         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3728         detection.
3729
3730 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3731
3732         Reviewed by Eric Seidel.
3733
3734         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3735         https://bugs.webkit.org/show_bug.cgi?id=51346
3736
3737         * Scripts/build-webkit:
3738
3739 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3740
3741         Reviewed by Adam Roben.
3742
3743         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3744         https://bugs.webkit.org/show_bug.cgi?id=51996
3745         
3746         After the configuration directory change, we were archiving the incorrect directory for
3747         build product, so we were running tests on the wrong binaries.
3748         
3749         This change archives the correct directory, and also unarchives it into a configuration-
3750         specific directory.
3751
3752         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3753         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3754
3755 2011-01-06  Eric Seidel  <eric@webkit.org>
3756
3757         Reviewed by Mihai Parparita.
3758
3759         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3760         https://bugs.webkit.org/show_bug.cgi?id=52002
3761
3762         See an example of this here:
3763         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3764
3765         It's due to the fact that we pass around TestFailure() instance
3766         objects and yet expect them to all compare to be the same.
3767
3768         This is bad.  We should either have shared instances of these values
3769         or we should just pass around the class names.  There are already hacks
3770         in place to make TestFailure objects pass equality tests, I just added
3771         a __hash__ implementation so they can be used in sets as expected.
3772
3773         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3774         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3775
3776 2011-01-06  Evan Martin  <evan@chromium.org>
3777
3778         Reviewed by Tony Chang.
3779
3780         [gdb] handle inaccessible memory and UChar*
3781         https://bugs.webkit.org/show_bug.cgi?id=52003
3782
3783         To pretty-print a UChar*, we just grope around in the memory
3784         looking for a terminating NUL.  We need to handle the exception
3785         that can occur when we poke into an invalid location.
3786
3787         Additionally, the logic for choosing which pretty-printer would
3788         early return before hitting the point where we'd use the UChar*
3789         printer.  (Did this ever work?  How did it regress?)
3790
3791         * gdb/webkit.py:
3792
3793 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3794
3795         Reviewed by Ada Chan.
3796
3797         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3798         https://bugs.webkit.org/show_bug.cgi?id=51969
3799