2011-01-10 Evan Martin <evan@chromium.org>
[WebKit.git] / Tools / ChangeLog
1 2011-01-10  Tony Chang  <tony@chromium.org>
2
3         Reviewed by Mihai Parparita.
4
5         [chromium] fix for animated gif layout tests
6         https://bugs.webkit.org/show_bug.cgi?id=52008
7
8         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
9             to trigger gif animations.
10         (WebViewHostPaintTask::WebViewHostPaintTask):
11         (WebViewHostPaintTask::runIfValid):
12         (WebViewHost::updatePaintRect):
13         * DumpRenderTree/chromium/WebViewHost.h:
14         (WebViewHost::taskList):
15
16 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
17
18         Reviewed by Xan Lopez.
19
20         [GTK] Fix gtk2 compilation for master
21         https://bugs.webkit.org/show_bug.cgi?id=51885
22
23         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
24         (createBitmapContextFromWebView): Replaced the old
25         gdk_drawable_get_size with gdk_pixmap_get_size.
26
27 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
28
29         Reviewed by Laszlo Gombos.
30
31         [WINCE] Reenable NPAPI after r75203
32         https://bugs.webkit.org/show_bug.cgi?id=52109
33
34         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
35         it with !isEfl(), because EFL port does not support NPAPI (yet).
36
37         * Scripts/build-webkit:
38
39 2011-01-10  Adam Roben  <aroben@apple.com>
40
41         Skip some asserting JS tests
42
43         See <http://webkit.org/b/52156>.
44
45         * Scripts/run-javascriptcore-tests:
46
47 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
48
49         Reviewed by Xan Lopez.
50
51         [GTK] build-webkit disable Blob support via arguments passed to automake
52         https://bugs.webkit.org/show_bug.cgi?id=52097
53
54         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
55         build-webkit.
56
57 2011-01-10  Adam Roben  <aroben@apple.com>
58
59         Use the same name and description for TestNetscapePlugin on Windows and
60         Mac
61
62         Fixes <http://webkit.org/b/52151>
63         fast/frames/iframe-reparenting-plugins.html fails on Windows
64
65         Reviewed by Steve Falkenburg.
66
67         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
68         the name and description from Mac's Info.plist.
69
70 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
71
72         Reviewed by Laszlo Gombos.
73
74         [Qt][WK2] Guard gcc-specific syntax
75
76         Non-gcc based compliers choke on the "-include"
77         syntax for preinclude, place guard around it.
78
79         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
80         * WebKitTestRunner/qt/WebKitTestRunner.pro:
81
82 2011-01-10  Andreas Kling  <kling@webkit.org>
83
84         Reviewed by Simon Hausmann.
85
86         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
87         https://bugs.webkit.org/show_bug.cgi?id=52111
88
89         When getting a createNewPage() callback from QWKPage, create the
90         new page with the same QWKContext as the page that is passed to
91         the callback.
92
93         * MiniBrowser/qt/BrowserView.h:
94         * MiniBrowser/qt/BrowserWindow.cpp:
95         (newPageFunction):
96         (BrowserWindow::BrowserWindow):
97         * MiniBrowser/qt/BrowserWindow.h:
98
99 2011-01-10  Andreas Kling  <kling@webkit.org>
100
101         Reviewed by Kenneth Rohde Christiansen.
102
103         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
104
105         BrowserView set its own useless createNewPage() callback on QWKPage.
106         This was immediately overridden by BrowserWindow anyway, so remove
107         the BrowserView one.
108
109         * MiniBrowser/qt/BrowserView.cpp:
110         (BrowserView::BrowserView):
111
112 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
113
114         Reviewed by Jeremy Orlow.
115
116         [Chromium] Remove non-client-based Geolocation code
117         https://bugs.webkit.org/show_bug.cgi?id=50921
118
119         * DumpRenderTree/chromium/LayoutTestController.cpp:
120         (LayoutTestController::setGeolocationPermission):
121         (LayoutTestController::setMockGeolocationPosition):
122         (LayoutTestController::setMockGeolocationError):
123         * DumpRenderTree/chromium/WebViewHost.cpp:
124         (WebViewHost::geolocationClientMock):
125         (WebViewHost::reset):
126         * DumpRenderTree/chromium/WebViewHost.h:
127
128 2011-01-10  Eric Seidel  <eric@webkit.org>
129
130         Reviewed by Adam Barth.
131
132         Commit bot tried to land r? cq+ patch
133         https://bugs.webkit.org/show_bug.cgi?id=36638
134
135         It should now be possible to post a patch with r? and cq+ and the
136         commit-queue will correctly wait for the r+ before attempting to land the patch.
137         (This was a feature requested by several users.)
138
139         One caveat: We don't actually reject r-, cq+ patches from the queue
140         (we just ignore them), but I think that's OK for now.
141
142         I also noticed that setting r- once a commit-queue node had grabbed
143         a patch would not properly cancel the landing.  That's fixed and
144         tested in this patch.
145
146         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
147         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
148         * Scripts/webkitpy/tool/bot/feeders.py:
149         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
150
151 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
152
153         Reviewed by Kenneth Rohde Christiansen.
154
155         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
156         https://bugs.webkit.org/show_bug.cgi?id=51934
157
158         When accessing the network from the destructor of QWebPage, the network access manager
159         was already deleted because the object WebPage was already destructed.
160
161         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
162         The object is now destructed in the destructor of QObject.
163
164         * QtTestBrowser/webpage.cpp:
165         (WebPage::WebPage):
166         (WebPage::setQnamThreaded):
167         * QtTestBrowser/webpage.h:
168         (QtNAMThread::QtNAMThread):
169
170 2011-01-08  Eric Seidel  <eric@webkit.org>
171
172         Reviewed by Ojan Vafai.
173
174         test_failures.py should not mention TestShell (long live DumpRenderTree!)
175         https://bugs.webkit.org/show_bug.cgi?id=52067
176
177         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
178         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
179
180         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
181
182 2011-01-08  Eric Seidel  <eric@webkit.org>
183
184         Reviewed by Mihai Parparita.
185
186         commit-queue hangs when the ChangeLog diff is bad
187         https://bugs.webkit.org/show_bug.cgi?id=52072
188
189         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
190         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
191
192 2011-01-08  Adam Barth  <abarth@webkit.org>
193
194         Teach svn-apply how to re-write WebCore to Source/WebCore.
195
196         * Scripts/VCSUtils.pm:
197
198 2011-01-07  Adam Barth  <abarth@webkit.org>
199
200         Rubber-stamped by Eric Seidel.
201
202         Move WebCore to Source
203         https://bugs.webkit.org/show_bug.cgi?id=52050
204
205         Update the tools to understand WebCore's new location.
206
207         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
208         * DumpRenderTree/wscript:
209         * GNUmakefile.am:
210         * Scripts/build-webkit:
211         * Scripts/do-file-rename:
212         * Scripts/do-webcore-rename:
213         * Scripts/generate-qt-inspector-resource:
214         * Scripts/prepare-ChangeLog:
215         * Scripts/run-bindings-tests:
216         * Scripts/update-iexploder-cssproperties:
217         * Scripts/update-sources-list.py:
218         * Scripts/update-webkit-localizable-strings:
219         * Scripts/webkitdirs.pm:
220         * Scripts/webkitpy/common/config/build.py:
221         * Scripts/webkitpy/common/config/build_unittest.py:
222         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
223         * Scripts/webkitpy/style/checker.py:
224         * Scripts/webkitpy/style/checker_unittest.py:
225         * WebKitTestRunner/DerivedSources.pro:
226         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
227         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
228         * wx/browser/wscript:
229         * wx/build/settings.py:
230
231 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
232
233         Reviewed by Sam Weinig.
234
235         Make WebKitTestRunner rest between loads more robust to avoid test crashes
236         https://bugs.webkit.org/show_bug.cgi?id=52086
237
238         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
239         (WTR::InjectedBundle::didReceiveMessage):
240         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
241         (WTR::LayoutTestController::notifyDone):
242         * WebKitTestRunner/TestController.cpp:
243         (WTR::TestController::resetStateToConsistentValues):
244         (WTR::TestController::run):
245
246 2011-01-07  James Robinson  <jamesr@chromium.org>
247
248         Revert "Implement mozilla's animationTime property"
249         https://bugs.webkit.org/show_bug.cgi?id=51952
250
251         This approach isn't quite right.
252
253         * DumpRenderTree/chromium/WebViewHost.cpp:
254         (WebViewHost::paintInvalidatedRegion):
255
256 2011-01-07  Adam Roben  <aroben@apple.com>
257
258         Build master fix
259
260         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
261         (RunWebKitTests.start): Don't try to concatenate a list and a string.
262
263 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
264
265         Reviewed by Csaba Osztrogonác.
266
267         run-qtwebkit-tests should be able to kill a testsuite.
268
269         Add new option in the script that can setup a timeout for a test.
270         If the test execution takes more then specified time then the test
271         would be terminated.
272
273         [Qt] run-qtwebkit-tests needs timeout
274         https://bugs.webkit.org/show_bug.cgi?id=51894
275
276         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
277         * Scripts/run-qtwebkit-tests:
278
279 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
280
281         Unreviewed fix after r75233.
282
283         Based on idea from Eric Seidel.
284
285         Add remote zip file handling to webkitpy.
286         https://bugs.webkit.org/show_bug.cgi?id=50901
287
288         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
289
290 2011-01-07  Shane Stephens  <shanestephens@google.com>
291
292         Reviewed by Eric Seidel.
293
294         svn-apply: should support git binary delta diffs
295         https://bugs.webkit.org/show_bug.cgi?id=38864
296
297         * Scripts/VCSUtils.pm:
298         * Scripts/svn-apply:
299
300 2011-01-06  Julie Parent  <jparent@chromium.org>
301
302         Reviewed by Eric Seidel.
303
304         Test Result Server not removing old results.
305         https://bugs.webkit.org/show_bug.cgi?id=52012
306
307         * TestResultServer/model/jsonresults.py:
308         Fix off-by-one: Truncate if >= num_runs, not just >.
309         * TestResultServer/model/jsonresults_unittest.py:
310         Add unit test to test that merging in a new result with the same value
311         as the last result causes previous result to fall off.
312
313 2011-01-06  James Kozianski  <koz@chromium.org>
314
315         Reviewed by Mihai Parparita.
316
317         Add classes to provide a consistent interface to a set of files.
318         https://bugs.webkit.org/show_bug.cgi?id=50901
319
320         These classes allow us to write code that is agnostic to whether a
321         particular set of files resides in a local directory or in a zip file
322         on a remote machine.
323
324         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
325         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
326         * Scripts/webkitpy/common/system/fileset.py: Added.
327         * Scripts/webkitpy/common/system/filesystem.py:
328         * Scripts/webkitpy/common/system/filesystem_mock.py:
329         * Scripts/webkitpy/common/system/zipfileset.py: Added.
330         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
331
332 2011-01-06  Eric Seidel  <eric@webkit.org>
333
334         Reviewed by Adam Barth.
335
336         NetworkTransaction should log the url it is retrying
337         https://bugs.webkit.org/show_bug.cgi?id=52043
338
339         * Scripts/webkitpy/common/net/networktransaction.py:
340         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
341
342 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
343
344         Windows build fix.
345         Import os before using it.
346
347         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
348
349 2011-01-06  Eric Seidel  <eric@webkit.org>
350
351         Reviewed by Adam Barth.
352
353         StyleQueue fails to report errors when patches have many files
354         https://bugs.webkit.org/show_bug.cgi?id=52042
355
356         This is one of at least two errors preventing style error reporting at the moment.
357         When we moved to passing the list of files to check explicitly,
358         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
359         We could change the type of the QueueStatus.message type, or we could
360         just teach statusserver.py how to clamp values (and warn when it does).
361         I chose the latter path.
362
363         * Scripts/webkitpy/common/net/statusserver.py:
364
365 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
366
367         Reviewed by Stephanie Lewis.
368         
369         Fix syntax error in script.
370
371         Windows bots need to archive/unarchive builds to/from configuration-specific directories
372         https://bugs.webkit.org/show_bug.cgi?id=51996
373
374         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
375
376 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
377
378         Unreviewed, fixing WinCE build after r75196.
379
380         WinCE port does not (yet) support NPAPI.
381
382         * Scripts/build-webkit:
383
384 2011-01-06  Xan Lopez  <xlopez@igalia.com>
385
386         Reviewed by Darin Adler.
387
388         File::Spec->rel2abs in sunspider-compare-results mangles parameters
389         https://bugs.webkit.org/show_bug.cgi?id=52015
390
391         * Scripts/sunspider-compare-results: call rel2abs on our arguments
392         after the platform has been detected, otherwise the script will
393         mangle things like '--gtk' into '/a/path/--gtk', breaking the
394         detection.
395
396 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
397
398         Reviewed by Eric Seidel.
399
400         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
401         https://bugs.webkit.org/show_bug.cgi?id=51346
402
403         * Scripts/build-webkit:
404
405 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
406
407         Reviewed by Adam Roben.
408
409         Windows bots need to archive/unarchive builds to/from configuration-specific directories
410         https://bugs.webkit.org/show_bug.cgi?id=51996
411         
412         After the configuration directory change, we were archiving the incorrect directory for
413         build product, so we were running tests on the wrong binaries.
414         
415         This change archives the correct directory, and also unarchives it into a configuration-
416         specific directory.
417
418         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
419         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
420
421 2011-01-06  Eric Seidel  <eric@webkit.org>
422
423         Reviewed by Mihai Parparita.
424
425         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
426         https://bugs.webkit.org/show_bug.cgi?id=52002
427
428         See an example of this here:
429         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
430
431         It's due to the fact that we pass around TestFailure() instance
432         objects and yet expect them to all compare to be the same.
433
434         This is bad.  We should either have shared instances of these values
435         or we should just pass around the class names.  There are already hacks
436         in place to make TestFailure objects pass equality tests, I just added
437         a __hash__ implementation so they can be used in sets as expected.
438
439         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
440         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
441
442 2011-01-06  Evan Martin  <evan@chromium.org>
443
444         Reviewed by Tony Chang.
445
446         [gdb] handle inaccessible memory and UChar*
447         https://bugs.webkit.org/show_bug.cgi?id=52003
448
449         To pretty-print a UChar*, we just grope around in the memory
450         looking for a terminating NUL.  We need to handle the exception
451         that can occur when we poke into an invalid location.
452
453         Additionally, the logic for choosing which pretty-printer would
454         early return before hitting the point where we'd use the UChar*
455         printer.  (Did this ever work?  How did it regress?)
456
457         * gdb/webkit.py:
458
459 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
460
461         Reviewed by Ada Chan.
462
463         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
464         https://bugs.webkit.org/show_bug.cgi?id=51969
465         
466         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
467
468         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
469         (WTR::InjectedBundlePage::InjectedBundlePage):
470         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
471         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
472
473 2011-01-06  James Robinson  <jamesr@chromium.org>
474
475         Reviewed by Simon Fraser.
476
477         Implement mozilla's animationTime property
478         https://bugs.webkit.org/show_bug.cgi?id=51952
479
480         Chromium DRT support for webkitAnimationTime.
481
482         * DumpRenderTree/chromium/WebViewHost.cpp:
483         (WebViewHost::paintInvalidatedRegion):
484
485 2011-01-06  Julie Parent  <jparent@chromium.org>
486
487         Reviewed by Tony Chang.
488
489         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
490         https://bugs.webkit.org/show_bug.cgi?id=51217
491
492         * TestResultServer/model/jsonresults.py:
493         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
494         Adds missing documentation.
495         * TestResultServer/model/jsonresults_unittest.py:
496         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
497         Update test_merge to take a number of builds to truncate at.
498
499 2011-01-06  Adam Barth  <abarth@webkit.org>
500
501         Reviewed by Eric Seidel.
502
503         The EWS should log outside of the working directory
504         https://bugs.webkit.org/show_bug.cgi?id=51986
505
506         This patch prepare us for using git clean -x -d -f in the EWS wrapper
507         script, which will actually clean the working copy back to a pristine
508         state instead of leaving untracked directories and ignored files.
509
510         * Scripts/webkitpy/tool/commands/queues.py:
511         * Scripts/webkitpy/tool/commands/queues_unittest.py:
512
513 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
514
515         Windows build fix.
516         Back out attempted change to built-product-archive.
517
518         * BuildSlaveSupport/built-product-archive:
519
520 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
521
522         Windows build fix.
523         Include configuration name when unpacking a build archive.
524
525         Needed, since we split Windows build results into configuration-specific directories
526         under WebKitOutputDir.
527
528         * BuildSlaveSupport/built-product-archive:
529
530 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
531
532         Reviewed by Darin Adler.
533
534         Debug and Release builds on Windows clobber each other
535         https://bugs.webkit.org/show_bug.cgi?id=49185
536
537         Changes the structure of WebKitBuild build products directory so we
538         completely separate each build configuration into independent directories.
539         
540         Although we previously had per-configuration directories for obj, this change adds
541         per-configuration directories for bin, lib, obj, and include. Each configuration's
542         build products are stored within a directory inside of WebKitBuild.
543         
544         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
545         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
546
547         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
548         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
549         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
550         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
551         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
552         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
553         * DumpRenderTree/win/ImageDiffCommon.vsprops:
554         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
555         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
556         * FindSafari/FindSafari.vcproj:
557         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
558         * MiniBrowser/MiniBrowserPostBuild.cmd:
559         * MiniBrowser/MiniBrowserPreBuild.cmd:
560         * Scripts/webkitdirs.pm:
561         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
562         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
563         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
564         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
565         * TestWebKitAPI/win/copy-resources.cmd:
566         * WebKitAPITest/WebKitAPITestCommon.vsprops:
567         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
568         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
569         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
570         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
571         * WebKitTestRunner/win/InjectedBundle.vcproj:
572         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
573         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
574         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
575         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
576         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
577         * WinLauncher/WinLauncherCommon.vsprops:
578         * WinLauncher/WinLauncherPostBuild.cmd:
579         * WinLauncher/WinLauncherPreBuild.cmd:
580
581 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
582
583         Reviewed by Ariya Hidayat.
584
585         [Qt] TestNetscapePlugin doesn't link on OS X
586         https://bugs.webkit.org/show_bug.cgi?id=51948
587
588         Only add a dependency on libX11 on X11 systems
589
590         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
591
592 2011-01-05  Jeff Miller  <jeffm@apple.com>
593
594         Reviewed by Adam Roben.
595
596         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
597         https://bugs.webkit.org/show_bug.cgi?id=51970
598
599         * Scripts/webkitpy/style/checker.py:
600         Add -readability/naming for WebKit2 C API directories.
601
602 2011-01-05  Eric Seidel  <eric@webkit.org>
603
604         Unreviewed, just fixing one more log error from my previous python patch.
605
606         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
607         https://bugs.webkit.org/show_bug.cgi?id=51802
608
609         webkit-patch failure-reason was logging about parsing errors
610         due to my misunderstanding of how BeautifulSoup.findAll worked.
611
612         Fixed, and added a unit test.
613
614         * Scripts/webkitpy/common/net/layouttestresults.py:
615         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
616
617 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
618
619         Reviewed by Kenneth Rohde Christiansen.
620
621         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
622         https://bugs.webkit.org/show_bug.cgi?id=51951
623
624         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
625         to create new window from WebKit.
626
627         * MiniBrowser/qt/BrowserWindow.cpp:
628         (newPageFunction):
629         (BrowserWindow::BrowserWindow):
630         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
631         (BrowserWindow::newWindow):
632         (BrowserWindow::updateUserAgentList):
633         (BrowserWindow::showUserAgentDialog):
634         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
635         define the type of the backing store used for new windows.
636         * MiniBrowser/qt/main.cpp:
637         (main):
638
639 2011-01-05  Eric Seidel  <eric@webkit.org>
640
641         Reviewed by Ojan Vafai.
642
643         commit-queue should report failure type when reporting flaky tests
644         https://bugs.webkit.org/show_bug.cgi?id=51900
645
646         This patch was a ridiculous amount of plumbing.  In the end I like
647         the NRWT-style TestResult class even less.  But now we're passing
648         a list of TestResult objects from the queue to the FlakyTestReporter.
649         Thus the FlakyTestReporter can more easily report what type of failure
650         occurred.
651
652         In the process, I found that I was not alone in finding TestResult
653         cumbersome to use.  A bunch of code was trying to create a TestResult
654         object with default values.  However since the constructor didn't make
655         this easy, some places were getting it wrong (including the TestResult unit test)!
656         I've fixed the TestResult constructor to have default values for non-essential
657         arguments.
658
659         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
660         * Scripts/webkitpy/common/net/layouttestresults.py:
661         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
662         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
663         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
664         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
665         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
666         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
667         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
668         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
669         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
670         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
671         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
672         * Scripts/webkitpy/tool/commands/queues.py:
673         * Scripts/webkitpy/tool/commands/queues_unittest.py:
674
675 2011-01-05  Eric Seidel  <eric@webkit.org>
676
677         Unreviewed.
678
679         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
680         https://bugs.webkit.org/show_bug.cgi?id=51802
681
682         Add another unit test to cover a previously missing import.
683
684         * Scripts/webkitpy/common/net/layouttestresults.py:
685         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
686
687 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
688
689         Reviewed by David Levin.
690
691         Add mihaip@chromium.org as a reviewer
692         https://bugs.webkit.org/show_bug.cgi?id=51966
693         
694         Add myself as a reviewer.
695
696         * Scripts/webkitpy/common/config/committers.py:
697
698 2011-01-05  James Simonsen  <simonjam@chromium.org>
699
700         Unreviewed. Adding myself to the list of committers.
701
702         * Scripts/webkitpy/common/config/committers.py:
703
704 2011-01-05  Eric Seidel  <eric@webkit.org>
705
706         Unreviewed.
707
708         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
709         https://bugs.webkit.org/show_bug.cgi?id=51802
710
711         Fix two exceptions seen on the bots after my original commit.
712
713         * Scripts/webkitpy/common/net/layouttestresults.py:
714         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
715
716 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
717
718         Reviewed by Andreas Kling.
719
720         [Qt]Add local storage settings to QtTestBrowser command line arguments 
721         https://bugs.webkit.org/show_bug.cgi?id=51750
722
723         * QtTestBrowser/main.cpp:
724         (LauncherApplication::handleUserOptions):
725          Local storage settings can be enable form command line arguments for
726          QtTestBrowser.
727
728 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
729
730         Reviewed by Martin Robinson.
731
732         GTK: AX: DRT needs to use correct root object method.
733         https://bugs.webkit.org/show_bug.cgi?id=51911
734
735         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
736         (AccessibilityController::rootElement):
737
738 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
739
740         Rubber-stamped by Csaba Osztrogonác.
741
742         Based on idea from Péter Gál.
743
744         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
745
746 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
747
748         Reviewed by Adam Barth.
749
750         sheriff-bot should be able to do multi-revision rollouts
751         https://bugs.webkit.org/show_bug.cgi?id=51176
752
753         * Scripts/webkitpy/tool/bot/irc_command.py:
754         * Scripts/webkitpy/tool/bot/sheriff.py:
755         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
756
757 2011-01-05  Eric Seidel  <eric@webkit.org>
758
759         Reviewed by Adam Barth.
760
761         queues.webkit.org should have per-bot status pages
762         https://bugs.webkit.org/show_bug.cgi?id=51906
763
764         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
765         statuses from a single queue.  Now that we have many bots servicing
766         some queues (commit-queue, win-ews, etc.) its easy to have the messages
767         you care about scroll off the end of the 15-message limit on the main page.
768
769         Eventually we should probably rename /queue-status to /queue or /queues,
770         but that's fodder for another patch.
771
772         * QueueStatusServer/handlers/queuestatus.py:
773         * QueueStatusServer/index.yaml:
774         * QueueStatusServer/main.py:
775         * QueueStatusServer/templates/includes/singlequeuestatus.html:
776          - This probably should use a custom filter instead of hard-coding
777            the URL scheme here, but I couldn't figure out how to easily
778            create such a filter.  Most filters work with "strings" so we can't
779            pass the status object.  We could add a method to the status
780            object and call that, but that seemed a bit strange too.
781         * QueueStatusServer/templates/queuestatus.html:
782
783 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
784
785         Unreviewed. Adding myself to the list of committers.
786
787         * Scripts/webkitpy/common/config/committers.py:
788
789 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
790
791         Reviewed by David Levin.
792
793         check-webkit-style treated some macros with parentheses after #elif as function calls
794         https://bugs.webkit.org/show_bug.cgi?id=51695
795
796         Ingore function call space checking in any preprocessor directives
797         (things starting with #). Change search() to match() because 
798         preprocessor directives are supposed to be in the beginning of lines.
799
800         * Scripts/webkitpy/style/checkers/cpp.py:
801         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
802
803 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
804
805         Reviewed by Tony Chang.
806
807         Change the --multi-load test option to --stress-opt
808         https://bugs.webkit.org/show_bug.cgi?id=50751
809
810         * DumpRenderTree/chromium/DumpRenderTree.cpp:
811         (runTest):
812         (main):
813         * DumpRenderTree/chromium/TestShell.cpp:
814         (TestShell::TestShell):
815         * DumpRenderTree/chromium/TestShell.h:
816         (TestShell::stressOpt):
817         (TestShell::setStressOpt):
818         (TestShell::stressDeopt):
819         (TestShell::setStressDeopt):
820         (TestShell::javaScriptFlags):
821         (TestShell::setJavaScriptFlags):
822         * Scripts/webkitpy/layout_tests/port/chromium.py:
823         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
824
825 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
826
827         Reviewed by Sam Weinig.
828
829         WK2: Support Accessibility
830         https://bugs.webkit.org/show_bug.cgi?id=51859
831
832         Use rootObject() method to get top of accessibility tree.
833
834         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
835         (AccessibilityController::focusedElement):
836         (AccessibilityController::rootElement):
837
838 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
839
840         Reviewed by Darin Adler.
841
842         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
843         https://bugs.webkit.org/show_bug.cgi?id=51846
844
845         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
846         back to GRefPtr.
847
848 2011-01-04  Zhe Su  <suzhe@chromium.org>
849
850         Reviewed by Kenneth Russell.
851
852         Fix insertText, setMarkedText and unmarkText methods of
853         TextInputController to call corresponding methods of WebKit::WebView
854         rather than WebKit::WebFrame. This change matches the behavior of
855         chromium browser.
856         insertText corresponds to WebView::confirmComposition(text)
857         setMarkedText corresponds to WebView::setComposition(...)
858         unmarkText corresponds to WebView::confirmComposition()
859         https://bugs.webkit.org/show_bug.cgi?id=51693
860
861         * DumpRenderTree/chromium/TextInputController.cpp:
862         (TextInputController::insertText):
863         (TextInputController::setMarkedText):
864         (TextInputController::unmarkText):
865
866 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
867
868         Reviewed by Laszlo Gombos.
869
870         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
871
872         On Symbian productDir points to the source directory. Removing all the
873         empty files from the productDir directory corrupts the svn repository.
874
875         * Scripts/build-webkit:
876
877 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
878
879         Reviewed by Adam Barth.
880
881         [Qt] Add SelectAll option to the context menu for the editor
882         https://bugs.webkit.org/show_bug.cgi?id=50049
883
884         Set shortcut for the SelectAll action.
885
886         * QtTestBrowser/mainwindow.cpp:
887         (MainWindow::buildUI):
888
889 2011-01-03  David Levin  <levin@chromium.org>
890
891         Reviewed by Eric Seidel.
892
893         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
894         https://bugs.webkit.org/show_bug.cgi?id=51842
895
896         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
897         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
898
899 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
900
901         Reviewed by David Kilzer.
902
903         [WINCE] Adds a build slave.
904         https://bugs.webkit.org/show_bug.cgi?id=50523
905
906         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
907         entry for a release build of the WinCE port.
908         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
909         flag to build the WinCE port.
910
911 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
912
913         Reviewed by David Kilzer.
914
915         Add WinCE support to build-webkit
916         https://bugs.webkit.org/show_bug.cgi?id=51642
917
918         * Scripts/build-webkit:
919         * Scripts/webkitdirs.pm:
920
921 2011-01-03  Eric Seidel  <eric@webkit.org>
922
923         Reviewed by Adam Barth.
924
925         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
926         https://bugs.webkit.org/show_bug.cgi?id=51802
927
928         I'm not the biggest fan of the test_failures or test_results classes,
929         but it's better to have one shared set of classes, than separate ones
930         for new vs. old run-webkit-test result handling.
931
932         This moves the ORWT results class "LayoutTestResults" over to using
933         TestResult and TestFailure classes, making it easy for us to
934         make all our sheriff-bot and other webkitpy code NRWT ready.
935
936         This also makes it a trivial patch to generate results.json information
937         from ORWT results.html files (for flaky test analysis, etc.) as well
938         as making it a one-liner to report test failure types when the
939         commit-queue sees flaky tests.
940
941         This patch tried not to add new functionality, but only to replace
942         the guts of LayoutTestResults, while adding unit tests and hoping
943         not to break anything.
944
945         I also moved callers which assumed User.prompt* were static/class methods
946         to using them as instance methods (since we'll eventually want to make them such).
947
948         In the process of re-writing things, I broke the rebaseline command, so I wrote
949         a unit test to catch my breakage were I do do so again in the future.
950
951         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
952         * Scripts/webkitpy/common/net/layouttestresults.py:
953         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
954         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
955         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
956         * Scripts/webkitpy/tool/commands/queries.py:
957         * Scripts/webkitpy/tool/commands/rebaseline.py:
958         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
959         * Scripts/webkitpy/tool/mocktool.py:
960
961 2011-01-03  Adam Barth  <abarth@webkit.org>
962
963         Reviewed by Simon Fraser.
964
965         webkit-patch shouldn't waste time cleaning a working directory that's already clean
966         https://bugs.webkit.org/show_bug.cgi?id=51840
967
968         * Scripts/webkitpy/common/checkout/scm.py:
969
970 2011-01-03  Adam Barth  <abarth@webkit.org>
971
972         Reviewed by Simon Fraser.
973
974         webkit-patch should only hide update output if --quiet
975         https://bugs.webkit.org/show_bug.cgi?id=51838
976
977         As requested by smfr.
978
979         * Scripts/webkitpy/tool/steps/update.py:
980
981 2011-01-03  Adam Barth  <abarth@webkit.org>
982
983         Reviewed by David Levin.
984
985         commit-queue shouldn't reject patches twice if two bots process the same patch
986         https://bugs.webkit.org/show_bug.cgi?id=51805
987
988         Before raising an error, we first check whether the patch is still in
989         the commit-queue.  This check is still racy, of course, but the time
990         window is much smaller.
991
992         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
993
994 2011-01-03  Sam Weinig  <sam@webkit.org>
995
996         Reviewed by Anders Carlsson.
997
998         Make run-api-tests less chatty.
999         https://bugs.webkit.org/show_bug.cgi?id=51831
1000
1001         - Make script quiet by default and add --verbose option (replacing --quiet).
1002         - When not verbose, pipe stdout and stderr to devnull.
1003
1004         * Scripts/run-api-tests:
1005
1006 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1007
1008         Unreviewed. Adding myself to committers.py.
1009
1010         * Scripts/webkitpy/common/config/committers.py:
1011
1012 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1013
1014         Reviewed by Xan Lopez.
1015
1016         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1017         https://bugs.webkit.org/show_bug.cgi?id=51806
1018
1019         Originally, the $libraryName is 'JavaScriptCore'. When building release 
1020         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1021         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1022         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
1023         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1024         so make it 'WebKitBuild/Release/.libs'
1025
1026         * Scripts/webkitdirs.pm: 
1027
1028 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1029
1030         Reviewed by Adam Barth.
1031
1032         Make EFL a core builder
1033         https://bugs.webkit.org/show_bug.cgi?id=51804
1034
1035         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1036         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1037
1038 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1039
1040         [Qt] Unreviewed fix after r74855 and r74875.
1041
1042         * BuildSlaveSupport/built-product-archive:
1043          - Create directories explicitly.
1044          - Pass shell=True to subprocess.call().
1045
1046 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1047
1048         [Qt] Unreviewed fix after r74855.
1049
1050         Move JavaScriptCore to Source
1051         https://bugs.webkit.org/show_bug.cgi?id=51604
1052
1053         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1054
1055 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1056
1057         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1058
1059         Move JavaScriptCore to Source
1060         https://bugs.webkit.org/show_bug.cgi?id=51604
1061
1062         * Scripts/webkitdirs.pm:
1063
1064 2011-01-02  Robert Hogan  <robert@webkit.org>
1065
1066         Unreviewed, build fix.
1067
1068         [Qt] Fix DRT build after 74855
1069
1070         * DumpRenderTree/qt/DumpRenderTree.pro:
1071
1072 2011-01-01  Adam Barth  <abarth@webkit.org>
1073
1074         Remove the assumption from the Qt and Gtk builds that every project is
1075         in the root directory.
1076
1077         * Scripts/build-webkit:
1078
1079 2011-01-01  Adam Barth  <abarth@webkit.org>
1080
1081         Reviewed by Eric Seidel.
1082
1083         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1084         https://bugs.webkit.org/show_bug.cgi?id=51796
1085
1086         After this change, svn-apply will magically apply patches to
1087         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1088
1089         * Scripts/VCSUtils.pm:
1090
1091 2011-01-01  Adam Barth  <abarth@webkit.org>
1092
1093         Reviewed by Eric Seidel.
1094
1095         Move JavaScriptCore to Source
1096         https://bugs.webkit.org/show_bug.cgi?id=51604
1097
1098         Update references to JavaScriptCore to point to the new location.
1099
1100         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1101         * DumpRenderTree/qt/DumpRenderTree.pro:
1102         * DumpRenderTree/qt/ImageDiff.pro:
1103         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1104         * DumpRenderTree/wscript:
1105         * Scripts/build-jsc:
1106         * Scripts/build-webkit:
1107         * Scripts/do-file-rename:
1108         * Scripts/do-webcore-rename:
1109         * Scripts/run-javascriptcore-tests:
1110         * Scripts/update-javascriptcore-test-results:
1111         * Scripts/webkitdirs.pm:
1112         * Scripts/webkitpy/common/config/build_unittest.py:
1113         * Scripts/webkitpy/style/checker.py:
1114         * Scripts/webkitpy/style/checker_unittest.py:
1115         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1116         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1117         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1118         * wx/build/settings.py:
1119
1120 2011-01-01  Adam Barth  <abarth@webkit.org>
1121
1122         Reviewed by Eric Seidel.
1123
1124         Move Sources to Source
1125         https://bugs.webkit.org/show_bug.cgi?id=51794
1126
1127         Update scripts to point to the new location.
1128
1129         * Scripts/build-webkit:
1130         * Scripts/do-file-rename:
1131         * Scripts/do-webcore-rename:
1132         * Scripts/webkitpy/common/config/build.py:
1133         * Scripts/webkitpy/common/config/build_unittest.py:
1134
1135 2010-12-31  Kent Tamura  <tkent@chromium.org>
1136
1137         Reviewed by Eric Seidel.
1138
1139         [DRT/Chromium] Enable mock spell checker on non-OSX
1140         https://bugs.webkit.org/show_bug.cgi?id=51401
1141
1142         * DumpRenderTree/chromium/WebViewHost.cpp:
1143         (WebViewHost::spellCheck):
1144
1145 2010-12-31  Adam Barth  <abarth@webkit.org>
1146
1147         Reviewed by Ariya Hidayat.
1148
1149         Remove Tools/Scripts/wkstyle
1150         https://bugs.webkit.org/show_bug.cgi?id=51774
1151
1152         This script appears to not have been touched in a while and seems to
1153         have been replaced by check-webkit-style.
1154
1155         * Scripts/wkstyle: Removed.
1156
1157 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1158
1159         Unreviewed. Coding style fix.
1160
1161         * DumpRenderTree/chromium/TestShell.h:
1162
1163 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1164
1165         Reviewed by Pavel Feldman.
1166
1167         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
1168
1169         It was a problem with Chromium DRT. DevToolsAgent object instance was
1170         attached not only to the inspected page but to the DevTools window too.
1171         As result all the inspector files were interpreted as a content of inspected page
1172         and were transfered to the DevTools scripts panel for debugging etc.
1173
1174         https://bugs.webkit.org/show_bug.cgi?id=51735
1175
1176         * DumpRenderTree/chromium/TestShell.cpp:
1177         (TestShell::TestShell):
1178         (TestShell::bindJSObjectsToWindow):
1179         (TestShell::createNewWindow):
1180         * DumpRenderTree/chromium/TestShell.h:
1181
1182 2010-12-31  Adam Barth  <abarth@webkit.org>
1183
1184         Rubber-stamped by Eric Seidel.
1185
1186         Move PageLoadTests to PerformanceTests/PageLoad
1187         https://bugs.webkit.org/show_bug.cgi?id=51771
1188
1189         Update references to PageLoadTests to point to the new location.
1190
1191         * Scripts/run-pageloadtest:
1192         * Scripts/webkitpy/common/config/build.py:
1193
1194 2010-12-31  Adam Barth  <abarth@webkit.org>
1195
1196         Rubber-stamped by Eric Seidel.
1197
1198         Move SunSpider into PerformanceTests
1199         https://bugs.webkit.org/show_bug.cgi?id=51769
1200
1201         Update these scripts to point to the new location.
1202
1203         * Scripts/run-sunspider:
1204         * Scripts/sunspider-compare-results:
1205
1206 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
1207
1208         Reviewed by Kent Tamura.
1209
1210         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
1211         https://bugs.webkit.org/show_bug.cgi?id=51728
1212         
1213         Add implementation of the Mac WebThemeEngine that uses an NSScroller
1214         to render top-level scrollbars. This makes them match the Mac port's
1215         use of an NSScrollView, which means that we'll be able to share more
1216         pixel baselines.
1217         
1218         The new rendering code will not be activated until the 
1219         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
1220         ScrollbarThemeChromiumMac.
1221
1222         * DumpRenderTree/DumpRenderTree.gypi:
1223         * DumpRenderTree/chromium/TestShellMac.mm:
1224         (platformInit):
1225         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
1226         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
1227         (+[FakeActiveWindow alwaysActiveWindow]):
1228         (+[FakeActiveWindow alwaysInactiveWindow]):
1229         (-[FakeActiveWindow initWithActiveControls:]):
1230         (-[FakeActiveWindow _hasActiveControls]):
1231         (WebThemeEngineDRTMac::paintScrollbarThumb):
1232         (stateToHIEnableState):
1233         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1234         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1235
1236 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
1237
1238         Reviewed by David Kilzer.
1239
1240         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
1241         used
1242         https://bugs.webkit.org/show_bug.cgi?id=51672
1243
1244         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
1245         with USE_SYSTEM_MALLOC=1
1246         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
1247         with USE_SYSTEM_MALLOC=1
1248
1249 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1250
1251         Reviewed by David Kilzer.
1252
1253         [Qt] [Symbian] Fix build-webkit script for Symbian
1254         https://bugs.webkit.org/show_bug.cgi?id=51509
1255
1256         Set the OUTPUT_DIR for Symbian to be the same as the source
1257         directory.
1258
1259         * Scripts/webkitdirs.pm:
1260
1261 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
1262
1263         Reviewed by Darin Adler.
1264
1265         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
1266         https://bugs.webkit.org/show_bug.cgi?id=51758
1267
1268         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
1269
1270         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
1271         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
1272
1273 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1274
1275         Unreviewed WinCE buildfix.
1276
1277         * WinCELauncher/main.cpp: Add missing include.
1278
1279 2010-12-29  Daniel Bates  <dbates@rim.com>
1280
1281         Reviewed by Darin Adler.
1282
1283         svn-apply updates date of wrong change log entry for a change log diff that
1284         contains two consecutive entries with the same author and date
1285         https://bugs.webkit.org/show_bug.cgi?id=46061
1286
1287         Fixes an issue where the date of the wrong change log entry may be modified.
1288         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
1289         in a ChangeLog file to the top of the file.
1290
1291         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
1292         diff when it detects that the diff inserts a change log entry earlier in a
1293         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
1294         change. With the advent of the commit-queue this functionality of bailing out
1295         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
1296         Instead, we should always move the change log entry to the top of the ChangeLog file.
1297
1298         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
1299         the date line of the correct change log entry in a ChangeLog diff.
1300
1301         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
1302
1303         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1304           Updated the following unit tests now that we move entries inserted earlier to the top:
1305           - "fixChangeLogPatch: New entry inserted in middle."
1306             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
1307
1308           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
1309             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
1310
1311         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
1312
1313 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
1314
1315         Reviewed by Eric Seidel.
1316
1317         [Qt] Fixed compatibility with gold linker on X11 platforms
1318         https://bugs.webkit.org/show_bug.cgi?id=51700
1319
1320         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1321         Linked TestNetscapePlugin with libX11 on Unix platforms
1322
1323 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1324
1325         Reviewed by Darin Adler.
1326
1327         Circular dependency in webkitpy.common.checkout.changelog module
1328         https://bugs.webkit.org/show_bug.cgi?id=50475
1329
1330         Remove automatic import of api.Checkout module when any checkout/
1331         submodule is imported (e.g.: when checkout.scm.Git is imported).
1332
1333         * Scripts/webkitpy/common/checkout/__init__.py:
1334
1335 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
1336
1337         Reviewed by Ojan Vafai.
1338
1339         prepare-ChangeLog should support the -g option for specifying the git-commit
1340         https://bugs.webkit.org/show_bug.cgi?id=51708
1341
1342         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
1343         webkit-patch, though the exact meaning of the two options remain different.
1344
1345         * Scripts/prepare-ChangeLog: Add -g.
1346
1347 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
1348
1349         Reviewed by Simon Hausmann.
1350
1351         [Qt] Fix compilation with Qt in namespace
1352         https://bugs.webkit.org/show_bug.cgi?id=51701
1353
1354         * QtTestBrowser/webview.h:
1355
1356 2010-12-28  Daniel Bates  <dbates@rim.com>
1357
1358         Reviewed by Sam Weinig.
1359
1360         Substitute // MARK: for compiler-specific #pragma mark
1361         https://bugs.webkit.org/show_bug.cgi?id=51657
1362
1363         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
1364         substituting  "// MARK:" for "#pragma mark", which provides
1365         analogous code-bookmarking functionality under Xcode.
1366
1367         Also, for consistency, we should substitute "// MARK:" for compiler-
1368         specific "#pragma mark" in the source files for the Mac port.
1369
1370         * DumpRenderTree/AccessibilityTextMarker.cpp:
1371         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
1372         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1373         * DumpRenderTree/mac/ObjCController.m:
1374         * MiniBrowser/mac/AppDelegate.m:
1375         * MiniBrowser/mac/BrowserWindowController.m:
1376
1377 2010-12-28  Xan Lopez  <xlopez@igalia.com>
1378
1379         Reviewed by Eric Seidel.
1380
1381         Add --no-build option to run-sunspider
1382         https://bugs.webkit.org/show_bug.cgi?id=51658
1383
1384         * Scripts/run-sunspider: add --no-build flag to skip building
1385         phase.
1386
1387 2010-12-27  Daniel Bates  <dbates@rim.com>
1388
1389         Rubber-stamped by Martin Robinson.
1390
1391         Append the directory Tools/DumpRenderTree to the list of directories that
1392         do-webcore-rename should search so that it can rename DRT files and
1393         source code.
1394
1395         * Scripts/do-webcore-rename:
1396
1397 2010-12-27  Eric Seidel  <eric@webkit.org>
1398
1399         Reviewed by Adam Barth.
1400
1401         build-webkit should detect missing Java SDK and explain how to install it
1402         https://bugs.webkit.org/show_bug.cgi?id=51651
1403
1404         * Scripts/build-webkit:
1405
1406 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
1407
1408         Reviewed by Daniel Bates.
1409
1410         [GTK] Add support for build-jsc
1411         https://bugs.webkit.org/show_bug.cgi?id=51625
1412
1413         Add GTK+ support to build-jsc now that building the jsc executable as
1414         a standalone target is easy.
1415
1416         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
1417         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
1418         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
1419         and pass it along to buildAutotoolsProject.
1420
1421 2010-12-27  David Levin  <levin@chromium.org>
1422
1423         Reviewed by Eric Seidel.
1424
1425         check-webkit-style check for meaningless variable names in function declarations.
1426         https://bugs.webkit.org/show_bug.cgi?id=51523
1427
1428         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
1429         from the new check and whitespace/parens because the syntax is unusual and
1430         produced a fair number of positives for these checks.
1431         * Scripts/webkitpy/style/checkers/cpp.py:
1432         (_convert_to_lower_with_underscores): Used as a canonical form for type names
1433         and parameter names when determining if the parameter name is useless.
1434         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
1435         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
1436         format.
1437         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
1438         text or an acronym of it.
1439         (check_function_definition): Checks function definitions for meaningless variable names.
1440         (process_line): Added call to check_function_definition.
1441         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1442         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
1443         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
1444         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
1445         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
1446         because when only checking a snippet, there are a lot of bogus functions.
1447         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
1448         that I put there previously and just noticed.
1449         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
1450         check_function_definition and process_line.
1451
1452 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1453
1454         Reviewed by Martin Robinson.
1455
1456         [GTK] Disable flash plugin in GtkLauncher when using gtk3
1457         https://bugs.webkit.org/show_bug.cgi?id=51591
1458
1459         Flash plugin uses gtk2 that is incompatible with gtk3 making
1460         webkit crash when it's built with gtk3.
1461
1462         * GtkLauncher/main.c:
1463         (main):
1464
1465 2010-12-25  Adam Barth  <abarth@webkit.org>
1466
1467         Reviewed by Eric Seidel.
1468
1469         Move ANGLE to Sources/ThirdParty
1470         https://bugs.webkit.org/show_bug.cgi?id=51605
1471
1472         * Scripts/build-webkit:
1473           - Point to the new ANGLE location.
1474
1475 2010-12-26  David Levin  <levin@chromium.org>
1476
1477         Reviewed by Eric Seidel.
1478
1479         check-webkit-style should be able to parse function declaration parameters.
1480         https://bugs.webkit.org/show_bug.cgi?id=51451
1481
1482         * Scripts/webkitpy/style/checkers/cpp.py:
1483         (Position.__init__): Holds simple position information (row, column).
1484         (Parameter.__init__): Holds information about a parameter.
1485         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
1486         (SingleLineView.convert_column_to_row): Returns the original row given a column.
1487         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
1488         (find_parameter_name_index): Finds where the parameter name is.
1489         (parameter_list): Generates the list of parameters for a function.
1490         (_FunctionState.begin): Added information to allow determining the parameters
1491         on demand.
1492         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
1493         (detect_functions): Improve function detection for operator functions and
1494         determine where the parameters end and pass that to _FunctionState.begin.
1495         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1496         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
1497         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
1498         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
1499         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
1500         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
1501         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
1502         (FunctionDetectionTest.perform_function_detection): Added support for verifying
1503         the parameters found.
1504         (FunctionDetectionTest.test_function_declaration_detection): Added more function
1505         detection test to verify that we catch the operator functions.
1506         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
1507         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
1508         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
1509         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
1510         test_function_length_check_definition_severity1_for_test.
1511
1512 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
1513
1514         Unreviewed WinCE buildfix after r74334.
1515
1516         * CMakeListsWinCE.txt:
1517
1518 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1519
1520         Unreviewed, rolling out r74632.
1521         http://trac.webkit.org/changeset/74632
1522         https://bugs.webkit.org/show_bug.cgi?id=51600
1523
1524         makes test-webkitpy hang forever on GTK (Requested by philn-tp
1525         on #webkit).
1526
1527         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1528         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1529
1530 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
1531
1532         Reviewed by Kenneth Rohde Christiansen.
1533
1534         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
1535         https://bugs.webkit.org/show_bug.cgi?id=43528
1536
1537         Remove on_resize because ewk_view_fixed_layout_size_set should not be
1538         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
1539         FrameView, rendering was ignored when _ewk_view_smart_calculate was
1540         called.
1541
1542         * EWebLauncher/main.c:
1543         (browserCreate):
1544
1545 2010-12-24  Eric Seidel  <eric@webkit.org>
1546
1547         Reviewed by Adam Barth.
1548
1549         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
1550         https://bugs.webkit.org/show_bug.cgi?id=28291
1551
1552         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
1553         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
1554         to strings with find in the diff.
1555         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
1556
1557         * Scripts/webkitpy/common/checkout/api.py:
1558         * Scripts/webkitpy/common/checkout/diff_parser.py:
1559         * Scripts/webkitpy/tool/steps/abstractstep.py:
1560         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1561         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
1562         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1563         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1564
1565 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
1566
1567         Reviewed by Kenneth Russell.
1568
1569         Modify new-run-webkit-tests to shut up and exit when all the threads
1570         are wedged so that test runs complete faster and we don't end up
1571         w/ enormous log files.
1572
1573         https://bugs.webkit.org/show_bug.cgi?id=51572
1574
1575         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1576         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1577
1578 2010-12-24  Eric Seidel  <eric@webkit.org>
1579
1580         Reviewed by David Levin.
1581
1582         commit-queue should better explain how it will re-open bugs and follow duplicate chains
1583         https://bugs.webkit.org/show_bug.cgi?id=51549
1584
1585         I've had multiple people ask me about the commit-queue's behavior
1586         regarding reporting flaky tests.  I figured it would be best to just
1587         have the queue explain itself in the bugs it files.
1588
1589         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1590         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1591
1592 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
1593
1594         Reviewed by Eric Seidel.
1595
1596         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
1597         https://bugs.webkit.org/show_bug.cgi?id=51467
1598
1599         * Scripts/webkitpy/style/checker.py:
1600         * Scripts/webkitpy/style/checker_unittest.py:
1601
1602 2010-12-23  Adam Barth  <abarth@webkit.org>
1603
1604         Rubber-stamped by Eric Seidel.
1605
1606         Move JavaScriptGlue into Sources
1607         https://bugs.webkit.org/show_bug.cgi?id=51583
1608
1609         These tools refer to JavaScriptGlue and need to be updated to its new
1610         location.
1611
1612         * Scripts/build-webkit:
1613         * Scripts/do-file-rename:
1614         * Scripts/do-webcore-rename:
1615         * Scripts/webkitpy/common/config/build.py:
1616         * Scripts/webkitpy/common/config/build_unittest.py:
1617
1618 2010-12-23  Lucas Forschler  <lforschler@apple.com>
1619
1620         Reviewed by Eric Seidel.
1621
1622         Bug 51539 - update iexploder scripts to point to new location
1623
1624         * Scripts/run-iexploder-tests:
1625         * Scripts/update-iexploder-cssproperties:
1626
1627 2010-12-23  Evan Martin  <evan@chromium.org>
1628
1629         Reviewed by Ryosuke Niwa.
1630
1631         [chromium] LayoutTestController warning in float->int conversion
1632         https://bugs.webkit.org/show_bug.cgi?id=51553
1633
1634         Rather than reading an int, converting to a float, then getting a compiler
1635         warning on passing the float to something that expects an int, instead
1636         just pass around ints.
1637
1638         No tests, fixes a compiler warning.
1639
1640         * DumpRenderTree/chromium/LayoutTestController.cpp:
1641         (parsePageSizeParameters):
1642         (LayoutTestController::pageNumberForElementById):
1643         (LayoutTestController::numberOfPages):
1644
1645 2010-12-23  Lucas Forschler  <lforschler@apple.com>
1646
1647         Reviewed by Darin Adler.
1648
1649         Bug 51537 - iexploder needs cleanup
1650         
1651         * iExploder/htdocs: Removed.
1652         * iExploder/htdocs/config.rb: Removed.
1653         * iExploder/htdocs/cssproperties.in: Removed.
1654         * iExploder/htdocs/cssvalues.in: Removed.
1655         * iExploder/htdocs/htmlattrs.in: Removed.
1656         * iExploder/htdocs/htmltags.in: Removed.
1657         * iExploder/htdocs/htmlvalues.in: Removed.
1658         * iExploder/htdocs/iexploder.cgi: Removed.
1659         * iExploder/htdocs/iexploder.rb: Removed.
1660         * iExploder/htdocs/index.html: Removed.
1661         * iExploder/htdocs/webserver.rb: Removed.
1662         * iExploder/iexploder-1.7.2/output: Removed.
1663         * iExploder/tools: Removed.
1664         * iExploder/tools/lasthit.rb: Removed.
1665         * iExploder/tools/osx_last_crash.rb: Removed.
1666         * iExploder/tools/showtest.rb: Removed.
1667
1668 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1669
1670         Reviewed by Kenneth Rohde Christiansen.
1671
1672         [EFL] Make 'single' the default backing store in EWebLauncher
1673         https://bugs.webkit.org/show_bug.cgi?id=51534
1674
1675         'single' is the simplest backing store and the one intended to be the
1676         default in the test browser. By mistake the tiled backing store was
1677         left as default in r72617.
1678
1679         * EWebLauncher/main.c:
1680         (browserCreate): ditto.
1681
1682 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1683
1684         Reviewed by Kenneth Rohde Christiansen.
1685
1686         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
1687         https://bugs.webkit.org/show_bug.cgi?id=51533
1688
1689         There's no point in concatenating env("HOME") with "blah", so remove
1690         option from EWebLauncher.
1691
1692         * EWebLauncher/main.c:
1693         (main): ditto.
1694
1695 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
1696
1697         Reviewed by Eric Seidel.
1698
1699         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
1700
1701         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
1702         I just discovered that we have two additional GC runs per each WebViewHost.
1703         Test_shell had no such calls.
1704         These gc runs eat 15% of cpu time.
1705
1706         https://bugs.webkit.org/show_bug.cgi?id=51479
1707
1708         * DumpRenderTree/chromium/WebViewHost.cpp:
1709         (WebViewHost::~WebViewHost):
1710
1711 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
1712
1713         Reviewed by Ojan Vafai.
1714
1715         This change splits out the TestRunner class into its own file.
1716         When we fork the code for message passing, we will create a new
1717         TestRunner, and this change will allow that to be more modular.
1718
1719         While we're at it, split out TestInput and ResultSummary into
1720         their own files, to reduce the size of run_webkit_tests to
1721         something more managable.
1722
1723         https://bugs.webkit.org/show_bug.cgi?id=51092
1724
1725         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1726         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
1727         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1728         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1729         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
1730         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1731         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1732
1733  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
1734
1735         Reviewed by Ojan Vafai.
1736
1737         nrwt multiprocessing - start over, prepare to fork the code
1738  
1739         This code cleans up the signatures and implementation of the
1740         TestRunner class so we can easily fork it to run either the
1741         stable implementation or the new, unstable message-passing
1742         implementation. The two variants will have different
1743         implementations of the run_tests() method. We will switch
1744         between the two based on the setting for the '--worker-model'
1745         switch. We rename the two currently valid values to 'old-inline'
1746         and 'old-threads'.
1747
1748         https://bugs.webkit.org/show_bug.cgi?id=51081
1749
1750         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1751         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1752
1753 2010-12-22  Victor Wang  <victorw@chromium.org>
1754
1755         Reviewed by Darin Fisher.
1756
1757         [Chromium] Update chromium archive test result url in rebaseline script.
1758
1759         https://bugs.webkit.org/show_bug.cgi?id=51503
1760
1761         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1762
1763 2010-12-22  Lucas Forschler  <lforschler@apple.com>
1764
1765         Reviewed by Alice Liu.
1766
1767         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
1768         Verified on Chrome, Safari, and IE.
1769         With this change, we will record memory from a parent browser window and all child processes.
1770
1771         * record-memory-win/main.cpp:
1772         (ProcessArgs):
1773         (PrintUsage):
1774         (getMemoryInfo):
1775         (printProcessInfo):
1776         (evalProcesses):
1777         (UseImage):
1778         (QueryContinuously):
1779         (ElapsedTime):
1780
1781 2010-12-22  Lucas Forschler  <lforschler@apple.com>
1782
1783         Unreviewed rollout r74489, because it was missing changelog.
1784
1785         * record-memory-win/main.cpp:
1786         
1787 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
1788
1789         Adding myself as a reviewer.
1790
1791         * Scripts/webkitpy/common/config/committers.py:
1792
1793 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
1794
1795         Unreviewed.  Adding myself to committers.py.
1796
1797         * Scripts/webkitpy/common/config/committers.py:
1798
1799 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
1800
1801         Reviewed by Kenneth Rohde Christiansen.
1802
1803         TestNetscapePlugIn should use #if defined
1804         https://bugs.webkit.org/show_bug.cgi?id=51471
1805
1806         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1807         (NP_Initialize):
1808         (NPP_New):
1809
1810 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
1811
1812         Reviewed by Yury Semikhatsky.
1813
1814         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
1815
1816         DevTools window should be closed explicitly because it has custom deinitialization code.
1817
1818         https://bugs.webkit.org/show_bug.cgi?id=50722
1819
1820         * DumpRenderTree/chromium/TestShell.cpp:
1821         (TestShell::closeRemainingWindows):
1822
1823 2010-12-22  David Levin  <levin@chromium.org>
1824
1825         Reviewed by Shinichiro Hamaji.
1826
1827         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
1828         https://bugs.webkit.org/show_bug.cgi?id=51452
1829
1830         * Scripts/webkitpy/style/checkers/cpp.py:
1831         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
1832         Using the file extension if possible but falling back to the file contents if we have a header file.
1833         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
1834         (_FileState.is_c_or_objective_c):
1835         (check_using_std): Changed to using _FileState to determine the file type.
1836         (check_max_min_macros): Ditto.
1837         (check_for_null): Ditto.
1838         (check_style): Changed the parameters to various calls since they now need _FileState
1839         to determine the file type.
1840         (check_language): Added the file_state parameter so it could be passed
1841         to check_identifier_name_in_declaration.
1842         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
1843         this is an Objective C file.
1844         (_process_lines): Added information for the _FileState constructor (and moved the
1845         call to a place that had the information).
1846         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1847         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
1848         its functionality.
1849         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
1850
1851 2010-12-21  Andy Estes  <aestes@apple.com>
1852
1853         Reviewed by Mark Rowe.
1854
1855         Do not build non-Intel architectures for WebKit2-related projects.
1856         https://bugs.webkit.org/show_bug.cgi?id=51440
1857
1858         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
1859         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1860         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1861
1862 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
1863
1864         Reviewed by Darin Fisher.
1865
1866         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
1867         https://bugs.webkit.org/show_bug.cgi?id=51406 
1868         
1869         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
1870         to WebThemeEngineDRTWin and update references everywhere.
1871
1872         * DumpRenderTree/DumpRenderTree.gypi:
1873         * DumpRenderTree/chromium/TestShellWin.cpp:
1874         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
1875         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
1876         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
1877         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
1878
1879 2010-12-21  Anders Carlsson  <andersca@apple.com>
1880
1881         Reviewed by John Sullivan.
1882
1883         Clicking missing plug-in text does not show a sheet
1884         https://bugs.webkit.org/show_bug.cgi?id=51403
1885
1886         Update for changes to the WebPageUIClient.
1887
1888         * MiniBrowser/mac/BrowserWindowController.m:
1889         (-[BrowserWindowController awakeFromNib]):
1890         * WebKitTestRunner/TestController.cpp:
1891         (WTR::createOtherPage):
1892         (WTR::TestController::initialize):
1893
1894 2010-12-21  Eric Seidel  <eric@webkit.org>
1895
1896         Reviewed by Adam Barth.
1897
1898         commit-queue will report constant failures as flaky if other tests flake
1899         https://bugs.webkit.org/show_bug.cgi?id=51272
1900
1901         This patch just removes functionality and adds testing.
1902         Previously we attempted to report flaky tests when we had
1903         two different tests fail in a row.  However, since we stop
1904         running the tests at the first failure, our code was wrong in
1905         trying to determine flakiness from the incomplete runs.
1906
1907         Originally I posted an alternate patch:
1908         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
1909         which fixed our flaky logic in this case, however it was decided
1910         that that patch would be too difficult to maintain, so now
1911         I'm just removing the broken logic.
1912
1913         This will dramatically cut-down on our flaky-test false positives
1914         at the (small) cost of the queues being unable to report
1915         any flakiness if the tree is very flaky.  (With at least one test
1916         flaking on every run, we'll never report failures anymore.)  I think
1917         this is a tradeoff worth making.
1918
1919         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1920         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1921
1922 2010-12-20  Eric Seidel  <eric@webkit.org>
1923
1924         Reviewed by Adam Barth.
1925
1926         commit-queue wrongly rejects patches when it can't update itself
1927         https://bugs.webkit.org/show_bug.cgi?id=46636
1928
1929         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1930         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1931         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1932
1933 2010-12-20  Adam Barth  <abarth@webkit.org>
1934
1935         Move web sites to Websites directory
1936         https://bugs.webkit.org/show_bug.cgi?id=51323
1937
1938         Update references to BugsSite to point to the new location.
1939
1940         This patch was never officially reviewed (because it was too large to
1941         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
1942         Rowe gave me the green light.
1943
1944         * Scripts/old-run-webkit-tests:
1945         * Scripts/webkitpy/common/config/build.py:
1946         * Scripts/webkitpy/common/config/build_unittest.py:
1947         * Scripts/webkitpy/common/prettypatch.py:
1948         * Scripts/webkitpy/layout_tests/port/base.py:
1949         * Scripts/webkitpy/style/main.py:
1950
1951 2010-12-20  Adrienne Walker  <enne@google.com>
1952
1953         Unreviewed. Adding myself to the list of committers.
1954
1955         * webkitpy/common/config/committers.py:
1956
1957 2010-12-20  Mark Rowe  <mrowe@apple.com>
1958
1959         Reviewed by Dan Bernstein.
1960
1961         <rdar://problem/8757601> Don't install header files in to the Resources directory.
1962
1963         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
1964         Resources directory.
1965
1966 2010-12-20  Eric Seidel  <eric@webkit.org>
1967
1968         Reviewed by Adam Barth.
1969
1970         commit-queue should include bot id when attaching failure diffs
1971         https://bugs.webkit.org/show_bug.cgi?id=51280
1972
1973         This is a tiny change to include the bot id in the name of the attachment.
1974         Most of this diff is just changing the unit test expectations
1975         now that I hid the comment printing when the comment is None.
1976
1977         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1978         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1979         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1980         * Scripts/webkitpy/tool/mocktool.py:
1981
1982 2010-12-20  Jeff Miller  <jeffm@apple.com>
1983
1984         Reviewed by Dan Bernstein.
1985
1986         Tools/vcbin/midl.exe needs to be rebuilt
1987         https://bugs.webkit.org/show_bug.cgi?id=51347
1988
1989         * vcbin/midl.exe: Rebuilt.
1990
1991 2010-12-20  David Levin  <levin@chromium.org>
1992
1993         Reviewed by Ariya Hidayat.
1994
1995         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
1996         https://bugs.webkit.org/show_bug.cgi?id=51343
1997
1998         Follow up from the WebKitTools -> Tools rename.
1999
2000         * Scripts/webkit-tools-completion.sh:
2001
2002 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2003
2004         Reviewed by James Robinson.
2005
2006         new-run-webkit-tests ignores trailing EOL differences in text tests
2007         https://bugs.webkit.org/show_bug.cgi?id=36983
2008
2009         Changed the handling of new-line characters within new-run-webkit-tests
2010         to match old-run-webkit-tests.  Differences in leading and trailing empty
2011         lines in text expectation files are no longer ignored.
2012
2013         * Scripts/webkitpy/layout_tests/port/base.py:
2014         * Scripts/webkitpy/layout_tests/port/test.py:
2015         Added unit tests.  Removed old duplicate unit test entries.
2016         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2017
2018 2010-12-20  David Levin  <levin@chromium.org>
2019
2020         Reviewed by Shinichiro Hamaji.
2021
2022         check-webkit-style should detect function declarations (and trivial functions).
2023         https://bugs.webkit.org/show_bug.cgi?id=51303
2024
2025         * Scripts/webkitpy/style/checkers/cpp.py:
2026         (_FunctionState.begin): Add is_declaration and changed the line count
2027         start to begin at -1 (which will keep the results consistent, since
2028         the starting line number passed in is one less in this change).
2029         (detect_functions): changed function detection to now catch trivial
2030         functions and declarations.
2031         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2032         of the function as this may look at return values (when processing
2033         a declaration).
2034         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2035         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2036         of testing the function detection.
2037         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2038         function.
2039         (FunctionDetectionTest.test_function_declaration_detection): Test a
2040         declaration.
2041         (FunctionDetectionTest.test_non_functions): A test case for a case
2042         that caused the code to fail due to the { being in quotes.
2043         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2044         cases to help catch false alarms for return values.
2045         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2046         we don't get false alarms for member variables either.
2047
2048 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2049
2050         Reviewed by Antonio Gomes.
2051
2052         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2053         https://bugs.webkit.org/show_bug.cgi?id=51319
2054
2055         * CMakeListsEfl.txt:
2056
2057 2010-12-18  Adam Barth  <abarth@webkit.org>
2058
2059         Reviewed by Sam Weinig.
2060
2061         Move WebKitExamplePlugins to Examples
2062         https://bugs.webkit.org/show_bug.cgi?id=51291
2063
2064         * Scripts/webkitpy/common/config/build.py:
2065
2066 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2067
2068         Unreviewed Qt buildfix after r74301.
2069
2070         Rename WebKitTools to Tools
2071         https://bugs.webkit.org/show_bug.cgi?id=49861
2072
2073         * MiniBrowser/DerivedSources.pro:
2074         * MiniBrowser/qt/MiniBrowser.pro:
2075
2076 2010-12-17  Dan Bernstein  <mitz@apple.com>
2077
2078         Reviewed by Simon Fraser.
2079
2080         Rename WebKitTools to Tools
2081         https://bugs.webkit.org/show_bug.cgi?id=49861
2082
2083         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2084         * CodeCoverage/README:
2085         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2086         (WebCore::DumpRenderTree::initializeFonts):
2087         * EWSTools/start-commit-queue.sh:
2088         * EWSTools/start-queue.sh:
2089         * GNUmakefile.am:
2090         * MIDLWrapper/MIDLWrapper.cpp:
2091         (wmain):
2092         * MiniBrowser/qt/MiniBrowser.pro:
2093         * Scripts/build-api-tests:
2094         * Scripts/build-dumprendertree:
2095         * Scripts/build-webkit:
2096         * Scripts/build-webkittestrunner:
2097         * Scripts/generate-coverage-data:
2098         * Scripts/old-run-webkit-tests:
2099         * Scripts/run-api-tests:
2100         * Scripts/run-iexploder-tests:
2101         * Scripts/run-javascriptcore-tests:
2102         * Scripts/run-mangleme-tests:
2103         * Scripts/run-sunspider:
2104         * Scripts/run-webkit-websocketserver:
2105         * Scripts/sunspider-compare-results:
2106         * Scripts/test-webkitperl:
2107         * Scripts/test-webkitpy:
2108         * Scripts/update-iexploder-cssproperties:
2109         * Scripts/update-webkit:
2110         * Scripts/update-webkit-localizable-strings:
2111         * Scripts/webkitdirs.pm:
2112         * Scripts/webkitpy/common/checkout/scm.py:
2113         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2114         * Scripts/webkitpy/common/config/committervalidator.py:
2115         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2116         * Scripts/webkitpy/common/config/ports.py:
2117         * Scripts/webkitpy/common/config/ports_unittest.py:
2118         * Scripts/webkitpy/common/system/logutils_unittest.py:
2119         * Scripts/webkitpy/common/system/ospath_unittest.py:
2120         * Scripts/webkitpy/layout_tests/port/chromium.py:
2121         * Scripts/webkitpy/layout_tests/port/config.py:
2122         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2123         * Scripts/webkitpy/layout_tests/port/http_server.py:
2124         * Scripts/webkitpy/layout_tests/port/test.py:
2125         * Scripts/webkitpy/style/checker.py:
2126         * Scripts/webkitpy/style/checker_unittest.py:
2127         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2128         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2129         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2130         * WebKitTestRunner/DerivedSources.pro:
2131         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2132         (WTR::activateFonts):
2133         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2134         * wx/build/build_utils.py:
2135
2136 2010-12-16  Antonio Gomes  <agomes@rim.com>
2137
2138         Reviewed by Martin Robinson.
2139
2140         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
2141         https://bugs.webkit.org/show_bug.cgi?id=51163
2142
2143         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
2144         GTK+'s DRT should also reset to UNIX after each test execution.
2145
2146         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2147         (resetDefaultsToConsistentValues):
2148
2149 2010-12-17  David Levin  <levin@chromium.org>
2150
2151         Reviewed by Eric Seidel.
2152
2153         check-webkit-style should understand WTF #include guards
2154         https://bugs.webkit.org/show_bug.cgi?id=44911
2155
2156         * Scripts/webkitpy/style/checkers/cpp.py:
2157         (get_header_guard_cpp_variable): modify to suggest the WTF style
2158         of header guard when appropriate.
2159         (check_for_header_guard): handle multiple return values from
2160         get_header_guard_cpp_variable
2161         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2162         (CppStyleTest.test_build_header_guard): Added tests for the WTF
2163         header style.
2164
2165 2010-12-16  David Levin  <levin@chromium.org>
2166
2167         Reviewed by Eric Seidel.
2168
2169         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2170         https://bugs.webkit.org/show_bug.cgi?id=51210
2171
2172         The error only shows up when using python 2.6 or later.
2173
2174         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2175         the decprecated field error,message with something equivalent.
2176
2177 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2178
2179         Reviewed by Eric Seidel.
2180
2181         Add --exit-after-n-failures/crashes to NRWT
2182         https://bugs.webkit.org/show_bug.cgi?id=51160
2183         
2184         Abort test run (in a similar way to how control-C is handled) when
2185         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
2186         that number of unexpected failures/crashes/timeouts.
2187
2188         * Scripts/webkitpy/layout_tests/port/test.py:
2189         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2190         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2191
2192 2010-12-16  David Levin  <levin@chromium.org>
2193
2194         Reviewed by Shinichiro Hamaji.
2195
2196         check-webkit-style unit tests has some duplicate boilerplate code.
2197         https://bugs.webkit.org/show_bug.cgi?id=49519
2198
2199         * Scripts/webkitpy/style/checkers/cpp.py:
2200         (update_include_state): Replaced the "io" parameter with the global
2201         configuration _unit_test_config. This allowed not calling into
2202         functions at a low level and also not plumbing through the injection
2203         information through many levels of code.
2204         (check_for_include_what_you_use): Ditto.
2205         (process_file_data): Added the ability to set up the unit test config
2206         to allow for injection.
2207         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2208         (ErrorCollector.__init__): Added support for having a filter for errors.
2209         (ErrorCollector.__call__): Ditto.
2210         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
2211         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
2212         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
2213         functions in the cpp.py with generic processing and a filter that
2214         indicates what errors should be kept.
2215         (CppStyleTestBase.perform_multi_line_lint): Ditto.
2216         (CppStyleTestBase.perform_language_rules_check): Ditto.
2217         (CppStyleTestBase.perform_function_lengths_check): Ditto.
2218         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
2219         (CppStyleTestBase.perform_include_what_you_use): Ditto.
2220         (CppStyleTest.test_multi_line_comments): Added another
2221         error message which applies to the test case.
2222         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
2223         to not have config.h, since it is processed as a header file.
2224         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
2225         style and indentation in checked code.
2226         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
2227         Fixed line number.
2228         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
2229         Ditto.
2230
2231 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2232
2233         Unreviewed, rolling out r74136.
2234         http://trac.webkit.org/changeset/74136
2235         https://bugs.webkit.org/show_bug.cgi?id=51135
2236
2237         r74136 breaks chromium canary bots because some tests are not
2238         rebaselined correctly to resolve EOL differences (Requested by
2239         jianli on #webkit).
2240
2241         * Scripts/webkitpy/layout_tests/port/base.py:
2242         * Scripts/webkitpy/layout_tests/port/test.py:
2243         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2244
2245 2010-12-15  Adam Roben  <aroben@apple.com>
2246
2247         Teach check-webkit-style to check .vcproj and .vsprops files for XML
2248         syntax errors
2249
2250         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
2251         XML syntax errors in .vcproj/.vsprops files
2252
2253         Reviewed by Dave Levin.
2254
2255         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
2256         that should be treated as XML and that should be allowed to contain
2257         carriage returns. (These lists happen to be identical currently.)
2258         (FileType): Added a new XML type.
2259         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
2260         Just does a simple file extension check.
2261         (CheckerDispatcher._file_type): Added a case for XML files.
2262         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
2263         files (surprise!).
2264         (StyleProcessor.process): Ask the dispatcher whether we should pass the
2265         lines through the carriage checker.
2266
2267         * Scripts/webkitpy/style/checker_unittest.py:
2268         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
2269         Added. Checks a few file names to see if carriage returns are allowed
2270         or not.
2271         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
2272         other assert_checker_* functions.
2273         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2274         test_*_paths functions.
2275         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2276         test_*_paths functions.
2277         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
2278         file from this test case, as vcproj files now have a type.
2279         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
2280         Added. Similar to the other should_* functions.
2281         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
2282         Added. Checks that carriage returns aren't checked for or stripped for
2283         allowed files.
2284
2285         * Scripts/webkitpy/style/checkers/xml.py: Added.
2286         (XMLChecker.__init__): Simple init method.
2287         (XMLChecker.check): Pass each line through the expat parser, and record
2288         a style error for any errors thrown by the parser.
2289
2290         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
2291         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
2292         produce a style error.
2293         (XMLCheckerTest.assert_error): Checks that the given XML produces an
2294         error of the given category on the given line.
2295         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
2296         checking that the XMLChecker constructor works properly.
2297         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
2298         cause a style error (see, e.g., r73887).
2299         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
2300         cause a style error (see, e.g., r73773).
2301         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
2302         properly.
2303         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
2304         tags cause a style error (see, e.g., r72795).
2305         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
2306         style error.
2307
2308 2010-12-15  Lucas Forschler  <lforschler@apple.com>
2309
2310         Reviewed by Stephanie Lewis.
2311
2312         https://bugs.webkit.org/show_bug.cgi?id=51117
2313         Add a new leopard test bot
2314         really really commit to trunk this time.
2315
2316         * BuildSlaveSupport/build.webkit.org-config/config.json:
2317
2318 2010-12-15  Sam Weinig  <sam@webkit.org>
2319
2320         Reviewed by Anders Carlsson.
2321
2322         WebKit2: Can't add files to an <input type=file>
2323         https://bugs.webkit.org/show_bug.cgi?id=51087
2324
2325         * MiniBrowser/mac/BrowserWindowController.m:
2326         (runOpenPanel):
2327         (-[BrowserWindowController awakeFromNib]):
2328         Add simple implementation of runOpenPanel callback.
2329
2330         * MiniBrowser/win/BrowserView.cpp:
2331         (BrowserView::create):
2332         * WebKitTestRunner/TestController.cpp:
2333         (WTR::createOtherPage):
2334         (WTR::TestController::initialize):
2335         Stub out runOpenPanel callback. 
2336
2337 2010-12-14  Eric Seidel  <eric@webkit.org>
2338
2339         Reviewed by Adam Barth.
2340
2341         commit-queue should upload failure diffs when tests flake
2342         https://bugs.webkit.org/show_bug.cgi?id=51051
2343
2344         To make this testable I needed to pipe FileSystem down onto tool.
2345         We've wanted it there for a long time anyway.
2346
2347         This patch is kinda a big hack.  But we don't have a nice
2348         way to read results.html files.  I think this will need further
2349         revision before this code actually feels clean.
2350
2351         As part of testing this change, I had to make MockBugzilla.create_bug
2352         actually return an id (like it should) which required updating
2353         a few other unit test results (for the better).
2354
2355         The results_matching_keys change in layouttestresults/rebasline
2356         was an alternate path which I decided not to use in the end, but
2357         I left the change as it seemed an improvement.
2358
2359         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2360         * Scripts/webkitpy/common/net/layouttestresults.py:
2361         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2362         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2363         * Scripts/webkitpy/tool/commands/queues.py:
2364         * Scripts/webkitpy/tool/commands/rebaseline.py:
2365         * Scripts/webkitpy/tool/main.py:
2366         * Scripts/webkitpy/tool/mocktool.py:
2367
2368 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
2369
2370         Reviewed by James Robinson.
2371
2372         new-run-webkit-tests ignores trailing EOL differences in text tests
2373         https://bugs.webkit.org/show_bug.cgi?id=36983
2374
2375         Changed the handling of new-line characters within new-run-webkit-tests
2376         to match old-run-webkit-tests.  Differences in leading and trailing empty
2377         lines in text expectation files are no longer ignored.
2378
2379         * Scripts/webkitpy/layout_tests/port/base.py:
2380         * Scripts/webkitpy/layout_tests/port/test.py:
2381         Added unit tests.  Removed old duplicate unit test entries.
2382         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2383
2384 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2385
2386         Reviewed by Adam Barth.
2387
2388         make status-bubble white-space:nowrap so we can measure it's width without wrapping
2389         https://bugs.webkit.org/show_bug.cgi?id=51149
2390
2391         * QueueStatusServer/templates/statusbubble.html:
2392
2393 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2394
2395         Reviewed by Adam Barth.
2396
2397         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
2398         https://bugs.webkit.org/show_bug.cgi?id=51125
2399
2400         * QueueStatusServer/templates/statusbubble.html:
2401
2402 2010-12-15  Darin Adler  <darin@apple.com>
2403
2404         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
2405
2406 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2407
2408         Unreviewed, rolling out r74117.
2409         http://trac.webkit.org/changeset/74117
2410         https://bugs.webkit.org/show_bug.cgi?id=51113
2411
2412         This broke the GTK1 build. (Requested by mrobinson on
2413         #webkit).
2414
2415         * Scripts/webkitdirs.pm:
2416
2417 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
2418
2419         Reviewed by Martin Robinson.
2420
2421         Change generate-forwarding-headers.pl for GTK port usage 
2422         (https://bugs.webkit.org/show_bug.cgi?id=37369)
2423
2424         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
2425
2426 2010-12-14  Kent Tamura  <tkent@chromium.org>
2427
2428         Reviewed by Jian Li.
2429
2430         [DRT/Chromium] Remove another unnecessary error message
2431         https://bugs.webkit.org/show_bug.cgi?id=51083
2432
2433         * DumpRenderTree/chromium/WebViewHost.cpp:
2434         (WebViewHost::didInvalidateRect):
2435
2436 2010-12-14  Lucas Forschler  <lforschler@apple.com>
2437
2438         Reviewed by Stephanie Lewis.
2439
2440         Add a new Leopard Debug Test WK2 Bot
2441
2442         * BuildSlaveSupport/build.webkit.org-config/config.json:
2443
2444 2010-12-14  Ojan Vafai  <ojan@chromium.org>
2445
2446         Fix python unittests after http://trac.webkit.org/changeset/74070.
2447
2448         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2449
2450 2010-12-14  Kent Tamura  <tkent@chromium.org>
2451
2452         Reviewed by Jian Li.
2453
2454         [DRT/Chromium] Remove a unnecessary error message
2455         https://bugs.webkit.org/show_bug.cgi?id=51069
2456
2457         * DumpRenderTree/chromium/WebViewHost.cpp:
2458         (WebViewHost::paintInvalidatedRegion):
2459
2460 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
2461
2462         Reviewed by Ojan Vafai.
2463
2464         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
2465         https://bugs.webkit.org/show_bug.cgi?id=48926
2466
2467         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2468         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
2469
2470 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2471
2472         Reviewed by Eric Seidel.
2473
2474         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
2475         https://bugs.webkit.org/show_bug.cgi?id=50231
2476
2477         Guard CONFIG+=link_pkgconfig with !symbian.
2478
2479         * DumpRenderTree/qt/DumpRenderTree.pro:
2480         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2481         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2482
2483 2010-12-14  Philippe Normand  <pnormand@igalia.com>
2484
2485         Reviewed by Ojan Vafai.
2486
2487         [new-run-webkit-tests] expectations parsing is slow
2488         https://bugs.webkit.org/show_bug.cgi?id=50635
2489
2490         Avoid expensive iteration of all the tests when checking if a test
2491         file is to be skipped or not.
2492
2493         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2494         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2495         * Scripts/webkitpy/layout_tests/port/test.py:
2496
2497 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
2498
2499         Reviewed by Xan Lopez.
2500
2501         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
2502         https://bugs.webkit.org/show_bug.cgi?id=27048
2503
2504         Add support in DRT for checking whether an accessibility UI
2505         element is focusable and/or focused. Implemented for GTK.
2506
2507         * DumpRenderTree/AccessibilityUIElement.cpp:
2508         (getIsFocusedCallback): New.
2509         (getIsFocusableCallback): New.
2510         (AccessibilityUIElement::getJSClass): Add the new available
2511         callbacks for isFocused and isFocusable.
2512         * DumpRenderTree/AccessibilityUIElement.h:
2513         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2514         (AccessibilityUIElement::isFocused): New, implemented by checking
2515         whether the related AtkState value is in the object's state set.
2516         (AccessibilityUIElement::isFocusable): Ditto.
2517         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2518         (AccessibilityUIElement::isFocused): New, dummy implementation.
2519         (AccessibilityUIElement::isFocusable): Ditto.
2520         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2521         (AccessibilityUIElement::isFocused): Ditto.
2522         (AccessibilityUIElement::isFocusable): Ditto.
2523
2524 2010-12-14  Eric Seidel  <eric@webkit.org>
2525
2526         Reviewed by Ojan Vafai.
2527
2528         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
2529         https://bugs.webkit.org/show_bug.cgi?id=50715
2530
2531         This patch makes webkit-patch print the following:
2532
2533         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
2534         Install a 64-bit git for better performance, see:
2535         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
2536
2537         I wrote this mostly because I have approximately 8 machines that I use
2538         and making sure each one is using a good Git install seemed folly.
2539         webkit-patch makes a lot of git calls, so using a fast git can shave
2540         several seconds in every invocation.  See the webkit-dev thread for more info.
2541
2542         This message will print twice during 'webkit-patch upload',
2543         once from webkit-patch and once from check-webkit-style.
2544
2545         Unfortunately there is no good way to test this due to how machine-dependent
2546         the code is.  I considered writing a test for the log message, but it seemed not worth it.
2547
2548         * Scripts/webkitpy/common/checkout/scm.py:
2549
2550 2010-12-13  Eric Seidel  <eric@webkit.org>
2551
2552         Reviewed by Adam Barth.
2553
2554         FlakyTestReporter doesn't understand bots running from multiple email addresses
2555         https://bugs.webkit.org/show_bug.cgi?id=50960
2556
2557         This explains at least one of the dupes of:
2558         https://bugs.webkit.org/show_bug.cgi?id=50863
2559         that we saw filed by the commit-queue this morning.
2560         I think the other one was explained by my previous fix to result counting code.
2561
2562         Since this is really hard to test with a unit test, instead I
2563         create a new (possibly useful in the future) command
2564         which given a layout test path will return you
2565         the one bug which our tools would assume it the flaky test bug.
2566         If some other script wants to use bug-for-test we'll
2567         need to extend it with some options like --create-if-missing or similar.
2568
2569         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2570         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2571         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2572         * Scripts/webkitpy/tool/commands/__init__.py:
2573         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
2574
2575 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
2576
2577         Reviewed by James Robinson.
2578
2579         Add option to build-webkit to not build WebKit2
2580         https://bugs.webkit.org/show_bug.cgi?id=50988
2581         
2582         Add support for a --no-webkit2 option to build-webkit. It seems to save
2583         ~1 minute from clean builds and ~10 seconds from no-op builds.
2584
2585         * Scripts/build-webkit:
2586
2587 2010-12-13  Lucas Forschler  <lforschler@apple.com>
2588
2589         Reviewed by Dave Kilzer.
2590
2591         Update iexploder from 1.3.2 to 1.7.2
2592         Move 1.3.2 into its own subdir
2593         Add 1.7.2 into its own subdir
2594         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
2595
2596         * Scripts/run-iexploder-tests:
2597         * Scripts/update-iexploder-cssproperties:
2598         * iExploder/CHANGELOG.txt: Removed.
2599         * iExploder/LICENSE.txt: Removed.
2600         * iExploder/README.txt: Removed.
2601         * iExploder/htdocs: Removed.
2602         * iExploder/iexploder-1.3.2: Added.
2603         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
2604         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
2605         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
2606         * iExploder/iexploder-1.3.2/htdocs: Added.
2607         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
2608         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
2609         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
2610         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
2611         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
2612         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
2613         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
2614         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
2615         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
2616         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
2617         * iExploder/iexploder-1.3.2/tools: Added.
2618         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
2619         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
2620         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
2621         * iExploder/iexploder-1.7.2: Added.
2622         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
2623         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
2624         * iExploder/iexploder-1.7.2/README.txt: Added.
2625         * iExploder/iexploder-1.7.2/output: Added.
2626         * iExploder/iexploder-1.7.2/src: Added.
2627         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
2628         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
2629         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
2630         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
2631         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
2632         * iExploder/iexploder-1.7.2/src/css-properties: Added.
2633         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
2634         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
2635         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
2636         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
2637         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
2638         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
2639         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
2640         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
2641         * iExploder/iexploder-1.7.2/src/css-values: Added.
2642         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
2643         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
2644         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
2645         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
2646         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
2647         * iExploder/iexploder-1.7.2/src/headers: Added.
2648         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
2649         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
2650         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
2651         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
2652         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
2653         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
2654         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
2655         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
2656         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
2657         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
2658         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
2659         * iExploder/iexploder-1.7.2/src/html-tags: Added.
2660         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
2661         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
2662         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
2663         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
2664         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
2665         * iExploder/iexploder-1.7.2/src/html-values: Added.
2666         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
2667         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
2668         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
2669         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
2670         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
2671         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
2672         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
2673         * iExploder/iexploder-1.7.2/src/index.html: Added.
2674         * iExploder/iexploder-1.7.2/src/media: Added.
2675         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
2676         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
2677         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
2678         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
2679         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
2680         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
2681         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
2682         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
2683         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
2684         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
2685         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
2686         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
2687         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
2688         * iExploder/iexploder-1.7.2/src/mime-types: Added.
2689         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
2690         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
2691         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
2692         * iExploder/iexploder-1.7.2/src/protocols: Added.
2693         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
2694         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
2695         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
2696         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
2697         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
2698         * iExploder/iexploder-1.7.2/src/version.rb: Added.
2699         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
2700         * iExploder/iexploder-1.7.2/testcases: Added.
2701         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
2702         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
2703         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
2704         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
2705         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
2706         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
2707         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
2708         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
2709         * iExploder/iexploder-1.7.2/tools: Added.
2710         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
2711         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
2712         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
2713         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
2714         * iExploder/tools: Removed.
2715
2716 2010-12-13  Sam Weinig  <sam@webkit.org>
2717
2718         Reviewed by Anders Carlsson.
2719
2720         Remove associated page concept from WKView constructor
2721         https://bugs.webkit.org/show_bug.cgi?id=50983
2722
2723         Step 1: Remove associate page constructors from WKView and make
2724         all views use the shared namespace for the context.
2725
2726         * TestWebKitAPI/PlatformWebView.h:
2727         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2728         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2729         * WebKitTestRunner/PlatformWebView.h:
2730         * WebKitTestRunner/TestController.cpp:
2731         (WTR::createOtherPage):
2732         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2733         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2734         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2735
2736 2010-12-13  Sam Weinig  <sam@webkit.org>
2737
2738         Reviewed by Anders Carlsson.
2739
2740         Change the WebKit2 public API so there is no explicit WKPageNamespace object
2741         https://bugs.webkit.org/show_bug.cgi?id=50898
2742
2743         * MiniBrowser/mac/AppDelegate.h:
2744         * MiniBrowser/mac/AppDelegate.m:
2745         * MiniBrowser/mac/BrowserWindowController.h:
2746         * MiniBrowser/mac/BrowserWindowController.m:
2747         * MiniBrowser/win/BrowserView.cpp:
2748         Convert MiniBrowser to not use PageNamespaces.
2749
2750         * TestWebKitAPI/PlatformWebView.h:
2751         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2752         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2753         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2754         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2755         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2756         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2757         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2758         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2759         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2760         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2761         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2762         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2763         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2764         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2765         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2766         Convert TestWebKitAPI to not use PageNamespaces.
2767
2768         * WebKitTestRunner/PlatformWebView.h:
2769         * WebKitTestRunner/TestController.cpp:
2770         * WebKitTestRunner/TestController.h:
2771         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2772         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2773         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2774         Convert WebKitTestRunner to not use PageNamespaces.
2775
2776 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2777
2778         Reviewed by Eric Seidel.
2779
2780         webkit-patch rollout should be able to do multi-revision rollouts
2781         https://bugs.webkit.org/show_bug.cgi?id=33336
2782
2783         Make it possible to pass more than one revision to webkit-patch.
2784
2785         * Scripts/webkitpy/common/checkout/api.py:
2786         * Scripts/webkitpy/common/checkout/changelog.py:
2787         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2788         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2789         * Scripts/webkitpy/tool/commands/download.py:
2790         * Scripts/webkitpy/tool/commands/download_unittest.py:
2791         * Scripts/webkitpy/tool/mocktool.py:
2792         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2793         * Scripts/webkitpy/tool/steps/revertrevision.py:
2794
2795 2010-12-13  Eric Seidel  <eric@webkit.org>
2796
2797         Unreviewed.
2798
2799         Teach webkit-patch how to search bugzilla
2800         https://bugs.webkit.org/show_bug.cgi?id=50500
2801
2802         webkit-patch bug-search fails when there is only one result.
2803         Turns out we needed a bit more logic in our result count parsing code.
2804
2805         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2806         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2807
2808 2010-12-13  Antti Koivisto  <antti@apple.com>
2809
2810         Reviewed by Alexey Proskuryakov.
2811
2812         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
2813         https://bugs.webkit.org/show_bug.cgi?id=50758
2814
2815         * DumpRenderTree/LayoutTestController.cpp:
2816         (setSerializeHTTPLoadsCallback):
2817         (LayoutTestController::staticFunctions):
2818         * DumpRenderTree/LayoutTestController.h:
2819         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2820         (LayoutTestController::setSerializeHTTPLoads):
2821         * DumpRenderTree/mac/DumpRenderTree.mm:
2822         (resetDefaultsToConsistentValues):
2823         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2824         (LayoutTestController::setSerializeHTTPLoads):
2825         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2826         (LayoutTestController::setSerializeHTTPLoads):
2827
2828 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
2829
2830         Reviewed by Ojan Vafai.
2831
2832         Remove "use-drt" option from test step command line, since the option was removed in r73748.
2833         https://bugs.webkit.org/show_bug.cgi?id=50936
2834
2835         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
2836
2837 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
2838
2839         Reviewed by Csaba Osztrogonác.
2840
2841         Add revlink to BuildBot status
2842         https://bugs.webkit.org/show_bug.cgi?id=50914
2843
2844         This adds a hyperlink to trac changeset on the revision numbers. 
2845
2846         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2847
2848 2010-12-13  Andras Becsi  <abecsi@webkit.org>
2849
2850         Reviewed by Csaba Osztrogonác.
2851
2852         [Qt][WK2] Fix build if WebKitTools are not available
2853         https://bugs.webkit.org/show_bug.cgi?id=50242
2854
2855         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
2856         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
2857         * MiniBrowser/DerivedSources.pro: Added.
2858
2859 2010-12-13  Eric Seidel  <eric@webkit.org>
2860
2861         Reviewed by Adam Barth.
2862
2863         EWS Queues should remove orpahned pyc files before starting
2864         https://bugs.webkit.org/show_bug.cgi?id=50904
2865
2866         A previous check added a platform.py which caused
2867         EWS bots on some platforms to hit an import exception.
2868         The platform.py file was removed in a subsequent commit, but
2869         the EWS bots in question stayed stuck.  This change will
2870         fix those bots once restarted (and prevent this in the future).
2871
2872         I also went ahead and unified start-queue and start-commit-queue
2873         since they were nearly identical.  I also added bot_id support
2874         to both force all EWSes to have bot ids as well as get rid of the one
2875         remaining reason why I had my own copies of these scripts.
2876         Hopefully this will be enough to get all the other bot admins
2877         (ahem, Adam, ahem) to move to using these checked in copies as well.
2878
2879         * EWSTools/start-commit-queue.sh: Removed.
2880         * EWSTools/start-queue.sh:
2881
2882 2010-10-28  MORITA Hajime  <morrita@google.com>
2883
2884         Reviewed by Ojan Vafai.
2885
2886         spellcheck does not check pasted text
2887         https://bugs.webkit.org/show_bug.cgi?id=40092
2888
2889         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
2890         to control the setting.
2891
2892         * DumpRenderTree/LayoutTestController.cpp:
2893         (setAsynchronousSpellCheckingEnabledCallback):
2894         (LayoutTestController::staticFunctions):
2895         * DumpRenderTree/LayoutTestController.h:
2896         * DumpRenderTree/chromium/LayoutTestController.h:
2897         * DumpRenderTree/chromium/LayoutTestController.cpp:
2898         (LayoutTestController::LayoutTestController):
2899         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2900         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2901         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2902         * DumpRenderTree/mac/DumpRenderTree.mm:
2903         (resetDefaultsToConsistentValues):
2904         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2905         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2906         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2907         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2908         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2909         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2910         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2911         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2912         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2913
2914 2010-12-12  Sam Weinig  <sam@webkit.org>
2915
2916         Reviewed by Anders Carlsson.
2917
2918         Fix failing API test. It turns out that a pop-state event
2919         is sent before every fragment navigation, so we have to test
2920         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
2921
2922         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2923         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2924
2925 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
2926
2927         Reviewed by Eric Seidel.
2928
2929         [GTK] Add new-run-webkit-tests support to gtk
2930         https://bugs.webkit.org/show_bug.cgi?id=50681
2931
2932         Adding the basic support to run the new-run-webkit-tests.
2933
2934         * Scripts/webkitpy/layout_tests/port/gtk.py:
2935
2936 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
2937
2938         Reviewed by Kenneth Rohde Christiansen.
2939
2940         [Qt] Mock DeviceOrientation client for DRT
2941         https://bugs.webkit.org/show_bug.cgi?id=47490
2942
2943         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2944         (WebCore::DumpRenderTree::DumpRenderTree):
2945         (WebCore::DumpRenderTree::~DumpRenderTree):
2946         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2947         (LayoutTestController::setMockDeviceOrientation):
2948
2949 2010-12-11  Philippe Normand  <pnormand@igalia.com>
2950
2951         Reviewed by Gustavo Noronha Silva.
2952
2953         [GTK] launcher: disable the Mozilla-style fullscreen API
2954         https://bugs.webkit.org/show_bug.cgi?id=50874
2955
2956         Disabling the fullscreen API until its implementation for GTK is
2957         mature enough. The webview setting for it is already FALSE by
2958         default.
2959
2960         * GtkLauncher/main.c:
2961         (createWindow):
2962
2963 2010-12-10  Eric Seidel  <eric@webkit.org>
2964
2965         Reviewed by Adam Barth.
2966
2967         commit-queue flaky test messages show cryptic version information for mac os x
2968         https://bugs.webkit.org/show_bug.cgi?id=50864
2969
2970         Turns out platform.platform() returns kernel version information
2971         which isn't helpful, and just plain confusing on Mac
2972         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
2973
2974         So I've updated PlatformInfo.display_name() to special case
2975         mac.  I also found a bad use of sys.platform in the process
2976         and fixed that.  (sys.platform always returns 'darwin' on mac).
2977
2978         * Scripts/webkitpy/common/system/platforminfo.py:
2979         * Scripts/webkitpy/common/system/user.py:
2980         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2981         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2982         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2983
2984 2010-12-10  Eric Seidel  <eric@webkit.org>
2985
2986         Unreviewed.
2987
2988         Exception seen while reporting flaky test with commit-queue.
2989         Just a missing include.
2990
2991         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2992         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2993
2994 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
2995
2996         Reviewed by Eric Seidel.
2997
2998         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
2999         https://bugs.webkit.org/show_bug.cgi?id=50796
3000
3001         Also updating the test code to use JSONResultsGeneratorBase and
3002         to improve test coverage for incremental cases.
3003
3004         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3005         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3006
3007 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
3008
3009         Reviewed by Darin Adler.
3010
3011         prepare-ChangeLog --help doesn't mention --bug shorthand -b
3012         https://bugs.webkit.org/show_bug.cgi?id=50835
3013
3014         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
3015
3016 2010-12-10  Eric Seidel  <eric@webkit.org>
3017
3018         Reviewed by Adam Barth.
3019
3020         Bugs created by the commit-queue should all block on a master bug
3021         https://bugs.webkit.org/show_bug.cgi?id=50857
3022
3023         This makes all bugs created by the commit-queue block on:
3024         https://bugs.webkit.org/show_bug.cgi?id=50856
3025
3026         In the process of testing this, I found that the existing
3027         create_bug code was wrong.  I also found that existing
3028         unit tests for create-rollout used invalid values
3029         for options.blocks.  I fixed both issues and tested.
3030
3031         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3032         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3033         * Scripts/webkitpy/tool/commands/commandtest.py:
3034         * Scripts/webkitpy/tool/commands/download_unittest.py:
3035         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3036         * Scripts/webkitpy/tool/mocktool.py:
3037         * Scripts/webkitpy/tool/steps/options.py:
3038
3039 2010-12-10  Eric Seidel  <eric@webkit.org>
3040
3041         Reviewed by Adam Barth.
3042
3043         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
3044         https://bugs.webkit.org/show_bug.cgi?id=50853
3045
3046         I also discovered when doing this that the code was posting
3047         the comment on the wrong bug, but that's fixed here too.
3048
3049         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3050         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3051         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3052         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3053         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3054         * Scripts/webkitpy/tool/mocktool.py:
3055
3056 2010-12-10  Anders Carlsson  <andersca@apple.com>
3057
3058         Reviewed by John Sullivan.
3059
3060         Make WKContextGetStatistics gather global statistics
3061         https://bugs.webkit.org/show_bug.cgi?id=50850
3062
3063         Remove the code that gets the statistics and fills in the per context
3064         statistics information for now.
3065
3066         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3067         (-[BrowserStatisticsWindowController refreshStatistics:]):
3068
3069 2010-12-10  Eric Seidel  <eric@webkit.org>
3070
3071         Unreviewed.
3072
3073         commit-queue should report port/platform information when commenting on flaky test bugs
3074         https://bugs.webkit.org/show_bug.cgi?id=50839
3075
3076         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
3077         which was only used by new run webkit tests (and clearly not unit tested).
3078
3079         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
3080         * Scripts/webkitpy/tool/main.py:
3081         * Scripts/webkitpy/tool/mocktool.py:
3082
3083 2010-12-10  Eric Seidel  <eric@webkit.org>
3084
3085         Reviewed by Tony Chang.
3086
3087         commit-queue should report port/platform information when commenting on flaky test bugs
3088         https://bugs.webkit.org/show_bug.cgi?id=50839
3089
3090         This was a suggestion from Tony Chang this morning.
3091         I added a platform.py class so I could easily mock the platform call,
3092         but that may not be the final solution for this mocking.
3093         We'll try it and see.
3094
3095         * Scripts/webkitpy/common/system/platform.py: Added.
3096         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3097         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3098         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3099         * Scripts/webkitpy/tool/main.py:
3100         * Scripts/webkitpy/tool/mocktool.py:
3101
3102 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
3103
3104         Reviewed by Joseph Pecoraro.
3105
3106         Bug 43455 - [Qt]: Implement Application Cache Quotas
3107         https://bugs.webkit.org/show_bug.cgi?id=43455
3108
3109         Introduce functions to allow new appcache layout test origin-quota.html
3110         to work correctly under Qt.
3111
3112         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3113         (WebCore::DumpRenderTree::DumpRenderTree):
3114         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
3115         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3116
3117         Introduce functions to allow new appcache layout test origin-quota.html
3118         to be successful under qt. Changes required because LayoutTestControllerQt
3119         does not inherit from LayoutController.
3120
3121         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3122         (LayoutTestController::reset):
3123         (LayoutTestController::clearAllApplicationCaches):
3124         (LayoutTestController::setApplicationCacheOriginQuota):
3125         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3126         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
3127         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
3128
3129 2010-12-10  Eric Seidel  <eric@webkit.org>
3130
3131         Reviewed by Adam Barth.
3132
3133         Move buildbot.py into its own module so we can split it out into one-file-per-class
3134         https://bugs.webkit.org/show_bug.cgi?id=50806
3135
3136         We're adding more buildbot logic these days, so it makes sense
3137         to give buildbot its own module.
3138
3139         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
3140         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
3141         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
3142         * Scripts/webkitpy/common/net/failuremap.py:
3143         * Scripts/webkitpy/common/net/regressionwindow.py:
3144         * Scripts/webkitpy/tool/commands/rebaseline.py:
3145
3146 2010-12-10  Tony Chang  <tony@chromium.org>
3147
3148         Reviewed by Eric Seidel.
3149
3150         Use FileSystem::remove when cleaning up http lock files
3151         https://bugs.webkit.org/show_bug.cgi?id=50830
3152
3153         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3154
3155 2010-12-10  Joone Hur  <joone@kldp.org>
3156
3157         Reviewed by Martin Robinson.
3158
3159         [GTK] DRT needs layoutTestController.setCacheModel
3160         https://bugs.webkit.org/show_bug.cgi?id=50705
3161         
3162         webkit_set_cache_mode() is called to set the cache model.
3163         
3164         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3165         (LayoutTestController::setCacheModel): Set the cache model. 
3166
3167 2010-12-10  Tony Chang  <tony@chromium.org>
3168
3169         Reviewed by Ojan Vafai.
3170
3171         [chromium] remove --use-drt and add --use-test-shell
3172         https://bugs.webkit.org/show_bug.cgi?id=50701
3173
3174         * Scripts/webkitpy/common/config/ports.py:
3175         * Scripts/webkitpy/common/config/ports_unittest.py:
3176         * Scripts/webkitpy/layout_tests/port/chromium.py:
3177         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3178         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3179         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3180         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3181         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3182         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3183         * Scripts/webkitpy/layout_tests/port/webkit.py:
3184         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3185         * Scripts/webkitpy/style/checkers/test_expectations.py:
3186         * Scripts/webkitpy/tool/commands/queries.py:
3187
3188 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
3189
3190         Reviewed by Steve Block.
3191
3192         [Chromium] Implement mocks for client-based geolocation
3193         https://bugs.webkit.org/show_bug.cgi?id=46895
3194
3195         * DumpRenderTree/chromium/LayoutTestController.cpp:
3196         (LayoutTestController::setGeolocationPermission):
3197         (LayoutTestController::setMockGeolocationPosition):
3198         (LayoutTestController::setMockGeolocationError):
3199         * DumpRenderTree/chromium/LayoutTestController.h:
3200         * DumpRenderTree/chromium/WebViewHost.cpp:
3201         (WebViewHost::geolocationClient):
3202         (WebViewHost::geolocationClientMock):
3203         (WebViewHost::reset):
3204         * DumpRenderTree/chromium/WebViewHost.h:
3205
3206 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
3207
3208         Reviewed by Martin Robinson.
3209
3210         [GTK] Add hasSpellingMarker support to the DRT
3211         https://bugs.webkit.org/show_bug.cgi?id=50739
3212
3213         Implemented the hasSpellingMarker to support spelling tests.
3214
3215         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3216         (LayoutTestController::hasSpellingMarker):
3217
3218 2010-12-10  Eric Seidel  <eric@webkit.org>
3219
3220         Reviewed by Ojan Vafai.
3221
3222         webkit-patch: not possible to use build-and-test with local commits
3223         https://bugs.webkit.org/show_bug.cgi?id=33378
3224
3225         Make --no-clean not even check if we have local commits.
3226         It's unclear to me why the code was originally written this way.
3227         I was unable to dig up a reason from svn history.
3228
3229         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3230         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3231
3232 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
3233
3234         Reviewed by Martin Robinson.
3235
3236         [GTK] AX: implement isEnabled in DRT
3237         https://bugs.webkit.org/show_bug.cgi?id=50814
3238
3239         Implement AccessibilityUIElement::isEnabled() for GTK.
3240
3241         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3242         (checkElementState): New function to refactor common code.
3243         (AccessibilityUIElement::isEnabled): Implement this by checking
3244         the current state of the AtkObject.
3245         (AccessibilityUIElement::isSelected): Use the new
3246         checkElementState function.
3247
3248 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3249
3250         Reviewed by Kenneth Rohde Christiansen.
3251
3252         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
3253         https://bugs.webkit.org/show_bug.cgi?id=50750
3254
3255         * MiniBrowser/qt/BrowserView.cpp:
3256         (BrowserView::BrowserView):
3257         * MiniBrowser/qt/BrowserView.h:
3258         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3259         (WTR::WebView::WebView):
3260
3261 2010-12-10  Joone Hur  <joone@kldp.org>
3262
3263         Reviewed by Xan Lopez.
3264
3265         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
3266         https://bugs.webkit.org/show_bug.cgi?id=50808
3267
3268         Unskipping the following test cases:
3269         userscripts/mixed-case-stylesheet.html
3270         userscripts/simple-stylesheet.html
3271         userscripts/user-style-all-frames.html
3272
3273         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3274         (LayoutTestController::addUserStyleSheet):
3275
3276 2010-12-10  Joone Hur  <joone@kldp.org>
3277
3278         Reviewed by Eric Seidel.
3279
3280         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
3281         https://bugs.webkit.org/show_bug.cgi?id=50783
3282
3283         This patch allows to unskip the following test cases:
3284         printing/page-rule-selection.html
3285         printing/page-format-data.html
3286
3287         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3288         (LayoutTestController::pageProperty): Added.
3289         (LayoutTestController::isPageBoxVisible): Ditto.
3290         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
3291         (LayoutTestController::addUserStyleSheet): Ditto.
3292
3293 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3294
3295         Reviewed by Kenneth Rohde Christiansen.
3296
3297         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
3298
3299         A menu allows to switch QNAM back to the same thread.
3300
3301         * QtTestBrowser/launcherwindow.cpp:
3302         (LauncherWindow::initializeView):
3303         (LauncherWindow::createChrome):
3304         (LauncherWindow::toggleThreadedQnam):
3305         * QtTestBrowser/launcherwindow.h:
3306         (WindowOptions::WindowOptions):
3307         * QtTestBrowser/webpage.cpp:
3308         (WebPage::WebPage):
3309         (WebPage::setQnamThreaded):
3310         * QtTestBrowser/webpage.h:
3311         (QnamThread::QnamThread):
3312         (QnamThread::~QnamThread):
3313         (QnamThread::networkAccessManager):
3314         (QnamThread::run):
3315
3316 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
3317
3318         Reviewed by Xan Lopez.
3319
3320         [Gtk] style="font-family: courier" makes text disappear
3321         https://bugs.webkit.org/show_bug.cgi?id=47452
3322
3323         Add a test that verifies that fonts without valid charmaps are
3324         never selected.
3325
3326         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3327         (initializeFonts): Initialize DRT with our font (derived from Ahem)
3328         that has no valid charmap.
3329         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
3330         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
3331         settings which may disable selection of bitmap fonts.
3332
3333 2010-12-10  Eric Seidel  <eric@webkit.org>
3334
3335         Unreviewed.
3336
3337         The commit-queue should file bugs about flaky tests it encounters
3338         https://bugs.webkit.org/show_bug.cgi?id=50803
3339
3340         create_bug_for_flaky_test was insufficiently tested, thus buggy.
3341         Now it's tested.
3342
3343         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3344         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3345
3346 2010-12-10  Eric Seidel  <eric@webkit.org>
3347
3348         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
3349
3350         The commit-queue should file bugs about flaky tests it encounters
3351         https://bugs.webkit.org/show_bug.cgi?id=50803
3352
3353         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3354
3355 2010-12-09  Eric Seidel  <eric@webkit.org>
3356
3357         Reviewed by Adam Barth.
3358
3359         The commit-queue should file bugs about flaky tests it encounters
3360         https://bugs.webkit.org/show_bug.cgi?id=50803
3361
3362         This change got a bit big.  I also added a new config.urls file
3363         because I needed to share the view_source_url code with committervalidator.py.
3364
3365         This adds a new class FlakyTestReporter which holds all the logic about
3366         reporting flaky tests to bugzilla.
3367
3368         Right now this code knows how to look up bugs for flaky tests.
3369         If it can't find a bug filed from the commit-queue, it will open a new
3370         one, ccing the relevant people and adding information about the failure.
3371
3372         It is not yet smart enough to chase down duplicate chains, or to include
3373         the actual failure diff.  But those can be added in later iterations.
3374
3375         * Scripts/webkitpy/common/checkout/api.py:
3376         * Scripts/webkitpy/common/checkout/changelog.py:
3377         * Scripts/webkitpy/common/checkout/commitinfo.py:
3378         * Scripts/webkitpy/common/config/committervalidator.py:
3379         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3380         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3381         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
3382         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3383         * Scripts/webkitpy/tool/bot/irc_command.py:
3384         * Scripts/webkitpy/tool/bot/sheriff.py:
3385         * Scripts/webkitpy/tool/commands/download.py:
3386         * Scripts/webkitpy/tool/commands/queues.py:
3387         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3388         * Scripts/webkitpy/tool/comments.py:
3389         * Scripts/webkitpy/tool/mocktool.py:
3390         * Scripts/webkitpy/tool/steps/commit.py:
3391
3392 2010-12-09  Eric Seidel  <eric@webkit.org>
3393
3394         Reviewed by Adam Barth.
3395
3396         Teach webkit-patch how to search bugzilla
3397         https://bugs.webkit.org/show_bug.cgi?id=50500
3398
3399         This is a step towards teaching webkitpy how to file
3400         new bugs for flaky tests and update them when new flakes occur.
3401
3402         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3403         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3404         * Scripts/webkitpy/tool/commands/__init__.py:
3405         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
3406
3407 2010-12-09  Adam Barth  <abarth@webkit.org>
3408
3409         Reviewed by Ojan Vafai.
3410
3411         commit-queue errors out due to local commits
3412         https://bugs.webkit.org/show_bug.cgi?id=50766
3413
3414         We seem to be tripping over having local commits in the working copy a
3415         lot recently.  I don't quite fully understand what the issue is, but
3416         this patch attempts to solve the problem by adding an explicit clean
3417         step before processing a patch.  Previously, we did the cleaning as
3418         part of the apply-attachment step, so this might not actually fix the
3419         problem.
3420
3421         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3422         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3423         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3424
3425 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
3426
3427         Reviewed by Ojan Vafai.
3428
3429         Make new-run-webkit-tests --lint-test-files log slightly better
3430         messages and return -1 if lint fails. Remove the
3431         'suppress_errors' keyword param to the TestExpectationsFile
3432         class, and clean up logging and exception raising for error
3433         handling. Also add more unit tests and clean up the unit test code a bit.
3434
3435         https://bugs.webkit.org/show_bug.cgi?id=50205
3436
3437         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3438         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3439         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
3440         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
3441         * Scripts/webkitpy/layout_tests/port/chromium.py:
3442         * Scripts/webkitpy/style/checkers/test_expectations.py:
3443         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3444
3445 2010-12-09  Tony Chang  <tony@chromium.org>
3446
3447         Unreviewed, fix for windows code.  We were catching the wrong
3448         exception in Windows.
3449
3450         * Scripts/webkitpy/common/system/filesystem.py:
3451
3452 2010-12-09  Antonio Gomes  <agomes@rim.com>
3453
3454         Reviewed by Martin Robinson.
3455
3456         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
3457         https://bugs.webkit.org/show_bug.cgi?id=48429
3458
3459         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
3460
3461         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3462         (LayoutTestController::workerThreadCount):
3463
3464 2010-12-06  Philippe Normand  <pnormand@igalia.com>
3465
3466         Reviewed by Martin Robinson.
3467
3468         [GTK] Support the Mozilla-style Fullscreen Javascript API
3469         https://bugs.webkit.org/show_bug.cgi?id=50572
3470
3471         Enable the Javascript Fullscreen support in the GtkLauncher. Also
3472         make DRT update the Chrome when the WebView settings have been
3473         reset to consistent values.
3474
3475         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3476         (resetDefaultsToConsistentValues):
3477         * GtkLauncher/main.c:
3478         (create_window):
3479         * Scripts/build-webkit:
3480
3481 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
3482
3483         Reviewed by Tor Arne Vestbø
3484
3485         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
3486         https://bugs.webkit.org/show_bug.cgi?id=50742
3487
3488         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
3489
3490         * Scripts/webkitdirs.pm:
3491
3492 2010-12-09  Joone Hur  <joone@kldp.org>
3493
3494          Reviewed by Martin Robinson.
3495
3496          [GTK] Support for viewport meta tag
3497          https://bugs.webkit.org/show_bug.cgi?id=45443
3498
3499          Add support for testing the viewport properties for WebKitGtk.
3500
3501          * DumpRenderTree/LayoutTestController.cpp:
3502          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
3503          (LayoutTestController::staticFunctions):
3504          * DumpRenderTree/LayoutTestController.h:
3505          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3506          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
3507          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3508          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3509          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3510          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3511          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3512          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3513          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3514          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3515
3516 2010-12-08  William Siegrist <wsiegrist@apple.com>
3517
3518         Reviewed by Eric Seidel.
3519
3520         Migrate buildbot.py from xmlrpc to json.
3521         https://bugs.webkit.org/show_bug.cgi?id=50647
3522
3523         * Scripts/webkitpy/common/net/buildbot.py:
3524
3525 2010-12-08  Tony Chang  <tony@chromium.org>
3526
3527         Reviewed by Eric Seidel.
3528
3529         make starting the websocket server more reliable on windows
3530         https://bugs.webkit.org/show_bug.cgi?id=50712
3531
3532         * Scripts/webkitpy/common/system/filesystem.py:
3533         (remove): Substitute method for os.remove to retry on error on Windows
3534         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3535         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
3536
3537 2010-12-08  Jessie Berlin  <jberlin@apple.com>
3538
3539         Reviewed by Adam Roben.
3540
3541         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
3542         https://bugs.webkit.org/show_bug.cgi?id=50656
3543
3544         * MiniBrowser/mac/BrowserWindowController.m:
3545         (-[BrowserWindowController awakeFromNib]):
3546         Indicate that exceededDatabaseQuota is not implemented.
3547         * MiniBrowser/win/BrowserView.cpp:
3548         (BrowserView::create):
3549         Ditto.
3550         * WebKitTestRunner/TestController.cpp:
3551         (WTR::createOtherPage):
3552         Ditto.
3553         (WTR::TestController::initialize):
3554         Ditto.
3555
3556 2010-12-08  Antonio Gomes  <agomes@rim.com>
3557
3558         Reviewed by Martin Robinson.
3559
3560         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
3561         https://bugs.webkit.org/show_bug.cgi?id=48429
3562
3563         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
3564         * webkit_gc_collect_javascript_objects;
3565         * webkit_gc_collect_javascript_objects_on_alternate_thread;
3566         * webkit_gc_count_javascript_objects;
3567         * webkit_web_frame_layout.
3568
3569         These were all only used by GTK+ DRT.
3570
3571         * DumpRenderTree/gtk/EventSender.cpp:
3572         (dispatchEvent):
3573         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3574         (GCController::collect):
3575         (GCController::collectOnAlternateThread):
3576         (GCController::getJSObjectCount):
3577
3578 2010-12-07  Tony Chang  <tony@chromium.org>
3579
3580         Reviewed by Ojan Vafai.
3581
3582         [chromium] force NRWT to use DRT
3583         https://bugs.webkit.org/show_bug.cgi?id=50359
3584
3585         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3586
3587 2010-12-06  Sam Weinig  <sam@webkit.org>
3588
3589         Reviewed by Anders Carlsson.
3590
3591         Generalize didChangeLocationWithinPageForFrame for all same document navigations
3592         https://bugs.webkit.org/show_bug.cgi?id=50584
3593
3594         * MiniBrowser/mac/BrowserWindowController.m:
3595         (didSameDocumentNavigationForFrame):
3596         (-[BrowserWindowController awakeFromNib]):
3597         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
3598         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3599         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3600         (TestWebKitAPI::TEST):
3601         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3602         (WTR::InjectedBundlePage::InjectedBundlePage):
3603         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
3604         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3605         * WebKitTestRunner/TestController.cpp:
3606         (WTR::TestController::initialize):
3607
3608 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
3609
3610         Reviewed by Ojan Vafai.
3611
3612         Make TestResultsServer return 404 for non-existing results files.
3613         https://bugs.webkit.org/show_bug.cgi?id=50581
3614
3615         * TestResultServer/handlers/testfilehandler.py:
3616
3617 2010-12-06  Tony Chang  <tony@chromium.org>
3618
3619         Reviewed by Ojan Vafai.
3620
3621         [chromium] fix an assert hit in DRT
3622         https://bugs.webkit.org/show_bug.cgi?id=50575
3623
3624         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
3625         semantics.
3626
3627         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
3628         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
3629         WTF::RefCountedBase::ref()).
3630
3631         * DumpRenderTree/chromium/TestWebWorker.h:
3632         (TestWebWorker::TestWebWorker):
3633
3634 2010-12-02  Ojan Vafai  <ojan@chromium.org>
3635
3636         Reviewed by Eric Seidel.
3637
3638         make webkit-patch command work when the git branch is not synced to the remote svn branch
3639         https://bugs.webkit.org/show_bug.cgi?id=50424
3640
3641         * Scripts/webkitpy/common/checkout/scm.py:
3642         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3643
3644 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
3645
3646         Reviewed by Andreas Kling.
3647
3648         [WINCE] Add build system
3649         https://bugs.webkit.org/show_bug.cgi?id=50522
3650
3651         * CMakeListsWinCE.txt: Added.
3652
3653 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
3654
3655         Reviewed by Tony Chang.
3656
3657         Allow the Chromium port to have Leopard-specific baselines
3658         https://bugs.webkit.org/show_bug.cgi?id=50506
3659
3660         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3661
3662 2010-12-03  Tony Chang  <tony@chromium.org>
3663
3664         Reviewed by Kent Tamura.
3665
3666         [chromium] fix 2 bugs with inspector tests in DRT
3667         https://bugs.webkit.org/show_bug.cgi?id=50492
3668
3669         Tasks can outlive the tasklist (even when canceled) so this was
3670         causing a crash when ~WebTask() ran.  Avoid this by unregistering
3671         when a task is canceled.
3672
3673         Also fix an assert when closing devtool windows by copying some
3674         logic from test_shell.
3675
3676         * DumpRenderTree/chromium/Task.cpp:
3677         (WebTask::~WebTask):
3678         (TaskList::revokeAll):
3679         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
3680             the tasklist (since the task can outlive the tasklist).
3681         * DumpRenderTree/chromium/TestShell.h:
3682         (TestShell::devToolsWebView):
3683         * DumpRenderTree/chromium/WebViewHost.cpp:
3684         (WebViewHost::~WebViewHost): Don't load about:blank when closing
3685             a window if the window has devtools loaded.  This avoids an
3686             ASSERT and matches test_shell.
3687
3688 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
3689
3690         Reviewed by Martin Robinson.
3691
3692         [GTK] Fix GtkLauncher.c style, use webkit style
3693         https://bugs.webkit.org/show_bug.cgi?id=50542
3694
3695         * GtkLauncher/main.c:
3696         (activateUriEntryCb):
3697         (updateTitle):
3698         (linkHoverCb):
3699         (notifyTitleCb):
3700         (notifyLoadStatusCb):
3701         (notifyProgressCb):
3702         (destroyCb):
3703         (goBackCb):
3704         (goForwardCb):
3705         (create_webViewCb):
3706         (webViewReadyCb):
3707         (closeWebViewCb):
3708         (createBrowser):
3709         (createStatusbar):
3710         (createToolbar):
3711         (createWindow):
3712         (main):
3713
3714 2010-12-04  Antonio Gomes  <agomes@rim.com>
3715
3716         Reviewed by Martin Robinson.
3717
3718         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
3719         https://bugs.webkit.org/show_bug.cgi?id=48429
3720
3721         Moved more private method declared with WEBKIT_API to
3722         DumpRenderTreeSupportGtk, since they were only being used by DRT.
3723
3724         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3725         (resetDefaultsToConsistentValues):
3726         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3727         (LayoutTestController::addOriginAccessWhitelistEntry):
3728         (LayoutTestController::execCommand):
3729         (LayoutTestController::isCommandEnabled):
3730
3731 2010-12-04  Antonio&n