2011-01-20 Maciej Stachowiak <mjs@apple.com>
[WebKit.git] / Tools / ChangeLog
1 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Eric Seidel.
4
5         nrwt: rewrite google_chrome_unittest to use mock filesystem.
6         
7         https://bugs.webkit.org/show_bug.cgi?id=52772
8         
9         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
10
11 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
12
13         Reviewed by Eric Siedel.
14
15         nrwt: clean up almost all remaining port references, remove
16         unnecessary import clauses. The only remaining references are
17         in places where a mock filesystem makes no sense or can't be
18         used, and in one routine in port/google_chrome_unittest that
19         I'll rewrite in a separate patch.
20
21         https://bugs.webkit.org/show_bug.cgi?id=52771
22
23         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
24         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
25         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
26         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
27         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
28         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
29         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
30         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
31         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
32         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
33         * Scripts/webkitpy/layout_tests/port/gtk.py:
34         * Scripts/webkitpy/layout_tests/port/mac.py:
35         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
36         * Scripts/webkitpy/layout_tests/port/qt.py:
37         * Scripts/webkitpy/layout_tests/port/webkit.py:
38         * Scripts/webkitpy/layout_tests/port/win.py:
39         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
40
41 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
42
43         Reviewed by Mihai Parparita.
44
45         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
46
47         https://bugs.webkit.org/show_bug.cgi?id=52762
48
49         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
50         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
51
52 2011-01-20  Tony Chang  <tony@chromium.org>
53
54         Reviewed by Ojan Vafai.
55
56         [chromium] fix the paths used for the rebaseline tool
57         https://bugs.webkit.org/show_bug.cgi?id=52857
58
59         Some of the bots were renamed so the path to grab the results zip
60         file has changed.
61
62         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
63
64 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
65
66         Reviewed by Tony Chang.
67
68         Fix bug introduced in r72688 / bug 52768 that broke the
69         generation of the output filename links in the results.html
70         output. Apparently none of the unit tests actually checked to
71         make sure the generated links were correct :(
72
73         https://bugs.webkit.org/show_bug.cgi?id=52854
74
75         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
76         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
77
78 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
79
80         Reviewed by Darin Adler.
81
82         https://bugs.webkit.org/show_bug.cgi?id=52849
83         Make window.print work with WebKit2
84
85         * MiniBrowser/mac/BrowserWindowController.m:
86         (-[BrowserWindowController awakeFromNib]):
87         * WebKitTestRunner/TestController.cpp:
88         (WTR::createOtherPage):
89         (WTR::TestController::initialize):
90         Added zeroes to WKPageUIClient structures to avoid build failures.
91
92 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
93
94         Reviewed by Eric Seidel.
95
96         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
97
98         https://bugs.webkit.org/show_bug.cgi?id=52756
99
100         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
101         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
102         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
103         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
104         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
105         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
106
107 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
108
109         Reviewed by Antonio Gomes.
110
111         QtTestBrowser should have a seperate menu for Settings
112         https://bugs.webkit.org/show_bug.cgi?id=52817
113         
114         Added a new menu item named "Settings"
115         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
116
117         * QtTestBrowser/launcherwindow.cpp:
118         (LauncherWindow::createChrome):
119
120 2011-01-20  Sam Weinig  <sam@webkit.org>
121
122         Reviewed by John Sullivan.
123
124         Update update-webkit-localizable-strings with new path to WebKit.
125
126         * Scripts/update-webkit-localizable-strings:
127
128 2011-01-20  James Robinson  <jamesr@chromium.org>
129
130         Reviewed by Darin Fisher.
131
132         Implement mozilla's requestAnimationFrame API
133         https://bugs.webkit.org/show_bug.cgi?id=51218
134
135         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
136
137         * DumpRenderTree/chromium/WebViewHost.cpp:
138         (invokeScheduleComposite):
139         (WebViewHost::scheduleAnimation):
140         (WebViewHost::paintInvalidatedRegion):
141         * DumpRenderTree/chromium/WebViewHost.h:
142
143 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
144
145         Reviewed by Adam Roben.
146
147         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
148         https://bugs.webkit.org/show_bug.cgi?id=42327
149
150         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
151         for methods that take their normal arguments but also a JSContextRef.
152         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
153         for evaluateScriptInIsolatedWorld.
154         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
155         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
156         this call is for an isolated world.
157         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
158         (WTR::worldMap): Helper to create a world map.
159         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
160         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
161         added LayoutTestController API.
162         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
163
164 2011-01-19  Adam Roben  <aroben@apple.com>
165
166         Convert paths in environment variables back to msys-style inside commit-log-editor
167
168         When this script gets run from inside git commit, msys-style paths in the environment will
169         have been turned into Windows-style paths with forward slashes. This screws up functions
170         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
171         the paths back to msys-style before doing anything else.
172
173         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
174         using msysgit's Perl and multiple ChangeLogs have been edited
175
176         Reviewed by David Kilzer.
177
178         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
179         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
180         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
181
182 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
183
184         [Win] Unreviewed build fix after r76248.
185
186         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
187
188 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
189
190         Reviewed by Csaba Osztrogonác.
191
192         Refactoring of the custom allocation framework
193         https://bugs.webkit.org/show_bug.cgi?id=49897
194
195         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
196         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
197         equivalent macro implementation at the necessary places.
198 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
199
200         Unreviewed. 
201
202         Adding myself to committers.py.
203
204         * Scripts/webkitpy/common/config/committers.py:
205
206 2011-01-20  Adam Barth  <abarth@webkit.org>
207
208         Reviewed by Tony Chang.
209
210         Chromium builders don't delete unversioned directories when DEPS change
211         https://bugs.webkit.org/show_bug.cgi?id=52745
212
213         If we pass this option to gclient sync, gclient will delete directories
214         that are no longer part of DEPS instead of leaving them around to
215         confuse us later.  Apparently, the downstream buildbots use this option
216         already.
217
218         * Scripts/update-webkit-chromium:
219
220 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
221
222         Unreviewed, build fix - I pulled this patch in to fix an issue
223         revealed by r76195 running on some new bots). Also fix a couple
224         of other issues revealed in testing.
225
226         nrwt: remove fs refs from layout_package/json*
227
228         https://bugs.webkit.org/show_bug.cgi?id=52754
229
230         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
231         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
232         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
233         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
234         * Scripts/webkitpy/layout_tests/port/base.py:
235
236 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
237
238         Unreviewed, build fix.
239
240         Fix a couple of minor bugs discovered while bringing up new bots
241         for testing.
242
243         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
244         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
245
246 2011-01-19  James Robinson  <jamesr@chromium.org>
247
248         Unreviewed, rolling out r76194.
249         http://trac.webkit.org/changeset/76194
250         https://bugs.webkit.org/show_bug.cgi?id=51218
251
252         Caused mysterious compile failure on the chromium win
253         build.webkit.org bots
254
255         * DumpRenderTree/chromium/WebViewHost.cpp:
256         (WebViewHost::paintInvalidatedRegion):
257         * DumpRenderTree/chromium/WebViewHost.h:
258
259 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
260
261         Reviewed by Mihai Parparita.
262
263         remove fs refs from test_runner, dump_render_tree_thread
264
265         https://bugs.webkit.org/show_bug.cgi?id=52753
266
267         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
268         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
269         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
270         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
271
272 2011-01-19  James Robinson  <jamesr@chromium.org>
273
274         Reviewed by Darin Fisher.
275
276         Implement mozilla's requestAnimationFrame API
277         https://bugs.webkit.org/show_bug.cgi?id=51218
278
279         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
280
281         * DumpRenderTree/chromium/WebViewHost.cpp:
282         (invokeScheduleComposite):
283         (WebViewHost::scheduleAnimation):
284         (WebViewHost::paintInvalidatedRegion):
285         * DumpRenderTree/chromium/WebViewHost.h:
286
287 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
288
289         Unreviewed, build fix.
290
291         Fix a few incorrect "self._filesystem" references introduced in
292         r76184.
293
294         * Scripts/webkitpy/layout_tests/port/chromium.py:
295         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
296
297 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
298
299         Reviewed by Mihai Parparita.
300
301         add a .sep property, abspath(), isabs(), mtime(), and
302         open_text_file_for_writing() to filesystem modules. Some of
303         these properties are not needed in this patch but will be needed
304         in subsequent patches (I'm doing this to avoid having to track
305         multiple versions of a single file).
306
307         Also, change most of the port/* modules to use the filesystem
308         objects instead of referencing the filesystem directly.
309
310         https://bugs.webkit.org/show_bug.cgi?id=52748
311
312         * Scripts/webkitpy/common/system/filesystem.py:
313         * Scripts/webkitpy/common/system/filesystem_mock.py:
314         * Scripts/webkitpy/layout_tests/port/__init__.py:
315         * Scripts/webkitpy/layout_tests/port/base.py:
316         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
317         * Scripts/webkitpy/layout_tests/port/chromium.py:
318         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
319         * Scripts/webkitpy/layout_tests/port/config.py:
320         * Scripts/webkitpy/layout_tests/port/test.py:
321         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
322
323 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
324
325         Reviewed by Anders Carlsson.
326
327         If resetting between tests times out, treat it as a WebProcess crash
328         https://bugs.webkit.org/show_bug.cgi?id=52757
329
330         * WebKitTestRunner/TestController.cpp:
331         (WTR::TestController::runTest):
332
333 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
334
335         Reviewed by Darin Adler.
336
337         https://bugs.webkit.org/show_bug.cgi?id=52739
338         Make it possible for a WebKit2 client to print headers and footers
339
340         Added dummy implementations for new printing UIClient calls.
341
342         * MiniBrowser/mac/BrowserWindowController.m:
343         (-[BrowserWindowController awakeFromNib]):
344         * WebKitTestRunner/TestController.cpp:
345         (WTR::createOtherPage):
346         (WTR::TestController::initialize):
347
348 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
349
350         Reviewed by Ojan Vafai.
351
352         Change webkitpy/layout_tests/port/test.py to use the
353         in-memory filesystem for cleaner unit testing. This
354         change allows us to kill a lot of code that was
355         specific to the test port, at the cost of being a
356         little less clear about how things would work if
357         you didn't have a filesystem.
358
359         https://bugs.webkit.org/show_bug.cgi?id=52605
360
361         * Scripts/webkitpy/layout_tests/port/test.py:
362
363 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
364
365         Unreviewed, build fix.
366
367         Fix test failure caused by committing attachment 79368 instead
368         of attachment 79461 on bug 52604.
369
370         * Scripts/webkitpy/common/system/filesystem_mock.py:
371
372 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
373
374         Reviewed by Mihai Parparita.
375
376         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
377         unit testing. os.walk() is too much of a hassle to implement on
378         top of the in-memory mock filesystem and adding the necessary
379         interface to files_under() gives clients a cleaner API anyway
380         (for this particular usage model).
381
382         https://bugs.webkit.org/show_bug.cgi?id=52691
383
384         * Scripts/webkitpy/common/system/filesystem.py:
385         * Scripts/webkitpy/common/system/filesystem_mock.py:
386         * Scripts/webkitpy/layout_tests/port/test_files.py:
387         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
388
389 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
390
391         Reviewed by Tony Chang.
392
393         Change more modules in the layout-tests code to use the
394         filesystem wrapper for cleaner unit testing.
395
396         This patch also adds the glob() wrapper to the filesystem
397         abstraction.
398         
399         https://bugs.webkit.org/show_bug.cgi?id=52604
400
401         * Scripts/webkitpy/layout_tests/port/test_files.py:
402         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
403         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
404         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
405         * Scripts/webkitpy/common/system/filesystem.py:
406         * Scripts/webkitpy/common/system/filesystem_mock.py:
407
408 2011-01-19  Levi Weintraub  <leviw@chromium.org>
409
410         Unreviewed.
411
412         Updating my email addresses and irc nick.
413
414         * Scripts/webkitpy/common/config/committers.py:
415
416 2011-01-19  Tony Chang  <tony@chromium.org>
417
418         Reviewed by Mihai Parparita.
419
420         [chromium] [linux] if check-sys-deps fails, output the failure reason
421         https://bugs.webkit.org/show_bug.cgi?id=52671
422
423         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
424             error handler functions.
425         * Scripts/webkitpy/layout_tests/port/chromium.py:
426             output the error text from --check-sys-deps
427         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
428
429 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
430
431         Reviewed by Andreas Kling.
432
433         [Qt] QtTestBrowser crashes when closing if Facebook is opened
434         https://bugs.webkit.org/show_bug.cgi?id=52554
435         
436         QtNetworkAccessManager is created in a thread and set as
437         member variable in QWebPage. When the thread is destroyed
438         the object is still used. So fix will set the object to
439         NULL once the thread is destroyed.
440
441         * QtTestBrowser/launcherwindow.cpp:
442         (LauncherWindow::~LauncherWindow):
443
444 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
445
446         Rubber stamped by Csaba Osztrogonac
447
448         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
449
450 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
451
452         Reviewed by Tony Chang.
453
454         new-run-webkit-tests: add a --build-directory command line argument
455
456         Official Google Chrome builds use a non-standard build directory
457         location. This patch adds a --build-directory argument that
458         allows that location to be specified on the command line. Only
459         Chromium-based builds will use this flag for now, but anyone can
460         in the future.
461
462         There are no unit tests for this since it's difficult to test
463         until mock filesystems are fully supported in the code. This was
464         tested by hand for now.
465
466         https://bugs.webkit.org/show_bug.cgi?id=52694
467
468         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
469         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
470         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
471         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
472
473 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
474
475         Not reviewed. Bot fix.
476
477         Remove an inadvertently committed debugging print.
478
479         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
480         (LayoutTestController::notifyDone):
481
482 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
483
484         Reviewed by Sam Weinig.
485
486         WebKitTestRunner should track loading more like DumpRenderTree
487         https://bugs.webkit.org/show_bug.cgi?id=52692
488
489         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
490         This makes some tests that call notifyDone multiple times pass.
491         
492         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
493         (WTR::InjectedBundle::InjectedBundle):
494         (WTR::InjectedBundle::done):
495         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
496         (WTR::InjectedBundle::topLoadingFrame):
497         (WTR::InjectedBundle::setTopLoadingFrame):
498         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
499         (WTR::InjectedBundlePage::InjectedBundlePage):
500         (WTR::InjectedBundlePage::stopLoading):
501         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
502         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
503         (WTR::InjectedBundlePage::didFinishLoadForFrame):
504         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
505         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
506         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
507         (WTR::LayoutTestController::notifyDone):
508         * WebKitTestRunner/TestController.cpp:
509         (WTR::TestController::didReceiveMessageFromInjectedBundle):
510
511 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
512
513         Reviewed by Kent Tamura.
514
515         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
516         https://bugs.webkit.org/show_bug.cgi?id=52678
517         
518         Update path now that WebKit is inside Source.
519
520         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
521
522 2011-01-18  Robert Hogan  <robert@webkit.org>
523
524         Reviewed by Simon Hausmann.
525
526         [Qt] http/tests/incremental/slow-utf8-text.pl fails
527         https://bugs.webkit.org/show_bug.cgi?id=44282
528
529         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
530         (WebCore::DumpRenderTree::dump):
531
532 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
533
534         Reviewed by Mihai Parparita.
535
536         Fix a small race condition that could cause the unit tests for
537         new-run-webkit-tests to fail in a multithreaded environment.
538         There was a small window in the code where one thread would
539         check to see if a thread had raised an exception, do something,
540         and then check to see if the thread was alive. If the other
541         thread raised an exception and exited in between these two
542         steps, the exception would be lost. Flipping the order of the
543         two checks fixes the race, since we will now always check for an
544         exception on the thread before exiting.
545
546         https://bugs.webkit.org/show_bug.cgi?id=51579
547
548         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
549
550 2011-01-18  Eric Seidel  <eric@webkit.org>
551
552         Reviewed by Adam Barth.
553
554         commit-queue dies when test archiving fails
555         https://bugs.webkit.org/show_bug.cgi?id=52617
556
557         I looked at the machine and it had 10 archives already
558         thus find_unused_name was returning None.  I've upped
559         the limit to 100 (per bug) and tested the case where
560         find_unused_name returns None (making archive return None).
561
562         * Scripts/webkitpy/common/system/workspace.py:
563         * Scripts/webkitpy/common/system/workspace_unittest.py:
564         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
565         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
566         * Scripts/webkitpy/tool/commands/queues.py:
567
568 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
569
570         Reviewed by Ojan Vafai.
571
572         Update rebaseline-chromium-webkit-tests unit tests to use a mock
573         filesystem. Also fix a couple of "with" statements missed by
574         r76050.
575
576         https://bugs.webkit.org/show_bug.cgi?id=52487
577
578         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
579
580 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
581
582         Reviewed by Martin Robinson.
583
584         [Gtk] Build fixes for gtk3 build
585         https://bugs.webkit.org/show_bug.cgi?id=52648
586
587         * DumpRenderTree/gtk/EventSender.cpp:
588         (beginDragWithFilesCallback):
589
590 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
591
592         Reviewed by Mihai Parparita.
593
594         Update rebaseline-chromium-webkit-tests to use filesystem objects
595         instead of direct references to os.path, shutil, tempfile, etc.
596
597         This patch doesn't change anything, but will allow subsequent
598         patches to change the unit tests to no longer use the real
599         filesystem.
600
601         This patch adds a bunch more methods to the filesystem object as
602         well.
603
604         https://bugs.webkit.org/show_bug.cgi?id=52482
605
606         * Scripts/webkitpy/common/system/filesystem.py:
607         * Scripts/webkitpy/common/system/filesystem_mock.py:
608         * Scripts/webkitpy/tool/commands/queues.py:
609         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
610         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
611
612 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
613
614         Reviewed by Mihai Parparita.
615
616         new-run-webkit-tests shouldn't crash when you try to run a
617         directory containing only skipped files.
618
619         https://bugs.webkit.org/show_bug.cgi?id=52478
620         
621         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
622         * Scripts/webkitpy/layout_tests/port/test.py:
623         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
624
625 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
626
627         Reviewed by Gustavo Noronha Silva.
628
629         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
630         https://bugs.webkit.org/show_bug.cgi?id=40833
631
632         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
633         GTK+ event sender.
634         (dragWithFilesDragDataGetCallback): Added.
635         (dragWithFilesDragEndCallback): Added.
636         (beginDragWithFilesCallback): Added.
637
638 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
639
640         Reviewed by Adam Barth.
641
642         ews: Add additional watcher to efl ews
643         https://bugs.webkit.org/show_bug.cgi?id=52613
644
645         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
646
647         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
648
649 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
650
651         Reviewed by Alexey Proskuryakov.
652
653         Fix some headers with missing or misspelled #ifndef guards
654         https://bugs.webkit.org/show_bug.cgi?id=52545
655
656         * DumpRenderTree/chromium/TestEventPrinter.h:
657         * DumpRenderTree/chromium/WebPreferences.h:
658
659 2011-01-17  Jessie Berlin  <jberlin@apple.com>
660
661         Reviewed by Anders Carlsson.
662
663         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
664         navigating back to an unreachable URL
665         https://bugs.webkit.org/show_bug.cgi?id=52388
666
667         Add a third parameter (unreachableURL) to queueLoadHTMLString.
668
669         * DumpRenderTree/LayoutTestController.cpp:
670         (queueLoadHTMLStringCallback):
671         (LayoutTestController::queueLoadHTMLString):
672         (LayoutTestController::queueLoadAlternateHTMLString):
673         * DumpRenderTree/LayoutTestController.h:
674
675         * DumpRenderTree/WorkQueueItem.h:
676         (LoadHTMLStringItem::LoadHTMLStringItem):
677
678         * DumpRenderTree/chromium/LayoutTestController.cpp:
679         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
680         (WorkItemLoadHTMLString::run):
681         (LayoutTestController::queueLoadHTMLString):
682
683         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
684         (LoadHTMLStringItem::invoke):
685         * DumpRenderTree/mac/WorkQueueItemMac.mm:
686         (LoadHTMLStringItem::invoke):
687         * DumpRenderTree/win/WorkQueueItemWin.cpp:
688         (LoadHTMLStringItem::invoke):
689
690 2011-01-17  Dan Bernstein  <mitz@apple.com>
691
692         Rubber-stamped by Mark Rowe.
693
694         Update xcodeproj svn:ignore to include xcuserdata.
695
696         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
697         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
698         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
699         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
700         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
701
702 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
703
704         Unreviewed fix after r75908.
705
706         Move WebKit into Source
707         https://bugs.webkit.org/show_bug.cgi?id=52530
708
709         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
710
711 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
712
713         Unreviewed.
714
715         Remove accidentally committed debug printing after r75908.
716
717         * Scripts/webkitdirs.pm:
718
719 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
720
721         Unreviewed.
722
723         Add myself to committers list
724         https://bugs.webkit.org/show_bug.cgi?id=52566
725
726         * Scripts/webkitpy/common/config/committers.py:
727
728 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
729
730         Reviewed by Jeremy Orlow.
731
732         GeolocationController should call stopUpdating on destruction
733         https://bugs.webkit.org/show_bug.cgi?id=52216
734
735         fast/dom/Geolocation/window-close-crash.html requires that a
736         Geolocation watch be started in a secondary window. Consequently,
737         we need to allow geolocation permission and provide a mock
738         geolocation position for the secondary window's
739         GeolocationClientMock.
740
741         * DumpRenderTree/chromium/LayoutTestController.cpp:
742         (LayoutTestController::setGeolocationPermission):
743         (LayoutTestController::setMockGeolocationPosition):
744         (LayoutTestController::setMockGeolocationError):
745         * DumpRenderTree/chromium/TestShell.h:
746         (TestShell::windowList):
747
748 2011-01-16  Adam Barth  <abarth@webkit.org>
749
750         Update more include paths to reflect WebKit move.
751
752         * DumpRenderTree/chromium/EventSender.cpp:
753         (EventSender::keyDown):
754         (EventSender::needsShiftModifier):
755         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
756         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
757
758 2011-01-16  Kent Tamura  <tkent@chromium.org>
759
760         Unreviewed, Chromium build fix.
761
762         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
763
764 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
765
766         Build fix for GTK+ after source directory movement.
767
768         * GNUmakefile.am: Correct include paths.
769
770 2011-01-16  Adam Barth  <abarth@webkit.org>
771
772         Teach svn-apply about WebKit move.
773
774         * Scripts/VCSUtils.pm:
775
776 2011-01-16  Adam Barth  <abarth@webkit.org>
777
778         Rubber-stamped by Eric Seidel.
779
780         Move WebKit into Source
781         https://bugs.webkit.org/show_bug.cgi?id=52530
782
783         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
784         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
785         * DumpRenderTree/qt/DumpRenderTreeQt.h:
786         * DumpRenderTree/qt/GCControllerQt.cpp:
787         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
788         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
789         * DumpRenderTree/qt/TextInputControllerQt.cpp:
790         * DumpRenderTree/wscript:
791         * QtTestBrowser/launcherwindow.h:
792         * Scripts/build-webkit:
793         * Scripts/webkitdirs.pm:
794
795 2011-01-15  Adam Barth  <abarth@webkit.org>
796
797         Teach svn-apply about WebKit2 move.
798
799         * Scripts/VCSUtils.pm:
800
801 2011-01-15  Adam Barth  <abarth@webkit.org>
802
803         Rubber-stamped by Eric Seidel.
804
805         Move WebKit2 into Source
806         https://bugs.webkit.org/show_bug.cgi?id=52438
807
808         * MiniBrowser/qt/MiniBrowser.pro:
809         * Scripts/build-webkit:
810         * Scripts/do-file-rename:
811         * Scripts/do-webcore-rename:
812         * Scripts/test-webkitpy:
813         * Scripts/webkitdirs.pm:
814         * Scripts/webkitpy/style/checker.py:
815         * WebKitTestRunner/DerivedSources.pro:
816         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
817         * WebKitTestRunner/qt/WebKitTestRunner.pro:
818
819 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
820
821         Reviewed by David Levin.
822
823         [chromium] remove obsolete createView method
824         https://bugs.webkit.org/show_bug.cgi?id=52437
825
826         * DumpRenderTree/chromium/WebViewHost.cpp:
827         (WebViewHost::createView):
828         * DumpRenderTree/chromium/WebViewHost.h:
829
830 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
831
832         Reviewed by Geoff Garen.
833
834         ShouldLoadResourceForFrame should use strings, not URLs.
835         https://bugs.webkit.org/show_bug.cgi?id=52476
836
837         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
838         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
839         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
840
841 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
842
843         Reviewed by David Levin.
844
845         Add Tony Gentilcore as a reviewer
846         https://bugs.webkit.org/show_bug.cgi?id=52480
847
848         * Scripts/webkitpy/common/config/committers.py:
849
850 2011-01-14  David Levin  <levin@chromium.org>
851
852         Reviewed by Eric Seidel.
853
854         check-webkit-style: _FunctionState should keep track of where the function name starts.
855         https://bugs.webkit.org/show_bug.cgi?id=52454
856
857         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
858         _FunctionState and logic for setting it correctly.
859         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
860
861 2011-01-14  Vincent Scheib  <scheib@chromium.org>
862
863         Reviewed by David Levin.
864
865         Add support to DumpRenderTree to use the GPU rather than software renderer
866         https://bugs.webkit.org/show_bug.cgi?id=52333
867
868         * DumpRenderTree/chromium/DumpRenderTree.cpp:
869         (main):
870         * Scripts/webkitpy/layout_tests/port/chromium.py:
871         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
872
873 2011-01-14  Tony Chang  <tony@chromium.org>
874
875         Reviewed by Kent Tamura.
876
877         [chromium] update fonts.conf to fix 6 linux tests in drt
878         https://bugs.webkit.org/show_bug.cgi?id=52411
879
880         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
881             chromium's src/webkit/tools/test_shell/resources/fonts.conf
882
883 2011-01-14  Eric Seidel  <eric@webkit.org>
884
885         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
886
887         Reviewed by Adam Barth.
888
889         Fix when running Tools/Scripts/check-webkit-style without arguments.
890         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
891
892         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
893         * Scripts/webkitpy/common/checkout/scm_unittest.py:
894
895 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
896
897         Reviewed by David Levin.
898
899         Store the tempdir object in a variable so it doesn't get deleted too early.
900         https://bugs.webkit.org/show_bug.cgi?id=51875
901
902         * Scripts/update-webkit-auxiliary-libs:
903         * Scripts/update-webkit-support-libs:
904
905 2011-01-14  Eric Seidel  <eric@webkit.org>
906
907         Unreviewed.  Make it work in python 2.5.
908
909         webkit-patch suggest-reviewers dies when ChangeLogs are missing
910         https://bugs.webkit.org/show_bug.cgi?id=49158
911
912         * Scripts/webkitpy/common/checkout/api_unittest.py:
913
914 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
915
916         Unreviewed, rolling out r75774.
917         http://trac.webkit.org/changeset/75774
918         https://bugs.webkit.org/show_bug.cgi?id=52431
919
920         gtk builds were broken (Requested by loislo2 on #webkit).
921
922         * Scripts/webkitpy/common/checkout/scm.py:
923
924 2011-01-14  David Levin  <levin@chromium.org>
925
926         Reviewed by Shinichiro Hamaji.
927
928         check-webkit-style: _FunctionState should detect pure functions.
929         https://bugs.webkit.org/show_bug.cgi?id=52428
930
931         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
932         is a pure virtual function.
933         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
934         virtual functions are correctly detected.
935
936 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
937
938         Reviewed by Yury Semikhatsky.
939
940         Just small fix for problem with check-webkit-style.
941         It just didn't work for this patch.
942         Old code can't concatenate a list of strings with None.
943
944         * Scripts/webkitpy/common/checkout/scm.py:
945
946 2011-01-13  David Levin  <levin@chromium.org>
947
948         Reviewed by Shinichiro Hamaji.
949
950         check-webkit-style: _FunctionState should use Position to know where items are.
951         https://bugs.webkit.org/show_bug.cgi?id=52424
952
953         * Scripts/webkitpy/style/checkers/cpp.py:
954         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
955         (detect_functions): Changed to pass Position's to _FunctionState.begin and
956         did some minor clean-up.
957         (*): Other changes are simply about converting to use the Position's in_FunctionState
958         instead of line numbers.
959         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
960         to verify the positions stored in _FunctionState.
961
962 2011-01-13  Eric Seidel  <eric@webkit.org>
963
964         Reviewed by David Levin.
965
966         webkit-patch suggest-reviewers dies when ChangeLogs are missing
967         https://bugs.webkit.org/show_bug.cgi?id=49158
968
969         This is not the most elegant, but it is a very safe fix to this bug.
970         One advantage of catching ScriptError like this instead of adding a
971         new added_or_modified_files or fixing all changed_files callers
972         to use a more specific change_files variant, is that we catch
973         all kinds of ScriptErrors which might cause our (non-essential)
974         suggest-reviewers code to fail out.  This should make passing
975         --suggest-reviewers to webkit-patch upload much more robust
976         and may even make it possible for us to make it default.
977
978         The root of the problem here is that SCM.changed_files includes
979         deleted ChangeLog paths (from moves, etc) which then when we ask
980         SVN/Git for the contents of the file at that revision, the command
981         errors out and Executive.run_command raises a ScriptError.
982
983         In the future we might fix this differently by making all current
984         callers of chagned_files use a more specific method for requesting
985         what types of changes they're interested in (adds, modifies, deletes, etc.)
986
987         * Scripts/webkitpy/common/checkout/api.py:
988         * Scripts/webkitpy/common/checkout/api_unittest.py:
989
990 2011-01-13  Dan Bernstein  <mitz@apple.com>
991
992         Reviewed by Alexey Proskuryakov.
993
994         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
995         https://bugs.webkit.org/show_bug.cgi?id=52419
996
997         Allow to further control the behavior of the willSendRequest delegate callback by making it
998         set a different URL in the new request.
999
1000         * DumpRenderTree/LayoutTestController.cpp:
1001         (addURLToRedirectCallback): Added.
1002         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1003         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1004         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1005         * DumpRenderTree/LayoutTestController.h:
1006         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1007         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1008         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1009         change the URL in the new request to the redirect destination.
1010
1011 2011-01-13  Eric Seidel  <eric@webkit.org>
1012
1013         Reviewed by Mihai Parparita.
1014
1015         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1016         https://bugs.webkit.org/show_bug.cgi?id=52416
1017
1018         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1019         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1020
1021         I also added FIXMEs about the changed_files returning deleted files problem
1022         which is causing the other most common exception for suggest-reviewers
1023         (and is probably breaking sheriff-bots blame detection).
1024
1025         * Scripts/webkitpy/common/checkout/api.py:
1026         * Scripts/webkitpy/common/checkout/api_unittest.py:
1027         * Scripts/webkitpy/common/checkout/scm.py:
1028
1029 2011-01-13  Eric Seidel  <eric@webkit.org>
1030
1031         Reviewed by Adam Barth.
1032
1033         results archives from commit-queue are too large to upload
1034         https://bugs.webkit.org/show_bug.cgi?id=52405
1035
1036         * Scripts/webkitpy/common/system/filesystem.py:
1037         * Scripts/webkitpy/common/system/filesystem_mock.py:
1038         * Scripts/webkitpy/tool/commands/queues.py:
1039
1040 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1041
1042         Reviewed by Martin Robinson.
1043
1044         [gtk] Zero-sized font does not yet work
1045         https://bugs.webkit.org/show_bug.cgi?id=49793
1046
1047         Set minimum-font-size to 0 for the DRT.
1048
1049         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1050         (resetDefaultsToConsistentValues):
1051
1052 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1053
1054         Reviewed by Darin Adler.
1055
1056         Make old-run-webkit-tests more robust on buildbots
1057         https://bugs.webkit.org/show_bug.cgi?id=52364
1058
1059         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1060
1061 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1062
1063         Reviewed by Darin Adler.
1064
1065         Make old-run-webkit-tests more robust on buildbots
1066         https://bugs.webkit.org/show_bug.cgi?id=52364
1067
1068         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1069
1070 2011-01-13  Tony Chang  <tony@chromium.org>
1071
1072         Reviewed by Kent Tamura.
1073
1074         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1075         https://bugs.webkit.org/show_bug.cgi?id=52332
1076
1077         Forked Info.plist is not longer needed.
1078
1079         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1080
1081 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1082
1083         Reviewed by Timothy Hatcher.
1084
1085         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1086         to be passed directly to WebInspector.UIString
1087
1088         https://bugs.webkit.org/show_bug.cgi?id=52365
1089
1090         * Scripts/check-inspector-strings:
1091
1092 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1093
1094         Unreviewed, rolling out r74881.
1095         http://trac.webkit.org/changeset/74881
1096         https://bugs.webkit.org/show_bug.cgi?id=52357
1097
1098         The EFL builder has been red for days (Requested by abarth on
1099         #webkit).
1100
1101         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1102         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1103
1104 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1105
1106         Reviewed by David Levin.
1107
1108         Add beforeunload support to WebKitTestRunner
1109         https://bugs.webkit.org/show_bug.cgi?id=52353
1110         
1111         This makes a number of currently failing tests pass.
1112
1113         * WebKitTestRunner/TestController.cpp:
1114         (WTR::runBeforeUnloadConfirmPanel):
1115         (WTR::createOtherPage):
1116         (WTR::TestController::initialize):
1117
1118 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1119
1120         Reviewed by Sam Weinig.
1121
1122         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1123         https://bugs.webkit.org/show_bug.cgi?id=52330
1124
1125         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1126         a web process crash.
1127         * WebKitTestRunner/TestController.cpp:
1128         (WTR::TestController::initialize): Set up a processDidCrash
1129         callback.
1130         (WTR::TestController::processDidCrash): Report that the Web process
1131         crashed.
1132         * WebKitTestRunner/TestController.h:
1133
1134 2011-01-12  David Levin  <levin@chromium.org>
1135
1136         Reviewed by Shinichiro Hamaji.
1137
1138         check-webkit-style -- close_expression function doesn't work correctly.
1139         https://bugs.webkit.org/show_bug.cgi?id=52272
1140
1141         * Scripts/webkitpy/style/checkers/cpp.py:
1142         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1143         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1144         generally useful (for upcoming code changes).
1145         (close_expression): Changed to use Position for input and output.
1146         Also, fixed many bugs such as only working correctly for parenthesis,
1147         not working correctly if given an offset in a line and not finding
1148         the real closing element if there were multiple closing elements in
1149         the same line.
1150         (detect_functions): Adjusted due to the change in arguments for
1151         close_expression.
1152         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1153         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1154         two positions are the same.
1155         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1156         (CppStyleTest.test_close_expression): Added tests to catch the issues
1157         that were fixed.
1158
1159 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1160
1161         Unreviewed, rolling out r75576.
1162         http://trac.webkit.org/changeset/75576
1163         https://bugs.webkit.org/show_bug.cgi?id=52304
1164
1165         broke rebaseline-chromium-webkit-test (Requested by thakis on
1166         #webkit).
1167
1168         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1169         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1170         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1171         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1172         * Scripts/webkitpy/layout_tests/port/base.py:
1173         * Scripts/webkitpy/layout_tests/port/chromium.py:
1174         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1175         * Scripts/webkitpy/layout_tests/port/test.py:
1176         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1177         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1178         * Scripts/webkitpy/style/checkers/test_expectations.py:
1179         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1180
1181 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1182
1183         Reviewed by Darin Adler.
1184
1185         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1186         https://bugs.webkit.org/show_bug.cgi?id=52307
1187
1188         * Scripts/old-run-webkit-tests:
1189
1190 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1191
1192         Reviewed by Martin Robinson.
1193
1194         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1195         https://bugs.webkit.org/show_bug.cgi?id=50867
1196
1197         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1198         TestNetscapePlugin.cpp 
1199
1200         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1201         * Scripts/webkitdirs.pm:
1202
1203 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1204
1205         Reviewed by Pavel Feldman.
1206
1207         Add check-inspector-strings script.
1208
1209         https://bugs.webkit.org/show_bug.cgi?id=52295
1210
1211         * Scripts/check-inspector-strings: Added.
1212
1213 2011-01-12  Adam Roben  <aroben@apple.com>
1214
1215         Advertise the .testnetscape file extension on Windows
1216
1217         Fixes <http://webkit.org/b/52298>
1218         plugins/no-mime-with-valid-extension.html fails on Windows
1219
1220         Reviewed by Dan Bernstein.
1221
1222         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1223         FileExtents field to map the .testnetscape file extension to the
1224         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1225
1226 2011-01-12  Adam Barth  <abarth@webkit.org>
1227
1228         Reviewed by Eric Seidel.
1229
1230         Make webkit-patch support subdirectories for SVN checkouts
1231         https://bugs.webkit.org/show_bug.cgi?id=52261
1232
1233         os.relpath does not exist on Python 2.5, so we need to call our version
1234         of the API.
1235
1236         * Scripts/webkitpy/common/checkout/scm.py:
1237
1238 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1239
1240         Reviewed by Eric Seidel.
1241
1242         Close additional pages opened during a test once the test completes.
1243         https://bugs.webkit.org/show_bug.cgi?id=52276
1244
1245         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1246         (WTR::InjectedBundle::done):
1247
1248 2011-01-11  David Levin  <levin@chromium.org>
1249
1250         Reviewed by Eric Seidel.
1251
1252         Errors should be separated from the command line in bot messages.
1253         https://bugs.webkit.org/show_bug.cgi?id=52275
1254
1255         * Scripts/webkitpy/common/system/executive.py:
1256         (ScriptError.message_with_output): Added a newline to separate the command
1257         line from the errors.
1258         * Scripts/webkitpy/common/system/executive_unittest.py:
1259         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1260         paths in message_with_output.
1261
1262 2011-01-11  Eric Seidel  <eric@webkit.org>
1263
1264         Unreviewed.
1265
1266         commit-queue should know how to upload archived results (for test flakes or general failures)
1267         https://bugs.webkit.org/show_bug.cgi?id=52048
1268
1269         The zips are mostly empty due to forgetting -r.
1270         Expected diffs were not being pulled from the archive due
1271         to the archive having longer paths than I realized.
1272
1273         * Scripts/webkitpy/common/system/workspace.py:
1274         * Scripts/webkitpy/common/system/workspace_unittest.py:
1275         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1276         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1277
1278 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1279
1280         Reviewed by Ojan Vafai.
1281
1282         The current modifier parsing code in test_expectations is
1283         fragile and hard-coded, so it's not easy to understand the logic
1284         or easily add new types of modifiers (like GPU vs. CPU testing
1285         for graphics tests, or 32-bit vs. 64-bit differences).
1286
1287         This is the first of two patches that will add in more generic
1288         support and then eliminate the GPU-specific test expectations
1289         files for Chromium.
1290
1291         This patch adds two standalone objects for handling modifiers. The
1292         rules for interpreting modifiers, precedence, and conflicts are
1293         given in the docstring to the ModifierMatcher class, which
1294         returns ModifierMatchResult objects.
1295         
1296         This patch also adds routines to the Port interface and a
1297         default set of values in the base object, in order to obtain the
1298         values needed on a given test run. These values are then passed
1299         to the expectation parser. This also allows us to clean up the
1300         logic used to lint all of the different configurations in a
1301         single test_expectations.txt file.
1302
1303         The next patch will merge in the separate GPU expectations file.
1304
1305         https://bugs.webkit.org/show_bug.cgi?id=51222
1306
1307         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1308         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1309         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1310         * Scripts/webkitpy/layout_tests/port/base.py:
1311         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1312         * Scripts/webkitpy/layout_tests/port/chromium.py:
1313         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1314         * Scripts/webkitpy/layout_tests/port/test.py:
1315         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1316         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1317
1318 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1319
1320         Reviewed by Adam Barth.
1321
1322         Make webkit-patch support subdirectories for SVN checkouts
1323         https://bugs.webkit.org/show_bug.cgi?id=52261
1324
1325         * Scripts/webkitpy/common/checkout/scm.py:
1326         * Scripts/webkitpy/style_references.py:
1327         * Scripts/webkitpy/tool/main.py:
1328         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1329
1330 2011-01-11  Eric Seidel  <eric@webkit.org>
1331
1332         Unreviewed.
1333
1334         commit-queue should know how to upload archived results (for test flakes or general failures)
1335         https://bugs.webkit.org/show_bug.cgi?id=52048
1336
1337         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1338         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1339
1340         * Scripts/webkitpy/common/system/workspace.py:
1341         * Scripts/webkitpy/common/system/workspace_unittest.py:
1342         * Scripts/webkitpy/tool/commands/queues.py:
1343
1344 2011-01-11  Sam Weinig  <sam@webkit.org>
1345
1346         Roll r75474 back in.
1347
1348 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1349
1350         Reviewed by Kenneth Rohde Christiansen.
1351
1352         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1353         https://bugs.webkit.org/show_bug.cgi?id=51204
1354
1355         * QtTestBrowser/webpage.h:
1356         (QtNAMThread::QtNAMThread):
1357         (QtNAMThread::networkAccessManager):
1358         (QtNAMThread::run):
1359
1360 2011-01-11  Peter Varga  <pvarga@webkit.org>
1361
1362         Unreviewed.
1363
1364         Add myself to committers' list.
1365
1366         * Scripts/webkitpy/common/config/committers.py:
1367
1368 2011-01-11  Eric Seidel  <eric@webkit.org>
1369
1370         Reviewed by Adam Barth.
1371
1372         commit-queue should know how to upload archived results (for test flakes or general failures)
1373         https://bugs.webkit.org/show_bug.cgi?id=52048
1374
1375         Now the queue will always upload results.  Either the entire zip, or just
1376         the diffs.txt in the case of text failures.
1377
1378         This should make understanding flakes much easier, and paves the way
1379         for having the EWS run layout tests (and upload failures).
1380
1381         In order to upload .zip files I had to teach bugzilla.py to autodetect
1382         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1383         for .patch files, I have it add one before calling guess_type.
1384
1385         We may find that always uploading the whole zip instead of just the -diffs.txt
1386         file is preferable, but for now I'm keeping the old behavior because it makes
1387         quickly understanding text failures easy.
1388
1389         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1390         * Scripts/webkitpy/common/system/workspace.py: Added.
1391         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1392         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1393         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1394         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1395         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1396         * Scripts/webkitpy/tool/commands/queues.py:
1397         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1398
1399 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1400
1401         Unreviewed, rolling out r75464.
1402         http://trac.webkit.org/changeset/75464
1403         https://bugs.webkit.org/show_bug.cgi?id=52193
1404
1405         Followup rollout for 75474 (Requested by Ossy on #webkit).
1406
1407         * MiniBrowser/mac/BrowserWindowController.m:
1408         (-[BrowserWindowController awakeFromNib]):
1409         * MiniBrowser/win/BrowserView.cpp:
1410         (BrowserView::create):
1411         * WebKitTestRunner/TestController.cpp:
1412         (WTR::createOtherPage):
1413         (WTR::TestController::initialize):
1414
1415 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1416
1417         Reviewed by Csaba Osztrogonác.
1418
1419         [Qt] Baseline qt_minimal configuration
1420         https://bugs.webkit.org/show_bug.cgi?id=51313
1421
1422         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1423         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1424         QT_NO_UNDOSTACK guard.
1425
1426         * QtTestBrowser/launcherwindow.cpp:
1427         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1428         guards.
1429         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1430         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1431         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1432         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1433
1434         * QtTestBrowser/launcherwindow.h:
1435         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1436         * QtTestBrowser/locationedit.h: Ditto.
1437
1438         * QtTestBrowser/mainwindow.cpp:
1439         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1440         QT_NO_UNDOSTACK guards.
1441         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1442         (MainWindow::changeLocation): Ditto.
1443         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1444         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1445
1446         * QtTestBrowser/webpage.cpp:
1447         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1448         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1449
1450         * QtTestBrowser/webview.cpp:
1451         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1452         (WebViewGraphicsBased::animatedYFlip): Ditto.
1453
1454 2011-01-10  Sam Weinig  <sam@webkit.org>
1455
1456         Fix build.
1457
1458         * MiniBrowser/mac/BrowserWindowController.m:
1459         (-[BrowserWindowController awakeFromNib]):
1460         * MiniBrowser/win/BrowserView.cpp:
1461         (BrowserView::create):
1462         * WebKitTestRunner/TestController.cpp:
1463         (WTR::createOtherPage):
1464         (WTR::TestController::initialize):
1465
1466 2011-01-10  Eric Seidel  <eric@webkit.org>
1467
1468         Reviewed by Ojan Vafai.
1469
1470         style-queue messages are way too long for big patches
1471         https://bugs.webkit.org/show_bug.cgi?id=52161
1472
1473         We definitely could build much fancier list-to-string-with-limit functions
1474         but this should be sufficient for our needs at the moment.
1475
1476         * Scripts/webkitpy/common/system/executive.py:
1477         * Scripts/webkitpy/common/system/executive_unittest.py:
1478
1479 2011-01-10  Tony Chang  <tony@chromium.org>
1480
1481         Unreviewed, rolling out r75398.
1482         http://trac.webkit.org/changeset/75398
1483         https://bugs.webkit.org/show_bug.cgi?id=52008
1484
1485         Some layout tests are crashing on Chromium Win.
1486
1487         * DumpRenderTree/chromium/WebViewHost.cpp:
1488         (WebViewHost::updatePaintRect):
1489         * DumpRenderTree/chromium/WebViewHost.h:
1490
1491 2011-01-10  Adam Roben  <aroben@apple.com>
1492
1493         Roll out r75392
1494
1495         It isn't needed now that r75289 has been rolled out.
1496
1497         * Scripts/run-javascriptcore-tests:
1498
1499 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1500
1501         Reviewed by Anders Carlsson.
1502
1503         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1504         https://bugs.webkit.org/show_bug.cgi?id=52160
1505
1506         * WebKitTestRunner/mac/TestControllerMac.mm:
1507         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1508         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1509         anyway.
1510
1511 2011-01-10  Tony Chang  <tony@chromium.org>
1512
1513         Reviewed by Mihai Parparita.
1514
1515         [chromium] fix for animated gif layout tests
1516         https://bugs.webkit.org/show_bug.cgi?id=52008
1517
1518         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1519             to trigger gif animations.
1520         (WebViewHostPaintTask::WebViewHostPaintTask):
1521         (WebViewHostPaintTask::runIfValid):
1522         (WebViewHost::updatePaintRect):
1523         * DumpRenderTree/chromium/WebViewHost.h:
1524         (WebViewHost::taskList):
1525
1526 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1527
1528         Reviewed by Xan Lopez.
1529
1530         [GTK] Fix gtk2 compilation for master
1531         https://bugs.webkit.org/show_bug.cgi?id=51885
1532
1533         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1534         (createBitmapContextFromWebView): Replaced the old
1535         gdk_drawable_get_size with gdk_pixmap_get_size.
1536
1537 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1538
1539         Reviewed by Laszlo Gombos.
1540
1541         [WINCE] Reenable NPAPI after r75203
1542         https://bugs.webkit.org/show_bug.cgi?id=52109
1543
1544         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1545         it with !isEfl(), because EFL port does not support NPAPI (yet).
1546
1547         * Scripts/build-webkit:
1548
1549 2011-01-10  Adam Roben  <aroben@apple.com>
1550
1551         Skip some asserting JS tests
1552
1553         See <http://webkit.org/b/52156>.
1554
1555         * Scripts/run-javascriptcore-tests:
1556
1557 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1558
1559         Reviewed by Xan Lopez.
1560
1561         [GTK] build-webkit disable Blob support via arguments passed to automake
1562         https://bugs.webkit.org/show_bug.cgi?id=52097
1563
1564         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1565         build-webkit.
1566
1567 2011-01-10  Adam Roben  <aroben@apple.com>
1568
1569         Use the same name and description for TestNetscapePlugin on Windows and
1570         Mac
1571
1572         Fixes <http://webkit.org/b/52151>
1573         fast/frames/iframe-reparenting-plugins.html fails on Windows
1574
1575         Reviewed by Steve Falkenburg.
1576
1577         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1578         the name and description from Mac's Info.plist.
1579
1580 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1581
1582         Reviewed by Laszlo Gombos.
1583
1584         [Qt][WK2] Guard gcc-specific syntax
1585
1586         Non-gcc based compliers choke on the "-include"
1587         syntax for preinclude, place guard around it.
1588
1589         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1590         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1591
1592 2011-01-10  Andreas Kling  <kling@webkit.org>
1593
1594         Reviewed by Simon Hausmann.
1595
1596         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1597         https://bugs.webkit.org/show_bug.cgi?id=52111
1598
1599         When getting a createNewPage() callback from QWKPage, create the
1600         new page with the same QWKContext as the page that is passed to
1601         the callback.
1602
1603         * MiniBrowser/qt/BrowserView.h:
1604         * MiniBrowser/qt/BrowserWindow.cpp:
1605         (newPageFunction):
1606         (BrowserWindow::BrowserWindow):
1607         * MiniBrowser/qt/BrowserWindow.h:
1608
1609 2011-01-10  Andreas Kling  <kling@webkit.org>
1610
1611         Reviewed by Kenneth Rohde Christiansen.
1612
1613         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1614
1615         BrowserView set its own useless createNewPage() callback on QWKPage.
1616         This was immediately overridden by BrowserWindow anyway, so remove
1617         the BrowserView one.
1618
1619         * MiniBrowser/qt/BrowserView.cpp:
1620         (BrowserView::BrowserView):
1621
1622 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1623
1624         Reviewed by Jeremy Orlow.
1625
1626         [Chromium] Remove non-client-based Geolocation code
1627         https://bugs.webkit.org/show_bug.cgi?id=50921
1628
1629         * DumpRenderTree/chromium/LayoutTestController.cpp:
1630         (LayoutTestController::setGeolocationPermission):
1631         (LayoutTestController::setMockGeolocationPosition):
1632         (LayoutTestController::setMockGeolocationError):
1633         * DumpRenderTree/chromium/WebViewHost.cpp:
1634         (WebViewHost::geolocationClientMock):
1635         (WebViewHost::reset):
1636         * DumpRenderTree/chromium/WebViewHost.h:
1637
1638 2011-01-10  Eric Seidel  <eric@webkit.org>
1639
1640         Reviewed by Adam Barth.
1641
1642         Commit bot tried to land r? cq+ patch
1643         https://bugs.webkit.org/show_bug.cgi?id=36638
1644
1645         It should now be possible to post a patch with r? and cq+ and the
1646         commit-queue will correctly wait for the r+ before attempting to land the patch.
1647         (This was a feature requested by several users.)
1648
1649         One caveat: We don't actually reject r-, cq+ patches from the queue
1650         (we just ignore them), but I think that's OK for now.
1651
1652         I also noticed that setting r- once a commit-queue node had grabbed
1653         a patch would not properly cancel the landing.  That's fixed and
1654         tested in this patch.
1655
1656         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1657         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1658         * Scripts/webkitpy/tool/bot/feeders.py:
1659         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1660
1661 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1662
1663         Reviewed by Kenneth Rohde Christiansen.
1664
1665         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1666         https://bugs.webkit.org/show_bug.cgi?id=51934
1667
1668         When accessing the network from the destructor of QWebPage, the network access manager
1669         was already deleted because the object WebPage was already destructed.
1670
1671         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1672         The object is now destructed in the destructor of QObject.
1673
1674         * QtTestBrowser/webpage.cpp:
1675         (WebPage::WebPage):
1676         (WebPage::setQnamThreaded):
1677         * QtTestBrowser/webpage.h:
1678         (QtNAMThread::QtNAMThread):
1679
1680 2011-01-08  Eric Seidel  <eric@webkit.org>
1681
1682         Reviewed by Ojan Vafai.
1683
1684         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1685         https://bugs.webkit.org/show_bug.cgi?id=52067
1686
1687         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1688         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1689
1690         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1691
1692 2011-01-08  Eric Seidel  <eric@webkit.org>
1693
1694         Reviewed by Mihai Parparita.
1695
1696         commit-queue hangs when the ChangeLog diff is bad
1697         https://bugs.webkit.org/show_bug.cgi?id=52072
1698
1699         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1700         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1701
1702 2011-01-08  Adam Barth  <abarth@webkit.org>
1703
1704         Teach svn-apply how to re-write WebCore to Source/WebCore.
1705
1706         * Scripts/VCSUtils.pm:
1707
1708 2011-01-07  Adam Barth  <abarth@webkit.org>
1709
1710         Rubber-stamped by Eric Seidel.
1711
1712         Move WebCore to Source
1713         https://bugs.webkit.org/show_bug.cgi?id=52050
1714
1715         Update the tools to understand WebCore's new location.
1716
1717         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1718         * DumpRenderTree/wscript:
1719         * GNUmakefile.am:
1720         * Scripts/build-webkit:
1721         * Scripts/do-file-rename:
1722         * Scripts/do-webcore-rename:
1723         * Scripts/generate-qt-inspector-resource:
1724         * Scripts/prepare-ChangeLog:
1725         * Scripts/run-bindings-tests:
1726         * Scripts/update-iexploder-cssproperties:
1727         * Scripts/update-sources-list.py:
1728         * Scripts/update-webkit-localizable-strings:
1729         * Scripts/webkitdirs.pm:
1730         * Scripts/webkitpy/common/config/build.py:
1731         * Scripts/webkitpy/common/config/build_unittest.py:
1732         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1733         * Scripts/webkitpy/style/checker.py:
1734         * Scripts/webkitpy/style/checker_unittest.py:
1735         * WebKitTestRunner/DerivedSources.pro:
1736         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1737         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1738         * wx/browser/wscript:
1739         * wx/build/settings.py:
1740
1741 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1742
1743         Reviewed by Sam Weinig.
1744
1745         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1746         https://bugs.webkit.org/show_bug.cgi?id=52086
1747
1748         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1749         (WTR::InjectedBundle::didReceiveMessage):
1750         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1751         (WTR::LayoutTestController::notifyDone):
1752         * WebKitTestRunner/TestController.cpp:
1753         (WTR::TestController::resetStateToConsistentValues):
1754         (WTR::TestController::run):
1755
1756 2011-01-07  James Robinson  <jamesr@chromium.org>
1757
1758         Revert "Implement mozilla's animationTime property"
1759         https://bugs.webkit.org/show_bug.cgi?id=51952
1760
1761         This approach isn't quite right.
1762
1763         * DumpRenderTree/chromium/WebViewHost.cpp:
1764         (WebViewHost::paintInvalidatedRegion):
1765
1766 2011-01-07  Adam Roben  <aroben@apple.com>
1767
1768         Build master fix
1769
1770         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1771         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1772
1773 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1774
1775         Reviewed by Csaba Osztrogonác.
1776
1777         run-qtwebkit-tests should be able to kill a testsuite.
1778
1779         Add new option in the script that can setup a timeout for a test.
1780         If the test execution takes more then specified time then the test
1781         would be terminated.
1782
1783         [Qt] run-qtwebkit-tests needs timeout
1784         https://bugs.webkit.org/show_bug.cgi?id=51894
1785
1786         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1787         * Scripts/run-qtwebkit-tests:
1788
1789 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1790
1791         Unreviewed fix after r75233.
1792
1793         Based on idea from Eric Seidel.
1794
1795         Add remote zip file handling to webkitpy.
1796         https://bugs.webkit.org/show_bug.cgi?id=50901
1797
1798         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1799
1800 2011-01-07  Shane Stephens  <shanestephens@google.com>
1801
1802         Reviewed by Eric Seidel.
1803
1804         svn-apply: should support git binary delta diffs
1805         https://bugs.webkit.org/show_bug.cgi?id=38864
1806
1807         * Scripts/VCSUtils.pm:
1808         * Scripts/svn-apply:
1809
1810 2011-01-06  Julie Parent  <jparent@chromium.org>
1811
1812         Reviewed by Eric Seidel.
1813
1814         Test Result Server not removing old results.
1815         https://bugs.webkit.org/show_bug.cgi?id=52012
1816
1817         * TestResultServer/model/jsonresults.py:
1818         Fix off-by-one: Truncate if >= num_runs, not just >.
1819         * TestResultServer/model/jsonresults_unittest.py:
1820         Add unit test to test that merging in a new result with the same value
1821         as the last result causes previous result to fall off.
1822
1823 2011-01-06  James Kozianski  <koz@chromium.org>
1824
1825         Reviewed by Mihai Parparita.
1826
1827         Add classes to provide a consistent interface to a set of files.
1828         https://bugs.webkit.org/show_bug.cgi?id=50901
1829
1830         These classes allow us to write code that is agnostic to whether a
1831         particular set of files resides in a local directory or in a zip file
1832         on a remote machine.
1833
1834         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1835         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1836         * Scripts/webkitpy/common/system/fileset.py: Added.
1837         * Scripts/webkitpy/common/system/filesystem.py:
1838         * Scripts/webkitpy/common/system/filesystem_mock.py:
1839         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1840         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1841
1842 2011-01-06  Eric Seidel  <eric@webkit.org>
1843
1844         Reviewed by Adam Barth.
1845
1846         NetworkTransaction should log the url it is retrying
1847         https://bugs.webkit.org/show_bug.cgi?id=52043
1848
1849         * Scripts/webkitpy/common/net/networktransaction.py:
1850         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1851
1852 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1853
1854         Windows build fix.
1855         Import os before using it.
1856
1857         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1858
1859 2011-01-06  Eric Seidel  <eric@webkit.org>
1860
1861         Reviewed by Adam Barth.
1862
1863         StyleQueue fails to report errors when patches have many files
1864         https://bugs.webkit.org/show_bug.cgi?id=52042
1865
1866         This is one of at least two errors preventing style error reporting at the moment.
1867         When we moved to passing the list of files to check explicitly,
1868         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1869         We could change the type of the QueueStatus.message type, or we could
1870         just teach statusserver.py how to clamp values (and warn when it does).
1871         I chose the latter path.
1872
1873         * Scripts/webkitpy/common/net/statusserver.py:
1874
1875 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1876
1877         Reviewed by Stephanie Lewis.
1878         
1879         Fix syntax error in script.
1880
1881         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1882         https://bugs.webkit.org/show_bug.cgi?id=51996
1883
1884         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1885
1886 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1887
1888         Unreviewed, fixing WinCE build after r75196.
1889
1890         WinCE port does not (yet) support NPAPI.
1891
1892         * Scripts/build-webkit:
1893
1894 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1895
1896         Reviewed by Darin Adler.
1897
1898         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1899         https://bugs.webkit.org/show_bug.cgi?id=52015
1900
1901         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1902         after the platform has been detected, otherwise the script will
1903         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1904         detection.
1905
1906 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1907
1908         Reviewed by Eric Seidel.
1909
1910         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1911         https://bugs.webkit.org/show_bug.cgi?id=51346
1912
1913         * Scripts/build-webkit:
1914
1915 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1916
1917         Reviewed by Adam Roben.
1918
1919         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1920         https://bugs.webkit.org/show_bug.cgi?id=51996
1921         
1922         After the configuration directory change, we were archiving the incorrect directory for
1923         build product, so we were running tests on the wrong binaries.
1924         
1925         This change archives the correct directory, and also unarchives it into a configuration-
1926         specific directory.
1927
1928         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1929         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1930
1931 2011-01-06  Eric Seidel  <eric@webkit.org>
1932
1933         Reviewed by Mihai Parparita.
1934
1935         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1936         https://bugs.webkit.org/show_bug.cgi?id=52002
1937
1938         See an example of this here:
1939         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1940
1941         It's due to the fact that we pass around TestFailure() instance
1942         objects and yet expect them to all compare to be the same.
1943
1944         This is bad.  We should either have shared instances of these values
1945         or we should just pass around the class names.  There are already hacks
1946         in place to make TestFailure objects pass equality tests, I just added
1947         a __hash__ implementation so they can be used in sets as expected.
1948
1949         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1950         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1951
1952 2011-01-06  Evan Martin  <evan@chromium.org>
1953
1954         Reviewed by Tony Chang.
1955
1956         [gdb] handle inaccessible memory and UChar*
1957         https://bugs.webkit.org/show_bug.cgi?id=52003
1958
1959         To pretty-print a UChar*, we just grope around in the memory
1960         looking for a terminating NUL.  We need to handle the exception
1961         that can occur when we poke into an invalid location.
1962
1963         Additionally, the logic for choosing which pretty-printer would
1964         early return before hitting the point where we'd use the UChar*
1965         printer.  (Did this ever work?  How did it regress?)
1966
1967         * gdb/webkit.py:
1968
1969 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1970
1971         Reviewed by Ada Chan.
1972
1973         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1974         https://bugs.webkit.org/show_bug.cgi?id=51969
1975         
1976         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1977
1978         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1979         (WTR::InjectedBundlePage::InjectedBundlePage):
1980         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1981         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1982
1983 2011-01-06  James Robinson  <jamesr@chromium.org>
1984
1985         Reviewed by Simon Fraser.
1986
1987         Implement mozilla's animationTime property
1988         https://bugs.webkit.org/show_bug.cgi?id=51952
1989
1990         Chromium DRT support for webkitAnimationTime.
1991
1992         * DumpRenderTree/chromium/WebViewHost.cpp:
1993         (WebViewHost::paintInvalidatedRegion):
1994
1995 2011-01-06  Julie Parent  <jparent@chromium.org>
1996
1997         Reviewed by Tony Chang.
1998
1999         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2000         https://bugs.webkit.org/show_bug.cgi?id=51217
2001
2002         * TestResultServer/model/jsonresults.py:
2003         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2004         Adds missing documentation.
2005         * TestResultServer/model/jsonresults_unittest.py:
2006         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2007         Update test_merge to take a number of builds to truncate at.
2008
2009 2011-01-06  Adam Barth  <abarth@webkit.org>
2010
2011         Reviewed by Eric Seidel.
2012
2013         The EWS should log outside of the working directory
2014         https://bugs.webkit.org/show_bug.cgi?id=51986
2015
2016         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2017         script, which will actually clean the working copy back to a pristine
2018         state instead of leaving untracked directories and ignored files.
2019
2020         * Scripts/webkitpy/tool/commands/queues.py:
2021         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2022
2023 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2024
2025         Windows build fix.
2026         Back out attempted change to built-product-archive.
2027
2028         * BuildSlaveSupport/built-product-archive:
2029
2030 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2031
2032         Windows build fix.
2033         Include configuration name when unpacking a build archive.
2034
2035         Needed, since we split Windows build results into configuration-specific directories
2036         under WebKitOutputDir.
2037
2038         * BuildSlaveSupport/built-product-archive:
2039
2040 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2041
2042         Reviewed by Darin Adler.
2043
2044         Debug and Release builds on Windows clobber each other
2045         https://bugs.webkit.org/show_bug.cgi?id=49185
2046
2047         Changes the structure of WebKitBuild build products directory so we
2048         completely separate each build configuration into independent directories.
2049         
2050         Although we previously had per-configuration directories for obj, this change adds
2051         per-configuration directories for bin, lib, obj, and include. Each configuration's
2052         build products are stored within a directory inside of WebKitBuild.
2053         
2054         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2055         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2056
2057         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2058         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2059         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2060         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2061         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2062         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2063         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2064         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2065         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2066         * FindSafari/FindSafari.vcproj:
2067         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2068         * MiniBrowser/MiniBrowserPostBuild.cmd:
2069         * MiniBrowser/MiniBrowserPreBuild.cmd:
2070         * Scripts/webkitdirs.pm:
2071         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2072         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2073         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2074         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2075         * TestWebKitAPI/win/copy-resources.cmd:
2076         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2077         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2078         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2079         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2080         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2081         * WebKitTestRunner/win/InjectedBundle.vcproj:
2082         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2083         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2084         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2085         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2086         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2087         * WinLauncher/WinLauncherCommon.vsprops:
2088         * WinLauncher/WinLauncherPostBuild.cmd:
2089         * WinLauncher/WinLauncherPreBuild.cmd:
2090
2091 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2092
2093         Reviewed by Ariya Hidayat.
2094
2095         [Qt] TestNetscapePlugin doesn't link on OS X
2096         https://bugs.webkit.org/show_bug.cgi?id=51948
2097
2098         Only add a dependency on libX11 on X11 systems
2099
2100         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2101
2102 2011-01-05  Jeff Miller  <jeffm@apple.com>
2103
2104         Reviewed by Adam Roben.
2105
2106         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2107         https://bugs.webkit.org/show_bug.cgi?id=51970
2108
2109         * Scripts/webkitpy/style/checker.py:
2110         Add -readability/naming for WebKit2 C API directories.
2111
2112 2011-01-05  Eric Seidel  <eric@webkit.org>
2113
2114         Unreviewed, just fixing one more log error from my previous python patch.
2115
2116         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2117         https://bugs.webkit.org/show_bug.cgi?id=51802
2118
2119         webkit-patch failure-reason was logging about parsing errors
2120         due to my misunderstanding of how BeautifulSoup.findAll worked.
2121
2122         Fixed, and added a unit test.
2123
2124         * Scripts/webkitpy/common/net/layouttestresults.py:
2125         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2126
2127 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2128
2129         Reviewed by Kenneth Rohde Christiansen.
2130
2131         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2132         https://bugs.webkit.org/show_bug.cgi?id=51951
2133
2134         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2135         to create new window from WebKit.
2136
2137         * MiniBrowser/qt/BrowserWindow.cpp:
2138         (newPageFunction):
2139         (BrowserWindow::BrowserWindow):
2140         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2141         (BrowserWindow::newWindow):
2142         (BrowserWindow::updateUserAgentList):
2143         (BrowserWindow::showUserAgentDialog):
2144         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2145         define the type of the backing store used for new windows.
2146         * MiniBrowser/qt/main.cpp:
2147         (main):
2148
2149 2011-01-05  Eric Seidel  <eric@webkit.org>
2150
2151         Reviewed by Ojan Vafai.
2152
2153         commit-queue should report failure type when reporting flaky tests
2154         https://bugs.webkit.org/show_bug.cgi?id=51900
2155
2156         This patch was a ridiculous amount of plumbing.  In the end I like
2157         the NRWT-style TestResult class even less.  But now we're passing
2158         a list of TestResult objects from the queue to the FlakyTestReporter.
2159         Thus the FlakyTestReporter can more easily report what type of failure
2160         occurred.
2161
2162         In the process, I found that I was not alone in finding TestResult
2163         cumbersome to use.  A bunch of code was trying to create a TestResult
2164         object with default values.  However since the constructor didn't make
2165         this easy, some places were getting it wrong (including the TestResult unit test)!
2166         I've fixed the TestResult constructor to have default values for non-essential
2167         arguments.
2168
2169         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2170         * Scripts/webkitpy/common/net/layouttestresults.py:
2171         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2172         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2173         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2174         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2175         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2176         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2177         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2178         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2179         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2180         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2181         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2182         * Scripts/webkitpy/tool/commands/queues.py:
2183         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2184
2185 2011-01-05  Eric Seidel  <eric@webkit.org>
2186
2187         Unreviewed.
2188
2189         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2190         https://bugs.webkit.org/show_bug.cgi?id=51802
2191
2192         Add another unit test to cover a previously missing import.
2193
2194         * Scripts/webkitpy/common/net/layouttestresults.py:
2195         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2196
2197 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2198
2199         Reviewed by David Levin.
2200
2201         Add mihaip@chromium.org as a reviewer
2202         https://bugs.webkit.org/show_bug.cgi?id=51966
2203         
2204         Add myself as a reviewer.
2205
2206         * Scripts/webkitpy/common/config/committers.py:
2207
2208 2011-01-05  James Simonsen  <simonjam@chromium.org>
2209
2210         Unreviewed. Adding myself to the list of committers.
2211
2212         * Scripts/webkitpy/common/config/committers.py:
2213
2214 2011-01-05  Eric Seidel  <eric@webkit.org>
2215
2216         Unreviewed.
2217
2218         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2219         https://bugs.webkit.org/show_bug.cgi?id=51802
2220
2221         Fix two exceptions seen on the bots after my original commit.
2222
2223         * Scripts/webkitpy/common/net/layouttestresults.py:
2224         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2225
2226 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2227
2228         Reviewed by Andreas Kling.
2229
2230         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2231         https://bugs.webkit.org/show_bug.cgi?id=51750
2232
2233         * QtTestBrowser/main.cpp:
2234         (LauncherApplication::handleUserOptions):
2235          Local storage settings can be enable form command line arguments for
2236          QtTestBrowser.
2237
2238 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2239
2240         Reviewed by Martin Robinson.
2241
2242         GTK: AX: DRT needs to use correct root object method.
2243         https://bugs.webkit.org/show_bug.cgi?id=51911
2244
2245         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2246         (AccessibilityController::rootElement):
2247
2248 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2249
2250         Rubber-stamped by Csaba Osztrogonác.
2251
2252         Based on idea from Péter Gál.
2253
2254         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2255
2256 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2257
2258         Reviewed by Adam Barth.
2259
2260         sheriff-bot should be able to do multi-revision rollouts
2261         https://bugs.webkit.org/show_bug.cgi?id=51176
2262
2263         * Scripts/webkitpy/tool/bot/irc_command.py:
2264         * Scripts/webkitpy/tool/bot/sheriff.py:
2265         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2266
2267 2011-01-05  Eric Seidel  <eric@webkit.org>
2268
2269         Reviewed by Adam Barth.
2270
2271         queues.webkit.org should have per-bot status pages
2272         https://bugs.webkit.org/show_bug.cgi?id=51906
2273
2274         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2275         statuses from a single queue.  Now that we have many bots servicing
2276         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2277         you care about scroll off the end of the 15-message limit on the main page.
2278
2279         Eventually we should probably rename /queue-status to /queue or /queues,
2280         but that's fodder for another patch.
2281
2282         * QueueStatusServer/handlers/queuestatus.py:
2283         * QueueStatusServer/index.yaml:
2284         * QueueStatusServer/main.py:
2285         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2286          - This probably should use a custom filter instead of hard-coding
2287            the URL scheme here, but I couldn't figure out how to easily
2288            create such a filter.  Most filters work with "strings" so we can't
2289            pass the status object.  We could add a method to the status
2290            object and call that, but that seemed a bit strange too.
2291         * QueueStatusServer/templates/queuestatus.html:
2292
2293 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2294
2295         Unreviewed. Adding myself to the list of committers.
2296
2297         * Scripts/webkitpy/common/config/committers.py:
2298
2299 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2300
2301         Reviewed by David Levin.
2302
2303         check-webkit-style treated some macros with parentheses after #elif as function calls
2304         https://bugs.webkit.org/show_bug.cgi?id=51695
2305
2306         Ingore function call space checking in any preprocessor directives
2307         (things starting with #). Change search() to match() because 
2308         preprocessor directives are supposed to be in the beginning of lines.
2309
2310         * Scripts/webkitpy/style/checkers/cpp.py:
2311         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2312
2313 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2314
2315         Reviewed by Tony Chang.
2316
2317         Change the --multi-load test option to --stress-opt
2318         https://bugs.webkit.org/show_bug.cgi?id=50751
2319
2320         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2321         (runTest):
2322         (main):
2323         * DumpRenderTree/chromium/TestShell.cpp:
2324         (TestShell::TestShell):
2325         * DumpRenderTree/chromium/TestShell.h:
2326         (TestShell::stressOpt):
2327         (TestShell::setStressOpt):
2328         (TestShell::stressDeopt):
2329         (TestShell::setStressDeopt):
2330         (TestShell::javaScriptFlags):
2331         (TestShell::setJavaScriptFlags):
2332         * Scripts/webkitpy/layout_tests/port/chromium.py:
2333         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2334
2335 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2336
2337         Reviewed by Sam Weinig.
2338
2339         WK2: Support Accessibility
2340         https://bugs.webkit.org/show_bug.cgi?id=51859
2341
2342         Use rootObject() method to get top of accessibility tree.
2343
2344         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2345         (AccessibilityController::focusedElement):
2346         (AccessibilityController::rootElement):
2347
2348 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2349
2350         Reviewed by Darin Adler.
2351
2352         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2353         https://bugs.webkit.org/show_bug.cgi?id=51846
2354
2355         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2356         back to GRefPtr.
2357
2358 2011-01-04  Zhe Su  <suzhe@chromium.org>
2359
2360         Reviewed by Kenneth Russell.
2361
2362         Fix insertText, setMarkedText and unmarkText methods of
2363         TextInputController to call corresponding methods of WebKit::WebView
2364         rather than WebKit::WebFrame. This change matches the behavior of
2365         chromium browser.
2366         insertText corresponds to WebView::confirmComposition(text)
2367         setMarkedText corresponds to WebView::setComposition(...)
2368         unmarkText corresponds to WebView::confirmComposition()
2369         https://bugs.webkit.org/show_bug.cgi?id=51693
2370
2371         * DumpRenderTree/chromium/TextInputController.cpp:
2372         (TextInputController::insertText):
2373         (TextInputController::setMarkedText):
2374         (TextInputController::unmarkText):
2375
2376 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2377
2378         Reviewed by Laszlo Gombos.
2379
2380         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2381
2382         On Symbian productDir points to the source directory. Removing all the
2383         empty files from the productDir directory corrupts the svn repository.
2384
2385         * Scripts/build-webkit:
2386
2387 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2388
2389         Reviewed by Adam Barth.
2390
2391         [Qt] Add SelectAll option to the context menu for the editor
2392         https://bugs.webkit.org/show_bug.cgi?id=50049
2393
2394         Set shortcut for the SelectAll action.
2395
2396         * QtTestBrowser/mainwindow.cpp:
2397         (MainWindow::buildUI):
2398
2399 2011-01-03  David Levin  <levin@chromium.org>
2400
2401         Reviewed by Eric Seidel.
2402
2403         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2404         https://bugs.webkit.org/show_bug.cgi?id=51842
2405
2406         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2407         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2408
2409 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2410
2411         Reviewed by David Kilzer.
2412
2413         [WINCE] Adds a build slave.
2414         https://bugs.webkit.org/show_bug.cgi?id=50523
2415
2416         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2417         entry for a release build of the WinCE port.
2418         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2419         flag to build the WinCE port.
2420
2421 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2422
2423         Reviewed by David Kilzer.
2424
2425         Add WinCE support to build-webkit
2426         https://bugs.webkit.org/show_bug.cgi?id=51642
2427
2428         * Scripts/build-webkit:
2429         * Scripts/webkitdirs.pm:
2430
2431 2011-01-03  Eric Seidel  <eric@webkit.org>
2432
2433         Reviewed by Adam Barth.
2434
2435         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2436         https://bugs.webkit.org/show_bug.cgi?id=51802
2437
2438         I'm not the biggest fan of the test_failures or test_results classes,
2439         but it's better to have one shared set of classes, than separate ones
2440         for new vs. old run-webkit-test result handling.
2441
2442         This moves the ORWT results class "LayoutTestResults" over to using
2443         TestResult and TestFailure classes, making it easy for us to
2444         make all our sheriff-bot and other webkitpy code NRWT ready.
2445
2446         This also makes it a trivial patch to generate results.json information
2447         from ORWT results.html files (for flaky test analysis, etc.) as well
2448         as making it a one-liner to report test failure types when the
2449         commit-queue sees flaky tests.
2450
2451         This patch tried not to add new functionality, but only to replace
2452         the guts of LayoutTestResults, while adding unit tests and hoping
2453         not to break anything.
2454
2455         I also moved callers which assumed User.prompt* were static/class methods
2456         to using them as instance methods (since we'll eventually want to make them such).
2457
2458         In the process of re-writing things, I broke the rebaseline command, so I wrote
2459         a unit test to catch my breakage were I do do so again in the future.
2460
2461         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2462         * Scripts/webkitpy/common/net/layouttestresults.py:
2463         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2464         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2465         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2466         * Scripts/webkitpy/tool/commands/queries.py:
2467         * Scripts/webkitpy/tool/commands/rebaseline.py:
2468         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2469         * Scripts/webkitpy/tool/mocktool.py:
2470
2471 2011-01-03  Adam Barth  <abarth@webkit.org>
2472
2473         Reviewed by Simon Fraser.
2474
2475         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2476         https://bugs.webkit.org/show_bug.cgi?id=51840
2477
2478         * Scripts/webkitpy/common/checkout/scm.py:
2479
2480 2011-01-03  Adam Barth  <abarth@webkit.org>
2481
2482         Reviewed by Simon Fraser.
2483
2484         webkit-patch should only hide update output if --quiet
2485         https://bugs.webkit.org/show_bug.cgi?id=51838
2486
2487         As requested by smfr.
2488
2489         * Scripts/webkitpy/tool/steps/update.py:
2490
2491 2011-01-03  Adam Barth  <abarth@webkit.org>
2492
2493         Reviewed by David Levin.
2494
2495         commit-queue shouldn't reject patches twice if two bots process the same patch
2496         https://bugs.webkit.org/show_bug.cgi?id=51805
2497
2498         Before raising an error, we first check whether the patch is still in
2499         the commit-queue.  This check is still racy, of course, but the time
2500         window is much smaller.
2501
2502         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2503
2504 2011-01-03  Sam Weinig  <sam@webkit.org>
2505
2506         Reviewed by Anders Carlsson.
2507
2508         Make run-api-tests less chatty.
2509         https://bugs.webkit.org/show_bug.cgi?id=51831
2510
2511         - Make script quiet by default and add --verbose option (replacing --quiet).
2512         - When not verbose, pipe stdout and stderr to devnull.
2513
2514         * Scripts/run-api-tests:
2515
2516 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2517
2518         Unreviewed. Adding myself to committers.py.
2519
2520         * Scripts/webkitpy/common/config/committers.py:
2521
2522 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2523
2524         Reviewed by Xan Lopez.
2525
2526         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2527         https://bugs.webkit.org/show_bug.cgi?id=51806
2528
2529         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2530         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2531         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2532         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2533         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2534         so make it 'WebKitBuild/Release/.libs'
2535
2536         * Scripts/webkitdirs.pm: 
2537
2538 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2539
2540         Reviewed by Adam Barth.
2541
2542         Make EFL a core builder
2543         https://bugs.webkit.org/show_bug.cgi?id=51804
2544
2545         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2546         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2547
2548 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2549
2550         [Qt] Unreviewed fix after r74855 and r74875.
2551
2552         * BuildSlaveSupport/built-product-archive:
2553          - Create directories explicitly.
2554          - Pass shell=True to subprocess.call().
2555
2556 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2557
2558         [Qt] Unreviewed fix after r74855.
2559
2560         Move JavaScriptCore to Source
2561         https://bugs.webkit.org/show_bug.cgi?id=51604
2562
2563         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2564
2565 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2566
2567         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2568
2569         Move JavaScriptCore to Source
2570         https://bugs.webkit.org/show_bug.cgi?id=51604
2571
2572         * Scripts/webkitdirs.pm:
2573
2574 2011-01-02  Robert Hogan  <robert@webkit.org>
2575
2576         Unreviewed, build fix.
2577
2578         [Qt] Fix DRT build after 74855
2579
2580         * DumpRenderTree/qt/DumpRenderTree.pro:
2581
2582 2011-01-01  Adam Barth  <abarth@webkit.org>
2583
2584         Remove the assumption from the Qt and Gtk builds that every project is
2585         in the root directory.
2586
2587         * Scripts/build-webkit:
2588
2589 2011-01-01  Adam Barth  <abarth@webkit.org>
2590
2591         Reviewed by Eric Seidel.
2592
2593         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2594         https://bugs.webkit.org/show_bug.cgi?id=51796
2595
2596         After this change, svn-apply will magically apply patches to
2597         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2598
2599         * Scripts/VCSUtils.pm:
2600
2601 2011-01-01  Adam Barth  <abarth@webkit.org>
2602
2603         Reviewed by Eric Seidel.
2604
2605         Move JavaScriptCore to Source
2606         https://bugs.webkit.org/show_bug.cgi?id=51604
2607
2608         Update references to JavaScriptCore to point to the new location.
2609
2610         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2611         * DumpRenderTree/qt/DumpRenderTree.pro:
2612         * DumpRenderTree/qt/ImageDiff.pro:
2613         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2614         * DumpRenderTree/wscript:
2615         * Scripts/build-jsc:
2616         * Scripts/build-webkit:
2617         * Scripts/do-file-rename:
2618         * Scripts/do-webcore-rename:
2619         * Scripts/run-javascriptcore-tests:
2620         * Scripts/update-javascriptcore-test-results:
2621         * Scripts/webkitdirs.pm:
2622         * Scripts/webkitpy/common/config/build_unittest.py:
2623         * Scripts/webkitpy/style/checker.py:
2624         * Scripts/webkitpy/style/checker_unittest.py:
2625         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2626         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2627         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2628         * wx/build/settings.py:
2629
2630 2011-01-01  Adam Barth  <abarth@webkit.org>
2631
2632         Reviewed by Eric Seidel.
2633
2634         Move Sources to Source
2635         https://bugs.webkit.org/show_bug.cgi?id=51794
2636
2637         Update scripts to point to the new location.
2638
2639         * Scripts/build-webkit:
2640         * Scripts/do-file-rename:
2641         * Scripts/do-webcore-rename:
2642         * Scripts/webkitpy/common/config/build.py:
2643         * Scripts/webkitpy/common/config/build_unittest.py:
2644
2645 2010-12-31  Kent Tamura  <tkent@chromium.org>
2646
2647         Reviewed by Eric Seidel.
2648
2649         [DRT/Chromium] Enable mock spell checker on non-OSX
2650         https://bugs.webkit.org/show_bug.cgi?id=51401
2651
2652         * DumpRenderTree/chromium/WebViewHost.cpp:
2653         (WebViewHost::spellCheck):
2654
2655 2010-12-31  Adam Barth  <abarth@webkit.org>
2656
2657         Reviewed by Ariya Hidayat.
2658
2659         Remove Tools/Scripts/wkstyle
2660         https://bugs.webkit.org/show_bug.cgi?id=51774
2661
2662         This script appears to not have been touched in a while and seems to
2663         have been replaced by check-webkit-style.
2664
2665         * Scripts/wkstyle: Removed.
2666
2667 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2668
2669         Unreviewed. Coding style fix.
2670
2671         * DumpRenderTree/chromium/TestShell.h:
2672
2673 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2674
2675         Reviewed by Pavel Feldman.
2676
2677         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2678
2679         It was a problem with Chromium DRT. DevToolsAgent object instance was
2680         attached not only to the inspected page but to the DevTools window too.
2681         As result all the inspector files were interpreted as a content of inspected page
2682         and were transfered to the DevTools scripts panel for debugging etc.
2683
2684         https://bugs.webkit.org/show_bug.cgi?id=51735
2685
2686         * DumpRenderTree/chromium/TestShell.cpp:
2687         (TestShell::TestShell):
2688         (TestShell::bindJSObjectsToWindow):
2689         (TestShell::createNewWindow):
2690         * DumpRenderTree/chromium/TestShell.h:
2691
2692 2010-12-31  Adam Barth  <abarth@webkit.org>
2693
2694         Rubber-stamped by Eric Seidel.
2695
2696         Move PageLoadTests to PerformanceTests/PageLoad
2697         https://bugs.webkit.org/show_bug.cgi?id=51771
2698
2699         Update references to PageLoadTests to point to the new location.
2700
2701         * Scripts/run-pageloadtest:
2702         * Scripts/webkitpy/common/config/build.py:
2703
2704 2010-12-31  Adam Barth  <abarth@webkit.org>
2705
2706         Rubber-stamped by Eric Seidel.
2707
2708         Move SunSpider into PerformanceTests
2709         https://bugs.webkit.org/show_bug.cgi?id=51769
2710
2711         Update these scripts to point to the new location.
2712
2713         * Scripts/run-sunspider:
2714         * Scripts/sunspider-compare-results:
2715
2716 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2717
2718         Reviewed by Kent Tamura.
2719
2720         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2721         https://bugs.webkit.org/show_bug.cgi?id=51728
2722         
2723         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2724         to render top-level scrollbars. This makes them match the Mac port's
2725         use of an NSScrollView, which means that we'll be able to share more
2726         pixel baselines.
2727         
2728         The new rendering code will not be activated until the 
2729         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2730         ScrollbarThemeChromiumMac.
2731
2732         * DumpRenderTree/DumpRenderTree.gypi:
2733         * DumpRenderTree/chromium/TestShellMac.mm:
2734         (platformInit):
2735         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2736         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2737         (+[FakeActiveWindow alwaysActiveWindow]):
2738         (+[FakeActiveWindow alwaysInactiveWindow]):
2739         (-[FakeActiveWindow initWithActiveControls:]):
2740         (-[FakeActiveWindow _hasActiveControls]):
2741         (WebThemeEngineDRTMac::paintScrollbarThumb):
2742         (stateToHIEnableState):
2743         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2744         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2745
2746 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2747
2748         Reviewed by David Kilzer.
2749
2750         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2751         used
2752         https://bugs.webkit.org/show_bug.cgi?id=51672
2753
2754         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2755         with USE_SYSTEM_MALLOC=1
2756         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2757         with USE_SYSTEM_MALLOC=1
2758
2759 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2760
2761         Reviewed by David Kilzer.
2762
2763         [Qt] [Symbian] Fix build-webkit script for Symbian
2764         https://bugs.webkit.org/show_bug.cgi?id=51509
2765
2766         Set the OUTPUT_DIR for Symbian to be the same as the source
2767         directory.
2768
2769         * Scripts/webkitdirs.pm:
2770
2771 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2772
2773         Reviewed by Darin Adler.
2774
2775         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2776         https://bugs.webkit.org/show_bug.cgi?id=51758
2777
2778         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2779
2780         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2781         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2782
2783 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2784
2785         Unreviewed WinCE buildfix.
2786
2787         * WinCELauncher/main.cpp: Add missing include.
2788
2789 2010-12-29  Daniel Bates  <dbates@rim.com>
2790
2791         Reviewed by Darin Adler.
2792
2793         svn-apply updates date of wrong change log entry for a change log diff that
2794         contains two consecutive entries with the same author and date
2795         https://bugs.webkit.org/show_bug.cgi?id=46061
2796
2797         Fixes an issue where the date of the wrong change log entry may be modified.
2798         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2799         in a ChangeLog file to the top of the file.
2800
2801         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2802         diff when it detects that the diff inserts a change log entry earlier in a
2803         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2804         change. With the advent of the commit-queue this functionality of bailing out
2805         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2806         Instead, we should always move the change log entry to the top of the ChangeLog file.
2807
2808         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2809         the date line of the correct change log entry in a ChangeLog diff.
2810
2811         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2812
2813         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2814           Updated the following unit tests now that we move entries inserted earlier to the top:
2815           - "fixChangeLogPatch: New entry inserted in middle."
2816             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2817
2818           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2819             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2820
2821         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2822
2823 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2824
2825         Reviewed by Eric Seidel.
2826
2827         [Qt] Fixed compatibility with gold linker on X11 platforms
2828         https://bugs.webkit.org/show_bug.cgi?id=51700
2829
2830         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2831         Linked TestNetscapePlugin with libX11 on Unix platforms
2832
2833 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2834
2835         Reviewed by Darin Adler.
2836
2837         Circular dependency in webkitpy.common.checkout.changelog module
2838         https://bugs.webkit.org/show_bug.cgi?id=50475
2839
2840         Remove automatic import of api.Checkout module when any checkout/
2841         submodule is imported (e.g.: when checkout.scm.Git is imported).
2842
2843         * Scripts/webkitpy/common/checkout/__init__.py:
2844
2845 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2846
2847         Reviewed by Ojan Vafai.
2848
2849         prepare-ChangeLog should support the -g option for specifying the git-commit
2850         https://bugs.webkit.org/show_bug.cgi?id=51708
2851
2852         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2853         webkit-patch, though the exact meaning of the two options remain different.
2854
2855         * Scripts/prepare-ChangeLog: Add -g.
2856
2857 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2858
2859         Reviewed by Simon Hausmann.
2860
2861         [Qt] Fix compilation with Qt in namespace
2862         https://bugs.webkit.org/show_bug.cgi?id=51701
2863
2864         * QtTestBrowser/webview.h:
2865
2866 2010-12-28  Daniel Bates  <dbates@rim.com>
2867
2868         Reviewed by Sam Weinig.
2869
2870         Substitute // MARK: for compiler-specific #pragma mark
2871         https://bugs.webkit.org/show_bug.cgi?id=51657
2872
2873         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2874         substituting  "// MARK:" for "#pragma mark", which provides
2875         analogous code-bookmarking functionality under Xcode.
2876
2877         Also, for consistency, we should substitute "// MARK:" for compiler-
2878         specific "#pragma mark" in the source files for the Mac port.
2879
2880         * DumpRenderTree/AccessibilityTextMarker.cpp:
2881         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2882         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2883         * DumpRenderTree/mac/ObjCController.m:
2884         * MiniBrowser/mac/AppDelegate.m:
2885         * MiniBrowser/mac/BrowserWindowController.m:
2886
2887 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2888
2889         Reviewed by Eric Seidel.
2890
2891         Add --no-build option to run-sunspider
2892         https://bugs.webkit.org/show_bug.cgi?id=51658
2893
2894         * Scripts/run-sunspider: add --no-build flag to skip building
2895         phase.
2896
2897 2010-12-27  Daniel Bates  <dbates@rim.com>
2898
2899         Rubber-stamped by Martin Robinson.
2900
2901         Append the directory Tools/DumpRenderTree to the list of directories that
2902         do-webcore-rename should search so that it can rename DRT files and
2903         source code.
2904
2905         * Scripts/do-webcore-rename:
2906
2907 2010-12-27  Eric Seidel  <eric@webkit.org>
2908
2909         Reviewed by Adam Barth.
2910
2911         build-webkit should detect missing Java SDK and explain how to install it
2912         https://bugs.webkit.org/show_bug.cgi?id=51651
2913
2914         * Scripts/build-webkit:
2915
2916 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2917
2918         Reviewed by Daniel Bates.
2919
2920         [GTK] Add support for build-jsc
2921         https://bugs.webkit.org/show_bug.cgi?id=51625
2922
2923         Add GTK+ support to build-jsc now that building the jsc executable as
2924         a standalone target is easy.
2925
2926         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2927         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2928         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2929         and pass it along to buildAutotoolsProject.
2930
2931 2010-12-27  David Levin  <levin@chromium.org>
2932
2933         Reviewed by Eric Seidel.
2934
2935         check-webkit-style check for meaningless variable names in function declarations.
2936         https://bugs.webkit.org/show_bug.cgi?id=51523
2937
2938         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2939         from the new check and whitespace/parens because the syntax is unusual and
2940         produced a fair number of positives for these checks.
2941         * Scripts/webkitpy/style/checkers/cpp.py:
2942         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2943         and parameter names when determining if the parameter name is useless.
2944         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2945         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2946         format.
2947         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2948         text or an acronym of it.
2949         (check_function_definition): Checks function definitions for meaningless variable names.
2950         (process_line): Added call to check_function_definition.
2951         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2952         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2953         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2954         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2955         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2956         because when only checking a snippet, there are a lot of bogus functions.
2957         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2958         that I put there previously and just noticed.
2959         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2960         check_function_definition and process_line.
2961
2962 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2963
2964         Reviewed by Martin Robinson.
2965
2966         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2967         https://bugs.webkit.org/show_bug.cgi?id=51591
2968
2969         Flash plugin uses gtk2 that is incompatible with gtk3 making
2970         webkit crash when it's built with gtk3.
2971
2972         * GtkLauncher/main.c:
2973         (main):
2974
2975 2010-12-25  Adam Barth  <abarth@webkit.org>
2976
2977         Reviewed by Eric Seidel.
2978
2979         Move ANGLE to Sources/ThirdParty
2980         https://bugs.webkit.org/show_bug.cgi?id=51605
2981
2982         * Scripts/build-webkit:
2983           - Point to the new ANGLE location.
2984
2985 2010-12-26  David Levin  <levin@chromium.org>
2986
2987         Reviewed by Eric Seidel.
2988
2989         check-webkit-style should be able to parse function declaration parameters.
2990         https://bugs.webkit.org/show_bug.cgi?id=51451
2991
2992         * Scripts/webkitpy/style/checkers/cpp.py:
2993         (Position.__init__): Holds simple position information (row, column).
2994         (Parameter.__init__): Holds information about a parameter.
2995         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2996         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2997         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2998         (find_parameter_name_index): Finds where the parameter name is.
2999         (parameter_list): Generates the list of parameters for a function.
3000         (_FunctionState.begin): Added information to allow determining the parameters
3001         on demand.
3002         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3003         (detect_functions): Improve function detection for operator functions and
3004         determine where the parameters end and pass that to _FunctionState.begin.
3005         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3006         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3007         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3008         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3009         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3010         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3011         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3012         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3013         the parameters found.
3014         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3015         detection test to verify that we catch the operator functions.
3016         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3017         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3018         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3019         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3020         test_function_length_check_definition_severity1_for_test.
3021
3022 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3023
3024         Unreviewed WinCE buildfix after r74334.
3025
3026         * CMakeListsWinCE.txt:
3027
3028 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3029
3030         Unreviewed, rolling out r74632.
3031         http://trac.webkit.org/changeset/74632
3032         https://bugs.webkit.org/show_bug.cgi?id=51600
3033
3034         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3035         on #webkit).
3036
3037         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3038         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3039
3040 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3041
3042         Reviewed by Kenneth Rohde Christiansen.
3043
3044         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3045         https://bugs.webkit.org/show_bug.cgi?id=43528
3046
3047         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3048         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3049         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3050         called.
3051
3052         * EWebLauncher/main.c:
3053         (browserCreate):
3054
3055 2010-12-24  Eric Seidel  <eric@webkit.org>
3056
3057         Reviewed by Adam Barth.
3058
3059         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3060         https://bugs.webkit.org/show_bug.cgi?id=28291
3061
3062         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3063         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3064         to strings with find in the diff.
3065         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3066
3067         * Scripts/webkitpy/common/checkout/api.py:
3068         * Scripts/webkitpy/common/checkout/diff_parser.py:
3069         * Scripts/webkitpy/tool/steps/abstractstep.py:
3070         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3071         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3072         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3073         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3074
3075 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3076
3077         Reviewed by Kenneth Russell.
3078
3079         Modify new-run-webkit-tests to shut up and exit when all the threads
3080         are wedged so that test runs complete faster and we don't end up
3081         w/ enormous log files.
3082
3083         https://bugs.webkit.org/show_bug.cgi?id=51572
3084
3085         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3086         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3087
3088 2010-12-24  Eric Seidel  <eric@webkit.org>
3089
3090         Reviewed by David Levin.
3091
3092         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3093         https://bugs.webkit.org/show_bug.cgi?id=51549
3094
3095         I've had multiple people ask me about the commit-queue's behavior
3096         regarding reporting flaky tests.  I figured it would be best to just
3097         have the queue explain itself in the bugs it files.
3098
3099         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3100         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3101
3102 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3103
3104         Reviewed by Eric Seidel.
3105
3106         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3107         https://bugs.webkit.org/show_bug.cgi?id=51467
3108
3109         * Scripts/webkitpy/style/checker.py:
3110         * Scripts/webkitpy/style/checker_unittest.py:
3111
3112 2010-12-23  Adam Barth  <abarth@webkit.org>
3113
3114         Rubber-stamped by Eric Seidel.
3115
3116         Move JavaScriptGlue into Sources
3117         https://bugs.webkit.org/show_bug.cgi?id=51583
3118
3119         These tools refer to JavaScriptGlue and need to be updated to its new
3120         location.
3121
3122         * Scripts/build-webkit:
3123         * Scripts/do-file-rename:
3124         * Scripts/do-webcore-rename:
3125         * Scripts/webkitpy/common/config/build.py:
3126         * Scripts/webkitpy/common/config/build_unittest.py:
3127
3128 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3129
3130         Reviewed by Eric Seidel.
3131
3132         Bug 51539 - update iexploder scripts to point to new location
3133
3134         * Scripts/run-iexploder-tests:
3135         * Scripts/update-iexploder-cssproperties:
3136
3137 2010-12-23  Evan Martin  <evan@chromium.org>
3138
3139         Reviewed by Ryosuke Niwa.
3140
3141         [chromium] LayoutTestController warning in float->int conversion
3142         https://bugs.webkit.org/show_bug.cgi?id=51553
3143
3144         Rather than reading an int, converting to a float, then getting a compiler
3145         warning on passing the float to something that expects an int, instead
3146         just pass around ints.
3147
3148         No tests, fixes a compiler warning.
3149
3150         * DumpRenderTree/chromium/LayoutTestController.cpp:
3151         (parsePageSizeParameters):
3152         (LayoutTestController::pageNumberForElementById):
3153         (LayoutTestController::numberOfPages):
3154
3155 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3156
3157         Reviewed by Darin Adler.
3158
3159         Bug 51537 - iexploder needs cleanup
3160         
3161         * iExploder/htdocs: Removed.
3162         * iExploder/htdocs/config.rb: Removed.
3163         * iExploder/htdocs/cssproperties.in: Removed.
3164         * iExploder/htdocs/cssvalues.in: Removed.
3165         * iExploder/htdocs/htmlattrs.in: Removed.
3166         * iExploder/htdocs/htmltags.in: Removed.
3167         * iExploder/htdocs/htmlvalues.in: Removed.
3168         * iExploder/htdocs/iexploder.cgi: Removed.
3169         * iExploder/htdocs/iexploder.rb: Removed.
3170         * iExploder/htdocs/index.html: Removed.
3171         * iExploder/htdocs/webserver.rb: Removed.
3172         * iExploder/iexploder-1.7.2/output: Removed.
3173         * iExploder/tools: Removed.
3174         * iExploder/tools/lasthit.rb: Removed.
3175         * iExploder/tools/osx_last_crash.rb: Removed.
3176         * iExploder/tools/showtest.rb: Removed.
3177
3178 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3179
3180         Reviewed by Kenneth Rohde Christiansen.
3181
3182         [EFL] Make 'single' the default backing store in EWebLauncher
3183         https://bugs.webkit.org/show_bug.cgi?id=51534
3184
3185         'single' is the simplest backing store and the one intended to be the
3186         default in the test browser. By mistake the tiled backing store was
3187         left as default in r72617.
3188
3189         * EWebLauncher/main.c:
3190         (browserCreate): ditto.
3191
3192 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3193
3194         Reviewed by Kenneth Rohde Christiansen.
3195
3196         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3197         https://bugs.webkit.org/show_bug.cgi?id=51533
3198
3199         There's no point in concatenating env("HOME") with "blah", so remove
3200         option from EWebLauncher.
3201
3202         * EWebLauncher/main.c:
3203         (main): ditto.
3204
3205 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3206
3207         Reviewed by Eric Seidel.
3208
3209         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3210
3211         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3212         I just discovered that we have two additional GC runs per each WebViewHost.
3213         Test_shell had no such calls.
3214         These gc runs eat 15% of cpu time.
3215
3216         https://bugs.webkit.org/show_bug.cgi?id=51479
3217
3218         * DumpRenderTree/chromium/WebViewHost.cpp:
3219         (WebViewHost::~WebViewHost):
3220
3221 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3222
3223         Reviewed by Ojan Vafai.
3224
3225         This change splits out the TestRunner class into its own file.
3226         When we fork the code for message passing, we will create a new
3227         TestRunner, and this change will allow that to be more modular.
3228
3229         While we're at it, split out TestInput and ResultSummary into
3230         their own files, to reduce the size of run_webkit_tests to
3231         something more managable.
3232
3233         https://bugs.webkit.org/show_bug.cgi?id=51092
3234
3235         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3236         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3237         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3238         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3239         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3240         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3241         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3242
3243  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3244
3245         Reviewed by Ojan Vafai.
3246
3247         nrwt multiprocessing - start over, prepare to fork the code
3248  
3249         This code cleans up the signatures and implementation of the
3250         TestRunner class so we can easily fork it to run either the
3251         stable implementation or the new, unstable message-passing
3252         implementation. The two variants will have different
3253         implementations of the run_tests() method. We will switch
3254         between the two based on the setting for the '--worker-model'
3255         switch. We rename the two currently valid values to 'old-inline'
3256         and 'old-threads'.
3257
3258         https://bugs.webkit.org/show_bug.cgi?id=51081
3259
3260         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3261         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3262
3263 2010-12-22  Victor Wang  <victorw@chromium.org>
3264
3265         Reviewed by Darin Fisher.
3266
3267         [Chromium] Update chromium archive test result url in rebaseline script.
3268
3269         https://bugs.webkit.org/show_bug.cgi?id=51503
3270
3271         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3272
3273 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3274
3275         Reviewed by Alice Liu.
3276
3277         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3278         Verified on Chrome, Safari, and IE.
3279         With this change, we will record memory from a parent browser window and all child processes.
3280
3281         * record-memory-win/main.cpp:
3282         (ProcessArgs):
3283         (PrintUsage):
3284         (getMemoryInfo):
3285         (printProcessInfo):
3286         (evalProcesses):
3287         (UseImage):
3288         (QueryContinuously):
3289         (ElapsedTime):
3290
3291 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3292
3293         Unreviewed rollout r74489, because it was missing changelog.
3294
3295         * record-memory-win/main.cpp:
3296         
3297 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3298
3299         Adding myself as a reviewer.
3300
3301         * Scripts/webkitpy/common/config/committers.py:
3302
3303 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3304
3305         Unreviewed.  Adding myself to committers.py.
3306
3307         * Scripts/webkitpy/common/config/committers.py:
3308
3309 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3310
3311         Reviewed by Kenneth Rohde Christiansen.
3312
3313         TestNetscapePlugIn should use #if defined
3314         https://bugs.webkit.org/show_bug.cgi?id=51471
3315
3316         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3317         (NP_Initialize):
3318         (NPP_New):
3319
3320 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3321
3322         Reviewed by Yury Semikhatsky.
3323
3324         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3325
3326         DevTools window should be closed explicitly because it has custom deinitialization code.
3327
3328         https://bugs.webkit.org/show_bug.cgi?id=50722
3329
3330         * DumpRenderTree/chromium/TestShell.cpp:
3331         (TestShell::closeRemainingWindows):
3332
3333 2010-12-22  David Levin  <levin@chromium.org>
3334
3335         Reviewed by Shinichiro Hamaji.
3336
3337         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3338         https://bugs.webkit.org/show_bug.cgi?id=51452
3339
3340         * Scripts/webkitpy/style/checkers/cpp.py:
3341         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3342         Using the file extension if possible but falling back to the file contents if we have a header file.
3343         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3344         (_FileState.is_c_or_objective_c):
3345         (check_using_std): Changed to using _FileState to determine the file type.
3346         (check_max_min_macros): Ditto.
3347         (check_for_null): Ditto.
3348         (check_style): Changed the parameters to various calls since they now need _FileState
3349         to determine the file type.
3350         (check_language): Added the file_state parameter so it could be passed
3351         to check_identifier_name_in_declaration.
3352         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3353         this is an Objective C file.
3354         (_process_lines): Added information for the _FileState constructor (and moved the
3355         call to a place that had the information).
3356         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3357         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3358         its functionality.
3359         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3360
3361 2010-12-21  Andy Estes  <aestes@apple.com>
3362
3363         Reviewed by Mark Rowe.
3364
3365         Do not build non-Intel architectures for WebKit2-related projects.
3366         https://bugs.webkit.org/show_bug.cgi?id=51440
3367
3368         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3369         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3370         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3371
3372 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3373
3374         Reviewed by Darin Fisher.
3375
3376         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3377         https://bugs.webkit.org/show_bug.cgi?id=51406 
3378         
3379         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3380         to WebThemeEngineDRTWin and update references everywhere.
3381
3382         * DumpRenderTree/DumpRenderTree.gypi:
3383         * DumpRenderTree/chromium/TestShellWin.cpp:
3384         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3385         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3386         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3387         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3388
3389 2010-12-21  Anders Carlsson  <andersca@apple.com>
3390
3391         Reviewed by John Sullivan.
3392
3393         Clicking missing plug-in text does not show a sheet
3394         https://bugs.webkit.org/show_bug.cgi?id=51403
3395
3396         Update for changes to the WebPageUIClient.
3397
3398         * MiniBrowser/mac/BrowserWindowController.m:
3399         (-[BrowserWindowController awakeFromNib]):
3400         * WebKitTestRunner/TestController.cpp:
3401         (WTR::createOtherPage):
3402         (WTR::TestController::initialize):
3403
3404 2010-12-21  Eric Seidel  <eric@webkit.org>
3405
3406         Reviewed by Adam Barth.
3407
3408         commit-queue will report constant failures as flaky if other tests flake
3409         https://bugs.webkit.org/show_bug.cgi?id=51272
3410
3411         This patch just removes functionality and adds testing.
3412         Previously we attempted to report flaky tests when we had
3413         two different tests fail in a row.  However, since we stop
3414         running the tests at the first failure, our code was wrong in
3415         trying to determine flakiness from the incomplete runs.
3416
3417         Originally I posted an alternate patch:
3418         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3419         which fixed our flaky logic in this case, however it was decided
3420         that that patch would be too difficult to maintain, so now
3421         I'm just removing the broken logic.
3422
3423         This will dramatically cut-down on our flaky-test false positives
3424         at the (small) cost of the queues being unable to report
3425         any flakiness if the tree is very flaky.  (With at least one test
3426         flaking on every run, we'll never report failures anymore.)  I think
3427         this is a tradeoff worth making.
3428
3429         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3430         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3431
3432 2010-12-20  Eric Seidel  <eric@webkit.org>
3433
3434         Reviewed by Adam Barth.
3435
3436         commit-queue wrongly rejects patches when it can't update itself
3437         https://bugs.webkit.org/show_bug.cgi?id=46636
3438
3439         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3440         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3441         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3442
3443 2010-12-20  Adam Barth  <abarth@webkit.org>
3444
3445         Move web sites to Websites directory
3446         https://bugs.webkit.org/show_bug.cgi?id=51323
3447
3448         Update references to BugsSite to point to the new location.
3449
3450         This patch was never officially reviewed (because it was too large to
3451         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3452         Rowe gave me the green light.
3453
3454         * Scripts/old-run-webkit-tests:
3455         * Scripts/webkitpy/common/config/build.py:
3456         * Scripts/webkitpy/common/config/build_unittest.py:
3457         * Scripts/webkitpy/common/prettypatch.py:
3458         * Scripts/webkitpy/layout_tests/port/base.py:
3459         * Scripts/webkitpy/style/main.py:
3460
3461 2010-12-20  Adrienne Walker  <enne@google.com>
3462
3463         Unreviewed. Adding myself to the list of committers.
3464
3465         * webkitpy/common/config/committers.py:
3466
3467 2010-12-20  Mark Rowe  <mrowe@apple.com>
3468
3469         Reviewed by Dan Bernstein.
3470
3471         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3472
3473         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3474         Resources directory.
3475
3476 2010-12-20  Eric Seidel  <eric@webkit.org>
3477
3478         Reviewed by Adam Barth.
3479
3480         commit-queue should include bot id when attaching failure diffs
3481         https://bugs.webkit.org/show_bug.cgi?id=51280
3482
3483         This is a tiny change to include the bot id in the name of the attachment.
3484         Most of this diff is just changing the unit test expectations
3485         now that I hid the comment printing when the comment is None.
3486
3487         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3488         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3489         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3490         * Scripts/webkitpy/tool/mocktool.py:
3491
3492 2010-12-20  Jeff Miller  <jeffm@apple.com>
3493
3494         Reviewed by Dan Bernstein.
3495
3496         Tools/vcbin/midl.exe needs to be rebuilt
3497         https://bugs.webkit.org/show_bug.cgi?id=51347
3498
3499         * vcbin/midl.exe: Rebuilt.
3500
3501 2010-12-20  David Levin  <levin@chromium.org>
3502
3503         Reviewed by Ariya Hidayat.
3504
3505         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3506         https://bugs.webkit.org/show_bug.cgi?id=51343
3507
3508         Follow up from the WebKitTools -> Tools rename.
3509
3510         * Scripts/webkit-tools-completion.sh:
3511
3512 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3513
3514         Reviewed by James Robinson.
3515
3516         new-run-webkit-tests ignores trailing EOL differences in text tests
3517         https://bugs.webkit.org/show_bug.cgi?id=36983
3518
3519         Changed the handling of new-line characters within new-run-webkit-tests
3520         to match old-run-webkit-tests.  Differences in leading and trailing empty
3521         lines in text expectation files are no longer ignored.
3522
3523         * Scripts/webkitpy/layout_tests/port/base.py:
3524         * Scripts/webkitpy/layout_tests/port/test.py:
3525         Added unit tests.  Removed old duplicate unit test entries.
3526         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3527
3528 2010-12-20  David Levin  <levin@chromium.org>
3529
3530         Reviewed by Shinichiro Hamaji.
3531
3532         check-webkit-style should detect function declarations (and trivial functions).
3533         https://bugs.webkit.org/show_bug.cgi?id=51303
3534
3535         * Scripts/webkitpy/style/checkers/cpp.py:
3536         (_FunctionState.begin): Add is_declaration and changed the line count
3537         start to begin at -1 (which will keep the results consistent, since
3538         the starting line number passed in is one less in this change).
3539         (detect_functions): changed function detection to now catch trivial
3540         functions and declarations.
3541         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3542         of the function as this may look at return values (when processing
3543         a declaration).
3544         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3545         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3546         of testing the function detection.
3547         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3548         function.
3549         (FunctionDetectionTest.test_function_declaration_detection): Test a
3550         declaration.
3551         (FunctionDetectionTest.test_non_functions): A test case for a case
3552         that caused the code to fail due to the { being in quotes.
3553         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3554         cases to help catch false alarms for return values.
3555         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3556         we don't get false alarms for member variables either.
3557
3558 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3559
3560         Reviewed by Antonio Gomes.
3561
3562         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3563         https://bugs.webkit.org/show_bug.cgi?id=51319
3564
3565         * CMakeListsEfl.txt:
3566
3567 2010-12-18  Adam Barth  <abarth@webkit.org>
3568
3569         Reviewed by Sam Weinig.
3570
3571         Move WebKitExamplePlugins to Examples
3572         https://bugs.webkit.org/show_bug.cgi?id=51291
3573
3574         * Scripts/webkitpy/common/config/build.py:
3575
3576 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3577
3578         Unreviewed Qt buildfix after r74301.
3579
3580         Rename WebKitTools to Tools
3581         https://bugs.webkit.org/show_bug.cgi?id=49861
3582
3583         * MiniBrowser/DerivedSources.pro:
3584         * MiniBrowser/qt/MiniBrowser.pro:
3585
3586 2010-12-17  Dan Bernstein  <mitz@apple.com>
3587
3588         Reviewed by Simon Fraser.
3589
3590         Rename WebKitTools to Tools
3591         https://bugs.webkit.org/show_bug.cgi?id=49861
3592
3593         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3594         * CodeCoverage/README:
3595         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3596         (WebCore::DumpRenderTree::initializeFonts):
3597         * EWSTools/start-commit-queue.sh:
3598         * EWSTools/start-queue.sh:
3599         * GNUmakefile.am:
3600         * MIDLWrapper/MIDLWrapper.cpp:
3601         (wmain):
3602         * MiniBrowser/qt/MiniBrowser.pro:
3603         * Scripts/build-api-tests:
3604         * Scripts/build-dumprendertree:
3605         * Scripts/build-webkit:
3606         * Scripts/build-webkittestrunner:
3607         * Scripts/generate-coverage-data:
3608         * Scripts/old-run-webkit-tests:
3609         * Scripts/run-api-tests:
3610         * Scripts/run-iexploder-tests:
3611         * Scripts/run-javascriptcore-tests:
3612         * Scripts/run-mangleme-tests:
3613         * Scripts/run-sunspider:
3614         * Scripts/run-webkit-websocketserver:
3615         * Scripts/sunspider-compare-results:
3616         * Scripts/test-webkitperl:
3617         * Scripts/test-webkitpy:
3618         * Scripts/update-iexploder-cssproperties:
3619         * Scripts/update-webkit:
3620         * Scripts/update-webkit-localizable-strings:
3621         * Scripts/webkitdirs.pm:
3622         * Scripts/webkitpy/common/checkout/scm.py:
3623         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3624         * Scripts/webkitpy/common/config/committervalidator.py:
3625         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3626         * Scripts/webkitpy/common/config/ports.py:
3627         * Scripts/webkitpy/common/config/ports_unittest.py:
3628         * Scripts/webkitpy/common/system/logutils_unittest.py:
3629         * Scripts/webkitpy/common/system/ospath_unittest.py:
3630         * Scripts/webkitpy/layout_tests/port/chromium.py:
3631         * Scripts/webkitpy/layout_tests/port/config.py:
3632         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3633         * Scripts/webkitpy/layout_tests/port/http_server.py:
3634         * Scripts/webkitpy/layout_tests/port/test.py:
3635         * Scripts/webkitpy/style/checker.py:
3636         * Scripts/webkitpy/style/checker_unittest.py:
3637         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3638         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3639         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3640         * WebKitTestRunner/DerivedSources.pro:
3641         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3642         (WTR::activateFonts):
3643         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3644         * wx/build/build_utils.py:
3645
3646 2010-12-16  Antonio Gomes  <agomes@rim.com>
3647
3648         Reviewed by Martin Robinson.
3649
3650         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3651         https://bugs.webkit.org/show_bug.cgi?id=51163
3652
3653         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3654         GTK+'s DRT should also reset to UNIX after each test execution.
3655
3656         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3657         (resetDefaultsToConsistentValues):
3658
3659 2010-12-17  David Levin  <levin@chromium.org>
3660
3661         Reviewed by Eric Seidel.
3662
3663         check-webkit-style should understand WTF #include guards
3664         https://bugs.webkit.org/show_bug.cgi?id=44911
3665
3666         * Scripts/webkitpy/style/checkers/cpp.py:
3667         (get_header_guard_cpp_variable): modify to suggest the WTF style
3668         of header guard when appropriate.
3669         (check_for_header_guard): handle multiple return values from
3670         get_header_guard_cpp_variable
3671         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3672         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3673         header style.
3674
3675 2010-12-16  David Levin  <levin@chromium.org>
3676
3677         Reviewed by Eric Seidel.
3678
3679         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3680         https://bugs.webkit.org/show_bug.cgi?id=51210
3681
3682         The error only shows up when using python 2.6 or later.
3683
3684         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3685         the decprecated field error,message with something equivalent.
3686
3687 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3688
3689         Reviewed by Eric Seidel.
3690
3691         Add --exit-after-n-failures/crashes to NRWT
3692         https://bugs.webkit.org/show_bug.cgi?id=51160
3693         
3694         Abort test run (in a similar way to how control-C is handled) when
3695         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3696         that number of unexpected failures/crashes/timeouts.
3697
3698         * Scripts/webkitpy/layout_tests/port/test.py:
3699         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3700         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3701
3702 2010-12-16  David Levin  <levin@chromium.org>
3703
3704         Reviewed by Shinichiro Hamaji.
3705
3706         check-webkit-style unit tests has some duplicate boilerplate code.
3707         https://bugs.webkit.org/show_bug.cgi?id=49519
3708
3709         * Scripts/webkitpy/style/checkers/cpp.py:
3710         (update_include_state): Replaced the "io" parameter with the global
3711         configuration _unit_test_config. This allowed not calling into
3712         functions at a low level and also not plumbing through the injection
3713         information through many levels of code.
3714         (check_for_include_what_you_use): Ditto.
3715         (process_file_data): Added the ability to set up the unit test config
3716         to allow for injection.
3717         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3718         (ErrorCollector.__init__): Added support for having a filter for errors.
3719         (ErrorCollector.__call__): Ditto.
3720         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3721         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3722         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3723         functions in the cpp.py with generic processing and a filter that
3724         indicates what errors should be kept.
3725         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3726         (CppStyleTestBase.perform_language_rules_check): Ditto.
3727         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3728         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3729         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3730         (CppStyleTest.test_multi_line_comments): Added another
3731         error message which applies to the test case.
3732         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3733         to not have config.h, since it is processed as a header file.
3734         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3735         style and indentation in checked code.
3736         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3737         Fixed line number.
3738         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3739         Ditto.
3740
3741 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3742
3743         Unreviewed, rolling out r74136.
3744         http://trac.webkit.org/changeset/74136
3745         https://bugs.webkit.org/show_bug.cgi?id=51135
3746
3747         r74136 breaks chromium canary bots because some tests are not
3748         rebaselined correctly to resolve EOL differences (Requested by
3749         jianli on #webkit).
3750
3751         * Scripts/webkitpy/layout_tests/port/base.py:
3752         * Scripts/webkitpy/layout_tests/port/test.py:
3753         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3754
3755 2010-12-15  Adam Roben  <aroben@apple.com>
3756
3757         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3758         syntax errors
3759
3760         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3761         XML syntax errors in .vcproj/.vsprops files
3762
3763         Reviewed by Dave Levin.
3764
3765         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3766         that should be treated as XML and that should be allowed to contain