3327a2a77da4409c8a96e4af107dbea008f06483
[WebKit.git] / Tools / ChangeLog
1 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
2
3         Reviewed by Gustavo Noronha Silva.
4
5         [GTK] fast/events/pagehide-timeout.html fails
6         https://bugs.webkit.org/show_bug.cgi?id=53771
7
8         Add knowledge of the document browser cache model the DRT. When resetting
9         WebKit settings to consistent values between tests, default to the document
10         browser cache model.
11
12         * DumpRenderTree/gtk/DumpRenderTree.cpp:
13         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
14         cache model between tests.
15         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
16         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
17         document browser cache model.
18
19 2011-02-04  Adam Barth  <abarth@webkit.org>
20
21         Reviewed by Eric Seidel.
22
23         PluginDocuments don't create widgets for plugins on back/forward
24         https://bugs.webkit.org/show_bug.cgi?id=53474
25
26         Teach the test plugin how to call alert on load.
27
28         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
29         (NPP_New):
30
31 2011-02-04  Adam Roben  <aroben@apple.com>
32
33         Add a test case for encode/decode of FormData/FormDataElement
34
35         If the fix made in r77401 is broken, this new test will crash.
36
37         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
38
39         Reviewed by Sam Weinig.
40
41         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
42         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
43
44         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
45         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
46         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
47         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
48         form, an return the session state data.
49         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
50         and restore it into another WKPage.
51
52         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
53
54         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
55         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
56         * TestWebKitAPI/win/copy-resources.cmd:
57         Added new files.
58
59 2011-02-04  Adam Roben  <aroben@apple.com>
60
61         Move code to run JavaScript tests into its own files
62
63         This will allow other tests to use this mechanism.
64
65         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
66         world
67
68         Reviewed by Sam Weinig.
69
70         * TestWebKitAPI/JavaScriptTest.cpp: Added.
71         * TestWebKitAPI/JavaScriptTest.h: Added.
72         Moved code here...
73
74         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
75
76         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
77         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
78         Added the new files.
79
80 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
81
82         Reviewed by Mihai Parparita.
83
84         merge test expectations for chromium, chromium-gpu. The
85         chromium-gpu port will no longer maintain its own
86         test expectations file.
87
88         Also add in a graphics_type() call on the port object to
89         determine what graphics type to use in the test configuration,
90         and log the configuration as a config setting.
91
92         https://bugs.webkit.org/show_bug.cgi?id=53562
93
94         * Scripts/webkitpy/layout_tests/port/base.py:
95         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
96         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
97         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
98
99 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
100
101         Reviewed by Pavel Feldman.
102
103         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
104         https://bugs.webkit.org/show_bug.cgi?id=53781
105
106         * Scripts/check-inspector-strings:
107
108 2011-02-04  Adam Roben  <aroben@apple.com>
109
110         Include the crashing function in the link to a crash log on Mac
111
112         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
113         function that crashed on Mac
114
115         Reviewed by David Kilzer.
116
117         * Scripts/old-run-webkit-tests:
118         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
119         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
120         the crash log.
121
122 2011-02-04  Adam Roben  <aroben@apple.com>
123
124         Link to Mac crash logs from results.html
125
126         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
127         results.html
128
129         Reviewed by David Kilzer.
130
131         * Scripts/old-run-webkit-tests:
132         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
133         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
134
135 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
136
137         Reviewed by Dan Bernstein.
138
139         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
140         https://bugs.webkit.org/show_bug.cgi?id=52897
141         <rdar://problem/8898294>
142
143         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
144         (WTR::InjectedBundlePage::InjectedBundlePage):
145         (WTR::InjectedBundlePage::willSendRequestForFrame):
146         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
147
148 2011-02-03  Ivan Krstić  <ike@apple.com>
149
150         Unreviewed.
151
152         Adding myself to committers.py.
153
154         * Scripts/webkitpy/common/config/committers.py:
155
156 2011-02-03  James Kozianski  <koz@chromium.org>
157
158         Reviewed by Dimitri Glazkov.
159
160         Add navigator.registerProtocolHandler behind a flag.
161         https://bugs.webkit.org/show_bug.cgi?id=52609
162
163         * Scripts/build-webkit:
164
165 2011-02-03  Hayato Ito  <hayato@chromium.org>
166
167         Reviewed by Eric Seidel.
168
169         [NRWT] Remove TestArgs class, which is wrongly used.
170
171         https://bugs.webkit.org/show_bug.cgi?id=53063
172
173         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
174         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
175         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
176         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
177         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
178         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
179
180 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
181
182         Reviewed by Kenneth Russell.
183
184         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
185         https://bugs.webkit.org/show_bug.cgi?id=53714
186
187         * Scripts/build-webkit: change --3d-canvas build option
188           to set ENABLE_WEBGL
189
190 2011-02-03  Hayato Ito  <hayato@chromium.org>
191
192         Reviewed by Tony Chang.
193
194         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
195         move _run_single_test() and _process_output() functions from
196         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
197
198         This is clean up and acts as a preparation for elimination of test_types/*
199         classes. These classes will move to the single_test_runner module introduced
200         in this patch.
201
202         https://bugs.webkit.org/show_bug.cgi?id=53004
203
204         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
205         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
206         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
207         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
208         * Scripts/webkitpy/layout_tests/port/base.py:
209         * Scripts/webkitpy/layout_tests/port/chromium.py:
210         * Scripts/webkitpy/layout_tests/port/dryrun.py:
211         * Scripts/webkitpy/layout_tests/port/test.py:
212         * Scripts/webkitpy/layout_tests/port/webkit.py:
213         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
214         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
215         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
216
217 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
218
219         Unreviewed, build fix.
220
221         Delete a line that was accidentally missed in r77586; without it
222         there is still a race between the two threads.
223
224         https://bugs.webkit.org/show_bug.cgi?id=51572
225
226         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
227
228 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
229
230         Reviewed by Tony Chang.
231
232         nrwt: handle "broken pipe" notifications from DRT more cleanly.
233
234         https://bugs.webkit.org/show_bug.cgi?id=52927
235
236         * Scripts/webkitpy/layout_tests/port/server_process.py:
237         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
238
239 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
240
241         Reviewed by Kenneth Russell.
242
243         Update, resubmit change to bug 51572. I think the race that was
244         fixed in r76703 caused the hang that caused us to roll this
245         patch out before, so I'd like to try again.
246
247         https://bugs.webkit.org/show_bug.cgi?id=51572
248
249         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
250         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
251
252 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
253
254         Unreviewed.
255
256         Adding myself to committers.py.
257
258         * Scripts/webkitpy/common/config/committers.py:
259
260 2011-02-03  Adam Roben  <aroben@apple.com>
261
262         Include the crashing function in the link to a crash log
263
264         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
265         function that crashed
266
267         Reviewed by David Kilzer.
268
269         * Scripts/old-run-webkit-tests:
270         (crashLocation): Added. Returns the location of the crash.
271         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
272         could be determined.
273
274 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
275
276         Unreviewed, build fix.
277
278         Actually make the changes suggested by Mihai in his review
279         of bug 53720 :(
280
281         https://bugs.webkit.org/show_bug.cgi?id=53720
282
283         * Scripts/webkitpy/layout_tests/port/test_files.py:
284         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
285
286 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
287
288         Reviewed by Mihai Parparita.
289
290         new-run-webkit-tests: Fix bug introduced in r77434 that was
291         causing us to run the canvas GPU tests on the Mac GPU port. This
292         bug revealed that we were not setting the port.name() field
293         properly in many cases, so I've cleaned up all of that code, and
294         removed a few comments about "version-specific" GPU ports that
295         don't exist and just confused things.
296
297         Testing also revealed that port.abspath_for_test() wasn't
298         normalizing paths on Windows properly, so I fixed that as well.
299
300         https://bugs.webkit.org/show_bug.cgi?id=53719
301
302         * Scripts/webkitpy/layout_tests/port/base.py:
303         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
304         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
305
306 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
307
308         Reviewed by Mihai Parparita.
309
310         new-run-webkit-tests: fix normalization of paths on windows when gathering files
311
312         r77434 introduced a bug that was causing the test expectations
313         for the GPU ports to not be treated properly. It turns out that
314         when we gathered the list of test files on Windows, we would
315         return paths of the form "c:\LayoutTests/fast/canvas", and the
316         mixture of backslashes and forward slashes was confusing things.
317
318         This patch normalizes all of the filenames returned from
319         test_files.find(), and adds better tests for this (fixing a
320         couple of other bugs found in the meantime).
321
322         https://bugs.webkit.org/show_bug.cgi?id=53720
323
324         * Scripts/webkitpy/layout_tests/port/test.py:
325         * Scripts/webkitpy/layout_tests/port/test_files.py:
326         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
327
328 2011-02-03  Adam Roben  <aroben@apple.com>
329
330         Add links to Windows crash logs in results.html
331
332         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
333         results.html
334
335         Reviewed by David Kilzer.
336
337         * Scripts/old-run-webkit-tests:
338         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
339         createDebuggerCommandFile).
340         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
341         tool has exited.
342         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
343         it into the test results directory tree. Only implemented for Cygwin currently.
344         (findNewestFileMatchingGlob): Added. Does what it says.
345         (htmlForResultsSection): Only link to files that exist.
346         (linksForErrorTest): Add a link to the crash log.
347         (deleteExpectedAndActualResults): Delete any old crash log for this test.
348         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
349         hardcoding it here.
350
351 2011-02-03  Adam Roben  <aroben@apple.com>
352
353         Tell the debugger the path to the WebKit source tree when saving a crash log
354
355         This allows the debugger to include the crashing line of code in the log.
356
357         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
358         of code
359
360         Reviewed by Sam Weinig.
361
362         * Scripts/old-run-webkit-tests:
363         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
364         file and returns the path to that file. The commands we pass came from
365         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
366         WebKit source code lives.
367         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
368         line using -c, save them to a file and specify the path to that file using -cf. This works
369         around what is presumably a bug in Windows's command line parsing, where having multiple
370         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
371         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
372         together to make them easier to modify in the future.
373
374 2011-02-02  Sam Weinig  <sam@webkit.org>
375
376         Reviewed by Anders Carlsson.
377
378         Add notification of the end of a rubber band.
379         <rdar://problem/8940648>
380
381         * MiniBrowser/mac/BrowserWindowController.m:
382         (-[BrowserWindowController awakeFromNib]):
383         * WebKitTestRunner/TestController.cpp:
384         (WTR::TestController::createOtherPage):
385         (WTR::TestController::initialize):
386         Stub out the new WKUIClient function.
387
388 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
389
390         Unreviewed.
391
392         Adding myself to committers.py.
393
394         * Scripts/webkitpy/common/config/committers.py:
395
396 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
397
398         Reviewed by Csaba Osztrogonác.
399
400         [Qt][WK2] MiniBrowser's window size should be 800x600
401         https://bugs.webkit.org/show_bug.cgi?id=53670
402
403         Make layout test failure debugging easier.
404         * MiniBrowser/qt/BrowserWindow.cpp:
405         (BrowserWindow::BrowserWindow):
406
407 2011-02-02  Andy Estes  <aestes@apple.com>
408
409         Reviewed by Mark Rowe.
410
411         'update-webkit' should handle OpenSource and Internal using different
412         VCSs.
413
414         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
415         Internal directory.
416
417 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
418
419         Reviewed by Mihai Parparita.
420
421         new-run-webkit-tests: hardcode the directories to scan for tests
422         for GPU bots instead of SKIPping them. See bug 53562 for some
423         context, but we will now hard-code the list of directories to
424         use by default instead of skipping over directories in the
425         expectations file. We do this so that we will be able to merge
426         the expectations files without getting conflicting SKIP
427         directives. Note that this change will reduce the # of tests
428         being run on the Mac GPU bots, because we're accidentally
429         including some today.
430
431         https://bugs.webkit.org/show_bug.cgi?id=53631
432
433         * Scripts/webkitpy/layout_tests/port/base.py:
434         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
435         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
436
437 2011-02-02  Sam Weinig  <sam@webkit.org>
438
439         Reviewed by Beth Dakin.
440
441         Add ChromeClient function to paint custom overhang areas.
442         https://bugs.webkit.org/show_bug.cgi?id=53639
443
444         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
445         (WTR::InjectedBundlePage::InjectedBundlePage):
446         Stub out new callback.
447
448 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
449
450         Reviewed by Tony Chang.
451
452         new-run-webkit-tests: support chromium code paths in mock_drt
453
454         https://bugs.webkit.org/show_bug.cgi?id=53471
455
456         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
457         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
458
459 2011-02-02  Adam Klein  <adamk@chromium.org>
460
461         Reviewed by Tony Chang.
462
463         Update new-run-webkit-tests --chromium to put output under Source/...
464         https://bugs.webkit.org/show_bug.cgi?id=53612
465
466         * BuildSlaveSupport/test-result-archive:
467         * Scripts/webkitpy/layout_tests/port/chromium.py:
468
469 2011-01-28  Tony Chang  <tony@chromium.org>
470
471         Reviewed by Eric Seidel.
472
473         [chromium] remove --use-test-shell from NRWT
474         https://bugs.webkit.org/show_bug.cgi?id=53346
475
476         I've already started removing some of the bindings like eventSender so
477         this already doesn't work isn't useful.  Also updated some comments to
478         refer to DRT instead of test_shell.
479
480         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
481         * Scripts/webkitpy/layout_tests/port/chromium.py:
482         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
483         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
484         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
485         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
486         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
487         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
488
489 2011-02-02  Steve Lacey  <sjl@chromium.org>
490
491         Reviewed by Eric Carlson.
492
493         Implement basic media statistics on media elements.
494         https://bugs.webkit.org/show_bug.cgi?id=53322
495
496         * Scripts/build-webkit:
497
498 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
499
500         [wx] Build fixes for wxWebKit.
501
502         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
503         (LayoutTestController::setSerializeHTTPLoads):
504         * wx/browser/wscript:
505         * wx/build/build_utils.py:
506         * wx/build/settings.py:
507
508 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
509
510         Reviewed by Mihai Parparita.
511
512         new-run-webkit-tests: stop skipping so many tests
513
514         r77163 introduced a regression where we weren't resetting test
515         expectations properly and were skipping too many tests as a
516         result. This patch fixes that and adds a test for it.
517
518         https://bugs.webkit.org/show_bug.cgi?id=53551
519
520         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
521         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
522
523 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
524
525         Reviewed by Tony Chang.
526
527         new-run-webkit-tests: add first stub of test_runner2. This
528         will add support for the 'inline', 'threads', and 'processes'
529         flags to --worker-model, but for now the implementatios just
530         fall back on the old ones.
531
532         https://bugs.webkit.org/show_bug.cgi?id=53157
533
534         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
535         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
536
537 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
538
539         Reviewed by James Robinson.
540
541         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
542         https://bugs.webkit.org/show_bug.cgi?id=53522
543
544         * Scripts/run-chromium-webkit-unit-tests:
545
546 2011-02-01  Adam Barth  <abarth@webkit.org>
547
548         Reviewed by Mihai Parparita.
549
550         Using Control-C to cancel webkit-patch or other python tools causes
551         unpleasant traceback console spew
552         https://bugs.webkit.org/show_bug.cgi?id=53462
553
554         Catch the exception and don't print the stack trace.
555
556         * Scripts/webkit-patch:
557
558 2011-02-01  Scott Cameron  <sccameron@rim.com>
559
560         Reviewed by Daniel Bates.
561
562         Use Windows format for MinGW HTTPD path.
563         https://bugs.webkit.org/show_bug.cgi?id=53503
564
565         * Scripts/webkitperl/httpd.pm:
566           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
567             so that we don't have to escape the space characters in the path. Also,
568             changed path to Windows-style path and removed FIXME comment.
569
570 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
571
572         Reviewed by Andreas Kling.
573
574         [Qt][WK2] Add a way to use shared process model in MiniBrowser
575         https://bugs.webkit.org/show_bug.cgi?id=53090
576
577         * MiniBrowser/qt/BrowserView.cpp:
578         (BrowserView::BrowserView): Removed the m_context member.
579         From now the context is guaranteed to be non-null and we
580         don't need to store that in the object.
581         * MiniBrowser/qt/BrowserView.h:
582         * MiniBrowser/qt/BrowserWindow.cpp:
583         Added static bool to determine that new windows need to be
584         created with their own context or not. Use the same context
585         and web process by default to be inilne with the other ports.
586         (BrowserWindow::BrowserWindow):
587         (BrowserWindow::newWindow):
588         * MiniBrowser/qt/BrowserWindow.h:
589         * MiniBrowser/qt/main.cpp:
590         (main): Added command line switch to be able to use the
591         non-shared process model. Simplify the handling of the command line
592         switches a little bit.
593
594 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
595
596         Reviewed by Andreas Kling.
597
598         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
599         https://bugs.webkit.org/show_bug.cgi?id=53491
600
601         * MiniBrowser/qt/BrowserWindow.cpp:
602         (BrowserWindow::BrowserWindow):
603         (BrowserWindow::toggleFullScreenMode):
604         * MiniBrowser/qt/BrowserWindow.h:
605
606 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
607
608         Reviewed by Andreas Kling.
609
610         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
611         https://bugs.webkit.org/show_bug.cgi?id=53489
612
613         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
614         to Settings menu.
615
616         * MiniBrowser/qt/BrowserWindow.cpp:
617         (BrowserWindow::BrowserWindow):
618         (BrowserWindow::toggleFrameFlattening):
619         (BrowserWindow::toggleDisableJavaScript):
620         (BrowserWindow::toggleAutoLoadImages):
621         * MiniBrowser/qt/BrowserWindow.h:
622
623 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
624
625         Reviewed by Tony Chang.
626
627         [Chromium] Switch chromium-mac to use ChromiumDriver
628         https://bugs.webkit.org/show_bug.cgi?id=53461
629         
630         For the sake of consistency with the other Chromium platforms (and so
631         that chromium-mac picks up special flags like --enable-hardware-gpu),
632         switch chromium-mac from the WebKitDriver to ChromiumDriver.
633
634         * Scripts/webkitpy/layout_tests/port/chromium.py:
635
636 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
637
638         Reviewed by Mihai Parparita.
639
640         The current modifier parsing code in test_expectations is
641         fragile and hard-coded, so it's not easy to understand the logic
642         or easily add new types of modifiers (like GPU vs. CPU testing
643         for graphics tests, or 32-bit vs. 64-bit differences).
644
645         This is the first of two patches that will add in more generic
646         support and then eliminate the GPU-specific test expectations
647         files for Chromium.
648
649         This patch adds two standalone objects for handling modifiers. The
650         rules for interpreting modifiers, precedence, and conflicts are
651         given in the docstring to the ModifierMatcher class, which
652         returns ModifierMatchResult objects.
653         
654         This patch also adds routines to the Port interface and a
655         default set of values in the base object, in order to obtain the
656         values needed on a given test run. These values are then passed
657         to the expectation parser. This also allows us to clean up the
658         logic used to lint all of the different configurations in a
659         single test_expectations.txt file.
660
661         The next patch will merge in the separate GPU expectations file.
662
663         https://bugs.webkit.org/show_bug.cgi?id=51222
664
665         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
666         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
667         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
668         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
669         * Scripts/webkitpy/layout_tests/port/base.py:
670         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
671         * Scripts/webkitpy/layout_tests/port/chromium.py:
672         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
673         * Scripts/webkitpy/layout_tests/port/test.py:
674         * Scripts/webkitpy/layout_tests/port/webkit.py:
675         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
676         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
677         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
678         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
679         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
680
681 2011-01-31  Scott Cameron  <sccameron@rim.com>
682
683         Reviewed by Daniel Bates.
684
685         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
686         https://bugs.webkit.org/show_bug.cgi?id=50036
687
688         This will add an Apache2.2 configuration file and modifies scripts to allow
689         running an httpd server in an MSYS environment.
690
691         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
692         in order to allow for simple installation/execution.  Simply install the latest
693         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
694         be able to execute run-webkit-httpd.
695         
696
697         * Scripts/run-webkit-httpd:
698         * Scripts/webkitperl/httpd.pm:
699
700 2011-01-31  Tony Chang  <tony@chromium.org>
701
702         Reviewed by Eric Seidel.
703
704         mac DRT should report RTL scroll offset relative to top right corner
705         https://bugs.webkit.org/show_bug.cgi?id=53324
706
707         * DumpRenderTree/mac/DumpRenderTree.mm:
708         (dumpFrameScrollPosition):
709
710 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
711
712         Reviewed by Andreas Kling.
713
714         [Qt] Add Take Screen Shot action to MiniBrowser
715         https://bugs.webkit.org/show_bug.cgi?id=53422
716
717         Add Take Screen Shot action to MiniBrowser's view menu.
718
719         * MiniBrowser/qt/BrowserWindow.cpp:
720         (BrowserWindow::BrowserWindow):
721         (BrowserWindow::screenshot):
722         * MiniBrowser/qt/BrowserWindow.h:
723
724 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
725
726         Reviewed by Xan Lopez.
727
728         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
729         https://bugs.webkit.org/show_bug.cgi?id=53379
730
731         Remove left over #ifdef's. I thought all of the conditional code
732         had been freed from the condition, but I forgot to check DRT.
733
734         * DumpRenderTree/gtk/DumpRenderTree.cpp:
735         (resetDefaultsToConsistentValues):
736         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
737         (LayoutTestController::setAlwaysAcceptCookies):
738
739 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
740
741         Unreviewed, build fix.
742
743         Fix regression introduced in r77093 - path.rsplit() doesn't
744         take keyword arguments.
745
746         https://bugs.webkit.org/show_bug.cgi?id=53326
747
748         * Scripts/webkitpy/common/system/filesystem_mock.py:
749
750 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
751
752         Reviewed by Mihai Parparita.
753
754         Add more unit tests for rebaseline-chromium-webkit-tests. This
755         change involves restructuring a bunch of r-c-w-t code to make it
756         more testable as well. We also add wrapper classes for handling
757         testing zip files and fetching URLs.
758
759         https://bugs.webkit.org/show_bug.cgi?id=53040
760
761         * Scripts/webkitpy/common/system/urlfetcher.py:
762         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
763         * Scripts/webkitpy/common/system/zipfileset_mock.py:
764         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
765         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
766         * Scripts/webkitpy/tool/mocktool.py:
767
768 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
769
770         Reviewed by Eric Seidel.
771
772         Clean up of the filesystem-related modules used in webkitpy.
773         I've added relpath() to the filesystem interface, modified
774         ospath.relpath() so that it could work with the filesystem
775         interface, and modified the fileset* routines to use the
776         filesystem interface consistently.
777
778         This patch also adds a close() routine to the fileset routines
779         to indicate that the caller is done with the fileset. This
780         allows zipfileset to clean up after itself when it creates
781         tempfiles to store downloads.
782
783         https://bugs.webkit.org/show_bug.cgi?id=53326
784
785         * Scripts/webkitpy/common/system/directoryfileset.py:
786         * Scripts/webkitpy/common/system/fileset.py:
787         * Scripts/webkitpy/common/system/filesystem.py:
788         * Scripts/webkitpy/common/system/filesystem_mock.py:
789         * Scripts/webkitpy/common/system/filesystem_unittest.py:
790         * Scripts/webkitpy/common/system/ospath.py:
791         * Scripts/webkitpy/common/system/zipfileset.py:
792         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
793
794 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
795
796         Reviewed by Csaba Osztrogonác.
797
798         [Qt][WK2]REGRESSION (r76991): Fix build errors
799         https://bugs.webkit.org/show_bug.cgi?id=53400
800
801         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
802         and remove WebKit2Prefix.h from the build.
803         * MiniBrowser/qt/MiniBrowser.pro:
804
805 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
806
807         Unreviewed.
808
809         [Qt][WK2] Buildfix.
810
811         * MiniBrowser/qt/MiniBrowser.pro:
812
813 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
814
815         Reviewed by Adam Roben.
816         
817         define NOMINMAX when building ImageDiff, as we do elsewhere.
818
819         Add various clampToInt() methods to MathExtras.h
820         https://bugs.webkit.org/show_bug.cgi?id=52910
821
822         * DumpRenderTree/win/ImageDiffCommon.vsprops:
823
824 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
825
826         Reviewed by Darin Adler.
827
828         WebKitTestRunner needs layoutTestController.setPOSIXLocale
829         https://bugs.webkit.org/show_bug.cgi?id=42682
830
831         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
832         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
833         (WTR::InjectedBundle::resetLocalSettings):
834         (WTR::InjectedBundle::didReceiveMessage):
835         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
836         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
837         (WTR::LayoutTestController::setPOSIXLocale):
838         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
839
840 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
841  
842          Reviewed by Mihai Parparita.
843  
844          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
845  
846          This patch re-enables this test and changes it to
847          handle all of the mac platform versions, not just the one
848          it is running on.
849  
850          https://bugs.webkit.org/show_bug.cgi?id=53356
851  
852          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
853  
854 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
855
856         Unreviewed, build fix.
857
858         Take two. The fix in 77023 didn't work, because we were
859         still calling path.abspath_to_uri, which calls _cygpath under
860         the covers, and it appears the cygpath on the bots does
861         something different than it does on my machine. This patch
862         removes the calls to path.abspath_to_uri, so it should be safe.
863         If it doesn't work, I'll roll it out along with r76982 and 77023.
864
865         https://bugs.webkit.org/show_bug.cgi?id=53126
866
867         * Scripts/webkitpy/layout_tests/port/test.py:
868
869 2011-01-28  David Kilzer  <ddkilzer@apple.com>
870
871         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
872         <http://webkit.org/b/53353>
873
874         Reviewed by Mark Rowe.
875
876         * Scripts/webkitdirs.pm:
877         (checkRequiredSystemConfig): Check the Xcode marketing version
878         in addition to the DevCoreTools build version before complaining
879         about an old version of Xcode.  Also make the Mac OS X version
880         check use Perl's built-in version string comparitor.
881
882 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
883
884         Unreviewed, build fix.
885
886         Work around breakage on Win 7 Release bot caused by r76982
887         and the fact that windows ports use "file:////" instead of
888         "file:///". Ideally the test code should be isolated from
889         this, but it isn't yet. Will fix properly in a bit.
890
891         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
892
893 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
894
895         Reviewed by Tony Chang.
896
897         new-run-webkit-tests: change worker model values to
898         "old-inline", "old-threads" in preparation for test_runner2 /
899         multiprocessing changes.
900
901         https://bugs.webkit.org/show_bug.cgi?id=53156
902
903         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
904         * Scripts/webkitpy/layout_tests/port/base.py:
905         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
906         * Scripts/webkitpy/layout_tests/port/mac.py:
907         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
908
909 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
910
911         Reviewed by Tony Chang.
912
913         committers.py - add an IRC nickname for dpranke
914         https://bugs.webkit.org/show_bug.cgi?id=53335
915
916         * Scripts/webkitpy/common/config/committers.py:
917
918 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
919
920         Reviewed by Tony Chang.
921
922         new-run-webkit-tests: add a "mock DRT" port implementation
923         and a separate class that emulates what we expect the
924         DumpRenderTree behavior to be.
925
926         This will eventually replace port/dryrun.py and allow us to get
927         better test coverage of the new-run-webkit-tests code as well as
928         a reference for what new-run-webkit-tests expects from DRT.
929
930         This is the first attempt at this, and it is pretty bare-boned. It
931         really only has been tested on the 'mac' port (and a little on
932         the 'chromium-mac' port.
933
934         https://bugs.webkit.org/show_bug.cgi?id=53126
935
936         * Scripts/webkitpy/common/system/filesystem_mock.py:
937         * Scripts/webkitpy/layout_tests/port/dryrun.py:
938         * Scripts/webkitpy/layout_tests/port/factory.py:
939         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
940         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
941         * Scripts/webkitpy/layout_tests/port/test.py:
942
943 2011-01-28  Pratik Solanki  <psolanki@apple.com>
944
945         Unreviewed. Removing .swp file checked in by mistake.
946
947         * Scripts/.webkitdirs.pm.swp: Removed.
948
949 2011-01-28  Pratik Solanki  <psolanki@apple.com>
950
951         Reviewed by David Kilzer.
952
953         Space not necessary for undefined feature
954         https://bugs.webkit.org/show_bug.cgi?id=53317
955
956         * Scripts/build-webkit:
957
958 2011-01-28  Chang Shu  <chang.shu@nokia.com>
959
960         Reviewed by Andreas Kling.
961
962         Reset NetworkAccessManager to clean up credentials from previous tests.
963         This change causes no performance overhead either.
964         https://bugs.webkit.org/show_bug.cgi?id=36688
965
966         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
967         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
968         (WebCore::DumpRenderTree::open):
969         * DumpRenderTree/qt/DumpRenderTreeQt.h:
970
971 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
972
973         Reviewed by Andreas Kling.
974
975         [Qt] Add Zoom Text Only action to MiniBrowser
976         https://bugs.webkit.org/show_bug.cgi?id=53297
977
978         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
979
980         * MiniBrowser/qt/BrowserWindow.cpp:
981         (BrowserWindow::BrowserWindow):
982         (BrowserWindow::zoomIn):
983         (BrowserWindow::zoomOut):
984         (BrowserWindow::resetZoom):
985         (BrowserWindow::toggleZoomTextOnly):
986         (BrowserWindow::applyZoom):
987         * MiniBrowser/qt/BrowserWindow.h:
988
989 2011-01-28  Adam Barth  <abarth@webkit.org>
990
991         Reviewed by Eric Seidel.
992
993         Add webkit-patch roll-chromium-deps
994         https://bugs.webkit.org/show_bug.cgi?id=53288
995
996         This command updates the Source/WebKit/chromium/DEPS file with the
997         last-known good revision of Chromium (or a revision specified on the
998         command line).  I'd eventually like to turn this into a SheriffBot
999         command, but this is the first step.
1000
1001         This patch somewhat sprawled because I needed to move a bunch of code
1002         out of ChangeLog that should never have been there in the first place.
1003         Also, I had to fix a bug in MockUser in order to test the new command.
1004
1005         * Scripts/webkitpy/common/checkout/api.py:
1006         * Scripts/webkitpy/common/checkout/changelog.py:
1007         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1008         * Scripts/webkitpy/common/checkout/deps.py: Added.
1009         * Scripts/webkitpy/common/config/urls.py:
1010         * Scripts/webkitpy/tool/commands/__init__.py:
1011         * Scripts/webkitpy/tool/commands/download_unittest.py:
1012         * Scripts/webkitpy/tool/commands/roll.py: Added.
1013         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1014         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1015         * Scripts/webkitpy/tool/mocktool.py:
1016         * Scripts/webkitpy/tool/steps/__init__.py:
1017         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1018         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1019         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1020         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1021         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1022         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1023
1024 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1025
1026         Reviewed by Laszlo Gombos.
1027
1028         Get rid of prefix header dependency for WebKit2 build system
1029         https://bugs.webkit.org/show_bug.cgi?id=50174
1030
1031         Change the style checker so that it enforces config.h include for
1032         WebKit2.
1033
1034         * Scripts/webkitpy/style/checker.py:
1035
1036 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1037
1038         Reviewed by Darin Adler.
1039
1040         execCommand("Paste") doesn't work in WebKitTestRunner
1041         https://bugs.webkit.org/show_bug.cgi?id=52785
1042
1043         Enable both of the settings needed to allow paste.
1044         
1045         * WebKitTestRunner/TestController.cpp:
1046         (WTR::TestController::resetStateToConsistentValues):
1047
1048 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1049
1050         Reviewed by Andreas Kling.
1051
1052         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1053         https://bugs.webkit.org/show_bug.cgi?id=48440
1054
1055         Preserve user input when toggling use of QGraphicsView
1056
1057         * QtTestBrowser/launcherwindow.cpp:
1058         (LauncherWindow::initializeView):
1059         (LauncherWindow::loadFinished):
1060         * QtTestBrowser/launcherwindow.h:
1061         * QtTestBrowser/mainwindow.cpp:
1062         (MainWindow::addressUrl):
1063         * QtTestBrowser/mainwindow.h:
1064
1065 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1066
1067         Reviewed by Mihai Parparita.
1068
1069         new-run-webkit-tests: turn off pixel tests correctly by default
1070         for webkit-based ports. r70013 (bug 47510) used
1071         port.set_option_default() to attempt to set default values, but
1072         that didn't work correctly. I have removed set_option_default
1073         for now since it was only being used in two places and in three
1074         useless unit tests. There is a separate bug open to fix the
1075         option parsing (48095), so this workaround is fine for now.
1076
1077         https://bugs.webkit.org/show_bug.cgi?id=53217
1078
1079         * Scripts/webkitpy/layout_tests/port/webkit.py:
1080         * Scripts/webkitpy/layout_tests/port/base.py:
1081         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1082
1083 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1084
1085         Rubber-stamped by Ariya Hidayat.
1086
1087         Trivial crash fix in WTR.
1088
1089         * WebKitTestRunner/TestController.cpp:
1090         (WTR::TestController::initialize): Increase the size
1091         of the vector by one to be able to store the null character.
1092
1093 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1094
1095         Reviewed by Csaba Osztrogonác.
1096
1097         [Qt][WK2] WTR should be initialized in the same way as DRT
1098         https://bugs.webkit.org/show_bug.cgi?id=53240
1099
1100         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1101         (WTR::activateFonts): Added missing initialization steps.
1102
1103 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1104
1105         Unreviewed. 
1106
1107         Adding myself to committers.py.
1108
1109         * Scripts/webkitpy/common/config/committers.py:
1110
1111 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1112
1113         Reviewed by Csaba Osztrogonác.
1114
1115         [Qt] [Symbian] Move project files into Source
1116         https://bugs.webkit.org/show_bug.cgi?id=52891
1117
1118         Fix the Symbian build after the project files
1119         are moved to Source directory. On Symbian qmake
1120         needs to run in the same directory where the main
1121         pro files (WebKit.pro, Tools.pro) are located.
1122
1123         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1124         is located before running qmake for Symbian. Qmake on Symbian
1125         does not properly honor the "-o" option, work it around by setting
1126         the name of the Makefile to bld.inf.
1127
1128 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1129
1130         Reviewed by Andreas Kling.
1131
1132         [Qt] Add simple zooming features to MiniBrowser
1133         https://bugs.webkit.org/show_bug.cgi?id=53231
1134
1135         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1136
1137         * MiniBrowser/qt/BrowserWindow.cpp:
1138         (BrowserWindow::BrowserWindow):
1139         (BrowserWindow::zoomIn):
1140         (BrowserWindow::zoomOut):
1141         (BrowserWindow::resetZoom):
1142         (BrowserWindow::updateUserAgentList):
1143         (BrowserWindow::applyZoom):
1144         * MiniBrowser/qt/BrowserWindow.h:
1145
1146 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1147
1148         Reviewed by Dan Bernstein.
1149
1150         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1151         https://bugs.webkit.org/show_bug.cgi?id=42319
1152         
1153         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1154
1155         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1156         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1157         (WTR::LayoutTestController::showWebInspector):
1158         (WTR::LayoutTestController::closeWebInspector):
1159         (WTR::LayoutTestController::evaluateInWebInspector):
1160         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1161         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1162         * WebKitTestRunner/TestInvocation.cpp:
1163         (WTR::shouldOpenWebInspector):
1164         (WTR::TestInvocation::invoke):
1165         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1166
1167 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1168
1169         Reviewed by Xan Lopez.
1170
1171         [GTK] Pixel dumps do not include scrollbars in output images
1172         https://bugs.webkit.org/show_bug.cgi?id=53216
1173
1174         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1175         that have scrollbars.
1176
1177         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1178         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1179         instead of the web view itself.
1180
1181 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1182
1183         Reviewed by Mihai Parparita.
1184
1185         Fix regression introduced in r76322 ... new-run-webkit-tests
1186         was attempting to save the image diff output as a UTF-8-encoded
1187         file.
1188
1189         https://bugs.webkit.org/show_bug.cgi?id=53210
1190
1191         * Scripts/webkitpy/layout_tests/port/webkit.py:
1192
1193 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1194
1195         Unreviewed, rolling out r76709.
1196         http://trac.webkit.org/changeset/76709
1197         https://bugs.webkit.org/show_bug.cgi?id=53194
1198
1199         "broke python tests on non-snowleopard platforms" (Requested
1200         by dpranke on #webkit).
1201
1202         * Scripts/webkitpy/layout_tests/port/factory.py:
1203         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1204         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1205
1206 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1207
1208         Reviewed by Tony Chang.
1209
1210         new-run-webkit-tests: add a "mock DRT" port implementation
1211         and a separate class that emulates what we expect the
1212         DumpRenderTree behavior to be.
1213
1214         This will eventually replace port/dryrun.py and allow us to get
1215         better test coverage of the new-run-webkit-tests code as well as
1216         a reference for what new-run-webkit-tests expects from DRT.
1217
1218         This is the first attempt at this, and it is pretty bare-boned. It
1219         really only has been tested on the 'mac' port (and a little on
1220         the 'chromium-mac' port.
1221
1222         https://bugs.webkit.org/show_bug.cgi?id=53126
1223
1224         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1225         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1226         * Scripts/webkitpy/layout_tests/port/factory.py:
1227
1228 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1229
1230         Reviewed by Tony Chang.
1231
1232         Add '--no-timeout' option to Chromium DRT to ease debugging.
1233         https://bugs.webkit.org/show_bug.cgi?id=52873
1234
1235         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1236         (main):
1237
1238 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1239
1240         Reviewed by Andreas Kling.
1241
1242         [Qt] Fix qt_minimal build
1243         https://bugs.webkit.org/show_bug.cgi?id=53172
1244
1245         * QtTestBrowser/locationedit.h:
1246
1247 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1248
1249         Reviewed by Antonio Gomes.
1250
1251         QtTestBrowser should have a UI Setting to disable plugins
1252         https://bugs.webkit.org/show_bug.cgi?id=52408
1253         
1254         Added a new action item named "Disable Plugins"
1255         under the "Settings" menu. 
1256
1257         * QtTestBrowser/launcherwindow.cpp:
1258         (LauncherWindow::createChrome):
1259         (LauncherWindow::togglePlugins):
1260         * QtTestBrowser/launcherwindow.h:
1261
1262 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1263
1264         Reviewed by Adam Barth.
1265
1266         Move main CMakeLists.txt into Source directory
1267         https://bugs.webkit.org/show_bug.cgi?id=52888
1268
1269         * Scripts/webkitdirs.pm:
1270
1271 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1272
1273         Reviewed by Eric Seidel.
1274
1275         Improve label text in submit-to-ews
1276         https://bugs.webkit.org/show_bug.cgi?id=53130
1277
1278         * QueueStatusServer/templates/submittoews.html:
1279
1280 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1281
1282         Reviewed by Antonio Gomes.
1283
1284         QtTestBrowser should have a UI Settings to prevent loading images
1285         https://bugs.webkit.org/show_bug.cgi?id=52409
1286         
1287         Added a new action item named "DisableAutoLoadImages"
1288         under the "Settings" menu 
1289
1290         * QtTestBrowser/launcherwindow.cpp:
1291         (LauncherWindow::createChrome):
1292         (LauncherWindow::toggleAutoLoadImages):
1293         * QtTestBrowser/launcherwindow.h:
1294
1295 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1296
1297         Reviewed by Tony Chang.
1298
1299         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1300         classes, test_expectations.py. This change adds "test-win" and
1301         "test-mac" variants to the test port so that we can better test
1302         rebaselining, and adds a MockUser() object for reuse in testing.
1303
1304         https://bugs.webkit.org/show_bug.cgi?id=53036
1305
1306         * Scripts/webkitpy/common/system/filesystem.py:
1307         * Scripts/webkitpy/common/system/filesystem_mock.py:
1308         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1309         * Scripts/webkitpy/layout_tests/port/factory.py:
1310         * Scripts/webkitpy/layout_tests/port/base.py:
1311         * Scripts/webkitpy/layout_tests/port/test.py:
1312         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1313         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1314         * Scripts/webkitpy/tool/mocktool.py:
1315
1316 2011-01-25  Tony Chang  <tony@chromium.org>
1317
1318         Reviewed by Dimitri Glazkov.
1319
1320         [chromium] remove unused layoutTestController callback
1321         https://bugs.webkit.org/show_bug.cgi?id=53103
1322
1323         This method is used by a test_shell_test, but not needed by DRT.
1324
1325         * DumpRenderTree/chromium/LayoutTestController.cpp:
1326         (LayoutTestController::LayoutTestController):
1327         * DumpRenderTree/chromium/LayoutTestController.h:
1328
1329 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1330
1331         Reviewed by Andreas Kling.
1332
1333         [GTK] Remove 64 bits release bot from the buildbot master
1334         https://bugs.webkit.org/show_bug.cgi?id=52899
1335
1336         Removes the 64 bits release slave from the buildbot configuration,
1337         so that we can use it as an EWS.
1338
1339         * BuildSlaveSupport/build.webkit.org-config/config.json:
1340
1341 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1342
1343         Reviewed by Dan Bernstein.
1344
1345         Implement database quota callback to fix storage tests on WebKit2 bot
1346         https://bugs.webkit.org/show_bug.cgi?id=53064
1347
1348         * WebKitTestRunner/TestController.cpp:
1349         (WTR::exceededDatabaseQuota):
1350         (WTR::TestController::createOtherPage):
1351         (WTR::TestController::initialize):
1352
1353 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1354
1355         Reviewed by Anders Carlsson.
1356
1357         Use designated temp directory for the database for WebKit2
1358         https://bugs.webkit.org/show_bug.cgi?id=53052
1359         
1360         Adopt the new WK2 API for this.
1361
1362         * WebKitTestRunner/TestController.cpp:
1363         (WTR::TestController::libraryPathForTesting):
1364         (WTR::TestController::initialize):
1365         * WebKitTestRunner/TestController.h:
1366         * WebKitTestRunner/mac/TestControllerMac.mm:
1367         (WTR::TestController::platformLibraryPathForTesting):
1368         * WebKitTestRunner/qt/TestControllerQt.cpp:
1369         (WTR::TestController::platformLibraryPathForTesting):
1370         * WebKitTestRunner/win/TestControllerWin.cpp:
1371         (WTR::TestController::platformLibraryPathForTesting):
1372
1373 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1374
1375         Reviewed by Stephanie Lewis.
1376
1377         Add a new Leopard test bot.
1378
1379         * BuildSlaveSupport/build.webkit.org-config/config.json:
1380
1381 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1382
1383         Reviewed by Adam Barth.
1384
1385         Add EFL Builder to core waterfall
1386         https://bugs.webkit.org/show_bug.cgi?id=52704
1387
1388         Add EFL Builder to the core waterfall again.
1389
1390         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1391         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1392
1393 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1394
1395         Reviewed by Tony Chang.
1396
1397         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1398         https://bugs.webkit.org/show_bug.cgi?id=52872
1399
1400         Force disabling proxy to resolve the problem.
1401
1402         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1403         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1404
1405 2011-01-24  Andreas Kling  <kling@webkit.org>
1406
1407         Reviewed by Darin Adler.
1408
1409         check-webkit-style: Update exemptions following Source/ move.
1410         https://bugs.webkit.org/show_bug.cgi?id=53017
1411
1412         * Scripts/webkitpy/style/checker.py:
1413         * Scripts/webkitpy/style/checker_unittest.py:
1414
1415 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1416
1417         Rubber-stamped by Csaba Osztrogonác.
1418
1419         [Qt] Move project files into Source
1420         https://bugs.webkit.org/show_bug.cgi?id=52891
1421
1422         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1423
1424 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1425
1426         Reviewed by Yury Semikhatsky.
1427
1428         Web Inspector: Find duplicate strings in localizedStrings.js
1429
1430         https://bugs.webkit.org/show_bug.cgi?id=53005
1431
1432         * Scripts/check-inspector-strings:
1433
1434 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1435
1436         Reviewed by Andreas Kling.
1437
1438         [Qt] Regroup MiniBrowser's menubar and add open file action
1439         https://bugs.webkit.org/show_bug.cgi?id=53000
1440
1441         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1442
1443         * MiniBrowser/qt/BrowserWindow.cpp:
1444         (BrowserWindow::BrowserWindow):
1445         (BrowserWindow::openFile):
1446         (BrowserWindow::~BrowserWindow):
1447         * MiniBrowser/qt/BrowserWindow.h:
1448
1449 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1450
1451         Unreviewed fix after r76496
1452
1453         [Qt] Move project files into Source
1454         https://bugs.webkit.org/show_bug.cgi?id=52891
1455
1456         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1457         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1458         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1459
1460 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1461
1462         Reviewed by Csaba Osztrogonác.
1463
1464         [Qt] Move project files into Source
1465         https://bugs.webkit.org/show_bug.cgi?id=52891
1466
1467         * DerivedSources.pro: Renamed from DerivedSources.pro.
1468         * DumpRenderTree/qt/DumpRenderTree.pro:
1469         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1470         * MiniBrowser/DerivedSources.pro:
1471         * MiniBrowser/qt/MiniBrowser.pro:
1472         * QtTestBrowser/QtTestBrowser.pro:
1473         * Scripts/webkitdirs.pm:
1474         * Tools.pro: Added.
1475         * WebKitTestRunner/DerivedSources.pro:
1476         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1477         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1478
1479 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1480
1481         Reviewed by Dan Bernstein.
1482
1483         Beefed up --threaded mode to catch even more kinds of errors.
1484         https://bugs.webkit.org/show_bug.cgi?id=52971
1485
1486         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1487         context group to force JSC to mark multiple threads. (This used to be
1488         the default, but it changed in SnowLeopard.)
1489         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1490         to give threading mistakes more chances to show themselves.
1491         (startJavaScriptThreads):
1492         (stopJavaScriptThreads):
1493
1494 2011-01-22  Robert Hogan  <robert@webkit.org>
1495
1496         Reviewed by Andreas Kling.
1497
1498         [Qt] Support layoutTestController.addURLToRedirect()
1499         https://bugs.webkit.org/show_bug.cgi?id=52956
1500
1501         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1502         (LayoutTestController::addURLToRedirect):
1503         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1504
1505 2011-01-22  Robert Hogan  <robert@webkit.org>
1506
1507         Reviewed by Kenneth Rohde Christiansen.
1508
1509         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1510         https://bugs.webkit.org/show_bug.cgi?id=49802
1511
1512         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1513         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1514         (WebCore::DumpRenderTree::open):
1515
1516 2011-01-21  Adam Barth  <abarth@webkit.org>
1517
1518         Reviewed by Maciej Stachowiak.
1519
1520         Disable mac_unittest.py that fails on some of the Mac bots
1521         https://bugs.webkit.org/show_bug.cgi?id=52947
1522
1523         As noted in the comment, this test does not appear to be correct
1524         because the function this test is testing returns different results
1525         depending on which flavor of Mac the test is run on.  This patch
1526         disable the test.  Hopefully we can re-enable the test once we've
1527         probably insulated the test from its environment.
1528
1529         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1530
1531 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1532
1533         Reviewed by Mihai Parparita.
1534
1535         Fix bug introduced in r76322 that caused NRWT to not actually
1536         read the Skipped files properly.
1537
1538         https://bugs.webkit.org/show_bug.cgi?id=52771
1539
1540         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1541         * Scripts/webkitpy/layout_tests/port/webkit.py:
1542         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1543
1544 2011-01-21  Sam Weinig  <sam@webkit.org>
1545
1546         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1547
1548         WebKitTestRunner needs the HOME environment variable to be set.
1549         <rdar://problem/8896573>
1550
1551         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1552         it exists.
1553
1554 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1555
1556         Reviewed by Eric Seidel.
1557
1558         Suppress a few remaining integration tests so that none of the
1559         layout_test unit tests ever read from the filesystem or launch
1560         subprocesses that aren't part of the unit tests.
1561
1562         Also fix a minor bug in the printing unit tests that was
1563         incorrectly relying on sys.argv.
1564
1565         https://bugs.webkit.org/show_bug.cgi?id=52863
1566
1567         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1568         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1569         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1570
1571 2011-01-21  Darin Adler  <darin@apple.com>
1572
1573        Fix Mac build.
1574
1575         * MiniBrowser/mac/BrowserWindowController.m:
1576         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1577
1578 2011-01-20  Darin Adler  <darin@apple.com>
1579
1580         Reviewed by Dan Bernstein.
1581
1582         WebKit2: Implement showModalDialog
1583         https://bugs.webkit.org/show_bug.cgi?id=52855
1584
1585         This fixes WebKitTestRunner to compile, but more work is probably
1586         needed to get it to pass the tests.
1587
1588         * WebKitTestRunner/TestController.cpp:
1589         (WTR::TestController::runModal): Added. Calls through to the
1590         platform-specific version of runModal.
1591         (WTR::TestController::createOtherPage): Changed to be a private
1592         static member function so it can refer to runModal, which is
1593         a private static member function.
1594         (WTR::TestController::initialize): Pass 0 for the runModal
1595         function since we don't need to run the main window modal.
1596         I suspect this is wrong and will need to change.
1597         * WebKitTestRunner/TestController.h: Added declarations for
1598         the functions added above.
1599         * WebKitTestRunner/mac/TestControllerMac.mm:
1600         (WTR::TestController::runModal): Added. Untested implementation.
1601         * WebKitTestRunner/qt/TestControllerQt.cpp:
1602         (WTR::TestController::runModal): Added.
1603         * WebKitTestRunner/win/TestControllerWin.cpp:
1604         (WTR::TestController::runModal): Added.
1605
1606 2011-01-21  Eric Seidel  <eric@webkit.org>
1607
1608         Reviewed by Adam Barth.
1609
1610         Split Host object off from WebKitPatch for easier re-use
1611         https://bugs.webkit.org/show_bug.cgi?id=52284
1612
1613         new-run-webkit-tests and other tools are eventually going to want one of these.
1614         Basically you need to inherit from this class if you want to pretend to be a
1615         self.tool object for Steps/Commands.
1616
1617         * Scripts/webkitpy/common/host.py: Added.
1618         * Scripts/webkitpy/tool/main.py:
1619
1620 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1621
1622         Reviewed by Adam Barth.
1623
1624         Disable the tests that start and stop the http server and web
1625         server, so that we don't have to worry about port collisions on
1626         the bots.
1627
1628         https://bugs.webkit.org/show_bug.cgi?id=52861
1629
1630         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1631
1632 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1633
1634         Reviewed by Eric Seidel.
1635
1636         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1637         
1638         https://bugs.webkit.org/show_bug.cgi?id=52772
1639         
1640         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1641
1642 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1643
1644         Reviewed by Eric Siedel.
1645
1646         nrwt: clean up almost all remaining port references, remove
1647         unnecessary import clauses. The only remaining references are
1648         in places where a mock filesystem makes no sense or can't be
1649         used, and in one routine in port/google_chrome_unittest that
1650         I'll rewrite in a separate patch.
1651
1652         https://bugs.webkit.org/show_bug.cgi?id=52771
1653
1654         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1655         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1656         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1657         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1658         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1659         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1660         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1661         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1662         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1663         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1664         * Scripts/webkitpy/layout_tests/port/gtk.py:
1665         * Scripts/webkitpy/layout_tests/port/mac.py:
1666         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1667         * Scripts/webkitpy/layout_tests/port/qt.py:
1668         * Scripts/webkitpy/layout_tests/port/webkit.py:
1669         * Scripts/webkitpy/layout_tests/port/win.py:
1670         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1671
1672 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1673
1674         Reviewed by Mihai Parparita.
1675
1676         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1677
1678         https://bugs.webkit.org/show_bug.cgi?id=52762
1679
1680         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1681         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1682
1683 2011-01-20  Tony Chang  <tony@chromium.org>
1684
1685         Reviewed by Ojan Vafai.
1686
1687         [chromium] fix the paths used for the rebaseline tool
1688         https://bugs.webkit.org/show_bug.cgi?id=52857
1689
1690         Some of the bots were renamed so the path to grab the results zip
1691         file has changed.
1692
1693         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1694
1695 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1696
1697         Reviewed by Tony Chang.
1698
1699         Fix bug introduced in r72688 / bug 52768 that broke the
1700         generation of the output filename links in the results.html
1701         output. Apparently none of the unit tests actually checked to
1702         make sure the generated links were correct :(
1703
1704         https://bugs.webkit.org/show_bug.cgi?id=52854
1705
1706         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1707         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1708
1709 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1710
1711         Reviewed by Darin Adler.
1712
1713         https://bugs.webkit.org/show_bug.cgi?id=52849
1714         Make window.print work with WebKit2
1715
1716         * MiniBrowser/mac/BrowserWindowController.m:
1717         (-[BrowserWindowController awakeFromNib]):
1718         * WebKitTestRunner/TestController.cpp:
1719         (WTR::createOtherPage):
1720         (WTR::TestController::initialize):
1721         Added zeroes to WKPageUIClient structures to avoid build failures.
1722
1723 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1724
1725         Reviewed by Eric Seidel.
1726
1727         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1728
1729         https://bugs.webkit.org/show_bug.cgi?id=52756
1730
1731         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1732         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1733         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1734         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1735         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1736         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1737
1738 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1739
1740         Reviewed by Antonio Gomes.
1741
1742         QtTestBrowser should have a seperate menu for Settings
1743         https://bugs.webkit.org/show_bug.cgi?id=52817
1744         
1745         Added a new menu item named "Settings"
1746         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1747
1748         * QtTestBrowser/launcherwindow.cpp:
1749         (LauncherWindow::createChrome):
1750
1751 2011-01-20  Sam Weinig  <sam@webkit.org>
1752
1753         Reviewed by John Sullivan.
1754
1755         Update update-webkit-localizable-strings with new path to WebKit.
1756
1757         * Scripts/update-webkit-localizable-strings:
1758
1759 2011-01-20  James Robinson  <jamesr@chromium.org>
1760
1761         Reviewed by Darin Fisher.
1762
1763         Implement mozilla's requestAnimationFrame API
1764         https://bugs.webkit.org/show_bug.cgi?id=51218
1765
1766         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1767
1768         * DumpRenderTree/chromium/WebViewHost.cpp:
1769         (invokeScheduleComposite):
1770         (WebViewHost::scheduleAnimation):
1771         (WebViewHost::paintInvalidatedRegion):
1772         * DumpRenderTree/chromium/WebViewHost.h:
1773
1774 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1775
1776         Reviewed by Adam Roben.
1777
1778         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1779         https://bugs.webkit.org/show_bug.cgi?id=42327
1780
1781         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1782         for methods that take their normal arguments but also a JSContextRef.
1783         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1784         for evaluateScriptInIsolatedWorld.
1785         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1786         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1787         this call is for an isolated world.
1788         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1789         (WTR::worldMap): Helper to create a world map.
1790         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1791         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1792         added LayoutTestController API.
1793         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1794
1795 2011-01-19  Adam Roben  <aroben@apple.com>
1796
1797         Convert paths in environment variables back to msys-style inside commit-log-editor
1798
1799         When this script gets run from inside git commit, msys-style paths in the environment will
1800         have been turned into Windows-style paths with forward slashes. This screws up functions
1801         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1802         the paths back to msys-style before doing anything else.
1803
1804         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1805         using msysgit's Perl and multiple ChangeLogs have been edited
1806
1807         Reviewed by David Kilzer.
1808
1809         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1810         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1811         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1812
1813 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1814
1815         [Win] Unreviewed build fix after r76248.
1816
1817         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1818
1819 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1820
1821         Reviewed by Csaba Osztrogonác.
1822
1823         Refactoring of the custom allocation framework
1824         https://bugs.webkit.org/show_bug.cgi?id=49897
1825
1826         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1827         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1828         equivalent macro implementation at the necessary places.
1829 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1830
1831         Unreviewed. 
1832
1833         Adding myself to committers.py.
1834
1835         * Scripts/webkitpy/common/config/committers.py:
1836
1837 2011-01-20  Adam Barth  <abarth@webkit.org>
1838
1839         Reviewed by Tony Chang.
1840
1841         Chromium builders don't delete unversioned directories when DEPS change
1842         https://bugs.webkit.org/show_bug.cgi?id=52745
1843
1844         If we pass this option to gclient sync, gclient will delete directories
1845         that are no longer part of DEPS instead of leaving them around to
1846         confuse us later.  Apparently, the downstream buildbots use this option
1847         already.
1848
1849         * Scripts/update-webkit-chromium:
1850
1851 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1852
1853         Unreviewed, build fix - I pulled this patch in to fix an issue
1854         revealed by r76195 running on some new bots). Also fix a couple
1855         of other issues revealed in testing.
1856
1857         nrwt: remove fs refs from layout_package/json*
1858
1859         https://bugs.webkit.org/show_bug.cgi?id=52754
1860
1861         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1862         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1863         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1864         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1865         * Scripts/webkitpy/layout_tests/port/base.py:
1866
1867 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1868
1869         Unreviewed, build fix.
1870
1871         Fix a couple of minor bugs discovered while bringing up new bots
1872         for testing.
1873
1874         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1875         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1876
1877 2011-01-19  James Robinson  <jamesr@chromium.org>
1878
1879         Unreviewed, rolling out r76194.
1880         http://trac.webkit.org/changeset/76194
1881         https://bugs.webkit.org/show_bug.cgi?id=51218
1882
1883         Caused mysterious compile failure on the chromium win
1884         build.webkit.org bots
1885
1886         * DumpRenderTree/chromium/WebViewHost.cpp:
1887         (WebViewHost::paintInvalidatedRegion):
1888         * DumpRenderTree/chromium/WebViewHost.h:
1889
1890 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1891
1892         Reviewed by Mihai Parparita.
1893
1894         remove fs refs from test_runner, dump_render_tree_thread
1895
1896         https://bugs.webkit.org/show_bug.cgi?id=52753
1897
1898         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1899         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1900         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1901         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1902
1903 2011-01-19  James Robinson  <jamesr@chromium.org>
1904
1905         Reviewed by Darin Fisher.
1906
1907         Implement mozilla's requestAnimationFrame API
1908         https://bugs.webkit.org/show_bug.cgi?id=51218
1909
1910         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1911
1912         * DumpRenderTree/chromium/WebViewHost.cpp:
1913         (invokeScheduleComposite):
1914         (WebViewHost::scheduleAnimation):
1915         (WebViewHost::paintInvalidatedRegion):
1916         * DumpRenderTree/chromium/WebViewHost.h:
1917
1918 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1919
1920         Unreviewed, build fix.
1921
1922         Fix a few incorrect "self._filesystem" references introduced in
1923         r76184.
1924
1925         * Scripts/webkitpy/layout_tests/port/chromium.py:
1926         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1927
1928 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1929
1930         Reviewed by Mihai Parparita.
1931
1932         add a .sep property, abspath(), isabs(), mtime(), and
1933         open_text_file_for_writing() to filesystem modules. Some of
1934         these properties are not needed in this patch but will be needed
1935         in subsequent patches (I'm doing this to avoid having to track
1936         multiple versions of a single file).
1937
1938         Also, change most of the port/* modules to use the filesystem
1939         objects instead of referencing the filesystem directly.
1940
1941         https://bugs.webkit.org/show_bug.cgi?id=52748
1942
1943         * Scripts/webkitpy/common/system/filesystem.py:
1944         * Scripts/webkitpy/common/system/filesystem_mock.py:
1945         * Scripts/webkitpy/layout_tests/port/__init__.py:
1946         * Scripts/webkitpy/layout_tests/port/base.py:
1947         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1948         * Scripts/webkitpy/layout_tests/port/chromium.py:
1949         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1950         * Scripts/webkitpy/layout_tests/port/config.py:
1951         * Scripts/webkitpy/layout_tests/port/test.py:
1952         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1953
1954 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1955
1956         Reviewed by Anders Carlsson.
1957
1958         If resetting between tests times out, treat it as a WebProcess crash
1959         https://bugs.webkit.org/show_bug.cgi?id=52757
1960
1961         * WebKitTestRunner/TestController.cpp:
1962         (WTR::TestController::runTest):
1963
1964 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1965
1966         Reviewed by Darin Adler.
1967
1968         https://bugs.webkit.org/show_bug.cgi?id=52739
1969         Make it possible for a WebKit2 client to print headers and footers
1970
1971         Added dummy implementations for new printing UIClient calls.
1972
1973         * MiniBrowser/mac/BrowserWindowController.m:
1974         (-[BrowserWindowController awakeFromNib]):
1975         * WebKitTestRunner/TestController.cpp:
1976         (WTR::createOtherPage):
1977         (WTR::TestController::initialize):
1978
1979 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1980
1981         Reviewed by Ojan Vafai.
1982
1983         Change webkitpy/layout_tests/port/test.py to use the
1984         in-memory filesystem for cleaner unit testing. This
1985         change allows us to kill a lot of code that was
1986         specific to the test port, at the cost of being a
1987         little less clear about how things would work if
1988         you didn't have a filesystem.
1989
1990         https://bugs.webkit.org/show_bug.cgi?id=52605
1991
1992         * Scripts/webkitpy/layout_tests/port/test.py:
1993
1994 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1995
1996         Unreviewed, build fix.
1997
1998         Fix test failure caused by committing attachment 79368 instead
1999         of attachment 79461 on bug 52604.
2000
2001         * Scripts/webkitpy/common/system/filesystem_mock.py:
2002
2003 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2004
2005         Reviewed by Mihai Parparita.
2006
2007         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2008         unit testing. os.walk() is too much of a hassle to implement on
2009         top of the in-memory mock filesystem and adding the necessary
2010         interface to files_under() gives clients a cleaner API anyway
2011         (for this particular usage model).
2012
2013         https://bugs.webkit.org/show_bug.cgi?id=52691
2014
2015         * Scripts/webkitpy/common/system/filesystem.py:
2016         * Scripts/webkitpy/common/system/filesystem_mock.py:
2017         * Scripts/webkitpy/layout_tests/port/test_files.py:
2018         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2019
2020 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2021
2022         Reviewed by Tony Chang.
2023
2024         Change more modules in the layout-tests code to use the
2025         filesystem wrapper for cleaner unit testing.
2026
2027         This patch also adds the glob() wrapper to the filesystem
2028         abstraction.
2029         
2030         https://bugs.webkit.org/show_bug.cgi?id=52604
2031
2032         * Scripts/webkitpy/layout_tests/port/test_files.py:
2033         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2034         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2035         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2036         * Scripts/webkitpy/common/system/filesystem.py:
2037         * Scripts/webkitpy/common/system/filesystem_mock.py:
2038
2039 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2040
2041         Unreviewed.
2042
2043         Updating my email addresses and irc nick.
2044
2045         * Scripts/webkitpy/common/config/committers.py:
2046
2047 2011-01-19  Tony Chang  <tony@chromium.org>
2048
2049         Reviewed by Mihai Parparita.
2050
2051         [chromium] [linux] if check-sys-deps fails, output the failure reason
2052         https://bugs.webkit.org/show_bug.cgi?id=52671
2053
2054         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2055             error handler functions.
2056         * Scripts/webkitpy/layout_tests/port/chromium.py:
2057             output the error text from --check-sys-deps
2058         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2059
2060 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2061
2062         Reviewed by Andreas Kling.
2063
2064         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2065         https://bugs.webkit.org/show_bug.cgi?id=52554
2066         
2067         QtNetworkAccessManager is created in a thread and set as
2068         member variable in QWebPage. When the thread is destroyed
2069         the object is still used. So fix will set the object to
2070         NULL once the thread is destroyed.
2071
2072         * QtTestBrowser/launcherwindow.cpp:
2073         (LauncherWindow::~LauncherWindow):
2074
2075 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2076
2077         Rubber stamped by Csaba Osztrogonac
2078
2079         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2080
2081 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2082
2083         Reviewed by Tony Chang.
2084
2085         new-run-webkit-tests: add a --build-directory command line argument
2086
2087         Official Google Chrome builds use a non-standard build directory
2088         location. This patch adds a --build-directory argument that
2089         allows that location to be specified on the command line. Only
2090         Chromium-based builds will use this flag for now, but anyone can
2091         in the future.
2092
2093         There are no unit tests for this since it's difficult to test
2094         until mock filesystems are fully supported in the code. This was
2095         tested by hand for now.
2096
2097         https://bugs.webkit.org/show_bug.cgi?id=52694
2098
2099         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2100         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2101         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2102         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2103
2104 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2105
2106         Not reviewed. Bot fix.
2107
2108         Remove an inadvertently committed debugging print.
2109
2110         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2111         (LayoutTestController::notifyDone):
2112
2113 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2114
2115         Reviewed by Sam Weinig.
2116
2117         WebKitTestRunner should track loading more like DumpRenderTree
2118         https://bugs.webkit.org/show_bug.cgi?id=52692
2119
2120         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2121         This makes some tests that call notifyDone multiple times pass.
2122         
2123         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2124         (WTR::InjectedBundle::InjectedBundle):
2125         (WTR::InjectedBundle::done):
2126         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2127         (WTR::InjectedBundle::topLoadingFrame):
2128         (WTR::InjectedBundle::setTopLoadingFrame):
2129         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2130         (WTR::InjectedBundlePage::InjectedBundlePage):
2131         (WTR::InjectedBundlePage::stopLoading):
2132         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2133         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2134         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2135         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2136         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2137         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2138         (WTR::LayoutTestController::notifyDone):
2139         * WebKitTestRunner/TestController.cpp:
2140         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2141
2142 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2143
2144         Reviewed by Kent Tamura.
2145
2146         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2147         https://bugs.webkit.org/show_bug.cgi?id=52678
2148         
2149         Update path now that WebKit is inside Source.
2150
2151         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2152
2153 2011-01-18  Robert Hogan  <robert@webkit.org>
2154
2155         Reviewed by Simon Hausmann.
2156
2157         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2158         https://bugs.webkit.org/show_bug.cgi?id=44282
2159
2160         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2161         (WebCore::DumpRenderTree::dump):
2162
2163 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2164
2165         Reviewed by Mihai Parparita.
2166
2167         Fix a small race condition that could cause the unit tests for
2168         new-run-webkit-tests to fail in a multithreaded environment.
2169         There was a small window in the code where one thread would
2170         check to see if a thread had raised an exception, do something,
2171         and then check to see if the thread was alive. If the other
2172         thread raised an exception and exited in between these two
2173         steps, the exception would be lost. Flipping the order of the
2174         two checks fixes the race, since we will now always check for an
2175         exception on the thread before exiting.
2176
2177         https://bugs.webkit.org/show_bug.cgi?id=51579
2178
2179         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2180
2181 2011-01-18  Eric Seidel  <eric@webkit.org>
2182
2183         Reviewed by Adam Barth.
2184
2185         commit-queue dies when test archiving fails
2186         https://bugs.webkit.org/show_bug.cgi?id=52617
2187
2188         I looked at the machine and it had 10 archives already
2189         thus find_unused_name was returning None.  I've upped
2190         the limit to 100 (per bug) and tested the case where
2191         find_unused_name returns None (making archive return None).
2192
2193         * Scripts/webkitpy/common/system/workspace.py:
2194         * Scripts/webkitpy/common/system/workspace_unittest.py:
2195         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2196         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2197         * Scripts/webkitpy/tool/commands/queues.py:
2198
2199 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2200
2201         Reviewed by Ojan Vafai.
2202
2203         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2204         filesystem. Also fix a couple of "with" statements missed by
2205         r76050.
2206
2207         https://bugs.webkit.org/show_bug.cgi?id=52487
2208
2209         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2210
2211 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2212
2213         Reviewed by Martin Robinson.
2214
2215         [Gtk] Build fixes for gtk3 build
2216         https://bugs.webkit.org/show_bug.cgi?id=52648
2217
2218         * DumpRenderTree/gtk/EventSender.cpp:
2219         (beginDragWithFilesCallback):
2220
2221 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2222
2223         Reviewed by Mihai Parparita.
2224
2225         Update rebaseline-chromium-webkit-tests to use filesystem objects
2226         instead of direct references to os.path, shutil, tempfile, etc.
2227
2228         This patch doesn't change anything, but will allow subsequent
2229         patches to change the unit tests to no longer use the real
2230         filesystem.
2231
2232         This patch adds a bunch more methods to the filesystem object as
2233         well.
2234
2235         https://bugs.webkit.org/show_bug.cgi?id=52482
2236
2237         * Scripts/webkitpy/common/system/filesystem.py:
2238         * Scripts/webkitpy/common/system/filesystem_mock.py:
2239         * Scripts/webkitpy/tool/commands/queues.py:
2240         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2241         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2242
2243 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2244
2245         Reviewed by Mihai Parparita.
2246
2247         new-run-webkit-tests shouldn't crash when you try to run a
2248         directory containing only skipped files.
2249
2250         https://bugs.webkit.org/show_bug.cgi?id=52478
2251         
2252         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2253         * Scripts/webkitpy/layout_tests/port/test.py:
2254         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2255
2256 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2257
2258         Reviewed by Gustavo Noronha Silva.
2259
2260         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2261         https://bugs.webkit.org/show_bug.cgi?id=40833
2262
2263         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2264         GTK+ event sender.
2265         (dragWithFilesDragDataGetCallback): Added.
2266         (dragWithFilesDragEndCallback): Added.
2267         (beginDragWithFilesCallback): Added.
2268
2269 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2270
2271         Reviewed by Adam Barth.
2272
2273         ews: Add additional watcher to efl ews
2274         https://bugs.webkit.org/show_bug.cgi?id=52613
2275
2276         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2277
2278         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2279
2280 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2281
2282         Reviewed by Alexey Proskuryakov.
2283
2284         Fix some headers with missing or misspelled #ifndef guards
2285         https://bugs.webkit.org/show_bug.cgi?id=52545
2286
2287         * DumpRenderTree/chromium/TestEventPrinter.h:
2288         * DumpRenderTree/chromium/WebPreferences.h:
2289
2290 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2291
2292         Reviewed by Anders Carlsson.
2293
2294         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2295         navigating back to an unreachable URL
2296         https://bugs.webkit.org/show_bug.cgi?id=52388
2297
2298         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2299
2300         * DumpRenderTree/LayoutTestController.cpp:
2301         (queueLoadHTMLStringCallback):
2302         (LayoutTestController::queueLoadHTMLString):
2303         (LayoutTestController::queueLoadAlternateHTMLString):
2304         * DumpRenderTree/LayoutTestController.h:
2305
2306         * DumpRenderTree/WorkQueueItem.h:
2307         (LoadHTMLStringItem::LoadHTMLStringItem):
2308
2309         * DumpRenderTree/chromium/LayoutTestController.cpp:
2310         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2311         (WorkItemLoadHTMLString::run):
2312         (LayoutTestController::queueLoadHTMLString):
2313
2314         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2315         (LoadHTMLStringItem::invoke):
2316         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2317         (LoadHTMLStringItem::invoke):
2318         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2319         (LoadHTMLStringItem::invoke):
2320
2321 2011-01-17  Dan Bernstein  <mitz@apple.com>
2322
2323         Rubber-stamped by Mark Rowe.
2324
2325         Update xcodeproj svn:ignore to include xcuserdata.
2326
2327         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2328         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2329         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2330         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2331         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2332
2333 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2334
2335         Unreviewed fix after r75908.
2336
2337         Move WebKit into Source
2338         https://bugs.webkit.org/show_bug.cgi?id=52530
2339
2340         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2341
2342 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2343
2344         Unreviewed.
2345
2346         Remove accidentally committed debug printing after r75908.
2347
2348         * Scripts/webkitdirs.pm:
2349
2350 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2351
2352         Unreviewed.
2353
2354         Add myself to committers list
2355         https://bugs.webkit.org/show_bug.cgi?id=52566
2356
2357         * Scripts/webkitpy/common/config/committers.py:
2358
2359 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2360
2361         Reviewed by Jeremy Orlow.
2362
2363         GeolocationController should call stopUpdating on destruction
2364         https://bugs.webkit.org/show_bug.cgi?id=52216
2365
2366         fast/dom/Geolocation/window-close-crash.html requires that a
2367         Geolocation watch be started in a secondary window. Consequently,
2368         we need to allow geolocation permission and provide a mock
2369         geolocation position for the secondary window's
2370         GeolocationClientMock.
2371
2372         * DumpRenderTree/chromium/LayoutTestController.cpp:
2373         (LayoutTestController::setGeolocationPermission):
2374         (LayoutTestController::setMockGeolocationPosition):
2375         (LayoutTestController::setMockGeolocationError):
2376         * DumpRenderTree/chromium/TestShell.h:
2377         (TestShell::windowList):
2378
2379 2011-01-16  Adam Barth  <abarth@webkit.org>
2380
2381         Update more include paths to reflect WebKit move.
2382
2383         * DumpRenderTree/chromium/EventSender.cpp:
2384         (EventSender::keyDown):
2385         (EventSender::needsShiftModifier):
2386         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2387         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2388
2389 2011-01-16  Kent Tamura  <tkent@chromium.org>
2390
2391         Unreviewed, Chromium build fix.
2392
2393         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2394
2395 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2396
2397         Build fix for GTK+ after source directory movement.
2398
2399         * GNUmakefile.am: Correct include paths.
2400
2401 2011-01-16  Adam Barth  <abarth@webkit.org>
2402
2403         Teach svn-apply about WebKit move.
2404
2405         * Scripts/VCSUtils.pm:
2406
2407 2011-01-16  Adam Barth  <abarth@webkit.org>
2408
2409         Rubber-stamped by Eric Seidel.
2410
2411         Move WebKit into Source
2412         https://bugs.webkit.org/show_bug.cgi?id=52530
2413
2414         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2415         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2416         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2417         * DumpRenderTree/qt/GCControllerQt.cpp:
2418         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2419         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2420         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2421         * DumpRenderTree/wscript:
2422         * QtTestBrowser/launcherwindow.h:
2423         * Scripts/build-webkit:
2424         * Scripts/webkitdirs.pm:
2425
2426 2011-01-15  Adam Barth  <abarth@webkit.org>
2427
2428         Teach svn-apply about WebKit2 move.
2429
2430         * Scripts/VCSUtils.pm:
2431
2432 2011-01-15  Adam Barth  <abarth@webkit.org>
2433
2434         Rubber-stamped by Eric Seidel.
2435
2436         Move WebKit2 into Source
2437         https://bugs.webkit.org/show_bug.cgi?id=52438
2438
2439         * MiniBrowser/qt/MiniBrowser.pro:
2440         * Scripts/build-webkit:
2441         * Scripts/do-file-rename:
2442         * Scripts/do-webcore-rename:
2443         * Scripts/test-webkitpy:
2444         * Scripts/webkitdirs.pm:
2445         * Scripts/webkitpy/style/checker.py:
2446         * WebKitTestRunner/DerivedSources.pro:
2447         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2448         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2449
2450 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2451
2452         Reviewed by David Levin.
2453
2454         [chromium] remove obsolete createView method
2455         https://bugs.webkit.org/show_bug.cgi?id=52437
2456
2457         * DumpRenderTree/chromium/WebViewHost.cpp:
2458         (WebViewHost::createView):
2459         * DumpRenderTree/chromium/WebViewHost.h:
2460
2461 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2462
2463         Reviewed by Geoff Garen.
2464
2465         ShouldLoadResourceForFrame should use strings, not URLs.
2466         https://bugs.webkit.org/show_bug.cgi?id=52476
2467
2468         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2469         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2470         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2471
2472 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2473
2474         Reviewed by David Levin.
2475
2476         Add Tony Gentilcore as a reviewer
2477         https://bugs.webkit.org/show_bug.cgi?id=52480
2478
2479         * Scripts/webkitpy/common/config/committers.py:
2480
2481 2011-01-14  David Levin  <levin@chromium.org>
2482
2483         Reviewed by Eric Seidel.
2484
2485         check-webkit-style: _FunctionState should keep track of where the function name starts.
2486         https://bugs.webkit.org/show_bug.cgi?id=52454
2487
2488         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2489         _FunctionState and logic for setting it correctly.
2490         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2491
2492 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2493
2494         Reviewed by David Levin.
2495
2496         Add support to DumpRenderTree to use the GPU rather than software renderer
2497         https://bugs.webkit.org/show_bug.cgi?id=52333
2498
2499         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2500         (main):
2501         * Scripts/webkitpy/layout_tests/port/chromium.py:
2502         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2503
2504 2011-01-14  Tony Chang  <tony@chromium.org>
2505
2506         Reviewed by Kent Tamura.
2507
2508         [chromium] update fonts.conf to fix 6 linux tests in drt
2509         https://bugs.webkit.org/show_bug.cgi?id=52411
2510
2511         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2512             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2513
2514 2011-01-14  Eric Seidel  <eric@webkit.org>
2515
2516         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2517
2518         Reviewed by Adam Barth.
2519
2520         Fix when running Tools/Scripts/check-webkit-style without arguments.
2521         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2522
2523         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2524         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2525
2526 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2527
2528         Reviewed by David Levin.
2529
2530         Store the tempdir object in a variable so it doesn't get deleted too early.
2531         https://bugs.webkit.org/show_bug.cgi?id=51875
2532
2533         * Scripts/update-webkit-auxiliary-libs:
2534         * Scripts/update-webkit-support-libs:
2535
2536 2011-01-14  Eric Seidel  <eric@webkit.org>
2537
2538         Unreviewed.  Make it work in python 2.5.
2539
2540         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2541         https://bugs.webkit.org/show_bug.cgi?id=49158
2542
2543         * Scripts/webkitpy/common/checkout/api_unittest.py:
2544
2545 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2546
2547         Unreviewed, rolling out r75774.
2548         http://trac.webkit.org/changeset/75774
2549         https://bugs.webkit.org/show_bug.cgi?id=52431
2550
2551         gtk builds were broken (Requested by loislo2 on #webkit).
2552
2553         * Scripts/webkitpy/common/checkout/scm.py:
2554
2555 2011-01-14  David Levin  <levin@chromium.org>
2556
2557         Reviewed by Shinichiro Hamaji.
2558
2559         check-webkit-style: _FunctionState should detect pure functions.
2560         https://bugs.webkit.org/show_bug.cgi?id=52428
2561
2562         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2563         is a pure virtual function.
2564         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2565         virtual functions are correctly detected.
2566
2567 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2568
2569         Reviewed by Yury Semikhatsky.
2570
2571         Just small fix for problem with check-webkit-style.
2572         It just didn't work for this patch.
2573         Old code can't concatenate a list of strings with None.
2574
2575         * Scripts/webkitpy/common/checkout/scm.py:
2576
2577 2011-01-13  David Levin  <levin@chromium.org>
2578
2579         Reviewed by Shinichiro Hamaji.
2580
2581         check-webkit-style: _FunctionState should use Position to know where items are.
2582         https://bugs.webkit.org/show_bug.cgi?id=52424
2583
2584         * Scripts/webkitpy/style/checkers/cpp.py:
2585         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2586         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2587         did some minor clean-up.
2588         (*): Other changes are simply about converting to use the Position's in_FunctionState
2589         instead of line numbers.
2590         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2591         to verify the positions stored in _FunctionState.
2592
2593 2011-01-13  Eric Seidel  <eric@webkit.org>
2594
2595         Reviewed by David Levin.
2596
2597         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2598         https://bugs.webkit.org/show_bug.cgi?id=49158
2599
2600         This is not the most elegant, but it is a very safe fix to this bug.
2601         One advantage of catching ScriptError like this instead of adding a
2602         new added_or_modified_files or fixing all changed_files callers
2603         to use a more specific change_files variant, is that we catch
2604         all kinds of ScriptErrors which might cause our (non-essential)
2605         suggest-reviewers code to fail out.  This should make passing
2606         --suggest-reviewers to webkit-patch upload much more robust
2607         and may even make it possible for us to make it default.
2608
2609         The root of the problem here is that SCM.changed_files includes
2610         deleted ChangeLog paths (from moves, etc) which then when we ask
2611         SVN/Git for the contents of the file at that revision, the command
2612         errors out and Executive.run_command raises a ScriptError.
2613
2614         In the future we might fix this differently by making all current
2615         callers of chagned_files use a more specific method for requesting
2616         what types of changes they're interested in (adds, modifies, deletes, etc.)
2617
2618         * Scripts/webkitpy/common/checkout/api.py:
2619         * Scripts/webkitpy/common/checkout/api_unittest.py:
2620
2621 2011-01-13  Dan Bernstein  <mitz@apple.com>
2622
2623         Reviewed by Alexey Proskuryakov.
2624
2625         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2626         https://bugs.webkit.org/show_bug.cgi?id=52419
2627
2628         Allow to further control the behavior of the willSendRequest delegate callback by making it
2629         set a different URL in the new request.
2630
2631         * DumpRenderTree/LayoutTestController.cpp:
2632         (addURLToRedirectCallback): Added.
2633         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2634         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2635         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2636         * DumpRenderTree/LayoutTestController.h:
2637         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2638         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2639         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2640         change the URL in the new request to the redirect destination.
2641
2642 2011-01-13  Eric Seidel  <eric@webkit.org>
2643
2644         Reviewed by Mihai Parparita.
2645
2646         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2647         https://bugs.webkit.org/show_bug.cgi?id=52416
2648
2649         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2650         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2651
2652         I also added FIXMEs about the changed_files returning deleted files problem
2653         which is causing the other most common exception for suggest-reviewers
2654         (and is probably breaking sheriff-bots blame detection).
2655
2656         * Scripts/webkitpy/common/checkout/api.py:
2657         * Scripts/webkitpy/common/checkout/api_unittest.py:
2658         * Scripts/webkitpy/common/checkout/scm.py:
2659
2660 2011-01-13  Eric Seidel  <eric@webkit.org>
2661
2662         Reviewed by Adam Barth.
2663
2664         results archives from commit-queue are too large to upload
2665         https://bugs.webkit.org/show_bug.cgi?id=52405
2666
2667         * Scripts/webkitpy/common/system/filesystem.py:
2668         * Scripts/webkitpy/common/system/filesystem_mock.py:
2669         * Scripts/webkitpy/tool/commands/queues.py:
2670
2671 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2672
2673         Reviewed by Martin Robinson.
2674
2675         [gtk] Zero-sized font does not yet work
2676         https://bugs.webkit.org/show_bug.cgi?id=49793
2677
2678         Set minimum-font-size to 0 for the DRT.
2679
2680         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2681         (resetDefaultsToConsistentValues):
2682
2683 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2684
2685         Reviewed by Darin Adler.
2686
2687         Make old-run-webkit-tests more robust on buildbots
2688         https://bugs.webkit.org/show_bug.cgi?id=52364
2689
2690         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2691
2692 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2693
2694         Reviewed by Darin Adler.
2695
2696         Make old-run-webkit-tests more robust on buildbots
2697         https://bugs.webkit.org/show_bug.cgi?id=52364
2698
2699         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2700
2701 2011-01-13  Tony Chang  <tony@chromium.org>
2702
2703         Reviewed by Kent Tamura.
2704
2705         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2706         https://bugs.webkit.org/show_bug.cgi?id=52332
2707
2708         Forked Info.plist is not longer needed.
2709
2710         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2711
2712 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2713
2714         Reviewed by Timothy Hatcher.
2715
2716         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2717         to be passed directly to WebInspector.UIString
2718
2719         https://bugs.webkit.org/show_bug.cgi?id=52365
2720
2721         * Scripts/check-inspector-strings:
2722
2723 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2724
2725         Unreviewed, rolling out r74881.
2726         http://trac.webkit.org/changeset/74881
2727         https://bugs.webkit.org/show_bug.cgi?id=52357
2728
2729         The EFL builder has been red for days (Requested by abarth on
2730         #webkit).
2731
2732         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2733         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2734
2735 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2736
2737         Reviewed by David Levin.
2738
2739         Add beforeunload support to WebKitTestRunner
2740         https://bugs.webkit.org/show_bug.cgi?id=52353
2741         
2742         This makes a number of currently failing tests pass.
2743
2744         * WebKitTestRunner/TestController.cpp:
2745         (WTR::runBeforeUnloadConfirmPanel):
2746         (WTR::createOtherPage):
2747         (WTR::TestController::initialize):
2748
2749 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2750
2751         Reviewed by Sam Weinig.
2752
2753         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2754         https://bugs.webkit.org/show_bug.cgi?id=52330
2755
2756         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2757         a web process crash.
2758         * WebKitTestRunner/TestController.cpp:
2759         (WTR::TestController::initialize): Set up a processDidCrash
2760         callback.
2761         (WTR::TestController::processDidCrash): Report that the Web process
2762         crashed.
2763         * WebKitTestRunner/TestController.h:
2764
2765 2011-01-12  David Levin  <levin@chromium.org>
2766
2767         Reviewed by Shinichiro Hamaji.
2768
2769         check-webkit-style -- close_expression function doesn't work correctly.
2770         https://bugs.webkit.org/show_bug.cgi?id=52272
2771
2772         * Scripts/webkitpy/style/checkers/cpp.py:
2773         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2774         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2775         generally useful (for upcoming code changes).
2776         (close_expression): Changed to use Position for input and output.
2777         Also, fixed many bugs such as only working correctly for parenthesis,
2778         not working correctly if given an offset in a line and not finding
2779         the real closing element if there were multiple closing elements in
2780         the same line.
2781         (detect_functions): Adjusted due to the change in arguments for
2782         close_expression.
2783         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2784         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2785         two positions are the same.
2786         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2787         (CppStyleTest.test_close_expression): Added tests to catch the issues
2788         that were fixed.
2789
2790 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2791
2792         Unreviewed, rolling out r75576.
2793         http://trac.webkit.org/changeset/75576
2794         https://bugs.webkit.org/show_bug.cgi?id=52304
2795
2796         broke rebaseline-chromium-webkit-test (Requested by thakis on
2797         #webkit).
2798
2799         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2800         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2801         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2802         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2803         * Scripts/webkitpy/layout_tests/port/base.py:
2804         * Scripts/webkitpy/layout_tests/port/chromium.py:
2805         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2806         * Scripts/webkitpy/layout_tests/port/test.py:
2807         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2808         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2809         * Scripts/webkitpy/style/checkers/test_expectations.py:
2810         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2811
2812 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2813
2814         Reviewed by Darin Adler.
2815
2816         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2817         https://bugs.webkit.org/show_bug.cgi?id=52307
2818
2819         * Scripts/old-run-webkit-tests:
2820
2821 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2822
2823         Reviewed by Martin Robinson.
2824
2825         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2826         https://bugs.webkit.org/show_bug.cgi?id=50867
2827
2828         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2829         TestNetscapePlugin.cpp 
2830
2831         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2832         * Scripts/webkitdirs.pm:
2833
2834 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2835
2836         Reviewed by Pavel Feldman.
2837
2838         Add check-inspector-strings script.
2839
2840         https://bugs.webkit.org/show_bug.cgi?id=52295
2841
2842         * Scripts/check-inspector-strings: Added.
2843
2844 2011-01-12  Adam Roben  <aroben@apple.com>
2845
2846         Advertise the .testnetscape file extension on Windows
2847
2848         Fixes <http://webkit.org/b/52298>
2849         plugins/no-mime-with-valid-extension.html fails on Windows
2850
2851         Reviewed by Dan Bernstein.
2852
2853         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2854         FileExtents field to map the .testnetscape file extension to the
2855         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2856
2857 2011-01-12  Adam Barth  <abarth@webkit.org>
2858
2859         Reviewed by Eric Seidel.
2860
2861         Make webkit-patch support subdirectories for SVN checkouts
2862         https://bugs.webkit.org/show_bug.cgi?id=52261
2863
2864         os.relpath does not exist on Python 2.5, so we need to call our version
2865         of the API.
2866
2867         * Scripts/webkitpy/common/checkout/scm.py:
2868
2869 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2870
2871         Reviewed by Eric Seidel.
2872
2873         Close additional pages opened during a test once the test completes.
2874         https://bugs.webkit.org/show_bug.cgi?id=52276
2875
2876         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2877         (WTR::InjectedBundle::done):
2878
2879 2011-01-11  David Levin  <levin@chromium.org>
2880
2881         Reviewed by Eric Seidel.
2882
2883         Errors should be separated from the command line in bot messages.
2884         https://bugs.webkit.org/show_bug.cgi?id=52275
2885
2886         * Scripts/webkitpy/common/system/executive.py:
2887         (ScriptError.message_with_output): Added a newline to separate the command
2888         line from the errors.
2889         * Scripts/webkitpy/common/system/executive_unittest.py:
2890         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2891         paths in message_with_output.
2892
2893 2011-01-11  Eric Seidel  <eric@webkit.org>
2894
2895         Unreviewed.
2896
2897         commit-queue should know how to upload archived results (for test flakes or general failures)
2898         https://bugs.webkit.org/show_bug.cgi?id=52048
2899
2900         The zips are mostly empty due to forgetting -r.
2901         Expected diffs were not being pulled from the archive due
2902         to the archive having longer paths than I realized.
2903
2904         * Scripts/webkitpy/common/system/workspace.py:
2905         * Scripts/webkitpy/common/system/workspace_unittest.py:
2906         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2907         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2908
2909 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2910
2911         Reviewed by Ojan Vafai.
2912
2913         The current modifier parsing code in test_expectations is
2914         fragile and hard-coded, so it's not easy to understand the logic
2915         or easily add new types of modifiers (like GPU vs. CPU testing
2916         for graphics tests, or 32-bit vs. 64-bit differences).
2917
2918         This is the first of two patches that will add in more generic
2919         support and then eliminate the GPU-specific test expectations
2920         files for Chromium.
2921
2922         This patch adds two standalone objects for handling modifiers. The
2923         rules for interpreting modifiers, precedence, and conflicts are
2924         given in the docstring to the ModifierMatcher class, which
2925         returns ModifierMatchResult objects.
2926         
2927         This patch also adds routines to the Port interface and a
2928         default set of values in the base object, in order to obtain the
2929         values needed on a given test run. These values are then passed
2930         to the expectation parser. This also allows us to clean up the
2931         logic used to lint all of the different configurations in a
2932         single test_expectations.txt file.
2933
2934         The next patch will merge in the separate GPU expectations file.
2935
2936         https://bugs.webkit.org/show_bug.cgi?id=51222
2937
2938         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2939         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2940         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2941         * Scripts/webkitpy/layout_tests/port/base.py:
2942         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2943         * Scripts/webkitpy/layout_tests/port/chromium.py:
2944         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2945         * Scripts/webkitpy/layout_tests/port/test.py:
2946         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2947         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2948
2949 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2950
2951         Reviewed by Adam Barth.
2952
2953         Make webkit-patch support subdirectories for SVN checkouts
2954         https://bugs.webkit.org/show_bug.cgi?id=52261
2955
2956         * Scripts/webkitpy/common/checkout/scm.py:
2957         * Scripts/webkitpy/style_references.py:
2958         * Scripts/webkitpy/tool/main.py:
2959         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2960
2961 2011-01-11  Eric Seidel  <eric@webkit.org>
2962
2963         Unreviewed.
2964
2965         commit-queue should know how to upload archived results (for test flakes or general failures)
2966         https://bugs.webkit.org/show_bug.cgi?id=52048
2967
2968         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2969         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2970
2971         * Scripts/webkitpy/common/system/workspace.py:
2972         * Scripts/webkitpy/common/system/workspace_unittest.py:
2973         * Scripts/webkitpy/tool/commands/queues.py:
2974
2975 2011-01-11  Sam Weinig  <sam@webkit.org>
2976
2977         Roll r75474 back in.
2978
2979 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2980
2981         Reviewed by Kenneth Rohde Christiansen.
2982
2983         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2984         https://bugs.webkit.org/show_bug.cgi?id=51204
2985
2986         * QtTestBrowser/webpage.h:
2987         (QtNAMThread::QtNAMThread):
2988         (QtNAMThread::networkAccessManager):
2989         (QtNAMThread::run):
2990
2991 2011-01-11  Peter Varga  <pvarga@webkit.org>
2992
2993         Unreviewed.
2994
2995         Add myself to committers' list.
2996
2997         * Scripts/webkitpy/common/config/committers.py:
2998
2999 2011-01-11  Eric Seidel  <eric@webkit.org>
3000
3001         Reviewed by Adam Barth.
3002
3003         commit-queue should know how to upload archived results (for test flakes or general failures)
3004         https://bugs.webkit.org/show_bug.cgi?id=52048
3005
3006         Now the queue will always upload results.  Either the entire zip, or just
3007         the diffs.txt in the case of text failures.
3008
3009         This should make understanding flakes much easier, and paves the way
3010         for having the EWS run layout tests (and upload failures).
3011
3012         In order to upload .zip files I had to teach bugzilla.py to autodetect
3013         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3014         for .patch files, I have it add one before calling guess_type.
3015
3016         We may find that always uploading the whole zip instead of just the -diffs.txt
3017         file is preferable, but for now I'm keeping the old behavior because it makes
3018         quickly understanding text failures easy.
3019
3020         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3021         * Scripts/webkitpy/common/system/workspace.py: Added.
3022         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3023         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3024         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3025         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3026         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3027         * Scripts/webkitpy/tool/commands/queues.py:
3028         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3029
3030 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3031
3032         Unreviewed, rolling out r75464.
3033         http://trac.webkit.org/changeset/75464
3034         https://bugs.webkit.org/show_bug.cgi?id=52193
3035
3036         Followup rollout for 75474 (Requested by Ossy on #webkit).
3037
3038         * MiniBrowser/mac/BrowserWindowController.m:
3039         (-[BrowserWindowController awakeFromNib]):
3040         * MiniBrowser/win/BrowserView.cpp:
3041         (BrowserView::create):
3042         * WebKitTestRunner/TestController.cpp:
3043         (WTR::createOtherPage):
3044         (WTR::TestController::initialize):
3045
3046 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3047
3048         Reviewed by Csaba Osztrogonác.
3049
3050         [Qt] Baseline qt_minimal configuration
3051         https://bugs.webkit.org/show_bug.cgi?id=51313
3052
3053         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3054         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3055         QT_NO_UNDOSTACK guard.
3056
3057         * QtTestBrowser/launcherwindow.cpp:
3058         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3059         guards.
3060         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3061         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3062         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3063         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3064
3065         * QtTestBrowser/launcherwindow.h:
3066         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3067         * QtTestBrowser/locationedit.h: Ditto.
3068
3069         * QtTestBrowser/mainwindow.cpp:
3070         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3071         QT_NO_UNDOSTACK guards.
3072         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3073         (MainWindow::changeLocation): Ditto.
3074         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3075         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3076
3077         * QtTestBrowser/webpage.cpp:
3078         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3079         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3080
3081         * QtTestBrowser/webview.cpp:
3082         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3083         (WebViewGraphicsBased::animatedYFlip): Ditto.
3084
3085 2011-01-10  Sam Weinig  <sam@webkit.org>
3086
3087         Fix build.
3088
3089         * MiniBrowser/mac/BrowserWindowController.m:
3090         (-[BrowserWindowController awakeFromNib]):
3091         * MiniBrowser/win/BrowserView.cpp:
3092         (BrowserView::create):
3093         * WebKitTestRunner/TestController.cpp:
3094         (WTR::createOtherPage):
3095         (WTR::TestController::initialize):
3096
3097 2011-01-10  Eric Seidel  <eric@webkit.org>
3098
3099         Reviewed by Ojan Vafai.
3100
3101         style-queue messages are way too long for big patches
3102         https://bugs.webkit.org/show_bug.cgi?id=52161
3103
3104         We definitely could build much fancier list-to-string-with-limit functions
3105         but this should be sufficient for our needs at the moment.
3106
3107         * Scripts/webkitpy/common/system/executive.py:
3108         * Scripts/webkitpy/common/system/executive_unittest.py:
3109
3110 2011-01-10  Tony Chang  <tony@chromium.org>
3111
3112         Unreviewed, rolling out r75398.
3113         http://trac.webkit.org/changeset/75398
3114         https://bugs.webkit.org/show_bug.cgi?id=52008
3115
3116         Some layout tests are crashing on Chromium Win.
3117
3118         * DumpRenderTree/chromium/WebViewHost.cpp:
3119         (WebViewHost::updatePaintRect):
3120         * DumpRenderTree/chromium/WebViewHost.h:
3121
3122 2011-01-10  Adam Roben  <aroben@apple.com>
3123
3124         Roll out r75392
3125
3126         It isn't needed now that r75289 has been rolled out.
3127
3128         * Scripts/run-javascriptcore-tests:
3129
3130 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3131
3132         Reviewed by Anders Carlsson.
3133
3134         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3135         https://bugs.webkit.org/show_bug.cgi?id=52160
3136
3137         * WebKitTestRunner/mac/TestControllerMac.mm:
3138         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3139         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3140         anyway.
3141
3142 2011-01-10  Tony Chang  <tony@chromium.org>
3143
3144         Reviewed by Mihai Parparita.
3145
3146         [chromium] fix for animated gif layout tests
3147         https://bugs.webkit.org/show_bug.cgi?id=52008
3148
3149         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3150             to trigger gif animations.
3151         (WebViewHostPaintTask::WebViewHostPaintTask):
3152         (WebViewHostPaintTask::runIfValid):
3153         (WebViewHost::updatePaintRect):
3154         * DumpRenderTree/chromium/WebViewHost.h:
3155         (WebViewHost::taskList):
3156
3157 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3158
3159         Reviewed by Xan Lopez.
3160
3161         [GTK] Fix gtk2 compilation for master
3162         https://bugs.webkit.org/show_bug.cgi?id=51885
3163
3164         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3165         (createBitmapContextFromWebView): Replaced the old
3166         gdk_drawable_get_size with gdk_pixmap_get_size.
3167
3168 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3169
3170         Reviewed by Laszlo Gombos.
3171
3172         [WINCE] Reenable NPAPI after r75203
3173         https://bugs.webkit.org/show_bug.cgi?id=52109
3174
3175         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3176         it with !isEfl(), because EFL port does not support NPAPI (yet).
3177
3178         * Scripts/build-webkit:
3179
3180 2011-01-10  Adam Roben  <aroben@apple.com>
3181
3182         Skip some asserting JS tests
3183
3184         See <http://webkit.org/b/52156>.
3185
3186         * Scripts/run-javascriptcore-tests:
3187
3188 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3189
3190         Reviewed by Xan Lopez.
3191
3192         [GTK] build-webkit disable Blob support via arguments passed to automake
3193         https://bugs.webkit.org/show_bug.cgi?id=52097
3194
3195         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3196         build-webkit.
3197
3198 2011-01-10  Adam Roben  <aroben@apple.com>
3199
3200         Use the same name and description for TestNetscapePlugin on Windows and
3201         Mac
3202
3203         Fixes <http://webkit.org/b/52151>
3204         fast/frames/iframe-reparenting-plugins.html fails on Windows
3205
3206         Reviewed by Steve Falkenburg.
3207
3208         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3209         the name and description from Mac's Info.plist.
3210
3211 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3212
3213         Reviewed by Laszlo Gombos.
3214
3215         [Qt][WK2] Guard gcc-specific syntax
3216
3217         Non-gcc based compliers choke on the "-include"
3218         syntax for preinclude, place guard around it.
3219
3220         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3221         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3222
3223 2011-01-10  Andreas Kling  <kling@webkit.org>
3224
3225         Reviewed by Simon Hausmann.
3226
3227         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3228         https://bugs.webkit.org/show_bug.cgi?id=52111
3229
3230         When getting a createNewPage() callback from QWKPage, create the
3231         new page with the same QWKContext as the page that is passed to
3232         the callback.
3233
3234         * MiniBrowser/qt/BrowserView.h:
3235         * MiniBrowser/qt/BrowserWindow.cpp:
3236         (newPageFunction):
3237         (BrowserWindow::BrowserWindow):
3238         * MiniBrowser/qt/BrowserWindow.h:
3239
3240 2011-01-10  Andreas Kling  <kling@webkit.org>
3241
3242         Reviewed by Kenneth Rohde Christiansen.
3243
3244         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3245
3246         BrowserView set its own useless createNewPage() callback on QWKPage.
3247         This was immediately overridden by BrowserWindow anyway, so remove
3248         the BrowserView one.
3249
3250         * MiniBrowser/qt/BrowserView.cpp:
3251         (BrowserView::BrowserView):
3252
3253 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3254
3255         Reviewed by Jeremy Orlow.
3256
3257         [Chromium] Remove non-client-based Geolocation code
3258         https://bugs.webkit.org/show_bug.cgi?id=50921
3259
3260         * DumpRenderTree/chromium/LayoutTestController.cpp:
3261         (LayoutTestController::setGeolocationPermission):
3262         (LayoutTestController::setMockGeolocationPosition):
3263         (LayoutTestController::setMockGeolocationError):
3264         * DumpRenderTree/chromium/WebViewHost.cpp:
3265         (WebViewHost::geolocationClientMock):
3266         (WebViewHost::reset):
3267         * DumpRenderTree/chromium/WebViewHost.h:
3268
3269 2011-01-10  Eric Seidel  <eric@webkit.org>
3270
3271         Reviewed by Adam Barth.
3272
3273         Commit bot tried to land r? cq+ patch
3274         https://bugs.webkit.org/show_bug.cgi?id=36638
3275
3276         It should now be possible to post a patch with r? and cq+ and the
3277         commit-queue will correctly wait for the r+ before attempting to land the patch.
3278         (This was a feature requested by several users.)
3279
3280         One caveat: We don't actually reject r-, cq+ patches from the queue
3281         (we just ignore them), but I think that's OK for now.
3282
3283         I also noticed that setting r- once a commit-queue node had grabbed
3284         a patch would not properly cancel the landing.  That's fixed and
3285         tested in this patch.
3286
3287         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3288         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3289         * Scripts/webkitpy/tool/bot/feeders.py:
3290         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3291
3292 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3293
3294         Reviewed by Kenneth Rohde Christiansen.
3295
3296         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3297         https://bugs.webkit.org/show_bug.cgi?id=51934
3298
3299         When accessing the network from the destructor of QWebPage, the network access manager
3300         was already deleted because the object WebPage was already destructed.
3301
3302         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3303         The object is now destructed in the destructor of QObject.
3304
3305         * QtTestBrowser/webpage.cpp:
3306         (WebPage::WebPage):
3307         (WebPage::setQnamThreaded):
3308         * QtTestBrowser/webpage.h:
3309         (QtNAMThread::QtNAMThread):
3310
3311 2011-01-08  Eric Seidel  <eric@webkit.org>
3312
3313         Reviewed by Ojan Vafai.
3314
3315         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3316         https://bugs.webkit.org/show_bug.cgi?id=52067
3317
3318         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3319         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3320
3321         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3322
3323 2011-01-08  Eric Seidel  <eric@webkit.org>
3324
3325         Reviewed by Mihai Parparita.
3326
3327         commit-queue hangs when the ChangeLog diff is bad
3328         https://bugs.webkit.org/show_bug.cgi?id=52072
3329
3330         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3331         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3332
3333 2011-01-08  Adam Barth  <abarth@webkit.org>
3334
3335         Teach svn-apply how to re-write WebCore to Source/WebCore.
3336
3337         * Scripts/VCSUtils.pm:
3338
3339 2011-01-07  Adam Barth  <abarth@webkit.org>
3340
3341         Rubber-stamped by Eric Seidel.
3342
3343         Move WebCore to Source
3344         https://bugs.webkit.org/show_bug.cgi?id=52050
3345
3346         Update the tools to understand WebCore's new location.
3347
3348         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3349         * DumpRenderTree/wscript:
3350         * GNUmakefile.am:
3351         * Scripts/build-webkit:
3352         * Scripts/do-file-rename:
3353         * Scripts/do-webcore-rename:
3354         * Scripts/generate-qt-inspector-resource:
3355         * Scripts/prepare-ChangeLog:
3356         * Scripts/run-bindings-tests:
3357         * Scripts/update-iexploder-cssproperties:
3358         * Scripts/update-sources-list.py:
3359         * Scripts/update-webkit-localizable-strings:
3360         * Scripts/webkitdirs.pm:
3361         * Scripts/webkitpy/common/config/build.py:
3362         * Scripts/webkitpy/common/config/build_unittest.py:
3363         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3364         * Scripts/webkitpy/style/checker.py:
3365         * Scripts/webkitpy/style/checker_unittest.py:
3366         * WebKitTestRunner/DerivedSources.pro:
3367         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3368         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3369         * wx/browser/wscript:
3370         * wx/build/settings.py:
3371
3372 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3373
3374         Reviewed by Sam Weinig.
3375
3376         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3377         https://bugs.webkit.org/show_bug.cgi?id=52086
3378
3379         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3380         (WTR::InjectedBundle::didReceiveMessage):
3381         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3382         (WTR::LayoutTestController::notifyDone):
3383         * WebKitTestRunner/TestController.cpp:
3384         (WTR::TestController::resetStateToConsistentValues):
3385         (WTR::TestController::run):
3386
3387 2011-01-07  James Robinson  <jamesr@chromium.org>
3388
3389         Revert "Implement mozilla's animationTime property"
3390         https://bugs.webkit.org/show_bug.cgi?id=51952
3391
3392         This approach isn't quite right.
3393
3394         * DumpRenderTree/chromium/WebViewHost.cpp:
3395         (WebViewHost::paintInvalidatedRegion):
3396
3397 2011-01-07  Adam Roben  <aroben@apple.com>
3398
3399         Build master fix
3400
3401         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3402         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3403
3404 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3405
3406         Reviewed by Csaba Osztrogonác.
3407
3408         run-qtwebkit-tests should be able to kill a testsuite.
3409
3410         Add new option in the script that can setup a timeout for a test.
3411         If the test execution takes more then specified time then the test
3412         would be terminated.
3413
3414         [Qt] run-qtwebkit-tests needs timeout
3415         https://bugs.webkit.org/show_bug.cgi?id=51894
3416
3417         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3418         * Scripts/run-qtwebkit-tests:
3419
3420 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3421
3422         Unreviewed fix after r75233.
3423
3424         Based on idea from Eric Seidel.
3425
3426         Add remote zip file handling to webkitpy.
3427         https://bugs.webkit.org/show_bug.cgi?id=50901
3428
3429         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3430
3431 2011-01-07  Shane Stephens  <shanestephens@google.com>
3432
3433         Reviewed by Eric Seidel.
3434
3435         svn-apply: should support git binary delta diffs
3436         https://bugs.webkit.org/show_bug.cgi?id=38864
3437
3438         * Scripts/VCSUtils.pm:
3439         * Scripts/svn-apply:
3440
3441 2011-01-06  Julie Parent  <jparent@chromium.org>
3442
3443         Reviewed by Eric Seidel.
3444
3445         Test Result Server not removing old results.
3446         https://bugs.webkit.org/show_bug.cgi?id=52012
3447
3448         * TestResultServer/model/jsonresults.py:
3449         Fix off-by-one: Truncate if >= num_runs, not just >.
3450         * TestResultServer/model/jsonresults_unittest.py:
3451         Add unit test to test that merging in a new result with the same value
3452         as the last result causes previous result to fall off.
3453
3454 2011-01-06  James Kozianski  <koz@chromium.org>
3455
3456         Reviewed by Mihai Parparita.
3457
3458         Add classes to provide a consistent interface to a set of files.
3459         https://bugs.webkit.org/show_bug.cgi?id=50901
3460
3461         These classes allow us to write code that is agnostic to whether a
3462         particular set of files resides in a local directory or in a zip file
3463         on a remote machine.
3464
3465         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3466         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3467         * Scripts/webkitpy/common/system/fileset.py: Added.
3468         * Scripts/webkitpy/common/system/filesystem.py:
3469         * Scripts/webkitpy/common/system/filesystem_mock.py:
3470         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3471         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3472
3473 2011-01-06  Eric Seidel  <eric@webkit.org>
3474
3475         Reviewed by Adam Barth.
3476
3477         NetworkTransaction should log the url it is retrying
3478         https://bugs.webkit.org/show_bug.cgi?id=52043
3479
3480         * Scripts/webkitpy/common/net/networktransaction.py:
3481         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3482
3483 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3484
3485         Windows build fix.
3486         Import os before using it.
3487
3488         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3489
3490 2011-01-06  Eric Seidel  <eric@webkit.org>
3491
3492         Reviewed by Adam Barth.
3493
3494         StyleQueue fails to report errors when patches have many files
3495         https://bugs.webkit.org/show_bug.cgi?id=52042
3496
3497         This is one of at least two errors preventing style error reporting at the moment.
3498         When we moved to passing the list of files to check explicitly,
3499         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3500         We could change the type of the QueueStatus.message type, or we could
3501         just teach statusserver.py how to clamp values (and warn when it does).
3502         I chose the latter path.
3503
3504         * Scripts/webkitpy/common/net/statusserver.py:
3505
3506 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3507
3508         Reviewed by Stephanie Lewis.
3509         
3510         Fix syntax error in script.
3511
3512         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3513         https://bugs.webkit.org/show_bug.cgi?id=51996
3514
3515         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3516
3517 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3518
3519         Unreviewed, fixing WinCE build after r75196.
3520
3521         WinCE port does not (yet) support NPAPI.
3522
3523         * Scripts/build-webkit:
3524
3525 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3526
3527         Reviewed by Darin Adler.
3528
3529         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3530         https://bugs.webkit.org/show_bug.cgi?id=52015
3531
3532         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3533         after the platform has been detected, otherwise the script will
3534         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3535         detection.
3536
3537 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3538
3539         Reviewed by Eric Seidel.
3540
3541         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3542         https://bugs.webkit.org/show_bug.cgi?id=51346
3543
3544         * Scripts/build-webkit:
3545
3546 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3547
3548         Reviewed by Adam Roben.
3549
3550         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3551         https://bugs.webkit.org/show_bug.cgi?id=51996
3552         
3553         After the configuration directory change, we were archiving the incorrect directory for
3554         build product, so we were running tests on the wrong binaries.
3555         
3556         This change archives the correct directory, and also unarchives it into a configuration-
3557         specific directory.
3558
3559         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3560         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3561
3562 2011-01-06  Eric Seidel  <eric@webkit.org>
3563
3564         Reviewed by Mihai Parparita.
3565
3566         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3567         https://bugs.webkit.org/show_bug.cgi?id=52002
3568
3569         See an example of this here:
3570         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3571
3572         It's due to the fact that we pass around TestFailure() instance
3573         objects and yet expect them to all compare to be the same.
3574
3575         This is bad.  We should either have shared instances of these values
3576         or we should just pass around the class names.  There are already hacks
3577         in place to make TestFailure objects pass equality tests, I just added
3578         a __hash__ implementation so they can be used in sets as expected.
3579
3580         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3581         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3582
3583 2011-01-06  Evan Martin  <evan@chromium.org>
3584
3585         Reviewed by Tony Chang.
3586
3587         [gdb] handle inaccessible memory and UChar*
3588         https://bugs.webkit.org/show_bug.cgi?id=52003
3589
3590         To pretty-print a UChar*, we just grope around in the memory
3591         looking for a terminating NUL.  We need to handle the exception
3592         that can occur when we poke into an invalid location.
3593
3594         Additionally, the logic for choosing which pretty-printer would
3595         early return before hitting the point where we'd use the UChar*
3596         printer.  (Did this ever work?  How did it regress?)
3597
3598         * gdb/webkit.py:
3599
3600 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3601
3602         Reviewed by Ada Chan.
3603
3604         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3605         https://bugs.webkit.org/show_bug.cgi?id=51969
3606         
3607         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3608
3609         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3610         (WTR::InjectedBundlePage::InjectedBundlePage):
3611         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3612         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3613
3614 2011-01-06  James Robinson  <jamesr@chromium.org>
3615
3616         Reviewed by Simon Fraser.
3617
3618         Implement mozilla's animationTime property
3619         https://bugs.webkit.org/show_bug.cgi?id=51952
3620
3621         Chromium DRT support for webkitAnimationTime.
3622
3623         * DumpRenderTree/chromium/WebViewHost.cpp:
3624         (WebViewHost::paintInvalidatedRegion):
3625
3626 2011-01-06  Julie Parent  <jparent@chromium.org>
3627
3628         Reviewed by Tony Chang.
3629
3630         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3631         https://bugs.webkit.org/show_bug.cgi?id=51217
3632
3633         * TestResultServer/model/jsonresults.py:
3634         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3635         Adds missing documentation.
3636         * TestResultServer/model/jsonresults_unittest.py:
3637         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3638         Update test_merge to take a number of builds to truncate at.
3639
3640 2011-01-06  Adam Barth  <abarth@webkit.org>
3641
3642         Reviewed by Eric Seidel.
3643
3644         The EWS should log outside of the working directory
3645         https://bugs.webkit.org/show_bug.cgi?id=51986
3646
3647         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3648         script, which will actually clean the working copy back to a pristine
3649         state instead of leaving untracked directories and ignored files.
3650
3651         * Scripts/webkitpy/tool/commands/queues.py:
3652         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3653
3654 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3655
3656         Windows build fix.
3657         Back out attempted change to built-product-archive.
3658
3659         * BuildSlaveSupport/built-product-archive:
3660
3661 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3662
3663         Windows build fix.
3664         Include configuration name when unpacking a build archive.
3665
3666         Needed, since we split Windows build results into configuration-specific directories
3667         under WebKitOutputDir.
3668
3669         * BuildSlaveSupport/built-product-archive:
3670
3671 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3672
3673         Reviewed by Darin Adler.
3674
3675         Debug and Release builds on Windows clobber each other
3676         https://bugs.webkit.org/show_bug.cgi?id=49185
3677
3678         Changes the structure of WebKitBuild build products directory so we
3679         completely separate each build configuration into independent directories.
3680         
3681         Although we previously had per-configuration directories for obj, this change adds
3682         per-configuration directories for bin, lib, obj, and include. Each configuration's
3683         build products are stored within a directory inside of WebKitBuild.
3684         
3685         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3686         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3687
3688         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3689         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3690         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3691         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3692         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3693         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3694         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3695         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3696         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3697         * FindSafari/FindSafari.vcproj:
3698         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3699         * MiniBrowser/MiniBrowserPostBuild.cmd:
3700         * MiniBrowser/MiniBrowserPreBuild.cmd:
3701         * Scripts/webkitdirs.pm:
3702         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3703         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3704         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3705         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3706         * TestWebKitAPI/win/copy-resources.cmd:
3707         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3708         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3709         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3710         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3711         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3712         * WebKitTestRunner/win/InjectedBundle.vcproj:
3713         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3714         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3715         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3716         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3717         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3718         * WinLauncher/WinLauncherCommon.vsprops:
3719         * WinLauncher/WinLauncherPostBuild.cmd:
3720         * WinLauncher/WinLauncherPreBuild.cmd:
3721
3722 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3723
3724         Reviewed by Ariya Hidayat.
3725
3726         [Qt] TestNetscapePlugin doesn't link on OS X
3727         https://bugs.webkit.org/show_bug.cgi?id=51948
3728
3729         Only add a dependency on libX11 on X11 systems
3730
3731         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3732
3733 2011-01-05  Jeff Miller  <jeffm@apple.com>
3734
3735         Reviewed by Adam Roben.
3736
3737         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3738         https://bugs.webkit.org/show_bug.cgi?id=51970
3739
3740         * Scripts/webkitpy/style/checker.py:
3741         Add -readability/naming for WebKit2 C API directories.
3742
3743 2011-01-05  Eric Seidel  <eric@webkit.org>
3744
3745         Unreviewed, just fixing one more log error from my previous python patch.
3746
3747         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3748         https://bugs.webkit.org/show_bug.cgi?id=51802
3749
3750         webkit-patch failure-reason was logging about parsing errors
3751         due to my misunderstanding of how BeautifulSoup.findAll worked.
3752
3753         Fixed, and added a unit test.
3754
3755         * Scripts/webkitpy/common/net/layouttestresults.py:
3756         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3757
3758 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3759
3760         Reviewed by Kenneth Rohde Christiansen.
3761
3762         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3763         https://bugs.webkit.org/show_bug.cgi?id=51951
3764
3765         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3766         to create new window from WebKit.
3767
3768         * MiniBrowser/qt/BrowserWindow.cpp:
3769         (newPageFunction):
3770         (BrowserWindow::BrowserWindow):
3771         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3772         (BrowserWindow::newWindow):
3773         (BrowserWindow::updateUserAgentList):
3774         (BrowserWindow::showUserAgentDialog):
3775         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3776         define the type of the backing store used for new windows.
3777         * MiniBrowser/qt/main.cpp:
3778         (main):
3779
3780 2011-01-05  Eric Seidel  <eric@webkit.org>
3781
3782         Reviewed by Ojan Vafai.
3783
3784         commit-queue should report failure type when reporting flaky tests
3785         https://bugs.webkit.org/show_bug.cgi?id=51900
3786
3787         This patch was a ridiculous amount of plumbing.  In the end I like
3788         the NRWT-style TestResult class even less.  But now we're passing
3789         a list of TestResult objects from the queue to the FlakyTestReporter.
3790         Thus the FlakyTestReporter can more easily