2011-01-18 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / Tools / ChangeLog
1 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Mihai Parparita.
4
5         new-run-webkit-tests shouldn't crash when you try to run a
6         directory containing only skipped files.
7
8         https://bugs.webkit.org/show_bug.cgi?id=52478
9         
10         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
11         * Scripts/webkitpy/layout_tests/port/test.py:
12         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
13
14 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
15
16         Reviewed by Gustavo Noronha Silva.
17
18         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
19         https://bugs.webkit.org/show_bug.cgi?id=40833
20
21         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
22         GTK+ event sender.
23         (dragWithFilesDragDataGetCallback): Added.
24         (dragWithFilesDragEndCallback): Added.
25         (beginDragWithFilesCallback): Added.
26
27 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
28
29         Reviewed by Adam Barth.
30
31         ews: Add additional watcher to efl ews
32         https://bugs.webkit.org/show_bug.cgi?id=52613
33
34         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
35
36         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
37
38 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
39
40         Reviewed by Alexey Proskuryakov.
41
42         Fix some headers with missing or misspelled #ifndef guards
43         https://bugs.webkit.org/show_bug.cgi?id=52545
44
45         * DumpRenderTree/chromium/TestEventPrinter.h:
46         * DumpRenderTree/chromium/WebPreferences.h:
47
48 2011-01-17  Jessie Berlin  <jberlin@apple.com>
49
50         Reviewed by Anders Carlsson.
51
52         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
53         navigating back to an unreachable URL
54         https://bugs.webkit.org/show_bug.cgi?id=52388
55
56         Add a third parameter (unreachableURL) to queueLoadHTMLString.
57
58         * DumpRenderTree/LayoutTestController.cpp:
59         (queueLoadHTMLStringCallback):
60         (LayoutTestController::queueLoadHTMLString):
61         (LayoutTestController::queueLoadAlternateHTMLString):
62         * DumpRenderTree/LayoutTestController.h:
63
64         * DumpRenderTree/WorkQueueItem.h:
65         (LoadHTMLStringItem::LoadHTMLStringItem):
66
67         * DumpRenderTree/chromium/LayoutTestController.cpp:
68         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
69         (WorkItemLoadHTMLString::run):
70         (LayoutTestController::queueLoadHTMLString):
71
72         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
73         (LoadHTMLStringItem::invoke):
74         * DumpRenderTree/mac/WorkQueueItemMac.mm:
75         (LoadHTMLStringItem::invoke):
76         * DumpRenderTree/win/WorkQueueItemWin.cpp:
77         (LoadHTMLStringItem::invoke):
78
79 2011-01-17  Dan Bernstein  <mitz@apple.com>
80
81         Rubber-stamped by Mark Rowe.
82
83         Update xcodeproj svn:ignore to include xcuserdata.
84
85         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
86         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
87         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
88         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
89         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
90
91 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
92
93         Unreviewed fix after r75908.
94
95         Move WebKit into Source
96         https://bugs.webkit.org/show_bug.cgi?id=52530
97
98         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
99
100 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
101
102         Unreviewed.
103
104         Remove accidentally committed debug printing after r75908.
105
106         * Scripts/webkitdirs.pm:
107
108 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
109
110         Unreviewed.
111
112         Add myself to committers list
113         https://bugs.webkit.org/show_bug.cgi?id=52566
114
115         * Scripts/webkitpy/common/config/committers.py:
116
117 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
118
119         Reviewed by Jeremy Orlow.
120
121         GeolocationController should call stopUpdating on destruction
122         https://bugs.webkit.org/show_bug.cgi?id=52216
123
124         fast/dom/Geolocation/window-close-crash.html requires that a
125         Geolocation watch be started in a secondary window. Consequently,
126         we need to allow geolocation permission and provide a mock
127         geolocation position for the secondary window's
128         GeolocationClientMock.
129
130         * DumpRenderTree/chromium/LayoutTestController.cpp:
131         (LayoutTestController::setGeolocationPermission):
132         (LayoutTestController::setMockGeolocationPosition):
133         (LayoutTestController::setMockGeolocationError):
134         * DumpRenderTree/chromium/TestShell.h:
135         (TestShell::windowList):
136
137 2011-01-16  Adam Barth  <abarth@webkit.org>
138
139         Update more include paths to reflect WebKit move.
140
141         * DumpRenderTree/chromium/EventSender.cpp:
142         (EventSender::keyDown):
143         (EventSender::needsShiftModifier):
144         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
145         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
146
147 2011-01-16  Kent Tamura  <tkent@chromium.org>
148
149         Unreviewed, Chromium build fix.
150
151         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
152
153 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
154
155         Build fix for GTK+ after source directory movement.
156
157         * GNUmakefile.am: Correct include paths.
158
159 2011-01-16  Adam Barth  <abarth@webkit.org>
160
161         Teach svn-apply about WebKit move.
162
163         * Scripts/VCSUtils.pm:
164
165 2011-01-16  Adam Barth  <abarth@webkit.org>
166
167         Rubber-stamped by Eric Seidel.
168
169         Move WebKit into Source
170         https://bugs.webkit.org/show_bug.cgi?id=52530
171
172         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
173         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
174         * DumpRenderTree/qt/DumpRenderTreeQt.h:
175         * DumpRenderTree/qt/GCControllerQt.cpp:
176         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
177         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
178         * DumpRenderTree/qt/TextInputControllerQt.cpp:
179         * DumpRenderTree/wscript:
180         * QtTestBrowser/launcherwindow.h:
181         * Scripts/build-webkit:
182         * Scripts/webkitdirs.pm:
183
184 2011-01-15  Adam Barth  <abarth@webkit.org>
185
186         Teach svn-apply about WebKit2 move.
187
188         * Scripts/VCSUtils.pm:
189
190 2011-01-15  Adam Barth  <abarth@webkit.org>
191
192         Rubber-stamped by Eric Seidel.
193
194         Move WebKit2 into Source
195         https://bugs.webkit.org/show_bug.cgi?id=52438
196
197         * MiniBrowser/qt/MiniBrowser.pro:
198         * Scripts/build-webkit:
199         * Scripts/do-file-rename:
200         * Scripts/do-webcore-rename:
201         * Scripts/test-webkitpy:
202         * Scripts/webkitdirs.pm:
203         * Scripts/webkitpy/style/checker.py:
204         * WebKitTestRunner/DerivedSources.pro:
205         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
206         * WebKitTestRunner/qt/WebKitTestRunner.pro:
207
208 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
209
210         Reviewed by David Levin.
211
212         [chromium] remove obsolete createView method
213         https://bugs.webkit.org/show_bug.cgi?id=52437
214
215         * DumpRenderTree/chromium/WebViewHost.cpp:
216         (WebViewHost::createView):
217         * DumpRenderTree/chromium/WebViewHost.h:
218
219 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
220
221         Reviewed by Geoff Garen.
222
223         ShouldLoadResourceForFrame should use strings, not URLs.
224         https://bugs.webkit.org/show_bug.cgi?id=52476
225
226         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
227         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
228         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
229
230 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
231
232         Reviewed by David Levin.
233
234         Add Tony Gentilcore as a reviewer
235         https://bugs.webkit.org/show_bug.cgi?id=52480
236
237         * Scripts/webkitpy/common/config/committers.py:
238
239 2011-01-14  David Levin  <levin@chromium.org>
240
241         Reviewed by Eric Seidel.
242
243         check-webkit-style: _FunctionState should keep track of where the function name starts.
244         https://bugs.webkit.org/show_bug.cgi?id=52454
245
246         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
247         _FunctionState and logic for setting it correctly.
248         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
249
250 2011-01-14  Vincent Scheib  <scheib@chromium.org>
251
252         Reviewed by David Levin.
253
254         Add support to DumpRenderTree to use the GPU rather than software renderer
255         https://bugs.webkit.org/show_bug.cgi?id=52333
256
257         * DumpRenderTree/chromium/DumpRenderTree.cpp:
258         (main):
259         * Scripts/webkitpy/layout_tests/port/chromium.py:
260         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
261
262 2011-01-14  Tony Chang  <tony@chromium.org>
263
264         Reviewed by Kent Tamura.
265
266         [chromium] update fonts.conf to fix 6 linux tests in drt
267         https://bugs.webkit.org/show_bug.cgi?id=52411
268
269         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
270             chromium's src/webkit/tools/test_shell/resources/fonts.conf
271
272 2011-01-14  Eric Seidel  <eric@webkit.org>
273
274         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
275
276         Reviewed by Adam Barth.
277
278         Fix when running Tools/Scripts/check-webkit-style without arguments.
279         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
280
281         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
282         * Scripts/webkitpy/common/checkout/scm_unittest.py:
283
284 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
285
286         Reviewed by David Levin.
287
288         Store the tempdir object in a variable so it doesn't get deleted too early.
289         https://bugs.webkit.org/show_bug.cgi?id=51875
290
291         * Scripts/update-webkit-auxiliary-libs:
292         * Scripts/update-webkit-support-libs:
293
294 2011-01-14  Eric Seidel  <eric@webkit.org>
295
296         Unreviewed.  Make it work in python 2.5.
297
298         webkit-patch suggest-reviewers dies when ChangeLogs are missing
299         https://bugs.webkit.org/show_bug.cgi?id=49158
300
301         * Scripts/webkitpy/common/checkout/api_unittest.py:
302
303 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
304
305         Unreviewed, rolling out r75774.
306         http://trac.webkit.org/changeset/75774
307         https://bugs.webkit.org/show_bug.cgi?id=52431
308
309         gtk builds were broken (Requested by loislo2 on #webkit).
310
311         * Scripts/webkitpy/common/checkout/scm.py:
312
313 2011-01-14  David Levin  <levin@chromium.org>
314
315         Reviewed by Shinichiro Hamaji.
316
317         check-webkit-style: _FunctionState should detect pure functions.
318         https://bugs.webkit.org/show_bug.cgi?id=52428
319
320         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
321         is a pure virtual function.
322         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
323         virtual functions are correctly detected.
324
325 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
326
327         Reviewed by Yury Semikhatsky.
328
329         Just small fix for problem with check-webkit-style.
330         It just didn't work for this patch.
331         Old code can't concatenate a list of strings with None.
332
333         * Scripts/webkitpy/common/checkout/scm.py:
334
335 2011-01-13  David Levin  <levin@chromium.org>
336
337         Reviewed by Shinichiro Hamaji.
338
339         check-webkit-style: _FunctionState should use Position to know where items are.
340         https://bugs.webkit.org/show_bug.cgi?id=52424
341
342         * Scripts/webkitpy/style/checkers/cpp.py:
343         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
344         (detect_functions): Changed to pass Position's to _FunctionState.begin and
345         did some minor clean-up.
346         (*): Other changes are simply about converting to use the Position's in_FunctionState
347         instead of line numbers.
348         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
349         to verify the positions stored in _FunctionState.
350
351 2011-01-13  Eric Seidel  <eric@webkit.org>
352
353         Reviewed by David Levin.
354
355         webkit-patch suggest-reviewers dies when ChangeLogs are missing
356         https://bugs.webkit.org/show_bug.cgi?id=49158
357
358         This is not the most elegant, but it is a very safe fix to this bug.
359         One advantage of catching ScriptError like this instead of adding a
360         new added_or_modified_files or fixing all changed_files callers
361         to use a more specific change_files variant, is that we catch
362         all kinds of ScriptErrors which might cause our (non-essential)
363         suggest-reviewers code to fail out.  This should make passing
364         --suggest-reviewers to webkit-patch upload much more robust
365         and may even make it possible for us to make it default.
366
367         The root of the problem here is that SCM.changed_files includes
368         deleted ChangeLog paths (from moves, etc) which then when we ask
369         SVN/Git for the contents of the file at that revision, the command
370         errors out and Executive.run_command raises a ScriptError.
371
372         In the future we might fix this differently by making all current
373         callers of chagned_files use a more specific method for requesting
374         what types of changes they're interested in (adds, modifies, deletes, etc.)
375
376         * Scripts/webkitpy/common/checkout/api.py:
377         * Scripts/webkitpy/common/checkout/api_unittest.py:
378
379 2011-01-13  Dan Bernstein  <mitz@apple.com>
380
381         Reviewed by Alexey Proskuryakov.
382
383         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
384         https://bugs.webkit.org/show_bug.cgi?id=52419
385
386         Allow to further control the behavior of the willSendRequest delegate callback by making it
387         set a different URL in the new request.
388
389         * DumpRenderTree/LayoutTestController.cpp:
390         (addURLToRedirectCallback): Added.
391         (LayoutTestController::staticFunctions): Added addURLToRedirect.
392         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
393         (LayoutTestController::redirectionDestinationForURL): Added this getter.
394         * DumpRenderTree/LayoutTestController.h:
395         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
396         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
397         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
398         change the URL in the new request to the redirect destination.
399
400 2011-01-13  Eric Seidel  <eric@webkit.org>
401
402         Reviewed by Mihai Parparita.
403
404         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
405         https://bugs.webkit.org/show_bug.cgi?id=52416
406
407         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
408         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
409
410         I also added FIXMEs about the changed_files returning deleted files problem
411         which is causing the other most common exception for suggest-reviewers
412         (and is probably breaking sheriff-bots blame detection).
413
414         * Scripts/webkitpy/common/checkout/api.py:
415         * Scripts/webkitpy/common/checkout/api_unittest.py:
416         * Scripts/webkitpy/common/checkout/scm.py:
417
418 2011-01-13  Eric Seidel  <eric@webkit.org>
419
420         Reviewed by Adam Barth.
421
422         results archives from commit-queue are too large to upload
423         https://bugs.webkit.org/show_bug.cgi?id=52405
424
425         * Scripts/webkitpy/common/system/filesystem.py:
426         * Scripts/webkitpy/common/system/filesystem_mock.py:
427         * Scripts/webkitpy/tool/commands/queues.py:
428
429 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
430
431         Reviewed by Martin Robinson.
432
433         [gtk] Zero-sized font does not yet work
434         https://bugs.webkit.org/show_bug.cgi?id=49793
435
436         Set minimum-font-size to 0 for the DRT.
437
438         * DumpRenderTree/gtk/DumpRenderTree.cpp:
439         (resetDefaultsToConsistentValues):
440
441 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
442
443         Reviewed by Darin Adler.
444
445         Make old-run-webkit-tests more robust on buildbots
446         https://bugs.webkit.org/show_bug.cgi?id=52364
447
448         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
449
450 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
451
452         Reviewed by Darin Adler.
453
454         Make old-run-webkit-tests more robust on buildbots
455         https://bugs.webkit.org/show_bug.cgi?id=52364
456
457         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
458
459 2011-01-13  Tony Chang  <tony@chromium.org>
460
461         Reviewed by Kent Tamura.
462
463         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
464         https://bugs.webkit.org/show_bug.cgi?id=52332
465
466         Forked Info.plist is not longer needed.
467
468         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
469
470 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
471
472         Reviewed by Timothy Hatcher.
473
474         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
475         to be passed directly to WebInspector.UIString
476
477         https://bugs.webkit.org/show_bug.cgi?id=52365
478
479         * Scripts/check-inspector-strings:
480
481 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
482
483         Unreviewed, rolling out r74881.
484         http://trac.webkit.org/changeset/74881
485         https://bugs.webkit.org/show_bug.cgi?id=52357
486
487         The EFL builder has been red for days (Requested by abarth on
488         #webkit).
489
490         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
491         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
492
493 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
494
495         Reviewed by David Levin.
496
497         Add beforeunload support to WebKitTestRunner
498         https://bugs.webkit.org/show_bug.cgi?id=52353
499         
500         This makes a number of currently failing tests pass.
501
502         * WebKitTestRunner/TestController.cpp:
503         (WTR::runBeforeUnloadConfirmPanel):
504         (WTR::createOtherPage):
505         (WTR::TestController::initialize):
506
507 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
508
509         Reviewed by Sam Weinig.
510
511         Detect, identify and recover from WebProcess crashes in run-webkit-tests
512         https://bugs.webkit.org/show_bug.cgi?id=52330
513
514         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
515         a web process crash.
516         * WebKitTestRunner/TestController.cpp:
517         (WTR::TestController::initialize): Set up a processDidCrash
518         callback.
519         (WTR::TestController::processDidCrash): Report that the Web process
520         crashed.
521         * WebKitTestRunner/TestController.h:
522
523 2011-01-12  David Levin  <levin@chromium.org>
524
525         Reviewed by Shinichiro Hamaji.
526
527         check-webkit-style -- close_expression function doesn't work correctly.
528         https://bugs.webkit.org/show_bug.cgi?id=52272
529
530         * Scripts/webkitpy/style/checkers/cpp.py:
531         (Position.__str__): Added a way to convert it to a string which is useful in tests.
532         (Position.__cmp__): Added a way to compare Position which is useful in tests and
533         generally useful (for upcoming code changes).
534         (close_expression): Changed to use Position for input and output.
535         Also, fixed many bugs such as only working correctly for parenthesis,
536         not working correctly if given an offset in a line and not finding
537         the real closing element if there were multiple closing elements in
538         the same line.
539         (detect_functions): Adjusted due to the change in arguments for
540         close_expression.
541         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
542         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
543         two positions are the same.
544         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
545         (CppStyleTest.test_close_expression): Added tests to catch the issues
546         that were fixed.
547
548 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
549
550         Unreviewed, rolling out r75576.
551         http://trac.webkit.org/changeset/75576
552         https://bugs.webkit.org/show_bug.cgi?id=52304
553
554         broke rebaseline-chromium-webkit-test (Requested by thakis on
555         #webkit).
556
557         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
558         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
559         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
560         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
561         * Scripts/webkitpy/layout_tests/port/base.py:
562         * Scripts/webkitpy/layout_tests/port/chromium.py:
563         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
564         * Scripts/webkitpy/layout_tests/port/test.py:
565         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
566         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
567         * Scripts/webkitpy/style/checkers/test_expectations.py:
568         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
569
570 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
571
572         Reviewed by Darin Adler.
573
574         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
575         https://bugs.webkit.org/show_bug.cgi?id=52307
576
577         * Scripts/old-run-webkit-tests:
578
579 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
580
581         Reviewed by Martin Robinson.
582
583         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
584         https://bugs.webkit.org/show_bug.cgi?id=50867
585
586         Fixed library extention for Mac in webkitdirs.pm and type conflict in
587         TestNetscapePlugin.cpp 
588
589         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
590         * Scripts/webkitdirs.pm:
591
592 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
593
594         Reviewed by Pavel Feldman.
595
596         Add check-inspector-strings script.
597
598         https://bugs.webkit.org/show_bug.cgi?id=52295
599
600         * Scripts/check-inspector-strings: Added.
601
602 2011-01-12  Adam Roben  <aroben@apple.com>
603
604         Advertise the .testnetscape file extension on Windows
605
606         Fixes <http://webkit.org/b/52298>
607         plugins/no-mime-with-valid-extension.html fails on Windows
608
609         Reviewed by Dan Bernstein.
610
611         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
612         FileExtents field to map the .testnetscape file extension to the
613         application/x-webkit-test-netscape MIME type, just as we do on Mac.
614
615 2011-01-12  Adam Barth  <abarth@webkit.org>
616
617         Reviewed by Eric Seidel.
618
619         Make webkit-patch support subdirectories for SVN checkouts
620         https://bugs.webkit.org/show_bug.cgi?id=52261
621
622         os.relpath does not exist on Python 2.5, so we need to call our version
623         of the API.
624
625         * Scripts/webkitpy/common/checkout/scm.py:
626
627 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
628
629         Reviewed by Eric Seidel.
630
631         Close additional pages opened during a test once the test completes.
632         https://bugs.webkit.org/show_bug.cgi?id=52276
633
634         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
635         (WTR::InjectedBundle::done):
636
637 2011-01-11  David Levin  <levin@chromium.org>
638
639         Reviewed by Eric Seidel.
640
641         Errors should be separated from the command line in bot messages.
642         https://bugs.webkit.org/show_bug.cgi?id=52275
643
644         * Scripts/webkitpy/common/system/executive.py:
645         (ScriptError.message_with_output): Added a newline to separate the command
646         line from the errors.
647         * Scripts/webkitpy/common/system/executive_unittest.py:
648         (ScriptErrorTest.test_message_with_output): Added tests for the various code
649         paths in message_with_output.
650
651 2011-01-11  Eric Seidel  <eric@webkit.org>
652
653         Unreviewed.
654
655         commit-queue should know how to upload archived results (for test flakes or general failures)
656         https://bugs.webkit.org/show_bug.cgi?id=52048
657
658         The zips are mostly empty due to forgetting -r.
659         Expected diffs were not being pulled from the archive due
660         to the archive having longer paths than I realized.
661
662         * Scripts/webkitpy/common/system/workspace.py:
663         * Scripts/webkitpy/common/system/workspace_unittest.py:
664         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
665         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
666
667 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
668
669         Reviewed by Ojan Vafai.
670
671         The current modifier parsing code in test_expectations is
672         fragile and hard-coded, so it's not easy to understand the logic
673         or easily add new types of modifiers (like GPU vs. CPU testing
674         for graphics tests, or 32-bit vs. 64-bit differences).
675
676         This is the first of two patches that will add in more generic
677         support and then eliminate the GPU-specific test expectations
678         files for Chromium.
679
680         This patch adds two standalone objects for handling modifiers. The
681         rules for interpreting modifiers, precedence, and conflicts are
682         given in the docstring to the ModifierMatcher class, which
683         returns ModifierMatchResult objects.
684         
685         This patch also adds routines to the Port interface and a
686         default set of values in the base object, in order to obtain the
687         values needed on a given test run. These values are then passed
688         to the expectation parser. This also allows us to clean up the
689         logic used to lint all of the different configurations in a
690         single test_expectations.txt file.
691
692         The next patch will merge in the separate GPU expectations file.
693
694         https://bugs.webkit.org/show_bug.cgi?id=51222
695
696         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
697         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
698         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
699         * Scripts/webkitpy/layout_tests/port/base.py:
700         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
701         * Scripts/webkitpy/layout_tests/port/chromium.py:
702         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
703         * Scripts/webkitpy/layout_tests/port/test.py:
704         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
705         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
706
707 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
708
709         Reviewed by Adam Barth.
710
711         Make webkit-patch support subdirectories for SVN checkouts
712         https://bugs.webkit.org/show_bug.cgi?id=52261
713
714         * Scripts/webkitpy/common/checkout/scm.py:
715         * Scripts/webkitpy/style_references.py:
716         * Scripts/webkitpy/tool/main.py:
717         * Scripts/webkitpy/tool/steps/preparechangelog.py:
718
719 2011-01-11  Eric Seidel  <eric@webkit.org>
720
721         Unreviewed.
722
723         commit-queue should know how to upload archived results (for test flakes or general failures)
724         https://bugs.webkit.org/show_bug.cgi?id=52048
725
726         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
727         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
728
729         * Scripts/webkitpy/common/system/workspace.py:
730         * Scripts/webkitpy/common/system/workspace_unittest.py:
731         * Scripts/webkitpy/tool/commands/queues.py:
732
733 2011-01-11  Sam Weinig  <sam@webkit.org>
734
735         Roll r75474 back in.
736
737 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
738
739         Reviewed by Kenneth Rohde Christiansen.
740
741         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
742         https://bugs.webkit.org/show_bug.cgi?id=51204
743
744         * QtTestBrowser/webpage.h:
745         (QtNAMThread::QtNAMThread):
746         (QtNAMThread::networkAccessManager):
747         (QtNAMThread::run):
748
749 2011-01-11  Peter Varga  <pvarga@webkit.org>
750
751         Unreviewed.
752
753         Add myself to committers' list.
754
755         * Scripts/webkitpy/common/config/committers.py:
756
757 2011-01-11  Eric Seidel  <eric@webkit.org>
758
759         Reviewed by Adam Barth.
760
761         commit-queue should know how to upload archived results (for test flakes or general failures)
762         https://bugs.webkit.org/show_bug.cgi?id=52048
763
764         Now the queue will always upload results.  Either the entire zip, or just
765         the diffs.txt in the case of text failures.
766
767         This should make understanding flakes much easier, and paves the way
768         for having the EWS run layout tests (and upload failures).
769
770         In order to upload .zip files I had to teach bugzilla.py to autodetect
771         mime types from the filename.  Since mimetypes.py doesn't include a mapping
772         for .patch files, I have it add one before calling guess_type.
773
774         We may find that always uploading the whole zip instead of just the -diffs.txt
775         file is preferable, but for now I'm keeping the old behavior because it makes
776         quickly understanding text failures easy.
777
778         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
779         * Scripts/webkitpy/common/system/workspace.py: Added.
780         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
781         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
782         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
783         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
784         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
785         * Scripts/webkitpy/tool/commands/queues.py:
786         * Scripts/webkitpy/tool/commands/queues_unittest.py:
787
788 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
789
790         Unreviewed, rolling out r75464.
791         http://trac.webkit.org/changeset/75464
792         https://bugs.webkit.org/show_bug.cgi?id=52193
793
794         Followup rollout for 75474 (Requested by Ossy on #webkit).
795
796         * MiniBrowser/mac/BrowserWindowController.m:
797         (-[BrowserWindowController awakeFromNib]):
798         * MiniBrowser/win/BrowserView.cpp:
799         (BrowserView::create):
800         * WebKitTestRunner/TestController.cpp:
801         (WTR::createOtherPage):
802         (WTR::TestController::initialize):
803
804 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
805
806         Reviewed by Csaba Osztrogonác.
807
808         [Qt] Baseline qt_minimal configuration
809         https://bugs.webkit.org/show_bug.cgi?id=51313
810
811         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
812         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
813         QT_NO_UNDOSTACK guard.
814
815         * QtTestBrowser/launcherwindow.cpp:
816         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
817         guards.
818         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
819         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
820         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
821         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
822
823         * QtTestBrowser/launcherwindow.h:
824         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
825         * QtTestBrowser/locationedit.h: Ditto.
826
827         * QtTestBrowser/mainwindow.cpp:
828         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
829         QT_NO_UNDOSTACK guards.
830         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
831         (MainWindow::changeLocation): Ditto.
832         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
833         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
834
835         * QtTestBrowser/webpage.cpp:
836         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
837         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
838
839         * QtTestBrowser/webview.cpp:
840         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
841         (WebViewGraphicsBased::animatedYFlip): Ditto.
842
843 2011-01-10  Sam Weinig  <sam@webkit.org>
844
845         Fix build.
846
847         * MiniBrowser/mac/BrowserWindowController.m:
848         (-[BrowserWindowController awakeFromNib]):
849         * MiniBrowser/win/BrowserView.cpp:
850         (BrowserView::create):
851         * WebKitTestRunner/TestController.cpp:
852         (WTR::createOtherPage):
853         (WTR::TestController::initialize):
854
855 2011-01-10  Eric Seidel  <eric@webkit.org>
856
857         Reviewed by Ojan Vafai.
858
859         style-queue messages are way too long for big patches
860         https://bugs.webkit.org/show_bug.cgi?id=52161
861
862         We definitely could build much fancier list-to-string-with-limit functions
863         but this should be sufficient for our needs at the moment.
864
865         * Scripts/webkitpy/common/system/executive.py:
866         * Scripts/webkitpy/common/system/executive_unittest.py:
867
868 2011-01-10  Tony Chang  <tony@chromium.org>
869
870         Unreviewed, rolling out r75398.
871         http://trac.webkit.org/changeset/75398
872         https://bugs.webkit.org/show_bug.cgi?id=52008
873
874         Some layout tests are crashing on Chromium Win.
875
876         * DumpRenderTree/chromium/WebViewHost.cpp:
877         (WebViewHost::updatePaintRect):
878         * DumpRenderTree/chromium/WebViewHost.h:
879
880 2011-01-10  Adam Roben  <aroben@apple.com>
881
882         Roll out r75392
883
884         It isn't needed now that r75289 has been rolled out.
885
886         * Scripts/run-javascriptcore-tests:
887
888 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
889
890         Reviewed by Anders Carlsson.
891
892         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
893         https://bugs.webkit.org/show_bug.cgi?id=52160
894
895         * WebKitTestRunner/mac/TestControllerMac.mm:
896         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
897         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
898         anyway.
899
900 2011-01-10  Tony Chang  <tony@chromium.org>
901
902         Reviewed by Mihai Parparita.
903
904         [chromium] fix for animated gif layout tests
905         https://bugs.webkit.org/show_bug.cgi?id=52008
906
907         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
908             to trigger gif animations.
909         (WebViewHostPaintTask::WebViewHostPaintTask):
910         (WebViewHostPaintTask::runIfValid):
911         (WebViewHost::updatePaintRect):
912         * DumpRenderTree/chromium/WebViewHost.h:
913         (WebViewHost::taskList):
914
915 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
916
917         Reviewed by Xan Lopez.
918
919         [GTK] Fix gtk2 compilation for master
920         https://bugs.webkit.org/show_bug.cgi?id=51885
921
922         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
923         (createBitmapContextFromWebView): Replaced the old
924         gdk_drawable_get_size with gdk_pixmap_get_size.
925
926 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
927
928         Reviewed by Laszlo Gombos.
929
930         [WINCE] Reenable NPAPI after r75203
931         https://bugs.webkit.org/show_bug.cgi?id=52109
932
933         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
934         it with !isEfl(), because EFL port does not support NPAPI (yet).
935
936         * Scripts/build-webkit:
937
938 2011-01-10  Adam Roben  <aroben@apple.com>
939
940         Skip some asserting JS tests
941
942         See <http://webkit.org/b/52156>.
943
944         * Scripts/run-javascriptcore-tests:
945
946 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
947
948         Reviewed by Xan Lopez.
949
950         [GTK] build-webkit disable Blob support via arguments passed to automake
951         https://bugs.webkit.org/show_bug.cgi?id=52097
952
953         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
954         build-webkit.
955
956 2011-01-10  Adam Roben  <aroben@apple.com>
957
958         Use the same name and description for TestNetscapePlugin on Windows and
959         Mac
960
961         Fixes <http://webkit.org/b/52151>
962         fast/frames/iframe-reparenting-plugins.html fails on Windows
963
964         Reviewed by Steve Falkenburg.
965
966         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
967         the name and description from Mac's Info.plist.
968
969 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
970
971         Reviewed by Laszlo Gombos.
972
973         [Qt][WK2] Guard gcc-specific syntax
974
975         Non-gcc based compliers choke on the "-include"
976         syntax for preinclude, place guard around it.
977
978         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
979         * WebKitTestRunner/qt/WebKitTestRunner.pro:
980
981 2011-01-10  Andreas Kling  <kling@webkit.org>
982
983         Reviewed by Simon Hausmann.
984
985         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
986         https://bugs.webkit.org/show_bug.cgi?id=52111
987
988         When getting a createNewPage() callback from QWKPage, create the
989         new page with the same QWKContext as the page that is passed to
990         the callback.
991
992         * MiniBrowser/qt/BrowserView.h:
993         * MiniBrowser/qt/BrowserWindow.cpp:
994         (newPageFunction):
995         (BrowserWindow::BrowserWindow):
996         * MiniBrowser/qt/BrowserWindow.h:
997
998 2011-01-10  Andreas Kling  <kling@webkit.org>
999
1000         Reviewed by Kenneth Rohde Christiansen.
1001
1002         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1003
1004         BrowserView set its own useless createNewPage() callback on QWKPage.
1005         This was immediately overridden by BrowserWindow anyway, so remove
1006         the BrowserView one.
1007
1008         * MiniBrowser/qt/BrowserView.cpp:
1009         (BrowserView::BrowserView):
1010
1011 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1012
1013         Reviewed by Jeremy Orlow.
1014
1015         [Chromium] Remove non-client-based Geolocation code
1016         https://bugs.webkit.org/show_bug.cgi?id=50921
1017
1018         * DumpRenderTree/chromium/LayoutTestController.cpp:
1019         (LayoutTestController::setGeolocationPermission):
1020         (LayoutTestController::setMockGeolocationPosition):
1021         (LayoutTestController::setMockGeolocationError):
1022         * DumpRenderTree/chromium/WebViewHost.cpp:
1023         (WebViewHost::geolocationClientMock):
1024         (WebViewHost::reset):
1025         * DumpRenderTree/chromium/WebViewHost.h:
1026
1027 2011-01-10  Eric Seidel  <eric@webkit.org>
1028
1029         Reviewed by Adam Barth.
1030
1031         Commit bot tried to land r? cq+ patch
1032         https://bugs.webkit.org/show_bug.cgi?id=36638
1033
1034         It should now be possible to post a patch with r? and cq+ and the
1035         commit-queue will correctly wait for the r+ before attempting to land the patch.
1036         (This was a feature requested by several users.)
1037
1038         One caveat: We don't actually reject r-, cq+ patches from the queue
1039         (we just ignore them), but I think that's OK for now.
1040
1041         I also noticed that setting r- once a commit-queue node had grabbed
1042         a patch would not properly cancel the landing.  That's fixed and
1043         tested in this patch.
1044
1045         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1046         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1047         * Scripts/webkitpy/tool/bot/feeders.py:
1048         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1049
1050 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1051
1052         Reviewed by Kenneth Rohde Christiansen.
1053
1054         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1055         https://bugs.webkit.org/show_bug.cgi?id=51934
1056
1057         When accessing the network from the destructor of QWebPage, the network access manager
1058         was already deleted because the object WebPage was already destructed.
1059
1060         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1061         The object is now destructed in the destructor of QObject.
1062
1063         * QtTestBrowser/webpage.cpp:
1064         (WebPage::WebPage):
1065         (WebPage::setQnamThreaded):
1066         * QtTestBrowser/webpage.h:
1067         (QtNAMThread::QtNAMThread):
1068
1069 2011-01-08  Eric Seidel  <eric@webkit.org>
1070
1071         Reviewed by Ojan Vafai.
1072
1073         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1074         https://bugs.webkit.org/show_bug.cgi?id=52067
1075
1076         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1077         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1078
1079         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1080
1081 2011-01-08  Eric Seidel  <eric@webkit.org>
1082
1083         Reviewed by Mihai Parparita.
1084
1085         commit-queue hangs when the ChangeLog diff is bad
1086         https://bugs.webkit.org/show_bug.cgi?id=52072
1087
1088         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1089         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1090
1091 2011-01-08  Adam Barth  <abarth@webkit.org>
1092
1093         Teach svn-apply how to re-write WebCore to Source/WebCore.
1094
1095         * Scripts/VCSUtils.pm:
1096
1097 2011-01-07  Adam Barth  <abarth@webkit.org>
1098
1099         Rubber-stamped by Eric Seidel.
1100
1101         Move WebCore to Source
1102         https://bugs.webkit.org/show_bug.cgi?id=52050
1103
1104         Update the tools to understand WebCore's new location.
1105
1106         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1107         * DumpRenderTree/wscript:
1108         * GNUmakefile.am:
1109         * Scripts/build-webkit:
1110         * Scripts/do-file-rename:
1111         * Scripts/do-webcore-rename:
1112         * Scripts/generate-qt-inspector-resource:
1113         * Scripts/prepare-ChangeLog:
1114         * Scripts/run-bindings-tests:
1115         * Scripts/update-iexploder-cssproperties:
1116         * Scripts/update-sources-list.py:
1117         * Scripts/update-webkit-localizable-strings:
1118         * Scripts/webkitdirs.pm:
1119         * Scripts/webkitpy/common/config/build.py:
1120         * Scripts/webkitpy/common/config/build_unittest.py:
1121         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1122         * Scripts/webkitpy/style/checker.py:
1123         * Scripts/webkitpy/style/checker_unittest.py:
1124         * WebKitTestRunner/DerivedSources.pro:
1125         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1126         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1127         * wx/browser/wscript:
1128         * wx/build/settings.py:
1129
1130 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1131
1132         Reviewed by Sam Weinig.
1133
1134         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1135         https://bugs.webkit.org/show_bug.cgi?id=52086
1136
1137         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1138         (WTR::InjectedBundle::didReceiveMessage):
1139         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1140         (WTR::LayoutTestController::notifyDone):
1141         * WebKitTestRunner/TestController.cpp:
1142         (WTR::TestController::resetStateToConsistentValues):
1143         (WTR::TestController::run):
1144
1145 2011-01-07  James Robinson  <jamesr@chromium.org>
1146
1147         Revert "Implement mozilla's animationTime property"
1148         https://bugs.webkit.org/show_bug.cgi?id=51952
1149
1150         This approach isn't quite right.
1151
1152         * DumpRenderTree/chromium/WebViewHost.cpp:
1153         (WebViewHost::paintInvalidatedRegion):
1154
1155 2011-01-07  Adam Roben  <aroben@apple.com>
1156
1157         Build master fix
1158
1159         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1160         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1161
1162 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1163
1164         Reviewed by Csaba Osztrogonác.
1165
1166         run-qtwebkit-tests should be able to kill a testsuite.
1167
1168         Add new option in the script that can setup a timeout for a test.
1169         If the test execution takes more then specified time then the test
1170         would be terminated.
1171
1172         [Qt] run-qtwebkit-tests needs timeout
1173         https://bugs.webkit.org/show_bug.cgi?id=51894
1174
1175         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1176         * Scripts/run-qtwebkit-tests:
1177
1178 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1179
1180         Unreviewed fix after r75233.
1181
1182         Based on idea from Eric Seidel.
1183
1184         Add remote zip file handling to webkitpy.
1185         https://bugs.webkit.org/show_bug.cgi?id=50901
1186
1187         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1188
1189 2011-01-07  Shane Stephens  <shanestephens@google.com>
1190
1191         Reviewed by Eric Seidel.
1192
1193         svn-apply: should support git binary delta diffs
1194         https://bugs.webkit.org/show_bug.cgi?id=38864
1195
1196         * Scripts/VCSUtils.pm:
1197         * Scripts/svn-apply:
1198
1199 2011-01-06  Julie Parent  <jparent@chromium.org>
1200
1201         Reviewed by Eric Seidel.
1202
1203         Test Result Server not removing old results.
1204         https://bugs.webkit.org/show_bug.cgi?id=52012
1205
1206         * TestResultServer/model/jsonresults.py:
1207         Fix off-by-one: Truncate if >= num_runs, not just >.
1208         * TestResultServer/model/jsonresults_unittest.py:
1209         Add unit test to test that merging in a new result with the same value
1210         as the last result causes previous result to fall off.
1211
1212 2011-01-06  James Kozianski  <koz@chromium.org>
1213
1214         Reviewed by Mihai Parparita.
1215
1216         Add classes to provide a consistent interface to a set of files.
1217         https://bugs.webkit.org/show_bug.cgi?id=50901
1218
1219         These classes allow us to write code that is agnostic to whether a
1220         particular set of files resides in a local directory or in a zip file
1221         on a remote machine.
1222
1223         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1224         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1225         * Scripts/webkitpy/common/system/fileset.py: Added.
1226         * Scripts/webkitpy/common/system/filesystem.py:
1227         * Scripts/webkitpy/common/system/filesystem_mock.py:
1228         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1229         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1230
1231 2011-01-06  Eric Seidel  <eric@webkit.org>
1232
1233         Reviewed by Adam Barth.
1234
1235         NetworkTransaction should log the url it is retrying
1236         https://bugs.webkit.org/show_bug.cgi?id=52043
1237
1238         * Scripts/webkitpy/common/net/networktransaction.py:
1239         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1240
1241 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1242
1243         Windows build fix.
1244         Import os before using it.
1245
1246         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1247
1248 2011-01-06  Eric Seidel  <eric@webkit.org>
1249
1250         Reviewed by Adam Barth.
1251
1252         StyleQueue fails to report errors when patches have many files
1253         https://bugs.webkit.org/show_bug.cgi?id=52042
1254
1255         This is one of at least two errors preventing style error reporting at the moment.
1256         When we moved to passing the list of files to check explicitly,
1257         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1258         We could change the type of the QueueStatus.message type, or we could
1259         just teach statusserver.py how to clamp values (and warn when it does).
1260         I chose the latter path.
1261
1262         * Scripts/webkitpy/common/net/statusserver.py:
1263
1264 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1265
1266         Reviewed by Stephanie Lewis.
1267         
1268         Fix syntax error in script.
1269
1270         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1271         https://bugs.webkit.org/show_bug.cgi?id=51996
1272
1273         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1274
1275 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1276
1277         Unreviewed, fixing WinCE build after r75196.
1278
1279         WinCE port does not (yet) support NPAPI.
1280
1281         * Scripts/build-webkit:
1282
1283 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1284
1285         Reviewed by Darin Adler.
1286
1287         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1288         https://bugs.webkit.org/show_bug.cgi?id=52015
1289
1290         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1291         after the platform has been detected, otherwise the script will
1292         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1293         detection.
1294
1295 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1296
1297         Reviewed by Eric Seidel.
1298
1299         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1300         https://bugs.webkit.org/show_bug.cgi?id=51346
1301
1302         * Scripts/build-webkit:
1303
1304 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1305
1306         Reviewed by Adam Roben.
1307
1308         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1309         https://bugs.webkit.org/show_bug.cgi?id=51996
1310         
1311         After the configuration directory change, we were archiving the incorrect directory for
1312         build product, so we were running tests on the wrong binaries.
1313         
1314         This change archives the correct directory, and also unarchives it into a configuration-
1315         specific directory.
1316
1317         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1318         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1319
1320 2011-01-06  Eric Seidel  <eric@webkit.org>
1321
1322         Reviewed by Mihai Parparita.
1323
1324         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1325         https://bugs.webkit.org/show_bug.cgi?id=52002
1326
1327         See an example of this here:
1328         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1329
1330         It's due to the fact that we pass around TestFailure() instance
1331         objects and yet expect them to all compare to be the same.
1332
1333         This is bad.  We should either have shared instances of these values
1334         or we should just pass around the class names.  There are already hacks
1335         in place to make TestFailure objects pass equality tests, I just added
1336         a __hash__ implementation so they can be used in sets as expected.
1337
1338         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1339         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1340
1341 2011-01-06  Evan Martin  <evan@chromium.org>
1342
1343         Reviewed by Tony Chang.
1344
1345         [gdb] handle inaccessible memory and UChar*
1346         https://bugs.webkit.org/show_bug.cgi?id=52003
1347
1348         To pretty-print a UChar*, we just grope around in the memory
1349         looking for a terminating NUL.  We need to handle the exception
1350         that can occur when we poke into an invalid location.
1351
1352         Additionally, the logic for choosing which pretty-printer would
1353         early return before hitting the point where we'd use the UChar*
1354         printer.  (Did this ever work?  How did it regress?)
1355
1356         * gdb/webkit.py:
1357
1358 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1359
1360         Reviewed by Ada Chan.
1361
1362         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1363         https://bugs.webkit.org/show_bug.cgi?id=51969
1364         
1365         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1366
1367         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1368         (WTR::InjectedBundlePage::InjectedBundlePage):
1369         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1370         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1371
1372 2011-01-06  James Robinson  <jamesr@chromium.org>
1373
1374         Reviewed by Simon Fraser.
1375
1376         Implement mozilla's animationTime property
1377         https://bugs.webkit.org/show_bug.cgi?id=51952
1378
1379         Chromium DRT support for webkitAnimationTime.
1380
1381         * DumpRenderTree/chromium/WebViewHost.cpp:
1382         (WebViewHost::paintInvalidatedRegion):
1383
1384 2011-01-06  Julie Parent  <jparent@chromium.org>
1385
1386         Reviewed by Tony Chang.
1387
1388         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1389         https://bugs.webkit.org/show_bug.cgi?id=51217
1390
1391         * TestResultServer/model/jsonresults.py:
1392         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1393         Adds missing documentation.
1394         * TestResultServer/model/jsonresults_unittest.py:
1395         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1396         Update test_merge to take a number of builds to truncate at.
1397
1398 2011-01-06  Adam Barth  <abarth@webkit.org>
1399
1400         Reviewed by Eric Seidel.
1401
1402         The EWS should log outside of the working directory
1403         https://bugs.webkit.org/show_bug.cgi?id=51986
1404
1405         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1406         script, which will actually clean the working copy back to a pristine
1407         state instead of leaving untracked directories and ignored files.
1408
1409         * Scripts/webkitpy/tool/commands/queues.py:
1410         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1411
1412 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1413
1414         Windows build fix.
1415         Back out attempted change to built-product-archive.
1416
1417         * BuildSlaveSupport/built-product-archive:
1418
1419 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1420
1421         Windows build fix.
1422         Include configuration name when unpacking a build archive.
1423
1424         Needed, since we split Windows build results into configuration-specific directories
1425         under WebKitOutputDir.
1426
1427         * BuildSlaveSupport/built-product-archive:
1428
1429 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1430
1431         Reviewed by Darin Adler.
1432
1433         Debug and Release builds on Windows clobber each other
1434         https://bugs.webkit.org/show_bug.cgi?id=49185
1435
1436         Changes the structure of WebKitBuild build products directory so we
1437         completely separate each build configuration into independent directories.
1438         
1439         Although we previously had per-configuration directories for obj, this change adds
1440         per-configuration directories for bin, lib, obj, and include. Each configuration's
1441         build products are stored within a directory inside of WebKitBuild.
1442         
1443         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1444         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1445
1446         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1447         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1448         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1449         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1450         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1451         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1452         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1453         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1454         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1455         * FindSafari/FindSafari.vcproj:
1456         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1457         * MiniBrowser/MiniBrowserPostBuild.cmd:
1458         * MiniBrowser/MiniBrowserPreBuild.cmd:
1459         * Scripts/webkitdirs.pm:
1460         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1461         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1462         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1463         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1464         * TestWebKitAPI/win/copy-resources.cmd:
1465         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1466         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1467         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1468         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1469         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1470         * WebKitTestRunner/win/InjectedBundle.vcproj:
1471         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1472         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1473         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1474         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1475         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1476         * WinLauncher/WinLauncherCommon.vsprops:
1477         * WinLauncher/WinLauncherPostBuild.cmd:
1478         * WinLauncher/WinLauncherPreBuild.cmd:
1479
1480 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1481
1482         Reviewed by Ariya Hidayat.
1483
1484         [Qt] TestNetscapePlugin doesn't link on OS X
1485         https://bugs.webkit.org/show_bug.cgi?id=51948
1486
1487         Only add a dependency on libX11 on X11 systems
1488
1489         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1490
1491 2011-01-05  Jeff Miller  <jeffm@apple.com>
1492
1493         Reviewed by Adam Roben.
1494
1495         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1496         https://bugs.webkit.org/show_bug.cgi?id=51970
1497
1498         * Scripts/webkitpy/style/checker.py:
1499         Add -readability/naming for WebKit2 C API directories.
1500
1501 2011-01-05  Eric Seidel  <eric@webkit.org>
1502
1503         Unreviewed, just fixing one more log error from my previous python patch.
1504
1505         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1506         https://bugs.webkit.org/show_bug.cgi?id=51802
1507
1508         webkit-patch failure-reason was logging about parsing errors
1509         due to my misunderstanding of how BeautifulSoup.findAll worked.
1510
1511         Fixed, and added a unit test.
1512
1513         * Scripts/webkitpy/common/net/layouttestresults.py:
1514         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1515
1516 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1517
1518         Reviewed by Kenneth Rohde Christiansen.
1519
1520         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1521         https://bugs.webkit.org/show_bug.cgi?id=51951
1522
1523         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1524         to create new window from WebKit.
1525
1526         * MiniBrowser/qt/BrowserWindow.cpp:
1527         (newPageFunction):
1528         (BrowserWindow::BrowserWindow):
1529         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1530         (BrowserWindow::newWindow):
1531         (BrowserWindow::updateUserAgentList):
1532         (BrowserWindow::showUserAgentDialog):
1533         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1534         define the type of the backing store used for new windows.
1535         * MiniBrowser/qt/main.cpp:
1536         (main):
1537
1538 2011-01-05  Eric Seidel  <eric@webkit.org>
1539
1540         Reviewed by Ojan Vafai.
1541
1542         commit-queue should report failure type when reporting flaky tests
1543         https://bugs.webkit.org/show_bug.cgi?id=51900
1544
1545         This patch was a ridiculous amount of plumbing.  In the end I like
1546         the NRWT-style TestResult class even less.  But now we're passing
1547         a list of TestResult objects from the queue to the FlakyTestReporter.
1548         Thus the FlakyTestReporter can more easily report what type of failure
1549         occurred.
1550
1551         In the process, I found that I was not alone in finding TestResult
1552         cumbersome to use.  A bunch of code was trying to create a TestResult
1553         object with default values.  However since the constructor didn't make
1554         this easy, some places were getting it wrong (including the TestResult unit test)!
1555         I've fixed the TestResult constructor to have default values for non-essential
1556         arguments.
1557
1558         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1559         * Scripts/webkitpy/common/net/layouttestresults.py:
1560         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1561         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1562         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1563         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1564         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1565         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1566         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1567         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1568         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1569         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1570         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1571         * Scripts/webkitpy/tool/commands/queues.py:
1572         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1573
1574 2011-01-05  Eric Seidel  <eric@webkit.org>
1575
1576         Unreviewed.
1577
1578         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1579         https://bugs.webkit.org/show_bug.cgi?id=51802
1580
1581         Add another unit test to cover a previously missing import.
1582
1583         * Scripts/webkitpy/common/net/layouttestresults.py:
1584         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1585
1586 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1587
1588         Reviewed by David Levin.
1589
1590         Add mihaip@chromium.org as a reviewer
1591         https://bugs.webkit.org/show_bug.cgi?id=51966
1592         
1593         Add myself as a reviewer.
1594
1595         * Scripts/webkitpy/common/config/committers.py:
1596
1597 2011-01-05  James Simonsen  <simonjam@chromium.org>
1598
1599         Unreviewed. Adding myself to the list of committers.
1600
1601         * Scripts/webkitpy/common/config/committers.py:
1602
1603 2011-01-05  Eric Seidel  <eric@webkit.org>
1604
1605         Unreviewed.
1606
1607         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1608         https://bugs.webkit.org/show_bug.cgi?id=51802
1609
1610         Fix two exceptions seen on the bots after my original commit.
1611
1612         * Scripts/webkitpy/common/net/layouttestresults.py:
1613         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1614
1615 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1616
1617         Reviewed by Andreas Kling.
1618
1619         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1620         https://bugs.webkit.org/show_bug.cgi?id=51750
1621
1622         * QtTestBrowser/main.cpp:
1623         (LauncherApplication::handleUserOptions):
1624          Local storage settings can be enable form command line arguments for
1625          QtTestBrowser.
1626
1627 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1628
1629         Reviewed by Martin Robinson.
1630
1631         GTK: AX: DRT needs to use correct root object method.
1632         https://bugs.webkit.org/show_bug.cgi?id=51911
1633
1634         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1635         (AccessibilityController::rootElement):
1636
1637 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1638
1639         Rubber-stamped by Csaba Osztrogonác.
1640
1641         Based on idea from Péter Gál.
1642
1643         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1644
1645 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1646
1647         Reviewed by Adam Barth.
1648
1649         sheriff-bot should be able to do multi-revision rollouts
1650         https://bugs.webkit.org/show_bug.cgi?id=51176
1651
1652         * Scripts/webkitpy/tool/bot/irc_command.py:
1653         * Scripts/webkitpy/tool/bot/sheriff.py:
1654         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1655
1656 2011-01-05  Eric Seidel  <eric@webkit.org>
1657
1658         Reviewed by Adam Barth.
1659
1660         queues.webkit.org should have per-bot status pages
1661         https://bugs.webkit.org/show_bug.cgi?id=51906
1662
1663         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1664         statuses from a single queue.  Now that we have many bots servicing
1665         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1666         you care about scroll off the end of the 15-message limit on the main page.
1667
1668         Eventually we should probably rename /queue-status to /queue or /queues,
1669         but that's fodder for another patch.
1670
1671         * QueueStatusServer/handlers/queuestatus.py:
1672         * QueueStatusServer/index.yaml:
1673         * QueueStatusServer/main.py:
1674         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1675          - This probably should use a custom filter instead of hard-coding
1676            the URL scheme here, but I couldn't figure out how to easily
1677            create such a filter.  Most filters work with "strings" so we can't
1678            pass the status object.  We could add a method to the status
1679            object and call that, but that seemed a bit strange too.
1680         * QueueStatusServer/templates/queuestatus.html:
1681
1682 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1683
1684         Unreviewed. Adding myself to the list of committers.
1685
1686         * Scripts/webkitpy/common/config/committers.py:
1687
1688 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1689
1690         Reviewed by David Levin.
1691
1692         check-webkit-style treated some macros with parentheses after #elif as function calls
1693         https://bugs.webkit.org/show_bug.cgi?id=51695
1694
1695         Ingore function call space checking in any preprocessor directives
1696         (things starting with #). Change search() to match() because 
1697         preprocessor directives are supposed to be in the beginning of lines.
1698
1699         * Scripts/webkitpy/style/checkers/cpp.py:
1700         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1701
1702 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1703
1704         Reviewed by Tony Chang.
1705
1706         Change the --multi-load test option to --stress-opt
1707         https://bugs.webkit.org/show_bug.cgi?id=50751
1708
1709         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1710         (runTest):
1711         (main):
1712         * DumpRenderTree/chromium/TestShell.cpp:
1713         (TestShell::TestShell):
1714         * DumpRenderTree/chromium/TestShell.h:
1715         (TestShell::stressOpt):
1716         (TestShell::setStressOpt):
1717         (TestShell::stressDeopt):
1718         (TestShell::setStressDeopt):
1719         (TestShell::javaScriptFlags):
1720         (TestShell::setJavaScriptFlags):
1721         * Scripts/webkitpy/layout_tests/port/chromium.py:
1722         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1723
1724 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1725
1726         Reviewed by Sam Weinig.
1727
1728         WK2: Support Accessibility
1729         https://bugs.webkit.org/show_bug.cgi?id=51859
1730
1731         Use rootObject() method to get top of accessibility tree.
1732
1733         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1734         (AccessibilityController::focusedElement):
1735         (AccessibilityController::rootElement):
1736
1737 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1738
1739         Reviewed by Darin Adler.
1740
1741         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1742         https://bugs.webkit.org/show_bug.cgi?id=51846
1743
1744         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1745         back to GRefPtr.
1746
1747 2011-01-04  Zhe Su  <suzhe@chromium.org>
1748
1749         Reviewed by Kenneth Russell.
1750
1751         Fix insertText, setMarkedText and unmarkText methods of
1752         TextInputController to call corresponding methods of WebKit::WebView
1753         rather than WebKit::WebFrame. This change matches the behavior of
1754         chromium browser.
1755         insertText corresponds to WebView::confirmComposition(text)
1756         setMarkedText corresponds to WebView::setComposition(...)
1757         unmarkText corresponds to WebView::confirmComposition()
1758         https://bugs.webkit.org/show_bug.cgi?id=51693
1759
1760         * DumpRenderTree/chromium/TextInputController.cpp:
1761         (TextInputController::insertText):
1762         (TextInputController::setMarkedText):
1763         (TextInputController::unmarkText):
1764
1765 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1766
1767         Reviewed by Laszlo Gombos.
1768
1769         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1770
1771         On Symbian productDir points to the source directory. Removing all the
1772         empty files from the productDir directory corrupts the svn repository.
1773
1774         * Scripts/build-webkit:
1775
1776 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1777
1778         Reviewed by Adam Barth.
1779
1780         [Qt] Add SelectAll option to the context menu for the editor
1781         https://bugs.webkit.org/show_bug.cgi?id=50049
1782
1783         Set shortcut for the SelectAll action.
1784
1785         * QtTestBrowser/mainwindow.cpp:
1786         (MainWindow::buildUI):
1787
1788 2011-01-03  David Levin  <levin@chromium.org>
1789
1790         Reviewed by Eric Seidel.
1791
1792         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1793         https://bugs.webkit.org/show_bug.cgi?id=51842
1794
1795         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1796         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1797
1798 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1799
1800         Reviewed by David Kilzer.
1801
1802         [WINCE] Adds a build slave.
1803         https://bugs.webkit.org/show_bug.cgi?id=50523
1804
1805         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1806         entry for a release build of the WinCE port.
1807         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1808         flag to build the WinCE port.
1809
1810 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1811
1812         Reviewed by David Kilzer.
1813
1814         Add WinCE support to build-webkit
1815         https://bugs.webkit.org/show_bug.cgi?id=51642
1816
1817         * Scripts/build-webkit:
1818         * Scripts/webkitdirs.pm:
1819
1820 2011-01-03  Eric Seidel  <eric@webkit.org>
1821
1822         Reviewed by Adam Barth.
1823
1824         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1825         https://bugs.webkit.org/show_bug.cgi?id=51802
1826
1827         I'm not the biggest fan of the test_failures or test_results classes,
1828         but it's better to have one shared set of classes, than separate ones
1829         for new vs. old run-webkit-test result handling.
1830
1831         This moves the ORWT results class "LayoutTestResults" over to using
1832         TestResult and TestFailure classes, making it easy for us to
1833         make all our sheriff-bot and other webkitpy code NRWT ready.
1834
1835         This also makes it a trivial patch to generate results.json information
1836         from ORWT results.html files (for flaky test analysis, etc.) as well
1837         as making it a one-liner to report test failure types when the
1838         commit-queue sees flaky tests.
1839
1840         This patch tried not to add new functionality, but only to replace
1841         the guts of LayoutTestResults, while adding unit tests and hoping
1842         not to break anything.
1843
1844         I also moved callers which assumed User.prompt* were static/class methods
1845         to using them as instance methods (since we'll eventually want to make them such).
1846
1847         In the process of re-writing things, I broke the rebaseline command, so I wrote
1848         a unit test to catch my breakage were I do do so again in the future.
1849
1850         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1851         * Scripts/webkitpy/common/net/layouttestresults.py:
1852         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1853         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1854         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1855         * Scripts/webkitpy/tool/commands/queries.py:
1856         * Scripts/webkitpy/tool/commands/rebaseline.py:
1857         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1858         * Scripts/webkitpy/tool/mocktool.py:
1859
1860 2011-01-03  Adam Barth  <abarth@webkit.org>
1861
1862         Reviewed by Simon Fraser.
1863
1864         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1865         https://bugs.webkit.org/show_bug.cgi?id=51840
1866
1867         * Scripts/webkitpy/common/checkout/scm.py:
1868
1869 2011-01-03  Adam Barth  <abarth@webkit.org>
1870
1871         Reviewed by Simon Fraser.
1872
1873         webkit-patch should only hide update output if --quiet
1874         https://bugs.webkit.org/show_bug.cgi?id=51838
1875
1876         As requested by smfr.
1877
1878         * Scripts/webkitpy/tool/steps/update.py:
1879
1880 2011-01-03  Adam Barth  <abarth@webkit.org>
1881
1882         Reviewed by David Levin.
1883
1884         commit-queue shouldn't reject patches twice if two bots process the same patch
1885         https://bugs.webkit.org/show_bug.cgi?id=51805
1886
1887         Before raising an error, we first check whether the patch is still in
1888         the commit-queue.  This check is still racy, of course, but the time
1889         window is much smaller.
1890
1891         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1892
1893 2011-01-03  Sam Weinig  <sam@webkit.org>
1894
1895         Reviewed by Anders Carlsson.
1896
1897         Make run-api-tests less chatty.
1898         https://bugs.webkit.org/show_bug.cgi?id=51831
1899
1900         - Make script quiet by default and add --verbose option (replacing --quiet).
1901         - When not verbose, pipe stdout and stderr to devnull.
1902
1903         * Scripts/run-api-tests:
1904
1905 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1906
1907         Unreviewed. Adding myself to committers.py.
1908
1909         * Scripts/webkitpy/common/config/committers.py:
1910
1911 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1912
1913         Reviewed by Xan Lopez.
1914
1915         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1916         https://bugs.webkit.org/show_bug.cgi?id=51806
1917
1918         Originally, the $libraryName is 'JavaScriptCore'. When building release 
1919         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1920         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1921         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
1922         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1923         so make it 'WebKitBuild/Release/.libs'
1924
1925         * Scripts/webkitdirs.pm: 
1926
1927 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1928
1929         Reviewed by Adam Barth.
1930
1931         Make EFL a core builder
1932         https://bugs.webkit.org/show_bug.cgi?id=51804
1933
1934         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1935         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1936
1937 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1938
1939         [Qt] Unreviewed fix after r74855 and r74875.
1940
1941         * BuildSlaveSupport/built-product-archive:
1942          - Create directories explicitly.
1943          - Pass shell=True to subprocess.call().
1944
1945 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1946
1947         [Qt] Unreviewed fix after r74855.
1948
1949         Move JavaScriptCore to Source
1950         https://bugs.webkit.org/show_bug.cgi?id=51604
1951
1952         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1953
1954 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1955
1956         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1957
1958         Move JavaScriptCore to Source
1959         https://bugs.webkit.org/show_bug.cgi?id=51604
1960
1961         * Scripts/webkitdirs.pm:
1962
1963 2011-01-02  Robert Hogan  <robert@webkit.org>
1964
1965         Unreviewed, build fix.
1966
1967         [Qt] Fix DRT build after 74855
1968
1969         * DumpRenderTree/qt/DumpRenderTree.pro:
1970
1971 2011-01-01  Adam Barth  <abarth@webkit.org>
1972
1973         Remove the assumption from the Qt and Gtk builds that every project is
1974         in the root directory.
1975
1976         * Scripts/build-webkit:
1977
1978 2011-01-01  Adam Barth  <abarth@webkit.org>
1979
1980         Reviewed by Eric Seidel.
1981
1982         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1983         https://bugs.webkit.org/show_bug.cgi?id=51796
1984
1985         After this change, svn-apply will magically apply patches to
1986         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1987
1988         * Scripts/VCSUtils.pm:
1989
1990 2011-01-01  Adam Barth  <abarth@webkit.org>
1991
1992         Reviewed by Eric Seidel.
1993
1994         Move JavaScriptCore to Source
1995         https://bugs.webkit.org/show_bug.cgi?id=51604
1996
1997         Update references to JavaScriptCore to point to the new location.
1998
1999         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2000         * DumpRenderTree/qt/DumpRenderTree.pro:
2001         * DumpRenderTree/qt/ImageDiff.pro:
2002         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2003         * DumpRenderTree/wscript:
2004         * Scripts/build-jsc:
2005         * Scripts/build-webkit:
2006         * Scripts/do-file-rename:
2007         * Scripts/do-webcore-rename:
2008         * Scripts/run-javascriptcore-tests:
2009         * Scripts/update-javascriptcore-test-results:
2010         * Scripts/webkitdirs.pm:
2011         * Scripts/webkitpy/common/config/build_unittest.py:
2012         * Scripts/webkitpy/style/checker.py:
2013         * Scripts/webkitpy/style/checker_unittest.py:
2014         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2015         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2016         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2017         * wx/build/settings.py:
2018
2019 2011-01-01  Adam Barth  <abarth@webkit.org>
2020
2021         Reviewed by Eric Seidel.
2022
2023         Move Sources to Source
2024         https://bugs.webkit.org/show_bug.cgi?id=51794
2025
2026         Update scripts to point to the new location.
2027
2028         * Scripts/build-webkit:
2029         * Scripts/do-file-rename:
2030         * Scripts/do-webcore-rename:
2031         * Scripts/webkitpy/common/config/build.py:
2032         * Scripts/webkitpy/common/config/build_unittest.py:
2033
2034 2010-12-31  Kent Tamura  <tkent@chromium.org>
2035
2036         Reviewed by Eric Seidel.
2037
2038         [DRT/Chromium] Enable mock spell checker on non-OSX
2039         https://bugs.webkit.org/show_bug.cgi?id=51401
2040
2041         * DumpRenderTree/chromium/WebViewHost.cpp:
2042         (WebViewHost::spellCheck):
2043
2044 2010-12-31  Adam Barth  <abarth@webkit.org>
2045
2046         Reviewed by Ariya Hidayat.
2047
2048         Remove Tools/Scripts/wkstyle
2049         https://bugs.webkit.org/show_bug.cgi?id=51774
2050
2051         This script appears to not have been touched in a while and seems to
2052         have been replaced by check-webkit-style.
2053
2054         * Scripts/wkstyle: Removed.
2055
2056 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2057
2058         Unreviewed. Coding style fix.
2059
2060         * DumpRenderTree/chromium/TestShell.h:
2061
2062 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2063
2064         Reviewed by Pavel Feldman.
2065
2066         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2067
2068         It was a problem with Chromium DRT. DevToolsAgent object instance was
2069         attached not only to the inspected page but to the DevTools window too.
2070         As result all the inspector files were interpreted as a content of inspected page
2071         and were transfered to the DevTools scripts panel for debugging etc.
2072
2073         https://bugs.webkit.org/show_bug.cgi?id=51735
2074
2075         * DumpRenderTree/chromium/TestShell.cpp:
2076         (TestShell::TestShell):
2077         (TestShell::bindJSObjectsToWindow):
2078         (TestShell::createNewWindow):
2079         * DumpRenderTree/chromium/TestShell.h:
2080
2081 2010-12-31  Adam Barth  <abarth@webkit.org>
2082
2083         Rubber-stamped by Eric Seidel.
2084
2085         Move PageLoadTests to PerformanceTests/PageLoad
2086         https://bugs.webkit.org/show_bug.cgi?id=51771
2087
2088         Update references to PageLoadTests to point to the new location.
2089
2090         * Scripts/run-pageloadtest:
2091         * Scripts/webkitpy/common/config/build.py:
2092
2093 2010-12-31  Adam Barth  <abarth@webkit.org>
2094
2095         Rubber-stamped by Eric Seidel.
2096
2097         Move SunSpider into PerformanceTests
2098         https://bugs.webkit.org/show_bug.cgi?id=51769
2099
2100         Update these scripts to point to the new location.
2101
2102         * Scripts/run-sunspider:
2103         * Scripts/sunspider-compare-results:
2104
2105 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2106
2107         Reviewed by Kent Tamura.
2108
2109         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2110         https://bugs.webkit.org/show_bug.cgi?id=51728
2111         
2112         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2113         to render top-level scrollbars. This makes them match the Mac port's
2114         use of an NSScrollView, which means that we'll be able to share more
2115         pixel baselines.
2116         
2117         The new rendering code will not be activated until the 
2118         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2119         ScrollbarThemeChromiumMac.
2120
2121         * DumpRenderTree/DumpRenderTree.gypi:
2122         * DumpRenderTree/chromium/TestShellMac.mm:
2123         (platformInit):
2124         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2125         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2126         (+[FakeActiveWindow alwaysActiveWindow]):
2127         (+[FakeActiveWindow alwaysInactiveWindow]):
2128         (-[FakeActiveWindow initWithActiveControls:]):
2129         (-[FakeActiveWindow _hasActiveControls]):
2130         (WebThemeEngineDRTMac::paintScrollbarThumb):
2131         (stateToHIEnableState):
2132         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2133         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2134
2135 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2136
2137         Reviewed by David Kilzer.
2138
2139         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2140         used
2141         https://bugs.webkit.org/show_bug.cgi?id=51672
2142
2143         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2144         with USE_SYSTEM_MALLOC=1
2145         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2146         with USE_SYSTEM_MALLOC=1
2147
2148 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2149
2150         Reviewed by David Kilzer.
2151
2152         [Qt] [Symbian] Fix build-webkit script for Symbian
2153         https://bugs.webkit.org/show_bug.cgi?id=51509
2154
2155         Set the OUTPUT_DIR for Symbian to be the same as the source
2156         directory.
2157
2158         * Scripts/webkitdirs.pm:
2159
2160 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2161
2162         Reviewed by Darin Adler.
2163
2164         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2165         https://bugs.webkit.org/show_bug.cgi?id=51758
2166
2167         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2168
2169         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2170         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2171
2172 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2173
2174         Unreviewed WinCE buildfix.
2175
2176         * WinCELauncher/main.cpp: Add missing include.
2177
2178 2010-12-29  Daniel Bates  <dbates@rim.com>
2179
2180         Reviewed by Darin Adler.
2181
2182         svn-apply updates date of wrong change log entry for a change log diff that
2183         contains two consecutive entries with the same author and date
2184         https://bugs.webkit.org/show_bug.cgi?id=46061
2185
2186         Fixes an issue where the date of the wrong change log entry may be modified.
2187         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2188         in a ChangeLog file to the top of the file.
2189
2190         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2191         diff when it detects that the diff inserts a change log entry earlier in a
2192         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2193         change. With the advent of the commit-queue this functionality of bailing out
2194         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2195         Instead, we should always move the change log entry to the top of the ChangeLog file.
2196
2197         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2198         the date line of the correct change log entry in a ChangeLog diff.
2199
2200         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2201
2202         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2203           Updated the following unit tests now that we move entries inserted earlier to the top:
2204           - "fixChangeLogPatch: New entry inserted in middle."
2205             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2206
2207           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2208             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2209
2210         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2211
2212 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2213
2214         Reviewed by Eric Seidel.
2215
2216         [Qt] Fixed compatibility with gold linker on X11 platforms
2217         https://bugs.webkit.org/show_bug.cgi?id=51700
2218
2219         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2220         Linked TestNetscapePlugin with libX11 on Unix platforms
2221
2222 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2223
2224         Reviewed by Darin Adler.
2225
2226         Circular dependency in webkitpy.common.checkout.changelog module
2227         https://bugs.webkit.org/show_bug.cgi?id=50475
2228
2229         Remove automatic import of api.Checkout module when any checkout/
2230         submodule is imported (e.g.: when checkout.scm.Git is imported).
2231
2232         * Scripts/webkitpy/common/checkout/__init__.py:
2233
2234 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2235
2236         Reviewed by Ojan Vafai.
2237
2238         prepare-ChangeLog should support the -g option for specifying the git-commit
2239         https://bugs.webkit.org/show_bug.cgi?id=51708
2240
2241         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2242         webkit-patch, though the exact meaning of the two options remain different.
2243
2244         * Scripts/prepare-ChangeLog: Add -g.
2245
2246 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2247
2248         Reviewed by Simon Hausmann.
2249
2250         [Qt] Fix compilation with Qt in namespace
2251         https://bugs.webkit.org/show_bug.cgi?id=51701
2252
2253         * QtTestBrowser/webview.h:
2254
2255 2010-12-28  Daniel Bates  <dbates@rim.com>
2256
2257         Reviewed by Sam Weinig.
2258
2259         Substitute // MARK: for compiler-specific #pragma mark
2260         https://bugs.webkit.org/show_bug.cgi?id=51657
2261
2262         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2263         substituting  "// MARK:" for "#pragma mark", which provides
2264         analogous code-bookmarking functionality under Xcode.
2265
2266         Also, for consistency, we should substitute "// MARK:" for compiler-
2267         specific "#pragma mark" in the source files for the Mac port.
2268
2269         * DumpRenderTree/AccessibilityTextMarker.cpp:
2270         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2271         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2272         * DumpRenderTree/mac/ObjCController.m:
2273         * MiniBrowser/mac/AppDelegate.m:
2274         * MiniBrowser/mac/BrowserWindowController.m:
2275
2276 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2277
2278         Reviewed by Eric Seidel.
2279
2280         Add --no-build option to run-sunspider
2281         https://bugs.webkit.org/show_bug.cgi?id=51658
2282
2283         * Scripts/run-sunspider: add --no-build flag to skip building
2284         phase.
2285
2286 2010-12-27  Daniel Bates  <dbates@rim.com>
2287
2288         Rubber-stamped by Martin Robinson.
2289
2290         Append the directory Tools/DumpRenderTree to the list of directories that
2291         do-webcore-rename should search so that it can rename DRT files and
2292         source code.
2293
2294         * Scripts/do-webcore-rename:
2295
2296 2010-12-27  Eric Seidel  <eric@webkit.org>
2297
2298         Reviewed by Adam Barth.
2299
2300         build-webkit should detect missing Java SDK and explain how to install it
2301         https://bugs.webkit.org/show_bug.cgi?id=51651
2302
2303         * Scripts/build-webkit:
2304
2305 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2306
2307         Reviewed by Daniel Bates.
2308
2309         [GTK] Add support for build-jsc
2310         https://bugs.webkit.org/show_bug.cgi?id=51625
2311
2312         Add GTK+ support to build-jsc now that building the jsc executable as
2313         a standalone target is easy.
2314
2315         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2316         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2317         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2318         and pass it along to buildAutotoolsProject.
2319
2320 2010-12-27  David Levin  <levin@chromium.org>
2321
2322         Reviewed by Eric Seidel.
2323
2324         check-webkit-style check for meaningless variable names in function declarations.
2325         https://bugs.webkit.org/show_bug.cgi?id=51523
2326
2327         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2328         from the new check and whitespace/parens because the syntax is unusual and
2329         produced a fair number of positives for these checks.
2330         * Scripts/webkitpy/style/checkers/cpp.py:
2331         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2332         and parameter names when determining if the parameter name is useless.
2333         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2334         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2335         format.
2336         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2337         text or an acronym of it.
2338         (check_function_definition): Checks function definitions for meaningless variable names.
2339         (process_line): Added call to check_function_definition.
2340         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2341         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2342         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2343         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2344         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2345         because when only checking a snippet, there are a lot of bogus functions.
2346         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2347         that I put there previously and just noticed.
2348         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2349         check_function_definition and process_line.
2350
2351 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2352
2353         Reviewed by Martin Robinson.
2354
2355         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2356         https://bugs.webkit.org/show_bug.cgi?id=51591
2357
2358         Flash plugin uses gtk2 that is incompatible with gtk3 making
2359         webkit crash when it's built with gtk3.
2360
2361         * GtkLauncher/main.c:
2362         (main):
2363
2364 2010-12-25  Adam Barth  <abarth@webkit.org>
2365
2366         Reviewed by Eric Seidel.
2367
2368         Move ANGLE to Sources/ThirdParty
2369         https://bugs.webkit.org/show_bug.cgi?id=51605
2370
2371         * Scripts/build-webkit:
2372           - Point to the new ANGLE location.
2373
2374 2010-12-26  David Levin  <levin@chromium.org>
2375
2376         Reviewed by Eric Seidel.
2377
2378         check-webkit-style should be able to parse function declaration parameters.
2379         https://bugs.webkit.org/show_bug.cgi?id=51451
2380
2381         * Scripts/webkitpy/style/checkers/cpp.py:
2382         (Position.__init__): Holds simple position information (row, column).
2383         (Parameter.__init__): Holds information about a parameter.
2384         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2385         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2386         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2387         (find_parameter_name_index): Finds where the parameter name is.
2388         (parameter_list): Generates the list of parameters for a function.
2389         (_FunctionState.begin): Added information to allow determining the parameters
2390         on demand.
2391         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2392         (detect_functions): Improve function detection for operator functions and
2393         determine where the parameters end and pass that to _FunctionState.begin.
2394         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2395         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2396         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2397         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2398         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2399         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2400         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2401         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2402         the parameters found.
2403         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2404         detection test to verify that we catch the operator functions.
2405         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2406         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2407         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2408         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2409         test_function_length_check_definition_severity1_for_test.
2410
2411 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2412
2413         Unreviewed WinCE buildfix after r74334.
2414
2415         * CMakeListsWinCE.txt:
2416
2417 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2418
2419         Unreviewed, rolling out r74632.
2420         http://trac.webkit.org/changeset/74632
2421         https://bugs.webkit.org/show_bug.cgi?id=51600
2422
2423         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2424         on #webkit).
2425
2426         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2427         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2428
2429 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2430
2431         Reviewed by Kenneth Rohde Christiansen.
2432
2433         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2434         https://bugs.webkit.org/show_bug.cgi?id=43528
2435
2436         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2437         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2438         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2439         called.
2440
2441         * EWebLauncher/main.c:
2442         (browserCreate):
2443
2444 2010-12-24  Eric Seidel  <eric@webkit.org>
2445
2446         Reviewed by Adam Barth.
2447
2448         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2449         https://bugs.webkit.org/show_bug.cgi?id=28291
2450
2451         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2452         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2453         to strings with find in the diff.
2454         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2455
2456         * Scripts/webkitpy/common/checkout/api.py:
2457         * Scripts/webkitpy/common/checkout/diff_parser.py:
2458         * Scripts/webkitpy/tool/steps/abstractstep.py:
2459         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2460         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2461         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2462         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2463
2464 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2465
2466         Reviewed by Kenneth Russell.
2467
2468         Modify new-run-webkit-tests to shut up and exit when all the threads
2469         are wedged so that test runs complete faster and we don't end up
2470         w/ enormous log files.
2471
2472         https://bugs.webkit.org/show_bug.cgi?id=51572
2473
2474         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2475         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2476
2477 2010-12-24  Eric Seidel  <eric@webkit.org>
2478
2479         Reviewed by David Levin.
2480
2481         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2482         https://bugs.webkit.org/show_bug.cgi?id=51549
2483
2484         I've had multiple people ask me about the commit-queue's behavior
2485         regarding reporting flaky tests.  I figured it would be best to just
2486         have the queue explain itself in the bugs it files.
2487
2488         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2489         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2490
2491 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2492
2493         Reviewed by Eric Seidel.
2494
2495         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2496         https://bugs.webkit.org/show_bug.cgi?id=51467
2497
2498         * Scripts/webkitpy/style/checker.py:
2499         * Scripts/webkitpy/style/checker_unittest.py:
2500
2501 2010-12-23  Adam Barth  <abarth@webkit.org>
2502
2503         Rubber-stamped by Eric Seidel.
2504
2505         Move JavaScriptGlue into Sources
2506         https://bugs.webkit.org/show_bug.cgi?id=51583
2507
2508         These tools refer to JavaScriptGlue and need to be updated to its new
2509         location.
2510
2511         * Scripts/build-webkit:
2512         * Scripts/do-file-rename:
2513         * Scripts/do-webcore-rename:
2514         * Scripts/webkitpy/common/config/build.py:
2515         * Scripts/webkitpy/common/config/build_unittest.py:
2516
2517 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2518
2519         Reviewed by Eric Seidel.
2520
2521         Bug 51539 - update iexploder scripts to point to new location
2522
2523         * Scripts/run-iexploder-tests:
2524         * Scripts/update-iexploder-cssproperties:
2525
2526 2010-12-23  Evan Martin  <evan@chromium.org>
2527
2528         Reviewed by Ryosuke Niwa.
2529
2530         [chromium] LayoutTestController warning in float->int conversion
2531         https://bugs.webkit.org/show_bug.cgi?id=51553
2532
2533         Rather than reading an int, converting to a float, then getting a compiler
2534         warning on passing the float to something that expects an int, instead
2535         just pass around ints.
2536
2537         No tests, fixes a compiler warning.
2538
2539         * DumpRenderTree/chromium/LayoutTestController.cpp:
2540         (parsePageSizeParameters):
2541         (LayoutTestController::pageNumberForElementById):
2542         (LayoutTestController::numberOfPages):
2543
2544 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2545
2546         Reviewed by Darin Adler.
2547
2548         Bug 51537 - iexploder needs cleanup
2549         
2550         * iExploder/htdocs: Removed.
2551         * iExploder/htdocs/config.rb: Removed.
2552         * iExploder/htdocs/cssproperties.in: Removed.
2553         * iExploder/htdocs/cssvalues.in: Removed.
2554         * iExploder/htdocs/htmlattrs.in: Removed.
2555         * iExploder/htdocs/htmltags.in: Removed.
2556         * iExploder/htdocs/htmlvalues.in: Removed.
2557         * iExploder/htdocs/iexploder.cgi: Removed.
2558         * iExploder/htdocs/iexploder.rb: Removed.
2559         * iExploder/htdocs/index.html: Removed.
2560         * iExploder/htdocs/webserver.rb: Removed.
2561         * iExploder/iexploder-1.7.2/output: Removed.
2562         * iExploder/tools: Removed.
2563         * iExploder/tools/lasthit.rb: Removed.
2564         * iExploder/tools/osx_last_crash.rb: Removed.
2565         * iExploder/tools/showtest.rb: Removed.
2566
2567 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2568
2569         Reviewed by Kenneth Rohde Christiansen.
2570
2571         [EFL] Make 'single' the default backing store in EWebLauncher
2572         https://bugs.webkit.org/show_bug.cgi?id=51534
2573
2574         'single' is the simplest backing store and the one intended to be the
2575         default in the test browser. By mistake the tiled backing store was
2576         left as default in r72617.
2577
2578         * EWebLauncher/main.c:
2579         (browserCreate): ditto.
2580
2581 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2582
2583         Reviewed by Kenneth Rohde Christiansen.
2584
2585         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2586         https://bugs.webkit.org/show_bug.cgi?id=51533
2587
2588         There's no point in concatenating env("HOME") with "blah", so remove
2589         option from EWebLauncher.
2590
2591         * EWebLauncher/main.c:
2592         (main): ditto.
2593
2594 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2595
2596         Reviewed by Eric Seidel.
2597
2598         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2599
2600         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2601         I just discovered that we have two additional GC runs per each WebViewHost.
2602         Test_shell had no such calls.
2603         These gc runs eat 15% of cpu time.
2604
2605         https://bugs.webkit.org/show_bug.cgi?id=51479
2606
2607         * DumpRenderTree/chromium/WebViewHost.cpp:
2608         (WebViewHost::~WebViewHost):
2609
2610 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2611
2612         Reviewed by Ojan Vafai.
2613
2614         This change splits out the TestRunner class into its own file.
2615         When we fork the code for message passing, we will create a new
2616         TestRunner, and this change will allow that to be more modular.
2617
2618         While we're at it, split out TestInput and ResultSummary into
2619         their own files, to reduce the size of run_webkit_tests to
2620         something more managable.
2621
2622         https://bugs.webkit.org/show_bug.cgi?id=51092
2623
2624         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2625         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2626         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2627         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2628         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2629         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2630         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2631
2632  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2633
2634         Reviewed by Ojan Vafai.
2635
2636         nrwt multiprocessing - start over, prepare to fork the code
2637  
2638         This code cleans up the signatures and implementation of the
2639         TestRunner class so we can easily fork it to run either the
2640         stable implementation or the new, unstable message-passing
2641         implementation. The two variants will have different
2642         implementations of the run_tests() method. We will switch
2643         between the two based on the setting for the '--worker-model'
2644         switch. We rename the two currently valid values to 'old-inline'
2645         and 'old-threads'.
2646
2647         https://bugs.webkit.org/show_bug.cgi?id=51081
2648
2649         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2650         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2651
2652 2010-12-22  Victor Wang  <victorw@chromium.org>
2653
2654         Reviewed by Darin Fisher.
2655
2656         [Chromium] Update chromium archive test result url in rebaseline script.
2657
2658         https://bugs.webkit.org/show_bug.cgi?id=51503
2659
2660         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2661
2662 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2663
2664         Reviewed by Alice Liu.
2665
2666         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2667         Verified on Chrome, Safari, and IE.
2668         With this change, we will record memory from a parent browser window and all child processes.
2669
2670         * record-memory-win/main.cpp:
2671         (ProcessArgs):
2672         (PrintUsage):
2673         (getMemoryInfo):
2674         (printProcessInfo):
2675         (evalProcesses):
2676         (UseImage):
2677         (QueryContinuously):
2678         (ElapsedTime):
2679
2680 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2681
2682         Unreviewed rollout r74489, because it was missing changelog.
2683
2684         * record-memory-win/main.cpp:
2685         
2686 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2687
2688         Adding myself as a reviewer.
2689
2690         * Scripts/webkitpy/common/config/committers.py:
2691
2692 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2693
2694         Unreviewed.  Adding myself to committers.py.
2695
2696         * Scripts/webkitpy/common/config/committers.py:
2697
2698 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2699
2700         Reviewed by Kenneth Rohde Christiansen.
2701
2702         TestNetscapePlugIn should use #if defined
2703         https://bugs.webkit.org/show_bug.cgi?id=51471
2704
2705         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2706         (NP_Initialize):
2707         (NPP_New):
2708
2709 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2710
2711         Reviewed by Yury Semikhatsky.
2712
2713         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2714
2715         DevTools window should be closed explicitly because it has custom deinitialization code.
2716
2717         https://bugs.webkit.org/show_bug.cgi?id=50722
2718
2719         * DumpRenderTree/chromium/TestShell.cpp:
2720         (TestShell::closeRemainingWindows):
2721
2722 2010-12-22  David Levin  <levin@chromium.org>
2723
2724         Reviewed by Shinichiro Hamaji.
2725
2726         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2727         https://bugs.webkit.org/show_bug.cgi?id=51452
2728
2729         * Scripts/webkitpy/style/checkers/cpp.py:
2730         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2731         Using the file extension if possible but falling back to the file contents if we have a header file.
2732         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2733         (_FileState.is_c_or_objective_c):
2734         (check_using_std): Changed to using _FileState to determine the file type.
2735         (check_max_min_macros): Ditto.
2736         (check_for_null): Ditto.
2737         (check_style): Changed the parameters to various calls since they now need _FileState
2738         to determine the file type.
2739         (check_language): Added the file_state parameter so it could be passed
2740         to check_identifier_name_in_declaration.
2741         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2742         this is an Objective C file.
2743         (_process_lines): Added information for the _FileState constructor (and moved the
2744         call to a place that had the information).
2745         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2746         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2747         its functionality.
2748         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2749
2750 2010-12-21  Andy Estes  <aestes@apple.com>
2751
2752         Reviewed by Mark Rowe.
2753
2754         Do not build non-Intel architectures for WebKit2-related projects.
2755         https://bugs.webkit.org/show_bug.cgi?id=51440
2756
2757         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2758         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2759         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2760
2761 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2762
2763         Reviewed by Darin Fisher.
2764
2765         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2766         https://bugs.webkit.org/show_bug.cgi?id=51406 
2767         
2768         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2769         to WebThemeEngineDRTWin and update references everywhere.
2770
2771         * DumpRenderTree/DumpRenderTree.gypi:
2772         * DumpRenderTree/chromium/TestShellWin.cpp:
2773         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2774         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2775         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2776         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2777
2778 2010-12-21  Anders Carlsson  <andersca@apple.com>
2779
2780         Reviewed by John Sullivan.
2781
2782         Clicking missing plug-in text does not show a sheet
2783         https://bugs.webkit.org/show_bug.cgi?id=51403
2784
2785         Update for changes to the WebPageUIClient.
2786
2787         * MiniBrowser/mac/BrowserWindowController.m:
2788         (-[BrowserWindowController awakeFromNib]):
2789         * WebKitTestRunner/TestController.cpp:
2790         (WTR::createOtherPage):
2791         (WTR::TestController::initialize):
2792
2793 2010-12-21  Eric Seidel  <eric@webkit.org>
2794
2795         Reviewed by Adam Barth.
2796
2797         commit-queue will report constant failures as flaky if other tests flake
2798         https://bugs.webkit.org/show_bug.cgi?id=51272
2799
2800         This patch just removes functionality and adds testing.
2801         Previously we attempted to report flaky tests when we had
2802         two different tests fail in a row.  However, since we stop
2803         running the tests at the first failure, our code was wrong in
2804         trying to determine flakiness from the incomplete runs.
2805
2806         Originally I posted an alternate patch:
2807         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2808         which fixed our flaky logic in this case, however it was decided
2809         that that patch would be too difficult to maintain, so now
2810         I'm just removing the broken logic.
2811
2812         This will dramatically cut-down on our flaky-test false positives
2813         at the (small) cost of the queues being unable to report
2814         any flakiness if the tree is very flaky.  (With at least one test
2815         flaking on every run, we'll never report failures anymore.)  I think
2816         this is a tradeoff worth making.
2817
2818         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2819         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2820
2821 2010-12-20  Eric Seidel  <eric@webkit.org>
2822
2823         Reviewed by Adam Barth.
2824
2825         commit-queue wrongly rejects patches when it can't update itself
2826         https://bugs.webkit.org/show_bug.cgi?id=46636
2827
2828         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2829         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2830         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2831
2832 2010-12-20  Adam Barth  <abarth@webkit.org>
2833
2834         Move web sites to Websites directory
2835         https://bugs.webkit.org/show_bug.cgi?id=51323
2836
2837         Update references to BugsSite to point to the new location.
2838
2839         This patch was never officially reviewed (because it was too large to
2840         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2841         Rowe gave me the green light.
2842
2843         * Scripts/old-run-webkit-tests:
2844         * Scripts/webkitpy/common/config/build.py:
2845         * Scripts/webkitpy/common/config/build_unittest.py:
2846         * Scripts/webkitpy/common/prettypatch.py:
2847         * Scripts/webkitpy/layout_tests/port/base.py:
2848         * Scripts/webkitpy/style/main.py:
2849
2850 2010-12-20  Adrienne Walker  <enne@google.com>
2851
2852         Unreviewed. Adding myself to the list of committers.
2853
2854         * webkitpy/common/config/committers.py:
2855
2856 2010-12-20  Mark Rowe  <mrowe@apple.com>
2857
2858         Reviewed by Dan Bernstein.
2859
2860         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2861
2862         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2863         Resources directory.
2864
2865 2010-12-20  Eric Seidel  <eric@webkit.org>
2866
2867         Reviewed by Adam Barth.
2868
2869         commit-queue should include bot id when attaching failure diffs
2870         https://bugs.webkit.org/show_bug.cgi?id=51280
2871
2872         This is a tiny change to include the bot id in the name of the attachment.
2873         Most of this diff is just changing the unit test expectations
2874         now that I hid the comment printing when the comment is None.
2875
2876         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2877         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2878         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2879         * Scripts/webkitpy/tool/mocktool.py:
2880
2881 2010-12-20  Jeff Miller  <jeffm@apple.com>
2882
2883         Reviewed by Dan Bernstein.
2884
2885         Tools/vcbin/midl.exe needs to be rebuilt
2886         https://bugs.webkit.org/show_bug.cgi?id=51347
2887
2888         * vcbin/midl.exe: Rebuilt.
2889
2890 2010-12-20  David Levin  <levin@chromium.org>
2891
2892         Reviewed by Ariya Hidayat.
2893
2894         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2895         https://bugs.webkit.org/show_bug.cgi?id=51343
2896
2897         Follow up from the WebKitTools -> Tools rename.
2898
2899         * Scripts/webkit-tools-completion.sh:
2900
2901 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2902
2903         Reviewed by James Robinson.
2904
2905         new-run-webkit-tests ignores trailing EOL differences in text tests
2906         https://bugs.webkit.org/show_bug.cgi?id=36983
2907
2908         Changed the handling of new-line characters within new-run-webkit-tests
2909         to match old-run-webkit-tests.  Differences in leading and trailing empty
2910         lines in text expectation files are no longer ignored.
2911
2912         * Scripts/webkitpy/layout_tests/port/base.py:
2913         * Scripts/webkitpy/layout_tests/port/test.py:
2914         Added unit tests.  Removed old duplicate unit test entries.
2915         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2916
2917 2010-12-20  David Levin  <levin@chromium.org>
2918
2919         Reviewed by Shinichiro Hamaji.
2920
2921         check-webkit-style should detect function declarations (and trivial functions).
2922         https://bugs.webkit.org/show_bug.cgi?id=51303
2923
2924         * Scripts/webkitpy/style/checkers/cpp.py:
2925         (_FunctionState.begin): Add is_declaration and changed the line count
2926         start to begin at -1 (which will keep the results consistent, since
2927         the starting line number passed in is one less in this change).
2928         (detect_functions): changed function detection to now catch trivial
2929         functions and declarations.
2930         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2931         of the function as this may look at return values (when processing
2932         a declaration).
2933         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2934         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2935         of testing the function detection.
2936         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2937         function.
2938         (FunctionDetectionTest.test_function_declaration_detection): Test a
2939         declaration.
2940         (FunctionDetectionTest.test_non_functions): A test case for a case
2941         that caused the code to fail due to the { being in quotes.
2942         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2943         cases to help catch false alarms for return values.
2944         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2945         we don't get false alarms for member variables either.
2946
2947 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2948
2949         Reviewed by Antonio Gomes.
2950
2951         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2952         https://bugs.webkit.org/show_bug.cgi?id=51319
2953
2954         * CMakeListsEfl.txt:
2955
2956 2010-12-18  Adam Barth  <abarth@webkit.org>
2957
2958         Reviewed by Sam Weinig.
2959
2960         Move WebKitExamplePlugins to Examples
2961         https://bugs.webkit.org/show_bug.cgi?id=51291
2962
2963         * Scripts/webkitpy/common/config/build.py:
2964
2965 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2966
2967         Unreviewed Qt buildfix after r74301.
2968
2969         Rename WebKitTools to Tools
2970         https://bugs.webkit.org/show_bug.cgi?id=49861
2971
2972         * MiniBrowser/DerivedSources.pro:
2973         * MiniBrowser/qt/MiniBrowser.pro:
2974
2975 2010-12-17  Dan Bernstein  <mitz@apple.com>
2976
2977         Reviewed by Simon Fraser.
2978
2979         Rename WebKitTools to Tools
2980         https://bugs.webkit.org/show_bug.cgi?id=49861
2981
2982         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2983         * CodeCoverage/README:
2984         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2985         (WebCore::DumpRenderTree::initializeFonts):
2986         * EWSTools/start-commit-queue.sh:
2987         * EWSTools/start-queue.sh:
2988         * GNUmakefile.am:
2989         * MIDLWrapper/MIDLWrapper.cpp:
2990         (wmain):
2991         * MiniBrowser/qt/MiniBrowser.pro:
2992         * Scripts/build-api-tests:
2993         * Scripts/build-dumprendertree:
2994         * Scripts/build-webkit:
2995         * Scripts/build-webkittestrunner:
2996         * Scripts/generate-coverage-data:
2997         * Scripts/old-run-webkit-tests:
2998         * Scripts/run-api-tests:
2999         * Scripts/run-iexploder-tests:
3000         * Scripts/run-javascriptcore-tests:
3001         * Scripts/run-mangleme-tests:
3002         * Scripts/run-sunspider:
3003         * Scripts/run-webkit-websocketserver:
3004         * Scripts/sunspider-compare-results:
3005         * Scripts/test-webkitperl:
3006         * Scripts/test-webkitpy:
3007         * Scripts/update-iexploder-cssproperties:
3008         * Scripts/update-webkit:
3009         * Scripts/update-webkit-localizable-strings:
3010         * Scripts/webkitdirs.pm:
3011         * Scripts/webkitpy/common/checkout/scm.py:
3012         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3013         * Scripts/webkitpy/common/config/committervalidator.py:
3014         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3015         * Scripts/webkitpy/common/config/ports.py:
3016         * Scripts/webkitpy/common/config/ports_unittest.py:
3017         * Scripts/webkitpy/common/system/logutils_unittest.py:
3018         * Scripts/webkitpy/common/system/ospath_unittest.py:
3019         * Scripts/webkitpy/layout_tests/port/chromium.py:
3020         * Scripts/webkitpy/layout_tests/port/config.py:
3021         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3022         * Scripts/webkitpy/layout_tests/port/http_server.py:
3023         * Scripts/webkitpy/layout_tests/port/test.py:
3024         * Scripts/webkitpy/style/checker.py:
3025         * Scripts/webkitpy/style/checker_unittest.py:
3026         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3027         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3028         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3029         * WebKitTestRunner/DerivedSources.pro:
3030         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3031         (WTR::activateFonts):
3032         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3033         * wx/build/build_utils.py:
3034
3035 2010-12-16  Antonio Gomes  <agomes@rim.com>
3036
3037         Reviewed by Martin Robinson.
3038
3039         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3040         https://bugs.webkit.org/show_bug.cgi?id=51163
3041
3042         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3043         GTK+'s DRT should also reset to UNIX after each test execution.
3044
3045         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3046         (resetDefaultsToConsistentValues):
3047
3048 2010-12-17  David Levin  <levin@chromium.org>
3049
3050         Reviewed by Eric Seidel.
3051
3052         check-webkit-style should understand WTF #include guards
3053         https://bugs.webkit.org/show_bug.cgi?id=44911
3054
3055         * Scripts/webkitpy/style/checkers/cpp.py:
3056         (get_header_guard_cpp_variable): modify to suggest the WTF style
3057         of header guard when appropriate.
3058         (check_for_header_guard): handle multiple return values from
3059         get_header_guard_cpp_variable
3060         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3061         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3062         header style.
3063
3064 2010-12-16  David Levin  <levin@chromium.org>
3065
3066         Reviewed by Eric Seidel.
3067
3068         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3069         https://bugs.webkit.org/show_bug.cgi?id=51210
3070
3071         The error only shows up when using python 2.6 or later.
3072
3073         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3074         the decprecated field error,message with something equivalent.
3075
3076 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3077
3078         Reviewed by Eric Seidel.
3079
3080         Add --exit-after-n-failures/crashes to NRWT
3081         https://bugs.webkit.org/show_bug.cgi?id=51160
3082         
3083         Abort test run (in a similar way to how control-C is handled) when
3084         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3085         that number of unexpected failures/crashes/timeouts.
3086
3087         * Scripts/webkitpy/layout_tests/port/test.py:
3088         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3089         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3090
3091 2010-12-16  David Levin  <levin@chromium.org>
3092
3093         Reviewed by Shinichiro Hamaji.
3094
3095         check-webkit-style unit tests has some duplicate boilerplate code.
3096         https://bugs.webkit.org/show_bug.cgi?id=49519
3097
3098         * Scripts/webkitpy/style/checkers/cpp.py:
3099         (update_include_state): Replaced the "io" parameter with the global
3100         configuration _unit_test_config. This allowed not calling into
3101         functions at a low level and also not plumbing through the injection
3102         information through many levels of code.
3103         (check_for_include_what_you_use): Ditto.
3104         (process_file_data): Added the ability to set up the unit test config
3105         to allow for injection.
3106         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3107         (ErrorCollector.__init__): Added support for having a filter for errors.
3108         (ErrorCollector.__call__): Ditto.
3109         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3110         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3111         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3112         functions in the cpp.py with generic processing and a filter that
3113         indicates what errors should be kept.
3114         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3115         (CppStyleTestBase.perform_language_rules_check): Ditto.
3116         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3117         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3118         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3119         (CppStyleTest.test_multi_line_comments): Added another
3120         error message which applies to the test case.
3121         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3122         to not have config.h, since it is processed as a header file.
3123         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3124         style and indentation in checked code.
3125         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3126         Fixed line number.
3127         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3128         Ditto.
3129
3130 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3131
3132         Unreviewed, rolling out r74136.
3133         http://trac.webkit.org/changeset/74136
3134         https://bugs.webkit.org/show_bug.cgi?id=51135
3135
3136         r74136 breaks chromium canary bots because some tests are not
3137         rebaselined correctly to resolve EOL differences (Requested by
3138         jianli on #webkit).
3139
3140         * Scripts/webkitpy/layout_tests/port/base.py:
3141         * Scripts/webkitpy/layout_tests/port/test.py:
3142         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3143
3144 2010-12-15  Adam Roben  <aroben@apple.com>
3145
3146         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3147         syntax errors
3148
3149         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3150         XML syntax errors in .vcproj/.vsprops files
3151
3152         Reviewed by Dave Levin.
3153
3154         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3155         that should be treated as XML and that should be allowed to contain
3156         carriage returns. (These lists happen to be identical currently.)
3157         (FileType): Added a new XML type.
3158         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3159         Just does a simple file extension check.
3160         (CheckerDispatcher._file_type): Added a case for XML files.
3161         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3162         files (surprise!).
3163         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3164         lines through the carriage checker.
3165
3166         * Scripts/webkitpy/style/checker_unittest.py:
3167         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3168         Added. Checks a few file names to see if carriage returns are allowed
3169         or not.
3170         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3171         other assert_checker_* functions.
3172         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3173         test_*_paths functions.
3174         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3175         test_*_paths functions.
3176         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3177         file from this test case, as vcproj files now have a type.
3178         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3179         Added. Similar to the other should_* functions.
3180         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3181         Added. Checks that carriage returns aren't checked for or stripped for
3182         allowed files.
3183
3184         * Scripts/webkitpy/style/checkers/xml.py: Added.
3185         (XMLChecker.__init__): Simple init method.
3186         (XMLChecker.check): Pass each line through the expat parser, and record
3187         a style error for any errors thrown by the parser.
3188
3189         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3190         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3191         produce a style error.
3192         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3193         error of the given category on the given line.
3194         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3195         checking that the XMLChecker constructor works properly.
3196         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3197         cause a style error (see, e.g., r73887).
3198         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3199         cause a style error (see, e.g., r73773).
3200         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3201         properly.
3202         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3203         tags cause a style error (see, e.g., r72795).
3204         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3205         style error.
3206
3207 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3208
3209         Reviewed by Stephanie Lewis.
3210
3211         https://bugs.webkit.org/show_bug.cgi?id=51117
3212         Add a new leopard test bot
3213         really really commit to trunk this time.
3214
3215         * BuildSlaveSupport/build.webkit.org-config/config.json:
3216
3217 2010-12-15  Sam Weinig  <sam@webkit.org>
3218
3219         Reviewed by Anders Carlsson.
3220
3221         WebKit2: Can't add files to an <input type=file>
3222         https://bugs.webkit.org/show_bug.cgi?id=51087
3223
3224         * MiniBrowser/mac/BrowserWindowController.m:
3225         (runOpenPanel):
3226         (-[BrowserWindowController awakeFromNib]):
3227         Add simple implementation of runOpenPanel callback.
3228
3229         * MiniBrowser/win/BrowserView.cpp:
3230         (BrowserView::create):
3231         * WebKitTestRunner/TestController.cpp:
3232         (WTR::createOtherPage):
3233         (WTR::TestController::initialize):
3234         Stub out runOpenPanel callback. 
3235
3236 2010-12-14  Eric Seidel  <eric@webkit.org>
3237
3238         Reviewed by Adam Barth.
3239
3240         commit-queue should upload failure diffs when tests flake
3241         https://bugs.webkit.org/show_bug.cgi?id=51051
3242
3243         To make this testable I needed to pipe FileSystem down onto tool.
3244         We've wanted it there for a long time anyway.
3245
3246         This patch is kinda a big hack.  But we don't have a nice
3247         way to read results.html files.  I think this will need further
3248         revision before this code actually feels clean.
3249
3250         As part of testing this change, I had to make MockBugzilla.create_bug
3251         actually return an id (like it should) which required updating
3252         a few other unit test results (for the better).
3253
3254         The results_matching_keys change in layouttestresults/rebasline
3255         was an alternate path which I decided not to use in the end, but
3256         I left the change as it seemed an improvement.
3257
3258         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3259         * Scripts/webkitpy/common/net/layouttestresults.py:
3260         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3261         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3262         * Scripts/webkitpy/tool/commands/queues.py:
3263         * Scripts/webkitpy/tool/commands/rebaseline.py:
3264         * Scripts/webkitpy/tool/main.py:
3265         * Scripts/webkitpy/tool/mocktool.py:
3266
3267 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3268
3269         Reviewed by James Robinson.
3270
3271         new-run-webkit-tests ignores trailing EOL differences in text tests
3272         https://bugs.webkit.org/show_bug.cgi?id=36983
3273
3274         Changed the handling of new-line characters within new-run-webkit-tests
3275         to match old-run-webkit-tests.  Differences in leading and trailing empty
3276         lines in text expectation files are no longer ignored.
3277
3278         * Scripts/webkitpy/layout_tests/port/base.py:
3279         * Scripts/webkitpy/layout_tests/port/test.py:
3280         Added unit tests.  Removed old duplicate unit test entries.
3281         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3282
3283 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3284
3285         Reviewed by Adam Barth.
3286
3287         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3288         https://bugs.webkit.org/show_bug.cgi?id=51149
3289
3290         * QueueStatusServer/templates/statusbubble.html:
3291
3292 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3293
3294         Reviewed by Adam Barth.
3295
3296         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3297         https://bugs.webkit.org/show_bug.cgi?id=51125
3298
3299         * QueueStatusServer/templates/statusbubble.html:
3300
3301 2010-12-15  Darin Adler  <darin@apple.com>
3302
3303         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3304
3305 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3306
3307         Unreviewed, rolling out r74117.
3308         http://trac.webkit.org/changeset/74117
3309         https://bugs.webkit.org/show_bug.cgi?id=51113
3310
3311         This broke the GTK1 build. (Requested by mrobinson on
3312         #webkit).
3313
3314         * Scripts/webkitdirs.pm:
3315
3316 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3317
3318         Reviewed by Martin Robinson.
3319
3320         Change generate-forwarding-headers.pl for GTK port usage 
3321         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3322
3323         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3324
3325 2010-12-14  Kent Tamura  <tkent@chromium.org>
3326
3327         Reviewed by Jian Li.
3328
3329         [DRT/Chromium] Remove another unnecessary error message
3330         https://bugs.webkit.org/show_bug.cgi?id=51083
3331
3332         * DumpRenderTree/chromium/WebViewHost.cpp:
3333         (WebViewHost::didInvalidateRect):
3334
3335 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3336
3337         Reviewed by Stephanie Lewis.
3338
3339         Add a new Leopard Debug Test WK2 Bot
3340
3341         * BuildSlaveSupport/build.webkit.org-config/config.json:
3342
3343 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3344
3345         Fix python unittests after http://trac.webkit.org/changeset/74070.
3346
3347         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3348
3349 2010-12-14  Kent Tamura  <tkent@chromium.org>
3350
3351         Reviewed by Jian Li.
3352
3353         [DRT/Chromium] Remove a unnecessary error message
3354         https://bugs.webkit.org/show_bug.cgi?id=51069
3355
3356         * DumpRenderTree/chromium/WebViewHost.cpp:
3357         (WebViewHost::paintInvalidatedRegion):
3358
3359 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3360
3361         Reviewed by Ojan Vafai.
3362
3363         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3364         https://bugs.webkit.org/show_bug.cgi?id=48926
3365
3366         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3367         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3368
3369 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3370
3371         Reviewed by Eric Seidel.
3372
3373         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3374         https://bugs.webkit.org/show_bug.cgi?id=50231
3375
3376         Guard CONFIG+=link_pkgconfig with !symbian.
3377
3378         * DumpRenderTree/qt/DumpRenderTree.pro:
3379         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3380         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3381
3382 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3383
3384         Reviewed by Ojan Vafai.
3385
3386         [new-run-webkit-tests] expectations parsing is slow
3387         https://bugs.webkit.org/show_bug.cgi?id=50635
3388
3389         Avoid expensive iteration of all the tests when checking if a test
3390         file is to be skipped or not.
3391
3392         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3393         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3394         * Scripts/webkitpy/layout_tests/port/test.py:
3395
3396 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3397
3398         Reviewed by Xan Lopez.
3399
3400         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3401         https://bugs.webkit.org/show_bug.cgi?id=27048
3402
3403         Add support in DRT for checking whether an accessibility UI
3404         element is focusable and/or focused. Implemented for GTK.
3405
3406         * DumpRenderTree/AccessibilityUIElement.cpp:
3407         (getIsFocusedCallback): New.
3408         (getIsFocusableCallback): New.
3409         (AccessibilityUIElement::getJSClass): Add the new available
3410         callbacks for isFocused and isFocusable.
3411         * DumpRenderTree/AccessibilityUIElement.h:
3412         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3413         (AccessibilityUIElement::isFocused): New, implemented by checking
3414         whether the related AtkState value is in the object's state set.
3415         (AccessibilityUIElement::isFocusable): Ditto.
3416         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3417         (AccessibilityUIElement::isFocused): New, dummy implementation.
3418         (AccessibilityUIElement::isFocusable): Ditto.
3419         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3420         (AccessibilityUIElement::isFocused): Ditto.
3421         (AccessibilityUIElement::isFocusable): Ditto.
3422
3423 2010-12-14  Eric Seidel  <eric@webkit.org>
3424
3425         Reviewed by Ojan Vafai.
3426
3427         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3428         https://bugs.webkit.org/show_bug.cgi?id=50715
3429
3430         This patch makes webkit-patch print the following:
3431
3432         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3433         Install a 64-bit git for better performance, see:
3434         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3435
3436         I wrote this mostly because I have approximately 8 machines that I use
3437         and making sure each one is using a good Git install seemed folly.
3438         webkit-patch makes a lot of git calls, so using a fast git can shave
3439         several seconds in every invocation.  See the webkit-dev thread for more info.
3440
3441         This message will print twice during 'webkit-patch upload',
3442         once from webkit-patch and once from check-webkit-style.
3443
3444         Unfortunately there is no good way to test this due to how machine-dependent
3445         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3446
3447         * Scripts/webkitpy/common/checkout/scm.py:
3448
3449 2010-12-13  Eric Seidel  <eric@webkit.org>
3450
3451         Reviewed by Adam Barth.
3452
3453         FlakyTestReporter doesn't understand bots running from multiple email addresses
3454         https://bugs.webkit.org/show_bug.cgi?id=50960
3455
3456         This explains at least one of the dupes of:
3457         https://bugs.webkit.org/show_bug.cgi?id=50863
3458         that we saw filed by the commit-queue this morning.
3459         I think the other one was explained by my previous fix to result counting code.
3460
3461         Since this is really hard to test with a unit test, instead I
3462         create a new (possibly useful in the future) command
3463         which given a layout test path will return you
3464         the one bug which our tools would assume it the flaky test bug.
3465         If some other script wants to use bug-for-test we'll
3466         need to extend it with some options like --create-if-missing or similar.
3467
3468         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3469         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3470         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3471         * Scripts/webkitpy/tool/commands/__init__.py:
3472         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3473
3474 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3475
3476         Reviewed by James Robinson.
3477
3478         Add option to build-webkit to not build WebKit2
3479         https://bugs.webkit.org/show_bug.cgi?id=50988
3480         
3481         Add support for a --no-webkit2 option to build-webkit. It seems to save
3482         ~1 minute from clean builds and ~10 seconds from no-op builds.
3483
3484         * Scripts/build-webkit:
3485
3486 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3487
3488         Reviewed by Dave Kilzer.
3489
3490         Update iexploder from 1.3.2 to 1.7.2
3491         Move 1.3.2 into its own subdir
3492         Add 1.7.2 into its own subdir
3493         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3494
3495         * Scripts/run-iexploder-tests:
3496         * Scripts/update-iexploder-cssproperties:
3497         * iExploder/CHANGELOG.txt: Removed.
3498         * iExploder/LICENSE.txt: Removed.
3499         * iExploder/README.txt: Removed.
3500         * iExploder/htdocs: Removed.
3501         * iExploder/iexploder-1.3.2: Added.
3502         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3503         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3504         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3505         * iExploder/iexploder-1.3.2/htdocs: Added.
3506         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3507         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3508         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3509         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3510         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3511         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3512         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3513         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3514         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3515         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3516         * iExploder/iexploder-1.3.2/tools: Added.
3517         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3518         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3519         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3520         * iExploder/iexploder-1.7.2: Added.
3521         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3522         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3523         * iExploder/iexploder-1.7.2/README.txt: Added.
3524         * iExploder/iexploder-1.7.2/output: Added.
3525         * iExploder/iexploder-1.7.2/src: Added.
3526         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3527         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3528         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3529         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3530         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3531         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3532         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3533         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3534         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3535         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3536         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3537         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3538         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3539         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3540         * iExploder/iexploder-1.7.2/src/css-values: Added.
3541         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3542         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3543         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3544         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3545         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3546         * iExploder/iexploder-1.7.2/src/headers: Added.
3547         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3548         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3549         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3550         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3551         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3552         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3553         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3554         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3555         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3556         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3557         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3558         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3559         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3560         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3561         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3562         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3563         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3564         * iExploder/iexploder-1.7.2/src/html-values: Added.
3565         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3566         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3567         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3568         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3569         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3570         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3571         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3572         * iExploder/iexploder-1.7.2/src/index.html: Added.
3573         * iExploder/iexploder-1.7.2/src/media: Added.
3574         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3575         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3576         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3577         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3578         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3579         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3580         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3581         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3582         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3583         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3584         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3585         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3586         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3587         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3588         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3589         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3590         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3591         * iExploder/iexploder-1.7.2/src/protocols: Added.
3592         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3593         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3594         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3595         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3596         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3597         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3598         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3599         * iExploder/iexploder-1.7.2/testcases: Added.
3600         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3601         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3602         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3603         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3604         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3605         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3606         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3607         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3608         * iExploder/iexploder-1.7.2/tools: Added.
3609         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3610         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3611         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3612         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3613         * iExploder/tools: Removed.
3614
3615 2010-12-13  Sam Weinig  <sam@webkit.org>
3616
3617         Reviewed by Anders Carlsson.
3618
3619         Remove associated page concept from WKView constructor
3620         https://bugs.webkit.org/show_bug.cgi?id=50983
3621
3622         Step 1: Remove associate page constructors from WKView and make
3623         all views use the shared namespace for the context.
3624
3625         * TestWebKitAPI/PlatformWebView.h:
3626         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3627         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3628         * WebKitTestRunner/PlatformWebView.h:
3629         * WebKitTestRunner/TestController.cpp:
3630         (WTR::createOtherPage):
3631         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3632         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3633         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3634
3635 2010-12-13  Sam Weinig  <sam@webkit.org>
3636
3637         Reviewed by Anders Carlsson.
3638
3639         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3640         https://bugs.webkit.org/show_bug.cgi?id=50898
3641
3642         * MiniBrowser/mac/AppDelegate.h:
3643         * MiniBrowser/mac/AppDelegate.m:
3644         * MiniBrowser/mac/BrowserWindowController.h:
3645         * MiniBrowser/mac/BrowserWindowController.m:
3646         * MiniBrowser/win/BrowserView.cpp:
3647         Convert MiniBrowser to not use PageNamespaces.
3648
3649         * TestWebKitAPI/PlatformWebView.h:
3650         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3651         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3652         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3653         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3654         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3655         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3656         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3657         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3658         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3659         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3660         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3661         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3662         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3663         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3664         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3665         Convert TestWebKitAPI to not use PageNamespaces.
3666
3667         * WebKitTestRunner/PlatformWebView.h:
3668         * WebKitTestRunner/TestController.cpp:
3669         * WebKitTestRunner/TestController.h:
3670         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3671         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3672         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3673         Convert WebKitTestRunner to not use PageNamespaces.
3674
3675 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3676
3677         Reviewed by Eric Seidel.
3678
3679         webkit-patch rollout should be able to do multi-revision rollouts
3680         https://bugs.webkit.org/show_bug.cgi?id=33336
3681
3682         Make it possible to pass more than one revision to webkit-patch.
3683
3684         * Scripts/webkitpy/common/checkout/api.py:
3685         * Scripts/webkitpy/common/checkout/changelog.py:
3686         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3687         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3688         * Scripts/webkitpy/tool/commands/download.py:
3689         * Scripts/webkitpy/tool/commands/download_unittest.py:
3690         * Scripts/webkitpy/tool/mocktool.py:
3691         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3692         * Scripts/webkitpy/tool/steps/revertrevision.py:
3693
3694 2010-12-13  Eric Seidel  <eric@webkit.org>
3695
3696         Unreviewed.
3697
3698         Teach webkit-patch how to search bugzilla
3699         https://bugs.webkit.org/show_bug.cgi?id=50500
3700
3701         webkit-patch bug-search fails when there is only one result.
3702         Turns out we needed a bit more logic in our result count parsing code.
3703
3704         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3705         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3706
3707 2010-12-13  Antti Koivisto  <antti@apple.com>
3708
3709         Reviewed by Alexey Proskuryakov.
3710
3711         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3712         https://bugs.webkit.org/show_bug.cgi?id=50758
3713
3714         * DumpRenderTree/LayoutTestController.cpp:
3715         (setSerializeHTTPLoadsCallback):
3716         (LayoutTestController::staticFunctions):
3717         * DumpRenderTree/LayoutTestController.h:
3718         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3719         (LayoutTestController::setSerializeHTTPLoads):
3720         * DumpRenderTree/mac/DumpRenderTree.mm:
3721         (resetDefaultsToConsistentValues):
3722         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3723         (LayoutTestController::setSerializeHTTPLoads):
3724         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3725         (LayoutTestController::setSerializeHTTPLoads):
3726
3727 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
3728
3729         Reviewed by Ojan Vafai.
3730
3731         Remove "use-drt" option from test step command line, since the option was removed in r73748.
3732         https://bugs.webkit.org/show_bug.cgi?id=50936
3733
3734         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
3735
3736 2010-12-13  Patrick Gansterer  <paroga@webkit.org>