2a41edee9919ab313414b12f4e22ecc07cc6ad57
[WebKit.git] / Tools / ChangeLog
1 2016-01-18  Nan Wang  <n_wang@apple.com>
2
3         AX: [Mac] Implement next/previous text marker functions using TextIterator
4         https://bugs.webkit.org/show_bug.cgi?id=152728
5
6         Reviewed by Chris Fleizach.
7
8         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
9         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
10
11 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
12
13         [cmake] Add testair to the build system
14         https://bugs.webkit.org/show_bug.cgi?id=153126
15
16         Reviewed by Michael Catanzaro.
17
18         * Scripts/build-jsc:
19
20 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
21
22         Remove TextRun::allowsRoundingHacks()
23         https://bugs.webkit.org/show_bug.cgi?id=153185
24
25         Reviewed by Simon Fraser.
26
27         * DumpRenderTree/mac/DumpRenderTree.mm:
28         (resetWebViewToConsistentStateBeforeTesting): Deleted.
29
30 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
31
32         [webkitdirs] Avoid list form of open because it broke WinCairo
33         https://bugs.webkit.org/show_bug.cgi?id=153106
34
35         Reviewed by Alex Christensen.
36
37         * Scripts/webkitdirs.pm:
38         (determineArchitecture):
39
40 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
41
42         Add kdebug_trace signposts for a few WebCore operations
43         https://bugs.webkit.org/show_bug.cgi?id=153136
44         rdar://problem/24208487
45
46         Reviewed by Sam Weinig.
47         
48         Plist used by kdebug_trace() viewing tools.
49
50         * Tracing/SystemTracePoints.plist: Added.
51
52 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
53
54         [webkitdirs] Replaced grep invocation with perl code
55         https://bugs.webkit.org/show_bug.cgi?id=153106
56
57         Reviewed by Alex Christensen.
58
59         * Scripts/webkitdirs.pm:
60         (determineArchitecture):
61
62 2016-01-14  Brian Burg  <bburg@apple.com>
63
64         prepare-changelog does not read paths containing spaces properly
65         https://bugs.webkit.org/show_bug.cgi?id=137982
66
67         Reviewed by Joseph Pecoraro.
68
69         Escape whitespace in filenames before passing the file path to other functions.
70
71         * Scripts/prepare-ChangeLog:
72         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
73
74 2016-01-14  Jason Marcell  <jmarcell@apple.com>
75
76         Standardize the usage of "branch" vs. "branchName".
77         https://bugs.webkit.org/show_bug.cgi?id=152982
78
79         Reviewed by Daniel Bates.
80
81         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
82         "branchName" implies that the variable or property in question is simply a string.
83
84         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
85         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
86         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
87         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
88         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
89         (Trac.prototype.commitsOnBranch): Change branch to branchName.
90         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
91         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
92         (MockTrac): Ditto.
93
94 2016-01-14  Jason Marcell  <jmarcell@apple.com>
95
96         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
97         https://bugs.webkit.org/show_bug.cgi?id=152910
98
99         Reviewed by Daniel Bates.
100
101         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
102         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
104         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
105         the need to talk to a real Buildbot server.
106         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
107         without the need to talk to a real Buildbot server.
108         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
109         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
110         server.
111         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
112         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
113         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
114         trying to talk to Trac.
115         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
116         QUnit unit tests.
117         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
118
119 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
120
121         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
122         https://bugs.webkit.org/show_bug.cgi?id=132599
123
124         Reviewed by Michael Catanzaro.
125
126         Check if cmake Ninja generators are installed.
127
128         * Scripts/webkitdirs.pm:
129         (canUseNinjaGenerator):
130         (canUseEclipseNinjaGenerator):
131         (generateBuildSystemFromCMakeProject):
132         (canUseEclipse): Deleted.
133
134 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
135
136         [Cocoa] Testing with font family name "System Font" is unused
137         https://bugs.webkit.org/show_bug.cgi?id=153073
138         <rdar://problem/24091683>
139
140         Reviewed by Brent Fulgham.
141
142         * DumpRenderTree/mac/DumpRenderTree.mm:
143         (allowedFontFamilySet): Deleted.
144         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
145         (WTR::allowedFontFamilySet): Deleted.
146         * WebKitTestRunner/mac/TestControllerMac.mm:
147         (WTR::allowedFontFamilySet): Deleted.
148
149 2016-01-13  Daniel Bates  <dabates@apple.com>
150
151         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
152         https://bugs.webkit.org/show_bug.cgi?id=152871
153
154         Reviewed by Brent Fulgham.
155
156         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
157         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
158
159         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
160
161 2016-01-08  Andy Estes  <aestes@apple.com>
162
163         [Content Filtering] Lazily load platform frameworks
164         https://bugs.webkit.org/show_bug.cgi?id=152881
165         rdar://problem/23270886
166
167         Reviewed by Brady Eidson.
168
169         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
170         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
171         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
172         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
173         is loaded after an HTTPS request.
174
175         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
176         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
177         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
178         also re-enabled on iOS after mistakenly being disabled by r188892.
179
180         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
181         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
182         (TestWebKitAPI::TEST):
183         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
184         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
185         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
186         (TEST):
187         (downloadTest):
188         (-[LazilyLoadPlatformFrameworksController init]):
189         (-[LazilyLoadPlatformFrameworksController webView]):
190         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
191         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
192         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
193         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
194         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
195         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
196         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
197         (TestWebKitAPI::TEST):
198         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
199         (TestWebKitAPI::TEST): Deleted.
200         * TestWebKitAPI/cocoa/TestProtocol.h:
201         * TestWebKitAPI/cocoa/TestProtocol.mm:
202         (+[TestProtocol registerWithScheme:]):
203         (+[TestProtocol unregister]):
204
205 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
206
207         Fix the Sunpider converage in slow device.
208         https://bugs.webkit.org/show_bug.cgi?id=152938
209         <rdar://problem/22511411>
210
211         Reviewed by Ryosuke Niwa.
212
213         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
214
215         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
216
217 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
218
219         Add a build flag for custom element
220         https://bugs.webkit.org/show_bug.cgi?id=153005
221
222         Reviewed by Alex Christensen.
223
224         Added --custom-elements option to enable custom elements support.
225
226         * Scripts/webkitperl/FeatureList.pm:
227
228 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
229
230         [JSC] Add a help message when run-jsc-stress-tests fails
231         https://bugs.webkit.org/show_bug.cgi?id=153014
232
233         Reviewed by Csaba Osztrogonác.
234
235         * Scripts/run-jsc-stress-tests:
236
237 2016-01-11  Saam barati  <sbarati@apple.com>
238
239         run-jsc-stress-tests should try to figure out a JSC path
240         https://bugs.webkit.org/show_bug.cgi?id=152971
241
242         Reviewed by Yusuke Suzuki.
243
244         This patch now allows run-jsc-stress-tests to be run
245         without a "--jsc <jsc-path>" argument. It tries
246         to take its best guess at a <jsc-path> automagically.
247         
248         This makes it much easier to just run run-jsc-stress-tests
249         with a directory or a yaml file as an argument.
250         You now just do this:
251         `run-jsc-stress-tests <path-to-yaml>`
252         or
253         `run-jsc-stress-tests <path-to-directory-of-js-files>`
254         
255         I wrote this patch because I'd often find myself hacking the 
256         run-javascriptcore-tests file just to run a particular subset of tests.
257         Because I always forget the arguments to run-jsc-stress-tests (which means
258         I always forgot to provide a --jsc argument), I always found it easier to 
259         just hack on that file instead of calling run-jsc-stress-tests directly.
260         No longer is this true!
261
262         * Scripts/run-jsc-stress-tests:
263
264 2016-01-09  Andy Estes  <aestes@apple.com>
265
266         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
267         https://bugs.webkit.org/show_bug.cgi?id=152950
268         rdar://problem/24066652
269
270         Reviewed by Tim Horton.
271
272         Added an API test.
273
274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
275         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
276         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
277         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
278         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
279         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
280         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
281         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
282         (TEST):
283
284 2016-01-11  Commit Queue  <commit-queue@webkit.org>
285
286         Unreviewed, rolling out r194866.
287         https://bugs.webkit.org/show_bug.cgi?id=152986
288
289         This change broke the mac build (Requested by ryanhaddad on
290         #webkit).
291
292         Reverted changeset:
293
294         "[Cocoa] Add SPI to opt out a URL scheme from the memory
295         cache"
296         https://bugs.webkit.org/show_bug.cgi?id=152950
297         http://trac.webkit.org/changeset/194866
298
299 2016-01-11  Andy Estes  <aestes@apple.com>
300
301         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
302         https://bugs.webkit.org/show_bug.cgi?id=152950
303         rdar://problem/24066652
304
305         Reviewed by Tim Horton.
306
307         Added an API test.
308
309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
310         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
311         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
312         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
313         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
314         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
315         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
316         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
317         (TEST):
318
319 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
320
321         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
322         https://bugs.webkit.org/show_bug.cgi?id=152959
323
324         Reviewed by Brent Fulgham.
325
326         * Scripts/webkitdirs.pm:
327         (determineArchitecture):
328
329 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
330
331         [GTK] W3C CSS2.1 anonymous table tests are failing
332         https://bugs.webkit.org/show_bug.cgi?id=152455
333
334         Reviewed by Mario Sanchez Prada.
335
336         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
337         tests. Add upstream patches to fix detection of XHTML files.
338
339         * gtk/jhbuild.modules:
340         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
341         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
342
343 2016-01-10  Saam barati  <sbarati@apple.com>
344
345         Implement a sampling profiler
346         https://bugs.webkit.org/show_bug.cgi?id=151713
347
348         Reviewed by Filip Pizlo.
349
350         * Scripts/run-jsc-stress-tests:
351
352 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
353
354         [webkitdirs] Try arch and uname commands on non-windows OS
355         https://bugs.webkit.org/show_bug.cgi?id=152958
356
357         Reviewed by Michael Catanzaro.
358
359         Right now, determineArchitecture()  uses `arch` and `uname -m`
360         commands to determine architecture in case of condition (isGtk() ||
361         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
362         instead, because this code is applicable to any non-windows OS WebKit
363         supports (even Haiku which once was supported is moderately
364         POSIX-compliant and has uname command).
365
366         * Scripts/webkitdirs.pm:
367         (determineArchitecture):
368
369 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
370
371         run-webkit-tests mis-counts totals when there are other crashes
372         https://bugs.webkit.org/show_bug.cgi?id=152894
373         <rdar://problem/24098697>
374
375         Reviewed by Alexey Proskuryakov.
376
377         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
378         (TestRunResults.add): Do not update result counters for other crashes.
379
380 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
381
382         webkit-patch build-and-test should have an option to iterate over new tests
383         https://bugs.webkit.org/show_bug.cgi?id=143093
384
385         Reviewed by Michael Catanzaro.
386
387         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
388         It allows running run-webkit-tests on modified or new paths in LayoutTests.
389         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
390         It implements the translation of -expected.* paths to their related tests.
391         It also implements the removal of skipped tests.
392
393         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
394         (LayoutTestFinder.find_touched_tests):
395         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
396         (MockPort):
397         (MockPort.__init__):
398         (MockPort.tests):
399         (LayoutTestFinderTests):
400         (LayoutTestFinderTests.touched_files):
401         (LayoutTestFinderTests.test_touched_test):
402         (LayoutTestFinderTests.test_expected_touched_test):
403         (LayoutTestFinderTests.test_platform_expected_touched_test):
404         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
405         (LayoutTestFinderTests.test_touched_but_skipped_test):
406         * Scripts/webkitpy/port/base.py:
407         (Port.potential_test_names_from_expected_file):
408         * Scripts/webkitpy/tool/commands/download_unittest.py:
409         (DownloadCommandsTest._default_options):
410         * Scripts/webkitpy/tool/steps/options.py:
411         (Options):
412         * Scripts/webkitpy/tool/steps/runtests.py:
413         (RunTests.options):
414         (RunTests.run):
415         (RunTests):
416         (RunTests._new_or_modified_tests):
417         (RunTests._run_webkit_tests):
418         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
419         (RunTestsTest.test_webkit_run_unit_tests):
420         * Scripts/webkitpy/tool/steps/steps_unittest.py:
421         (StepsTest._step_options):
422
423 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
424
425         prepare-ChangeLog should include radar number
426         https://bugs.webkit.org/show_bug.cgi?id=152839
427         <rdar://problem/24093563>
428
429         Reviewed by Daniel Bates.
430
431         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
432         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
433         in the ChangeLog description after the bug URL.
434
435         * Scripts/prepare-ChangeLog:
436         (main): Update signatures.
437         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
438         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
439         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
440         (generateNewChangeLogs): Include radar URL if we found one.
441
442         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
443         Tests for the radar URL extraction.
444
445 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
446
447         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
448         https://bugs.webkit.org/show_bug.cgi?id=152390
449         <rdar://problem/23948321>
450
451         Reviewed by Simon Fraser.
452
453         Fix two use-after-frees.
454
455         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
456         but we may have already progressed to another test by the time the callback fires,
457         having destroyed the TestInvocation.
458         2. UIScriptController is a RefCounted object, but it has a raw pointer to
459         UIScriptContext which has the same lifetime as a TestInvocation.
460         As a result, completion blocks of UIScriptController actions would use a destroyed
461         TestInvocation.
462
463         * WebKitTestRunner/TestInvocation.cpp:
464         (WTR::TestInvocation::~TestInvocation):
465         (WTR::TestInvocation::url):
466         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
467         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
468         (WTR::TestInvocation::runUISideScript):
469         * WebKitTestRunner/TestInvocation.h:
470         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
471         (UIScriptContext::UIScriptContext):
472         (UIScriptContext::~UIScriptContext):
473         (UIScriptContext::runUIScript):
474         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
475         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
476         (WTR::UIScriptController::UIScriptController):
477         (WTR::UIScriptController::contextDestroyed):
478         (WTR::UIScriptController::makeWindowObject):
479         (WTR::UIScriptController::setWillBeginZoomingCallback):
480         (WTR::UIScriptController::willBeginZoomingCallback):
481         (WTR::UIScriptController::setDidEndZoomingCallback):
482         (WTR::UIScriptController::didEndZoomingCallback):
483         (WTR::UIScriptController::setDidEndScrollingCallback):
484         (WTR::UIScriptController::didEndScrollingCallback):
485         (WTR::UIScriptController::setDidShowKeyboardCallback):
486         (WTR::UIScriptController::didShowKeyboardCallback):
487         (WTR::UIScriptController::setDidHideKeyboardCallback):
488         (WTR::UIScriptController::didHideKeyboardCallback):
489         (WTR::UIScriptController::uiScriptComplete):
490         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
491         (WTR::UIScriptController::create):
492         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
493         (WTR::UIScriptController::doAsyncTask):
494         (WTR::UIScriptController::zoomToScale):
495         (WTR::UIScriptController::singleTapAtPoint):
496         (WTR::UIScriptController::doubleTapAtPoint):
497         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
498         (WTR::UIScriptController::contentVisibleRect):
499         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
500         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
501         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
502         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
503         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
504         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
505         (WTR::UIScriptController::doAsyncTask):
506
507 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
508
509         [buildbot] clean-build script should remove untracked files and revert local changes too
510         https://bugs.webkit.org/show_bug.cgi?id=142400
511
512         Reviewed by Ryosuke Niwa.
513
514         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
515         A helper routine SCM.discard_untracked_files is added for that purpose.
516
517         * BuildSlaveSupport/clean-build:
518         (main): Making call to Scripts/clean-webkit
519         * Scripts/clean-webkit: Added.
520         (main): Revert changes and delete untracked files.
521         * Scripts/webkitpy/common/checkout/scm/scm.py:
522         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
523         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
524         (SCMTest._shared_test_discard_untracked_files):
525         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
526
527 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
528
529         Add a setting and preferences to enable display-list drawing. Does nothing yet.
530         https://bugs.webkit.org/show_bug.cgi?id=152807
531
532         Reviewed by Zalan Bujtas.
533         
534         Add an item to the Settings menu to toggle display-list drawing.
535
536         * MiniBrowser/mac/SettingsController.h:
537         * MiniBrowser/mac/SettingsController.m:
538         (-[SettingsController _populateMenu]):
539         (-[SettingsController validateMenuItem:]):
540         (-[SettingsController toggleDisplayListDrawingEnabled:]):
541         (-[SettingsController displayListDrawingEnabled]):
542         * MiniBrowser/mac/WK2BrowserWindowController.m:
543         (-[WK2BrowserWindowController didChangeSettings]):
544
545 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
546
547         Python SCM should be able to retrieve untracked files - Add GIT support
548         https://bugs.webkit.org/show_bug.cgi?id=143135
549
550         Reviewed by Michael Catanzaro.
551
552         * Scripts/webkitpy/common/checkout/scm/git.py:
553         (Git.untracked_files): Adding support for git.
554         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
555         (GitTest.setUp):
556         (GitTest.test_untracked_files): Adding test.
557
558 2016-01-05  Mark Lam  <mark.lam@apple.com>
559
560         Rename badly named JSC_timeout env var to JSCTEST_timeout.
561         https://bugs.webkit.org/show_bug.cgi?id=152748
562
563         Reviewed by Geoffrey Garen.
564
565         Now that we validate JSC options, the badly named JSC_timeout env var causes the
566         bots to have a bad time.
567
568         * Scripts/run-javascriptcore-tests:
569         * Scripts/run-jsc-stress-tests:
570
571 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
572
573         [GTK] Allow to save and restore session
574         https://bugs.webkit.org/show_bug.cgi?id=115600
575
576         Reviewed by Michael Catanzaro.
577
578         Add test case to check the new session API.
579
580         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
581         (testWebKitWebViewSessionState):
582         (testWebKitWebViewSessionStateWithFormData):
583         (beforeAll):
584
585 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
586
587         [EFL] Bump EFL version to 1.16.1
588         https://bugs.webkit.org/show_bug.cgi?id=152688
589
590         Reviewed by Gyuyoung Kim.
591
592         * efl/jhbuild.modules:
593
594 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
595
596         error running layout tests on iOS simulator on latest build
597         https://bugs.webkit.org/show_bug.cgi?id=152719
598         <rdar://problem/24009549>
599
600         Reviewed by Alexey Proskuryakov.
601
602         * Scripts/webkitpy/xcode/simulator.py:
603         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
604           before running simctl spawn command.
605
606 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
607
608         Unreviewed, move Frédéric Wang to committers list
609
610         He seems to be on the contributors list by accident. He has been landing his own commits for
611         about two years now.
612
613         * Scripts/webkitpy/common/config/contributors.json:
614
615 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
616
617         Unreviewed, move Sebastian Dröge to committers list harder
618
619         He accidentally added himself to the reviewers list because the file is confusing. Then I
620         accidentially moved him to the contributors list because the file is confusing, even though
621         I knew the contributors list existed in this file and was attempting to add him to the
622         committers list. Really move him to the committers list now.
623
624         * Scripts/webkitpy/common/config/contributors.json:
625
626 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
627
628         Python SCM should be able to retrieve untracked files - Add SVN support
629         https://bugs.webkit.org/show_bug.cgi?id=152546
630
631         Reviewed by Michael Catanzaro.
632
633         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
634         (test_untracked_files): Activating test for SVN.
635         * Scripts/webkitpy/common/checkout/scm/svn.py:
636         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
637
638 2015-12-31  Andy Estes  <aestes@apple.com>
639
640         Replace WTF::move with WTFMove
641         https://bugs.webkit.org/show_bug.cgi?id=152601
642
643         Reviewed by Brady Eidson.
644
645         * DumpRenderTree/TestRunner.h:
646         (TestRunner::setAllowedHosts):
647         * DumpRenderTree/win/DRTDataObject.cpp:
648         (DRTDataObject::SetData):
649         * TestWebKitAPI/Tests/WTF/Deque.cpp:
650         (TestWebKitAPI::TEST):
651         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
652         (TestWebKitAPI::TEST):
653         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
654         (TestWebKitAPI::TEST):
655         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
656         (TestWebKitAPI::TEST):
657         * TestWebKitAPI/Tests/WTF/Ref.cpp:
658         (TestWebKitAPI::passWithRef):
659         (TestWebKitAPI::TEST):
660         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
661         (TestWebKitAPI::TEST):
662         * TestWebKitAPI/Tests/WTF/Vector.cpp:
663         (TestWebKitAPI::TEST):
664         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
665         (TestWebKitAPI::TEST):
666         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
667         (TestWebKitAPI::TEST):
668         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
669         (TestWebKitAPI::createTestValue):
670         (TestWebKitAPI::TEST):
671         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
672         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
673         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
674         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
675         (TestWebKitAPI::createNFAs):
676         (TestWebKitAPI::TEST_F):
677         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
678         (TestWebKitAPI::combine):
679         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
680         (TestWebKitAPI::createNFAs):
681         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
682         (TEST):
683         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
684         (WebProcessTest::add):
685
686 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
687
688         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
689         https://bugs.webkit.org/show_bug.cgi?id=152634
690
691         Reviewed by Carlos Garcia Campos.
692
693         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
694         (testLoadFromGResource): Added test.
695         (beforeAll):
696         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
697         (registerGResource): Added.
698         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
699         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
700         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
701
702 2015-12-31  David Kilzer  <ddkilzer@apple.com>
703
704         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
705         <https://bugs.webkit.org/show_bug.cgi?id=152601>
706
707         Ignore unknown pragmas on older clangs.  Fixes the following
708         build failure:
709
710             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
711             #pragma clang diagnostic ignored "-Wself-move"
712                                              ^
713             1 error generated.
714
715         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
716         (TestWebKitAPI::TEST):
717         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
718         (TestWebKitAPI::TEST):
719
720 2015-12-31  Andy Estes  <aestes@apple.com>
721
722         Update the style checker to advise using WTFMove() instead of WTF::move()
723         https://bugs.webkit.org/show_bug.cgi?id=152601
724
725         Reviewed by Daniel Bates.
726
727         * Scripts/webkitpy/style/checkers/cpp.py:
728         (check_wtf_move):
729         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
730         (WebKitStyleTest.test_wtf_move):
731
732 2015-12-31  Andy Estes  <aestes@apple.com>
733
734         Fix warnings uncovered by migrating to WTF_MOVE
735         https://bugs.webkit.org/show_bug.cgi?id=152601
736
737         Reviewed by Daniel Bates.
738
739         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
740         self-move, even if doing so would trigger a warning.
741
742         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
743         (TestWebKitAPI::TEST):
744         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
745         (TestWebKitAPI::TEST):
746
747 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
748
749         [GTK] The install-dependencies script has a syntax error
750         https://bugs.webkit.org/show_bug.cgi?id=152613
751
752         Reviewed by Michael Catanzaro.
753
754         * gtk/install-dependencies: Add the missing 'then.'
755
756 2015-12-30  Philippe Normand  <pnormand@igalia.com>
757
758         [Mac][GTK] Jhbuild support for OSX
759         https://bugs.webkit.org/show_bug.cgi?id=150799
760
761         Reviewed by Michael Catanzaro.
762
763         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
764         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
765         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
766         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
767
768 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
769
770         Unreviewed, move Sebastian Dröge to committers list
771
772         He accidentally added himself to the reviewers list because the file is confusing.
773
774         * Scripts/webkitpy/common/config/contributors.json:
775
776 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
777
778         Remove the unused #define _USE_MATH_DEFINES
779         https://bugs.webkit.org/show_bug.cgi?id=152034
780
781         Reviewed by Tim Horton.
782         
783         Update this test to use piDouble from MathExtras.h, and
784         std::numeric_limits<>.
785
786         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
787
788 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
789
790         Python SCM should be able to retrieve untracked files - Generic changes
791         https://bugs.webkit.org/show_bug.cgi?id=152536
792
793         Reviewed by Brent Fulgham.
794
795         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
796         No support is yet added to GIT and SVN specific implementations.
797
798         * Scripts/webkitpy/common/checkout/scm/scm.py:
799         (SCM.untracked_files):
800         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
801         (SCMTest._shared_test_untracked_files):
802
803 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
804
805         SVN checkout used by RunBenchmark should be non-interactive
806         https://bugs.webkit.org/show_bug.cgi?id=152542
807
808         Reviewed by Ryosuke Niwa.
809
810         RunBenchmark should not require user interaction while running.
811
812         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
813         (BenchmarkBuilder._checkout_with_subversion):
814
815 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
816
817         Web Inspector: add support for running protocol-test.js tests on Windows
818         https://bugs.webkit.org/show_bug.cgi?id=148037
819         <rdar://problem/22292237>
820
821         Reviewed by Simon Fraser.
822
823         * DumpRenderTree/win/TestRunnerWin.cpp:
824         (TestRunner::inspectorTestStubURL): Provide implementation.
825
826 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
827
828         [MediaStream] MediaDeviceInfo.label must be empty in some situations
829         https://bugs.webkit.org/show_bug.cgi?id=152000
830
831         Reviewed by Brent Fulgham.
832
833         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
834         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
835         (WTR::InjectedBundle::setUserMediaPermission):
836         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
837         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
838
839         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
840         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
841         * WebKitTestRunner/InjectedBundle/TestRunner.h:
842
843         * WebKitTestRunner/TestController.cpp:
844         (WTR::TestController::setUserMediaPermissionForOrigin):
845         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
846         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
847           persistent permission for origin, that can be done from script now.
848         * WebKitTestRunner/TestController.h:
849
850         * WebKitTestRunner/TestInvocation.cpp:
851         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
852           SetUserMediaPermissionForOrigin.
853
854 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
855
856         [Win] Unreviewed build fix: Recognize Windows 10 variants.
857
858         * Scripts/webkitpy/common/system/platforminfo.py:
859         (PlatformInfo._determine_win_version):
860
861 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
862
863         Content blockers should be able to promote http to https
864         https://bugs.webkit.org/show_bug.cgi?id=148966
865
866         Reviewed by Benjamin Poulain.
867
868         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
869         (WebCore::ContentExtensions::operator<<):
870         (TestWebKitAPI::TEST_F):
871
872 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
873
874         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
875         https://bugs.webkit.org/show_bug.cgi?id=152516
876
877         Reviewed by Gyuyoung Kim.
878
879         * MiniBrowser/efl/main.c:
880
881 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
882
883         Unreviewed: Add John Wilander as a contributor.
884
885         * Scripts/webkitpy/common/config/contributors.json:
886
887 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
888
889         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
890         https://bugs.webkit.org/show_bug.cgi?id=152482
891
892         Reviewed by Brent Fulgham.
893
894         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
895         for the same property. On WK2, the element returned will not be valid, but is still present and
896         that can lead to looping.
897
898         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
899         (AccessibilityUIElement::horizontalScrollbar):
900         (AccessibilityUIElement::verticalScrollbar):
901         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
902         (WTR::AccessibilityUIElement::horizontalScrollbar):
903         (WTR::AccessibilityUIElement::verticalScrollbar):
904
905 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
906
907         Unreviewed.
908
909         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
910
911 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
912
913         [EFL] test_ewk2_context failed after r192808
914         https://bugs.webkit.org/show_bug.cgi?id=151846
915
916         Reviewed by Gyuyoung Kim.
917
918         Used the added ewk_context_web_process_count_limit_set api
919         instead of the deprecated ewk_context_process_model_set.
920
921         * MiniBrowser/efl/main.c:
922         (elm_main):
923
924 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
925
926         Unreviewed, move myself to reviewer list.
927
928         * Scripts/webkitpy/common/config/contributors.json:
929
930 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
931
932         Unreviewed, add myself to the committers list.
933
934         * Scripts/webkitpy/common/config/contributors.json:
935
936 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
937
938         [GTK] jquery.min.js violates DFSG
939         https://bugs.webkit.org/show_bug.cgi?id=152428
940
941         Reviewed by Joseph Pecoraro.
942
943         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
944         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
945
946         * gtk/manifest.txt.in:
947
948 2015-12-19  Dan Bernstein  <mitz@apple.com>
949
950         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
951         https://bugs.webkit.org/show_bug.cgi?id=152462
952
953         Reviewed by Alexey Proskuryakov.
954
955         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
956           OS X 10.9:
957
958         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
959         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
960         * MiniBrowser/Configurations/DebugRelease.xcconfig:
961         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
962         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
963
964         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
965           never getting compiled:
966
967         * DumpRenderTree/mac/TextInputController.m:
968         * MiniBrowser/mac/BrowserWindowController.m:
969         * TestWebKitAPI/Tests/mac/AttributedString.mm:
970         * WebKitTestRunner/mac/EventSenderProxy.mm:
971
972 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
973
974         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
975
976         This is to make it easy to CC it on Bugzilla.
977
978         * Scripts/webkitpy/common/config/contributors.json:
979
980 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
981
982         Pasteboard get messed up after running kill-old-processes
983         https://bugs.webkit.org/show_bug.cgi?id=152426
984
985         Reviewed by Alexey Proskuryakov.
986
987         * BuildSlaveSupport/kill-old-processes:
988         (main): Do not kill pasteboard anymore.
989
990 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
991
992         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
993         https://bugs.webkit.org/show_bug.cgi?id=152157
994         <rdar://problem/23851817>
995
996         Reviewed by Alexey Proskuryakov.
997
998         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
999         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1000         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1001         (Manager._get_test_inputs): Common method to calculate test_inputs.
1002         (Manager._update_worker_count): Calculate and update required number of workers.
1003
1004 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1005
1006         run-webkit-tests fails to delete Simulator device during cleanup
1007         https://bugs.webkit.org/show_bug.cgi?id=152363
1008
1009         Reviewed by Alexey Proskuryakov.
1010
1011         * Scripts/webkitpy/xcode/simulator.py:
1012         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1013
1014 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1015
1016         [mac-wk2] fast/events force click tests crashing
1017         https://bugs.webkit.org/show_bug.cgi?id=152339
1018
1019         Reviewed by Beth Dakin.
1020
1021         * WebKitTestRunner/mac/EventSenderProxy.mm:
1022         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1023         Set the NSEvent's _type member in addition to overriding -type,
1024         because there are assertions in touch event handling code that depend on it.
1025
1026 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1027
1028         Enforce temporarily bots to sync WebKit and WPT testharness.js
1029         https://bugs.webkit.org/show_bug.cgi?id=152334
1030
1031         Reviewed by Darin Adler.
1032
1033         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1034         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1035
1036 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1037
1038         [Fetch API] Add fetch API compile time flag
1039         https://bugs.webkit.org/show_bug.cgi?id=152254
1040
1041         Reviewed by Darin Adler.
1042
1043         * Scripts/webkitperl/FeatureList.pm:
1044
1045 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1046
1047         Unreviewed.
1048
1049         Added files that have impact in building Streams API to the watchlist.
1050
1051         * Scripts/webkitpy/common/config/watchlist:
1052
1053 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1054
1055         Unreviewed.
1056
1057         Added imported tests to Streams API watchlist.
1058
1059         * Scripts/webkitpy/common/config/watchlist:
1060
1061 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1062
1063         Remove default copy of wpt testharness.js when launching wpt server
1064         https://bugs.webkit.org/show_bug.cgi?id=152298
1065
1066         Reviewed by Darin Adler.
1067
1068         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1069         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1070
1071 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1072
1073         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1074         <http://webkit.org/b/152314>
1075
1076         Reviewed by Daniel Bates.
1077
1078         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1079         code path to exit immediately when calling main().
1080         Unfortunately, DumpRenderTreeMain.mm was used for both
1081         DumpRenderTree command-line binary and DumpRenderTree.app, which
1082         meant that the app would exit immediately with no error code
1083         when run!
1084
1085         The workaround is to introduce a separate source file called
1086         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1087         already does.
1088
1089         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1090         DumpRenderTreeAppMain.mm to the project.  Make it the only
1091         compiled source for the DumpRenderTree.app target.
1092         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1093         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1094         case someone tries mistakenly to use the app.
1095         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1096         Link to JavaScriptCore.framework on iOS for the assert.
1097         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1098         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1099         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1100         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1101         (main): Add assert for iOS so that a crash occurs if someone
1102         tries to run the wrong command.
1103
1104 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1105
1106         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1107         https://bugs.webkit.org/show_bug.cgi?id=152266
1108         <rdar://problem/22092676>
1109
1110         Reviewed by Simon Fraser.
1111
1112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1113         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1114         Add a test that crashed before this change, and doesn't crash after.
1115
1116 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1117
1118         AX: iOS: Text field variations do not have the correct traits
1119         https://bugs.webkit.org/show_bug.cgi?id=152237
1120
1121         Reviewed by Mario Sanchez Prada.
1122
1123         Add iOS calls for determing if an object is a search field or a text area.
1124
1125         * DumpRenderTree/AccessibilityUIElement.cpp:
1126         (getIsSearchFieldCallback):
1127         (getIsTextAreaCallback):
1128         (stringForSelectionCallback):
1129         (AccessibilityUIElement::getJSClass):
1130         * DumpRenderTree/AccessibilityUIElement.h:
1131         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1132         (AccessibilityUIElement::identifier):
1133         (AccessibilityUIElement::isTextArea):
1134         (AccessibilityUIElement::isSearchField):
1135         (AccessibilityUIElement::traits):
1136         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1137         (WTR::AccessibilityUIElement::scrollPageRight):
1138         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1139         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1140         (WTR::AccessibilityUIElement::isSearchField):
1141         (WTR::AccessibilityUIElement::isTextArea):
1142         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1143         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1144         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1145         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1146         (WTR::AccessibilityUIElement::isTextArea):
1147         (WTR::AccessibilityUIElement::isSearchField):
1148         (WTR::AccessibilityUIElement::rowCount):
1149
1150 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1151
1152         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1153         https://bugs.webkit.org/show_bug.cgi?id=152252
1154
1155         Reviewed by Sergio Villar Senin.
1156
1157         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1158         for building the JHBuild on Debian systems.
1159
1160 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1161
1162         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1163         https://bugs.webkit.org/show_bug.cgi?id=152156
1164
1165         Reviewed by Dan Bernstein.
1166
1167         Our frameworks should appropriately prefix all ObjC classes,
1168         not just external symbols.
1169
1170         * Scripts/check-for-inappropriate-objc-class-names:
1171         Remove the -g switch to check all ObjC class names.
1172
1173 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1174
1175         [MediaStream] Expose media capture devices persistent permissions to WebCore
1176         https://bugs.webkit.org/show_bug.cgi?id=152087
1177
1178         Add support for the new user media permission checker page UI client method.
1179
1180         Reviewed by Chris Dumez.
1181
1182         * WebKitTestRunner/TestController.cpp:
1183         (WTR::decidePolicyForUserMediaPermissionRequest):
1184         (WTR::checkUserMediaPermissionForOrigin):
1185         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1186         (WTR::TestController::createWebViewWithOptions): Ditto.
1187         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1188         (WTR::originUserVisibleName): New, create a string for the origin.
1189         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1190           according to the state of the origin permission map.
1191         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1192           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1193         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1194           origin permission map.
1195         * WebKitTestRunner/TestController.h:
1196
1197 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1198
1199         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1200         https://bugs.webkit.org/show_bug.cgi?id=152022
1201         rdar://problem/23763584
1202
1203         Reviewed by Darin Adler.
1204
1205         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1206         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1207         (WTR::InjectedBundlePage::willSendRequestForFrame):
1208         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1209         (WTR::TestRunner::setWillSendRequestReturnsNull):
1210         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1211         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1212         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1213         (WTR::TestRunner::willSendRequestHTTPBody):
1214         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1215
1216 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1217
1218         Remove additional simulator checks before running layout-tests
1219         https://bugs.webkit.org/show_bug.cgi?id=152146
1220
1221         Reviewed by Darin Adler.
1222
1223         * Scripts/webkitpy/port/ios.py:
1224         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1225         * Scripts/webkitpy/xcode/simulator.py:
1226         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1227         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1228
1229 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1230
1231         Run atleast one simulator even if max process limit is low
1232         https://bugs.webkit.org/show_bug.cgi?id=152081
1233         <rdar://problem/23819694>
1234
1235         Reviewed by Alexey Proskuryakov.
1236
1237 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1238
1239         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1240         https://bugs.webkit.org/show_bug.cgi?id=144262
1241
1242         Reviewed by Carlos Garcia Campos.
1243
1244         Added new unit test to check the additional scenarios we now
1245         handle for custom URI schemes.
1246
1247         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1248         (generateHTMLContent): New helper function to generate big enough content.
1249         (testWebContextURIScheme): New unit test.
1250
1251 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1252
1253         [EFL] Fix unhandled web process message when launching MiniBrowser
1254         https://bugs.webkit.org/show_bug.cgi?id=152048
1255
1256         Reviewed by Gyuyoung Kim.
1257
1258         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1259         (TestWebKitAPI::TEST):
1260
1261 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1262
1263         [GTK] Add API to handle beforeunload events
1264         https://bugs.webkit.org/show_bug.cgi?id=139090
1265
1266         Reviewed by Gustavo Noronha Silva.
1267
1268         * MiniBrowser/gtk/BrowserWindow.c:
1269         (browserWindowConstructed):
1270         (browserWindowDeleteEvent):
1271         (browser_window_class_init):
1272         Handle delete-event to prevent the window from being closed when
1273         the page has beforeunload handlers. Use
1274         webkit_web_view_try_close() when the window is requested to be
1275         closed.
1276         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1277         (testWebViewJavaScriptDialogs):
1278         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1279         script dialog type.
1280
1281 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1282
1283         Refactored initialization code in LoadTrackingTest.
1284
1285         Rubber-stamped by Carlos Garcia Campos.
1286
1287         Small refactoring to make sure that the state of a LoadTrackingTest
1288         gets properly reset before loading new web content.
1289
1290         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1291         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1292         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1293         functions and reset the remaining local variables.
1294         (LoadTrackingTest::loadURI): Call reset();
1295         (LoadTrackingTest::loadHtml): Ditto.
1296         (LoadTrackingTest::loadPlainText): Ditto.
1297         (LoadTrackingTest::loadBytes): Ditto.
1298         (LoadTrackingTest::loadRequest): Ditto.
1299         (LoadTrackingTest::reload): Ditto.
1300         (LoadTrackingTest::goBack): Ditto.
1301         (LoadTrackingTest::goForward): Ditto.
1302
1303 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1304
1305         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1306         https://bugs.webkit.org/show_bug.cgi?id=151942
1307
1308         Reviewed by Darin Adler.
1309
1310         * MiniBrowser/efl/main.c:
1311         (window_create): Enable offline web application cache feature on MiniBrowser.
1312         (elm_main):
1313
1314 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1315
1316         https://bugs.webkit.org/show_bug.cgi?id=151243
1317         <rdar://problem/22955197>
1318
1319         Reviewed by Alexey Proskuryakov.
1320
1321         * LayoutTestRelay/LayoutTestRelay/main.m:
1322         (getTestingSimDevice): Use separate testing device for each worker.
1323         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1324         (Manager.run): Perform cleanup even if setup fails.
1325         * Scripts/webkitpy/port/ios.py:
1326         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1327         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1328         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1329         (IOSSimulatorPort._quit_ios_simulator): Same
1330         (IOSSimulatorPort.clean_up_test_run): Same
1331         (IOSSimulatorPort.check_sys_deps): Same
1332         (IOSSimulatorPort.testing_device): Same
1333         (IOSSimulatorPort.reset_preferences): Same
1334         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1335         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1336         * Scripts/webkitpy/xcode/simulator.py:
1337         (Device.delete): Delete the simulator device.
1338         (Simulator.delete_device): Same
1339         (Simulator.wait_until_device_is_booted): Wait for device booting.
1340
1341 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1342
1343         [EFL] Add API to provide preferences before creating ewk_view
1344         https://bugs.webkit.org/show_bug.cgi?id=151587
1345
1346         Reviewed by Gyuyoung Kim.
1347
1348         * MiniBrowser/efl/main.c:
1349         (on_key_down):
1350         (quit):
1351         (window_create):
1352         Moved settings related code to configuration() not to update settings
1353         whenever ewk_view is created.
1354         (configuration):
1355         (elm_main):
1356
1357 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1358
1359         Unreviewed. Fix GTK+ API tests after r193639.
1360
1361         The new jhbuild version needs some more variables ot be present in
1362         the builtin dict, even if they are set to None.
1363
1364         * jhbuild/jhbuildutils.py:
1365         (enter_jhbuild_environment_if_available):
1366
1367 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1368
1369         [GTK] Notify WebCore when notification is clicked
1370         https://bugs.webkit.org/show_bug.cgi?id=151951
1371
1372         Reviewed by Carlos Garcia Campos.
1373
1374         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1375         (testWebViewNotification): test the new API.
1376
1377 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1378
1379         'jhbuild build' should fail immediately when building any module fails
1380         https://bugs.webkit.org/show_bug.cgi?id=145697
1381
1382         Reviewed by Carlos Garcia Campos.
1383
1384         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1385         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1386         Everything is placed under lib instead of lib64 now.
1387         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1388         --exit-on-error when running 'jhbuild build'.
1389         * jhbuild/jhbuildrc_common.py:
1390         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1391         jhbuild should be able to handle these for us without breaking things....
1392
1393 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1394
1395         Add support to import w3c tests from a repository with a different root that the main repo dir
1396         https://bugs.webkit.org/show_bug.cgi?id=151751
1397
1398         Reviewed by Ryosuke Niwa and Youenn Fablet.
1399
1400         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1401         in a different directory than the repository root.
1402
1403         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1404         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1405         requires having the copy_path lists including tuples of origin and destination directories.
1406
1407         * Scripts/webkitpy/w3c/test_downloader.py:
1408         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1409         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1410         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1411         (TestImporterTest.test_tests_directory): Test.
1412
1413 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1414
1415         Mock TestRepositories in W3C importer tests
1416         https://bugs.webkit.org/show_bug.cgi?id=151938
1417
1418         Reviewed by Youenn Fablet.
1419
1420         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1421         is because the test repository method reading the file was using the filesystem directly instead of taking the
1422         host one. This patch changes that.
1423
1424         * Scripts/webkitpy/w3c/test_downloader.py:
1425         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1426         default one.
1427         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1428         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1429         (TestImporterTest.test_harnesslinks_conversion):
1430         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1431
1432 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1433
1434         TestNetscapePlugIn: Address review comment on 193607
1435         <http://webkit.org/b/151881>
1436
1437         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1438         (testSetStatus): Initializing std::unique_ptr<char[]> with
1439         nullptr is redundant.
1440
1441 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1442
1443         [GTK] Add webkit_uri_request_get_http_method
1444         https://bugs.webkit.org/show_bug.cgi?id=151601
1445
1446         Reviewed by Martin Robinson.
1447
1448         Add test case to check HTTP method of WebKitURIRequest.
1449
1450         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1451         (testURIRequestHTTPMethod):
1452         (serverCallback):
1453         (beforeAll):
1454         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1455         (sendRequestCallback):
1456
1457 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1458
1459         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1460         https://bugs.webkit.org/show_bug.cgi?id=79918
1461
1462         Reviewed by Gustavo Noronha Silva.
1463
1464         Add unit tests to check the different console messages.
1465
1466         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1467         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1468         (ConsoleMessageTest::ConsoleMessage::operator==):
1469         (ConsoleMessageTest::consoleMessageReceivedCallback):
1470         (ConsoleMessageTest::ConsoleMessageTest):
1471         (ConsoleMessageTest::~ConsoleMessageTest):
1472         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1473         (testWebKitConsoleMessageConsoleAPI):
1474         (testWebKitConsoleMessageJavaScriptException):
1475         (testWebKitConsoleMessageNetworkError):
1476         (testWebKitConsoleMessageSecurityError):
1477         (beforeAll):
1478         (afterAll):
1479         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1480         (consoleMessageSentCallback):
1481         (pageCreatedCallback):
1482
1483 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1484
1485         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1486         https://bugs.webkit.org/show_bug.cgi?id=151934
1487
1488         Reviewed by Csaba Osztrogonác.
1489
1490         * MiniBrowser/efl/main.c:
1491         (on_window_deletion): Revert the changes of r192767.
1492
1493 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1494
1495         [GTK] update-webkitgtk-libs cannot build mesa
1496         https://bugs.webkit.org/show_bug.cgi?id=151535
1497
1498         Reviewed by Martin Robinson.
1499
1500         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1501         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1502         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1503         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1504         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1505         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1506
1507         * gtk/jhbuild.modules:
1508
1509 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1510
1511         [GTK][Mac] libWebExtensionTest link error
1512         https://bugs.webkit.org/show_bug.cgi?id=150802
1513
1514         Reviewed by Carlos Garcia Campos.
1515
1516         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1517
1518 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1519
1520         TestNetscapePlugIn: Fix leaks found by static analyzer
1521         <http://webkit.org/b/151881>
1522
1523         Reviewed by Darin Adler.
1524
1525         Fixes the following leaks found by the static analyzer:
1526             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1527                     return false;
1528                            ^~~~~
1529             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1530                     return false;
1531                            ^~~~~
1532             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1533                     return false;
1534                            ^~~~~
1535
1536         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1537         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1538         early return if allocation fails.
1539         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1540         Make sure to call fclose() on filehandle, even for an early
1541         return.
1542         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1543
1544 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1545
1546         prepare-ChangeLog: Fix some warning messages when using svn
1547         <http://webkit.org/b/151914>
1548
1549         Reviewed by Daniel Bates.
1550
1551         * Scripts/prepare-ChangeLog:
1552         (generateFunctionLists): Simplify logic so that we never call
1553         normalizePath() with an undefined value.
1554         (attributeCommand): Quote $subPath for the shell so that we
1555         don't try to run "svn propget" on invalid paths.
1556
1557 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1558
1559         TestNetscapePlugIn: Fix remaining static analyzer warnings
1560         <http://webkit.org/b/151888>
1561
1562         Reviewed by Alexey Proskuryakov.
1563
1564         Fixes the following static analyzer warnings:
1565             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1566                     CRASH();
1567                     ^~~~~~~
1568             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1569                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1570                 ^~~~~~~~~~~~~~~~
1571             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1572                 return obj->pluginTest->NPP_SetWindow(window);
1573                        ^~~~~~~~~~~~~~~
1574             2 warnings generated.
1575
1576         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1577         (CRASH): Use __builtin_trap() for gcc/clang.
1578         (NPP_SetWindow): Add early return if obj is nullptr.
1579
1580 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1581
1582         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1583         https://bugs.webkit.org/show_bug.cgi?id=151797
1584
1585         Reviewed by Martin Robinson.
1586
1587         Since we switched to use the network process to run the unit tests
1588         the test /webkit2/WebKitWebResource/get-data sometimes fails and
1589         sometimes passes. We are now also getting the notification for the
1590         css image. Since we wait for 3 resources, sometimes the css image
1591         is loaded before and then checkResourceData is called for it, but
1592         not handled. When the css image is the last one loaded the test
1593         passes. So, we just need to wait for the 4 resources.
1594
1595         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1596         (testWebResourceGetData):
1597
1598 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1599
1600         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1601         <http://webkit.org/b/151845>
1602
1603         Reviewed by Simon Fraser.
1604
1605         Fixes the following static analyzer warning:
1606             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1607                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1608                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1609
1610         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1611         (createBitmapContext): Free 'buffer' after using it in logging
1612         to fix the use-after-free.  Assign a value of nullptr to buffer
1613         so we don't return with it set to a freed address.
1614
1615 2015-12-03  Jer Noble  <jer.noble@apple.com>
1616
1617         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1618         https://bugs.webkit.org/show_bug.cgi?id=151830
1619
1620         Reviewed by Anders Carlsson.
1621
1622         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1623
1624         * DumpRenderTree/mac/DumpRenderTree.mm:
1625         (resetWebPreferencesToConsistentValues):
1626         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1627         (WTR::initializeWebViewConfiguration):
1628
1629 2015-12-03  Anders Carlsson  <andersca@apple.com>
1630
1631         Remove Objective-C GC support
1632         https://bugs.webkit.org/show_bug.cgi?id=151819
1633         rdar://problem/23746991
1634
1635         Reviewed by Dan Bernstein.
1636
1637         * asan/asan.xcconfig:
1638
1639 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1640
1641         Allow nil for unspecified benchmark pathes
1642         https://bugs.webkit.org/show_bug.cgi?id=151784
1643
1644         Reviewed by Filip Pizlo.
1645
1646         `Pathname.new(nil)` will raise an error.
1647         Only generate Pathname if the benchmark path is specified.
1648
1649         * Scripts/run-jsc-benchmarks:
1650
1651 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1652
1653         [Win] Run non-http tests without Cygwin
1654         https://bugs.webkit.org/show_bug.cgi?id=151721
1655
1656         Reviewed by Andy Estes.
1657
1658         Support native 32-bit and 64-bit Python (and Perl) builds
1659         for running tests:
1660
1661         1. Use "startswith('win')", rather than "== 'win32'" to support
1662         various Windows build types.
1663         2. Supply full path for some native Windows utilities, since the
1664         path environment does not always have the specified, and they are
1665         guaranteed to exist in those specific locations.
1666         3. Make sure native Windows Python test runs pass proper environment
1667         variables to run programs.
1668         4. Append 'exe' suffix when running Windows executables.
1669         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1670         command doesn't exist.
1671         
1672         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1673         the current Perl executable, rather than requiring a new path search.
1674         * Scripts/webkitpy/common/find_files_unittest.py:
1675         (TestWinNormalize.test_win): Use startswith('win').
1676         * Scripts/webkitpy/common/prettypatch_unittest.py:
1677         (test_pretty_diff_encodings): Ditto.
1678         * Scripts/webkitpy/common/system/executive.py:
1679         (Executive._should_close_fds): Ditto.
1680         (Executive.shell_command_for_script): Use startswith('win').
1681         (Executive.kill_process): Use full path to killall executable.
1682         (Executive.check_running_pid): Use startswith('win').
1683         (Executive.running_pids): Ditto.
1684         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1685         running under native Windows Python.
1686         (Executive._child_process_encoding): Use startswith('win').
1687         (Executive._should_encode_child_process_arguments): Ditto.
1688         (Executive.popen): Recognize proper script engine on Windows, since it
1689         does not support the shebang syntax.
1690         (Executive.run_in_parallel): Use startswith('win').
1691         * Scripts/webkitpy/common/system/executive_unittest.py:
1692         (never_ending_command): Ditto.
1693         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1694         (ExecutiveTest.serial_test_kill_process): Ditto.
1695         (ExecutiveTest.serial_test_kill_all): Ditto.
1696         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1697         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1698         (main): Ditto.
1699         * Scripts/webkitpy/common/system/file_lock.py:
1700         (FileLock._create_lock): Ditto.
1701         (FileLock._remove_lock): Ditto.
1702         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1703         (RealFileSystemTest.test_chdir): Ditto.
1704         (RealFileSystemTest.test_chdir__notexists): Ditto.
1705         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1706         * Scripts/webkitpy/common/system/path_unittest.py:
1707         (AbspathTest.test_abspath_to_uri_win): Ditto.
1708         * Scripts/webkitpy/common/system/platforminfo.py:
1709         (PlatformInfo._determine_os_name): Ditto.
1710         * Scripts/webkitpy/common/system/user.py: Ditto.
1711         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1712         (ManagerTest.integration_test_needs_servers): Ditto.
1713         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1714         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1715         driver letters.
1716         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1717         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1718         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1719         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1720         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1721         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1722         (TestHttpServer.test_start_cmd): Ditto.
1723         * Scripts/webkitpy/port/base.py:
1724         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1725         and 'SYSTEMROOT' in environment passed to test runners.
1726         (Port._apache_config_file_name_for_platform): Use startswith('win').
1727         (Port._build_path): Ditto.
1728         (Port._path_to_driver): Include 'exe' suffix when running under native
1729         Windows.
1730         * Scripts/webkitpy/port/driver.py:
1731         (Driver._setup_environ_for_driver): Explicitly make some environment
1732         variables strings.
1733         * Scripts/webkitpy/port/server_process.py:
1734         (ServerProcess.__init__): Use startswith('win').
1735         * Scripts/webkitpy/port/win.py:
1736         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1737         registry key formats.
1738         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1739         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1740         and regtool on Cygwin.
1741         (WinPort.write_registry_value): Ditto.
1742         (WinPort.setup_crash_log_saving): Ditto.
1743         (WinPort.restore_crash_log_saving): Ditto.
1744         (WinPort.prevent_error_dialogs): Ditto.
1745         (WinPort.allow_error_dialogs): Ditto.
1746         (WinPort.find_system_pid): Revise to use Windows management
1747         infrastructure on native Windows, continue using 'ps' on Cygwin.
1748         (WinPort.read_registry_string): Deleted.
1749         (WinPort.write_registry_string): Deleted.
1750         * Scripts/webkitpy/test/main.py:
1751         (main): Use startswith('win').
1752         (Tester._parse_args): Ditto.
1753
1754 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1755
1756         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1757         https://bugs.webkit.org/show_bug.cgi?id=150792
1758
1759         Reviewed by Saam Barati.
1760
1761         * Scripts/webkitperl/FeatureList.pm:
1762
1763 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1764
1765         Unreviewed, rolling out r192914.
1766         https://bugs.webkit.org/show_bug.cgi?id=151734
1767
1768         JSC tests for this change are failing on 32 and 64-bit bots
1769         (Requested by ryanhaddad on #webkit).
1770
1771         Reverted changeset:
1772
1773         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1774         enable this feature"
1775         https://bugs.webkit.org/show_bug.cgi?id=150792
1776         http://trac.webkit.org/changeset/192914
1777
1778 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1779
1780         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1781         <http://webkit.org/b/151726>
1782
1783         Reviewed by Simon Fraser.
1784
1785         * WebKitTestRunner/mac/EventSenderProxy.mm:
1786         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1787         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1788
1789 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1790
1791         Give String and AtomicString an existingHash() function
1792         https://bugs.webkit.org/show_bug.cgi?id=151717
1793
1794         Reviewed by Andreas Kling.
1795
1796         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1797         (TestWebKitAPI::TEST):
1798         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1799         (TestWebKitAPI::TEST):
1800
1801 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1802
1803         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1804         https://bugs.webkit.org/show_bug.cgi?id=150792
1805
1806         Reviewed by Saam Barati.
1807
1808         * Scripts/webkitperl/FeatureList.pm:
1809
1810 2015-12-01  Sam Weinig  <sam@webkit.org>
1811
1812         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1813         <rdar://problem/23320863>
1814         https://bugs.webkit.org/show_bug.cgi?id=151708
1815
1816         Reviewed by Anders Carlsson.
1817
1818         * WebKitTestRunner/TestController.cpp:
1819         (WTR::TestController::createOtherPage):
1820         (WTR::TestController::createWebViewWithOptions):
1821         Update for new WKPageUIClient.
1822
1823 2015-12-01  Anders Carlsson  <andersca@apple.com>
1824
1825         Remove WebKit2.framework
1826         https://bugs.webkit.org/show_bug.cgi?id=151715
1827
1828         Reviewed by Dan Bernstein.
1829
1830         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1831         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1832         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1833         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1834         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1835         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1836         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1837
1838 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
1839
1840         Unreviewed common typo fix "occurance" => "occurrence".
1841
1842         * Scripts/webkitpy/tool/commands/queries.py:
1843         (FindFlakyTests._print_statistics):
1844
1845 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1846
1847         Make ProcessModel always MultipleSecondaryProcesses
1848         https://bugs.webkit.org/show_bug.cgi?id=151662
1849
1850         Reviewed by Antti Koivisto.
1851
1852         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1853         (TestWebKitAPI::TEST):
1854         * WebKitTestRunner/TestController.cpp:
1855         (WTR::TestController::generatePageConfiguration):
1856
1857 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1858
1859         Make usesNetworkProcess always true
1860         https://bugs.webkit.org/show_bug.cgi?id=151580
1861
1862         Reviewed by Darin Adler.
1863
1864         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1865         (TestWebKitAPI::TEST):
1866         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1867         (TestWebKitAPI::TEST):
1868         * WebKitTestRunner/TestController.cpp:
1869         (WTR::TestController::generatePageConfiguration):
1870
1871 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1872
1873         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1874
1875         Add a way to skip unit tests only for Debug or Release builds and
1876         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1877
1878         * Scripts/run-gtk-tests:
1879         (SkippedTest):
1880         (SkippedTest.__init__):
1881         (SkippedTest.__str__):
1882         (SkippedTest.skip_entire_suite):
1883         (SkippedTest.skip_for_build_type):
1884         (TestRunner):
1885         (TestRunner.__init__):
1886
1887 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1888
1889         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
1890
1891         It's an assert hit because we are reloading a view loaded with
1892         HTML data which is not supported. Use loadURI instead.
1893
1894         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1895         (testWebViewCustomCharset):
1896
1897 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1898
1899         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
1900         https://bugs.webkit.org/show_bug.cgi?id=151633
1901
1902         Reviewed by Csaba Osztrogonác.
1903
1904         * TestWebKitAPI/PlatformGTK.cmake:
1905         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
1906
1907 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1908
1909         [GTK] Remove the remaining uses of GMainLoopSource
1910         https://bugs.webkit.org/show_bug.cgi?id=151632
1911
1912         Reviewed by Žan Doberšek.
1913
1914         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1915         (testWebViewSyncRequestOnMaxConns):
1916         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1917         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1918         (WTR::TestRunner::TestRunner):
1919         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1920         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1921         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1922         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1923         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1924         (WTR::timeoutSource):
1925         (WTR::TestController::notifyDone):
1926         (WTR::TestController::platformRunUntil):
1927
1928 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1929
1930         [cmake] Add testb3 to the build system
1931         https://bugs.webkit.org/show_bug.cgi?id=151619
1932
1933         Reviewed by Gyuyoung Kim.
1934
1935         * Scripts/build-jsc:
1936
1937 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1938
1939         [jhbuild] Fix pixman build with clang
1940         https://bugs.webkit.org/show_bug.cgi?id=151441
1941
1942         Reviewed by Carlos Garcia Campos.
1943
1944         * efl/jhbuild.modules:
1945         * gtk/jhbuild.modules:
1946
1947 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1948
1949         Extract prependToEnvironmentVariableList
1950         <http://webkit.org/b/151536>
1951
1952         Reviewed by Daniel Bates.
1953
1954         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1955                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1956
1957         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1958         and prependToEnvironmentVariableList.
1959         (appendToEnvironmentVariableList): Simplify variable name.
1960         Switch to use $Config{path_sep}.
1961         (prependToEnvironmentVariableList): Add new method.
1962         (setupMacWebKitEnvironment): Switch to use
1963         prependToEnvironmentVariableList().
1964         (setupIOSWebKitEnvironment): Ditto.
1965
1966         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1967         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1968
1969 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1970
1971         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1972         https://bugs.webkit.org/show_bug.cgi?id=151567
1973
1974         Reviewed by Darin Adler.
1975
1976         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1977         (on_window_deletion):
1978
1979 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1980
1981         [GTK] Use the network process unconditionally
1982         https://bugs.webkit.org/show_bug.cgi?id=151541
1983
1984         Reviewed by Alex Christensen.
1985
1986         Fix TestInspectorServer test. Do not assume we already have the
1987         title we want when the page has been loaded, since the title is
1988         changed afterwards. So, check if the title has already been set,
1989         and if not wait for it.
1990
1991         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1992         (openRemoteDebuggingSession):
1993
1994 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1995
1996         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1997         https://bugs.webkit.org/show_bug.cgi?id=151532
1998
1999         Reviewed by Benjamin Poulain.
2000
2001         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2002         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2003         (TestWebKitAPI::TEST):
2004         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2005         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2006         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2007         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
2008         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2009         so it was calling a function on a test object that had gone out of scope.
2010         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2011         but that will become the default soon and that call will be removed.
2012
2013 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2014
2015         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2016         <http://webkit.org/b/151542>
2017
2018         Reviewed by Daniel Bates.
2019
2020         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2021         (base_url): Use the Port object (already passed in) to give us
2022         the path to the LayoutTests directory, which already checks for a
2023         --layout-tests-directory command-line switch.
2024         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2025         argument since we can get this from the Port object already
2026         passed in via Port.results_directory().  Also switch to use
2027         Port.layout_tests_dir() to get the LayoutTests directory.
2028
2029         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2030         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2031         Add test case for custom LayoutTests directory.
2032         (TestWebPlatformTestServer.test_previously_spawned_instance):
2033         Update Port object to set mock results directory as if it was
2034         set on the command-line.  Remove unneeded argument from
2035         WebPlatformTestServer constructor.
2036         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2037
2038         * Scripts/webkitpy/port/base.py:
2039         (Port.to.start_web_platform_test_server): Remove unneeded
2040         argument from WebPlatformTestServer constuctor.
2041
2042 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2043
2044         [GTK] Some unit tests fail when using the network process
2045         https://bugs.webkit.org/show_bug.cgi?id=151490
2046
2047         Reviewed by Martin Robinson.
2048
2049         Run the soup server in a separate thread in TestResources test to
2050         avoid deadlocks.
2051
2052         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2053         /webkit2/WebKitWebResource/get-data when using the network process.
2054
2055         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2056         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2057         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2058         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2059         present, create a WorkQueue to run the server.
2060         (WebKitTestServer::run): Run the server in the work queue if it
2061         has been created.
2062         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2063         type into server options as flags.
2064
2065 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2066
2067         [GTK] ImageDiff should normalize the diff image
2068         https://bugs.webkit.org/show_bug.cgi?id=151261
2069
2070         Reviewed by Sergio Villar Senin.
2071
2072         * ImageDiff/gtk/ImageDiff.cpp:
2073         (readPixbufFromStdin): Fix memory leak.
2074         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2075         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2076
2077 == Rolled over to ChangeLog-2015-11-21 ==