230a8ebf605dafc7a86d5d3b8aa27291c2205660
[WebKit.git] / Tools / ChangeLog
1 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
2
3         [macOS] Accessibility sandbox regressions
4         https://bugs.webkit.org/show_bug.cgi?id=209065
5
6         Reviewed by Brent Fulgham.
7
8         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
9         (TEST):
10         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
11         (TEST):
12
13 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
14
15         Unreviewed infrastructure fix.
16
17         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
18         while the hardware is out for repair.
19
20 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
21
22         [WebXR] IDLs, stubs and build configuration for WPE
23         https://bugs.webkit.org/show_bug.cgi?id=208702
24
25         Reviewed by Dean Jackson.
26
27         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
28         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
29
30 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
31
32         [Cocoa] Limit set of classes that can be decoded when a preference has changed
33         https://bugs.webkit.org/show_bug.cgi?id=208012
34
35         Reviewed by Brent Fulgham.
36
37         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
38         (TEST):
39
40 2020-03-16  youenn fablet  <youenn@apple.com>
41
42         Unique origins should not be Potentially Trustworthy
43         https://bugs.webkit.org/show_bug.cgi?id=209049
44
45         Reviewed by Darin Adler.
46
47         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
48         (TestWebKitAPI::TEST_F):
49
50 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
51
52         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
53         https://bugs.webkit.org/show_bug.cgi?id=207324
54
55         Reviewed by Darin Adler.
56
57         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
58         (TestWebKitAPI::generateRandomData): Added.
59         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
60
61 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
62
63         Should not use variable-length-array (VLA)
64         https://bugs.webkit.org/show_bug.cgi?id=209043
65
66         Reviewed by Mark Lam.
67
68         * ContentExtensionTester/Configurations/Base.xcconfig:
69         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
70
71 2020-03-13  Alex Christensen  <achristensen@webkit.org>
72
73         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
74         https://bugs.webkit.org/show_bug.cgi?id=209011
75         <rdar://problem/59370588>
76
77         Reviewed by Youenn Fablet.
78
79         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
80         (TestWebKitAPI::TEST):
81
82 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
83
84         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
85         https://bugs.webkit.org/show_bug.cgi?id=209089
86
87         Reviewed by Tim Horton.
88
89         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
90         marketing name for the feature.
91
92         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
93         (runUntilReceivesAutoplayEvent):
94
95         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
96         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
97         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
98         be any compelling reason to compare against different types here (especially since we only set
99         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
100         these all to be `_WKAutoplayEvent`.
101
102         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
103         (-[AutoFillTestView _autofillInputView]):
104         (-[AutoFillTestView textInputHasAutoFillContext]):
105         (TestWebKitAPI::TEST):
106         (-[AutofillTestView initWithFrame:]): Deleted.
107         (-[AutofillTestView _autofillInputView]): Deleted.
108         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
109         * TestWebKitAPI/ios/UIKitSPI.h:
110
111 2020-03-13  Chris Dumez  <cdumez@apple.com>
112
113         Unreviewed, reverting r256232.
114
115         Caused ResizeObserver tests to become flaky
116
117         Reverted changeset:
118
119         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
120         override TestOptions"
121         https://bugs.webkit.org/show_bug.cgi?id=207481
122         https://trac.webkit.org/changeset/256232
123
124 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
125
126         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
127         https://bugs.webkit.org/show_bug.cgi?id=209016
128         <rdar://problem/60329530> 
129
130         Reviewed by Chris Dumez.
131
132         Re-initialize the app-bound domains when the correct
133         TestOptions parameter is set.
134
135         * WebKitTestRunner/TestController.cpp:
136         (WTR::TestController::createWebViewWithOptions):
137         (WTR::TestController::reinitializeAppBoundDomains):
138         * WebKitTestRunner/TestController.h:
139
140 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
141
142         Report all third party loads on a per-page basis
143         https://bugs.webkit.org/show_bug.cgi?id=209032
144         <rdar://problem/60397323>
145
146         Reviewed by Chris Dumez.
147
148         Mostly naming updates to reflect the change in use for this SPI call.
149         It now returns all loaded third party domains, not just prevalent ones.
150
151         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
152         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
153         (WTR::InjectedBundle::didReceiveMessageToPage):
154         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
155         (WTR::TestRunner::getLoadedThirdPartyDomains):
156         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
157         (WTR::TestRunner::getPrevalentDomains): Deleted.
158         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
159         * WebKitTestRunner/InjectedBundle/TestRunner.h:
160         * WebKitTestRunner/TestController.cpp:
161         (WTR::TestController::resetStateToConsistentValues):
162         (WTR::TestController::getLoadedThirdPartyDomains):
163         (WTR::TestController::clearLoadedThirdPartyDomains):
164         (WTR::TestController::getPrevalentDomains): Deleted.
165         (WTR::TestController::clearPrevalentDomains): Deleted.
166         * WebKitTestRunner/TestController.h:
167         * WebKitTestRunner/TestInvocation.cpp:
168         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
169         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
170         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
171         * WebKitTestRunner/TestInvocation.h:
172         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
173         (WTR::TestController::getLoadedThirdPartyDomains):
174         (WTR::TestController::clearLoadedThirdPartyDomains):
175         (WTR::TestController::getPrevalentDomains): Deleted.
176         (WTR::TestController::clearPrevalentDomains): Deleted.
177
178 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
179
180         [ews] run FindModifiedChangeLogs early in the build
181         https://bugs.webkit.org/show_bug.cgi?id=209060
182
183         Reviewed by Jonathan Bedard.
184
185         * BuildSlaveSupport/ews-build/factories.py:
186         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
187
188 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
189
190         [GTK] Add EWS testers to run GTK layout tests
191         https://bugs.webkit.org/show_bug.cgi?id=207648
192
193         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
194
195         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
196         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
197         tests (layout tests).
198
199         * BuildSlaveSupport/ews-build/config.json: Added new queue for
200         WK2 tests.
201         * BuildSlaveSupport/ews-build/factories.py:
202         (GTKTestsFactory):
203         * BuildSlaveSupport/ews-build/factories_unittest.py:
204         (TestCommitQueueFactory.test_commit_queue_factory):
205         (TestGTKFactory): Added unit-test.
206         (TestGTKFactory.test_gtk_factory):
207         * BuildSlaveSupport/ews-build/loadConfig.py:
208         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
209         (TagsForBuilderTest.test_getTagsForBuilder):
210
211 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
212
213         Add API endpoint in EWS django app to provide patch status in json format
214         https://bugs.webkit.org/show_bug.cgi?id=208940
215
216         Reviewed by Jonathan Bedard.
217
218         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
219         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
220
221 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
222
223         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
224         https://bugs.webkit.org/show_bug.cgi?id=209055
225         <rdar://problem/60272692>
226
227         Reviewed by Simon Fraser.
228
229         Now that WebKitTestRunner has a bundleID, its' user default values
230         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
231         to NO before running tests. It will be set to YES in PlatformWebView
232         if specified by the test.
233
234         * WebKitTestRunner/mac/main.mm:
235         (setDefaultsToConsistentValuesForTesting):
236
237 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
238
239         [CMake] Eleminate mismatches between Find* module names and variables they set
240         https://bugs.webkit.org/show_bug.cgi?id=208948
241
242         Reviewed by Michael Catanzaro.
243
244         * wpe/backends/CMakeLists.txt:
245
246 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
247
248         [ews-app] reduce logging
249         https://bugs.webkit.org/show_bug.cgi?id=209062
250
251         Reviewed by Jonathan Bedard.
252
253         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
254         (BugzillaBeautifulSoup.authenticate):
255         (BugzillaBeautifulSoup._load_query):
256
257 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
258
259         Crash in TextIterator::node via TextManipulationController::replace
260         https://bugs.webkit.org/show_bug.cgi?id=209048
261
262         Reviewed by Wenson Hsieh.
263
264         Added a regression test.
265
266         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
267         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
268
269 2020-03-13  Saam Barati  <sbarati@apple.com>
270
271         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
272         https://bugs.webkit.org/show_bug.cgi?id=209038
273
274         Reviewed by Keith Miller.
275
276         This allows us to automatically pull in some tests that are in non open sourced Apple
277         checkouts.
278
279         * Scripts/run-javascriptcore-tests:
280         (runJSCStressTests):
281
282 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
283
284         Crash in TextManipulationController::replace
285         https://bugs.webkit.org/show_bug.cgi?id=209021
286
287         Reviewed by Wenson Hsieh.
288
289         Added a regression test.
290
291         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
292         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
293
294 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
295
296         [macOS] _AXSApplicationAccessibilityEnabled should not be called
297         https://bugs.webkit.org/show_bug.cgi?id=208953
298
299         Reviewed by Brent Fulgham.
300
301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
302
303 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
304
305         Resource load statistics data summary should return all third party data
306         https://bugs.webkit.org/show_bug.cgi?id=209000
307         <rdar://problem/60348306>
308
309         Reviewed by John Wilander.
310
311         Marked only 2 of 3 domains prevalent in data summary tests to ensure
312         the call returns all third parties, not just prevalent ones.
313         Added a more aggressive check for the size of the array at the
314         beginning of the test to ensure the array is still returning 3 values. 
315         Also removed the ASSERT statements as they seem to cause timeouts (not
316         clear crashes) when they are not true, which is hard to debug.
317         If these values are nil, the test will fail in the EXPECT_WK_STREQ
318         checks, we don't need ASSERT statements.
319
320         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
321         (TEST):
322
323 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
324
325         resultsdpy: Add script to run local instance
326         https://bugs.webkit.org/show_bug.cgi?id=208746
327
328         Rubber-stamped by Aakash Jain.
329
330         * resultsdbpy/resultsdbpy/example: Added.
331         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
332         * resultsdbpy/resultsdbpy/example/environment.py: Added.
333         (Environment): Organize environment variables used by results database.
334         (ModelFromEnvironment): Construct the database model from the environment.
335         (main): Create and drop tables, if required.
336         * resultsdbpy/resultsdbpy/example/main.py: Added.
337         (health): Web-server health check.
338         (handle_errors):
339         (main): Run results database web-server.
340         * resultsdbpy/resultsdbpy/example/worker.py: Added.
341         (main): Asynchronously process uploaded results.
342         * resultsdbpy/resultsdbpy/run: Added.
343
344 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
345
346         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
347         https://bugs.webkit.org/show_bug.cgi?id=209004
348
349         Reviewed by Tim Horton.
350
351         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
352         `use_gpu_process` is specified.
353
354         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
355         (parse_args):
356
357 2020-03-12  Matt Lewis  <jlewis3@apple.com>
358
359         Make flatpack import for run-webkit-tests only happen on linux systems
360         https://bugs.webkit.org/show_bug.cgi?id=208954
361
362         Reviewed by Philippe Normand.
363
364         * Scripts/run-webkit-tests: Added an if statement to find the system platform
365         to determine if we need the flatpackutils import. 
366
367 2020-03-12  Alex Christensen  <achristensen@webkit.org>
368
369         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
370         https://bugs.webkit.org/show_bug.cgi?id=207609
371
372         Reviewed by Ryosuke Niwa.
373
374         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
375         (TestWebKitAPI::TEST):
376
377 2020-03-12  Daniel Bates  <dabates@apple.com>
378
379         FocusController::setFocusedElement() should tell client of refocused element
380         https://bugs.webkit.org/show_bug.cgi?id=208880
381
382         Reviewed by Wenson Hsieh.
383
384         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
385         to start an input session. Currently, it does not even try.
386
387         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
388         (TEST):
389
390 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
391
392         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
393         https://bugs.webkit.org/show_bug.cgi?id=208970
394
395         Reviewed by Daniel Bates.
396
397         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
398         #!/usr/bin/env python.
399
400         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
401         probably has similar rules.
402
403         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
404         Everything else that does so is probably only used by webkit-build.
405
406         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
407
408         * gtkdoc/generate-gtkdoc:
409
410 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
411
412         [WebAuthn] Formalize the Keychain schema
413         https://bugs.webkit.org/show_bug.cgi?id=183533
414         <rdar://problem/43347926>
415
416         Reviewed by Brent Fulgham.
417
418         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
419         the original combination of RP ID and user handle.
420
421         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
422         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
423         (WTR::TestRunner::cleanUpKeychain):
424         (WTR::TestRunner::keyExistsInKeychain):
425         * WebKitTestRunner/InjectedBundle/TestRunner.h:
426         * WebKitTestRunner/TestController.h:
427         * WebKitTestRunner/TestInvocation.cpp:
428         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
429         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
430         (WTR::TestController::cleanUpKeychain):
431         (WTR::TestController::keyExistsInKeychain):
432
433 2020-03-11  Keith Miller  <keith_miller@apple.com>
434
435         Test262-runner should always consider crashes as new failures
436         https://bugs.webkit.org/show_bug.cgi?id=208943
437
438         Reviewed by Yusuke Suzuki.
439
440         Right now the runner will consider crashes with no output as passes, which is obviously bad.
441         Since we should never crash on a conformance test we should consider a crash as a new failure
442         100% of the time.
443
444         * Scripts/test262/Runner.pm:
445         (processFile):
446         (runTest):
447         (processResult):
448
449 2020-03-11  Chris Dumez  <cdumez@apple.com>
450
451         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
452         https://bugs.webkit.org/show_bug.cgi?id=208927
453         <rdar://problem/55448331>
454
455         Reviewed by Alex Christensen.
456
457         Add API test coverage.
458
459         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
460
461 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
462
463         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
464         https://bugs.webkit.org/show_bug.cgi?id=208860
465
466         Reviewed by Carlos Alberto Lopez Perez.
467
468         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
469         (StatusBubble): Added 'api-gtk'.
470         * BuildSlaveSupport/ews-build/config.json:
471         * BuildSlaveSupport/ews-build/factories.py:
472         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
473         GTK.
474         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
475         GTK.
476         (GTKBuildFactory):
477         (GTKBuildFactory.__init__): Deleted.
478         (GTKBuildAndTestFactory): Deleted.
479         (GTKBuildAndTestFactory.__init__): Deleted.
480         (GTKAPIBuildAndTestFactory): Deleted.
481         * BuildSlaveSupport/ews-build/loadConfig.py:
482
483 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
484
485         [ews] Add unit test to prevent multiple schedulers for a builder.
486         https://bugs.webkit.org/show_bug.cgi?id=208917
487
488         Reviewed by Carlos Alberto Lopez Perez.
489
490         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
491         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
492         (TagsForBuilderTest): Fixed a typo.
493
494 2020-03-11 Philippe Normand  <pnormand@igalia.com>
495
496         [GTK] Failing API tests under the Flatpak SDK environment
497         https://bugs.webkit.org/show_bug.cgi?id=208871
498
499         Reviewed by Michael Catanzaro.
500
501         The load-failed signal callback should return a boolean result,
502         otherwise we enter in unknown territory depending on how the
503         toolchain compiles this, possibly triggering bad behavior (with
504         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
505         GCC toolchain on buildbots).
506
507         Patch suggested by Michael Catanzaro.
508
509         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
510         (loadFailedCallback):
511
512 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
513
514         Sync FeatureList.pm with CMake definitions
515         https://bugs.webkit.org/show_bug.cgi?id=208866
516
517         Reviewed by Michael Catanzaro.
518
519         * Scripts/webkitperl/FeatureList.pm:
520
521 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
522
523         [ews] Add unit tests for commit queue factory
524         https://bugs.webkit.org/show_bug.cgi?id=208862
525
526         Reviewed by Jonathan Bedard.
527
528         * BuildSlaveSupport/ews-build/factories_unittest.py:
529         (TestCommitQueueFactory):
530         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
531
532 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
533
534         [ews-app] Status bubble should only display important messages in pop-over - part 3
535         https://bugs.webkit.org/show_bug.cgi?id=208865
536
537         Reviewed by Jonathan Bedard.
538
539         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
540         (StatusBubble): Added more strings to STEPS_TO_HIDE.
541
542 2020-03-10  Lauro Moura  <lmoura@igalia.com>
543
544         [WPE] MiniBrowser: Close child WebViews when exiting
545         https://bugs.webkit.org/show_bug.cgi?id=208689
546
547         Reviewed by Carlos Garcia Campos.
548
549         Store created views so we can release them before exiting.
550
551         * MiniBrowser/wpe/main.cpp:
552         (webViewClose):
553         (createWebView):
554         (main):
555
556 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
557
558         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
559         https://bugs.webkit.org/show_bug.cgi?id=208861
560
561         Reviewed by Jonathan Bedard.
562
563         * BuildSlaveSupport/ews-build/factories.py:
564         (Factory.__init__): Remove verifycqplus parameter.
565         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
566         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
567         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
568
569 2020-03-10  Philippe Normand  <pnormand@igalia.com>
570
571         [GTK] API favicon test flaky timeouts
572         https://bugs.webkit.org/show_bug.cgi?id=208189
573
574         Reviewed by Carlos Garcia Campos.
575
576         Sometimes the favicon changes already during the load. Keeping
577         track of it in the WebView favicon property notification handler
578         gets us rid of the race.
579
580         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
581         (testFaviconDatabaseGetFavicon):
582
583 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
584
585         Generate commit-queue status bubble from new EWS
586         https://bugs.webkit.org/show_bug.cgi?id=208811
587
588         Reviewed by Jonathan Bedard.
589
590         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
591         (StatusBubble._build_bubbles_for_patch):
592
593 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
594
595         Remove obsolete feature flags
596         https://bugs.webkit.org/show_bug.cgi?id=208830
597
598         Reviewed by Alex Christensen.
599
600         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
601         are no longer used.
602
603         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
604         when the compilation flag was removed in r258148.
605
606         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
607         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
608
609         * Scripts/webkitperl/FeatureList.pm:
610         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
611
612 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
613
614         WebKitTestRunner bundleID should not be cleared before every test
615         https://bugs.webkit.org/show_bug.cgi?id=208823
616         <rdar://problem/60204539>
617
618         Reviewed by Per Arne Vollan.
619
620         This is causing test failures for layout tests which rely on the Info.plist 
621         bundle identifier (not the one set via the override method).
622
623         * WebKitTestRunner/TestController.cpp:
624         (WTR::TestController::createWebViewWithOptions):
625         (WTR::TestController::ensureViewSupportsOptionsForTest):
626         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
627
628 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
629
630         [macOS] Notification observer is not removed
631         https://bugs.webkit.org/show_bug.cgi?id=208834
632
633         Reviewed by Tim Horton.
634
635         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
636         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
637         (TEST):
638
639 2020-03-06  Brian Burg  <bburg@apple.com>
640
641         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
642         https://bugs.webkit.org/show_bug.cgi?id=208729
643         <rdar://problem/60105447>
644
645         Reviewed by Jonathan Bedard.
646
647         Improve upload.py to look for the svn branch and revision for the 'webkit'
648         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
649
650         * Scripts/webkitpy/common/checkout/scm/git.py:
651         (Git):
652         (Git.git_svn_id_regexp):
653         (Git._field_from_git_svn_id):
654         (Git.svn_revision):
655         (Git.svn_branch):
656         (Git.svn_url):
657         (Git.native_branch):
658         Refactor svn revision, branch, url to use the same regexp and helper code.
659
660         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
661         (StubRepository.svn_branch):
662         Expose a stub since this is used unconditionally by Port.commits_for_upload.
663
664         * Scripts/webkitpy/common/checkout/scm/svn.py:
665         (SVN.svn_branch):
666         (SVN.native_revision):
667         (SVN):
668         (SVN.native_branch):
669         Refactor so the actual implementation is contained in svn_revision / svn_branch.
670         The native_* methods call out to the SVN equivalents since this is an SVN repository.
671
672         * Scripts/webkitpy/port/base.py:
673         (Port.commits_for_upload):
674         Add special git-svn handling for the WebKit repository so that SVN branch and revision
675         is preferred over the git equivalents.
676
677 2020-03-09  Antoine Quint  <graouts@apple.com>
678
679         TestWebKitAPI fails to build on watchOS
680         https://bugs.webkit.org/show_bug.cgi?id=208820
681
682         Reviewed by Tim Horton.
683
684         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
685
686 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
687
688         resultsdbpy: Add tool to manage resultsdbpy container
689         https://bugs.webkit.org/show_bug.cgi?id=208743
690
691         Rubber-stamped by Aakash Jain.
692
693         Add tool to start, stop and restart the resultsdbpy Docker container.
694
695         * resultsdbpy/resultsdbpy/container: Added.
696
697 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
698
699         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
700         https://bugs.webkit.org/show_bug.cgi?id=208706
701
702         Reviewed by Žan Doberšek.
703
704         Add test case to check surrounding text in multiline context.
705
706         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
707         (testWebKitInputMethodContextSurrounding):
708
709 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
710
711         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
712         https://bugs.webkit.org/show_bug.cgi?id=208783
713
714         Reviewed by Brent Fulgham.
715
716         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
717
718 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
719
720         Replace the use of term "rollout" to "revert" in various tools
721         https://bugs.webkit.org/show_bug.cgi?id=208775
722
723         Reviewed by Ryosuke Niwa.
724
725         See this webkit-dev thread for the originating discussion:
726         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
727
728         'rollout' is a confusing term to anyone unacquainted with WebKit;
729         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
730
731         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
732         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
733
734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
735         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
736         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
737         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
738         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
739         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
740         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
741         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
742         * BuildSlaveSupport/ews-build/steps.py:
743         * BuildSlaveSupport/ews-build/steps_unittest.py:
744         * Scripts/webkit-tools-completion.sh:
745         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
746         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
747         * Scripts/webkitpy/common/checkout/scm/svn.py:
748         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
749         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
750         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
751         * Scripts/webkitpy/tool/bot/feeders.py:
752         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
753         * Scripts/webkitpy/tool/bot/irc_command.py:
754         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
755         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
756         * Scripts/webkitpy/tool/bot/sheriff.py:
757         * Scripts/webkitpy/tool/commands/download.py:
758         * Scripts/webkitpy/tool/commands/download_unittest.py:
759         * Scripts/webkitpy/tool/commands/newcommitbot.py:
760         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
761         * Scripts/webkitpy/tool/commands/queues_unittest.py:
762         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
763         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
764         * Scripts/webkitpy/tool/steps/__init__.py:
765         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
766         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
767         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
768         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
769
770 2020-03-07  David Quesada  <david_quesada@apple.com>
771
772         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
773         https://bugs.webkit.org/show_bug.cgi?id=208781
774         rdar://problem/60061016
775
776         Reviewed by Alex Christensen.
777
778         Add a test that recreates the conditions of this crash:
779         - Send a message from the injected bundle to the UI process that contains a reply block.
780         - Hold a reference to the reply block.
781         - Let the web view deallocate.
782         - Call the block, and expect not to crash.
783
784         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
785         (localObjectInterface):
786         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
787         (-[LocalObject doSomethingWithCompletionHandler:]):
788         (TEST):
789         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
790         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
791
792 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
793
794         TextManipulationController should work with ARIA labels
795         https://bugs.webkit.org/show_bug.cgi?id=208759
796
797         Reviewed by Wenson Hsieh.
798
799         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
800         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
801         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
802         the expected number of tokens for the first item as the very first image is correctly
803         detected per the code change. 
804         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
805
806 2020-03-07  Alex Christensen  <achristensen@webkit.org>
807
808         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
809         https://bugs.webkit.org/show_bug.cgi?id=208767
810
811         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
812         The frameID of the main frame before loading is only 0 on Mac right now.
813         The test is still good because it validates that execution works in the main frame before loading.
814
815 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
816
817         [ews] commit queue is not skipping layout tests for rollout patches
818         https://bugs.webkit.org/show_bug.cgi?id=208716
819
820         Unreviewed minor fix.
821
822         * BuildSlaveSupport/ews-build/steps.py:
823         (RunWebKitTests.doStepIf):
824         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
825         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
826
827 2020-03-05  Sam Weinig  <weinig@apple.com>
828
829         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
830         https://bugs.webkit.org/show_bug.cgi?id=207436
831         <rdar://problem/59296762>
832
833         Reviewed by Darin Adler.
834
835         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
836         Remove JSC related defines.
837
838 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
839
840         AX: Provide a way to run tests in isolated tree mode
841         https://bugs.webkit.org/show_bug.cgi?id=208629
842         <rdar://problem/60075583>
843
844         Reviewed by Ryosuke Niwa.
845
846         Provide the ability to run tests for accessibility in the isolated tree mode.
847         This sends a flag over to the injected bundle which calls the right HIServices override so that
848         the system thinks it is in isolated mode.
849
850         * Scripts/compare-webkit-configurations:
851         (flag_for_comparison):
852         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
853         (parse_args):
854         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
855         (parse_args):
856         * Scripts/webkitpy/port/driver.py:
857         (Driver.cmd_line):
858         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
859         (WTR::AccessibilityController::AccessibilityController):
860         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
861         (WTR::AccessibilityController::updateIsolatedTreeMode):
862         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
863         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
864         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
865         (WTR::InjectedBundle::didReceiveMessageToPage):
866         (WTR::InjectedBundle::beginTesting):
867         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
868         * WebKitTestRunner/Options.cpp:
869         (WTR::handleOptionAccessibilityIsolatedTreeMode):
870         (WTR::OptionsHandler::OptionsHandler):
871         * WebKitTestRunner/Options.h:
872         * WebKitTestRunner/TestController.cpp:
873         (WTR::TestController::initialize):
874         (WTR::TestController::resetPreferencesToConsistentValues):
875         (WTR::TestController::resetStateToConsistentValues):
876         * WebKitTestRunner/TestController.h:
877         (WTR::TestController::accessibilityIsolatedTreeMode const):
878
879 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
880
881         [Cocoa] Re-enable CFPrefs direct mode
882         https://bugs.webkit.org/show_bug.cgi?id=208690
883
884         Reviewed by Brent Fulgham.
885
886         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
887         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
888         (TEST):
889         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
890         (TestWebKitAPI::TEST):
891
892 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
893
894         UIProcess needs mechanism to specify AppBound domains
895         https://bugs.webkit.org/show_bug.cgi?id=208528
896         <rdar://problem/59980340>
897
898         Reviewed by Brent Fulgham.
899
900         Added test app-bound domains to the plist and tested that the domains
901         are properly stored in the website data store after a navigation.
902
903         * TestWebKitAPI/Info.plist:
904         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
905         (TEST):
906
907 2020-03-06  Alex Christensen  <achristensen@webkit.org>
908
909         Add SPI to disable cross origin access control checks
910         https://bugs.webkit.org/show_bug.cgi?id=208748
911
912         Reviewed by Tim Hatcher.
913
914         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
915         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
916
917 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
918
919         [webkitpy] Fix executive on Windows to run wpt server correctly
920         https://bugs.webkit.org/show_bug.cgi?id=208693
921
922         Reviewed by Jonathan Bedard.
923
924         Bug fix for Windows environment a) fixing a typo. b) fixing path
925         c) fix how to kill subprocesses.
926
927         * Scripts/webkitpy/common/system/executive.py:
928         (Executive._windows_kill_command):
929         (Executive.interrupt):
930         (Executive.kill_all):
931         * Scripts/webkitpy/port/base.py:
932         (Port.web_platform_test_server_doc_root):
933
934 2020-03-06  Alex Christensen  <achristensen@webkit.org>
935
936         Evaluating JavaScript in main frame before loading should succeed
937         https://bugs.webkit.org/show_bug.cgi?id=208733
938
939         Reviewed by Tim Horton.
940
941         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
942
943 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
944
945         TextManipulationController should preserve images
946         https://bugs.webkit.org/show_bug.cgi?id=208692
947
948         Reviewed by Wenson Hsieh.
949
950         Added tests for preserving images and their ordering.
951
952         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
953         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
954         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
955         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
956
957 2020-03-06  David Quesada  <david_quesada@apple.com>
958
959         Add _WKResourceLoadInfo.resourceType SPI
960         https://bugs.webkit.org/show_bug.cgi?id=208723
961
962         Reviewed by Alex Christensen.
963
964         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
965         (TEST):
966
967 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
968
969         Stop reporting to webkit-test-results.webkit.org
970         https://bugs.webkit.org/show_bug.cgi?id=207218
971
972         Reviewed by Alexey Proskuryakov.
973
974         * BuildSlaveSupport/build.webkit.org-config/steps.py:
975         (RunWebKitTests):
976
977 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
978
979         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
980         https://bugs.webkit.org/show_bug.cgi?id=208365
981         <rdar://problem/59877296>
982
983         Reviewed by Geoffrey Garen.
984
985         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
986         (TEST):
987
988 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
989
990         EWS should be able to fetch patch status for security bugs while processing them
991         https://bugs.webkit.org/show_bug.cgi?id=206511
992
993         Reviewed by Alexey Proskuryakov.
994
995         * BuildSlaveSupport/ews-build/steps.py:
996         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
997         (BugzillaMixin.get_patch_json): 
998         (BugzillaMixin.get_bug_json):
999         (BugzillaMixin._is_bug_closed):
1000         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
1001         (TransferToS3.hideStepIf): Ditto.
1002
1003 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1004
1005         [ews] commit-queue should show the trac url for the commit on the build page
1006         https://bugs.webkit.org/show_bug.cgi?id=208715
1007
1008         Reviewed by Jonathan Bedard.
1009
1010         * BuildSlaveSupport/ews-build/steps.py:
1011         (PushCommitToWebKitRepo.evaluateCommand):
1012
1013 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1014
1015         Fix ResourceLoadDelegate.LoadInfo API test after r257816
1016         https://bugs.webkit.org/show_bug.cgi?id=208550
1017
1018         * TestWebKitAPI/cocoa/HTTPServer.mm:
1019         (TestWebKitAPI::HTTPServer::respondToRequests):
1020         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
1021         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
1022
1023 2020-03-06  Lauro Moura <lmoura@igalia.com>
1024
1025         [WPE][WebDriver] MiniBrowser should react to close session commands
1026         https://bugs.webkit.org/show_bug.cgi?id=207529
1027
1028         Reviewed by Carlos Garcia Campos.
1029
1030         Do not call g_object_unref on the first created view if it has already
1031         been disposed in the "close" signal handler.
1032
1033         Based on original patch by Yury Semikhatsky.
1034
1035         * MiniBrowser/wpe/main.cpp:
1036         (main):
1037
1038 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1039
1040         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
1041         https://bugs.webkit.org/show_bug.cgi?id=208647
1042
1043         Reviewed by Carlos Garcia Campos.
1044
1045         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1046         (TestWebKitAPI::TEST):
1047
1048 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1049
1050         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
1051         https://bugs.webkit.org/show_bug.cgi?id=208670
1052
1053         Reviewed by Brady Eidson.
1054
1055         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1056         (-[FrameNavigationDelegate waitForNavigations:]):
1057         (-[FrameNavigationDelegate requests]):
1058         (-[FrameNavigationDelegate frames]):
1059         (-[FrameNavigationDelegate callbacks]):
1060         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
1061         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
1062         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
1063         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
1064         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
1065         (TEST):
1066
1067 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1068
1069         Add WKFrameInfo._parentFrameHandle SPI
1070         https://bugs.webkit.org/show_bug.cgi?id=208674
1071
1072         Reviewed by Brady Eidson.
1073
1074         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1075
1076 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
1077
1078         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
1079         https://bugs.webkit.org/show_bug.cgi?id=208626
1080         <rdar://problem/60074148>
1081
1082         Reviewed by Brent Fulgham.
1083
1084         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1085         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1086         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
1087         (TestWebKitAPI::TEST):
1088         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
1089         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
1090         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
1091
1092 2020-03-05  Antoine Quint  <graouts@apple.com>
1093
1094         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
1095         https://bugs.webkit.org/show_bug.cgi?id=208644
1096         <rdar://problem/60042429>
1097
1098         Reviewed by Brady Eidson.
1099
1100         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
1101         
1102         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
1103            empty document has been removed in favor of the document for the requested URL,
1104         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
1105            correctly does not injected the style sheet.
1106
1107         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1108
1109 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1110
1111         [ews] Add build step to push commit to WebKit repository
1112         https://bugs.webkit.org/show_bug.cgi?id=208589
1113
1114         Reviewed by Jonathan Bedard.
1115
1116         * BuildSlaveSupport/ews-build/steps.py:
1117         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
1118         (PushCommitToWebKitRepo.start): Initialize log observer.
1119         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
1120         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
1121         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
1122         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
1123         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1124         * BuildSlaveSupport/ews-build/factories.py:
1125
1126 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1127
1128         [ews] Add unit tests for ValidateCommiterAndReviewer build step
1129         https://bugs.webkit.org/show_bug.cgi?id=208262
1130
1131         Reviewed by Jonathan Bedard.
1132
1133         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
1134
1135 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1136
1137         commit-queue should run WK2 tests instead of WK1 tests
1138         https://bugs.webkit.org/show_bug.cgi?id=208544
1139
1140         Reviewed by Jonathan Bedard.
1141
1142         * BuildSlaveSupport/ews-build/factories.py:
1143
1144 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1145
1146         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
1147         https://bugs.webkit.org/show_bug.cgi?id=208645
1148
1149         Reviewed by Alexey Proskuryakov.
1150
1151         * BuildSlaveSupport/ews-build/steps.py:
1152         (ValidateCommiterAndReviewer.load_contributors):
1153         (ValidateCommiterAndReviewer.start):
1154
1155 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1156
1157         style-checker: Add UAF to the list of security words to warn about.
1158         https://bugs.webkit.org/show_bug.cgi?id=208643
1159
1160         Reviewed by Jonathan Bedard.
1161
1162         UAF is a common acronym used for use after free.
1163
1164         * Scripts/webkitpy/style/checkers/changelog.py:
1165         (ChangeLogChecker.check_for_unwanted_security_phrases):
1166
1167 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
1168
1169         [MSVC] Add .natvis support of WebKit types
1170         https://bugs.webkit.org/show_bug.cgi?id=193119
1171
1172         Reviewed by Don Olmstead.
1173
1174         To help the WebKit developer while debugging, this file defines how
1175         WebKit types are displayed in debugger of Visual Studio.
1176         Very limited set of WebKit types, but it changes the world.
1177
1178         * VisualStudio/WebKit.natvis: Added.
1179
1180 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1181
1182         Add system trace points around display list replay
1183         https://bugs.webkit.org/show_bug.cgi?id=208616
1184
1185         Reviewed by Simon Fraser.
1186
1187         Add a new "Display list replay" trace point.
1188
1189         * Tracing/SystemTracePoints.plist:
1190
1191 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1192
1193         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
1194         https://bugs.webkit.org/show_bug.cgi?id=208615
1195         <rdar://problem/59406743>
1196
1197         Reviewed by Alex Christensen.
1198
1199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1200         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
1201         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1202         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
1203         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1204         (TEST):
1205         Also make a test written in bug 206310 actually run code.
1206
1207 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1208
1209         [build.webkit.org] Remove leaks queue
1210         https://bugs.webkit.org/show_bug.cgi?id=208580
1211
1212         Reviewed by Jonathan Bedard.
1213
1214         * BuildSlaveSupport/build.webkit.org-config/config.json:
1215         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1217
1218 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1219
1220         Add SPI to evaluate JavaScript in an iframe
1221         https://bugs.webkit.org/show_bug.cgi?id=208605
1222
1223         Reviewed by Brady Eidson.
1224
1225         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1226
1227 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
1228
1229         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
1230         https://bugs.webkit.org/show_bug.cgi?id=208533
1231         <rdar://problem/60010184>
1232
1233         Reviewed by Alex Christensen.
1234
1235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1236         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1237         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
1238         (TestWebKitAPI::TEST):
1239         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
1240         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
1241
1242 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1243
1244         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
1245         https://bugs.webkit.org/show_bug.cgi?id=208593
1246
1247         Reviewed by Brady Eidson.
1248
1249         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
1250         (TestWebKitAPI::TEST):
1251
1252 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1253
1254         WKWebView's frames accessor should return a traversable type
1255         https://bugs.webkit.org/show_bug.cgi?id=208591
1256
1257         Reviewed by Brady Eidson.
1258
1259         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1260
1261 2020-03-04  Antoine Quint  <graouts@apple.com>
1262
1263         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
1264         https://bugs.webkit.org/show_bug.cgi?id=208575
1265         <rdar://problem/59773690>
1266
1267         Reviewed by Brady Eidson.
1268
1269         Add new tests for the new SPI which check:
1270         
1271         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
1272            specified WKWebView alone,
1273         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
1274         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
1275         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
1276         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
1277         6. and that the same test also works with PSON enabled.
1278
1279         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1280
1281 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
1282
1283         [macOS] test-lldb-webkit failing on debug bots
1284         https://bugs.webkit.org/show_bug.cgi?id=208545
1285
1286         Reviewed by Jonathan Bedard.
1287
1288         The lldb-webkit-test step must pass in the build configuration as an
1289         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
1290         binary that is downloaded with the rest of the build products. Without this
1291         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
1292         regardless of their actual build configuration.
1293
1294         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1295         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
1296         * Scripts/test-lldb-webkit:
1297         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
1298
1299 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1300
1301         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
1302         https://bugs.webkit.org/show_bug.cgi?id=208539
1303
1304         Unreviewed follow-up fix.
1305
1306         * BuildSlaveSupport/ews-build/steps.py:
1307
1308 2020-03-04  Daniel Bates  <dabates@apple.com>
1309
1310         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
1311         https://bugs.webkit.org/show_bug.cgi?id=208565
1312
1313         Reviewed by Wenson Hsieh.
1314
1315         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
1316         of its frame as a means to find all the editable elements in the visible content area
1317         of the web view.
1318
1319         Coincidentally this makes no difference to the test results right now because the web view
1320         happens to be located at the origin (0, 0) in the window. However if in the future the
1321         web view would be located at some other point then the tests may fail because the rectangle
1322         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
1323         rectangle for the visible content area.
1324
1325         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1326         (TEST):
1327
1328 2020-03-04  Daniel Bates  <dabates@apple.com>
1329
1330         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
1331         https://bugs.webkit.org/show_bug.cgi?id=208564
1332
1333         Reviewed by Alex Christensen.
1334
1335         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
1336         to make it easy to run just these tests.
1337
1338         Currently, the tests are organized under the test case name WebKit. This means you need to
1339         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
1340         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
1341         so that a person can run just these test using:
1342         
1343                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
1344
1345         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1346         (TEST):
1347
1348 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1349
1350         [ews] Add build step to create local git commit for commit-queue
1351         https://bugs.webkit.org/show_bug.cgi?id=208539
1352
1353         Reviewed by Jonathan Bedard.
1354
1355         * BuildSlaveSupport/ews-build/steps.py:
1356         (CreateLocalGITCommit): Build step to create local git commit.
1357         (CreateLocalGITCommit.start):
1358         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
1359         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
1360         * BuildSlaveSupport/ews-build/factories.py:
1361
1362 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
1363
1364         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
1365         https://bugs.webkit.org/show_bug.cgi?id=207948
1366
1367         Reviewed by Zalan Bujtas.
1368
1369         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
1370         so that it receives the wheel events.
1371
1372         * DumpRenderTree/mac/EventSendingController.mm:
1373         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1374         * DumpRenderTree/win/EventSender.cpp:
1375         (mouseScrollBy):
1376
1377 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
1378
1379         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
1380         https://bugs.webkit.org/show_bug.cgi?id=208520
1381         <rdar://problem/60000214>
1382
1383         Reviewed by Chris Fleizach.
1384
1385         Calling InjectedBundle::singleton().page()->page() in the constructor
1386         of the AccessibilityController is having this side effect on iOS.
1387         So #if to MAC where it's actually being used.
1388
1389         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1390         (WTR::AccessibilityController::AccessibilityController):
1391
1392 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1393
1394         Add SPI _WKResourceLoadInfo.loadedFromCache
1395         https://bugs.webkit.org/show_bug.cgi?id=208554
1396
1397         Reviewed by Wenson Hsieh.
1398
1399         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1400         (TEST):
1401
1402 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1403
1404         Batch observations and completions of text manipulations
1405         https://bugs.webkit.org/show_bug.cgi?id=208406
1406
1407         Reviewed by Wenson Hsieh.
1408
1409         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
1410         multiple paragraphs at once.
1411
1412         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1413         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
1414         (-[TextManipulationDelegate items]):
1415         (-[LegacyTextManipulationDelegate init]):
1416         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
1417         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
1418         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
1419         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
1420         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
1421         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
1422         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
1423
1424 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
1425
1426         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1427         https://bugs.webkit.org/show_bug.cgi?id=208415
1428
1429         Reviewed by Brent Fulgham.
1430
1431         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1432         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1433         (TEST):
1434
1435 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1436
1437         Add response to _WKResourceLoadDelegate didCompleteWithError callback
1438         https://bugs.webkit.org/show_bug.cgi?id=208553
1439
1440         Reviewed by Simon Fraser.
1441
1442         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1443         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
1444         (TEST):
1445         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
1446
1447 2020-03-03  Brady Eidson  <beidson@apple.com>
1448
1449         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
1450         https://bugs.webkit.org/show_bug.cgi?id=198795
1451
1452         Reviewed by Chris Dumez.
1453
1454         This test appears to no longer be flaky.
1455         
1456         Let's re-enable it.
1457         
1458         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1459         (TestWebKitAPI::TEST):
1460
1461 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1462
1463         Requests sent to _WKResourceLoadDelegate should include HTTPBody
1464         https://bugs.webkit.org/show_bug.cgi?id=208550
1465
1466         Reviewed by Tim Hatcher.
1467
1468         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1469         (TEST):
1470         * TestWebKitAPI/cocoa/HTTPServer.mm:
1471         (TestWebKitAPI::HTTPServer::respondToRequests):
1472         HTTPServer now looks for Content-Length in its request.
1473         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
1474
1475 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1476
1477         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
1478         https://bugs.webkit.org/show_bug.cgi?id=208522
1479
1480         Reviewed by Brian Weinstein.
1481
1482         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1483         (TEST):
1484
1485 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
1486
1487         commit-queue should update working directory and reapply patch just before commiting
1488         https://bugs.webkit.org/show_bug.cgi?id=208521
1489
1490         Reviewed by Jonathan Bedard.
1491
1492         * BuildSlaveSupport/ews-build/factories.py:
1493
1494 2020-03-03  Matt Lewis  <jlewis3@apple.com>
1495
1496         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
1497         https://bugs.webkit.org/show_bug.cgi?id=208485
1498
1499         Reviewed by Jonathan Bedard.
1500
1501         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1502         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
1503         that we don't have to recreate the variables that are already created.
1504         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
1505         from each module, rather than making extra imports that we don't need.
1506         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
1507         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
1508         and not part of the host.
1509         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
1510         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
1511         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
1512         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
1513         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
1514         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
1515         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
1516         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
1517         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
1518         if we were geting any value at all
1519         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
1520         sure we aren't gabking the wrong key:value pair
1521         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
1522         come with the MockHosts and MockHost inherits from MockSystemHost.
1523         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
1524         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
1525         to the various upload steps.
1526
1527 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
1528
1529         [ews] Add build step to find list of modified changelogs
1530         https://bugs.webkit.org/show_bug.cgi?id=208514
1531
1532         Reviewed by Jonathan Bedard.
1533
1534         * BuildSlaveSupport/ews-build/factories.py:
1535         * BuildSlaveSupport/ews-build/steps.py:
1536         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
1537         (FindModifiedChangeLogs.start): Initialize log observer.
1538         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
1539         (FindModifiedChangeLogs.evaluateCommand):
1540         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
1541         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
1542         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
1543         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1544
1545 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
1546
1547         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
1548         https://bugs.webkit.org/show_bug.cgi?id=208451
1549
1550         Unreviewed test gardening.
1551
1552         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
1553
1554 2020-03-03  Jiten Mehta  <jmehta@apple.com>
1555
1556         Adopt HTTP Alternative Services Storage
1557         https://bugs.webkit.org/show_bug.cgi?id=208387
1558
1559         Reviewed by Alex Christensen.
1560
1561         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1562         (checkUntilEntryFound):
1563         (TEST):
1564
1565 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
1566
1567         Check for navigation to app-bound domain during script evaluation
1568         https://bugs.webkit.org/show_bug.cgi?id=208319
1569         <rdar://problem/57569321>
1570
1571         Reviewed by Brent Fulgham.
1572
1573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1574         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
1575         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1576         (TEST):
1577         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
1578         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
1579
1580 2020-03-03  Commit Queue  <commit-queue@webkit.org>
1581
1582         Unreviewed, rolling out r257754.
1583         https://bugs.webkit.org/show_bug.cgi?id=208513
1584
1585         Introduced API test failure (Requested by perarne on #webkit).
1586
1587         Reverted changeset:
1588
1589         "[Cocoa] Mapping from MIME type to UTI type should be done in
1590         the UI process"
1591         https://bugs.webkit.org/show_bug.cgi?id=208415
1592         https://trac.webkit.org/changeset/257754
1593
1594 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
1595
1596         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
1597         https://bugs.webkit.org/show_bug.cgi?id=208506
1598
1599         Reviewed by Carlos Garcia Campos.
1600
1601         * WebKitTestRunner/TestController.cpp:
1602         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
1603
1604 2020-03-02  Ben Nham  <nham@apple.com>
1605
1606         Add performance probes for HTML parsing
1607         https://bugs.webkit.org/show_bug.cgi?id=208271
1608
1609         Reviewed by Daniel Bates.
1610
1611         This adds probes that show which lines of HTML are have been parsed.
1612
1613         * Tracing/SystemTracePoints.plist:
1614
1615 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
1616
1617         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1618         https://bugs.webkit.org/show_bug.cgi?id=208415
1619
1620         Reviewed by Brent Fulgham.
1621
1622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1623         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1624         (TEST):
1625
1626 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
1627
1628         Unreviewed, rolling out r257725.
1629
1630         This commit caused 10 API tests to fail
1631
1632         Reverted changeset:
1633
1634         "[Cocoa] Mapping from MIME type to UTI type should be done in
1635         the UI process"
1636         https://bugs.webkit.org/show_bug.cgi?id=208415
1637         https://trac.webkit.org/changeset/257725
1638
1639 2020-03-02  Saam Barati  <sbarati@apple.com>
1640
1641         Don't skip tests unnecessarily on arm64
1642         https://bugs.webkit.org/show_bug.cgi?id=208470
1643         <rdar://problem/59968869>
1644
1645         Reviewed by Tadeu Zagallo.
1646
1647         * Scripts/run-jsc-stress-tests:
1648
1649 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
1650
1651         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
1652         https://bugs.webkit.org/show_bug.cgi?id=208434
1653
1654         Reviewed by Chris Fleizach.
1655
1656         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1657         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
1658         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
1659         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1660         (WTR::AccessibilityController::accessibleElementById): Same as above.
1661
1662 2020-03-02  John Wilander  <wilander@apple.com>
1663
1664         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
1665         https://bugs.webkit.org/show_bug.cgi?id=208399
1666         <rdar://problem/24731650>
1667
1668         Reviewed by Brent Fulgham.
1669
1670         The majority of the changes in WTR::TestController is (partially) fixing a bug
1671         where the TestRunner would statically use the default website datastore instead
1672         of the website data store configure for the page. This worked for persistent
1673         storage testing but not for ephemeral sessions which is what this patch is all
1674         about. The previous TestController::websiteDataStore() is now called
1675         TestController::defaultWebsiteDataStore() and the new
1676         TestController::websiteDataStore() returns the configured website data store.
1677         Most of the use of the default website data store should probably change but
1678         that's not really for this patch to deal with. I did however move all of
1679         resource load statistics' use to the new TestController::websiteDataStore().
1680
1681         A new TestRunner function was added: isStatisticsEphemeral()
1682         It allows test cases to query the ephemeral status of resource load statistics.
1683
1684         One problem that is mitigated in this patch but not fully fixed is that for
1685         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
1686         TestController::generatePageConfiguration() via C API 
1687         WKPageConfigurationSetWebsiteDataStore(), and then again in 
1688         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
1689         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
1690         I tried removing the latter since one session for all platforms should be
1691         Enough but got broken behavior as a result. So now both are still there
1692         and both enable resource load statistics.
1693
1694         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1695         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1696         (WTR::TestRunner::isStatisticsEphemeral):
1697         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1698         * WebKitTestRunner/TestController.cpp:
1699         (WTR::TestController::defaultWebsiteDataStore):
1700         (WTR::TestController::websiteDataStore):
1701         (WTR::TestController::generatePageConfiguration):
1702         (WTR::TestController::resetPreferencesToConsistentValues):
1703         (WTR::TestController::resetStateToConsistentValues):
1704         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1705         (WTR::TestController::decidePolicyForNavigationAction):
1706         (WTR::TestController::platformAdjustContext):
1707         (WTR::TestController::clearServiceWorkerRegistrations):
1708         (WTR::TestController::clearDOMCache):
1709         (WTR::TestController::clearDOMCaches):
1710         (WTR::TestController::clearIndexedDatabases):
1711         (WTR::TestController::clearLocalStorage):
1712         (WTR::TestController::hasDOMCache):
1713         (WTR::TestController::domCacheSize):
1714         (WTR::TestController::setStatisticsEnabled):
1715         (WTR::TestController::isStatisticsEphemeral):
1716         (WTR::TestController::setStatisticsDebugMode):
1717         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
1718         (WTR::TestController::setStatisticsLastSeen):
1719         (WTR::TestController::setStatisticsMergeStatistic):
1720         (WTR::TestController::setStatisticsPrevalentResource):
1721         (WTR::TestController::setStatisticsVeryPrevalentResource):
1722         (WTR::TestController::dumpResourceLoadStatistics):
1723         (WTR::TestController::isStatisticsPrevalentResource):
1724         (WTR::TestController::isStatisticsVeryPrevalentResource):
1725         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
1726         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1727         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1728         (WTR::TestController::setStatisticsHasHadUserInteraction):
1729         (WTR::TestController::isStatisticsHasHadUserInteraction):
1730         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
1731         (WTR::TestController::setStatisticsGrandfathered):
1732         (WTR::TestController::isStatisticsGrandfathered):
1733         (WTR::TestController::setUseITPDatabase):
1734         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
1735         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
1736         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
1737         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
1738         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
1739         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
1740         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1741         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1742         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1743         (WTR::TestController::statisticsUpdateCookieBlocking):
1744         (WTR::TestController::statisticsSubmitTelemetry):
1745         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1746         (WTR::TestController::setStatisticsIsRunningTest):
1747         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1748         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1749         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1750         (WTR::TestController::setStatisticsGrandfatheringTime):
1751         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1752         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1753         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1754         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1755         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1756         (WTR::TestController::statisticsDeleteCookiesForHost):
1757         (WTR::TestController::isStatisticsHasLocalStorage):
1758         (WTR::TestController::setStatisticsCacheMaxAgeCap):
1759         (WTR::TestController::hasStatisticsIsolatedSession):
1760         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
1761         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
1762         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
1763         (WTR::TestController::statisticsResetToConsistentState):
1764         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1765         * WebKitTestRunner/TestController.h:
1766         * WebKitTestRunner/TestInvocation.cpp:
1767         (WTR::TestInvocation::invoke):
1768         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1769         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1770         (WTR::initializeWebViewConfiguration):
1771         (WTR::TestController::platformCreateWebView):
1772
1773 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
1774
1775         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1776         https://bugs.webkit.org/show_bug.cgi?id=208415
1777
1778         Reviewed by Brent Fulgham.
1779
1780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1781         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1782         (TEST):
1783
1784 2020-03-02  Daniel Bates  <dabates@apple.com>
1785
1786         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
1787         https://bugs.webkit.org/show_bug.cgi?id=208352
1788         <rdar://problem/59867815>
1789
1790         Reviewed by Wenson Hsieh.
1791
1792         Update test results to reflect the new behavior. To do this I also need to fix up the test code
1793         to actually scroll the web content. This also means we now execute the same code on both Mac and
1794         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
1795         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
1796         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
1797
1798         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1799         (TEST):
1800
1801 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
1802
1803         Unreviewed, rolling out r257687.
1804
1805         This commit caused debug tests to crash for macOS & iOS
1806
1807         Reverted changeset:
1808
1809         "[Cocoa] Mapping from MIME type to UTI type should be done in
1810         the UI process"
1811         https://bugs.webkit.org/show_bug.cgi?id=208415
1812         https://trac.webkit.org/changeset/257687
1813
1814 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1815
1816         Unreviewed, rolling out r257618.
1817
1818         This allegedly causes Safari to crash when closing a window
1819         (see rdar://problem/59922725).
1820
1821         Reverted changeset:
1822
1823         "UIProcess crash after using _prepareForMoveToWindow, then
1824         deallocating the WKWebView before moving to the window"
1825         https://bugs.webkit.org/show_bug.cgi?id=208365
1826         https://trac.webkit.org/changeset/257618
1827
1828 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
1829
1830         Remove std::lock_guard
1831         https://bugs.webkit.org/show_bug.cgi?id=206451
1832
1833         Reviewed by Anders Carlsson.
1834
1835         Add std::lock_guard lint rule to prevent from using it.
1836
1837         * Scripts/webkitpy/style/checkers/cpp.py:
1838         (check_lock_guard):
1839         (check_style):
1840         (CppChecker):
1841         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1842         (WebKitStyleTest.test_lock_guard):
1843         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1844         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1845         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1846         (assertHasObjects):
1847         (assertHasOnlyObjects):
1848         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1849         (WTR::AXThread::dispatch):
1850         (WTR::AXThread::dispatchFunctionsFromAXThread):
1851         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1852         (WTR::AXThread::initializeRunLoop):
1853
1854 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
1855
1856         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1857         https://bugs.webkit.org/show_bug.cgi?id=208415
1858
1859         Reviewed by Brent Fulgham.
1860
1861         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1862         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1863         (TEST):
1864
1865 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1866
1867         Unreviewed, rolling out r257565.
1868
1869         It broke WinCairo MiniBrowser
1870
1871         Reverted changeset:
1872
1873         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
1874         https://bugs.webkit.org/show_bug.cgi?id=206894
1875         https://trac.webkit.org/changeset/257565
1876
1877 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1878
1879         EWS fails to retry build in case of kill-old-processes exception
1880         https://bugs.webkit.org/show_bug.cgi?id=208003
1881
1882         Reviewed by Jonathan Bedard.
1883
1884         * BuildSlaveSupport/ews-build/steps.py:
1885         (KillOldProcesses.evaluateCommand):
1886         (KillOldProcesses.getResultSummary):
1887
1888 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1889
1890         [ews] commit-queue should update the ChangeLog with Reviewer name
1891         https://bugs.webkit.org/show_bug.cgi?id=206535
1892
1893         Reviewed by Jonathan Bedard.
1894
1895         * BuildSlaveSupport/ews-build/steps.py:
1896         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
1897
1898 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
1899
1900         run-javascriptcore-tests: Make upload format valid
1901         https://bugs.webkit.org/show_bug.cgi?id=208341
1902
1903         Rubber-stamped by Aakash Jain.
1904
1905         * Scripts/run-javascriptcore-tests:
1906         (uploadResults): Remove. FIXME.
1907         * Scripts/webkitdirs.pm:
1908         (splitVersionString): Handle case where the subminor version number has a - in it.
1909         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
1910
1911 2020-02-28  youenn fablet  <youenn@apple.com>
1912
1913         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
1914         https://bugs.webkit.org/show_bug.cgi?id=208130
1915
1916         Reviewed by Eric Carlson.
1917
1918         * WebKitTestRunner/TestOptions.h:
1919         Use GPU process to capture by default.
1920         We will remove this option once done verifying that every test works smoothly.
1921
1922 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1923
1924         [ews] commit queue should skip building and testing for rollout patches
1925         https://bugs.webkit.org/show_bug.cgi?id=208329
1926
1927         Reviewed by Jonathan Bedard.
1928
1929         * BuildSlaveSupport/ews-build/steps.py:
1930         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
1931         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
1932         (RunWebKit1Tests.doStepIf): Ditto.
1933         * BuildSlaveSupport/ews-build/steps_unittest.py:
1934         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
1935         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
1936
1937 2020-02-28  Daniel Bates  <dabates@apple.com>
1938
1939         Update my watch list preferences and contributor's entry.
1940
1941         * Scripts/webkitpy/common/config/contributors.json:
1942         * Scripts/webkitpy/common/config/watchlist:
1943
1944 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
1945
1946         Fix WebCore export macros for declspec
1947         https://bugs.webkit.org/show_bug.cgi?id=208363
1948
1949         Reviewed by Konstantin Tokarev.
1950
1951         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
1952         files. Removed precompiled headers that were empty.
1953
1954         * DumpRenderTree/DumpRenderTreePrefix.h:
1955         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
1956         * MiniBrowser/win/stdafx.h:
1957         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
1958         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
1959         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
1960         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
1961         * WebKitTestRunner/PlatformFTW.cmake:
1962         * WebKitTestRunner/PlatformWin.cmake:
1963         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1964
1965 2020-02-27  Tim Horton  <timothy_horton@apple.com>
1966
1967         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
1968         https://bugs.webkit.org/show_bug.cgi?id=208365
1969
1970         Reviewed by Alex Christensen.
1971
1972         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1973         (TEST):
1974         Add a test! It was a 100% repro crash before this change.
1975
1976 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
1977
1978         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
1979         https://bugs.webkit.org/show_bug.cgi?id=208260
1980         <rdar://problem/59820107>
1981
1982         Reviewed by Tim Horton.
1983
1984         Followed instructions for adding an Info.plist for Single-File Tools
1985         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
1986
1987         The default WebsiteDataStore file path will change with this test to
1988         reflect the new bundleID so we must change expectations for any api
1989         tests which rely on knowing the path.
1990
1991         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1993         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
1994         (TEST):
1995         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1996         (TEST):
1997         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
1998         (TEST):
1999         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
2000         (TEST):
2001         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2002         (TEST):
2003         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2004         (TEST):
2005         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2006         (TEST):
2007         (defaultWebsiteCacheDirectory):
2008         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
2009         (TEST):
2010         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2011         (TEST):
2012         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2013         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2014         (TEST):
2015         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2016         (TEST):
2017         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2018         (runWebsiteDataStoreCustomPaths):
2019         (TEST):
2020         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2021         (TestWebKitAPI::resetTestState):
2022         Now that we set a bundleID, we have to reset the cache model between
2023         tests, otherwise it gets stored between tests.
2024
2025         (TestWebKitAPI::TEST):
2026         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2027         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2028
2029 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2030
2031         TextManipulationController should not generate a new item for content in manipulated paragraphs
2032         https://bugs.webkit.org/show_bug.cgi?id=208286
2033
2034         Reviewed by Wenson Hsieh.
2035
2036         Added a regression test.
2037
2038         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2039         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
2040
2041 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
2042
2043         run-javascriptcore-tests: Make upload format valid
2044         https://bugs.webkit.org/show_bug.cgi?id=208341
2045
2046         Reviewed by Aakash Jain.
2047
2048         * Scripts/run-javascriptcore-tests:
2049         (uploadResults): Print json blob for upload after failure for debugging.
2050
2051 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2052
2053         [CMake] Add WebKit::PAL target
2054         https://bugs.webkit.org/show_bug.cgi?id=198493
2055
2056         Reviewed by Michael Catanzaro.
2057
2058         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
2059
2060         * DumpRenderTree/PlatformWin.cmake:
2061
2062 2020-02-27  Alex Christensen  <achristensen@webkit.org>
2063
2064         Add SPI to query WKFrameInfos in a WKWebView
2065         https://bugs.webkit.org/show_bug.cgi?id=208212
2066
2067         Reviewed by Brady Eidson.
2068
2069         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2070         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2071         * WebKitTestRunner/TestController.cpp:
2072         (WTR::TestController::saltForOrigin):
2073
2074 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
2075
2076         Unreviewed, rolling out r257530.
2077
2078         This commit seems to have broke the build internally for
2079         watchOS
2080
2081         Reverted changeset:
2082
2083         "Add SPI to query WKFrameInfos in a WKWebView"
2084         https://bugs.webkit.org/show_bug.cgi?id=208212
2085         https://trac.webkit.org/changeset/257530
2086
2087 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2088
2089         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
2090         https://bugs.webkit.org/show_bug.cgi?id=206894
2091
2092         Reviewed by Adrian Perez de Castro.
2093
2094         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
2095         MiniBrowsers.
2096
2097         * MiniBrowser/gtk/CMakeLists.txt:
2098         * MiniBrowser/win/CMakeLists.txt:
2099         * MiniBrowser/wpe/CMakeLists.txt:
2100
2101 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2102
2103         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
2104         https://bugs.webkit.org/show_bug.cgi?id=206456
2105
2106         Reviewed by Brady Eidson.
2107
2108         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2109         (TEST):
2110
2111 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2112
2113         _WKUserContentWorld should be a wrapper around WKContentWorld
2114         https://bugs.webkit.org/show_bug.cgi?id=208274
2115
2116         Reviewed by Brady Eidson.
2117
2118         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
2119         (TEST):
2120         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2121         (TEST):
2122
2123 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
2124
2125         Unreviewed, rolling out r257522.
2126
2127         Caused 16 API test failures on the bots
2128
2129         Reverted changeset:
2130
2131         "TestWebKitAPI and WebKitTestRunner should have bundle
2132         identifiers"
2133         https://bugs.webkit.org/show_bug.cgi?id=208260
2134         https://trac.webkit.org/changeset/257522
2135
2136 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2137
2138         Add SPI to query WKFrameInfos in a WKWebView
2139         https://bugs.webkit.org/show_bug.cgi?id=208212
2140
2141         Reviewed by Brady Eidson.
2142
2143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2144         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2145         * WebKitTestRunner/TestController.cpp:
2146         (WTR::TestController::saltForOrigin):
2147
2148 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2149
2150         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
2151         https://bugs.webkit.org/show_bug.cgi?id=208260
2152         <rdar://problem/59820107>
2153
2154         Reviewed by Tim Horton.
2155
2156         Followed instructions for adding an Info.plist for Single-File Tools
2157         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
2158
2159         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2160         * TestWebKitAPI/Info.plist: Added.
2161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2162         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2163         * WebKitTestRunner/Info.plist: Added.
2164         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2165
2166 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2167
2168         Tests should each use a unique ResourceLoadStatistics file path for its database store
2169         https://bugs.webkit.org/show_bug.cgi?id=208206
2170         <rdar://problem/59690272>
2171
2172         Reviewed by Brady Eidson.
2173
2174         Initialize a default website data store before checking for the ITP
2175         store to ensure the directory exists after the file has been deleted.
2176
2177         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2178         (TEST):
2179
2180 2020-02-26  Christopher Reid  <chris.reid@sony.com>
2181
2182         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
2183         https://bugs.webkit.org/show_bug.cgi?id=197684
2184         <rdar://problem/59467397>
2185
2186         Reviewed by Yusuke Suzuki.
2187
2188         Add test for FileSystem::createFile
2189
2190         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2191
2192 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
2193
2194         [ews] commit-queue should verify patch committer and reviewer
2195         https://bugs.webkit.org/show_bug.cgi?id=206532
2196
2197         Reviewed by Jonathan Bedard.
2198
2199         * BuildSlaveSupport/ews-build/steps.py:
2200         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
2201         (ValidateCommiterAndReviewer._addToLog):
2202         (ValidateCommiterAndReviewer.getResultSummary):
2203         (ValidateCommiterAndReviewer.fail_build):
2204         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
2205         (ValidateCommiterAndReviewer.is_reviewer):
2206         (ValidateCommiterAndReviewer.is_committer):
2207         (ValidateCommiterAndReviewer.full_name_from_email):
2208         (ValidateCommiterAndReviewer.start):
2209
2210 2020-02-26  Daniel Bates  <dabates@apple.com>
2211
2212         [iOS] Send focus update immediately on becoming or resigning first responder
2213         https://bugs.webkit.org/show_bug.cgi?id=208082
2214         <rdar://problem/59688413>
2215
2216         Rubber-stamped by Jer Noble.
2217
2218         Add a test to ensure that selecting a position at a point after the web view
2219         becomes first responder is allowed. Such an operation is only allowed if the
2220         web view is focused.
2221
2222         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2223         (-[TestWKWebView selectPositionAtPoint:]):
2224         (TEST):
2225         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
2226
2227 2020-02-26  Chris Dumez  <cdumez@apple.com>
2228
2229         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
2230
2231         The test was added for macOS and times out on iOS.
2232
2233         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2234         (TEST):
2235
2236 2020-02-26  Youenn Fablet  <youenn@apple.com>
2237
2238         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
2239         https://bugs.webkit.org/show_bug.cgi?id=208238
2240
2241         Reviewed by Eric Carlson.
2242
2243         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2244         (TEST):
2245         Remove use of deleted parameter.
2246
2247 2020-02-25  Devin Rousso  <drousso@apple.com>
2248
2249         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
2250         https://bugs.webkit.org/show_bug.cgi?id=206911
2251         <rdar://problem/58026635>
2252
2253         Reviewed by Brian Burg.
2254
2255         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2256         (TestWebKitAPI::TEST):
2257         Add test for `WTF::HashSet::reserveInitialCapacity`.
2258
2259         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2260         (TestWebKitAPI::TEST):
2261         Actually check the value of `WTF::HashMap::capacity`.
2262
2263         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
2264         (-[InspectorDelegate _webView:didAttachInspector:])
2265         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
2266         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
2267         (TestWebKitAPI::TEST):
2268         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2269         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
2270         (TestWebKitAPI::TEST): Deleted.
2271
2272 2020-02-25  Matt Lewis  <jlewis3@apple.com>
2273
2274         Add checkout_root to stubrepository.py
2275         https://bugs.webkit.org/show_bug.cgi?id=208213
2276
2277         Reviewed by Jonathan Bedard.
2278
2279         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
2280         (StubRepository.__init__):
2281
2282         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
2283         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
2284
2285 2020-02-25  Daniel Bates  <dabates@apple.com>
2286
2287         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
2288         https://bugs.webkit.org/show_bug.cgi?id=208214
2289
2290         Reviewed by Wenson Hsieh.
2291
2292         Wait until the copy operation completes before loading the second web view and testing paste
2293         to ensure that something was actually copied to the clipboard.
2294
2295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
2296         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2297         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
2298         so that we wait until the command completes.
2299
2300 2020-02-25  Chris Dumez  <cdumez@apple.com>
2301
2302         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
2303         https://bugs.webkit.org/show_bug.cgi?id=208199
2304         <rdar://problem/59746887>
2305
2306         Reviewed by Alex Christensen.
2307
2308         Add API test coverage.
2309
2310         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2311         (TEST):
2312
2313 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
2314
2315         spinRunLoop should take a non-zero integer as parameter
2316         https://bugs.webkit.org/show_bug.cgi?id=208148
2317         <rdar://problem/59766682>
2318
2319         Unreviewed iOS build fix.
2320
2321         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2322         (TestWebKitAPI::Util::spinRunLoop):
2323
2324 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
2325
2326         spinRunLoop should take a non-zero integer as parameter
2327         https://bugs.webkit.org/show_bug.cgi?id=208148
2328
2329         Reviewed by Darin Adler.
2330
2331         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2332         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2333         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2334         (TestWebKitAPI::Util::spinRunLoop):
2335
2336 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
2337
2338         [WTF] Add tests for CompactRefPtrTuple
2339         https://bugs.webkit.org/show_bug.cgi?id=208172
2340
2341         Reviewed by Darin Adler.
2342
2343         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
2344         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
2345
2346         * TestWebKitAPI/CMakeLists.txt:
2347         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2348         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
2349         (TestWebKitAPI::TEST):
2350
2351 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
2352
2353         [ews] commit-queue should check that patch have appropriate review flag
2354         https://bugs.webkit.org/show_bug.cgi?id=208138
2355
2356         Reviewed by Jonathan Bedard.
2357
2358         * BuildSlaveSupport/ews-build/steps.py:
2359         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
2360         (BugzillaMixin._is_patch_cq_plus):
2361         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
2362         (ValidatePatch.start):
2363
2364 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
2365
2366         [WebAuthn] Implement SPI for the platform authenticator
2367         https://bugs.webkit.org/show_bug.cgi?id=208087
2368         <rdar://problem/59369305>
2369
2370         Reviewed by Brent Fulgham.
2371
2372         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
2373
2374         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
2375         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2377         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2378         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
2379         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
2380         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
2381         (TestWebKitAPI::TEST):
2382         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
2383         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
2384         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
2385         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
2386
2387 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
2388
2389         Unreviewed, updating LLDB test for CompactPointerTuple.
2390         https://bugs.webkit.org/show_bug.cgi?id=207827
2391
2392         * lldb/lldb_webkit.py:
2393         (WTFCompactPointerTupleProvider):
2394         (WTFCompactPointerTupleProvider.update):
2395
2396 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
2397
2398         Provide alternate way to name Web Content process
2399         https://bugs.webkit.org/show_bug.cgi?id=205224
2400         rdar://57038084
2401
2402         Reviewed by Alex Christensen.
2403
2404         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2405         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
2406         (TestWebKitAPI::TEST):
2407
2408 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
2409
2410         results.webkit.org: Link to result archives
2411         https://bugs.webkit.org/show_bug.cgi?id=207646
2412         <rdar://problem/59395807>
2413
2414         Rubber-stamped by Aakash Jain.
2415
2416         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
2417         (_ArchiveRouter): Retrieve json from archive-router endpoint.
2418         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
2419         return the most specific value.
2420         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
2421         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
2422         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
2423         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
2424         (parametersForInstance): Extract from lambda function.
2425         (testRunLink): Use parametersForInstance instead of a lambda function.
2426         (archiveLink): Return an archive link for data. 
2427         (contentForData): Add archive link to view.
2428         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2429         (TimelineFromEndpoint): Accept both suite and test.
2430         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
2431         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
2432         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
2433         * resultsdbpy/resultsdbpy/view/view_routes.py:
2434         (ViewRoutes.__init__): Add archive_route dictionary.
2435
2436 2020-02-24  Alex Christensen  <achristensen@webkit.org>
2437
2438         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
2439         https://bugs.webkit.org/show_bug.cgi?id=208035
2440         <rdar://problem/58011337>
2441
2442         Reviewed by Tim Hatcher.
2443
2444         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2445
2446 2020-02-22  Darin Adler  <darin@apple.com>
2447
2448         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
2449         https://bugs.webkit.org/show_bug.cgi?id=208099
2450
2451         Reviewed by Antti Koivisto.
2452
2453         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2454         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
2455         so we can use the -[NSString createJSStringRef] method.
2456         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
2457         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
2458
2459 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2460
2461         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
2462         https://bugs.webkit.org/show_bug.cgi?id=208096
2463         <rdar://problem/59632008>
2464
2465         Reviewed by Alexey Proskuryakov.
2466
2467         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
2468         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
2469         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
2470
2471         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
2472         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
2473         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
2474         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
2475         in the credit card expiry field.
2476
2477         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
2478
2479         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2480         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2481         (WTR::UIScriptController::setDefaultCalendarType):
2482         * WebKitTestRunner/TestController.h:
2483
2484         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
2485         identifier and calendar locale identifier.
2486
2487         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2488         (WTR::swizzledCalendar):
2489         (WTR::TestController::overriddenCalendarIdentifier const):
2490         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
2491
2492         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
2493
2494         (WTR::TestController::setDefaultCalendarType):
2495
2496         Plumb the new calendar's locale identifier through this method.
2497
2498         (WTR::TestController::cocoaResetStateToConsistentValues):
2499         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
2500         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
2501         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
2502         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
2503
2504 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
2505
2506         App-bound domains should have separate Network Sessions
2507         https://bugs.webkit.org/show_bug.cgi?id=208026
2508         <rdar://problem/59434006>
2509
2510         Reviewed by Brent Fulgham.
2511
2512         This patch is mostly test infrastructure involving 3 functions.
2513         One sets in-app browser privacy as enabled in the network process
2514         manually for the test. One ensures that setting the WebView category
2515         works properly, and the last one checks for an app-bound session for
2516         an app-bound navigation.
2517
2518         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2519         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2520         (WTR::InjectedBundle::didReceiveMessageToPage):
2521         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2522         (WTR::TestRunner::getWebViewCategory):
2523         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
2524         (WTR::TestRunner::hasAppBoundSession):
2525         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
2526         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
2527         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2528         * WebKitTestRunner/TestController.cpp:
2529         (WTR::TestController::ensureViewSupportsOptionsForTest):
2530         Clearing the bundleID should happen right before setting a new one, 
2531         otherwise it clears the ID after it is set and returns a null ID.
2532
2533         (WTR::TestController::resetStateToConsistentValues):
2534         (WTR::TestController::getWebViewCategory):
2535         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
2536         (WTR::inAppBrowserPrivacyBooleanResultCallback):
2537         (WTR::inAppBrowserPrivacyVoidResultCallback):
2538         (WTR::TestController::hasAppBoundSession):
2539         (WTR::TestController::setInAppBrowserPrivacyEnabled):
2540         * WebKitTestRunner/TestController.h:
2541         * WebKitTestRunner/TestInvocation.cpp:
2542         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2543         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2544         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
2545         (WTR::TestInvocation::didReceivePrevalentDomains):
2546         (WTR::TestInvocation::didReceiveWebViewCategory):
2547         * WebKitTestRunner/TestInvocation.h:
2548         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2549         (WTR::TestController::getWebViewCategory):
2550
2551 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
2552
2553         Build DumpRenderTree and WebKitTestRunner for macCatalyst
2554         https://bugs.webkit.org/show_bug.cgi?id=208068
2555         <rdar://problem/59676596>
2556
2557         Reviewed by Tim Horton.
2558
2559         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
2560         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
2561         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
2562         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
2563         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
2564         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
2565         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
2566         * DumpRenderTree/mac/EventSendingController.h: Ditto.
2567         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
2568         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
2569         * Makefile: Add DumpRenderTree and WebKitTestRunner.
2570         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
2571         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
2572         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
2573
2574 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
2575
2576         [ews] Add build step to Validate ChangeLog for commit-queue
2577         https://bugs.webkit.org/show_bug.cgi?id=208064
2578
2579         Reviewed by Jonathan Bedard.
2580
2581         * BuildSlaveSupport/ews-build/steps.py:
2582         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
2583         (ValidateChangeLogAndReviewer.start):
2584         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
2585         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
2586
2587 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
2588
2589         [ews] Add build step to set cq- flag on bugzilla patch
2590         https://bugs.webkit.org/show_bug.cgi?id=208021
2591
2592         Reviewed by Jonathan Bedard.
2593
2594         * BuildSlaveSupport/ews-build/steps.py:
2595         (BugzillaMixin.set_cq_minus_flag_on_patch):
2596         (SetCommitQueueMinusFlagOnPatch):
2597         (SetCommitQueueMinusFlagOnPatch.start):
2598         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
2599
2600 2020-02-20  Matt Lewis  <jlewis3@apple.com>
2601
2602         Stub repositories fail to upload some results due to missing head svn revision
2603         https://bugs.webkit.org/show_bug.cgi?id=207684
2604
2605         Reviewed by Jonathan Bedard.
2606
2607         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
2608         (MockHost.__init__):
2609         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2610         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
2611         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2612         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
2613         * Scripts/webkitpy/port/base.py:
2614         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
2615         from using mock SCMs and more
2616         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
2617
2618 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
2619
2620         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
2621         https://bugs.webkit.org/show_bug.cgi?id=208051
2622
2623         Reviewed by Carlos Alberto Lopez Perez.
2624
2625         Verbose flag prints out each test name executed. Without this flag
2626         stdout prints out one or two periods.
2627
2628         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2629         (RunJavaScriptCoreTests.start):
2630
2631 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
2632
2633         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
2634         https://bugs.webkit.org/show_bug.cgi?id=207984
2635
2636         Reviewed by Daniel Bates.
2637
2638         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2639         (TestWebKitAPI::TEST):
2640
2641 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
2642
2643         [GTK] Improve user agent quirk for Google Docs and Google Drive
2644         https://bugs.webkit.org/show_bug.cgi?id=206506
2645
2646         Reviewed by Carlos Garcia Campos.
2647
2648         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2649         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2650         (TestWebKitAPI::TEST):
2651
2652 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2653
2654         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
2655         https://bugs.webkit.org/show_bug.cgi?id=207380
2656
2657         Reviewed by Jonathan Bedard.
2658
2659         Added a new rule 'build/export_macro'.
2660
2661         Removed a obsolete rule 'readability/webkit_export' which was used
2662         only by Chromium port (r148185).
2663
2664         * Scripts/webkitpy/style/checkers/cpp.py:
2665         (_FunctionState.export_macro):
2666         (check_function_definition):
2667         (_unix_path): Added.
2668         (is_generated_file): Use _unix_path.
2669         (check_has_config_header): Ditto.
2670         (CppChecker):
2671         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2672         (WebKitStyleTest.test_export_macro_check):
2673         (WebKitStyleTest.test_webkit_export_check): Deleted.
2674
2675 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2676
2677         [Win][MiniBrowser] Add prettier toolbar button icons
2678         https://bugs.webkit.org/show_bug.cgi?id=207999
2679
2680         Reviewed by Ross Kirsling.
2681
2682         Use a custom toolbar button icons instead of system stock icons.
2683
2684         Fixed a bug toolbar button dropdown arrows always looked being
2685         hovered. TBSTYLE_FLAT should be given.
2686
2687         Removed the window border line of Progress Indicator.
2688
2689         * MiniBrowser/win/MainWindow.cpp:
2690         (MainWindow::createToolbar):
2691         * MiniBrowser/win/MiniBrowserLib.rc:
2692         * MiniBrowser/win/MiniBrowserLibResource.h:
2693         * MiniBrowser/win/toolbar.bmp: Added.
2694
2695 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
2696
2697         Update run-webkit-tests help description for skip-failing-tests
2698         https://bugs.webkit.org/show_bug.cgi?id=208031
2699
2700         Reviewed by Alexey Proskuryakov.
2701
2702         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2703
2704 2020-02-20  Chris Dumez  <cdumez@apple.com>
2705
2706         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
2707         https://bugs.webkit.org/show_bug.cgi?id=208015
2708         <rdar://problem/59591630>
2709
2710         Reviewed by Geoffrey Garen.
2711
2712         Add API test coverage.
2713
2714         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
2715         (TEST):
2716
2717 2020-02-20  Tim Horton  <timothy_horton@apple.com>
2718
2719         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
2720         https://bugs.webkit.org/show_bug.cgi?id=207998
2721         <rdar://problem/40942425>
2722
2723         Reviewed by Sam Weinig.
2724
2725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2726         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
2727         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2728         (TestWebKitAPI::TEST):
2729         Add some tests for top content insets.
2730
2731 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
2732
2733         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
2734         https://bugs.webkit.org/show_bug.cgi?id=207910
2735
2736         Unreviewed infrastructure fix.
2737
2738         * Scripts/run-javascriptcore-tests:
2739         (configurationForUpload): Use the major version instead of the sub-minor version
2740         for version name.
2741
2742 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
2743
2744         [CMake] Add WPE::libwpe target
2745         https://bugs.webkit.org/show_bug.cgi?id=207970
2746
2747         Reviewed by Adrian Perez de Castro.
2748
2749         Use the WPE::libwpe target.
2750
2751         * MiniBrowser/wpe/CMakeLists.txt:
2752         * TestWebKitAPI/PlatformWPE.cmake:
2753         * TestWebKitAPI/glib/PlatformWPE.cmake:
2754         * wpe/backends/CMakeLists.txt:
2755
2756 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2757
2758         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
2759         https://bugs.webkit.org/show_bug.cgi?id=207749
2760
2761         Reviewed by Ross Kirsling.
2762
2763         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
2764
2765         * MiniBrowser/win/MainWindow.cpp:
2766         (MainWindow::createToolbar):
2767         (MainWindow::WndProc):
2768         (MainWindow::setDefaultURLToCurrentURL):
2769         (MainWindow::goHome): Added.
2770         (MainWindow::onURLBarEnter):
2771         * MiniBrowser/win/MainWindow.h:
2772         * MiniBrowser/win/MiniBrowserLib.rc:
2773         * MiniBrowser/win/MiniBrowserLibResource.h:
2774         * MiniBrowser/win/MiniBrowserReplace.h:
2775         * MiniBrowser/win/WinMain.cpp:
2776         (wWinMain):
2777
2778 2020-02-19  Peng Liu  <peng.liu6@apple.com>
2779
2780         Fix check-webkit-style errors related to AVFoundationSPI.h
2781         https://bugs.webkit.org/show_bug.cgi?id=207834
2782
2783         Reviewed by Daniel Bates.
2784
2785         Revert the change in r256770 regarding the headers ordering.
2786         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
2787
2788         * Scripts/webkitpy/style/checkers/cpp.py:
2789         (check_include_line):
2790
2791 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
2792
2793         results.webkit.org: Correctly report JSC tests for windows
2794         https://bugs.webkit.org/show_bug.cgi?id=207910
2795
2796         Rubber-stamped by Aakash Jain.
2797
2798         * Scripts/run-javascriptcore-tests:
2799         (configurationForUpload): Give Windows a version name.
2800         * Scripts/webkitdirs.pm:
2801         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
2802         Version dictionary.
2803
2804 2020-02-19  Chris Dumez  <cdumez@apple.com>
2805
2806         Unreviewed, fix assertions in storage access API layout tests after r256882.
2807
2808         Drop dead testRunner code to toggle storage access API feature.
2809
2810         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2811         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2812         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
2813         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2814         * WebKitTestRunner/TestInvocation.cpp:
2815         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2816
2817 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
2818
2819         [WPE] Support 2D axis, smooth-motion events
2820         https://bugs.webkit.org/show_bug.cgi?id=207881
2821
2822         Reviewed by Carlos Garcia Campos.
2823
2824         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
2825
2826 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
2827
2828         Unreviewed, rolling out r256851.
2829
2830         Broke internal bots
2831
2832         Reverted changeset:
2833
2834         "Stub repositories fail to upload some results due to missing
2835         head svn revision"
2836         https://bugs.webkit.org/show_bug.cgi?id=207684
2837         https://trac.webkit.org/changeset/256851
2838
2839 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2840
2841         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
2842         https://bugs.webkit.org/show_bug.cgi?id=207883
2843
2844         Reviewed by Ross Kirsling.
2845
2846         Unlike other mouse buttons, 4th and 5th mouse buttons are
2847         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
2848         WM_XBUTTONUP events to the window under the mouse cursor.
2849         Unhandled WM_XBUTTONUP events are automatically converted to
2850         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
2851         parent window.
2852         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
2853
2854         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
2855         handled.
2856
2857         * MiniBrowser/win/BrowserWindow.h:
2858         * MiniBrowser/win/MainWindow.cpp:
2859         (MainWindow::WndProc):
2860         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2861         (WebKitBrowserWindow::navigateForwardOrBackward):
2862         * MiniBrowser/win/WebKitBrowserWindow.h:
2863         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2864         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
2865         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2866
2867 2020-02-18  Alex Christensen  <achristensen@webkit.org>
2868
2869         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
2870         https://bugs.webkit.org/show_bug.cgi?id=207912
2871         <rdar://problem/59556922>
2872
2873         Reviewed by Brian Weinstein.
2874
2875         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
2876         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
2877         (TEST):
2878         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
2879         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
2880
2881 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2882
2883         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
2884         https://bugs.webkit.org/show_bug.cgi?id=207899
2885         <rdar://problem/55658207>
2886
2887         Reviewed by Tim Horton and Simon Fraser.
2888
2889         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
2890
2891         * WebKitTestRunner/TestController.cpp:
2892         (WTR::updateTestOptionsFromTestHeader):
2893         * WebKitTestRunner/TestOptions.h:
2894         (WTR::TestOptions::hasSameInitializationOptions const):
2895         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2896         (WTR::TestController::platformCreateWebView):
2897
2898 2020-02-18  Matt Lewis  <jlewis3@apple.com>
2899
2900         Stub repositories fail to upload some results due to missing head svn revision
2901         https://bugs.webkit.org/show_bug.cgi?id=207684
2902
2903         Reviewed by Jonathan Bedard.
2904
2905         * Scripts/webkitpy/api_tests/run_api_tests.py:
2906         (main): Added initializing the scm to the host object.
2907         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2908         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
2909         it in line with modern code.
2910         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2911         (main): Added inializing the scm to the host object.
2912         * Scripts/webkitpy/port/base.py:
2913         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
2914         from using mock SCMs and more
2915         * Scripts/webkitpy/test/main.py:
2916         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
2917         and converted the webkit_root variable to the SCM checkout root.
2918         (Tester._run_tests):
2919
2920 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
2921
2922         Move [UIDevice currentDevice] calls to UI process
2923         https://bugs.webkit.org/show_bug.cgi?id=204320
2924
2925         Reviewed by Darin Adler.
2926
2927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2928         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
2929         (TEST):
2930
2931 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
2932
2933         Move from "layer flush" terminology to "rendering update"
2934         https://bugs.webkit.org/show_bug.cgi?id=207870
2935
2936         Reviewed by Tim Horton.
2937
2938         Rename various functions and member variables to move away from the legacy "layer flush"
2939         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
2940         that we have layers is an implementation detail.
2941         
2942         Change LayerFlushThrottlingState to be an OptionSet<>.
2943
2944         * Tracing/SystemTracePoints.plist:
2945
2946 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
2947
2948         [Webkit.css] Adding popover style element
2949         This help to prevent us reinventing the wheel ever again
2950         https://bugs.webkit.org/show_bug.cgi?id=207787
2951
2952         Reviewed by Dean Jackson.
2953
2954         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
2955         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
2956         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2957         (.popover):
2958         (.popover>.content):
2959         (.popover.display):
2960         (.popover .arrow):
2961         (.popover .arrow.point-top):
2962         (.popover .arrow.point-bottom):
2963         (.popover .arrow.point-left):
2964         (.popover .arrow.point-right):
2965         (@media (prefers-color-scheme: dark) .popover>.content):
2966         (@media (prefers-color-scheme: dark) .popover.display):
2967         (@media (prefers-color-scheme: dark) .popover .arrow):
2968         (.popover>.content>.section): Deleted.
2969         (.popover:focus>.content, .popover:hover>.content): Deleted.
2970         (.popover.right>.content): Deleted.
2971         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
2972         (.popover.left>.content): Deleted.
2973         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
2974         (.popover.bottom>.content): Deleted.
2975         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
2976
2977 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
2978
2979         Update WebKit Tools to issue mach extensions as needed
2980         https://bugs.webkit.org/show_bug.cgi?id=207850
2981         <rdar://problem/59521019>
2982
2983         Reviewed by Per Arne Vollan.
2984
2985         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
2986         to its child processes (WebContent, GPU, Network, etc.) as needed.
2987
2988         * MiniBrowser/MiniBrowser.entitlements:
2989         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
2990         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2992         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
2993
2994 2020-02-17  Peng Liu  <peng.liu6@apple.com>
2995
2996         Fix check-webkit-style errors related to AVFoundationSPI.h
2997         https://bugs.webkit.org/show_bug.cgi?id=207834
2998
2999         Reviewed by Eric Carlson.
3000
3001         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
3002         Soft-link headers can be included as either "file.h" or <file.h>.
3003
3004         * Scripts/webkitpy/style/checkers/cpp.py:
3005         (_classify_include):
3006         (check_include_line):
3007
3008 2020-02-17  Keith Rollin  <krollin@apple.com>
3009
3010         Unreviewed build fix after r256715.
3011
3012         Fix tvOS and watchOS builds.
3013
3014         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3015
3016 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
3017
3018         Use CF prefs direct mode in the WebContent process
3019         https://bugs.webkit.org/show_bug.cgi?id=203420
3020
3021         Reviewed by Brent Fulgham.
3022
3023         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3024         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
3025         (TEST):
3026
3027 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3028
3029         EWS should be able to file Bugzilla bugs
3030         https://bugs.webkit.org/show_bug.cgi?id=207845
3031
3032         Reviewed by Alexey Proskuryakov.
3033
3034         * BuildSlaveSupport/ews-build/steps.py:
3035         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
3036
3037 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3038
3039         EWS should be able to comment on Bugzilla
3040         https://bugs.webkit.org/show_bug.cgi?id=201927
3041
3042         Reviewed by Jonathan Bedard.
3043
3044         * BuildSlaveSupport/ews-build/steps.py:
3045         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
3046         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
3047         (BugzillaMixin.close_bug): Ditto.
3048         (CommentOnBug): Build step to comment on bugzilla bug.
3049
3050 2020-02-17  Antti Koivisto  <antti@apple.com>
3051
3052         [macOS] Add trace points for layer flush runloop observer
3053         https://bugs.webkit.org/show_bug.cgi?id=207837
3054
3055         Reviewed by Sam Weinig.
3056
3057         * Tracing/SystemTracePoints.plist:
3058
3059 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
3060
3061         [CMake] Use builtin targets
3062         https://bugs.webkit.org/show_bug.cgi?id=205166
3063
3064         Reviewed by Darin Adler.
3065
3066         * TestWebKitAPI/PlatformWin.cmake:
3067
3068 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3069
3070         [ews] add SetBuildSummary step for Windows EWS
3071         https://bugs.webkit.org/show_bug.cgi?id=207556
3072
3073         Reviewed by Jonathan Bedard.
3074
3075         * BuildSlaveSupport/ews-build/factories.py:
3076         (WindowsFactory.__init__):
3077         (GTKBuildAndTestFactory.__init__):
3078         * BuildSlaveSupport/ews-build/factories_unittest.py:
3079         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
3080
3081 2020-02-17  Alberto Garcia  <berto@igalia.com>
3082
3083         [WPE] Change the QML plugin install path
3084         https://bugs.webkit.org/show_bug.cgi?id=207761
3085
3086         Reviewed by Philippe Normand.
3087
3088         * Scripts/run-qt-wpe-minibrowser:
3089         * glib/api_test_runner.py:
3090         (TestRunner._run_test_qt):
3091
3092 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
3093
3094         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
3095         https://bugs.webkit.org/show_bug.cgi?id=207746
3096
3097         Reviewed by Don Olmstead.
3098
3099         * MiniBrowser/win/stdafx.h:
3100
3101 2020-02-16  Brady Eidson  <beidson@apple.com>
3102
3103         Expose "allowsContentJavaScript" on WKWebpagePreferences
3104         <rdar://problem/51534967> and https://bugs.webkit.org/show_bug.cgi?id=207427
3105
3106         Reviewed by Darin Adler.
3107
3108         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3109         (TEST):
3110         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3111         (-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3112         (TEST):
3113         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.
3114         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3115         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3116         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3117         (-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
3118         (-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
3119         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3120         * TestWebKitAPI/cocoa/TestWKWebView.h:
3121         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3122         (-[WKWebView synchronouslyLoadHTMLString:preferences:]):
3123
3124 2020-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
3125
3126         NetworkLoadMetrics should be shared by multiple ResourceResponse instances
3127         https://bugs.webkit.org/show_bug.cgi?id=207747
3128
3129         Reviewed by Keith Miller.
3130
3131         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
3132         (TestWebKitAPI::TEST):
3133
3134 2020-02-14  Alex Christensen  <achristensen@webkit.org>
3135
3136         Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
3137         https://bugs.webkit.org/show_bug.cgi?id=207360
3138         <rdar://problem/57825317>
3139
3140         Reviewed by Ryosuke Niwa.
3141
3142         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3143         (TestWebKitAPI::TEST):
3144
3145 2020-02-14  Don Olmstead  <don.olmstead@sony.com>
3146
3147         [CMake] Add Fontconfig::Fontconfig target
3148         https://bugs.webkit.org/show_bug.cgi?id=207730
3149
3150         Reviewed by Adrian Perez de Castro.
3151
3152         Use the Fontconfig::Fontconfig target.
3153
3154         * WebKitTestRunner/PlatformGTK.cmake:
3155
3156 2020-02-13  Kate Cheney  <katherine_cheney@apple.com>
3157
3158          Expose prevalent domains on a per-page basis
3159          https://bugs.webkit.org/show_bug.cgi?id=207523
3160          <rdar://problem/59270758>
3161
3162         Reviewed by Chris Dumez.
3163
3164         Added WebKitTestRunner functions so this functionality can be tested.
3165         clearPrevalentDomains should be called between tests to reset the
3166         state.
3167
3168         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3169         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3170         (WTR::InjectedBundle::didReceiveMessageToPage):
3171         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3172         (WTR::TestRunner::getPrevalentDomains):
3173         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback):
3174         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3175         * WebKitTestRunner/TestController.cpp:
3176         (WTR::TestController::resetStateToConsistentValues):
3177         (WTR::TestController::getPrevalentDomains):
3178         (WTR::TestController::clearPrevalentDomains):
3179         * WebKitTestRunner/TestController.h:
3180         * WebKitTestRunner/TestInvocation.cpp:
3181         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3182         (WTR::TestInvocation::didReceivePrevalentDomains):
3183         * WebKitTestRunner/TestInvocation.h:
3184         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3185         (WTR::TestController::getPrevalentDomains):
3186         (WTR::TestController::clearPrevalentDomains):
3187
3188 2020-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
3189
3190         [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
3191         https://bugs.webkit.org/show_bug.cgi?id=207682
3192
3193         Reviewed by Ross Kirsling.
3194
3195         The toolbar placed button common controls as the toolbar buttons.
3196         However, because these buttons are focusable, shortcut keys don't
3197         work after clicking them.
3198
3199         Added Home button, Add to Bookmarks button, dropdown buttons of
3200         back and forward buttons, but they aren't implemented yet. Just
3201         placeholders at the moment.
3202
3203         * MiniBrowser/win/MainWindow.cpp:
3204         (MainWindow::createToolbar): Added.
3205         (MainWindow::resizeToolbar): Added.
3206         (MainWindow::rescaleToolbar): Added.
3207         (MainWindow::init):
3208         (MainWindow::resizeSubViews):
3209         (MainWindow::updateDeviceScaleFactor):
3210         * MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
3211
3212 2020-02-13  Ryosuke Niwa  <rniwa@webkit.org>
3213
3214         Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
3215         https://bugs.webkit.org/show_bug.cgi?id=207676
3216
3217         Reviewed by Wenson Hsieh and Timothy Hatcher.
3218
3219         Added regression tests for pasting content with -apple-system-label and outdenting content.
3220
3221         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3222         (PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
3223         (PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
3224
3225 2020-02-13  Alex Christensen  <achristensen@webkit.org>
3226
3227         _WKResourceLoadInfo should conform to NSSecureCoding
3228         https://bugs.webkit.org/show_bug.cgi?id=207667
3229
3230         Reviewed by Brady Eidson.
3231
3232         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
3233         (TEST):
3234
3235 2020-02-13  Stephan Szabo  <stephan.szabo@sony.com>
3236
3237         [PlayStation] Add Buildbots for Debug/Release builds
3238         https://bugs.webkit.org/show_bug.cgi?id=199454
3239
3240         Reviewed by Aakash Jain.
3241
3242         * BuildSlaveSupport/build.webkit.org-config/config.json:
3243         Add PlayStation slaves, builders
3244         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3245         Use higher timeout for playstation as with win bot
3246         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
3247         Set PlayStation category for playstation platform
3248         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3249         Use same path as gtk, wincairo, etc for appendCustomBuildFlags
3250         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3251         Add PlayStation expectations
3252
3253 2020-02-13  Per Arne Vollan  <pvollan@apple.com>
3254
3255         [iOS] Check if PIP is supported in the UI process
3256         https://bugs.webkit.org/show_bug.cgi?id=207406
3257
3258         Reviewed by Brent Fulgham.
3259
3260         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3261         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
3262         (TEST):
3263
3264 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
3265
3266         TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
3267         https://bugs.webkit.org/show_bug.cgi?id=207397
3268         <rdar://problem/59268128>
3269
3270         Reviewed by Jer Noble.
3271
3272         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
3273         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
3274
3275 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
3276
3277         TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
3278         https://bugs.webkit.org/show_bug.cgi?id=207696
3279
3280         Reviewed by Tim Horton.
3281
3282         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3283
3284 2020-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3285
3286         [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
3287         https://bugs.webkit.org/show_bug.cgi?id=207680
3288         <rdar://problem/59340940>
3289
3290         Reviewed by Tim Horton.
3291
3292         Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind
3293         the current selection works.
3294
3295         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
3296         (-[TestWKWebView updateSelectionWithExtentPoint:]):
3297         * TestWebKitAPI/ios/UIKitSPI.h:
3298
3299 2020-02-13  Said Abou-Hallawa  <said@apple.com>
3300
3301         Unreviewed, rolling out r255158, 255405 and r255486
3302
3303         Caused test flakiness and PLT regression.
3304
3305         * DumpRenderTree/mac/DumpRenderTree.mm:
3306         (resetWebPreferencesToConsistentValues):
3307         * DumpRenderTree/win/DumpRenderTree.cpp:
3308         (enableExperimentalFeatures):
3309         * WebKitTestRunner/TestController.cpp:
3310         (WTR::TestController::resetPreferencesToConsistentValues):
3311
3312 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3313
3314         run-javascriptcore-tests: Allow insecure requests on upload
3315         https://bugs.webkit.org/show_bug.cgi?id=207662
3316
3317         Rubber-stamped by Aakash Jain.
3318
3319         * Scripts/run-javascriptcore-tests:
3320         (uploadResults): Allow insecure curl request when posting results.
3321
3322 2020-02-12  Truitt Savell  <tsavell@apple.com>
3323
3324         Unreviewed, rolling out r256463.
3325
3326         Caused major flakiness on Mac wk2
3327
3328         Reverted changeset:
3329
3330         "REGRESSION (r255158): http/tests/frame-throttling/raf-
3331         throttle-in-cross-origin-subframe.html is a flaky failure"
3332         https://bugs.webkit.org/show_bug.cgi?id=206839
3333         https://trac.webkit.org/changeset/256463
3334
3335 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3336
3337         results.webkit.org: Remove debug JS logging
3338         https://bugs.webkit.org/show_bug.cgi?id=207663
3339
3340         Reviewed by Aakash Jain.
3341
3342         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
3343         (elapsed):
3344         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
3345         (_ToolTip.prototype.toString):
3346         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
3347         (prototype.addWithDelay):
3348         * resultsdbpy/resultsdbpy/view/templates/archive_list.html:
3349
3350 2020-02-12  Simon Fraser  <simon.fraser@apple.com>
3351
3352         Remove CSS_DEVICE_ADAPTATION
3353         https://bugs.webkit.org/show_bug.cgi?id=203479
3354
3355         Reviewed by Tim Horton.
3356         
3357         CSS Working Group resolved to remove @viewport <https://github.com/w3c/csswg-drafts/issues/4766>,
3358         so remove the code.
3359
3360         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3361
3362 2020-02-12  Said Abou-Hallawa  <said@apple.com>
3363
3364         REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
3365         https://bugs.webkit.org/show_bug.cgi?id=206839
3366
3367         Reviewed by Simon Fraser.
3368
3369         Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
3370
3371         * DumpRenderTree/mac/DumpRenderTree.mm:
3372         (resetWebPreferencesToConsistentValues):
3373         * DumpRenderTree/win/DumpRenderTree.cpp:
3374         (enableExperimentalFeatures):
3375         * WebKitTestRunner/TestController.cpp:
3376         (WTR::TestController::resetPreferencesToConsistentValues):
3377
3378 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3379
3380         results.webkit.org: Cache archive content
3381         https://bugs.webkit.org/show_bug.cgi?id=207589
3382
3383         Reviewed by Aakash Jain.
3384
3385         * resultsdbpy/resultsdbpy/flask_support/util.py:
3386         (cache_for): Add decorator function which sets the cache values on the returned response.
3387         * resultsdbpy/resultsdbpy/view/archive_view.py:
3388         (ArchiveView): Cache archive content client-side for 12 hours.
3389         * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
3390         (ArchiveViewUnittest.test_file): Verify that archived content is cached.
3391
3392 2020-02-12  Youenn Fablet  <youenn@apple.com>
3393
3394         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
3395         https://bugs.webkit.org/show_bug.cgi?id=207537
3396
3397         Reviewed by Chris Dumez.
3398
3399         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3400
3401 2020-02-11  Rob Buis  <rbuis@igalia.com>
3402
3403         Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
3404         <https://webkit.org/b/207424>
3405         <rdar://problem/59250384>
3406
3407         Reviewed by Rob Buis.
3408
3409         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3410         (TestWebKitAPI::TEST): Add more tests.
3411
3412 2020-02-11  Commit Queue  <commit-queue@webkit.org>
3413
3414         Unreviewed, rolling out r256314.
3415         https://bugs.webkit.org/show_bug.cgi?id=207594
3416
3417         It is breaking an API test (Requested by youenn on #webkit).
3418
3419         Reverted changeset:
3420
3421         "WebSWServerConnection::registerServiceWorkerClient is not
3422         sending IPC message to UIProcess when it should"
3423         https://bugs.webkit.org/show_bug.cgi?id=207537
3424         https://trac.webkit.org/changeset/256314
3425
3426 2020-02-11  Jonathan Bedard  <jbedard@apple.com>
3427
3428         results.webkit.org: Configuration documentation should include architecture
3429         https://bugs.webkit.org/show_bug.cgi?id=207584
3430
3431         Reviewed by Aakash Jain.
3432
3433         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
3434
3435 2020-02-11  Youenn Fablet  <youenn@apple.com>
3436
3437         Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
3438         https://bugs.webkit.org/show_bug.cgi?id=207325
3439         <rdar://problem/59224810>
3440
3441         Reviewed by Eric Carlson.
3442
3443         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
3444         (TestWebKitAPI::TEST):
3445         Add a test validating that RTCRtpSender.getCapabilities does not return null.
3446         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3447
3448 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3449
3450         KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
3451         https://bugs.webkit.org/show_bug.cgi?id=207557
3452
3453         Reviewed by Jonathan Bedard.
3454
3455         The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
3456         a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
3457         to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
3458         around this by focusing an empty select element instead (for which we won't attempt to create and select any
3459         table view cells).
3460
3461         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3462
3463 2020-02-11  Alex Christensen  <achristensen@webkit.org>
3464
3465         Add WKHTTPCookieStore._getCookiesForURL SPI
3466         https://bugs.webkit.org/show_bug.cgi?id=207527
3467
3468         Reviewed by Brady Eidson.
3469
3470         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3471         (TEST):
3472
3473 2020-02-11  Youenn Fablet  <youenn@apple.com>
3474
3475         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
3476         https://bugs.webkit.org/show_bug.cgi?id=207537
3477
3478         Reviewed by Chris Dumez.
3479
3480         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3481
3482 2020-02-11  Lauro Moura  <lmoura@igalia.com>
3483
3484         [WPE][WebDriver] MiniBrowser should react to close session commands
3485         https://bugs.webkit.org/show_bug.cgi?id=207529
3486
3487         Reviewed by Carlos Garcia Campos.
3488
3489         WebDriver delete session command asks to close the WebView associated to the
3490         current automation session. We must react to it to avoid lots of
3491         timeouts and errors.
3492
3493         * MiniBrowser/wpe/main.cpp:
3494         (main): Listen to "close" signal on the main WebView.
3495
3496 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3497
3498         [iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
3499         https://bugs.webkit.org/show_bug.cgi?id=207525
3500         <rdar://problem/59110543>
3501
3502         Reviewed by Tim Horton.
3503
3504         After the fix for <rdar://problem/56301207>, some scroll view content offset changes will attempt to call into
3505         CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
3506         creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
3507         unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
3508         UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
3509         causing us to crash upon trying to create the dictionary.
3510
3511         While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
3512         some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
3513         identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
3514         throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
3515         identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
3516         beginning of each API test.
3517
3518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3519         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3520         (overrideBundleIdentifier):
3521
3522         Move this to the top of the file, so it can be shared.
3523
3524         (+[WKWebView initialize]):
3525
3526         At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
3527         internal class method that calls into the internal helper function, with no other side effects.
3528
3529         * TestWebKitAPI/ios/UIKitSPI.h:
3530
3531 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
3532
3533         TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
3534         https://bugs.webkit.org/show_bug.cgi?id=207501
3535         <rdar://problem/59323414>
3536
3537         Reviewed by Alex Christensen.
3538
3539         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
3540         (writeMultipleObjectsToPlatformPasteboard): All iOS family ports should have
3541         The same behavior.
3542
3543 2020-02-10  Alan Sien Wei Hshieh  <hshieh@apple.com>
3544
3545         Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes
3546         https://bugs.webkit.org/show_bug.cgi?id=207352
3547         <rdar://problem/59115798>
3548
3549         Reviewed by Alex Christensen.
3550
3551         Add a test to exercise the new SPI.
3552
3553         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm: Add a test for getting text from all frames with
3554         a webpage that contains text in subframes.
3555
3556
3557 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
3558
3559         [iOS] Crash when granting access to asset services
3560         https://bugs.webkit.org/show_bug.cgi?id=207520
3561
3562         Reviewed by Brent Fulgham.
3563
3564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3565         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: Added.
3566         (TEST):
3567
3568 2020-02-10  Chris Dumez  <cdumez@apple.com>
3569
3570         [DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
3571         https://bugs.webkit.org/show_bug.cgi?id=207481
3572
3573         Reviewed by Alexey Proskuryakov.
3574
3575         InternalSettingsGenerated::resetToConsistentState() may override TestOptions such as enableBackForwardCache.
3576         This is causing issues such as the back/forward cache sometimes getting enabled on tests where
3577         TestOptions::enableBackForwardCache() is false, because a previous test has enabled the back/forward cache.
3578
3579         * DumpRenderTree/mac/DumpRenderTree.mm:
3580         (resetWebViewToConsistentStateBeforeTesting):
3581         Make sure we reset preferences after we call WebCoreTestSupport::resetInternalsObject(), since
3582         resetInternalsObject() updates settings and TestOptions / DRT preferences should have priority
3583         over internal settings.
3584
3585 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
3586
3587         [watchOS] Notification listener is never unregistered
3588         https://bugs.webkit.org/show_bug.cgi?id=207459
3589
3590         Reviewed by Maciej Stachowiak.
3591
3592         Add a test which tests that posting a backlight level change notification will not cause a crash.
3593
3594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3595         * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added.
3596         (TEST):
3597
3598 2020-02-10  James Howard  <jameshoward@mac.com>
3599
3600         Standard gamepad mapping for GameControllerGamepads
3601         https://bugs.webkit.org/show_bug.cgi?id=206033
3602
3603         Reviewed by Dean Jackson.
3604
3605         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3606         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3607         (WTR::TestRunner::setMockGamepadDetails):
3608         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3609         * WebKitTestRunner/TestInvocation.cpp:
3610         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3611
3612 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
3613
3614         [ews] Display flaky layout test names in build summary
3615         https://bugs.webkit.org/show_bug.cgi?id=207504
3616
3617         Reviewed by Jonathan Bedard.
3618
3619         * BuildSlaveSupport/ews-build/steps.py:
3620         (ReRunWebKitTests.evaluateCommand): Drive-by fix to correct the pluralization.
3621         (AnalyzeLayoutTestsResults.report_pre_existing_failures): Append the flaky failure information.
3622         (AnalyzeLayoutTestsResults.start):
3623
3624 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
3625
3626         [ews] Use SetBuildSummary instead of buildFinished in Layout tests
3627         https://bugs.webkit.org/show_bug.cgi?id=207492
3628
3629         Reviewed by Jonathan Bedard.
3630
3631         * BuildSlaveSupport/ews-build/steps.py:
3632         (RunWebKitTests.evaluateCommand):
3633         (ReRunWebKitTests.evaluateCommand):
3634         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
3635         * BuildSlaveSupport/ews-build/factories.py:
3636         (TestFactory.__init__):
3637
3638 2020-02-10  Truitt Savell  <tsavell@apple.com>
3639
3640         Unreviewed, rolling out r256091.
3641
3642         Broke internal builds
3643
3644         Reverted changeset:
3645
3646         "Move trivial definitions from FeatureDefines.xcconfig to
3647         PlatformEnableCocoa.h"
3648         https://bugs.webkit.org/show_bug.cgi?id=207155
3649         https://trac.webkit.org/changeset/256091
3650
3651 2020-02-10  Truitt Savell  <tsavell@apple.com>
3652
3653         Unreviewed, rolling out r256103.
3654
3655         This patch is blocking the rollout of r256091
3656
3657         Reverted changeset:
3658
3659         "Move JavaScriptCore related feature defines from
3660         FeatureDefines.xcconfig to PlatformEnableCocoa.h"
3661         https://bugs.webkit.org/show_bug.cgi?id=207436
3662         https://trac.webkit.org/changeset/256103
3663
3664 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
3665
3666         results.webkit.org: Abstract archive storage solutions
3667         https://bugs.webkit.org/show_bug.cgi?id=207277
3668
3669         Rubber-stamped by Aakash Jain.
3670
3671         * resultsdbpy/resultsdbpy/model/archive_context.py:
3672         (ArchiveContext):
3673         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
3674         (ArchiveContext.__init__): Add archiver member.
3675         (ArchiveContext.__enter__): archiver is a context manager.
3676         (ArchiveContext.__exit__): Ditto.
3677         (ArchiveContext.register): The archiver member owns saving an archive.
3678         (ArchiveContext.find_archive): The archiver member owns retrieving an archive.
3679         (ArchiveContext.ArchiveChunks): Move to CassandraArchiver.
3680         * resultsdbpy/resultsdbpy/model/archiver.py: Added.
3681         (Archiver): Base class for all Archiving systems.
3682         (Archiver.archive_digest): Given a file-like archive, calculate it's digest.
3683         (Archiver.archive_size): Given a file-like archive, calculate it's size.
3684         (Archiver.save):
3685         (Archiver.retrieve):
3686         * resultsdbpy/resultsdbpy/model/cassandra_archiver.py: Added.
3687         (CassandraArchiver):
3688         (CassandraArchiver.ArchiveChunks): Moved from ArchiveContext.
3689         (CassandraArchiver.__init__):
3690         (CassandraArchiver.__enter__):
3691         (CassandraArchiver.__exit__):
3692         (CassandraArchiver.save): Split the provided archive into chunks for saving, moved
3693         from ArchiveContext.
3694         (CassandraArchiver.retrieve): Retrieve an archive with the provided hash, moved
3695         from ArchiveContext.
3696
3697 2020-02-09  Lauro Moura  <lmoura@igalia.com>
3698
3699         [GTK][WPE] Expose allowTopNavigationToDataURL
3700         https://bugs.webkit.org/show_bug.cgi?id=207384
3701
3702         Reviewed by Adrian Perez de Castro.
3703
3704         Updates with new "allow-top-navigation-to-data-urls" property.
3705
3706         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3707         (testWebViewAllowModalDialogs): This test requires this property to be
3708         set.
3709         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3710         (testWebKitSettings): Added tests for getter/setter.
3711
3712 2020-02-08  Sam Weinig  <weinig@apple.com>
3713
3714         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3715         https://bugs.webkit.org/show_bug.cgi?id=207436
3716
3717         Reviewed by Tim Horton.
3718
3719         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3720         Remove ENABLE_FAST_JIT_PERMISSIONS and ENABLE_FTL_JIT.
3721
3722 2020-02-08  Yusuke Suzuki  <ysuzuki@apple.com>
3723
3724         [WTF] Try using 75% load factor for HashTable
3725         https://bugs.webkit.org/show_bug.cgi?id=207183
3726
3727         Reviewed by Mark Lam.
3728
3729         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3730         (TestWebKitAPI::testInitialCapacity):
3731
3732 2020-02-08  Sam Weinig  <weinig@apple.com>
3733
3734         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3735         https://bugs.webkit.org/show_bug.cgi?id=207155
3736
3737         Reviewed by Tim Horton.
3738
3739         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
3740         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
3741         also has a default value in PlatformEnable.h
3742
3743         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3744
3745 2020-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3746
3747         Several iOS API tests that call -makeKeyWindow assert after r255907
3748         https://bugs.webkit.org/show_bug.cgi?id=207411
3749
3750         Reviewed by Tim Horton.
3751
3752         r255907 asserted in -makeKeyWindow that the shared UIApplication exists. While this was guaranteed for all call
3753         sites of -makeKeyWindow from API tests, -makeKeyWindow may also be invoked from within UIKit code; in this case,
3754         nothing guarantees that the application has been initialized, and we end up hitting this assertion. To fix this,
3755         replace the assertion with logic to bootstrap the shared UIApplication (if it didn't already exist).
3756
3757         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3758         (TestWebKitAPI::TEST):
3759         (TestWebKitAPI::overrideBundleIdentifier): Deleted.
3760         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3761         (overrideBundleIdentifier):
3762         (setOverriddenApplicationKeyWindow):
3763
3764 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3765
3766         TestWebKitAPI: Disable legacy ActionSheet tests on Catalyst
3767         https://bugs.webkit.org/show_bug.cgi?id=207405
3768
3769         Reviewed by Wenson Hsieh.
3770
3771         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3772
3773 2020-02-07  Alex Christensen  <achristensen@apple.com>
3774
3775         Remember if we used legacy TLS in the back/forward cache like we remember if we have only secure content
3776         https://bugs.webkit.org/show_bug.cgi?id=207409
3777         rdar://problem/59275641
3778
3779         Reviewed by Chris Dumez.
3780
3781         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3782         (TestWebKitAPI::TEST):
3783
3784 2020-02-07  Ryan Haddad  <ryanhaddad@apple.com>
3785
3786         Unreviewed, rolling out r256051.
3787
3788         Broke internal builds.
3789
3790         Reverted changeset:
3791
3792         "Move trivial definitions from FeatureDefines.xcconfig to
3793         PlatformEnableCocoa.h"
3794         https://bugs.webkit.org/show_bug.cgi?id=207155
3795         https://trac.webkit.org/changeset/256051
3796
3797 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3798
3799         iPad testers failing to launch processes
3800         https://bugs.webkit.org/show_bug.cgi?id=207401
3801         <rdar://problem/58184777>
3802
3803         Unreviewed infrastructure fix.
3804
3805         This is a speculative fix because I've had problems reproducing this error.
3806         The only time I managed to reproduce the problem was immediately after killing the 
3807         SimulatorTrampoline and CoreSimulator.xpc processes.
3808
3809         * BuildSlaveSupport/kill-old-processes:
3810         (main): Only kill Simulator.app, not all associated simulator processes.
3811
3812 2020-02-07  Jiewen Tan  <jiewen_tan@apple.com>
3813
3814         [WebAuthn] Report CTAP Client Pin Error to clients
3815         https://bugs.webkit.org/show_bug.cgi?id=205837
3816         <rdar://problem/58356872>
3817
3818         Reviewed by Brent Fulgham.
3819
3820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3821         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3822         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
3823         (TestWebKitAPI::TEST):
3824         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3825         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-invalid-error-retry.html: Added.
3826         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3827         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3828         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-invalid-error-retry.html: Added.
3829         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-blocked-error.html: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3830         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-invalid-error-retry.html: Added.
3831         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-invalid-error-retry.html: Added.
3832
3833 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3834
3835         run-safari Doesn't work with the latest Xcode version and iOS
3836         https://bugs.webkit.org/show_bug.cgi?id=207394
3837
3838         Reviewed by Ryosuke Niwa.
3839
3840         * Scripts/webkitdirs.pm:
3841         (iosSimulatorRuntime): Determine the runtime from valid runtimes.
3842         (findOrCreateSimulatorForIOSDevice): iPhone 5 is unsupported, remove code.
3843
3844 2020-02-07  Daniel Bates  <dabates@apple.com>
3845
3846         Legacy WebKit: Have linkedOnOrAfter() respect the NSDefault WebKitLinkedOnOrAfterEverything and opt DumpRenderTree in
3847         https://bugs.webkit.org/show_bug.cgi?id=207366
3848
3849         Reviewed by Brent Fulgham.
3850
3851         Enable default WebKitLinkedOnOrAfterEverything in DumpRenderTree just as we do in WebKitTestRunner.
3852         This lets me put test results for Mac and iOS Legacy WebKit in the same cross-platform directory
3853         as the actual test instead of under a platform-specific directory even when the tests' behavior
3854         depends on the link-time version of WebKit.
3855
3856         Note that testing of pre-linked behavior can still be accomplished by test writers by exposing settings
3857         and toggling them in a test.
3858
3859         * DumpRenderTree/mac/DumpRenderTree.mm:
3860         (setDefaultsToConsistentValuesForTesting):
3861
3862 2020-02-03  Sam Weinig  <weinig@apple.com>
3863
3864         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3865         https://bugs.webkit.org/show_bug.cgi?id=207155
3866
3867         Reviewed by Tim Horton.
3868
3869         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
3870         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
3871         also has a default value in PlatformEnable.h
3872
3873         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3874
3875 2020-02-07  Kate Cheney  <katherine_cheney@apple.com>
3876
3877         Update WebView category name to be more accurate
3878         https://bugs.webkit.org/show_bug.cgi?id=207334
3879         <rdar://problem/59224855>
3880
3881         Reviewed by Brent Fulgham.
3882
3883         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
3884         (TEST):
3885
3886 2020-02-07  Aakash Jain  <aakash_jain@apple.com>
3887
3888         [ews] add commit-queue build step to close the bug
3889         https://bugs.webkit.org/show_bug.cgi?id=207387
3890
3891         Reviewed by Jonathan Bedard.
3892
3893         * BuildSlaveSupport/ews-build/steps.py:
3894         (BugzillaMixin.close_bug): Method to close the bugzilla bug.
3895         (CloseBug): Build step to close bugzilla bug.
3896
3897 2020-02-05  Aakash Jain  <aakash_jain@apple.com>
3898
3899         [ews] add commit-queue build step to clear flags on patch
3900         https://bugs.webkit.org/show_bug.cgi?id=206536
3901
3902         Reviewed by Jonathan Bedard.
3903
3904         * BuildSlaveSupport/ews-build/steps.py:
3905         (BugzillaMixin): Class for common bugzilla related methods.
3906         (BugzillaMixin.get_bugzilla_api_key): Method to read bugzilla api key from file.
3907         (BugzillaMixin.remove_flags_on_patch): Method to remove flags on patch.
3908         (ValidatePatch):
3909         (RemoveFlagsOnPatch): Class to remove flags on patch.
3910         (RemoveFlagsOnPatch.start):
3911         (ValidatePatch._addToLog): Moved.
3912         (ValidatePatch.fetch_data_from_url): Moved.
3913         (ValidatePatch.get_patch_json): Moved.
3914         (ValidatePatch.get_bug_json): Moved.
3915         (ValidatePatch.get_bug_id_from_patch): Moved.
3916         (ValidatePatch._is_patch_obsolete): Moved.
3917         (ValidatePatch._is_patch_review_denied): Moved.
3918         (ValidatePatch._is_patch_cq_plus): Moved.
3919         (ValidatePatch._is_bug_closed): Moved.
3920
3921 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3922
3923         EWS should run resultsdbpy tests
3924         https://bugs.webkit.org/show_bug.cgi?id=201928
3925
3926         Reviewed by Aakash Jain.
3927
3928         * BuildSlaveSupport/ews-build/factories.py:
3929         (ServicesFactory.__init__): Add RunResultsdbpyTests.
3930         * BuildSlaveSupport/ews-build/factories_unittest.py:
3931         (TestTestsFactory.test_services_factory): Add RunResultsdbpyTests.
3932         * BuildSlaveSupport/ews-build/steps.py:
3933         (CheckPatchRelevance): resultsdbpy changes should trigger service tests.
3934         (RunResultsdbpyTests): Add step which runs resultsdbpy tests.
3935         * BuildSlaveSupport/ews-build/steps_unittest.py:
3936         (TestRunResultsdbpyTests):
3937         (TestRunResultsdbpyTests.setUp):
3938         (TestRunResultsdbpyTests.tearDown):
3939         (TestRunResultsdbpyTests.test_success):
3940         (TestRunResultsdbpyTests.test_failure):
3941
3942 2020-02-07  Jacob Uphoff  <jacob_uphoff@apple.com>
3943
3944         Adding myself to contributors.json
3945         
3946         Unreviewed
3947
3948         * Scripts/webkitpy/common/config/contributors.json:
3949
3950 2020-02-07  Jason Lawrence  <lawrence.j@apple.com>
3951
3952         Adding myself to contributors.json
3953         
3954         Unreviewed
3955
3956         * Scripts/webkitpy/common/config/contributors.json:
3957
3958 2020-02-07  Patrick Griffis  <pgriffis@igalia.com>
3959
3960         [GTK][WPE] Add same-site cookie support
3961         https://bugs.webkit.org/show_bug.cgi?id=204137
3962
3963         Reviewed by Carlos Garcia Campos.
3964
3965         Update libsoup to 2.69.90 in JHBuild.
3966
3967         * gtk/jhbuild.modules:
3968         * wpe/jhbuild.modules:
3969
3970 2020-02-07  Yusuke Suzuki  <ysuzuki@apple.com>
3971
3972         Unreviewed, revert 75% load-factor because of JetStream2/string-unpack-code-SP regression
3973         https://bugs.webkit.org/show_bug.cgi?id=207183
3974
3975         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3976         (TestWebKitAPI::testInitialCapacity):
3977
3978 2020-02-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3979
3980         WebPage::rangeForGranularityAtPoint always returns null in the case of CharacterGranularity
3981         https://bugs.webkit.org/show_bug.cgi?id=207350
3982         <rdar://problem/59239914>
3983
3984         Reviewed by Tim Horton.
3985
3986         Add a test to exercise the corner case in the SPI.
3987
3988         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3989         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm: Added.
3990
3991 2020-02-06  Jiewen Tan  <jiewen_tan@apple.com>
3992
3993         Adopt new SOAuthorizationOption constants
3994         https://bugs.webkit.org/show_bug.cgi?id=207186
3995         <rdar://problem/48909336>
3996
3997         Reviewed by Brent Fulgham.
3998
3999         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
4000         (checkAuthorizationOptions):
4001
4002 2020-02-06  Brady Eidson  <beidson@apple.com>
4003
4004         Cleanup and promote WKContentWorld and its clients in WKWebView.
4005         https://bugs.webkit.org/show_bug.cgi?id=207351
4006
4007         Reviewed by Alex Christensen.
4008
4009         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
4010         (TestWebKitAPI::TEST):
4011         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
4012         (TEST):
4013         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4014         (-[WKWebView objectByCallingAsyncFunction:withArguments:error:]):
4015
4016 2020-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
4017
4018         [Win][MiniBrowser] Accelerator keys don't work unless the main window is focused
4019         https://bugs.webkit.org/show_bug.cgi?id=207250
4020
4021         Reviewed by Alex Christensen.
4022
4023         MiniBrowser has shortcut keys, Ctrl-W to close window, Ctrl-R to
4024         reload. However, they don't work unless the main window is
4025         focused.
4026
4027         Ctrl-W should be processed differently. Ctrl-W should be handled
4028         without dispatching to WebKit, others should be handled only when
4029         WebKit didn't consume. So, this change split the accelerator table
4030         into two, one is for Ctrl-W, another is for other shortcut keys.
4031
4032         For Ctrl-W, key events are processed before dispatching to
4033         WebView. It is converted to IDM_CLOSE_WINDOW of WM_COMMAND, and
4034         dispatched to WebView. WebKit2 WebView bubbles up unhandled
4035         WM_COMMAND to the parent window. Then, IDM_CLOSE_WINDOW is handled
4036         in the main window's WndProc. However, it doesn't work for WebKit1
4037         because this change doesn't add the bubbling up code to WebKit1
4038         WebView.
4039
4040         For other shortcut keys, for example Ctrl-R, key events are
4041         dispatched to WebView without accelerator key translations. Then,
4042         WebKitBrowserWindow::didNotHandleKeyEvent is called back if they
4043         aren't consumed. didNotHandleKeyEvent posts the messasge to the
4044         main window. The message loop processed key events dispatched to
4045         the main window with another accelerator table. However, it
4046         doesn't work for WebKit1, because WebKit1 doesn't have a API
4047         equivalent to didNotHandleKeyEvent.
4048
4049         After switching the active window by pressing Alt-Tab and
4050         reactivating the main window, the main window got the focus. This
4051         was the reason shortcut keys worked only after reactivating the
4052         main window. But, this is not the desired behavior after this
4053         change because other shortcut keys don't work if the main window
4054         is focused. So. set the focus to the brower window when
4055         WM_ACTIVATE of the main window.
4056
4057         Shortcut keys Ctrl++ (zoom in) and Ctrl+- (zoom out) were
4058         effective only for keyboard numpad. Add VK_OEM_MINUS and
4059         VK_OEM_PLUS for them.
4060
4061         Add a shortcut key Ctrl-0 to reset page zoom scale to actual.
4062
4063         * MiniBrowser/win/MainWindow.cpp:
4064         (MainWindow::isInstance):
4065         (MainWindow::WndProc):
4066         * MiniBrowser/win/MainWindow.h:
4067         * MiniBrowser/win/MiniBrowserLib.rc: Add a new accelerator table
4068         IDR_ACCELERATORS_PRE for Ctrl-W.
4069         * MiniBrowser/win/MiniBrowserLibResource.h:
4070         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4071         (WebKitBrowserWindow::didNotHandleKeyEvent):
4072         * MiniBrowser/win/WinMain.cpp:
4073         (wWinMain):
4074
4075 2020-02-06  Jonathan Bedard  <jbedard@apple.com>
4076
4077         results.webkitorg: Dead CI links
4078         https://bugs.webkit.org/show_bug.cgi?id=207340
4079
4080         Reviewed by Alexey Proskuryakov.
4081
4082         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
4083         (Configuration.prototype.toParams): Version name and version number often duplicate the
4084         same information, exception version number is often more specific than is useful.
4085
4086 2020-02-06  Brent Fulgham  <bfulgham@apple.com>
4087
4088         Prevent navigating top level frames to Data URLs
4089         https://bugs.webkit.org/show_bug.cgi?id=206962
4090         <rdar://problem/56770676>
4091
4092         Reviewed by Youenn Fablet.
4093
4094         Revise test running code to allow data URL navigations by default, since they are so frequently
4095         used in testing. However, provide a flag to turn this off in tests so we can confirm proper
4096         function.
4097
4098         * DumpRenderTree/TestOptions.cpp:
4099         (TestOptions::TestOptions):
4100         * DumpRenderTree/TestOptions.h:
4101         * DumpRenderTree/mac/DumpRenderTree.mm:
4102         (setWebPreferencesForTestOptions):
4103         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4104         (DownloadAttributeDoesNotStartDownloads): Revise configuration to allow script navigation of the main frame to a Data URL.
4105         (StartDownloadWithDownloadAttribute): Ditto.
4106         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
4107         (WebViewWillPerformClientRedirect): Ditto.
4108         (WebViewDidCancelClientRedirect): Ditto.
4109         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4110         (NavigateToDataURLThenBack): Ditto.
4111         (ContentExtensionBlocksMainLoadThenReloadWithoutExtensions): Ditto.
4112         * WebKitTestRunner/TestController.cpp:
4113         (WTR::TestController::resetPreferencesToConsistentValues):
4114         (WTR::updateTestOptionsFromTestHeader):
4115         * WebKitTestRunner/TestOptions.h:
4116         (WTR::TestOptions::hasSameInitializationOptions const):
4117         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4118         (WTR::initializeWebViewConfiguration):
4119         (WTR::TestController::platformCreateWebView):
4120
4121 2020-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
4122
4123         [iOS] Provide a way to suppress software keyboards on WKWebView's WKContentView
4124         https://bugs.webkit.org/show_bug.cgi?id=207272
4125         <rdar://problem/59190828>
4126
4127         Reviewed by Tim Horton.
4128
4129         Add an API test to verify (through UIKeyboardImpl) that the software keyboard should be suppressed when setting
4130         -_setSuppressSoftwareKeyboard: on the web view. This involves making `-makeKeyWindow` "work" in the API testing
4131         environment on iOS, by swizzling out both `-[NSBundle bundleIdentifier]` and `-[UIApplication keyWindow]`.
4132
4133         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4134         (TestWebKitAPI::overrideBundleIdentifier):
4135         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4136         (setOverriddenApplicationKeyWindow):
4137         (applicationKeyWindowOverride):
4138         (-[TestWKWebViewHostWindow makeKeyWindow]):
4139         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4140         * TestWebKitAPI/ios/UIKitSPI.h:
4141
4142         Also move the `UIResponder (UIKitSPI)` category from the internal section to the SPI section; this is redundant
4143         when using the internal SDK to build, since these methods are already declared in UIResponder_Private.h.
4144
4145 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
4146
4147         [PlayStation] Build a shared JavaScriptCore
4148         https://bugs.webkit.org/show_bug.cgi?id=198446
4149
4150         Reviewed by Fujii Hironori.
4151
4152         Add TARGET_OBJECTS for bmalloc and WTF so TestWTF links.
4153
4154         * TestWebKitAPI/PlatformPlayStation.cmake:
4155
4156 2020-02-05  Stephan Szabo  <stephan.szabo@sony.com>
4157
4158         [WinCairo] Set up fonts for layout tests for test bot image
4159         https://bugs.webkit.org/show_bug.cgi?id=207223
4160
4161         Reviewed by Fujii Hironori.
4162
4163         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp:
4164           Implement activateFonts to load fonts for test
4165
4166 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
4167
4168         [PlayStation] Miscellaneous build fixes February 2020 edition
4169         https://bugs.webkit.org/show_bug.cgi?id=207312
4170
4171         Unreviewed build fix.
4172
4173         * TestWebKitAPI/PlatformWebView.h: Remove #elif guard and just use #else
4174
4175 2020-02-05  Yusuke Suzuki  <ysuzuki@apple.com>
4176
4177         [WTF] Try using 75% load factor for HashTable
4178         https://bugs.webkit.org/show_bug.cgi?id=207183
4179
4180         Reviewed by Mark Lam.
4181
4182         Fix load-factor assumption in existing tests.
4183
4184         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4185         (TestWebKitAPI::testInitialCapacity):
4186
4187 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
4188
4189         resulsdbpy: Fix unit tests
4190         https://bugs.webkit.org/show_bug.cgi?id=207304
4191
4192         Reviewed by Aakash Jain.
4193
4194         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
4195         (ConfigurationContextTest.test_partition_by_configuration): Add branch to testing table.
4196         (ConfigurationContextTest.test_partition_by_partial_configuration): Ditto.
4197         * resultsdbpy/resultsdbpy/model/failure_context_unittest.py:
4198         (FailureContextTest.test_failures): Sort test failures by uuid for a predictable order in testing.
4199         (FailureContextTest.test_unexpected_failures): Ditto.
4200         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
4201         (MockModelFactory.iterate_all_commits): Do not batch requests since this function has no way
4202         of knowing how expensive the callback may be.
4203
4204 2020-02-05  Chris Dumez  <cdumez@apple.com>
4205
4206         Unreviewed, another build fix after r255846
4207
4208         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
4209
4210 2020-02-05  Ryan Haddad  <ryanhaddad@apple.com>
4211
4212         Unreviewed infrastructure fix.
4213
4214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4215         (WebKitBuildbot): Delete entries for queues that have been removed from buildbot.
4216
4217 2020-02-05  Chris Dumez  <cdumez@apple.com>
4218
4219         Unreviewed build fix after r255846.
4220
4221         * TestWebKitAPI/cocoa/HTTPServer.h:
4222
4223 2020-02-05  Jiewen Tan  <jiewen_tan@apple.com>
4224
4225         Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide
4226         https://bugs.webkit.org/show_bug.cgi?id=207173
4227         <rdar://problem/55669065>
4228
4229         Reviewed by Brent Fulgham.
4230
4231         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
4232         (TestWebKitAPI::TEST):
4233         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4234         (-[TestWKWebView _setUpTestWindow:]):
4235         Make the TestWKWebViewHostWindow miniaturizable to enable the test.
4236
4237 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
4238
4239         results.webkit.org: Apply ttl to archive shards
4240         https://bugs.webkit.org/show_bug.cgi?id=207295
4241
4242         Rubber-stamped by Aakash Jain.
4243
4244         * resultsdbpy/resultsdbpy/model/archive_context.py:
4245         (ArchiveContext.ArchiveMetaDataByCommit): Use new table.
4246         (ArchiveContext.ArchiveChunks): Use new table.
4247         (ArchiveContext.register): Add ttl to archive shards.
4248
4249 2020-02-05  Alex Christensen  <achristensen@webkit.org>
4250
4251         Make WKWebView._negotiatedLegacyTLS accurate when loading main resouorce from network or cache
4252         https://bugs.webkit.org/show_bug.cgi?id=207207
4253
4254         Reviewed by Chris Dumez.
4255
4256         HTTPServer now supports HTTPS. Tell your friends!
4257
4258         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
4259         (testCertificate):
4260         (testIdentity):
4261         (credentialWithIdentity):
4262         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
4263         (TestWebKitAPI::webViewWithNavigationDelegate):
4264         (TestWebKitAPI::TEST):
4265         * TestWebKitAPI/cocoa/HTTPServer.h:
4266         * TestWebKitAPI/cocoa/HTTPServer.mm:
4267         (TestWebKitAPI::HTTPServer::HTTPServer):
4268         (TestWebKitAPI::HTTPServer::request const):
4269
4270 2020-02-05  Brady Eidson  <beidson@apple.com>
4271
4272         _WKDownload should expose the originating FrameInfo.
4273         <rdar://problem/58022576> and https://bugs.webkit.org/show_bug.cgi?id=207185
4274
4275         Reviewed by Geoff Garen.
4276
4277         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4278         (-[DownloadTestSchemeDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4279         (-[DownloadSecurityOriginDelegate _downloadDidStart:]):
4280         (loaded):
4281         * TestWebKitAPI/cocoa/HTTPServer.mm:
4282
4283 2020-02-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4284
4285         [GTK] Fix dependencies build
4286         https://bugs.webkit.org/show_bug.cgi?id=207273
4287
4288         Reviewed by Carlos Garcia Campos.
4289
4290         * gtk/jhbuild.modules: Bumped wpebackend-fdo version to 1.4.1 and
4291         added mesa as one of its deps. Added the xserver patch as well.
4292         * gtk/patches/xserver-gl-version.patch: Added.
4293
4294 2020-02-05  Chris Dumez  <cdumez@apple.com>
4295
4296         REGRESSION(r255595): page not closed after beforeunload handler returns true
4297         https://bugs.webkit.org/show_bug.cgi?id=207189
4298         <rdar://problem/59149593>
4299
4300         Reviewed by Youenn Fablet.
4301
4302         Add API test coverage for fix landed in r255677.
4303
4304         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
4305         (-[SlowBeforeUnloadPromptUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
4306         (TEST):
4307
4308 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
4309
4310         results.webkit.org should disable auto-capitalize over the search field
4311         https://bugs.webkit.org/show_bug.cgi?id=207240
4312         <rdar://problem/59053042>
4313
4314         Rubber-stamped by Aakash Jain.
4315
4316         * resultsdbpy/resultsdbpy/view/static/js/search.js:
4317
4318 2020-02-01  Darin Adler  <darin@apple.com>
4319
4320         Replace RGBA32 typedef with a class to improve type safety
4321         https://bugs.webkit.org/show_bug.cgi?id=206862
4322
4323         Reviewed by Sam Weinig.
4324
4325         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
4326         (TestWebKitAPI::TEST): Use the Color constructor instead of Color::createUnchecked.
4327
4328 2020-02-04  Darin Adler  <darin@apple.com>
4329
4330         Remove NSKeyedArchiverSPI.h now that WebKit only uses API
4331         https://bugs.webkit.org/show_bug.cgi?id=207203
4332
4333         Reviewed by Anders Carlsson.
4334
4335         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Removed
4336         include of NSKeyedArchiverSPI.h and call methods of NSKeyedArchiver directly.
4337         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm: Ditto.
4338         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Ditto.
4339         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Ditto.
4340
4341 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
4342
4343         results.webkit.org: Support Internal in run-javascriptcore-tests
4344         https://bugs.webkit.org/show_bug.cgi?id=204095
4345
4346         Rubber-stamped by Aakash Jain.
4347
4348         * Scripts/VCSUtils.pm:
4349         (gitBisectStartBranchForDirectory): Renamed from gitBisectStartBranch.
4350         (gitBranchForDirectory): Compute branch for directory.
4351         (gitBranch): Compute branch for the current git directory.
4352         (commitForDirectory): Add git support.
4353         (gitBisectStartBranch): Renamed to gitBisectStartBranchForDirectory.
4354         * Scripts/run-javascriptcore-tests:
4355         (uploadResults): Check for Internal repository.
4356
4357 2020-02-04  Alex Christensen  <achristensen@webkit.org>
4358
4359         REGRESSION: (r255611) [ Mac ] 3 lldb tests failing related to HashMap
4360         https://bugs.webkit.org/show_bug.cgi?id=207204
4361
4362         Reviewed by Simon Fraser.
4363
4364         Remove support for HashSet and HashMap until we are able to do the equivalent of reinterpret_cast<unsigned*>(pointer)[-1]
4365         in LLDB's python API.
4366
4367         * lldb/lldb_webkit_unittest.py:
4368         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
4369         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
4370         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
4371
4372 2020-02-04  Lauro Moura  <lmoura@igalia.com>
4373
4374         [EWS] Stop GTK/WPE build if jhbuild fails.
4375         https://bugs.webkit.org/show_bug.cgi?id=207220
4376
4377         Reviewed by Adrian Perez de Castro.
4378
4379         * BuildSlaveSupport/ews-build/steps.py:
4380         (InstallGtkDependencies): Halt on failure
4381         (InstallWpeDependencies): Ditto
4382
4383 2020-02-04  Alex Christensen  <achristensen@webkit.org>
4384
4385         Fix Mac CMake build
4386         https://bugs.webkit.org/show_bug.cgi?id=207231
4387
4388         * DumpRenderTree/PlatformMac.cmake:
4389         * MiniBrowser/mac/CMakeLists.txt:
4390         * MiniBrowser/mac/WK2BrowserWindowController.m:
4391         (-[WK2BrowserWindowController awakeFromNib]):
4392         * WebKitTestRunner/PlatformMac.cmake:
4393
4394 2020-02-04  Don Olmstead  <don.olmstead@sony.com>
4395
4396         [PlayStation] Enable TestWebKit
4397         https://bugs.webkit.org/show_bug.cgi?id=207211
4398
4399         Reviewed by Ross Kirsling.
4400
4401         Stub out PlayStation implementation of TestWebKit so it builds.
4402
4403         * TestWebKitAPI/PlatformPlayStation.cmake:
4404         * TestWebKitAPI/PlatformWebView.h: Simplify platform define
4405         * TestWebKitAPI/playstation/PlatformUtilitiesPlayStation.cpp: Added.
4406         (TestWebKitAPI::Util::createInjectedBundlePath):
4407         (TestWebKitAPI::Util::createURLForResource):
4408         (TestWebKitAPI::Util::URLForNonExistentResource):
4409         (TestWebKitAPI::Util::isKeyDown):
4410         * TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp: Added.
4411         (TestWebKitAPI::PlatformWebView::PlatformWebView):
4412         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
4413         (TestWebKitAPI::PlatformWebView::initialize):
4414         (TestWebKitAPI::PlatformWebView::page const):
4415         (TestWebKitAPI::PlatformWebView::resizeTo):
4416         (TestWebKitAPI::PlatformWebView::focus):
4417         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
4418         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
4419         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
4420         (TestWebKitAPI::PlatformWebView::simulateRightClick):
4421
4422 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
4423
4424         results.webkit.org: Support branches in run-javascriptcore-tests
4425         https://bugs.webkit.org/show_bug.cgi?id=204094
4426
4427         Rubber-stamped by Aakash Jain.
4428
4429         * Scripts/run-javascriptcore-tests:
4430         (uploadResults): Use webkitdirs function to generate commit information.
4431         * Scripts/VCSUtils.pm:
4432         (commitForDirectory): Generate commit information for SVN repository, including
4433         branch name.
4434
4435 2020-02-04  Matt Lewis  <jlewis3@apple.com>
4436
4437         Replace bot677 due to hardware failure
4438         https://bugs.webkit.org/show_bug.cgi?id=207224
4439
4440         Reviewed by Aakash Jain.