229339ffeff6dbb3f1af4fc4adcc8bb79ec88cd4
[WebKit.git] / Tools / ChangeLog
1 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Another unreviewed Chromium build fix.
4
5         * DumpRenderTree/chromium/LayoutTestController.cpp:
6         (LayoutTestController::pathToLocalResource):
7
8 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
9
10         Unreviewed Chromium build fix.
11
12         * DumpRenderTree/chromium/LayoutTestController.cpp:
13         (LayoutTestController::pathToLocalResource):
14
15 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
16
17         Reviewed by Darin Adler.
18
19         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
20         https://bugs.webkit.org/show_bug.cgi?id=52867
21
22         * DumpRenderTree/chromium/ImageDiff.cpp:
23         (Image::craeteFromStdin): Call adoptArrayPtr.
24
25 2011-02-06  James Kozianski  <koz@chromium.org>
26
27         Reviewed by Ojan Vafai.
28
29         Add classes for representing test outputs.
30         https://bugs.webkit.org/show_bug.cgi?id=52136
31
32         These classes will make it easier to write scripts that deal with test
33         outputs such as rebaselining and deduping scripts. The intent is that
34         eventually we will be have buildbot return TestOutputs for a
35         particular build which can be compared with TestOutputs derived from a
36         local LayoutTests directory.
37
38         * Scripts/webkitpy/common/net/testoutput.py: Added.
39         * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
40         * Scripts/webkitpy/common/net/testoutputset.py: Added.
41         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
42         * Scripts/webkitpy/common/system/zip_mock.py: Added.
43
44 2011-02-06  Robert Hogan  <robert@webkit.org>
45
46         Reviewed by Andreas Kling.
47
48         [Qt] Clear page's groupName even when not in DRT
49         https://bugs.webkit.org/show_bug.cgi?id=53874
50
51         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
52         (WebCore::DumpRenderTree::windowCloseRequested):
53
54 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
55
56         Reviewed by Andreas Kling.
57
58         [CMake] Add dependencies for Visual Studio projects
59         https://bugs.webkit.org/show_bug.cgi?id=53773
60
61         Add a WebKit dependecy to WinCELauncher, so CMake can 
62         generate the correct build order for the solution.
63
64         * CMakeListsWinCE.txt:
65
66 2011-02-06  Andreas Kling  <kling@webkit.org>
67
68         Reviewed by Antonio Gomes.
69
70         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
71         https://bugs.webkit.org/show_bug.cgi?id=53869
72
73         * MiniBrowser/qt/BrowserView.cpp:
74         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
75         * MiniBrowser/qt/BrowserWindow.cpp:
76         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
77         * MiniBrowser/qt/BrowserWindow.h:
78
79 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
80
81         Reviewed by Dan Bernstein.
82
83         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
84         https://bugs.webkit.org/show_bug.cgi?id=42690
85         <rdar://problem/8213851>
86
87         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
88         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
89         (WTR::InjectedBundlePage::willSendRequestForFrame):
90         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
91         (WTR::LayoutTestController::LayoutTestController):
92         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
93         (WTR::LayoutTestController::willSendRequestReturnsNull):
94         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
95
96 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
97
98         Unreviewed, rolling out r77720.
99         http://trac.webkit.org/changeset/77720
100         https://bugs.webkit.org/show_bug.cgi?id=53854
101
102         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
103         #webkit).
104
105         * Scripts/webkitpy/common/system/executive.py:
106
107 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
108
109         Unreviewed, rolling out r77725.
110         http://trac.webkit.org/changeset/77725
111         https://bugs.webkit.org/show_bug.cgi?id=53844
112
113         It broke Qt minimal build (Requested by Ossy_ on #webkit).
114
115         * QtTestBrowser/launcherwindow.cpp:
116         (LauncherWindow::createChrome):
117         * QtTestBrowser/launcherwindow.h:
118         (WindowOptions::WindowOptions):
119         * QtTestBrowser/main.cpp:
120         (LauncherApplication::handleUserOptions):
121
122 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
123
124         Reviewed by Adam Barth.
125
126         [GTK] plugins/plugin-document-back-forward.html fails
127         https://bugs.webkit.org/show_bug.cgi?id=53833
128
129         Add the new "alert on load" functionality for the Unix version of the
130         test plugin. This functionality was originally introduced in r77706.
131
132         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
133         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
134
135 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
136
137         Reviewed by Andreas Kling.
138
139         Local Storage settings can be enable/disable from "Develop" menu
140         https://bugs.webkit.org/show_bug.cgi?id=52296
141
142         * QtTestBrowser/launcherwindow.cpp:
143         (LauncherWindow::createChrome):
144         (LauncherWindow::toggleLocalStorage):
145         (LauncherWindow::toggleOfflineStorageDatabase):
146         (LauncherWindow::toggleOfflineWebApplicationCache):
147         (LauncherWindow::setOfflineStorageDefaultQuota):
148         * QtTestBrowser/launcherwindow.h:
149         (WindowOptions::WindowOptions):
150         * QtTestBrowser/main.cpp:
151         (LauncherApplication::handleUserOptions):
152
153 2011-02-04  Tony Chang  <tony@chromium.org>
154
155         Reviewed by Eric Seidel.
156
157         get test-webkitpy running on win32 python
158         https://bugs.webkit.org/show_bug.cgi?id=53822
159
160         The test harness crashes with a WindowsError because it can't find
161         'svn' when using subprocess.Popen.  This gets us past the error
162         so we can see the failing tests on the Chromium Win Release Tests
163         bot.
164
165         * Scripts/webkitpy/common/system/executive.py:
166
167 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
168
169         Reviewed by Gustavo Noronha Silva.
170
171         [GTK] fast/events/pagehide-timeout.html fails
172         https://bugs.webkit.org/show_bug.cgi?id=53771
173
174         Add knowledge of the document browser cache model the DRT. When resetting
175         WebKit settings to consistent values between tests, default to the document
176         browser cache model.
177
178         * DumpRenderTree/gtk/DumpRenderTree.cpp:
179         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
180         cache model between tests.
181         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
182         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
183         document browser cache model.
184
185 2011-02-04  Adam Barth  <abarth@webkit.org>
186
187         Reviewed by Eric Seidel.
188
189         PluginDocuments don't create widgets for plugins on back/forward
190         https://bugs.webkit.org/show_bug.cgi?id=53474
191
192         Teach the test plugin how to call alert on load.
193
194         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
195         (NPP_New):
196
197 2011-02-04  Adam Roben  <aroben@apple.com>
198
199         Add a test case for encode/decode of FormData/FormDataElement
200
201         If the fix made in r77401 is broken, this new test will crash.
202
203         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
204
205         Reviewed by Sam Weinig.
206
207         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
208         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
209
210         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
211         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
212         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
213         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
214         form, an return the session state data.
215         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
216         and restore it into another WKPage.
217
218         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
219
220         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
221         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
222         * TestWebKitAPI/win/copy-resources.cmd:
223         Added new files.
224
225 2011-02-04  Adam Roben  <aroben@apple.com>
226
227         Move code to run JavaScript tests into its own files
228
229         This will allow other tests to use this mechanism.
230
231         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
232         world
233
234         Reviewed by Sam Weinig.
235
236         * TestWebKitAPI/JavaScriptTest.cpp: Added.
237         * TestWebKitAPI/JavaScriptTest.h: Added.
238         Moved code here...
239
240         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
241
242         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
243         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
244         Added the new files.
245
246 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
247
248         Reviewed by Mihai Parparita.
249
250         merge test expectations for chromium, chromium-gpu. The
251         chromium-gpu port will no longer maintain its own
252         test expectations file.
253
254         Also add in a graphics_type() call on the port object to
255         determine what graphics type to use in the test configuration,
256         and log the configuration as a config setting.
257
258         https://bugs.webkit.org/show_bug.cgi?id=53562
259
260         * Scripts/webkitpy/layout_tests/port/base.py:
261         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
262         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
263         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
264
265 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
266
267         Reviewed by Pavel Feldman.
268
269         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
270         https://bugs.webkit.org/show_bug.cgi?id=53781
271
272         * Scripts/check-inspector-strings:
273
274 2011-02-04  Adam Roben  <aroben@apple.com>
275
276         Include the crashing function in the link to a crash log on Mac
277
278         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
279         function that crashed on Mac
280
281         Reviewed by David Kilzer.
282
283         * Scripts/old-run-webkit-tests:
284         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
285         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
286         the crash log.
287
288 2011-02-04  Adam Roben  <aroben@apple.com>
289
290         Link to Mac crash logs from results.html
291
292         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
293         results.html
294
295         Reviewed by David Kilzer.
296
297         * Scripts/old-run-webkit-tests:
298         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
299         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
300
301 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
302
303         Reviewed by Dan Bernstein.
304
305         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
306         https://bugs.webkit.org/show_bug.cgi?id=52897
307         <rdar://problem/8898294>
308
309         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
310         (WTR::InjectedBundlePage::InjectedBundlePage):
311         (WTR::InjectedBundlePage::willSendRequestForFrame):
312         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
313
314 2011-02-03  Ivan Krstić  <ike@apple.com>
315
316         Unreviewed.
317
318         Adding myself to committers.py.
319
320         * Scripts/webkitpy/common/config/committers.py:
321
322 2011-02-03  James Kozianski  <koz@chromium.org>
323
324         Reviewed by Dimitri Glazkov.
325
326         Add navigator.registerProtocolHandler behind a flag.
327         https://bugs.webkit.org/show_bug.cgi?id=52609
328
329         * Scripts/build-webkit:
330
331 2011-02-03  Hayato Ito  <hayato@chromium.org>
332
333         Reviewed by Eric Seidel.
334
335         [NRWT] Remove TestArgs class, which is wrongly used.
336
337         https://bugs.webkit.org/show_bug.cgi?id=53063
338
339         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
340         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
341         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
342         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
343         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
344         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
345
346 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
347
348         Reviewed by Kenneth Russell.
349
350         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
351         https://bugs.webkit.org/show_bug.cgi?id=53714
352
353         * Scripts/build-webkit: change --3d-canvas build option
354           to set ENABLE_WEBGL
355
356 2011-02-03  Hayato Ito  <hayato@chromium.org>
357
358         Reviewed by Tony Chang.
359
360         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
361         move _run_single_test() and _process_output() functions from
362         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
363
364         This is clean up and acts as a preparation for elimination of test_types/*
365         classes. These classes will move to the single_test_runner module introduced
366         in this patch.
367
368         https://bugs.webkit.org/show_bug.cgi?id=53004
369
370         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
371         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
372         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
373         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
374         * Scripts/webkitpy/layout_tests/port/base.py:
375         * Scripts/webkitpy/layout_tests/port/chromium.py:
376         * Scripts/webkitpy/layout_tests/port/dryrun.py:
377         * Scripts/webkitpy/layout_tests/port/test.py:
378         * Scripts/webkitpy/layout_tests/port/webkit.py:
379         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
380         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
381         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
382
383 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
384
385         Unreviewed, build fix.
386
387         Delete a line that was accidentally missed in r77586; without it
388         there is still a race between the two threads.
389
390         https://bugs.webkit.org/show_bug.cgi?id=51572
391
392         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
393
394 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
395
396         Reviewed by Tony Chang.
397
398         nrwt: handle "broken pipe" notifications from DRT more cleanly.
399
400         https://bugs.webkit.org/show_bug.cgi?id=52927
401
402         * Scripts/webkitpy/layout_tests/port/server_process.py:
403         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
404
405 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
406
407         Reviewed by Kenneth Russell.
408
409         Update, resubmit change to bug 51572. I think the race that was
410         fixed in r76703 caused the hang that caused us to roll this
411         patch out before, so I'd like to try again.
412
413         https://bugs.webkit.org/show_bug.cgi?id=51572
414
415         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
416         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
417
418 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
419
420         Unreviewed.
421
422         Adding myself to committers.py.
423
424         * Scripts/webkitpy/common/config/committers.py:
425
426 2011-02-03  Adam Roben  <aroben@apple.com>
427
428         Include the crashing function in the link to a crash log
429
430         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
431         function that crashed
432
433         Reviewed by David Kilzer.
434
435         * Scripts/old-run-webkit-tests:
436         (crashLocation): Added. Returns the location of the crash.
437         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
438         could be determined.
439
440 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
441
442         Unreviewed, build fix.
443
444         Actually make the changes suggested by Mihai in his review
445         of bug 53720 :(
446
447         https://bugs.webkit.org/show_bug.cgi?id=53720
448
449         * Scripts/webkitpy/layout_tests/port/test_files.py:
450         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
451
452 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
453
454         Reviewed by Mihai Parparita.
455
456         new-run-webkit-tests: Fix bug introduced in r77434 that was
457         causing us to run the canvas GPU tests on the Mac GPU port. This
458         bug revealed that we were not setting the port.name() field
459         properly in many cases, so I've cleaned up all of that code, and
460         removed a few comments about "version-specific" GPU ports that
461         don't exist and just confused things.
462
463         Testing also revealed that port.abspath_for_test() wasn't
464         normalizing paths on Windows properly, so I fixed that as well.
465
466         https://bugs.webkit.org/show_bug.cgi?id=53719
467
468         * Scripts/webkitpy/layout_tests/port/base.py:
469         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
470         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
471
472 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
473
474         Reviewed by Mihai Parparita.
475
476         new-run-webkit-tests: fix normalization of paths on windows when gathering files
477
478         r77434 introduced a bug that was causing the test expectations
479         for the GPU ports to not be treated properly. It turns out that
480         when we gathered the list of test files on Windows, we would
481         return paths of the form "c:\LayoutTests/fast/canvas", and the
482         mixture of backslashes and forward slashes was confusing things.
483
484         This patch normalizes all of the filenames returned from
485         test_files.find(), and adds better tests for this (fixing a
486         couple of other bugs found in the meantime).
487
488         https://bugs.webkit.org/show_bug.cgi?id=53720
489
490         * Scripts/webkitpy/layout_tests/port/test.py:
491         * Scripts/webkitpy/layout_tests/port/test_files.py:
492         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
493
494 2011-02-03  Adam Roben  <aroben@apple.com>
495
496         Add links to Windows crash logs in results.html
497
498         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
499         results.html
500
501         Reviewed by David Kilzer.
502
503         * Scripts/old-run-webkit-tests:
504         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
505         createDebuggerCommandFile).
506         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
507         tool has exited.
508         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
509         it into the test results directory tree. Only implemented for Cygwin currently.
510         (findNewestFileMatchingGlob): Added. Does what it says.
511         (htmlForResultsSection): Only link to files that exist.
512         (linksForErrorTest): Add a link to the crash log.
513         (deleteExpectedAndActualResults): Delete any old crash log for this test.
514         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
515         hardcoding it here.
516
517 2011-02-03  Adam Roben  <aroben@apple.com>
518
519         Tell the debugger the path to the WebKit source tree when saving a crash log
520
521         This allows the debugger to include the crashing line of code in the log.
522
523         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
524         of code
525
526         Reviewed by Sam Weinig.
527
528         * Scripts/old-run-webkit-tests:
529         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
530         file and returns the path to that file. The commands we pass came from
531         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
532         WebKit source code lives.
533         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
534         line using -c, save them to a file and specify the path to that file using -cf. This works
535         around what is presumably a bug in Windows's command line parsing, where having multiple
536         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
537         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
538         together to make them easier to modify in the future.
539
540 2011-02-02  Sam Weinig  <sam@webkit.org>
541
542         Reviewed by Anders Carlsson.
543
544         Add notification of the end of a rubber band.
545         <rdar://problem/8940648>
546
547         * MiniBrowser/mac/BrowserWindowController.m:
548         (-[BrowserWindowController awakeFromNib]):
549         * WebKitTestRunner/TestController.cpp:
550         (WTR::TestController::createOtherPage):
551         (WTR::TestController::initialize):
552         Stub out the new WKUIClient function.
553
554 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
555
556         Unreviewed.
557
558         Adding myself to committers.py.
559
560         * Scripts/webkitpy/common/config/committers.py:
561
562 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
563
564         Reviewed by Csaba Osztrogonác.
565
566         [Qt][WK2] MiniBrowser's window size should be 800x600
567         https://bugs.webkit.org/show_bug.cgi?id=53670
568
569         Make layout test failure debugging easier.
570         * MiniBrowser/qt/BrowserWindow.cpp:
571         (BrowserWindow::BrowserWindow):
572
573 2011-02-02  Andy Estes  <aestes@apple.com>
574
575         Reviewed by Mark Rowe.
576
577         'update-webkit' should handle OpenSource and Internal using different
578         VCSs.
579
580         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
581         Internal directory.
582
583 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
584
585         Reviewed by Mihai Parparita.
586
587         new-run-webkit-tests: hardcode the directories to scan for tests
588         for GPU bots instead of SKIPping them. See bug 53562 for some
589         context, but we will now hard-code the list of directories to
590         use by default instead of skipping over directories in the
591         expectations file. We do this so that we will be able to merge
592         the expectations files without getting conflicting SKIP
593         directives. Note that this change will reduce the # of tests
594         being run on the Mac GPU bots, because we're accidentally
595         including some today.
596
597         https://bugs.webkit.org/show_bug.cgi?id=53631
598
599         * Scripts/webkitpy/layout_tests/port/base.py:
600         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
601         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
602
603 2011-02-02  Sam Weinig  <sam@webkit.org>
604
605         Reviewed by Beth Dakin.
606
607         Add ChromeClient function to paint custom overhang areas.
608         https://bugs.webkit.org/show_bug.cgi?id=53639
609
610         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
611         (WTR::InjectedBundlePage::InjectedBundlePage):
612         Stub out new callback.
613
614 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
615
616         Reviewed by Tony Chang.
617
618         new-run-webkit-tests: support chromium code paths in mock_drt
619
620         https://bugs.webkit.org/show_bug.cgi?id=53471
621
622         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
623         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
624
625 2011-02-02  Adam Klein  <adamk@chromium.org>
626
627         Reviewed by Tony Chang.
628
629         Update new-run-webkit-tests --chromium to put output under Source/...
630         https://bugs.webkit.org/show_bug.cgi?id=53612
631
632         * BuildSlaveSupport/test-result-archive:
633         * Scripts/webkitpy/layout_tests/port/chromium.py:
634
635 2011-01-28  Tony Chang  <tony@chromium.org>
636
637         Reviewed by Eric Seidel.
638
639         [chromium] remove --use-test-shell from NRWT
640         https://bugs.webkit.org/show_bug.cgi?id=53346
641
642         I've already started removing some of the bindings like eventSender so
643         this already doesn't work isn't useful.  Also updated some comments to
644         refer to DRT instead of test_shell.
645
646         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
647         * Scripts/webkitpy/layout_tests/port/chromium.py:
648         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
649         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
650         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
651         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
652         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
653         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
654
655 2011-02-02  Steve Lacey  <sjl@chromium.org>
656
657         Reviewed by Eric Carlson.
658
659         Implement basic media statistics on media elements.
660         https://bugs.webkit.org/show_bug.cgi?id=53322
661
662         * Scripts/build-webkit:
663
664 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
665
666         [wx] Build fixes for wxWebKit.
667
668         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
669         (LayoutTestController::setSerializeHTTPLoads):
670         * wx/browser/wscript:
671         * wx/build/build_utils.py:
672         * wx/build/settings.py:
673
674 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
675
676         Reviewed by Mihai Parparita.
677
678         new-run-webkit-tests: stop skipping so many tests
679
680         r77163 introduced a regression where we weren't resetting test
681         expectations properly and were skipping too many tests as a
682         result. This patch fixes that and adds a test for it.
683
684         https://bugs.webkit.org/show_bug.cgi?id=53551
685
686         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
687         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
688
689 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
690
691         Reviewed by Tony Chang.
692
693         new-run-webkit-tests: add first stub of test_runner2. This
694         will add support for the 'inline', 'threads', and 'processes'
695         flags to --worker-model, but for now the implementatios just
696         fall back on the old ones.
697
698         https://bugs.webkit.org/show_bug.cgi?id=53157
699
700         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
701         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
702
703 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
704
705         Reviewed by James Robinson.
706
707         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
708         https://bugs.webkit.org/show_bug.cgi?id=53522
709
710         * Scripts/run-chromium-webkit-unit-tests:
711
712 2011-02-01  Adam Barth  <abarth@webkit.org>
713
714         Reviewed by Mihai Parparita.
715
716         Using Control-C to cancel webkit-patch or other python tools causes
717         unpleasant traceback console spew
718         https://bugs.webkit.org/show_bug.cgi?id=53462
719
720         Catch the exception and don't print the stack trace.
721
722         * Scripts/webkit-patch:
723
724 2011-02-01  Scott Cameron  <sccameron@rim.com>
725
726         Reviewed by Daniel Bates.
727
728         Use Windows format for MinGW HTTPD path.
729         https://bugs.webkit.org/show_bug.cgi?id=53503
730
731         * Scripts/webkitperl/httpd.pm:
732           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
733             so that we don't have to escape the space characters in the path. Also,
734             changed path to Windows-style path and removed FIXME comment.
735
736 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
737
738         Reviewed by Andreas Kling.
739
740         [Qt][WK2] Add a way to use shared process model in MiniBrowser
741         https://bugs.webkit.org/show_bug.cgi?id=53090
742
743         * MiniBrowser/qt/BrowserView.cpp:
744         (BrowserView::BrowserView): Removed the m_context member.
745         From now the context is guaranteed to be non-null and we
746         don't need to store that in the object.
747         * MiniBrowser/qt/BrowserView.h:
748         * MiniBrowser/qt/BrowserWindow.cpp:
749         Added static bool to determine that new windows need to be
750         created with their own context or not. Use the same context
751         and web process by default to be inilne with the other ports.
752         (BrowserWindow::BrowserWindow):
753         (BrowserWindow::newWindow):
754         * MiniBrowser/qt/BrowserWindow.h:
755         * MiniBrowser/qt/main.cpp:
756         (main): Added command line switch to be able to use the
757         non-shared process model. Simplify the handling of the command line
758         switches a little bit.
759
760 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
761
762         Reviewed by Andreas Kling.
763
764         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
765         https://bugs.webkit.org/show_bug.cgi?id=53491
766
767         * MiniBrowser/qt/BrowserWindow.cpp:
768         (BrowserWindow::BrowserWindow):
769         (BrowserWindow::toggleFullScreenMode):
770         * MiniBrowser/qt/BrowserWindow.h:
771
772 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
773
774         Reviewed by Andreas Kling.
775
776         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
777         https://bugs.webkit.org/show_bug.cgi?id=53489
778
779         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
780         to Settings menu.
781
782         * MiniBrowser/qt/BrowserWindow.cpp:
783         (BrowserWindow::BrowserWindow):
784         (BrowserWindow::toggleFrameFlattening):
785         (BrowserWindow::toggleDisableJavaScript):
786         (BrowserWindow::toggleAutoLoadImages):
787         * MiniBrowser/qt/BrowserWindow.h:
788
789 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
790
791         Reviewed by Tony Chang.
792
793         [Chromium] Switch chromium-mac to use ChromiumDriver
794         https://bugs.webkit.org/show_bug.cgi?id=53461
795         
796         For the sake of consistency with the other Chromium platforms (and so
797         that chromium-mac picks up special flags like --enable-hardware-gpu),
798         switch chromium-mac from the WebKitDriver to ChromiumDriver.
799
800         * Scripts/webkitpy/layout_tests/port/chromium.py:
801
802 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
803
804         Reviewed by Mihai Parparita.
805
806         The current modifier parsing code in test_expectations is
807         fragile and hard-coded, so it's not easy to understand the logic
808         or easily add new types of modifiers (like GPU vs. CPU testing
809         for graphics tests, or 32-bit vs. 64-bit differences).
810
811         This is the first of two patches that will add in more generic
812         support and then eliminate the GPU-specific test expectations
813         files for Chromium.
814
815         This patch adds two standalone objects for handling modifiers. The
816         rules for interpreting modifiers, precedence, and conflicts are
817         given in the docstring to the ModifierMatcher class, which
818         returns ModifierMatchResult objects.
819         
820         This patch also adds routines to the Port interface and a
821         default set of values in the base object, in order to obtain the
822         values needed on a given test run. These values are then passed
823         to the expectation parser. This also allows us to clean up the
824         logic used to lint all of the different configurations in a
825         single test_expectations.txt file.
826
827         The next patch will merge in the separate GPU expectations file.
828
829         https://bugs.webkit.org/show_bug.cgi?id=51222
830
831         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
832         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
833         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
834         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
835         * Scripts/webkitpy/layout_tests/port/base.py:
836         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
837         * Scripts/webkitpy/layout_tests/port/chromium.py:
838         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
839         * Scripts/webkitpy/layout_tests/port/test.py:
840         * Scripts/webkitpy/layout_tests/port/webkit.py:
841         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
842         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
843         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
844         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
845         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
846
847 2011-01-31  Scott Cameron  <sccameron@rim.com>
848
849         Reviewed by Daniel Bates.
850
851         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
852         https://bugs.webkit.org/show_bug.cgi?id=50036
853
854         This will add an Apache2.2 configuration file and modifies scripts to allow
855         running an httpd server in an MSYS environment.
856
857         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
858         in order to allow for simple installation/execution.  Simply install the latest
859         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
860         be able to execute run-webkit-httpd.
861         
862
863         * Scripts/run-webkit-httpd:
864         * Scripts/webkitperl/httpd.pm:
865
866 2011-01-31  Tony Chang  <tony@chromium.org>
867
868         Reviewed by Eric Seidel.
869
870         mac DRT should report RTL scroll offset relative to top right corner
871         https://bugs.webkit.org/show_bug.cgi?id=53324
872
873         * DumpRenderTree/mac/DumpRenderTree.mm:
874         (dumpFrameScrollPosition):
875
876 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
877
878         Reviewed by Andreas Kling.
879
880         [Qt] Add Take Screen Shot action to MiniBrowser
881         https://bugs.webkit.org/show_bug.cgi?id=53422
882
883         Add Take Screen Shot action to MiniBrowser's view menu.
884
885         * MiniBrowser/qt/BrowserWindow.cpp:
886         (BrowserWindow::BrowserWindow):
887         (BrowserWindow::screenshot):
888         * MiniBrowser/qt/BrowserWindow.h:
889
890 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
891
892         Reviewed by Xan Lopez.
893
894         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
895         https://bugs.webkit.org/show_bug.cgi?id=53379
896
897         Remove left over #ifdef's. I thought all of the conditional code
898         had been freed from the condition, but I forgot to check DRT.
899
900         * DumpRenderTree/gtk/DumpRenderTree.cpp:
901         (resetDefaultsToConsistentValues):
902         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
903         (LayoutTestController::setAlwaysAcceptCookies):
904
905 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
906
907         Unreviewed, build fix.
908
909         Fix regression introduced in r77093 - path.rsplit() doesn't
910         take keyword arguments.
911
912         https://bugs.webkit.org/show_bug.cgi?id=53326
913
914         * Scripts/webkitpy/common/system/filesystem_mock.py:
915
916 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
917
918         Reviewed by Mihai Parparita.
919
920         Add more unit tests for rebaseline-chromium-webkit-tests. This
921         change involves restructuring a bunch of r-c-w-t code to make it
922         more testable as well. We also add wrapper classes for handling
923         testing zip files and fetching URLs.
924
925         https://bugs.webkit.org/show_bug.cgi?id=53040
926
927         * Scripts/webkitpy/common/system/urlfetcher.py:
928         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
929         * Scripts/webkitpy/common/system/zipfileset_mock.py:
930         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
931         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
932         * Scripts/webkitpy/tool/mocktool.py:
933
934 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
935
936         Reviewed by Eric Seidel.
937
938         Clean up of the filesystem-related modules used in webkitpy.
939         I've added relpath() to the filesystem interface, modified
940         ospath.relpath() so that it could work with the filesystem
941         interface, and modified the fileset* routines to use the
942         filesystem interface consistently.
943
944         This patch also adds a close() routine to the fileset routines
945         to indicate that the caller is done with the fileset. This
946         allows zipfileset to clean up after itself when it creates
947         tempfiles to store downloads.
948
949         https://bugs.webkit.org/show_bug.cgi?id=53326
950
951         * Scripts/webkitpy/common/system/directoryfileset.py:
952         * Scripts/webkitpy/common/system/fileset.py:
953         * Scripts/webkitpy/common/system/filesystem.py:
954         * Scripts/webkitpy/common/system/filesystem_mock.py:
955         * Scripts/webkitpy/common/system/filesystem_unittest.py:
956         * Scripts/webkitpy/common/system/ospath.py:
957         * Scripts/webkitpy/common/system/zipfileset.py:
958         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
959
960 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
961
962         Reviewed by Csaba Osztrogonác.
963
964         [Qt][WK2]REGRESSION (r76991): Fix build errors
965         https://bugs.webkit.org/show_bug.cgi?id=53400
966
967         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
968         and remove WebKit2Prefix.h from the build.
969         * MiniBrowser/qt/MiniBrowser.pro:
970
971 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
972
973         Unreviewed.
974
975         [Qt][WK2] Buildfix.
976
977         * MiniBrowser/qt/MiniBrowser.pro:
978
979 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
980
981         Reviewed by Adam Roben.
982         
983         define NOMINMAX when building ImageDiff, as we do elsewhere.
984
985         Add various clampToInt() methods to MathExtras.h
986         https://bugs.webkit.org/show_bug.cgi?id=52910
987
988         * DumpRenderTree/win/ImageDiffCommon.vsprops:
989
990 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
991
992         Reviewed by Darin Adler.
993
994         WebKitTestRunner needs layoutTestController.setPOSIXLocale
995         https://bugs.webkit.org/show_bug.cgi?id=42682
996
997         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
998         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
999         (WTR::InjectedBundle::resetLocalSettings):
1000         (WTR::InjectedBundle::didReceiveMessage):
1001         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1002         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1003         (WTR::LayoutTestController::setPOSIXLocale):
1004         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1005
1006 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1007  
1008          Reviewed by Mihai Parparita.
1009  
1010          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
1011  
1012          This patch re-enables this test and changes it to
1013          handle all of the mac platform versions, not just the one
1014          it is running on.
1015  
1016          https://bugs.webkit.org/show_bug.cgi?id=53356
1017  
1018          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1019  
1020 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1021
1022         Unreviewed, build fix.
1023
1024         Take two. The fix in 77023 didn't work, because we were
1025         still calling path.abspath_to_uri, which calls _cygpath under
1026         the covers, and it appears the cygpath on the bots does
1027         something different than it does on my machine. This patch
1028         removes the calls to path.abspath_to_uri, so it should be safe.
1029         If it doesn't work, I'll roll it out along with r76982 and 77023.
1030
1031         https://bugs.webkit.org/show_bug.cgi?id=53126
1032
1033         * Scripts/webkitpy/layout_tests/port/test.py:
1034
1035 2011-01-28  David Kilzer  <ddkilzer@apple.com>
1036
1037         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
1038         <http://webkit.org/b/53353>
1039
1040         Reviewed by Mark Rowe.
1041
1042         * Scripts/webkitdirs.pm:
1043         (checkRequiredSystemConfig): Check the Xcode marketing version
1044         in addition to the DevCoreTools build version before complaining
1045         about an old version of Xcode.  Also make the Mac OS X version
1046         check use Perl's built-in version string comparitor.
1047
1048 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1049
1050         Unreviewed, build fix.
1051
1052         Work around breakage on Win 7 Release bot caused by r76982
1053         and the fact that windows ports use "file:////" instead of
1054         "file:///". Ideally the test code should be isolated from
1055         this, but it isn't yet. Will fix properly in a bit.
1056
1057         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1058
1059 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1060
1061         Reviewed by Tony Chang.
1062
1063         new-run-webkit-tests: change worker model values to
1064         "old-inline", "old-threads" in preparation for test_runner2 /
1065         multiprocessing changes.
1066
1067         https://bugs.webkit.org/show_bug.cgi?id=53156
1068
1069         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1070         * Scripts/webkitpy/layout_tests/port/base.py:
1071         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1072         * Scripts/webkitpy/layout_tests/port/mac.py:
1073         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1074
1075 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1076
1077         Reviewed by Tony Chang.
1078
1079         committers.py - add an IRC nickname for dpranke
1080         https://bugs.webkit.org/show_bug.cgi?id=53335
1081
1082         * Scripts/webkitpy/common/config/committers.py:
1083
1084 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1085
1086         Reviewed by Tony Chang.
1087
1088         new-run-webkit-tests: add a "mock DRT" port implementation
1089         and a separate class that emulates what we expect the
1090         DumpRenderTree behavior to be.
1091
1092         This will eventually replace port/dryrun.py and allow us to get
1093         better test coverage of the new-run-webkit-tests code as well as
1094         a reference for what new-run-webkit-tests expects from DRT.
1095
1096         This is the first attempt at this, and it is pretty bare-boned. It
1097         really only has been tested on the 'mac' port (and a little on
1098         the 'chromium-mac' port.
1099
1100         https://bugs.webkit.org/show_bug.cgi?id=53126
1101
1102         * Scripts/webkitpy/common/system/filesystem_mock.py:
1103         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1104         * Scripts/webkitpy/layout_tests/port/factory.py:
1105         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1106         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1107         * Scripts/webkitpy/layout_tests/port/test.py:
1108
1109 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1110
1111         Unreviewed. Removing .swp file checked in by mistake.
1112
1113         * Scripts/.webkitdirs.pm.swp: Removed.
1114
1115 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1116
1117         Reviewed by David Kilzer.
1118
1119         Space not necessary for undefined feature
1120         https://bugs.webkit.org/show_bug.cgi?id=53317
1121
1122         * Scripts/build-webkit:
1123
1124 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1125
1126         Reviewed by Andreas Kling.
1127
1128         Reset NetworkAccessManager to clean up credentials from previous tests.
1129         This change causes no performance overhead either.
1130         https://bugs.webkit.org/show_bug.cgi?id=36688
1131
1132         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1133         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1134         (WebCore::DumpRenderTree::open):
1135         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1136
1137 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1138
1139         Reviewed by Andreas Kling.
1140
1141         [Qt] Add Zoom Text Only action to MiniBrowser
1142         https://bugs.webkit.org/show_bug.cgi?id=53297
1143
1144         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1145
1146         * MiniBrowser/qt/BrowserWindow.cpp:
1147         (BrowserWindow::BrowserWindow):
1148         (BrowserWindow::zoomIn):
1149         (BrowserWindow::zoomOut):
1150         (BrowserWindow::resetZoom):
1151         (BrowserWindow::toggleZoomTextOnly):
1152         (BrowserWindow::applyZoom):
1153         * MiniBrowser/qt/BrowserWindow.h:
1154
1155 2011-01-28  Adam Barth  <abarth@webkit.org>
1156
1157         Reviewed by Eric Seidel.
1158
1159         Add webkit-patch roll-chromium-deps
1160         https://bugs.webkit.org/show_bug.cgi?id=53288
1161
1162         This command updates the Source/WebKit/chromium/DEPS file with the
1163         last-known good revision of Chromium (or a revision specified on the
1164         command line).  I'd eventually like to turn this into a SheriffBot
1165         command, but this is the first step.
1166
1167         This patch somewhat sprawled because I needed to move a bunch of code
1168         out of ChangeLog that should never have been there in the first place.
1169         Also, I had to fix a bug in MockUser in order to test the new command.
1170
1171         * Scripts/webkitpy/common/checkout/api.py:
1172         * Scripts/webkitpy/common/checkout/changelog.py:
1173         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1174         * Scripts/webkitpy/common/checkout/deps.py: Added.
1175         * Scripts/webkitpy/common/config/urls.py:
1176         * Scripts/webkitpy/tool/commands/__init__.py:
1177         * Scripts/webkitpy/tool/commands/download_unittest.py:
1178         * Scripts/webkitpy/tool/commands/roll.py: Added.
1179         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1180         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1181         * Scripts/webkitpy/tool/mocktool.py:
1182         * Scripts/webkitpy/tool/steps/__init__.py:
1183         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1184         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1185         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1186         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1187         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1188         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1189
1190 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1191
1192         Reviewed by Laszlo Gombos.
1193
1194         Get rid of prefix header dependency for WebKit2 build system
1195         https://bugs.webkit.org/show_bug.cgi?id=50174
1196
1197         Change the style checker so that it enforces config.h include for
1198         WebKit2.
1199
1200         * Scripts/webkitpy/style/checker.py:
1201
1202 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1203
1204         Reviewed by Darin Adler.
1205
1206         execCommand("Paste") doesn't work in WebKitTestRunner
1207         https://bugs.webkit.org/show_bug.cgi?id=52785
1208
1209         Enable both of the settings needed to allow paste.
1210         
1211         * WebKitTestRunner/TestController.cpp:
1212         (WTR::TestController::resetStateToConsistentValues):
1213
1214 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1215
1216         Reviewed by Andreas Kling.
1217
1218         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1219         https://bugs.webkit.org/show_bug.cgi?id=48440
1220
1221         Preserve user input when toggling use of QGraphicsView
1222
1223         * QtTestBrowser/launcherwindow.cpp:
1224         (LauncherWindow::initializeView):
1225         (LauncherWindow::loadFinished):
1226         * QtTestBrowser/launcherwindow.h:
1227         * QtTestBrowser/mainwindow.cpp:
1228         (MainWindow::addressUrl):
1229         * QtTestBrowser/mainwindow.h:
1230
1231 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1232
1233         Reviewed by Mihai Parparita.
1234
1235         new-run-webkit-tests: turn off pixel tests correctly by default
1236         for webkit-based ports. r70013 (bug 47510) used
1237         port.set_option_default() to attempt to set default values, but
1238         that didn't work correctly. I have removed set_option_default
1239         for now since it was only being used in two places and in three
1240         useless unit tests. There is a separate bug open to fix the
1241         option parsing (48095), so this workaround is fine for now.
1242
1243         https://bugs.webkit.org/show_bug.cgi?id=53217
1244
1245         * Scripts/webkitpy/layout_tests/port/webkit.py:
1246         * Scripts/webkitpy/layout_tests/port/base.py:
1247         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1248
1249 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1250
1251         Rubber-stamped by Ariya Hidayat.
1252
1253         Trivial crash fix in WTR.
1254
1255         * WebKitTestRunner/TestController.cpp:
1256         (WTR::TestController::initialize): Increase the size
1257         of the vector by one to be able to store the null character.
1258
1259 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1260
1261         Reviewed by Csaba Osztrogonác.
1262
1263         [Qt][WK2] WTR should be initialized in the same way as DRT
1264         https://bugs.webkit.org/show_bug.cgi?id=53240
1265
1266         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1267         (WTR::activateFonts): Added missing initialization steps.
1268
1269 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1270
1271         Unreviewed. 
1272
1273         Adding myself to committers.py.
1274
1275         * Scripts/webkitpy/common/config/committers.py:
1276
1277 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1278
1279         Reviewed by Csaba Osztrogonác.
1280
1281         [Qt] [Symbian] Move project files into Source
1282         https://bugs.webkit.org/show_bug.cgi?id=52891
1283
1284         Fix the Symbian build after the project files
1285         are moved to Source directory. On Symbian qmake
1286         needs to run in the same directory where the main
1287         pro files (WebKit.pro, Tools.pro) are located.
1288
1289         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1290         is located before running qmake for Symbian. Qmake on Symbian
1291         does not properly honor the "-o" option, work it around by setting
1292         the name of the Makefile to bld.inf.
1293
1294 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1295
1296         Reviewed by Andreas Kling.
1297
1298         [Qt] Add simple zooming features to MiniBrowser
1299         https://bugs.webkit.org/show_bug.cgi?id=53231
1300
1301         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1302
1303         * MiniBrowser/qt/BrowserWindow.cpp:
1304         (BrowserWindow::BrowserWindow):
1305         (BrowserWindow::zoomIn):
1306         (BrowserWindow::zoomOut):
1307         (BrowserWindow::resetZoom):
1308         (BrowserWindow::updateUserAgentList):
1309         (BrowserWindow::applyZoom):
1310         * MiniBrowser/qt/BrowserWindow.h:
1311
1312 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1313
1314         Reviewed by Dan Bernstein.
1315
1316         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1317         https://bugs.webkit.org/show_bug.cgi?id=42319
1318         
1319         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1320
1321         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1322         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1323         (WTR::LayoutTestController::showWebInspector):
1324         (WTR::LayoutTestController::closeWebInspector):
1325         (WTR::LayoutTestController::evaluateInWebInspector):
1326         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1327         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1328         * WebKitTestRunner/TestInvocation.cpp:
1329         (WTR::shouldOpenWebInspector):
1330         (WTR::TestInvocation::invoke):
1331         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1332
1333 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1334
1335         Reviewed by Xan Lopez.
1336
1337         [GTK] Pixel dumps do not include scrollbars in output images
1338         https://bugs.webkit.org/show_bug.cgi?id=53216
1339
1340         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1341         that have scrollbars.
1342
1343         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1344         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1345         instead of the web view itself.
1346
1347 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1348
1349         Reviewed by Mihai Parparita.
1350
1351         Fix regression introduced in r76322 ... new-run-webkit-tests
1352         was attempting to save the image diff output as a UTF-8-encoded
1353         file.
1354
1355         https://bugs.webkit.org/show_bug.cgi?id=53210
1356
1357         * Scripts/webkitpy/layout_tests/port/webkit.py:
1358
1359 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1360
1361         Unreviewed, rolling out r76709.
1362         http://trac.webkit.org/changeset/76709
1363         https://bugs.webkit.org/show_bug.cgi?id=53194
1364
1365         "broke python tests on non-snowleopard platforms" (Requested
1366         by dpranke on #webkit).
1367
1368         * Scripts/webkitpy/layout_tests/port/factory.py:
1369         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1370         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1371
1372 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1373
1374         Reviewed by Tony Chang.
1375
1376         new-run-webkit-tests: add a "mock DRT" port implementation
1377         and a separate class that emulates what we expect the
1378         DumpRenderTree behavior to be.
1379
1380         This will eventually replace port/dryrun.py and allow us to get
1381         better test coverage of the new-run-webkit-tests code as well as
1382         a reference for what new-run-webkit-tests expects from DRT.
1383
1384         This is the first attempt at this, and it is pretty bare-boned. It
1385         really only has been tested on the 'mac' port (and a little on
1386         the 'chromium-mac' port.
1387
1388         https://bugs.webkit.org/show_bug.cgi?id=53126
1389
1390         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1391         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1392         * Scripts/webkitpy/layout_tests/port/factory.py:
1393
1394 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1395
1396         Reviewed by Tony Chang.
1397
1398         Add '--no-timeout' option to Chromium DRT to ease debugging.
1399         https://bugs.webkit.org/show_bug.cgi?id=52873
1400
1401         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1402         (main):
1403
1404 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1405
1406         Reviewed by Andreas Kling.
1407
1408         [Qt] Fix qt_minimal build
1409         https://bugs.webkit.org/show_bug.cgi?id=53172
1410
1411         * QtTestBrowser/locationedit.h:
1412
1413 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1414
1415         Reviewed by Antonio Gomes.
1416
1417         QtTestBrowser should have a UI Setting to disable plugins
1418         https://bugs.webkit.org/show_bug.cgi?id=52408
1419         
1420         Added a new action item named "Disable Plugins"
1421         under the "Settings" menu. 
1422
1423         * QtTestBrowser/launcherwindow.cpp:
1424         (LauncherWindow::createChrome):
1425         (LauncherWindow::togglePlugins):
1426         * QtTestBrowser/launcherwindow.h:
1427
1428 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1429
1430         Reviewed by Adam Barth.
1431
1432         Move main CMakeLists.txt into Source directory
1433         https://bugs.webkit.org/show_bug.cgi?id=52888
1434
1435         * Scripts/webkitdirs.pm:
1436
1437 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1438
1439         Reviewed by Eric Seidel.
1440
1441         Improve label text in submit-to-ews
1442         https://bugs.webkit.org/show_bug.cgi?id=53130
1443
1444         * QueueStatusServer/templates/submittoews.html:
1445
1446 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1447
1448         Reviewed by Antonio Gomes.
1449
1450         QtTestBrowser should have a UI Settings to prevent loading images
1451         https://bugs.webkit.org/show_bug.cgi?id=52409
1452         
1453         Added a new action item named "DisableAutoLoadImages"
1454         under the "Settings" menu 
1455
1456         * QtTestBrowser/launcherwindow.cpp:
1457         (LauncherWindow::createChrome):
1458         (LauncherWindow::toggleAutoLoadImages):
1459         * QtTestBrowser/launcherwindow.h:
1460
1461 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1462
1463         Reviewed by Tony Chang.
1464
1465         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1466         classes, test_expectations.py. This change adds "test-win" and
1467         "test-mac" variants to the test port so that we can better test
1468         rebaselining, and adds a MockUser() object for reuse in testing.
1469
1470         https://bugs.webkit.org/show_bug.cgi?id=53036
1471
1472         * Scripts/webkitpy/common/system/filesystem.py:
1473         * Scripts/webkitpy/common/system/filesystem_mock.py:
1474         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1475         * Scripts/webkitpy/layout_tests/port/factory.py:
1476         * Scripts/webkitpy/layout_tests/port/base.py:
1477         * Scripts/webkitpy/layout_tests/port/test.py:
1478         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1479         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1480         * Scripts/webkitpy/tool/mocktool.py:
1481
1482 2011-01-25  Tony Chang  <tony@chromium.org>
1483
1484         Reviewed by Dimitri Glazkov.
1485
1486         [chromium] remove unused layoutTestController callback
1487         https://bugs.webkit.org/show_bug.cgi?id=53103
1488
1489         This method is used by a test_shell_test, but not needed by DRT.
1490
1491         * DumpRenderTree/chromium/LayoutTestController.cpp:
1492         (LayoutTestController::LayoutTestController):
1493         * DumpRenderTree/chromium/LayoutTestController.h:
1494
1495 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1496
1497         Reviewed by Andreas Kling.
1498
1499         [GTK] Remove 64 bits release bot from the buildbot master
1500         https://bugs.webkit.org/show_bug.cgi?id=52899
1501
1502         Removes the 64 bits release slave from the buildbot configuration,
1503         so that we can use it as an EWS.
1504
1505         * BuildSlaveSupport/build.webkit.org-config/config.json:
1506
1507 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1508
1509         Reviewed by Dan Bernstein.
1510
1511         Implement database quota callback to fix storage tests on WebKit2 bot
1512         https://bugs.webkit.org/show_bug.cgi?id=53064
1513
1514         * WebKitTestRunner/TestController.cpp:
1515         (WTR::exceededDatabaseQuota):
1516         (WTR::TestController::createOtherPage):
1517         (WTR::TestController::initialize):
1518
1519 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1520
1521         Reviewed by Anders Carlsson.
1522
1523         Use designated temp directory for the database for WebKit2
1524         https://bugs.webkit.org/show_bug.cgi?id=53052
1525         
1526         Adopt the new WK2 API for this.
1527
1528         * WebKitTestRunner/TestController.cpp:
1529         (WTR::TestController::libraryPathForTesting):
1530         (WTR::TestController::initialize):
1531         * WebKitTestRunner/TestController.h:
1532         * WebKitTestRunner/mac/TestControllerMac.mm:
1533         (WTR::TestController::platformLibraryPathForTesting):
1534         * WebKitTestRunner/qt/TestControllerQt.cpp:
1535         (WTR::TestController::platformLibraryPathForTesting):
1536         * WebKitTestRunner/win/TestControllerWin.cpp:
1537         (WTR::TestController::platformLibraryPathForTesting):
1538
1539 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1540
1541         Reviewed by Stephanie Lewis.
1542
1543         Add a new Leopard test bot.
1544
1545         * BuildSlaveSupport/build.webkit.org-config/config.json:
1546
1547 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1548
1549         Reviewed by Adam Barth.
1550
1551         Add EFL Builder to core waterfall
1552         https://bugs.webkit.org/show_bug.cgi?id=52704
1553
1554         Add EFL Builder to the core waterfall again.
1555
1556         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1557         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1558
1559 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1560
1561         Reviewed by Tony Chang.
1562
1563         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1564         https://bugs.webkit.org/show_bug.cgi?id=52872
1565
1566         Force disabling proxy to resolve the problem.
1567
1568         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1569         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1570
1571 2011-01-24  Andreas Kling  <kling@webkit.org>
1572
1573         Reviewed by Darin Adler.
1574
1575         check-webkit-style: Update exemptions following Source/ move.
1576         https://bugs.webkit.org/show_bug.cgi?id=53017
1577
1578         * Scripts/webkitpy/style/checker.py:
1579         * Scripts/webkitpy/style/checker_unittest.py:
1580
1581 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1582
1583         Rubber-stamped by Csaba Osztrogonác.
1584
1585         [Qt] Move project files into Source
1586         https://bugs.webkit.org/show_bug.cgi?id=52891
1587
1588         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1589
1590 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1591
1592         Reviewed by Yury Semikhatsky.
1593
1594         Web Inspector: Find duplicate strings in localizedStrings.js
1595
1596         https://bugs.webkit.org/show_bug.cgi?id=53005
1597
1598         * Scripts/check-inspector-strings:
1599
1600 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1601
1602         Reviewed by Andreas Kling.
1603
1604         [Qt] Regroup MiniBrowser's menubar and add open file action
1605         https://bugs.webkit.org/show_bug.cgi?id=53000
1606
1607         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1608
1609         * MiniBrowser/qt/BrowserWindow.cpp:
1610         (BrowserWindow::BrowserWindow):
1611         (BrowserWindow::openFile):
1612         (BrowserWindow::~BrowserWindow):
1613         * MiniBrowser/qt/BrowserWindow.h:
1614
1615 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1616
1617         Unreviewed fix after r76496
1618
1619         [Qt] Move project files into Source
1620         https://bugs.webkit.org/show_bug.cgi?id=52891
1621
1622         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1623         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1624         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1625
1626 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1627
1628         Reviewed by Csaba Osztrogonác.
1629
1630         [Qt] Move project files into Source
1631         https://bugs.webkit.org/show_bug.cgi?id=52891
1632
1633         * DerivedSources.pro: Renamed from DerivedSources.pro.
1634         * DumpRenderTree/qt/DumpRenderTree.pro:
1635         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1636         * MiniBrowser/DerivedSources.pro:
1637         * MiniBrowser/qt/MiniBrowser.pro:
1638         * QtTestBrowser/QtTestBrowser.pro:
1639         * Scripts/webkitdirs.pm:
1640         * Tools.pro: Added.
1641         * WebKitTestRunner/DerivedSources.pro:
1642         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1643         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1644
1645 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1646
1647         Reviewed by Dan Bernstein.
1648
1649         Beefed up --threaded mode to catch even more kinds of errors.
1650         https://bugs.webkit.org/show_bug.cgi?id=52971
1651
1652         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1653         context group to force JSC to mark multiple threads. (This used to be
1654         the default, but it changed in SnowLeopard.)
1655         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1656         to give threading mistakes more chances to show themselves.
1657         (startJavaScriptThreads):
1658         (stopJavaScriptThreads):
1659
1660 2011-01-22  Robert Hogan  <robert@webkit.org>
1661
1662         Reviewed by Andreas Kling.
1663
1664         [Qt] Support layoutTestController.addURLToRedirect()
1665         https://bugs.webkit.org/show_bug.cgi?id=52956
1666
1667         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1668         (LayoutTestController::addURLToRedirect):
1669         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1670
1671 2011-01-22  Robert Hogan  <robert@webkit.org>
1672
1673         Reviewed by Kenneth Rohde Christiansen.
1674
1675         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1676         https://bugs.webkit.org/show_bug.cgi?id=49802
1677
1678         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1679         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1680         (WebCore::DumpRenderTree::open):
1681
1682 2011-01-21  Adam Barth  <abarth@webkit.org>
1683
1684         Reviewed by Maciej Stachowiak.
1685
1686         Disable mac_unittest.py that fails on some of the Mac bots
1687         https://bugs.webkit.org/show_bug.cgi?id=52947
1688
1689         As noted in the comment, this test does not appear to be correct
1690         because the function this test is testing returns different results
1691         depending on which flavor of Mac the test is run on.  This patch
1692         disable the test.  Hopefully we can re-enable the test once we've
1693         probably insulated the test from its environment.
1694
1695         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1696
1697 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1698
1699         Reviewed by Mihai Parparita.
1700
1701         Fix bug introduced in r76322 that caused NRWT to not actually
1702         read the Skipped files properly.
1703
1704         https://bugs.webkit.org/show_bug.cgi?id=52771
1705
1706         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1707         * Scripts/webkitpy/layout_tests/port/webkit.py:
1708         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1709
1710 2011-01-21  Sam Weinig  <sam@webkit.org>
1711
1712         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1713
1714         WebKitTestRunner needs the HOME environment variable to be set.
1715         <rdar://problem/8896573>
1716
1717         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1718         it exists.
1719
1720 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1721
1722         Reviewed by Eric Seidel.
1723
1724         Suppress a few remaining integration tests so that none of the
1725         layout_test unit tests ever read from the filesystem or launch
1726         subprocesses that aren't part of the unit tests.
1727
1728         Also fix a minor bug in the printing unit tests that was
1729         incorrectly relying on sys.argv.
1730
1731         https://bugs.webkit.org/show_bug.cgi?id=52863
1732
1733         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1734         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1735         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1736
1737 2011-01-21  Darin Adler  <darin@apple.com>
1738
1739        Fix Mac build.
1740
1741         * MiniBrowser/mac/BrowserWindowController.m:
1742         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1743
1744 2011-01-20  Darin Adler  <darin@apple.com>
1745
1746         Reviewed by Dan Bernstein.
1747
1748         WebKit2: Implement showModalDialog
1749         https://bugs.webkit.org/show_bug.cgi?id=52855
1750
1751         This fixes WebKitTestRunner to compile, but more work is probably
1752         needed to get it to pass the tests.
1753
1754         * WebKitTestRunner/TestController.cpp:
1755         (WTR::TestController::runModal): Added. Calls through to the
1756         platform-specific version of runModal.
1757         (WTR::TestController::createOtherPage): Changed to be a private
1758         static member function so it can refer to runModal, which is
1759         a private static member function.
1760         (WTR::TestController::initialize): Pass 0 for the runModal
1761         function since we don't need to run the main window modal.
1762         I suspect this is wrong and will need to change.
1763         * WebKitTestRunner/TestController.h: Added declarations for
1764         the functions added above.
1765         * WebKitTestRunner/mac/TestControllerMac.mm:
1766         (WTR::TestController::runModal): Added. Untested implementation.
1767         * WebKitTestRunner/qt/TestControllerQt.cpp:
1768         (WTR::TestController::runModal): Added.
1769         * WebKitTestRunner/win/TestControllerWin.cpp:
1770         (WTR::TestController::runModal): Added.
1771
1772 2011-01-21  Eric Seidel  <eric@webkit.org>
1773
1774         Reviewed by Adam Barth.
1775
1776         Split Host object off from WebKitPatch for easier re-use
1777         https://bugs.webkit.org/show_bug.cgi?id=52284
1778
1779         new-run-webkit-tests and other tools are eventually going to want one of these.
1780         Basically you need to inherit from this class if you want to pretend to be a
1781         self.tool object for Steps/Commands.
1782
1783         * Scripts/webkitpy/common/host.py: Added.
1784         * Scripts/webkitpy/tool/main.py:
1785
1786 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1787
1788         Reviewed by Adam Barth.
1789
1790         Disable the tests that start and stop the http server and web
1791         server, so that we don't have to worry about port collisions on
1792         the bots.
1793
1794         https://bugs.webkit.org/show_bug.cgi?id=52861
1795
1796         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1797
1798 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1799
1800         Reviewed by Eric Seidel.
1801
1802         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1803         
1804         https://bugs.webkit.org/show_bug.cgi?id=52772
1805         
1806         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1807
1808 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1809
1810         Reviewed by Eric Siedel.
1811
1812         nrwt: clean up almost all remaining port references, remove
1813         unnecessary import clauses. The only remaining references are
1814         in places where a mock filesystem makes no sense or can't be
1815         used, and in one routine in port/google_chrome_unittest that
1816         I'll rewrite in a separate patch.
1817
1818         https://bugs.webkit.org/show_bug.cgi?id=52771
1819
1820         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1821         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1822         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1823         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1824         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1825         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1826         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1827         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1828         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1829         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1830         * Scripts/webkitpy/layout_tests/port/gtk.py:
1831         * Scripts/webkitpy/layout_tests/port/mac.py:
1832         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1833         * Scripts/webkitpy/layout_tests/port/qt.py:
1834         * Scripts/webkitpy/layout_tests/port/webkit.py:
1835         * Scripts/webkitpy/layout_tests/port/win.py:
1836         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1837
1838 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1839
1840         Reviewed by Mihai Parparita.
1841
1842         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1843
1844         https://bugs.webkit.org/show_bug.cgi?id=52762
1845
1846         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1847         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1848
1849 2011-01-20  Tony Chang  <tony@chromium.org>
1850
1851         Reviewed by Ojan Vafai.
1852
1853         [chromium] fix the paths used for the rebaseline tool
1854         https://bugs.webkit.org/show_bug.cgi?id=52857
1855
1856         Some of the bots were renamed so the path to grab the results zip
1857         file has changed.
1858
1859         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1860
1861 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1862
1863         Reviewed by Tony Chang.
1864
1865         Fix bug introduced in r72688 / bug 52768 that broke the
1866         generation of the output filename links in the results.html
1867         output. Apparently none of the unit tests actually checked to
1868         make sure the generated links were correct :(
1869
1870         https://bugs.webkit.org/show_bug.cgi?id=52854
1871
1872         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1873         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1874
1875 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1876
1877         Reviewed by Darin Adler.
1878
1879         https://bugs.webkit.org/show_bug.cgi?id=52849
1880         Make window.print work with WebKit2
1881
1882         * MiniBrowser/mac/BrowserWindowController.m:
1883         (-[BrowserWindowController awakeFromNib]):
1884         * WebKitTestRunner/TestController.cpp:
1885         (WTR::createOtherPage):
1886         (WTR::TestController::initialize):
1887         Added zeroes to WKPageUIClient structures to avoid build failures.
1888
1889 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1890
1891         Reviewed by Eric Seidel.
1892
1893         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1894
1895         https://bugs.webkit.org/show_bug.cgi?id=52756
1896
1897         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1898         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1899         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1900         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1901         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1902         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1903
1904 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1905
1906         Reviewed by Antonio Gomes.
1907
1908         QtTestBrowser should have a seperate menu for Settings
1909         https://bugs.webkit.org/show_bug.cgi?id=52817
1910         
1911         Added a new menu item named "Settings"
1912         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1913
1914         * QtTestBrowser/launcherwindow.cpp:
1915         (LauncherWindow::createChrome):
1916
1917 2011-01-20  Sam Weinig  <sam@webkit.org>
1918
1919         Reviewed by John Sullivan.
1920
1921         Update update-webkit-localizable-strings with new path to WebKit.
1922
1923         * Scripts/update-webkit-localizable-strings:
1924
1925 2011-01-20  James Robinson  <jamesr@chromium.org>
1926
1927         Reviewed by Darin Fisher.
1928
1929         Implement mozilla's requestAnimationFrame API
1930         https://bugs.webkit.org/show_bug.cgi?id=51218
1931
1932         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1933
1934         * DumpRenderTree/chromium/WebViewHost.cpp:
1935         (invokeScheduleComposite):
1936         (WebViewHost::scheduleAnimation):
1937         (WebViewHost::paintInvalidatedRegion):
1938         * DumpRenderTree/chromium/WebViewHost.h:
1939
1940 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1941
1942         Reviewed by Adam Roben.
1943
1944         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1945         https://bugs.webkit.org/show_bug.cgi?id=42327
1946
1947         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1948         for methods that take their normal arguments but also a JSContextRef.
1949         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1950         for evaluateScriptInIsolatedWorld.
1951         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1952         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1953         this call is for an isolated world.
1954         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1955         (WTR::worldMap): Helper to create a world map.
1956         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1957         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1958         added LayoutTestController API.
1959         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1960
1961 2011-01-19  Adam Roben  <aroben@apple.com>
1962
1963         Convert paths in environment variables back to msys-style inside commit-log-editor
1964
1965         When this script gets run from inside git commit, msys-style paths in the environment will
1966         have been turned into Windows-style paths with forward slashes. This screws up functions
1967         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1968         the paths back to msys-style before doing anything else.
1969
1970         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1971         using msysgit's Perl and multiple ChangeLogs have been edited
1972
1973         Reviewed by David Kilzer.
1974
1975         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1976         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1977         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1978
1979 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1980
1981         [Win] Unreviewed build fix after r76248.
1982
1983         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1984
1985 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1986
1987         Reviewed by Csaba Osztrogonác.
1988
1989         Refactoring of the custom allocation framework
1990         https://bugs.webkit.org/show_bug.cgi?id=49897
1991
1992         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1993         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1994         equivalent macro implementation at the necessary places.
1995 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1996
1997         Unreviewed. 
1998
1999         Adding myself to committers.py.
2000
2001         * Scripts/webkitpy/common/config/committers.py:
2002
2003 2011-01-20  Adam Barth  <abarth@webkit.org>
2004
2005         Reviewed by Tony Chang.
2006
2007         Chromium builders don't delete unversioned directories when DEPS change
2008         https://bugs.webkit.org/show_bug.cgi?id=52745
2009
2010         If we pass this option to gclient sync, gclient will delete directories
2011         that are no longer part of DEPS instead of leaving them around to
2012         confuse us later.  Apparently, the downstream buildbots use this option
2013         already.
2014
2015         * Scripts/update-webkit-chromium:
2016
2017 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2018
2019         Unreviewed, build fix - I pulled this patch in to fix an issue
2020         revealed by r76195 running on some new bots). Also fix a couple
2021         of other issues revealed in testing.
2022
2023         nrwt: remove fs refs from layout_package/json*
2024
2025         https://bugs.webkit.org/show_bug.cgi?id=52754
2026
2027         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2028         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2029         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2030         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2031         * Scripts/webkitpy/layout_tests/port/base.py:
2032
2033 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2034
2035         Unreviewed, build fix.
2036
2037         Fix a couple of minor bugs discovered while bringing up new bots
2038         for testing.
2039
2040         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2041         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2042
2043 2011-01-19  James Robinson  <jamesr@chromium.org>
2044
2045         Unreviewed, rolling out r76194.
2046         http://trac.webkit.org/changeset/76194
2047         https://bugs.webkit.org/show_bug.cgi?id=51218
2048
2049         Caused mysterious compile failure on the chromium win
2050         build.webkit.org bots
2051
2052         * DumpRenderTree/chromium/WebViewHost.cpp:
2053         (WebViewHost::paintInvalidatedRegion):
2054         * DumpRenderTree/chromium/WebViewHost.h:
2055
2056 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2057
2058         Reviewed by Mihai Parparita.
2059
2060         remove fs refs from test_runner, dump_render_tree_thread
2061
2062         https://bugs.webkit.org/show_bug.cgi?id=52753
2063
2064         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2065         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2066         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2067         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2068
2069 2011-01-19  James Robinson  <jamesr@chromium.org>
2070
2071         Reviewed by Darin Fisher.
2072
2073         Implement mozilla's requestAnimationFrame API
2074         https://bugs.webkit.org/show_bug.cgi?id=51218
2075
2076         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2077
2078         * DumpRenderTree/chromium/WebViewHost.cpp:
2079         (invokeScheduleComposite):
2080         (WebViewHost::scheduleAnimation):
2081         (WebViewHost::paintInvalidatedRegion):
2082         * DumpRenderTree/chromium/WebViewHost.h:
2083
2084 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2085
2086         Unreviewed, build fix.
2087
2088         Fix a few incorrect "self._filesystem" references introduced in
2089         r76184.
2090
2091         * Scripts/webkitpy/layout_tests/port/chromium.py:
2092         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2093
2094 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2095
2096         Reviewed by Mihai Parparita.
2097
2098         add a .sep property, abspath(), isabs(), mtime(), and
2099         open_text_file_for_writing() to filesystem modules. Some of
2100         these properties are not needed in this patch but will be needed
2101         in subsequent patches (I'm doing this to avoid having to track
2102         multiple versions of a single file).
2103
2104         Also, change most of the port/* modules to use the filesystem
2105         objects instead of referencing the filesystem directly.
2106
2107         https://bugs.webkit.org/show_bug.cgi?id=52748
2108
2109         * Scripts/webkitpy/common/system/filesystem.py:
2110         * Scripts/webkitpy/common/system/filesystem_mock.py:
2111         * Scripts/webkitpy/layout_tests/port/__init__.py:
2112         * Scripts/webkitpy/layout_tests/port/base.py:
2113         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2114         * Scripts/webkitpy/layout_tests/port/chromium.py:
2115         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2116         * Scripts/webkitpy/layout_tests/port/config.py:
2117         * Scripts/webkitpy/layout_tests/port/test.py:
2118         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2119
2120 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2121
2122         Reviewed by Anders Carlsson.
2123
2124         If resetting between tests times out, treat it as a WebProcess crash
2125         https://bugs.webkit.org/show_bug.cgi?id=52757
2126
2127         * WebKitTestRunner/TestController.cpp:
2128         (WTR::TestController::runTest):
2129
2130 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2131
2132         Reviewed by Darin Adler.
2133
2134         https://bugs.webkit.org/show_bug.cgi?id=52739
2135         Make it possible for a WebKit2 client to print headers and footers
2136
2137         Added dummy implementations for new printing UIClient calls.
2138
2139         * MiniBrowser/mac/BrowserWindowController.m:
2140         (-[BrowserWindowController awakeFromNib]):
2141         * WebKitTestRunner/TestController.cpp:
2142         (WTR::createOtherPage):
2143         (WTR::TestController::initialize):
2144
2145 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2146
2147         Reviewed by Ojan Vafai.
2148
2149         Change webkitpy/layout_tests/port/test.py to use the
2150         in-memory filesystem for cleaner unit testing. This
2151         change allows us to kill a lot of code that was
2152         specific to the test port, at the cost of being a
2153         little less clear about how things would work if
2154         you didn't have a filesystem.
2155
2156         https://bugs.webkit.org/show_bug.cgi?id=52605
2157
2158         * Scripts/webkitpy/layout_tests/port/test.py:
2159
2160 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2161
2162         Unreviewed, build fix.
2163
2164         Fix test failure caused by committing attachment 79368 instead
2165         of attachment 79461 on bug 52604.
2166
2167         * Scripts/webkitpy/common/system/filesystem_mock.py:
2168
2169 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2170
2171         Reviewed by Mihai Parparita.
2172
2173         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2174         unit testing. os.walk() is too much of a hassle to implement on
2175         top of the in-memory mock filesystem and adding the necessary
2176         interface to files_under() gives clients a cleaner API anyway
2177         (for this particular usage model).
2178
2179         https://bugs.webkit.org/show_bug.cgi?id=52691
2180
2181         * Scripts/webkitpy/common/system/filesystem.py:
2182         * Scripts/webkitpy/common/system/filesystem_mock.py:
2183         * Scripts/webkitpy/layout_tests/port/test_files.py:
2184         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2185
2186 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2187
2188         Reviewed by Tony Chang.
2189
2190         Change more modules in the layout-tests code to use the
2191         filesystem wrapper for cleaner unit testing.
2192
2193         This patch also adds the glob() wrapper to the filesystem
2194         abstraction.
2195         
2196         https://bugs.webkit.org/show_bug.cgi?id=52604
2197
2198         * Scripts/webkitpy/layout_tests/port/test_files.py:
2199         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2200         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2201         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2202         * Scripts/webkitpy/common/system/filesystem.py:
2203         * Scripts/webkitpy/common/system/filesystem_mock.py:
2204
2205 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2206
2207         Unreviewed.
2208
2209         Updating my email addresses and irc nick.
2210
2211         * Scripts/webkitpy/common/config/committers.py:
2212
2213 2011-01-19  Tony Chang  <tony@chromium.org>
2214
2215         Reviewed by Mihai Parparita.
2216
2217         [chromium] [linux] if check-sys-deps fails, output the failure reason
2218         https://bugs.webkit.org/show_bug.cgi?id=52671
2219
2220         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2221             error handler functions.
2222         * Scripts/webkitpy/layout_tests/port/chromium.py:
2223             output the error text from --check-sys-deps
2224         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2225
2226 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2227
2228         Reviewed by Andreas Kling.
2229
2230         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2231         https://bugs.webkit.org/show_bug.cgi?id=52554
2232         
2233         QtNetworkAccessManager is created in a thread and set as
2234         member variable in QWebPage. When the thread is destroyed
2235         the object is still used. So fix will set the object to
2236         NULL once the thread is destroyed.
2237
2238         * QtTestBrowser/launcherwindow.cpp:
2239         (LauncherWindow::~LauncherWindow):
2240
2241 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2242
2243         Rubber stamped by Csaba Osztrogonac
2244
2245         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2246
2247 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2248
2249         Reviewed by Tony Chang.
2250
2251         new-run-webkit-tests: add a --build-directory command line argument
2252
2253         Official Google Chrome builds use a non-standard build directory
2254         location. This patch adds a --build-directory argument that
2255         allows that location to be specified on the command line. Only
2256         Chromium-based builds will use this flag for now, but anyone can
2257         in the future.
2258
2259         There are no unit tests for this since it's difficult to test
2260         until mock filesystems are fully supported in the code. This was
2261         tested by hand for now.
2262
2263         https://bugs.webkit.org/show_bug.cgi?id=52694
2264
2265         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2266         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2267         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2268         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2269
2270 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2271
2272         Not reviewed. Bot fix.
2273
2274         Remove an inadvertently committed debugging print.
2275
2276         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2277         (LayoutTestController::notifyDone):
2278
2279 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2280
2281         Reviewed by Sam Weinig.
2282
2283         WebKitTestRunner should track loading more like DumpRenderTree
2284         https://bugs.webkit.org/show_bug.cgi?id=52692
2285
2286         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2287         This makes some tests that call notifyDone multiple times pass.
2288         
2289         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2290         (WTR::InjectedBundle::InjectedBundle):
2291         (WTR::InjectedBundle::done):
2292         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2293         (WTR::InjectedBundle::topLoadingFrame):
2294         (WTR::InjectedBundle::setTopLoadingFrame):
2295         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2296         (WTR::InjectedBundlePage::InjectedBundlePage):
2297         (WTR::InjectedBundlePage::stopLoading):
2298         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2299         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2300         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2301         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2302         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2303         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2304         (WTR::LayoutTestController::notifyDone):
2305         * WebKitTestRunner/TestController.cpp:
2306         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2307
2308 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2309
2310         Reviewed by Kent Tamura.
2311
2312         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2313         https://bugs.webkit.org/show_bug.cgi?id=52678
2314         
2315         Update path now that WebKit is inside Source.
2316
2317         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2318
2319 2011-01-18  Robert Hogan  <robert@webkit.org>
2320
2321         Reviewed by Simon Hausmann.
2322
2323         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2324         https://bugs.webkit.org/show_bug.cgi?id=44282
2325
2326         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2327         (WebCore::DumpRenderTree::dump):
2328
2329 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2330
2331         Reviewed by Mihai Parparita.
2332
2333         Fix a small race condition that could cause the unit tests for
2334         new-run-webkit-tests to fail in a multithreaded environment.
2335         There was a small window in the code where one thread would
2336         check to see if a thread had raised an exception, do something,
2337         and then check to see if the thread was alive. If the other
2338         thread raised an exception and exited in between these two
2339         steps, the exception would be lost. Flipping the order of the
2340         two checks fixes the race, since we will now always check for an
2341         exception on the thread before exiting.
2342
2343         https://bugs.webkit.org/show_bug.cgi?id=51579
2344
2345         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2346
2347 2011-01-18  Eric Seidel  <eric@webkit.org>
2348
2349         Reviewed by Adam Barth.
2350
2351         commit-queue dies when test archiving fails
2352         https://bugs.webkit.org/show_bug.cgi?id=52617
2353
2354         I looked at the machine and it had 10 archives already
2355         thus find_unused_name was returning None.  I've upped
2356         the limit to 100 (per bug) and tested the case where
2357         find_unused_name returns None (making archive return None).
2358
2359         * Scripts/webkitpy/common/system/workspace.py:
2360         * Scripts/webkitpy/common/system/workspace_unittest.py:
2361         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2362         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2363         * Scripts/webkitpy/tool/commands/queues.py:
2364
2365 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2366
2367         Reviewed by Ojan Vafai.
2368
2369         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2370         filesystem. Also fix a couple of "with" statements missed by
2371         r76050.
2372
2373         https://bugs.webkit.org/show_bug.cgi?id=52487
2374
2375         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2376
2377 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2378
2379         Reviewed by Martin Robinson.
2380
2381         [Gtk] Build fixes for gtk3 build
2382         https://bugs.webkit.org/show_bug.cgi?id=52648
2383
2384         * DumpRenderTree/gtk/EventSender.cpp:
2385         (beginDragWithFilesCallback):
2386
2387 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2388
2389         Reviewed by Mihai Parparita.
2390
2391         Update rebaseline-chromium-webkit-tests to use filesystem objects
2392         instead of direct references to os.path, shutil, tempfile, etc.
2393
2394         This patch doesn't change anything, but will allow subsequent
2395         patches to change the unit tests to no longer use the real
2396         filesystem.
2397
2398         This patch adds a bunch more methods to the filesystem object as
2399         well.
2400
2401         https://bugs.webkit.org/show_bug.cgi?id=52482
2402
2403         * Scripts/webkitpy/common/system/filesystem.py:
2404         * Scripts/webkitpy/common/system/filesystem_mock.py:
2405         * Scripts/webkitpy/tool/commands/queues.py:
2406         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2407         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2408
2409 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2410
2411         Reviewed by Mihai Parparita.
2412
2413         new-run-webkit-tests shouldn't crash when you try to run a
2414         directory containing only skipped files.
2415
2416         https://bugs.webkit.org/show_bug.cgi?id=52478
2417         
2418         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2419         * Scripts/webkitpy/layout_tests/port/test.py:
2420         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2421
2422 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2423
2424         Reviewed by Gustavo Noronha Silva.
2425
2426         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2427         https://bugs.webkit.org/show_bug.cgi?id=40833
2428
2429         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2430         GTK+ event sender.
2431         (dragWithFilesDragDataGetCallback): Added.
2432         (dragWithFilesDragEndCallback): Added.
2433         (beginDragWithFilesCallback): Added.
2434
2435 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2436
2437         Reviewed by Adam Barth.
2438
2439         ews: Add additional watcher to efl ews
2440         https://bugs.webkit.org/show_bug.cgi?id=52613
2441
2442         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2443
2444         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2445
2446 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2447
2448         Reviewed by Alexey Proskuryakov.
2449
2450         Fix some headers with missing or misspelled #ifndef guards
2451         https://bugs.webkit.org/show_bug.cgi?id=52545
2452
2453         * DumpRenderTree/chromium/TestEventPrinter.h:
2454         * DumpRenderTree/chromium/WebPreferences.h:
2455
2456 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2457
2458         Reviewed by Anders Carlsson.
2459
2460         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2461         navigating back to an unreachable URL
2462         https://bugs.webkit.org/show_bug.cgi?id=52388
2463
2464         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2465
2466         * DumpRenderTree/LayoutTestController.cpp:
2467         (queueLoadHTMLStringCallback):
2468         (LayoutTestController::queueLoadHTMLString):
2469         (LayoutTestController::queueLoadAlternateHTMLString):
2470         * DumpRenderTree/LayoutTestController.h:
2471
2472         * DumpRenderTree/WorkQueueItem.h:
2473         (LoadHTMLStringItem::LoadHTMLStringItem):
2474
2475         * DumpRenderTree/chromium/LayoutTestController.cpp:
2476         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2477         (WorkItemLoadHTMLString::run):
2478         (LayoutTestController::queueLoadHTMLString):
2479
2480         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2481         (LoadHTMLStringItem::invoke):
2482         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2483         (LoadHTMLStringItem::invoke):
2484         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2485         (LoadHTMLStringItem::invoke):
2486
2487 2011-01-17  Dan Bernstein  <mitz@apple.com>
2488
2489         Rubber-stamped by Mark Rowe.
2490
2491         Update xcodeproj svn:ignore to include xcuserdata.
2492
2493         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2494         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2495         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2496         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2497         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2498
2499 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2500
2501         Unreviewed fix after r75908.
2502
2503         Move WebKit into Source
2504         https://bugs.webkit.org/show_bug.cgi?id=52530
2505
2506         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2507
2508 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2509
2510         Unreviewed.
2511
2512         Remove accidentally committed debug printing after r75908.
2513
2514         * Scripts/webkitdirs.pm:
2515
2516 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2517
2518         Unreviewed.
2519
2520         Add myself to committers list
2521         https://bugs.webkit.org/show_bug.cgi?id=52566
2522
2523         * Scripts/webkitpy/common/config/committers.py:
2524
2525 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2526
2527         Reviewed by Jeremy Orlow.
2528
2529         GeolocationController should call stopUpdating on destruction
2530         https://bugs.webkit.org/show_bug.cgi?id=52216
2531
2532         fast/dom/Geolocation/window-close-crash.html requires that a
2533         Geolocation watch be started in a secondary window. Consequently,
2534         we need to allow geolocation permission and provide a mock
2535         geolocation position for the secondary window's
2536         GeolocationClientMock.
2537
2538         * DumpRenderTree/chromium/LayoutTestController.cpp:
2539         (LayoutTestController::setGeolocationPermission):
2540         (LayoutTestController::setMockGeolocationPosition):
2541         (LayoutTestController::setMockGeolocationError):
2542         * DumpRenderTree/chromium/TestShell.h:
2543         (TestShell::windowList):
2544
2545 2011-01-16  Adam Barth  <abarth@webkit.org>
2546
2547         Update more include paths to reflect WebKit move.
2548
2549         * DumpRenderTree/chromium/EventSender.cpp:
2550         (EventSender::keyDown):
2551         (EventSender::needsShiftModifier):
2552         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2553         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2554
2555 2011-01-16  Kent Tamura  <tkent@chromium.org>
2556
2557         Unreviewed, Chromium build fix.
2558
2559         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2560
2561 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2562
2563         Build fix for GTK+ after source directory movement.
2564
2565         * GNUmakefile.am: Correct include paths.
2566
2567 2011-01-16  Adam Barth  <abarth@webkit.org>
2568
2569         Teach svn-apply about WebKit move.
2570
2571         * Scripts/VCSUtils.pm:
2572
2573 2011-01-16  Adam Barth  <abarth@webkit.org>
2574
2575         Rubber-stamped by Eric Seidel.
2576
2577         Move WebKit into Source
2578         https://bugs.webkit.org/show_bug.cgi?id=52530
2579
2580         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2581         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2582         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2583         * DumpRenderTree/qt/GCControllerQt.cpp:
2584         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2585         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2586         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2587         * DumpRenderTree/wscript:
2588         * QtTestBrowser/launcherwindow.h:
2589         * Scripts/build-webkit:
2590         * Scripts/webkitdirs.pm:
2591
2592 2011-01-15  Adam Barth  <abarth@webkit.org>
2593
2594         Teach svn-apply about WebKit2 move.
2595
2596         * Scripts/VCSUtils.pm:
2597
2598 2011-01-15  Adam Barth  <abarth@webkit.org>
2599
2600         Rubber-stamped by Eric Seidel.
2601
2602         Move WebKit2 into Source
2603         https://bugs.webkit.org/show_bug.cgi?id=52438
2604
2605         * MiniBrowser/qt/MiniBrowser.pro:
2606         * Scripts/build-webkit:
2607         * Scripts/do-file-rename:
2608         * Scripts/do-webcore-rename:
2609         * Scripts/test-webkitpy:
2610         * Scripts/webkitdirs.pm:
2611         * Scripts/webkitpy/style/checker.py:
2612         * WebKitTestRunner/DerivedSources.pro:
2613         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2614         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2615
2616 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2617
2618         Reviewed by David Levin.
2619
2620         [chromium] remove obsolete createView method
2621         https://bugs.webkit.org/show_bug.cgi?id=52437
2622
2623         * DumpRenderTree/chromium/WebViewHost.cpp:
2624         (WebViewHost::createView):
2625         * DumpRenderTree/chromium/WebViewHost.h:
2626
2627 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2628
2629         Reviewed by Geoff Garen.
2630
2631         ShouldLoadResourceForFrame should use strings, not URLs.
2632         https://bugs.webkit.org/show_bug.cgi?id=52476
2633
2634         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2635         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2636         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2637
2638 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2639
2640         Reviewed by David Levin.
2641
2642         Add Tony Gentilcore as a reviewer
2643         https://bugs.webkit.org/show_bug.cgi?id=52480
2644
2645         * Scripts/webkitpy/common/config/committers.py:
2646
2647 2011-01-14  David Levin  <levin@chromium.org>
2648
2649         Reviewed by Eric Seidel.
2650
2651         check-webkit-style: _FunctionState should keep track of where the function name starts.
2652         https://bugs.webkit.org/show_bug.cgi?id=52454
2653
2654         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2655         _FunctionState and logic for setting it correctly.
2656         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2657
2658 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2659
2660         Reviewed by David Levin.
2661
2662         Add support to DumpRenderTree to use the GPU rather than software renderer
2663         https://bugs.webkit.org/show_bug.cgi?id=52333
2664
2665         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2666         (main):
2667         * Scripts/webkitpy/layout_tests/port/chromium.py:
2668         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2669
2670 2011-01-14  Tony Chang  <tony@chromium.org>
2671
2672         Reviewed by Kent Tamura.
2673
2674         [chromium] update fonts.conf to fix 6 linux tests in drt
2675         https://bugs.webkit.org/show_bug.cgi?id=52411
2676
2677         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2678             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2679
2680 2011-01-14  Eric Seidel  <eric@webkit.org>
2681
2682         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2683
2684         Reviewed by Adam Barth.
2685
2686         Fix when running Tools/Scripts/check-webkit-style without arguments.
2687         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2688
2689         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2690         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2691
2692 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2693
2694         Reviewed by David Levin.
2695
2696         Store the tempdir object in a variable so it doesn't get deleted too early.
2697         https://bugs.webkit.org/show_bug.cgi?id=51875
2698
2699         * Scripts/update-webkit-auxiliary-libs:
2700         * Scripts/update-webkit-support-libs:
2701
2702 2011-01-14  Eric Seidel  <eric@webkit.org>
2703
2704         Unreviewed.  Make it work in python 2.5.
2705
2706         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2707         https://bugs.webkit.org/show_bug.cgi?id=49158
2708
2709         * Scripts/webkitpy/common/checkout/api_unittest.py:
2710
2711 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2712
2713         Unreviewed, rolling out r75774.
2714         http://trac.webkit.org/changeset/75774
2715         https://bugs.webkit.org/show_bug.cgi?id=52431
2716
2717         gtk builds were broken (Requested by loislo2 on #webkit).
2718
2719         * Scripts/webkitpy/common/checkout/scm.py:
2720
2721 2011-01-14  David Levin  <levin@chromium.org>
2722
2723         Reviewed by Shinichiro Hamaji.
2724
2725         check-webkit-style: _FunctionState should detect pure functions.
2726         https://bugs.webkit.org/show_bug.cgi?id=52428
2727
2728         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2729         is a pure virtual function.
2730         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2731         virtual functions are correctly detected.
2732
2733 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2734
2735         Reviewed by Yury Semikhatsky.
2736
2737         Just small fix for problem with check-webkit-style.
2738         It just didn't work for this patch.
2739         Old code can't concatenate a list of strings with None.
2740
2741         * Scripts/webkitpy/common/checkout/scm.py:
2742
2743 2011-01-13  David Levin  <levin@chromium.org>
2744
2745         Reviewed by Shinichiro Hamaji.
2746
2747         check-webkit-style: _FunctionState should use Position to know where items are.
2748         https://bugs.webkit.org/show_bug.cgi?id=52424
2749
2750         * Scripts/webkitpy/style/checkers/cpp.py:
2751         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2752         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2753         did some minor clean-up.
2754         (*): Other changes are simply about converting to use the Position's in_FunctionState
2755         instead of line numbers.
2756         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2757         to verify the positions stored in _FunctionState.
2758
2759 2011-01-13  Eric Seidel  <eric@webkit.org>
2760
2761         Reviewed by David Levin.
2762
2763         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2764         https://bugs.webkit.org/show_bug.cgi?id=49158
2765
2766         This is not the most elegant, but it is a very safe fix to this bug.
2767         One advantage of catching ScriptError like this instead of adding a
2768         new added_or_modified_files or fixing all changed_files callers
2769         to use a more specific change_files variant, is that we catch
2770         all kinds of ScriptErrors which might cause our (non-essential)
2771         suggest-reviewers code to fail out.  This should make passing
2772         --suggest-reviewers to webkit-patch upload much more robust
2773         and may even make it possible for us to make it default.
2774
2775         The root of the problem here is that SCM.changed_files includes
2776         deleted ChangeLog paths (from moves, etc) which then when we ask
2777         SVN/Git for the contents of the file at that revision, the command
2778         errors out and Executive.run_command raises a ScriptError.
2779
2780         In the future we might fix this differently by making all current
2781         callers of chagned_files use a more specific method for requesting
2782         what types of changes they're interested in (adds, modifies, deletes, etc.)
2783
2784         * Scripts/webkitpy/common/checkout/api.py:
2785         * Scripts/webkitpy/common/checkout/api_unittest.py:
2786
2787 2011-01-13  Dan Bernstein  <mitz@apple.com>
2788
2789         Reviewed by Alexey Proskuryakov.
2790
2791         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2792         https://bugs.webkit.org/show_bug.cgi?id=52419
2793
2794         Allow to further control the behavior of the willSendRequest delegate callback by making it
2795         set a different URL in the new request.
2796
2797         * DumpRenderTree/LayoutTestController.cpp:
2798         (addURLToRedirectCallback): Added.
2799         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2800         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2801         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2802         * DumpRenderTree/LayoutTestController.h:
2803         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2804         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2805         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2806         change the URL in the new request to the redirect destination.
2807
2808 2011-01-13  Eric Seidel  <eric@webkit.org>
2809
2810         Reviewed by Mihai Parparita.
2811
2812         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2813         https://bugs.webkit.org/show_bug.cgi?id=52416
2814
2815         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2816         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2817
2818         I also added FIXMEs about the changed_files returning deleted files problem
2819         which is causing the other most common exception for suggest-reviewers
2820         (and is probably breaking sheriff-bots blame detection).
2821
2822         * Scripts/webkitpy/common/checkout/api.py:
2823         * Scripts/webkitpy/common/checkout/api_unittest.py:
2824         * Scripts/webkitpy/common/checkout/scm.py:
2825
2826 2011-01-13  Eric Seidel  <eric@webkit.org>
2827
2828         Reviewed by Adam Barth.
2829
2830         results archives from commit-queue are too large to upload
2831         https://bugs.webkit.org/show_bug.cgi?id=52405
2832
2833         * Scripts/webkitpy/common/system/filesystem.py:
2834         * Scripts/webkitpy/common/system/filesystem_mock.py:
2835         * Scripts/webkitpy/tool/commands/queues.py:
2836
2837 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2838
2839         Reviewed by Martin Robinson.
2840
2841         [gtk] Zero-sized font does not yet work
2842         https://bugs.webkit.org/show_bug.cgi?id=49793
2843
2844         Set minimum-font-size to 0 for the DRT.
2845
2846         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2847         (resetDefaultsToConsistentValues):
2848
2849 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2850
2851         Reviewed by Darin Adler.
2852
2853         Make old-run-webkit-tests more robust on buildbots
2854         https://bugs.webkit.org/show_bug.cgi?id=52364
2855
2856         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2857
2858 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2859
2860         Reviewed by Darin Adler.
2861
2862         Make old-run-webkit-tests more robust on buildbots
2863         https://bugs.webkit.org/show_bug.cgi?id=52364
2864
2865         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2866
2867 2011-01-13  Tony Chang  <tony@chromium.org>
2868
2869         Reviewed by Kent Tamura.
2870
2871         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2872         https://bugs.webkit.org/show_bug.cgi?id=52332
2873
2874         Forked Info.plist is not longer needed.
2875
2876         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2877
2878 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2879
2880         Reviewed by Timothy Hatcher.
2881
2882         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2883         to be passed directly to WebInspector.UIString
2884
2885         https://bugs.webkit.org/show_bug.cgi?id=52365
2886
2887         * Scripts/check-inspector-strings:
2888
2889 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2890
2891         Unreviewed, rolling out r74881.
2892         http://trac.webkit.org/changeset/74881
2893         https://bugs.webkit.org/show_bug.cgi?id=52357
2894
2895         The EFL builder has been red for days (Requested by abarth on
2896         #webkit).
2897
2898         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2899         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2900
2901 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2902
2903         Reviewed by David Levin.
2904
2905         Add beforeunload support to WebKitTestRunner
2906         https://bugs.webkit.org/show_bug.cgi?id=52353
2907         
2908         This makes a number of currently failing tests pass.
2909
2910         * WebKitTestRunner/TestController.cpp:
2911         (WTR::runBeforeUnloadConfirmPanel):
2912         (WTR::createOtherPage):
2913         (WTR::TestController::initialize):
2914
2915 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2916
2917         Reviewed by Sam Weinig.
2918
2919         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2920         https://bugs.webkit.org/show_bug.cgi?id=52330
2921
2922         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2923         a web process crash.
2924         * WebKitTestRunner/TestController.cpp:
2925         (WTR::TestController::initialize): Set up a processDidCrash
2926         callback.
2927         (WTR::TestController::processDidCrash): Report that the Web process
2928         crashed.
2929         * WebKitTestRunner/TestController.h:
2930
2931 2011-01-12  David Levin  <levin@chromium.org>
2932
2933         Reviewed by Shinichiro Hamaji.
2934
2935         check-webkit-style -- close_expression function doesn't work correctly.
2936         https://bugs.webkit.org/show_bug.cgi?id=52272
2937
2938         * Scripts/webkitpy/style/checkers/cpp.py:
2939         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2940         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2941         generally useful (for upcoming code changes).
2942         (close_expression): Changed to use Position for input and output.
2943         Also, fixed many bugs such as only working correctly for parenthesis,
2944         not working correctly if given an offset in a line and not finding
2945         the real closing element if there were multiple closing elements in
2946         the same line.
2947         (detect_functions): Adjusted due to the change in arguments for
2948         close_expression.
2949         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2950         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2951         two positions are the same.
2952         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2953         (CppStyleTest.test_close_expression): Added tests to catch the issues
2954         that were fixed.
2955
2956 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2957
2958         Unreviewed, rolling out r75576.
2959         http://trac.webkit.org/changeset/75576
2960         https://bugs.webkit.org/show_bug.cgi?id=52304
2961
2962         broke rebaseline-chromium-webkit-test (Requested by thakis on
2963         #webkit).
2964
2965         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2966         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2967         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2968         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2969         * Scripts/webkitpy/layout_tests/port/base.py:
2970         * Scripts/webkitpy/layout_tests/port/chromium.py:
2971         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2972         * Scripts/webkitpy/layout_tests/port/test.py:
2973         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2974         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2975         * Scripts/webkitpy/style/checkers/test_expectations.py:
2976         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2977
2978 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2979
2980         Reviewed by Darin Adler.
2981
2982         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2983         https://bugs.webkit.org/show_bug.cgi?id=52307
2984
2985         * Scripts/old-run-webkit-tests:
2986
2987 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2988
2989         Reviewed by Martin Robinson.
2990
2991         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2992         https://bugs.webkit.org/show_bug.cgi?id=50867
2993
2994         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2995         TestNetscapePlugin.cpp 
2996
2997         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2998         * Scripts/webkitdirs.pm:
2999
3000 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
3001
3002         Reviewed by Pavel Feldman.
3003
3004         Add check-inspector-strings script.
3005
3006         https://bugs.webkit.org/show_bug.cgi?id=52295
3007
3008         * Scripts/check-inspector-strings: Added.
3009
3010 2011-01-12  Adam Roben  <aroben@apple.com>
3011
3012         Advertise the .testnetscape file extension on Windows
3013
3014         Fixes <http://webkit.org/b/52298>
3015         plugins/no-mime-with-valid-extension.html fails on Windows
3016
3017         Reviewed by Dan Bernstein.
3018
3019         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
3020         FileExtents field to map the .testnetscape file extension to the
3021         application/x-webkit-test-netscape MIME type, just as we do on Mac.
3022
3023 2011-01-12  Adam Barth  <abarth@webkit.org>
3024
3025         Reviewed by Eric Seidel.
3026
3027         Make webkit-patch support subdirectories for SVN checkouts
3028         https://bugs.webkit.org/show_bug.cgi?id=52261
3029
3030         os.relpath does not exist on Python 2.5, so we need to call our version
3031         of the API.
3032
3033         * Scripts/webkitpy/common/checkout/scm.py:
3034
3035 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3036
3037         Reviewed by Eric Seidel.
3038
3039         Close additional pages opened during a test once the test completes.
3040         https://bugs.webkit.org/show_bug.cgi?id=52276
3041
3042         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3043         (WTR::InjectedBundle::done):
3044
3045 2011-01-11  David Levin  <levin@chromium.org>
3046
3047         Reviewed by Eric Seidel.
3048
3049         Errors should be separated from the command line in bot messages.
3050         https://bugs.webkit.org/show_bug.cgi?id=52275
3051
3052         * Scripts/webkitpy/common/system/executive.py:
3053         (ScriptError.message_with_output): Added a newline to separate the command
3054         line from the errors.
3055         * Scripts/webkitpy/common/system/executive_unittest.py:
3056         (ScriptErrorTest.test_message_with_output): Added tests for the various code
3057         paths in message_with_output.
3058
3059 2011-01-11  Eric Seidel  <eric@webkit.org>
3060
3061         Unreviewed.
3062
3063         commit-queue should know how to upload archived results (for test flakes or general failures)
3064         https://bugs.webkit.org/show_bug.cgi?id=52048
3065
3066         The zips are mostly empty due to forgetting -r.
3067         Expected diffs were not being pulled from the archive due
3068         to the archive having longer paths than I realized.
3069
3070         * Scripts/webkitpy/common/system/workspace.py:
3071         * Scripts/webkitpy/common/system/workspace_unittest.py:
3072         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3073         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3074
3075 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
3076
3077         Reviewed by Ojan Vafai.
3078
3079         The current modifier parsing code in test_expectations is
3080         fragile and hard-coded, so it's not easy to understand the logic
3081         or easily add new types of modifiers (like GPU vs. CPU testing
3082         for graphics tests, or 32-bit vs. 64-bit differences).
3083
3084         This is the first of two patches that will add in more generic
3085         support and then eliminate the GPU-specific test expectations
3086         files for Chromium.
3087
3088         This patch adds two standalone objects for handling modifiers. The
3089         rules for interpreting modifiers, precedence, and conflicts are
3090         given in the docstring to the ModifierMatcher class, which
3091         returns ModifierMatchResult objects.
3092         
3093         This patch also adds routines to the Port interface and a
3094         default set of values in the base object, in order to obtain the
3095         values needed on a given test run. These values are then passed
3096         to the expectation parser. This also allows us to clean up the
3097         logic used to lint all of the different configurations in a
3098         single test_expectations.txt file.
3099
3100         The next patch will merge in the separate GPU expectations file.
3101
3102         https://bugs.webkit.org/show_bug.cgi?id=51222
3103
3104         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3105         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3106         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3107         * Scripts/webkitpy/layout_tests/port/base.py:
3108         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3109         * Scripts/webkitpy/layout_tests/port/chromium.py:
3110         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3111         * Scripts/webkitpy/layout_tests/port/test.py:
3112         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3113         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3114
3115 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3116
3117         Reviewed by Adam Barth.
3118
3119         Make webkit-patch support subdirectories for SVN checkouts
3120         https://bugs.webkit.org/show_bug.cgi?id=52261
3121
3122         * Scripts/webkitpy/common/checkout/scm.py:
3123         * Scripts/webkitpy/style_references.py:
3124         * Scripts/webkitpy/tool/main.py:
3125         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3126
3127 2011-01-11  Eric Seidel  <eric@webkit.org>
3128
3129         Unreviewed.
3130
3131         commit-queue should know how to upload archived results (for test flakes or general failures)
3132         https://bugs.webkit.org/show_bug.cgi?id=52048
3133
3134         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3135         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3136
3137         * Scripts/webkitpy/common/system/workspace.py:
3138         * Scripts/webkitpy/common/system/workspace_unittest.py:
3139         * Scripts/webkitpy/tool/commands/queues.py:
3140
3141 2011-01-11  Sam Weinig  <sam@webkit.org>
3142
3143         Roll r75474 back in.
3144
3145 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3146
3147         Reviewed by Kenneth Rohde Christiansen.
3148
3149         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3150         https://bugs.webkit.org/show_bug.cgi?id=51204
3151
3152         * QtTestBrowser/webpage.h:
3153         (QtNAMThread::QtNAMThread):
3154         (QtNAMThread::networkAccessManager):
3155         (QtNAMThread::run):
3156
3157 2011-01-11  Peter Varga  <pvarga@webkit.org>
3158
3159         Unreviewed.
3160
3161         Add myself to committers' list.
3162
3163         * Scripts/webkitpy/common/config/committers.py:
3164
3165 2011-01-11  Eric Seidel  <eric@webkit.org>
3166
3167         Reviewed by Adam Barth.
3168
3169         commit-queue should know how to upload archived results (for test flakes or general failures)
3170         https://bugs.webkit.org/show_bug.cgi?id=52048
3171
3172         Now the queue will always upload results.  Either the entire zip, or just
3173         the diffs.txt in the case of text failures.
3174
3175         This should make understanding flakes much easier, and paves the way
3176         for having the EWS run layout tests (and upload failures).
3177
3178         In order to upload .zip files I had to teach bugzilla.py to autodetect
3179         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3180         for .patch files, I have it add one before calling guess_type.
3181
3182         We may find that always uploading the whole zip instead of just the -diffs.txt
3183         file is preferable, but for now I'm keeping the old behavior because it makes
3184         quickly understanding text failures easy.
3185
3186         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3187         * Scripts/webkitpy/common/system/workspace.py: Added.
3188         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3189         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3190         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3191         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3192         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3193         * Scripts/webkitpy/tool/commands/queues.py:
3194         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3195
3196 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3197
3198         Unreviewed, rolling out r75464.
3199         http://trac.webkit.org/changeset/75464
3200         https://bugs.webkit.org/show_bug.cgi?id=52193
3201
3202         Followup rollout for 75474 (Requested by Ossy on #webkit).
3203
3204         * MiniBrowser/mac/BrowserWindowController.m:
3205         (-[BrowserWindowController awakeFromNib]):
3206         * MiniBrowser/win/BrowserView.cpp:
3207         (BrowserView::create):
3208         * WebKitTestRunner/TestController.cpp:
3209         (WTR::createOtherPage):
3210         (WTR::TestController::initialize):
3211
3212 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3213
3214         Reviewed by Csaba Osztrogonác.
3215
3216         [Qt] Baseline qt_minimal configuration
3217         https://bugs.webkit.org/show_bug.cgi?id=51313
3218
3219         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3220         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3221         QT_NO_UNDOSTACK guard.
3222
3223         * QtTestBrowser/launcherwindow.cpp:
3224         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3225         guards.
3226         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3227         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3228         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3229         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3230
3231         * QtTestBrowser/launcherwindow.h:
3232         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3233         * QtTestBrowser/locationedit.h: Ditto.
3234
3235         * QtTestBrowser/mainwindow.cpp:
3236         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3237         QT_NO_UNDOSTACK guards.
3238         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3239         (MainWindow::changeLocation): Ditto.
3240         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3241         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3242
3243         * QtTestBrowser/webpage.cpp:
3244         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3245         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3246
3247         * QtTestBrowser/webview.cpp:
3248         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3249         (WebViewGraphicsBased::animatedYFlip): Ditto.
3250
3251 2011-01-10  Sam Weinig  <sam@webkit.org>
3252
3253         Fix build.
3254
3255         * MiniBrowser/mac/BrowserWindowController.m:
3256         (-[BrowserWindowController awakeFromNib]):
3257         * MiniBrowser/win/BrowserView.cpp:
3258         (BrowserView::create):
3259         * WebKitTestRunner/TestController.cpp:
3260         (WTR::createOtherPage):
3261         (WTR::TestController::initialize):
3262
3263 2011-01-10  Eric Seidel  <eric@webkit.org>
3264
3265         Reviewed by Ojan Vafai.
3266
3267         style-queue messages are way too long for big patches
3268         https://bugs.webkit.org/show_bug.cgi?id=52161
3269
3270         We definitely could build much fancier list-to-string-with-limit functions
3271         but this should be sufficient for our needs at the moment.
3272
3273         * Scripts/webkitpy/common/system/executive.py:
3274         * Scripts/webkitpy/common/system/executive_unittest.py:
3275
3276 2011-01-10  Tony Chang  <tony@chromium.org>
3277
3278         Unreviewed, rolling out r75398.
3279         http://trac.webkit.org/changeset/75398
3280         https://bugs.webkit.org/show_bug.cgi?id=52008
3281
3282         Some layout tests are crashing on Chromium Win.
3283
3284         * DumpRenderTree/chromium/WebViewHost.cpp:
3285         (WebViewHost::updatePaintRect):
3286         * DumpRenderTree/chromium/WebViewHost.h:
3287
3288 2011-01-10  Adam Roben  <aroben@apple.com>
3289
3290         Roll out r75392
3291
3292         It isn't needed now that r75289 has been rolled out.
3293
3294         * Scripts/run-javascriptcore-tests:
3295
3296 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3297
3298         Reviewed by Anders Carlsson.
3299
3300         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3301         https://bugs.webkit.org/show_bug.cgi?id=52160
3302
3303         * WebKitTestRunner/mac/TestControllerMac.mm:
3304         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3305         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3306         anyway.
3307
3308 2011-01-10  Tony Chang  <tony@chromium.org>
3309
3310         Reviewed by Mihai Parparita.
3311
3312         [chromium] fix for animated gif layout tests
3313         https://bugs.webkit.org/show_bug.cgi?id=52008
3314
3315         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3316             to trigger gif animations.
3317         (WebViewHostPaintTask::WebViewHostPaintTask):
3318         (WebViewHostPaintTask::runIfValid):
3319         (WebViewHost::updatePaintRect):
3320         * DumpRenderTree/chromium/WebViewHost.h:
3321         (WebViewHost::taskList):
3322
3323 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3324
3325         Reviewed by Xan Lopez.
3326
3327         [GTK] Fix gtk2 compilation for master
3328         https://bugs.webkit.org/show_bug.cgi?id=51885
3329
3330         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3331         (createBitmapContextFromWebView): Replaced the old
3332         gdk_drawable_get_size with gdk_pixmap_get_size.
3333
3334 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3335
3336         Reviewed by Laszlo Gombos.
3337
3338         [WINCE] Reenable NPAPI after r75203
3339         https://bugs.webkit.org/show_bug.cgi?id=52109
3340
3341         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3342         it with !isEfl(), because EFL port does not support NPAPI (yet).
3343
3344         * Scripts/build-webkit:
3345
3346 2011-01-10  Adam Roben  <aroben@apple.com>
3347
3348         Skip some asserting JS tests
3349
3350         See <http://webkit.org/b/52156>.
3351
3352         * Scripts/run-javascriptcore-tests:
3353
3354 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3355
3356         Reviewed by Xan Lopez.
3357
3358         [GTK] build-webkit disable Blob support via arguments passed to automake
3359         https://bugs.webkit.org/show_bug.cgi?id=52097
3360
3361         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3362         build-webkit.
3363
3364 2011-01-10  Adam Roben  <aroben@apple.com>
3365
3366         Use the same name and description for TestNetscapePlugin on Windows and
3367         Mac
3368
3369         Fixes <http://webkit.org/b/52151>
3370         fast/frames/iframe-reparenting-plugins.html fails on Windows
3371
3372         Reviewed by Steve Falkenburg.
3373
3374         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3375         the name and description from Mac's Info.plist.
3376
3377 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3378
3379         Reviewed by Laszlo Gombos.
3380
3381         [Qt][WK2] Guard gcc-specific syntax
3382
3383         Non-gcc based compliers choke on the "-include"
3384         syntax for preinclude, place guard around it.
3385
3386         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3387         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3388
3389 2011-01-10  Andreas Kling  <kling@webkit.org>
3390
3391         Reviewed by Simon Hausmann.
3392
3393         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3394         https://bugs.webkit.org/show_bug.cgi?id=52111
3395
3396         When getting a createNewPage() callback from QWKPage, create the
3397         new page with the same QWKContext as the page that is passed to
3398         the callback.
3399
3400         * MiniBrowser/qt/BrowserView.h:
3401         * MiniBrowser/qt/BrowserWindow.cpp:
3402         (newPageFunction):
3403         (BrowserWindow::BrowserWindow):
3404         * MiniBrowser/qt/BrowserWindow.h:
3405
3406 2011-01-10  Andreas Kling  <kling@webkit.org>
3407
3408         Reviewed by Kenneth Rohde Christiansen.
3409
3410         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3411
3412         BrowserView set its own useless createNewPage() callback on QWKPage.
3413         This was immediately overridden by BrowserWindow anyway, so remove
3414         the BrowserView one.
3415
3416         * MiniBrowser/qt/BrowserView.cpp:
3417         (BrowserView::BrowserView):
3418
3419 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3420
3421         Reviewed by Jeremy Orlow.
3422
3423         [Chromium] Remove non-client-based Geolocation code
3424         https://bugs.webkit.org/show_bug.cgi?id=50921
3425
3426         * DumpRenderTree/chromium/LayoutTestController.cpp:
3427         (LayoutTestController::setGeolocationPermission):
3428         (LayoutTestController::setMockGeolocationPosition):
3429         (LayoutTestController::setMockGeolocationError):
3430         * DumpRenderTree/chromium/WebViewHost.cpp:
3431         (WebViewHost::geolocationClientMock):
3432         (WebViewHost::reset):
3433         * DumpRenderTree/chromium/WebViewHost.h:
3434
3435 2011-01-10  Eric Seidel  <eric@webkit.org>
3436
3437         Reviewed by Adam Barth.
3438
3439         Commit bot tried to land r? cq+ patch
3440         https://bugs.webkit.org/show_bug.cgi?id=36638
3441
3442         It should now be possible to post a patch with r? and cq+ and the
3443         commit-queue will correctly wait for the r+ before attempting to land the patch.
3444         (This was a feature requested by several users.)
3445
3446         One caveat: We don't actually reject r-, cq+ patches from the queue
3447         (we just ignore them), but I think that's OK for now.
3448
3449         I also noticed that setting r- once a commit-queue node had grabbed
3450         a patch would not properly cancel the landing.  That's fixed and
3451         tested in this patch.
3452
3453         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3454         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3455         * Scripts/webkitpy/tool/bot/feeders.py:
3456         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3457
3458 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3459
3460         Reviewed by Kenneth Rohde Christiansen.
3461
3462         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3463         https://bugs.webkit.org/show_bug.cgi?id=51934
3464
3465         When accessing the network from the destructor of QWebPage, the network access manager
3466         was already deleted because the object WebPage was already destructed.
3467
3468         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3469         The object is now destructed in the destructor of QObject.
3470
3471         * QtTestBrowser/webpage.cpp:
3472         (WebPage::WebPage):
3473         (WebPage::setQnamThreaded):
3474         * QtTestBrowser/webpage.h:
3475         (QtNAMThread::QtNAMThread):
3476
3477 2011-01-08  Eric Seidel  <eric@webkit.org>
3478
3479         Reviewed by Ojan Vafai.
3480
3481         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3482         https://bugs.webkit.org/show_bug.cgi?id=52067
3483
3484         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3485         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3486
3487         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3488
3489 2011-01-08  Eric Seidel  <eric@webkit.org>
3490
3491         Reviewed by Mihai Parparita.
3492
3493         commit-queue hangs when the ChangeLog diff is bad
3494         https://bugs.webkit.org/show_bug.cgi?id=52072
3495
3496         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3497         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3498
3499 2011-01-08  Adam Barth  <abarth@webkit.org>
3500
3501         Teach svn-apply how to re-write WebCore to Source/WebCore.
3502
3503         * Scripts/VCSUtils.pm:
3504
3505 2011-01-07  Adam Barth  <abarth@webkit.org>
3506
3507         Rubber-stamped by Eric Seidel.
3508
3509         Move WebCore to Source
3510         https://bugs.webkit.org/show_bug.cgi?id=52050
3511
3512         Update the tools to understand WebCore's new location.
3513
3514         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3515         * DumpRenderTree/wscript:
3516         * GNUmakefile.am:
3517         * Scripts/build-webkit:
3518         * Scripts/do-file-rename:
3519         * Scripts/do-webcore-rename:
3520         * Scripts/generate-qt-inspector-resource:
3521         * Scripts/prepare-ChangeLog:
3522         * Scripts/run-bindings-tests:
3523         * Scripts/update-iexploder-cssproperties:
3524         * Scripts/update-sources-list.py:
3525         * Scripts/update-webkit-localizable-strings:
3526         * Scripts/webkitdirs.pm:
3527         * Scripts/webkitpy/common/config/build.py:
3528         * Scripts/webkitpy/common/config/build_unittest.py:
3529         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3530         * Scripts/webkitpy/style/checker.py:
3531         * Scripts/webkitpy/style/checker_unittest.py:
3532         * WebKitTestRunner/DerivedSources.pro:
3533         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3534         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3535         * wx/browser/wscript:
3536         * wx/build/settings.py:
3537
3538 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3539
3540         Reviewed by Sam Weinig.
3541
3542         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3543         https://bugs.webkit.org/show_bug.cgi?id=52086
3544
3545         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3546         (WTR::InjectedBundle::didReceiveMessage):
3547         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3548         (WTR::LayoutTestController::notifyDone):
3549         * WebKitTestRunner/TestController.cpp:
3550         (WTR::TestController::resetStateToConsistentValues):
3551         (WTR::TestController::run):
3552
3553 2011-01-07  James Robinson  <jamesr@chromium.org>
3554
3555         Revert "Implement mozilla's animationTime property"
3556         https://bugs.webkit.org/show_bug.cgi?id=51952
3557
3558         This approach isn't quite right.
3559
3560         * DumpRenderTree/chromium/WebViewHost.cpp:
3561         (WebViewHost::paintInvalidatedRegion):
3562
3563 2011-01-07  Adam Roben  <aroben@apple.com>
3564
3565         Build master fix
3566
3567         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3568         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3569
3570 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3571
3572         Reviewed by Csaba Osztrogonác.
3573
3574         run-qtwebkit-tests should be able to kill a testsuite.
3575
3576         Add new option in the script that can setup a timeout for a test.
3577         If the test execution takes more then specified time then the test
3578         would be terminated.
3579
3580         [Qt] run-qtwebkit-tests needs timeout
3581         https://bugs.webkit.org/show_bug.cgi?id=51894
3582
3583         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3584         * Scripts/run-qtwebkit-tests:
3585
3586 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3587
3588         Unreviewed fix after r75233.
3589
3590         Based on idea from Eric Seidel.
3591
3592         Add remote zip file handling to webkitpy.
3593         https://bugs.webkit.org/show_bug.cgi?id=50901
3594
3595         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3596
3597 2011-01-07  Shane Stephens  <shanestephens@google.com>
3598
3599         Reviewed by Eric Seidel.
3600
3601         svn-apply: should support git binary delta diffs
3602         https://bugs.webkit.org/show_bug.cgi?id=38864
3603
3604         * Scripts/VCSUtils.pm:
3605         * Scripts/svn-apply:
3606
3607 2011-01-06  Julie Parent  <jparent@chromium.org>
3608
3609         Reviewed by Eric Seidel.
3610
3611         Test Result Server not removing old results.
3612         https://bugs.webkit.org/show_bug.cgi?id=52012
3613
3614         * TestResultServer/model/jsonresults.py:
3615         Fix off-by-one: Truncate if >= num_runs, not just >.
3616         * TestResultServer/model/jsonresults_unittest.py:
3617         Add unit test to test that merging in a new result with the same value
3618         as the last result causes previous result to fall off.
3619
3620 2011-01-06  James Kozianski  <koz@chromium.org>
3621
3622         Reviewed by Mihai Parparita.
3623
3624         Add classes to provide a consistent interface to a set of files.
3625         https://bugs.webkit.org/show_bug.cgi?id=50901
3626
3627         These classes allow us to write code that is agnostic to whether a
3628         particular set of files resides in a local directory or in a zip file
3629         on a remote machine.
3630
3631         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3632         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3633         * Scripts/webkitpy/common/system/fileset.py: Added.
3634         * Scripts/webkitpy/common/system/filesystem.py:
3635         * Scripts/webkitpy/common/system/filesystem_mock.py:
3636         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3637         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3638
3639 2011-01-06  Eric Seidel  <eric@webkit.org>
3640
3641         Reviewed by Adam Barth.
3642
3643         NetworkTransaction should log the url it is retrying
3644         https://bugs.webkit.org/show_bug.cgi?id=52043
3645
3646         * Scripts/webkitpy/common/net/networktransaction.py:
3647         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3648
3649 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3650
3651         Windows build fix.
3652         Import os before using it.
3653
3654         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3655
3656 2011-01-06  Eric Seidel  <eric@webkit.org>
3657
3658         Reviewed by Adam Barth.
3659
3660         StyleQueue fails to report errors when patches have many files
3661         https://bugs.webkit.org/show_bug.cgi?id=52042
3662
3663         This is one of at least two errors preventing style error reporting at the moment.
3664         When we moved to passing the list of files to check explicitly,
3665         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3666         We could change the type of the QueueStatus.message type, or we could
3667         just teach statusserver.py how to clamp values (and warn when it does).
3668         I chose the latter path.
3669
3670         * Scripts/webkitpy/common/net/statusserver.py:
3671
3672 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3673
3674         Reviewed by Stephanie Lewis.
3675         
3676         Fix syntax error in script.
3677
3678         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3679         https://bugs.webkit.org/show_bug.cgi?id=51996
3680
3681         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3682
3683 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3684
3685         Unreviewed, fixing WinCE build after r75196.
3686
3687         WinCE port does not (yet) support NPAPI.
3688
3689         * Scripts/build-webkit:
3690
3691 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3692
3693         Reviewed by Darin Adler.
3694
3695         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3696         https://bugs.webkit.org/show_bug.cgi?id=52015
3697
3698         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3699         after the platform has been detected, otherwise the script will
3700         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3701         detection.
3702
3703 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3704
3705         Reviewed by Eric Seidel.
3706
3707         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3708         https://bugs.webkit.org/show_bug.cgi?id=51346
3709
3710         * Scripts/build-webkit:
3711
3712 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3713
3714         Reviewed by Adam Roben.
3715
3716         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3717         https://bugs.webkit.org/show_bug.cgi?id=51996
3718         
3719         After the configuration directory change, we were archiving the incorrect directory for
3720         build product, so we were running tests on the wrong binaries.
3721         
3722         This change archives the correct directory, and also unarchives it into a configuration-
3723         specific directory.
3724
3725         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3726         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3727
3728 2011-01-06  Eric Seidel  <eric@webkit.org>
3729
3730         Reviewed by Mihai Parparita.
3731
3732         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3733         https://bugs.webkit.org/show_bug.cgi?id=52002
3734
3735         See an example of this here:
3736         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3737
3738         It's due to the fact that we pass around TestFailure() instance
3739         objects and yet expect them to all compare to be the same.
3740
3741         This is bad.  We should either have shared instances of these values
3742         or we should just pass around the class names.  There are already hacks
3743         in place to make TestFailure objects pass equality tests, I just added
3744         a __hash__ implementation so they can be used in sets as expected.
3745
3746         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3747         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3748
3749 2011-01-06  Evan Martin  <evan@chromium.org>
3750
3751         Reviewed by Tony Chang.
3752
3753         [gdb] handle inaccessible memory and UChar*
3754         https://bugs.webkit.org/show_bug.cgi?id=52003
3755
3756         To pretty-print a UChar*, we just grope around in the memory
3757         looking for a terminating NUL.  We need to handle the exception
3758         that can occur when we poke into an invalid location.
3759
3760         Additionally, the logic for choosing which pretty-printer would
3761         early return before hitting the point where we'd use the UChar*
3762         printer.  (Did this ever work?  How did it regress?)
3763
3764         * gdb/webkit.py:
3765
3766 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3767
3768         Reviewed by Ada Chan.
3769
3770         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3771         https://bugs.webkit.org/show_bug.cgi?id=51969
3772         
3773         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3774
3775         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3776         (WTR::InjectedBundlePage::InjectedBundlePage):
3777         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3778         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3779
3780 2011-01-06  James Robinson  <jamesr@chromium.org>
3781
3782         Reviewed by Simon Fraser.
3783
3784         Implement mozilla's animationTime property
3785         https://bugs.webkit.org/show_bug.cgi?id=51952
3786
3787         Chromium DRT support for webkitAnimationTime.
3788
3789         * DumpRenderTree/chromium/WebViewHost.cpp:
3790         (WebViewHost::paintInvalidatedRegion):
3791
3792 2011-01-06  Julie Parent  <jparent@chromium.org>
3793
3794         Reviewed by Tony Chang.
3795
3796         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3797         https://bugs.webkit.org/show_bug.cgi?id=51217
3798
3799         * TestResultServer/model/jsonresults.py:
3800         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3801         Adds missing documentation.
3802         * TestResultServer/model/jsonresults_unittest.py:
3803         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3804         Update test_merge to take a number of builds to truncate at.
3805
3806 2011-01-06  Adam Barth  <abarth@webkit.org>
3807
3808         Reviewed by Eric Seidel.
3809
3810         The EWS should log outside of the working directory
3811         https://bugs.webkit.org/show_bug.cgi?id=51986
3812
3813         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3814         script, which will actually clean the working copy back to a pristine
3815         state instead of leaving untracked directories and ignored files.
3816
3817         * Scripts/webkitpy/tool/commands/queues.py:
3818         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3819
3820 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3821
3822         Windows build fix.
3823         Back out attempted change to built-product-archive.
3824
3825         * BuildSlaveSupport/built-product-archive:
3826
3827 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3828
3829         Windows build fix.
3830         Include configuration name when unpacking a build archive.
3831
3832         Needed, since we split Windows build results into configuration-specific directories
3833         under WebKitOutputDir.
3834
3835         * BuildSlaveSupport/built-product-archive:
3836
3837 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3838
3839         Reviewed by Darin Adler.
3840
3841         Debug and Release builds on Windows clobber each other
3842         https://bugs.webkit.org/show_bug.cgi?id=49185
3843
3844         Changes the structure of WebKitBuild build products directory so we
3845         completely separate each build configuration into independent directories.
3846         
3847         Although we previously had per-configuration directories for obj, this change adds
3848         per-configuration directories for bin, lib, obj, and include. Each configuration's
3849         build products are stored within a directory inside of WebKitBuild.
3850         
3851         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3852         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3853
3854         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3855         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3856         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3857         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3858         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3859         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3860         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3861         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3862         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3863         * FindSafari/FindSafari.vcproj:
3864         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3865         * MiniBrowser/MiniBrowserPostBuild.cmd:
3866         * MiniBrowser/MiniBrowserPreBuild.cmd:
3867         * Scripts/webkitdirs.pm:
3868         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3869         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3870         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3871         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3872         * TestWebKitAPI/win/copy-resources.cmd:
3873         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3874         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3875         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3876         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3877         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3878         * WebKitTestRunner/win/InjectedBundle.vcproj:
3879         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3880         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3881         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3882         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3883         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3884         * WinLauncher/WinLauncherCommon.vsprops:
3885         * WinLauncher/WinLauncherPostBuild.cmd:
3886         * WinLauncher/WinLauncherPreBuild.cmd:
3887
3888 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3889
3890         Reviewed by Ariya Hidayat.
3891
3892         [Qt] TestNetscapePlugin doesn't link on OS X
3893         https://bugs.webkit.org/show_bug.cgi?id=51948
3894
3895         Only add a dependency on libX11 on X11 systems
3896
3897         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3898
3899 2011-01-05  Jeff Miller  <jeffm@apple.com>
3900
3901         Reviewed by Adam Roben.
3902
3903         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3904         https://bugs.webkit.org/show_bug.cgi?id=51970
3905
3906         * Scripts/webkitpy/style/checker.py:
3907         Add -readability/naming for WebKit2 C API directories.
3908
3909 2011-01-05  Eric Seidel  <eric@webkit.org>
3910
3911         Unreviewed, just fixing one more log error from my previous python patch.
3912
3913         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3914         https://bugs.webkit.org/show_bug.cgi?id=51802
3915
3916         webkit-patch failure-reason was logging about parsing errors
3917         due to my misunderstanding of how BeautifulSoup.findAll worked.
3918
3919         Fixed, and added a unit test.
3920
3921         * Scripts/webkitpy/common/net/layouttestresults.py:
3922         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3923
3924 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3925
3926         Reviewed by Kenneth Rohde Christiansen.
3927
3928         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3929         https://bugs.webkit.org/show_bug.cgi?id=51951
3930
3931         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3932         to create new window from WebKit.
3933
3934         * MiniBrowser/qt/BrowserWindow.cpp:
3935         (newPageFunction):
3936         (BrowserWindow::BrowserWindow):
3937         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3938         (BrowserWindow::newWindow):
3939         (BrowserWindow::updateUserAgentList):
3940         (BrowserWindow::showUserAgentDialog):
3941         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3942         define the type of the backing store used for new windows.
3943         * MiniBrowser/qt/main.cpp:
3944         (main):
3945
3946 2011-01-05  Eric Seidel  <eric@webkit.org>
3947
3948         Reviewed by Ojan Vafai.
3949
3950         commit-queue should report failure type when reporting flaky tests
3951         https://bugs.webkit.org/show_bug.cgi?id=51900
3952
3953         This patch was a ridiculous amount of plumbing.  In the end I like
3954         the NRWT-style TestResult class even less.  But now we're passing
3955         a list of TestResult objects from the queue to the FlakyTestReporter.
3956         Thus the FlakyTestReporter can more easily report what type of failure
3957         occurred.
3958
3959         In the process, I found that I was not alone in finding TestResult
3960         cumbersome to use.  A bunch of code was trying to create a TestResult
3961         object with default values.  However since the constructor didn't make
3962         this easy, some places were getting it wrong (including the TestResult unit test)!
3963         I've fixed the TestResult constructor to have default values for non-essential
3964         arguments.
3965
3966         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3967         * Scripts/webkitpy/common/net/layouttestresults.py:
3968         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3969         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3970         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3971         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3972         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3973         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3974         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3975         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3976         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3977         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3978         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3979         * Scripts/webkitpy/tool/commands/queues.py:
3980         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3981
3982 2011-01-05  Eric Seidel  <eric@webkit.org>
3983
3984         Unreviewed.
3985
3986         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3987         https://bugs.webkit.org/show_bug.cgi?id=51802
3988
3989         Add another unit test to cover a previously missing import.
3990
3991         * Scripts/webkitpy/common/net/layouttestresults.py:
3992         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3993
3994 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3995
3996         Reviewed by David Levin.
3997
3998         Add mihaip@chromium.org as a reviewer
3999         https://bugs.webkit.org/show_bug.cgi?id=51966
4000         
4001         Add myself as a reviewer.
4002
4003         * Scripts/webkitpy/common/config/committers.py:
4004
4005 2011-01-05  James Simonsen  <simonjam@chromium.org>
4006
4007         Unreviewed. Adding myself to the list of committers.
4008
4009         * Scripts/webkitpy/common/config/committers.py:
4010
4011 2011-01-05  Eric Seidel  <eric@webkit.org>
4012
4013         Unreviewed.
4014
4015         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
4016         https://bugs.webkit.org/show_bug.cgi?id=51802
4017
4018         Fix two exceptions seen on the bots after my original commit.
4019
4020         * Scripts/webkitpy/common/net/layouttestresults.py:
4021         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
4022
4023 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
4024
4025         Reviewed by Andreas Kling.
4026
4027         [Qt]Add local storage settings to QtTestBrowser command line arguments 
4028         https://bugs.webkit.org/show_bug.cgi?id=51750
4029
4030         * QtTestBrowser/main.cpp:
4031         (LauncherApplication::handleUserOptions):
4032          Local storage settings can be enable form command line arguments for
4033          QtTestBrowser.
4034
4035 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
4036
4037         Reviewed by Martin Robinson.
4038
4039         GTK: AX: DRT needs to use correct root object method.
4040         https://bugs.webkit.org/show_bug.cgi?id=51911
4041
4042         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
4043         (AccessibilityController::rootElement):
4044
4045 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4046
4047         Rubber-stamped by Csaba Osztrogonác.
4048
4049         Based on idea from Péter Gál.
4050
4051         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
4052
4053 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4054
4055         Reviewed by Adam Barth.
4056
4057         sheriff-bot should be able to do multi-revision rollouts
4058         https://bugs.webkit.org/show_bug.cgi?id=51176
4059
4060         * Scripts/webkitpy/tool/bot/irc_command.py:
4061         * Scripts/webkitpy/tool/bot/sheriff.py:
4062         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
4063
4064 2011-01-05  Eric Seidel  <eric@webkit.org>
4065
4066         Reviewed by Adam Barth.
4067
4068         queues.webkit.org should have per-bot status pages
4069         https://bugs.webkit.org/show_bug.cgi?id=51906
4070
4071         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
4072         statuses from a single queue.  Now that we have many bots servicing
4073         some queues (commit-queue, win-ews, etc.) its easy to have the messages
4074         you care about scroll off the end of the 15-message limit on the main page.
4075
4076         Eventually we should probably rename /queue-status to /queue or /queues,
4077         but that's fodder for another patch.
4078
4079         * QueueStatusServer/handlers/queuestatus.py:
4080         * QueueStatusServer/index.yaml:
4081         * QueueStatusServer/main.py:
4082         * QueueStatusServer/templates/includes/singlequeuestatus.html:
4083          - This probably should use a custom filter instead of hard-coding
4084            the URL scheme here, but I couldn't figure out how to easily
4085            create such a filter.  Most filters work with "strings" so we can't
4086            pass the status object.  We could add a method to the status
4087            object and call that, but that seemed a bit strange too.
4088         * QueueStatusServer/templates/queuestatus.html:
4089
4090 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
4091
4092         Unreviewed. Adding myself to the list of committers.
4093
4094         * Scripts/webkitpy/common/config/committers.py:
4095
4096 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
4097
4098         Reviewed by David Levin.
4099
4100         check-webkit-style treated some macros with parentheses after #elif as function calls
4101         https://bugs.webkit.org/show_bug.cgi?id=51695
4102
4103         Ingore function call space checking in any preprocessor directives
4104         (things starting with #). Change search() to match() because 
4105         preprocessor directives are supposed to be in the beginning of lines.
4106
4107         * Scripts/webkitpy/style/checkers/cpp.py:
4108         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
4109
4110 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
4111
4112         Reviewed by Tony Chang.
4113
4114         Change the --multi-load test option to --stress-opt
4115         https://bugs.webkit.org/show_bug.cgi?id=50751
4116
4117         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4118         (runTest):
4119         (main):
4120         * DumpRenderTree/chromium/TestShell.cpp:
4121         (TestShell::TestShell):
4122         * DumpRenderTree/chromium/TestShell.h:
4123         (TestShell::stressOpt):
4124         (TestShell::setStressOpt):
4125         (TestShell::stressDeopt):
4126         (TestShell::setStressDeopt):
4127         (TestShell::javaScriptFlags):
4128         (TestShell::setJavaScriptFlags):
4129         * Scripts/webkitpy/layout_tests/port/chromium.py:
4130         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4131
4132 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
4133
4134         Reviewed by Sam Weinig.
4135
4136         WK2: Support Accessibility
4137         https://bugs.webkit.org/show_bug.cgi?id=51859
4138
4139         Use rootObject() method to get top of accessibility tree.
4140
4141         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4142         (AccessibilityController::focusedElement):
4143         (AccessibilityController::rootElement):
4144
4145 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
4146
4147         Reviewed by Darin Adler.
4148
4149         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
4150         https://bugs.webkit.org/show_bug.cgi?id=51846
4151
4152         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
4153         back to GRefPtr.
4154
4155 2011-01-04  Zhe Su  <suzhe@chromium.org>
4156
4157         Reviewed by Kenneth Russell.
4158
4159         Fix insertText, setMarkedText and unmarkText methods of
4160         TextInputController to call corresponding methods of WebKit::WebView
4161         rather than WebKit::WebFrame. This change matches the behavior of
4162         chromium browser.
4163         insertText corresponds to WebView::confirmComposition(text)
4164         setMarkedText corresponds to WebView::setComposition(...)
4165         unmarkText corresponds to WebView::confirmComposition()
4166         https://bugs.webkit.org/show_bug.cgi?id=51693
4167
4168         * DumpRenderTree/chromium/TextInputController.cpp:
4169         (TextInputController::insertText):
4170         (TextInputController::setMarkedText):
4171         (TextInputController::unmarkText):
4172
4173 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
4174
4175         Reviewed by Laszlo Gombos.
4176
4177         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
4178
4179         On Symbian productDir points to the source directory. Removing all the
4180         empty files from the productDir directory corrupts the svn repository.
4181
4182         * Scripts/build-webkit:
4183
4184 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
4185
4186         Reviewed by Adam Barth.
4187
4188         [Qt] Add SelectAll option to the context menu for the editor
4189         https://bugs.webkit.org/show_bug.cgi?id=50049
4190
4191         Set shortcut for the SelectAll action.
4192
4193         * QtTestBrowser/mainwindow.cpp:
4194         (MainWindow::buildUI):
4195
4196 2011-01-03  David Levin  <levin@chromium.org>
4197
4198         Reviewed by Eric Seidel.
4199
4200         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
4201         https://bugs.webkit.org/show_bug.cgi?id=51842
4202
4203         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
4204         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
4205
4206 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
4207
4208         Reviewed by David Kilzer.
4209
4210         [WINCE] Adds a build slave.
4211         https://bugs.webkit.org/show_bug.cgi?id=50523
4212
4213         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
4214         entry for a release build of the WinCE port.
4215         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
4216         flag to build the WinCE port.
4217
4218 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
4219
4220         Reviewed by David Kilzer.
4221
4222         Add WinCE support to build-webkit
4223         https://bugs.webkit.org/show_bug.cgi?id=51642
4224
4225         * Scripts/build-webkit:
4226         * Scripts/webkitdirs.pm:
4227
4228 2011-01-03  Eric Seidel  <eric@webkit.org>
4229
4230         Reviewed by Adam Barth.
4231
4232         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
4233         https://bugs.webkit.org/show_bug.cgi?id=51802
4234
4235         I'm not the biggest fan of the test_failures or test_results classes,
4236         but it's better to have one shared set of classes, than separate ones
4237         for new vs. old run-webkit-test result handling.
4238
4239         This moves the ORWT results class "LayoutTestResults" over to using
4240         TestResult and TestFailure classes, making it easy for us to
4241         make all our sheriff-bot and other webkitpy code NRWT ready.
4242
4243         This also makes it a trivial patch to generate results.json information
4244         from ORWT results.html files (for flaky test analysis, etc.) as well
4245         as making it a one-liner to report test failure types when the
4246         commit-queue sees flaky tests.
4247
4248         This patch tried not to add new functionality, but only to replace
4249         the guts of LayoutTestResults, while adding unit tests and hoping
4250         not to break anything.
4251
4252         I also moved callers which assumed User.prompt* were static/class methods
4253         to using them as instance methods (since we'll eventually want to make them such).
4254
4255         In the process of re-writing things, I broke the rebaseline command, so I wrote
4256         a unit test to catch my breakage were I do do so again in the future.
4257
4258         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4259         * Scripts/webkitpy/common/net/layouttestresults.py:
4260         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
4261         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
4262         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
4263         * Scripts/webkitpy/tool/commands/queries.py:
4264         * Scripts/webkitpy/tool/commands/rebaseline.py:
4265         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4266         * Scripts/webkitpy/tool/mocktool.py:
4267
4268 2011-01-03  Adam Barth  <abarth@webkit.org>
4269
4270         Reviewed by Simon Fraser.
4271
4272         webkit-patch shouldn't waste time cleaning a working directory that's already clean
4273         https://bugs.webkit.org/show_bug.cgi?id=51840
4274
4275         * Scripts/webkitpy/common/checkout/scm.py:
4276
4277 2011-01-03  Adam Barth  <abarth@webkit.org>
4278
4279         Reviewed by Simon Fraser.
4280
4281         webkit-patch should only hide update output if --quiet
4282         https://bugs.webkit.org/show_bug.cgi?id=51838
4283
4284         As requested by smfr.
4285
4286         * Scripts/webkitpy/tool/steps/update.py:
4287
4288 2011-01-03  Adam Barth  <abarth@webkit.org>
4289
4290         Reviewed by David Levin.
4291
4292         commit-queue shouldn't reject patches twice if two bots process the same patch
4293         https://bugs.webkit.org/show_bug.cgi?id=51805
4294
4295         Before raising an error, we first check whether the patch is still in
4296         the commit-queue.  This check is still racy, of course, but the time
4297         window is much smaller.
4298
4299         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4300
4301 2011-01-03  Sam Weinig  <sam@webkit.org>
4302
4303         Reviewed by Anders Carlsson.
4304
4305         Make run-api-tests less chatty.
4306         https://bugs.webkit.org/show_bug.cgi?id=51831
4307
4308         - Make script quiet by default and add --verbose option (replacing --quiet).
4309         - When not verbose, pipe stdout and stderr to devnull.
4310
4311         * Scripts/run-api-tests:
4312
4313 2011-01-03  Pratik Solanki  <psolanki@apple.com>
4314
4315         Unreviewed. Adding myself to committers.py.
4316
4317         * Scripts/webkitpy/common/config/committers.py:
4318
4319 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
4320
4321         Reviewed by Xan Lopez.
4322
4323         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
4324         https://bugs.webkit.org/show_bug.cgi?id=51806
4325
4326         Originally, the $libraryName is 'JavaScriptCore'. When building release 
4327         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
4328         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
4329         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
4330         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
4331         so make it 'WebKitBuild/Release/.libs'
4332
4333         * Scripts/webkitdirs.pm: 
4334
4335 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
4336
4337         Reviewed by Adam Barth.
4338
4339         Make EFL a core builder
4340         https://bugs.webkit.org/show_bug.cgi?id=51804
4341
4342         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4343         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4344
4345 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4346
4347         [Qt] Unreviewed fix after r74855 and r74875.
4348
4349         * BuildSlaveSupport/built-product-archive:
4350          - Create directories explicitly.
4351          - Pass shell=True to subprocess.call().
4352
4353 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4354
4355         [Qt] Unreviewed fix after r74855.
4356
4357         Move JavaScriptCore to Source
4358         https://bugs.webkit.org/show_bug.cgi?id=51604
4359
4360         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
4361
4362 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4363
4364         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
4365
4366         Move JavaScriptCore to Source
4367         https://bugs.webkit.org/show_bug.cgi?id=51604
4368
4369         * Scripts/webkitdirs.pm:
4370
4371 2011-01-02  Robert Hogan  <robert@webkit.org>
4372
4373         Unreviewed, build fix.
4374
4375         [Qt] Fix DRT build after 74855
4376
4377         * DumpRenderTree/qt/DumpRenderTree.pro:
4378
4379 2011-01-01  Adam Barth  <abarth@webkit.org>
4380
4381         Remove the assumption from the Qt and Gtk builds that every project is
4382         in the root directory.
4383
4384         * Scripts/build-webkit:
4385
4386 2011-01-01  Adam Barth  <abarth@webkit.org>
4387
4388         Reviewed by Eric Seidel.
4389
4390         Teach svn-apply how to apply patches even though JavaScriptCore has moved
4391         https://bugs.webkit.org/show_bug.cgi?id=51796
4392
4393         After this change, svn-apply will magically apply patches to
4394         JavaScriptCore/foo to Source/JavaScriptCore/foo.
4395
4396         * Scripts/VCSUtils.pm:
4397
4398 2011-01-01  Adam Barth  <abarth@webkit.org>
4399
4400         Reviewed by Eric Seidel.
4401
4402         Move JavaScriptCore to Source
4403         https://bugs.webkit.org/show_bug.cgi?id=51604
4404
4405         Update references to JavaScriptCore to point to the new location.
4406
4407         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4408         * DumpRenderTree/qt/DumpRenderTree.pro:
4409         * DumpRenderTree/qt/ImageDiff.pro:
4410         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4411         * DumpRenderTree/wscript:
4412         * Scripts/build-jsc:
4413         * Scripts/build-webkit:
4414         * Scripts/do-file-rename:
4415         * Scripts/do-webcore-rename:
4416         * Scripts/run-javascriptcore-tests:
4417         * Scripts/update-javascriptcore-test-results:
4418         * Scripts/webkitdirs.pm:
4419         * Scripts/webkitpy/common/config/build_unittest.py:
4420         * Scripts/webkitpy/style/checker.py:
4421         * Scripts/webkitpy/style/checker_unittest.py:
4422         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4423         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4424         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4425         * wx/build/settings.py:
4426
4427 2011-01-01  Adam Barth  <abarth@webkit.org>
4428
4429         Reviewed by Eric Seidel.
4430
4431         Move Sources to Source
4432         https://bugs.webkit.org/show_bug.cgi?id=51794
4433
4434         Update scripts to point to the new location.
4435
4436         * Scripts/build-webkit:
4437         * Scripts/do-file-rename:
4438         * Scripts/do-webcore-rename:
4439         * Scripts/webkitpy/common/config/build.py:
4440         * Scripts/webkitpy/common/config/build_unittest.py:
4441
4442 2010-12-31  Kent Tamura  <tkent@chromium.org>
4443
4444         Reviewed by Eric Seidel.
4445
4446         [DRT/Chromium] Enable mock spell checker on non-OSX
4447         https://bugs.webkit.org/show_bug.cgi?id=51401
4448
4449         * DumpRenderTree/chromium/WebViewHost.cpp:
4450         (WebViewHost::spellCheck):
4451
4452 2010-12-31  Adam Barth  <abarth@webkit.org>
4453
4454         Reviewed by Ariya Hidayat.
4455
4456         Remove Tools/Scripts/wkstyle
4457         https://bugs.webkit.org/show_bug.cgi?id=51774
4458
4459         This script appears to not have been touched in a while and seems to
4460         have been replaced by check-webkit-style.
4461
4462         * Scripts/wkstyle: Removed.
4463
4464 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4465
4466         Unreviewed. Coding style fix.
4467
4468         * DumpRenderTree/chromium/TestShell.h:
4469
4470 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4471
4472         Reviewed by Pavel Feldman.
4473
4474         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
4475
4476         It was a problem with Chromium DRT. DevToolsAgent object instance was
4477         attached not only to the inspected page but to the DevTools window too.
4478         As result all the inspector files were interpreted as a content of inspected page
4479         and were transfered to the DevTools scripts panel for debugging etc.
4480
4481         https://bugs.webkit.org/show_bug.cgi?id=51735
4482
4483         * DumpRenderTree/chromium/TestShell.cpp:
4484         (TestShell::TestShell):
4485         (TestShell::bindJSObjectsToWindow):
4486         (TestShell::createNewWindow):
4487         * DumpRenderTree/chromium/TestShell.h:
4488
4489 2010-12-31  Adam Barth  <abarth@webkit.org>
4490
4491         Rubber-stamped by Eric Seidel.
4492
4493         Move PageLoadTests to PerformanceTests/PageLoad
4494         https://bugs.webkit.org/show_bug.cgi?id=51771
4495
4496         Update references to PageLoadTests to point to the new location.
4497
4498         * Scripts/run-pageloadtest:
4499         * Scripts/webkitpy/common/config/build.py:
4500
4501 2010-12-31  Adam Barth  <abarth@webkit.org>
4502
4503         Rubber-stamped by Eric Seidel.
4504
4505         Move SunSpider into PerformanceTests
4506         https://bugs.webkit.org/show_bug.cgi?id=51769
4507
4508         Update these scripts to point to the new location.
4509
4510         * Scripts/run-sunspider:
4511         * Scripts/sunspider-compare-results:
4512
4513 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
4514
4515         Reviewed by Kent Tamura.
4516
4517         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
4518         https://bugs.webkit.org/show_bug.cgi?id=51728
4519    &nbs