222a7642603dcb40cd0976d9edff39d5854d0908
[WebKit.git] / Tools / ChangeLog
1 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r136784 and r136802.
4         http://trac.webkit.org/changeset/136784
5         http://trac.webkit.org/changeset/136802
6         https://bugs.webkit.org/show_bug.cgi?id=104231
7
8         breaks chromium canary (Requested by morrita on #webkit).
9
10         * Scripts/webkitpy/common/config/build_unittest.py:
11         (ShouldBuildTest):
12
13 2012-12-05  Ryosuke Niwa  <rniwa@webkit.org>
14
15         Add myself to watch changes in PerformanceTests/*.
16
17         * Scripts/webkitpy/common/config/watchlist:
18
19 2012-12-05  Shinya Kawanaka  <shinyak@chromium.org>
20
21         [Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
22         https://bugs.webkit.org/show_bug.cgi?id=102459
23
24         Reviewed by Dimitri Glazkov.
25
26         Since WebThemeControlDRTWin::markState does not consider indeterminate state, DRT caused a crash.
27
28         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
29         (WebThemeControlDRTWin::markState):
30
31 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
32
33         DFG profiler should be able to display where a code block was inlined into, and what it inlined
34         https://bugs.webkit.org/show_bug.cgi?id=104216
35
36         Reviewed by Oliver Hunt.
37
38         Added an "inlines" command that shows the inline stacks that a code block participated
39         in. Also cleaned up some of the ways we print compilation units.
40
41         * Scripts/display-profiler-output:
42
43 2012-12-05  Halton Huo  <halton.huo@intel.com>
44
45         [CMake] Unify coding style for CMake files
46         https://bugs.webkit.org/show_bug.cgi?id=103605
47
48         Reviewed by Laszlo Gombos.
49
50         Update cmake files(.cmake, CMakeLists.txt) with following style rules:
51         1. Indentation
52         1.1 Use spaces, not tabs.
53         1.2 Four spaces as indent.
54         2. Spacing
55         2.1 Place one space between control statements and their parentheses.
56             For eg, if (), else (), elseif (), endif (), foreach (),
57             endforeach (), while (), endwhile (), break ().
58         2.2 Do not place spaces between function and macro statements and
59             their parentheses. For eg, macro(), endmacro(), function(),
60             endfunction().
61         2.3 Do not place spaces between a command or function or macro and its
62             parentheses, or between a parenthesis and its content. For eg,
63             message("testing") not message( "testing") or message ("testing" )
64         2.4 No space at line ending.
65         3. Lowercase when call commands macros and functions. For eg,
66            add_executable() not ADD_EXECUTABLE(), set() not SET().
67
68         * CMakeLists.txt:
69         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
70         * DumpRenderTree/efl/CMakeLists.txt:
71         * EWebLauncher/CMakeLists.txt:
72         * EWebLauncher/ControlTheme/CMakeLists.txt:
73         * MiniBrowser/efl/CMakeLists.txt:
74         * TestWebKitAPI/CMakeLists.txt:
75         * TestWebKitAPI/PlatformEfl.cmake:
76         * WebKitTestRunner/CMakeLists.txt:
77         * WebKitTestRunner/PlatformEfl.cmake:
78         * WinCELauncher/CMakeLists.txt:
79         * clang/ReportMemoryUsagePlugin/CMakeLists.txt:
80
81 2012-12-05  Scott Violet  <sky@chromium.org>
82
83         [chromium] Remove linux theme related files and switch to default
84         https://bugs.webkit.org/show_bug.cgi?id=103897
85
86         Reviewed by Tony Chang.
87
88         * Scripts/webkitpy/common/config/build_unittest.py:
89         (ShouldBuildTest): linux->default
90
91 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
92
93         nrwt: run_webkit_tests_integrationtest.py depends on being able to share a port w/ between master and worker
94         https://bugs.webkit.org/show_bug.cgi?id=78168
95
96         Reviewed by Ojan Vafai.
97
98         This patch adds a single ordered list to ResultSummary that contains
99         the results of every test run in order of result received, and
100         modifies the TestResults class to contain the list of references used
101         for each test as well as the pid of the driver; this allows us to stop
102         having to override the test drivers to record the tests, and makes the
103         integration tests that test rdering, retries, restarts, etc. black-box
104         tests.
105
106         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
107         (SingleTestRunner._run_rebaseline):
108         (SingleTestRunner._compare_output):
109         (SingleTestRunner._run_reftest):
110         (SingleTestRunner._compare_output_with_reference):
111         * Scripts/webkitpy/layout_tests/models/result_summary.py:
112         (ResultSummary.__init__):
113         (ResultSummary.add):
114         * Scripts/webkitpy/layout_tests/models/test_results.py:
115         (TestResult.__init__):
116         * Scripts/webkitpy/layout_tests/port/driver.py:
117         (DriverOutput.__init__):
118         (Driver.run_test):
119         * Scripts/webkitpy/layout_tests/port/test.py:
120         (TestDriver):
121         (TestDriver.__init__):
122         (TestDriver.run_test):
123         (TestDriver.stop):
124         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
125         (get_tests_run):
126         (get_test_batches):
127         (get_test_results):
128         (MainTest.test_batch_size):
129         (MainTest.test_dryrun):
130         (MainTest.test_natural_order):
131         (MainTest.test_natural_order_test_specified_multiple_times):
132         (MainTest.test_random_order):
133         (MainTest.test_random_order_test_specified_multiple_times):
134         (MainTest.test_no_order):
135         (MainTest.test_no_order_test_specified_multiple_times):
136         (MainTest.test_no_order_with_directory_entries_in_natural_order):
137         (MainTest.test_repeat_each):
138         (MainTest.test_ignore_flag):
139         (MainTest.test_skipped_flag):
140         (MainTest.test_iterations):
141         (MainTest.test_run_chunk):
142         (MainTest.test_run_part):
143         (MainTest.test_run_singly):
144         (MainTest.test_skip_failing_tests):
145         (MainTest.test_single_file):
146         (MainTest.test_single_file_with_prefix):
147         (MainTest.test_single_skipped_file):
148         (MainTest.test_test_list):
149         (MainTest.test_test_list_with_prefix):
150         (MainTest.test_exit_after_n_failures):
151         (MainTest.test_exit_after_n_crashes):
152         (MainTest.test_run_order__inline):
153         (MainTest.test_reftest_run):
154         (MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
155         (MainTest.test_reftest_skip_reftests_if_no_ref_tests):
156         (MainTest.test_reftest_expected_html_should_be_ignored):
157         (MainTest.test_reftest_driver_should_run_expected_html):
158         (MainTest.test_reftest_driver_should_run_expected_mismatch_html):
159         (MainTest.test_no_http_tests):
160         (MainTest.test_platform_tests_are_found):
161
162 2012-12-05  Dana Jansens  <danakj@chromium.org>
163
164         [chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
165         https://bugs.webkit.org/show_bug.cgi?id=103967
166
167         Reviewed by James Robinson.
168
169         Use the WebCompositorSupport methods to create an OutputSurface. If they
170         fail, then fall back to the WebViewHost methods.
171
172         Once the chromium side lands, the WebCompositorSupport methods will stop
173         failing, and will replace the WebViewHost ones.
174
175         * DumpRenderTree/chromium/WebViewHost.cpp:
176         (WebViewHost::createOutputSurface):
177
178 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
179
180         nrwt: split all of the buildbot-specific output into its own file
181         https://bugs.webkit.org/show_bug.cgi?id=104165
182
183         Reviewed by Ojan Vafai.
184
185         Now that we have the RunDetails object we can move all of the
186         buildbot-specific knowledge out of the core test-running code
187         and into the outermost run_webkit_tests layer.
188
189         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
190         (run):
191         (main):
192         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
193         (passing_run):
194         (logging_run):
195         (run_and_capture):
196         (MainTest.test_all):
197         (MainTest.test_max_locked_shards):
198         (MainTest.test_child_processes_2):
199         (MainTest.test_child_processes_min):
200         (MainTest.test_full_results_html):
201         (MainTest.test_hung_thread):
202         (MainTest.test_keyboard_interrupt):
203         (MainTest.test_no_tests_found):
204         (MainTest.test_no_tests_found_2):
205         (MainTest.test_repeat_each_iterations_num_tests):
206         (MainTest.test_run_singly_actually_runs_tests):
207         (MainTest.test_test_list):
208         (MainTest.test_unexpected_failures):
209         (MainTest.test_missing_and_unexpected_results):
210         (MainTest.test_pixel_test_directories):
211         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
212         (MainTest.test_crash_with_stderr):
213         (MainTest.test_no_image_failure_with_image_diff):
214         (MainTest.test_crash_log):
215         (MainTest.test_web_process_crash_log):
216         (MainTest.test_exit_after_n_failures_upload):
217         (MainTest.test_results_directory_absolute):
218         (MainTest.test_results_directory_default):
219         (MainTest.test_results_directory_relative):
220         (MainTest.test_retrying_and_flaky_tests):
221         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
222         (MainTest.test_output_diffs):
223         (MainTest.test_unsupported_platform):
224         (MainTest.test_verbose_in_child_processes):
225         (EndToEndTest.test_end_to_end):
226         (EndToEndTest.test_reftest_with_two_notrefs):
227         (RebaselineTest.test_reset_results):
228         (RebaselineTest.test_missing_results):
229         (RebaselineTest.test_new_baseline):
230         * Scripts/webkitpy/layout_tests/views/buildbot_results.py: Added.
231         (BuildBotPrinter):
232         (BuildBotPrinter.__init__):
233         (BuildBotPrinter.print_results):
234         (BuildBotPrinter._print):
235         (BuildBotPrinter.print_result_summary):
236         (BuildBotPrinter._print_result_summary_entry):
237         (BuildBotPrinter.print_unexpected_results):
238         (BuildBotPrinter.print_unexpected_results.add_to_dict_of_lists):
239         (BuildBotPrinter.print_unexpected_results.add_result):
240         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py: Added.
241         (BuildBotPrinterTests):
242         (BuildBotPrinterTests.assertEmpty):
243         (BuildBotPrinterTests.assertNotEmpty):
244         (BuildBotPrinterTests.get_printer):
245         (BuildBotPrinterTests.get_result):
246         (BuildBotPrinterTests.get_result_summary):
247         (BuildBotPrinterTests.test_print_unexpected_results):
248         (BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
249         * Scripts/webkitpy/layout_tests/views/printing.py:
250         (Printer):
251         (Printer.__init__):
252         (Printer.print_results):
253         (Printer._print_statistics_for_test_timings):
254         (Printer._print_baseline):
255         (Printer._print_debug):
256         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
257         (Testprinter.get_printer):
258         (Testprinter.get_result):
259         (Testprinter.test_configure_and_cleanup):
260         (Testprinter.test_print_config):
261         (Testprinter.test_print_one_line_summary):
262         (Testprinter.test_test_status_line):
263         (Testprinter.test_details):
264
265 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
266
267         nrwt: collect all of the information about a run into a new RunDetails class
268         https://bugs.webkit.org/show_bug.cgi?id=104158
269
270         Reviewed by Ojan Vafai.
271
272         This patch collects the information from both test passes (the
273         main one and the retries) as well as the summarized results and
274         the exit code into a RunDetails class, so that the integration
275         tests can more easily tell what happened.
276
277         Also, change the way the --lint-test-files works slightly so that
278         we don't need to create a printer object (and hence we need to
279         rework the tests that are testing logging).
280
281         * Scripts/webkitpy/layout_tests/controllers/manager.py:
282         (RunDetails):
283         (RunDetails.__init__):
284         (Manager.run):
285         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
286         (run):
287         (main):
288         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
289         (passing_run):
290         (run_and_capture):
291         (LintTest.test_lint_test_files):
292         (LintTest.test_lint_test_files__errors):
293         (MainTest.test_verbose_in_child_processes):
294
295 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
296
297         nrwt: remove --no-record-results
298         https://bugs.webkit.org/show_bug.cgi?id=104072
299
300         Reviewed by Ojan Vafai.
301
302         The command line flag was only being used in the unit tests and
303         wasn't really needed once we started using a mock filesystem.
304
305         Also, reformat a bunch of long lines ...
306
307         * Scripts/webkitpy/layout_tests/controllers/manager.py:
308         (Manager.run):
309         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
310         (parse_args):
311         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
312         (parse_args):
313         (passing_run):
314         (logging_run):
315         (MainTest.test_repeat_each_iterations_num_tests):
316         (MainTest.test_test_list):
317         (MainTest.test_missing_and_unexpected_results):
318         (MainTest.test_pixel_test_directories):
319         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
320         (MainTest.test_crash_with_stderr):
321         (MainTest.test_no_image_failure_with_image_diff):
322         (MainTest.test_crash_log):
323         (MainTest.test_web_process_crash_log):
324         (MainTest.test_exit_after_n_failures_upload):
325         (MainTest.test_results_directory_absolute):
326         (MainTest.test_results_directory_relative):
327         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
328         (MainTest.test_additional_expectations):
329         (MainTest.test_output_diffs):
330         (EndToEndTest.test_end_to_end):
331         (EndToEndTest.test_reftest_with_two_notrefs):
332         (RebaselineTest.test_reset_results):
333         (RebaselineTest.test_missing_results):
334         (RebaselineTest.test_new_baseline):
335
336 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
337
338         nrwt: only summarize the results one way
339         https://bugs.webkit.org/show_bug.cgi?id=104064
340
341         Reviewed by Ojan Vafai.
342
343         Change manager.summarize_results so that we always (and only)
344         include both expected and unexpected results. Previously we
345         would summarize the results twice, once with expected results
346         and once without. This made the code much more confusing than
347         it needed to be.
348
349         * Scripts/webkitpy/layout_tests/controllers/manager.py:
350         (summarize_results):
351         (Manager.run):
352         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
353         (ResultSummaryTest.summarized_results):
354         (ResultSummaryTest.test_no_svn_revision):
355         (ResultSummaryTest.test_svn_revision):
356         (ResultSummaryTest.test_summarized_results_wontfix):
357         * Scripts/webkitpy/layout_tests/views/printing.py:
358         (Printer.print_results):
359         (Printer._print_unexpected_results):
360         (Printer._print_unexpected_results.add_result):
361         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
362         (Testprinter.test_print_unexpected_results.get_unexpected_results):
363         (Testprinter):
364
365 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
366
367         DFG profiler should display more information
368         https://bugs.webkit.org/show_bug.cgi?id=104163
369
370         Reviewed by Gavin Barraclough.
371
372         Added the following:
373         
374         - Distinguish between source counts and bytecode counts.
375         
376         - Add a "full" summary view that shows both kinds of counts, plus inline counts.
377         
378         - Add a "source" command to see the source.
379         
380         - Add a "bytecode" command to see the bytecode and counts.
381
382         * Scripts/display-profiler-output:
383
384 2012-12-05  Yong Li  <yoli@rim.com>
385
386         [BlackBerry] Build with libjpegturbo
387         https://bugs.webkit.org/show_bug.cgi?id=104152
388
389         Reviewed by Rob Buis.
390
391         RIM PR# 196975.
392         Make sure the right include path for libjpeg is included.
393
394         * Scripts/webkitdirs.pm:
395         (blackberryCMakeArguments):
396
397 2012-12-05  Joseph Pecoraro  <pecoraro@apple.com>
398
399         Remove stale check in check-for-webkit-framework-include-consistency
400         https://bugs.webkit.org/show_bug.cgi?id=103775
401
402         Reviewed by David Kilzer.
403
404         The underlying issue was fixed in r81173.
405
406         * Scripts/check-for-webkit-framework-include-consistency:
407
408 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
409
410         nrwt: simplify the finding of tests to retry
411         https://bugs.webkit.org/show_bug.cgi?id=104067
412
413         Reviewed by Ryosuke Niwa.
414
415         I think this makes the code a little clearer; note that
416         we were no longer using the include_missing flag.
417
418         * Scripts/webkitpy/layout_tests/controllers/manager.py:
419         (Manager.run):
420         (Manager._failed_test_names):
421
422 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
423
424         nrwt: remove two unused parameters from a function
425         https://bugs.webkit.org/show_bug.cgi?id=104059
426
427         Reviewed by Ryosuke Niwa.
428
429         Also remove an old, stale FIXME.
430
431         * Scripts/webkitpy/layout_tests/controllers/manager.py:
432         (interpret_test_failures):
433         (summarize_results):
434         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
435         (ResultSummaryTest.test_interpret_test_failures):
436
437 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
438
439         nrwt: return result_summaries from LayoutTestRunner.run_tests()
440         https://bugs.webkit.org/show_bug.cgi?id=104051
441
442         Reviewed by Ojan Vafai.
443
444         This patch completes the refactoring that makes the result summary      
445         an object returned from the layout test runner, rather than having      
446         it passed in and modified. This makes the split of duties between       
447         the manager and runner clearer and makes the data flow more             
448         functionally.                                                           
449
450         Also clean up some minor lint issues.
451
452         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
453         (LayoutTestRunner.__init__):
454         (LayoutTestRunner.run_tests):
455         (LayoutTestRunner._mark_interrupted_tests_as_skipped):
456         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
457         (FakePrinter.print_expected):
458         (LockCheckingRunner.__init__):
459         (LayoutTestRunnerTests._runner):
460         (LayoutTestRunnerTests._run_tests):
461         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
462         * Scripts/webkitpy/layout_tests/controllers/manager.py:
463         (Manager.__init__):
464         (Manager.run):
465         (Manager._run_tests):
466
467 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
468
469         nrwt: move creation of the resultsummary objects into Manager._run_tests()
470         https://bugs.webkit.org/show_bug.cgi?id=104048
471
472         Reviewed by Ojan Vafai.
473
474         This is a preparatory step to making the resultsummary just get
475         returned from the layout_test_runner; this does most of manager-side
476         changes.
477
478         * Scripts/webkitpy/layout_tests/controllers/manager.py:
479         (Manager._prepare_lists):
480         (Manager.run):
481         (Manager._run_tests):
482
483 2012-12-05  Leo Yang  <leoyang@rim.com>
484
485         [BlackBerry] Enable CSS_IMAGE_RESOLUTION
486         https://bugs.webkit.org/show_bug.cgi?id=104132
487
488         Reviewed by Yong Li.
489
490         * Scripts/webkitperl/FeatureList.pm:
491
492 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
493
494         JSC profiler should not count executions of op_call_put_result because doing so changes DFG codegen
495         https://bugs.webkit.org/show_bug.cgi?id=104102
496
497         Reviewed by Oliver Hunt.
498
499         Modify the profiler to not output counts for op_call_put_result, since there
500         won't be any. Also fix a few weird bugs, like providing better error reporting
501         when you type something incorrectly and not reporting counts for slow paths
502         in the old JIT since those counts are actually not what you think they are
503         (we don't actually count slow path executions separately).
504
505         * Scripts/display-profiler-output:
506
507 2012-12-05  Andras Becsi  <andras.becsi@digia.com>
508
509         Fix compilation for Qt5.0.0 stable branch.
510         https://bugs.webkit.org/show_bug.cgi?id=103870
511
512         Reviewed by Simon Hausmann.
513
514         Fix the use of renamed QWindow functions.
515         Patch by Andras Becsi <andras.becsi@digia.com>
516
517         * MiniBrowser/qt/BrowserWindow.cpp:
518         (BrowserWindow::BrowserWindow):
519         (BrowserWindow::onTitleChanged):
520         * MiniBrowser/qt/raw/View.cpp:
521         (View::View):
522
523 2012-12-05  Jussi Kukkonen  <jussi.kukkonen@intel.com>
524
525         [WK2] InjectedBundle should check Intent url for null
526         https://bugs.webkit.org/show_bug.cgi?id=104117
527
528         Reviewed by Kenneth Rohde Christiansen.
529
530         WKIntentServiceInfoCopyHref() can return null, we need to check
531         for that in InjectedBundlePage::registerIntentServiceForFrame()
532         to avoid crashing.
533
534         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
535         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
536
537 2012-12-04  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
538
539         Change email address of Jonathan Dong
540         https://bugs.webkit.org/show_bug.cgi?id=103976
541
542         Unreviewed, change my email address from jonathan.dong@torchmobile.com.cn
543         to jonathan.dong.webkit@gmail.com in committers list.
544
545         * Scripts/webkitpy/common/config/committers.py:
546
547 2012-12-04  Xiaobo Wang  <xbwang@torchmobile.com.cn>
548
549         [BlackBerry] DRT - Tests under "dumpAsText" directory should be dumped as text
550         https://bugs.webkit.org/show_bug.cgi?id=103986
551
552         Reviewed by Rob Buis.
553
554         Also move declaration of webSettingTransaction to before any WebSettings
555         ::setXXX() calls so that it works as expected (commit only once in the
556         function scope).
557
558         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
559         (shouldDumpAsText):
560         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
561
562 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
563
564         display-profiler-output should be able to show source code
565         https://bugs.webkit.org/show_bug.cgi?id=104073
566
567         Reviewed by Oliver Hunt.
568
569         Display source code in the summary, using a one-line shortening.
570
571         * Scripts/display-profiler-output:
572
573 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
574
575         display-profiler-output should not use reflective infocation to resolve command names
576
577         Rubber stamped by Mark Hahnenberg.
578
579         Reflection is amazing, but here it was just kind of a bit much.
580
581         * Scripts/display-profiler-output:
582
583 2012-12-02  Filip Pizlo  <fpizlo@apple.com>
584
585         JSC should be able to report profiling data associated with the IR dumps and disassembly
586         https://bugs.webkit.org/show_bug.cgi?id=102999
587
588         Reviewed by Gavin Barraclough.
589
590         Added a tool that allows you to grok the output from JSC's new profiler. Currently,
591         this still gets confused a bit about the execution counts of a method running
592         standalone versus a method running inlined, but other than that, it's pretty cool.
593         See the attached "sampling profiling session" attached to the bug to see it in
594         action.
595         
596         Also had to feed EFL's build system.
597
598         * DumpRenderTree/efl/CMakeLists.txt:
599         * Scripts/display-profiler-output: Added.
600
601 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
602
603         nrwt: fix total number of tests computed in the result summary
604         https://bugs.webkit.org/show_bug.cgi?id=104061
605
606         Unreviewed, build fix.
607
608         One of the recent changes to the resultsummary refactoring caused
609         us to not include the number of skipped tests in the total number
610         of tests, throwing off the totals printed in print_one_line_summary().
611
612         Unfortunately, given the current state of the code it is difficult
613         to construct an accurate unit test for this. I have verified the
614         fix by hand, and will write a test once the remaining refactoring
615         patches land, at which point it will be trivial to test it.
616
617         * Scripts/webkitpy/layout_tests/controllers/manager.py:
618         (Manager._prepare_lists):
619
620 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
621
622         nrwt is not returning the exit status properly
623         https://bugs.webkit.org/show_bug.cgi?id=103830
624
625         Unreviewed, build fix.
626
627         The fix in r136474 wasn't quite right either, and would return
628         the correct exceptional status, but not the correct failing status.
629
630         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
631
632 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
633
634         nrwt: make paths and test_names passed arguments in Manager._prepare_lists et al
635         https://bugs.webkit.org/show_bug.cgi?id=104047
636
637         Reviewed by Eric Seidel.
638
639         The code becomes cleaner if we are just passing values around rather
640         than hanging them off the manager object, helps move _prepare_lists()
641         to a pure function, and is needed to eventually make the
642         result_summary object something returned from runner.run_tests()
643         (note that two more patches are needed for that to happen).
644
645         * Scripts/webkitpy/layout_tests/controllers/manager.py:
646         (Manager.__init__):
647         (Manager._http_tests):
648         (Manager._prepare_lists):
649         (Manager.needs_servers):
650         (Manager._set_up_run):
651         (Manager.run):
652         (Manager._run_tests):
653         (Manager._upload_json_files):
654         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
655         (ManagerTest.test_needs_servers.get_manager):
656         (ManagerTest.test_needs_servers):
657         (ManagerTest.integration_test_needs_servers.get_manager):
658         (ManagerTest.integration_test_needs_servers):
659         (ManagerTest.test_look_for_new_crash_logs.get_manager):
660         (ManagerTest):
661         (ManagerTest.test_look_for_new_crash_logs):
662         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
663         (JSONLayoutResultsGenerator.__init__):
664         (JSONLayoutResultsGenerator._get_modifier_char):
665
666 2012-12-04  Adam Barth  <abarth@webkit.org>
667
668         commit-queue can get stuck with a local commit
669         https://bugs.webkit.org/show_bug.cgi?id=104032
670
671         Reviewed by Dirk Pranke.
672
673         Previously the commit-queue would only clean down to HEAD. If the
674         commit-queue gets interrupted in the middle of a commit (e.g., after
675         the local commit but before the dcommit), then it can end up with a
676         patch locally committed. That patch will then prevent the commit-queue
677         from functioning.
678
679         This patch teaches the commit-queue to clean down to the merge base,
680         which will remove any local commits.
681
682         * Scripts/webkitpy/common/checkout/scm/git.py:
683         (Git.working_directory_is_clean):
684         (Git.clean_working_directory):
685         * Scripts/webkitpy/tool/commands/roll_unittest.py:
686         * Scripts/webkitpy/tool/steps/commit.py:
687         (Commit._commit_warning):
688         (Commit.run):
689
690 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
691
692         nrwt: store only the total number of tests in the result summary
693         https://bugs.webkit.org/show_bug.cgi?id=103963
694
695         Reviewed by Ryosuke Niwa.
696
697         The result summary only needs the total number of tests that will
698         be run (including repetitions) in order to provide the correct stats;
699         it doesn't actually need to know how many unique tests there are, or
700         or how many repetitions there are.
701
702         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
703         (LayoutTestRunnerTests._result_summary):
704         (LayoutTestRunnerTests.test_update_summary_with_result):
705         * Scripts/webkitpy/layout_tests/controllers/manager.py:
706         (Manager._prepare_lists):
707         (Manager.run):
708         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
709         (ManagerTest.test_look_for_new_crash_logs):
710         (ResultSummaryTest.get_result_summary):
711         * Scripts/webkitpy/layout_tests/models/result_summary.py:
712         (ResultSummary.__init__):
713         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
714         (Testprinter.get_result_summary):
715
716 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
717
718         nrwt: do less work when ctrl-c'ed
719         https://bugs.webkit.org/show_bug.cgi?id=103961
720
721         Reviewed by Ryosuke Niwa.
722
723         Do less work when we are ctrl-c'ed, because the statistics aren't
724         that useful anyway. While we're at it, modify summarize_results
725         to be aware that we don't always retry results (instead of pretending
726         that the retry produced the same results the initial run did).
727
728         * Scripts/webkitpy/layout_tests/controllers/manager.py:
729         (summarize_results):
730         (Manager.run):
731
732 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
733
734         nrwt: result summaries should not require a list of tests to skip
735         https://bugs.webkit.org/show_bug.cgi?id=103951
736
737         Reviewed by Ryosuke Niwa.
738
739         We shouldn't really be passing a list of tests to skip to the
740         ResultSummary objects; they should be handled like any other
741         test result as much as possible.
742
743         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
744         (LayoutTestRunnerTests._result_summary):
745         (LayoutTestRunnerTests.test_update_summary_with_result):
746         * Scripts/webkitpy/layout_tests/controllers/manager.py:
747         (Manager._prepare_lists):
748         (Manager.run):
749         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
750         (ManagerTest.test_look_for_new_crash_logs):
751         (ResultSummaryTest.get_result_summary):
752         * Scripts/webkitpy/layout_tests/models/result_summary.py:
753         (ResultSummary.__init__):
754         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
755         (TestExpectations):
756         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
757         (Testprinter.get_result_summary):
758
759 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
760
761         nrwt: derive per-thread, per-worker stats from result summaries
762         https://bugs.webkit.org/show_bug.cgi?id=103943
763
764         Reviewed by Ojan Vafai.
765
766         This patch changes the manager and printing code to pull more           
767         information from the ResultSummary object rather than tracking          
768         additional statistics on the side. This allows us to consolidate        
769         a bunch of logic and remove a bunch of free-floating lists and dicts of 
770         of values. We add the shard_name and worker_name to each TestResult,    
771         and then modify print_timing_statistics() and upload_json_files()       
772         to just need the result summaries.                                      
773
774         Note that this patch also changes the timing statistics slightly
775         so that the individual test times are the times to run just the
776         tests themselves (TestResult.test_run_time) and do not include the
777         times taken to run the ref tests, compute diffs, etc. The aggregated
778         per-worker and per-shard statistics still use the total time to
779         process each test (TestResult.total_run_time).
780
781         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
782         (LayoutTestRunner.__init__):
783         (LayoutTestRunner.run_tests):
784         (LayoutTestRunner._handle_finished_test_list):
785         (LayoutTestRunner._handle_finished_test):
786         (Worker.handle):
787         (Worker._run_test):
788         * Scripts/webkitpy/layout_tests/controllers/manager.py:
789         (summarize_results):
790         (Manager.run):
791         (Manager._upload_json_files):
792         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
793         (ResultSummaryTest.summarized_results):
794         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
795         (JSONLayoutResultsGenerator.__init__):
796         (JSONLayoutResultsGenerator._get_test_timing):
797         * Scripts/webkitpy/layout_tests/models/test_results.py:
798         (TestResult.__init__):
799         * Scripts/webkitpy/layout_tests/views/printing.py:
800         (Printer.print_results):
801         (Printer._print_timing_statistics):
802         (Printer):
803         (Printer._print_worker_statistics):
804         (Printer._print_aggregate_test_statistics):
805         (Printer._print_individual_test_times):
806         (Printer._print_directory_timings):
807         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
808         (Testprinter.test_print_unexpected_results.get_unexpected_results):
809         (Testprinter):
810
811 2012-12-04  Adam Barth  <abarth@webkit.org>
812
813         Remove obsolete code from webkitpy
814         https://bugs.webkit.org/show_bug.cgi?id=104029
815
816         Reviewed by Eric Seidel.
817
818         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
819         (CommitQueueTask.run):
820         * Scripts/webkitpy/tool/steps/commit.py:
821         (Commit.options):
822         * Scripts/webkitpy/tool/steps/options.py:
823         (Options):
824
825 2012-12-04  Jochen Eisinger  <jochen@chromium.org>
826
827         [chromium] move WebPreferences and methods for modifying them to the TestRunner library
828         https://bugs.webkit.org/show_bug.cgi?id=103841
829
830         Reviewed by Darin Fisher.
831
832         * DumpRenderTree/DumpRenderTree.gypi:
833         * DumpRenderTree/chromium/DRTTestRunner.cpp:
834         (DRTTestRunner::DRTTestRunner):
835         (DRTTestRunner::reset):
836         * DumpRenderTree/chromium/DRTTestRunner.h:
837         (DRTTestRunner):
838         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.h.
839         (WebKit):
840         (WebTestRunner):
841         (WebPreferences):
842         (WebTestRunner::WebPreferences::WebPreferences):
843         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
844         (WebTestRunner):
845         (WebTestDelegate):
846         (WebTestRunner::WebTestDelegate::localFileToDataURL):
847         (WebTestRunner::WebTestDelegate::rewriteLayoutTestsURL):
848         (WebTestRunner::WebTestDelegate::preferences):
849         (WebTestRunner::WebTestDelegate::applyPreferences):
850         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
851         (WebTestRunner::TestRunner::TestRunner):
852         (WebTestRunner::TestRunner::reset):
853         (WebTestRunner::TestRunner::setUserStyleSheetEnabled):
854         (WebTestRunner):
855         (WebTestRunner::TestRunner::setUserStyleSheetLocation):
856         (WebTestRunner::TestRunner::setAuthorAndUserStylesEnabled):
857         (WebTestRunner::TestRunner::setPopupBlockingEnabled):
858         (WebTestRunner::TestRunner::setJavaScriptCanAccessClipboard):
859         (WebTestRunner::TestRunner::setXSSAuditorEnabled):
860         (WebTestRunner::TestRunner::setAllowUniversalAccessFromFileURLs):
861         (WebTestRunner::TestRunner::setAllowFileAccessFromFileURLs):
862         (WebTestRunner::TestRunner::overridePreference):
863         (WebTestRunner::TestRunner::setPluginsEnabled):
864         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
865         (TestRunner):
866         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.cpp.
867         (WebTestRunner::WebPreferences::reset):
868         (WebTestRunner):
869         (WebTestRunner::WebPreferences::applyTo):
870         * DumpRenderTree/chromium/TestShell.h:
871         (TestShell::preferences):
872         (TestShell):
873         * DumpRenderTree/chromium/WebViewHost.cpp:
874         (WebViewHost::localFileToDataURL):
875         (WebViewHost::rewriteLayoutTestsURL):
876         (WebViewHost::preferences):
877         (WebViewHost::applyPreferences):
878         * DumpRenderTree/chromium/WebViewHost.h:
879         (WebViewHost):
880
881 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
882
883         Many webkitpy unit tests can be run standalone, are executable
884         https://bugs.webkit.org/show_bug.cgi?id=103900
885
886         Reviewed by Eric Seidel.
887
888         There's no need anymore to run unit tests in standalone mode as they
889         are now handled by test-webkitpy in a formidable fashion. This makes
890         it possible for this patch to remove the following unnecessary bits:
891         - remove shebang lines from unit test files,
892         - remove calls to unittest.main(),
893         - make unit test files non-executable.
894
895         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
896         (DiffParserTest.test_git_mnemonicprefix):
897         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
898         (GitTestWithMock.test_push_local_commits_to_server_without_username_and_with_password):
899         * Scripts/webkitpy/common/config/build_unittest.py:
900         (ShouldBuildTest.test_should_build):
901         * Scripts/webkitpy/common/config/ports_unittest.py:
902         (DeprecatedPortTest.test_chromium_xvfb_port):
903         * Scripts/webkitpy/common/find_files_unittest.py:
904         (TestWinNormalize.test_win):
905         * Scripts/webkitpy/common/lru_cache_unittest.py:
906         (LRUCacheTest.test_set_again):
907         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
908         (test_results_zip_url):
909         * Scripts/webkitpy/common/net/credentials_unittest.py:
910         (test_keyring_without_git_repo_nor_keychain):
911         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
912         (OmahaProxyTest.test_get_revisions):
913         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
914         * Scripts/webkitpy/common/newstringio_unittest.py:
915         (NewStringIOTest.test_with):
916         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
917         (ReadChecksumFromPngTest.test_read_checksum):
918         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
919         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
920         (MockFileSystemTest.test_normpath):
921         * Scripts/webkitpy/common/system/filesystem_unittest.py:
922         (RealFileSystemTest.test_sep):
923         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
924         (TestPlatformInfo.test_total_bytes_memory):
925         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
926         (ZipFileSetTest.test_namelist):
927         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
928         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
929         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
930         (TestResultWriterTest.test_reftest_diff_image):
931         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
932         (JSONGeneratorTest.test_test_timings_trie):
933         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
934         (TestExpectationSerializationTests.test_string_whitespace_stripping):
935         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
936         (KeyCompareTest.test_test_key):
937         * Scripts/webkitpy/layout_tests/port/builders_unittest.py:
938         (BuildersTest.test_path_from_name):
939         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
940         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
941         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
942         (ChromiumLinuxPortTest.test_path_to_image_diff):
943         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
944         (ChromiumMacPortTest.test_path_to_image_diff):
945         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
946         (ChromiumPortLoggingTest.test_check_sys_deps):
947         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
948         (ChromiumPortLoggingTest.test_check_sys_deps):
949         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
950         (ConfigTest.test_default_configuration__scripterror):
951         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
952         (DriverTest.test_start_actually_starts):
953         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
954         (FactoryTest.test_get_from_builder_name):
955         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
956         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
957         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
958         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:
959         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
960         (PortTest.disabled_test_mac_lion):
961         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
962         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
963         (VerboseTest.test_log_args):
964         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
965         (test_details):
966         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
967         (TestPerfTestFactory.test_inspector_test):
968         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
969         (test_parse_args):
970         * Scripts/webkitpy/style/checker_unittest.py:
971         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
972         (ChangeLogCheckerTest.test_no_error):
973         * Scripts/webkitpy/style/checkers/common_unittest.py:
974         (TabCheckerTest.test_tab):
975         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
976         (CppCheckerTest.test_ne):
977         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
978         * Scripts/webkitpy/style/checkers/png_unittest.py:
979         (PNGCheckerTest.test_check):
980         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
981         * Scripts/webkitpy/style/checkers/text_unittest.py:
982         (TextCheckerTest.test_init):
983         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
984         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
985         (XcodeProjectFileCheckerTest.test_detect_development_region):
986         * Scripts/webkitpy/style/checkers/xml_unittest.py:
987         (XMLCheckerTest.test_no_error):
988         * Scripts/webkitpy/style/patchreader_unittest.py:
989         * Scripts/webkitpy/test/finder_unittest.py:
990         (FinderTest.test_paths):
991         * Scripts/webkitpy/test/runner_unittest.py:
992         (RunnerTest.test_run):
993         * Scripts/webkitpy/test/skip_unittest.py:
994         (SkipTest.test_skip_if_true):
995         * Scripts/webkitpy/thirdparty/__init___unittest.py:
996         (ThirdpartyTest.test_imports):
997         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
998         (TestTranslation.test_include_rewriting):
999         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1000         (QueueEngineTest.tearDown):
1001         * Scripts/webkitpy/tool/grammar_unittest.py:
1002         (GrammarTest.test_join_with_separators):
1003         * Scripts/webkitpy/tool/mocktool_unittest.py:
1004         (MockOptionsTest.test_kwarg__set):
1005         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1006         (test_command_help):
1007
1008 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1009
1010         Many webkitpy module files are executable, have shebang line
1011         https://bugs.webkit.org/show_bug.cgi?id=103985
1012
1013         Reviewed by Dirk Pranke.
1014
1015         Remove the executable bit from webkitpy module files that are
1016         unnecessarily executable. Remove the shebang line from webkitpy
1017         module files, they are of no use. Only non-third-party files are
1018         changed.
1019
1020         * Scripts/webkitpy/bindings/main.py:
1021         * Scripts/webkitpy/common/config/watchlist:
1022         * Scripts/webkitpy/common/find_files.py:
1023         * Scripts/webkitpy/common/lru_cache.py:
1024         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1025         * Scripts/webkitpy/common/net/file_uploader.py:
1026         * Scripts/webkitpy/common/newstringio.py:
1027         * Scripts/webkitpy/common/read_checksum_from_png.py:
1028         * Scripts/webkitpy/common/system/autoinstall.py:
1029         * Scripts/webkitpy/common/system/file_lock.py:
1030         * Scripts/webkitpy/common/system/file_lock_mock.py:
1031         * Scripts/webkitpy/common/version_check.py:
1032         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1033         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1034         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1035         * Scripts/webkitpy/layout_tests/models/test_input.py:
1036         * Scripts/webkitpy/layout_tests/port/__init__.py:
1037         * Scripts/webkitpy/layout_tests/port/base.py:
1038         * Scripts/webkitpy/layout_tests/port/builders.py:
1039         * Scripts/webkitpy/layout_tests/port/chromium.py:
1040         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1041         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1042         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1043         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1044         * Scripts/webkitpy/layout_tests/port/config.py:
1045         * Scripts/webkitpy/layout_tests/port/factory.py:
1046         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1047         * Scripts/webkitpy/layout_tests/port/image_diff.py:
1048         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1049         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1050         * Scripts/webkitpy/layout_tests/port/server_process.py:
1051         * Scripts/webkitpy/layout_tests/port/test.py:
1052         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1053         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1054         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1055         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1056         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1057         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1058         * Scripts/webkitpy/layout_tests/views/printing.py:
1059         * Scripts/webkitpy/performance_tests/perftest.py:
1060         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1061         * Scripts/webkitpy/style/checkers/changelog.py:
1062         * Scripts/webkitpy/style/checkers/cpp.py:
1063         * Scripts/webkitpy/style/checkers/xcodeproj.py:
1064         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1065         (main): There's no need to run this module in standalone because
1066         it's wrapped by the Tools/Scripts/update-webgl-conformance-tests script.
1067         * Scripts/webkitpy/tool/commands/upload.py:
1068         * Scripts/webkitpy/tool/comments.py:
1069         * Scripts/webkitpy/tool/main.py:
1070
1071 2012-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1072
1073         Add a Chromium Android Release (Perf) to the list of perf. bots.
1074
1075         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1076
1077 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1078
1079         [GTK] Insert the jhbuild wrapper command at the beginning of the command list
1080         https://bugs.webkit.org/show_bug.cgi?id=103991
1081
1082         Reviewed by Martin Robinson.
1083
1084         Insert the Tools/gtk/run-with-jhbuild wrapper at the beginning of the
1085         command that's being formed in multiprocessing bootstrap. The wrapper is
1086         an executable Python script while the command being wrapped perhaps isn't
1087         and therefore requires the Python interpreter to be listed at the beginning
1088         of the command sublist that is then executed by the wrapper.
1089
1090         Specifically, the webkitpy/layout_tests/run_webkit_tests.py module file
1091         is about to lose the executable bit and the Python-signaling shebang line.
1092         The Jhbuild wrapper simply executes the command that's passed, but that errs
1093         in this case unless the Python executable is executed and the module file
1094         is passed to it as an argument.
1095
1096         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1097         (run):
1098
1099 2012-12-04  Peter Beverloo  <peter@chromium.org>
1100
1101         Add the Chromium Android Release (Perf) bot
1102         https://bugs.webkit.org/show_bug.cgi?id=103891
1103
1104         Reviewed by Eric Seidel.
1105
1106         Add configuration for the bot itself. It will be triggered by the Chromium
1107         Android Release builder. When running for Android, the DownloadAndPerfTest
1108         factory will also add the OutputAndroidDeviceStatus step.
1109
1110         * BuildSlaveSupport/build.webkit.org-config/config.json:
1111         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1112         (DownloadAndPerfTestFactory.__init__):
1113
1114 2012-12-04  Peter Beverloo  <peter@chromium.org>
1115
1116         [Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
1117         https://bugs.webkit.org/show_bug.cgi?id=103758
1118
1119         Reviewed by Eric Seidel.
1120
1121         Lazily initialize the adb command parameters rather than initializing it in the
1122         constructor now that there is an assert if adb is not available on the system and
1123         we're not in a Chromium Android checkout.
1124
1125         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1126         (ChromiumAndroidDriver.__init__):
1127         (ChromiumAndroidDriver._push_file_if_needed):
1128         (ChromiumAndroidDriver._run_adb_command):
1129         (ChromiumAndroidDriver.cmd_line):
1130         (ChromiumAndroidDriver._start_once):
1131         (ChromiumAndroidDriver._read_prompt):
1132         (ChromiumAndroidDriver):
1133         (ChromiumAndroidDriver._adb_command):
1134
1135 2012-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1136
1137         Dromaeo should report individual test result
1138         https://bugs.webkit.org/show_bug.cgi?id=99800
1139
1140         Reviewed by Eric Seidel.
1141
1142         Ignore subtest results spit out by Dromaeo tests.
1143
1144         * Scripts/webkitpy/performance_tests/perftest.py:
1145         (PerfTest): Added a line to ignore.
1146         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1147         (MainTest.test_parse_output_with_subtests): Added.
1148
1149 2012-12-03  Zan Dobersek  <zandobersek@gmail.com>
1150
1151         Unreviewed, functionality fix after r136437.
1152
1153         Calling sys.exit actually raises a SystemExit exception that
1154         is then handled in the second block and causes the script to
1155         return an 'exceptional' exit code rather than the code presenting
1156         the number of failed tests.
1157
1158         This is just a temporary fix to get the faultless bots green while
1159         they are unnecessarily red at the moment. The problem and a proper
1160         fix will be properly addressed.
1161
1162         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1163
1164 2012-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1165
1166         Unreviewed, rolling out r136460.
1167         http://trac.webkit.org/changeset/136460
1168         https://bugs.webkit.org/show_bug.cgi?id=103958
1169
1170         This patch caused compile error when building DumpRenderTree
1171         (Requested by tasak on #webkit).
1172
1173         * Scripts/webkitpy/common/config/build_unittest.py:
1174         (ShouldBuildTest):
1175
1176 2012-12-03  Scott Violet  <sky@chromium.org>
1177
1178         [chromium] Remove linux theme related files and switch to default
1179         https://bugs.webkit.org/show_bug.cgi?id=103897
1180
1181         Reviewed by Darin Fisher.
1182
1183         * Scripts/webkitpy/common/config/build_unittest.py:
1184         (ShouldBuildTest): linux->default
1185
1186 2012-12-03  Roger Fong  <roger_fong@apple.com>
1187
1188         Disable WebKit2 API tests on Apple Windows port.
1189         https://bugs.webkit.org/show_bug.cgi?id=103929.
1190
1191         Reviewed by Timothy Horton.
1192
1193         * Scripts/run-api-tests:
1194         (runTestsBySuite):
1195
1196 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1197
1198         webkitpy's run_webkit_tests should initialize the printer earlier on
1199         https://bugs.webkit.org/show_bug.cgi?id=103661
1200
1201         Reviewed by Eric Seidel.
1202
1203         Initialize the printer before computing the derived options
1204         from the command line arguments, so that we can safely log from
1205         port methods.
1206
1207         Also clean up a few miscellaneous lint warnings.
1208
1209         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1210         (ChromiumAndroidPort.path_to_adb):
1211         * Scripts/webkitpy/layout_tests/port/mac.py:
1212         (MacPort.default_child_processes):
1213         (MacPort.sample_process):
1214         (MacPort.start_helper):
1215         (MacPort.stop_helper):
1216         (MacPort.nm_command):
1217         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1218         (test_default_child_processes):
1219         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1220         (run):
1221         (_set_up_derived_options):
1222
1223 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1224
1225         webkitpy: autoinstaller is failing on windows
1226         https://bugs.webkit.org/show_bug.cgi?id=103699
1227
1228         Reviewed by Tony Chang.
1229
1230         Attempt to fix the python autoinstaller to work for pylint on win32
1231         again ... it turns out one of the dependent packages contains
1232         a write-protected test file and windows will choke when it tries to move
1233         it into place. Fortunately we can just delete the file prior to
1234         installing it in the final location, but we have to jump through
1235         a couple of hoops to do so.
1236
1237         Also, make sure that we're flattening nested module names like
1238         "logilab/common" into either safe basenames (logilab_common) or
1239         host-specific subdirs (logilab\common) as needed.
1240
1241         * Scripts/webkitpy/common/system/autoinstall.py:
1242         (AutoInstaller._url_downloaded_path):
1243         (AutoInstaller._install):
1244         (AutoInstaller.install):
1245         * Scripts/webkitpy/thirdparty/__init__.py:
1246         (AutoinstallImportHook._install_pylint):
1247
1248 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1249
1250         nrwt: clean up exception propagation / handling for interrupts and early exits
1251         https://bugs.webkit.org/show_bug.cgi?id=103830
1252
1253         Reviewed by Ojan Vafai.
1254
1255         The code for propagating early exits out of the test run was
1256         convoluted and hard to follow. By adjusting the WorkerException to
1257         derive from BaseException rather than Exception (which is a fair
1258         way of representing an error that was really unexpected/unrecoverable
1259         anyway) and pushing the TestRunInterruptedException into the
1260         ResultSummary (which is also fair since it was more of a result
1261         than an exception) this allows us to consolidate and clean up
1262         a bunch of the try/catch logic and pass fewer state flags around.
1263
1264         There are no real functional changes to this patch; there's an
1265         API change in that we stop exporting TestRunInterruptedException
1266         and WorkerException out of the Manager, and the existence of the
1267         MessagePool is now completely hidden.
1268
1269         * Scripts/webkitpy/common/message_pool.py:
1270         (WorkerException):
1271         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1272         (LayoutTestRunner.run_tests):
1273         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1274         (summarize_results):
1275         (Manager.run):
1276         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1277         (ResultSummaryTest.summarized_results):
1278         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1279         (ResultSummary.__init__):
1280         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1281         (run):
1282         (main):
1283         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1284         (MainTest.test_exception_raised.of):
1285         (MainTest.test_exception_raised):
1286         (MainTest.test_run_force):
1287         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1288         (Testprinter.test_print_unexpected_results.get_unexpected_results):
1289         (Testprinter):
1290
1291 2012-12-03  Julien BRIANCEAU   <jbrianceau@nds.com>
1292
1293         Add Qt/SH4 build slave to build.webkit.org
1294         https://bugs.webkit.org/show_bug.cgi?id=103384
1295
1296         Reviewed by Csaba Osztrogonác.
1297
1298         * BuildSlaveSupport/build.webkit.org-config/config.json:
1299
1300 2012-12-03  Alexis Menard  <alexis@webkit.org>
1301
1302         Enable CSS3 background-position offset by default
1303         https://bugs.webkit.org/show_bug.cgi?id=103917
1304
1305         Reviewed by Benjamin Poulain.
1306
1307         Even though each port may enable or not the feature we still need
1308         to pass it at configure time otherwise it will be disabled.
1309
1310         * Scripts/webkitperl/FeatureList.pm:
1311
1312 2012-12-03  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1313
1314         Unreviewed. Adding myself to committers.py.
1315
1316         * Scripts/webkitpy/common/config/committers.py:
1317
1318 2012-12-03  Laszlo Gombos  <l.gombos@samsung.com>
1319
1320         [CMake] Enable building WebKit2-only build for the EFL port
1321         https://bugs.webkit.org/show_bug.cgi?id=103820
1322
1323         Reviewed by Gyuyoung Kim.
1324
1325         Set ENABLE_WEBKIT2 to OFF if build-webkit was run with --no-webkit2.
1326         Never set ENABLE_WEBKIT in build-webkit. This will simplyfy invoking
1327         cmake directly. Initialize $cmakeArgs to avoid potential
1328         warnings when running the script.
1329
1330         * Scripts/build-webkit:
1331
1332 2012-12-03  Tommy Widenflycht  <tommyw@google.com>
1333
1334         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
1335         https://bugs.webkit.org/show_bug.cgi?id=103407
1336
1337         Reviewed by Kentaro Hara.
1338
1339         Changing the mock to use the new results delivery API.
1340
1341         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1342
1343 2012-12-03  Alexis Menard  <alexis@webkit.org>
1344
1345         [Qt] Enable CSS3 background-position offsets by default.
1346         https://bugs.webkit.org/show_bug.cgi?id=103877
1347
1348         Reviewed by Tor Arne Vestbø.
1349
1350         Enable by default CSS3 background-position offsets.
1351
1352         * qmake/mkspecs/features/features.pri:
1353
1354 2012-12-03  KyungTae Kim  <ktf.kim@samsung.com>
1355
1356         [EFL][WK2] Use float variable for zoom levels for MiniBrowser
1357         https://bugs.webkit.org/show_bug.cgi?id=103863
1358
1359         Reviewed by Gyuyoung Kim.
1360
1361         Use float instead of int for zoomLevels variables for a clearer expression
1362
1363         * MiniBrowser/efl/main.c:
1364         (on_key_down):
1365
1366 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
1367
1368         [EFL][WK2] Add support for a zoom level setting to MiniBrowser
1369         https://bugs.webkit.org/show_bug.cgi?id=99285
1370
1371         Reviewed by Gyuyoung Kim.
1372
1373          Add support for a zoom level setting to MiniBrowser.
1374          Shortcuts for setting operations are same as common browsers:
1375          Ctrl + '+' to zoom in, Ctrl + '-' to zoom out and Ctrl + '0' to zoom to default.
1376
1377         * MiniBrowser/efl/main.c:
1378         (on_key_down):
1379
1380 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
1381
1382         [EFL][WK2] ECORE_GETOPT_VALUE_BOOL need to be used for Eina_Bool
1383         https://bugs.webkit.org/show_bug.cgi?id=103835
1384
1385         Reviewed by Kentaro Hara.
1386
1387         Because legacy_behavior_enabled is Eina_Bool, ECORE_GETOPT_VALUE_BOOL need to be used
1388
1389         * MiniBrowser/efl/main.c:
1390         (elm_main):
1391
1392 2012-12-02  Mike West  <mkwst@chromium.org>
1393
1394         Garden-o-matic shouldn't die when blank JSON results are received.
1395         https://bugs.webkit.org/show_bug.cgi?id=103838
1396
1397         Reviewed by Adam Barth.
1398
1399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1400             If the JSONP string doesn't contain '(' or ')', return an empty object.
1401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1402             Check that this behavior stays in place.
1403
1404 2012-12-02  Eric Seidel  <eric@webkit.org>
1405
1406         run-perf-tests --profile should use iprofiler instead of instruments on Mac
1407         https://bugs.webkit.org/show_bug.cgi?id=103765
1408
1409         Unreviewed.  Updating the unittests after my previous change.
1410
1411         * Scripts/webkitpy/common/system/profiler_unittest.py:
1412         (ProfilerFactoryTest.test_basic):
1413
1414 2012-12-02  Julie Parent  <jparent@chromium.org>
1415
1416         Remove dead code in flakiness dashboard for obsolete buildDir option
1417         https://bugs.webkit.org/show_bug.cgi?id=103792
1418
1419         Reviewed by Dirk Pranke.
1420
1421         * TestResultServer/static-dashboards/dashboard_base.js:
1422         (initBuilders):
1423
1424 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
1425
1426         nrwt: clean up logic for retrying failed tests a bit
1427         https://bugs.webkit.org/show_bug.cgi?id=103829
1428
1429         Reviewed by Ojan Vafai.
1430
1431         The code for determining when to retry test failures and
1432         show the results.html file was awkward and could stand some
1433         cleaning up. This patch should have no functional changes.
1434
1435         The routine called _get_failures() returned a dict of test names
1436         to failure types, but we only ever used the names, so I've converted
1437         it to return a list (and renamed it); also, the show_results_html()
1438         file was calling that routine to figure out if anything failed, when
1439         the information was already in the result_summary (as either
1440         unexpected_results or total_failures), so we were doing unnecessary work.
1441
1442         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1443         (Manager.__init__):
1444         (Manager.run):
1445         (Manager._run_tests):
1446         (Manager._failed_test_names):
1447         (Manager._copy_results_html_file):
1448
1449 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
1450
1451         nrwt: remove unused methods in manager.py
1452         https://bugs.webkit.org/show_bug.cgi?id=103828
1453
1454         Reviewed by Eric Seidel.
1455
1456         These two methods weren't being called by anything and were no
1457         longer needed.
1458
1459         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1460         (Manager._get_failures):
1461         (Manager._upload_json_files):
1462
1463 2012-12-02  Laszlo Gombos  <l.gombos@samsung.com>
1464
1465         Correct the spelling of the cmakeargs argument
1466         https://bugs.webkit.org/show_bug.cgi?id=103814
1467
1468         Reviewed by Darin Adler.
1469
1470         The script expects cmakeargs (plural), so lets get the
1471         documentation of the script report the same.
1472
1473         * Scripts/build-webkit:
1474
1475 2012-12-02  Mike West  <mkwst@chromium.org>
1476
1477         [gtk] Enable the CSP_NEXT runtime flag.
1478         https://bugs.webkit.org/show_bug.cgi?id=103810
1479
1480         Reviewed by Adam Barth.
1481
1482         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1483         (resetDefaultsToConsistentValues):
1484             Turn on the CSP_NEXT runtime flag when running tests under GTK.
1485
1486 2012-12-02  Eric Seidel  <eric@webkit.org>
1487
1488         run-perf-tests --profile should use iprofiler instead of instruments on Mac
1489         https://bugs.webkit.org/show_bug.cgi?id=103765
1490
1491         Reviewed by Ryosuke Niwa.
1492
1493         Stephanie pointed out that iprofiler is the newer command-line interface
1494         to replace /usr/bin/instruments in Instruments 4 (which according to the
1495         interblags is supported on everything since 10.6.6), so I've moved --profile
1496         to use iprofiler on Mac.
1497
1498         I also made the IProfiler class wait for iprofiler to complete so that
1499         iprofiler won't continue running after run-perf-tests is complete (and
1500         spam over the top of your shell output).
1501
1502         There are a couple of "got-chas" to this approach:
1503         1.  iprofiler will ask for your password the first time you run it, which may
1504             cause your first test to fail.  /usr/bin/instruments doesn't seem to do that.
1505         2.  iprofiler has nice (but kinda awkward for our purposes) support for separate
1506             directory and basename arguments, making IProfiler a somewhat awkward
1507             baseclass of SingleFileOutputProfiler
1508
1509         I suspect we'll iterate from here.  It does seem slightly faster than
1510         /usr/bin/instruments was.
1511
1512         * Scripts/webkitpy/common/system/profiler.py:
1513         (ProfilerFactory.create_profiler):
1514         (IProfiler):
1515         (IProfiler.__init__):
1516         (IProfiler.attach_to_pid):
1517
1518 2012-12-02  Yongjun Zhang  <yongjun_zhang@apple.com>
1519
1520         Need a method to close all idle localstorage databases immediately.
1521         https://bugs.webkit.org/show_bug.cgi?id=103469
1522
1523         Reviewed by David Kilzer.
1524
1525         Add an JS method to TestRunner, to enable testing closing idle local storage databases in
1526         DumpRenderTree layout tests.
1527
1528         * DumpRenderTree/TestRunner.cpp:
1529         (closeIdleLocalStorageDatabasesCallback):
1530         (TestRunner::staticFunctions):
1531         * DumpRenderTree/TestRunner.h:
1532         (TestRunner):
1533         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1534         (TestRunner::closeIdleLocalStorageDatabases):
1535         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1536         (TestRunner::closeIdleLocalStorageDatabases):
1537         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1538         (TestRunner::closeIdleLocalStorageDatabases):
1539         * DumpRenderTree/mac/TestRunnerMac.mm:
1540         (TestRunner::closeIdleLocalStorageDatabases):
1541         * DumpRenderTree/win/TestRunnerWin.cpp:
1542         (TestRunner::closeIdleLocalStorageDatabases):
1543         * DumpRenderTree/wx/TestRunnerWx.cpp:
1544         (TestRunner::closeIdleLocalStorageDatabases):
1545
1546 2012-12-02  Yael Aharon  <yael.aharon@intel.com>
1547
1548         [EFL][WK2] MiniBrowser should have a legacy mode
1549         https://bugs.webkit.org/show_bug.cgi?id=103679
1550
1551         Reviewed by Kenneth Rohde Christiansen.
1552
1553         Add an option to start MiniBrowser in legacy mode.
1554
1555         * MiniBrowser/efl/main.c:
1556         (window_create):
1557         (elm_main):
1558
1559 2012-12-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1560
1561         Unreviewed, rolling out r136236.
1562         http://trac.webkit.org/changeset/136236
1563         https://bugs.webkit.org/show_bug.cgi?id=103833
1564
1565         [chromium] Flakey crashes in SpeechRecognitionEvent::emma
1566         during GC. (Requested by mkwst on #webkit).
1567
1568         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1569
1570 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
1571
1572         [XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
1573         https://bugs.webkit.org/show_bug.cgi?id=103806
1574
1575         Reviewed by Dirk Pranke.
1576
1577         There are occasional mishaps on builders where XvfbDriver doesn't properly
1578         clean up the Xvfb instance it was managing so the related guard lock files
1579         are still existing when the webkitpy unit tests are run. This can cause failures
1580         in XvfbDriverTest.test_next_free_display as the test tries to acquire displays
1581         with a specific number but is unable to due to the stale locks.
1582
1583         The solution to this is to use MockFileLock when inside unit test. This is achievable
1584         by creating a file lock through the SystemHost instance connected to the Port object,
1585         the latter available to the Driver.
1586
1587         * Scripts/webkitpy/common/system/file_lock_mock.py:
1588         (MockFileLock.acquire_lock): Return True to signal lock acquiring succeeded.
1589         (MockFileLock.release_lock): Return True to signal lock releasing succeeded.
1590         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1591         (XvfbDriver._next_free_display): Create the file lock through a mockable way.
1592         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
1593         (XvfbDriverTest.test_next_free_display): Enable back the unit test.
1594
1595 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
1596
1597         [GTK] A11y tests in WK2 report badly-formatted AX roles
1598         https://bugs.webkit.org/show_bug.cgi?id=102947
1599
1600         Reviewed by Xan Lopez.
1601
1602         As in DRT, convert the ATK accessibility roles to corresponding AXRoles.
1603         These are expected in both tests and their baselines.
1604
1605         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1606         (WTR::roleToString):
1607         (WTR):
1608         (WTR::AccessibilityUIElement::role):
1609
1610 2012-11-30  Mike West  <mkwst@chromium.org>
1611
1612         CSP 1.1: Make the CSP_NEXT flag runtime enabled.
1613         https://bugs.webkit.org/show_bug.cgi?id=103652
1614
1615         Reviewed by Adam Barth.
1616
1617         Ensures that the new SecurityPolicy runtime flag is enabled for Chromium's tests.
1618
1619         * DumpRenderTree/chromium/TestShell.cpp:
1620         (TestShell::TestShell):
1621
1622 2012-11-30  Roger Fong  <roger_fong@apple.com>
1623
1624         Unreviewed. Removed temporary debugging change from DRT (r136300).
1625
1626         * DumpRenderTree/win/DumpRenderTree.cpp:
1627         (dump):
1628
1629 2012-11-30  Roger Fong  <roger_fong@apple.com>
1630
1631         Unreviewed. Temporary change to DRT for debugging purposes.
1632
1633         * DumpRenderTree/win/DumpRenderTree.cpp:
1634         (dump):
1635
1636 2012-11-29  Tommy Widenflycht  <tommyw@google.com>
1637
1638         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
1639         https://bugs.webkit.org/show_bug.cgi?id=103407
1640
1641         Reviewed by Adam Barth.
1642
1643         Changing the mock to use the new results delivery API.
1644
1645         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1646
1647 2012-11-30  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi  <pierre.rossi@digia.com>
1648
1649         [Qt] Separate Qt WebKit into Qt WebKit and Qt WebKit Widgets
1650         https://bugs.webkit.org/show_bug.cgi?id=99314
1651
1652         Reviewed by Tor Arne Vestbø.
1653
1654         This big change separates QtWebKit into QtWebKit and QtWebKitWidgets as
1655         shared libraries.
1656
1657         It's a big refactoring that mostly involves moving WebCore dependent
1658         code into QtWebKit and accessing it through exported QWebFrameAdapter
1659         and QWebPageAdapter classes.
1660
1661         * DumpRenderTree/qt/DumpRenderTree.pro:
1662         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1663         (WebCore::DumpRenderTree::dump): Adapt to internal API changes.
1664         * MiniBrowser/qt/MiniBrowser.pro:
1665         * Scripts/webkitpy/style/checker.py: Adapt Qt exceptions to new paths.
1666         * Scripts/webkitpy/style/checker_unittest.py:
1667         (GlobalVariablesTest.test_path_rules_specifier):
1668         * WebKitTestRunner/InjectedBundle/Target.pri:
1669         * qmake/mkspecs/features/default_post.prf:
1670         * qmake/mkspecs/features/webkit_modules.prf:
1671         * qmake/mkspecs/modules/webkitwidgets.prf: Removed.
1672
1673 2012-11-30  Csaba Osztrogonác  <ossy@webkit.org>
1674
1675         [Qt] Unreviewed trivial fix.
1676
1677         Add empty.cpp back, it was removed accidentally by r129092.
1678
1679         * qmake/config.tests/gccdepends/empty.cpp: Added.
1680
1681 2012-11-30  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1682
1683         [Qt] Add support for prepare_docs and generate_docs
1684
1685         Follow-up to changes in Qt in how documentation is built.
1686
1687         Reviewed by Simon Hausmann.
1688
1689         * qmake/mkspecs/features/default_post.prf:
1690
1691 2012-11-30  Zan Dobersek  <zandobersek@gmail.com>
1692
1693         Finally remove webkitpy.common.system.deprecated_logging
1694         https://bugs.webkit.org/show_bug.cgi?id=103624
1695
1696         Reviewed by Adam Barth.
1697
1698         Remove the deprecated logging module and its unit tests now that such logging is not
1699         used anymore in webkitpy.
1700
1701         The tee and OutputTee classes are moved into a new module, webkitpy.common.system.outputtee.
1702         The tee class is renamed to Tee to conform with the usual guidelines.
1703
1704         Only unit test for the Tee class is currently provided as the OutputTee is not currently
1705         using the webkitpy Filesystem abstraction that would make its functionality testable.
1706
1707         * Scripts/webkitpy/common/system/executive.py: tee (now Tee) is now in a new module.
1708         (Executive.run_and_throw_if_fail):
1709         * Scripts/webkitpy/common/system/outputtee.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging.py.
1710         (Tee):
1711         (Tee.__init__):
1712         (Tee.write):
1713         (OutputTee):
1714         (OutputTee.__init__):
1715         (OutputTee.add_log):
1716         (OutputTee.remove_log):
1717         (OutputTee._open_log_file):
1718         (OutputTee._tee_outputs_to_files):
1719         * Scripts/webkitpy/common/system/outputtee_unittest.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging_unittest.py.
1720         (SimpleTeeTest):
1721         (SimpleTeeTest.test_simple_tee):
1722         * Scripts/webkitpy/tool/bot/queueengine.py: OutputTee is now in a new module.
1723         * Scripts/webkitpy/webkitpy.pyproj: Remove the deprecated_logging module and related unit test file.
1724
1725 2012-11-30  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1726
1727         [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
1728         https://bugs.webkit.org/show_bug.cgi?id=103634
1729
1730         Reviewed by Gyuyoung Kim.
1731
1732         Add support for PlatformWebView::simulateRightClick() and enable
1733         WebKit2 API test HitTestResultNodeHandle.
1734
1735         * TestWebKitAPI/PlatformEfl.cmake:
1736         * TestWebKitAPI/efl/PlatformWebView.cpp:
1737         (TestWebKitAPI::PlatformWebView::simulateRightClick):
1738         (TestWebKitAPI):
1739
1740 2012-11-30  Mihai Maerean  <mmaerean@adobe.com>
1741
1742         [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
1743         https://bugs.webkit.org/show_bug.cgi?id=101192
1744
1745         Reviewed by Hajime Morita.
1746
1747         Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
1748
1749         Tests: No new tests because there is no functional change.
1750
1751         * DumpRenderTree/chromium/WebPreferences.cpp:
1752         (WebPreferences::applyTo):
1753
1754 2012-11-29  Rafael Weinstein  <rafaelw@chromium.org>
1755
1756         [HTMLTemplateElement] Add feature flag
1757         https://bugs.webkit.org/show_bug.cgi?id=103694
1758
1759         Reviewed by Adam Barth.
1760
1761         This flag will guard the implementation of the HTMLTemplateElement.
1762         http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html
1763
1764         * Scripts/webkitperl/FeatureList.pm:
1765
1766 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
1767
1768         Ignore errors when removing directories on win32 during autoinstall
1769         https://bugs.webkit.org/show_bug.cgi?id=103699
1770
1771         Unreviewed, build fix.
1772
1773         I think this will work on win32; if not, I'll have to actually
1774         reproduce this :). The problem is that the logilab files
1775         appear to contain a write-protected file, and deleting those
1776         is problematic on windows.
1777
1778         * Scripts/webkitpy/common/system/autoinstall.py:
1779         (AutoInstaller._install):
1780         (AutoInstaller.install):
1781
1782 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
1783
1784         webkitpy: autoinstaller is failing on windows
1785         https://bugs.webkit.org/show_bug.cgi?id=103699
1786
1787         Unreviewed, build fix.
1788
1789         We're attempting to create directories with forward slashes in them;
1790         this is a no-no on windows.
1791
1792         * Scripts/webkitpy/common/system/autoinstall.py:
1793         (AutoInstaller._create_scratch_directory_inner):
1794
1795 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
1796
1797         Fix python unit tests after r136158 (android port tests failing)
1798         https://bugs.webkit.org/show_bug.cgi?id=103581
1799
1800         Unreviewed, build fix.
1801
1802         The unit tests apparently weren't ran for this patch; we failed
1803         to update the mock executive calls out to adb to determine various
1804         aspects of the environment, and were failing to create drivers.
1805
1806         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1807         (MockRunCommand.mock_run_command_fn):
1808
1809 2012-11-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1810
1811         Unreviewed, rolling out r136175 and r136177.
1812         http://trac.webkit.org/changeset/136175
1813         http://trac.webkit.org/changeset/136177
1814         https://bugs.webkit.org/show_bug.cgi?id=103683
1815
1816         Changes did not correct Windows build. (Requested by bfulgham
1817         on #webkit).
1818
1819         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1820
1821 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
1822
1823         [Windows, WinCairo] Unreviewed build correction. Correct debug
1824         build case on build machine.
1825
1826         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1827
1828 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
1829
1830         [Windows, WinCairo] Unreviewed build correction. Hide the
1831         unexported 'notSolidColor' symbol when testing against
1832         the BitmapImage class to avoid having to deal with a
1833         debug-only symbol in the Windows export definition file.
1834
1835         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: 
1836
1837 2012-11-29  Peter Beverloo  <peter@chromium.org>
1838
1839         run-perf-tests --chromium-android should not require adb in my path
1840         https://bugs.webkit.org/show_bug.cgi?id=103581
1841
1842         Reviewed by Eric Seidel.
1843
1844         Remove the need to have "adb" available in the path for Layout and Performance
1845         tests. We'll determine the versions of the "adb" version in path (if any) and
1846         the one provided in the Chromium Android checkout. Unless the "adb" available
1847         in the path is newer, the provided version will be used.
1848
1849         Some other minor nits addressed:
1850         - The path_to_forwarder/path_to_md5sum should not be in the "private overrides"
1851           section, as they're not overriding anything and are used by the driver.
1852         - Make _restart_adb_as_root slightly more robust by waiting for the device
1853           to come back online regardless of the output.
1854
1855         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1856         (ChromiumAndroidPort.__init__):
1857         (ChromiumAndroidPort.check_build):
1858         (ChromiumAndroidPort.path_to_adb):
1859         (ChromiumAndroidPort):
1860         (ChromiumAndroidPort.path_to_forwarder):
1861         (ChromiumAndroidPort.path_to_md5sum):
1862         (ChromiumAndroidPort._path_to_helper):
1863         (ChromiumAndroidPort._determine_adb_version):
1864         (ChromiumAndroidPort._get_devices):
1865         (ChromiumAndroidDriver.__init__):
1866         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1867         (ChromiumAndroidDriver._push_executable):
1868         (ChromiumAndroidDriver._restart_adb_as_root):
1869
1870 2012-11-29  Martin Robinson  <mrobinson@igalia.com>
1871
1872         [GTK] [WebKit2] Embed the HTTP authentication dialog into the WebView
1873         https://bugs.webkit.org/show_bug.cgi?id=103277
1874
1875         Reviewed by Carlos Garcia Campos.
1876
1877         Skip the new WebKit2GtkAuthenticationDialog files so that they are not processed
1878         during gtkdoc generation.
1879
1880         * gtk/generate-gtkdoc:
1881         (get_webkit2_options):
1882
1883 2012-11-29  Eric Seidel  <eric@webkit.org>
1884
1885         run-perf-tests --chromium-android fails due to Skia INFO logging
1886         https://bugs.webkit.org/show_bug.cgi?id=103585
1887
1888         Reviewed by Adam Barth.
1889
1890         Ignore all INFO logging from Chromium code.
1891         Also added some basic testing of the ignored-stderr lines code.
1892
1893         * Scripts/webkitpy/performance_tests/perftest.py:
1894         (PerfTest):
1895         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1896         (MainTest.test_ignored_stderr_lines):
1897
1898 2012-11-29  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1899
1900         [EFL][WK2] Add support for PlatformWebView::simulateMouseMove() in TestWebKitAPI
1901         https://bugs.webkit.org/show_bug.cgi?id=103252
1902
1903         Reviewed by Kenneth Rohde Christiansen.
1904
1905         Add support for PlatformWebView::simulateMouseMove() and enable
1906         WebKit2 API test MouseMoveAfterCrash.
1907
1908         * TestWebKitAPI/PlatformEfl.cmake: Enable MouseMoveAfterCrash API
1909         test.
1910         * TestWebKitAPI/efl/PlatformWebView.cpp:
1911         (TestWebKitAPI::onWebProcessCrashed): Handle 'webprocess,crashed' signal
1912         to prevent loading an error page since the test case is reloading actual
1913         page after web process has terminated and recovered.
1914         (TestWebKitAPI):
1915         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1916         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Implemented.
1917
1918 2012-11-29  Andras Becsi  <andras.becsi@digia.com>
1919
1920         [Qt] Fix installation of QtWebProcess binary
1921         https://bugs.webkit.org/show_bug.cgi?id=101735
1922
1923         Reviewed by Simon Hausmann.
1924
1925         Add config test to detect the availability of support
1926         for "program executables" in Qt (libexec).
1927
1928         This test can be removed after the Qt5 release.
1929
1930         * Tools.pro:
1931         * qmake/mkspecs/features/features.prf:
1932         * qmake/config.tests/libexecdir/libexecdir.cpp:
1933         * qmake/config.tests/libexecdir/libexecdir.pro:
1934
1935 2012-11-29  Eric Seidel  <eric@webkit.org>
1936
1937         run-perf-tests does not work when the layout test directory does not exist
1938         https://bugs.webkit.org/show_bug.cgi?id=103572
1939
1940         Reviewed by Ryosuke Niwa.
1941
1942         Make sure that Profiler() calls maybe_make_directory for the output_dir
1943         before ever using it.  It's a little awkward to create the directory
1944         from the constructor, but its simplest that way as the various subclasses
1945         all use the directory at different times.
1946
1947         Since this required having a filesystem in Profiler (and I didn't want
1948         to grab inside Workspace to get one), I just made Profiler expect a
1949         SystemHost instead of a separate filesystem, executive and workspace.
1950
1951         * Scripts/webkitpy/common/system/profiler.py:
1952         (ProfilerFactory.create_profiler):
1953         (Profiler.__init__):
1954         (SingleFileOutputProfiler.__init__):
1955         (GooglePProf.__init__):
1956         (GooglePProf.profile_after_exit):
1957         (Instruments.__init__):
1958         (Instruments.attach_to_pid):
1959         * Scripts/webkitpy/common/system/profiler_unittest.py:
1960         (ProfilerFactoryTest.test_basic):
1961
1962 2012-11-28  Vivek Galatage  <vivek.vg@samsung.com>
1963
1964         Adding secondary email id
1965         https://bugs.webkit.org/show_bug.cgi?id=103594
1966
1967         Unreviewed. Adding secondary email.
1968
1969         * Scripts/webkitpy/common/config/committers.py:
1970
1971 2012-11-28  Kent Tamura  <tkent@chromium.org>
1972
1973         garden-o-matic: Use indeterminate <progress> in the status area
1974         https://bugs.webkit.org/show_bug.cgi?id=103494
1975
1976         Reviewed by Adam Barth.
1977
1978         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1979         Wrap the "Processing..." message with an indeterminate progress bar.
1980         We keep the message as a fallback content.
1981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1982         Follow the above change.
1983
1984 2012-11-28  Nima Ghanavatian  <nghanavatian@rim.com>
1985
1986         Adding Nima Ghanavatian to committers.py
1987         https://bugs.webkit.org/show_bug.cgi?id=103533
1988
1989         Reviewed by Rob Buis.
1990
1991         Adding myself to committers.py as a Committer.
1992
1993         * Scripts/webkitpy/common/config/committers.py:
1994
1995 2012-11-28  peavo@outlook.com  <peavo@outlook.com>
1996
1997         [WinCairo] Crash when requesting favicon.
1998         https://bugs.webkit.org/show_bug.cgi?id=102689
1999
2000         Reviewed by Brent Fulgham.
2001
2002         * TestWebKitAPI/Tests/WebCore/win: Added.
2003         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: Added.
2004         (TestWebKitAPI::BitmapImageTest::BitmapImageTest): Allocate frame in constructor.
2005         (TestWebKitAPI::BitmapImageTest::frameCount): Override frameCount() method.
2006         (TestWebKitAPI::TEST): Added new test.
2007         * TestWebKitAPI/config.h: Make sure defines are correct for WinCairo.
2008        * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
2009
2010 2012-11-28  Eric Seidel  <eric@webkit.org>
2011
2012         run-perf-tests should have a --profile option for easy profiling
2013         https://bugs.webkit.org/show_bug.cgi?id=99517
2014
2015         Reviewed by Adam Barth.
2016
2017         This is a very basic implementation which works on Mac and Linux
2018         and makes it trivial for anyone to profile a PerformanceTest.
2019
2020         Currently it's not "hard" to profile a PerformanceTest
2021         but lowering the barriers to entry here allows all of us to focus
2022         less on the tools and more on the code.
2023
2024         This also paves the way for adding easy mobile-profiling (e.g. chromium-android)
2025         which is actually "hard", and this option will make much easier.
2026
2027         * Scripts/webkitpy/common/system/profiler.py: Added.
2028         (ProfilerFactory):
2029         (ProfilerFactory.create_profiler):
2030         (Profiler):
2031         (Profiler.__init__):
2032         (Profiler.adjusted_environment):
2033         (Profiler.attach_to_pid):
2034         (Profiler.did_stop):
2035         (SingleFileOutputProfiler):
2036         (SingleFileOutputProfiler.__init__):
2037         (GooglePProf):
2038         (GooglePProf.__init__):
2039         (GooglePProf.adjusted_environment):
2040         (GooglePProf.did_stop):
2041         (Instruments):
2042         (Instruments.__init__):
2043         (Instruments.attach_to_pid):
2044         * Scripts/webkitpy/common/system/profiler_unittest.py: Added.
2045         (ProfilerFactoryTest):
2046         (ProfilerFactoryTest.test_basic):
2047         * Scripts/webkitpy/layout_tests/port/driver.py:
2048         (Driver.__init__):
2049         (Driver._start):
2050         (Driver.stop):
2051         (Driver.cmd_line):
2052         * Scripts/webkitpy/performance_tests/perftest.py:
2053         (PerfTest.parse_output):
2054         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2055         (MainTest.test_parse_output):
2056         (MainTest.test_parse_output_with_failing_line):
2057         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2058         (PerfTestsRunner._parse_args):
2059         (PerfTestsRunner.run):
2060
2061 2012-11-28  Zan Dobersek  <zandobersek@gmail.com>
2062
2063         Remove deprecated logging usage from QueueEngine
2064         https://bugs.webkit.org/show_bug.cgi?id=103532
2065
2066         Reviewed by Dirk Pranke.
2067
2068         Replace usage of deprecated logging in webkitpy.tool.bot.queueengine with
2069         logging through the Logger object. The unit test is modified to reflect
2070         these changes.
2071
2072         After these changes the deprecated logging (i.e. logging to stderr) is not
2073         used anymore through webkitpy and can be removed.
2074
2075         * Scripts/webkitpy/tool/bot/queueengine.py:
2076         (QueueEngine.exit_after_handled_error):
2077         (QueueEngine.run):
2078         (QueueEngine._stopping):
2079         (QueueEngine._sleep):
2080         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2081         (QueueEngineTest._run_engine):
2082
2083 2012-11-28  Nate Chapin  <japhet@chromium.org>
2084
2085         Move empty loading to DocumentLoader, simplify FrameLoader::init()
2086         https://bugs.webkit.org/show_bug.cgi?id=101512
2087
2088         Reviewed by Adam Barth.
2089
2090         * DumpRenderTree/chromium/WebViewHost.cpp:
2091         (WebViewHost::updateForCommittedLoad): This function doesn't play nicely with empty urls and incorrectly
2092             interprets them as a non-empty load. This change is required for
2093              http/tests/navigation/new-window-redirect-history.html to continue to pass in chromium.
2094         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: This test relies on a callback that no longer
2095              is sent for about:blank loads.  Hook into didFinishLoadForFrame() instead.
2096         (TestWebKitAPI::didFinishLoadForFrame):
2097         (TestWebKitAPI::TEST):
2098
2099 2012-11-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2100
2101         [chromium] Allow plugins to opt-in to receive synthetic mouse events out of touch events.
2102         https://bugs.webkit.org/show_bug.cgi?id=103092
2103
2104         Reviewed by Tony Chang.
2105
2106         Update the test web-plugin to be able to opt-in to receive synthesized mouse events created
2107         from touch events.
2108
2109         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2110         (parseTouchEventRequestType):
2111         (TestWebPlugin::TestWebPlugin):
2112         (TestWebPlugin::initialize):
2113         * DumpRenderTree/chromium/TestWebPlugin.h:
2114         (TestWebPlugin):
2115
2116 2012-11-28  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2117
2118         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
2119         https://bugs.webkit.org/show_bug.cgi?id=103123
2120
2121         Reviewed by Laszlo Gombos.
2122
2123         Add support for PlatformWebView::simulateSpacebarKeyPress().
2124         This functionality is needed by WebKit2 API test MouseMoveAfterCrash
2125         which is going to be unskipped in bug #103252.
2126
2127         * TestWebKitAPI/efl/PlatformUtilities.cpp:
2128         (TestWebKitAPI::Util::sleep):
2129         * TestWebKitAPI/efl/PlatformWebView.cpp: Use usleep() instead of
2130         sleep().
2131         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2132         (TestWebKitAPI):
2133
2134 2012-11-28  Yael Aharon  <yael.aharon@intel.com>
2135
2136         Minor cleanup in TestInvocation
2137         https://bugs.webkit.org/show_bug.cgi?id=103512
2138
2139         Reviewed by Kenneth Rohde Christiansen.
2140
2141         Remove a function declaration that is not defined and not used.
2142         Fix spelling error in m_webProcessIsUnresponsive.
2143
2144         * WebKitTestRunner/TestInvocation.cpp:
2145         (WTR::TestInvocation::TestInvocation):
2146         (WTR::TestInvocation::invoke):
2147         * WebKitTestRunner/TestInvocation.h:
2148         (TestInvocation):
2149         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2150         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2151         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2152         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2153
2154 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2155
2156         Unreviewed. Use my personal email as bugzilla email.
2157
2158         * Scripts/webkitpy/common/config/committers.py:
2159
2160 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2161
2162         Unreviewed. Adding myself to committers.py.
2163
2164         * Scripts/webkitpy/common/config/committers.py:
2165
2166 2012-11-26  Andrey Adaikin  <aandrey@chromium.org>
2167
2168         Unreviewed. Adding myself to committers.py.
2169
2170         * Scripts/webkitpy/common/config/committers.py:
2171
2172 2012-11-28  Tommy Widenflycht  <tommyw@google.com>
2173
2174         Add basic implementation for MediaStreamAudioDestinationNode
2175         https://bugs.webkit.org/show_bug.cgi?id=101815
2176
2177         Reviewed by Chris Rogers.
2178
2179         Adds a bit of code that exercises the WebKit API.
2180
2181         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2182         (MockWebMediaStreamSourceConsumer):
2183         (MockWebMediaStreamSourceConsumer::~MockWebMediaStreamSourceConsumer):
2184         (MockWebMediaStreamCenter::didCreateMediaStream):
2185
2186 2012-11-28  Matt Falkenhagen  <falken@chromium.org>
2187
2188         Unreviewed. Adding myself to committers list.
2189
2190         * Scripts/webkitpy/common/config/committers.py:
2191
2192 2012-11-27  Li Yin  <li.yin@intel.com>
2193
2194         Unreviewed. Adding myself to committers list.
2195
2196         * Scripts/webkitpy/common/config/committers.py:
2197
2198 2012-11-27  Christophe Dumez  <christophe.dumez@intel.com>
2199
2200         Unreviewed. Adding myself to committers.py.
2201
2202         * Scripts/webkitpy/common/config/committers.py:
2203
2204 2012-11-27  Vivek Galatage  <vivek.vg@samsung.com>
2205
2206         Unreviewd. Adding myself to committers list.
2207
2208         * Scripts/webkitpy/common/config/committers.py:
2209
2210 2012-11-27  Tony Chang  <tony@chromium.org>
2211
2212         Bring back partytime!
2213         https://bugs.webkit.org/show_bug.cgi?id=103466
2214
2215         Reviewed by Adam Barth.
2216
2217         "code 404, message Unknown function images/partytime_gif" since we didn't
2218         allow .gif or .png files to be served.
2219
2220         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2221         (GardeningHTTPRequestHandler):
2222
2223 2012-11-27  Adam Barth  <abarth@webkit.org>
2224
2225         run-perf-tests fails on Android because of stderr output
2226         https://bugs.webkit.org/show_bug.cgi?id=103462
2227
2228         Reviewed by Ryosuke Niwa.
2229
2230         The chromium-android port produces some stderr output that causes
2231         run-perf-tests to get sad and not record the results of the performance
2232         test. This patch teaches run-perf-test to ignore this output much in
2233         the same way that it currently ignores some stdout messages.
2234
2235         * Scripts/webkitpy/performance_tests/perftest.py:
2236         (PerfTest.run):
2237         (PerfTest._should_ignore_line):
2238         (PerfTest):
2239         (PerfTest._should_ignore_line_in_stderr):
2240         (PerfTest._filter_stderr):
2241         (PerfTest._should_ignore_line_in_parser_test_result):
2242
2243 2012-11-27  Tony Chang  <tony@chromium.org>
2244
2245         Fix garden-o-matic for non-chromium ports
2246         https://bugs.webkit.org/show_bug.cgi?id=103458
2247
2248         Reviewed by Adam Barth.
2249
2250         I was getting a 403 error when trying to select any non-chromium port.
2251
2252         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2253         (ReflectionHandler._handle_request): Use the path without query params.
2254
2255 2012-11-27  Yael Aharon  <yael.aharon@intel.com>
2256
2257         [EFL][WK2] 3D pixel tests are failing
2258         https://bugs.webkit.org/show_bug.cgi?id=102833
2259
2260         Reviewed by Kenneth Rohde Christiansen.
2261
2262         Generate a snapshot of the view in the UI process instead of the web process.
2263         We have to use Texture Mapper in order to correctly paint 3D transforms etc.
2264
2265         * WebKitTestRunner/TestInvocation.h:
2266         (TestInvocation):
2267         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2268         (WTR::writeFunction):
2269         (WTR::paintRepaintRectOverlay):
2270         (WTR):
2271         (WTR::TestInvocation::forceRepaintDoneCallback):
2272         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2273         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2274         (WTR::PlatformWebView::windowSnapshotImage):
2275
2276 2012-11-27  Adam Barth  <abarth@webkit.org>
2277
2278         Make it possible to run performance tests on Chromium Android
2279         https://bugs.webkit.org/show_bug.cgi?id=103268
2280
2281         Reviewed by Ryosuke Niwa.
2282
2283         Based on a patch by Peter Beverloo.
2284
2285         This patch (almost) makes it possible to run WebKit performance tests
2286         on the Chromium port for Android. There are a few things I had to do
2287         in order to make this happen:
2288
2289         1) The worker number when creating a driver for a port is zero-based
2290            for layout tests and elsewhere. Android uses this to determine
2291            which device it has to run on, so make it zero based for performance
2292            tests as well.
2293
2294         2) Tests aren't available on the Android device, so we start an HTTP
2295            server that serves the tests to the device or emulator.
2296
2297         The one shortcoming of this patch is that chromium-android produces
2298         some stderr output that confuses run-perf-tests. I'll address that
2299         issue in a subsequent CL. This patch also depends on
2300         https://codereview.chromium.org/11416182 in order to work.
2301
2302         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2303         (ChromiumAndroidPort.start_http_server):
2304         (ChromiumAndroidDriver._command_from_driver_input):
2305         * Scripts/webkitpy/performance_tests/perftest.py:
2306         (ReplayPerfTest.prepare):
2307         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2308         (PerfTestsRunner.__init__):
2309         (PerfTestsRunner._parse_args):
2310         (PerfTestsRunner._start_servers):
2311         (PerfTestsRunner):
2312         (PerfTestsRunner._stop_servers):
2313         (PerfTestsRunner.run):
2314         (PerfTestsRunner._run_tests_set):
2315
2316 2012-11-27  Zan Dobersek  <zandobersek@gmail.com>
2317
2318         Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
2319         https://bugs.webkit.org/show_bug.cgi?id=103408
2320
2321         Reviewed by Dirk Pranke.
2322
2323         Remove the use of the deprecated log and error methods by replacing them with
2324         logging through Python's logging.Logger objects.
2325
2326         This patch covers such changes in webkitpy.common and webkitpy.layout_tests and also
2327         updates any affected unit test.
2328
2329         * Scripts/webkitpy/common/checkout/changelog.py:
2330         (ChangeLogEntry._parse_entry):
2331         * Scripts/webkitpy/common/checkout/checkout.py:
2332         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2333         (CheckoutTest.test_apply_patch):
2334         * Scripts/webkitpy/common/checkout/deps_mock.py:
2335         (MockDEPS.write_variable):
2336         * Scripts/webkitpy/common/checkout/scm/detection.py:
2337         (SCMDetector.default_scm):
2338         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2339         (SCMDetectorTest.test_detect_scm_system):
2340         * Scripts/webkitpy/common/checkout/scm/git.py:
2341         (Git._check_git_architecture):
2342         (Git._commit_on_branch):
2343         * Scripts/webkitpy/common/checkout/scm/scm.py:
2344         (SCM.ensure_clean_working_directory):
2345         (SCM.ensure_no_local_commits):
2346         (SCM.will.commit_locally_with_message):
2347         * Scripts/webkitpy/common/checkout/scm/svn.py:
2348         (SVN.apply_reverse_diff):
2349         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
2350         (Attachment._validate_flag_value):
2351         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2352         (Bugzilla._fetch_bug_page):
2353         (Bugzilla.bug_id_for_attachment_id):
2354         (Bugzilla.authenticate):
2355         (Bugzilla._commit_queue_flag):
2356         (Bugzilla.add_attachment_to_bug):
2357         (Bugzilla.add_patch_to_bug):
2358         (Bugzilla.create_bug):
2359         (Bugzilla.clear_attachment_flags):
2360         (Bugzilla.set_flag_on_attachment):
2361         (Bugzilla.obsolete_attachment):
2362         (Bugzilla.add_cc_to_bug):
2363         (Bugzilla.post_comment_to_bug):
2364         (Bugzilla.close_bug_as_fixed):
2365         (Bugzilla.reassign_bug):
2366         (reopen_bug):
2367         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2368         (MockBugzilla.create_bug):
2369         (MockBugzilla.reassign_bug):
2370         (MockBugzilla.set_flag_on_attachment):
2371         (MockBugzilla.post_comment_to_bug):
2372         (MockBugzilla.add_attachment_to_bug):
2373         (MockBugzilla.add_patch_to_bug):
2374         (MockBugzilla.reopen_bug):
2375         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2376         (test_add_cc_to_bug):
2377         (_assert_reopen):
2378         (test_reopen_bug):
2379         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2380         (MockBuilder.force_build):
2381         * Scripts/webkitpy/common/net/credentials.py:
2382         (Credentials._run_security_tool):
2383         * Scripts/webkitpy/common/net/credentials_unittest.py:
2384         (_assert_security_call):
2385         * Scripts/webkitpy/common/net/irc/irc_mock.py:
2386         (MockIRC.post):
2387         (MockIRC.disconnect):
2388         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2389         (IRCProxy.__init__):
2390         (IRCProxy.disconnect):
2391         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
2392         (IRCProxyTest.test_trivial):
2393         * Scripts/webkitpy/common/net/layouttestresults.py:
2394         (ORWTResultsHTMLParser._failures_from_fail_row):
2395         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2396         (test_failures_from_fail_row):
2397         * Scripts/webkitpy/common/net/networktransaction.py:
2398         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2399         (JSONTestResult._tokenize):
2400         (JSONTestResult._failure_types_from_actual_result):
2401         * Scripts/webkitpy/common/net/statusserver.py:
2402         (StatusServer.update_status):
2403         (StatusServer.update_svn_revision):
2404         * Scripts/webkitpy/common/net/statusserver_mock.py:
2405         (MockStatusServer.release_work_item):
2406         (MockStatusServer.update_work_items):
2407         (MockStatusServer.submit_to_ews):
2408         (MockStatusServer.update_status):
2409         * Scripts/webkitpy/common/net/unittestresults.py:
2410         (UnitTestResults.results_from_string):
2411         * Scripts/webkitpy/common/system/executive_mock.py:
2412         (MockExecutive.running_pids):
2413         (MockExecutive.run_and_throw_if_fail):
2414         (MockExecutive.run_command):
2415         (MockExecutive.popen):
2416         * Scripts/webkitpy/common/system/user_mock.py:
2417         (MockUser.confirm):
2418         (MockUser.open_url):
2419         * Scripts/webkitpy/common/system/workspace_unittest.py:
2420         (WorkspaceTest.test_create_zip):
2421         (WorkspaceTest.test_create_zip_exception):
2422         * Scripts/webkitpy/common/watchlist/watchlist_mock.py:
2423         (MockWatchList.determine_cc_and_messages):
2424         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2425         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
2426         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2427         (EflPortTest.test_show_results_html_file):
2428         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2429         (GtkPortTest.test_show_results_html_file):
2430         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2431         (test_show_results_html_file):
2432         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2433         (test_build_driver):
2434         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2435         (QtPortTest.test_show_results_html_file):
2436         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2437         (WinPortTest.test_show_results_html_file):
2438         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
2439         (XvfbDriverTest.assertDriverStartSuccessful):
2440         (XvfbDriverTest.test_start_no_pixel_tests):
2441         (XvfbDriverTest.test_start_pixel_tests):
2442         (XvfbDriverTest.test_start_arbitrary_worker_number):
2443         (XvfbDriverTest.test_start_next_worker):
2444         (XvfbDriverTest.test_stop):
2445         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2446         (TestLayoutTestApacheHttpd.test_start_cmd):
2447         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2448         (test_run_test_pause_before_testing):
2449         (test_run_memory_test):
2450         (_test_run_with_json_output):
2451         (test_run_respects_no_results):
2452         (test_run_generates_and_show_results_page):
2453         (test_run_respects_no_show_results):
2454         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2455         (FeedersTest.test_commit_queue_feeder):
2456         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2457         (FlakyTestReporterTest.test_create_bug_for_flaky_test):
2458         (test_report_flaky_tests_creating_bug):
2459         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2460         (IRCCommandTest.test_rollout_updates_working_copy):
2461         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2462         (IRCBotTest.test_exception_during_command):
2463         (IRCBotTest.test_hi):
2464         (IRCBotTest.test_help):
2465         (IRCBotTest.test_restart):
2466         (IRCBotTest.test_rollout):
2467         (IRCBotTest.test_revert):
2468         (IRCBotTest.test_roll_chromium_deps):
2469         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
2470         (IRCBotTest.test_multi_rollout):
2471         (IRCBotTest.test_rollout_with_r_in_svn_revision):
2472         (IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
2473         (IRCBotTest.test_rollout_bananas):
2474         (IRCBotTest.test_rollout_invalidate_revision):
2475         (IRCBotTest.test_rollout_invalidate_reason):
2476         (test_multi_rollout_invalidate_reason):
2477         (test_rollout_no_reason):
2478         (test_multi_rollout_no_reason):
2479         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2480         (SheriffTest.test_post_blame_comment_on_bug):
2481         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
2482         (ApplyWatchListLocalTest.test_args_parsing):
2483         (test_args_parsing_with_bug):
2484         * Scripts/webkitpy/tool/commands/download_unittest.py:
2485         (test_land_cowboy):
2486         (test_check_style):
2487         (test_create_rollout):
2488         (test_create_rollout_resolved):
2489         (test_rollout):
2490         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2491         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2492         (EarlyWarningSytemTest._default_expected_logs):
2493         (EarlyWarningSytemTest._test_builder_ews):
2494         (EarlyWarningSytemTest._test_testing_ews):
2495         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
2496         (OpenBugsTest.test_args_parsing):
2497         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2498         (QueryCommandsTest.test_bugs_to_commit):
2499         (QueryCommandsTest.test_patches_in_commit_queue):
2500         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2501         (FeederQueueTest.test_feeder_queue):
2502         (AbstractPatchQueueTest.test_next_patch):
2503         (AbstractPatchQueueTest.test_upload_results_archive_for_patch):
2504         (CommitQueueTest.test_commit_queue):
2505         (test_commit_queue_failure):
2506         (test_commit_queue_failure_with_failing_tests):
2507         (test_rollout):
2508         (test_rollout_lands):
2509         (test_auto_retry):
2510         (test_manual_reject_during_processing):
2511         (test_report_flaky_tests):
2512         (StyleQueueTest.test_style_queue_with_style_exception):
2513         (test_style_queue_with_watch_list_exception):
2514         * Scripts/webkitpy/tool/commands/queuestest.py:
2515         (QueuesTest._default_begin_work_queue_logs):
2516         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2517         (RollCommandsTest.test_update_chromium_deps):
2518         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2519         (UploadCommandsTest.test_assign_to_committer):
2520         (test_post):
2521         (test_attach_to_bug):
2522         (test_attach_to_bug_no_description_or_comment):
2523         (test_land_safely):
2524         (test_prepare):
2525         (test_upload):
2526         (test_mark_bug_fixed):
2527         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
2528         (ApplyWatchListTest.test_apply_watch_list_local):
2529         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2530         (CommitTest._test_check_test_expectations):
2531         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2532         (RunTestsTest.test_webkit_run_unit_tests):
2533         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2534         (StepsTest._assert_step_output_with_bug):
2535         (StepsTest._assert_post_diff_output_for_bug):
2536         (StepsTest.test_post_diff):
2537         (StepsTest.test_post_diff_for_commit):
2538         (StepsTest.test_ensure_bug_is_open_and_assigned):
2539         (StepsTest.test_runtests_args):
2540         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
2541         (SuggestReviewersTest.test_basic):
2542         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2543         (ValidateChangeLogsTest._assert_start_line_produces_output):
2544
2545 2012-11-27  Pratik Solanki  <psolanki@apple.com>
2546
2547         objc/objc-runtime.h does not exist on all PLATFORM(MAC)
2548         https://bugs.webkit.org/show_bug.cgi?id=101780
2549
2550         Reviewed by Brent Fulgham.
2551
2552         Clean up header includes so we don't include objc/objc-runtime.h.
2553
2554         * DumpRenderTree/mac/DumpRenderTree.mm:
2555         * DumpRenderTree/mac/ObjCPlugin.m:
2556         * TestWebKitAPI/mac/InstanceMethodSwizzler.h:
2557         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2558
2559 2012-11-27  Marja Hölttä  <marja@chromium.org>
2560
2561         Add callbacks to the FrameLoaderClient when a resource is requested
2562         https://bugs.webkit.org/show_bug.cgi?id=92761
2563
2564         Reviewed by Adam Barth.
2565
2566         In Chromium, when an extension script cancels a network
2567         request (which happens out of process), we'd like to
2568         notify content scripts running on the current page about
2569         which elements failed to load because the requests were
2570         cancelled (as opposed to e.g. the network request just
2571         didn't work). Since the resource request itself does not
2572         carry any information what DOM element is was made for,
2573         currently a content script has to search the DOM tree and
2574         guess which requests will be cancelled by its counter
2575         part. By adding these callbacks, the embedder can make
2576         this connection explictly.
2577
2578         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2579         (DRTTestRunner::DRTTestRunner):
2580         (DRTTestRunner::dumpResourceRequestCallbacks):
2581         (DRTTestRunner::reset):
2582         * DumpRenderTree/chromium/DRTTestRunner.h:
2583         (DRTTestRunner):
2584         (DRTTestRunner::setShouldDumpResourceRequestCallbacks):
2585         (DRTTestRunner::shouldDumpResourceRequestCallbacks):
2586         * DumpRenderTree/chromium/TestShell.h:
2587         (TestShell::shouldDumpResourceRequestCallbacks):
2588         * DumpRenderTree/chromium/WebViewHost.cpp:
2589         (WebViewHost::willRequestResource):
2590         * DumpRenderTree/chromium/WebViewHost.h:
2591         (WebViewHost):
2592
2593 2012-11-27  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
2594
2595         [GStreamer] Verify if GStreamer was previously initialized
2596         https://bugs.webkit.org/show_bug.cgi?id=103151
2597
2598         Reviewed by Philippe Normand.
2599
2600         This patch adds the gst_init() in GtkLauncher, so we can add the
2601         GStreamer options in the command line through
2602         gst_init_get_option_group().
2603
2604         This approach is not valid for MiniBrowser because it uses WebKit2,
2605         where the GStreamer backend lives in the web process, which is
2606         different from the UI process.
2607
2608         * GNUmakefile.am:
2609         * GtkLauncher/main.c:
2610         (main):
2611
2612 2012-11-27  Andras Becsi  <andras.becsi@digia.com>
2613
2614         [Qt] Fix the build with new Qt5 hash
2615         https://bugs.webkit.org/show_bug.cgi?id=103406
2616
2617         Reviewed by Csaba Osztrogonác.
2618
2619         Remove references to deprecated QApplication::GuiServer which
2620         has been removed, and use QStyleFactory::create instead of
2621         instantiating a QWindowsStyle directly since it is about to
2622         become an internal class.
2623
2624         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2625         (main):
2626         * QtTestBrowser/qttestbrowser.cpp:
2627         (LauncherApplication::LauncherApplication):
2628         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2629         (WTR::InjectedBundle::platformInitialize):
2630
2631 2012-11-27  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2632
2633         [style] Add a style-check for enum-member names
2634         https://bugs.webkit.org/show_bug.cgi?id=103157
2635
2636         Reviewed by Daniel Bates.
2637
2638         * Scripts/webkitpy/style/checkers/cpp.py:
2639         (_EnumState):
2640         (_EnumState.__init__):
2641         (_EnumState.process_clean_line):
2642         (check_enum_casing):
2643         (check_style):
2644         (process_line):
2645         (_process_lines):
2646         (CppChecker):
2647         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2648         (NoNonVirtualDestructorsTest.test_enum_casing):
2649         (NoNonVirtualDestructorsTest.test_internal_braces.Foo):
2650
2651 2012-11-26  Ryuan Choi  <ryuan.choi@gmail.com>
2652
2653         [EFL][jhbuild] Disable unnecessary options of elementary module
2654         https://bugs.webkit.org/show_bug.cgi?id=103360
2655
2656         Reviewed by Gyuyoung Kim.
2657
2658         When jhbuild configures elementary, unnecessary options may be enabled by
2659         user installed modules and it causes build break.
2660
2661         * efl/jhbuild.modules:
2662         Added --disable-emap --disable-ethumb --disable-eweather to elementary.
2663
2664 2012-11-26  Varun Jain  <varunjain@chromium.org>
2665
2666         LongPress and LongTap gestures should start drag/drop and open context menu respectively.
2667         https://bugs.webkit.org/show_bug.cgi?id=101545
2668
2669         Reviewed by Antonio Gomes.
2670
2671         For LongPress, we simulate drag by sending a mouse down and mouse drag
2672         events. If a drag is not started (because maybe there is no draggable
2673         element), then we show context menu instead (which is the current
2674         behavior for LongPress). For LongTap, we use the existing functions that
2675         LongPress uses to summon the context menu. LongPress initiated drag and
2676         drop can be enabled/disabled by the platform using the Setting
2677         touchDragDropEnabled which is disabled by default.
2678
2679         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2680         (WebTestRunner):
2681         (WebTestRunner::EventSender::EventSender):
2682         (WebTestRunner::EventSender::gestureLongTap):
2683         (WebTestRunner::EventSender::gestureEvent):
2684         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
2685         (EventSender):
2686         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2687         (WebTestRunner::TestRunner::TestRunner):
2688         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
2689         (WebTestRunner):
2690         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2691         (TestRunner):
2692
2693 2012-11-26  Christophe Dumez  <christophe.dumez@intel.com>
2694
2695         [EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
2696         https://bugs.webkit.org/show_bug.cgi?id=103224
2697
2698         Reviewed by Laszlo Gombos.
2699
2700         Add --local-storage command line argument to MiniBrowser to
2701         explicitely disable HTML5 local storage functionality. This
2702         is useful for testing purposes.
2703
2704         * MiniBrowser/efl/main.c:
2705         (window_create):
2706         (elm_main):
2707
2708 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
2709
2710         Remove use of deprecated logging from most of webkitpy.tool
2711         https://bugs.webkit.org/show_bug.cgi?id=103180
2712
2713         Reviewed by Dirk Pranke.
2714
2715         Remove calls to log and error methods of the deprecated_logging module, replacing them
2716         by using Python's Logger objects. This patch covers the switch in all of webkitpy.tool
2717         except the QueueEngine.
2718
2719         Unit tests are adjusted for these changes, moving output from expected stderr to expected logs.
2720
2721         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2722         (MockCommitQueue.run_command):
2723         (MockCommitQueue.command_passed):
2724         (MockCommitQueue.command_failed):
2725         (MockCommitQueue.report_flaky_tests):
2726         (MockCommitQueue.archive_last_test_results):
2727         (CommitQueueTaskTest._run_through_task):
2728         (CommitQueueTaskTest.test_success_case):
2729         (test_fast_success_case):
2730         (test_clean_failure):
2731         (test_update_failure):
2732         (test_apply_failure):
2733         (test_validate_changelog_failure):
2734         (test_build_failure):
2735         (test_red_build_failure):
2736         (test_flaky_test_failure):
2737         (test_failed_archive):
2738         (test_double_flaky_test_failure):
2739         (test_test_failure):
2740         (test_red_test_failure):
2741         (test_very_red_tree_retry):
2742         (test_red_tree_patch_rejection):
2743         (test_land_failure):
2744         * Scripts/webkitpy/tool/bot/feeders.py:
2745         (CommitQueueFeeder._update_work_items):
2746         (EWSFeeder.feed):
2747         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2748         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2749         (LayoutTestResultsReader.archive):
2750         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2751         (test_archive_last_layout_test_results):
2752         * Scripts/webkitpy/tool/bot/sheriff.py:
2753         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2754         (AbstractSequencedCommand.execute):
2755         * Scripts/webkitpy/tool/commands/commandtest.py:
2756         (CommandsTest.assert_execute_outputs):
2757         * Scripts/webkitpy/tool/commands/download.py:
2758         (AbstractPatchProcessingCommand._process_patch.execute):
2759         (ProcessBugsMixin._fetch_list_of_patches_to_process):
2760         (ProcessURLsMixin._fetch_list_of_patches_to_process):
2761         (AbstractRolloutPrepCommand._commit_info):
2762         * Scripts/webkitpy/tool/commands/download_unittest.py:
2763         (AbstractRolloutPrepCommandTest.test_commit_info):
2764         (DownloadCommandsTest.test_build):
2765         (DownloadCommandsTest.test_build_and_test):
2766         (test_apply_attachment):
2767         (test_apply_from_bug):
2768         (test_apply_watch_list):
2769         (test_land):
2770         (test_land_red_builders):
2771         (test_check_style):
2772         (test_build_attachment):
2773         (test_land_attachment):
2774         (test_land_from_bug):
2775         (test_land_from_url):
2776         (test_prepare_rollout):
2777         (test_create_rollout):
2778         (test_create_rollout_resolved):
2779         (test_rollout):
2780         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2781         (AbstractEarlyWarningSystem.handle_script_error.does):
2782         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2783         (EarlyWarningSytemTest._default_expected_stderr):
2784         (EarlyWarningSytemTest._default_expected_logs):
2785         (EarlyWarningSytemTest._test_testing_ews):
2786         * Scripts/webkitpy/tool/commands/openbugs.py:
2787         (OpenBugs.execute):
2788         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
2789         (OpenBugsTest.test_args_parsing):
2790         * Scripts/webkitpy/tool/commands/perfalizer.py:
2791         (Perfalizer.handle_unexpected_error):
2792         * Scripts/webkitpy/tool/commands/queries.py:
2793         (PatchesInCommitQueue.execute):
2794         (PatchesToCommitQueue._needs_commit_queue):
2795         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2796         (QueryCommandsTest.test_bugs_to_commit):
2797         (QueryCommandsTest.test_patches_in_commit_queue):
2798         (QueryCommandsTest.test_patches_to_commit_queue):
2799         * Scripts/webkitpy/tool/commands/queues.py:
2800         (AbstractQueue._cc_watchers):
2801         (AbstractQueue.begin_work_queue):
2802         (FeederQueue.handle_unexpected_error):
2803         (CommitQueue.handle_script_error):
2804         (AbstractReviewQueue.handle_unexpected_error):
2805         (AbstractReviewQueue.handle_script_error):
2806         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2807         (test_auto_retry):
2808         * Scripts/webkitpy/tool/commands/queuestest.py:
2809         (QueuesTest.assert_outputs):
2810         (QueuesTest._default_begin_work_queue_stderr):
2811         (QueuesTest):
2812         (QueuesTest._default_begin_work_queue_logs):
2813         (QueuesTest.assert_queue_outputs):
2814         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2815         (RollCommandsTest.test_update_chromium_deps):
2816         (test_update_chromium_deps_older_revision):
2817         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2818         (SheriffBot.handle_unexpected_error):
2819         * Scripts/webkitpy/tool/commands/stepsequence.py:
2820         (StepSequence.run_and_handle_errors):
2821         * Scripts/webkitpy/tool/commands/upload.py:
2822         (AssignToCommitter._assign_bug_to_last_patch_attacher):
2823         (AbstractPatchUploadingCommand._prepare_state):
2824         (PostCommits.execute):
2825         (MarkBugFixed._determine_bug_id_and_svn_revision):
2826         (MarkBugFixed.execute):
2827         (CreateBug.create_bug_from_commit):
2828         (CreateBug.execute):
2829         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2830         (test_obsolete_attachments):
2831         (test_land_safely):
2832         (test_mark_bug_fixed):
2833         * Scripts/webkitpy/tool/multicommandtool.py:
2834         (Command.check_arguments_and_execute):
2835         (MultiCommandTool.main):
2836         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2837         (CommandTest.test_required_arguments):
2838         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:
2839         (AddSvnMimetypeForPng.run):
2840         * Scripts/webkitpy/tool/steps/applypatch.py:
2841         (ApplyPatch.run):
2842         * Scripts/webkitpy/tool/steps/build.py:
2843         (Build.run):
2844         * Scripts/webkitpy/tool/steps/checkstyle.py:
2845         * Scripts/webkitpy/tool/steps/closebug.py:
2846         (CloseBug.run):
2847         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
2848         (CloseBugForLandDiff.run):
2849         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2850         (CloseBugForLandDiffTest.test_empty_state):
2851         * Scripts/webkitpy/tool/steps/commit.py:
2852         (Commit.run):
2853         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2854         (CommitTest._test_check_test_expectations):
2855         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
2856         (EnsureLocalCommitIfNeeded.run):
2857         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
2858         (ObsoletePatches.run):
2859         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2860         (PrepareChangeLog.run):
2861         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2862         (ReopenBugAfterRollout.run):
2863         * Scripts/webkitpy/tool/steps/runtests.py:
2864         (RunTests.run):
2865         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2866         (RunTestsTest.test_webkit_run_unit_tests):
2867         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2868         (StepsTest.test_update_step):
2869         (StepsTest.test_runtests_args):
2870         * Scripts/webkitpy/tool/steps/update.py:
2871         (Update.run):
2872         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2873         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
2874         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_multipatch_bug):
2875         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2876         (UpdateChangeLogsWithReviewer._guess_reviewer_from_bug):
2877         (UpdateChangeLogsWithReviewer.run):
2878         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
2879         (UpdateChromiumDEPS._validate_revisions):
2880         (UpdateChromiumDEPS.run):
2881         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2882         (ValidateChangeLogs._check_changelog_diff):
2883         (ValidateChangeLogs.run):
2884         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2885         (ValidateChangeLogsTest._assert_start_line_produces_output):
2886         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2887         (ValidateReviewer.run):
2888
2889 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
2890
2891         Coverage testing in webkitpy should omit some paths
2892         https://bugs.webkit.org/show_bug.cgi?id=103267
2893
2894         Reviewed by Dirk Pranke.
2895
2896         Omit testing coverage of any file under /usr directory and any file
2897         that is of third party origin and was autoinstalled.
2898
2899         * Scripts/webkitpy/test/main.py:
2900         (Tester._run_tests):
2901
2902 2012-11-26  Jaehun Lim  <ljaehun.lim@samsung.com>
2903
2904         Text Autosizing: Add Text Autosizing APIs for WK2
2905         https://bugs.webkit.org/show_bug.cgi?id=100633
2906
2907         Reviewed by Sam Weinig.
2908
2909         Add test cases for Text Autosizing in WKPreferences.
2910
2911         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2912         (TestWebKitAPI::TEST):
2913
2914 2012-11-26  Pierre Rossi  <pierre.rossi@gmail.com>
2915
2916         [Qt] REGRESSION(r135575): It made all tests assert
2917         https://bugs.webkit.org/show_bug.cgi?id=103169
2918
2919         Reviewed by Simon Hausmann.
2920
2921         This fixes another regression introduced in r135515:
2922         initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
2923         since it can be called from WebKit2 to initialize QStyle for testing.
2924         This would then lead to things such as PlatformStrategies being
2925         initialized twice.
2926
2927         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Also propagate the change to DRT this time.
2928         (WebCore::DumpRenderTree::DumpRenderTree):
2929
2930 2012-11-24  Zan Dobersek  <zandobersek@gmail.com>
2931
2932         Add the --order option to NRWT
2933         https://bugs.webkit.org/show_bug.cgi?id=102229
2934
2935         Reviewed by Dirk Pranke.
2936
2937         The --order option controls in what order the gathered tests will be run.
2938         There are 3 options:
2939         - natural, the tests are sorted in natural order,
2940         - random, the tests are sorted in random order,
2941         - none, the tests are kept in the order in which they were specified through
2942         arguments or the test list.
2943
2944         The natural option is the default one and maintains the current behavior.
2945
2946         The none option is primarily intended to be used with the --test-list option,
2947         with the test list file expected to list specific test names.
2948         When a directory is specified as one of the paths from under which tests should
2949         be gathered and the none option is used, that path will expand to all the tests
2950         under it, with these tests sorted in the natural order.
2951
2952         Using --order=random duplicated the behavior of the --randomize-order option, so
2953         the latter is removed.
2954
2955         This patch also incorporates the change with which makes it is possible to specify
2956         a test via arguments or the test list multiple tests and then have the test run
2957         that many times.
2958
2959         * Scripts/webkitpy/common/find_files.py:
2960         (find): Accept an optional sorting key that is used to sort files found in the directories
2961         that the given paths specify.
2962         (_normalized_find): Both paths that are then searched for the tests and the tests that
2963         were found are now kept in lists. This makes it possible to run a test multiple times
2964         by specifying it multiple times through arguments or the test list file.
2965         (_normalized_find.sort_by_directory_key):
2966         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2967         (LayoutTestFinder.find_tests): Keep the paths where we should search for tests in a list.
2968         (LayoutTestFinder.skip_tests): Subtracting from a set of paths is necessary.
2969         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2970         (LayoutTestRunner.__init__): The Sharder class no longer needs a test path separator.
2971         (Sharder.__init__): Ditto.
2972         (Sharder._resize_shards):
2973         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2974         (SharderTests.get_shards): Modify the Shader initializing as required.
2975         (SharderTests.test_multiple_locked_shards): The natural sorting and test name key unit tests
2976         are now moved to the base Port unit tests.
2977         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2978         (Manager._prepare_lists): Keep the test names in a list. Order that list as specified by
2979         the new --order option.
2980         * Scripts/webkitpy/layout_tests/port/base.py:
2981         (Port.tests): This method should now return a list of all the tests found in the specified
2982         paths.
2983         (Port._real_tests): A list is required, so no conversion to a set is made.
2984         (Port):
2985         (Port.test_key): Place this method here for now, but it should really move into a separate
2986         module.
2987         (Port._natural_sort_key): Ditto.
2988         (Port._natural_sort_key.tryint):
2989         (Port._virtual_tests): A list is required, so the function now operates on that rather than
2990         on a set.
2991         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2992         (PortTest.test_find_with_skipped_directories_2): Adjust the test case to check for an empty
2993         list rather than an empty set.
2994         (PortTest.test_dont_require_http_server):
2995         (NaturalCompareTest): The natural sorting unit tests are placed here for now.
2996         (NaturalCompareTest.assert_cmp):
2997         (NaturalCompareTest.test_natural_compare):
2998         (KeyCompareTest): The test name key unit tests are placed here for now.
2999         (KeyCompareTest.assert_cmp):
3000         (KeyCompareTest.test_test_key):
3001         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3002         (parse_args): Remove the --randomize-order option, it's now possible to replicate its behavior
3003         by using --order=random.
3004         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Add unit tests covering
3005         various aspects of this change.
3006         (MainTest.test_natural_order):
3007         (MainTest):
3008         (MainTest.test_natural_order_test_specified_multiple_times):
3009         (MainTest.test_random_order):
3010         (MainTest.test_random_order_test_specified_multiple_times):
3011         (MainTest.test_no_order):
3012         (MainTest.test_no_order_test_specified_multiple_times):
3013         (MainTest.test_no_order_with_directory_entries_in_natural_order):
3014         * Scripts/webkitpy/tool/commands/queries.py:
3015         (PrintExpectations.execute): Operate on a set of tests when printing out expectations.
3016
3017 2012-11-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3018
3019         Unreviewed, rolling out r135600.
3020         http://trac.webkit.org/changeset/135600
3021         https://bugs.webkit.org/show_bug.cgi?id=103173
3022
3023         It made EFL API test is failed (Requested by gyuyoung_mbp on
3024         #webkit).
3025
3026         * TestWebKitAPI/PlatformEfl.cmake:
3027         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3028         (TestWebKitAPI::Util::sleep):
3029         * TestWebKitAPI/efl/PlatformWebView.cpp:
3030
3031 2012-11-23  Alexis Menard  <alexis@webkit.org>
3032
3033         [CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
3034         https://bugs.webkit.org/show_bug.cgi?id=102104
3035
3036         Reviewed by Julien Chaffraix.
3037
3038         Protect the new feature behind a feature flag.
3039
3040         * Scripts/webkitperl/FeatureList.pm:
3041         * qmake/mkspecs/features/features.pri:
3042
3043 2012-11-23  Mario Sanchez Prada  <mario@webkit.org>
3044
3045         Unreviewed. Update my e-mail address.
3046
3047         * Scripts/webkitpy/common/config/committers.py:
3048
3049 2012-11-23  Mateusz Leszko  <m.leszko@samsung.com>
3050
3051         [EFL][GTK] Adapt accessibility feature to WebKitTestRunner.
3052         https://bugs.webkit.org/show_bug.cgi?id=100757
3053
3054         Reviewed by Laszlo Gombos.
3055
3056         Allow to build accessibility feature in WebkitTestRunner for EFL Platform.
3057         Updating CMake files due to changes from Bug 99011.
3058
3059         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3060         (WTR::AccessibilityController::AccessibilityController):
3061         (WTR):
3062         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3063         (AccessibilityController):
3064         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3065         (WTR):
3066         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3067         (AccessibilityUIElement):
3068         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: - Removed gtk/gtk.h dependency.
3069         * WebKitTestRunner/PlatformEfl.cmake: - Adding atk includes.
3070
3071 2012-11-16  Yury Semikhatsky  <yurys@chromium.org>
3072
3073         Memory instrumentation: extract MemoryObjectInfo declaration into a separate file
3074         https://bugs.webkit.org/show_bug.cgi?id=102510
3075
3076         Reviewed by Pavel Feldman.
3077
3078         Added missing includes.
3079
3080         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3081
3082 2012-11-23  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3083
3084         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
3085         https://bugs.webkit.org/show_bug.cgi?id=103123
3086
3087         Reviewed by Kenneth Rohde Christiansen.
3088
3089         Add support for PlatformWebView::simulateSpacebarKeyPress() and enable
3090         WebKit2 API test ResponsivenessTimerDoesntFireEarly.
3091
3092         * TestWebKitAPI/PlatformEfl.cmake: Enable ResponsivenessTimerDoesntFireEarly
3093         test.
3094         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3095         (TestWebKitAPI::Util::sleep): Use usleep() instead of sleep since the
3096         test case is passing 0.5 seconds to sleep.
3097         * TestWebKitAPI/efl/PlatformWebView.cpp:
3098         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Implemented.
3099         (TestWebKitAPI):
3100
3101 2012-11-23  Wojciech Bielawski  <w.bielawski@samsung.com>
3102
3103         [WK2][WKTR] WebKitTestRunner needs eventSender.contextClick()
3104         https://bugs.webkit.org/show_bug.cgi?id=86881
3105
3106         Reviewed by Kenneth Rohde Christiansen.
3107
3108         eventSender object extended with contextClick() method in WebKitTestRunner.
3109         contextClick() method returns an array of menu items objects with field 'title' containing title of single
3110         context menu entry. According to some tests menu items objects shall also support 'click()' method, but it's not
3111         delivered in this patch.
3112
3113         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3114         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3115         (WTR::EventSendingController::contextClick):
3116         (WTR):
3117         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3118         (EventSendingController):
3119
3120 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
3121
3122         [Qt] Compiling against QtWebkit API requires QT_DLL to be defined
3123         https://bugs.webkit.org/show_bug.cgi?id=102942
3124
3125         Reviewed by Tor Arne Vestbø.
3126
3127         Remove the requirement of having QT_DLL defined in order for the QWEBKIT_EXPORT
3128         macro to be defined as Q_DECL_IMPORT. Instead unify the export macro definition
3129         to follow the same rules as other Qt 5 modules, with the exception that instead of
3130         QT_BUILD_WEBKIT_LIB we continue to use BUILDING_WEBKIT, because that's used also
3131         in other cross-platform header files to determine the correct meaning of export
3132         macros.
3133
3134         * qmake/mkspecs/features/default_post.prf:
3135         * qmake/mkspecs/features/win32/default_post.prf:
3136
3137 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
3138
3139         [Qt] QWebPage::shouldInterruptJavaScript should be virtual in Qt 5
3140         https://bugs.webkit.org/show_bug.cgi?id=103111
3141
3142         Reviewed by Kenneth Rohde Christiansen.
3143
3144         This function was added as a slot during Qt 4.x times because adding
3145         virtual functions breaks binary compatibility. This constraint is gone
3146         with the initial release of WebKit with Qt 5, and therefore we can
3147         make it virtual now.
3148
3149         The change is fully source compatible as existing "re-implementations"
3150         as slots will now be called through it being a virtual function. They
3151         become unused slots.
3152
3153         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3154         (WebCore::WebPage::shouldInterruptJavaScript):
3155         (WebPage):
3156         * QtTestBrowser/webpage.h:
3157         (WebPage):
3158
3159 2012-11-22  Peter Beverloo  <peter@chromium.org>
3160
3161         [Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
3162         https://bugs.webkit.org/show_bug.cgi?id=103065
3163
3164         Reviewed by Dirk Pranke.
3165
3166         This addresses two further reliability issues in the Android test running
3167         scripts. Firstly, the run_tests.py script needs to have the --exit_code
3168         argument passed in order to return non-zero codes, which we need for the
3169         build master to distinguish failures from successful runs.
3170
3171         Secondly, it modifies the layout test runner to briefly wait (through
3172         the wait-for-device command) after requesting a device to switch to root
3173         mode. Without this waiting period, commands might get lost and thereby
3174         unexpectedly fail.
3175
3176         * Scripts/run-api-tests:
3177         * Scripts/run-chromium-webkit-unit-tests:
3178         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3179         (ChromiumAndroidDriver._setup_test):
3180         (ChromiumAndroidDriver._restart_adb_as_root):
3181
3182 2012-11-22  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi <pierre.rossi@digia.com>
3183
3184         [Qt] Separate QWidget dependant code into separate WebKitWidgets static library
3185         https://bugs.webkit.org/show_bug.cgi?id=102800
3186
3187         Reviewed by Tor Arne Vestbø.
3188
3189         This patch separates code that needs to use QWidget related APIs in
3190         WebKit/qt/WebCoreSupport and Api from code that doesn't. This means for
3191         example FrameLoaderClientQt.cpp remains in the WebKit1 static library,
3192         while qwebpage.cpp and qwebframe.cpp become part of the WebKitWidgets
3193         static library. WebKit1 is compiled without QT += widgets and therefore
3194         any widget related dependency has been moved "up" and out of WebKit1 into
3195         the WebKitWidgets library.
3196
3197         Between the code in WebKit.a and WebKitWidgets.a new adapters and
3198         interfaces have been introduced, such as QWebPageAdapter and
3199         QWebFrameAdapter. QWebPageAdapter, when used from WebKit1, is a way to
3200         call out into the API layer, implemented by QWebPage (QWebPagePrivate).
3201         The other way around if QWebPage wants to access WebCore or
3202         WebCoreSupport related functionality, it will go through
3203         QWebPageAdapater (as base class). The separation in the direction up
3204         into the API layer is complete with this patch, no code in WebKit1
3205         depends on QtWidgets. The separation the other way around, code in the
3206         API layer not using any WebCore types, is not complete yet.
3207
3208         Some classes such as QWebSettings, QWebElement or
3209         DumpRenderTreeSupportQt remain in WebKit1. While they are API layer,
3210         they do not depend on widget related Qt APIs and they make much more
3211         use of WebCore internal APIs and therefore are easier to keep in
3212         WebKit1.
3213
3214         In the future we plan to place a real shared library boundary between
3215         WebKit1 and WebKitWidgets, by keeping the WebKit1 static library as
3216         part of the QtWebKit shared library and by turning the WebKitWidgets
3217         static library into a shared one.
3218
3219         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3220         (WebCore::WebPage::resetSettings):
3221         (WebCore::WebPage::createWindow):
3222         (WebCore::DumpRenderTree::DumpRenderTree):
3223         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3224         (WebCore::DumpRenderTree::initJSObjects):
3225         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
3226         (WebCore::DumpRenderTree::dumpFramesAsText):
3227         (WebCore::DumpRenderTree::dump):
3228         (WebCore::DumpRenderTree::createWindow):
3229         (WebCore::DumpRenderTree::pageAdapter):
3230         (WebCore):
3231         (WebCore::DumpRenderTree::mainFrameAdapter):
3232         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3233         (DumpRenderTree):
3234         * DumpRenderTree/qt/EventSenderQt.cpp:
3235         (EventSender::contextClick):
3236         (EventSender::scalePageBy):
3237         * DumpRenderTree/qt/TestRunnerQt.cpp:
3238         (TestRunner::reset):
3239         (TestRunner::display):
3240         (TestRunner::closeWebInspector):
3241         (TestRunner::showWebInspector):
3242         (TestRunner::evaluateInWebInspector):
3243         (TestRunner::setFrameFlatteningEnabled):
3244         (TestRunner::goBack):
3245         (TestRunner::setDefersLoading):
3246         (TestRunner::pauseAnimationAtTimeOnElementWithId):
3247         (TestRunner::pauseTransitionAtTimeOnElementWithId):
3248         (TestRunner::numberOfActiveAnimations):
3249         (TestRunner::setCaretBrowsingEnabled):
3250         (TestRunner::setAuthorAndUserStylesEnabled):
3251         (TestRunner::callShouldCloseOnWebView):
3252         (TestRunner::setSmartInsertDeleteEnabled):
3253         (TestRunner::setSelectTrailingWhitespaceEnabled):
3254         (TestRunner::execCommand):
3255         (TestRunner::isCommandEnabled):
3256         (TestRunner::findString):
3257         (TestRunner::elementDoesAutoCompleteForElementWithId):
3258         (TestRunner::setMockDeviceOrientation):
3259         (TestRunner::setGeolocationPermission):
3260         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3261         (TestRunner::setMockGeolocationPositionUnavailableError):
3262         (TestRunner::setMockGeolocationPosition):
3263         (TestRunner::evaluateScriptInIsolatedWorld):
3264         (TestRunner::addUserStyleSheet):
3265         (TestRunner::setMinimumTimerInterval):
3266         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3267         (TextInputController::selectedRange):
3268         (TextInputController::firstRectForCharacterRange):
3269         (TextInputController::unmarkText):
3270         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
3271         (LoadAlternateHTMLStringItem::invoke):
3272         * qmake/mkspecs/features/default_post.prf:
3273         * qmake/mkspecs/features/production_build.prf:
3274         * qmake/mkspecs/features/webkit_modules.prf:
3275         * qmake/mkspecs/modules/webkitwidgets.prf: Added.
3276
3277 2012-11-22  Christophe Dumez  <christophe.dumez@intel.com>
3278
3279         WebKitTestRunner needs layoutTestController.setCacheModel
3280         https://bugs.webkit.org/show_bug.cgi?id=42684
3281
3282         Reviewed by Kenneth Rohde Christiansen.
3283
3284         Add support for testRunner.setCacheModel to WebKitTestRunner.
3285
3286         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3287         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3288         (WTR::InjectedBundle::beginTesting):
3289         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3290         (WTR::TestRunner::setCacheModel):
3291         (WTR):
3292         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3293         (TestRunner):
3294
3295 2012-11-22  Balazs Kelemen  <kbalazs@webkit.org>
3296
3297         [Qt][WTR] TestController::platformRunUntil should not do busy waiting
3298         https://bugs.webkit.org/show_bug.cgi?id=101327
3299
3300         Reviewed by Simon Hausmann.
3301
3302         Avoid busy waiting for events in platformRunUntil while making
3303         sure we don't change the behavior of modal event loops.
3304
3305         * WebKitTestRunner/TestController.cpp:
3306         (WTR::TestController::~TestController):
3307         * WebKitTestRunner/TestController.h:
3308         (TestController):
3309         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3310         (WTR::TestController::platformDestroy):
3311         (WTR):
3312         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3313         (WTR::TestController::platformDestroy):
3314         (WTR):
3315         * WebKitTestRunner/mac/TestControllerMac.mm:
3316         (WTR::TestController::platformDestroy):
3317         (WTR):
3318         * WebKitTestRunner/qt/TestControllerQt.cpp:
3319         (TestController::RunLoop): Helper class to handle
3320         the event loop logic
3321         (WTR):
3322         (WTR::TestController::RunLoop::RunLoop):
3323         (WTR::TestController::RunLoop::runUntil): Use QEventLoop to implement
3324         the run loop. This is the appropriate API to push the WaitForMoreEvents
3325         flag to QCoreApplication::processEvents and also being able to exit the
3326         loop if we have timed out.
3327         (WTR::TestController::RunLoop::notifyDone):
3328         (WTR::TestController::RunLoop::timerFired):
3329         (WTR::TestController::RunLoop::runModal):
3330         (WTR::TestController::notifyDone):
3331         (WTR::TestController::platformInitialize):
3332         (WTR::TestController::platformDestroy):
3333         (WTR::TestController::platformRunUntil):
3334         (WTR::TestController::runModal):
3335         * WebKitTestRunner/win/TestControllerWin.cpp:
3336         (WTR::TestController::platformDestroy):
3337         (WTR):
3338
3339 2012-11-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3340
3341         [EFL][WK2] Enable WKPreferences and AboutBlankLoad API tests
3342         https://bugs.webkit.org/show_bug.cgi?id=102926
3343
3344         Reviewed by Kenneth Rohde Christiansen.
3345
3346         Add missing bits needed by WKPreferences and AboutBlankLoad API
3347         tests in the test harness and enable these tests on EFL port.
3348
3349         * TestWebKitAPI/PlatformEfl.cmake:
3350         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3351         (TestWebKitAPI::TEST):
3352         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3353         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3354         (Util):
3355
3356 2012-11-21  Zan Dobersek  <zandobersek@gmail.com>
3357
3358         [GTK][WTR] Implement AccessibilityUIElement::stringValue
3359         https://bugs.webkit.org/show_bug.cgi?id=102951
3360
3361         Reviewed by Martin Robinson.
3362
3363         Implement AccessibilityUIElement::stringValue in the ATK backend
3364         in the same manner it is implemented in DumpRenderTree.
3365
3366         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3367         (WTR::replaceCharactersForResults):
3368         (WTR):
3369         (WTR::AccessibilityUIElement::stringValue):
3370
3371 2012-11-21  Vineet Chaudhary  <rgf748@motorola.com>
3372
3373         Unreviewed. Adding myself to committers.py.
3374
3375         * Scripts/webkitpy/common/config/committers.py:
3376
3377 2012-11-21  Tien-Ren Chen  <trchen@chromium.org>
3378
3379         [chromium] Device scale factor should be no-op when applyDeviceScaleFactorInCompositor == 0
3380         https://bugs.webkit.org/show_bug.cgi?id=100061
3381
3382         Reviewed by Adam Barth.
3383
3384         On Android we're using a different pixel scaling implementation
3385         (WebCore::Settings::applyDefaultDeviceScaleFactorInCompositor() == 0) than other
3386         platforms. In this mode, we don't make use of device-independent pixels. Device
3387         scale factor is provided to WebKit and get merged into page scale factor. Other
3388         than that device scale factor should have no effects on rendering.
3389
3390         * DumpRenderTree/chromium/WebPreferences.cpp:
3391         (WebPreferences::applyTo):
3392
3393 2012-11-21  Fady Samuel  <fsamuel@chromium.org>
3394
3395         Clear MousePressed state on context menu to avoid initiating a drag
3396         https://bugs.webkit.org/show_bug.cgi?id=101786
3397
3398         Reviewed by Ojan Vafai.
3399
3400         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3401         (WebTestRunner):
3402         (WebTestRunner::EventSender::EventSender):
3403         (WebTestRunner::EventSender::contextClick):
3404         Only send a MouseUp on Windows. Keep the current mouse pressed state when
3405         calling up a context menu.
3406
3407 2012-11-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3408
3409         [EFL] KURL unit test crashing when tiled backing store is enabled on Release Bots
3410         https://bugs.webkit.org/show_bug.cgi?id=102895
3411
3412         Reviewed by Gyuyoung Kim.
3413
3414         Change the link order so it wont override the new operator on gtest.
3415         Looks like it was crashing because an allocator mismatch (using libc's
3416         new and later fastMalloc delete. Thanks to Kangil Han for hinting on
3417         the fastMalloc issue.
3418
3419         * TestWebKitAPI/CMakeLists.txt:
3420
3421 2012-11-21  Kentaro Hara  <haraken@chromium.org>
3422
3423         Unreviewed, rolling out r135340.
3424         http://trac.webkit.org/changeset/135340
3425         https://bugs.webkit.org/show_bug.cgi?id=102492
3426
3427         It broke Safari's internal build
3428
3429         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3430         (new):
3431         (GenerateModule):
3432         (GenerateInterface):
3433         (finish):
3434
3435 2012-11-21  Yael Aharon  <yael.aharon@intel.com>, Gyuyoung Kim <gyuyoung.kim@samsung.com>
3436
3437         [EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
3438         https://bugs.webkit.org/show_bug.cgi?id=101526
3439
3440         Reviewed by Kenneth Rohde Christiansen.
3441
3442         Turn on WTF_USE_TILED_BACKING_STORE for EFL port.
3443
3444         * Scripts/webkitperl/FeatureList.pm:
3445         * TestWebKitAPI/CMakeLists.txt: No include KURL.cpp because of API test crash.
3446
3447 2012-11-21  Jongseok Yang  <js45.yang@samsung.com>
3448
3449         [EFL][WK2] Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX
3450         https://bugs.webkit.org/show_bug.cgi?id=102867
3451
3452         Reviewed by Gyuyoung Kim.
3453
3454         Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX.
3455
3456         ewk_view_setting_encoding_custom_XXX APIs might be misunderstanded as the "setting" word
3457         because ewk_view_setting_encoding_custom_set triggers the "reload" operation.
3458         And ewk_view_setting_XXX is not correct because there is ewk_settings object for settings.
3459
3460         * MiniBrowser/efl/main.c:
3461         (on_key_down):
3462
3463 2012-11-20  Sheriff Bot  <webkit.review.bot@gmail.com>
3464
3465         Unreviewed, rolling out r133859.
3466         http://trac.webkit.org/changeset/133859
3467         https://bugs.webkit.org/show_bug.cgi?id=102875
3468
3469         This patch makes API test broken (Requested by gyuyoung on
3470         #webkit).
3471
3472         * Scripts/webkitperl/FeatureList.pm:
3473
3474 2012-11-20  Jinwoo Song  <jinwoo7.song@samsung.com>
3475
3476         [EFL][WK2] Add Ewk_Window_Features API and related UI callbacks
3477         https://bugs.webkit.org/show_bug.cgi?id=99114
3478
3479         Reviewed by Gyuyoung Kim.
3480
3481         Implemented window_create and window_close smartcallback functions.
3482
3483         * MiniBrowser/efl/main.c:
3484         (on_window_create):
3485         (on_window_close):
3486         (window_create):
3487
3488 2012-11-20  Ojan Vafai  <ojan@chromium.org>
3489
3490         Simplify builder filters now that we have lists of which builders run which tests
3491         https://bugs.webkit.org/show_bug.cgi?id=102849
3492
3493         Reviewed by Dirk Pranke.
3494
3495         We only need filters when we load the same master for multiple groups in the
3496         same test type, i.e. when we need to only include some of the builders that run
3497         a given test suite on a given master.
3498
3499         Also, get rid of the DEFAULT_BUILDER enum. We were always using the first builder anyways.
3500         Now just make it a method on BuilderGroup.
3501
3502         * TestResultServer/static-dashboards/builders.js:
3503         (BuilderGroup.prototype.append):
3504         (BuilderGroup.prototype.setup):
3505         (BuilderGroup.prototype._defaultBuilder):
3506         (BuilderGroup.prototype.master):
3507         (requestBuilderList):
3508         (isChromiumWebkitTipOfTreeTestRunner):
3509         (isChromiumWebkitDepsTestRunner):
3510         (loadBuildersList):
3511         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3512         (test):
3513
3514 2012-11-20  Ojan Vafai  <ojan@chromium.org>
3515
3516         Remove perfav master for webkit_unit_tests and test_shell_tests.
3517         There are no bots on this master that run these tests.
3518         * TestResultServer/static-dashboards/builders.js:
3519
3520 2012-11-20  Ojan Vafai  <ojan@chromium.org>
3521
3522         Remove special case for layout tests when builders fail to load
3523         https://bugs.webkit.org/show_bug.cgi?id=102842
3524
3525         Reviewed by Tony Chang.
3526
3527         Now that we load only builders that actually run the given test
3528         type, we can reliably show errors to the users because it
3529         represents a broken bot.
3530         * TestResultServer/static-dashboards/loader.js:
3531
3532 2012-11-15  Ojan Vafai  <ojan@chromium.org>
3533
3534         Generate a list of builders/test suites from the buildbot json
3535         https://bugs.webkit.org/show_bug.cgi?id=102443
3536
3537         Reviewed by Dirk Pranke.
3538
3539         Instead of the cludgy things we do now to track which bots run which tests,
3540         we generate all that data from the buildbots' json files.
3541         This is the minimal amount to keep everything working. Once this lands,
3542         we can also do a bunch of followup cleanup.
3543
3544         For now we commit the generated data. In theory, in the future, we could
3545         have the test results server generate the data on the fly.
3546
3547         For the sake of easily understanding what changes when we run the generate script,
3548         also checkin a pretty printed version of the output. The pretty printed version
3549         is too large to serve as part of the flakiness dashboard though.
3550
3551         This also has the benefit of making the dashboard load much faster since
3552         we no longer ever need to block on requests to buildbot.
3553
3554         * TestResultServer/generate_builders_json.py: Added.
3555         (master_json_url):
3556         (builder_json_url):
3557         (cached_build_json_url):
3558         (fetch_json):
3559         (insert_builder_and_test_data):
3560         (main):
3561         * TestResultServer/generate_builders_json_unittest.py: Added.
3562         (GenerateBuildersJsonTest):
3563         (GenerateBuildersJsonTest.test_master_json_url):
3564         (GenerateBuildersJsonTest.test_builder_json_url):
3565         (GenerateBuildersJsonTest.test_cached_build_json_url):
3566         (GenerateBuildersJsonTest.test_generate_json_data):
3567         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
3568         * TestResultServer/static-dashboards/builders-pretty.jsonp: Added.
3569         * TestResultServer/static-dashboards/builders.js:
3570         (LOAD_BUILDBOT_DATA):
3571         (BuilderGroup):
3572         (BuilderGroup.prototype.append):
3573         (BuilderGroup.prototype.master):
3574         (requestBuilderList):
3575         * TestResultServer/static-dashboards/builders.jsonp: Added.
3576         * TestResultServer/static-dashboards/builders_unittests.js: Added.
3577         * TestResultServer/static-dashboards/dashboard_base.js:
3578         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3579         (showPopupForBuild):
3580         (htmlForTestResults):
3581         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
3582         (loadExpectationsLayoutTests):
3583         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3584         (resetGlobals):
3585         (test):
3586         * TestResultServer/static-dashboards/loader.js:
3587         * TestResultServer/static-dashboards/loader_unittests.js:
3588         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3589         * TestResultServer/static-dashboards/run-unittests.html:
3590         * TestResultServer/static-dashboards/timeline_explorer.html:
3591
3592 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3593
3594         [WTR][Qt] Enable fixedLayout when needed by the test
3595         https://bugs.webkit.org/show_bug.cgi?id=102811
3596
3597         Reviewed by Kenneth Rohde Christiansen.
3598
3599         Create a flickable view for CSS Device Adaptation tests. This is
3600         crucial for testing them since they will change the size of the
3601         viewport.
3602
3603         * WebKitTestRunner/PlatformWebView.h:
3604         (PlatformWebView):
3605         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3606         (WTR::PlatformWebView::PlatformWebView):
3607         (WTR::PlatformWebView::viewSupportsOptions):
3608         (WTR):
3609         * WebKitTestRunner/qt/main.cpp:
3610         (main):
3611
3612 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3613
3614         [WTR] WebKitTestRunner should be able to run tests using fixed layout
3615         https://bugs.webkit.org/show_bug.cgi?id=102517
3616
3617         Reviewed by Kenneth Rohde Christiansen.
3618
3619         WTR will now request the creation of a view that has a page using
3620         fixed layout for CSS Device Adaptation tests, but this feature might
3621         be used in the future by any other test that requires a mobile-like type
3622         of viewport (i.e. Viewport META tests should be ported).
3623
3624         The viewport type of the other tests remains unchanged and is restored
3625         when the runner leaves the device-adapt/ folder.
3626
3627         * WebKitTestRunner/PlatformWebView.h:
3628         (PlatformWebView):
3629         * WebKitTestRunner/TestInvocation.cpp:
3630         (WTR):
3631         (WTR::shouldUseFixedLayout):
3632         (WTR::updateLayoutType):
3633         (WTR::TestInvocation::invoke):
3634         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3635         (WTR::PlatformWebView::PlatformWebView):
3636         (WTR::PlatformWebView::viewSupportsOptions):
3637         (WTR):
3638
3639 2012-11-20  Csaba Osztrogonác  <ossy@webkit.org>
3640
3641         [Qt] REGRESSION(r128174): Fast build path doesn't work now
3642         https://bugs.webkit.org/show_bug.cgi?id=100360
3643
3644         Reviewed by Tor Arne Vestbø.
3645
3646         Use a separated .builtRevisions.cache file instead of .qmake.cache to cache built SVN revisions.
3647
3648         * Scripts/webkitdirs.pm:
3649         (buildQMakeProjects):
3650
3651 2012-11-20  Mateusz Leszko  <m.leszko@samsung.com>
3652
3653         [EFL][GTK]Sharing accessibility support in WebKitTestRunner.
3654         https://bugs.webkit.org/show_bug.cgi?id=99011
3655
3656         Reviewed by Martin Robinson.
3657
3658         Accessibility files from gtk folder are moved to atk folder due to common implementation. Event Type naming changed to default, from Gtk to ATK.
3659
3660         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp.
3661         (WTR::AccessibilityController::logAccessibilityEvents):
3662         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp.
3663
3664 2012-11-20  Zan Dobersek  <zandobersek@gmail.com>
3665
3666         webkitpy unit tests should run serially when checking code coverage
3667         https://bugs.webkit.org/show_bug.cgi?id=102693
3668
3669         Reviewed by Dirk Pranke.
3670
3671         When checking code coverage, the unit tests should not be run in parallel
3672         as this causes the tracing functions (set via sys.settrace in the coverage
3673         module) being overriden, resulting in incorrect coverage reports.
3674
3675         * Scripts/webkitpy/test/main.py:
3676         (Tester._run_tests):
3677
3678 2012-11-19  Viatcheslav Ostapenko  <v.ostapenko@samsung.com>
3679
3680         [EFL] Add fallback for WebkitTestRunner if opengl is not available.
3681         https://bugs.webkit.org/show_bug.cgi?id=102704
3682
3683         Reviewed by Laszlo Gombos.
3684
3685         Add fallback to non-opengl evas engine in WebkitTestRunner if opengl is not available.
3686
3687         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3688         (WTR::initEcoreEvas):
3689
3690 2012-11-19  Dimitri Glazkov  <dglazkov@chromium.org>
3691
3692         [garden-o-matic] Switch frontend to use the gardeningserver.
3693         https://bugs.webkit.org/show_bug.cgi?id=102712
3694
3695         Reviewed by Dirk Pranke.
3696
3697         Instead of serving garden-o-matic frontend as file, we now serve it from the gardening server. This enables
3698         using garden-o-matic in a Chrome OS device, with a separate machine as a headless server.
3699
3700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Changed CSP policy to use 'self'.
3701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Removed now-unnecessary references to kLocalServerURL.
3702         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Tweaked the test expectation.
3703         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Removed kLocalServerURL.
3704         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Spuriously updated the name of the webkit-patch command.
3705         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Removed kLocalServerURL.
3706         * Scripts/webkitpy/tool/servers/gardeningserver.py: Changed to use the new launch URL.
3707
3708 2012-11-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3709
3710         Unreviewed, rolling out r135172.
3711         http://trac.webkit.org/changeset/135172
3712         https://bugs.webkit.org/show_bug.cgi?id=102710
3713
3714         Broke some WebKit2 api tests :( (Requested by japhet on
3715         #webkit).
3716
3717         * DumpRenderTree/chromium/WebViewHost.cpp:
3718         (WebViewHost::updateForCommittedLoad):
3719
3720 2012-11-19  Dimitri Glazkov  <dglazkov@chromium.org>
3721
3722         [garden-o-matic] Enable serving garden-o-matic with gardeningserver.
3723         https://bugs.webkit.org/show_bug.cgi?id=102703
3724
3725         Reviewed by Ojan Vafai.
3726
3727         To enable gardening from a Chrome OS device, we need the ability to serve garden-o-matic
3728         from the same origin as the gardening server. This change gently massages the current
3729         logic to adapt an extension-sniffing-based approach of identifying static files,
3730         rather than requiring an explicit list.
3731
3732         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
3733         (ReflectionHandler): Replaced STATIC_FILE_NAMES with STATIC_FILE_EXTENSIONS.
3734         (ReflectionHandler._handle_request): Changed the logic to smell for extensions, rather than specific files.
3735         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py: Added.
3736
3737 2012-11-19  Ojan Vafai  <ojan@chromium.org>
3738
3739         Add DOM and HTML watchlists and add myself to a bunch of lists
3740         https://bugs.webkit.org/show_bug.cgi?id=102707
3741
3742         Reviewed by Eric Seidel.
3743
3744         * Scripts/webkitpy/common/config/watchlist:
3745
3746 2012-11-19  Jochen Eisinger  <jochen@chromium.org>
3747
3748         [chromium] move methods that only use the WebKit API from DRTTestRunner to TestRunner
3749         https://bugs.webkit.org/show_bug.cgi?id=102676
3750
3751         Reviewed by Tony Chang.
3752
3753         In addition, I've replaced parsePageNumber with the more commonly used
3754         cppVariantToInt32, moved abortModal to the list of stubbed out methods,
3755         and removed setAutomaticLinkDetectionEnabled which wasn't used
3756         anywhere.
3757
3758         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3759         (DRTTestRunner::DRTTestRunner):
3760         (DRTTestRunner::reset):
3761         (DRTTestRunner::overridePreference):
3762         * DumpRenderTree/chromium/DRTTestRunner.h:
3763         (DRTTestRunner):
3764         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3765         (WebTestRunner::TestRunner::TestRunner):
3766         (WebTestRunner::TestRunner::reset):
3767         (WebTestRunner):
3768         (WebTestRunner::TestRunner::setTabKeyCyclesThroughElements):
3769         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
3770         (WebTestRunner::TestRunner::execCommand):
3771         (WebTestRunner::TestRunner::isCommandEnabled):
3772         (WebTestRunner::TestRunner::pauseAnimationAtTimeOnElementWithId):
3773         (WebTestRunner::TestRunner::pauseTransitionAtTimeOnElementWithId):
3774         (WebTestRunner::TestRunner::elementDoesAutoCompleteForElementWithId):
3775         (WebTestRunner::TestRunner::numberOfActiveAnimations):
3776         (WebTestRunner::TestRunner::callShouldCloseOnWebView):
3777         (WebTestRunner::TestRunner::setDomainRelaxationForbiddenForURLScheme):
3778         (WebTestRunner::TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3779         (WebTestRunner::TestRunner::evaluateScriptInIsolatedWorld):
3780         (WebTestRunner::TestRunner::setIsolatedWorldSecurityOrigin):
3781         (WebTestRunner::TestRunner::setIsolatedWorldContentSecurityPolicy):
3782         (WebTestRunner::TestRunner::addOriginAccessWhitelistEntry):
3783         (WebTestRunner::TestRunner::removeOriginAccessWhitelistEntry):
3784         (WebTestRunner::TestRunner::hasCustomPageSizeStyle):
3785         (WebTestRunner::TestRunner::forceRedSelectionColors):
3786         (WebTestRunner::TestRunner::addUserScript):
3787         (WebTestRunner::TestRunner::addUserStyleSheet):
3788         (WebTestRunner::TestRunner::startSpeechInput):
3789         (WebTestRunner::TestRunner::loseCompositorContext):
3790         (WebTestRunner::TestRunner::markerTextForListItem):
3791         (WebTestRunner::TestRunner::findString):
3792         (WebTestRunner::TestRunner::setMinimumTimerInterval):
3793         (WebTestRunner::TestRunner::setAutofilled):
3794         (WebTestRunner::TestRunner::setValueForUser):
3795         (WebTestRunner::TestRunner::enableFixedLayoutMode):
3796         (WebTestRunner::TestRunner::setFixedLayoutSize):
3797         (WebTestRunner::TestRunner::selectionAsMarkup):
3798         (WebTestRunner::TestRunner::setTextSubpixelPositioning):
3799         (WebTestRunner::TestRunner::resetPageVisibility):
3800         (WebTestRunner::TestRunner::setPageVisibility):
3801         (WebTestRunner::TestRunner::setTextDirection):
3802         (WebTestRunner::TestRunner::textSurroundingNode):
3803         (WebTestRunner::TestRunner::workerThreadCount):
3804         (WebTestRunner::TestRunner::cppVariantToBool):
3805         (WebTestRunner::TestRunner::cppVariantToInt32):
3806         (WebTestRunner::TestRunner::cppVariantToWebString):
3807         (WebTestRunner::TestRunner::cppVariantToWebStringArray):
3808         (WebTestRunner::TestRunner::printErrorMessage): formerly logErrorToConsole
3809         (WebTestRunner::TestRunner::fallbackMethod):
3810         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3811         (WebKit):
3812         (WebTestRunner::TestRunner::setWebView):
3813         (TestRunner):
3814         * DumpRenderTree/chromium/TestShell.cpp:
3815         (TestShell::createMainWindow):
3816         (TestShell::~TestShell):
3817
3818 2012-11-19  Yusuke Sato  <yusukes@chromium.org>
3819
3820         [Chromium] Flash cannot receive scroll events when threaded compositing is in use
3821         https://bugs.webkit.org/show_bug.cgi?id=101423
3822
3823         Reviewed by James Robinson.
3824
3825         Call setWantsWheelEvents(true) in initialize() so that gesture-events and transformed-events tests in
3826         LayoutTests/platform/chromium/plugins/ will not fail even if a buildbot introduces threaded compositing
3827         in the future.
3828
3829         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3830         (TestWebPlugin::initialize):
3831
3832 2012-11-19  Nate Chapin  <japhet@chromium.org>
3833
3834         Move empty loading to DocumentLoader, simplify FrameLoader::init()
3835         https://bugs.webkit.org/show_bug.cgi?id=101512
3836
3837         Reviewed by Adam Barth.
3838
3839         Chromium DRT has some code that doesn't play nicely with empty urls and incorrectly
3840         interprets them as a non-empty load. This ensures
3841         http/tests/navigation/new-window-redirect-history.html continues to pass
3842         in chromium.
3843
3844         * DumpRenderTree/chromium/WebViewHost.cpp:
3845         (WebViewHost::updateForCommittedLoad):
3846
3847 2012-11-19  Vincent Scheib  <scheib@chromium.org>
3848
3849         [Chromium] Remove WebKit::WebRuntimeFeatures::enablePointerLock.
3850         https://bugs.webkit.org/show_bug.cgi?id=96946
3851
3852         Reviewed by Adam Barth.
3853
3854         The runtime flag functionality has already been removed.
3855         Now that Chromium no longer has a compile dependency on this
3856         API, it can be removed as well.
3857
3858         * DumpRenderTree/chromium/TestShell.cpp:
3859         (TestShell::TestShell):
3860
3861 2012-11-19  Kihong Kwon  <kihong.kwon@samsung.com>
3862
3863         Add PROXIMITY_EVENTS feature
3864         https://bugs.webkit.org/show_bug.cgi?id=102658
3865
3866         Reviewed by Kentaro Hara.
3867
3868         Add PROXIMITY_EVENTS feature to FeatureList and qmake.
3869
3870         * Scripts/webkitperl/FeatureList.pm:
3871         * qmake/mkspecs/features/features.pri:
3872
3873 2012-11-19  Christophe Dumez  <christophe.dumez@intel.com>
3874
3875         [WK2][WTR] Memory leak in TestController::initialize()
3876         https://bugs.webkit.org/show_bug.cgi?id=102616
3877
3878         Reviewed by Kenneth Rohde Christiansen.
3879
3880         Remove call to WKStringCreateWithUTF8CString() to construct
3881         the icon database path which was leaking memory since the
3882         returned WKStringRef was not adopted. The code now uses
3883         WTF::String instead of std::string and converts it to a
3884         WKStringRef using toWK().
3885
3886         * WebKitTestRunner/StringFunctions.h:
3887         (WTR::toWK): Overload toWK() to take a WTF::String in
3888         argument.
3889         (WTR):
3890         * WebKitTestRunner/TestController.cpp:
3891         (WTR::TestController::initialize):
3892
3893 2012-11-19  Kentaro Hara  <haraken@chromium.org>
3894
3895         Remove IDLStructure.pm
3896         https://bugs.webkit.org/show_bug.cgi?id=102642
3897
3898         Reviewed by Adam Barth.
3899
3900         Previously IDLStructure.pm was full of regular expressions to
3901         parse IDL files. Now a new IDL parser is implemented, IDLStructure.pm
3902         just contains several data structures for the IDL parser. We can
3903         move them to IDLParser.pm and thus remove IDLStructure.pm.
3904
3905         No tests. No change in generated code.
3906
3907         * WebKitTestRunner/DerivedSources.make:
3908         * WebKitTestRunner/GNUmakefile.am:
3909         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
3910
3911 2012-11-18  KyungTae Kim  <ktf.kim@samsung.com>
3912
3913         [EFL] Not to include "ewk_view_private.h" in Tools
3914         https://bugs.webkit.org/show_bug.cgi?id=102644
3915
3916         Reviewed by Gyuyoung Kim.
3917
3918         Include ewk_view.h instead of ewk_view_private.h in Tools
3919
3920         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3921
3922 2012-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3923
3924         Unreviewed, rolling out r135104.
3925         http://trac.webkit.org/changeset/135104
3926         https://bugs.webkit.org/show_bug.cgi?id=102638
3927
3928         Should not use commit queue to add people to committer list.
3929         (Requested by ap_ on #webkit).
3930
3931         * Scripts/webkitpy/common/config/committers.py:
3932
3933 2012-11-18  Vivek Galatage  <vivek.vg@samsung.com>
3934
3935         Add myself to committers.py
3936         https://bugs.webkit.org/show_bug.cgi?id=102636
3937
3938         Reviewed by Laszlo Gombos.
3939
3940         Add myself to committers.py
3941
3942         * Scripts/webkitpy/common/config/committers.py:
3943
3944 2012-11-18  Genevieve Mak  <gmak@rim.com>
3945
3946         [BlackBerry] Enable Touch Sliders
3947         https://bugs.webkit.org/show_bug.cgi?id=102516
3948
3949         Reviewed by Rob Buis.
3950
3951         Enabled for BlackBerry only
3952         PR #242781
3953         PR #176014
3954
3955         * Scripts/webkitperl/FeatureList.pm:
3956
3957 2012-11-17  Dimitri Glazkov  <dglazkov@chromium.org>
3958
3959         Remove unused code I wrote a long time ago from gardeningserver.py
3960         https://bugs.webkit.org/show_bug.cgi?id=102605
3961
3962         Reviewed by Adam Barth.
3963
3964         * Scripts/webkitpy/tool/servers/gardeningserver.py: Removed.
3965         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Removed.
3966
3967 2012-11-16  Tony Chang  <tony@chromium.org>
3968
3969         Remove ENABLE_CSS_HIERARCHIES since it's no longer in use
3970         https://bugs.webkit.org/show_bug.cgi?id=102554
3971
3972         Reviewed by Andreas Kling.
3973
3974         As mentioned in https://bugs.webkit.org/show_bug.cgi?id=79939#c41 ,
3975         we're going to revist this feature once additional vendor support is
3976         achieved.
3977
3978         * Scripts/webkitperl/FeatureList.pm:
3979
3980 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
3981
3982         [chromium] move stubs from DRTTestRunner to TestRunner
3983         https://bugs.webkit.org/show_bug.cgi?id=102489
3984
3985         Reviewed by Adam Barth.
3986
3987         This is part of moving all methods from DRTTestRunner to TestRunner.
3988         Instead of keeping one stub per method, I'm using a shared stub to
3989         clean up the code.
3990
3991         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3992         (DRTTestRunner::DRTTestRunner):
3993         * DumpRenderTree/chromium/DRTTestRunner.h:
3994         (DRTTestRunner):
3995         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3996         (WebTestRunner::TestRunner::TestRunner):
3997         (WebTestRunner):
3998         (WebTestRunner::TestRunner::fallbackMethod):
3999         (WebTestRunner::TestRunner::notImplemented):
4000         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4001         (WebTestRunner):
4002         (TestRunner):
4003         (WebTestRunner::TestRunner::setDelegate):
4004         * DumpRenderTree/chromium/TestShell.cpp:
4005         (TestShell::createMainWindow):
4006         (TestShell::~TestShell):
4007
4008 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
4009
4010         [chromium] fake drag drop operations in the WebTestProxyBase instead of the WebViewHost
4011         https://bugs.webkit.org/show_bug.cgi?id=102495
4012
4013         Reviewed by Adam Barth.
4014
4015         When a drag operation is initiated in a layout test, we need to
4016         simulate a corresponding drop event, otherwise the WebViewImpl will sit
4017         there waiting for it. Instead of having the embedder taking care of
4018         this, move this into the TestRunner library.
4019
4020         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4021         (WebKit):
4022         (WebTestProxyBase):
4023         (WebTestRunner::WebTestProxy::startDragging):
4024         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4025         (WebTestRunner::WebTestProxyBase::startDragging):
4026         (WebTestRunner):
4027         * DumpRenderTree/chromium/WebViewHost.cpp:
4028         * DumpRenderTree/chromium/WebViewHost.h:
4029         (WebViewHost):
4030
4031 2012-11-16  Tien-Ren Chen  <trchen@chromium.org>
4032
4033         Rename applyDefaultDeviceScaleFactorInCompositor to setApplyDeviceScaleFactorInCompositor
4034         https://bugs.webkit.org/show_bug.cgi?id=102462
4035
4036         Reviewed by James Robinson.
4037
4038         As we no longer have this "default" device scale factor.
4039
4040         * DumpRenderTree/chromium/WebPreferences.cpp:
4041         (WebPreferences::applyTo):
4042
4043 2012-11-15  Takashi Sakamoto  <tasak@google.com>
4044
4045         [Win] key event's location does not work on Windows platform.
4046         https://bugs.webkit.org/show_bug.cgi?id=89742
4047
4048         Reviewed by Brent Fulgham.
4049
4050         Modified keyDownCallback to use lparam to specify left-hand keys or
4051         right-hand keys.
4052
4053         * DumpRenderTree/win/EventSender.cpp:
4054         (makeKeyDataForScanCode):
4055         Given a virtual keycode, generate scancode and extended key bit of
4056         lparam.
4057         (keyDownCallback):
4058         Use lparam for left-hand and right-hand keys, because Windows doesn't
4059         directly provide a virtual keycode which distinguishes between
4060         left-hand and right-hand. For example, when control key is pressed,
4061         wparam has VK_CONTROL, neither VK_RCONTROL nor VK_LCONTROL.
4062
4063 2012-11-16  Tommy Widenflycht  <tommyw@google.com>
4064
4065         [chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
4066         https://bugs.webkit.org/show_bug.cgi?id=102386
4067
4068         Reviewed by Adam Barth.
4069
4070         Adding mock data channel functionality.
4071
4072         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4073         (MockWebRTCPeerConnectionHandler::openDataChannel):
4074
4075 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
4076
4077         [chromium] delete unused testRunner methods
4078         https://bugs.webkit.org/show_bug.cgi?id=102479
4079
4080         Reviewed by Adam Barth.
4081
4082         These methods aren't used by any layout test. Remove them to avoid bit rot
4083
4084         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4085         (DRTTestRunner::DRTTestRunner):
4086         (DRTTestRunner::reset):
4087         * DumpRenderTree/chromium/DRTTestRunner.h:
4088         (DRTTestRunner):
4089         * DumpRenderTree/chromium/WebViewHost.cpp:
4090         (WebViewHost::shouldBeginEditing):
4091         (WebViewHost::shouldEndEditing):
4092         (WebViewHost::shouldInsertNode):
4093         (WebViewHost::shouldInsertText):
4094         (WebViewHost::shouldChangeSelectedRange):
4095         (WebViewHost::shouldDeleteRange):
4096         (WebViewHost::shouldApplyStyle):
4097         (WebViewHost::startDragging):
4098         (WebViewHost::enterFullScreenNow):
4099         (WebViewHost::exitFullScreenNow):
4100
4101 2012-11-15  Alexey Proskuryakov  <ap@apple.com>
4102
4103         Private Browsing is a per-page setting that sets a global value
4104         https://bugs.webkit.org/show_bug.cgi?id=67870
4105
4106         Reviewed by Sam Weinig.
4107
4108         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
4109         Call _switchNetworkLoaderToNewTestingSession before making other settings, so that
4110         they would actually apply to the testing session.
4111
4112         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4113         (WTR::InjectedBundle::initialize):
4114         (WTR::InjectedBundle::beginTesting):
4115         Only call WKBundleSwitchNetworkLoaderToNewTestingSession once per process, matching
4116         WebKit1. I'm not fully sure what is going wrong, but apparently creating mutiple
4117         sessions with the same identifier doesn't quite work.
4118
4119 2012-11-16  Yael Aharon  <yael.aharon@intel.com>
4120
4121         Unreviewed. Help bugzilla find me.
4122
4123         * Scripts/webkitpy/common/config/committers.py:
4124
4125 2012-11-16  Peter Beverloo  <peter@chromium.org>
4126
4127         Running TestWebKitAPI and webkit_unit_tests for Chromium Android should defer to the Chromium-sided test runner
4128         https://bugs.webkit.org/show_bug.cgi?id=102245
4129
4130         Reviewed by Tony Chang.
4131
4132         When running TestWebKitAPI and webkit_unit_test for Chromium Android, defer
4133         the actual running part to the test runner which lives on the Chromium side.
4134         Re-implementing or even generalizing the device-interaction part in WebKit
4135         is error prone and not worth the effort.
4136
4137         * Scripts/run-api-tests:
4138         * Scripts/run-chromium-webkit-unit-tests:
4139
4140 2012-11-15  Yury Semikhatsky  <yurys@chromium.org>
4141
4142         Memory instrumentation: add code for reporting stack traces of unknown instrumented objects
4143         https://bugs.webkit.org/show_bug.cgi?id=102384
4144
4145         Reviewed by Pavel Feldman.
4146
4147         Updated return type in accord with the changes in MemoryInstrumentationClient.
4148
4149         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
4150
4151 2012-11-15  Gustavo Noronha Silva  <gns@gnome.org>
4152
4153         [GTK] Split WebCore/platform into a separate library
4154         https://bugs.webkit.org/show_bug.cgi?id=94435
4155
4156         Reviewed by Martin Robinson.
4157
4158         More people have been reporting problems when linking WebCore because
4159         the command line limit is being exceeded. Splitting WebCore a bit more
4160         is in order.
4161
4162         * GNUmakefile.am: link libWebCorePlatform into DRT
4163
4164 2012-11-15  Dana Jansens  <danakj@chromium.org>
4165
4166         [chromium] Stop using the WebCompositorSupport methods for changing settings
4167         https://bugs.webkit.org/show_bug.cgi?id=101968
4168
4169         Reviewed by James Robinson.
4170
4171         * DumpRenderTree/chromium/TestShell.cpp:
4172         * DumpRenderTree/chromium/TestShell.h:
4173         (TestShell::setPerTilePaintingEnabled):
4174         (TestShell::setAcceleratedAnimationEnabled):
4175
4176 2012-11-15  Tony Chang  <tony@chromium.org>
4177
4178         Generate Settings from a .in file
4179         https://bugs.webkit.org/show_bug.cgi?id=100393
4180
4181         Reviewed by Adam Barth.
4182
4183         Add the generated WebCore files to the include dir.
4184
4185         * TestWebKitAPI/CMakeLists.txt:
4186         * WebKitTestRunner/CMakeLists.txt:
4187
4188 2012-11-15  Roger Fong  <roger_fong@apple.com>
4189
4190         Make old-run-webkit-tests handle setting the results directory properly.
4191         https://bugs.webkit.org/show_bug.cgi?id=102273
4192         <rdar://problem/11571607>
4193
4194         Reviewed by Timothy Horton.
4195
4196         A call to chdirWebkit in old-run-webkit-tests set the current working directory to the OpenSource folder.
4197         Thus setting --results-directory to OpenSource/layout-test-results would create OpenSource/layout-test-results inside the main OpenSource folder.
4198         This caused many other problems including failure to upload test results and failed future test runs.
4199         The solution is to save the current working directory before calling chdirWebKit and then reconstructing the full path to the results directory 
4200         using the saved directory when setting $testResultsDirectory.
4201
4202         * Scripts/old-run-webkit-tests:
4203
4204 2012-11-15  Sheriff Bot  <webkit.review.bot@gmail.com>
4205
4206         Unreviewed, rolling out r134800 and r134805.
4207         http://trac.webkit.org/changeset/134800
4208         http://trac.webkit.org/changeset/134805
4209         https://bugs.webkit.org/show_bug.cgi?id=102417
4210
4211         This patch broke chromium port (Requested by jianli on
4212         #webkit).
4213
4214         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4215         (MockWebRTCPeerConnectionHandler::openDataChannel):
4216
4217 2012-11-15  Tommy Widenflycht  <tommyw@google.com>
4218
4219         [chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
4220         https://bugs.webkit.org/show_bug.cgi?id=102386
4221
4222         Reviewed by Adam Barth.
4223
4224         Adding mock data channel functionality.
4225
4226         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4227         (MockWebRTCPeerConnectionHandler::openDataChannel):
4228
4229 2012-11-15  Sheriff Bot  <webkit.review.bot@gmail.com>
4230
4231         Unreviewed, rolling out r134649 and r134665.
4232         http://trac.webkit.org/changeset/134649
4233         http://trac.webkit.org/changeset/134665
4234         https://bugs.webkit.org/show_bug.cgi?id=102413
4235
4236         Broke a ton of downstream chromium tests (Requested by japhet
4237         on #webkit).
4238
4239         * DumpRenderTree/chromium/WebViewHost.cpp:
4240         (WebViewHost::updateForCommittedLoad):
4241
4242 2012-11-15  Andreas Kling  <akling@apple.com>
4243
4244         Update my e-mail address.
4245
4246         Rubber-stamped by Anders Koivisto.
4247
4248         * Scripts/webkitpy/common/config/committers.py:
4249
4250 2012-11-15  Dominik Röttsches  <dominik.rottsches@intel.com>
4251
4252         [EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL
4253         https://bugs.webkit.org/show_bug.cgi?id=101323
4254
4255         Reviewed by Martin Robinson.
4256
4257         Bumping Harfbuzz to newer version so that we can remove the
4258         ifdef round the fix for bug 101009 for EFL, too.
4259         We're using the zip snapshot since jhbuild can fallback to the previously
4260         downloaded blob in case of network failures which leads to better
4261         buildbot robustness. This zip snapshot currently needs to be locally
4262         patched to fix ICU detection on systems that don't have icu pkg-config files.
4263         The patch is suggested for merging into HarfBuzz. We can remove it locally
4264         once it's accepted into HarfBuzz upstream.
4265
4266         * efl/patches/harfbuzz-icu-detection-fix.patch: Applied after retrieving source to fix harfbuzz detection on systems that don't have pkg-config files for it.
4267         * efl/jhbuild.modules: Bumping harfbuzz version.
4268
4269 2012-11-15  Alexey Proskuryakov  <ap@apple.com>
4270
4271         [Mac] Implement WTR --no-timeout-at-all option
4272         https://bugs.webkit.org/show_bug.cgi?id=102251
4273
4274         Reviewed by Eric Carlson.
4275
4276         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformRunUntil):
4277         Just do it, and convert to Objective C on the way for simplicity.
4278
4279 2012-11-14  Ryuan Choi  <ryuan.choi@gmail.com>
4280
4281         [EFL] Port tiled backing store
4282         https://bugs.webkit.org/show_bug.cgi?id=71352
4283
4284         Reviewed by Gyuyoung Kim.
4285
4286         * EWebLauncher/main.c: Added option to test the WebCore's tiled backing store.
4287         (_User_Arguments):
4288         (windowCreate):
4289         (parseUserArguments):
4290
4291 2012-11-14  Andy Estes  <aestes@apple.com>
4292
4293         Fix the build.
4294
4295         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
4296
4297 2012-11-14  Dirk Pranke  <dpranke@chromium.org>
4298
4299         webkitpy: consolidate webkit-base-finding code
4300         https://bugs.webkit.org/show_bug.cgi?id=102007
4301
4302         Reviewed by Eric Seidel.
4303
4304         This patch creates a new "WebKitFinder" class that other
4305         modules can use to find the top of the WebKit tree and
4306         commonly used subdirectories. This logic was in the
4307         webkitpy.layout_test.port classes but wasn't specific to those
4308         classes and now can be used by other modules without needing a port
4309         (e.g., by the check-webkit-style python linter).
4310
4311         This code is somewhat redundant with the code for find_checkout_root()
4312         in the scm modules, but it does not rely on the presence of a version
4313         control system to work. This is a requirement for some uses of the
4314         tree (e.g., Chromium tester checkouts).
4315
4316         This patch removes most of the logic from the layout_tests.port.config
4317         module and makes that as private as possible. Now we just need to move
4318         the default_configuration and flag_from_configuration logic into
4319         DeprecatedPort (or someplace else appropriate) and we can finish
4320         getting rid of the Config class (but that is a separate patch).
4321
4322         * Scripts/webkitpy/common/webkit_finder.py: Added.
4323         (WebKitFinder):
4324         (WebKitFinder.__init__):
4325         (WebKitFinder.webkit_base):
4326         (WebKitFinder.path_from_webkit_base):
4327         (WebKitFinder.path_to_script):
4328         (WebKitFinder.layout_tests_dir):
4329         (WebKitFinder.perf_tests_dir):
4330         * Scripts/webkitpy/layout_tests/port/base.py:
4331         (Port.__init__):
4332         (Port):
4333         (Port.webkit_base):
4334         (Port.path_from_webkit_base):
4335         (Port.path_to_script):
4336         (Port.layout_tests_dir):
4337         (Port.perf_tests_dir):
4338         (Port.set_option_default):
4339         (Port._run_script):
4340         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4341         (PortTest.test_diff_text):
4342         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4343         (ChromiumLinuxPort._determine_driver_path_statically):
4344         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4345         * Scripts/webkitpy/layout_tests/port/config.py:
4346         (Config.__init__):
4347         (Config.build_directory):
4348         (Config.default_configuration):
4349         (Config._read_configuration):
4350         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
4351         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
4352         (ConfigTest.test_default_configuration__standalone):
4353         (ConfigTest.test_default_configuration__scripterror):
4354         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
4355         (DriverTest.make_port):
4356         (DriverTest.test_no_timeout):
4357         * Scripts/webkitpy/layout_tests/port/gtk.py:
4358         (GtkPort.setup_environ_for_server):
4359         * Scripts/webkitpy/layout_tests/port/mac.py:
4360         (MacPort.show_results_html_file):
4361         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4362         (TestWebKitPort.__init__):
4363         (PortTestCase.make_port):
4364         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4365         (WinPortTest.test_expectations_files):
4366         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
4367         (XvfbDriverTest.make_driver):
4368         (XvfbDriverTest.test_stop):
4369         * Scripts/webkitpy/style/checkers/python.py:
4370         (Pylinter.__init__):
4371
4372 2012-11-14  Dana Jansens  <danakj@chromium.org>
4373
4374         [chromium] WebPreferences reset() should set perTilePainting and acceleratedAnimation settings to false.
4375         https://bugs.webkit.org/show_bug.cgi?id=102296
4376
4377         Revie