[wx] Build fixes for wxWebKit.
[WebKit.git] / Tools / ChangeLog
1 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
2
3         [wx] Build fixes for wxWebKit.
4
5         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
6         (LayoutTestController::setSerializeHTTPLoads):
7         * wx/browser/wscript:
8         * wx/build/build_utils.py:
9         * wx/build/settings.py:
10
11 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
12
13         Reviewed by Mihai Parparita.
14
15         new-run-webkit-tests: stop skipping so many tests
16
17         r77163 introduced a regression where we weren't resetting test
18         expectations properly and were skipping too many tests as a
19         result. This patch fixes that and adds a test for it.
20
21         https://bugs.webkit.org/show_bug.cgi?id=53551
22
23         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
24         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
25
26 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
27
28         Reviewed by Tony Chang.
29
30         new-run-webkit-tests: add first stub of test_runner2. This
31         will add support for the 'inline', 'threads', and 'processes'
32         flags to --worker-model, but for now the implementatios just
33         fall back on the old ones.
34
35         https://bugs.webkit.org/show_bug.cgi?id=53157
36
37         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
38         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
39
40 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
41
42         Reviewed by James Robinson.
43
44         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
45         https://bugs.webkit.org/show_bug.cgi?id=53522
46
47         * Scripts/run-chromium-webkit-unit-tests:
48
49 2011-02-01  Adam Barth  <abarth@webkit.org>
50
51         Reviewed by Mihai Parparita.
52
53         Using Control-C to cancel webkit-patch or other python tools causes
54         unpleasant traceback console spew
55         https://bugs.webkit.org/show_bug.cgi?id=53462
56
57         Catch the exception and don't print the stack trace.
58
59         * Scripts/webkit-patch:
60
61 2011-02-01  Scott Cameron  <sccameron@rim.com>
62
63         Reviewed by Daniel Bates.
64
65         Use Windows format for MinGW HTTPD path.
66         https://bugs.webkit.org/show_bug.cgi?id=53503
67
68         * Scripts/webkitperl/httpd.pm:
69           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
70             so that we don't have to escape the space characters in the path. Also,
71             changed path to Windows-style path and removed FIXME comment.
72
73 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
74
75         Reviewed by Andreas Kling.
76
77         [Qt][WK2] Add a way to use shared process model in MiniBrowser
78         https://bugs.webkit.org/show_bug.cgi?id=53090
79
80         * MiniBrowser/qt/BrowserView.cpp:
81         (BrowserView::BrowserView): Removed the m_context member.
82         From now the context is guaranteed to be non-null and we
83         don't need to store that in the object.
84         * MiniBrowser/qt/BrowserView.h:
85         * MiniBrowser/qt/BrowserWindow.cpp:
86         Added static bool to determine that new windows need to be
87         created with their own context or not. Use the same context
88         and web process by default to be inilne with the other ports.
89         (BrowserWindow::BrowserWindow):
90         (BrowserWindow::newWindow):
91         * MiniBrowser/qt/BrowserWindow.h:
92         * MiniBrowser/qt/main.cpp:
93         (main): Added command line switch to be able to use the
94         non-shared process model. Simplify the handling of the command line
95         switches a little bit.
96
97 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
98
99         Reviewed by Andreas Kling.
100
101         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
102         https://bugs.webkit.org/show_bug.cgi?id=53491
103
104         * MiniBrowser/qt/BrowserWindow.cpp:
105         (BrowserWindow::BrowserWindow):
106         (BrowserWindow::toggleFullScreenMode):
107         * MiniBrowser/qt/BrowserWindow.h:
108
109 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
110
111         Reviewed by Andreas Kling.
112
113         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
114         https://bugs.webkit.org/show_bug.cgi?id=53489
115
116         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
117         to Settings menu.
118
119         * MiniBrowser/qt/BrowserWindow.cpp:
120         (BrowserWindow::BrowserWindow):
121         (BrowserWindow::toggleFrameFlattening):
122         (BrowserWindow::toggleDisableJavaScript):
123         (BrowserWindow::toggleAutoLoadImages):
124         * MiniBrowser/qt/BrowserWindow.h:
125
126 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
127
128         Reviewed by Tony Chang.
129
130         [Chromium] Switch chromium-mac to use ChromiumDriver
131         https://bugs.webkit.org/show_bug.cgi?id=53461
132         
133         For the sake of consistency with the other Chromium platforms (and so
134         that chromium-mac picks up special flags like --enable-hardware-gpu),
135         switch chromium-mac from the WebKitDriver to ChromiumDriver.
136
137         * Scripts/webkitpy/layout_tests/port/chromium.py:
138
139 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
140
141         Reviewed by Mihai Parparita.
142
143         The current modifier parsing code in test_expectations is
144         fragile and hard-coded, so it's not easy to understand the logic
145         or easily add new types of modifiers (like GPU vs. CPU testing
146         for graphics tests, or 32-bit vs. 64-bit differences).
147
148         This is the first of two patches that will add in more generic
149         support and then eliminate the GPU-specific test expectations
150         files for Chromium.
151
152         This patch adds two standalone objects for handling modifiers. The
153         rules for interpreting modifiers, precedence, and conflicts are
154         given in the docstring to the ModifierMatcher class, which
155         returns ModifierMatchResult objects.
156         
157         This patch also adds routines to the Port interface and a
158         default set of values in the base object, in order to obtain the
159         values needed on a given test run. These values are then passed
160         to the expectation parser. This also allows us to clean up the
161         logic used to lint all of the different configurations in a
162         single test_expectations.txt file.
163
164         The next patch will merge in the separate GPU expectations file.
165
166         https://bugs.webkit.org/show_bug.cgi?id=51222
167
168         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
169         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
170         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
171         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
172         * Scripts/webkitpy/layout_tests/port/base.py:
173         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
174         * Scripts/webkitpy/layout_tests/port/chromium.py:
175         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
176         * Scripts/webkitpy/layout_tests/port/test.py:
177         * Scripts/webkitpy/layout_tests/port/webkit.py:
178         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
179         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
180         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
181         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
182         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
183
184 2011-01-31  Scott Cameron  <sccameron@rim.com>
185
186         Reviewed by Daniel Bates.
187
188         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
189         https://bugs.webkit.org/show_bug.cgi?id=50036
190
191         This will add an Apache2.2 configuration file and modifies scripts to allow
192         running an httpd server in an MSYS environment.
193
194         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
195         in order to allow for simple installation/execution.  Simply install the latest
196         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
197         be able to execute run-webkit-httpd.
198         
199
200         * Scripts/run-webkit-httpd:
201         * Scripts/webkitperl/httpd.pm:
202
203 2011-01-31  Tony Chang  <tony@chromium.org>
204
205         Reviewed by Eric Seidel.
206
207         mac DRT should report RTL scroll offset relative to top right corner
208         https://bugs.webkit.org/show_bug.cgi?id=53324
209
210         * DumpRenderTree/mac/DumpRenderTree.mm:
211         (dumpFrameScrollPosition):
212
213 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
214
215         Reviewed by Andreas Kling.
216
217         [Qt] Add Take Screen Shot action to MiniBrowser
218         https://bugs.webkit.org/show_bug.cgi?id=53422
219
220         Add Take Screen Shot action to MiniBrowser's view menu.
221
222         * MiniBrowser/qt/BrowserWindow.cpp:
223         (BrowserWindow::BrowserWindow):
224         (BrowserWindow::screenshot):
225         * MiniBrowser/qt/BrowserWindow.h:
226
227 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
228
229         Reviewed by Xan Lopez.
230
231         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
232         https://bugs.webkit.org/show_bug.cgi?id=53379
233
234         Remove left over #ifdef's. I thought all of the conditional code
235         had been freed from the condition, but I forgot to check DRT.
236
237         * DumpRenderTree/gtk/DumpRenderTree.cpp:
238         (resetDefaultsToConsistentValues):
239         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
240         (LayoutTestController::setAlwaysAcceptCookies):
241
242 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
243
244         Unreviewed, build fix.
245
246         Fix regression introduced in r77093 - path.rsplit() doesn't
247         take keyword arguments.
248
249         https://bugs.webkit.org/show_bug.cgi?id=53326
250
251         * Scripts/webkitpy/common/system/filesystem_mock.py:
252
253 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
254
255         Reviewed by Mihai Parparita.
256
257         Add more unit tests for rebaseline-chromium-webkit-tests. This
258         change involves restructuring a bunch of r-c-w-t code to make it
259         more testable as well. We also add wrapper classes for handling
260         testing zip files and fetching URLs.
261
262         https://bugs.webkit.org/show_bug.cgi?id=53040
263
264         * Scripts/webkitpy/common/system/urlfetcher.py:
265         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
266         * Scripts/webkitpy/common/system/zipfileset_mock.py:
267         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
268         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
269         * Scripts/webkitpy/tool/mocktool.py:
270
271 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
272
273         Reviewed by Eric Seidel.
274
275         Clean up of the filesystem-related modules used in webkitpy.
276         I've added relpath() to the filesystem interface, modified
277         ospath.relpath() so that it could work with the filesystem
278         interface, and modified the fileset* routines to use the
279         filesystem interface consistently.
280
281         This patch also adds a close() routine to the fileset routines
282         to indicate that the caller is done with the fileset. This
283         allows zipfileset to clean up after itself when it creates
284         tempfiles to store downloads.
285
286         https://bugs.webkit.org/show_bug.cgi?id=53326
287
288         * Scripts/webkitpy/common/system/directoryfileset.py:
289         * Scripts/webkitpy/common/system/fileset.py:
290         * Scripts/webkitpy/common/system/filesystem.py:
291         * Scripts/webkitpy/common/system/filesystem_mock.py:
292         * Scripts/webkitpy/common/system/filesystem_unittest.py:
293         * Scripts/webkitpy/common/system/ospath.py:
294         * Scripts/webkitpy/common/system/zipfileset.py:
295         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
296
297 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
298
299         Reviewed by Csaba Osztrogonác.
300
301         [Qt][WK2]REGRESSION (r76991): Fix build errors
302         https://bugs.webkit.org/show_bug.cgi?id=53400
303
304         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
305         and remove WebKit2Prefix.h from the build.
306         * MiniBrowser/qt/MiniBrowser.pro:
307
308 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
309
310         Unreviewed.
311
312         [Qt][WK2] Buildfix.
313
314         * MiniBrowser/qt/MiniBrowser.pro:
315
316 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
317
318         Reviewed by Adam Roben.
319         
320         define NOMINMAX when building ImageDiff, as we do elsewhere.
321
322         Add various clampToInt() methods to MathExtras.h
323         https://bugs.webkit.org/show_bug.cgi?id=52910
324
325         * DumpRenderTree/win/ImageDiffCommon.vsprops:
326
327 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
328
329         Reviewed by Darin Adler.
330
331         WebKitTestRunner needs layoutTestController.setPOSIXLocale
332         https://bugs.webkit.org/show_bug.cgi?id=42682
333
334         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
335         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
336         (WTR::InjectedBundle::resetLocalSettings):
337         (WTR::InjectedBundle::didReceiveMessage):
338         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
339         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
340         (WTR::LayoutTestController::setPOSIXLocale):
341         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
342
343 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
344  
345          Reviewed by Mihai Parparita.
346  
347          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
348  
349          This patch re-enables this test and changes it to
350          handle all of the mac platform versions, not just the one
351          it is running on.
352  
353          https://bugs.webkit.org/show_bug.cgi?id=53356
354  
355          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
356  
357 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
358
359         Unreviewed, build fix.
360
361         Take two. The fix in 77023 didn't work, because we were
362         still calling path.abspath_to_uri, which calls _cygpath under
363         the covers, and it appears the cygpath on the bots does
364         something different than it does on my machine. This patch
365         removes the calls to path.abspath_to_uri, so it should be safe.
366         If it doesn't work, I'll roll it out along with r76982 and 77023.
367
368         https://bugs.webkit.org/show_bug.cgi?id=53126
369
370         * Scripts/webkitpy/layout_tests/port/test.py:
371
372 2011-01-28  David Kilzer  <ddkilzer@apple.com>
373
374         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
375         <http://webkit.org/b/53353>
376
377         Reviewed by Mark Rowe.
378
379         * Scripts/webkitdirs.pm:
380         (checkRequiredSystemConfig): Check the Xcode marketing version
381         in addition to the DevCoreTools build version before complaining
382         about an old version of Xcode.  Also make the Mac OS X version
383         check use Perl's built-in version string comparitor.
384
385 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
386
387         Unreviewed, build fix.
388
389         Work around breakage on Win 7 Release bot caused by r76982
390         and the fact that windows ports use "file:////" instead of
391         "file:///". Ideally the test code should be isolated from
392         this, but it isn't yet. Will fix properly in a bit.
393
394         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
395
396 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
397
398         Reviewed by Tony Chang.
399
400         new-run-webkit-tests: change worker model values to
401         "old-inline", "old-threads" in preparation for test_runner2 /
402         multiprocessing changes.
403
404         https://bugs.webkit.org/show_bug.cgi?id=53156
405
406         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
407         * Scripts/webkitpy/layout_tests/port/base.py:
408         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
409         * Scripts/webkitpy/layout_tests/port/mac.py:
410         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
411
412 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
413
414         Reviewed by Tony Chang.
415
416         committers.py - add an IRC nickname for dpranke
417         https://bugs.webkit.org/show_bug.cgi?id=53335
418
419         * Scripts/webkitpy/common/config/committers.py:
420
421 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
422
423         Reviewed by Tony Chang.
424
425         new-run-webkit-tests: add a "mock DRT" port implementation
426         and a separate class that emulates what we expect the
427         DumpRenderTree behavior to be.
428
429         This will eventually replace port/dryrun.py and allow us to get
430         better test coverage of the new-run-webkit-tests code as well as
431         a reference for what new-run-webkit-tests expects from DRT.
432
433         This is the first attempt at this, and it is pretty bare-boned. It
434         really only has been tested on the 'mac' port (and a little on
435         the 'chromium-mac' port.
436
437         https://bugs.webkit.org/show_bug.cgi?id=53126
438
439         * Scripts/webkitpy/common/system/filesystem_mock.py:
440         * Scripts/webkitpy/layout_tests/port/dryrun.py:
441         * Scripts/webkitpy/layout_tests/port/factory.py:
442         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
443         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
444         * Scripts/webkitpy/layout_tests/port/test.py:
445
446 2011-01-28  Pratik Solanki  <psolanki@apple.com>
447
448         Unreviewed. Removing .swp file checked in by mistake.
449
450         * Scripts/.webkitdirs.pm.swp: Removed.
451
452 2011-01-28  Pratik Solanki  <psolanki@apple.com>
453
454         Reviewed by David Kilzer.
455
456         Space not necessary for undefined feature
457         https://bugs.webkit.org/show_bug.cgi?id=53317
458
459         * Scripts/build-webkit:
460
461 2011-01-28  Chang Shu  <chang.shu@nokia.com>
462
463         Reviewed by Andreas Kling.
464
465         Reset NetworkAccessManager to clean up credentials from previous tests.
466         This change causes no performance overhead either.
467         https://bugs.webkit.org/show_bug.cgi?id=36688
468
469         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
470         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
471         (WebCore::DumpRenderTree::open):
472         * DumpRenderTree/qt/DumpRenderTreeQt.h:
473
474 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
475
476         Reviewed by Andreas Kling.
477
478         [Qt] Add Zoom Text Only action to MiniBrowser
479         https://bugs.webkit.org/show_bug.cgi?id=53297
480
481         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
482
483         * MiniBrowser/qt/BrowserWindow.cpp:
484         (BrowserWindow::BrowserWindow):
485         (BrowserWindow::zoomIn):
486         (BrowserWindow::zoomOut):
487         (BrowserWindow::resetZoom):
488         (BrowserWindow::toggleZoomTextOnly):
489         (BrowserWindow::applyZoom):
490         * MiniBrowser/qt/BrowserWindow.h:
491
492 2011-01-28  Adam Barth  <abarth@webkit.org>
493
494         Reviewed by Eric Seidel.
495
496         Add webkit-patch roll-chromium-deps
497         https://bugs.webkit.org/show_bug.cgi?id=53288
498
499         This command updates the Source/WebKit/chromium/DEPS file with the
500         last-known good revision of Chromium (or a revision specified on the
501         command line).  I'd eventually like to turn this into a SheriffBot
502         command, but this is the first step.
503
504         This patch somewhat sprawled because I needed to move a bunch of code
505         out of ChangeLog that should never have been there in the first place.
506         Also, I had to fix a bug in MockUser in order to test the new command.
507
508         * Scripts/webkitpy/common/checkout/api.py:
509         * Scripts/webkitpy/common/checkout/changelog.py:
510         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
511         * Scripts/webkitpy/common/checkout/deps.py: Added.
512         * Scripts/webkitpy/common/config/urls.py:
513         * Scripts/webkitpy/tool/commands/__init__.py:
514         * Scripts/webkitpy/tool/commands/download_unittest.py:
515         * Scripts/webkitpy/tool/commands/roll.py: Added.
516         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
517         * Scripts/webkitpy/tool/commands/upload_unittest.py:
518         * Scripts/webkitpy/tool/mocktool.py:
519         * Scripts/webkitpy/tool/steps/__init__.py:
520         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
521         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
522         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
523         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
524         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
525         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
526
527 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
528
529         Reviewed by Laszlo Gombos.
530
531         Get rid of prefix header dependency for WebKit2 build system
532         https://bugs.webkit.org/show_bug.cgi?id=50174
533
534         Change the style checker so that it enforces config.h include for
535         WebKit2.
536
537         * Scripts/webkitpy/style/checker.py:
538
539 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
540
541         Reviewed by Darin Adler.
542
543         execCommand("Paste") doesn't work in WebKitTestRunner
544         https://bugs.webkit.org/show_bug.cgi?id=52785
545
546         Enable both of the settings needed to allow paste.
547         
548         * WebKitTestRunner/TestController.cpp:
549         (WTR::TestController::resetStateToConsistentValues):
550
551 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
552
553         Reviewed by Andreas Kling.
554
555         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
556         https://bugs.webkit.org/show_bug.cgi?id=48440
557
558         Preserve user input when toggling use of QGraphicsView
559
560         * QtTestBrowser/launcherwindow.cpp:
561         (LauncherWindow::initializeView):
562         (LauncherWindow::loadFinished):
563         * QtTestBrowser/launcherwindow.h:
564         * QtTestBrowser/mainwindow.cpp:
565         (MainWindow::addressUrl):
566         * QtTestBrowser/mainwindow.h:
567
568 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
569
570         Reviewed by Mihai Parparita.
571
572         new-run-webkit-tests: turn off pixel tests correctly by default
573         for webkit-based ports. r70013 (bug 47510) used
574         port.set_option_default() to attempt to set default values, but
575         that didn't work correctly. I have removed set_option_default
576         for now since it was only being used in two places and in three
577         useless unit tests. There is a separate bug open to fix the
578         option parsing (48095), so this workaround is fine for now.
579
580         https://bugs.webkit.org/show_bug.cgi?id=53217
581
582         * Scripts/webkitpy/layout_tests/port/webkit.py:
583         * Scripts/webkitpy/layout_tests/port/base.py:
584         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
585
586 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
587
588         Rubber-stamped by Ariya Hidayat.
589
590         Trivial crash fix in WTR.
591
592         * WebKitTestRunner/TestController.cpp:
593         (WTR::TestController::initialize): Increase the size
594         of the vector by one to be able to store the null character.
595
596 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
597
598         Reviewed by Csaba Osztrogonác.
599
600         [Qt][WK2] WTR should be initialized in the same way as DRT
601         https://bugs.webkit.org/show_bug.cgi?id=53240
602
603         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
604         (WTR::activateFonts): Added missing initialization steps.
605
606 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
607
608         Unreviewed. 
609
610         Adding myself to committers.py.
611
612         * Scripts/webkitpy/common/config/committers.py:
613
614 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
615
616         Reviewed by Csaba Osztrogonác.
617
618         [Qt] [Symbian] Move project files into Source
619         https://bugs.webkit.org/show_bug.cgi?id=52891
620
621         Fix the Symbian build after the project files
622         are moved to Source directory. On Symbian qmake
623         needs to run in the same directory where the main
624         pro files (WebKit.pro, Tools.pro) are located.
625
626         * Scripts/webkitdirs.pm: Change to the directory where the pro file
627         is located before running qmake for Symbian. Qmake on Symbian
628         does not properly honor the "-o" option, work it around by setting
629         the name of the Makefile to bld.inf.
630
631 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
632
633         Reviewed by Andreas Kling.
634
635         [Qt] Add simple zooming features to MiniBrowser
636         https://bugs.webkit.org/show_bug.cgi?id=53231
637
638         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
639
640         * MiniBrowser/qt/BrowserWindow.cpp:
641         (BrowserWindow::BrowserWindow):
642         (BrowserWindow::zoomIn):
643         (BrowserWindow::zoomOut):
644         (BrowserWindow::resetZoom):
645         (BrowserWindow::updateUserAgentList):
646         (BrowserWindow::applyZoom):
647         * MiniBrowser/qt/BrowserWindow.h:
648
649 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
650
651         Reviewed by Dan Bernstein.
652
653         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
654         https://bugs.webkit.org/show_bug.cgi?id=42319
655         
656         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
657
658         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
659         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
660         (WTR::LayoutTestController::showWebInspector):
661         (WTR::LayoutTestController::closeWebInspector):
662         (WTR::LayoutTestController::evaluateInWebInspector):
663         (WTR::LayoutTestController::setTimelineProfilingEnabled):
664         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
665         * WebKitTestRunner/TestInvocation.cpp:
666         (WTR::shouldOpenWebInspector):
667         (WTR::TestInvocation::invoke):
668         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
669
670 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
671
672         Reviewed by Xan Lopez.
673
674         [GTK] Pixel dumps do not include scrollbars in output images
675         https://bugs.webkit.org/show_bug.cgi?id=53216
676
677         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
678         that have scrollbars.
679
680         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
681         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
682         instead of the web view itself.
683
684 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
685
686         Reviewed by Mihai Parparita.
687
688         Fix regression introduced in r76322 ... new-run-webkit-tests
689         was attempting to save the image diff output as a UTF-8-encoded
690         file.
691
692         https://bugs.webkit.org/show_bug.cgi?id=53210
693
694         * Scripts/webkitpy/layout_tests/port/webkit.py:
695
696 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
697
698         Unreviewed, rolling out r76709.
699         http://trac.webkit.org/changeset/76709
700         https://bugs.webkit.org/show_bug.cgi?id=53194
701
702         "broke python tests on non-snowleopard platforms" (Requested
703         by dpranke on #webkit).
704
705         * Scripts/webkitpy/layout_tests/port/factory.py:
706         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
707         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
708
709 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
710
711         Reviewed by Tony Chang.
712
713         new-run-webkit-tests: add a "mock DRT" port implementation
714         and a separate class that emulates what we expect the
715         DumpRenderTree behavior to be.
716
717         This will eventually replace port/dryrun.py and allow us to get
718         better test coverage of the new-run-webkit-tests code as well as
719         a reference for what new-run-webkit-tests expects from DRT.
720
721         This is the first attempt at this, and it is pretty bare-boned. It
722         really only has been tested on the 'mac' port (and a little on
723         the 'chromium-mac' port.
724
725         https://bugs.webkit.org/show_bug.cgi?id=53126
726
727         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
728         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
729         * Scripts/webkitpy/layout_tests/port/factory.py:
730
731 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
732
733         Reviewed by Tony Chang.
734
735         Add '--no-timeout' option to Chromium DRT to ease debugging.
736         https://bugs.webkit.org/show_bug.cgi?id=52873
737
738         * DumpRenderTree/chromium/DumpRenderTree.cpp:
739         (main):
740
741 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
742
743         Reviewed by Andreas Kling.
744
745         [Qt] Fix qt_minimal build
746         https://bugs.webkit.org/show_bug.cgi?id=53172
747
748         * QtTestBrowser/locationedit.h:
749
750 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
751
752         Reviewed by Antonio Gomes.
753
754         QtTestBrowser should have a UI Setting to disable plugins
755         https://bugs.webkit.org/show_bug.cgi?id=52408
756         
757         Added a new action item named "Disable Plugins"
758         under the "Settings" menu. 
759
760         * QtTestBrowser/launcherwindow.cpp:
761         (LauncherWindow::createChrome):
762         (LauncherWindow::togglePlugins):
763         * QtTestBrowser/launcherwindow.h:
764
765 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
766
767         Reviewed by Adam Barth.
768
769         Move main CMakeLists.txt into Source directory
770         https://bugs.webkit.org/show_bug.cgi?id=52888
771
772         * Scripts/webkitdirs.pm:
773
774 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
775
776         Reviewed by Eric Seidel.
777
778         Improve label text in submit-to-ews
779         https://bugs.webkit.org/show_bug.cgi?id=53130
780
781         * QueueStatusServer/templates/submittoews.html:
782
783 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
784
785         Reviewed by Antonio Gomes.
786
787         QtTestBrowser should have a UI Settings to prevent loading images
788         https://bugs.webkit.org/show_bug.cgi?id=52409
789         
790         Added a new action item named "DisableAutoLoadImages"
791         under the "Settings" menu 
792
793         * QtTestBrowser/launcherwindow.cpp:
794         (LauncherWindow::createChrome):
795         (LauncherWindow::toggleAutoLoadImages):
796         * QtTestBrowser/launcherwindow.h:
797
798 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
799
800         Reviewed by Tony Chang.
801
802         Minor bug fixes and cleanup for filesystem wrappers, port/* test
803         classes, test_expectations.py. This change adds "test-win" and
804         "test-mac" variants to the test port so that we can better test
805         rebaselining, and adds a MockUser() object for reuse in testing.
806
807         https://bugs.webkit.org/show_bug.cgi?id=53036
808
809         * Scripts/webkitpy/common/system/filesystem.py:
810         * Scripts/webkitpy/common/system/filesystem_mock.py:
811         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
812         * Scripts/webkitpy/layout_tests/port/factory.py:
813         * Scripts/webkitpy/layout_tests/port/base.py:
814         * Scripts/webkitpy/layout_tests/port/test.py:
815         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
816         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
817         * Scripts/webkitpy/tool/mocktool.py:
818
819 2011-01-25  Tony Chang  <tony@chromium.org>
820
821         Reviewed by Dimitri Glazkov.
822
823         [chromium] remove unused layoutTestController callback
824         https://bugs.webkit.org/show_bug.cgi?id=53103
825
826         This method is used by a test_shell_test, but not needed by DRT.
827
828         * DumpRenderTree/chromium/LayoutTestController.cpp:
829         (LayoutTestController::LayoutTestController):
830         * DumpRenderTree/chromium/LayoutTestController.h:
831
832 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
833
834         Reviewed by Andreas Kling.
835
836         [GTK] Remove 64 bits release bot from the buildbot master
837         https://bugs.webkit.org/show_bug.cgi?id=52899
838
839         Removes the 64 bits release slave from the buildbot configuration,
840         so that we can use it as an EWS.
841
842         * BuildSlaveSupport/build.webkit.org-config/config.json:
843
844 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
845
846         Reviewed by Dan Bernstein.
847
848         Implement database quota callback to fix storage tests on WebKit2 bot
849         https://bugs.webkit.org/show_bug.cgi?id=53064
850
851         * WebKitTestRunner/TestController.cpp:
852         (WTR::exceededDatabaseQuota):
853         (WTR::TestController::createOtherPage):
854         (WTR::TestController::initialize):
855
856 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
857
858         Reviewed by Anders Carlsson.
859
860         Use designated temp directory for the database for WebKit2
861         https://bugs.webkit.org/show_bug.cgi?id=53052
862         
863         Adopt the new WK2 API for this.
864
865         * WebKitTestRunner/TestController.cpp:
866         (WTR::TestController::libraryPathForTesting):
867         (WTR::TestController::initialize):
868         * WebKitTestRunner/TestController.h:
869         * WebKitTestRunner/mac/TestControllerMac.mm:
870         (WTR::TestController::platformLibraryPathForTesting):
871         * WebKitTestRunner/qt/TestControllerQt.cpp:
872         (WTR::TestController::platformLibraryPathForTesting):
873         * WebKitTestRunner/win/TestControllerWin.cpp:
874         (WTR::TestController::platformLibraryPathForTesting):
875
876 2011-01-24  Lucas Forschler  <lforschler@apple.com>
877
878         Reviewed by Stephanie Lewis.
879
880         Add a new Leopard test bot.
881
882         * BuildSlaveSupport/build.webkit.org-config/config.json:
883
884 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
885
886         Reviewed by Adam Barth.
887
888         Add EFL Builder to core waterfall
889         https://bugs.webkit.org/show_bug.cgi?id=52704
890
891         Add EFL Builder to the core waterfall again.
892
893         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
894         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
895
896 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
897
898         Reviewed by Tony Chang.
899
900         new-run-webkit-tests fails to start HTTP server if there are proxy settings
901         https://bugs.webkit.org/show_bug.cgi?id=52872
902
903         Force disabling proxy to resolve the problem.
904
905         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
906         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
907
908 2011-01-24  Andreas Kling  <kling@webkit.org>
909
910         Reviewed by Darin Adler.
911
912         check-webkit-style: Update exemptions following Source/ move.
913         https://bugs.webkit.org/show_bug.cgi?id=53017
914
915         * Scripts/webkitpy/style/checker.py:
916         * Scripts/webkitpy/style/checker_unittest.py:
917
918 2011-01-24  Andras Becsi  <abecsi@webkit.org>
919
920         Rubber-stamped by Csaba Osztrogonác.
921
922         [Qt] Move project files into Source
923         https://bugs.webkit.org/show_bug.cgi?id=52891
924
925         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
926
927 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
928
929         Reviewed by Yury Semikhatsky.
930
931         Web Inspector: Find duplicate strings in localizedStrings.js
932
933         https://bugs.webkit.org/show_bug.cgi?id=53005
934
935         * Scripts/check-inspector-strings:
936
937 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
938
939         Reviewed by Andreas Kling.
940
941         [Qt] Regroup MiniBrowser's menubar and add open file action
942         https://bugs.webkit.org/show_bug.cgi?id=53000
943
944         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
945
946         * MiniBrowser/qt/BrowserWindow.cpp:
947         (BrowserWindow::BrowserWindow):
948         (BrowserWindow::openFile):
949         (BrowserWindow::~BrowserWindow):
950         * MiniBrowser/qt/BrowserWindow.h:
951
952 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
953
954         Unreviewed fix after r76496
955
956         [Qt] Move project files into Source
957         https://bugs.webkit.org/show_bug.cgi?id=52891
958
959         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
960         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
961         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
962
963 2011-01-24  Andras Becsi  <abecsi@webkit.org>
964
965         Reviewed by Csaba Osztrogonác.
966
967         [Qt] Move project files into Source
968         https://bugs.webkit.org/show_bug.cgi?id=52891
969
970         * DerivedSources.pro: Renamed from DerivedSources.pro.
971         * DumpRenderTree/qt/DumpRenderTree.pro:
972         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
973         * MiniBrowser/DerivedSources.pro:
974         * MiniBrowser/qt/MiniBrowser.pro:
975         * QtTestBrowser/QtTestBrowser.pro:
976         * Scripts/webkitdirs.pm:
977         * Tools.pro: Added.
978         * WebKitTestRunner/DerivedSources.pro:
979         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
980         * WebKitTestRunner/qt/WebKitTestRunner.pro:
981
982 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
983
984         Reviewed by Dan Bernstein.
985
986         Beefed up --threaded mode to catch even more kinds of errors.
987         https://bugs.webkit.org/show_bug.cgi?id=52971
988
989         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
990         context group to force JSC to mark multiple threads. (This used to be
991         the default, but it changed in SnowLeopard.)
992         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
993         to give threading mistakes more chances to show themselves.
994         (startJavaScriptThreads):
995         (stopJavaScriptThreads):
996
997 2011-01-22  Robert Hogan  <robert@webkit.org>
998
999         Reviewed by Andreas Kling.
1000
1001         [Qt] Support layoutTestController.addURLToRedirect()
1002         https://bugs.webkit.org/show_bug.cgi?id=52956
1003
1004         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1005         (LayoutTestController::addURLToRedirect):
1006         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1007
1008 2011-01-22  Robert Hogan  <robert@webkit.org>
1009
1010         Reviewed by Kenneth Rohde Christiansen.
1011
1012         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1013         https://bugs.webkit.org/show_bug.cgi?id=49802
1014
1015         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1016         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1017         (WebCore::DumpRenderTree::open):
1018
1019 2011-01-21  Adam Barth  <abarth@webkit.org>
1020
1021         Reviewed by Maciej Stachowiak.
1022
1023         Disable mac_unittest.py that fails on some of the Mac bots
1024         https://bugs.webkit.org/show_bug.cgi?id=52947
1025
1026         As noted in the comment, this test does not appear to be correct
1027         because the function this test is testing returns different results
1028         depending on which flavor of Mac the test is run on.  This patch
1029         disable the test.  Hopefully we can re-enable the test once we've
1030         probably insulated the test from its environment.
1031
1032         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1033
1034 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1035
1036         Reviewed by Mihai Parparita.
1037
1038         Fix bug introduced in r76322 that caused NRWT to not actually
1039         read the Skipped files properly.
1040
1041         https://bugs.webkit.org/show_bug.cgi?id=52771
1042
1043         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1044         * Scripts/webkitpy/layout_tests/port/webkit.py:
1045         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1046
1047 2011-01-21  Sam Weinig  <sam@webkit.org>
1048
1049         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1050
1051         WebKitTestRunner needs the HOME environment variable to be set.
1052         <rdar://problem/8896573>
1053
1054         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1055         it exists.
1056
1057 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1058
1059         Reviewed by Eric Seidel.
1060
1061         Suppress a few remaining integration tests so that none of the
1062         layout_test unit tests ever read from the filesystem or launch
1063         subprocesses that aren't part of the unit tests.
1064
1065         Also fix a minor bug in the printing unit tests that was
1066         incorrectly relying on sys.argv.
1067
1068         https://bugs.webkit.org/show_bug.cgi?id=52863
1069
1070         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1071         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1072         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1073
1074 2011-01-21  Darin Adler  <darin@apple.com>
1075
1076        Fix Mac build.
1077
1078         * MiniBrowser/mac/BrowserWindowController.m:
1079         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1080
1081 2011-01-20  Darin Adler  <darin@apple.com>
1082
1083         Reviewed by Dan Bernstein.
1084
1085         WebKit2: Implement showModalDialog
1086         https://bugs.webkit.org/show_bug.cgi?id=52855
1087
1088         This fixes WebKitTestRunner to compile, but more work is probably
1089         needed to get it to pass the tests.
1090
1091         * WebKitTestRunner/TestController.cpp:
1092         (WTR::TestController::runModal): Added. Calls through to the
1093         platform-specific version of runModal.
1094         (WTR::TestController::createOtherPage): Changed to be a private
1095         static member function so it can refer to runModal, which is
1096         a private static member function.
1097         (WTR::TestController::initialize): Pass 0 for the runModal
1098         function since we don't need to run the main window modal.
1099         I suspect this is wrong and will need to change.
1100         * WebKitTestRunner/TestController.h: Added declarations for
1101         the functions added above.
1102         * WebKitTestRunner/mac/TestControllerMac.mm:
1103         (WTR::TestController::runModal): Added. Untested implementation.
1104         * WebKitTestRunner/qt/TestControllerQt.cpp:
1105         (WTR::TestController::runModal): Added.
1106         * WebKitTestRunner/win/TestControllerWin.cpp:
1107         (WTR::TestController::runModal): Added.
1108
1109 2011-01-21  Eric Seidel  <eric@webkit.org>
1110
1111         Reviewed by Adam Barth.
1112
1113         Split Host object off from WebKitPatch for easier re-use
1114         https://bugs.webkit.org/show_bug.cgi?id=52284
1115
1116         new-run-webkit-tests and other tools are eventually going to want one of these.
1117         Basically you need to inherit from this class if you want to pretend to be a
1118         self.tool object for Steps/Commands.
1119
1120         * Scripts/webkitpy/common/host.py: Added.
1121         * Scripts/webkitpy/tool/main.py:
1122
1123 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1124
1125         Reviewed by Adam Barth.
1126
1127         Disable the tests that start and stop the http server and web
1128         server, so that we don't have to worry about port collisions on
1129         the bots.
1130
1131         https://bugs.webkit.org/show_bug.cgi?id=52861
1132
1133         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1134
1135 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1136
1137         Reviewed by Eric Seidel.
1138
1139         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1140         
1141         https://bugs.webkit.org/show_bug.cgi?id=52772
1142         
1143         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1144
1145 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1146
1147         Reviewed by Eric Siedel.
1148
1149         nrwt: clean up almost all remaining port references, remove
1150         unnecessary import clauses. The only remaining references are
1151         in places where a mock filesystem makes no sense or can't be
1152         used, and in one routine in port/google_chrome_unittest that
1153         I'll rewrite in a separate patch.
1154
1155         https://bugs.webkit.org/show_bug.cgi?id=52771
1156
1157         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1158         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1159         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1160         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1161         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1162         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1163         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1164         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1165         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1166         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1167         * Scripts/webkitpy/layout_tests/port/gtk.py:
1168         * Scripts/webkitpy/layout_tests/port/mac.py:
1169         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1170         * Scripts/webkitpy/layout_tests/port/qt.py:
1171         * Scripts/webkitpy/layout_tests/port/webkit.py:
1172         * Scripts/webkitpy/layout_tests/port/win.py:
1173         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1174
1175 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1176
1177         Reviewed by Mihai Parparita.
1178
1179         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1180
1181         https://bugs.webkit.org/show_bug.cgi?id=52762
1182
1183         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1184         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1185
1186 2011-01-20  Tony Chang  <tony@chromium.org>
1187
1188         Reviewed by Ojan Vafai.
1189
1190         [chromium] fix the paths used for the rebaseline tool
1191         https://bugs.webkit.org/show_bug.cgi?id=52857
1192
1193         Some of the bots were renamed so the path to grab the results zip
1194         file has changed.
1195
1196         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1197
1198 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1199
1200         Reviewed by Tony Chang.
1201
1202         Fix bug introduced in r72688 / bug 52768 that broke the
1203         generation of the output filename links in the results.html
1204         output. Apparently none of the unit tests actually checked to
1205         make sure the generated links were correct :(
1206
1207         https://bugs.webkit.org/show_bug.cgi?id=52854
1208
1209         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1210         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1211
1212 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1213
1214         Reviewed by Darin Adler.
1215
1216         https://bugs.webkit.org/show_bug.cgi?id=52849
1217         Make window.print work with WebKit2
1218
1219         * MiniBrowser/mac/BrowserWindowController.m:
1220         (-[BrowserWindowController awakeFromNib]):
1221         * WebKitTestRunner/TestController.cpp:
1222         (WTR::createOtherPage):
1223         (WTR::TestController::initialize):
1224         Added zeroes to WKPageUIClient structures to avoid build failures.
1225
1226 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1227
1228         Reviewed by Eric Seidel.
1229
1230         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1231
1232         https://bugs.webkit.org/show_bug.cgi?id=52756
1233
1234         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1235         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1236         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1237         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1238         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1239         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1240
1241 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1242
1243         Reviewed by Antonio Gomes.
1244
1245         QtTestBrowser should have a seperate menu for Settings
1246         https://bugs.webkit.org/show_bug.cgi?id=52817
1247         
1248         Added a new menu item named "Settings"
1249         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1250
1251         * QtTestBrowser/launcherwindow.cpp:
1252         (LauncherWindow::createChrome):
1253
1254 2011-01-20  Sam Weinig  <sam@webkit.org>
1255
1256         Reviewed by John Sullivan.
1257
1258         Update update-webkit-localizable-strings with new path to WebKit.
1259
1260         * Scripts/update-webkit-localizable-strings:
1261
1262 2011-01-20  James Robinson  <jamesr@chromium.org>
1263
1264         Reviewed by Darin Fisher.
1265
1266         Implement mozilla's requestAnimationFrame API
1267         https://bugs.webkit.org/show_bug.cgi?id=51218
1268
1269         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1270
1271         * DumpRenderTree/chromium/WebViewHost.cpp:
1272         (invokeScheduleComposite):
1273         (WebViewHost::scheduleAnimation):
1274         (WebViewHost::paintInvalidatedRegion):
1275         * DumpRenderTree/chromium/WebViewHost.h:
1276
1277 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1278
1279         Reviewed by Adam Roben.
1280
1281         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1282         https://bugs.webkit.org/show_bug.cgi?id=42327
1283
1284         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1285         for methods that take their normal arguments but also a JSContextRef.
1286         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1287         for evaluateScriptInIsolatedWorld.
1288         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1289         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1290         this call is for an isolated world.
1291         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1292         (WTR::worldMap): Helper to create a world map.
1293         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1294         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1295         added LayoutTestController API.
1296         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1297
1298 2011-01-19  Adam Roben  <aroben@apple.com>
1299
1300         Convert paths in environment variables back to msys-style inside commit-log-editor
1301
1302         When this script gets run from inside git commit, msys-style paths in the environment will
1303         have been turned into Windows-style paths with forward slashes. This screws up functions
1304         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1305         the paths back to msys-style before doing anything else.
1306
1307         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1308         using msysgit's Perl and multiple ChangeLogs have been edited
1309
1310         Reviewed by David Kilzer.
1311
1312         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1313         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1314         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1315
1316 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1317
1318         [Win] Unreviewed build fix after r76248.
1319
1320         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1321
1322 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1323
1324         Reviewed by Csaba Osztrogonác.
1325
1326         Refactoring of the custom allocation framework
1327         https://bugs.webkit.org/show_bug.cgi?id=49897
1328
1329         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1330         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1331         equivalent macro implementation at the necessary places.
1332 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1333
1334         Unreviewed. 
1335
1336         Adding myself to committers.py.
1337
1338         * Scripts/webkitpy/common/config/committers.py:
1339
1340 2011-01-20  Adam Barth  <abarth@webkit.org>
1341
1342         Reviewed by Tony Chang.
1343
1344         Chromium builders don't delete unversioned directories when DEPS change
1345         https://bugs.webkit.org/show_bug.cgi?id=52745
1346
1347         If we pass this option to gclient sync, gclient will delete directories
1348         that are no longer part of DEPS instead of leaving them around to
1349         confuse us later.  Apparently, the downstream buildbots use this option
1350         already.
1351
1352         * Scripts/update-webkit-chromium:
1353
1354 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1355
1356         Unreviewed, build fix - I pulled this patch in to fix an issue
1357         revealed by r76195 running on some new bots). Also fix a couple
1358         of other issues revealed in testing.
1359
1360         nrwt: remove fs refs from layout_package/json*
1361
1362         https://bugs.webkit.org/show_bug.cgi?id=52754
1363
1364         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1365         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1366         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1367         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1368         * Scripts/webkitpy/layout_tests/port/base.py:
1369
1370 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1371
1372         Unreviewed, build fix.
1373
1374         Fix a couple of minor bugs discovered while bringing up new bots
1375         for testing.
1376
1377         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1378         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1379
1380 2011-01-19  James Robinson  <jamesr@chromium.org>
1381
1382         Unreviewed, rolling out r76194.
1383         http://trac.webkit.org/changeset/76194
1384         https://bugs.webkit.org/show_bug.cgi?id=51218
1385
1386         Caused mysterious compile failure on the chromium win
1387         build.webkit.org bots
1388
1389         * DumpRenderTree/chromium/WebViewHost.cpp:
1390         (WebViewHost::paintInvalidatedRegion):
1391         * DumpRenderTree/chromium/WebViewHost.h:
1392
1393 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1394
1395         Reviewed by Mihai Parparita.
1396
1397         remove fs refs from test_runner, dump_render_tree_thread
1398
1399         https://bugs.webkit.org/show_bug.cgi?id=52753
1400
1401         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1402         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1403         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1404         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1405
1406 2011-01-19  James Robinson  <jamesr@chromium.org>
1407
1408         Reviewed by Darin Fisher.
1409
1410         Implement mozilla's requestAnimationFrame API
1411         https://bugs.webkit.org/show_bug.cgi?id=51218
1412
1413         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1414
1415         * DumpRenderTree/chromium/WebViewHost.cpp:
1416         (invokeScheduleComposite):
1417         (WebViewHost::scheduleAnimation):
1418         (WebViewHost::paintInvalidatedRegion):
1419         * DumpRenderTree/chromium/WebViewHost.h:
1420
1421 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1422
1423         Unreviewed, build fix.
1424
1425         Fix a few incorrect "self._filesystem" references introduced in
1426         r76184.
1427
1428         * Scripts/webkitpy/layout_tests/port/chromium.py:
1429         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1430
1431 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1432
1433         Reviewed by Mihai Parparita.
1434
1435         add a .sep property, abspath(), isabs(), mtime(), and
1436         open_text_file_for_writing() to filesystem modules. Some of
1437         these properties are not needed in this patch but will be needed
1438         in subsequent patches (I'm doing this to avoid having to track
1439         multiple versions of a single file).
1440
1441         Also, change most of the port/* modules to use the filesystem
1442         objects instead of referencing the filesystem directly.
1443
1444         https://bugs.webkit.org/show_bug.cgi?id=52748
1445
1446         * Scripts/webkitpy/common/system/filesystem.py:
1447         * Scripts/webkitpy/common/system/filesystem_mock.py:
1448         * Scripts/webkitpy/layout_tests/port/__init__.py:
1449         * Scripts/webkitpy/layout_tests/port/base.py:
1450         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1451         * Scripts/webkitpy/layout_tests/port/chromium.py:
1452         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1453         * Scripts/webkitpy/layout_tests/port/config.py:
1454         * Scripts/webkitpy/layout_tests/port/test.py:
1455         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1456
1457 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1458
1459         Reviewed by Anders Carlsson.
1460
1461         If resetting between tests times out, treat it as a WebProcess crash
1462         https://bugs.webkit.org/show_bug.cgi?id=52757
1463
1464         * WebKitTestRunner/TestController.cpp:
1465         (WTR::TestController::runTest):
1466
1467 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1468
1469         Reviewed by Darin Adler.
1470
1471         https://bugs.webkit.org/show_bug.cgi?id=52739
1472         Make it possible for a WebKit2 client to print headers and footers
1473
1474         Added dummy implementations for new printing UIClient calls.
1475
1476         * MiniBrowser/mac/BrowserWindowController.m:
1477         (-[BrowserWindowController awakeFromNib]):
1478         * WebKitTestRunner/TestController.cpp:
1479         (WTR::createOtherPage):
1480         (WTR::TestController::initialize):
1481
1482 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1483
1484         Reviewed by Ojan Vafai.
1485
1486         Change webkitpy/layout_tests/port/test.py to use the
1487         in-memory filesystem for cleaner unit testing. This
1488         change allows us to kill a lot of code that was
1489         specific to the test port, at the cost of being a
1490         little less clear about how things would work if
1491         you didn't have a filesystem.
1492
1493         https://bugs.webkit.org/show_bug.cgi?id=52605
1494
1495         * Scripts/webkitpy/layout_tests/port/test.py:
1496
1497 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1498
1499         Unreviewed, build fix.
1500
1501         Fix test failure caused by committing attachment 79368 instead
1502         of attachment 79461 on bug 52604.
1503
1504         * Scripts/webkitpy/common/system/filesystem_mock.py:
1505
1506 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1507
1508         Reviewed by Mihai Parparita.
1509
1510         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1511         unit testing. os.walk() is too much of a hassle to implement on
1512         top of the in-memory mock filesystem and adding the necessary
1513         interface to files_under() gives clients a cleaner API anyway
1514         (for this particular usage model).
1515
1516         https://bugs.webkit.org/show_bug.cgi?id=52691
1517
1518         * Scripts/webkitpy/common/system/filesystem.py:
1519         * Scripts/webkitpy/common/system/filesystem_mock.py:
1520         * Scripts/webkitpy/layout_tests/port/test_files.py:
1521         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1522
1523 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1524
1525         Reviewed by Tony Chang.
1526
1527         Change more modules in the layout-tests code to use the
1528         filesystem wrapper for cleaner unit testing.
1529
1530         This patch also adds the glob() wrapper to the filesystem
1531         abstraction.
1532         
1533         https://bugs.webkit.org/show_bug.cgi?id=52604
1534
1535         * Scripts/webkitpy/layout_tests/port/test_files.py:
1536         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1537         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1538         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1539         * Scripts/webkitpy/common/system/filesystem.py:
1540         * Scripts/webkitpy/common/system/filesystem_mock.py:
1541
1542 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1543
1544         Unreviewed.
1545
1546         Updating my email addresses and irc nick.
1547
1548         * Scripts/webkitpy/common/config/committers.py:
1549
1550 2011-01-19  Tony Chang  <tony@chromium.org>
1551
1552         Reviewed by Mihai Parparita.
1553
1554         [chromium] [linux] if check-sys-deps fails, output the failure reason
1555         https://bugs.webkit.org/show_bug.cgi?id=52671
1556
1557         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1558             error handler functions.
1559         * Scripts/webkitpy/layout_tests/port/chromium.py:
1560             output the error text from --check-sys-deps
1561         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1562
1563 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1564
1565         Reviewed by Andreas Kling.
1566
1567         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1568         https://bugs.webkit.org/show_bug.cgi?id=52554
1569         
1570         QtNetworkAccessManager is created in a thread and set as
1571         member variable in QWebPage. When the thread is destroyed
1572         the object is still used. So fix will set the object to
1573         NULL once the thread is destroyed.
1574
1575         * QtTestBrowser/launcherwindow.cpp:
1576         (LauncherWindow::~LauncherWindow):
1577
1578 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1579
1580         Rubber stamped by Csaba Osztrogonac
1581
1582         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1583
1584 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1585
1586         Reviewed by Tony Chang.
1587
1588         new-run-webkit-tests: add a --build-directory command line argument
1589
1590         Official Google Chrome builds use a non-standard build directory
1591         location. This patch adds a --build-directory argument that
1592         allows that location to be specified on the command line. Only
1593         Chromium-based builds will use this flag for now, but anyone can
1594         in the future.
1595
1596         There are no unit tests for this since it's difficult to test
1597         until mock filesystems are fully supported in the code. This was
1598         tested by hand for now.
1599
1600         https://bugs.webkit.org/show_bug.cgi?id=52694
1601
1602         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1603         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1604         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1605         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1606
1607 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1608
1609         Not reviewed. Bot fix.
1610
1611         Remove an inadvertently committed debugging print.
1612
1613         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1614         (LayoutTestController::notifyDone):
1615
1616 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1617
1618         Reviewed by Sam Weinig.
1619
1620         WebKitTestRunner should track loading more like DumpRenderTree
1621         https://bugs.webkit.org/show_bug.cgi?id=52692
1622
1623         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1624         This makes some tests that call notifyDone multiple times pass.
1625         
1626         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1627         (WTR::InjectedBundle::InjectedBundle):
1628         (WTR::InjectedBundle::done):
1629         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1630         (WTR::InjectedBundle::topLoadingFrame):
1631         (WTR::InjectedBundle::setTopLoadingFrame):
1632         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1633         (WTR::InjectedBundlePage::InjectedBundlePage):
1634         (WTR::InjectedBundlePage::stopLoading):
1635         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1636         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1637         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1638         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1639         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1640         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1641         (WTR::LayoutTestController::notifyDone):
1642         * WebKitTestRunner/TestController.cpp:
1643         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1644
1645 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1646
1647         Reviewed by Kent Tamura.
1648
1649         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1650         https://bugs.webkit.org/show_bug.cgi?id=52678
1651         
1652         Update path now that WebKit is inside Source.
1653
1654         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1655
1656 2011-01-18  Robert Hogan  <robert@webkit.org>
1657
1658         Reviewed by Simon Hausmann.
1659
1660         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1661         https://bugs.webkit.org/show_bug.cgi?id=44282
1662
1663         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1664         (WebCore::DumpRenderTree::dump):
1665
1666 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1667
1668         Reviewed by Mihai Parparita.
1669
1670         Fix a small race condition that could cause the unit tests for
1671         new-run-webkit-tests to fail in a multithreaded environment.
1672         There was a small window in the code where one thread would
1673         check to see if a thread had raised an exception, do something,
1674         and then check to see if the thread was alive. If the other
1675         thread raised an exception and exited in between these two
1676         steps, the exception would be lost. Flipping the order of the
1677         two checks fixes the race, since we will now always check for an
1678         exception on the thread before exiting.
1679
1680         https://bugs.webkit.org/show_bug.cgi?id=51579
1681
1682         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1683
1684 2011-01-18  Eric Seidel  <eric@webkit.org>
1685
1686         Reviewed by Adam Barth.
1687
1688         commit-queue dies when test archiving fails
1689         https://bugs.webkit.org/show_bug.cgi?id=52617
1690
1691         I looked at the machine and it had 10 archives already
1692         thus find_unused_name was returning None.  I've upped
1693         the limit to 100 (per bug) and tested the case where
1694         find_unused_name returns None (making archive return None).
1695
1696         * Scripts/webkitpy/common/system/workspace.py:
1697         * Scripts/webkitpy/common/system/workspace_unittest.py:
1698         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1699         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1700         * Scripts/webkitpy/tool/commands/queues.py:
1701
1702 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1703
1704         Reviewed by Ojan Vafai.
1705
1706         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1707         filesystem. Also fix a couple of "with" statements missed by
1708         r76050.
1709
1710         https://bugs.webkit.org/show_bug.cgi?id=52487
1711
1712         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1713
1714 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1715
1716         Reviewed by Martin Robinson.
1717
1718         [Gtk] Build fixes for gtk3 build
1719         https://bugs.webkit.org/show_bug.cgi?id=52648
1720
1721         * DumpRenderTree/gtk/EventSender.cpp:
1722         (beginDragWithFilesCallback):
1723
1724 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1725
1726         Reviewed by Mihai Parparita.
1727
1728         Update rebaseline-chromium-webkit-tests to use filesystem objects
1729         instead of direct references to os.path, shutil, tempfile, etc.
1730
1731         This patch doesn't change anything, but will allow subsequent
1732         patches to change the unit tests to no longer use the real
1733         filesystem.
1734
1735         This patch adds a bunch more methods to the filesystem object as
1736         well.
1737
1738         https://bugs.webkit.org/show_bug.cgi?id=52482
1739
1740         * Scripts/webkitpy/common/system/filesystem.py:
1741         * Scripts/webkitpy/common/system/filesystem_mock.py:
1742         * Scripts/webkitpy/tool/commands/queues.py:
1743         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1744         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1745
1746 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1747
1748         Reviewed by Mihai Parparita.
1749
1750         new-run-webkit-tests shouldn't crash when you try to run a
1751         directory containing only skipped files.
1752
1753         https://bugs.webkit.org/show_bug.cgi?id=52478
1754         
1755         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1756         * Scripts/webkitpy/layout_tests/port/test.py:
1757         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1758
1759 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1760
1761         Reviewed by Gustavo Noronha Silva.
1762
1763         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1764         https://bugs.webkit.org/show_bug.cgi?id=40833
1765
1766         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1767         GTK+ event sender.
1768         (dragWithFilesDragDataGetCallback): Added.
1769         (dragWithFilesDragEndCallback): Added.
1770         (beginDragWithFilesCallback): Added.
1771
1772 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1773
1774         Reviewed by Adam Barth.
1775
1776         ews: Add additional watcher to efl ews
1777         https://bugs.webkit.org/show_bug.cgi?id=52613
1778
1779         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1780
1781         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1782
1783 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1784
1785         Reviewed by Alexey Proskuryakov.
1786
1787         Fix some headers with missing or misspelled #ifndef guards
1788         https://bugs.webkit.org/show_bug.cgi?id=52545
1789
1790         * DumpRenderTree/chromium/TestEventPrinter.h:
1791         * DumpRenderTree/chromium/WebPreferences.h:
1792
1793 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1794
1795         Reviewed by Anders Carlsson.
1796
1797         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1798         navigating back to an unreachable URL
1799         https://bugs.webkit.org/show_bug.cgi?id=52388
1800
1801         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1802
1803         * DumpRenderTree/LayoutTestController.cpp:
1804         (queueLoadHTMLStringCallback):
1805         (LayoutTestController::queueLoadHTMLString):
1806         (LayoutTestController::queueLoadAlternateHTMLString):
1807         * DumpRenderTree/LayoutTestController.h:
1808
1809         * DumpRenderTree/WorkQueueItem.h:
1810         (LoadHTMLStringItem::LoadHTMLStringItem):
1811
1812         * DumpRenderTree/chromium/LayoutTestController.cpp:
1813         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1814         (WorkItemLoadHTMLString::run):
1815         (LayoutTestController::queueLoadHTMLString):
1816
1817         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1818         (LoadHTMLStringItem::invoke):
1819         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1820         (LoadHTMLStringItem::invoke):
1821         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1822         (LoadHTMLStringItem::invoke):
1823
1824 2011-01-17  Dan Bernstein  <mitz@apple.com>
1825
1826         Rubber-stamped by Mark Rowe.
1827
1828         Update xcodeproj svn:ignore to include xcuserdata.
1829
1830         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1831         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1832         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1833         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1834         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1835
1836 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1837
1838         Unreviewed fix after r75908.
1839
1840         Move WebKit into Source
1841         https://bugs.webkit.org/show_bug.cgi?id=52530
1842
1843         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1844
1845 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1846
1847         Unreviewed.
1848
1849         Remove accidentally committed debug printing after r75908.
1850
1851         * Scripts/webkitdirs.pm:
1852
1853 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1854
1855         Unreviewed.
1856
1857         Add myself to committers list
1858         https://bugs.webkit.org/show_bug.cgi?id=52566
1859
1860         * Scripts/webkitpy/common/config/committers.py:
1861
1862 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1863
1864         Reviewed by Jeremy Orlow.
1865
1866         GeolocationController should call stopUpdating on destruction
1867         https://bugs.webkit.org/show_bug.cgi?id=52216
1868
1869         fast/dom/Geolocation/window-close-crash.html requires that a
1870         Geolocation watch be started in a secondary window. Consequently,
1871         we need to allow geolocation permission and provide a mock
1872         geolocation position for the secondary window's
1873         GeolocationClientMock.
1874
1875         * DumpRenderTree/chromium/LayoutTestController.cpp:
1876         (LayoutTestController::setGeolocationPermission):
1877         (LayoutTestController::setMockGeolocationPosition):
1878         (LayoutTestController::setMockGeolocationError):
1879         * DumpRenderTree/chromium/TestShell.h:
1880         (TestShell::windowList):
1881
1882 2011-01-16  Adam Barth  <abarth@webkit.org>
1883
1884         Update more include paths to reflect WebKit move.
1885
1886         * DumpRenderTree/chromium/EventSender.cpp:
1887         (EventSender::keyDown):
1888         (EventSender::needsShiftModifier):
1889         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1890         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1891
1892 2011-01-16  Kent Tamura  <tkent@chromium.org>
1893
1894         Unreviewed, Chromium build fix.
1895
1896         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1897
1898 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1899
1900         Build fix for GTK+ after source directory movement.
1901
1902         * GNUmakefile.am: Correct include paths.
1903
1904 2011-01-16  Adam Barth  <abarth@webkit.org>
1905
1906         Teach svn-apply about WebKit move.
1907
1908         * Scripts/VCSUtils.pm:
1909
1910 2011-01-16  Adam Barth  <abarth@webkit.org>
1911
1912         Rubber-stamped by Eric Seidel.
1913
1914         Move WebKit into Source
1915         https://bugs.webkit.org/show_bug.cgi?id=52530
1916
1917         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1918         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1919         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1920         * DumpRenderTree/qt/GCControllerQt.cpp:
1921         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1922         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1923         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1924         * DumpRenderTree/wscript:
1925         * QtTestBrowser/launcherwindow.h:
1926         * Scripts/build-webkit:
1927         * Scripts/webkitdirs.pm:
1928
1929 2011-01-15  Adam Barth  <abarth@webkit.org>
1930
1931         Teach svn-apply about WebKit2 move.
1932
1933         * Scripts/VCSUtils.pm:
1934
1935 2011-01-15  Adam Barth  <abarth@webkit.org>
1936
1937         Rubber-stamped by Eric Seidel.
1938
1939         Move WebKit2 into Source
1940         https://bugs.webkit.org/show_bug.cgi?id=52438
1941
1942         * MiniBrowser/qt/MiniBrowser.pro:
1943         * Scripts/build-webkit:
1944         * Scripts/do-file-rename:
1945         * Scripts/do-webcore-rename:
1946         * Scripts/test-webkitpy:
1947         * Scripts/webkitdirs.pm:
1948         * Scripts/webkitpy/style/checker.py:
1949         * WebKitTestRunner/DerivedSources.pro:
1950         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1951         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1952
1953 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1954
1955         Reviewed by David Levin.
1956
1957         [chromium] remove obsolete createView method
1958         https://bugs.webkit.org/show_bug.cgi?id=52437
1959
1960         * DumpRenderTree/chromium/WebViewHost.cpp:
1961         (WebViewHost::createView):
1962         * DumpRenderTree/chromium/WebViewHost.h:
1963
1964 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1965
1966         Reviewed by Geoff Garen.
1967
1968         ShouldLoadResourceForFrame should use strings, not URLs.
1969         https://bugs.webkit.org/show_bug.cgi?id=52476
1970
1971         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1972         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1973         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1974
1975 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1976
1977         Reviewed by David Levin.
1978
1979         Add Tony Gentilcore as a reviewer
1980         https://bugs.webkit.org/show_bug.cgi?id=52480
1981
1982         * Scripts/webkitpy/common/config/committers.py:
1983
1984 2011-01-14  David Levin  <levin@chromium.org>
1985
1986         Reviewed by Eric Seidel.
1987
1988         check-webkit-style: _FunctionState should keep track of where the function name starts.
1989         https://bugs.webkit.org/show_bug.cgi?id=52454
1990
1991         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1992         _FunctionState and logic for setting it correctly.
1993         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1994
1995 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1996
1997         Reviewed by David Levin.
1998
1999         Add support to DumpRenderTree to use the GPU rather than software renderer
2000         https://bugs.webkit.org/show_bug.cgi?id=52333
2001
2002         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2003         (main):
2004         * Scripts/webkitpy/layout_tests/port/chromium.py:
2005         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2006
2007 2011-01-14  Tony Chang  <tony@chromium.org>
2008
2009         Reviewed by Kent Tamura.
2010
2011         [chromium] update fonts.conf to fix 6 linux tests in drt
2012         https://bugs.webkit.org/show_bug.cgi?id=52411
2013
2014         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2015             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2016
2017 2011-01-14  Eric Seidel  <eric@webkit.org>
2018
2019         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2020
2021         Reviewed by Adam Barth.
2022
2023         Fix when running Tools/Scripts/check-webkit-style without arguments.
2024         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2025
2026         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2027         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2028
2029 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2030
2031         Reviewed by David Levin.
2032
2033         Store the tempdir object in a variable so it doesn't get deleted too early.
2034         https://bugs.webkit.org/show_bug.cgi?id=51875
2035
2036         * Scripts/update-webkit-auxiliary-libs:
2037         * Scripts/update-webkit-support-libs:
2038
2039 2011-01-14  Eric Seidel  <eric@webkit.org>
2040
2041         Unreviewed.  Make it work in python 2.5.
2042
2043         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2044         https://bugs.webkit.org/show_bug.cgi?id=49158
2045
2046         * Scripts/webkitpy/common/checkout/api_unittest.py:
2047
2048 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2049
2050         Unreviewed, rolling out r75774.
2051         http://trac.webkit.org/changeset/75774
2052         https://bugs.webkit.org/show_bug.cgi?id=52431
2053
2054         gtk builds were broken (Requested by loislo2 on #webkit).
2055
2056         * Scripts/webkitpy/common/checkout/scm.py:
2057
2058 2011-01-14  David Levin  <levin@chromium.org>
2059
2060         Reviewed by Shinichiro Hamaji.
2061
2062         check-webkit-style: _FunctionState should detect pure functions.
2063         https://bugs.webkit.org/show_bug.cgi?id=52428
2064
2065         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2066         is a pure virtual function.
2067         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2068         virtual functions are correctly detected.
2069
2070 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2071
2072         Reviewed by Yury Semikhatsky.
2073
2074         Just small fix for problem with check-webkit-style.
2075         It just didn't work for this patch.
2076         Old code can't concatenate a list of strings with None.
2077
2078         * Scripts/webkitpy/common/checkout/scm.py:
2079
2080 2011-01-13  David Levin  <levin@chromium.org>
2081
2082         Reviewed by Shinichiro Hamaji.
2083
2084         check-webkit-style: _FunctionState should use Position to know where items are.
2085         https://bugs.webkit.org/show_bug.cgi?id=52424
2086
2087         * Scripts/webkitpy/style/checkers/cpp.py:
2088         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2089         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2090         did some minor clean-up.
2091         (*): Other changes are simply about converting to use the Position's in_FunctionState
2092         instead of line numbers.
2093         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2094         to verify the positions stored in _FunctionState.
2095
2096 2011-01-13  Eric Seidel  <eric@webkit.org>
2097
2098         Reviewed by David Levin.
2099
2100         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2101         https://bugs.webkit.org/show_bug.cgi?id=49158
2102
2103         This is not the most elegant, but it is a very safe fix to this bug.
2104         One advantage of catching ScriptError like this instead of adding a
2105         new added_or_modified_files or fixing all changed_files callers
2106         to use a more specific change_files variant, is that we catch
2107         all kinds of ScriptErrors which might cause our (non-essential)
2108         suggest-reviewers code to fail out.  This should make passing
2109         --suggest-reviewers to webkit-patch upload much more robust
2110         and may even make it possible for us to make it default.
2111
2112         The root of the problem here is that SCM.changed_files includes
2113         deleted ChangeLog paths (from moves, etc) which then when we ask
2114         SVN/Git for the contents of the file at that revision, the command
2115         errors out and Executive.run_command raises a ScriptError.
2116
2117         In the future we might fix this differently by making all current
2118         callers of chagned_files use a more specific method for requesting
2119         what types of changes they're interested in (adds, modifies, deletes, etc.)
2120
2121         * Scripts/webkitpy/common/checkout/api.py:
2122         * Scripts/webkitpy/common/checkout/api_unittest.py:
2123
2124 2011-01-13  Dan Bernstein  <mitz@apple.com>
2125
2126         Reviewed by Alexey Proskuryakov.
2127
2128         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2129         https://bugs.webkit.org/show_bug.cgi?id=52419
2130
2131         Allow to further control the behavior of the willSendRequest delegate callback by making it
2132         set a different URL in the new request.
2133
2134         * DumpRenderTree/LayoutTestController.cpp:
2135         (addURLToRedirectCallback): Added.
2136         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2137         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2138         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2139         * DumpRenderTree/LayoutTestController.h:
2140         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2141         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2142         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2143         change the URL in the new request to the redirect destination.
2144
2145 2011-01-13  Eric Seidel  <eric@webkit.org>
2146
2147         Reviewed by Mihai Parparita.
2148
2149         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2150         https://bugs.webkit.org/show_bug.cgi?id=52416
2151
2152         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2153         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2154
2155         I also added FIXMEs about the changed_files returning deleted files problem
2156         which is causing the other most common exception for suggest-reviewers
2157         (and is probably breaking sheriff-bots blame detection).
2158
2159         * Scripts/webkitpy/common/checkout/api.py:
2160         * Scripts/webkitpy/common/checkout/api_unittest.py:
2161         * Scripts/webkitpy/common/checkout/scm.py:
2162
2163 2011-01-13  Eric Seidel  <eric@webkit.org>
2164
2165         Reviewed by Adam Barth.
2166
2167         results archives from commit-queue are too large to upload
2168         https://bugs.webkit.org/show_bug.cgi?id=52405
2169
2170         * Scripts/webkitpy/common/system/filesystem.py:
2171         * Scripts/webkitpy/common/system/filesystem_mock.py:
2172         * Scripts/webkitpy/tool/commands/queues.py:
2173
2174 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2175
2176         Reviewed by Martin Robinson.
2177
2178         [gtk] Zero-sized font does not yet work
2179         https://bugs.webkit.org/show_bug.cgi?id=49793
2180
2181         Set minimum-font-size to 0 for the DRT.
2182
2183         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2184         (resetDefaultsToConsistentValues):
2185
2186 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2187
2188         Reviewed by Darin Adler.
2189
2190         Make old-run-webkit-tests more robust on buildbots
2191         https://bugs.webkit.org/show_bug.cgi?id=52364
2192
2193         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2194
2195 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2196
2197         Reviewed by Darin Adler.
2198
2199         Make old-run-webkit-tests more robust on buildbots
2200         https://bugs.webkit.org/show_bug.cgi?id=52364
2201
2202         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2203
2204 2011-01-13  Tony Chang  <tony@chromium.org>
2205
2206         Reviewed by Kent Tamura.
2207
2208         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2209         https://bugs.webkit.org/show_bug.cgi?id=52332
2210
2211         Forked Info.plist is not longer needed.
2212
2213         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2214
2215 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2216
2217         Reviewed by Timothy Hatcher.
2218
2219         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2220         to be passed directly to WebInspector.UIString
2221
2222         https://bugs.webkit.org/show_bug.cgi?id=52365
2223
2224         * Scripts/check-inspector-strings:
2225
2226 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2227
2228         Unreviewed, rolling out r74881.
2229         http://trac.webkit.org/changeset/74881
2230         https://bugs.webkit.org/show_bug.cgi?id=52357
2231
2232         The EFL builder has been red for days (Requested by abarth on
2233         #webkit).
2234
2235         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2236         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2237
2238 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2239
2240         Reviewed by David Levin.
2241
2242         Add beforeunload support to WebKitTestRunner
2243         https://bugs.webkit.org/show_bug.cgi?id=52353
2244         
2245         This makes a number of currently failing tests pass.
2246
2247         * WebKitTestRunner/TestController.cpp:
2248         (WTR::runBeforeUnloadConfirmPanel):
2249         (WTR::createOtherPage):
2250         (WTR::TestController::initialize):
2251
2252 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2253
2254         Reviewed by Sam Weinig.
2255
2256         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2257         https://bugs.webkit.org/show_bug.cgi?id=52330
2258
2259         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2260         a web process crash.
2261         * WebKitTestRunner/TestController.cpp:
2262         (WTR::TestController::initialize): Set up a processDidCrash
2263         callback.
2264         (WTR::TestController::processDidCrash): Report that the Web process
2265         crashed.
2266         * WebKitTestRunner/TestController.h:
2267
2268 2011-01-12  David Levin  <levin@chromium.org>
2269
2270         Reviewed by Shinichiro Hamaji.
2271
2272         check-webkit-style -- close_expression function doesn't work correctly.
2273         https://bugs.webkit.org/show_bug.cgi?id=52272
2274
2275         * Scripts/webkitpy/style/checkers/cpp.py:
2276         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2277         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2278         generally useful (for upcoming code changes).
2279         (close_expression): Changed to use Position for input and output.
2280         Also, fixed many bugs such as only working correctly for parenthesis,
2281         not working correctly if given an offset in a line and not finding
2282         the real closing element if there were multiple closing elements in
2283         the same line.
2284         (detect_functions): Adjusted due to the change in arguments for
2285         close_expression.
2286         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2287         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2288         two positions are the same.
2289         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2290         (CppStyleTest.test_close_expression): Added tests to catch the issues
2291         that were fixed.
2292
2293 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2294
2295         Unreviewed, rolling out r75576.
2296         http://trac.webkit.org/changeset/75576
2297         https://bugs.webkit.org/show_bug.cgi?id=52304
2298
2299         broke rebaseline-chromium-webkit-test (Requested by thakis on
2300         #webkit).
2301
2302         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2303         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2304         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2305         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2306         * Scripts/webkitpy/layout_tests/port/base.py:
2307         * Scripts/webkitpy/layout_tests/port/chromium.py:
2308         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2309         * Scripts/webkitpy/layout_tests/port/test.py:
2310         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2311         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2312         * Scripts/webkitpy/style/checkers/test_expectations.py:
2313         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2314
2315 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2316
2317         Reviewed by Darin Adler.
2318
2319         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2320         https://bugs.webkit.org/show_bug.cgi?id=52307
2321
2322         * Scripts/old-run-webkit-tests:
2323
2324 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2325
2326         Reviewed by Martin Robinson.
2327
2328         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2329         https://bugs.webkit.org/show_bug.cgi?id=50867
2330
2331         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2332         TestNetscapePlugin.cpp 
2333
2334         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2335         * Scripts/webkitdirs.pm:
2336
2337 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2338
2339         Reviewed by Pavel Feldman.
2340
2341         Add check-inspector-strings script.
2342
2343         https://bugs.webkit.org/show_bug.cgi?id=52295
2344
2345         * Scripts/check-inspector-strings: Added.
2346
2347 2011-01-12  Adam Roben  <aroben@apple.com>
2348
2349         Advertise the .testnetscape file extension on Windows
2350
2351         Fixes <http://webkit.org/b/52298>
2352         plugins/no-mime-with-valid-extension.html fails on Windows
2353
2354         Reviewed by Dan Bernstein.
2355
2356         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2357         FileExtents field to map the .testnetscape file extension to the
2358         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2359
2360 2011-01-12  Adam Barth  <abarth@webkit.org>
2361
2362         Reviewed by Eric Seidel.
2363
2364         Make webkit-patch support subdirectories for SVN checkouts
2365         https://bugs.webkit.org/show_bug.cgi?id=52261
2366
2367         os.relpath does not exist on Python 2.5, so we need to call our version
2368         of the API.
2369
2370         * Scripts/webkitpy/common/checkout/scm.py:
2371
2372 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2373
2374         Reviewed by Eric Seidel.
2375
2376         Close additional pages opened during a test once the test completes.
2377         https://bugs.webkit.org/show_bug.cgi?id=52276
2378
2379         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2380         (WTR::InjectedBundle::done):
2381
2382 2011-01-11  David Levin  <levin@chromium.org>
2383
2384         Reviewed by Eric Seidel.
2385
2386         Errors should be separated from the command line in bot messages.
2387         https://bugs.webkit.org/show_bug.cgi?id=52275
2388
2389         * Scripts/webkitpy/common/system/executive.py:
2390         (ScriptError.message_with_output): Added a newline to separate the command
2391         line from the errors.
2392         * Scripts/webkitpy/common/system/executive_unittest.py:
2393         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2394         paths in message_with_output.
2395
2396 2011-01-11  Eric Seidel  <eric@webkit.org>
2397
2398         Unreviewed.
2399
2400         commit-queue should know how to upload archived results (for test flakes or general failures)
2401         https://bugs.webkit.org/show_bug.cgi?id=52048
2402
2403         The zips are mostly empty due to forgetting -r.
2404         Expected diffs were not being pulled from the archive due
2405         to the archive having longer paths than I realized.
2406
2407         * Scripts/webkitpy/common/system/workspace.py:
2408         * Scripts/webkitpy/common/system/workspace_unittest.py:
2409         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2410         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2411
2412 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2413
2414         Reviewed by Ojan Vafai.
2415
2416         The current modifier parsing code in test_expectations is
2417         fragile and hard-coded, so it's not easy to understand the logic
2418         or easily add new types of modifiers (like GPU vs. CPU testing
2419         for graphics tests, or 32-bit vs. 64-bit differences).
2420
2421         This is the first of two patches that will add in more generic
2422         support and then eliminate the GPU-specific test expectations
2423         files for Chromium.
2424
2425         This patch adds two standalone objects for handling modifiers. The
2426         rules for interpreting modifiers, precedence, and conflicts are
2427         given in the docstring to the ModifierMatcher class, which
2428         returns ModifierMatchResult objects.
2429         
2430         This patch also adds routines to the Port interface and a
2431         default set of values in the base object, in order to obtain the
2432         values needed on a given test run. These values are then passed
2433         to the expectation parser. This also allows us to clean up the
2434         logic used to lint all of the different configurations in a
2435         single test_expectations.txt file.
2436
2437         The next patch will merge in the separate GPU expectations file.
2438
2439         https://bugs.webkit.org/show_bug.cgi?id=51222
2440
2441         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2442         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2443         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2444         * Scripts/webkitpy/layout_tests/port/base.py:
2445         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2446         * Scripts/webkitpy/layout_tests/port/chromium.py:
2447         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2448         * Scripts/webkitpy/layout_tests/port/test.py:
2449         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2450         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2451
2452 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2453
2454         Reviewed by Adam Barth.
2455
2456         Make webkit-patch support subdirectories for SVN checkouts
2457         https://bugs.webkit.org/show_bug.cgi?id=52261
2458
2459         * Scripts/webkitpy/common/checkout/scm.py:
2460         * Scripts/webkitpy/style_references.py:
2461         * Scripts/webkitpy/tool/main.py:
2462         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2463
2464 2011-01-11  Eric Seidel  <eric@webkit.org>
2465
2466         Unreviewed.
2467
2468         commit-queue should know how to upload archived results (for test flakes or general failures)
2469         https://bugs.webkit.org/show_bug.cgi?id=52048
2470
2471         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2472         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2473
2474         * Scripts/webkitpy/common/system/workspace.py:
2475         * Scripts/webkitpy/common/system/workspace_unittest.py:
2476         * Scripts/webkitpy/tool/commands/queues.py:
2477
2478 2011-01-11  Sam Weinig  <sam@webkit.org>
2479
2480         Roll r75474 back in.
2481
2482 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2483
2484         Reviewed by Kenneth Rohde Christiansen.
2485
2486         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2487         https://bugs.webkit.org/show_bug.cgi?id=51204
2488
2489         * QtTestBrowser/webpage.h:
2490         (QtNAMThread::QtNAMThread):
2491         (QtNAMThread::networkAccessManager):
2492         (QtNAMThread::run):
2493
2494 2011-01-11  Peter Varga  <pvarga@webkit.org>
2495
2496         Unreviewed.
2497
2498         Add myself to committers' list.
2499
2500         * Scripts/webkitpy/common/config/committers.py:
2501
2502 2011-01-11  Eric Seidel  <eric@webkit.org>
2503
2504         Reviewed by Adam Barth.
2505
2506         commit-queue should know how to upload archived results (for test flakes or general failures)
2507         https://bugs.webkit.org/show_bug.cgi?id=52048
2508
2509         Now the queue will always upload results.  Either the entire zip, or just
2510         the diffs.txt in the case of text failures.
2511
2512         This should make understanding flakes much easier, and paves the way
2513         for having the EWS run layout tests (and upload failures).
2514
2515         In order to upload .zip files I had to teach bugzilla.py to autodetect
2516         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2517         for .patch files, I have it add one before calling guess_type.
2518
2519         We may find that always uploading the whole zip instead of just the -diffs.txt
2520         file is preferable, but for now I'm keeping the old behavior because it makes
2521         quickly understanding text failures easy.
2522
2523         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2524         * Scripts/webkitpy/common/system/workspace.py: Added.
2525         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2526         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2527         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2528         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2529         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2530         * Scripts/webkitpy/tool/commands/queues.py:
2531         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2532
2533 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2534
2535         Unreviewed, rolling out r75464.
2536         http://trac.webkit.org/changeset/75464
2537         https://bugs.webkit.org/show_bug.cgi?id=52193
2538
2539         Followup rollout for 75474 (Requested by Ossy on #webkit).
2540
2541         * MiniBrowser/mac/BrowserWindowController.m:
2542         (-[BrowserWindowController awakeFromNib]):
2543         * MiniBrowser/win/BrowserView.cpp:
2544         (BrowserView::create):
2545         * WebKitTestRunner/TestController.cpp:
2546         (WTR::createOtherPage):
2547         (WTR::TestController::initialize):
2548
2549 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2550
2551         Reviewed by Csaba Osztrogonác.
2552
2553         [Qt] Baseline qt_minimal configuration
2554         https://bugs.webkit.org/show_bug.cgi?id=51313
2555
2556         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2557         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2558         QT_NO_UNDOSTACK guard.
2559
2560         * QtTestBrowser/launcherwindow.cpp:
2561         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2562         guards.
2563         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2564         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2565         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2566         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2567
2568         * QtTestBrowser/launcherwindow.h:
2569         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2570         * QtTestBrowser/locationedit.h: Ditto.
2571
2572         * QtTestBrowser/mainwindow.cpp:
2573         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2574         QT_NO_UNDOSTACK guards.
2575         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2576         (MainWindow::changeLocation): Ditto.
2577         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2578         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2579
2580         * QtTestBrowser/webpage.cpp:
2581         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2582         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2583
2584         * QtTestBrowser/webview.cpp:
2585         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2586         (WebViewGraphicsBased::animatedYFlip): Ditto.
2587
2588 2011-01-10  Sam Weinig  <sam@webkit.org>
2589
2590         Fix build.
2591
2592         * MiniBrowser/mac/BrowserWindowController.m:
2593         (-[BrowserWindowController awakeFromNib]):
2594         * MiniBrowser/win/BrowserView.cpp:
2595         (BrowserView::create):
2596         * WebKitTestRunner/TestController.cpp:
2597         (WTR::createOtherPage):
2598         (WTR::TestController::initialize):
2599
2600 2011-01-10  Eric Seidel  <eric@webkit.org>
2601
2602         Reviewed by Ojan Vafai.
2603
2604         style-queue messages are way too long for big patches
2605         https://bugs.webkit.org/show_bug.cgi?id=52161
2606
2607         We definitely could build much fancier list-to-string-with-limit functions
2608         but this should be sufficient for our needs at the moment.
2609
2610         * Scripts/webkitpy/common/system/executive.py:
2611         * Scripts/webkitpy/common/system/executive_unittest.py:
2612
2613 2011-01-10  Tony Chang  <tony@chromium.org>
2614
2615         Unreviewed, rolling out r75398.
2616         http://trac.webkit.org/changeset/75398
2617         https://bugs.webkit.org/show_bug.cgi?id=52008
2618
2619         Some layout tests are crashing on Chromium Win.
2620
2621         * DumpRenderTree/chromium/WebViewHost.cpp:
2622         (WebViewHost::updatePaintRect):
2623         * DumpRenderTree/chromium/WebViewHost.h:
2624
2625 2011-01-10  Adam Roben  <aroben@apple.com>
2626
2627         Roll out r75392
2628
2629         It isn't needed now that r75289 has been rolled out.
2630
2631         * Scripts/run-javascriptcore-tests:
2632
2633 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2634
2635         Reviewed by Anders Carlsson.
2636
2637         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2638         https://bugs.webkit.org/show_bug.cgi?id=52160
2639
2640         * WebKitTestRunner/mac/TestControllerMac.mm:
2641         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2642         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2643         anyway.
2644
2645 2011-01-10  Tony Chang  <tony@chromium.org>
2646
2647         Reviewed by Mihai Parparita.
2648
2649         [chromium] fix for animated gif layout tests
2650         https://bugs.webkit.org/show_bug.cgi?id=52008
2651
2652         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2653             to trigger gif animations.
2654         (WebViewHostPaintTask::WebViewHostPaintTask):
2655         (WebViewHostPaintTask::runIfValid):
2656         (WebViewHost::updatePaintRect):
2657         * DumpRenderTree/chromium/WebViewHost.h:
2658         (WebViewHost::taskList):
2659
2660 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2661
2662         Reviewed by Xan Lopez.
2663
2664         [GTK] Fix gtk2 compilation for master
2665         https://bugs.webkit.org/show_bug.cgi?id=51885
2666
2667         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2668         (createBitmapContextFromWebView): Replaced the old
2669         gdk_drawable_get_size with gdk_pixmap_get_size.
2670
2671 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2672
2673         Reviewed by Laszlo Gombos.
2674
2675         [WINCE] Reenable NPAPI after r75203
2676         https://bugs.webkit.org/show_bug.cgi?id=52109
2677
2678         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2679         it with !isEfl(), because EFL port does not support NPAPI (yet).
2680
2681         * Scripts/build-webkit:
2682
2683 2011-01-10  Adam Roben  <aroben@apple.com>
2684
2685         Skip some asserting JS tests
2686
2687         See <http://webkit.org/b/52156>.
2688
2689         * Scripts/run-javascriptcore-tests:
2690
2691 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2692
2693         Reviewed by Xan Lopez.
2694
2695         [GTK] build-webkit disable Blob support via arguments passed to automake
2696         https://bugs.webkit.org/show_bug.cgi?id=52097
2697
2698         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2699         build-webkit.
2700
2701 2011-01-10  Adam Roben  <aroben@apple.com>
2702
2703         Use the same name and description for TestNetscapePlugin on Windows and
2704         Mac
2705
2706         Fixes <http://webkit.org/b/52151>
2707         fast/frames/iframe-reparenting-plugins.html fails on Windows
2708
2709         Reviewed by Steve Falkenburg.
2710
2711         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2712         the name and description from Mac's Info.plist.
2713
2714 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2715
2716         Reviewed by Laszlo Gombos.
2717
2718         [Qt][WK2] Guard gcc-specific syntax
2719
2720         Non-gcc based compliers choke on the "-include"
2721         syntax for preinclude, place guard around it.
2722
2723         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2724         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2725
2726 2011-01-10  Andreas Kling  <kling@webkit.org>
2727
2728         Reviewed by Simon Hausmann.
2729
2730         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2731         https://bugs.webkit.org/show_bug.cgi?id=52111
2732
2733         When getting a createNewPage() callback from QWKPage, create the
2734         new page with the same QWKContext as the page that is passed to
2735         the callback.
2736
2737         * MiniBrowser/qt/BrowserView.h:
2738         * MiniBrowser/qt/BrowserWindow.cpp:
2739         (newPageFunction):
2740         (BrowserWindow::BrowserWindow):
2741         * MiniBrowser/qt/BrowserWindow.h:
2742
2743 2011-01-10  Andreas Kling  <kling@webkit.org>
2744
2745         Reviewed by Kenneth Rohde Christiansen.
2746
2747         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2748
2749         BrowserView set its own useless createNewPage() callback on QWKPage.
2750         This was immediately overridden by BrowserWindow anyway, so remove
2751         the BrowserView one.
2752
2753         * MiniBrowser/qt/BrowserView.cpp:
2754         (BrowserView::BrowserView):
2755
2756 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2757
2758         Reviewed by Jeremy Orlow.
2759
2760         [Chromium] Remove non-client-based Geolocation code
2761         https://bugs.webkit.org/show_bug.cgi?id=50921
2762
2763         * DumpRenderTree/chromium/LayoutTestController.cpp:
2764         (LayoutTestController::setGeolocationPermission):
2765         (LayoutTestController::setMockGeolocationPosition):
2766         (LayoutTestController::setMockGeolocationError):
2767         * DumpRenderTree/chromium/WebViewHost.cpp:
2768         (WebViewHost::geolocationClientMock):
2769         (WebViewHost::reset):
2770         * DumpRenderTree/chromium/WebViewHost.h:
2771
2772 2011-01-10  Eric Seidel  <eric@webkit.org>
2773
2774         Reviewed by Adam Barth.
2775
2776         Commit bot tried to land r? cq+ patch
2777         https://bugs.webkit.org/show_bug.cgi?id=36638
2778
2779         It should now be possible to post a patch with r? and cq+ and the
2780         commit-queue will correctly wait for the r+ before attempting to land the patch.
2781         (This was a feature requested by several users.)
2782
2783         One caveat: We don't actually reject r-, cq+ patches from the queue
2784         (we just ignore them), but I think that's OK for now.
2785
2786         I also noticed that setting r- once a commit-queue node had grabbed
2787         a patch would not properly cancel the landing.  That's fixed and
2788         tested in this patch.
2789
2790         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2791         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2792         * Scripts/webkitpy/tool/bot/feeders.py:
2793         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2794
2795 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2796
2797         Reviewed by Kenneth Rohde Christiansen.
2798
2799         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2800         https://bugs.webkit.org/show_bug.cgi?id=51934
2801
2802         When accessing the network from the destructor of QWebPage, the network access manager
2803         was already deleted because the object WebPage was already destructed.
2804
2805         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2806         The object is now destructed in the destructor of QObject.
2807
2808         * QtTestBrowser/webpage.cpp:
2809         (WebPage::WebPage):
2810         (WebPage::setQnamThreaded):
2811         * QtTestBrowser/webpage.h:
2812         (QtNAMThread::QtNAMThread):
2813
2814 2011-01-08  Eric Seidel  <eric@webkit.org>
2815
2816         Reviewed by Ojan Vafai.
2817
2818         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2819         https://bugs.webkit.org/show_bug.cgi?id=52067
2820
2821         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2822         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2823
2824         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2825
2826 2011-01-08  Eric Seidel  <eric@webkit.org>
2827
2828         Reviewed by Mihai Parparita.
2829
2830         commit-queue hangs when the ChangeLog diff is bad
2831         https://bugs.webkit.org/show_bug.cgi?id=52072
2832
2833         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2834         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2835
2836 2011-01-08  Adam Barth  <abarth@webkit.org>
2837
2838         Teach svn-apply how to re-write WebCore to Source/WebCore.
2839
2840         * Scripts/VCSUtils.pm:
2841
2842 2011-01-07  Adam Barth  <abarth@webkit.org>
2843
2844         Rubber-stamped by Eric Seidel.
2845
2846         Move WebCore to Source
2847         https://bugs.webkit.org/show_bug.cgi?id=52050
2848
2849         Update the tools to understand WebCore's new location.
2850
2851         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2852         * DumpRenderTree/wscript:
2853         * GNUmakefile.am:
2854         * Scripts/build-webkit:
2855         * Scripts/do-file-rename:
2856         * Scripts/do-webcore-rename:
2857         * Scripts/generate-qt-inspector-resource:
2858         * Scripts/prepare-ChangeLog:
2859         * Scripts/run-bindings-tests:
2860         * Scripts/update-iexploder-cssproperties:
2861         * Scripts/update-sources-list.py:
2862         * Scripts/update-webkit-localizable-strings:
2863         * Scripts/webkitdirs.pm:
2864         * Scripts/webkitpy/common/config/build.py:
2865         * Scripts/webkitpy/common/config/build_unittest.py:
2866         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2867         * Scripts/webkitpy/style/checker.py:
2868         * Scripts/webkitpy/style/checker_unittest.py:
2869         * WebKitTestRunner/DerivedSources.pro:
2870         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2871         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2872         * wx/browser/wscript:
2873         * wx/build/settings.py:
2874
2875 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2876
2877         Reviewed by Sam Weinig.
2878
2879         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2880         https://bugs.webkit.org/show_bug.cgi?id=52086
2881
2882         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2883         (WTR::InjectedBundle::didReceiveMessage):
2884         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2885         (WTR::LayoutTestController::notifyDone):
2886         * WebKitTestRunner/TestController.cpp:
2887         (WTR::TestController::resetStateToConsistentValues):
2888         (WTR::TestController::run):
2889
2890 2011-01-07  James Robinson  <jamesr@chromium.org>
2891
2892         Revert "Implement mozilla's animationTime property"
2893         https://bugs.webkit.org/show_bug.cgi?id=51952
2894
2895         This approach isn't quite right.
2896
2897         * DumpRenderTree/chromium/WebViewHost.cpp:
2898         (WebViewHost::paintInvalidatedRegion):
2899
2900 2011-01-07  Adam Roben  <aroben@apple.com>
2901
2902         Build master fix
2903
2904         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2905         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2906
2907 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2908
2909         Reviewed by Csaba Osztrogonác.
2910
2911         run-qtwebkit-tests should be able to kill a testsuite.
2912
2913         Add new option in the script that can setup a timeout for a test.
2914         If the test execution takes more then specified time then the test
2915         would be terminated.
2916
2917         [Qt] run-qtwebkit-tests needs timeout
2918         https://bugs.webkit.org/show_bug.cgi?id=51894
2919
2920         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2921         * Scripts/run-qtwebkit-tests:
2922
2923 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2924
2925         Unreviewed fix after r75233.
2926
2927         Based on idea from Eric Seidel.
2928
2929         Add remote zip file handling to webkitpy.
2930         https://bugs.webkit.org/show_bug.cgi?id=50901
2931
2932         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2933
2934 2011-01-07  Shane Stephens  <shanestephens@google.com>
2935
2936         Reviewed by Eric Seidel.
2937
2938         svn-apply: should support git binary delta diffs
2939         https://bugs.webkit.org/show_bug.cgi?id=38864
2940
2941         * Scripts/VCSUtils.pm:
2942         * Scripts/svn-apply:
2943
2944 2011-01-06  Julie Parent  <jparent@chromium.org>
2945
2946         Reviewed by Eric Seidel.
2947
2948         Test Result Server not removing old results.
2949         https://bugs.webkit.org/show_bug.cgi?id=52012
2950
2951         * TestResultServer/model/jsonresults.py:
2952         Fix off-by-one: Truncate if >= num_runs, not just >.
2953         * TestResultServer/model/jsonresults_unittest.py:
2954         Add unit test to test that merging in a new result with the same value
2955         as the last result causes previous result to fall off.
2956
2957 2011-01-06  James Kozianski  <koz@chromium.org>
2958
2959         Reviewed by Mihai Parparita.
2960
2961         Add classes to provide a consistent interface to a set of files.
2962         https://bugs.webkit.org/show_bug.cgi?id=50901
2963
2964         These classes allow us to write code that is agnostic to whether a
2965         particular set of files resides in a local directory or in a zip file
2966         on a remote machine.
2967
2968         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2969         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2970         * Scripts/webkitpy/common/system/fileset.py: Added.
2971         * Scripts/webkitpy/common/system/filesystem.py:
2972         * Scripts/webkitpy/common/system/filesystem_mock.py:
2973         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2974         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2975
2976 2011-01-06  Eric Seidel  <eric@webkit.org>
2977
2978         Reviewed by Adam Barth.
2979
2980         NetworkTransaction should log the url it is retrying
2981         https://bugs.webkit.org/show_bug.cgi?id=52043
2982
2983         * Scripts/webkitpy/common/net/networktransaction.py:
2984         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2985
2986 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2987
2988         Windows build fix.
2989         Import os before using it.
2990
2991         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2992
2993 2011-01-06  Eric Seidel  <eric@webkit.org>
2994
2995         Reviewed by Adam Barth.
2996
2997         StyleQueue fails to report errors when patches have many files
2998         https://bugs.webkit.org/show_bug.cgi?id=52042
2999
3000         This is one of at least two errors preventing style error reporting at the moment.
3001         When we moved to passing the list of files to check explicitly,
3002         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3003         We could change the type of the QueueStatus.message type, or we could
3004         just teach statusserver.py how to clamp values (and warn when it does).
3005         I chose the latter path.
3006
3007         * Scripts/webkitpy/common/net/statusserver.py:
3008
3009 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3010
3011         Reviewed by Stephanie Lewis.
3012         
3013         Fix syntax error in script.
3014
3015         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3016         https://bugs.webkit.org/show_bug.cgi?id=51996
3017
3018         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3019
3020 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3021
3022         Unreviewed, fixing WinCE build after r75196.
3023
3024         WinCE port does not (yet) support NPAPI.
3025
3026         * Scripts/build-webkit:
3027
3028 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3029
3030         Reviewed by Darin Adler.
3031
3032         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3033         https://bugs.webkit.org/show_bug.cgi?id=52015
3034
3035         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3036         after the platform has been detected, otherwise the script will
3037         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3038         detection.
3039
3040 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3041
3042         Reviewed by Eric Seidel.
3043
3044         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3045         https://bugs.webkit.org/show_bug.cgi?id=51346
3046
3047         * Scripts/build-webkit:
3048
3049 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3050
3051         Reviewed by Adam Roben.
3052
3053         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3054         https://bugs.webkit.org/show_bug.cgi?id=51996
3055         
3056         After the configuration directory change, we were archiving the incorrect directory for
3057         build product, so we were running tests on the wrong binaries.
3058         
3059         This change archives the correct directory, and also unarchives it into a configuration-
3060         specific directory.
3061
3062         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3063         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3064
3065 2011-01-06  Eric Seidel  <eric@webkit.org>
3066
3067         Reviewed by Mihai Parparita.
3068
3069         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3070         https://bugs.webkit.org/show_bug.cgi?id=52002
3071
3072         See an example of this here:
3073         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3074
3075         It's due to the fact that we pass around TestFailure() instance
3076         objects and yet expect them to all compare to be the same.
3077
3078         This is bad.  We should either have shared instances of these values
3079         or we should just pass around the class names.  There are already hacks
3080         in place to make TestFailure objects pass equality tests, I just added
3081         a __hash__ implementation so they can be used in sets as expected.
3082
3083         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3084         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3085
3086 2011-01-06  Evan Martin  <evan@chromium.org>
3087
3088         Reviewed by Tony Chang.
3089
3090         [gdb] handle inaccessible memory and UChar*
3091         https://bugs.webkit.org/show_bug.cgi?id=52003
3092
3093         To pretty-print a UChar*, we just grope around in the memory
3094         looking for a terminating NUL.  We need to handle the exception
3095         that can occur when we poke into an invalid location.
3096
3097         Additionally, the logic for choosing which pretty-printer would
3098         early return before hitting the point where we'd use the UChar*
3099         printer.  (Did this ever work?  How did it regress?)
3100
3101         * gdb/webkit.py:
3102
3103 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3104
3105         Reviewed by Ada Chan.
3106
3107         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3108         https://bugs.webkit.org/show_bug.cgi?id=51969
3109         
3110         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3111
3112         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3113         (WTR::InjectedBundlePage::InjectedBundlePage):
3114         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3115         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3116
3117 2011-01-06  James Robinson  <jamesr@chromium.org>
3118
3119         Reviewed by Simon Fraser.
3120
3121         Implement mozilla's animationTime property
3122         https://bugs.webkit.org/show_bug.cgi?id=51952
3123
3124         Chromium DRT support for webkitAnimationTime.
3125
3126         * DumpRenderTree/chromium/WebViewHost.cpp:
3127         (WebViewHost::paintInvalidatedRegion):
3128
3129 2011-01-06  Julie Parent  <jparent@chromium.org>
3130
3131         Reviewed by Tony Chang.
3132
3133         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3134         https://bugs.webkit.org/show_bug.cgi?id=51217
3135
3136         * TestResultServer/model/jsonresults.py:
3137         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3138         Adds missing documentation.
3139         * TestResultServer/model/jsonresults_unittest.py:
3140         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3141         Update test_merge to take a number of builds to truncate at.
3142
3143 2011-01-06  Adam Barth  <abarth@webkit.org>
3144
3145         Reviewed by Eric Seidel.
3146
3147         The EWS should log outside of the working directory
3148         https://bugs.webkit.org/show_bug.cgi?id=51986
3149
3150         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3151         script, which will actually clean the working copy back to a pristine
3152         state instead of leaving untracked directories and ignored files.
3153
3154         * Scripts/webkitpy/tool/commands/queues.py:
3155         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3156
3157 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3158
3159         Windows build fix.
3160         Back out attempted change to built-product-archive.
3161
3162         * BuildSlaveSupport/built-product-archive:
3163
3164 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3165
3166         Windows build fix.
3167         Include configuration name when unpacking a build archive.
3168
3169         Needed, since we split Windows build results into configuration-specific directories
3170         under WebKitOutputDir.
3171
3172         * BuildSlaveSupport/built-product-archive:
3173
3174 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3175
3176         Reviewed by Darin Adler.
3177
3178         Debug and Release builds on Windows clobber each other
3179         https://bugs.webkit.org/show_bug.cgi?id=49185
3180
3181         Changes the structure of WebKitBuild build products directory so we
3182         completely separate each build configuration into independent directories.
3183         
3184         Although we previously had per-configuration directories for obj, this change adds
3185         per-configuration directories for bin, lib, obj, and include. Each configuration's
3186         build products are stored within a directory inside of WebKitBuild.
3187         
3188         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3189         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3190
3191         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3192         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3193         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3194         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3195         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3196         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3197         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3198         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3199         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3200         * FindSafari/FindSafari.vcproj:
3201         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3202         * MiniBrowser/MiniBrowserPostBuild.cmd:
3203         * MiniBrowser/MiniBrowserPreBuild.cmd:
3204         * Scripts/webkitdirs.pm:
3205         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3206         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3207         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3208         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3209         * TestWebKitAPI/win/copy-resources.cmd:
3210         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3211         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3212         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3213         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3214         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3215         * WebKitTestRunner/win/InjectedBundle.vcproj:
3216         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3217         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3218         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3219         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3220         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3221         * WinLauncher/WinLauncherCommon.vsprops:
3222         * WinLauncher/WinLauncherPostBuild.cmd:
3223         * WinLauncher/WinLauncherPreBuild.cmd:
3224
3225 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3226
3227         Reviewed by Ariya Hidayat.
3228
3229         [Qt] TestNetscapePlugin doesn't link on OS X
3230         https://bugs.webkit.org/show_bug.cgi?id=51948
3231
3232         Only add a dependency on libX11 on X11 systems
3233
3234         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3235
3236 2011-01-05  Jeff Miller  <jeffm@apple.com>
3237
3238         Reviewed by Adam Roben.
3239
3240         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3241         https://bugs.webkit.org/show_bug.cgi?id=51970
3242
3243         * Scripts/webkitpy/style/checker.py:
3244         Add -readability/naming for WebKit2 C API directories.
3245
3246 2011-01-05  Eric Seidel  <eric@webkit.org>
3247
3248         Unreviewed, just fixing one more log error from my previous python patch.
3249
3250         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3251         https://bugs.webkit.org/show_bug.cgi?id=51802
3252
3253         webkit-patch failure-reason was logging about parsing errors
3254         due to my misunderstanding of how BeautifulSoup.findAll worked.
3255
3256         Fixed, and added a unit test.
3257
3258         * Scripts/webkitpy/common/net/layouttestresults.py:
3259         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3260
3261 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3262
3263         Reviewed by Kenneth Rohde Christiansen.
3264
3265         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3266         https://bugs.webkit.org/show_bug.cgi?id=51951
3267
3268         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3269         to create new window from WebKit.
3270
3271         * MiniBrowser/qt/BrowserWindow.cpp:
3272         (newPageFunction):
3273         (BrowserWindow::BrowserWindow):
3274         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3275         (BrowserWindow::newWindow):
3276         (BrowserWindow::updateUserAgentList):
3277         (BrowserWindow::showUserAgentDialog):
3278         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3279         define the type of the backing store used for new windows.
3280         * MiniBrowser/qt/main.cpp:
3281         (main):
3282
3283 2011-01-05  Eric Seidel  <eric@webkit.org>
3284
3285         Reviewed by Ojan Vafai.
3286
3287         commit-queue should report failure type when reporting flaky tests
3288         https://bugs.webkit.org/show_bug.cgi?id=51900
3289
3290         This patch was a ridiculous amount of plumbing.  In the end I like
3291         the NRWT-style TestResult class even less.  But now we're passing
3292         a list of TestResult objects from the queue to the FlakyTestReporter.
3293         Thus the FlakyTestReporter can more easily report what type of failure
3294         occurred.
3295
3296         In the process, I found that I was not alone in finding TestResult
3297         cumbersome to use.  A bunch of code was trying to create a TestResult
3298         object with default values.  However since the constructor didn't make
3299         this easy, some places were getting it wrong (including the TestResult unit test)!
3300         I've fixed the TestResult constructor to have default values for non-essential
3301         arguments.
3302
3303         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3304         * Scripts/webkitpy/common/net/layouttestresults.py:
3305         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3306         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3307         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3308         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3309         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3310         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3311         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3312         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3313         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3314         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3315         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3316         * Scripts/webkitpy/tool/commands/queues.py:
3317         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3318
3319 2011-01-05  Eric Seidel  <eric@webkit.org>
3320
3321         Unreviewed.
3322
3323         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3324         https://bugs.webkit.org/show_bug.cgi?id=51802
3325
3326         Add another unit test to cover a previously missing import.
3327
3328         * Scripts/webkitpy/common/net/layouttestresults.py:
3329         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3330
3331 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3332
3333         Reviewed by David Levin.
3334
3335         Add mihaip@chromium.org as a reviewer
3336         https://bugs.webkit.org/show_bug.cgi?id=51966
3337         
3338         Add myself as a reviewer.
3339
3340         * Scripts/webkitpy/common/config/committers.py:
3341
3342 2011-01-05  James Simonsen  <simonjam@chromium.org>
3343
3344         Unreviewed. Adding myself to the list of committers.
3345
3346         * Scripts/webkitpy/common/config/committers.py:
3347
3348 2011-01-05  Eric Seidel  <eric@webkit.org>
3349
3350         Unreviewed.
3351
3352         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3353         https://bugs.webkit.org/show_bug.cgi?id=51802
3354
3355         Fix two exceptions seen on the bots after my original commit.
3356
3357         * Scripts/webkitpy/common/net/layouttestresults.py:
3358         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3359
3360 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3361
3362         Reviewed by Andreas Kling.
3363
3364         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3365         https://bugs.webkit.org/show_bug.cgi?id=51750
3366
3367         * QtTestBrowser/main.cpp:
3368         (LauncherApplication::handleUserOptions):
3369          Local storage settings can be enable form command line arguments for
3370          QtTestBrowser.
3371
3372 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3373
3374         Reviewed by Martin Robinson.
3375
3376         GTK: AX: DRT needs to use correct root object method.
3377         https://bugs.webkit.org/show_bug.cgi?id=51911
3378
3379         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3380         (AccessibilityController::rootElement):
3381
3382 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3383
3384         Rubber-stamped by Csaba Osztrogonác.
3385
3386         Based on idea from Péter Gál.
3387
3388         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3389
3390 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3391
3392         Reviewed by Adam Barth.
3393
3394         sheriff-bot should be able to do multi-revision rollouts
3395         https://bugs.webkit.org/show_bug.cgi?id=51176
3396
3397         * Scripts/webkitpy/tool/bot/irc_command.py:
3398         * Scripts/webkitpy/tool/bot/sheriff.py:
3399         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3400
3401 2011-01-05  Eric Seidel  <eric@webkit.org>
3402
3403         Reviewed by Adam Barth.
3404
3405         queues.webkit.org should have per-bot status pages
3406         https://bugs.webkit.org/show_bug.cgi?id=51906
3407
3408         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3409         statuses from a single queue.  Now that we have many bots servicing
3410         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3411         you care about scroll off the end of the 15-message limit on the main page.
3412
3413         Eventually we should probably rename /queue-status to /queue or /queues,
3414         but that's fodder for another patch.
3415
3416         * QueueStatusServer/handlers/queuestatus.py:
3417         * QueueStatusServer/index.yaml:
3418         * QueueStatusServer/main.py:
3419         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3420          - This probably should use a custom filter instead of hard-coding
3421            the URL scheme here, but I couldn't figure out how to easily
3422            create such a filter.  Most filters work with "strings" so we can't
3423            pass the status object.  We could add a method to the status
3424            object and call that, but that seemed a bit strange too.
3425         * QueueStatusServer/templates/queuestatus.html:
3426
3427 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3428
3429         Unreviewed. Adding myself to the list of committers.
3430
3431         * Scripts/webkitpy/common/config/committers.py:
3432
3433 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3434
3435         Reviewed by David Levin.
3436
3437         check-webkit-style treated some macros with parentheses after #elif as function calls
3438         https://bugs.webkit.org/show_bug.cgi?id=51695
3439
3440         Ingore function call space checking in any preprocessor directives
3441         (things starting with #). Change search() to match() because 
3442         preprocessor directives are supposed to be in the beginning of lines.
3443
3444         * Scripts/webkitpy/style/checkers/cpp.py:
3445         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3446
3447 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3448
3449         Reviewed by Tony Chang.
3450
3451         Change the --multi-load test option to --stress-opt
3452         https://bugs.webkit.org/show_bug.cgi?id=50751
3453
3454         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3455         (runTest):
3456         (main):
3457         * DumpRenderTree/chromium/TestShell.cpp:
3458         (TestShell::TestShell):
3459         * DumpRenderTree/chromium/TestShell.h:
3460         (TestShell::stressOpt):
3461         (TestShell::setStressOpt):
3462         (TestShell::stressDeopt):
3463         (TestShell::setStressDeopt):
3464         (TestShell::javaScriptFlags):
3465         (TestShell::setJavaScriptFlags):
3466         * Scripts/webkitpy/layout_tests/port/chromium.py:
3467         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3468
3469 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3470
3471         Reviewed by Sam Weinig.
3472
3473         WK2: Support Accessibility
3474         https://bugs.webkit.org/show_bug.cgi?id=51859
3475
3476         Use rootObject() method to get top of accessibility tree.
3477
3478         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3479         (AccessibilityController::focusedElement):
3480         (AccessibilityController::rootElement):
3481
3482 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3483
3484         Reviewed by Darin Adler.
3485
3486         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3487         https://bugs.webkit.org/show_bug.cgi?id=51846
3488
3489         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3490         back to GRefPtr.
3491
3492 2011-01-04  Zhe Su  <suzhe@chromium.org>
3493
3494         Reviewed by Kenneth Russell.
3495
3496         Fix insertText, setMarkedText and unmarkText methods of
3497         TextInputController to call corresponding methods of WebKit::WebView
3498         rather than WebKit::WebFrame. This change matches the behavior of
3499         chromium browser.
3500         insertText corresponds to WebView::confirmComposition(text)
3501         setMarkedText corresponds to WebView::setComposition(...)
3502         unmarkText corresponds to WebView::confirmComposition()
3503         https://bugs.webkit.org/show_bug.cgi?id=51693
3504
3505         * DumpRenderTree/chromium/TextInputController.cpp:
3506         (TextInputController::insertText):
3507         (TextInputController::setMarkedText):
3508         (TextInputController::unmarkText):
3509
3510 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3511
3512         Reviewed by Laszlo Gombos.
3513
3514         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3515
3516         On Symbian productDir points to the source directory. Removing all the
3517         empty files from the productDir directory corrupts the svn repository.
3518
3519         * Scripts/build-webkit:
3520
3521 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3522
3523         Reviewed by Adam Barth.
3524
3525         [Qt] Add SelectAll option to the context menu for the editor
3526         https://bugs.webkit.org/show_bug.cgi?id=50049
3527
3528         Set shortcut for the SelectAll action.
3529
3530         * QtTestBrowser/mainwindow.cpp:
3531         (MainWindow::buildUI):
3532
3533 2011-01-03  David Levin  <levin@chromium.org>
3534
3535         Reviewed by Eric Seidel.
3536
3537         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3538         https://bugs.webkit.org/show_bug.cgi?id=51842
3539
3540         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3541         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3542
3543 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3544
3545         Reviewed by David Kilzer.
3546
3547         [WINCE] Adds a build slave.
3548         https://bugs.webkit.org/show_bug.cgi?id=50523
3549
3550         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
3551         entry for a release build of the WinCE port.
3552         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
3553         flag to build the WinCE port.
3554
3555 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3556
3557         Reviewed by David Kilzer.
3558
3559         Add WinCE support to build-webkit
3560         https://bugs.webkit.org/show_bug.cgi?id=51642
3561
3562         * Scripts/build-webkit:
3563         * Scripts/webkitdirs.pm:
3564
3565 2011-01-03  Eric Seidel  <eric@webkit.org>
3566
3567         Reviewed by Adam Barth.
3568
3569         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3570         https://bugs.webkit.org/show_bug.cgi?id=51802
3571
3572         I'm not the biggest fan of the test_failures or test_results classes,
3573         but it's better to have one shared set of classes, than separate ones
3574         for new vs. old run-webkit-test result handling.
3575
3576         This moves the ORWT results class "LayoutTestResults" over to using
3577         TestResult and TestFailure classes, making it easy for us to
3578         make all our sheriff-bot and other webkitpy code NRWT ready.
3579
3580         This also makes it a trivial patch to generate results.json information
3581         from ORWT results.html files (for flaky test analysis, etc.) as well
3582         as making it a one-liner to report test failure types when the
3583         commit-queue sees flaky tests.
3584
3585         This patch tried not to add new functionality, but only to replace
3586         the guts of LayoutTestResults, while adding unit tests and hoping
3587         not to break anything.
3588
3589         I also moved callers which assumed User.prompt* were static/class methods
3590         to using them as instance methods (since we'll eventually want to make them such).
3591
3592         In the process of re-writing things, I broke the rebaseline command, so I wrote
3593         a unit test to catch my breakage were I do do so again in the future.
3594
3595         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3596         * Scripts/webkitpy/common/net/layouttestresults.py:
3597         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3598         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3599         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3600         * Scripts/webkitpy/tool/commands/queries.py:
3601         * Scripts/webkitpy/tool/commands/rebaseline.py:
3602         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3603         * Scripts/webkitpy/tool/mocktool.py:
3604
3605 2011-01-03  Adam Barth  <abarth@webkit.org>
3606
3607         Reviewed by Simon Fraser.
3608
3609         webkit-patch shouldn't waste time cleaning a working directory that's already clean
3610         https://bugs.webkit.org/show_bug.cgi?id=51840
3611
3612         * Scripts/webkitpy/common/checkout/scm.py:
3613
3614 2011-01-03  Adam Barth  <abarth@webkit.org>
3615
3616         Reviewed by Simon Fraser.
3617
3618         webkit-patch should only hide update output if --quiet
3619         https://bugs.webkit.org/show_bug.cgi?id=51838
3620
3621         As requested by smfr.
3622
3623         * Scripts/webkitpy/tool/steps/update.py:
3624
3625 2011-01-03  Adam Barth  <abarth@webkit.org>
3626
3627         Reviewed by David Levin.
3628
3629         commit-queue shouldn't reject patches twice if two bots process the same patch
3630         https://bugs.webkit.org/show_bug.cgi?id=51805
3631
3632         Before raising an error, we first check whether the patch is still in
3633         the commit-queue.  This check is still racy, of course, but the time
3634         window is much smaller.
3635
3636         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3637
3638 2011-01-03  Sam Weinig  <sam@webkit.org>
3639
3640         Reviewed by Anders Carlsson.
3641
3642         Make run-api-tests less chatty.
3643         https://bugs.webkit.org/show_bug.cgi?id=51831
3644
3645         - Make script quiet by default and add --verbose option (replacing --quiet).
3646         - When not verbose, pipe stdout and stderr to devnull.
3647
3648         * Scripts/run-api-tests:
3649
3650 2011-01-03  Pratik Solanki  <psolanki@apple.com>
3651
3652         Unreviewed. Adding myself to committers.py.
3653
3654         * Scripts/webkitpy/common/config/committers.py:
3655
3656 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
3657
3658         Reviewed by Xan Lopez.
3659
3660         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
3661         https://bugs.webkit.org/show_bug.cgi?id=51806
3662
3663         Originally, the $libraryName is 'JavaScriptCore'. When building release 
3664         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
3665         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
3666         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
3667         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
3668         so make it 'WebKitBuild/Release/.libs'
3669
3670         * Scripts/webkitdirs.pm: 
3671
3672 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
3673
3674         Reviewed by Adam Barth.
3675
3676         Make EFL a core builder
3677         https://bugs.webkit.org/show_bug.cgi?id=51804
3678
3679         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3680         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3681
3682 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3683
3684         [Qt] Unreviewed fix after r74855 and r74875.
3685
3686         * BuildSlaveSupport/built-product-archive:
3687          - Create directories explicitly.
3688          - Pass shell=True to subprocess.call().
3689
3690 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3691
3692         [Qt] Unreviewed fix after r74855.
3693
3694         Move JavaScriptCore to Source
3695         https://bugs.webkit.org/show_bug.cgi?id=51604
3696
3697         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
3698
3699 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3700
3701         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
3702
3703         Move JavaScriptCore to Source
3704         https://bugs.webkit.org/show_bug.cgi?id=51604
3705
3706         * Scripts/webkitdirs.pm:
3707
3708 2011-01-02  Robert Hogan  <robert@webkit.org>
3709
3710         Unreviewed, build fix.
3711
3712         [Qt] Fix DRT build after 74855
3713
3714         * DumpRenderTree/qt/DumpRenderTree.pro:
3715
3716 2011-01-01  Adam Barth  <abarth@webkit.org>
3717
3718         Remove the assumption from the Qt and Gtk builds that every project is
3719         in the root directory.
3720
3721         * Scripts/build-webkit:
3722
3723 2011-01-01  Adam Barth  <abarth@webkit.org>
3724
3725         Reviewed by Eric Seidel.
3726
3727         Teach svn-apply how to apply patches even though JavaScriptCore has moved
3728         https://bugs.webkit.org/show_bug.cgi?id=51796
3729
3730         After this change, svn-apply will magically apply patches to
3731         JavaScriptCore/foo to Source/JavaScriptCore/foo.
3732
3733         * Scripts/VCSUtils.pm:
3734
3735 2011-01-01  Adam Barth  <abarth@webkit.org>
3736
3737         Reviewed by Eric Seidel.
3738
3739         Move JavaScriptCore to Source
3740         https://bugs.webkit.org/show_bug.cgi?id=51604
3741
3742         Update references to JavaScriptCore to point to the new location.
3743
3744         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3745         * DumpRenderTree/qt/DumpRenderTree.pro:
3746         * DumpRenderTree/qt/ImageDiff.pro:
3747         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3748         * DumpRenderTree/wscript:
3749         * Scripts/build-jsc:
3750         * Scripts/build-webkit:
3751         * Scripts/do-file-rename:
3752         * Scripts/do-webcore-rename:
3753         * Scripts/run-javascriptcore-tests:
3754         * Scripts/update-javascriptcore-test-results:
3755         * Scripts/webkitdirs.pm:
3756         * Scripts/webkitpy/common/config/build_unittest.py:
3757         * Scripts/webkitpy/style/checker.py:
3758         * Scripts/webkitpy/style/checker_unittest.py:
3759         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3760         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3761         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3762         * wx/build/settings.py:
3763
3764 2011-01-01  Adam Barth  <abarth@webkit.org>
3765
3766         Reviewed by Eric Seidel.
3767
3768         Move Sources to Source
3769         https://bugs.webkit.org/show_bug.cgi?id=51794
3770
3771         Update scripts to point to the new location.
3772
3773         * Scripts/build-webkit:
3774         * Scripts/do-file-rename:
3775         * Scripts/do-webcore-rename:
3776         * Scripts/webkitpy/common/config/build.py:
3777         * Scripts/webkitpy/common/config/build_unittest.py:
3778
3779 2010-12-31  Kent Tamura  <tkent@chromium.org>
3780
3781         Reviewed by Eric Seidel.
3782
3783         [DRT/Chromium] Enable mock spell checker on non-OSX
3784         https://bugs.webkit.org/show_bug.cgi?id=51401
3785
3786         * DumpRenderTree/chromium/WebViewHost.cpp:
3787         (WebViewHost::spellCheck):
3788
3789 2010-12-31  Adam Barth  <abarth@webkit.org>
3790
3791         Reviewed by Ariya Hidayat.
3792
3793         Remove Tools/Scripts/wkstyle
3794         https://bugs.webkit.org/show_bug.cgi?id=51774