1f042cabd283dd800d53537a9e9ea87548fa0338
[WebKit.git] / Tools / ChangeLog
1 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
2
3         Reviewed by Andreas Kling.
4
5         Local Storage settings can be enable/disable from "Develop" menu
6         https://bugs.webkit.org/show_bug.cgi?id=52296
7
8         * QtTestBrowser/launcherwindow.cpp:
9         (LauncherWindow::createChrome):
10         (LauncherWindow::toggleLocalStorage):
11         (LauncherWindow::toggleOfflineStorageDatabase):
12         (LauncherWindow::toggleOfflineWebApplicationCache):
13         (LauncherWindow::setOfflineStorageDefaultQuota):
14         * QtTestBrowser/launcherwindow.h:
15         (WindowOptions::WindowOptions):
16         * QtTestBrowser/main.cpp:
17         (LauncherApplication::handleUserOptions):
18
19 2011-02-04  Tony Chang  <tony@chromium.org>
20
21         Reviewed by Eric Seidel.
22
23         get test-webkitpy running on win32 python
24         https://bugs.webkit.org/show_bug.cgi?id=53822
25
26         The test harness crashes with a WindowsError because it can't find
27         'svn' when using subprocess.Popen.  This gets us past the error
28         so we can see the failing tests on the Chromium Win Release Tests
29         bot.
30
31         * Scripts/webkitpy/common/system/executive.py:
32
33 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
34
35         Reviewed by Gustavo Noronha Silva.
36
37         [GTK] fast/events/pagehide-timeout.html fails
38         https://bugs.webkit.org/show_bug.cgi?id=53771
39
40         Add knowledge of the document browser cache model the DRT. When resetting
41         WebKit settings to consistent values between tests, default to the document
42         browser cache model.
43
44         * DumpRenderTree/gtk/DumpRenderTree.cpp:
45         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
46         cache model between tests.
47         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
48         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
49         document browser cache model.
50
51 2011-02-04  Adam Barth  <abarth@webkit.org>
52
53         Reviewed by Eric Seidel.
54
55         PluginDocuments don't create widgets for plugins on back/forward
56         https://bugs.webkit.org/show_bug.cgi?id=53474
57
58         Teach the test plugin how to call alert on load.
59
60         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
61         (NPP_New):
62
63 2011-02-04  Adam Roben  <aroben@apple.com>
64
65         Add a test case for encode/decode of FormData/FormDataElement
66
67         If the fix made in r77401 is broken, this new test will crash.
68
69         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
70
71         Reviewed by Sam Weinig.
72
73         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
74         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
75
76         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
77         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
78         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
79         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
80         form, an return the session state data.
81         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
82         and restore it into another WKPage.
83
84         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
85
86         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
87         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
88         * TestWebKitAPI/win/copy-resources.cmd:
89         Added new files.
90
91 2011-02-04  Adam Roben  <aroben@apple.com>
92
93         Move code to run JavaScript tests into its own files
94
95         This will allow other tests to use this mechanism.
96
97         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
98         world
99
100         Reviewed by Sam Weinig.
101
102         * TestWebKitAPI/JavaScriptTest.cpp: Added.
103         * TestWebKitAPI/JavaScriptTest.h: Added.
104         Moved code here...
105
106         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
107
108         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
109         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
110         Added the new files.
111
112 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
113
114         Reviewed by Mihai Parparita.
115
116         merge test expectations for chromium, chromium-gpu. The
117         chromium-gpu port will no longer maintain its own
118         test expectations file.
119
120         Also add in a graphics_type() call on the port object to
121         determine what graphics type to use in the test configuration,
122         and log the configuration as a config setting.
123
124         https://bugs.webkit.org/show_bug.cgi?id=53562
125
126         * Scripts/webkitpy/layout_tests/port/base.py:
127         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
128         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
129         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
130
131 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
132
133         Reviewed by Pavel Feldman.
134
135         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
136         https://bugs.webkit.org/show_bug.cgi?id=53781
137
138         * Scripts/check-inspector-strings:
139
140 2011-02-04  Adam Roben  <aroben@apple.com>
141
142         Include the crashing function in the link to a crash log on Mac
143
144         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
145         function that crashed on Mac
146
147         Reviewed by David Kilzer.
148
149         * Scripts/old-run-webkit-tests:
150         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
151         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
152         the crash log.
153
154 2011-02-04  Adam Roben  <aroben@apple.com>
155
156         Link to Mac crash logs from results.html
157
158         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
159         results.html
160
161         Reviewed by David Kilzer.
162
163         * Scripts/old-run-webkit-tests:
164         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
165         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
166
167 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
168
169         Reviewed by Dan Bernstein.
170
171         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
172         https://bugs.webkit.org/show_bug.cgi?id=52897
173         <rdar://problem/8898294>
174
175         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
176         (WTR::InjectedBundlePage::InjectedBundlePage):
177         (WTR::InjectedBundlePage::willSendRequestForFrame):
178         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
179
180 2011-02-03  Ivan Krstić  <ike@apple.com>
181
182         Unreviewed.
183
184         Adding myself to committers.py.
185
186         * Scripts/webkitpy/common/config/committers.py:
187
188 2011-02-03  James Kozianski  <koz@chromium.org>
189
190         Reviewed by Dimitri Glazkov.
191
192         Add navigator.registerProtocolHandler behind a flag.
193         https://bugs.webkit.org/show_bug.cgi?id=52609
194
195         * Scripts/build-webkit:
196
197 2011-02-03  Hayato Ito  <hayato@chromium.org>
198
199         Reviewed by Eric Seidel.
200
201         [NRWT] Remove TestArgs class, which is wrongly used.
202
203         https://bugs.webkit.org/show_bug.cgi?id=53063
204
205         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
206         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
207         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
208         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
209         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
210         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
211
212 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
213
214         Reviewed by Kenneth Russell.
215
216         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
217         https://bugs.webkit.org/show_bug.cgi?id=53714
218
219         * Scripts/build-webkit: change --3d-canvas build option
220           to set ENABLE_WEBGL
221
222 2011-02-03  Hayato Ito  <hayato@chromium.org>
223
224         Reviewed by Tony Chang.
225
226         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
227         move _run_single_test() and _process_output() functions from
228         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
229
230         This is clean up and acts as a preparation for elimination of test_types/*
231         classes. These classes will move to the single_test_runner module introduced
232         in this patch.
233
234         https://bugs.webkit.org/show_bug.cgi?id=53004
235
236         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
237         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
238         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
239         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
240         * Scripts/webkitpy/layout_tests/port/base.py:
241         * Scripts/webkitpy/layout_tests/port/chromium.py:
242         * Scripts/webkitpy/layout_tests/port/dryrun.py:
243         * Scripts/webkitpy/layout_tests/port/test.py:
244         * Scripts/webkitpy/layout_tests/port/webkit.py:
245         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
246         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
247         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
248
249 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
250
251         Unreviewed, build fix.
252
253         Delete a line that was accidentally missed in r77586; without it
254         there is still a race between the two threads.
255
256         https://bugs.webkit.org/show_bug.cgi?id=51572
257
258         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
259
260 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
261
262         Reviewed by Tony Chang.
263
264         nrwt: handle "broken pipe" notifications from DRT more cleanly.
265
266         https://bugs.webkit.org/show_bug.cgi?id=52927
267
268         * Scripts/webkitpy/layout_tests/port/server_process.py:
269         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
270
271 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
272
273         Reviewed by Kenneth Russell.
274
275         Update, resubmit change to bug 51572. I think the race that was
276         fixed in r76703 caused the hang that caused us to roll this
277         patch out before, so I'd like to try again.
278
279         https://bugs.webkit.org/show_bug.cgi?id=51572
280
281         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
282         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
283
284 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
285
286         Unreviewed.
287
288         Adding myself to committers.py.
289
290         * Scripts/webkitpy/common/config/committers.py:
291
292 2011-02-03  Adam Roben  <aroben@apple.com>
293
294         Include the crashing function in the link to a crash log
295
296         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
297         function that crashed
298
299         Reviewed by David Kilzer.
300
301         * Scripts/old-run-webkit-tests:
302         (crashLocation): Added. Returns the location of the crash.
303         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
304         could be determined.
305
306 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
307
308         Unreviewed, build fix.
309
310         Actually make the changes suggested by Mihai in his review
311         of bug 53720 :(
312
313         https://bugs.webkit.org/show_bug.cgi?id=53720
314
315         * Scripts/webkitpy/layout_tests/port/test_files.py:
316         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
317
318 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
319
320         Reviewed by Mihai Parparita.
321
322         new-run-webkit-tests: Fix bug introduced in r77434 that was
323         causing us to run the canvas GPU tests on the Mac GPU port. This
324         bug revealed that we were not setting the port.name() field
325         properly in many cases, so I've cleaned up all of that code, and
326         removed a few comments about "version-specific" GPU ports that
327         don't exist and just confused things.
328
329         Testing also revealed that port.abspath_for_test() wasn't
330         normalizing paths on Windows properly, so I fixed that as well.
331
332         https://bugs.webkit.org/show_bug.cgi?id=53719
333
334         * Scripts/webkitpy/layout_tests/port/base.py:
335         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
336         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
337
338 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
339
340         Reviewed by Mihai Parparita.
341
342         new-run-webkit-tests: fix normalization of paths on windows when gathering files
343
344         r77434 introduced a bug that was causing the test expectations
345         for the GPU ports to not be treated properly. It turns out that
346         when we gathered the list of test files on Windows, we would
347         return paths of the form "c:\LayoutTests/fast/canvas", and the
348         mixture of backslashes and forward slashes was confusing things.
349
350         This patch normalizes all of the filenames returned from
351         test_files.find(), and adds better tests for this (fixing a
352         couple of other bugs found in the meantime).
353
354         https://bugs.webkit.org/show_bug.cgi?id=53720
355
356         * Scripts/webkitpy/layout_tests/port/test.py:
357         * Scripts/webkitpy/layout_tests/port/test_files.py:
358         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
359
360 2011-02-03  Adam Roben  <aroben@apple.com>
361
362         Add links to Windows crash logs in results.html
363
364         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
365         results.html
366
367         Reviewed by David Kilzer.
368
369         * Scripts/old-run-webkit-tests:
370         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
371         createDebuggerCommandFile).
372         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
373         tool has exited.
374         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
375         it into the test results directory tree. Only implemented for Cygwin currently.
376         (findNewestFileMatchingGlob): Added. Does what it says.
377         (htmlForResultsSection): Only link to files that exist.
378         (linksForErrorTest): Add a link to the crash log.
379         (deleteExpectedAndActualResults): Delete any old crash log for this test.
380         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
381         hardcoding it here.
382
383 2011-02-03  Adam Roben  <aroben@apple.com>
384
385         Tell the debugger the path to the WebKit source tree when saving a crash log
386
387         This allows the debugger to include the crashing line of code in the log.
388
389         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
390         of code
391
392         Reviewed by Sam Weinig.
393
394         * Scripts/old-run-webkit-tests:
395         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
396         file and returns the path to that file. The commands we pass came from
397         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
398         WebKit source code lives.
399         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
400         line using -c, save them to a file and specify the path to that file using -cf. This works
401         around what is presumably a bug in Windows's command line parsing, where having multiple
402         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
403         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
404         together to make them easier to modify in the future.
405
406 2011-02-02  Sam Weinig  <sam@webkit.org>
407
408         Reviewed by Anders Carlsson.
409
410         Add notification of the end of a rubber band.
411         <rdar://problem/8940648>
412
413         * MiniBrowser/mac/BrowserWindowController.m:
414         (-[BrowserWindowController awakeFromNib]):
415         * WebKitTestRunner/TestController.cpp:
416         (WTR::TestController::createOtherPage):
417         (WTR::TestController::initialize):
418         Stub out the new WKUIClient function.
419
420 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
421
422         Unreviewed.
423
424         Adding myself to committers.py.
425
426         * Scripts/webkitpy/common/config/committers.py:
427
428 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
429
430         Reviewed by Csaba Osztrogonác.
431
432         [Qt][WK2] MiniBrowser's window size should be 800x600
433         https://bugs.webkit.org/show_bug.cgi?id=53670
434
435         Make layout test failure debugging easier.
436         * MiniBrowser/qt/BrowserWindow.cpp:
437         (BrowserWindow::BrowserWindow):
438
439 2011-02-02  Andy Estes  <aestes@apple.com>
440
441         Reviewed by Mark Rowe.
442
443         'update-webkit' should handle OpenSource and Internal using different
444         VCSs.
445
446         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
447         Internal directory.
448
449 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
450
451         Reviewed by Mihai Parparita.
452
453         new-run-webkit-tests: hardcode the directories to scan for tests
454         for GPU bots instead of SKIPping them. See bug 53562 for some
455         context, but we will now hard-code the list of directories to
456         use by default instead of skipping over directories in the
457         expectations file. We do this so that we will be able to merge
458         the expectations files without getting conflicting SKIP
459         directives. Note that this change will reduce the # of tests
460         being run on the Mac GPU bots, because we're accidentally
461         including some today.
462
463         https://bugs.webkit.org/show_bug.cgi?id=53631
464
465         * Scripts/webkitpy/layout_tests/port/base.py:
466         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
467         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
468
469 2011-02-02  Sam Weinig  <sam@webkit.org>
470
471         Reviewed by Beth Dakin.
472
473         Add ChromeClient function to paint custom overhang areas.
474         https://bugs.webkit.org/show_bug.cgi?id=53639
475
476         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
477         (WTR::InjectedBundlePage::InjectedBundlePage):
478         Stub out new callback.
479
480 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
481
482         Reviewed by Tony Chang.
483
484         new-run-webkit-tests: support chromium code paths in mock_drt
485
486         https://bugs.webkit.org/show_bug.cgi?id=53471
487
488         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
489         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
490
491 2011-02-02  Adam Klein  <adamk@chromium.org>
492
493         Reviewed by Tony Chang.
494
495         Update new-run-webkit-tests --chromium to put output under Source/...
496         https://bugs.webkit.org/show_bug.cgi?id=53612
497
498         * BuildSlaveSupport/test-result-archive:
499         * Scripts/webkitpy/layout_tests/port/chromium.py:
500
501 2011-01-28  Tony Chang  <tony@chromium.org>
502
503         Reviewed by Eric Seidel.
504
505         [chromium] remove --use-test-shell from NRWT
506         https://bugs.webkit.org/show_bug.cgi?id=53346
507
508         I've already started removing some of the bindings like eventSender so
509         this already doesn't work isn't useful.  Also updated some comments to
510         refer to DRT instead of test_shell.
511
512         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
513         * Scripts/webkitpy/layout_tests/port/chromium.py:
514         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
515         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
516         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
517         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
518         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
519         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
520
521 2011-02-02  Steve Lacey  <sjl@chromium.org>
522
523         Reviewed by Eric Carlson.
524
525         Implement basic media statistics on media elements.
526         https://bugs.webkit.org/show_bug.cgi?id=53322
527
528         * Scripts/build-webkit:
529
530 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
531
532         [wx] Build fixes for wxWebKit.
533
534         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
535         (LayoutTestController::setSerializeHTTPLoads):
536         * wx/browser/wscript:
537         * wx/build/build_utils.py:
538         * wx/build/settings.py:
539
540 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
541
542         Reviewed by Mihai Parparita.
543
544         new-run-webkit-tests: stop skipping so many tests
545
546         r77163 introduced a regression where we weren't resetting test
547         expectations properly and were skipping too many tests as a
548         result. This patch fixes that and adds a test for it.
549
550         https://bugs.webkit.org/show_bug.cgi?id=53551
551
552         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
553         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
554
555 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
556
557         Reviewed by Tony Chang.
558
559         new-run-webkit-tests: add first stub of test_runner2. This
560         will add support for the 'inline', 'threads', and 'processes'
561         flags to --worker-model, but for now the implementatios just
562         fall back on the old ones.
563
564         https://bugs.webkit.org/show_bug.cgi?id=53157
565
566         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
567         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
568
569 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
570
571         Reviewed by James Robinson.
572
573         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
574         https://bugs.webkit.org/show_bug.cgi?id=53522
575
576         * Scripts/run-chromium-webkit-unit-tests:
577
578 2011-02-01  Adam Barth  <abarth@webkit.org>
579
580         Reviewed by Mihai Parparita.
581
582         Using Control-C to cancel webkit-patch or other python tools causes
583         unpleasant traceback console spew
584         https://bugs.webkit.org/show_bug.cgi?id=53462
585
586         Catch the exception and don't print the stack trace.
587
588         * Scripts/webkit-patch:
589
590 2011-02-01  Scott Cameron  <sccameron@rim.com>
591
592         Reviewed by Daniel Bates.
593
594         Use Windows format for MinGW HTTPD path.
595         https://bugs.webkit.org/show_bug.cgi?id=53503
596
597         * Scripts/webkitperl/httpd.pm:
598           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
599             so that we don't have to escape the space characters in the path. Also,
600             changed path to Windows-style path and removed FIXME comment.
601
602 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
603
604         Reviewed by Andreas Kling.
605
606         [Qt][WK2] Add a way to use shared process model in MiniBrowser
607         https://bugs.webkit.org/show_bug.cgi?id=53090
608
609         * MiniBrowser/qt/BrowserView.cpp:
610         (BrowserView::BrowserView): Removed the m_context member.
611         From now the context is guaranteed to be non-null and we
612         don't need to store that in the object.
613         * MiniBrowser/qt/BrowserView.h:
614         * MiniBrowser/qt/BrowserWindow.cpp:
615         Added static bool to determine that new windows need to be
616         created with their own context or not. Use the same context
617         and web process by default to be inilne with the other ports.
618         (BrowserWindow::BrowserWindow):
619         (BrowserWindow::newWindow):
620         * MiniBrowser/qt/BrowserWindow.h:
621         * MiniBrowser/qt/main.cpp:
622         (main): Added command line switch to be able to use the
623         non-shared process model. Simplify the handling of the command line
624         switches a little bit.
625
626 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
627
628         Reviewed by Andreas Kling.
629
630         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
631         https://bugs.webkit.org/show_bug.cgi?id=53491
632
633         * MiniBrowser/qt/BrowserWindow.cpp:
634         (BrowserWindow::BrowserWindow):
635         (BrowserWindow::toggleFullScreenMode):
636         * MiniBrowser/qt/BrowserWindow.h:
637
638 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
639
640         Reviewed by Andreas Kling.
641
642         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
643         https://bugs.webkit.org/show_bug.cgi?id=53489
644
645         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
646         to Settings menu.
647
648         * MiniBrowser/qt/BrowserWindow.cpp:
649         (BrowserWindow::BrowserWindow):
650         (BrowserWindow::toggleFrameFlattening):
651         (BrowserWindow::toggleDisableJavaScript):
652         (BrowserWindow::toggleAutoLoadImages):
653         * MiniBrowser/qt/BrowserWindow.h:
654
655 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
656
657         Reviewed by Tony Chang.
658
659         [Chromium] Switch chromium-mac to use ChromiumDriver
660         https://bugs.webkit.org/show_bug.cgi?id=53461
661         
662         For the sake of consistency with the other Chromium platforms (and so
663         that chromium-mac picks up special flags like --enable-hardware-gpu),
664         switch chromium-mac from the WebKitDriver to ChromiumDriver.
665
666         * Scripts/webkitpy/layout_tests/port/chromium.py:
667
668 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
669
670         Reviewed by Mihai Parparita.
671
672         The current modifier parsing code in test_expectations is
673         fragile and hard-coded, so it's not easy to understand the logic
674         or easily add new types of modifiers (like GPU vs. CPU testing
675         for graphics tests, or 32-bit vs. 64-bit differences).
676
677         This is the first of two patches that will add in more generic
678         support and then eliminate the GPU-specific test expectations
679         files for Chromium.
680
681         This patch adds two standalone objects for handling modifiers. The
682         rules for interpreting modifiers, precedence, and conflicts are
683         given in the docstring to the ModifierMatcher class, which
684         returns ModifierMatchResult objects.
685         
686         This patch also adds routines to the Port interface and a
687         default set of values in the base object, in order to obtain the
688         values needed on a given test run. These values are then passed
689         to the expectation parser. This also allows us to clean up the
690         logic used to lint all of the different configurations in a
691         single test_expectations.txt file.
692
693         The next patch will merge in the separate GPU expectations file.
694
695         https://bugs.webkit.org/show_bug.cgi?id=51222
696
697         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
698         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
699         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
700         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
701         * Scripts/webkitpy/layout_tests/port/base.py:
702         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
703         * Scripts/webkitpy/layout_tests/port/chromium.py:
704         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
705         * Scripts/webkitpy/layout_tests/port/test.py:
706         * Scripts/webkitpy/layout_tests/port/webkit.py:
707         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
708         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
709         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
710         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
711         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
712
713 2011-01-31  Scott Cameron  <sccameron@rim.com>
714
715         Reviewed by Daniel Bates.
716
717         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
718         https://bugs.webkit.org/show_bug.cgi?id=50036
719
720         This will add an Apache2.2 configuration file and modifies scripts to allow
721         running an httpd server in an MSYS environment.
722
723         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
724         in order to allow for simple installation/execution.  Simply install the latest
725         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
726         be able to execute run-webkit-httpd.
727         
728
729         * Scripts/run-webkit-httpd:
730         * Scripts/webkitperl/httpd.pm:
731
732 2011-01-31  Tony Chang  <tony@chromium.org>
733
734         Reviewed by Eric Seidel.
735
736         mac DRT should report RTL scroll offset relative to top right corner
737         https://bugs.webkit.org/show_bug.cgi?id=53324
738
739         * DumpRenderTree/mac/DumpRenderTree.mm:
740         (dumpFrameScrollPosition):
741
742 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
743
744         Reviewed by Andreas Kling.
745
746         [Qt] Add Take Screen Shot action to MiniBrowser
747         https://bugs.webkit.org/show_bug.cgi?id=53422
748
749         Add Take Screen Shot action to MiniBrowser's view menu.
750
751         * MiniBrowser/qt/BrowserWindow.cpp:
752         (BrowserWindow::BrowserWindow):
753         (BrowserWindow::screenshot):
754         * MiniBrowser/qt/BrowserWindow.h:
755
756 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
757
758         Reviewed by Xan Lopez.
759
760         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
761         https://bugs.webkit.org/show_bug.cgi?id=53379
762
763         Remove left over #ifdef's. I thought all of the conditional code
764         had been freed from the condition, but I forgot to check DRT.
765
766         * DumpRenderTree/gtk/DumpRenderTree.cpp:
767         (resetDefaultsToConsistentValues):
768         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
769         (LayoutTestController::setAlwaysAcceptCookies):
770
771 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
772
773         Unreviewed, build fix.
774
775         Fix regression introduced in r77093 - path.rsplit() doesn't
776         take keyword arguments.
777
778         https://bugs.webkit.org/show_bug.cgi?id=53326
779
780         * Scripts/webkitpy/common/system/filesystem_mock.py:
781
782 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
783
784         Reviewed by Mihai Parparita.
785
786         Add more unit tests for rebaseline-chromium-webkit-tests. This
787         change involves restructuring a bunch of r-c-w-t code to make it
788         more testable as well. We also add wrapper classes for handling
789         testing zip files and fetching URLs.
790
791         https://bugs.webkit.org/show_bug.cgi?id=53040
792
793         * Scripts/webkitpy/common/system/urlfetcher.py:
794         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
795         * Scripts/webkitpy/common/system/zipfileset_mock.py:
796         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
797         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
798         * Scripts/webkitpy/tool/mocktool.py:
799
800 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
801
802         Reviewed by Eric Seidel.
803
804         Clean up of the filesystem-related modules used in webkitpy.
805         I've added relpath() to the filesystem interface, modified
806         ospath.relpath() so that it could work with the filesystem
807         interface, and modified the fileset* routines to use the
808         filesystem interface consistently.
809
810         This patch also adds a close() routine to the fileset routines
811         to indicate that the caller is done with the fileset. This
812         allows zipfileset to clean up after itself when it creates
813         tempfiles to store downloads.
814
815         https://bugs.webkit.org/show_bug.cgi?id=53326
816
817         * Scripts/webkitpy/common/system/directoryfileset.py:
818         * Scripts/webkitpy/common/system/fileset.py:
819         * Scripts/webkitpy/common/system/filesystem.py:
820         * Scripts/webkitpy/common/system/filesystem_mock.py:
821         * Scripts/webkitpy/common/system/filesystem_unittest.py:
822         * Scripts/webkitpy/common/system/ospath.py:
823         * Scripts/webkitpy/common/system/zipfileset.py:
824         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
825
826 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
827
828         Reviewed by Csaba Osztrogonác.
829
830         [Qt][WK2]REGRESSION (r76991): Fix build errors
831         https://bugs.webkit.org/show_bug.cgi?id=53400
832
833         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
834         and remove WebKit2Prefix.h from the build.
835         * MiniBrowser/qt/MiniBrowser.pro:
836
837 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
838
839         Unreviewed.
840
841         [Qt][WK2] Buildfix.
842
843         * MiniBrowser/qt/MiniBrowser.pro:
844
845 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
846
847         Reviewed by Adam Roben.
848         
849         define NOMINMAX when building ImageDiff, as we do elsewhere.
850
851         Add various clampToInt() methods to MathExtras.h
852         https://bugs.webkit.org/show_bug.cgi?id=52910
853
854         * DumpRenderTree/win/ImageDiffCommon.vsprops:
855
856 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
857
858         Reviewed by Darin Adler.
859
860         WebKitTestRunner needs layoutTestController.setPOSIXLocale
861         https://bugs.webkit.org/show_bug.cgi?id=42682
862
863         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
864         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
865         (WTR::InjectedBundle::resetLocalSettings):
866         (WTR::InjectedBundle::didReceiveMessage):
867         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
868         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
869         (WTR::LayoutTestController::setPOSIXLocale):
870         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
871
872 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
873  
874          Reviewed by Mihai Parparita.
875  
876          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
877  
878          This patch re-enables this test and changes it to
879          handle all of the mac platform versions, not just the one
880          it is running on.
881  
882          https://bugs.webkit.org/show_bug.cgi?id=53356
883  
884          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
885  
886 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
887
888         Unreviewed, build fix.
889
890         Take two. The fix in 77023 didn't work, because we were
891         still calling path.abspath_to_uri, which calls _cygpath under
892         the covers, and it appears the cygpath on the bots does
893         something different than it does on my machine. This patch
894         removes the calls to path.abspath_to_uri, so it should be safe.
895         If it doesn't work, I'll roll it out along with r76982 and 77023.
896
897         https://bugs.webkit.org/show_bug.cgi?id=53126
898
899         * Scripts/webkitpy/layout_tests/port/test.py:
900
901 2011-01-28  David Kilzer  <ddkilzer@apple.com>
902
903         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
904         <http://webkit.org/b/53353>
905
906         Reviewed by Mark Rowe.
907
908         * Scripts/webkitdirs.pm:
909         (checkRequiredSystemConfig): Check the Xcode marketing version
910         in addition to the DevCoreTools build version before complaining
911         about an old version of Xcode.  Also make the Mac OS X version
912         check use Perl's built-in version string comparitor.
913
914 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
915
916         Unreviewed, build fix.
917
918         Work around breakage on Win 7 Release bot caused by r76982
919         and the fact that windows ports use "file:////" instead of
920         "file:///". Ideally the test code should be isolated from
921         this, but it isn't yet. Will fix properly in a bit.
922
923         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
924
925 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
926
927         Reviewed by Tony Chang.
928
929         new-run-webkit-tests: change worker model values to
930         "old-inline", "old-threads" in preparation for test_runner2 /
931         multiprocessing changes.
932
933         https://bugs.webkit.org/show_bug.cgi?id=53156
934
935         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
936         * Scripts/webkitpy/layout_tests/port/base.py:
937         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
938         * Scripts/webkitpy/layout_tests/port/mac.py:
939         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
940
941 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
942
943         Reviewed by Tony Chang.
944
945         committers.py - add an IRC nickname for dpranke
946         https://bugs.webkit.org/show_bug.cgi?id=53335
947
948         * Scripts/webkitpy/common/config/committers.py:
949
950 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
951
952         Reviewed by Tony Chang.
953
954         new-run-webkit-tests: add a "mock DRT" port implementation
955         and a separate class that emulates what we expect the
956         DumpRenderTree behavior to be.
957
958         This will eventually replace port/dryrun.py and allow us to get
959         better test coverage of the new-run-webkit-tests code as well as
960         a reference for what new-run-webkit-tests expects from DRT.
961
962         This is the first attempt at this, and it is pretty bare-boned. It
963         really only has been tested on the 'mac' port (and a little on
964         the 'chromium-mac' port.
965
966         https://bugs.webkit.org/show_bug.cgi?id=53126
967
968         * Scripts/webkitpy/common/system/filesystem_mock.py:
969         * Scripts/webkitpy/layout_tests/port/dryrun.py:
970         * Scripts/webkitpy/layout_tests/port/factory.py:
971         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
972         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
973         * Scripts/webkitpy/layout_tests/port/test.py:
974
975 2011-01-28  Pratik Solanki  <psolanki@apple.com>
976
977         Unreviewed. Removing .swp file checked in by mistake.
978
979         * Scripts/.webkitdirs.pm.swp: Removed.
980
981 2011-01-28  Pratik Solanki  <psolanki@apple.com>
982
983         Reviewed by David Kilzer.
984
985         Space not necessary for undefined feature
986         https://bugs.webkit.org/show_bug.cgi?id=53317
987
988         * Scripts/build-webkit:
989
990 2011-01-28  Chang Shu  <chang.shu@nokia.com>
991
992         Reviewed by Andreas Kling.
993
994         Reset NetworkAccessManager to clean up credentials from previous tests.
995         This change causes no performance overhead either.
996         https://bugs.webkit.org/show_bug.cgi?id=36688
997
998         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
999         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1000         (WebCore::DumpRenderTree::open):
1001         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1002
1003 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1004
1005         Reviewed by Andreas Kling.
1006
1007         [Qt] Add Zoom Text Only action to MiniBrowser
1008         https://bugs.webkit.org/show_bug.cgi?id=53297
1009
1010         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1011
1012         * MiniBrowser/qt/BrowserWindow.cpp:
1013         (BrowserWindow::BrowserWindow):
1014         (BrowserWindow::zoomIn):
1015         (BrowserWindow::zoomOut):
1016         (BrowserWindow::resetZoom):
1017         (BrowserWindow::toggleZoomTextOnly):
1018         (BrowserWindow::applyZoom):
1019         * MiniBrowser/qt/BrowserWindow.h:
1020
1021 2011-01-28  Adam Barth  <abarth@webkit.org>
1022
1023         Reviewed by Eric Seidel.
1024
1025         Add webkit-patch roll-chromium-deps
1026         https://bugs.webkit.org/show_bug.cgi?id=53288
1027
1028         This command updates the Source/WebKit/chromium/DEPS file with the
1029         last-known good revision of Chromium (or a revision specified on the
1030         command line).  I'd eventually like to turn this into a SheriffBot
1031         command, but this is the first step.
1032
1033         This patch somewhat sprawled because I needed to move a bunch of code
1034         out of ChangeLog that should never have been there in the first place.
1035         Also, I had to fix a bug in MockUser in order to test the new command.
1036
1037         * Scripts/webkitpy/common/checkout/api.py:
1038         * Scripts/webkitpy/common/checkout/changelog.py:
1039         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1040         * Scripts/webkitpy/common/checkout/deps.py: Added.
1041         * Scripts/webkitpy/common/config/urls.py:
1042         * Scripts/webkitpy/tool/commands/__init__.py:
1043         * Scripts/webkitpy/tool/commands/download_unittest.py:
1044         * Scripts/webkitpy/tool/commands/roll.py: Added.
1045         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1046         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1047         * Scripts/webkitpy/tool/mocktool.py:
1048         * Scripts/webkitpy/tool/steps/__init__.py:
1049         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1050         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1051         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1052         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1053         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1054         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1055
1056 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1057
1058         Reviewed by Laszlo Gombos.
1059
1060         Get rid of prefix header dependency for WebKit2 build system
1061         https://bugs.webkit.org/show_bug.cgi?id=50174
1062
1063         Change the style checker so that it enforces config.h include for
1064         WebKit2.
1065
1066         * Scripts/webkitpy/style/checker.py:
1067
1068 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1069
1070         Reviewed by Darin Adler.
1071
1072         execCommand("Paste") doesn't work in WebKitTestRunner
1073         https://bugs.webkit.org/show_bug.cgi?id=52785
1074
1075         Enable both of the settings needed to allow paste.
1076         
1077         * WebKitTestRunner/TestController.cpp:
1078         (WTR::TestController::resetStateToConsistentValues):
1079
1080 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1081
1082         Reviewed by Andreas Kling.
1083
1084         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1085         https://bugs.webkit.org/show_bug.cgi?id=48440
1086
1087         Preserve user input when toggling use of QGraphicsView
1088
1089         * QtTestBrowser/launcherwindow.cpp:
1090         (LauncherWindow::initializeView):
1091         (LauncherWindow::loadFinished):
1092         * QtTestBrowser/launcherwindow.h:
1093         * QtTestBrowser/mainwindow.cpp:
1094         (MainWindow::addressUrl):
1095         * QtTestBrowser/mainwindow.h:
1096
1097 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1098
1099         Reviewed by Mihai Parparita.
1100
1101         new-run-webkit-tests: turn off pixel tests correctly by default
1102         for webkit-based ports. r70013 (bug 47510) used
1103         port.set_option_default() to attempt to set default values, but
1104         that didn't work correctly. I have removed set_option_default
1105         for now since it was only being used in two places and in three
1106         useless unit tests. There is a separate bug open to fix the
1107         option parsing (48095), so this workaround is fine for now.
1108
1109         https://bugs.webkit.org/show_bug.cgi?id=53217
1110
1111         * Scripts/webkitpy/layout_tests/port/webkit.py:
1112         * Scripts/webkitpy/layout_tests/port/base.py:
1113         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1114
1115 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1116
1117         Rubber-stamped by Ariya Hidayat.
1118
1119         Trivial crash fix in WTR.
1120
1121         * WebKitTestRunner/TestController.cpp:
1122         (WTR::TestController::initialize): Increase the size
1123         of the vector by one to be able to store the null character.
1124
1125 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1126
1127         Reviewed by Csaba Osztrogonác.
1128
1129         [Qt][WK2] WTR should be initialized in the same way as DRT
1130         https://bugs.webkit.org/show_bug.cgi?id=53240
1131
1132         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1133         (WTR::activateFonts): Added missing initialization steps.
1134
1135 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1136
1137         Unreviewed. 
1138
1139         Adding myself to committers.py.
1140
1141         * Scripts/webkitpy/common/config/committers.py:
1142
1143 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1144
1145         Reviewed by Csaba Osztrogonác.
1146
1147         [Qt] [Symbian] Move project files into Source
1148         https://bugs.webkit.org/show_bug.cgi?id=52891
1149
1150         Fix the Symbian build after the project files
1151         are moved to Source directory. On Symbian qmake
1152         needs to run in the same directory where the main
1153         pro files (WebKit.pro, Tools.pro) are located.
1154
1155         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1156         is located before running qmake for Symbian. Qmake on Symbian
1157         does not properly honor the "-o" option, work it around by setting
1158         the name of the Makefile to bld.inf.
1159
1160 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1161
1162         Reviewed by Andreas Kling.
1163
1164         [Qt] Add simple zooming features to MiniBrowser
1165         https://bugs.webkit.org/show_bug.cgi?id=53231
1166
1167         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1168
1169         * MiniBrowser/qt/BrowserWindow.cpp:
1170         (BrowserWindow::BrowserWindow):
1171         (BrowserWindow::zoomIn):
1172         (BrowserWindow::zoomOut):
1173         (BrowserWindow::resetZoom):
1174         (BrowserWindow::updateUserAgentList):
1175         (BrowserWindow::applyZoom):
1176         * MiniBrowser/qt/BrowserWindow.h:
1177
1178 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1179
1180         Reviewed by Dan Bernstein.
1181
1182         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1183         https://bugs.webkit.org/show_bug.cgi?id=42319
1184         
1185         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1186
1187         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1188         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1189         (WTR::LayoutTestController::showWebInspector):
1190         (WTR::LayoutTestController::closeWebInspector):
1191         (WTR::LayoutTestController::evaluateInWebInspector):
1192         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1193         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1194         * WebKitTestRunner/TestInvocation.cpp:
1195         (WTR::shouldOpenWebInspector):
1196         (WTR::TestInvocation::invoke):
1197         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1198
1199 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1200
1201         Reviewed by Xan Lopez.
1202
1203         [GTK] Pixel dumps do not include scrollbars in output images
1204         https://bugs.webkit.org/show_bug.cgi?id=53216
1205
1206         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1207         that have scrollbars.
1208
1209         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1210         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1211         instead of the web view itself.
1212
1213 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1214
1215         Reviewed by Mihai Parparita.
1216
1217         Fix regression introduced in r76322 ... new-run-webkit-tests
1218         was attempting to save the image diff output as a UTF-8-encoded
1219         file.
1220
1221         https://bugs.webkit.org/show_bug.cgi?id=53210
1222
1223         * Scripts/webkitpy/layout_tests/port/webkit.py:
1224
1225 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1226
1227         Unreviewed, rolling out r76709.
1228         http://trac.webkit.org/changeset/76709
1229         https://bugs.webkit.org/show_bug.cgi?id=53194
1230
1231         "broke python tests on non-snowleopard platforms" (Requested
1232         by dpranke on #webkit).
1233
1234         * Scripts/webkitpy/layout_tests/port/factory.py:
1235         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1236         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1237
1238 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1239
1240         Reviewed by Tony Chang.
1241
1242         new-run-webkit-tests: add a "mock DRT" port implementation
1243         and a separate class that emulates what we expect the
1244         DumpRenderTree behavior to be.
1245
1246         This will eventually replace port/dryrun.py and allow us to get
1247         better test coverage of the new-run-webkit-tests code as well as
1248         a reference for what new-run-webkit-tests expects from DRT.
1249
1250         This is the first attempt at this, and it is pretty bare-boned. It
1251         really only has been tested on the 'mac' port (and a little on
1252         the 'chromium-mac' port.
1253
1254         https://bugs.webkit.org/show_bug.cgi?id=53126
1255
1256         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1257         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1258         * Scripts/webkitpy/layout_tests/port/factory.py:
1259
1260 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1261
1262         Reviewed by Tony Chang.
1263
1264         Add '--no-timeout' option to Chromium DRT to ease debugging.
1265         https://bugs.webkit.org/show_bug.cgi?id=52873
1266
1267         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1268         (main):
1269
1270 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1271
1272         Reviewed by Andreas Kling.
1273
1274         [Qt] Fix qt_minimal build
1275         https://bugs.webkit.org/show_bug.cgi?id=53172
1276
1277         * QtTestBrowser/locationedit.h:
1278
1279 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1280
1281         Reviewed by Antonio Gomes.
1282
1283         QtTestBrowser should have a UI Setting to disable plugins
1284         https://bugs.webkit.org/show_bug.cgi?id=52408
1285         
1286         Added a new action item named "Disable Plugins"
1287         under the "Settings" menu. 
1288
1289         * QtTestBrowser/launcherwindow.cpp:
1290         (LauncherWindow::createChrome):
1291         (LauncherWindow::togglePlugins):
1292         * QtTestBrowser/launcherwindow.h:
1293
1294 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1295
1296         Reviewed by Adam Barth.
1297
1298         Move main CMakeLists.txt into Source directory
1299         https://bugs.webkit.org/show_bug.cgi?id=52888
1300
1301         * Scripts/webkitdirs.pm:
1302
1303 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1304
1305         Reviewed by Eric Seidel.
1306
1307         Improve label text in submit-to-ews
1308         https://bugs.webkit.org/show_bug.cgi?id=53130
1309
1310         * QueueStatusServer/templates/submittoews.html:
1311
1312 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1313
1314         Reviewed by Antonio Gomes.
1315
1316         QtTestBrowser should have a UI Settings to prevent loading images
1317         https://bugs.webkit.org/show_bug.cgi?id=52409
1318         
1319         Added a new action item named "DisableAutoLoadImages"
1320         under the "Settings" menu 
1321
1322         * QtTestBrowser/launcherwindow.cpp:
1323         (LauncherWindow::createChrome):
1324         (LauncherWindow::toggleAutoLoadImages):
1325         * QtTestBrowser/launcherwindow.h:
1326
1327 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1328
1329         Reviewed by Tony Chang.
1330
1331         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1332         classes, test_expectations.py. This change adds "test-win" and
1333         "test-mac" variants to the test port so that we can better test
1334         rebaselining, and adds a MockUser() object for reuse in testing.
1335
1336         https://bugs.webkit.org/show_bug.cgi?id=53036
1337
1338         * Scripts/webkitpy/common/system/filesystem.py:
1339         * Scripts/webkitpy/common/system/filesystem_mock.py:
1340         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1341         * Scripts/webkitpy/layout_tests/port/factory.py:
1342         * Scripts/webkitpy/layout_tests/port/base.py:
1343         * Scripts/webkitpy/layout_tests/port/test.py:
1344         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1345         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1346         * Scripts/webkitpy/tool/mocktool.py:
1347
1348 2011-01-25  Tony Chang  <tony@chromium.org>
1349
1350         Reviewed by Dimitri Glazkov.
1351
1352         [chromium] remove unused layoutTestController callback
1353         https://bugs.webkit.org/show_bug.cgi?id=53103
1354
1355         This method is used by a test_shell_test, but not needed by DRT.
1356
1357         * DumpRenderTree/chromium/LayoutTestController.cpp:
1358         (LayoutTestController::LayoutTestController):
1359         * DumpRenderTree/chromium/LayoutTestController.h:
1360
1361 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1362
1363         Reviewed by Andreas Kling.
1364
1365         [GTK] Remove 64 bits release bot from the buildbot master
1366         https://bugs.webkit.org/show_bug.cgi?id=52899
1367
1368         Removes the 64 bits release slave from the buildbot configuration,
1369         so that we can use it as an EWS.
1370
1371         * BuildSlaveSupport/build.webkit.org-config/config.json:
1372
1373 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1374
1375         Reviewed by Dan Bernstein.
1376
1377         Implement database quota callback to fix storage tests on WebKit2 bot
1378         https://bugs.webkit.org/show_bug.cgi?id=53064
1379
1380         * WebKitTestRunner/TestController.cpp:
1381         (WTR::exceededDatabaseQuota):
1382         (WTR::TestController::createOtherPage):
1383         (WTR::TestController::initialize):
1384
1385 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1386
1387         Reviewed by Anders Carlsson.
1388
1389         Use designated temp directory for the database for WebKit2
1390         https://bugs.webkit.org/show_bug.cgi?id=53052
1391         
1392         Adopt the new WK2 API for this.
1393
1394         * WebKitTestRunner/TestController.cpp:
1395         (WTR::TestController::libraryPathForTesting):
1396         (WTR::TestController::initialize):
1397         * WebKitTestRunner/TestController.h:
1398         * WebKitTestRunner/mac/TestControllerMac.mm:
1399         (WTR::TestController::platformLibraryPathForTesting):
1400         * WebKitTestRunner/qt/TestControllerQt.cpp:
1401         (WTR::TestController::platformLibraryPathForTesting):
1402         * WebKitTestRunner/win/TestControllerWin.cpp:
1403         (WTR::TestController::platformLibraryPathForTesting):
1404
1405 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1406
1407         Reviewed by Stephanie Lewis.
1408
1409         Add a new Leopard test bot.
1410
1411         * BuildSlaveSupport/build.webkit.org-config/config.json:
1412
1413 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1414
1415         Reviewed by Adam Barth.
1416
1417         Add EFL Builder to core waterfall
1418         https://bugs.webkit.org/show_bug.cgi?id=52704
1419
1420         Add EFL Builder to the core waterfall again.
1421
1422         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1423         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1424
1425 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1426
1427         Reviewed by Tony Chang.
1428
1429         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1430         https://bugs.webkit.org/show_bug.cgi?id=52872
1431
1432         Force disabling proxy to resolve the problem.
1433
1434         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1435         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1436
1437 2011-01-24  Andreas Kling  <kling@webkit.org>
1438
1439         Reviewed by Darin Adler.
1440
1441         check-webkit-style: Update exemptions following Source/ move.
1442         https://bugs.webkit.org/show_bug.cgi?id=53017
1443
1444         * Scripts/webkitpy/style/checker.py:
1445         * Scripts/webkitpy/style/checker_unittest.py:
1446
1447 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1448
1449         Rubber-stamped by Csaba Osztrogonác.
1450
1451         [Qt] Move project files into Source
1452         https://bugs.webkit.org/show_bug.cgi?id=52891
1453
1454         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1455
1456 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1457
1458         Reviewed by Yury Semikhatsky.
1459
1460         Web Inspector: Find duplicate strings in localizedStrings.js
1461
1462         https://bugs.webkit.org/show_bug.cgi?id=53005
1463
1464         * Scripts/check-inspector-strings:
1465
1466 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1467
1468         Reviewed by Andreas Kling.
1469
1470         [Qt] Regroup MiniBrowser's menubar and add open file action
1471         https://bugs.webkit.org/show_bug.cgi?id=53000
1472
1473         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1474
1475         * MiniBrowser/qt/BrowserWindow.cpp:
1476         (BrowserWindow::BrowserWindow):
1477         (BrowserWindow::openFile):
1478         (BrowserWindow::~BrowserWindow):
1479         * MiniBrowser/qt/BrowserWindow.h:
1480
1481 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1482
1483         Unreviewed fix after r76496
1484
1485         [Qt] Move project files into Source
1486         https://bugs.webkit.org/show_bug.cgi?id=52891
1487
1488         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1489         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1490         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1491
1492 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1493
1494         Reviewed by Csaba Osztrogonác.
1495
1496         [Qt] Move project files into Source
1497         https://bugs.webkit.org/show_bug.cgi?id=52891
1498
1499         * DerivedSources.pro: Renamed from DerivedSources.pro.
1500         * DumpRenderTree/qt/DumpRenderTree.pro:
1501         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1502         * MiniBrowser/DerivedSources.pro:
1503         * MiniBrowser/qt/MiniBrowser.pro:
1504         * QtTestBrowser/QtTestBrowser.pro:
1505         * Scripts/webkitdirs.pm:
1506         * Tools.pro: Added.
1507         * WebKitTestRunner/DerivedSources.pro:
1508         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1509         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1510
1511 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1512
1513         Reviewed by Dan Bernstein.
1514
1515         Beefed up --threaded mode to catch even more kinds of errors.
1516         https://bugs.webkit.org/show_bug.cgi?id=52971
1517
1518         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1519         context group to force JSC to mark multiple threads. (This used to be
1520         the default, but it changed in SnowLeopard.)
1521         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1522         to give threading mistakes more chances to show themselves.
1523         (startJavaScriptThreads):
1524         (stopJavaScriptThreads):
1525
1526 2011-01-22  Robert Hogan  <robert@webkit.org>
1527
1528         Reviewed by Andreas Kling.
1529
1530         [Qt] Support layoutTestController.addURLToRedirect()
1531         https://bugs.webkit.org/show_bug.cgi?id=52956
1532
1533         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1534         (LayoutTestController::addURLToRedirect):
1535         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1536
1537 2011-01-22  Robert Hogan  <robert@webkit.org>
1538
1539         Reviewed by Kenneth Rohde Christiansen.
1540
1541         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1542         https://bugs.webkit.org/show_bug.cgi?id=49802
1543
1544         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1545         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1546         (WebCore::DumpRenderTree::open):
1547
1548 2011-01-21  Adam Barth  <abarth@webkit.org>
1549
1550         Reviewed by Maciej Stachowiak.
1551
1552         Disable mac_unittest.py that fails on some of the Mac bots
1553         https://bugs.webkit.org/show_bug.cgi?id=52947
1554
1555         As noted in the comment, this test does not appear to be correct
1556         because the function this test is testing returns different results
1557         depending on which flavor of Mac the test is run on.  This patch
1558         disable the test.  Hopefully we can re-enable the test once we've
1559         probably insulated the test from its environment.
1560
1561         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1562
1563 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1564
1565         Reviewed by Mihai Parparita.
1566
1567         Fix bug introduced in r76322 that caused NRWT to not actually
1568         read the Skipped files properly.
1569
1570         https://bugs.webkit.org/show_bug.cgi?id=52771
1571
1572         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1573         * Scripts/webkitpy/layout_tests/port/webkit.py:
1574         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1575
1576 2011-01-21  Sam Weinig  <sam@webkit.org>
1577
1578         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1579
1580         WebKitTestRunner needs the HOME environment variable to be set.
1581         <rdar://problem/8896573>
1582
1583         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1584         it exists.
1585
1586 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1587
1588         Reviewed by Eric Seidel.
1589
1590         Suppress a few remaining integration tests so that none of the
1591         layout_test unit tests ever read from the filesystem or launch
1592         subprocesses that aren't part of the unit tests.
1593
1594         Also fix a minor bug in the printing unit tests that was
1595         incorrectly relying on sys.argv.
1596
1597         https://bugs.webkit.org/show_bug.cgi?id=52863
1598
1599         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1600         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1601         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1602
1603 2011-01-21  Darin Adler  <darin@apple.com>
1604
1605        Fix Mac build.
1606
1607         * MiniBrowser/mac/BrowserWindowController.m:
1608         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1609
1610 2011-01-20  Darin Adler  <darin@apple.com>
1611
1612         Reviewed by Dan Bernstein.
1613
1614         WebKit2: Implement showModalDialog
1615         https://bugs.webkit.org/show_bug.cgi?id=52855
1616
1617         This fixes WebKitTestRunner to compile, but more work is probably
1618         needed to get it to pass the tests.
1619
1620         * WebKitTestRunner/TestController.cpp:
1621         (WTR::TestController::runModal): Added. Calls through to the
1622         platform-specific version of runModal.
1623         (WTR::TestController::createOtherPage): Changed to be a private
1624         static member function so it can refer to runModal, which is
1625         a private static member function.
1626         (WTR::TestController::initialize): Pass 0 for the runModal
1627         function since we don't need to run the main window modal.
1628         I suspect this is wrong and will need to change.
1629         * WebKitTestRunner/TestController.h: Added declarations for
1630         the functions added above.
1631         * WebKitTestRunner/mac/TestControllerMac.mm:
1632         (WTR::TestController::runModal): Added. Untested implementation.
1633         * WebKitTestRunner/qt/TestControllerQt.cpp:
1634         (WTR::TestController::runModal): Added.
1635         * WebKitTestRunner/win/TestControllerWin.cpp:
1636         (WTR::TestController::runModal): Added.
1637
1638 2011-01-21  Eric Seidel  <eric@webkit.org>
1639
1640         Reviewed by Adam Barth.
1641
1642         Split Host object off from WebKitPatch for easier re-use
1643         https://bugs.webkit.org/show_bug.cgi?id=52284
1644
1645         new-run-webkit-tests and other tools are eventually going to want one of these.
1646         Basically you need to inherit from this class if you want to pretend to be a
1647         self.tool object for Steps/Commands.
1648
1649         * Scripts/webkitpy/common/host.py: Added.
1650         * Scripts/webkitpy/tool/main.py:
1651
1652 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1653
1654         Reviewed by Adam Barth.
1655
1656         Disable the tests that start and stop the http server and web
1657         server, so that we don't have to worry about port collisions on
1658         the bots.
1659
1660         https://bugs.webkit.org/show_bug.cgi?id=52861
1661
1662         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1663
1664 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1665
1666         Reviewed by Eric Seidel.
1667
1668         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1669         
1670         https://bugs.webkit.org/show_bug.cgi?id=52772
1671         
1672         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1673
1674 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1675
1676         Reviewed by Eric Siedel.
1677
1678         nrwt: clean up almost all remaining port references, remove
1679         unnecessary import clauses. The only remaining references are
1680         in places where a mock filesystem makes no sense or can't be
1681         used, and in one routine in port/google_chrome_unittest that
1682         I'll rewrite in a separate patch.
1683
1684         https://bugs.webkit.org/show_bug.cgi?id=52771
1685
1686         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1687         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1688         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1689         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1690         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1691         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1692         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1693         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1694         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1695         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1696         * Scripts/webkitpy/layout_tests/port/gtk.py:
1697         * Scripts/webkitpy/layout_tests/port/mac.py:
1698         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1699         * Scripts/webkitpy/layout_tests/port/qt.py:
1700         * Scripts/webkitpy/layout_tests/port/webkit.py:
1701         * Scripts/webkitpy/layout_tests/port/win.py:
1702         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1703
1704 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1705
1706         Reviewed by Mihai Parparita.
1707
1708         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1709
1710         https://bugs.webkit.org/show_bug.cgi?id=52762
1711
1712         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1713         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1714
1715 2011-01-20  Tony Chang  <tony@chromium.org>
1716
1717         Reviewed by Ojan Vafai.
1718
1719         [chromium] fix the paths used for the rebaseline tool
1720         https://bugs.webkit.org/show_bug.cgi?id=52857
1721
1722         Some of the bots were renamed so the path to grab the results zip
1723         file has changed.
1724
1725         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1726
1727 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1728
1729         Reviewed by Tony Chang.
1730
1731         Fix bug introduced in r72688 / bug 52768 that broke the
1732         generation of the output filename links in the results.html
1733         output. Apparently none of the unit tests actually checked to
1734         make sure the generated links were correct :(
1735
1736         https://bugs.webkit.org/show_bug.cgi?id=52854
1737
1738         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1739         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1740
1741 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1742
1743         Reviewed by Darin Adler.
1744
1745         https://bugs.webkit.org/show_bug.cgi?id=52849
1746         Make window.print work with WebKit2
1747
1748         * MiniBrowser/mac/BrowserWindowController.m:
1749         (-[BrowserWindowController awakeFromNib]):
1750         * WebKitTestRunner/TestController.cpp:
1751         (WTR::createOtherPage):
1752         (WTR::TestController::initialize):
1753         Added zeroes to WKPageUIClient structures to avoid build failures.
1754
1755 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1756
1757         Reviewed by Eric Seidel.
1758
1759         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1760
1761         https://bugs.webkit.org/show_bug.cgi?id=52756
1762
1763         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1764         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1765         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1766         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1767         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1768         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1769
1770 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1771
1772         Reviewed by Antonio Gomes.
1773
1774         QtTestBrowser should have a seperate menu for Settings
1775         https://bugs.webkit.org/show_bug.cgi?id=52817
1776         
1777         Added a new menu item named "Settings"
1778         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1779
1780         * QtTestBrowser/launcherwindow.cpp:
1781         (LauncherWindow::createChrome):
1782
1783 2011-01-20  Sam Weinig  <sam@webkit.org>
1784
1785         Reviewed by John Sullivan.
1786
1787         Update update-webkit-localizable-strings with new path to WebKit.
1788
1789         * Scripts/update-webkit-localizable-strings:
1790
1791 2011-01-20  James Robinson  <jamesr@chromium.org>
1792
1793         Reviewed by Darin Fisher.
1794
1795         Implement mozilla's requestAnimationFrame API
1796         https://bugs.webkit.org/show_bug.cgi?id=51218
1797
1798         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1799
1800         * DumpRenderTree/chromium/WebViewHost.cpp:
1801         (invokeScheduleComposite):
1802         (WebViewHost::scheduleAnimation):
1803         (WebViewHost::paintInvalidatedRegion):
1804         * DumpRenderTree/chromium/WebViewHost.h:
1805
1806 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1807
1808         Reviewed by Adam Roben.
1809
1810         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1811         https://bugs.webkit.org/show_bug.cgi?id=42327
1812
1813         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1814         for methods that take their normal arguments but also a JSContextRef.
1815         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1816         for evaluateScriptInIsolatedWorld.
1817         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1818         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1819         this call is for an isolated world.
1820         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1821         (WTR::worldMap): Helper to create a world map.
1822         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1823         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1824         added LayoutTestController API.
1825         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1826
1827 2011-01-19  Adam Roben  <aroben@apple.com>
1828
1829         Convert paths in environment variables back to msys-style inside commit-log-editor
1830
1831         When this script gets run from inside git commit, msys-style paths in the environment will
1832         have been turned into Windows-style paths with forward slashes. This screws up functions
1833         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1834         the paths back to msys-style before doing anything else.
1835
1836         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1837         using msysgit's Perl and multiple ChangeLogs have been edited
1838
1839         Reviewed by David Kilzer.
1840
1841         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1842         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1843         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1844
1845 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1846
1847         [Win] Unreviewed build fix after r76248.
1848
1849         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1850
1851 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1852
1853         Reviewed by Csaba Osztrogonác.
1854
1855         Refactoring of the custom allocation framework
1856         https://bugs.webkit.org/show_bug.cgi?id=49897
1857
1858         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1859         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1860         equivalent macro implementation at the necessary places.
1861 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1862
1863         Unreviewed. 
1864
1865         Adding myself to committers.py.
1866
1867         * Scripts/webkitpy/common/config/committers.py:
1868
1869 2011-01-20  Adam Barth  <abarth@webkit.org>
1870
1871         Reviewed by Tony Chang.
1872
1873         Chromium builders don't delete unversioned directories when DEPS change
1874         https://bugs.webkit.org/show_bug.cgi?id=52745
1875
1876         If we pass this option to gclient sync, gclient will delete directories
1877         that are no longer part of DEPS instead of leaving them around to
1878         confuse us later.  Apparently, the downstream buildbots use this option
1879         already.
1880
1881         * Scripts/update-webkit-chromium:
1882
1883 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1884
1885         Unreviewed, build fix - I pulled this patch in to fix an issue
1886         revealed by r76195 running on some new bots). Also fix a couple
1887         of other issues revealed in testing.
1888
1889         nrwt: remove fs refs from layout_package/json*
1890
1891         https://bugs.webkit.org/show_bug.cgi?id=52754
1892
1893         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1894         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1895         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1896         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1897         * Scripts/webkitpy/layout_tests/port/base.py:
1898
1899 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1900
1901         Unreviewed, build fix.
1902
1903         Fix a couple of minor bugs discovered while bringing up new bots
1904         for testing.
1905
1906         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1907         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1908
1909 2011-01-19  James Robinson  <jamesr@chromium.org>
1910
1911         Unreviewed, rolling out r76194.
1912         http://trac.webkit.org/changeset/76194
1913         https://bugs.webkit.org/show_bug.cgi?id=51218
1914
1915         Caused mysterious compile failure on the chromium win
1916         build.webkit.org bots
1917
1918         * DumpRenderTree/chromium/WebViewHost.cpp:
1919         (WebViewHost::paintInvalidatedRegion):
1920         * DumpRenderTree/chromium/WebViewHost.h:
1921
1922 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1923
1924         Reviewed by Mihai Parparita.
1925
1926         remove fs refs from test_runner, dump_render_tree_thread
1927
1928         https://bugs.webkit.org/show_bug.cgi?id=52753
1929
1930         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1931         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1932         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1933         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1934
1935 2011-01-19  James Robinson  <jamesr@chromium.org>
1936
1937         Reviewed by Darin Fisher.
1938
1939         Implement mozilla's requestAnimationFrame API
1940         https://bugs.webkit.org/show_bug.cgi?id=51218
1941
1942         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1943
1944         * DumpRenderTree/chromium/WebViewHost.cpp:
1945         (invokeScheduleComposite):
1946         (WebViewHost::scheduleAnimation):
1947         (WebViewHost::paintInvalidatedRegion):
1948         * DumpRenderTree/chromium/WebViewHost.h:
1949
1950 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1951
1952         Unreviewed, build fix.
1953
1954         Fix a few incorrect "self._filesystem" references introduced in
1955         r76184.
1956
1957         * Scripts/webkitpy/layout_tests/port/chromium.py:
1958         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1959
1960 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1961
1962         Reviewed by Mihai Parparita.
1963
1964         add a .sep property, abspath(), isabs(), mtime(), and
1965         open_text_file_for_writing() to filesystem modules. Some of
1966         these properties are not needed in this patch but will be needed
1967         in subsequent patches (I'm doing this to avoid having to track
1968         multiple versions of a single file).
1969
1970         Also, change most of the port/* modules to use the filesystem
1971         objects instead of referencing the filesystem directly.
1972
1973         https://bugs.webkit.org/show_bug.cgi?id=52748
1974
1975         * Scripts/webkitpy/common/system/filesystem.py:
1976         * Scripts/webkitpy/common/system/filesystem_mock.py:
1977         * Scripts/webkitpy/layout_tests/port/__init__.py:
1978         * Scripts/webkitpy/layout_tests/port/base.py:
1979         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1980         * Scripts/webkitpy/layout_tests/port/chromium.py:
1981         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1982         * Scripts/webkitpy/layout_tests/port/config.py:
1983         * Scripts/webkitpy/layout_tests/port/test.py:
1984         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1985
1986 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1987
1988         Reviewed by Anders Carlsson.
1989
1990         If resetting between tests times out, treat it as a WebProcess crash
1991         https://bugs.webkit.org/show_bug.cgi?id=52757
1992
1993         * WebKitTestRunner/TestController.cpp:
1994         (WTR::TestController::runTest):
1995
1996 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1997
1998         Reviewed by Darin Adler.
1999
2000         https://bugs.webkit.org/show_bug.cgi?id=52739
2001         Make it possible for a WebKit2 client to print headers and footers
2002
2003         Added dummy implementations for new printing UIClient calls.
2004
2005         * MiniBrowser/mac/BrowserWindowController.m:
2006         (-[BrowserWindowController awakeFromNib]):
2007         * WebKitTestRunner/TestController.cpp:
2008         (WTR::createOtherPage):
2009         (WTR::TestController::initialize):
2010
2011 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2012
2013         Reviewed by Ojan Vafai.
2014
2015         Change webkitpy/layout_tests/port/test.py to use the
2016         in-memory filesystem for cleaner unit testing. This
2017         change allows us to kill a lot of code that was
2018         specific to the test port, at the cost of being a
2019         little less clear about how things would work if
2020         you didn't have a filesystem.
2021
2022         https://bugs.webkit.org/show_bug.cgi?id=52605
2023
2024         * Scripts/webkitpy/layout_tests/port/test.py:
2025
2026 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2027
2028         Unreviewed, build fix.
2029
2030         Fix test failure caused by committing attachment 79368 instead
2031         of attachment 79461 on bug 52604.
2032
2033         * Scripts/webkitpy/common/system/filesystem_mock.py:
2034
2035 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2036
2037         Reviewed by Mihai Parparita.
2038
2039         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2040         unit testing. os.walk() is too much of a hassle to implement on
2041         top of the in-memory mock filesystem and adding the necessary
2042         interface to files_under() gives clients a cleaner API anyway
2043         (for this particular usage model).
2044
2045         https://bugs.webkit.org/show_bug.cgi?id=52691
2046
2047         * Scripts/webkitpy/common/system/filesystem.py:
2048         * Scripts/webkitpy/common/system/filesystem_mock.py:
2049         * Scripts/webkitpy/layout_tests/port/test_files.py:
2050         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2051
2052 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2053
2054         Reviewed by Tony Chang.
2055
2056         Change more modules in the layout-tests code to use the
2057         filesystem wrapper for cleaner unit testing.
2058
2059         This patch also adds the glob() wrapper to the filesystem
2060         abstraction.
2061         
2062         https://bugs.webkit.org/show_bug.cgi?id=52604
2063
2064         * Scripts/webkitpy/layout_tests/port/test_files.py:
2065         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2066         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2067         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2068         * Scripts/webkitpy/common/system/filesystem.py:
2069         * Scripts/webkitpy/common/system/filesystem_mock.py:
2070
2071 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2072
2073         Unreviewed.
2074
2075         Updating my email addresses and irc nick.
2076
2077         * Scripts/webkitpy/common/config/committers.py:
2078
2079 2011-01-19  Tony Chang  <tony@chromium.org>
2080
2081         Reviewed by Mihai Parparita.
2082
2083         [chromium] [linux] if check-sys-deps fails, output the failure reason
2084         https://bugs.webkit.org/show_bug.cgi?id=52671
2085
2086         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2087             error handler functions.
2088         * Scripts/webkitpy/layout_tests/port/chromium.py:
2089             output the error text from --check-sys-deps
2090         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2091
2092 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2093
2094         Reviewed by Andreas Kling.
2095
2096         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2097         https://bugs.webkit.org/show_bug.cgi?id=52554
2098         
2099         QtNetworkAccessManager is created in a thread and set as
2100         member variable in QWebPage. When the thread is destroyed
2101         the object is still used. So fix will set the object to
2102         NULL once the thread is destroyed.
2103
2104         * QtTestBrowser/launcherwindow.cpp:
2105         (LauncherWindow::~LauncherWindow):
2106
2107 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2108
2109         Rubber stamped by Csaba Osztrogonac
2110
2111         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2112
2113 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2114
2115         Reviewed by Tony Chang.
2116
2117         new-run-webkit-tests: add a --build-directory command line argument
2118
2119         Official Google Chrome builds use a non-standard build directory
2120         location. This patch adds a --build-directory argument that
2121         allows that location to be specified on the command line. Only
2122         Chromium-based builds will use this flag for now, but anyone can
2123         in the future.
2124
2125         There are no unit tests for this since it's difficult to test
2126         until mock filesystems are fully supported in the code. This was
2127         tested by hand for now.
2128
2129         https://bugs.webkit.org/show_bug.cgi?id=52694
2130
2131         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2132         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2133         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2134         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2135
2136 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2137
2138         Not reviewed. Bot fix.
2139
2140         Remove an inadvertently committed debugging print.
2141
2142         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2143         (LayoutTestController::notifyDone):
2144
2145 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2146
2147         Reviewed by Sam Weinig.
2148
2149         WebKitTestRunner should track loading more like DumpRenderTree
2150         https://bugs.webkit.org/show_bug.cgi?id=52692
2151
2152         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2153         This makes some tests that call notifyDone multiple times pass.
2154         
2155         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2156         (WTR::InjectedBundle::InjectedBundle):
2157         (WTR::InjectedBundle::done):
2158         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2159         (WTR::InjectedBundle::topLoadingFrame):
2160         (WTR::InjectedBundle::setTopLoadingFrame):
2161         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2162         (WTR::InjectedBundlePage::InjectedBundlePage):
2163         (WTR::InjectedBundlePage::stopLoading):
2164         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2165         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2166         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2167         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2168         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2169         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2170         (WTR::LayoutTestController::notifyDone):
2171         * WebKitTestRunner/TestController.cpp:
2172         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2173
2174 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2175
2176         Reviewed by Kent Tamura.
2177
2178         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2179         https://bugs.webkit.org/show_bug.cgi?id=52678
2180         
2181         Update path now that WebKit is inside Source.
2182
2183         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2184
2185 2011-01-18  Robert Hogan  <robert@webkit.org>
2186
2187         Reviewed by Simon Hausmann.
2188
2189         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2190         https://bugs.webkit.org/show_bug.cgi?id=44282
2191
2192         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2193         (WebCore::DumpRenderTree::dump):
2194
2195 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2196
2197         Reviewed by Mihai Parparita.
2198
2199         Fix a small race condition that could cause the unit tests for
2200         new-run-webkit-tests to fail in a multithreaded environment.
2201         There was a small window in the code where one thread would
2202         check to see if a thread had raised an exception, do something,
2203         and then check to see if the thread was alive. If the other
2204         thread raised an exception and exited in between these two
2205         steps, the exception would be lost. Flipping the order of the
2206         two checks fixes the race, since we will now always check for an
2207         exception on the thread before exiting.
2208
2209         https://bugs.webkit.org/show_bug.cgi?id=51579
2210
2211         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2212
2213 2011-01-18  Eric Seidel  <eric@webkit.org>
2214
2215         Reviewed by Adam Barth.
2216
2217         commit-queue dies when test archiving fails
2218         https://bugs.webkit.org/show_bug.cgi?id=52617
2219
2220         I looked at the machine and it had 10 archives already
2221         thus find_unused_name was returning None.  I've upped
2222         the limit to 100 (per bug) and tested the case where
2223         find_unused_name returns None (making archive return None).
2224
2225         * Scripts/webkitpy/common/system/workspace.py:
2226         * Scripts/webkitpy/common/system/workspace_unittest.py:
2227         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2228         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2229         * Scripts/webkitpy/tool/commands/queues.py:
2230
2231 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2232
2233         Reviewed by Ojan Vafai.
2234
2235         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2236         filesystem. Also fix a couple of "with" statements missed by
2237         r76050.
2238
2239         https://bugs.webkit.org/show_bug.cgi?id=52487
2240
2241         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2242
2243 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2244
2245         Reviewed by Martin Robinson.
2246
2247         [Gtk] Build fixes for gtk3 build
2248         https://bugs.webkit.org/show_bug.cgi?id=52648
2249
2250         * DumpRenderTree/gtk/EventSender.cpp:
2251         (beginDragWithFilesCallback):
2252
2253 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2254
2255         Reviewed by Mihai Parparita.
2256
2257         Update rebaseline-chromium-webkit-tests to use filesystem objects
2258         instead of direct references to os.path, shutil, tempfile, etc.
2259
2260         This patch doesn't change anything, but will allow subsequent
2261         patches to change the unit tests to no longer use the real
2262         filesystem.
2263
2264         This patch adds a bunch more methods to the filesystem object as
2265         well.
2266
2267         https://bugs.webkit.org/show_bug.cgi?id=52482
2268
2269         * Scripts/webkitpy/common/system/filesystem.py:
2270         * Scripts/webkitpy/common/system/filesystem_mock.py:
2271         * Scripts/webkitpy/tool/commands/queues.py:
2272         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2273         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2274
2275 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2276
2277         Reviewed by Mihai Parparita.
2278
2279         new-run-webkit-tests shouldn't crash when you try to run a
2280         directory containing only skipped files.
2281
2282         https://bugs.webkit.org/show_bug.cgi?id=52478
2283         
2284         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2285         * Scripts/webkitpy/layout_tests/port/test.py:
2286         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2287
2288 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2289
2290         Reviewed by Gustavo Noronha Silva.
2291
2292         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2293         https://bugs.webkit.org/show_bug.cgi?id=40833
2294
2295         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2296         GTK+ event sender.
2297         (dragWithFilesDragDataGetCallback): Added.
2298         (dragWithFilesDragEndCallback): Added.
2299         (beginDragWithFilesCallback): Added.
2300
2301 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2302
2303         Reviewed by Adam Barth.
2304
2305         ews: Add additional watcher to efl ews
2306         https://bugs.webkit.org/show_bug.cgi?id=52613
2307
2308         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2309
2310         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2311
2312 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2313
2314         Reviewed by Alexey Proskuryakov.
2315
2316         Fix some headers with missing or misspelled #ifndef guards
2317         https://bugs.webkit.org/show_bug.cgi?id=52545
2318
2319         * DumpRenderTree/chromium/TestEventPrinter.h:
2320         * DumpRenderTree/chromium/WebPreferences.h:
2321
2322 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2323
2324         Reviewed by Anders Carlsson.
2325
2326         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2327         navigating back to an unreachable URL
2328         https://bugs.webkit.org/show_bug.cgi?id=52388
2329
2330         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2331
2332         * DumpRenderTree/LayoutTestController.cpp:
2333         (queueLoadHTMLStringCallback):
2334         (LayoutTestController::queueLoadHTMLString):
2335         (LayoutTestController::queueLoadAlternateHTMLString):
2336         * DumpRenderTree/LayoutTestController.h:
2337
2338         * DumpRenderTree/WorkQueueItem.h:
2339         (LoadHTMLStringItem::LoadHTMLStringItem):
2340
2341         * DumpRenderTree/chromium/LayoutTestController.cpp:
2342         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2343         (WorkItemLoadHTMLString::run):
2344         (LayoutTestController::queueLoadHTMLString):
2345
2346         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2347         (LoadHTMLStringItem::invoke):
2348         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2349         (LoadHTMLStringItem::invoke):
2350         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2351         (LoadHTMLStringItem::invoke):
2352
2353 2011-01-17  Dan Bernstein  <mitz@apple.com>
2354
2355         Rubber-stamped by Mark Rowe.
2356
2357         Update xcodeproj svn:ignore to include xcuserdata.
2358
2359         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2360         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2361         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2362         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2363         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2364
2365 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2366
2367         Unreviewed fix after r75908.
2368
2369         Move WebKit into Source
2370         https://bugs.webkit.org/show_bug.cgi?id=52530
2371
2372         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2373
2374 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2375
2376         Unreviewed.
2377
2378         Remove accidentally committed debug printing after r75908.
2379
2380         * Scripts/webkitdirs.pm:
2381
2382 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2383
2384         Unreviewed.
2385
2386         Add myself to committers list
2387         https://bugs.webkit.org/show_bug.cgi?id=52566
2388
2389         * Scripts/webkitpy/common/config/committers.py:
2390
2391 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2392
2393         Reviewed by Jeremy Orlow.
2394
2395         GeolocationController should call stopUpdating on destruction
2396         https://bugs.webkit.org/show_bug.cgi?id=52216
2397
2398         fast/dom/Geolocation/window-close-crash.html requires that a
2399         Geolocation watch be started in a secondary window. Consequently,
2400         we need to allow geolocation permission and provide a mock
2401         geolocation position for the secondary window's
2402         GeolocationClientMock.
2403
2404         * DumpRenderTree/chromium/LayoutTestController.cpp:
2405         (LayoutTestController::setGeolocationPermission):
2406         (LayoutTestController::setMockGeolocationPosition):
2407         (LayoutTestController::setMockGeolocationError):
2408         * DumpRenderTree/chromium/TestShell.h:
2409         (TestShell::windowList):
2410
2411 2011-01-16  Adam Barth  <abarth@webkit.org>
2412
2413         Update more include paths to reflect WebKit move.
2414
2415         * DumpRenderTree/chromium/EventSender.cpp:
2416         (EventSender::keyDown):
2417         (EventSender::needsShiftModifier):
2418         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2419         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2420
2421 2011-01-16  Kent Tamura  <tkent@chromium.org>
2422
2423         Unreviewed, Chromium build fix.
2424
2425         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2426
2427 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2428
2429         Build fix for GTK+ after source directory movement.
2430
2431         * GNUmakefile.am: Correct include paths.
2432
2433 2011-01-16  Adam Barth  <abarth@webkit.org>
2434
2435         Teach svn-apply about WebKit move.
2436
2437         * Scripts/VCSUtils.pm:
2438
2439 2011-01-16  Adam Barth  <abarth@webkit.org>
2440
2441         Rubber-stamped by Eric Seidel.
2442
2443         Move WebKit into Source
2444         https://bugs.webkit.org/show_bug.cgi?id=52530
2445
2446         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2447         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2448         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2449         * DumpRenderTree/qt/GCControllerQt.cpp:
2450         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2451         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2452         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2453         * DumpRenderTree/wscript:
2454         * QtTestBrowser/launcherwindow.h:
2455         * Scripts/build-webkit:
2456         * Scripts/webkitdirs.pm:
2457
2458 2011-01-15  Adam Barth  <abarth@webkit.org>
2459
2460         Teach svn-apply about WebKit2 move.
2461
2462         * Scripts/VCSUtils.pm:
2463
2464 2011-01-15  Adam Barth  <abarth@webkit.org>
2465
2466         Rubber-stamped by Eric Seidel.
2467
2468         Move WebKit2 into Source
2469         https://bugs.webkit.org/show_bug.cgi?id=52438
2470
2471         * MiniBrowser/qt/MiniBrowser.pro:
2472         * Scripts/build-webkit:
2473         * Scripts/do-file-rename:
2474         * Scripts/do-webcore-rename:
2475         * Scripts/test-webkitpy:
2476         * Scripts/webkitdirs.pm:
2477         * Scripts/webkitpy/style/checker.py:
2478         * WebKitTestRunner/DerivedSources.pro:
2479         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2480         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2481
2482 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2483
2484         Reviewed by David Levin.
2485
2486         [chromium] remove obsolete createView method
2487         https://bugs.webkit.org/show_bug.cgi?id=52437
2488
2489         * DumpRenderTree/chromium/WebViewHost.cpp:
2490         (WebViewHost::createView):
2491         * DumpRenderTree/chromium/WebViewHost.h:
2492
2493 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2494
2495         Reviewed by Geoff Garen.
2496
2497         ShouldLoadResourceForFrame should use strings, not URLs.
2498         https://bugs.webkit.org/show_bug.cgi?id=52476
2499
2500         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2501         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2502         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2503
2504 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2505
2506         Reviewed by David Levin.
2507
2508         Add Tony Gentilcore as a reviewer
2509         https://bugs.webkit.org/show_bug.cgi?id=52480
2510
2511         * Scripts/webkitpy/common/config/committers.py:
2512
2513 2011-01-14  David Levin  <levin@chromium.org>
2514
2515         Reviewed by Eric Seidel.
2516
2517         check-webkit-style: _FunctionState should keep track of where the function name starts.
2518         https://bugs.webkit.org/show_bug.cgi?id=52454
2519
2520         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2521         _FunctionState and logic for setting it correctly.
2522         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2523
2524 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2525
2526         Reviewed by David Levin.
2527
2528         Add support to DumpRenderTree to use the GPU rather than software renderer
2529         https://bugs.webkit.org/show_bug.cgi?id=52333
2530
2531         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2532         (main):
2533         * Scripts/webkitpy/layout_tests/port/chromium.py:
2534         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2535
2536 2011-01-14  Tony Chang  <tony@chromium.org>
2537
2538         Reviewed by Kent Tamura.
2539
2540         [chromium] update fonts.conf to fix 6 linux tests in drt
2541         https://bugs.webkit.org/show_bug.cgi?id=52411
2542
2543         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2544             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2545
2546 2011-01-14  Eric Seidel  <eric@webkit.org>
2547
2548         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2549
2550         Reviewed by Adam Barth.
2551
2552         Fix when running Tools/Scripts/check-webkit-style without arguments.
2553         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2554
2555         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2556         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2557
2558 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2559
2560         Reviewed by David Levin.
2561
2562         Store the tempdir object in a variable so it doesn't get deleted too early.
2563         https://bugs.webkit.org/show_bug.cgi?id=51875
2564
2565         * Scripts/update-webkit-auxiliary-libs:
2566         * Scripts/update-webkit-support-libs:
2567
2568 2011-01-14  Eric Seidel  <eric@webkit.org>
2569
2570         Unreviewed.  Make it work in python 2.5.
2571
2572         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2573         https://bugs.webkit.org/show_bug.cgi?id=49158
2574
2575         * Scripts/webkitpy/common/checkout/api_unittest.py:
2576
2577 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2578
2579         Unreviewed, rolling out r75774.
2580         http://trac.webkit.org/changeset/75774
2581         https://bugs.webkit.org/show_bug.cgi?id=52431
2582
2583         gtk builds were broken (Requested by loislo2 on #webkit).
2584
2585         * Scripts/webkitpy/common/checkout/scm.py:
2586
2587 2011-01-14  David Levin  <levin@chromium.org>
2588
2589         Reviewed by Shinichiro Hamaji.
2590
2591         check-webkit-style: _FunctionState should detect pure functions.
2592         https://bugs.webkit.org/show_bug.cgi?id=52428
2593
2594         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2595         is a pure virtual function.
2596         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2597         virtual functions are correctly detected.
2598
2599 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2600
2601         Reviewed by Yury Semikhatsky.
2602
2603         Just small fix for problem with check-webkit-style.
2604         It just didn't work for this patch.
2605         Old code can't concatenate a list of strings with None.
2606
2607         * Scripts/webkitpy/common/checkout/scm.py:
2608
2609 2011-01-13  David Levin  <levin@chromium.org>
2610
2611         Reviewed by Shinichiro Hamaji.
2612
2613         check-webkit-style: _FunctionState should use Position to know where items are.
2614         https://bugs.webkit.org/show_bug.cgi?id=52424
2615
2616         * Scripts/webkitpy/style/checkers/cpp.py:
2617         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2618         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2619         did some minor clean-up.
2620         (*): Other changes are simply about converting to use the Position's in_FunctionState
2621         instead of line numbers.
2622         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2623         to verify the positions stored in _FunctionState.
2624
2625 2011-01-13  Eric Seidel  <eric@webkit.org>
2626
2627         Reviewed by David Levin.
2628
2629         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2630         https://bugs.webkit.org/show_bug.cgi?id=49158
2631
2632         This is not the most elegant, but it is a very safe fix to this bug.
2633         One advantage of catching ScriptError like this instead of adding a
2634         new added_or_modified_files or fixing all changed_files callers
2635         to use a more specific change_files variant, is that we catch
2636         all kinds of ScriptErrors which might cause our (non-essential)
2637         suggest-reviewers code to fail out.  This should make passing
2638         --suggest-reviewers to webkit-patch upload much more robust
2639         and may even make it possible for us to make it default.
2640
2641         The root of the problem here is that SCM.changed_files includes
2642         deleted ChangeLog paths (from moves, etc) which then when we ask
2643         SVN/Git for the contents of the file at that revision, the command
2644         errors out and Executive.run_command raises a ScriptError.
2645
2646         In the future we might fix this differently by making all current
2647         callers of chagned_files use a more specific method for requesting
2648         what types of changes they're interested in (adds, modifies, deletes, etc.)
2649
2650         * Scripts/webkitpy/common/checkout/api.py:
2651         * Scripts/webkitpy/common/checkout/api_unittest.py:
2652
2653 2011-01-13  Dan Bernstein  <mitz@apple.com>
2654
2655         Reviewed by Alexey Proskuryakov.
2656
2657         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2658         https://bugs.webkit.org/show_bug.cgi?id=52419
2659
2660         Allow to further control the behavior of the willSendRequest delegate callback by making it
2661         set a different URL in the new request.
2662
2663         * DumpRenderTree/LayoutTestController.cpp:
2664         (addURLToRedirectCallback): Added.
2665         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2666         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2667         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2668         * DumpRenderTree/LayoutTestController.h:
2669         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2670         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2671         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2672         change the URL in the new request to the redirect destination.
2673
2674 2011-01-13  Eric Seidel  <eric@webkit.org>
2675
2676         Reviewed by Mihai Parparita.
2677
2678         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2679         https://bugs.webkit.org/show_bug.cgi?id=52416
2680
2681         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2682         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2683
2684         I also added FIXMEs about the changed_files returning deleted files problem
2685         which is causing the other most common exception for suggest-reviewers
2686         (and is probably breaking sheriff-bots blame detection).
2687
2688         * Scripts/webkitpy/common/checkout/api.py:
2689         * Scripts/webkitpy/common/checkout/api_unittest.py:
2690         * Scripts/webkitpy/common/checkout/scm.py:
2691
2692 2011-01-13  Eric Seidel  <eric@webkit.org>
2693
2694         Reviewed by Adam Barth.
2695
2696         results archives from commit-queue are too large to upload
2697         https://bugs.webkit.org/show_bug.cgi?id=52405
2698
2699         * Scripts/webkitpy/common/system/filesystem.py:
2700         * Scripts/webkitpy/common/system/filesystem_mock.py:
2701         * Scripts/webkitpy/tool/commands/queues.py:
2702
2703 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2704
2705         Reviewed by Martin Robinson.
2706
2707         [gtk] Zero-sized font does not yet work
2708         https://bugs.webkit.org/show_bug.cgi?id=49793
2709
2710         Set minimum-font-size to 0 for the DRT.
2711
2712         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2713         (resetDefaultsToConsistentValues):
2714
2715 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2716
2717         Reviewed by Darin Adler.
2718
2719         Make old-run-webkit-tests more robust on buildbots
2720         https://bugs.webkit.org/show_bug.cgi?id=52364
2721
2722         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2723
2724 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2725
2726         Reviewed by Darin Adler.
2727
2728         Make old-run-webkit-tests more robust on buildbots
2729         https://bugs.webkit.org/show_bug.cgi?id=52364
2730
2731         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2732
2733 2011-01-13  Tony Chang  <tony@chromium.org>
2734
2735         Reviewed by Kent Tamura.
2736
2737         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2738         https://bugs.webkit.org/show_bug.cgi?id=52332
2739
2740         Forked Info.plist is not longer needed.
2741
2742         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2743
2744 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2745
2746         Reviewed by Timothy Hatcher.
2747
2748         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2749         to be passed directly to WebInspector.UIString
2750
2751         https://bugs.webkit.org/show_bug.cgi?id=52365
2752
2753         * Scripts/check-inspector-strings:
2754
2755 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2756
2757         Unreviewed, rolling out r74881.
2758         http://trac.webkit.org/changeset/74881
2759         https://bugs.webkit.org/show_bug.cgi?id=52357
2760
2761         The EFL builder has been red for days (Requested by abarth on
2762         #webkit).
2763
2764         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2765         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2766
2767 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2768
2769         Reviewed by David Levin.
2770
2771         Add beforeunload support to WebKitTestRunner
2772         https://bugs.webkit.org/show_bug.cgi?id=52353
2773         
2774         This makes a number of currently failing tests pass.
2775
2776         * WebKitTestRunner/TestController.cpp:
2777         (WTR::runBeforeUnloadConfirmPanel):
2778         (WTR::createOtherPage):
2779         (WTR::TestController::initialize):
2780
2781 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2782
2783         Reviewed by Sam Weinig.
2784
2785         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2786         https://bugs.webkit.org/show_bug.cgi?id=52330
2787
2788         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2789         a web process crash.
2790         * WebKitTestRunner/TestController.cpp:
2791         (WTR::TestController::initialize): Set up a processDidCrash
2792         callback.
2793         (WTR::TestController::processDidCrash): Report that the Web process
2794         crashed.
2795         * WebKitTestRunner/TestController.h:
2796
2797 2011-01-12  David Levin  <levin@chromium.org>
2798
2799         Reviewed by Shinichiro Hamaji.
2800
2801         check-webkit-style -- close_expression function doesn't work correctly.
2802         https://bugs.webkit.org/show_bug.cgi?id=52272
2803
2804         * Scripts/webkitpy/style/checkers/cpp.py:
2805         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2806         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2807         generally useful (for upcoming code changes).
2808         (close_expression): Changed to use Position for input and output.
2809         Also, fixed many bugs such as only working correctly for parenthesis,
2810         not working correctly if given an offset in a line and not finding
2811         the real closing element if there were multiple closing elements in
2812         the same line.
2813         (detect_functions): Adjusted due to the change in arguments for
2814         close_expression.
2815         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2816         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2817         two positions are the same.
2818         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2819         (CppStyleTest.test_close_expression): Added tests to catch the issues
2820         that were fixed.
2821
2822 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2823
2824         Unreviewed, rolling out r75576.
2825         http://trac.webkit.org/changeset/75576
2826         https://bugs.webkit.org/show_bug.cgi?id=52304
2827
2828         broke rebaseline-chromium-webkit-test (Requested by thakis on
2829         #webkit).
2830
2831         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2832         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2833         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2834         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2835         * Scripts/webkitpy/layout_tests/port/base.py:
2836         * Scripts/webkitpy/layout_tests/port/chromium.py:
2837         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2838         * Scripts/webkitpy/layout_tests/port/test.py:
2839         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2840         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2841         * Scripts/webkitpy/style/checkers/test_expectations.py:
2842         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2843
2844 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2845
2846         Reviewed by Darin Adler.
2847
2848         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2849         https://bugs.webkit.org/show_bug.cgi?id=52307
2850
2851         * Scripts/old-run-webkit-tests:
2852
2853 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2854
2855         Reviewed by Martin Robinson.
2856
2857         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2858         https://bugs.webkit.org/show_bug.cgi?id=50867
2859
2860         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2861         TestNetscapePlugin.cpp 
2862
2863         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2864         * Scripts/webkitdirs.pm:
2865
2866 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2867
2868         Reviewed by Pavel Feldman.
2869
2870         Add check-inspector-strings script.
2871
2872         https://bugs.webkit.org/show_bug.cgi?id=52295
2873
2874         * Scripts/check-inspector-strings: Added.
2875
2876 2011-01-12  Adam Roben  <aroben@apple.com>
2877
2878         Advertise the .testnetscape file extension on Windows
2879
2880         Fixes <http://webkit.org/b/52298>
2881         plugins/no-mime-with-valid-extension.html fails on Windows
2882
2883         Reviewed by Dan Bernstein.
2884
2885         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2886         FileExtents field to map the .testnetscape file extension to the
2887         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2888
2889 2011-01-12  Adam Barth  <abarth@webkit.org>
2890
2891         Reviewed by Eric Seidel.
2892
2893         Make webkit-patch support subdirectories for SVN checkouts
2894         https://bugs.webkit.org/show_bug.cgi?id=52261
2895
2896         os.relpath does not exist on Python 2.5, so we need to call our version
2897         of the API.
2898
2899         * Scripts/webkitpy/common/checkout/scm.py:
2900
2901 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2902
2903         Reviewed by Eric Seidel.
2904
2905         Close additional pages opened during a test once the test completes.
2906         https://bugs.webkit.org/show_bug.cgi?id=52276
2907
2908         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2909         (WTR::InjectedBundle::done):
2910
2911 2011-01-11  David Levin  <levin@chromium.org>
2912
2913         Reviewed by Eric Seidel.
2914
2915         Errors should be separated from the command line in bot messages.
2916         https://bugs.webkit.org/show_bug.cgi?id=52275
2917
2918         * Scripts/webkitpy/common/system/executive.py:
2919         (ScriptError.message_with_output): Added a newline to separate the command
2920         line from the errors.
2921         * Scripts/webkitpy/common/system/executive_unittest.py:
2922         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2923         paths in message_with_output.
2924
2925 2011-01-11  Eric Seidel  <eric@webkit.org>
2926
2927         Unreviewed.
2928
2929         commit-queue should know how to upload archived results (for test flakes or general failures)
2930         https://bugs.webkit.org/show_bug.cgi?id=52048
2931
2932         The zips are mostly empty due to forgetting -r.
2933         Expected diffs were not being pulled from the archive due
2934         to the archive having longer paths than I realized.
2935
2936         * Scripts/webkitpy/common/system/workspace.py:
2937         * Scripts/webkitpy/common/system/workspace_unittest.py:
2938         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2939         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2940
2941 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2942
2943         Reviewed by Ojan Vafai.
2944
2945         The current modifier parsing code in test_expectations is
2946         fragile and hard-coded, so it's not easy to understand the logic
2947         or easily add new types of modifiers (like GPU vs. CPU testing
2948         for graphics tests, or 32-bit vs. 64-bit differences).
2949
2950         This is the first of two patches that will add in more generic
2951         support and then eliminate the GPU-specific test expectations
2952         files for Chromium.
2953
2954         This patch adds two standalone objects for handling modifiers. The
2955         rules for interpreting modifiers, precedence, and conflicts are
2956         given in the docstring to the ModifierMatcher class, which
2957         returns ModifierMatchResult objects.
2958         
2959         This patch also adds routines to the Port interface and a
2960         default set of values in the base object, in order to obtain the
2961         values needed on a given test run. These values are then passed
2962         to the expectation parser. This also allows us to clean up the
2963         logic used to lint all of the different configurations in a
2964         single test_expectations.txt file.
2965
2966         The next patch will merge in the separate GPU expectations file.
2967
2968         https://bugs.webkit.org/show_bug.cgi?id=51222
2969
2970         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2971         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2972         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2973         * Scripts/webkitpy/layout_tests/port/base.py:
2974         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2975         * Scripts/webkitpy/layout_tests/port/chromium.py:
2976         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2977         * Scripts/webkitpy/layout_tests/port/test.py:
2978         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2979         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2980
2981 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2982
2983         Reviewed by Adam Barth.
2984
2985         Make webkit-patch support subdirectories for SVN checkouts
2986         https://bugs.webkit.org/show_bug.cgi?id=52261
2987
2988         * Scripts/webkitpy/common/checkout/scm.py:
2989         * Scripts/webkitpy/style_references.py:
2990         * Scripts/webkitpy/tool/main.py:
2991         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2992
2993 2011-01-11  Eric Seidel  <eric@webkit.org>
2994
2995         Unreviewed.
2996
2997         commit-queue should know how to upload archived results (for test flakes or general failures)
2998         https://bugs.webkit.org/show_bug.cgi?id=52048
2999
3000         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3001         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3002
3003         * Scripts/webkitpy/common/system/workspace.py:
3004         * Scripts/webkitpy/common/system/workspace_unittest.py:
3005         * Scripts/webkitpy/tool/commands/queues.py:
3006
3007 2011-01-11  Sam Weinig  <sam@webkit.org>
3008
3009         Roll r75474 back in.
3010
3011 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3012
3013         Reviewed by Kenneth Rohde Christiansen.
3014
3015         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3016         https://bugs.webkit.org/show_bug.cgi?id=51204
3017
3018         * QtTestBrowser/webpage.h:
3019         (QtNAMThread::QtNAMThread):
3020         (QtNAMThread::networkAccessManager):
3021         (QtNAMThread::run):
3022
3023 2011-01-11  Peter Varga  <pvarga@webkit.org>
3024
3025         Unreviewed.
3026
3027         Add myself to committers' list.
3028
3029         * Scripts/webkitpy/common/config/committers.py:
3030
3031 2011-01-11  Eric Seidel  <eric@webkit.org>
3032
3033         Reviewed by Adam Barth.
3034
3035         commit-queue should know how to upload archived results (for test flakes or general failures)
3036         https://bugs.webkit.org/show_bug.cgi?id=52048
3037
3038         Now the queue will always upload results.  Either the entire zip, or just
3039         the diffs.txt in the case of text failures.
3040
3041         This should make understanding flakes much easier, and paves the way
3042         for having the EWS run layout tests (and upload failures).
3043
3044         In order to upload .zip files I had to teach bugzilla.py to autodetect
3045         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3046         for .patch files, I have it add one before calling guess_type.
3047
3048         We may find that always uploading the whole zip instead of just the -diffs.txt
3049         file is preferable, but for now I'm keeping the old behavior because it makes
3050         quickly understanding text failures easy.
3051
3052         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3053         * Scripts/webkitpy/common/system/workspace.py: Added.
3054         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3055         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3056         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3057         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3058         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3059         * Scripts/webkitpy/tool/commands/queues.py:
3060         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3061
3062 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3063
3064         Unreviewed, rolling out r75464.
3065         http://trac.webkit.org/changeset/75464
3066         https://bugs.webkit.org/show_bug.cgi?id=52193
3067
3068         Followup rollout for 75474 (Requested by Ossy on #webkit).
3069
3070         * MiniBrowser/mac/BrowserWindowController.m:
3071         (-[BrowserWindowController awakeFromNib]):
3072         * MiniBrowser/win/BrowserView.cpp:
3073         (BrowserView::create):
3074         * WebKitTestRunner/TestController.cpp:
3075         (WTR::createOtherPage):
3076         (WTR::TestController::initialize):
3077
3078 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3079
3080         Reviewed by Csaba Osztrogonác.
3081
3082         [Qt] Baseline qt_minimal configuration
3083         https://bugs.webkit.org/show_bug.cgi?id=51313
3084
3085         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3086         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3087         QT_NO_UNDOSTACK guard.
3088
3089         * QtTestBrowser/launcherwindow.cpp:
3090         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3091         guards.
3092         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3093         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3094         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3095         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3096
3097         * QtTestBrowser/launcherwindow.h:
3098         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3099         * QtTestBrowser/locationedit.h: Ditto.
3100
3101         * QtTestBrowser/mainwindow.cpp:
3102         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3103         QT_NO_UNDOSTACK guards.
3104         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3105         (MainWindow::changeLocation): Ditto.
3106         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3107         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3108
3109         * QtTestBrowser/webpage.cpp:
3110         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3111         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3112
3113         * QtTestBrowser/webview.cpp:
3114         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3115         (WebViewGraphicsBased::animatedYFlip): Ditto.
3116
3117 2011-01-10  Sam Weinig  <sam@webkit.org>
3118
3119         Fix build.
3120
3121         * MiniBrowser/mac/BrowserWindowController.m:
3122         (-[BrowserWindowController awakeFromNib]):
3123         * MiniBrowser/win/BrowserView.cpp:
3124         (BrowserView::create):
3125         * WebKitTestRunner/TestController.cpp:
3126         (WTR::createOtherPage):
3127         (WTR::TestController::initialize):
3128
3129 2011-01-10  Eric Seidel  <eric@webkit.org>
3130
3131         Reviewed by Ojan Vafai.
3132
3133         style-queue messages are way too long for big patches
3134         https://bugs.webkit.org/show_bug.cgi?id=52161
3135
3136         We definitely could build much fancier list-to-string-with-limit functions
3137         but this should be sufficient for our needs at the moment.
3138
3139         * Scripts/webkitpy/common/system/executive.py:
3140         * Scripts/webkitpy/common/system/executive_unittest.py:
3141
3142 2011-01-10  Tony Chang  <tony@chromium.org>
3143
3144         Unreviewed, rolling out r75398.
3145         http://trac.webkit.org/changeset/75398
3146         https://bugs.webkit.org/show_bug.cgi?id=52008
3147
3148         Some layout tests are crashing on Chromium Win.
3149
3150         * DumpRenderTree/chromium/WebViewHost.cpp:
3151         (WebViewHost::updatePaintRect):
3152         * DumpRenderTree/chromium/WebViewHost.h:
3153
3154 2011-01-10  Adam Roben  <aroben@apple.com>
3155
3156         Roll out r75392
3157
3158         It isn't needed now that r75289 has been rolled out.
3159
3160         * Scripts/run-javascriptcore-tests:
3161
3162 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3163
3164         Reviewed by Anders Carlsson.
3165
3166         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3167         https://bugs.webkit.org/show_bug.cgi?id=52160
3168
3169         * WebKitTestRunner/mac/TestControllerMac.mm:
3170         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3171         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3172         anyway.
3173
3174 2011-01-10  Tony Chang  <tony@chromium.org>
3175
3176         Reviewed by Mihai Parparita.
3177
3178         [chromium] fix for animated gif layout tests
3179         https://bugs.webkit.org/show_bug.cgi?id=52008
3180
3181         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3182             to trigger gif animations.
3183         (WebViewHostPaintTask::WebViewHostPaintTask):
3184         (WebViewHostPaintTask::runIfValid):
3185         (WebViewHost::updatePaintRect):
3186         * DumpRenderTree/chromium/WebViewHost.h:
3187         (WebViewHost::taskList):
3188
3189 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3190
3191         Reviewed by Xan Lopez.
3192
3193         [GTK] Fix gtk2 compilation for master
3194         https://bugs.webkit.org/show_bug.cgi?id=51885
3195
3196         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3197         (createBitmapContextFromWebView): Replaced the old
3198         gdk_drawable_get_size with gdk_pixmap_get_size.
3199
3200 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3201
3202         Reviewed by Laszlo Gombos.
3203
3204         [WINCE] Reenable NPAPI after r75203
3205         https://bugs.webkit.org/show_bug.cgi?id=52109
3206
3207         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3208         it with !isEfl(), because EFL port does not support NPAPI (yet).
3209
3210         * Scripts/build-webkit:
3211
3212 2011-01-10  Adam Roben  <aroben@apple.com>
3213
3214         Skip some asserting JS tests
3215
3216         See <http://webkit.org/b/52156>.
3217
3218         * Scripts/run-javascriptcore-tests:
3219
3220 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3221
3222         Reviewed by Xan Lopez.
3223
3224         [GTK] build-webkit disable Blob support via arguments passed to automake
3225         https://bugs.webkit.org/show_bug.cgi?id=52097
3226
3227         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3228         build-webkit.
3229
3230 2011-01-10  Adam Roben  <aroben@apple.com>
3231
3232         Use the same name and description for TestNetscapePlugin on Windows and
3233         Mac
3234
3235         Fixes <http://webkit.org/b/52151>
3236         fast/frames/iframe-reparenting-plugins.html fails on Windows
3237
3238         Reviewed by Steve Falkenburg.
3239
3240         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3241         the name and description from Mac's Info.plist.
3242
3243 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3244
3245         Reviewed by Laszlo Gombos.
3246
3247         [Qt][WK2] Guard gcc-specific syntax
3248
3249         Non-gcc based compliers choke on the "-include"
3250         syntax for preinclude, place guard around it.
3251
3252         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3253         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3254
3255 2011-01-10  Andreas Kling  <kling@webkit.org>
3256
3257         Reviewed by Simon Hausmann.
3258
3259         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3260         https://bugs.webkit.org/show_bug.cgi?id=52111
3261
3262         When getting a createNewPage() callback from QWKPage, create the
3263         new page with the same QWKContext as the page that is passed to
3264         the callback.
3265
3266         * MiniBrowser/qt/BrowserView.h:
3267         * MiniBrowser/qt/BrowserWindow.cpp:
3268         (newPageFunction):
3269         (BrowserWindow::BrowserWindow):
3270         * MiniBrowser/qt/BrowserWindow.h:
3271
3272 2011-01-10  Andreas Kling  <kling@webkit.org>
3273
3274         Reviewed by Kenneth Rohde Christiansen.
3275
3276         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3277
3278         BrowserView set its own useless createNewPage() callback on QWKPage.
3279         This was immediately overridden by BrowserWindow anyway, so remove
3280         the BrowserView one.
3281
3282         * MiniBrowser/qt/BrowserView.cpp:
3283         (BrowserView::BrowserView):
3284
3285 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3286
3287         Reviewed by Jeremy Orlow.
3288
3289         [Chromium] Remove non-client-based Geolocation code
3290         https://bugs.webkit.org/show_bug.cgi?id=50921
3291
3292         * DumpRenderTree/chromium/LayoutTestController.cpp:
3293         (LayoutTestController::setGeolocationPermission):
3294         (LayoutTestController::setMockGeolocationPosition):
3295         (LayoutTestController::setMockGeolocationError):
3296         * DumpRenderTree/chromium/WebViewHost.cpp:
3297         (WebViewHost::geolocationClientMock):
3298         (WebViewHost::reset):
3299         * DumpRenderTree/chromium/WebViewHost.h:
3300
3301 2011-01-10  Eric Seidel  <eric@webkit.org>
3302
3303         Reviewed by Adam Barth.
3304
3305         Commit bot tried to land r? cq+ patch
3306         https://bugs.webkit.org/show_bug.cgi?id=36638
3307
3308         It should now be possible to post a patch with r? and cq+ and the
3309         commit-queue will correctly wait for the r+ before attempting to land the patch.
3310         (This was a feature requested by several users.)
3311
3312         One caveat: We don't actually reject r-, cq+ patches from the queue
3313         (we just ignore them), but I think that's OK for now.
3314
3315         I also noticed that setting r- once a commit-queue node had grabbed
3316         a patch would not properly cancel the landing.  That's fixed and
3317         tested in this patch.
3318
3319         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3320         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3321         * Scripts/webkitpy/tool/bot/feeders.py:
3322         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3323
3324 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3325
3326         Reviewed by Kenneth Rohde Christiansen.
3327
3328         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3329         https://bugs.webkit.org/show_bug.cgi?id=51934
3330
3331         When accessing the network from the destructor of QWebPage, the network access manager
3332         was already deleted because the object WebPage was already destructed.
3333
3334         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3335         The object is now destructed in the destructor of QObject.
3336
3337         * QtTestBrowser/webpage.cpp:
3338         (WebPage::WebPage):
3339         (WebPage::setQnamThreaded):
3340         * QtTestBrowser/webpage.h:
3341         (QtNAMThread::QtNAMThread):
3342
3343 2011-01-08  Eric Seidel  <eric@webkit.org>
3344
3345         Reviewed by Ojan Vafai.
3346
3347         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3348         https://bugs.webkit.org/show_bug.cgi?id=52067
3349
3350         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3351         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3352
3353         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3354
3355 2011-01-08  Eric Seidel  <eric@webkit.org>
3356
3357         Reviewed by Mihai Parparita.
3358
3359         commit-queue hangs when the ChangeLog diff is bad
3360         https://bugs.webkit.org/show_bug.cgi?id=52072
3361
3362         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3363         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3364
3365 2011-01-08  Adam Barth  <abarth@webkit.org>
3366
3367         Teach svn-apply how to re-write WebCore to Source/WebCore.
3368
3369         * Scripts/VCSUtils.pm:
3370
3371 2011-01-07  Adam Barth  <abarth@webkit.org>
3372
3373         Rubber-stamped by Eric Seidel.
3374
3375         Move WebCore to Source
3376         https://bugs.webkit.org/show_bug.cgi?id=52050
3377
3378         Update the tools to understand WebCore's new location.
3379
3380         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3381         * DumpRenderTree/wscript:
3382         * GNUmakefile.am:
3383         * Scripts/build-webkit:
3384         * Scripts/do-file-rename:
3385         * Scripts/do-webcore-rename:
3386         * Scripts/generate-qt-inspector-resource:
3387         * Scripts/prepare-ChangeLog:
3388         * Scripts/run-bindings-tests:
3389         * Scripts/update-iexploder-cssproperties:
3390         * Scripts/update-sources-list.py:
3391         * Scripts/update-webkit-localizable-strings:
3392         * Scripts/webkitdirs.pm:
3393         * Scripts/webkitpy/common/config/build.py:
3394         * Scripts/webkitpy/common/config/build_unittest.py:
3395         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3396         * Scripts/webkitpy/style/checker.py:
3397         * Scripts/webkitpy/style/checker_unittest.py:
3398         * WebKitTestRunner/DerivedSources.pro:
3399         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3400         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3401         * wx/browser/wscript:
3402         * wx/build/settings.py:
3403
3404 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3405
3406         Reviewed by Sam Weinig.
3407
3408         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3409         https://bugs.webkit.org/show_bug.cgi?id=52086
3410
3411         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3412         (WTR::InjectedBundle::didReceiveMessage):
3413         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3414         (WTR::LayoutTestController::notifyDone):
3415         * WebKitTestRunner/TestController.cpp:
3416         (WTR::TestController::resetStateToConsistentValues):
3417         (WTR::TestController::run):
3418
3419 2011-01-07  James Robinson  <jamesr@chromium.org>
3420
3421         Revert "Implement mozilla's animationTime property"
3422         https://bugs.webkit.org/show_bug.cgi?id=51952
3423
3424         This approach isn't quite right.
3425
3426         * DumpRenderTree/chromium/WebViewHost.cpp:
3427         (WebViewHost::paintInvalidatedRegion):
3428
3429 2011-01-07  Adam Roben  <aroben@apple.com>
3430
3431         Build master fix
3432
3433         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3434         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3435
3436 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3437
3438         Reviewed by Csaba Osztrogonác.
3439
3440         run-qtwebkit-tests should be able to kill a testsuite.
3441
3442         Add new option in the script that can setup a timeout for a test.
3443         If the test execution takes more then specified time then the test
3444         would be terminated.
3445
3446         [Qt] run-qtwebkit-tests needs timeout
3447         https://bugs.webkit.org/show_bug.cgi?id=51894
3448
3449         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3450         * Scripts/run-qtwebkit-tests:
3451
3452 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3453
3454         Unreviewed fix after r75233.
3455
3456         Based on idea from Eric Seidel.
3457
3458         Add remote zip file handling to webkitpy.
3459         https://bugs.webkit.org/show_bug.cgi?id=50901
3460
3461         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3462
3463 2011-01-07  Shane Stephens  <shanestephens@google.com>
3464
3465         Reviewed by Eric Seidel.
3466
3467         svn-apply: should support git binary delta diffs
3468         https://bugs.webkit.org/show_bug.cgi?id=38864
3469
3470         * Scripts/VCSUtils.pm:
3471         * Scripts/svn-apply:
3472
3473 2011-01-06  Julie Parent  <jparent@chromium.org>
3474
3475         Reviewed by Eric Seidel.
3476
3477         Test Result Server not removing old results.
3478         https://bugs.webkit.org/show_bug.cgi?id=52012
3479
3480         * TestResultServer/model/jsonresults.py:
3481         Fix off-by-one: Truncate if >= num_runs, not just >.
3482         * TestResultServer/model/jsonresults_unittest.py:
3483         Add unit test to test that merging in a new result with the same value
3484         as the last result causes previous result to fall off.
3485
3486 2011-01-06  James Kozianski  <koz@chromium.org>
3487
3488         Reviewed by Mihai Parparita.
3489
3490         Add classes to provide a consistent interface to a set of files.
3491         https://bugs.webkit.org/show_bug.cgi?id=50901
3492
3493         These classes allow us to write code that is agnostic to whether a
3494         particular set of files resides in a local directory or in a zip file
3495         on a remote machine.
3496
3497         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3498         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3499         * Scripts/webkitpy/common/system/fileset.py: Added.
3500         * Scripts/webkitpy/common/system/filesystem.py:
3501         * Scripts/webkitpy/common/system/filesystem_mock.py:
3502         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3503         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3504
3505 2011-01-06  Eric Seidel  <eric@webkit.org>
3506
3507         Reviewed by Adam Barth.
3508
3509         NetworkTransaction should log the url it is retrying
3510         https://bugs.webkit.org/show_bug.cgi?id=52043
3511
3512         * Scripts/webkitpy/common/net/networktransaction.py:
3513         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3514
3515 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3516
3517         Windows build fix.
3518         Import os before using it.
3519
3520         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3521
3522 2011-01-06  Eric Seidel  <eric@webkit.org>
3523
3524         Reviewed by Adam Barth.
3525
3526         StyleQueue fails to report errors when patches have many files
3527         https://bugs.webkit.org/show_bug.cgi?id=52042
3528
3529         This is one of at least two errors preventing style error reporting at the moment.
3530         When we moved to passing the list of files to check explicitly,
3531         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3532         We could change the type of the QueueStatus.message type, or we could
3533         just teach statusserver.py how to clamp values (and warn when it does).
3534         I chose the latter path.
3535
3536         * Scripts/webkitpy/common/net/statusserver.py:
3537
3538 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3539
3540         Reviewed by Stephanie Lewis.
3541         
3542         Fix syntax error in script.
3543
3544         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3545         https://bugs.webkit.org/show_bug.cgi?id=51996
3546
3547         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3548
3549 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3550
3551         Unreviewed, fixing WinCE build after r75196.
3552
3553         WinCE port does not (yet) support NPAPI.
3554
3555         * Scripts/build-webkit:
3556
3557 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3558
3559         Reviewed by Darin Adler.
3560
3561         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3562         https://bugs.webkit.org/show_bug.cgi?id=52015
3563
3564         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3565         after the platform has been detected, otherwise the script will
3566         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3567         detection.
3568
3569 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3570
3571         Reviewed by Eric Seidel.
3572
3573         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3574         https://bugs.webkit.org/show_bug.cgi?id=51346
3575
3576         * Scripts/build-webkit:
3577
3578 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3579
3580         Reviewed by Adam Roben.
3581
3582         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3583         https://bugs.webkit.org/show_bug.cgi?id=51996
3584         
3585         After the configuration directory change, we were archiving the incorrect directory for
3586         build product, so we were running tests on the wrong binaries.
3587         
3588         This change archives the correct directory, and also unarchives it into a configuration-
3589         specific directory.
3590
3591         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3592         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3593
3594 2011-01-06  Eric Seidel  <eric@webkit.org>
3595
3596         Reviewed by Mihai Parparita.
3597
3598         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3599         https://bugs.webkit.org/show_bug.cgi?id=52002
3600
3601         See an example of this here:
3602         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3603
3604         It's due to the fact that we pass around TestFailure() instance
3605         objects and yet expect them to all compare to be the same.
3606
3607         This is bad.  We should either have shared instances of these values
3608         or we should just pass around the class names.  There are already hacks
3609         in place to make TestFailure objects pass equality tests, I just added
3610         a __hash__ implementation so they can be used in sets as expected.
3611
3612         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3613         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3614
3615 2011-01-06  Evan Martin  <evan@chromium.org>
3616
3617         Reviewed by Tony Chang.
3618
3619         [gdb] handle inaccessible memory and UChar*
3620         https://bugs.webkit.org/show_bug.cgi?id=52003
3621
3622         To pretty-print a UChar*, we just grope around in the memory
3623         looking for a terminating NUL.  We need to handle the exception
3624         that can occur when we poke into an invalid location.
3625
3626         Additionally, the logic for choosing which pretty-printer would
3627         early return before hitting the point where we'd use the UChar*
3628         printer.  (Did this ever work?  How did it regress?)
3629
3630         * gdb/webkit.py:
3631
3632 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3633
3634         Reviewed by Ada Chan.
3635
3636         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3637         https://bugs.webkit.org/show_bug.cgi?id=51969
3638         
3639         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3640
3641         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3642         (WTR::InjectedBundlePage::InjectedBundlePage):
3643         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3644         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3645
3646 2011-01-06  James Robinson  <jamesr@chromium.org>
3647
3648         Reviewed by Simon Fraser.
3649
3650         Implement mozilla's animationTime property
3651         https://bugs.webkit.org/show_bug.cgi?id=51952
3652
3653         Chromium DRT support for webkitAnimationTime.
3654
3655         * DumpRenderTree/chromium/WebViewHost.cpp:
3656         (WebViewHost::paintInvalidatedRegion):
3657
3658 2011-01-06  Julie Parent  <jparent@chromium.org>
3659
3660         Reviewed by Tony Chang.
3661
3662         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3663         https://bugs.webkit.org/show_bug.cgi?id=51217
3664
3665         * TestResultServer/model/jsonresults.py:
3666         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3667         Adds missing documentation.
3668         * TestResultServer/model/jsonresults_unittest.py:
3669         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3670         Update test_merge to take a number of builds to truncate at.
3671
3672 2011-01-06  Adam Barth  <abarth@webkit.org>
3673
3674         Reviewed by Eric Seidel.
3675
3676         The EWS should log outside of the working directory
3677         https://bugs.webkit.org/show_bug.cgi?id=51986
3678
3679         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3680         script, which will actually clean the working copy back to a pristine
3681         state instead of leaving untracked directories and ignored files.
3682
3683         * Scripts/webkitpy/tool/commands/queues.py:
3684         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3685
3686 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3687
3688         Windows build fix.
3689         Back out attempted change to built-product-archive.
3690
3691         * BuildSlaveSupport/built-product-archive:
3692
3693 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3694
3695         Windows build fix.
3696         Include configuration name when unpacking a build archive.
3697
3698         Needed, since we split Windows build results into configuration-specific directories
3699         under WebKitOutputDir.
3700
3701         * BuildSlaveSupport/built-product-archive:
3702
3703 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3704
3705         Reviewed by Darin Adler.
3706
3707         Debug and Release builds on Windows clobber each other
3708         https://bugs.webkit.org/show_bug.cgi?id=49185
3709
3710         Changes the structure of WebKitBuild build products directory so we
3711         completely separate each build configuration into independent directories.
3712         
3713         Although we previously had per-configuration directories for obj, this change adds
3714         per-configuration directories for bin, lib, obj, and include. Each configuration's
3715         build products are stored within a directory inside of WebKitBuild.
3716         
3717         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3718         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3719
3720         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3721         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3722         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3723         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3724         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3725         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3726         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3727         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3728         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3729         * FindSafari/FindSafari.vcproj:
3730         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3731         * MiniBrowser/MiniBrowserPostBuild.cmd:
3732         * MiniBrowser/MiniBrowserPreBuild.cmd:
3733         * Scripts/webkitdirs.pm:
3734         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3735         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3736         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3737         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3738         * TestWebKitAPI/win/copy-resources.cmd:
3739         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3740         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3741         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3742         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3743         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3744         * WebKitTestRunner/win/InjectedBundle.vcproj:
3745         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3746         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3747         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3748         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3749         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3750         * WinLauncher/WinLauncherCommon.vsprops:
3751         * WinLauncher/WinLauncherPostBuild.cmd:
3752         * WinLauncher/WinLauncherPreBuild.cmd:
3753
3754 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3755
3756         Reviewed by Ariya Hidayat.
3757
3758         [Qt] TestNetscapePlugin doesn't link on OS X
3759         https://bugs.webkit.org/show_bug.cgi?id=51948
3760
3761         Only add a dependency on libX11 on X11 systems
3762
3763         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3764
3765 2011-01-05  Jeff Miller  <jeffm@apple.com>
3766
3767         Reviewed by Adam Roben.
3768
3769         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3770         https://bugs.webkit.org/show_bug.cgi?id=51970
3771
3772         * Scripts/webkitpy/style/checker.py:
3773         Add -readability/naming for WebKit2 C API directories.
3774
3775 2011-01-05  Eric Seidel  <eric@webkit.org>
3776
3777         Unreviewed, just fixing one more log error from my previous python patch.
3778
3779         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3780         https://bugs.webkit.org/show_bug.cgi?id=51802
3781
3782         webkit-patch failure-reason was logging about parsing errors
3783         due to my misunderstanding of how BeautifulSoup.findAll worked.
3784
3785         Fixed, and added a unit test.
3786
3787         * Scripts/webkitpy/common/net/layouttestresults.py:
3788         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3789
3790 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3791
3792         Reviewed by Kenneth Rohde Christiansen.
3793
3794         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3795         https://bugs.webkit.org/show_bug.cgi?id=51951
3796
3797         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3798         to create new window from WebKit.
3799
3800         * MiniBrowser/qt/BrowserWindow.cpp:
3801         (newPageFunction):
3802         (BrowserWindow::BrowserWindow):
3803         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3804         (BrowserWindow::newWindow):
3805         (BrowserWindow::updateUserAgentList):
3806         (BrowserWindow::showUserAgentDialog):
3807         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3808         define the type of the backing store used for new windows.
3809         * MiniBrowser/qt/main.cpp:
3810         (main):
3811
3812 2011-01-05  Eric Seidel  <eric@webkit.org>
3813
3814         Reviewed by Ojan Vafai.
3815
3816         commit-queue should report failure type when reporting flaky tests
3817         https://bugs.webkit.org/show_bug.cgi?id=51900
3818
3819         This patch was a ridiculous amount of plumbing.  In the end I like
3820         the NRWT-style TestResult class even less.  But now we're passing
3821         a list of TestResult objects from the queue to the FlakyTestReporter.
3822         Thus the FlakyTestReporter can more easily report what type of failure
3823         occurred.
3824
3825         In the process, I found that I was not alone in finding TestResult
3826         cumbersome to use.  A bunch of code was trying to create a TestResult
3827         object with default values.  However since the constructor didn't make
3828         this easy, some places were getting it wrong (including the TestResult unit test)!
3829         I've fixed the TestResult constructor to have default values for non-essential
3830         arguments.
3831
3832         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3833         * Scripts/webkitpy/common/net/layouttestresults.py:
3834         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3835         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3836         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3837         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3838         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3839         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3840         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3841         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3842         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3843         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3844         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3845         * Scripts/webkitpy/tool/commands/queues.py:
3846         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3847
3848 2011-01-05  Eric Seidel  <eric@webkit.org>
3849
3850         Unreviewed.
3851
3852         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3853         https://bugs.webkit.org/show_bug.cgi?id=51802
3854
3855         Add another unit test to cover a previously missing import.
3856
3857         * Scripts/webkitpy/common/net/layouttestresults.py:
3858         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3859
3860 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3861
3862         Reviewed by David Levin.
3863
3864         Add mihaip@chromium.org as a reviewer
3865         https://bugs.webkit.org/show_bug.cgi?id=51966
3866         
3867         Add myself as a reviewer.
3868
3869         * Scripts/webkitpy/common/config/committers.py:
3870
3871 2011-01-05  James Simonsen  <simonjam@chromium.org>
3872
3873         Unreviewed. Adding myself to the list of committers.
3874
3875         * Scripts/webkitpy/common/config/committers.py:
3876
3877 2011-01-05  Eric Seidel  <eric@webkit.org>
3878
3879         Unreviewed.
3880
3881         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3882         https://bugs.webkit.org/show_bug.cgi?id=51802
3883
3884         Fix two exceptions seen on the bots after my original commit.
3885
3886         * Scripts/webkitpy/common/net/layouttestresults.py:
3887         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3888
3889 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3890
3891         Reviewed by Andreas Kling.
3892
3893         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3894         https://bugs.webkit.org/show_bug.cgi?id=51750
3895
3896         * QtTestBrowser/main.cpp:
3897         (LauncherApplication::handleUserOptions):
3898          Local storage settings can be enable form command line arguments for
3899          QtTestBrowser.
3900
3901 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3902
3903         Reviewed by Martin Robinson.
3904
3905         GTK: AX: DRT needs to use correct root object method.
3906         https://bugs.webkit.org/show_bug.cgi?id=51911
3907
3908         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3909         (AccessibilityController::rootElement):
3910
3911 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3912
3913         Rubber-stamped by Csaba Osztrogonác.
3914
3915         Based on idea from Péter Gál.
3916
3917         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3918
3919 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3920
3921         Reviewed by Adam Barth.
3922
3923         sheriff-bot should be able to do multi-revision rollouts
3924         https://bugs.webkit.org/show_bug.cgi?id=51176
3925
3926         * Scripts/webkitpy/tool/bot/irc_command.py:
3927         * Scripts/webkitpy/tool/bot/sheriff.py:
3928         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3929
3930 2011-01-05  Eric Seidel  <eric@webkit.org>
3931
3932         Reviewed by Adam Barth.
3933
3934         queues.webkit.org should have per-bot status pages
3935         https://bugs.webkit.org/show_bug.cgi?id=51906
3936
3937         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3938         statuses from a single queue.  Now that we have many bots servicing
3939         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3940         you care about scroll off the end of the 15-message limit on the main page.
3941
3942         Eventually we should probably rename /queue-status to /queue or /queues,
3943         but that's fodder for another patch.
3944
3945         * QueueStatusServer/handlers/queuestatus.py:
3946         * QueueStatusServer/index.yaml:
3947         * QueueStatusServer/main.py:
3948         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3949          - This probably should use a custom filter instead of hard-coding
3950            the URL scheme here, but I couldn't figure out how to easily
3951            create such a filter.  Most filters work with "strings" so we can't
3952            pass the status object.  We could add a method to the status
3953            object and call that, but that seemed a bit strange too.
3954         * QueueStatusServer/templates/queuestatus.html:
3955
3956 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3957
3958         Unreviewed. Adding myself to the list of committers.
3959
3960         * Scripts/webkitpy/common/config/committers.py:
3961
3962 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3963
3964         Reviewed by David Levin.
3965
3966         check-webkit-style treated some macros with parentheses after #elif as function calls
3967         https://bugs.webkit.org/show_bug.cgi?id=51695
3968
3969         Ingore function call space checking in any preprocessor directives
3970         (things starting with #). Change search() to match() because 
3971         preprocessor directives are supposed to be in the beginning of lines.
3972
3973         * Scripts/webkitpy/style/checkers/cpp.py:
3974         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3975
3976 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3977
3978         Reviewed by Tony Chang.
3979
3980         Change the --multi-load test option to --stress-opt
3981         https://bugs.webkit.org/show_bug.cgi?id=50751
3982
3983         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3984         (runTest):
3985         (main):
3986         * DumpRenderTree/chromium/TestShell.cpp:
3987         (TestShell::TestShell):
3988         * DumpRenderTree/chromium/TestShell.h:
3989         (TestShell::stressOpt):
3990         (TestShell::setStressOpt):
3991         (TestShell::stressDeopt):
3992         (TestShell::setStressDeopt):
3993         (TestShell::javaScriptFlags):
3994         (TestShell::setJavaScriptFlags):
3995         * Scripts/webkitpy/layout_tests/port/chromium.py:
3996         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3997
3998 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3999
4000         Reviewed by Sam Weinig.
4001
4002         WK2: Support Accessibility
4003         https://bugs.webkit.org/show_bug.cgi?id=51859
4004
4005         Use rootObject() method to get top of accessibility tree.
4006
4007         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4008         (AccessibilityController::focusedElement):
4009         (AccessibilityController::rootElement):
4010
4011 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
4012
4013         Reviewed by Darin Adler.
4014
4015         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
4016         https://bugs.webkit.org/show_bug.cgi?id=51846
4017
4018         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
4019         back to GRefPtr.
4020
4021 2011-01-04  Zhe Su  <suzhe@chromium.org>
4022
4023         Reviewed by Kenneth Russell.
4024
4025         Fix insertText, setMarkedText and unmarkText methods of
4026         TextInputController to call corresponding methods of WebKit::WebView
4027         rather than WebKit::WebFrame. This change matches the behavior of
4028         chromium browser.
4029         insertText corresponds to WebView::confirmComposition(text)
4030         setMarkedText corresponds to WebView::setComposition(...)
4031         unmarkText corresponds to WebView::confirmComposition()
4032         https://bugs.webkit.org/show_bug.cgi?id=51693
4033
4034         * DumpRenderTree/chromium/TextInputController.cpp:
4035         (TextInputController::insertText):
4036         (TextInputController::setMarkedText):
4037         (TextInputController::unmarkText):
4038
4039 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
4040
4041         Reviewed by Laszlo Gombos.
4042
4043         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
4044
4045         On Symbian productDir points to the source directory. Removing all the
4046         empty files from the productDir directory corrupts the svn repository.
4047
4048         * Scripts/build-webkit:
4049
4050 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
4051
4052         Reviewed by Adam Barth.
4053
4054         [Qt] Add SelectAll option to the context menu for the editor
4055         https://bugs.webkit.org/show_bug.cgi?id=50049
4056
4057         Set shortcut for the SelectAll action.
4058
4059         * QtTestBrowser/mainwindow.cpp:
4060         (MainWindow::buildUI):
4061
4062 2011-01-03  David Levin  <levin@chromium.org>
4063
4064         Reviewed by Eric Seidel.
4065
4066         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
4067         https://bugs.webkit.org/show_bug.cgi?id=51842
4068
4069         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
4070         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
4071
4072 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
4073
4074         Reviewed by David Kilzer.
4075
4076         [WINCE] Adds a build slave.
4077         https://bugs.webkit.org/show_bug.cgi?id=50523
4078
4079         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
4080         entry for a release build of the WinCE port.
4081         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
4082         flag to build the WinCE port.
4083
4084 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
4085
4086         Reviewed by David Kilzer.
4087
4088         Add WinCE support to build-webkit
4089         https://bugs.webkit.org/show_bug.cgi?id=51642
4090
4091         * Scripts/build-webkit:
4092         * Scripts/webkitdirs.pm:
4093
4094 2011-01-03  Eric Seidel  <eric@webkit.org>
4095
4096         Reviewed by Adam Barth.
4097
4098         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
4099         https://bugs.webkit.org/show_bug.cgi?id=51802
4100
4101         I'm not the biggest fan of the test_failures or test_results classes,
4102         but it's better to have one shared set of classes, than separate ones
4103         for new vs. old run-webkit-test result handling.
4104
4105         This moves the ORWT results class "LayoutTestResults" over to using
4106         TestResult and TestFailure classes, making it easy for us to
4107         make all our sheriff-bot and other webkitpy code NRWT ready.
4108
4109         This also makes it a trivial patch to generate results.json information
4110         from ORWT results.html files (for flaky test analysis, etc.) as well
4111         as making it a one-liner to report test failure types when the
4112         commit-queue sees flaky tests.
4113
4114         This patch tried not to add new functionality, but only to replace
4115         the guts of LayoutTestResults, while adding unit tests and hoping
4116         not to break anything.
4117
4118         I also moved callers which assumed User.prompt* were static/class methods
4119         to using them as instance methods (since we'll eventually want to make them such).
4120
4121         In the process of re-writing things, I broke the rebaseline command, so I wrote
4122         a unit test to catch my breakage were I do do so again in the future.
4123
4124         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4125         * Scripts/webkitpy/common/net/layouttestresults.py:
4126         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
4127         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
4128         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
4129         * Scripts/webkitpy/tool/commands/queries.py:
4130         * Scripts/webkitpy/tool/commands/rebaseline.py:
4131         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4132         * Scripts/webkitpy/tool/mocktool.py:
4133
4134 2011-01-03  Adam Barth  <abarth@webkit.org>
4135
4136         Reviewed by Simon Fraser.
4137
4138         webkit-patch shouldn't waste time cleaning a working directory that's already clean
4139         https://bugs.webkit.org/show_bug.cgi?id=51840
4140
4141         * Scripts/webkitpy/common/checkout/scm.py:
4142
4143 2011-01-03  Adam Barth  <abarth@webkit.org>
4144
4145         Reviewed by Simon Fraser.
4146
4147         webkit-patch should only hide update output if --quiet
4148         https://bugs.webkit.org/show_bug.cgi?id=51838
4149
4150         As requested by smfr.
4151
4152         * Scripts/webkitpy/tool/steps/update.py:
4153
4154 2011-01-03  Adam Barth  <abarth@webkit.org>
4155
4156         Reviewed by David Levin.
4157
4158         commit-queue shouldn't reject patches twice if two bots process the same patch
4159         https://bugs.webkit.org/show_bug.cgi?id=51805
4160
4161         Before raising an error, we first check whether the patch is still in
4162         the commit-queue.  This check is still racy, of course, but the time
4163         window is much smaller.
4164
4165         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4166
4167 2011-01-03  Sam Weinig  <sam@webkit.org>
4168
4169         Reviewed by Anders Carlsson.
4170
4171         Make run-api-tests less chatty.
4172         https://bugs.webkit.org/show_bug.cgi?id=51831
4173
4174         - Make script quiet by default and add --verbose option (replacing --quiet).
4175         - When not verbose, pipe stdout and stderr to devnull.
4176
4177         * Scripts/run-api-tests:
4178
4179 2011-01-03  Pratik Solanki  <psolanki@apple.com>
4180
4181         Unreviewed. Adding myself to committers.py.
4182
4183         * Scripts/webkitpy/common/config/committers.py:
4184
4185 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
4186
4187         Reviewed by Xan Lopez.
4188
4189         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
4190         https://bugs.webkit.org/show_bug.cgi?id=51806
4191
4192         Originally, the $libraryName is 'JavaScriptCore'. When building release 
4193         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
4194         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
4195         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
4196         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
4197         so make it 'WebKitBuild/Release/.libs'
4198
4199         * Scripts/webkitdirs.pm: 
4200
4201 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
4202
4203         Reviewed by Adam Barth.
4204
4205         Make EFL a core builder
4206         https://bugs.webkit.org/show_bug.cgi?id=51804
4207
4208         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4209         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4210
4211 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4212
4213         [Qt] Unreviewed fix after r74855 and r74875.
4214
4215         * BuildSlaveSupport/built-product-archive:
4216          - Create directories explicitly.
4217          - Pass shell=True to subprocess.call().
4218
4219 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4220
4221         [Qt] Unreviewed fix after r74855.
4222
4223         Move JavaScriptCore to Source
4224         https://bugs.webkit.org/show_bug.cgi?id=51604
4225
4226         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
4227
4228 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4229
4230         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
4231
4232         Move JavaScriptCore to Source
4233         https://bugs.webkit.org/show_bug.cgi?id=51604
4234
4235         * Scripts/webkitdirs.pm:
4236
4237 2011-01-02  Robert Hogan  <robert@webkit.org>
4238
4239         Unreviewed, build fix.
4240
4241         [Qt] Fix DRT build after 74855
4242
4243         * DumpRenderTree/qt/DumpRenderTree.pro:
4244
4245 2011-01-01  Adam Barth  <abarth@webkit.org>
4246
4247         Remove the assumption from the Qt and Gtk builds that every project is
4248         in the root directory.
4249
4250         * Scripts/build-webkit:
4251
4252 2011-01-01  Adam Barth  <abarth@webkit.org>
4253
4254         Reviewed by Eric Seidel.
4255
4256         Teach svn-apply how to apply patches even though JavaScriptCore has moved
4257         https://bugs.webkit.org/show_bug.cgi?id=51796
4258
4259         After this change, svn-apply will magically apply patches to
4260         JavaScriptCore/foo to Source/JavaScriptCore/foo.
4261
4262         * Scripts/VCSUtils.pm:
4263
4264 2011-01-01  Adam Barth  <abarth@webkit.org>
4265
4266         Reviewed by Eric Seidel.
4267
4268         Move JavaScriptCore to Source
4269         https://bugs.webkit.org/show_bug.cgi?id=51604
4270
4271         Update references to JavaScriptCore to point to the new location.
4272
4273         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4274         * DumpRenderTree/qt/DumpRenderTree.pro:
4275         * DumpRenderTree/qt/ImageDiff.pro:
4276         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4277         * DumpRenderTree/wscript:
4278         * Scripts/build-jsc:
4279         * Scripts/build-webkit:
4280         * Scripts/do-file-rename:
4281         * Scripts/do-webcore-rename:
4282         * Scripts/run-javascriptcore-tests:
4283         * Scripts/update-javascriptcore-test-results:
4284         * Scripts/webkitdirs.pm:
4285         * Scripts/webkitpy/common/config/build_unittest.py:
4286         * Scripts/webkitpy/style/checker.py:
4287         * Scripts/webkitpy/style/checker_unittest.py:
4288         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4289         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4290         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4291         * wx/build/settings.py:
4292
4293 2011-01-01  Adam Barth  <abarth@webkit.org>
4294
4295         Reviewed by Eric Seidel.
4296
4297         Move Sources to Source
4298         https://bugs.webkit.org/show_bug.cgi?id=51794
4299
4300         Update scripts to point to the new location.
4301
4302         * Scripts/build-webkit:
4303         * Scripts/do-file-rename:
4304         * Scripts/do-webcore-rename:
4305         * Scripts/webkitpy/common/config/build.py:
4306         * Scripts/webkitpy/common/config/build_unittest.py:
4307
4308 2010-12-31  Kent Tamura  <tkent@chromium.org>
4309
4310         Reviewed by Eric Seidel.
4311
4312         [DRT/Chromium] Enable mock spell checker on non-OSX
4313         https://bugs.webkit.org/show_bug.cgi?id=51401
4314
4315         * DumpRenderTree/chromium/WebViewHost.cpp:
4316         (WebViewHost::spellCheck):
4317
4318 2010-12-31  Adam Barth  <abarth@webkit.org>
4319
4320         Reviewed by Ariya Hidayat.
4321
4322         Remove Tools/Scripts/wkstyle
4323         https://bugs.webkit.org/show_bug.cgi?id=51774
4324
4325         This script appears to not have been touched in a while and seems to
4326         have been replaced by check-webkit-style.
4327
4328         * Scripts/wkstyle: Removed.
4329
4330 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4331
4332         Unreviewed. Coding style fix.
4333
4334         * DumpRenderTree/chromium/TestShell.h:
4335
4336 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4337
4338         Reviewed by Pavel Feldman.
4339
4340         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
4341
4342         It was a problem with Chromium DRT. DevToolsAgent object instance was
4343         attached not only to the inspected page but to the DevTools window too.
4344         As result all the inspector files were interpreted as a content of inspected page
4345         and were transfered to the DevTools scripts panel for debugging etc.
4346
4347         https://bugs.webkit.org/show_bug.cgi?id=51735
4348
4349         * DumpRenderTree/chromium/TestShell.cpp:
4350         (TestShell::TestShell):
4351         (TestShell::bindJSObjectsToWindow):
4352         (TestShell::createNewWindow):
4353         * DumpRenderTree/chromium/TestShell.h:
4354
4355 2010-12-31  Adam Barth  <abarth@webkit.org>
4356
4357         Rubber-stamped by Eric Seidel.
4358
4359         Move PageLoadTests to PerformanceTests/PageLoad
4360         https://bugs.webkit.org/show_bug.cgi?id=51771
4361
4362         Update references to PageLoadTests to point to the new location.
4363
4364         * Scripts/run-pageloadtest:
4365         * Scripts/webkitpy/common/config/build.py:
4366
4367 2010-12-31  Adam Barth  <abarth@webkit.org>
4368
4369         Rubber-stamped by Eric Seidel.
4370
4371         Move SunSpider into PerformanceTests
4372         https://bugs.webkit.org/show_bug.cgi?id=51769
4373
4374         Update these scripts to point to the new location.
4375
4376         * Scripts/run-sunspider:
4377         * Scripts/sunspider-compare-results:
4378
4379 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
4380
4381         Reviewed by Kent Tamura.
4382
4383         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
4384         https://bugs.webkit.org/show_bug.cgi?id=51728
4385         
4386         Add implementation of the Mac WebThemeEngine that uses an NSScroller
4387         to render top-level scrollbars. This makes them match the Mac port's
4388         use of an NSScrollView, which means that we'll be able to share more
4389         pixel baselines.
4390         
4391         The new rendering code will not be activated until the 
4392         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
4393         ScrollbarThemeChromiumMac.
4394
4395         * DumpRenderTree/DumpRenderTree.gypi:
4396         * DumpRenderTree/chromium/TestShellMac.mm:
4397         (platformInit):
4398         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
4399         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
4400         (+[FakeActiveWindow alwaysActiveWindow]):
4401         (+[FakeActiveWindow alwaysInactiveWindow]):
4402         (-[FakeActiveWindow initWithActiveControls:]):
4403         (-[FakeActiveWindow _hasActiveControls]):
4404         (WebThemeEngineDRTMac::paintScrollbarThumb):
4405         (stateToHIEnableState):
4406         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
4407         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
4408
4409 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
4410
4411         Reviewed by David Kilzer.
4412
4413         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
4414         used
4415         https://bugs.webkit.org/show_bug.cgi?id=51672
4416
4417         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
4418         with USE_SYSTEM_MALLOC=1
4419         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
4420         with USE_SYSTEM_MALLOC=1
4421
4422 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4423
4424         Reviewed by David Kilzer.
4425
4426         [Qt] [Symbian] Fix build-webkit script for Symbian
4427         https://bugs.webkit.org/show_bug.cgi?id=51509
4428
4429         Set the OUTPUT_DIR for Symbian to be the same as the source
4430         directory.
4431
4432         * Scripts/webkitdirs.pm:
4433
4434 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
4435
4436         Reviewed by Darin Adler.
4437
4438         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
4439         https://bugs.webkit.org/show_bug.cgi?id=51758
4440
4441         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
4442
4443         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
4444         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
4445
4446 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
4447
4448         Unreviewed WinCE buildfix.
4449
4450         * WinCELauncher/main.cpp: Add missing include.
4451
4452 2010-12-29  Daniel Bates  <dbates@rim.com>
4453
4454         Reviewed by Darin Adler.
4455
4456         svn-apply updates date of wrong change log entry for a change log diff that
4457         contains two consecutive entries with the same author and date
4458         https://bugs.webkit.org/show_bug.cgi?id=46061
4459
4460         Fixes an issue where the date of the wrong change log entry may be modified.
4461         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
4462         in a ChangeLog file to the top of the file.
4463
4464         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
4465         diff when it detects that the diff inserts a change log entry earlier in a
4466         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
4467         change. With the advent of the commit-queue this functionality of bailing out
4468         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
4469         Instead, we should always move the change log entry to the top of the ChangeLog file.
4470
4471         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
4472         the date line of the correct change log entry in a ChangeLog diff.
4473
4474         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
4475
4476         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
4477           Updated the following unit tests now that we move entries inserted earlier to the top:
4478           - "fixChangeLogPatch: New entry inserted in middle."
4479             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
4480
4481           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
4482             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
4483
4484         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
4485
4486 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
4487
4488         Reviewed by Eric Seidel.
4489
4490         [Qt] Fixed compatibility with gold linker on X11 platforms
4491         https://bugs.webkit.org/show_bug.cgi?id=51700
4492
4493         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4494         Linked TestNetscapePlugin with libX11 on Unix platforms
4495
4496 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
4497
4498         Reviewed by Darin Adler.
4499
4500         Circular dependency in webkitpy.common.checkout.changelog module
4501         https://bugs.webkit.org/show_bug.cgi?id=50475
4502
4503         Remove automatic import of api.Checkout module when any checkout/
4504         submodule is imported (e.g.: when checkout.scm.Git is imported).
4505
4506         * Scripts/webkitpy/common/checkout/__init__.py:
4507
4508 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
4509
4510     &n