1ee963ad25ba98b6770e51bbf55474c425817842
[WebKit.git] / Tools / ChangeLog
1 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2
3         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
4         https://bugs.webkit.org/show_bug.cgi?id=174501
5
6         Reviewed by Darin Adler.
7
8         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
9         (TestWebKitAPI::TEST):
10
11 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
12
13         Bring mac expectations in-line with other platforms
14         https://bugs.webkit.org/show_bug.cgi?id=174472
15         <rdar://problem/33297388>
16
17         Reviewed by David Kilzer.
18
19         The override order for Mac test expectations does not conform to the pattern used by iOS,
20         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
21
22             platform/mac-wk2
23             platform/wk2
24             platform/mac-elcapitan
25             platform/mac-sierra
26             generic
27
28         After this change, El Capitan's baseline search path looks like this:
29
30             platform/mac-sierra-wk2
31             platform/mac-sierra
32             platform/mac-wk2
33             platform/wk2
34             generic
35
36         * Scripts/webkitpy/port/mac.py:
37         (MacPort.__init__): If a specific version is specified in the port name, use that
38         as the os version.
39         (MacPort.default_baseline_search_path): Expectation search paths should work the
40         same way they do on other ports. Port + version overrides port, port overrides generic
41         and wk1/wk2 should override expectations for the two combined.
42         * Scripts/webkitpy/port/mac_unittest.py:
43         (MacTest.test_tests_for_other_platforms): Deleted.
44         (MacTest._assert_search_path): Deleted.
45         (MacTest.test_baseline_search_path): Deleted.
46         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
47         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
48         (test_rebaseline_test_and_print_scm_changes): Ditto.
49         (test_rebaseline_and_copy_test): Ditto.
50         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
51         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
52         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
53
54 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
55
56         Fix style checker unit test
57
58         Unreviewed WebKit2 => WebKit fixup.
59
60         * Scripts/webkitpy/style/checker_unittest.py:
61         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
62
63 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
64
65         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
66
67         Unreviewed build fix.
68
69         r219492 missed one hunk from its partial revert of r219489.
70         This patch reverts that hunk.
71
72         * TestWebKitAPI/CMakeLists.txt:
73
74 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
75
76         Use the old WebKit/WebKit2 targets for CMake builds.
77
78         Unreviewed build fix.
79
80         We can update the target names to match the Framework names in a future patch.
81         This is a partial revert of r219489.
82
83         * TestWebKitAPI/CMakeLists.txt:
84         WebKitLegacy => WebKit
85         WebKit => WebKit2
86
87 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
88
89         Fix TestWebKit API.
90         https://bugs.webkit.org/show_bug.cgi?id=174164
91         rdar://problem/33137595
92
93         Reviewed by Dan Bernstein.
94
95         * TestWebKitAPI/CMakeLists.txt:
96         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
97         * TestWebKitAPI/PlatformGTK.cmake:
98
99 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
100
101         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
102         https://bugs.webkit.org/show_bug.cgi?id=174164
103         rdar://problem/33137595
104
105         Reviewed by Dan Bernstein.
106
107         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
108         (ShouldBuildTest):
109         * DumpRenderTree/mac/Configurations/Base.xcconfig:
110         * Scripts/build-webkit:
111         * Scripts/do-file-rename:
112         * Scripts/do-webcore-rename:
113         * Scripts/update-webkit-localizable-strings:
114         * Scripts/webkitpy/common/config/watchlist:
115         * Scripts/webkitpy/style/checker.py:
116         * Scripts/webkitpy/style/checkers/featuredefines.py:
117         * gtk/make-dist.py:
118         (ensure_version_if_possible):
119         * gtk/manifest.txt.in:
120
121 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
122
123         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
124         https://bugs.webkit.org/show_bug.cgi?id=174162
125         rdar://problem/33137594
126
127         Reviewed by Dan Bernstein.
128
129         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
130
131         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
132         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
133         * EWSTools/configure-clang-linux.sh:
134         * Scripts/build-webkit:
135         * Scripts/do-file-rename:
136         * Scripts/do-webcore-rename:
137         * Scripts/update-webkit-localizable-strings:
138         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
139         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
140         * Scripts/webkitpy/style/checkers/featuredefines.py:
141         * gtk/manifest.txt.in:
142
143 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
144
145         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
146         https://bugs.webkit.org/show_bug.cgi?id=174438
147         <rdar://problem/33277112>
148
149         Reviewed by Aakash Jain.
150
151         Given a patch, this will convert the changes from the path to the new directory structure.
152
153         * Scripts/rebase-patch-after-webkit-move: Added.
154         (append_source): Append 'Source' to the provided path.
155         (is_editable_line): Return true if a line the script expects to modify.
156         (needs_rebase): Return if a line needs to be rebased based on it's content.
157         (rebase_line): Rebase the provided line.
158         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
159         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
160         were provided.
161
162 2017-07-12  Nan Wang  <n_wang@apple.com>
163
164         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
165         https://bugs.webkit.org/show_bug.cgi?id=174393
166         <rdar://problem/33248006>
167
168         Reviewed by Chris Fleizach.
169
170         * DumpRenderTree/AccessibilityUIElement.cpp:
171         (textMarkerRangeMatchesTextNearMarkersCallback):
172         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
173         (AccessibilityUIElement::getJSClass):
174         * DumpRenderTree/AccessibilityUIElement.h:
175         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
176         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
177         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
178         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
179         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
180         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
181         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
182         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
183
184 2017-07-12  Matt Lewis  <jlewis3@apple.com>
185
186         Unreviewed, rolling out r219409.
187
188         The revision caused the Windows builds to fail.
189
190         Reverted changeset:
191
192         "AX: [iOS] Implement a way to retrieve a text marker range
193         with desired text that is closest to a position"
194         https://bugs.webkit.org/show_bug.cgi?id=174393
195         http://trac.webkit.org/changeset/219409
196
197 2017-07-12  Nan Wang  <n_wang@apple.com>
198
199         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
200         https://bugs.webkit.org/show_bug.cgi?id=174393
201         <rdar://problem/33248006>
202
203         Reviewed by Chris Fleizach.
204
205         * DumpRenderTree/AccessibilityUIElement.cpp:
206         (textMarkerRangeMatchesTextNearMarkersCallback):
207         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
208         (AccessibilityUIElement::getJSClass):
209         * DumpRenderTree/AccessibilityUIElement.h:
210         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
211         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
212         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
213         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
214         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
215         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
216         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
217         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
218
219 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
220
221         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
222         https://bugs.webkit.org/show_bug.cgi?id=174197
223
224         Reviewed by Darin Adler.
225
226         This bit me the first time I tried to submit a patch to WebKit, and still I have
227         to manually edit the ChangeLog every time I use the script.
228
229         This generates a more convenient and standard ChangeLog entry.
230
231         * Scripts/prepare-ChangeLog:
232         (generateNewChangeLogs):
233
234 2017-07-12  Matt Lewis  <jlewis3@apple.com>
235
236         Unreviewed, rolling out r219401.
237
238         This revision rolled out the previous patch, but after talking
239         with reviewer, a rebaseline is what was needed.Rolling back in
240         before rebaseline.
241
242         Reverted changeset:
243
244         "Unreviewed, rolling out r219379."
245         https://bugs.webkit.org/show_bug.cgi?id=174400
246         http://trac.webkit.org/changeset/219401
247
248 2017-07-12  Matt Lewis  <jlewis3@apple.com>
249
250         Unreviewed, rolling out r219379.
251
252         This revision caused a consistent failure in the test
253         fast/dom/Window/property-access-on-cached-window-after-frame-
254         removed.html.
255
256         Reverted changeset:
257
258         "Remove NAVIGATOR_HWCONCURRENCY"
259         https://bugs.webkit.org/show_bug.cgi?id=174400
260         http://trac.webkit.org/changeset/219379
261
262 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
263
264         [WPE] Use libepoxy
265         https://bugs.webkit.org/show_bug.cgi?id=172104
266
267         Reviewed by Michael Catanzaro.
268
269         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
270         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
271
272 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
273
274         [GTK][WPE] Align Jhbuild patches for GStreamer packages
275         https://bugs.webkit.org/show_bug.cgi?id=174363
276
277         Reviewed by Michael Catanzaro.
278
279         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
280         between the GTK+ and WPE port. There's no reason for the two ports to apply
281         different patches over same versions of GStreamer releases.
282
283         This aligns the two ports on this specific issue. Next we'll look into
284         creating a single GStreamer-specific Jhbuild moduleset that will allow us
285         to keep these patches in a single place, avoiding duplicate files.
286
287         * gtk/jhbuild.modules:
288         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
289         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
290         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
291         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
292
293 2017-07-11  Dean Jackson  <dino@apple.com>
294
295         Remove NAVIGATOR_HWCONCURRENCY
296         https://bugs.webkit.org/show_bug.cgi?id=174400
297
298         Reviewed by Sam Weinig.
299
300         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
301
302 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
303
304         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
305         https://bugs.webkit.org/show_bug.cgi?id=174239
306
307         Reviewed by Brady Eidson.
308
309         Create windows with specific features set and make sure those are properly reflected in the
310         WKWindowFeatures object.
311
312         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
313         (resetToConsistentState):
314         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
315         (TEST):
316
317 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
318
319         Do not duplicate files when deleting directories with svn 1.9
320         https://bugs.webkit.org/show_bug.cgi?id=174339
321         <rdar://problem/33226781>
322
323         Reviewed by David Kilzer.
324
325         * Scripts/svn-create-patch:
326         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
327         (generateFileList): Determine which files are deleted because they are part of a
328         directory being deleted.
329
330 2017-07-11  Dean Jackson  <dino@apple.com>
331
332         Rolling out r219372.
333
334         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
335
336 2017-07-11  Dean Jackson  <dino@apple.com>
337
338         Remove NAVIGATOR_HWCONCURRENCY
339         https://bugs.webkit.org/show_bug.cgi?id=174400
340
341         Reviewed by Sam Weinig.
342
343         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
344
345 2017-07-11  Lucas Forschler  <lforschler@apple.com>
346
347         Teach build workers to fetch archives from S3.
348         https://bugs.webkit.org/show_bug.cgi?id=174384
349
350         Reviewed by Aakash Jain.
351
352         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
353         (DownloadBuiltProduct):
354
355 2017-07-11  Lucas Forschler  <lforschler@apple.com>
356
357         Configure buildbot to transfer all archives to S3.
358         Previously this was Mac only, but it's time to expand!
359         https://bugs.webkit.org/show_bug.cgi?id=174378
360         
361         Reviewed by Aakash Jain.
362
363         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
364         (BuildFactory.__init__):
365
366 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
367
368         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
369         https://bugs.webkit.org/show_bug.cgi?id=174350
370
371         Reviewed by Xabier Rodriguez-Calvar.
372
373         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
374         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
375         patches are removed. The patches for gst-plugins-good are updated, removing
376         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
377         rtpbin elements that will help with the EMEv3 development.
378
379         * wpe/jhbuild.modules:
380         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
381         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
382         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
383         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
384         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
385         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
386         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
387         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
388         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
389
390 2017-07-10  John Wilander  <wilander@apple.com>
391
392         Resource Load Statistics: Prune statistics in orders of importance
393         https://bugs.webkit.org/show_bug.cgi?id=174215
394         <rdar://problem/33164403>
395
396         Reviewed by Chris Dumez.
397
398         Nest infrastructure. Adds these functions:
399         1. testRunner.setStatisticsLastSeen()
400         2. setStatisticsMaxStatisticsEntries()
401         3. setStatisticsPruneEntriesDownTo()
402
403         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
404         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
405         (WTR::TestRunner::setStatisticsLastSeen):
406         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
407         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
408         * WebKitTestRunner/InjectedBundle/TestRunner.h:
409         * WebKitTestRunner/TestController.cpp:
410         (WTR::TestController::setStatisticsLastSeen):
411         (WTR::TestController::setMaxStatisticsEntries):
412         (WTR::TestController::setPruneEntriesDownTo):
413         * WebKitTestRunner/TestController.h:
414         * WebKitTestRunner/TestInvocation.cpp:
415         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
416         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
417         (WTR::TestController::setStatisticsLastSeen):
418         (WTR::TestController::setStatisticsMaxStatisticsEntries):
419         (WTR::TestController::setStatisticsPruneEntriesDownTo):
420
421 2017-07-03  Brian Burg  <bburg@apple.com>
422
423         Web Replay: remove some unused code
424         https://bugs.webkit.org/show_bug.cgi?id=173903
425
426         Rubber-stamped by Joseph Pecoraro.
427
428         * Scripts/run-input-generator-tests: Removed.
429         * Scripts/webkitpy/replay/__init__.py: Removed.
430         * Scripts/webkitpy/replay/main.py: Removed.
431
432 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
433
434         [WPE] Fix layout test baseline and TestExpectations hierarchy
435         https://bugs.webkit.org/show_bug.cgi?id=174092
436
437         Reviewed by Michael Catanzaro.
438
439         Like for the GTK+ port, override the default_baseline_search_path() and
440         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
441         Both methods operate on a short list of search paths that defaults to 'wpe' and
442         'wk2', along with any other user-specified platform directory.
443
444         The test_expectations_file_position() method is overridden for testing purposes,
445         and relevant unit tests are added.
446
447         * Scripts/webkitpy/port/wpe.py:
448         (WPEPort._search_paths):
449         (WPEPort):
450         (WPEPort.default_baseline_search_path):
451         (WPEPort._port_specific_expectations_files):
452         (WPEPort.test_expectations_file_position):
453         * Scripts/webkitpy/port/wpe_unittest.py:
454         (WPEPortTest.test_default_baseline_search_path):
455         (WPEPortTest):
456         (WPEPortTest.test_port_specific_expectations_files):
457
458 2017-07-10  Chris Dumez  <cdumez@apple.com>
459
460         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
461         https://bugs.webkit.org/show_bug.cgi?id=174301
462
463         Reviewed by Brent Fulgham.
464
465         Rename some of the testRunner API for clarity and to better match what it calls
466         internally.
467
468         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
469         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
470         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
471         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
472         * WebKitTestRunner/InjectedBundle/TestRunner.h:
473         * WebKitTestRunner/TestController.cpp:
474         (WTR::TestController::statisticsUpdateCookiePartitioning):
475         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
476         * WebKitTestRunner/TestController.h:
477         * WebKitTestRunner/TestInvocation.cpp:
478         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
479         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
480         (WTR::TestController::statisticsUpdateCookiePartitioning):
481         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
482
483 2017-07-10  Charlie Turner  <cturner@igalia.com>
484
485         [GStreamer] Live twitch.tv videos do not play
486         https://bugs.webkit.org/show_bug.cgi?id=174222
487
488         Reviewed by Michael Catanzaro.
489
490         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
491         fixes videos not playing on twitch.tv.
492
493         * gtk/jhbuild.modules:
494
495 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
496
497         Add WebGL2 configuration option to build-webkit
498         https://bugs.webkit.org/show_bug.cgi?id=174251
499
500         Reviewed by Michael Catanzaro.
501
502         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
503         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
504         is marked as enabled for the Apple Cocoa ports.
505
506 2017-07-08  Chris Dumez  <cdumez@apple.com>
507
508         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
509         https://bugs.webkit.org/show_bug.cgi?id=174290
510
511         Reviewed by Brent Fulgham.
512
513         Rename testRunner API to match the new internal API names.
514
515         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
516         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
517         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
518         (WTR::TestRunner::statisticsSubmitTelemetry):
519         * WebKitTestRunner/InjectedBundle/TestRunner.h:
520         * WebKitTestRunner/TestController.cpp:
521         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
522         (WTR::TestController::statisticsSubmitTelemetry):
523         * WebKitTestRunner/TestController.h:
524         * WebKitTestRunner/TestInvocation.cpp:
525         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
526         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
527         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
528         (WTR::TestController::statisticsSubmitTelemetry):
529
530 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
531
532         Drop NOSNIFF compile flag
533         https://bugs.webkit.org/show_bug.cgi?id=174289
534
535         Reviewed by Michael Catanzaro.
536
537         * Scripts/webkitperl/FeatureList.pm:
538         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
539
540 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
541
542         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
543         https://bugs.webkit.org/show_bug.cgi?id=174219
544         <rdar://problem/32083177>
545
546         Reviewed by Ryosuke Niwa.
547
548         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
549         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
550         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
551         place.
552
553         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
554         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
555         no action is taken when dropping.
556
557         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
558         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
559         (TestWebKitAPI::TEST):
560         * TestWebKitAPI/ios/DataInteractionSimulator.h:
561         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
562         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
563         (-[MockDragDropSession allowsMoveOperation]):
564         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
565         (-[MockDataInteractionSession initWithWindow:allowMove:]):
566         (-[DataInteractionSimulator initWithWebView:]):
567         (-[DataInteractionSimulator runFrom:to:]):
568         (-[DataInteractionSimulator _advanceProgress]):
569         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
570         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
571         (-[MockDataInteractionSession initWithWindow:]): Deleted.
572
573 2017-07-07  Commit Queue  <commit-queue@webkit.org>
574
575         Unreviewed, rolling out r219238, r219239, and r219241.
576         https://bugs.webkit.org/show_bug.cgi?id=174265
577
578         "fast/workers/dedicated-worker-lifecycle.html is flaky"
579         (Requested by yusukesuzuki on #webkit).
580
581         Reverted changesets:
582
583         "[WTF] Implement WTF::ThreadGroup"
584         https://bugs.webkit.org/show_bug.cgi?id=174081
585         http://trac.webkit.org/changeset/219238
586
587         "Unreviewed, build fix after r219238"
588         https://bugs.webkit.org/show_bug.cgi?id=174081
589         http://trac.webkit.org/changeset/219239
590
591         "Unreviewed, CLoop build fix after r219238"
592         https://bugs.webkit.org/show_bug.cgi?id=174081
593         http://trac.webkit.org/changeset/219241
594
595 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
596
597         [GTK][WPE] Enable X-Content-Type-Options: nosniff
598         https://bugs.webkit.org/show_bug.cgi?id=174250
599
600         Reviewed by Carlos Alberto Lopez Perez.
601
602         * Scripts/webkitperl/FeatureList.pm:
603
604 2017-07-07  Charlie Turner  <cturner@igalia.com>
605         [GStreamer] vid.me videos do not play
606         https://bugs.webkit.org/show_bug.cgi?id=172240
607
608         Reviewed by Xabier Rodriguez-Calvar.
609
610         Build httpsoupsrc again for use in adaptive streaming pipelines, and
611         have the existing libsoup build against GNOME to avoid header drift
612         against GStreamer's linked Soup library.
613
614         * gtk/jhbuild.modules:
615
616 2017-07-06  Lucas Forschler  <lforschler@apple.com>
617
618         Write a support script to enable buildbot to upload to S3
619         https://bugs.webkit.org/show_bug.cgi?id=174196
620         
621         Reviewed by Stephanie Lewis.
622
623         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
624         (uploadToS3):
625         (archiveExists):
626
627 2017-07-06  Lucas Forschler  <lforschler@apple.com>
628
629         Enabling uploading archives to S3.
630         https://bugs.webkit.org/show_bug.cgi?id=174198
631         
632         Reviewed by Stephanie Lewis.
633
634         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
635         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
636         (UploadMinifiedBuiltProduct): Upload minified archive to build master
637         (TransferToS3): Transfer full and minified archives to S3
638
639 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
640
641         [WTF] Implement WTF::ThreadGroup
642         https://bugs.webkit.org/show_bug.cgi?id=174081
643
644         Reviewed by Mark Lam.
645
646         Add WTF::ThreadGroup tests.
647
648         * TestWebKitAPI/CMakeLists.txt:
649         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
650         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
651         (TestWebKitAPI::TEST):
652
653 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
654
655         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
656         https://bugs.webkit.org/show_bug.cgi?id=174150
657
658         Reviewed by Mark Lam.
659
660         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
661         (TestWebKitAPI::TEST):
662         * TestWebKitAPI/TestsController.cpp:
663         (TestWebKitAPI::TestsController::TestsController):
664
665 2017-07-06  Lucas Forschler  <lforschler@apple.com>
666
667         Enabling uploading archives to S3.
668         https://bugs.webkit.org/show_bug.cgi?id=174198
669         
670         Reviewed by Lucas Forschler.
671
672         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
673         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
674         (UploadMinifiedBuiltProduct): Upload minified archive to build master
675         (TransferToS3): Transfer full and minified archives to S3
676
677 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
678
679         [GTK][WPE] kill-old-process should kill more webkit related process
680         https://bugs.webkit.org/show_bug.cgi?id=174220
681
682         Reviewed by Michael Catanzaro.
683
684         Generate list of possible webkit-related process names and add
685         them to the list of process to kill.
686         Also update the possible system related process for GTK+/WPE.
687
688         * BuildSlaveSupport/kill-old-processes:
689         (listAllWebKitPrograms):
690         (main):
691
692 2017-07-06  Chris Dumez  <cdumez@apple.com>
693
694         FileMonitor should not be ref counted
695         https://bugs.webkit.org/show_bug.cgi?id=174166
696
697         Reviewed by Brent Fulgham.
698
699         Update the API tests to reflect the API change.
700
701         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
702         (TestWebKitAPI::TEST_F):
703
704 2017-07-06  Commit Queue  <commit-queue@webkit.org>
705
706         Unreviewed, rolling out r219194.
707         https://bugs.webkit.org/show_bug.cgi?id=174207
708
709         it broke some layout tests (Requested by clopez on #webkit).
710
711         Reverted changeset:
712
713         "[GStreamer] vid.me videos do not play"
714         https://bugs.webkit.org/show_bug.cgi?id=172240
715         http://trac.webkit.org/changeset/219194
716
717 2017-07-06  Matt Lewis  <jlewis3@apple.com>
718
719         Unreviewed, rolling out r219178.
720
721         This caused a consistent failure with the API test
722         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
723
724         Reverted changeset:
725
726         "[WTF] Clean up StringStatics.cpp by using
727         LazyNeverDestroyed<> for Atoms"
728         https://bugs.webkit.org/show_bug.cgi?id=174150
729         http://trac.webkit.org/changeset/219178
730
731 2017-07-06  Alicia Boya García  <aboya@igalia.com>
732
733         Add CWD to Perl library path (no longer the default since 5.26.0)
734         https://bugs.webkit.org/show_bug.cgi?id=174200
735
736         Reviewed by Michael Catanzaro.
737
738         * Scripts/webkitpy/tool/commands/setupgitclone.py:
739         (SetupGitClone._get_username_and_email):
740
741 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
742
743         Unreviewed, update my email address.
744
745         * Scripts/webkitpy/common/config/contributors.json:
746
747 2017-07-06  Charlie Turner  <cturner@igalia.com>
748         [GStreamer] vid.me videos do not play
749         https://bugs.webkit.org/show_bug.cgi?id=172240
750
751         Reviewed by Xabier Rodriguez-Calvar.
752
753         Build httpsoupsrc again for use in adaptive streaming pipelines, and
754         have the existing libsoup build against GNOME to avoid header drift
755         against GStreamer's linked Soup library.
756
757         * gtk/jhbuild.modules:
758
759 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
760
761         [WTF] Move SoftLinking.h into WTF
762         https://bugs.webkit.org/show_bug.cgi?id=174000
763
764         Reviewed by Alex Christensen.
765
766         * DumpRenderTree/mac/TestRunnerMac.mm:
767         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
768         (test_primary_header):
769         (ErrorCollector.__init__): Deleted.
770         (ErrorCollector.__call__): Deleted.
771         (ErrorCollector.results): Deleted.
772         (ErrorCollector.result_list): Deleted.
773         (ErrorCollector.verify_all_categories_are_seen): Deleted.
774         (MockIo.open): Deleted.
775         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
776         (CppFunctionsTest.test_create_acronym): Deleted.
777         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
778         (CppFunctionsTest.test_parameter): Deleted.
779         (CppFunctionsTest.test_single_line_view): Deleted.
780         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
781         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
782         (CppFunctionsTest.test_parameter_list): Deleted.
783         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
784         (CppStyleTestBase.process_file_data): Deleted.
785         (CppStyleTestBase.perform_lint): Deleted.
786         (CppStyleTestBase.perform_single_line_lint): Deleted.
787         (CppStyleTestBase.perform_multi_line_lint): Deleted.
788         (CppStyleTestBase.perform_language_rules_check): Deleted.
789         (CppStyleTestBase.perform_function_lengths_check): Deleted.
790         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
791         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
792         (CppStyleTestBase.perform_include_what_you_use): Deleted.
793         (CppStyleTestBase.perform_header_guard_check): Deleted.
794         (CppStyleTestBase.assert_lint): Deleted.
795         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
796         (CppStyleTestBase.assert_multi_line_lint): Deleted.
797         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
798         (CppStyleTestBase.assert_language_rules_check): Deleted.
799         (CppStyleTestBase.assert_include_what_you_use): Deleted.
800         (CppStyleTestBase.assert_header_guard): Deleted.
801         (CppStyleTestBase.assert_blank_lines_check): Deleted.
802         (CppStyleTestBase.assert_positions_equal): Deleted.
803         (FunctionDetectionTest.test_basic_function_detection): Deleted.
804         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
805         (FunctionDetectionTest.test_pure_function_detection): Deleted.
806         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
807         (FunctionDetectionTest.test_ignore_macros): Deleted.
808         (FunctionDetectionTest.test_non_functions): Deleted.
809         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
810         (FunctionDetectionTest.test_parameter_list): Deleted.
811         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
812         (CppStyleTest.test_asm_lines_ignored): Deleted.
813         (CppStyleTest.test_get_line_width): Deleted.
814         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
815         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
816         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
817         (CppStyleTest.test_position): Deleted.
818         (CppStyleTest.test_rfind_in_lines): Deleted.
819         (CppStyleTest.test_close_expression): Deleted.
820         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
821         (CppStyleTest.test_cstyle_cast): Deleted.
822         (CppStyleTest.test_runtime_casting): Deleted.
823         (CppStyleTest.test_runtime_selfinit): Deleted.
824         (CppStyleTest.test_runtime_rtti): Deleted.
825         (CppStyleTest.test_static_cast_readability): Deleted.
826         (CppStyleTest.test_check_for_unnamed_params): Deleted.
827         (CppStyleTest.void): Deleted.
828         (CppStyleTest.test_deprecated_cast): Deleted.
829         (CppStyleTest.test_mock_method): Deleted.
830         (CppStyleTest.test_sizeof_type): Deleted.
831         (CppStyleTest.cases): Deleted.
832         (CppStyleTest.for): Deleted.
833         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
834         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
835         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
836         (CppStyleTest.test_include_what_you_use): Deleted.
837         (CppStyleTest.test_files_belong_to_same_module): Deleted.
838         (CppStyleTest.test_cleanse_line): Deleted.
839         (CppStyleTest.test_multi_line_comments): Deleted.
840         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
841         (CppStyleTest.test_multiline_strings): Deleted.
842         (CppStyleTest.test_platformh_comments): Deleted.
843         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
844         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
845         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
846         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
847         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
848         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
849         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
850         (CppStyleTest.test_check_posix_threading): Deleted.
851         (CppStyleTest.test_insecure_string_operations): Deleted.
852         (CppStyleTest.test_format_strings): Deleted.
853         (CppStyleTest.test_insecure_temp_file): Deleted.
854         (CppStyleTest.test_variable_length_array_detection): Deleted.
855         (CppStyleTest.test_braces): Deleted.
856         (CppStyleTest.test_check_check): Deleted.
857         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
858         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
859         (CppStyleTest.test_spacing_for_fncall): Deleted.
860         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
861         (CppStyleTest.test_spacing_before_braces): Deleted.
862         (CppStyleTest.test_spacing_between_braces): Deleted.
863         (CppStyleTest.test_spacing_before_brackets): Deleted.
864         (CppStyleTest.test_cpp_lambda_functions): Deleted.
865         (CppStyleTest.test_objective_c_block): Deleted.
866         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
867         (CppStyleTest.test_spacing_around_else): Deleted.
868         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
869         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
870         (CppStyleTest.test_operator_methods): Deleted.
871         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
872         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
873         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
874         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
875         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
876         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
877         (CppStyleTest.test_space_after_comment_marker): Deleted.
878         (CppStyleTest.test_newline_at_eof): Deleted.
879         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
880         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
881         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
882         (CppStyleTest.test_invalid_utf8): Deleted.
883         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
884         (CppStyleTest.test_is_blank_line): Deleted.
885         (CppStyleTest.test_blank_lines_check): Deleted.
886         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
887         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
888         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
889         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
890         (CppStyleTest.test_comma): Deleted.
891         (CppStyleTest.test_declaration): Deleted.
892         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
893         (CppStyleTest.test_indent): Deleted.
894         (CppStyleTest.test_indent.Foo): Deleted.
895         (CppStyleTest.test_not_alabel): Deleted.
896         (CppStyleTest.test_tab): Deleted.
897         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
898         (CppStyleTest.test_build_class): Deleted.
899         (CppStyleTest.test_build_class.definitions): Deleted.
900         (CppStyleTest.test_build_class.Foo): Deleted.
901         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
902         (CppStyleTest.test_build_end_comment): Deleted.
903         (CppStyleTest.test_build_forward_decl): Deleted.
904         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
905         (CppStyleTest.test_build_header_guard): Deleted.
906         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
907         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
908         (CppStyleTest.test_build_printf_format): Deleted.
909         (CppStyleTest.test_runtime_printf_format): Deleted.
910         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
911         (CppStyleTest.test_build_storage_class): Deleted.
912         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
913         (CppStyleTest.test_build_storage_class.declaration): Deleted.
914         (CppStyleTest.test_build_storage_class.after): Deleted.
915         (CppStyleTest.test_build_storage_class.is): Deleted.
916         (CppStyleTest.test_legal_copyright): Deleted.
917         (CppStyleTest.test_invalid_increment): Deleted.
918         (CppStyleTest.test_enum_bitfields): Deleted.
919         (CppStyleTest.test_plain_integral_bitfields): Deleted.
920         (CleansedLinesTest.test_init_empty): Deleted.
921         (CleansedLinesTest.test_collapse_strings): Deleted.
922         (OrderOfIncludesTest.tearDown): Deleted.
923         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
924         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
925         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
926         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
927         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
928         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
929         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
930         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
931         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
932         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
933         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
934         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
935         (OrderOfIncludesTest.test_primary_header): Deleted.
936         (OrderOfIncludesTest.test_public_primary_header): Deleted.
937         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
938         (OrderOfIncludesTest.test_classify_include): Deleted.
939         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
940         (CheckForFunctionLengthsTest.tearDown): Deleted.
941         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
942         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
943         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
944         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
945         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
946         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
947         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
948         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
949         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
950         (CheckForFunctionLengthsTest.function_body): Deleted.
951         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
952         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
953         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
954         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
955         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
956         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
957         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
958         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
959         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
960         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
961         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
962         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
963         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
964         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
965         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
966         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
967         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
968         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
969         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
970         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
971         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
972         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
973         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
974         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
975         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
976         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
977         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
978         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
979         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
980         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
981         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
982         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
983         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
984         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
985         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
986         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
987         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
988         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
989         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
990         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
991         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
992         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
993         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
994         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
995         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
996         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
997         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
998         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
999         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
1000         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
1001         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
1002         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
1003         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
1004         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
1005         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
1006         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
1007         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
1008         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
1009         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
1010         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
1011         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
1012         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
1013         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
1014         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
1015         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
1016         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
1017         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
1018         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
1019         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
1020         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
1021         (LeakyPatternTest.test_get_dc): Deleted.
1022         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
1023         (LeakyPatternTest.test_own_get_dc): Deleted.
1024         (LeakyPatternTest.test_create_dc): Deleted.
1025         (LeakyPatternTest.test_create_compatible_dc): Deleted.
1026         (WebKitStyleTest.test_indentation): Deleted.
1027         (WebKitStyleTest.test_indentation.Foo): Deleted.
1028         (WebKitStyleTest.test_indentation.Document): Deleted.
1029         (WebKitStyleTest.test_spacing): Deleted.
1030         (WebKitStyleTest.test_line_breaking): Deleted.
1031         (WebKitStyleTest.test_braces): Deleted.
1032         (WebKitStyleTest.test_braces.MyClass): Deleted.
1033         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
1034         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
1035         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
1036         (WebKitStyleTest.test_null_false_zero): Deleted.
1037         (WebKitStyleTest.test_directive_indentation): Deleted.
1038         (WebKitStyleTest.test_using_std): Deleted.
1039         (WebKitStyleTest.test_using_namespace): Deleted.
1040         (WebKitStyleTest.test_max_macro): Deleted.
1041         (WebKitStyleTest.test_min_macro): Deleted.
1042         (WebKitStyleTest.test_wtf_move): Deleted.
1043         (WebKitStyleTest.test_ctype_fucntion): Deleted.
1044         (WebKitStyleTest.test_names): Deleted.
1045         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
1046         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
1047         (WebKitStyleTest.test_names.declarations): Deleted.
1048         (WebKitStyleTest.test_names.struct): Deleted.
1049         (WebKitStyleTest.test_names.VectorType): Deleted.
1050         (WebKitStyleTest.test_parameter_names): Deleted.
1051         (WebKitStyleTest.test_comments): Deleted.
1052         (WebKitStyleTest.test_webkit_export_check): Deleted.
1053         (WebKitStyleTest.test_member_initialization_list): Deleted.
1054         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
1055         (WebKitStyleTest.test_other): Deleted.
1056         (CppCheckerTest.mock_handle_style_error): Deleted.
1057         (CppCheckerTest._checker): Deleted.
1058         (CppCheckerTest.test_init): Deleted.
1059         (CppCheckerTest.test_eq): Deleted.
1060         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
1061         (CppCheckerTest.test_ne): Deleted.
1062         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1063         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1064         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1065         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1066         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1067         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1068
1069 2017-07-05  Saam Barati  <sbarati@apple.com>
1070
1071         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
1072         https://bugs.webkit.org/show_bug.cgi?id=174188
1073         <rdar://problem/30581423>
1074
1075         Reviewed by Mark Lam.
1076
1077         * Scripts/run-jsc-stress-tests:
1078
1079 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1080
1081         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1082         https://bugs.webkit.org/show_bug.cgi?id=174150
1083
1084         Reviewed by Mark Lam.
1085
1086         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1087         (TestWebKitAPI::TEST):
1088
1089 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1090
1091         Remove copy of ICU headers from WebKit
1092         https://bugs.webkit.org/show_bug.cgi?id=116407
1093
1094         Reviewed by Alex Christensen.
1095
1096         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1097         * TestWebKitAPI/Configurations/Base.xcconfig:
1098         * WebKitTestRunner/Configurations/Base.xcconfig:
1099
1100 2017-07-05  Chris Dumez  <cdumez@apple.com>
1101
1102         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
1103         https://bugs.webkit.org/show_bug.cgi?id=174163
1104         <rdar://problem/33067518>
1105
1106         Reviewed by Alex Christensen.
1107
1108         Add API test coverage.
1109
1110         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1111         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
1112         (TEST):
1113
1114 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1115
1116         When dragging a selection, clearing the selection in dragstart should not crash the web process
1117         https://bugs.webkit.org/show_bug.cgi?id=174142
1118         <rdar://problem/33067501>
1119
1120         Reviewed by Tim Horton.
1121
1122         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
1123         drag is starting up.
1124
1125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1126         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
1127         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1128         (TestWebKitAPI::TEST):
1129
1130 2017-07-05  Daniel Bates  <dabates@apple.com>
1131
1132         Do not pass API::FrameInfo for source frame or clear out page of target frame on
1133         API navigation
1134         https://bugs.webkit.org/show_bug.cgi?id=174170
1135         <rdar://problem/33140328>
1136
1137         Reviewed by Brady Eidson.
1138
1139         Update tests as needed for the behavior change.
1140
1141         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1142         (TEST):
1143
1144 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
1145
1146         Add WebKitPrivateFrameworkStubs for iOS 11
1147         https://bugs.webkit.org/show_bug.cgi?id=173988
1148
1149         Reviewed by David Kilzer.
1150
1151         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
1152         should use the same directory for private framework stubs.
1153         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1154
1155 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
1156
1157         [MediaStream] Protect request and web view during gUM client callback
1158         https://bugs.webkit.org/show_bug.cgi?id=174096
1159         <rdar://problem/32833102>
1160
1161         Reviewed by Youenn Fablet.
1162
1163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1164         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
1165
1166 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1167
1168         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
1169
1170         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1171
1172 2017-07-05  Matt Lewis  <jlewis3@apple.com>
1173
1174         Unreviewed, rolling out r219128.
1175
1176         Spoke with engineer who originally submitted, Patch for APi
1177         test to follow.
1178
1179         Reverted changeset:
1180
1181         "Unreviewed, rolling out r219070."
1182         https://bugs.webkit.org/show_bug.cgi?id=174082
1183         http://trac.webkit.org/changeset/219128
1184
1185 2017-07-05  Matt Lewis  <jlewis3@apple.com>
1186
1187         Unreviewed, rolling out r219070.
1188
1189         This revision caused consistent failures of the API test
1190         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
1191
1192         Reverted changeset:
1193
1194         "Pasting single words copied to UIPasteboard inserts URLs in
1195         editable areas"
1196         https://bugs.webkit.org/show_bug.cgi?id=174082
1197         http://trac.webkit.org/changeset/219070
1198
1199 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1200
1201         Remove unused EFL logo from bot watcher dashboard
1202         https://bugs.webkit.org/show_bug.cgi?id=174136
1203
1204         Reviewed by Alexey Proskuryakov.
1205
1206         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
1207         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
1208
1209 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1210
1211         [GTK] Add more GTK bots to dashboard
1212         https://bugs.webkit.org/show_bug.cgi?id=174129
1213
1214         Reviewed by Carlos Alberto Lopez Perez.
1215
1216         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
1217         them.
1218
1219         This also changes the sort order to put WPE above GTK so that it's not buried under all the
1220         less-essential GTK bots.
1221
1222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1224         (WebKitBuildbot):
1225
1226 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1227
1228         [WPE] Add WPE to bot watcher dashboard
1229         https://bugs.webkit.org/show_bug.cgi?id=174119
1230
1231         Reviewed by Alexey Proskuryakov.
1232
1233         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
1234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
1235         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
1236         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1238         (WebKitBuildbot):
1239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1240         (table.queue-grid tr.platform.linux-wpe img.logo):
1241
1242 2017-07-03  Lucas Forschler  <lforschler@apple.com>
1243
1244         https://bugs.webkit.org/show_bug.cgi?id=174105
1245         
1246         Reviewed by Stephanie Lewis.
1247
1248         * BuildSlaveSupport/built-product-archive:
1249         (main): Add a -minify parser option
1250         (createZip): Pass along the optional Minify argument if requested
1251         (minifySource): This will trim down archives, logic limited to Mac platform.
1252
1253 2017-07-03  Matt Rajca  <mrajca@apple.com>
1254
1255         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
1256         https://bugs.webkit.org/show_bug.cgi?id=174103
1257
1258         Reviewed by Alex Christensen.
1259
1260         Added an API test.
1261
1262         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
1263         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1264         (TEST): Added test.
1265         * TestWebKitAPI/cocoa/TestWKWebView.h:
1266         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1267         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
1268
1269 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1270
1271         Unreviewed, rolling out r219103.
1272
1273         Caused multiple build failures.
1274
1275         Reverted changeset:
1276
1277         "Remove copy of ICU headers from WebKit"
1278         https://bugs.webkit.org/show_bug.cgi?id=116407
1279         http://trac.webkit.org/changeset/219103
1280
1281 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1282
1283         Remove copy of ICU headers from WebKit
1284         https://bugs.webkit.org/show_bug.cgi?id=116407
1285
1286         Reviewed by Alex Christensen.
1287
1288         Use WTF's copy of ICU headers.
1289
1290         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1291         * TestWebKitAPI/Configurations/Base.xcconfig:
1292         * WebKitTestRunner/Configurations/Base.xcconfig:
1293
1294 2017-07-03  Brady Eidson  <beidson@apple.com>
1295
1296         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
1297         https://bugs.webkit.org/show_bug.cgi?id=174073
1298
1299         Reviewed by Andy Estes.
1300
1301         * DumpRenderTree/mac/TestRunnerMac.mm:
1302         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
1303
1304         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
1305         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
1306
1307 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1308
1309         Unreviewed, rolling out r219083.
1310
1311         The revision caused an API failure on all testing platforms.
1312
1313         Reverted changeset:
1314
1315         "[MediaStream] Protect request and web view during gUM client
1316         callback"
1317         https://bugs.webkit.org/show_bug.cgi?id=174096
1318         http://trac.webkit.org/changeset/219083
1319
1320 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
1321
1322         webkitpy: Properly number duplicated crashlogs
1323         https://bugs.webkit.org/show_bug.cgi?id=172002
1324
1325         Reviewed by Aakash Jain.
1326
1327         * Scripts/webkitpy/common/system/crashlogs.py:
1328         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
1329         an increasing integer.
1330         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1331         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
1332         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
1333         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
1334
1335 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
1336
1337         WebContent processes crash when the network process crashes with pending connection requests
1338         https://bugs.webkit.org/show_bug.cgi?id=174065
1339         <rdar://problem/30359835>
1340
1341         Reviewed by Tim Horton.
1342
1343         Add a API to ensure UI process tries to relaunch a new network process when the network process
1344         crashes with pending network connection requests.
1345
1346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1347         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
1348         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1349         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1350         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
1351
1352 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
1353
1354         [MediaStream] Protect request and web view during gUM client callback
1355         https://bugs.webkit.org/show_bug.cgi?id=174096
1356         <rdar://problem/32833102>
1357
1358         Reviewed by Youenn Fablet.
1359
1360         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1361         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
1362
1363 2017-07-03  Andy Estes  <aestes@apple.com>
1364
1365         [Xcode] Add an experimental setting to build with ccache
1366         https://bugs.webkit.org/show_bug.cgi?id=173875
1367
1368         Reviewed by Tim Horton.
1369
1370         On systems that already have ccache(1) installed, this patch adds experimental support for
1371         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
1372
1373         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
1374         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
1375         find the toolchain from which to run clang, and then invokes ccache with the required
1376         arguments.
1377
1378         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
1379         precompiled headers to work properly [1].
1380
1381         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
1382         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
1383         during linking.
1384         
1385         [1] https://ccache.samba.org/manual.html#_precompiled_headers
1386
1387         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
1388         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
1389         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
1390         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
1391         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
1392         * ccache/README.md: Added.
1393         * ccache/ccache-clang: Added.
1394         * ccache/ccache-clang++: Added.
1395         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
1396
1397 2017-07-03  Alex Christensen  <achristensen@webkit.org>
1398
1399         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
1400         https://bugs.webkit.org/show_bug.cgi?id=174051
1401
1402         Reviewed by Tim Horton.
1403
1404         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1405         (TestWebKitAPI::TEST_F):
1406
1407 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1408
1409         Unreviewed, rolling out r219024.
1410
1411         This patch cause 3 didferent test to fail.
1412
1413         Reverted changeset:
1414
1415         "REGRESSION(r215096) Queries of URLs with non-special schemes
1416         should not percent-encode single quotes"
1417         https://bugs.webkit.org/show_bug.cgi?id=174051
1418         http://trac.webkit.org/changeset/219024
1419
1420 2017-07-03  Chris Dumez  <cdumez@apple.com>
1421
1422         Drop ResourceLoadStatisticsStore's statisticsLock
1423         https://bugs.webkit.org/show_bug.cgi?id=174080
1424
1425         Reviewed by Brent Fulgham.
1426
1427         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
1428
1429         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1430         (WTR::TestController::isStatisticsPrevalentResource):
1431         (WTR::TestController::isStatisticsHasHadUserInteraction):
1432         (WTR::TestController::isStatisticsGrandfathered):
1433
1434 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1435
1436         Pasting single words copied to UIPasteboard inserts URLs in editable areas
1437         https://bugs.webkit.org/show_bug.cgi?id=174082
1438         <rdar://problem/33046992>
1439
1440         Reviewed by Tim Horton.
1441
1442         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
1443
1444         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1445         (TestWebKitAPI::setUpWebViewForPasteboardTests):
1446         (TestWebKitAPI::TEST):
1447
1448 2017-07-02  Brady Eidson  <beidson@apple.com>
1449
1450         Add API test for all parts of WebKit1 API related to favicons.
1451         https://bugs.webkit.org/show_bug.cgi?id=174069
1452
1453         Reviewed by Andy Estes.
1454
1455         These two API tests cover all WebKit1 API related to icons.
1456         
1457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1458         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
1459         (mainResourceData):
1460         (defaultFaviconData):
1461         (customFaviconData):
1462         (imageFromData):
1463         (+[IconLoadingProtocol canInitWithRequest:]):
1464         (+[IconLoadingProtocol canonicalRequestForRequest:]):
1465         (-[IconLoadingProtocol startLoading]):
1466         (-[IconLoadingProtocol stopLoading]):
1467         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1468         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
1469         (TestWebKitAPI::TEST):
1470
1471 2017-07-01  Dan Bernstein  <mitz@apple.com>
1472
1473         [iOS] Remove code only needed when building for iOS 9.x
1474         https://bugs.webkit.org/show_bug.cgi?id=174068
1475
1476         Reviewed by Tim Horton.
1477
1478         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1479         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1480         (WTR::initializeWebViewConfiguration):
1481         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1482         (-[HIDEventGenerator _createIOHIDEventType:]):
1483
1484 2017-07-01  Brady Eidson  <beidson@apple.com>
1485
1486         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
1487         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
1488
1489         Reviewed by Alex Christensen.
1490
1491         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1492
1493 2017-07-01  Dan Bernstein  <mitz@apple.com>
1494
1495         [macOS] Remove code only needed when building for OS X Yosemite
1496         https://bugs.webkit.org/show_bug.cgi?id=174067
1497
1498         Reviewed by Tim Horton.
1499
1500         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1501         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1502         * DumpRenderTree/mac/DumpRenderTree.mm:
1503         (setDefaultsToConsistentValuesForTesting):
1504         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1505         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
1506         * MiniBrowser/Configurations/Base.xcconfig:
1507         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1508         * TestWebKitAPI/Configurations/Base.xcconfig:
1509         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1510         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1511         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1512         (TestWebKitAPI::TEST_F):
1513         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1514         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
1515         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1516         (TestWebKitAPI::TEST_F):
1517         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1518         (TestWebKitAPI::TEST):
1519         * WebKitTestRunner/Configurations/Base.xcconfig:
1520         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1521         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1522         (WTR::InjectedBundle::platformInitialize):
1523         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1524         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
1525
1526 2017-07-01  Chris Dumez  <cdumez@apple.com>
1527
1528         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
1529         https://bugs.webkit.org/show_bug.cgi?id=174060
1530
1531         Reviewed by Brent Fulgham.
1532
1533         Port WebKitTestRunner over to the new Cocoa SPI.
1534
1535         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1536         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1537         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1538         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
1539         no-ops since this code runs in the WebContent process, not the
1540         UIProcess.
1541
1542         * WebKitTestRunner/TestController.cpp:
1543         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1544
1545 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
1546
1547         Unreviewed mac build fix.
1548
1549         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
1550         (TestWebKitAPI::TEST):
1551
1552 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
1553
1554         Add API to get WKActivatedElementInfo
1555         https://bugs.webkit.org/show_bug.cgi?id=174001
1556         <rdar://problem/29165518>
1557         
1558         Tests for now SPI to get activatedElementInfo.
1559
1560         Reviewed by Tim Horton.
1561
1562         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1563         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
1564         (TestWebKitAPI::TEST):
1565
1566 2017-06-30  Chris Dumez  <cdumez@apple.com>
1567
1568         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
1569         https://bugs.webkit.org/show_bug.cgi?id=174038
1570
1571         Reviewed by Brent Fulgham.
1572
1573         Fix typo in API name.
1574
1575         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1576         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1577         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1578         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1579         * WebKitTestRunner/TestController.cpp:
1580         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1581         * WebKitTestRunner/TestController.h:
1582         * WebKitTestRunner/TestInvocation.cpp:
1583         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1584
1585 2017-06-30  Alex Christensen  <achristensen@webkit.org>
1586
1587         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
1588         https://bugs.webkit.org/show_bug.cgi?id=174051
1589         <rdar://problem/33002846>
1590
1591         Reviewed by Tim Horton.
1592
1593         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1594         (TestWebKitAPI::TEST_F):
1595
1596 2017-06-30  Daniel Bates  <dabates@apple.com>
1597
1598         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
1599         https://bugs.webkit.org/show_bug.cgi?id=165160
1600         <rdar://problem/29451999>
1601
1602         Reviewed by Brady Eidson.
1603
1604         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
1605         for navigations and window creation.
1606
1607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1608         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
1609         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
1610         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
1611         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1612         (TEST):
1613
1614 2017-06-29  Jer Noble  <jer.noble@apple.com>
1615
1616         Make Legacy EME API controlled by RuntimeEnabled setting.
1617         https://bugs.webkit.org/show_bug.cgi?id=173994
1618
1619         Reviewed by Sam Weinig.
1620
1621         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1622
1623 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
1624
1625         Follow-up fix for r218996
1626
1627         Unreviewed infrastructure fix.
1628
1629         Repeated calls to 'ios_version' make the log noisy, memoize the function.
1630
1631         * Scripts/webkitpy/port/ios_simulator.py:
1632         (IOSSimulatorPort): Memoize ios_version().
1633
1634 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1635
1636         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
1637         https://bugs.webkit.org/show_bug.cgi?id=174017
1638         <rdar://problem/32959782>
1639
1640         Reviewed by Simon Fraser.
1641
1642         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
1643         changes, the caret would appear outside of the iframe.
1644
1645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1646         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
1647         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1648         (checkDragCaretRectIsContainedInRect):
1649         (TestWebKitAPI::TEST):
1650         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1651         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1652         (-[DataInteractionSimulator _resetSimulatedState]):
1653         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
1654         (-[DataInteractionSimulator _advanceProgress]):
1655         (-[DataInteractionSimulator lastKnownDragCaretRect]):
1656
1657 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
1658
1659         Add support for different versions of iOS when loading test expectations
1660         https://bugs.webkit.org/show_bug.cgi?id=173774
1661         <rdar://problem/32951132>
1662
1663         Rubber-stamped by Aakash Jain.
1664
1665         When running layout tests, we should support multiple version of iOS the same way we do Mac.
1666
1667         * Scripts/webkitpy/port/ios.py:
1668         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
1669         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
1670         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
1671         * Scripts/webkitpy/port/ios_device.py:
1672         (IOSDevicePort.ios_version): Ask connected devices for implementation.
1673         * Scripts/webkitpy/port/ios_device_unittest.py:
1674         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
1675         (IOSDeviceTest.test_baseline_searchpath): Ditto.
1676         (IOSDeviceTest.test_expectations_ordering): Ditto.
1677         * Scripts/webkitpy/port/ios_simulator.py:
1678         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
1679         ask the platform.
1680
1681 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
1682
1683         Fontconfig build breaks with glibc 2.15+
1684         https://bugs.webkit.org/show_bug.cgi?id=174019
1685
1686         Reviewed by Carlos Alberto Lopez Perez.
1687
1688         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
1689
1690         * wpe/jhbuild.modules:
1691         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
1692
1693 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1694
1695         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
1696         https://bugs.webkit.org/show_bug.cgi?id=174010
1697         <rdar://problem/32597802>
1698
1699         Reviewed by Tim Horton.
1700
1701         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
1702         snapshot fails for any reason.
1703
1704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1705         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
1706         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1707         (TestWebKitAPI::TEST):
1708
1709 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
1710
1711         AX: Cannot call setValue() on contenteditable or ARIA text controls
1712         https://bugs.webkit.org/show_bug.cgi?id=173520
1713
1714         Reviewed by Ryosuke Niwa.
1715
1716         Add setValue() method to WKTR (already existed in DRT).
1717
1718         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1719         (WTR::AccessibilityUIElement::setValue):
1720         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1721         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1722         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1723         (WTR::AccessibilityUIElement::setValue):
1724
1725 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
1726
1727         getBoundingClientRect returns wrong value for combination of page zoom and scroll
1728         https://bugs.webkit.org/show_bug.cgi?id=173841
1729         rdar://problem/32983841
1730
1731         Reviewed by Dean Jackson.
1732
1733         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
1734         always did text zooming.
1735
1736         * MiniBrowser/mac/WK1BrowserWindowController.m:
1737         (-[WK1BrowserWindowController zoomIn:]):
1738         (-[WK1BrowserWindowController zoomOut:]):
1739         (-[WK1BrowserWindowController canResetZoom]):
1740         (-[WK1BrowserWindowController resetZoom:]):
1741
1742 2017-06-29  John Wilander  <wilander@apple.com>
1743
1744         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
1745         https://bugs.webkit.org/show_bug.cgi?id=173940
1746         <rdar://problem/33018125>
1747
1748         Reviewed by Brent Fulgham.
1749
1750         This change allows the TestController to turn off
1751         regular resource load statistics telemetry submission
1752         and to manually control when telemetry is calculated
1753         and submitted.
1754
1755         * WebKitTestRunner/TestController.cpp:
1756         (WTR::TestController::initialize):
1757             Turns off automatic resource load statistics telemetry submission.
1758
1759 2017-06-29  Commit Queue  <commit-queue@webkit.org>
1760
1761         Unreviewed, rolling out r218512.
1762         https://bugs.webkit.org/show_bug.cgi?id=173981
1763
1764         "It changes the behavior of the JS API's JSEvaluateScript
1765         which breaks TurboTax" (Requested by saamyjoon on #webkit).
1766
1767         Reverted changeset:
1768
1769         "test262: Completion values for control flow do not match the
1770         spec"
1771         https://bugs.webkit.org/show_bug.cgi?id=171265
1772         http://trac.webkit.org/changeset/218512
1773
1774 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
1775
1776         Add WebKitSystemInterface for iOS 11
1777         https://bugs.webkit.org/show_bug.cgi?id=173936
1778
1779         Reviewed by Lucas Forschler.
1780
1781         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
1782
1783 2017-06-28  Keith Miller  <keith_miller@apple.com>
1784
1785         VMTraps has some races
1786         https://bugs.webkit.org/show_bug.cgi?id=173941
1787
1788         Reviewed by Michael Saboff.
1789
1790         Add new testing mode for testing the Watchdog with our stress
1791         tests.
1792
1793         * Scripts/run-jsc-stress-tests:
1794
1795 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1796
1797         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
1798         https://bugs.webkit.org/show_bug.cgi?id=173877
1799
1800         Reviewed by Brady Eidson.
1801
1802         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
1803         the next tests.
1804
1805         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1806         (testGetFavicon):
1807
1808 2017-06-28  Tim Horton  <timothy_horton@apple.com>
1809
1810         MobileSafari was constantly using 10-15% CPU viewing a PDF
1811         https://bugs.webkit.org/show_bug.cgi?id=173944
1812         <rdar://problem/33039910>
1813
1814         Reviewed by Simon Fraser.
1815
1816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1817         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
1818         Add a test that we ever call the stable presentation update callback
1819         when we have a WKPDFView up, instead of infinitely looping.
1820
1821 2017-06-28  Alex Christensen  <achristensen@webkit.org>
1822
1823         Prevent displaying URLs with small capital letters
1824         https://bugs.webkit.org/show_bug.cgi?id=173949
1825         <rdar://problem/32952058>
1826
1827         Reviewed by Brent Fulgham.
1828
1829         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1830         (TestWebKitAPI::TEST):
1831
1832 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
1833
1834         Unreviewed test fix.
1835
1836         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
1837
1838         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
1839
1840 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
1841
1842         Teach ResourceLoadStatistics to recognize changes in the file system
1843         https://bugs.webkit.org/show_bug.cgi?id=173800
1844         <rdar://problem/32937842>
1845
1846         Reviewed by Chris Dumez.
1847
1848         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1849         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
1850         (TestWebKitAPI::FileMonitorTest::tempFilePath):
1851         (TestWebKitAPI::handleFileModification):
1852         (TestWebKitAPI::handleFileDeletion):
1853         (TestWebKitAPI::resetTestState):
1854         (TestWebKitAPI::TEST_F):
1855
1856 2017-06-28  Brady Eidson  <beidson@apple.com>
1857
1858         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
1859         https://bugs.webkit.org/show_bug.cgi?id=173874
1860
1861         Reviewed by Alex Christensen.
1862
1863         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
1864
1865 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
1866
1867         Unreviewed, adding Don Olmstead to contributors.json
1868
1869         * Scripts/webkitpy/common/config/contributors.json:
1870
1871 2017-06-28  Alex Christensen  <achristensen@webkit.org>
1872
1873         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
1874         https://bugs.webkit.org/show_bug.cgi?id=173886
1875         <rdar://problem/32543191>
1876
1877         Reviewed by Andy Estes.
1878
1879         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1880         (ParsedRange::ParsedRange):
1881         (-[TestSchemeHandler initWithVideoData:]):
1882         (-[TestSchemeHandler webView:startURLSchemeTask:]):
1883         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
1884         (TEST):
1885
1886 2017-06-27  JF Bastien  <jfbastien@apple.com>
1887
1888         WebAssembly: running out of executable memory should throw OoM
1889         https://bugs.webkit.org/show_bug.cgi?id=171537
1890         <rdar://problem/32963338>
1891
1892         Reviewed by Saam Barati.
1893
1894         * Scripts/run-jsc-stress-tests: add a configuration which runs the
1895         tests under limited executable memory and avoids non-WebAssembly
1896         code generation so that we more reliably run out of executable
1897         memory in WebAssembly.
1898
1899 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1900
1901         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
1902         https://bugs.webkit.org/show_bug.cgi?id=173854
1903         <rdar://problem/32236827>
1904
1905         Reviewed by Ryosuke Niwa and Tim Horton.
1906
1907         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
1908
1909         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1910         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
1911         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1912         (TestWebKitAPI::TEST):
1913
1914 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
1915
1916         [PAL] Add symbol export macros for PAL
1917         https://bugs.webkit.org/show_bug.cgi?id=171519
1918
1919         Reviewed by Konstantin Tokarev.
1920
1921         * DumpRenderTree/config.h:
1922         * TestWebKitAPI/CMakeLists.txt:
1923         * TestWebKitAPI/config.h:
1924         * WebKitTestRunner/config.h:
1925
1926 2017-06-27  John Wilander  <wilander@apple.com>
1927
1928         Resource Load Statistics: Add telemetry
1929         https://bugs.webkit.org/show_bug.cgi?id=173499
1930         <rdar://problem/32826094>
1931
1932         Reviewed by Brent Fulgham.
1933
1934         Adds three new testRunner functions:
1935         - installStatisticsDidRunTelemetryCallback()
1936         - statisticsFireTelemetryHandler()
1937         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
1938
1939         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1940         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1941         (WTR::InjectedBundle::didReceiveMessageToPage):
1942         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1943         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
1944         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
1945         (WTR::TestRunner::statisticsFireTelemetryHandler):
1946         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1947         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1948         * WebKitTestRunner/TestController.cpp:
1949         (WTR::TestController::resetStateToConsistentValues):
1950         (WTR::TestController::statisticsFireTelemetryHandler):
1951         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1952         * WebKitTestRunner/TestController.h:
1953         * WebKitTestRunner/TestInvocation.cpp:
1954         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1955
1956 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
1957
1958         Add missing includes to fix compilation error on FreeBSD
1959         https://bugs.webkit.org/show_bug.cgi?id=172919
1960
1961         Reviewed by Mark Lam.
1962
1963         * ImageDiff/cairo/PlatformImageCairo.cpp:
1964
1965 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
1966
1967         Unreviewed, rolling out r218783.
1968
1969         Causing accessibility/mac/setting-attributes-is-
1970         asynchronous.html to crash consistently on mac-wk2 Debug
1971
1972         Reverted changeset:
1973
1974         "AX: Cannot call setValue() on contenteditable or ARIA text
1975         controls"
1976         https://bugs.webkit.org/show_bug.cgi?id=173520
1977         http://trac.webkit.org/changeset/218783
1978
1979 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1980
1981         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
1982         https://bugs.webkit.org/show_bug.cgi?id=173825
1983
1984         Reviewed by Saam Barati.
1985
1986         * DumpRenderTree/JavaScriptThreading.cpp:
1987         (runJavaScriptThread):
1988         (startJavaScriptThreads):
1989         * DumpRenderTree/mac/DumpRenderTree.mm:
1990         (runThread):
1991         (runPthread):
1992         (testThreadIdentifierMap):
1993
1994 2017-06-26  David Kilzer  <ddkilzer@apple.com>
1995
1996         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
1997         <https://webkit.org/b/173837>
1998
1999         Reviewed by Geoffrey Garen.
2000
2001         The clang static analyzer can't reason about objects that are
2002         assigned to a delegate as +1 retained, and then released
2003         later in a different method when the delegate is cleared.
2004
2005         Instead, use a common idiom where the object setting the
2006         delegate retains it as an instance variable on initialization.
2007         Then the same object clears the delegate and releases its
2008         instance variable during teardown.
2009
2010         Also add EXPECT_TRUE() tests to make sure the delegate objects
2011         match before teardown.
2012
2013         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2014         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2015         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2016         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2017         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2018         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
2019
2020 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2021
2022         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
2023         <https://webkit.org/b/173836>
2024
2025         Reviewed by Brady Eidson.
2026
2027         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2028         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
2029         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
2030         objects in this test.
2031
2032 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
2033
2034         [ATK] Add support for aria-details and aria-errormessage
2035         https://bugs.webkit.org/show_bug.cgi?id=172588
2036
2037         Reviewed by Chris Fleizach.
2038
2039         Add additional methods to test ARIA properties which are exposed via
2040         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
2041         to versions which support the details and error-message relation types.
2042
2043         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2044         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2045         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2046         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2047         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2048         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2049         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2050         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2051         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2052         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2053         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2054         * gtk/jhbuild.modules:
2055
2056 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2057
2058         Unreviewed. Add libfii to GTK+ install dependencies script.
2059
2060         * gtk/install-dependencies:
2061
2062 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2063
2064         Unreviewed, rolling out r215190.
2065
2066         Broke product select element on GNOME Bugzilla
2067
2068         Reverted changeset:
2069
2070         "[GTK] Misplaced right click menu on web page due to
2071         deprecated gtk_menu_popup()"
2072         https://bugs.webkit.org/show_bug.cgi?id=170553
2073         http://trac.webkit.org/changeset/215190
2074
2075 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
2076
2077         Remove Reflect.enumerate
2078         https://bugs.webkit.org/show_bug.cgi?id=173806
2079
2080         Reviewed by Yusuke Suzuki.
2081
2082         * Scripts/run-jsc-stress-tests:
2083
2084 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
2085
2086         AX: Cannot call setValue() on contenteditable or ARIA text controls
2087         https://bugs.webkit.org/show_bug.cgi?id=173520
2088
2089         Reviewed by Ryosuke Niwa.
2090
2091         Add setValue() method to WKTR (already existed in DRT).
2092
2093         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2094         (WTR::AccessibilityUIElement::setValue):
2095         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2096         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2097         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2098         (WTR::AccessibilityUIElement::setValue):
2099
2100 2017-06-23  Keith Miller  <keith_miller@apple.com>
2101
2102         Switch VMTraps to use halt instructions rather than breakpoint instructions
2103         https://bugs.webkit.org/show_bug.cgi?id=173677
2104
2105         Reviewed by JF Bastien.
2106
2107         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2108         (TEST):
2109
2110 2017-06-23  Youenn Fablet  <youenn@apple.com>
2111
2112         Set getUserMedia permission to true by default on WTR
2113         https://bugs.webkit.org/show_bug.cgi?id=173610
2114
2115         Reviewed by Alex Christensen.
2116
2117         Adding a way to reset the getUserMedia permission to pending.
2118
2119         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2120         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2121         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
2122         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2123         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2124         (WTR::TestRunner::setUserMediaPermissionAsUnset):
2125         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2126         * WebKitTestRunner/TestController.cpp:
2127         (WTR::TestController::resetStateToConsistentValues):
2128         (WTR::TestController::setUserMediaPermissionAsUnset):
2129         * WebKitTestRunner/TestController.h:
2130         * WebKitTestRunner/TestInvocation.cpp:
2131         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2132
2133 2017-06-23  Alex Christensen  <achristensen@webkit.org>
2134
2135         Add SPI to WKURLSchemeTask for redirection
2136         https://bugs.webkit.org/show_bug.cgi?id=173730
2137
2138         Reviewed by Brady Eidson.
2139
2140         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2141         (-[SchemeHandler webView:startURLSchemeTask:]):
2142         (-[SchemeHandler webView:stopURLSchemeTask:]):
2143         (TEST):
2144         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
2145         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
2146         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
2147         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
2148         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
2149
2150 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2151
2152         [WPE] Use JSC API to send script messages from web extension in tests
2153         https://bugs.webkit.org/show_bug.cgi?id=173757
2154
2155         Reviewed by Žan Doberšek.
2156
2157         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
2158         to run postMessage().
2159
2160         Fixes: /wpe/WebKitSecurityManager/file-xhr
2161                /wpe/WebKitConsoleMessage/console-api
2162                /wpe/WebKitConsoleMessage/js-exception
2163                /wpe/WebKitConsoleMessage/network-error
2164                /wpe/WebKitConsoleMessage/security-error
2165
2166         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2167         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
2168         (beforeAll): Ditto.
2169         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2170         (testWebContextSecurityFileXHR): Ditto.
2171         (beforeAll): Ditto.
2172         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2173         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
2174         (pageCreatedCallback): Remove ifdefs.
2175
2176 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2177
2178         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
2179
2180         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
2181         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
2182         doesn't exist yet in WPE.
2183
2184         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2185         (testWebViewJavaScriptDialogs):
2186         (testWebViewWindowProperties):
2187
2188 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2189
2190         [GTK] Upgrade pixman and cairo in jhbuild
2191         https://bugs.webkit.org/show_bug.cgi?id=173710
2192
2193         Reviewed by Carlos Alberto Lopez Perez.
2194
2195         * gtk/jhbuild.modules:
2196
2197 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2198
2199         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
2200         https://bugs.webkit.org/show_bug.cgi?id=173711
2201
2202         Reviewed by Carlos Alberto Lopez Perez.
2203
2204         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
2205         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
2206
2207         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2208         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
2209
2210 2017-06-22  David Kilzer  <ddkilzer@apple.com>
2211
2212         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
2213         <https://webkit.org/b/173721>
2214
2215         Reviewed by Joseph Pecoraro.
2216
2217         Use RetainPtr<> to create NSMutableDictionary and NSNumber
2218         objects to fix leaks and to avoid the autoreleasepool.
2219
2220         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
2221         (TEST):
2222
2223 2017-06-22  Matt Lewis  <jlewis3@apple.com>
2224
2225         Unreviewed, rolling out r218633.
2226
2227         The test is failing frequently on Sierra Debug and Windows
2228
2229         Reverted changeset:
2230
2231         "AX: Cannot call setValue() on contenteditable or ARIA text
2232         controls"
2233         https://bugs.webkit.org/show_bug.cgi?id=173520
2234         http://trac.webkit.org/changeset/218633
2235
2236 2017-06-22  David Kilzer  <ddkilzer@apple.com>
2237
2238         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
2239         <https://webkit.org/b/173690>
2240
2241         Reviewed by Chris Dumez.
2242
2243         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
2244         ownership of malloc()-ed memory, then frees it when it's
2245         released.  These tests were passing global variables into the
2246         method, which is not malloc()-ed memory, which violates the API
2247         contract.
2248
2249         The fix is to switch to use
2250         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
2251         NO for the last argument.
2252
2253         Caught by the clang static analyzer.
2254
2255         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2256         (TEST):
2257         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2258         (TEST):
2259
2260 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2261
2262         [GTK] Upgrade Harfbuzz to version 1.4.2
2263         https://bugs.webkit.org/show_bug.cgi?id=173592
2264
2265         Reviewed by Carlos Alberto Lopez Perez.
2266
2267         * gtk/jhbuild.modules:
2268
2269 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2270
2271         [WPE] Update WPEBackend-mesa
2272         https://bugs.webkit.org/show_bug.cgi?id=173705
2273
2274         Reviewed by Carlos Alberto Lopez Perez.
2275
2276         A crash has been fixed, needed for unit tests to work.
2277
2278         * wpe/jhbuild.modules:
2279
2280 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2281
2282         Remove unused coordinated graphics C API
2283         https://bugs.webkit.org/show_bug.cgi?id=173706
2284
2285         Reviewed by Žan Doberšek.
2286
2287         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
2288         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
2289         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
2290         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
2291         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
2292         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
2293
2294 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2295
2296         [WPE] Build glib API tests
2297         https://bugs.webkit.org/show_bug.cgi?id=173702
2298
2299         Reviewed by Žan Doberšek.
2300
2301         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
2302         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
2303         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
2304         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
2305         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
2306         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
2307         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
2308         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
2309         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
2310         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
2311         and implement the missing features.
2312
2313         * CMakeLists.txt:
2314         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
2315         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2316         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2317         (testAutomationSessionRequestSession):
2318         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2319         (testWebKitWebViewSessionState):
2320         (testWebKitWebViewSessionStateWithFormData):
2321         (testWebKitWebViewNavigationAfterSessionRestore):
2322         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2323         (beforeAll):
2324         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2325         (testCookieManagerEphemeral):
2326         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2327         (testBlobDownload):
2328         (beforeAll):
2329         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2330         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2331         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2332         (testProcessPerWebView):
2333         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2334         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2335         (testWebViewCreateNavigationData):
2336         (testWebViewJavaScriptDialogs):
2337         (testWebViewWindowProperties):
2338         (testWebViewMouseTarget):
2339         (testWebViewGeolocationPermissionRequests):
2340         (testWebViewUserMediaPermissionRequests):
2341         (testWebViewAudioOnlyUserMediaPermissionRequests):
2342         (testWebViewFileChooserRequest):
2343         (beforeAll):
2344         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2345         (beforeAll):
2346         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2347         (testPrivateBrowsing):
2348         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2349         (testFindControllerHide):
2350         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2351         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2352         (testWebKitSettings):
2353         (beforeAll):
2354         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2355         (testWebViewNewWithUserContentManager):
2356         (beforeAll):
2357         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2358         (testWebContextEphemeral):
2359         (testWebContextProxySettings):
2360         (beforeAll):
2361         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2362         (testWebViewWebContext):
2363         (testWebViewWebContextLifetime):
2364         (testWebViewEphemeral):
2365         (testWebViewSettings):
2366         (testWebViewCanShowMIMEType):
2367         (testWebViewPageVisibility):
2368         (testWebViewIsPlayingAudio):
2369         (beforeAll):
2370         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2371         (testWebsiteDataEphemeral):
2372         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2373         (documentLoadedCallback):
2374         (pageCreatedCallback):
2375         (methodCallCallback):
2376         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
2377         * TestWebKitAPI/glib/CMakeLists.txt:
2378         * TestWebKitAPI/glib/PlatformGTK.cmake:
2379         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2380         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2381         (main):
2382         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2383         (Test::adoptView):
2384         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2385         (WebKitTestBus::run):
2386         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2387         (WebViewTest::~WebViewTest):
2388         (WebViewTest::initializeWebView):
2389         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
2390         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
2391         (WebViewTest::platformDestroy):
2392         (WebViewTest::platformInitializeWebView):
2393         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
2394         (WebViewTest::resizeView):
2395         (WebViewTest::hideView):
2396         (parentWindowMapped):
2397         (WebViewTest::showInWindow):
2398         (WebViewTest::showInWindowAndWaitUntilMapped):
2399         (WebViewTest::mouseMoveTo):
2400         (WebViewTest::clickMouseButton):
2401         (WebViewTest::emitPopupMenuSignal):
2402         (WebViewTest::keyStroke):
2403         (WebViewTest::doMouseButtonEvent):
2404         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
2405         (WebViewTest::platformDestroy):
2406         (WebViewTest::platformInitializeWebView):
2407         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
2408         (WebViewTest::resizeView):
2409         (WebViewTest::hideView):
2410         (WebViewTest::mouseMoveTo):
2411         (WebViewTest::clickMouseButton):
2412         (WebViewTest::keyStroke):
2413
2414 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2415
2416         [GTK] Move WebKit2 GLib API tests to glib directories
2417         https://bugs.webkit.org/show_bug.cgi?id=173642
2418
2419         Reviewed by Žan Doberšek.
2420
2421         * CMakeLists.txt:
2422         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
2423         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
2424         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
2425         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
2426         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
2427         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
2428         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
2429         (testWebKitConsoleMessageNetworkError):
2430         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
2431         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
2432         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
2433         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
2434         (testLoadFromGResource):
2435         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
2436         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
2437         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
2438         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
2439         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
2440         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
2441         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
2442         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
2443         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
2444         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
2445         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
2446         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
2447         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
2448         (testWebViewRunJavaScript):
2449         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
2450         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
2451         (registerGResource):
2452         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
2453         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
2454         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
2455         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
2456         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
2457         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
2458         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
2459         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
2460         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
2461         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
2462         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
2463         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
2464         * TestWebKitAPI/glib/CMakeLists.txt: Added.
2465         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
2466         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
2467         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
2468         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
2469         (registerGResource):
2470         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
2471         (Test::getResourcesDir):
2472         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
2473         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
2474         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
2475         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
2476         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
2477         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
2478
2479 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2480
2481         [WPE] Add initial web extensions API
2482         https://bugs.webkit.org/show_bug.cgi?id=173640
2483
2484         Reviewed by Žan Doberšek.
2485
2486         Add style checker exceptions for WPE web extensions API files.
2487
2488         * Scripts/webkitpy/style/checker.py:
2489
2490 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2491
2492         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
2493         https://bugs.webkit.org/show_bug.cgi?id=173659
2494         <rdar://problem/32879788>
2495
2496         Reviewed by Tim Horton.
2497
2498         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
2499
2500         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
2501
2502         Augment this test page to log dragend and dragstart events on the drag source as well.
2503
2504         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2505         (checkStringArraysAreEqual):
2506         (TestWebKitAPI::TEST):
2507
2508 2017-06-21  Antoine Quint  <graouts@apple.com>
2509
2510         Ensure DRT always logs rAF suspension debugging code
2511         https://bugs.webkit.org/show_bug.cgi?id=173681
2512
2513         Reviewed by Tim "Mr. T" Horton.
2514
2515         * DumpRenderTree/mac/DumpRenderTree.mm:
2516         (resetWebPreferencesToConsistentValues):
2517
2518 2017-06-21  Chris Dumez  <cdumez@apple.com>
2519
2520         Allow constructing a WTF:Function from a function pointer
2521         https://bugs.webkit.org/show_bug.cgi?id=173660
2522
2523         Reviewed by Alex Christensen.
2524
2525         Add API test coverage.
2526
2527         * TestWebKitAPI/Tests/WTF/Function.cpp:
2528         (TestWebKitAPI::returnThree):
2529         (TestWebKitAPI::returnFour):
2530         (TestWebKitAPI::returnPassedValue):
2531         (TestWebKitAPI::TEST):
2532
2533 2017-06-21  Antoine Quint  <graouts@apple.com>
2534
2535         Add logging to identify when the Page suspends scripted animations
2536         https://bugs.webkit.org/show_bug.cgi?id=173626
2537
2538         Reviewed by Tim Horton.
2539
2540         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
2541
2542         * DumpRenderTree/mac/DumpRenderTree.mm:
2543         (resetWebPreferencesToConsistentValues):
2544
2545 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
2546
2547         AX: Cannot call setValue() on contenteditable or ARIA text controls
2548         https://bugs.webkit.org/show_bug.cgi?id=173520
2549
2550         Reviewed by Ryosuke Niwa.
2551
2552         Add setValue() method to WKTR (already existed in DRT).
2553
2554         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2555         (WTR::AccessibilityUIElement::setValue):
2556         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2557         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2558         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2559         (WTR::AccessibilityUIElement::setValue):
2560
2561 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
2562
2563         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
2564         as one of the dependencies required to build the product.
2565
2566         Rubber-stamped by Carlos Garcia Campos.
2567
2568         * gtk/install-dependencies:
2569         * wpe/install-dependencies:
2570
2571 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
2572
2573         Disable font variations on macOS Sierra and iOS 10
2574         https://bugs.webkit.org/show_bug.cgi?id=173618
2575         <rdar://problem/32879164>
2576
2577         Reviewed by Jon Lee.
2578
2579         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2580
2581 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2582
2583         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
2584         https://bugs.webkit.org/show_bug.cgi?id=173578
2585         <rdar://problem/32825028>
2586
2587         Reviewed by Tim Horton.
2588
2589         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
2590         a custom popover does not cause dragging to fail when the popover is presented.
2591
2592         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2593         (-[DataInteractionSimulator _advanceProgress]):
2594
2595 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2596
2597         [WPE] Add initial implementation of glib API
2598         https://bugs.webkit.org/show_bug.cgi?id=173546
2599
2600         Reviewed by Žan Doberšek.
2601
2602         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
2603         include WPE glib API files.
2604
2605         * Scripts/webkitperl/FeatureList.pm:
2606         * Scripts/webkitpy/style/checker.py:
2607         * Scripts/webkitpy/style/checkers/cpp.py:
2608         (check_identifier_name_in_declaration):
2609
2610 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2611
2612         [GTK] Upgrade to ICU to version 57.1
2613         https://bugs.webkit.org/show_bug.cgi?id=173538
2614
2615         Reviewed by Žan Doberšek.
2616
2617         * gtk/jhbuild.modules:
2618
2619 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2620
2621         [GTK] Remove unneeded modules from the jhbuild
2622         https://bugs.webkit.org/show_bug.cgi?id=170540
2623
2624         Reviewed by Michael Catanzaro.
2625
2626         We are building libxslt and libffi that we don't really need to build from sources.
2627
2628         * gtk/jhbuild.modules:
2629
2630 2017-06-19  Frederic Wang  <fwang@igalia.com>
2631
2632         [Mac] Add an experimental feature setting for async frame scrolling
2633         https://bugs.webkit.org/show_bug.cgi?id=173359
2634
2635         Reviewed by Simon Fraser.
2636
2637         * DumpRenderTree/mac/DumpRenderTree.mm:
2638         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
2639         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
2640         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2641         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
2642
2643 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
2644
2645         Unreviewed, adding myself to contributors.json
2646
2647         * Scripts/webkitpy/common/config/contributors.json:
2648
2649 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
2650
2651         test262: Completion values for control flow do not match the spec
2652         https://bugs.webkit.org/show_bug.cgi?id=171265
2653
2654         Reviewed by Saam Barati.
2655
2656         * Scripts/run-jsc-stress-tests:
2657         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
2658
2659 2017-06-19  Zalan Bujtas  <zalan@apple.com>
2660
2661         Opening certain mails brings up a mail that grows indefinitely.
2662         https://bugs.webkit.org/show_bug.cgi?id=173562
2663         <rdar://problem/32766579>
2664
2665         Reviewed by Tim Horton.
2666
2667         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2668         (TEST):
2669
2670 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2671
2672         [iOS DnD] Support .zip archives for file uploads via drag and drop
2673         https://bugs.webkit.org/show_bug.cgi?id=173511
2674         <rdar://problem/32521025>
2675
2676         Reviewed by Tim Horton.
2677
2678         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
2679         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
2680
2681         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2682         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
2683         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2684         (testZIPArchive):
2685         (TestWebKitAPI::TEST):
2686
2687 2017-06-18  Darin Adler  <darin@apple.com>
2688
2689         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
2690         https://bugs.webkit.org/show_bug.cgi?id=173526
2691
2692         Reviewed by Sam Weinig.
2693
2694         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
2695         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2696
2697         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
2698         tests for assignment before destruction ones.
2699
2700         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
2701         as a function, so it can be used in WTF::Function tests.
2702
2703         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
2704         Added tests for swap and for assignment before deref.
2705
2706         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
2707         to inline everything. Also removed the unnecessary clearing of the log every time
2708         the DerivedRefLogger constructor is called.
2709         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
2710
2711         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
2712         Added tests for assignment before deref and similar for releaseNonNull.
2713
2714 2017-06-19  Sam Weinig  <sam@webkit.org>
2715
2716         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
2717         https://bugs.webkit.org/show_bug.cgi?id=173513
2718
2719         Reviewed by Alex Christensen.
2720
2721         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2722         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2723         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
2724
2725 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
2726
2727         [Win] fast/dom/assign-to-window-status.html is flaky.
2728         https://bugs.webkit.org/show_bug.cgi?id=173512
2729
2730         Reviewed by Alex Christensen.
2731
2732         We should not dump status callbacks when test is done.
2733
2734         * DumpRenderTree/win/UIDelegate.cpp:
2735         (UIDelegate::setStatusText):
2736
2737 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2738
2739         [WPE][JHBuild] Update WPEBackend-mesa
2740         https://bugs.webkit.org/show_bug.cgi?id=173433
2741
2742         Unreviewed.
2743
2744         Update WPEBackend-mesa back (like it was done originally in r218344)
2745         after fixing the issue with the DISPLAY environment variables that
2746         caused the crashes.
2747
2748         * wpe/jhbuild.modules:
2749
2750 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2751
2752         Rename unit test file after r218482
2753         https://bugs.webkit.org/show_bug.cgi?id=173483
2754
2755         Unreviewed.
2756
2757         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
2758
2759 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2760
2761         Unreviewed. Fix wrong style checker condition added in r218487.
2762
2763         * Scripts/webkitpy/style/checkers/cpp.py:
2764         (check_identifier_name_in_declaration):
2765
2766 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
2767
2768         Missing <functional> includes make builds fail with GCC 7.x
2769         https://bugs.webkit.org/show_bug.cgi?id=173544
2770
2771         Unreviewed gardening.
2772
2773         Fix compilation with GCC 7.
2774
2775         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2776         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
2777
2778 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2779
2780         [GTK] Move GTK+ API files that could be shared to glib dirs
2781         https://bugs.webkit.org/show_bug.cgi?id=173545
2782
2783         Reviewed by Žan Doberšek.
2784
2785         Update paths of GTK+ API in watchlist and style checker.
2786
2787         * Scripts/webkitpy/common/config/watchlist:
2788         * Scripts/webkitpy/style/checker.py:
2789         * Scripts/webkitpy/style/checkers/cpp.py:
2790         (check_identifier_name_in_declaration):
2791
2792 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2793
2794         Port setup_environ_for_server should not set environment variables related with the driver.
2795         https://bugs.webkit.org/show_bug.cgi?id=173483
2796
2797         Reviewed by Carlos Garcia Campos.
2798
2799         The port setup_environ_for_server() should not set environment variables
2800         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
2801         This varibles should be only set on the driver setup_environ_for_test().
2802
2803         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
2804         into the test environment even when running the tests with a driver
2805         that is not the Xorg or Xvfb one.
2806
2807         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
2808         (Port.to.setup_environ_for_server):
2809         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
2810         (Driver._setup_environ_for_driver):
2811         * Scripts/webkitpy/port/driver_unittest.py:
2812         (DriverTest.test_setup_environ_for_test):
2813         (DriverTest):
2814         (DriverTest.test_setup_environ_base_vars):
2815         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
2816         (GtkPort.setup_environ_for_server):
2817         * Scripts/webkitpy/port/wayland_unittest.py: Added.
2818         (WaylandDriverTest):
2819         (WaylandDriverTest.make_driver):
2820         (WaylandDriverTest.make_environment):
2821         (WaylandDriverTest.test_checkdriver):
2822         (WaylandDriverTest.test_environment_needed_variables):
2823         (WaylandDriverTest.test_environment_forbidden_variables):
2824         (WaylandDriverTest.test_environment_optional_variables):
2825         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
2826         (WaylandDriver.check_driver):
2827         (WaylandDriver._setup_environ_for_test):
2828         * Scripts/webkitpy/port/xorgdriver.py:
2829         (XorgDriver.check_driver):
2830         (XorgDriver._setup_environ_for_test):
2831         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
2832         (XorgDriverTest):
2833         (XorgDriverTest.make_driver):
2834         (XorgDriverTest.make_environment):
2835         (XorgDriverTest.test_checkdriver):
2836         (XorgDriverTest.test_environment_needed_variables):
2837         (XorgDriverTest.test_environment_forbidden_variables):
2838         (XorgDriverTest.test_environment_optional_variables):
2839         * Scripts/webkitpy/port/xvfbdriver.py:
2840         (XvfbDriver._setup_environ_for_test):
2841         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2842         (XvfbDriverTest.assertDriverStartSuccessful):
2843
2844
2845 2017-05-14 Frederic Wang  <fwang@igalia.com>
2846
2847         Add heuristic to avoid flattening "fullscreen" iframes
2848         https://bugs.webkit.org/show_bug.cgi?id=171914
2849
2850         Reviewed by Simon Fraser.
2851
2852         * DumpRenderTree/mac/DumpRenderTree.mm:
2853         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
2854
2855 2017-06-18  Chris Dumez  <cdumez@apple.com>
2856
2857         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
2858         https://bugs.webkit.org/show_bug.cgi?id=173522
2859         <rdar://problem/31185739>
2860
2861         Reviewed by Darin Adler.
2862
2863         Add API test for re-entering Function's assignment operators.
2864
2865         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2866         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
2867         (TestWebKitAPI::TestObject::TestObject):
2868         (TestWebKitAPI::TestObject::~TestObject):
2869         (TestWebKitAPI::TestObject::operator()):
2870         (TestWebKitAPI::TEST):
2871
2872 2017-06-16  Dan Bernstein  <mitz@apple.com>
2873
2874         [Cocoa] Some declarations have missing or incorrect availability attributes
2875         https://bugs.webkit.org/show_bug.cgi?id=173508
2876
2877         Reviewed by Tim Horton.
2878
2879         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
2880         (TestWebKitAPI::TEST): Updated for renames.
2881
2882 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2883
2884         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
2885         https://bugs.webkit.org/show_bug.cgi?id=173366
2886         <rdar://problem/32767014>
2887
2888         Reviewed by Tim Horton.
2889
2890         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
2891         change in behavior.
2892
2893         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2894         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2895         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
2896         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
2897         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
2898         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
2899         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
2900         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
2901         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
2902         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
2903         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
2904         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
2905         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
2906         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
2907         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2908         (-[MockDragDropSession initWithItems:location:window:]):
2909         (-[MockDragDropSession allowsMoveOperation]):
2910         (-[MockDragDropSession isRestrictedToDraggingApplication]):
2911         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
2912         (-[MockDragDropSession canLoadObjectsOfClass:]):
2913         (-[MockDragDropSession canLoadObjectsOfClasses:]):
2914         (-[MockDragDropSession items]):
2915         (-[MockDragDropSession setItems:]):
2916         (-[MockDragDropSession locationInView:]):
2917         (-[MockDataOperationSession initWithProviders:location:window:]):
2918         (-[MockDataOperationSession session]):
2919         (-[MockDataOperationSession isLocal]):
2920         (-[MockDataOperationSession progress]):
2921         (-[MockDataOperationSession setProgressIndicatorStyle:]):
2922         (-[MockDataOperationSession progressIndicatorStyle]):
2923         (-[MockDataOperationSession operationMask]):
2924         (-[MockDataOperationSession localDragSession]):
2925         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
2926         (-[MockDataOperationSession canCreateItemsOfClass:]):
2927         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
2928         (-[MockDataInteractionSession initWithWindow:]):
2929         (-[MockDataInteractionSession localOperationMask]):
2930         (-[MockDataInteractionSession externalOperationMask]):
2931         (-[MockDataInteractionSession session]):
2932         (-[DataInteractionSimulator _advanceProgress]):
2933
2934 2017-06-16  Alex Christensen  <achristensen@webkit.org>
2935
2936         Show punycode to user if a URL has dotless i or j followed by diacritic dot
2937         https://bugs.webkit.org/show_bug.cgi?id=173431
2938
2939         Reviewed by Darin Adler.
2940
2941         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2942         (TestWebKitAPI::TEST):
2943
2944 2017-06-16  Chris Dumez  <cdumez@apple.com>
2945
2946         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
2947         https://bugs.webkit.org/show_bug.cgi?id=173472
2948         <rdar://problem/28858817>
2949
2950         Reviewed by Brady Eidson.
2951
2952         Add API test coverage.
2953
2954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2955         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
2956         (TEST):
2957
2958 2017-06-16  Brady Eidson  <beidson@apple.com>
2959
2960         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
2961         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
2962
2963         Reviewed by Daniel Bates.
2964
2965         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2966
2967 2017-06-16  Chris Dumez  <cdumez@apple.com>
2968
2969         DRT fails to reset page visibility between tests
2970         https://bugs.webkit.org/show_bug.cgi?id=173485
2971
2972         Reviewed by Alexey Proskuryakov.
2973
2974         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
2975         Fix this to address flakiness.
2976
2977         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
2978         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
2979         The test became flaky without the DRT change and was no longer flaky with the DRT
2980         change.
2981
2982         WebKitTestRunner already does this.
2983
2984         * DumpRenderTree/mac/DumpRenderTree.mm:
2985         (resetWebViewToConsistentStateBeforeTesting):
2986
2987 2017-06-16  Alex Christensen  <achristensen@webkit.org>
2988
2989         Implement basic authentication in MiniBrowser
2990         https://bugs.webkit.org/show_bug.cgi?id=173443
2991
2992         Reviewed by Tim Horton.
2993
2994         * MiniBrowser/mac/WK2BrowserWindowController.m:
2995         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
2996
2997 2017-06-16  Jer Noble  <jer.noble@apple.com>
2998
2999         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
3000         https://bugs.webkit.org/show_bug.cgi?id=173398
3001         <rdar://problem/32592961>
3002
3003         Reviewed by Eric Carlson.
3004
3005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3006         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
3007         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3008         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3009         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
3010         (TestWebKitAPI::TEST):
3011         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
3012
3013 2017-06-16  Matt Lewis  <jlewis3@apple.com>
3014
3015         Unreviewed, rolling out r218375.
3016
3017         The API test MediaStreamTrackDetached is still timing out
3018         after the patch
3019
3020         Reverted changeset:
3021
3022         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
3023         reports no recording to WebKit clients"
3024         https://bugs.webkit.org/show_bug.cgi?id=173398
3025         http://trac.webkit.org/changeset/218375
3026
3027 2017-06-15  Jer Noble  <jer.noble@apple.com>
3028
3029         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
3030         https://bugs.webkit.org/show_bug.cgi?id=173398
3031         <rdar://problem/32592961>
3032
3033         Reviewed by Eric Carlson.
3034
3035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3036         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
3037         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3038         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3039         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
3040         (TestWebKitAPI::TEST):
3041         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
3042
3043 2017-06-15  Matt Lewis  <jlewis3@apple.com>
3044
3045         Unreviewed, rolling out r218365.
3046
3047         The revision caused API timeouts on all builds.
3048
3049         Reverted changeset:
3050
3051         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
3052         reports no recording to WebKit clients"
3053         https://bugs.webkit.org/show_bug.cgi?id=173398
3054         http://trac.webkit.org/changeset/218365
3055
3056 2017-06-15  Jer Noble  <jer.noble@apple.com>
3057
3058         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
3059         https://bugs.webkit.org/show_bug.cgi?id=173398
3060         <rdar://problem/32592961>
3061
3062         Reviewed by Eric Carlson.
3063
3064         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3065         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
3066         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3067         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3068         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
3069         (TestWebKitAPI::TEST):
3070         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
3071
3072 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3073
3074         REGRESSION(r218344): [WPE] Thousands of layout test crashes
3075         https://bugs.webkit.org/show_bug.cgi?id=173433
3076
3077         Unreviewed.
3078
3079         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
3080
3081 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3082
3083         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
3084         https://bugs.webkit.org/show_bug.cgi?id=173061
3085
3086         Reviewed by Žan Doberšek.
3087
3088         Launch dyz <https://github.com/Igalia/dyz> with the script
3089         run-minibrowser for the wpe port. It is now built as part of the
3090         WPE dependencies with JHBuild.
3091
3092         * Scripts/run-minibrowser:
3093         * Scripts/webkitdirs.pm:
3094         (launcherPath):
3095         (launcherName):
3096         * wpe/install-dependencies: Luajit is needed for building dyz.
3097         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
3098
3099 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3100
3101         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
3102         https://bugs.webkit.org/show_bug.cgi?id=173338
3103         <rdar://problem/32777720>
3104
3105         Reviewed by Tim Horton.
3106
3107         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
3108         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
3109         these remaining items on drop.
3110
3111         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3112         (TestWebKitAPI::TEST):
3113         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3114         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3115
3116         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
3117
3118         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
3119
3120 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
3121
3122         [Win] Crash in accessibility layout test.
3123         https://bugs.webkit.org/show_bug.cgi?id=173401
3124
3125         Reviewed by Brent Fulgham.
3126
3127         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
3128         member will be automatically released when the _variant_t object goes out of scope if the vt member
3129         does not equal VT_UNKNOWN | VT_BYREF.
3130         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
3131
3132         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3133         (AccessibilityUIElement::titleUIElement):
3134
3135 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3136
3137         [GTK] Add API to allow overriding popup menus
3138         https://bugs.webkit.org/show_bug.cgi?id=172905
3139
3140         Reviewed by Michael Catanzaro.
3141
3142         Add a unit test to check the new API.
3143
3144         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3145         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
3146         (OptionMenuTest::OptionMenuTest):
3147         (OptionMenuTest::~OptionMenuTest):
3148         (OptionMenuTest::destroyMenu):
3149         (OptionMenuTest::showOptionMenuCallback):
3150         (OptionMenuTest::menuCloseCallback):
3151         (OptionMenuTest::showOptionMenu):
3152         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
3153         (OptionMenuTest::close):
3154         (OptionMenuTest::activateItem):
3155         (OptionMenuTest::selectItem):
3156         (testOptionMenuSimple):
3157         (testOptionMenuGroups):
3158         (testOptionMenuActivate):
3159         (testOptionMenuSelect):
3160         (beforeAll):
3161         (afterAll):
3162
3163 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
3164
3165         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
3166         https://bugs.webkit.org/show_bug.cgi?id=173399
3167
3168         Reviewed by Per Arne Vollan.
3169
3170         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
3171         Curl port needs to do nothing because libcurl doesn't have disk cache.
3172
3173         * DumpRenderTree/win/DumpRenderTree.cpp:
3174         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
3175         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
3176
3177 2017-06-14  Tomas Popela  <tpopela@redhat.com>
3178
3179         [GTK] integer expression expected if running Tools/gtk/install-dependencies
3180         https://bugs.webkit.org/show_bug.cgi?id=173356
3181
3182         Reviewed by Michael Catanzaro.
3183
3184         Use the correct operator to compare the strings.
3185
3186         * gtk/install-dependencies:
3187
3188 2017-06-14  Commit Queue  <commit-queue@webkit.org>
3189
3190         Unreviewed, rolling out r218285.
3191         https://bugs.webkit.org/show_bug.cgi?id=173391
3192
3193         API test fails on iOS (Requested by alexchristensen on
3194         #webkit).
3195
3196         Reverted changeset:
3197
3198         "Add SPI for immediate injection of user scripts"
3199         https://bugs.webkit.org/show_bug.cgi?id=173342
3200         http://trac.webkit.org/changeset/218285
3201
3202 2017-06-14  Chris Dumez  <cdumez@apple.com>
3203
3204         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
3205         https://bugs.webkit.org/show_bug.cgi?id=173384
3206         <rdar://problem/32723779>
3207
3208         Reviewed by Dan Bernstein.
3209
3210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3211         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
3212         Add API test coverage.
3213
3214         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3215         (TestWebKitAPI::Util::sleep):
3216         Update implementation of Util::sleep() so that we actually run the run loop.
3217         Otherwise, we don't process events while sleeping.
3218
3219 2017-06-14  Alex Christensen  <achristensen@webkit.org>
3220
3221         Add SPI for immediate injection of user scripts
3222         https://bugs.webkit.org/show_bug.cgi?id=173342
3223         <rdar://problem/29202285>
3224
3225         Reviewed by Brady Eidson.
3226
3227         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3228         (waitForMessage):
3229         (TEST):
3230
3231 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
3232
3233         Add WPE to the flakiness dashboard
3234         https://bugs.webkit.org/show_bug.cgi?id=173365
3235
3236         Reviewed by Carlos Alberto Lopez Perez.
3237
3238         * TestResultServer/static-dashboards/builders.jsonp:
3239         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3240         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3241         (resetGlobals):
3242         * TestResultServer/static-dashboards/loader_unittests.js:
3243
3244 2017-06-14  Brady Eidson  <beidson@apple.com>
3245
3246         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
3247         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
3248
3249         Reviewed by Alex Christensen.
3250
3251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3252         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
3253         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
3254         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
3255         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
3256         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
3257         (TEST):
3258
3259 2017-06-14  Tim Horton  <timothy_horton@apple.com>
3260
3261         WKContentViewEditingActions API test always fails
3262         https://bugs.webkit.org/show_bug.cgi?id=173374
3263
3264         Reviewed by Wenson Hsieh.
3265
3266         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
3267         (TEST):
3268         selectAll isn't working, because canPerformAction for selectAll returns NO
3269         if selectionIsNone (which is true in the non-contenteditable case).
3270         Instead, make use of r218180's test page, which knows how to select itself.
3271         Also, reset the pasteboard at the beginning of the test to reduce confusion
3272         (I landed the test broken because my simulator had the correct text
3273         stuck in its pasteboard).
3274
3275 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
3276
3277         Configure screen scale for running layout tests on plus devices
3278         https://bugs.webkit.org/show_bug.cgi?id=173319
3279
3280         Reviewed by Tim Horton.
3281
3282         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
3283         * DumpRenderTree/mac/DumpRenderTree.mm:
3284         (dumpRenderTree): Set screen scale to 2.0.
3285         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
3286         add _setScale for UIScreen.
3287         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
3288         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
3289         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
3290         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
3291         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
3292         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
3293         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
3294         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
3295         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
3296         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
3297
3298 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
3299
3300         Add iOS 11 support to the bot watcher's dashboard
3301         https://bugs.webkit.org/show_bug.cgi?id=173369
3302
3303         Reviewed by Lucas Forschler.
3304
3305         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
3306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
3307         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
3308         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
3309         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3310         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3311
3312 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3313
3314         [GTK][WPE] Raise the timeout values for layout tests
3315         https://bugs.webkit.org/show_bug.cgi?id=173368
3316
3317         Reviewed by Carlos Garcia Campos.
3318
3319         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
3320         When running under valgrind a 10x multiplier is applied.
3321
3322         * Scripts/webkitpy/port/gtk.py:
3323         (GtkPort.default_timeout_ms):
3324         * Scripts/webkitpy/port/gtk_unittest.py:
3325         (GtkPortTest.test_default_timeout_ms):
3326         * Scripts/webkitpy/port/wpe.py:
3327         (WPEPort.default_timeout_ms):
3328         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
3329         (WPEPortTest):
3330         (WPEPortTest.make_port):
3331         (WPEPortTest.test_default_timeout_ms):
3332         (WPEPortTest.test_get_crash_log):
3333
3334 2017-06-14  Alex Christensen  <achristensen@webkit.org>
3335
3336         Test persistent WKHTTPCookieStorages on iOS.
3337         https://bugs.webkit.org/show_bug.cgi?id=173284
3338
3339         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3340         (TEST):
3341         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
3342
3343 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
3344
3345         [Win] DRT should not use disk cache.
3346         https://bugs.webkit.org/show_bug.cgi?id=173361
3347
3348         Reviewed by Darin Adler.
3349
3350         Like on macOS/iOS, DRT on Windows should only use memory cache.
3351
3352         * DumpRenderTree/win/DumpRenderTree.cpp:
3353         (setDefaultsToConsistentValuesForTesting):
3354         (prepareConsistentTestingEnvironment):
3355
3356 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
3357
3358         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
3359         https://bugs.webkit.org/show_bug.cgi?id=171668
3360
3361         Reviewed by Jer Noble.
3362
3363         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
3364         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
3365         Infinity when the double value passed as argument is greater than 2^64.
3366
3367         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
3368         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
3369         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
3370         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
3371         method. No behavior change for rational MediaTime.
3372
3373         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
3374         (TestWebKitAPI::TEST):
3375
3376 2017-06-13  Alex Christensen  <achristensen@webkit.org>
3377
3378         Test persistent WKHTTPCookieStorages on iOS
3379         https://bugs.webkit.org/show_bug.cgi?id=173284
3380         <rdar://problem/32260156>
3381
3382         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3383         (TEST):
3384
3385 2017-06-13  Matt Rajca  <mrajca@apple.com>
3386
3387         WebsitePolicies: let clients select specific autoplay quirks
3388         https://bugs.webkit.org/show_bug.cgi?id=173343
3389
3390         Reviewed by Alex Christensen.
3391
3392         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3393         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3394         (TEST): Updated tests.
3395
3396 2017-06-13  Daniel Bates  <dabates@apple.com>
3397
3398         Implement W3C Secure Contexts Draft Specification
3399         https://bugs.webkit.org/show_bug.cgi?id=158121
3400         <rdar://problem/26012994>
3401
3402         Reviewed by Brent Fulgham.
3403
3404         Part 4
3405
3406         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
3407         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
3408         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3409
3410         * DumpRenderTree/TestOptions.h:
3411         * DumpRenderTree/TestOptions.mm:
3412         (TestOptions::TestOptions):
3413         * DumpRenderTree/mac/DumpRenderTree.mm:
3414         (setWebPreferencesForTestOptions):
3415         * DumpRenderTree/win/DumpRenderTree.cpp:
3416         (enableExperimentalFeatures):
3417         * WebKitTestRunner/TestController.cpp:
3418         (WTR::TestController::resetPreferencesToConsistentValues):
3419         (WTR::updateTestOptionsFromTestHeader):
3420         * WebKitTestRunner/TestOptions.h:
3421         (WTR::TestOptions::hasSameInitializationOptions):
3422
3423 2017-06-13  Alex Christensen  <achristensen@webkit.org>
3424
3425         Test persistent WKHTTPCookieStorages on iOS
3426         https://bugs.webkit.org/show_bug.cgi?id=173284
3427         <rdar://problem/32260156>
3428
3429         Reviewed by Alexey Proskuryakov.
3430
3431         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3432         (TEST):
3433
3434 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3435
3436         [GTK] Blob download doesn't work
3437         https://bugs.webkit.org/show_bug.cgi?id=172442
3438
3439         Reviewed by Carlos Alberto Lopez Perez.
3440
3441         Add a unit test to check blob downloads.
3442
3443         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3444         (testBlobDownload):
3445         (beforeAll):
3446
3447 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3448
3449         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
3450         https://bugs.webkit.org/show_bug.cgi?id=173316
3451
3452         Reviewed by Alex Christensen.
3453
3454         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
3455
3456         * gtk/manifest.txt.in:
3457
3458 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3459
3460         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
3461         https://bugs.webkit.org/show_bug.cgi?id=173315
3462
3463         Reviewed by Darin Adler.
3464
3465         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
3466         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
3467         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
3468         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
3469         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
3470         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
3471         WKGeolocationManagerRef is not destroyed.
3472
3473         * WebKitTestRunner/GeolocationProviderMock.cpp:
3474         (WTR::GeolocationProviderMock::GeolocationProviderMock):
3475         * WebKitTestRunner/GeolocationProviderMock.h:
3476
3477 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3478
3479         Unable to paste text that was copied from a page into the universal search field
3480         https://bugs.webkit.org/show_bug.cgi?id=173293
3481         <rdar://problem/32440918>
3482
3483         Reviewed by Ryosuke Niwa.
3484
3485         Adds 2 new unit tests for copying plain and rich selected web content.
3486         See WebCore and WebKit ChangeLogs for more detail.
3487
3488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3489         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
3490         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
3491         (TestWebKitAPI::dataForPasteboardType):
3492         (TestWebKitAPI::setUpWebViewForPasteboardTests):
3493         (TestWebKitAPI::TEST):
3494
3495 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
3496
3497         AX: [ATK] Implement missing AtkRelation types
3498         https://bugs.webkit.org/show_bug.cgi?id=155494
3499
3500         Reviewed by Darin Adler.
3501
3502         Add additional methods to test ARIA properties which are exposed via
3503         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
3504
3505         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3506         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
3507         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
3508         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
3509         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
3510         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
3511         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
3512         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
3513         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3514         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3515         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
3516         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
3517         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
3518         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
3519         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
3520         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
3521         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
3522         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
3523
3524 2017-06-12  Daniel Bates  <dabates@apple.com>
3525
3526         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
3527         https://bugs.webkit.org/show_bug.cgi?id=173286
3528         <rdar://problem/32726102>
3529
3530         Reviewed by Brent Fulgham.
3531
3532         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3533         (TestWebKitAPI::TEST_F):
3534
3535 2017-06-12  Lucas Forschler  <lforschler@apple.com>
3536
3537         <rdar://problem/32683422>
3538         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
3539
3540         Reviewed by Conrad Schultz.
3541
3542         * Scripts/copy-webkitlibraries-to-product-directory:
3543
3544 2017-06-12  Tim Horton  <timothy_horton@apple.com>
3545
3546         [iOS] Cmd-C doesn't copy text from WKWebView
3547         https://bugs.webkit.org/show_bug.cgi?id=173277
3548         <rdar://problem/32396742>
3549
3550         Reviewed by Dan Bernstein.
3551
3552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3553         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
3554         Add a test ensuring that -copy on WKContentView will cause text to be copied.
3555
3556 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
3557
3558         [WebCrypto] Remove experimental feature flag of SubtleCrypto
3559         https://bugs.webkit.org/show_bug.cgi?id=173197
3560         <rdar://problem/32688148>
3561
3562         Reviewed by Brent Fulgham.
3563
3564         * DumpRenderTree/mac/DumpRenderTree.mm:
3565         (enableExperimentalFeatures):
3566         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3567         (WTR::InjectedBundle::beginTesting):
3568         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3569         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
3570         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3571
3572 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3573
3574         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
3575         https://bugs.webkit.org/show_bug.cgi?id=173238
3576         <rdar://problem/31943370>
3577
3578         Reviewed by Ryosuke Niwa and Tim Horton.
3579
3580         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
3581         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
3582         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
3583
3584         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3585         (TestWebKitAPI::TEST):
3586         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3587         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3588         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
3589         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
3590
3591 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3592
3593         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
3594         https://bugs.webkit.org/show_bug.cgi?id=173225
3595         <rdar://problem/32713144>
3596
3597         Reviewed by Tim Horton.
3598
3599         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
3600         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
3601
3602         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3603         (TestWebKitAPI::TEST):
3604
3605 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
3606
3607         Return correct process names for iOS on-device testing
3608         https://bugs.webkit.org/show_bug.cgi?id=173263
3609
3610         Reviewed by Alex Christensen.
3611
3612         When running tests on iOS devices, process names do not end with '.Development'
3613         as they do on Mac and iOS simulator.
3614
3615         * WebKitTestRunner/TestController.cpp:
3616         (WTR::TestController::webProcessName): Return correct process name without '.Development'
3617         for iOS on-device testing.
3618         (WTR::TestController::networkProcessName): Ditto.
3619         (WTR::TestController::databaseProcessName): Ditto.
3620
3621 2017-06-12  Chris Dumez  <cdumez@apple.com>
3622
3623         Regression(r217867): Legacy SessionHistoryEntryData format should not change
3624         https://bugs.webkit.org/show_bug.cgi?id=173267
3625         <rdar://problem/32701257>
3626
3627         Reviewed by Simon Fraser.
3628
3629         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
3630         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
3631         though as this covers the crash that r217867 was fixing.
3632
3633         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
3634         (TestWebKitAPI::createSessionStateData):
3635         (TestWebKitAPI::TEST):
3636         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
3637
3638 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3639
3640         [GTK] Stop dismissing menus attached to the web view for every injected event
3641         https://bugs.webkit.org/show_bug.cgi?id=172708
3642
3643         Reviewed by Alex Christensen.
3644
3645         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
3646         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
3647         events while the menu is open.
3648
3649         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3650         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
3651         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3652         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
3653
3654 2017-06-12  Miguel Gomez  <magomez@igalia.com>
3655
3656         [GTK][WPE] Enable GStreamer GL on development builds
3657         https://bugs.webkit.org/show_bug.cgi?id=173248
3658
3659         Enable GStreamer GL for GTK and WPE.
3660
3661         Reviewed by Carlos Garcia Campos.
3662
3663         * Scripts/webkitperl/FeatureList.pm:
3664
3665 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3666
3667         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
3668
3669         Notifications are no longer cleared on page navigation.
3670
3671         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3672         (testWebViewNotification):
3673
3674 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3675
3676         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
3677
3678         DBus interface and object path names were updated in r217831.
3679
3680         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
3681
3682 2017-06-10  Dan Bernstein  <mitz@apple.com>
3683
3684         Reverted r218056 because it made the IDE reindex constantly.
3685
3686         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3687         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3688         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
3689         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3690         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
3691         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3692         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3693         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3694
3695 2017-06-10  Dan Bernstein  <mitz@apple.com>
3696
3697         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
3698         https://bugs.webkit.org/show_bug.cgi?id=173223
3699
3700         Reviewed by Sam Weinig.
3701
3702         The rebuilds were happening due to a difference in the compiler options that the IDE and
3703         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
3704         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
3705         specify an appropriate path in CLANG_INDEX_STORE_PATH.
3706
3707         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3708         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3709         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
3710         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3711         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
3712         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3713         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3714         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3715
3716 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
3717
3718         webkitpy: Reduce polling in ServerProcess
3719         https://bugs.webkit.org/show_bug.cgi?id=173116
3720
3721         Reviewed by Ryosuke Niwa.
3722
3723         We should be smarter about polling. We do not need to poll every time a line is read from
3724         stdout and stderr since lines are usually read from cached data. We should only poll
3725         when extracting that cached data from stdout and stderr.
3726
3727         * Scripts/webkitpy/port/driver.py:
3728         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
3729         and on ServerProcess to poll the process if not data is available in stdout and stderr.
3730         * Scripts/webkitpy/port/driver_unittest.py:
3731         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
3732         ServerProcess.
3733         * Scripts/webkitpy/port/server_process.py:
3734         (ServerProcess._read): Allow for data to be read from _output even if the process has
3735         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
3736         * Scripts/webkitpy/port/server_process_mock.py:
3737         (MockServerProcess): Add number_of_times_polled.
3738         (MockServerProcess.poll): Increment number_of_times_polled.
3739         (MockServerProcess.has_crashed): Poll before returning crash state.
3740         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
3741         just like a ServerProcess would.
3742         (MockServerProcess.read_stdout): Ditto.
3743         * Scripts/webkitpy/port/server_process_unittest.py:
3744         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
3745         process from ending before stdout and stderr are read. This is the reason this test was flakey.
3746         (TestServerProcess):
3747         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
3748         the processes is polled.
3749         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
3750         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
3751
3752 2017-06-10  Andy Estes  <aestes@apple.com>
3753
3754         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
3755         https://bugs.webkit.org/show_bug.cgi?id=173190
3756         <rdar://problem/31360659>
3757
3758         Reviewed by Brady Eidson.
3759         
3760         Added a release assert that tries to create a proper test failure if the web process crashes.
3761
3762         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
3763         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
3764
3765 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3766
3767         [iOS DnD] Add a hook to perform two-step drops in editable content
3768         https://bugs.webkit.org/show_bug.cgi?id=172992
3769         <rdar://problem/32590174>
3770
3771         Reviewed by Tim Horton.
3772
3773         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
3774         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
3775                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
3776
3777         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
3778         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3779         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
3780
3781         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
3782         be overridden. Currently, this is overridden to just return true.
3783
3784         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3785         (TestWebKitAPI::TEST):
3786         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3787         (WTR::InjectedBundlePage::InjectedBundlePage):
3788
3789 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
3790
3791         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
3792         https://bugs.webkit.org/show_bug.cgi?id=173103
3793
3794         Reviewed by Xabier Rodriguez-Calvar.
3795
3796         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
3797         when building the WPE port through build-webkit.
3798
3799 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
3800
3801         [WPE] Enable MEDIA_SOURCE for build-webkit builds
3802         https://bugs.webkit.org/show_bug.cgi?id=173136
3803
3804         Reviewed by Xabier Rodriguez-Calvar.
3805
3806         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
3807
3808 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3809
3810         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
3811         https://bugs.webkit.org/show_bug.cgi?id=173098
3812
3813         Reviewed by Žan Doberšek.
3814
3815         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
3816         assuming that all tests containing forms define ids for the form elements like
3817         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
3818
3819         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3820         (formControlsAssociatedCallback):
3821
3822 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
3823
3824         webkitpy: Run sample/spindump on iOS devices
3825         https://bugs.webkit.org/show_bug.cgi?id=171881
3826         <rdar://problem/32084602>
3827
3828         Reviewed by Daniel Bates.
3829
3830         * Scripts/webkitpy/port/darwin.py:
3831         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
3832         requires sudo to run spindump.
3833         * Scripts/webkitpy/port/ios_device.py:
3834         (IOSDevicePort.look_for_new_samples): Deleted.
3835         (IOSDevicePort.sample_process): Deleted.
3836         * Scripts/webkitpy/port/ios_device_unittest.py:
3837         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
3838         (IOSDeviceTest.test_spindump):
3839         (IOSDeviceTest.test_sample_process):
3840         (IOSDeviceTest.test_sample_process_exception):
3841         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3842         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
3843
3844 2017-06-08  Keith Miller  <keith_miller@apple.com>
3845
3846         WebAssembly: We should only create wrappers for functions that can be exported
3847         https://bugs.webkit.org/show_bug.cgi?id=173088
3848
3849         Reviewed by Saam Barati.
3850
3851         Add quick mode for wasm tests.
3852
3853         * Scripts/run-jsc-stress-tests:
3854
3855 2017-06-08  Darin Adler  <darin@apple.com>
3856
3857         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
3858         https://bugs.webkit.org/show_bug.cgi?id=173106
3859
3860         Reviewed by Sam Weinig.
3861
3862         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
3863         destroyed last.
3864         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
3865         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
3866
3867 2017-06-07  Dan Bernstein  <mitz@apple.com>
3868
3869         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
3870         https://bugs.webkit.org/show_bug.cgi?id=173086
3871
3872         Reviewed by Andy Estes.
3873
3874         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
3875         (TEST):
3876
3877 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
3878
3879         Add High Sierra support to WebKit tools
3880         https://bugs.webkit.org/show_bug.cgi?id=173080
3881
3882         Rubber-stamped by Daniel Bates.
3883
3884         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
3885         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
3886         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3887         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3888         Added dashboard support.
3889
3890         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3891         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3892         Trigger the right build queues on check-in.
3893
3894         * Scripts/webkitpy/common/system/platforminfo.py:
3895         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3896         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3897         * Scripts/webkitpy/port/mac.py:
3898         * Scripts/webkitpy/port/mac_unittest.py:
3899         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3900         Added cases for Sierra, and updated tests for new baseline search paths.
3901
3902 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
3903
3904         Unreviewed, rolling out r217902.
3905
3906         This change appears to have caused imported/w3c/web-platform-
3907         tests/fetch/api/cors tests to fail on El Capitan.
3908
3909         Reverted changeset:
3910
3911         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
3912         https://bugs.webkit.org/show_bug.cgi?id=172930
3913         http://trac.webkit.org/changeset/217902
3914
3915 2017-06-07  Daniel Bates  <dabates@apple.com>
3916
3917         Teach run-webkit-tests how to run HTTPS Web Platform Tests
3918         https://bugs.webkit.org/show_bug.cgi?id=172930
3919         <rdar://problem/32570201>
3920
3921         Reviewed by Youenn Fablet.
3922
3923         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
3924         that is conditioned on the page being delivered over a secure protocol. One example of such
3925         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
3926
3927         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
3928         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
3929         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
3930
3931         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3932         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
3933         to the Web Platform Tests HTTPS server.
3934         * Scripts/webkitpy/port/base.py:
3935         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
3936         * Scripts/webkitpy/port/driver.py:
3937         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
3938         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
3939         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
3940         indicate that they should be considered private instance variables.
3941         (Driver.is_web_platform_test): Update code for renamed instance variables.
3942         (Driver):
3943         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
3944         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
3945         determine the base URL to use to access the test.
3946         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
3947         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
3948
3949 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
3950
3951         Support removal of authentication data through the Website data store API.
3952         https://bugs.webkit.org/show_bug.cgi?id=171217
3953
3954         Reviewed by Brady Eidson.
3955
3956         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3957         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3958         (WTR::InjectedBundle::didReceiveMessageToPage):
3959         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3960         (WTR::TestRunner::removeAllSessionCredentials):
3961         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
3962         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3963         * WebKitTestRunner/TestController.h:
3964         * WebKitTestRunner/TestInvocation.cpp:
3965         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3966         (WTR::TestInvocation::didRemoveAllSessionCredentials):
3967         * WebKitTestRunner/TestInvocation.h:
3968         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3969         (WTR::TestController::removeAllSessionCredentials):
3970
3971 2017-06-07  Charlie Turner  <cturner@igalia.com>
3972
3973         Add Charlie Turner as contributor
3974         https://bugs.webkit.org/show_bug.cgi?id=173055
3975
3976         Reviewed by Carlos Alberto Lopez Perez.
3977
3978         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
3979         of webkit-patch upload, which reordered some fields and removed a newline.
3980
3981         * Scripts/webkitpy/common/config/contributors.json:
3982
3983 2017-06-06  Chris Dumez  <cdumez@apple.com>
3984
3985         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
3986         https://bugs.webkit.org/show_bug.cgi?id=173033
3987         <rdar://problem/32591099>
3988
3989         Reviewed by Simon Fraser.
3990
3991         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
3992         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
3993
3994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3995         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
3996         (TestWebKitAPI::didFinishLoadForFrame):
3997         (TestWebKitAPI::setPageLoaderClient):
3998         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
3999         (TestWebKitAPI::TEST):
4000
4001 2017-06-06  Andy Estes  <aestes@apple.com>
4002
4003         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
4004         https://bugs.webkit.org/show_bug.cgi?id=172849
4005         <rdar://problem/32567454>
4006
4007         Reviewed by Darin Adler.
4008
4009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4010         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
4011         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
4012         (TestWebKitAPI::TEST):
4013
4014 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
4015
4016         [preload] Conditional support for media preloading and align media `as` values.
4017         https://bugs.webkit.org/show_bug.cgi?id=172501
4018
4019         Reviewed by Dean Jackson.
4020
4021         Turn on media preloading preference for tests.
4022
4023         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
4024         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
4025         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
4026
4027 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
4028
4029         webkitpy: Return correct process names from SimulatorProcess
4030         https://bugs.webkit.org/show_bug.cgi?id=172940
4031
4032         Reviewed by Aakash Jain.
4033
4034         * Scripts/webkitpy/port/darwin.py:
4035         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
4036         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
4037         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
4038         * Scripts/webkitpy/port/driver.py:
4039         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
4040         _server_process.name() will not return the correct process name for iOS.
4041         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
4042         (Driver._read_block): Ditto.
4043         * Scripts/webkitpy/port/driver_unittest.py:
4044         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
4045         process_name() instead of name().
4046         * Scripts/webkitpy/port/server_process.py:
4047         (ServerProcess._start): Use process_name() instead of name().
4048         (ServerProcess.stop): Ditto.
4049         (ServerProcess.name): Deleted.
4050         * Scripts/webkitpy/port/simulator_process.py:
4051         (SimulatorProcess.process_name): Check the provided bundle for the process name.
4052
4053 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
4054
4055         test-webkitpy: stop forking unsafely from within a spawned process
4056         https://bugs.webkit.org/show_bug.cgi?id=172774
4057
4058         Reviewed by Darin Adler.
4059
4060         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4061         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
4062         it's going to be used.
4063         (Builder.force_build):
4064
4065 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
4066
4067         webkitpy: Process crash-logs for iOS devices
4068         https://bugs.webkit.org/show_bug.cgi?id=171976
4069         <rdar://problem/32134551>
4070
4071         Reviewed by David Kilzer.
4072
4073         When running layout tests on an iOS device, crash logs should be processed.
4074         Implement crash log searching and parsing for iOS devices.
4075
4076         * Scripts/webkitpy/common/system/crashlogs.py:
4077         (CrashLogs): Moved process regular expression for Darwin to class variable.
4078         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
4079         (CrashLogs.find_newest_log): Add iOS as a potential platform.
4080         (CrashLogs.find_all_logs): Ditto.
4081         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
4082         Do not assume that a Darwin crash log starts with the process.
4083         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
4084         shared code for parsing Darwin crash logs.
4085         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
4086         object so that crash logs already on the system before testing are not parsed.
4087         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
4088         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
4089         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
4090         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
4091         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
4092         * Scripts/webkitpy/common/system/systemhost.py:
4093         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
4094         systems is just the crashlog, use this behavior by default.
4095         * Scripts/webkitpy/common/system/systemhost_mock.py:
4096         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
4097         systems is just the crashlog, use this behavior by default.
4098         * Scripts/webkitpy/port/apple.py:
4099         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
4100         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
4101         the system before testing begins
4102         * Scripts/webkitpy/port/base.py:
4103         (Port._get_crash_log): Pass optional target host when getting crash logs.
4104         * Scripts/webkitpy/port/darwin.py:
4105         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
4106         CrashLogs object.
4107         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
4108         logs to be skipped to CrashLogs object.
4109         * Scripts/webkitpy/port/darwin_testcase.py:
4110         (DarwinTest.test_get_crash_log): Removed unused local function.
4111         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
4112         * Scripts/webkitpy/port/device.py:
4113         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
4114         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
4115         * Scripts/webkitpy/port/driver.py:
4116         (Driver._get_crash_log): Pass optional target host when getting crash logs.
4117         * Scripts/webkitpy/port/gtk.py:
4118         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
4119         * Scripts/webkitpy/port/ios.py: Ditto.
4120         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
4121         to be skipped for each host.
4122         * Scripts/webkitpy/port/ios_device.py:
4123         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
4124         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
4125         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
4126         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
4127         host is specified. Else, search all connected devices for the specified crash-log.
4128         (IOSDevicePort.look_for_new_crash_logs): Deleted.
4129         * Scripts/webkitpy/port/ios_device_unittest.py:
4130         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
4131         (IOSDeviceTest.test_get_crash_log): Ditto.
4132         * Scripts/webkitpy/port/simulator_process.py:
4133         (SimulatorProcess.process_name): Check the provided bundle for the process name.
4134         * Scripts/webkitpy/port/win.py:
4135         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
4136         logs to be skipped to CrashLogs object.
4137         * Scripts/webkitpy/port/wpe.py:
4138         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
4139
4140 2017-06-06  David Kilzer  <ddkilzer@apple.com>
4141
4142         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
4143         <https://webkit.org/b/172804>
4144
4145         Reviewed by Darin Adler.
4146
4147         WTF_ATTRIBUTE_PRINTF() only works outside the current
4148         compilation unit if it's on the declaration, not the
4149         implementation, of a function or class method.
4150
4151         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
4152         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
4153         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
4154         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
4155         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
4156         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4157         - Remove redundant CRASH() macro definition.  Use the one from
4158           <wtf/Assertions.h> instead.
4159
4160 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
4161
4162         Move Resource Timing / User Timing from experimental features into main preferences
4163         https://bugs.webkit.org/show_bug.cgi?id=172950
4164
4165         Reviewed by Darin Adler.
4166
4167         * DumpRenderTree/mac/DumpRenderTree.mm:
4168         (enableExperimentalFeatures):
4169         (resetWebPreferencesToConsistentValues):
4170         * DumpRenderTree/win/DumpRenderTree.cpp:
4171         (enableExperimentalFeatures):
4172         (resetWebPreferencesToConsistentValues):
4173         * WebKitTestRunner/TestController.cpp:
4174         (WTR::TestController::resetPreferencesToConsistentValues):
4175         Move out no longer experimental features to the main list.
4176
4177 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4178
4179         [WPE] Add an install-dependencies script
4180         https://bugs.webkit.org/show_bug.cgi?id=172948
4181
4182         Reviewed by Žan Doberšek.
4183
4184         It is based on the gtk/install-dependencies script.
4185         Includes support for Debian based distrubutions, Fedora and Arch.
4186         It has been tested on a minimal Debian 9 chroot.
4187
4188         * wpe/install-dependencies: Added.
4189
4190 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
4191
4192         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
4193         https://bugs.webkit.org/show_bug.cgi?id=172891
4194         <rdar://problem/32204540>
4195
4196         Reviewed by Darin Adler.
4197
4198         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
4199         contenteditable. See WebCore ChangeLog for more details.
4200
4201         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4202         (TestWebKitAPI::TEST):
4203
4204 2017-06-05  Daniel Bates  <dabates@apple.com>
4205
4206         webkitpy: Abstract Executive class
4207         https://bugs.webkit.org/show_bug.cgi?id=172928
4208         <rdar://problem/32569531>
4209
4210         Reviewed by Ryosuke Niwa.
4211
4212         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
4213         This will make it straightforward to create additional derived classes that
4214         adhere to the same interface, say for iOS on-device testing.
4215
4216         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
4217         (AbstractExecutive):
4218         (AbstractExecutive.run_and_throw_if_fail):
4219         (AbstractExecutive.cpu_count):
4220         (AbstractExecutive.interpreter_for_script):
4221         (AbstractExecutive.shell_command_for_script):
4222         (AbstractExecutive.kill_process):
4223         (AbstractExecutive.check_running_pid):
4224         (AbstractExecutive.running_pids):
4225         (AbstractExecutive.wait_newest):
4226         (AbstractExecutive.wait_limited):
4227         (AbstractExecutive.interrupt):
4228         (AbstractExecutive.default_error_handler):
4229         (AbstractExecutive.ignore_error):
4230         (AbstractExecutive._stringify_args):
4231         (AbstractExecutive.command_for_printing):
4232         (AbstractExecutive.run_command):
4233         (AbstractExecutive.popen):
4234         (AbstractExecutive.run_in_parallel):
4235         * Scripts/webkitpy/common/system/executive.py:
4236         (Executive):
4237         (Executive.cpu_count):
4238         (Executive.running_pids):
4239         (Executive.kill_all):
4240         (Executive._compute_stdin):
4241         (Executive.interpreter_for_script): Deleted.
4242         (Executive.shell_command_for_script): Deleted.
4243         (Executive.wait_newest): Deleted.
4244         (Executive.wait_limited): Deleted.
4245         (Executive.default_error_handler): Deleted.
4246         (Executive.ignore_error): Deleted.
4247         (Executive.command_for_printing): Deleted.
4248
4249 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
4250
4251         webkitpy: Add iOS to platform
4252         https://bugs.webkit.org/show_bug.cgi?id=172931
4253
4254         Reviewed by Daniel Bates.
4255
4256         * Scripts/webkitpy/common/system/platforminfo.py:
4257         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
4258         (PlatformInfo.is_ios): Added.
4259         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
4260         * Scripts/webkitpy/common/system/platforminfo_mock.py:
4261         (MockPlatformInfo.is_ios): Added.
4262
4263 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4264
4265         [WPE][JHBuild] Switch github repository from git:// to https://
4266         https://bugs.webkit.org/show_bug.cgi?id=172921
4267
4268         Reviewed by Alex Christensen.
4269
4270         * wpe/jhbuild.modules:
4271
4272 2017-06-05  Tim Horton  <timothy_horton@apple.com>
4273
4274         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
4275         https://bugs.webkit.org/show_bug.cgi?id=172887
4276         <rdar://problem/32546061>
4277
4278         Reviewed by Sam Weinig.
4279
4280         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4281         (WTR::UIScriptController::applyAutocorrection):
4282         applyAutocorrection can call its completion handler synchronously,
4283         which makes UIScriptController unhappy (see bug 172884).
4284
4285 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
4286
4287         webkitpy: Add contextmanager to disable logging for a block
4288         https://bugs.webkit.org/show_bug.cgi?id=172876
4289
4290         Reviewed by Daniel Bates.
4291
4292         Add a context manager which will use an OutputCapture object to capture logging
4293         in a block and hold it in a variable.
4294
4295         * Scripts/webkitpy/common/system/outputcapture.py:
4296         (OutputCaptureScope):
4297         (OutputCaptureScope.__init__): Construct with OutputCapture object.
4298         (OutputCaptureScope.__enter__): Begin capturing output. 
4299         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
4300         output and retain the resulting log.
4301         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
4302         (OutputCaptureTest.test_output_capture_scope): Added.
4303
4304 2017-06-02  Zalan Bujtas  <zalan@apple.com>
4305
4306         Cleanup FrameView::autoSizeIfEnabled.
4307         https://bugs.webkit.org/show_bug.cgi?id=172889
4308         <rdar://problem/32550783>
4309
4310         Reviewed by Tim Horton.
4311
4312         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
4313         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
4314         (TEST):
4315
4316 2017-06-02  Chris Dumez  <cdumez@apple.com>
4317
4318         ResourceLoadStatistics are not using unique paths during test runs
4319         https://bugs.webkit.org/show_bug.cgi?id=172861
4320         <rdar://problem/32442251>
4321
4322         Reviewed by Darin Adler.
4323
4324         Make sure WebKitTestRunner sets a temporary path for saving resource
4325         load statistics.
4326
4327         * WebKitTestRunner/TestController.cpp:
4328         (WTR::TestController::generateContextConfiguration):
4329
4330 2017-06-02  Brady Eidson  <beidson@apple.com>
4331
4332         Prevent scheme handlers from handling all built-in URL schemes.
4333         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
4334
4335         Reviewed by Andy Estes.
4336
4337         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
4338
4339 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
4340
4341         [JSCOnly] Build static jsc.exe on Windows
4342         https://bugs.webkit.org/show_bug.cgi?id=172833
4343
4344         Reviewed by Konstantin Tokarev.
4345
4346         * CMakeLists.txt:
4347         * Scripts/build-jsc:
4348
4349 2017-06-02  Zalan Bujtas  <zalan@apple.com>
4350
4351         Disable ViewportSizeForViewportUnits tests on iOS.
4352         https://bugs.webkit.org/show_bug.cgi?id=172872
4353
4354         Reviewed by Tim Horton.
4355
4356         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
4357