2010-12-20 David Levin <levin@chromium.org>
[WebKit.git] / Tools / ChangeLog
1 2010-12-20  David Levin  <levin@chromium.org>
2
3         Reviewed by Ariya Hidayat.
4
5         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
6         https://bugs.webkit.org/show_bug.cgi?id=51343
7
8         Follow up from the WebKitTools -> Tools rename.
9
10         * Scripts/webkit-tools-completion.sh:
11
12 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
13
14         Reviewed by James Robinson.
15
16         new-run-webkit-tests ignores trailing EOL differences in text tests
17         https://bugs.webkit.org/show_bug.cgi?id=36983
18
19         Changed the handling of new-line characters within new-run-webkit-tests
20         to match old-run-webkit-tests.  Differences in leading and trailing empty
21         lines in text expectation files are no longer ignored.
22
23         * Scripts/webkitpy/layout_tests/port/base.py:
24         * Scripts/webkitpy/layout_tests/port/test.py:
25         Added unit tests.  Removed old duplicate unit test entries.
26         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
27
28 2010-12-20  David Levin  <levin@chromium.org>
29
30         Reviewed by Shinichiro Hamaji.
31
32         check-webkit-style should detect function declarations (and trivial functions).
33         https://bugs.webkit.org/show_bug.cgi?id=51303
34
35         * Scripts/webkitpy/style/checkers/cpp.py:
36         (_FunctionState.begin): Add is_declaration and changed the line count
37         start to begin at -1 (which will keep the results consistent, since
38         the starting line number passed in is one less in this change).
39         (detect_functions): changed function detection to now catch trivial
40         functions and declarations.
41         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
42         of the function as this may look at return values (when processing
43         a declaration).
44         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
45         (FunctionDetectionTest.perform_function_detection): Basic mechanics
46         of testing the function detection.
47         (FunctionDetectionTest.test_basic_function_detection): Test a simple
48         function.
49         (FunctionDetectionTest.test_function_declaration_detection): Test a
50         declaration.
51         (FunctionDetectionTest.test_non_functions): A test case for a case
52         that caused the code to fail due to the { being in quotes.
53         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
54         cases to help catch false alarms for return values.
55         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
56         we don't get false alarms for member variables either.
57
58 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
59
60         Reviewed by Antonio Gomes.
61
62         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
63         https://bugs.webkit.org/show_bug.cgi?id=51319
64
65         * CMakeListsEfl.txt:
66
67 2010-12-18  Adam Barth  <abarth@webkit.org>
68
69         Reviewed by Sam Weinig.
70
71         Move WebKitExamplePlugins to Examples
72         https://bugs.webkit.org/show_bug.cgi?id=51291
73
74         * Scripts/webkitpy/common/config/build.py:
75
76 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
77
78         Unreviewed Qt buildfix after r74301.
79
80         Rename WebKitTools to Tools
81         https://bugs.webkit.org/show_bug.cgi?id=49861
82
83         * MiniBrowser/DerivedSources.pro:
84         * MiniBrowser/qt/MiniBrowser.pro:
85
86 2010-12-17  Dan Bernstein  <mitz@apple.com>
87
88         Reviewed by Simon Fraser.
89
90         Rename WebKitTools to Tools
91         https://bugs.webkit.org/show_bug.cgi?id=49861
92
93         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
94         * CodeCoverage/README:
95         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
96         (WebCore::DumpRenderTree::initializeFonts):
97         * EWSTools/start-commit-queue.sh:
98         * EWSTools/start-queue.sh:
99         * GNUmakefile.am:
100         * MIDLWrapper/MIDLWrapper.cpp:
101         (wmain):
102         * MiniBrowser/qt/MiniBrowser.pro:
103         * Scripts/build-api-tests:
104         * Scripts/build-dumprendertree:
105         * Scripts/build-webkit:
106         * Scripts/build-webkittestrunner:
107         * Scripts/generate-coverage-data:
108         * Scripts/old-run-webkit-tests:
109         * Scripts/run-api-tests:
110         * Scripts/run-iexploder-tests:
111         * Scripts/run-javascriptcore-tests:
112         * Scripts/run-mangleme-tests:
113         * Scripts/run-sunspider:
114         * Scripts/run-webkit-websocketserver:
115         * Scripts/sunspider-compare-results:
116         * Scripts/test-webkitperl:
117         * Scripts/test-webkitpy:
118         * Scripts/update-iexploder-cssproperties:
119         * Scripts/update-webkit:
120         * Scripts/update-webkit-localizable-strings:
121         * Scripts/webkitdirs.pm:
122         * Scripts/webkitpy/common/checkout/scm.py:
123         * Scripts/webkitpy/common/checkout/scm_unittest.py:
124         * Scripts/webkitpy/common/config/committervalidator.py:
125         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
126         * Scripts/webkitpy/common/config/ports.py:
127         * Scripts/webkitpy/common/config/ports_unittest.py:
128         * Scripts/webkitpy/common/system/logutils_unittest.py:
129         * Scripts/webkitpy/common/system/ospath_unittest.py:
130         * Scripts/webkitpy/layout_tests/port/chromium.py:
131         * Scripts/webkitpy/layout_tests/port/config.py:
132         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
133         * Scripts/webkitpy/layout_tests/port/http_server.py:
134         * Scripts/webkitpy/layout_tests/port/test.py:
135         * Scripts/webkitpy/style/checker.py:
136         * Scripts/webkitpy/style/checker_unittest.py:
137         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
138         * Scripts/webkitpy/tool/commands/queues_unittest.py:
139         * Scripts/webkitpy/tool/steps/steps_unittest.py:
140         * WebKitTestRunner/DerivedSources.pro:
141         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
142         (WTR::activateFonts):
143         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
144         * wx/build/build_utils.py:
145
146 2010-12-16  Antonio Gomes  <agomes@rim.com>
147
148         Reviewed by Martin Robinson.
149
150         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
151         https://bugs.webkit.org/show_bug.cgi?id=51163
152
153         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
154         GTK+'s DRT should also reset to UNIX after each test execution.
155
156         * DumpRenderTree/gtk/DumpRenderTree.cpp:
157         (resetDefaultsToConsistentValues):
158
159 2010-12-17  David Levin  <levin@chromium.org>
160
161         Reviewed by Eric Seidel.
162
163         check-webkit-style should understand WTF #include guards
164         https://bugs.webkit.org/show_bug.cgi?id=44911
165
166         * Scripts/webkitpy/style/checkers/cpp.py:
167         (get_header_guard_cpp_variable): modify to suggest the WTF style
168         of header guard when appropriate.
169         (check_for_header_guard): handle multiple return values from
170         get_header_guard_cpp_variable
171         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
172         (CppStyleTest.test_build_header_guard): Added tests for the WTF
173         header style.
174
175 2010-12-16  David Levin  <levin@chromium.org>
176
177         Reviewed by Eric Seidel.
178
179         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
180         https://bugs.webkit.org/show_bug.cgi?id=51210
181
182         The error only shows up when using python 2.6 or later.
183
184         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
185         the decprecated field error,message with something equivalent.
186
187 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
188
189         Reviewed by Eric Seidel.
190
191         Add --exit-after-n-failures/crashes to NRWT
192         https://bugs.webkit.org/show_bug.cgi?id=51160
193         
194         Abort test run (in a similar way to how control-C is handled) when
195         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
196         that number of unexpected failures/crashes/timeouts.
197
198         * Scripts/webkitpy/layout_tests/port/test.py:
199         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
200         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
201
202 2010-12-16  David Levin  <levin@chromium.org>
203
204         Reviewed by Shinichiro Hamaji.
205
206         check-webkit-style unit tests has some duplicate boilerplate code.
207         https://bugs.webkit.org/show_bug.cgi?id=49519
208
209         * Scripts/webkitpy/style/checkers/cpp.py:
210         (update_include_state): Replaced the "io" parameter with the global
211         configuration _unit_test_config. This allowed not calling into
212         functions at a low level and also not plumbing through the injection
213         information through many levels of code.
214         (check_for_include_what_you_use): Ditto.
215         (process_file_data): Added the ability to set up the unit test config
216         to allow for injection.
217         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
218         (ErrorCollector.__init__): Added support for having a filter for errors.
219         (ErrorCollector.__call__): Ditto.
220         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
221         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
222         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
223         functions in the cpp.py with generic processing and a filter that
224         indicates what errors should be kept.
225         (CppStyleTestBase.perform_multi_line_lint): Ditto.
226         (CppStyleTestBase.perform_language_rules_check): Ditto.
227         (CppStyleTestBase.perform_function_lengths_check): Ditto.
228         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
229         (CppStyleTestBase.perform_include_what_you_use): Ditto.
230         (CppStyleTest.test_multi_line_comments): Added another
231         error message which applies to the test case.
232         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
233         to not have config.h, since it is processed as a header file.
234         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
235         style and indentation in checked code.
236         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
237         Fixed line number.
238         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
239         Ditto.
240
241 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
242
243         Unreviewed, rolling out r74136.
244         http://trac.webkit.org/changeset/74136
245         https://bugs.webkit.org/show_bug.cgi?id=51135
246
247         r74136 breaks chromium canary bots because some tests are not
248         rebaselined correctly to resolve EOL differences (Requested by
249         jianli on #webkit).
250
251         * Scripts/webkitpy/layout_tests/port/base.py:
252         * Scripts/webkitpy/layout_tests/port/test.py:
253         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
254
255 2010-12-15  Adam Roben  <aroben@apple.com>
256
257         Teach check-webkit-style to check .vcproj and .vsprops files for XML
258         syntax errors
259
260         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
261         XML syntax errors in .vcproj/.vsprops files
262
263         Reviewed by Dave Levin.
264
265         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
266         that should be treated as XML and that should be allowed to contain
267         carriage returns. (These lists happen to be identical currently.)
268         (FileType): Added a new XML type.
269         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
270         Just does a simple file extension check.
271         (CheckerDispatcher._file_type): Added a case for XML files.
272         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
273         files (surprise!).
274         (StyleProcessor.process): Ask the dispatcher whether we should pass the
275         lines through the carriage checker.
276
277         * Scripts/webkitpy/style/checker_unittest.py:
278         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
279         Added. Checks a few file names to see if carriage returns are allowed
280         or not.
281         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
282         other assert_checker_* functions.
283         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
284         test_*_paths functions.
285         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
286         test_*_paths functions.
287         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
288         file from this test case, as vcproj files now have a type.
289         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
290         Added. Similar to the other should_* functions.
291         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
292         Added. Checks that carriage returns aren't checked for or stripped for
293         allowed files.
294
295         * Scripts/webkitpy/style/checkers/xml.py: Added.
296         (XMLChecker.__init__): Simple init method.
297         (XMLChecker.check): Pass each line through the expat parser, and record
298         a style error for any errors thrown by the parser.
299
300         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
301         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
302         produce a style error.
303         (XMLCheckerTest.assert_error): Checks that the given XML produces an
304         error of the given category on the given line.
305         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
306         checking that the XMLChecker constructor works properly.
307         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
308         cause a style error (see, e.g., r73887).
309         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
310         cause a style error (see, e.g., r73773).
311         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
312         properly.
313         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
314         tags cause a style error (see, e.g., r72795).
315         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
316         style error.
317
318 2010-12-15  Lucas Forschler  <lforschler@apple.com>
319
320         Reviewed by Stephanie Lewis.
321
322         https://bugs.webkit.org/show_bug.cgi?id=51117
323         Add a new leopard test bot
324         really really commit to trunk this time.
325
326         * BuildSlaveSupport/build.webkit.org-config/config.json:
327
328 2010-12-15  Sam Weinig  <sam@webkit.org>
329
330         Reviewed by Anders Carlsson.
331
332         WebKit2: Can't add files to an <input type=file>
333         https://bugs.webkit.org/show_bug.cgi?id=51087
334
335         * MiniBrowser/mac/BrowserWindowController.m:
336         (runOpenPanel):
337         (-[BrowserWindowController awakeFromNib]):
338         Add simple implementation of runOpenPanel callback.
339
340         * MiniBrowser/win/BrowserView.cpp:
341         (BrowserView::create):
342         * WebKitTestRunner/TestController.cpp:
343         (WTR::createOtherPage):
344         (WTR::TestController::initialize):
345         Stub out runOpenPanel callback. 
346
347 2010-12-14  Eric Seidel  <eric@webkit.org>
348
349         Reviewed by Adam Barth.
350
351         commit-queue should upload failure diffs when tests flake
352         https://bugs.webkit.org/show_bug.cgi?id=51051
353
354         To make this testable I needed to pipe FileSystem down onto tool.
355         We've wanted it there for a long time anyway.
356
357         This patch is kinda a big hack.  But we don't have a nice
358         way to read results.html files.  I think this will need further
359         revision before this code actually feels clean.
360
361         As part of testing this change, I had to make MockBugzilla.create_bug
362         actually return an id (like it should) which required updating
363         a few other unit test results (for the better).
364
365         The results_matching_keys change in layouttestresults/rebasline
366         was an alternate path which I decided not to use in the end, but
367         I left the change as it seemed an improvement.
368
369         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
370         * Scripts/webkitpy/common/net/layouttestresults.py:
371         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
372         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
373         * Scripts/webkitpy/tool/commands/queues.py:
374         * Scripts/webkitpy/tool/commands/rebaseline.py:
375         * Scripts/webkitpy/tool/main.py:
376         * Scripts/webkitpy/tool/mocktool.py:
377
378 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
379
380         Reviewed by James Robinson.
381
382         new-run-webkit-tests ignores trailing EOL differences in text tests
383         https://bugs.webkit.org/show_bug.cgi?id=36983
384
385         Changed the handling of new-line characters within new-run-webkit-tests
386         to match old-run-webkit-tests.  Differences in leading and trailing empty
387         lines in text expectation files are no longer ignored.
388
389         * Scripts/webkitpy/layout_tests/port/base.py:
390         * Scripts/webkitpy/layout_tests/port/test.py:
391         Added unit tests.  Removed old duplicate unit test entries.
392         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
393
394 2010-12-15  Ojan Vafai  <ojan@chromium.org>
395
396         Reviewed by Adam Barth.
397
398         make status-bubble white-space:nowrap so we can measure it's width without wrapping
399         https://bugs.webkit.org/show_bug.cgi?id=51149
400
401         * QueueStatusServer/templates/statusbubble.html:
402
403 2010-12-15  Ojan Vafai  <ojan@chromium.org>
404
405         Reviewed by Adam Barth.
406
407         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
408         https://bugs.webkit.org/show_bug.cgi?id=51125
409
410         * QueueStatusServer/templates/statusbubble.html:
411
412 2010-12-15  Darin Adler  <darin@apple.com>
413
414         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
415
416 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
417
418         Unreviewed, rolling out r74117.
419         http://trac.webkit.org/changeset/74117
420         https://bugs.webkit.org/show_bug.cgi?id=51113
421
422         This broke the GTK1 build. (Requested by mrobinson on
423         #webkit).
424
425         * Scripts/webkitdirs.pm:
426
427 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
428
429         Reviewed by Martin Robinson.
430
431         Change generate-forwarding-headers.pl for GTK port usage 
432         (https://bugs.webkit.org/show_bug.cgi?id=37369)
433
434         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
435
436 2010-12-14  Kent Tamura  <tkent@chromium.org>
437
438         Reviewed by Jian Li.
439
440         [DRT/Chromium] Remove another unnecessary error message
441         https://bugs.webkit.org/show_bug.cgi?id=51083
442
443         * DumpRenderTree/chromium/WebViewHost.cpp:
444         (WebViewHost::didInvalidateRect):
445
446 2010-12-14  Lucas Forschler  <lforschler@apple.com>
447
448         Reviewed by Stephanie Lewis.
449
450         Add a new Leopard Debug Test WK2 Bot
451
452         * BuildSlaveSupport/build.webkit.org-config/config.json:
453
454 2010-12-14  Ojan Vafai  <ojan@chromium.org>
455
456         Fix python unittests after http://trac.webkit.org/changeset/74070.
457
458         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
459
460 2010-12-14  Kent Tamura  <tkent@chromium.org>
461
462         Reviewed by Jian Li.
463
464         [DRT/Chromium] Remove a unnecessary error message
465         https://bugs.webkit.org/show_bug.cgi?id=51069
466
467         * DumpRenderTree/chromium/WebViewHost.cpp:
468         (WebViewHost::paintInvalidatedRegion):
469
470 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
471
472         Reviewed by Ojan Vafai.
473
474         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
475         https://bugs.webkit.org/show_bug.cgi?id=48926
476
477         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
478         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
479
480 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
481
482         Reviewed by Eric Seidel.
483
484         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
485         https://bugs.webkit.org/show_bug.cgi?id=50231
486
487         Guard CONFIG+=link_pkgconfig with !symbian.
488
489         * DumpRenderTree/qt/DumpRenderTree.pro:
490         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
491         * WebKitTestRunner/qt/WebKitTestRunner.pro:
492
493 2010-12-14  Philippe Normand  <pnormand@igalia.com>
494
495         Reviewed by Ojan Vafai.
496
497         [new-run-webkit-tests] expectations parsing is slow
498         https://bugs.webkit.org/show_bug.cgi?id=50635
499
500         Avoid expensive iteration of all the tests when checking if a test
501         file is to be skipped or not.
502
503         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
504         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
505         * Scripts/webkitpy/layout_tests/port/test.py:
506
507 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
508
509         Reviewed by Xan Lopez.
510
511         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
512         https://bugs.webkit.org/show_bug.cgi?id=27048
513
514         Add support in DRT for checking whether an accessibility UI
515         element is focusable and/or focused. Implemented for GTK.
516
517         * DumpRenderTree/AccessibilityUIElement.cpp:
518         (getIsFocusedCallback): New.
519         (getIsFocusableCallback): New.
520         (AccessibilityUIElement::getJSClass): Add the new available
521         callbacks for isFocused and isFocusable.
522         * DumpRenderTree/AccessibilityUIElement.h:
523         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
524         (AccessibilityUIElement::isFocused): New, implemented by checking
525         whether the related AtkState value is in the object's state set.
526         (AccessibilityUIElement::isFocusable): Ditto.
527         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
528         (AccessibilityUIElement::isFocused): New, dummy implementation.
529         (AccessibilityUIElement::isFocusable): Ditto.
530         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
531         (AccessibilityUIElement::isFocused): Ditto.
532         (AccessibilityUIElement::isFocusable): Ditto.
533
534 2010-12-14  Eric Seidel  <eric@webkit.org>
535
536         Reviewed by Ojan Vafai.
537
538         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
539         https://bugs.webkit.org/show_bug.cgi?id=50715
540
541         This patch makes webkit-patch print the following:
542
543         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
544         Install a 64-bit git for better performance, see:
545         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
546
547         I wrote this mostly because I have approximately 8 machines that I use
548         and making sure each one is using a good Git install seemed folly.
549         webkit-patch makes a lot of git calls, so using a fast git can shave
550         several seconds in every invocation.  See the webkit-dev thread for more info.
551
552         This message will print twice during 'webkit-patch upload',
553         once from webkit-patch and once from check-webkit-style.
554
555         Unfortunately there is no good way to test this due to how machine-dependent
556         the code is.  I considered writing a test for the log message, but it seemed not worth it.
557
558         * Scripts/webkitpy/common/checkout/scm.py:
559
560 2010-12-13  Eric Seidel  <eric@webkit.org>
561
562         Reviewed by Adam Barth.
563
564         FlakyTestReporter doesn't understand bots running from multiple email addresses
565         https://bugs.webkit.org/show_bug.cgi?id=50960
566
567         This explains at least one of the dupes of:
568         https://bugs.webkit.org/show_bug.cgi?id=50863
569         that we saw filed by the commit-queue this morning.
570         I think the other one was explained by my previous fix to result counting code.
571
572         Since this is really hard to test with a unit test, instead I
573         create a new (possibly useful in the future) command
574         which given a layout test path will return you
575         the one bug which our tools would assume it the flaky test bug.
576         If some other script wants to use bug-for-test we'll
577         need to extend it with some options like --create-if-missing or similar.
578
579         * Scripts/webkitpy/common/net/bugzilla/bug.py:
580         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
581         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
582         * Scripts/webkitpy/tool/commands/__init__.py:
583         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
584
585 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
586
587         Reviewed by James Robinson.
588
589         Add option to build-webkit to not build WebKit2
590         https://bugs.webkit.org/show_bug.cgi?id=50988
591         
592         Add support for a --no-webkit2 option to build-webkit. It seems to save
593         ~1 minute from clean builds and ~10 seconds from no-op builds.
594
595         * Scripts/build-webkit:
596
597 2010-12-13  Lucas Forschler  <lforschler@apple.com>
598
599         Reviewed by Dave Kilzer.
600
601         Update iexploder from 1.3.2 to 1.7.2
602         Move 1.3.2 into its own subdir
603         Add 1.7.2 into its own subdir
604         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
605
606         * Scripts/run-iexploder-tests:
607         * Scripts/update-iexploder-cssproperties:
608         * iExploder/CHANGELOG.txt: Removed.
609         * iExploder/LICENSE.txt: Removed.
610         * iExploder/README.txt: Removed.
611         * iExploder/htdocs: Removed.
612         * iExploder/iexploder-1.3.2: Added.
613         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
614         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
615         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
616         * iExploder/iexploder-1.3.2/htdocs: Added.
617         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
618         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
619         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
620         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
621         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
622         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
623         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
624         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
625         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
626         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
627         * iExploder/iexploder-1.3.2/tools: Added.
628         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
629         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
630         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
631         * iExploder/iexploder-1.7.2: Added.
632         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
633         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
634         * iExploder/iexploder-1.7.2/README.txt: Added.
635         * iExploder/iexploder-1.7.2/output: Added.
636         * iExploder/iexploder-1.7.2/src: Added.
637         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
638         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
639         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
640         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
641         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
642         * iExploder/iexploder-1.7.2/src/css-properties: Added.
643         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
644         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
645         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
646         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
647         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
648         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
649         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
650         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
651         * iExploder/iexploder-1.7.2/src/css-values: Added.
652         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
653         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
654         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
655         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
656         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
657         * iExploder/iexploder-1.7.2/src/headers: Added.
658         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
659         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
660         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
661         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
662         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
663         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
664         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
665         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
666         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
667         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
668         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
669         * iExploder/iexploder-1.7.2/src/html-tags: Added.
670         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
671         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
672         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
673         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
674         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
675         * iExploder/iexploder-1.7.2/src/html-values: Added.
676         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
677         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
678         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
679         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
680         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
681         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
682         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
683         * iExploder/iexploder-1.7.2/src/index.html: Added.
684         * iExploder/iexploder-1.7.2/src/media: Added.
685         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
686         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
687         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
688         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
689         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
690         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
691         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
692         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
693         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
694         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
695         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
696         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
697         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
698         * iExploder/iexploder-1.7.2/src/mime-types: Added.
699         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
700         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
701         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
702         * iExploder/iexploder-1.7.2/src/protocols: Added.
703         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
704         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
705         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
706         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
707         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
708         * iExploder/iexploder-1.7.2/src/version.rb: Added.
709         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
710         * iExploder/iexploder-1.7.2/testcases: Added.
711         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
712         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
713         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
714         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
715         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
716         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
717         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
718         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
719         * iExploder/iexploder-1.7.2/tools: Added.
720         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
721         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
722         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
723         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
724         * iExploder/tools: Removed.
725
726 2010-12-13  Sam Weinig  <sam@webkit.org>
727
728         Reviewed by Anders Carlsson.
729
730         Remove associated page concept from WKView constructor
731         https://bugs.webkit.org/show_bug.cgi?id=50983
732
733         Step 1: Remove associate page constructors from WKView and make
734         all views use the shared namespace for the context.
735
736         * TestWebKitAPI/PlatformWebView.h:
737         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
738         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
739         * WebKitTestRunner/PlatformWebView.h:
740         * WebKitTestRunner/TestController.cpp:
741         (WTR::createOtherPage):
742         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
743         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
744         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
745
746 2010-12-13  Sam Weinig  <sam@webkit.org>
747
748         Reviewed by Anders Carlsson.
749
750         Change the WebKit2 public API so there is no explicit WKPageNamespace object
751         https://bugs.webkit.org/show_bug.cgi?id=50898
752
753         * MiniBrowser/mac/AppDelegate.h:
754         * MiniBrowser/mac/AppDelegate.m:
755         * MiniBrowser/mac/BrowserWindowController.h:
756         * MiniBrowser/mac/BrowserWindowController.m:
757         * MiniBrowser/win/BrowserView.cpp:
758         Convert MiniBrowser to not use PageNamespaces.
759
760         * TestWebKitAPI/PlatformWebView.h:
761         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
762         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
763         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
764         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
765         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
766         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
767         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
768         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
769         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
770         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
771         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
772         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
773         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
774         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
775         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
776         Convert TestWebKitAPI to not use PageNamespaces.
777
778         * WebKitTestRunner/PlatformWebView.h:
779         * WebKitTestRunner/TestController.cpp:
780         * WebKitTestRunner/TestController.h:
781         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
782         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
783         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
784         Convert WebKitTestRunner to not use PageNamespaces.
785
786 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
787
788         Reviewed by Eric Seidel.
789
790         webkit-patch rollout should be able to do multi-revision rollouts
791         https://bugs.webkit.org/show_bug.cgi?id=33336
792
793         Make it possible to pass more than one revision to webkit-patch.
794
795         * Scripts/webkitpy/common/checkout/api.py:
796         * Scripts/webkitpy/common/checkout/changelog.py:
797         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
798         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
799         * Scripts/webkitpy/tool/commands/download.py:
800         * Scripts/webkitpy/tool/commands/download_unittest.py:
801         * Scripts/webkitpy/tool/mocktool.py:
802         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
803         * Scripts/webkitpy/tool/steps/revertrevision.py:
804
805 2010-12-13  Eric Seidel  <eric@webkit.org>
806
807         Unreviewed.
808
809         Teach webkit-patch how to search bugzilla
810         https://bugs.webkit.org/show_bug.cgi?id=50500
811
812         webkit-patch bug-search fails when there is only one result.
813         Turns out we needed a bit more logic in our result count parsing code.
814
815         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
816         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
817
818 2010-12-13  Antti Koivisto  <antti@apple.com>
819
820         Reviewed by Alexey Proskuryakov.
821
822         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
823         https://bugs.webkit.org/show_bug.cgi?id=50758
824
825         * DumpRenderTree/LayoutTestController.cpp:
826         (setSerializeHTTPLoadsCallback):
827         (LayoutTestController::staticFunctions):
828         * DumpRenderTree/LayoutTestController.h:
829         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
830         (LayoutTestController::setSerializeHTTPLoads):
831         * DumpRenderTree/mac/DumpRenderTree.mm:
832         (resetDefaultsToConsistentValues):
833         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
834         (LayoutTestController::setSerializeHTTPLoads):
835         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
836         (LayoutTestController::setSerializeHTTPLoads):
837
838 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
839
840         Reviewed by Ojan Vafai.
841
842         Remove "use-drt" option from test step command line, since the option was removed in r73748.
843         https://bugs.webkit.org/show_bug.cgi?id=50936
844
845         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
846
847 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
848
849         Reviewed by Csaba Osztrogonác.
850
851         Add revlink to BuildBot status
852         https://bugs.webkit.org/show_bug.cgi?id=50914
853
854         This adds a hyperlink to trac changeset on the revision numbers. 
855
856         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
857
858 2010-12-13  Andras Becsi  <abecsi@webkit.org>
859
860         Reviewed by Csaba Osztrogonác.
861
862         [Qt][WK2] Fix build if WebKitTools are not available
863         https://bugs.webkit.org/show_bug.cgi?id=50242
864
865         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
866         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
867         * MiniBrowser/DerivedSources.pro: Added.
868
869 2010-12-13  Eric Seidel  <eric@webkit.org>
870
871         Reviewed by Adam Barth.
872
873         EWS Queues should remove orpahned pyc files before starting
874         https://bugs.webkit.org/show_bug.cgi?id=50904
875
876         A previous check added a platform.py which caused
877         EWS bots on some platforms to hit an import exception.
878         The platform.py file was removed in a subsequent commit, but
879         the EWS bots in question stayed stuck.  This change will
880         fix those bots once restarted (and prevent this in the future).
881
882         I also went ahead and unified start-queue and start-commit-queue
883         since they were nearly identical.  I also added bot_id support
884         to both force all EWSes to have bot ids as well as get rid of the one
885         remaining reason why I had my own copies of these scripts.
886         Hopefully this will be enough to get all the other bot admins
887         (ahem, Adam, ahem) to move to using these checked in copies as well.
888
889         * EWSTools/start-commit-queue.sh: Removed.
890         * EWSTools/start-queue.sh:
891
892 2010-10-28  MORITA Hajime  <morrita@google.com>
893
894         Reviewed by Ojan Vafai.
895
896         spellcheck does not check pasted text
897         https://bugs.webkit.org/show_bug.cgi?id=40092
898
899         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
900         to control the setting.
901
902         * DumpRenderTree/LayoutTestController.cpp:
903         (setAsynchronousSpellCheckingEnabledCallback):
904         (LayoutTestController::staticFunctions):
905         * DumpRenderTree/LayoutTestController.h:
906         * DumpRenderTree/chromium/LayoutTestController.h:
907         * DumpRenderTree/chromium/LayoutTestController.cpp:
908         (LayoutTestController::LayoutTestController):
909         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
910         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
911         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
912         * DumpRenderTree/mac/DumpRenderTree.mm:
913         (resetDefaultsToConsistentValues):
914         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
915         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
916         * DumpRenderTree/qt/LayoutTestControllerQt.h:
917         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
918         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
919         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
920         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
921         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
922         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
923
924 2010-12-12  Sam Weinig  <sam@webkit.org>
925
926         Reviewed by Anders Carlsson.
927
928         Fix failing API test. It turns out that a pop-state event
929         is sent before every fragment navigation, so we have to test
930         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
931
932         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
933         (TestWebKitAPI::didSameDocumentNavigationForFrame):
934
935 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
936
937         Reviewed by Eric Seidel.
938
939         [GTK] Add new-run-webkit-tests support to gtk
940         https://bugs.webkit.org/show_bug.cgi?id=50681
941
942         Adding the basic support to run the new-run-webkit-tests.
943
944         * Scripts/webkitpy/layout_tests/port/gtk.py:
945
946 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
947
948         Reviewed by Kenneth Rohde Christiansen.
949
950         [Qt] Mock DeviceOrientation client for DRT
951         https://bugs.webkit.org/show_bug.cgi?id=47490
952
953         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
954         (WebCore::DumpRenderTree::DumpRenderTree):
955         (WebCore::DumpRenderTree::~DumpRenderTree):
956         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
957         (LayoutTestController::setMockDeviceOrientation):
958
959 2010-12-11  Philippe Normand  <pnormand@igalia.com>
960
961         Reviewed by Gustavo Noronha Silva.
962
963         [GTK] launcher: disable the Mozilla-style fullscreen API
964         https://bugs.webkit.org/show_bug.cgi?id=50874
965
966         Disabling the fullscreen API until its implementation for GTK is
967         mature enough. The webview setting for it is already FALSE by
968         default.
969
970         * GtkLauncher/main.c:
971         (createWindow):
972
973 2010-12-10  Eric Seidel  <eric@webkit.org>
974
975         Reviewed by Adam Barth.
976
977         commit-queue flaky test messages show cryptic version information for mac os x
978         https://bugs.webkit.org/show_bug.cgi?id=50864
979
980         Turns out platform.platform() returns kernel version information
981         which isn't helpful, and just plain confusing on Mac
982         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
983
984         So I've updated PlatformInfo.display_name() to special case
985         mac.  I also found a bad use of sys.platform in the process
986         and fixed that.  (sys.platform always returns 'darwin' on mac).
987
988         * Scripts/webkitpy/common/system/platforminfo.py:
989         * Scripts/webkitpy/common/system/user.py:
990         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
991         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
992         * Scripts/webkitpy/tool/commands/queues_unittest.py:
993
994 2010-12-10  Eric Seidel  <eric@webkit.org>
995
996         Unreviewed.
997
998         Exception seen while reporting flaky test with commit-queue.
999         Just a missing include.
1000
1001         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1002         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1003
1004 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
1005
1006         Reviewed by Eric Seidel.
1007
1008         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
1009         https://bugs.webkit.org/show_bug.cgi?id=50796
1010
1011         Also updating the test code to use JSONResultsGeneratorBase and
1012         to improve test coverage for incremental cases.
1013
1014         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1015         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1016
1017 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
1018
1019         Reviewed by Darin Adler.
1020
1021         prepare-ChangeLog --help doesn't mention --bug shorthand -b
1022         https://bugs.webkit.org/show_bug.cgi?id=50835
1023
1024         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
1025
1026 2010-12-10  Eric Seidel  <eric@webkit.org>
1027
1028         Reviewed by Adam Barth.
1029
1030         Bugs created by the commit-queue should all block on a master bug
1031         https://bugs.webkit.org/show_bug.cgi?id=50857
1032
1033         This makes all bugs created by the commit-queue block on:
1034         https://bugs.webkit.org/show_bug.cgi?id=50856
1035
1036         In the process of testing this, I found that the existing
1037         create_bug code was wrong.  I also found that existing
1038         unit tests for create-rollout used invalid values
1039         for options.blocks.  I fixed both issues and tested.
1040
1041         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1042         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1043         * Scripts/webkitpy/tool/commands/commandtest.py:
1044         * Scripts/webkitpy/tool/commands/download_unittest.py:
1045         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1046         * Scripts/webkitpy/tool/mocktool.py:
1047         * Scripts/webkitpy/tool/steps/options.py:
1048
1049 2010-12-10  Eric Seidel  <eric@webkit.org>
1050
1051         Reviewed by Adam Barth.
1052
1053         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
1054         https://bugs.webkit.org/show_bug.cgi?id=50853
1055
1056         I also discovered when doing this that the code was posting
1057         the comment on the wrong bug, but that's fixed here too.
1058
1059         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1060         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1061         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1062         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1063         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1064         * Scripts/webkitpy/tool/mocktool.py:
1065
1066 2010-12-10  Anders Carlsson  <andersca@apple.com>
1067
1068         Reviewed by John Sullivan.
1069
1070         Make WKContextGetStatistics gather global statistics
1071         https://bugs.webkit.org/show_bug.cgi?id=50850
1072
1073         Remove the code that gets the statistics and fills in the per context
1074         statistics information for now.
1075
1076         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1077         (-[BrowserStatisticsWindowController refreshStatistics:]):
1078
1079 2010-12-10  Eric Seidel  <eric@webkit.org>
1080
1081         Unreviewed.
1082
1083         commit-queue should report port/platform information when commenting on flaky test bugs
1084         https://bugs.webkit.org/show_bug.cgi?id=50839
1085
1086         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
1087         which was only used by new run webkit tests (and clearly not unit tested).
1088
1089         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
1090         * Scripts/webkitpy/tool/main.py:
1091         * Scripts/webkitpy/tool/mocktool.py:
1092
1093 2010-12-10  Eric Seidel  <eric@webkit.org>
1094
1095         Reviewed by Tony Chang.
1096
1097         commit-queue should report port/platform information when commenting on flaky test bugs
1098         https://bugs.webkit.org/show_bug.cgi?id=50839
1099
1100         This was a suggestion from Tony Chang this morning.
1101         I added a platform.py class so I could easily mock the platform call,
1102         but that may not be the final solution for this mocking.
1103         We'll try it and see.
1104
1105         * Scripts/webkitpy/common/system/platform.py: Added.
1106         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1107         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1108         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1109         * Scripts/webkitpy/tool/main.py:
1110         * Scripts/webkitpy/tool/mocktool.py:
1111
1112 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
1113
1114         Reviewed by Joseph Pecoraro.
1115
1116         Bug 43455 - [Qt]: Implement Application Cache Quotas
1117         https://bugs.webkit.org/show_bug.cgi?id=43455
1118
1119         Introduce functions to allow new appcache layout test origin-quota.html
1120         to work correctly under Qt.
1121
1122         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1123         (WebCore::DumpRenderTree::DumpRenderTree):
1124         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
1125         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1126
1127         Introduce functions to allow new appcache layout test origin-quota.html
1128         to be successful under qt. Changes required because LayoutTestControllerQt
1129         does not inherit from LayoutController.
1130
1131         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1132         (LayoutTestController::reset):
1133         (LayoutTestController::clearAllApplicationCaches):
1134         (LayoutTestController::setApplicationCacheOriginQuota):
1135         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1136         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
1137         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1138
1139 2010-12-10  Eric Seidel  <eric@webkit.org>
1140
1141         Reviewed by Adam Barth.
1142
1143         Move buildbot.py into its own module so we can split it out into one-file-per-class
1144         https://bugs.webkit.org/show_bug.cgi?id=50806
1145
1146         We're adding more buildbot logic these days, so it makes sense
1147         to give buildbot its own module.
1148
1149         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1150         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1151         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1152         * Scripts/webkitpy/common/net/failuremap.py:
1153         * Scripts/webkitpy/common/net/regressionwindow.py:
1154         * Scripts/webkitpy/tool/commands/rebaseline.py:
1155
1156 2010-12-10  Tony Chang  <tony@chromium.org>
1157
1158         Reviewed by Eric Seidel.
1159
1160         Use FileSystem::remove when cleaning up http lock files
1161         https://bugs.webkit.org/show_bug.cgi?id=50830
1162
1163         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1164
1165 2010-12-10  Joone Hur  <joone@kldp.org>
1166
1167         Reviewed by Martin Robinson.
1168
1169         [GTK] DRT needs layoutTestController.setCacheModel
1170         https://bugs.webkit.org/show_bug.cgi?id=50705
1171         
1172         webkit_set_cache_mode() is called to set the cache model.
1173         
1174         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1175         (LayoutTestController::setCacheModel): Set the cache model. 
1176
1177 2010-12-10  Tony Chang  <tony@chromium.org>
1178
1179         Reviewed by Ojan Vafai.
1180
1181         [chromium] remove --use-drt and add --use-test-shell
1182         https://bugs.webkit.org/show_bug.cgi?id=50701
1183
1184         * Scripts/webkitpy/common/config/ports.py:
1185         * Scripts/webkitpy/common/config/ports_unittest.py:
1186         * Scripts/webkitpy/layout_tests/port/chromium.py:
1187         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1188         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1189         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1190         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1191         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1192         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1193         * Scripts/webkitpy/layout_tests/port/webkit.py:
1194         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1195         * Scripts/webkitpy/style/checkers/test_expectations.py:
1196         * Scripts/webkitpy/tool/commands/queries.py:
1197
1198 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1199
1200         Reviewed by Steve Block.
1201
1202         [Chromium] Implement mocks for client-based geolocation
1203         https://bugs.webkit.org/show_bug.cgi?id=46895
1204
1205         * DumpRenderTree/chromium/LayoutTestController.cpp:
1206         (LayoutTestController::setGeolocationPermission):
1207         (LayoutTestController::setMockGeolocationPosition):
1208         (LayoutTestController::setMockGeolocationError):
1209         * DumpRenderTree/chromium/LayoutTestController.h:
1210         * DumpRenderTree/chromium/WebViewHost.cpp:
1211         (WebViewHost::geolocationClient):
1212         (WebViewHost::geolocationClientMock):
1213         (WebViewHost::reset):
1214         * DumpRenderTree/chromium/WebViewHost.h:
1215
1216 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1217
1218         Reviewed by Martin Robinson.
1219
1220         [GTK] Add hasSpellingMarker support to the DRT
1221         https://bugs.webkit.org/show_bug.cgi?id=50739
1222
1223         Implemented the hasSpellingMarker to support spelling tests.
1224
1225         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1226         (LayoutTestController::hasSpellingMarker):
1227
1228 2010-12-10  Eric Seidel  <eric@webkit.org>
1229
1230         Reviewed by Ojan Vafai.
1231
1232         webkit-patch: not possible to use build-and-test with local commits
1233         https://bugs.webkit.org/show_bug.cgi?id=33378
1234
1235         Make --no-clean not even check if we have local commits.
1236         It's unclear to me why the code was originally written this way.
1237         I was unable to dig up a reason from svn history.
1238
1239         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1240         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1241
1242 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1243
1244         Reviewed by Martin Robinson.
1245
1246         [GTK] AX: implement isEnabled in DRT
1247         https://bugs.webkit.org/show_bug.cgi?id=50814
1248
1249         Implement AccessibilityUIElement::isEnabled() for GTK.
1250
1251         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1252         (checkElementState): New function to refactor common code.
1253         (AccessibilityUIElement::isEnabled): Implement this by checking
1254         the current state of the AtkObject.
1255         (AccessibilityUIElement::isSelected): Use the new
1256         checkElementState function.
1257
1258 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1259
1260         Reviewed by Kenneth Rohde Christiansen.
1261
1262         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
1263         https://bugs.webkit.org/show_bug.cgi?id=50750
1264
1265         * MiniBrowser/qt/BrowserView.cpp:
1266         (BrowserView::BrowserView):
1267         * MiniBrowser/qt/BrowserView.h:
1268         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1269         (WTR::WebView::WebView):
1270
1271 2010-12-10  Joone Hur  <joone@kldp.org>
1272
1273         Reviewed by Xan Lopez.
1274
1275         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
1276         https://bugs.webkit.org/show_bug.cgi?id=50808
1277
1278         Unskipping the following test cases:
1279         userscripts/mixed-case-stylesheet.html
1280         userscripts/simple-stylesheet.html
1281         userscripts/user-style-all-frames.html
1282
1283         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1284         (LayoutTestController::addUserStyleSheet):
1285
1286 2010-12-10  Joone Hur  <joone@kldp.org>
1287
1288         Reviewed by Eric Seidel.
1289
1290         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
1291         https://bugs.webkit.org/show_bug.cgi?id=50783
1292
1293         This patch allows to unskip the following test cases:
1294         printing/page-rule-selection.html
1295         printing/page-format-data.html
1296
1297         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1298         (LayoutTestController::pageProperty): Added.
1299         (LayoutTestController::isPageBoxVisible): Ditto.
1300         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
1301         (LayoutTestController::addUserStyleSheet): Ditto.
1302
1303 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1304
1305         Reviewed by Kenneth Rohde Christiansen.
1306
1307         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
1308
1309         A menu allows to switch QNAM back to the same thread.
1310
1311         * QtTestBrowser/launcherwindow.cpp:
1312         (LauncherWindow::initializeView):
1313         (LauncherWindow::createChrome):
1314         (LauncherWindow::toggleThreadedQnam):
1315         * QtTestBrowser/launcherwindow.h:
1316         (WindowOptions::WindowOptions):
1317         * QtTestBrowser/webpage.cpp:
1318         (WebPage::WebPage):
1319         (WebPage::setQnamThreaded):
1320         * QtTestBrowser/webpage.h:
1321         (QnamThread::QnamThread):
1322         (QnamThread::~QnamThread):
1323         (QnamThread::networkAccessManager):
1324         (QnamThread::run):
1325
1326 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1327
1328         Reviewed by Xan Lopez.
1329
1330         [Gtk] style="font-family: courier" makes text disappear
1331         https://bugs.webkit.org/show_bug.cgi?id=47452
1332
1333         Add a test that verifies that fonts without valid charmaps are
1334         never selected.
1335
1336         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1337         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1338         that has no valid charmap.
1339         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1340         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1341         settings which may disable selection of bitmap fonts.
1342
1343 2010-12-10  Eric Seidel  <eric@webkit.org>
1344
1345         Unreviewed.
1346
1347         The commit-queue should file bugs about flaky tests it encounters
1348         https://bugs.webkit.org/show_bug.cgi?id=50803
1349
1350         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1351         Now it's tested.
1352
1353         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1354         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1355
1356 2010-12-10  Eric Seidel  <eric@webkit.org>
1357
1358         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1359
1360         The commit-queue should file bugs about flaky tests it encounters
1361         https://bugs.webkit.org/show_bug.cgi?id=50803
1362
1363         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1364
1365 2010-12-09  Eric Seidel  <eric@webkit.org>
1366
1367         Reviewed by Adam Barth.
1368
1369         The commit-queue should file bugs about flaky tests it encounters
1370         https://bugs.webkit.org/show_bug.cgi?id=50803
1371
1372         This change got a bit big.  I also added a new config.urls file
1373         because I needed to share the view_source_url code with committervalidator.py.
1374
1375         This adds a new class FlakyTestReporter which holds all the logic about
1376         reporting flaky tests to bugzilla.
1377
1378         Right now this code knows how to look up bugs for flaky tests.
1379         If it can't find a bug filed from the commit-queue, it will open a new
1380         one, ccing the relevant people and adding information about the failure.
1381
1382         It is not yet smart enough to chase down duplicate chains, or to include
1383         the actual failure diff.  But those can be added in later iterations.
1384
1385         * Scripts/webkitpy/common/checkout/api.py:
1386         * Scripts/webkitpy/common/checkout/changelog.py:
1387         * Scripts/webkitpy/common/checkout/commitinfo.py:
1388         * Scripts/webkitpy/common/config/committervalidator.py:
1389         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1390         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1391         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1392         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1393         * Scripts/webkitpy/tool/bot/irc_command.py:
1394         * Scripts/webkitpy/tool/bot/sheriff.py:
1395         * Scripts/webkitpy/tool/commands/download.py:
1396         * Scripts/webkitpy/tool/commands/queues.py:
1397         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1398         * Scripts/webkitpy/tool/comments.py:
1399         * Scripts/webkitpy/tool/mocktool.py:
1400         * Scripts/webkitpy/tool/steps/commit.py:
1401
1402 2010-12-09  Eric Seidel  <eric@webkit.org>
1403
1404         Reviewed by Adam Barth.
1405
1406         Teach webkit-patch how to search bugzilla
1407         https://bugs.webkit.org/show_bug.cgi?id=50500
1408
1409         This is a step towards teaching webkitpy how to file
1410         new bugs for flaky tests and update them when new flakes occur.
1411
1412         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1413         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1414         * Scripts/webkitpy/tool/commands/__init__.py:
1415         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1416
1417 2010-12-09  Adam Barth  <abarth@webkit.org>
1418
1419         Reviewed by Ojan Vafai.
1420
1421         commit-queue errors out due to local commits
1422         https://bugs.webkit.org/show_bug.cgi?id=50766
1423
1424         We seem to be tripping over having local commits in the working copy a
1425         lot recently.  I don't quite fully understand what the issue is, but
1426         this patch attempts to solve the problem by adding an explicit clean
1427         step before processing a patch.  Previously, we did the cleaning as
1428         part of the apply-attachment step, so this might not actually fix the
1429         problem.
1430
1431         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1432         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1433         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1434
1435 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1436
1437         Reviewed by Ojan Vafai.
1438
1439         Make new-run-webkit-tests --lint-test-files log slightly better
1440         messages and return -1 if lint fails. Remove the
1441         'suppress_errors' keyword param to the TestExpectationsFile
1442         class, and clean up logging and exception raising for error
1443         handling. Also add more unit tests and clean up the unit test code a bit.
1444
1445         https://bugs.webkit.org/show_bug.cgi?id=50205
1446
1447         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1448         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1449         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1450         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1451         * Scripts/webkitpy/layout_tests/port/chromium.py:
1452         * Scripts/webkitpy/style/checkers/test_expectations.py:
1453         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1454
1455 2010-12-09  Tony Chang  <tony@chromium.org>
1456
1457         Unreviewed, fix for windows code.  We were catching the wrong
1458         exception in Windows.
1459
1460         * Scripts/webkitpy/common/system/filesystem.py:
1461
1462 2010-12-09  Antonio Gomes  <agomes@rim.com>
1463
1464         Reviewed by Martin Robinson.
1465
1466         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1467         https://bugs.webkit.org/show_bug.cgi?id=48429
1468
1469         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1470
1471         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1472         (LayoutTestController::workerThreadCount):
1473
1474 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1475
1476         Reviewed by Martin Robinson.
1477
1478         [GTK] Support the Mozilla-style Fullscreen Javascript API
1479         https://bugs.webkit.org/show_bug.cgi?id=50572
1480
1481         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1482         make DRT update the Chrome when the WebView settings have been
1483         reset to consistent values.
1484
1485         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1486         (resetDefaultsToConsistentValues):
1487         * GtkLauncher/main.c:
1488         (create_window):
1489         * Scripts/build-webkit:
1490
1491 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1492
1493         Reviewed by Tor Arne Vestbø
1494
1495         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1496         https://bugs.webkit.org/show_bug.cgi?id=50742
1497
1498         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1499
1500         * Scripts/webkitdirs.pm:
1501
1502 2010-12-09  Joone Hur  <joone@kldp.org>
1503
1504          Reviewed by Martin Robinson.
1505
1506          [GTK] Support for viewport meta tag
1507          https://bugs.webkit.org/show_bug.cgi?id=45443
1508
1509          Add support for testing the viewport properties for WebKitGtk.
1510
1511          * DumpRenderTree/LayoutTestController.cpp:
1512          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1513          (LayoutTestController::staticFunctions):
1514          * DumpRenderTree/LayoutTestController.h:
1515          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1516          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1517          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1518          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1519          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1520          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1521          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1522          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1523          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1524          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1525
1526 2010-12-08  William Siegrist <wsiegrist@apple.com>
1527
1528         Reviewed by Eric Seidel.
1529
1530         Migrate buildbot.py from xmlrpc to json.
1531         https://bugs.webkit.org/show_bug.cgi?id=50647
1532
1533         * Scripts/webkitpy/common/net/buildbot.py:
1534
1535 2010-12-08  Tony Chang  <tony@chromium.org>
1536
1537         Reviewed by Eric Seidel.
1538
1539         make starting the websocket server more reliable on windows
1540         https://bugs.webkit.org/show_bug.cgi?id=50712
1541
1542         * Scripts/webkitpy/common/system/filesystem.py:
1543         (remove): Substitute method for os.remove to retry on error on Windows
1544         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1545         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1546
1547 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1548
1549         Reviewed by Adam Roben.
1550
1551         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1552         https://bugs.webkit.org/show_bug.cgi?id=50656
1553
1554         * MiniBrowser/mac/BrowserWindowController.m:
1555         (-[BrowserWindowController awakeFromNib]):
1556         Indicate that exceededDatabaseQuota is not implemented.
1557         * MiniBrowser/win/BrowserView.cpp:
1558         (BrowserView::create):
1559         Ditto.
1560         * WebKitTestRunner/TestController.cpp:
1561         (WTR::createOtherPage):
1562         Ditto.
1563         (WTR::TestController::initialize):
1564         Ditto.
1565
1566 2010-12-08  Antonio Gomes  <agomes@rim.com>
1567
1568         Reviewed by Martin Robinson.
1569
1570         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1571         https://bugs.webkit.org/show_bug.cgi?id=48429
1572
1573         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1574         * webkit_gc_collect_javascript_objects;
1575         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1576         * webkit_gc_count_javascript_objects;
1577         * webkit_web_frame_layout.
1578
1579         These were all only used by GTK+ DRT.
1580
1581         * DumpRenderTree/gtk/EventSender.cpp:
1582         (dispatchEvent):
1583         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1584         (GCController::collect):
1585         (GCController::collectOnAlternateThread):
1586         (GCController::getJSObjectCount):
1587
1588 2010-12-07  Tony Chang  <tony@chromium.org>
1589
1590         Reviewed by Ojan Vafai.
1591
1592         [chromium] force NRWT to use DRT
1593         https://bugs.webkit.org/show_bug.cgi?id=50359
1594
1595         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1596
1597 2010-12-06  Sam Weinig  <sam@webkit.org>
1598
1599         Reviewed by Anders Carlsson.
1600
1601         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1602         https://bugs.webkit.org/show_bug.cgi?id=50584
1603
1604         * MiniBrowser/mac/BrowserWindowController.m:
1605         (didSameDocumentNavigationForFrame):
1606         (-[BrowserWindowController awakeFromNib]):
1607         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1608         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1609         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1610         (TestWebKitAPI::TEST):
1611         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1612         (WTR::InjectedBundlePage::InjectedBundlePage):
1613         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1614         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1615         * WebKitTestRunner/TestController.cpp:
1616         (WTR::TestController::initialize):
1617
1618 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1619
1620         Reviewed by Ojan Vafai.
1621
1622         Make TestResultsServer return 404 for non-existing results files.
1623         https://bugs.webkit.org/show_bug.cgi?id=50581
1624
1625         * TestResultServer/handlers/testfilehandler.py:
1626
1627 2010-12-06  Tony Chang  <tony@chromium.org>
1628
1629         Reviewed by Ojan Vafai.
1630
1631         [chromium] fix an assert hit in DRT
1632         https://bugs.webkit.org/show_bug.cgi?id=50575
1633
1634         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1635         semantics.
1636
1637         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
1638         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
1639         WTF::RefCountedBase::ref()).
1640
1641         * DumpRenderTree/chromium/TestWebWorker.h:
1642         (TestWebWorker::TestWebWorker):
1643
1644 2010-12-02  Ojan Vafai  <ojan@chromium.org>
1645
1646         Reviewed by Eric Seidel.
1647
1648         make webkit-patch command work when the git branch is not synced to the remote svn branch
1649         https://bugs.webkit.org/show_bug.cgi?id=50424
1650
1651         * Scripts/webkitpy/common/checkout/scm.py:
1652         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1653
1654 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
1655
1656         Reviewed by Andreas Kling.
1657
1658         [WINCE] Add build system
1659         https://bugs.webkit.org/show_bug.cgi?id=50522
1660
1661         * CMakeListsWinCE.txt: Added.
1662
1663 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1664
1665         Reviewed by Tony Chang.
1666
1667         Allow the Chromium port to have Leopard-specific baselines
1668         https://bugs.webkit.org/show_bug.cgi?id=50506
1669
1670         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1671
1672 2010-12-03  Tony Chang  <tony@chromium.org>
1673
1674         Reviewed by Kent Tamura.
1675
1676         [chromium] fix 2 bugs with inspector tests in DRT
1677         https://bugs.webkit.org/show_bug.cgi?id=50492
1678
1679         Tasks can outlive the tasklist (even when canceled) so this was
1680         causing a crash when ~WebTask() ran.  Avoid this by unregistering
1681         when a task is canceled.
1682
1683         Also fix an assert when closing devtool windows by copying some
1684         logic from test_shell.
1685
1686         * DumpRenderTree/chromium/Task.cpp:
1687         (WebTask::~WebTask):
1688         (TaskList::revokeAll):
1689         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
1690             the tasklist (since the task can outlive the tasklist).
1691         * DumpRenderTree/chromium/TestShell.h:
1692         (TestShell::devToolsWebView):
1693         * DumpRenderTree/chromium/WebViewHost.cpp:
1694         (WebViewHost::~WebViewHost): Don't load about:blank when closing
1695             a window if the window has devtools loaded.  This avoids an
1696             ASSERT and matches test_shell.
1697
1698 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
1699
1700         Reviewed by Martin Robinson.
1701
1702         [GTK] Fix GtkLauncher.c style, use webkit style
1703         https://bugs.webkit.org/show_bug.cgi?id=50542
1704
1705         * GtkLauncher/main.c:
1706         (activateUriEntryCb):
1707         (updateTitle):
1708         (linkHoverCb):
1709         (notifyTitleCb):
1710         (notifyLoadStatusCb):
1711         (notifyProgressCb):
1712         (destroyCb):
1713         (goBackCb):
1714         (goForwardCb):
1715         (create_webViewCb):
1716         (webViewReadyCb):
1717         (closeWebViewCb):
1718         (createBrowser):
1719         (createStatusbar):
1720         (createToolbar):
1721         (createWindow):
1722         (main):
1723
1724 2010-12-04  Antonio Gomes  <agomes@rim.com>
1725
1726         Reviewed by Martin Robinson.
1727
1728         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
1729         https://bugs.webkit.org/show_bug.cgi?id=48429
1730
1731         Moved more private method declared with WEBKIT_API to
1732         DumpRenderTreeSupportGtk, since they were only being used by DRT.
1733
1734         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1735         (resetDefaultsToConsistentValues):
1736         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1737         (LayoutTestController::addOriginAccessWhitelistEntry):
1738         (LayoutTestController::execCommand):
1739         (LayoutTestController::isCommandEnabled):
1740
1741 2010-12-04  Antonio Gomes  <agomes@rim.com>
1742
1743         Reviewed by Andreas Kling.
1744
1745         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
1746
1747         Method was removed by http://trac.webkit.org/changeset/71604
1748
1749         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1750
1751 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
1752
1753         Reviewed by Xan Lopez.
1754
1755         [GTK] Fix compilation warnings reported by clang
1756         https://bugs.webkit.org/show_bug.cgi?id=50252
1757
1758         * GtkLauncher/main.c:
1759         (create_window): The create_statusbar function does not have
1760         parameters.
1761
1762 2010-12-05  Robert Hogan  <robert@webkit.org>
1763
1764         Reviewed by Andreas Kling.
1765
1766         [Qt] Zero-sized font does not yet work
1767
1768         Fix fast/text/font-size-zero.html
1769
1770         Copy other ports by setting minimumFontSize to 0 for DRT runs.
1771
1772         https://bugs.webkit.org/show_bug.cgi?id=49759
1773
1774         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1775         (WebCore::WebPage::WebPage):
1776
1777 2010-12-04  Sam Weinig  <sam@webkit.org>
1778
1779         Reviewed by Jon Honeycutt.
1780
1781         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
1782         https://bugs.webkit.org/show_bug.cgi?id=50511
1783
1784         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
1785         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
1786
1787         * MiniBrowser/mac/BrowserWindowController.m:
1788         (didChangeLocationWithinPageForFrame):
1789         (-[BrowserWindowController awakeFromNib]):
1790         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
1791         * TestWebKitAPI/PlatformUtilities.cpp:
1792         (TestWebKitAPI::Util::toWK):
1793         * TestWebKitAPI/PlatformUtilities.h:
1794         (TestWebKitAPI::Util::adoptWK):
1795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1796         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
1797         (TestWebKitAPI::nullJavaScriptCallback):
1798         (TestWebKitAPI::didFinishLoadForFrame):
1799         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
1800         (TestWebKitAPI::TEST):
1801         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
1802         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1803         * TestWebKitAPI/win/copy-resources.cmd:
1804         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1805         (WTR::InjectedBundlePage::InjectedBundlePage):
1806         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
1807         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1808         * WebKitTestRunner/TestController.cpp:
1809         (WTR::TestController::initialize):
1810
1811 2010-11-08  Antonio Gomes  <agomes@rim.com>
1812
1813         Reviewed by Martin Robinson.
1814
1815         [Gtk] Populate DumpRenderTreeSupportGtk
1816         https://bugs.webkit.org/show_bug.cgi?id=48429
1817
1818         Made the previous calls to webkit_web_frame* functions defined as private
1819         APIs in webkitprivate.h go through DRTSupportGtk.
1820
1821         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1822         (AccessibilityController::focusedElement):
1823         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1824         (dumpFramesAsText):
1825         (resetDefaultsToConsistentValues):
1826         (dump):
1827         (webViewDocumentLoadFinished):
1828         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1829         (LayoutTestController::counterValueForElementById):
1830         (LayoutTestController::pageNumberForElementById):
1831         (LayoutTestController::numberOfPages):
1832         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1833         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1834         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1835         (LayoutTestController::numberOfActiveAnimations):
1836         (LayoutTestController::suspendAnimations):
1837         (LayoutTestController::resumeAnimations):
1838         (LayoutTestController::markerTextForListItem):
1839
1840 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1841
1842         Reviewed by Tony Chang.
1843
1844         Rebaseline server: use pretty text diff output
1845         https://bugs.webkit.org/show_bug.cgi?id=50484
1846         
1847         Serve *-pretty-diff.html for text diff output.
1848
1849         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1850         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1851         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1852         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1853
1854 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1855
1856         Unreviewed, rolling out r73302.
1857         http://trac.webkit.org/changeset/73302
1858         https://bugs.webkit.org/show_bug.cgi?id=50499
1859
1860         Causes crashes in debug LayoutTests (Requested by xan_ on
1861         #webkit).
1862
1863         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1864         (AccessibilityUIElement::AccessibilityUIElement):
1865         (AccessibilityUIElement::parentElementCallback):
1866         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1867         * DumpRenderTree/chromium/CppBoundClass.cpp:
1868         * DumpRenderTree/chromium/CppBoundClass.h:
1869
1870 2010-12-03  Sam Weinig  <sam@webkit.org>
1871
1872         Reviewed by Maciej Stachowiak.
1873
1874         Enable <a ping> for Mac/Windows/WebKit2 builds
1875         <rdar://problem/8504473>
1876         https://bugs.webkit.org/show_bug.cgi?id=50488
1877
1878         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1879         (TestWebKitAPI::TEST): Test that the default value of
1880         WKPreferencesGetHyperlinkAuditingEnabled is true.
1881
1882 2010-12-03  Chris Guillory  <chris.guillory@google.com>
1883
1884         Reviewed by Chris Fleizach.
1885
1886         Include the FrameView widget of a RenderWidget in the accessibility tree.
1887         https://bugs.webkit.org/show_bug.cgi?id=49106
1888
1889         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1890         (AccessibilityUIElement::AccessibilityUIElement):
1891         (AccessibilityUIElement::parentElementCallback):
1892         (AccessibilityUIElement::isEqualCallback):
1893         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1894         * DumpRenderTree/chromium/CppBoundClass.cpp:
1895         (CppBoundClass::getFromCppVariant):
1896         * DumpRenderTree/chromium/CppBoundClass.h:
1897
1898 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1899
1900         Reviewed by Tony Chang.
1901
1902         Rebaseline server: organize tests by state, add dry run mode
1903         https://bugs.webkit.org/show_bug.cgi?id=50473
1904         
1905         Group tests in the menu by state, so that it's easier to see after
1906         processing the queue which failed.
1907         
1908         Add support for the --dry-run flag so that it's easier to test changes
1909         such as this (stubs out filesystem and SCM operations).
1910
1911         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1912         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1913         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1914
1915 2010-12-03  Brady Eidson  <beidson@apple.com>
1916
1917         Reviewed by Anders Carlsson.
1918
1919         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
1920         WebKit2 Authentication Support
1921
1922         Keep these builds working:
1923         * MiniBrowser/mac/BrowserWindowController.m:
1924         (-[BrowserWindowController awakeFromNib]):
1925
1926         * WebKitTestRunner/TestController.cpp:
1927         (WTR::TestController::initialize):
1928
1929 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
1930
1931         Reviewed by Tony Chang.
1932
1933         Rebaseline server: move existing baselines
1934         https://bugs.webkit.org/show_bug.cgi?id=50421
1935         
1936         Implement moving of existing baselines: move all files that are about
1937         to be overwriten by update baselines.
1938         
1939         Also fix a typo in the UI JS.
1940
1941         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1942         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1943         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
1944
1945 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1946
1947         Unreviewed, rolling out r73211.
1948         http://trac.webkit.org/changeset/73211
1949         https://bugs.webkit.org/show_bug.cgi?id=50450
1950
1951         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
1952         yutak on #webkit).
1953
1954         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1955
1956 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1957
1958         Unreviewed, rolling out r73222.
1959         http://trac.webkit.org/changeset/73222
1960         https://bugs.webkit.org/show_bug.cgi?id=50449
1961
1962         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
1963         (Requested by yutak on #webkit).
1964
1965         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1966         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1967         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1968         * Scripts/webkitpy/layout_tests/port/base.py:
1969         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1970         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1971
1972 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1973
1974         Unreviewed, rolling out r73228.
1975         http://trac.webkit.org/changeset/73228
1976         https://bugs.webkit.org/show_bug.cgi?id=50448
1977
1978         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
1979         (Requested by yutak on #webkit).
1980
1981         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1982         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1983         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1984         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
1985         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1986
1987 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1988
1989         Unreviewed, rolling out r73231.
1990         http://trac.webkit.org/changeset/73231
1991         https://bugs.webkit.org/show_bug.cgi?id=50443
1992
1993         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
1994         (Requested by yutak on #webkit).
1995
1996         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1997         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1998         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1999         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2000
2001 2010-12-03  David Levin  <levin@chromium.org>
2002
2003         Reviewed by Shinichiro Hamaji.
2004
2005         check-webkit-style: false positive reported for #if macro
2006         https://bugs.webkit.org/show_bug.cgi?id=48242
2007
2008         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
2009           all preprocessor commands.
2010         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
2011
2012 2010-12-02  Eric Seidel  <eric@webkit.org>
2013
2014         Reviewed by Adam Barth.
2015
2016         Update the EWSTools scripts to use modern-style git repos
2017         https://bugs.webkit.org/show_bug.cgi?id=50402
2018
2019         * EWSTools/create-webkit-git:
2020         * EWSTools/start-commit-queue.sh:
2021         * EWSTools/start-queue.sh:
2022
2023 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2024
2025         Fix Chromium Linux plugin tests by not logging
2026         unconditionally from the event handling code.
2027
2028         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2029         (handleEventX11):
2030
2031 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2032
2033         Reviewed by Tony Chang.
2034
2035         nrwt multiprocessing - move logic back into run_webkit_tests
2036
2037         This change moves a bunch of logic that I had put into
2038         message_broker back into run_webkit_tests, in a slightly
2039         different format. WorkerMessageBroker needed to become less aware of
2040         the logic the TestRunner class uses, and more generic.
2041         Eventually the MessageBroker will only do generic messaging and
2042         thread/process-pooling, and (almost) all of the
2043         run-webkit-tests-specific logic will be moved to
2044         run_webkit_tests.py and dump_render_tree_thread.py.
2045         
2046         The biggest changes are that the Broker can now start a single
2047         worker, but the responsibility for starting all of them is pushed
2048         back to the TestRunner (Manager), and the logic for checking if
2049         the threads are done or wedged is moved back to TestRunner. We
2050         also remove WorkerMessageBroker.cleanup (not needed) and
2051         cancel_workers (they have to be cancelled individually).
2052         
2053         The  message_broker is now encapsulated inside
2054         TestRunner._run_tests(); it only needs to exist while actually
2055         running the tests.
2056
2057         Also, delete a bunch of tests in message_broker_unittest that no
2058         longer make much sense.
2059
2060         This patch depends on bug 50372.
2061
2062         https://bugs.webkit.org/show_bug.cgi?id=50374
2063
2064         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2065         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2066         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2067         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2068         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2069
2070 2010-12-02  Hayato Ito  <hayato@chromium.org>
2071
2072         Reviewed by Eric Seidel.
2073
2074         Refactor test_types's compare_output() method so that it takes a
2075         TestInput object.
2076
2077         compare_output() will need additional information included in a TestInput
2078         object to support reftests. This change is a pre-requirement of that.
2079
2080         https://bugs.webkit.org/show_bug.cgi?id=50362
2081
2082         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2083         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2084         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2085         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2086         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2087
2088 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2089
2090         Reviewed by Anders Carlsson.
2091
2092         Add the ability to run script on 'new' and 'paint' in the test plugin
2093         https://bugs.webkit.org/show_bug.cgi?id=50425
2094         
2095         Add "onnew" and "onpaintevent" attributes to the test plugin,
2096         so that tests can run JS at these times.
2097
2098         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2099         (pluginAllocate):
2100         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2101         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2102         (NPP_New):
2103         (NPP_Destroy):
2104         (handleEventCarbon):
2105         (handleEventCocoa):
2106         (NPP_HandleEvent):
2107
2108 2010-12-02  Sam Weinig  <sam@webkit.org>
2109
2110         Fix Qt build.
2111
2112         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2113         (WTR::PlatformWebView::PlatformWebView):
2114
2115 2010-12-02  Sam Weinig  <sam@webkit.org>
2116
2117         Reviewed by Anders Carlsson.
2118
2119         WebKit2 Preferences should be held off the PageGroup, not the Context
2120         https://bugs.webkit.org/show_bug.cgi?id=50414
2121
2122         Update for API changes.
2123
2124         * WebKitTestRunner/PlatformWebView.h:
2125         * WebKitTestRunner/TestController.cpp:
2126         (WTR::createOtherPage):
2127         (WTR::TestController::initialize):
2128         (WTR::TestController::resetStateToConsistentValues):
2129         * WebKitTestRunner/TestController.h:
2130         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2131         (WTR::PlatformWebView::PlatformWebView):
2132         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2133         (WTR::PlatformWebView::PlatformWebView):
2134
2135 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2136
2137         Reviewed by Tony Chang.
2138
2139         new-run-webkit-tests: minor cleanup for multiprocessing work
2140
2141         This change:
2142         * moves worker naming into TestShellThread, eliminating a
2143           parameter to the constructor and putting the responsibility in
2144           the correct place.
2145         * eliminates the _WorkerState() class in message_broker, because
2146           it turns out that state really needs to be in run_webkit_tests
2147         * renames the Broker classes to be module-private.
2148         * fixes a bunch of minor commenting and whitespace issues to
2149           make subsequent patches a bit clearer.
2150         * Adds a Port hook for default_worker_model() so that we can
2151           accomodate the potential for different worker models on
2152           different ports.
2153         * merge in the fix from 50420 for the brokenness introduced in
2154           bug 50367.
2155
2156         This patch depends on bug 50367.
2157
2158         https://bugs.webkit.org/show_bug.cgi?id=50372
2159
2160         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2161         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2162         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2163         * Scripts/webkitpy/layout_tests/port/base.py:
2164         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2165         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2166
2167 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2168
2169         Reviewed by Tony Chang.
2170
2171         This change is a bunch of cleanup / refactoring of the file
2172         below. It moves a bunch of free functions to methods on the
2173         TestShellThread class, and restructures other methods to be
2174         closer to the structure we'll need for the multiprocessing
2175         rewrite.
2176
2177         It also makes the logic of --run-singly a *lot* easier to follow
2178         by nestling all of the separate-thread logic into a single
2179         routine.
2180
2181         There should be no semantic changes in this patch, just cleanup.
2182
2183         https://bugs.webkit.org/show_bug.cgi?id=50367
2184
2185         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2186
2187 2010-12-02  Tony Chang  <tony@chromium.org>
2188
2189         Unreviewed, rolling out r73164.
2190         http://trac.webkit.org/changeset/73164
2191         https://bugs.webkit.org/show_bug.cgi?id=50359
2192
2193         broke debugger tests on win
2194
2195         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2196
2197 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2198
2199         Reviewed by Tony Chang.
2200
2201         Rebaseline server: add updating of baselines
2202         https://bugs.webkit.org/show_bug.cgi?id=50305
2203         
2204         Implements updating of baselines, where we copy -actual.* files over
2205         the current -expected.* files. To do this, we need a
2206         _get_actual_result_files method to get test results files and a
2207         _rebaseline_test method to actually do the file copy and SCM operation.
2208         _rebaseline_test logs output into a buffer, this is useful for both
2209         showing result in the UI and for unit tests.
2210         
2211         To make passing around of the various test environment properties
2212         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2213         class for them.
2214         
2215         Moving of existing baselines is not implemented yet, this patch is big
2216         enough as it is.
2217
2218         * Scripts/webkitpy/common/system/filesystem.py:
2219         * Scripts/webkitpy/common/system/filesystem_mock.py:
2220         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2221         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2222         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2223         * Scripts/webkitpy/tool/mocktool.py:
2224
2225 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2226
2227         Unreviewed build fix after vcproj updates.
2228
2229         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2230         that WIN_CAIRO is defined for this build.
2231         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2232         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2233         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2234
2235 2010-12-02  Sam Weinig  <sam@webkit.org>
2236
2237         Reviewed by Anders Carlsson.
2238
2239         WebKit2 needs API to turn on popup blocking
2240         https://bugs.webkit.org/show_bug.cgi?id=50407
2241
2242         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2243         (TestWebKitAPI::TEST):
2244         * WebKitTestRunner/TestController.cpp:
2245         (WTR::TestController::resetStateToConsistentValues):
2246
2247 2010-12-01  Tony Chang  <tony@chromium.org>
2248
2249         Reviewed by Ojan Vafai.
2250
2251         [chromium] force NRWT to use DRT
2252         https://bugs.webkit.org/show_bug.cgi?id=50359
2253
2254         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2255
2256 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2257
2258         Reviewed by Xan Lopez.
2259
2260         [GTK] DumpRenderTree has two copies of JavaScriptCore
2261         https://bugs.webkit.org/show_bug.cgi?id=49877
2262
2263         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
2264         LDADD list for DumpRenderTree.
2265
2266 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
2267
2268         Unreviewed: Added myself to list of Committers.
2269
2270         * Scripts/webkitpy/common/config/committers.py:
2271
2272 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
2273
2274         Reviewed by Adam Barth.
2275
2276         build-webkit --chromium always updates DEPS and re-generates project files
2277         https://bugs.webkit.org/show_bug.cgi?id=50340
2278         
2279         Make build-webkit --chromium invoke update-webkit-chromium only when
2280         --update-chromium is passed in, so that we don't add 20 seconds to all
2281         builds.
2282         
2283         Making all invocations update was added with r61883, with the goal of
2284         making EWS bots always update. The bots will switch to using this flag
2285         (as will all other webkit-patch build steps) so nothing should change
2286         for them.
2287
2288         * Scripts/webkitdirs.pm:
2289         * Scripts/webkitpy/common/config/ports.py:
2290         * Scripts/webkitpy/common/config/ports_unittest.py:
2291
2292 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2293
2294         Reviewed by Tony Chang.
2295
2296         new-run-webkit-tests: add a --dry-run / -n flag
2297         https://bugs.webkit.org/show_bug.cgi?id=50045
2298
2299         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2300         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2301
2302 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2303
2304         Reviewed by Adam Roben.
2305
2306         WinCairo build should not use link-time code generation (LTCG)
2307         https://bugs.webkit.org/show_bug.cgi?id=50353
2308
2309         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2310         * DumpRenderTree/win/DumpRenderTree.vcproj:
2311         * DumpRenderTree/win/ImageDiff.vcproj:
2312         * FindSafari/FindSafari.vcproj:
2313         * MiniBrowser/MiniBrowser.vcproj:
2314         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2315         * WebKitAPITest/WebKitAPITest.vcproj:
2316         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2317         * WebKitTestRunner/win/InjectedBundle.vcproj:
2318         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2319         * WinLauncher/WinLauncher.vcproj:
2320         * record-memory-win/record-memory-win.vcproj:
2321
2322 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2323
2324         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
2325         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2326         adding the file to the sources list was not enough to force the rebuild.
2327
2328         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2329         Remove an empty line at the end of this file to force a rebuild.
2330
2331 2010-12-01  Sam Weinig  <sam@webkit.org>
2332
2333         Fix windows build.
2334
2335         * MiniBrowser/win/BrowserView.cpp:
2336         (BrowserView::create):
2337
2338 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2339
2340         Add missing file to the TestNetscapePlugin sources list after r73057.
2341
2342         * GNUmakefile.am: Add missing file.
2343
2344 2010-12-01  Sam Weinig  <sam@webkit.org>
2345
2346         Reviewed by Anders Carlsson.
2347
2348         Add PageGrouping to WebKit2 API
2349         https://bugs.webkit.org/show_bug.cgi?id=50332
2350
2351         - Update testing harnesses to deal with new PageGroup API.
2352
2353         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2354         (WKBundleInitialize):
2355         * TestWebKitAPI/InjectedBundleController.cpp:
2356         (TestWebKitAPI::InjectedBundleController::initialize):
2357         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2358         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2359         * TestWebKitAPI/InjectedBundleController.h:
2360         * TestWebKitAPI/InjectedBundleTest.h:
2361         (TestWebKitAPI::InjectedBundleTest::initialize):
2362         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2363         * TestWebKitAPI/PlatformUtilities.cpp:
2364         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2365         * TestWebKitAPI/PlatformUtilities.h:
2366         * TestWebKitAPI/PlatformWebView.h:
2367         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2368         (TestWebKitAPI::TEST):
2369         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2370         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2371         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2372         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2373         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2374         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2375         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2376         (WTR::InjectedBundle::didInitializePageGroup):
2377         (WTR::InjectedBundle::initialize):
2378         (WTR::InjectedBundle::beginTesting):
2379         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2380         (WTR::InjectedBundle::pageGroup):
2381         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2382         (WTR::LayoutTestController::addUserScript):
2383         (WTR::LayoutTestController::addUserStyleSheet):
2384         (WTR::LayoutTestController::setXSSAuditorEnabled):
2385         * WebKitTestRunner/TestController.cpp:
2386         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2387         (WTR::PlatformWebView::PlatformWebView):
2388
2389 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2390
2391         Reviewed by Adam Roben.
2392
2393         vcproj changes can't be applied cleanly by the Windows EWS bot
2394         https://bugs.webkit.org/show_bug.cgi?id=50328
2395
2396         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2397         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2398         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2399         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2400         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2401         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2402         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2403         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2404         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2405         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2406         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2407         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2408         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2409         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2410         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2411         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2412         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2413         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2414         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2415         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2416         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2417         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2418         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2419         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2420         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2421         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2422         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2423         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2424         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2425         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2426         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2427         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2428         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2429         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2430         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2431         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2432         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2433         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2434         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2435         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2436         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2437         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2438         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2439         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2440         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2441
2442 2010-12-01  Anders Carlsson  <andersca@apple.com>
2443
2444         Reviewed by Darin Adler.
2445
2446         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2447         https://bugs.webkit.org/show_bug.cgi?id=50336
2448
2449         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2450         Add new test.
2451
2452         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2453         (PluginTest::NPP_New):
2454         Add default implementation/
2455
2456         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2457         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2458         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2459         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2460         Get the user agent.
2461
2462         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2463         (NPP_New):
2464         Call PluginTest::NPP_New.
2465
2466         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2467         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2468         Add new files.
2469
2470         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2471         (webkit_test_plugin_new_instance):
2472         Call PluginTest::NPP_New.
2473
2474 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2475
2476         [wx] Build fixes after recent trunk changes.
2477
2478         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2479         (LayoutTestController::findString):
2480         * wx/build/settings.py:
2481
2482 2010-12-01  Dan Bernstein  <mitz@apple.com>
2483
2484         Reviewed by Darin Adler.
2485
2486         WebKitTestRunner needs layoutTestController.findString
2487         https://bugs.webkit.org/show_bug.cgi?id=50238
2488
2489         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2490         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2491         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2492         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2493
2494 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2495
2496         Try using svn:eol-style native on a vcproj file.
2497
2498         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2499
2500 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2501
2502         Reviewed by Adam Roben.
2503
2504         [WINCE] Add WinCELauncher
2505         https://bugs.webkit.org/show_bug.cgi?id=50217
2506
2507         * WinCELauncher/main.cpp: Added.
2508
2509 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2510
2511         Reviewed by Kenneth Rohde Christiansen.
2512
2513         [Qt] Implement layoutTestController.findString
2514         https://bugs.webkit.org/show_bug.cgi?id=50236
2515
2516         Add the missing function to the LayoutTestController.
2517
2518         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2519         (LayoutTestController::findString):
2520         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2521
2522 2010-11-30  Tony Chang  <tony@chromium.org>
2523
2524         Reviewed by Adam Barth.
2525
2526         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2527         https://bugs.webkit.org/show_bug.cgi?id=49036
2528
2529         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2530             for CppVariants.
2531         (LayoutTestController::cppVariantToBool):
2532         (LayoutTestController::cppVariantToInt32):
2533         (LayoutTestController::setDatabaseQuota):
2534         (LayoutTestController::evaluateInWebInspector):
2535         (LayoutTestController::setMockGeolocationError):
2536
2537 2010-11-30  Eric Seidel  <eric@webkit.org>
2538
2539         Reviewed by Tony Chang.
2540
2541         update-webkit should call git fetch before git svn rebase
2542         https://bugs.webkit.org/show_bug.cgi?id=50273
2543
2544         After discussion on webkit-dev, we've decided to move the "default"
2545         git setup to pulling updates from git.webkit.org in preference
2546         to rebuilding the local svn index using git svn fetch every time.
2547
2548         This change should have no effect on people using the "old" git setup
2549         and should dramatically increase the speed of updates for those using
2550         the "new" git setup along with update-webkit.  I'm about to move the
2551         EWS and other queues over to this setup once this lands.
2552
2553         * Scripts/update-webkit:
2554
2555 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2556
2557         Reviewed by Xan Lopez.
2558
2559         GTK: AX: implement press in DRT
2560         https://bugs.webkit.org/show_bug.cgi?id=36146
2561
2562         Implement AccessibilityUIElement::press() for GTK.
2563
2564         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2565         (AccessibilityUIElement::press): Implemented.
2566
2567 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2568
2569         Reviewed by Tony Chang.
2570
2571         config.webkit_base_dir returns a path with a trailing slash
2572         https://bugs.webkit.org/show_bug.cgi?id=50197
2573         
2574         config.webkit_base_dir() should return a path without a trailing slash,
2575         like all the other methods that return paths.
2576         
2577         Undoes MockFileSytem changes by r72640, since they're no longer
2578         necessary for GetBaselinesTest to pass.
2579
2580         * Scripts/webkitpy/common/system/filesystem_mock.py:
2581         * Scripts/webkitpy/layout_tests/port/base.py:
2582         * Scripts/webkitpy/layout_tests/port/config.py:
2583         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2584
2585 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2586
2587         Reviewed by Tony Chang.
2588
2589         Rebaseline server: baseline display tweaks
2590         https://bugs.webkit.org/show_bug.cgi?id=50207
2591         
2592         Determine which baselines were used when running the tests and highlight
2593         them in the UI. Sort platform names alphabetically.
2594         
2595         Also makes the server URL be launched in the user's browser
2596         automatically.
2597
2598         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2599         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2600         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2601         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2602         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2603
2604 2010-11-30  Dan Bernstein  <mitz@apple.com>
2605
2606         Reviewed by Anders Carlsson.
2607
2608         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2609         https://bugs.webkit.org/show_bug.cgi?id=50238
2610
2611         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2612         (WTR::LayoutTestController::findString): Added.
2613         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2614
2615 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2616
2617         Reviewed by Adam Roben.
2618
2619         All projects on Windows should use cmd files for build events
2620         https://bugs.webkit.org/show_bug.cgi?id=50213
2621
2622         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2623         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2624         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2625         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2626         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2627         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2628         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2629         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2630         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2631         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2632         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2633         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2634         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2635         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
2636         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2637         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
2638         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
2639         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2640         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
2641         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
2642         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2643         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2644         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
2645         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
2646         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
2647         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
2648         * WinLauncher/WinLauncherCommon.vsprops:
2649         * WinLauncher/WinLauncherPostBuild.cmd: Added.
2650         * WinLauncher/WinLauncherPreBuild.cmd: Added.
2651
2652 2010-11-29  Dan Bernstein  <mitz@apple.com>
2653
2654         GTK DumpRenderTree build fix after r72887.
2655
2656         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2657         (LayoutTestController::findString):
2658
2659 2010-11-29  Dan Bernstein  <mitz@apple.com>
2660
2661         Windows DumpRenderTree build fix after r72887.
2662
2663         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2664         (LayoutTestController::findString): Added empty implementation.
2665
2666 2010-11-29  Dan Bernstein  <mitz@apple.com>
2667
2668         Reviewed by Darin Adler.
2669
2670         DumpRenderTree changes for testing the text search API.
2671         https://bugs.webkit.org/show_bug.cgi?id=50038
2672
2673         * DumpRenderTree/LayoutTestController.cpp:
2674         (findStringCallback):
2675         (LayoutTestController::staticFunctions):
2676         * DumpRenderTree/LayoutTestController.h:
2677         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2678         (LayoutTestController::findString):
2679         * MiniBrowser/mac/BrowserWindowController.m:
2680         (-[BrowserWindowController find:]):
2681
2682 2010-11-29  Johnny Ding  <jnd@chromium.org>
2683
2684         Unreviewed: Add myself to the list of Committers.
2685
2686         * Scripts/webkitpy/common/config/committers.py:
2687
2688 2010-11-29  Mark Rowe  <mrowe@apple.com>
2689
2690         Reviewed by Adele Peterson.
2691
2692         <rdar://problem/8694997> DumpRenderTree fails to build.
2693
2694         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
2695
2696 2010-11-29  Mark Rowe  <mrowe@apple.com>
2697
2698         Reviewed by Adele Peterson.
2699
2700         <rdar://problem/8694997> DumpRenderTree fails to build.
2701
2702         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
2703         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
2704         * DumpRenderTree/mac/PerlSupport/Makefile:
2705
2706 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
2707
2708         Reviewed by Martin Robinson.
2709
2710         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
2711         https://bugs.webkit.org/show_bug.cgi?id=50154
2712
2713         Added missing checks to allAttributes().
2714
2715         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2716         (AccessibilityUIElement::allAttributes): Added missing checks.
2717
2718 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2719
2720         Reviewed by Kenneth Rohde Christiansen.
2721
2722         [Qt] Allow pre-generation for package builds for WebKit2
2723         https://bugs.webkit.org/show_bug.cgi?id=50139
2724
2725         Use a build variable for the generated directory path and set the
2726         value based on CONFIG just like for WebKit1.
2727
2728         For non-package builds use a relative base path for the
2729         genrated directory just like for WebKit1.
2730
2731         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2732         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2733
2734 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2735
2736         Reviewed by Kenneth Rohde Christiansen.
2737
2738         [Qt] Move some build logic from Qt to platform independent code
2739         https://bugs.webkit.org/show_bug.cgi?id=50134
2740
2741         Create target directories inside generate-forwarding-headers.pl.
2742
2743         * Scripts/generate-forwarding-headers.pl:
2744
2745 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2746
2747         Reviewed by Martin Robinson.
2748
2749         [GTK] Windowless plugins gets broken key input
2750         https://bugs.webkit.org/show_bug.cgi?id=49927
2751
2752         Convert the XEvent::keycode to ASCII before printing it. Not
2753         doing this was causing false positive in 
2754         plugins/keyboard-events.html.
2755
2756         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2757         (keycode_to_char):
2758         (webkit_test_plugin_handle_event):
2759
2760 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
2761
2762         Reviewed by Antonio Gomes.
2763
2764         [Qt] Html autofocus not working with QGraphicsWebView
2765         https://bugs.webkit.org/show_bug.cgi?id=43169
2766
2767         Tell the scene to set the webview item as the currently
2768         focused item. This makes the input field with autofocus get
2769         focus as it should.
2770
2771         * QtTestBrowser/webview.cpp:
2772         (WebViewGraphicsBased::WebViewGraphicsBased):
2773
2774 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2775
2776         Reviewed by Tony Chang.
2777
2778         nrwt - clean up create_driver interface and print out the
2779         command line used for DumpRenderTree/TestShell.
2780
2781         This patch adds a driver_cmd_line() call to the Port class in
2782         order to retrive the command line to print it out (as part of
2783         --print config).
2784
2785         In addition, this patch cleans up the Port.create_driver()
2786         signature and the Driver constructor interface to take a worker
2787         number and no longer require the image_path argument (Chromium's
2788         drivers now synthesize the image_path from the worker number
2789         internally).
2790
2791         https://bugs.webkit.org/show_bug.cgi?id=49934
2792
2793         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2794         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2795         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2796         * Scripts/webkitpy/layout_tests/port/base.py:
2797         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2798         * Scripts/webkitpy/layout_tests/port/chromium.py:
2799         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2800         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2801         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2802         * Scripts/webkitpy/layout_tests/port/test.py:
2803         * Scripts/webkitpy/layout_tests/port/webkit.py:
2804         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2805         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2806
2807 2010-11-24  Ojan Vafai  <ojan@chromium.org>
2808
2809         Reviewed by Tony Chang.
2810
2811         [chromium] improve memory usage for test results server and store fewer runs
2812         https://bugs.webkit.org/show_bug.cgi?id=50035
2813
2814         Store fewer runs and don't pass full files around when we only need bools.
2815         Greatly improves error rates on test-results.appspot.com.
2816
2817         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2818         * TestResultServer/handlers/testfilehandler.py:
2819         * TestResultServer/model/dashboardfile.py:
2820         * TestResultServer/model/jsonresults.py:
2821
2822 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2823
2824         Reviewed by Tony Chang.
2825
2826         This patch implements the first part of the manager side of the
2827         Broker objects - it handles creating threads, waiting for them
2828         to complete, and running a single-threaded loop as well.
2829
2830         https://bugs.webkit.org/show_bug.cgi?id=49779
2831
2832         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2833         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2834         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2835         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2836
2837 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
2838
2839         Reviewed by David Levin.
2840
2841         DRT should not generate pixel output for text/plain tests
2842         https://bugs.webkit.org/show_bug.cgi?id=50002
2843         
2844         Modify Mac, Windows and GTK DRT implementations to disable pixel output
2845         when encountering a text/plain response (the Chromium one already does
2846         this, and none of the other ports special-case text/plain output in
2847         the first place).
2848
2849         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2850         (dump):
2851         * DumpRenderTree/mac/DumpRenderTree.mm:
2852         (dump):
2853         * DumpRenderTree/win/DumpRenderTree.cpp:
2854         (dump):
2855
2856 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2857
2858         Unreviewed.
2859
2860         Add my other email address to committers.py.
2861
2862         * Scripts/webkitpy/common/config/committers.py:
2863
2864 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2865
2866         Reviewed by Csaba Osztrogonác.
2867
2868         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
2869         https://bugs.webkit.org/show_bug.cgi?id=49975
2870
2871         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
2872         to enable the script to define it 0 in case of a minimal build.
2873
2874 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
2875
2876         Reviewed by Xan Lopez.
2877
2878         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
2879         https://bugs.webkit.org/show_bug.cgi?id=49143
2880
2881         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2882         (createWebView): Call the new connectEditingCallbacks function.
2883         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
2884         (dumpNodePath):
2885         (dumpRange):
2886         (insertActionString):
2887         (selectionAffinityString):
2888         (shouldBeginEditing):
2889         (shouldEndEditing):
2890         (shouldInsertNode):
2891         (shouldInsertText):
2892         (shouldDeleteRange):
2893         (shouldShowDeleteInterfaceForElement):
2894         (shouldChangeSelectedRange):
2895         (shouldApplyStyle):
2896         (editingBegan):
2897         (userChangedContents):
2898         (editingEnded):
2899         (selectionChanged):
2900         (connectEditingCallbacks):
2901         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
2902         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
2903
2904 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
2905
2906         Reviewed by Andreas Kling.
2907
2908         [Qt] Make QtTestBrowser remember the selected user agent
2909         https://bugs.webkit.org/show_bug.cgi?id=50021
2910
2911         Set user agent for a new page by using the old page's
2912
2913         * QtTestBrowser/mainwindow.cpp:
2914         (MainWindow::setPage):
2915
2916 2010-11-24 Patrick Gansterer <paroga@webkit.org>
2917
2918         Reviewed by Csaba Osztrogonác.
2919
2920         Remove Bakefile build system files
2921         https://bugs.webkit.org/show_bug.cgi?id=49983
2922
2923         r53757 only removed the content, but not the files.
2924         This patch removes that empty files.
2925
2926         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
2927         * wx/browser/browser.bkl: Removed.
2928         * wx/build-wxwebkit: Removed.
2929
2930 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
2931
2932         Reviewed by Tony Chang.
2933
2934         This patch cleans up the logic used to shard tests into groups a
2935         bit and adds the --worker-model flag to NRWT. The flag is only
2936         used at the moment to control whether to run single-threaded or
2937         not, but eventually will also allow toggling between threads and
2938         processes.
2939
2940         Also add a minor cleanup with _test_is_slow(), which just
2941         eliminates some repetition and gives slightly better encapsulation.
2942
2943         https://bugs.webkit.org/show_bug.cgi?id=49773
2944
2945         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2946         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2947
2948 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
2949
2950         Reviewed by Tony Chang.
2951
2952         Rebaseline server: list current baselines and platforms
2953         https://bugs.webkit.org/show_bug.cgi?id=49991
2954         
2955         List existing baselines (with Trac links) for tests.
2956         
2957         Add dropdowns for choosing with platform baselines to target (and what
2958         to do with existing ones).
2959
2960         Also fix MockFileSystem.join to behave more like os.path.join (unit
2961         test was ending up with two consecutive slashes in a layout test
2962         path).        
2963
2964         * Scripts/webkitpy/common/system/filesystem_mock.py:
2965         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2966         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2967         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2968         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2969         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2970         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2971         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
2972
2973 2010-11-23  Ojan Vafai  <ojan@chromium.org>
2974
2975         Reviewed by Tony Chang.
2976
2977         remove timeout argument to urlopen
2978         https://bugs.webkit.org/show_bug.cgi?id=49995
2979
2980         Apparently the version of python we have on the bots doesn't accept a timeout argument.
2981
2982         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2983
2984 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2985
2986         Unreviewed, rolling out r72628.
2987         http://trac.webkit.org/changeset/72628
2988         https://bugs.webkit.org/show_bug.cgi?id=49994
2989
2990         This patch is causing layout-test failtures on GTK Linux
2991         64-bit Debug (Requested by ctguil on #webkit).
2992
2993         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2994         (AccessibilityUIElement::AccessibilityUIElement):
2995         (AccessibilityUIElement::parentElementCallback):
2996         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2997         * DumpRenderTree/chromium/CppBoundClass.cpp:
2998         * DumpRenderTree/chromium/CppBoundClass.h:
2999
3000 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3001
3002         Reviewed by Tony Chang.
3003
3004         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
3005         https://bugs.webkit.org/show_bug.cgi?id=49944
3006
3007         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3008
3009 2010-11-23  Chris Guillory  <chris.guillory@google.com>
3010
3011         Reviewed by Dimitri Glazkov.
3012
3013         Include the FrameView widget of a RenderWidget in the accessibility tree.
3014         https://bugs.webkit.org/show_bug.cgi?id=49106
3015
3016         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3017         (AccessibilityUIElement::AccessibilityUIElement):
3018         (AccessibilityUIElement::parentElementCallback):
3019         (AccessibilityUIElement::isEqualCallback):
3020         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3021         * DumpRenderTree/chromium/CppBoundClass.cpp:
3022         (CppBoundClass::getFromCppVariant):
3023         * DumpRenderTree/chromium/CppBoundClass.h:
3024
3025 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
3026
3027         Reviewed by Kenneth Rohde Christiansen.
3028
3029         [EFL] Add tiled backing store to EWebLauncher
3030         https://bugs.webkit.org/show_bug.cgi?id=45777
3031
3032         Allow EWebLauncher to choose between single and tiled backing store
3033
3034         * EWebLauncher/main.c:
3035         (on_key_down):
3036         (browserCreate):
3037         (main):
3038
3039 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3040
3041         Reviewed by Tor Arne Vestbø.
3042
3043         [Qt] Review the setUserPermission & friends API
3044         https://bugs.webkit.org/show_bug.cgi?id=46810
3045
3046         Renamed requestPermissionFromUser to featurePermissionRequested
3047         and cancelRequestsForPermission to featurePermissionRequestCanceled.
3048
3049         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3050         (WebCore::WebPage::WebPage):
3051         * QtTestBrowser/webpage.cpp:
3052         (WebPage::WebPage):
3053         (WebPage::featurePermissionRequestCanceled):
3054         * QtTestBrowser/webpage.h:
3055
3056 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3057
3058         Reviewed by Tor Arne Vestbø.
3059
3060         [Qt] Review the setUserPermission & friends API
3061         https://bugs.webkit.org/show_bug.cgi?id=46810
3062
3063         Rename setUserPermission to setFeaturePermission
3064
3065         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3066         (WebCore::WebPage::requestPermission):
3067         (WebCore::WebPage::permissionSet):
3068         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3069         (LayoutTestController::grantDesktopNotificationPermission):
3070         * QtTestBrowser/webpage.cpp:
3071         (WebPage::requestPermission):
3072
3073 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3074
3075         Reviewed by Tor Arne Vestbø.
3076
3077         [Qt] Review the setUserPermission & friends API
3078         https://bugs.webkit.org/show_bug.cgi?id=46810
3079
3080         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
3081         and GeolocationPermissionDomain to Geolocation.
3082
3083         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3084         (WebCore::WebPage::WebPage):
3085         (WebCore::WebPage::requestPermission):
3086         (WebCore::WebPage::cancelPermission):
3087         (WebCore::WebPage::permissionSet):
3088         (WebCore::DumpRenderTree::geolocationPermissionSet):
3089         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3090         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3091         (LayoutTestController::grantDesktopNotificationPermission):
3092         * QtTestBrowser/webpage.cpp:
3093         (WebPage::WebPage):
3094         (WebPage::requestPermission):
3095         (WebPage::cancelRequestsForPermission):
3096         * QtTestBrowser/webpage.h:
3097
3098 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3099
3100         Reviewed by Tor Arne Vestbø.
3101
3102         [Qt] Review the setUserPermission & friends API
3103         https://bugs.webkit.org/show_bug.cgi?id=46810
3104
3105         Add a ByUser suffix to PermissionGranted/Denied. In the future
3106         we can add PermissionGrantedByDefault.
3107
3108
3109         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3110         (WebCore::WebPage::requestPermission):
3111         (WebCore::WebPage::permissionSet):
3112         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3113         (LayoutTestController::grantDesktopNotificationPermission):
3114         * QtTestBrowser/webpage.cpp:
3115         (WebPage::requestPermission):
3116
3117 2010-11-18  Satish Sampath  <satish@chromium.org>
3118
3119         Reviewed by Jeremy Orlow.
3120
3121         For speech input event, send an event object containing all the recognition results and metadata.
3122         https://bugs.webkit.org/show_bug.cgi?id=49736
3123
3124         Updated DRT by renaming the mock result method on all platforms to the new signature.
3125
3126         * DumpRenderTree/LayoutTestController.cpp:
3127         (addMockSpeechInputResultCallback):
3128         (LayoutTestController::staticFunctions):
3129         * DumpRenderTree/LayoutTestController.h:
3130         * DumpRenderTree/chromium/LayoutTestController.cpp:
3131         (LayoutTestController::LayoutTestController):
3132         (LayoutTestController::addMockSpeechInputResult):
3133         * DumpRenderTree/chromium/LayoutTestController.h:
3134         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3135         (LayoutTestController::addMockSpeechInputResult):
3136         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3137         (LayoutTestController::addMockSpeechInputResult):
3138         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3139         (LayoutTestController::addMockSpeechInputResult):
3140         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3141         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3142         (LayoutTestController::addMockSpeechInputResult):
3143         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3144         (LayoutTestController::addMockSpeechInputResult):
3145
3146 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
3147
3148         Reviewed by Tony Chang.
3149
3150         Fix some spacing issues with log messages with
3151         new-run-webkit-tests --verbose.
3152
3153         https://bugs.webkit.org/show_bug.cgi?id=49936
3154
3155         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3156
3157 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3158
3159         Reviewed by Adam Barth.
3160
3161         update scm to work with different remote branches
3162         https://bugs.webkit.org/show_bug.cgi?id=49949
3163
3164         This works if there are multiple svn tracking branches
3165         and/or if the tracking branch is refs/remots/origin/master
3166         instead of refs/remotes/trunk which is the direction we're trying
3167         to head since that makes fetches faster.
3168
3169         * Scripts/webkitpy/common/checkout/scm.py:
3170         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3171
3172 2010-11-22  Hayato Ito  <hayato@chromium.org>
3173
3174         Reviewed by Shinichiro Hamaji.
3175
3176         Ignore reference files which will be used by reftests when collecting
3177         test cases.
3178         https://bugs.webkit.org/show_bug.cgi?id=49835
3179
3180         * Scripts/webkitpy/layout_tests/port/test_files.py:
3181         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3182
3183 2010-11-22  Adam Roben  <aroben@apple.com>
3184
3185         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3186
3187         Apple's Windows build allows placing header files and import libraries for WebKit's
3188         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3189         $WebKitLibrariesDir environment variable. This is both required for production builds and
3190         convenient for Apple-internal developer builds. Apple's production builds also require that
3191         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3192         builds, the files are copied into that directory tree by the
3193         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3194         copying is done by
3195         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3196
3197         This .vsprops copying is problematic in one very important case: when a developer updates
3198         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3199         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3200         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3201         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3202         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
3203         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3204
3205         To fix this, we now use normal relative paths to access the .vsprops files in the source
3206         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3207         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3208         unset, so the normal relative paths are used to read the .vsprops files out of the source
3209         tree directly. In production builds, this environment variable is set to a fake directory
3210         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3211         is resolved.
3212         
3213         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3214
3215         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3216
3217         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3218         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3219         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3220         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3221         FeatureDefines.vsprops becomes:
3222
3223         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3224
3225         which resolves to:
3226
3227         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3228
3229         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3230         actually exist since they are matched by an equal number of ".." path components.)
3231
3232         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3233         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3234
3235         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3236         updated
3237
3238         Reviewed by Dave Hyatt.
3239
3240         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3241         * DumpRenderTree/win/DumpRenderTree.vcproj:
3242         * DumpRenderTree/win/ImageDiff.vcproj:
3243         * FindSafari/FindSafari.vcproj:
3244         * MiniBrowser/MiniBrowser.vcproj:
3245         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3246         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3247         * WebKitAPITest/WebKitAPITest.vcproj:
3248         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3249         * WebKitTestRunner/win/InjectedBundle.vcproj:
3250         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3251         * WinLauncher/WinLauncher.vcproj:
3252         * record-memory-win/record-memory-win.vcproj:
3253         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3254         files.
3255
3256 2010-11-22  Adam Roben  <aroben@apple.com>
3257
3258         Make it possible to run tests on Windows without Visual Studio or VC++
3259         Express installed
3260
3261         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
3262         are not installed. But this function doesn't need to be called when we
3263         already have a build available and are just trying to run the tests.
3264
3265         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
3266         because Visual Studio/VC++ Express aren't installed
3267
3268         Reviewed by Dave Hyatt.
3269
3270         * Scripts/webkitdirs.pm:
3271         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
3272         it is not needed by this function. Also added a FIXME.
3273
3274         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
3275         relying on determineConfigurationForVisualStudio doing it.
3276
3277 2010-11-19  Hayato Ito  <hayato@chromium.org>
3278
3279         Reviewed by Shinichiro Hamaji.
3280
3281         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
3282
3283         https://bugs.webkit.org/show_bug.cgi?id=49812
3284
3285         * Scripts/webkitpy/layout_tests/driver_test.py:
3286         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3287         * Scripts/webkitpy/layout_tests/port/base.py:
3288         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3289         * Scripts/webkitpy/layout_tests/port/chromium.py:
3290         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3291         * Scripts/webkitpy/layout_tests/port/test.py:
3292         * Scripts/webkitpy/layout_tests/port/webkit.py:
3293         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3294         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3295
3296 2010-11-22  Hayato Ito  <hayato@chromium.org>
3297
3298         Reviewed by Tony Chang.
3299
3300         [NRWT] Retry a few times in reading a png image to avoid a race condition.
3301
3302         https://bugs.webkit.org/show_bug.cgi?id=49924
3303
3304         * Scripts/webkitpy/layout_tests/port/chromium.py:
3305
3306 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
3307
3308         Reviewed by Kenneth Rohde Christiansen.
3309
3310         Fix EWebLauncher zoom discretization
3311         https://bugs.webkit.org/show_bug.cgi?id=49810
3312
3313         * EWebLauncher/main.c:
3314         (nearest_zoom_level_get):
3315         (zoom_level_set):
3316         (on_load_finished):
3317         (on_key_down):
3318
3319 2010-11-21  Sam Weinig  <sam@webkit.org>
3320
3321         Rubber-stamped by Dan Bernstein.
3322
3323         Fix ~300 WebKit2 tests by enabling developer extras preference.
3324
3325         * WebKitTestRunner/TestController.cpp:
3326         (WTR::TestController::resetStateToConsistentValues):
3327
3328 2010-11-21  Sam Weinig  <sam@webkit.org>
3329
3330         Reviewed by Dan Bernstein.
3331
3332         Textareas should be resizable by default
3333         https://bugs.webkit.org/show_bug.cgi?id=49892
3334
3335         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3336         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
3337         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3338         Add preferences test.
3339
3340 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
3341
3342         Reviewed by Tony Chang.
3343
3344         Rebaseline server: checksum-only differences and prefetching
3345         https://bugs.webkit.org/show_bug.cgi?id=49841
3346         
3347         Add support for image test results where the only difference is in the
3348         checksum.
3349         
3350         Add prefetching of the image results from the next test.
3351         
3352         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3353         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3354         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3355
3356 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3357
3358         Reviewed by Tony Chang.
3359
3360         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
3361
3362         Add the 'worker number' and 'worker name' concepts to the 
3363         TestShellThread objects, and move test_types and test_args from
3364         the TestRunner to the TestShellThread.
3365
3366         https://bugs.webkit.org/show_bug.cgi?id=49768
3367
3368         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3369         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3370
3371 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3372
3373         Reviewed by Ojan Vafai.
3374
3375         Do some minor cleanup and bug fixing.
3376
3377         https://bugs.webkit.org/show_bug.cgi?id=49777
3378
3379         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3380         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3381
3382 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3383
3384         Reviewed by Ojan Vafai.
3385
3386         nrwt - config.build_directory() is busted
3387
3388         Fixes a typo that was causing us to usually return the top level
3389         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
3390         bug was hidden by test stubs that were too simplistic :(.
3391
3392         https://bugs.webkit.org/show_bug.cgi?id=49815
3393
3394         * Scripts/webkitpy/common/system/executive_mock.py:
3395         * Scripts/webkitpy/layout_tests/port/config.py:
3396         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3397
3398 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3399
3400         Reviewed by Adam Roben.
3401
3402         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3403         https://bugs.webkit.org/show_bug.cgi?id=49819
3404
3405         * DumpRenderTree/DumpRenderTree.sln:
3406         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3407         * DumpRenderTree/win/DumpRenderTree.vcproj:
3408         * DumpRenderTree/win/ImageDiff.vcproj:
3409         * FindSafari/FindSafari.vcproj:
3410         * MiniBrowser/MiniBrowser.vcproj:
3411         * TestWebKitAPI/win/TestWebKitAPI.sln:
3412         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3413         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3414         * WebKitAPITest/WebKitAPITest.vcproj:
3415         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3416         * WebKitTestRunner/win/InjectedBundle.vcproj:
3417         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3418         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3419         * WinLauncher/WinLauncher.vcproj:
3420         * record-memory-win/record-memory-win.vcproj:
3421
3422 2010-11-19  Adam Roben  <aroben@apple.com>
3423
3424         Add some more Windows slaves
3425
3426         This is probably more than we will be using in the immediate future,
3427         but having some extra slave names makes experimenting with different
3428         configurations easier.
3429
3430         Reviewed by Jon Honeycutt.
3431
3432         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
3433         Windows slaves and distributed them among the three different Test
3434         builders.
3435
3436 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
3437
3438         Reviewed by Ojan Vafai.
3439
3440         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3441         https://bugs.webkit.org/show_bug.cgi?id=49702
3442
3443         Re-landing r72357 with a test fix.
3444
3445         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3446         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3447         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3448
3449 2010-11-19  Avi Drissman  <avi@google.com>
3450
3451         Reviewed by Antonio Gomes.
3452
3453         Complete support for Unix editing mode
3454         https://bugs.webkit.org/show_bug.cgi?id=49757
3455
3456         * DumpRenderTree/LayoutTestController.cpp:
3457         (setEditingBehaviorCallback):
3458         * DumpRenderTree/chromium/LayoutTestController.cpp:
3459         (LayoutTestController::setEditingBehavior):
3460
3461 2010-11-19  Adam Roben  <aroben@apple.com>
3462
3463         Fix run-javascriptcore-tests when there's a space in the path to
3464         testapi
3465
3466         Reviewed by Sam Weinig.
3467
3468         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
3469         system() to force it to interpret spaces in the path correctly.
3470
3471 2010-11-19  Adam Roben  <aroben@apple.com>
3472
3473         Update scripts for .exe name changes after r72327
3474
3475         As of r72327, the "_debug" suffix is only used in Debug_All builds.
3476
3477         Reviewed by Sam Weinig.
3478
3479         * Scripts/run-javascriptcore-tests:
3480         (testapiPath):
3481
3482         * Scripts/sunspider-compare-results:
3483         (pathToBuiltJSC):
3484
3485         * Scripts/webkitdirs.pm:
3486         (jscPath):
3487         (safariPath):
3488
3489 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3490
3491         Reviewed by Darin Adler.
3492
3493         Normalize Cairo/CFLite project/solution configuration names
3494         https://bugs.webkit.org/show_bug.cgi?id=49818
3495
3496         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3497         * DumpRenderTree/win/DumpRenderTree.vcproj:
3498         * DumpRenderTree/win/ImageDiff.vcproj:
3499         * MiniBrowser/MiniBrowser.vcproj:
3500         * TestWebKitAPI/win/TestWebKitAPI.sln:
3501         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3502         * WebKitAPITest/WebKitAPITest.vcproj:
3503         * WebKitTestRunner/win/InjectedBundle.vcproj:
3504         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3505         * WinLauncher/WinLauncher.vcproj:
3506         * Scripts/webkitdirs.pm: Updated cairo build configs.
3507
3508 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3509
3510         Reviewed by Adam Roben.
3511
3512         Windows vcproj configuration names should be normalized across projects
3513         https://bugs.webkit.org/show_bug.cgi?id=49776
3514
3515         * DumpRenderTree/DumpRenderTree.sln:
3516         * FindSafari/FindSafari.vcproj:
3517         * TestWebKitAPI/win/TestWebKitAPI.sln:
3518         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3519         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
3520         * WebKitAPITest/WebKitAPITest.vcproj:
3521         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3522         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3523         * WebKitTestRunner/WebKitTestRunner.sln:
3524         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3525         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
3526         * record-memory-win/record-memory-win.vcproj:
3527
3528 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3529
3530         Build fix - as per DRT-mac, always enabled developer extras,
3531         in win/qt/gtk DRT.
3532
3533         This is necessary to enable rich exception messages to be generated
3534         following https://bugs.webkit.org/show_bug.cgi?id=49708.
3535
3536         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3537         (shouldEnableDeveloperExtras):
3538         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3539         (WebCore::shouldEnableDeveloperExtras):
3540         * DumpRenderTree/win/DumpRenderTree.cpp:
3541         (shouldEnableDeveloperExtras):
3542
3543 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3544
3545         Unreviewed, rolling out r72357.
3546         http://trac.webkit.org/changeset/72357
3547         https://bugs.webkit.org/show_bug.cgi?id=49784
3548
3549         It broke test-webkitpy tests since the patch didn't have the
3550         corresponding test update (Requested by kinuko on #webkit).
3551
3552         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3553         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3554
3555 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
3556
3557         Reviewed by Tony Chang.
3558
3559         Rebaseline server: add rebaseline queue
3560         https://bugs.webkit.org/show_bug.cgi?id=49763
3561         
3562         Add a UI queue (a multi-item <select>) where tests to be baselined
3563         can be enqueued (also supports basic removal). A queue is used instead
3564         of immediately doing rebaselines since SCM operations can take a while.
3565         It's better to go through lots of tests quickly to mark them as
3566         needing rebaselining and then batch the SCM operations.
3567         
3568         Also adds a simple log where results can be displayed.
3569
3570         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3571         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3572         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3573         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
3574         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3575         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3576
3577 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3578
3579         Reviewed by Oliver Hunt.
3580
3581         Bug 49708 - Stop recompiling functions to regenerate exception info.
3582
3583         Instead only hold info as necessary – keep divot info is the inspector
3584         is enabled, line number info is debugging or profiling, and handler
3585         info for functions with try/catch.
3586
3587         * DumpRenderTree/mac/DumpRenderTree.mm:
3588         (shouldEnableDeveloperExtras):
3589             - always enable the developer tools from DRT, to ensure we
3590               produce rich error messages on JavaScript exceptions.
3591
3592 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
3593
3594         Reviewed by Ojan Vafai.
3595
3596         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3597         https://bugs.webkit.org/show_bug.cgi?id=49702
3598
3599         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3600         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3601
3602 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
3603
3604         Reviewed by Tony Chang.
3605
3606         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
3607
3608         Create the first version of the 'message_broker' package. This
3609         class will encapsulate all of the threading/multiprocessing and
3610         message-sending details for the communication between the
3611         'manager' object and the 'worker' objects. For the moment, it
3612         just holds some routines and tests for logging thread stacks.
3613
3614         There should be no functional changes in this patch, just moving stuff
3615         around.
3616
3617         https://bugs.webkit.org/show_bug.cgi?id=49707
3618
3619         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3620         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
3621         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
3622         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
3623         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3624         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3625
3626 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3627
3628         Reviewed by Adam Roben.
3629
3630         Remove leftover Windows Debug_Internal configurations
3631         https://bugs.webkit.org/show_bug.cgi?id=49758
3632
3633         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3634         * DumpRenderTree/win/DumpRenderTree.vcproj:
3635         * DumpRenderTree/win/ImageDiff.vcproj:
3636         * MiniBrowser/MiniBrowser.vcproj:
3637         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3638         * WebKitAPITest/WebKitAPITest.vcproj:
3639         * WebKitTestRunner/win/InjectedBundle.vcproj:
3640         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3641         * WinLauncher/WinLauncher.vcproj:
3642
3643 2010-11-18  Adam Roben  <aroben@apple.com>
3644
3645         Add three new Windows XP build slaves
3646
3647         Reviewed by Steve Falkenburg.
3648
3649         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
3650         new slaves, and added them to the Windows XP Debug (Tests) builder.
3651
3652 2010-11-18  Daniel Bates  <dbates@rim.com>
3653
3654         Reviewed by Adam Roben.
3655
3656         update-webkit-support-libs should fall back to existing
3657         WebKitSupportLibrary version if there is no internet connectivity
3658         https://bugs.webkit.org/show_bug.cgi?id=49503
3659
3660         Fall back to existing support libraries (if present) when there is
3661         no internet connection.
3662
3663         Currently, update-webkit-support-libs dies with an "out-of-date"
3664         error when there is no internet connection because it cannot
3665         retrieve versioning information from developer.apple.com. Because
3666         update-webkit-support-libs fails, build-webkit fails. Instead,
3667         if there is no internet connection and the support libraries are
3668         present then we should warn the user and exit() with success so
3669         that build-webkit can work without an internet connection.
3670
3671         * Scripts/update-webkit-support-libs:
3672
3673 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3674
3675         Reviewed by Adam Roben.
3676
3677         Debug_Internal Windows configuration is unnecessary, should be removed
3678         https://bugs.webkit.org/show_bug.cgi?id=49753
3679
3680         * DumpRenderTree/win/DumpRenderTree.cpp:
3681         * MiniBrowser/win/stdafx.h:
3682         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3683         * WebKitTestRunner/win/TestControllerWin.cpp:
3684
3685 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3686
3687         Reviewed by Adam Roben.
3688
3689         Clean up vcproj errors
3690         https://bugs.webkit.org/show_bug.cgi?id=49741
3691
3692         * MiniBrowser/MiniBrowser.vcproj:
3693         * WebKitAPITest/WebKitAPITest.vcproj:
3694         * WebKitTestRunner/win/InjectedBundle.vcproj:
3695         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3696
3697 2010-11-18  Hayato Ito  <hayato@chromium.org>
3698
3699         Reviewed by Shinichiro Hamaji.
3700
3701         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
3702         which is caused by r72249.
3703
3704         https://bugs.webkit.org/show_bug.cgi?id=49751
3705
3706         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3707
3708 2010-11-18  Adam Roben  <aroben@apple.com>
3709
3710         Implement layoutTestController.waitForPolicyDelegate on Windows
3711
3712         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
3713
3714         Reviewed by Simon Fraser.
3715
3716         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3717         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
3718         code from LayoutTestControllerMac.mm.
3719
3720 2010-11-18  Hayato Ito  <hayato@c