2011-01-26 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / Tools / ChangeLog
1 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         new-run-webkit-tests: add a "mock DRT" port implementation
6         and a separate class that emulates what we expect the
7         DumpRenderTree behavior to be.
8
9         This will eventually replace port/dryrun.py and allow us to get
10         better test coverage of the new-run-webkit-tests code as well as
11         a reference for what new-run-webkit-tests expects from DRT.
12
13         This is the first attempt at this, and it is pretty bare-boned. It
14         really only has been tested on the 'mac' port (and a little on
15         the 'chromium-mac' port.
16
17         https://bugs.webkit.org/show_bug.cgi?id=53126
18
19         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
20         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
21         * Scripts/webkitpy/layout_tests/port/factory.py:
22
23 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
24
25         Reviewed by Tony Chang.
26
27         Add '--no-timeout' option to Chromium DRT to ease debugging.
28         https://bugs.webkit.org/show_bug.cgi?id=52873
29
30         * DumpRenderTree/chromium/DumpRenderTree.cpp:
31         (main):
32
33 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
34
35         Reviewed by Andreas Kling.
36
37         [Qt] Fix qt_minimal build
38         https://bugs.webkit.org/show_bug.cgi?id=53172
39
40         * QtTestBrowser/locationedit.h:
41
42 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
43
44         Reviewed by Antonio Gomes.
45
46         QtTestBrowser should have a UI Setting to disable plugins
47         https://bugs.webkit.org/show_bug.cgi?id=52408
48         
49         Added a new action item named "Disable Plugins"
50         under the "Settings" menu. 
51
52         * QtTestBrowser/launcherwindow.cpp:
53         (LauncherWindow::createChrome):
54         (LauncherWindow::togglePlugins):
55         * QtTestBrowser/launcherwindow.h:
56
57 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
58
59         Reviewed by Adam Barth.
60
61         Move main CMakeLists.txt into Source directory
62         https://bugs.webkit.org/show_bug.cgi?id=52888
63
64         * Scripts/webkitdirs.pm:
65
66 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
67
68         Reviewed by Eric Seidel.
69
70         Improve label text in submit-to-ews
71         https://bugs.webkit.org/show_bug.cgi?id=53130
72
73         * QueueStatusServer/templates/submittoews.html:
74
75 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
76
77         Reviewed by Antonio Gomes.
78
79         QtTestBrowser should have a UI Settings to prevent loading images
80         https://bugs.webkit.org/show_bug.cgi?id=52409
81         
82         Added a new action item named "DisableAutoLoadImages"
83         under the "Settings" menu 
84
85         * QtTestBrowser/launcherwindow.cpp:
86         (LauncherWindow::createChrome):
87         (LauncherWindow::toggleAutoLoadImages):
88         * QtTestBrowser/launcherwindow.h:
89
90 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
91
92         Reviewed by Tony Chang.
93
94         Minor bug fixes and cleanup for filesystem wrappers, port/* test
95         classes, test_expectations.py. This change adds "test-win" and
96         "test-mac" variants to the test port so that we can better test
97         rebaselining, and adds a MockUser() object for reuse in testing.
98
99         https://bugs.webkit.org/show_bug.cgi?id=53036
100
101         * Scripts/webkitpy/common/system/filesystem.py:
102         * Scripts/webkitpy/common/system/filesystem_mock.py:
103         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
104         * Scripts/webkitpy/layout_tests/port/factory.py:
105         * Scripts/webkitpy/layout_tests/port/base.py:
106         * Scripts/webkitpy/layout_tests/port/test.py:
107         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
108         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
109         * Scripts/webkitpy/tool/mocktool.py:
110
111 2011-01-25  Tony Chang  <tony@chromium.org>
112
113         Reviewed by Dimitri Glazkov.
114
115         [chromium] remove unused layoutTestController callback
116         https://bugs.webkit.org/show_bug.cgi?id=53103
117
118         This method is used by a test_shell_test, but not needed by DRT.
119
120         * DumpRenderTree/chromium/LayoutTestController.cpp:
121         (LayoutTestController::LayoutTestController):
122         * DumpRenderTree/chromium/LayoutTestController.h:
123
124 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
125
126         Reviewed by Andreas Kling.
127
128         [GTK] Remove 64 bits release bot from the buildbot master
129         https://bugs.webkit.org/show_bug.cgi?id=52899
130
131         Removes the 64 bits release slave from the buildbot configuration,
132         so that we can use it as an EWS.
133
134         * BuildSlaveSupport/build.webkit.org-config/config.json:
135
136 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
137
138         Reviewed by Dan Bernstein.
139
140         Implement database quota callback to fix storage tests on WebKit2 bot
141         https://bugs.webkit.org/show_bug.cgi?id=53064
142
143         * WebKitTestRunner/TestController.cpp:
144         (WTR::exceededDatabaseQuota):
145         (WTR::TestController::createOtherPage):
146         (WTR::TestController::initialize):
147
148 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
149
150         Reviewed by Anders Carlsson.
151
152         Use designated temp directory for the database for WebKit2
153         https://bugs.webkit.org/show_bug.cgi?id=53052
154         
155         Adopt the new WK2 API for this.
156
157         * WebKitTestRunner/TestController.cpp:
158         (WTR::TestController::libraryPathForTesting):
159         (WTR::TestController::initialize):
160         * WebKitTestRunner/TestController.h:
161         * WebKitTestRunner/mac/TestControllerMac.mm:
162         (WTR::TestController::platformLibraryPathForTesting):
163         * WebKitTestRunner/qt/TestControllerQt.cpp:
164         (WTR::TestController::platformLibraryPathForTesting):
165         * WebKitTestRunner/win/TestControllerWin.cpp:
166         (WTR::TestController::platformLibraryPathForTesting):
167
168 2011-01-24  Lucas Forschler  <lforschler@apple.com>
169
170         Reviewed by Stephanie Lewis.
171
172         Add a new Leopard test bot.
173
174         * BuildSlaveSupport/build.webkit.org-config/config.json:
175
176 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
177
178         Reviewed by Adam Barth.
179
180         Add EFL Builder to core waterfall
181         https://bugs.webkit.org/show_bug.cgi?id=52704
182
183         Add EFL Builder to the core waterfall again.
184
185         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
186         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
187
188 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
189
190         Reviewed by Tony Chang.
191
192         new-run-webkit-tests fails to start HTTP server if there are proxy settings
193         https://bugs.webkit.org/show_bug.cgi?id=52872
194
195         Force disabling proxy to resolve the problem.
196
197         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
198         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
199
200 2011-01-24  Andreas Kling  <kling@webkit.org>
201
202         Reviewed by Darin Adler.
203
204         check-webkit-style: Update exemptions following Source/ move.
205         https://bugs.webkit.org/show_bug.cgi?id=53017
206
207         * Scripts/webkitpy/style/checker.py:
208         * Scripts/webkitpy/style/checker_unittest.py:
209
210 2011-01-24  Andras Becsi  <abecsi@webkit.org>
211
212         Rubber-stamped by Csaba Osztrogonác.
213
214         [Qt] Move project files into Source
215         https://bugs.webkit.org/show_bug.cgi?id=52891
216
217         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
218
219 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
220
221         Reviewed by Yury Semikhatsky.
222
223         Web Inspector: Find duplicate strings in localizedStrings.js
224
225         https://bugs.webkit.org/show_bug.cgi?id=53005
226
227         * Scripts/check-inspector-strings:
228
229 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
230
231         Reviewed by Andreas Kling.
232
233         [Qt] Regroup MiniBrowser's menubar and add open file action
234         https://bugs.webkit.org/show_bug.cgi?id=53000
235
236         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
237
238         * MiniBrowser/qt/BrowserWindow.cpp:
239         (BrowserWindow::BrowserWindow):
240         (BrowserWindow::openFile):
241         (BrowserWindow::~BrowserWindow):
242         * MiniBrowser/qt/BrowserWindow.h:
243
244 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
245
246         Unreviewed fix after r76496
247
248         [Qt] Move project files into Source
249         https://bugs.webkit.org/show_bug.cgi?id=52891
250
251         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
252         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
253         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
254
255 2011-01-24  Andras Becsi  <abecsi@webkit.org>
256
257         Reviewed by Csaba Osztrogonác.
258
259         [Qt] Move project files into Source
260         https://bugs.webkit.org/show_bug.cgi?id=52891
261
262         * DerivedSources.pro: Renamed from DerivedSources.pro.
263         * DumpRenderTree/qt/DumpRenderTree.pro:
264         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
265         * MiniBrowser/DerivedSources.pro:
266         * MiniBrowser/qt/MiniBrowser.pro:
267         * QtTestBrowser/QtTestBrowser.pro:
268         * Scripts/webkitdirs.pm:
269         * Tools.pro: Added.
270         * WebKitTestRunner/DerivedSources.pro:
271         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
272         * WebKitTestRunner/qt/WebKitTestRunner.pro:
273
274 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
275
276         Reviewed by Dan Bernstein.
277
278         Beefed up --threaded mode to catch even more kinds of errors.
279         https://bugs.webkit.org/show_bug.cgi?id=52971
280
281         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
282         context group to force JSC to mark multiple threads. (This used to be
283         the default, but it changed in SnowLeopard.)
284         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
285         to give threading mistakes more chances to show themselves.
286         (startJavaScriptThreads):
287         (stopJavaScriptThreads):
288
289 2011-01-22  Robert Hogan  <robert@webkit.org>
290
291         Reviewed by Andreas Kling.
292
293         [Qt] Support layoutTestController.addURLToRedirect()
294         https://bugs.webkit.org/show_bug.cgi?id=52956
295
296         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
297         (LayoutTestController::addURLToRedirect):
298         * DumpRenderTree/qt/LayoutTestControllerQt.h:
299
300 2011-01-22  Robert Hogan  <robert@webkit.org>
301
302         Reviewed by Kenneth Rohde Christiansen.
303
304         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
305         https://bugs.webkit.org/show_bug.cgi?id=49802
306
307         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
308         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
309         (WebCore::DumpRenderTree::open):
310
311 2011-01-21  Adam Barth  <abarth@webkit.org>
312
313         Reviewed by Maciej Stachowiak.
314
315         Disable mac_unittest.py that fails on some of the Mac bots
316         https://bugs.webkit.org/show_bug.cgi?id=52947
317
318         As noted in the comment, this test does not appear to be correct
319         because the function this test is testing returns different results
320         depending on which flavor of Mac the test is run on.  This patch
321         disable the test.  Hopefully we can re-enable the test once we've
322         probably insulated the test from its environment.
323
324         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
325
326 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
327
328         Reviewed by Mihai Parparita.
329
330         Fix bug introduced in r76322 that caused NRWT to not actually
331         read the Skipped files properly.
332
333         https://bugs.webkit.org/show_bug.cgi?id=52771
334
335         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
336         * Scripts/webkitpy/layout_tests/port/webkit.py:
337         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
338
339 2011-01-21  Sam Weinig  <sam@webkit.org>
340
341         Reviewed by Geoffrey Sean Garen and Mark Rowe.
342
343         WebKitTestRunner needs the HOME environment variable to be set.
344         <rdar://problem/8896573>
345
346         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
347         it exists.
348
349 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
350
351         Reviewed by Eric Seidel.
352
353         Suppress a few remaining integration tests so that none of the
354         layout_test unit tests ever read from the filesystem or launch
355         subprocesses that aren't part of the unit tests.
356
357         Also fix a minor bug in the printing unit tests that was
358         incorrectly relying on sys.argv.
359
360         https://bugs.webkit.org/show_bug.cgi?id=52863
361
362         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
363         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
364         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
365
366 2011-01-21  Darin Adler  <darin@apple.com>
367
368        Fix Mac build.
369
370         * MiniBrowser/mac/BrowserWindowController.m:
371         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
372
373 2011-01-20  Darin Adler  <darin@apple.com>
374
375         Reviewed by Dan Bernstein.
376
377         WebKit2: Implement showModalDialog
378         https://bugs.webkit.org/show_bug.cgi?id=52855
379
380         This fixes WebKitTestRunner to compile, but more work is probably
381         needed to get it to pass the tests.
382
383         * WebKitTestRunner/TestController.cpp:
384         (WTR::TestController::runModal): Added. Calls through to the
385         platform-specific version of runModal.
386         (WTR::TestController::createOtherPage): Changed to be a private
387         static member function so it can refer to runModal, which is
388         a private static member function.
389         (WTR::TestController::initialize): Pass 0 for the runModal
390         function since we don't need to run the main window modal.
391         I suspect this is wrong and will need to change.
392         * WebKitTestRunner/TestController.h: Added declarations for
393         the functions added above.
394         * WebKitTestRunner/mac/TestControllerMac.mm:
395         (WTR::TestController::runModal): Added. Untested implementation.
396         * WebKitTestRunner/qt/TestControllerQt.cpp:
397         (WTR::TestController::runModal): Added.
398         * WebKitTestRunner/win/TestControllerWin.cpp:
399         (WTR::TestController::runModal): Added.
400
401 2011-01-21  Eric Seidel  <eric@webkit.org>
402
403         Reviewed by Adam Barth.
404
405         Split Host object off from WebKitPatch for easier re-use
406         https://bugs.webkit.org/show_bug.cgi?id=52284
407
408         new-run-webkit-tests and other tools are eventually going to want one of these.
409         Basically you need to inherit from this class if you want to pretend to be a
410         self.tool object for Steps/Commands.
411
412         * Scripts/webkitpy/common/host.py: Added.
413         * Scripts/webkitpy/tool/main.py:
414
415 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
416
417         Reviewed by Adam Barth.
418
419         Disable the tests that start and stop the http server and web
420         server, so that we don't have to worry about port collisions on
421         the bots.
422
423         https://bugs.webkit.org/show_bug.cgi?id=52861
424
425         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
426
427 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
428
429         Reviewed by Eric Seidel.
430
431         nrwt: rewrite google_chrome_unittest to use mock filesystem.
432         
433         https://bugs.webkit.org/show_bug.cgi?id=52772
434         
435         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
436
437 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
438
439         Reviewed by Eric Siedel.
440
441         nrwt: clean up almost all remaining port references, remove
442         unnecessary import clauses. The only remaining references are
443         in places where a mock filesystem makes no sense or can't be
444         used, and in one routine in port/google_chrome_unittest that
445         I'll rewrite in a separate patch.
446
447         https://bugs.webkit.org/show_bug.cgi?id=52771
448
449         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
450         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
451         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
452         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
453         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
454         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
455         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
456         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
457         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
458         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
459         * Scripts/webkitpy/layout_tests/port/gtk.py:
460         * Scripts/webkitpy/layout_tests/port/mac.py:
461         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
462         * Scripts/webkitpy/layout_tests/port/qt.py:
463         * Scripts/webkitpy/layout_tests/port/webkit.py:
464         * Scripts/webkitpy/layout_tests/port/win.py:
465         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
466
467 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
468
469         Reviewed by Mihai Parparita.
470
471         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
472
473         https://bugs.webkit.org/show_bug.cgi?id=52762
474
475         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
476         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
477
478 2011-01-20  Tony Chang  <tony@chromium.org>
479
480         Reviewed by Ojan Vafai.
481
482         [chromium] fix the paths used for the rebaseline tool
483         https://bugs.webkit.org/show_bug.cgi?id=52857
484
485         Some of the bots were renamed so the path to grab the results zip
486         file has changed.
487
488         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
489
490 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
491
492         Reviewed by Tony Chang.
493
494         Fix bug introduced in r72688 / bug 52768 that broke the
495         generation of the output filename links in the results.html
496         output. Apparently none of the unit tests actually checked to
497         make sure the generated links were correct :(
498
499         https://bugs.webkit.org/show_bug.cgi?id=52854
500
501         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
502         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
503
504 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
505
506         Reviewed by Darin Adler.
507
508         https://bugs.webkit.org/show_bug.cgi?id=52849
509         Make window.print work with WebKit2
510
511         * MiniBrowser/mac/BrowserWindowController.m:
512         (-[BrowserWindowController awakeFromNib]):
513         * WebKitTestRunner/TestController.cpp:
514         (WTR::createOtherPage):
515         (WTR::TestController::initialize):
516         Added zeroes to WKPageUIClient structures to avoid build failures.
517
518 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
519
520         Reviewed by Eric Seidel.
521
522         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
523
524         https://bugs.webkit.org/show_bug.cgi?id=52756
525
526         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
527         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
528         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
529         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
530         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
531         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
532
533 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
534
535         Reviewed by Antonio Gomes.
536
537         QtTestBrowser should have a seperate menu for Settings
538         https://bugs.webkit.org/show_bug.cgi?id=52817
539         
540         Added a new menu item named "Settings"
541         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
542
543         * QtTestBrowser/launcherwindow.cpp:
544         (LauncherWindow::createChrome):
545
546 2011-01-20  Sam Weinig  <sam@webkit.org>
547
548         Reviewed by John Sullivan.
549
550         Update update-webkit-localizable-strings with new path to WebKit.
551
552         * Scripts/update-webkit-localizable-strings:
553
554 2011-01-20  James Robinson  <jamesr@chromium.org>
555
556         Reviewed by Darin Fisher.
557
558         Implement mozilla's requestAnimationFrame API
559         https://bugs.webkit.org/show_bug.cgi?id=51218
560
561         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
562
563         * DumpRenderTree/chromium/WebViewHost.cpp:
564         (invokeScheduleComposite):
565         (WebViewHost::scheduleAnimation):
566         (WebViewHost::paintInvalidatedRegion):
567         * DumpRenderTree/chromium/WebViewHost.h:
568
569 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
570
571         Reviewed by Adam Roben.
572
573         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
574         https://bugs.webkit.org/show_bug.cgi?id=42327
575
576         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
577         for methods that take their normal arguments but also a JSContextRef.
578         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
579         for evaluateScriptInIsolatedWorld.
580         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
581         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
582         this call is for an isolated world.
583         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
584         (WTR::worldMap): Helper to create a world map.
585         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
586         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
587         added LayoutTestController API.
588         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
589
590 2011-01-19  Adam Roben  <aroben@apple.com>
591
592         Convert paths in environment variables back to msys-style inside commit-log-editor
593
594         When this script gets run from inside git commit, msys-style paths in the environment will
595         have been turned into Windows-style paths with forward slashes. This screws up functions
596         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
597         the paths back to msys-style before doing anything else.
598
599         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
600         using msysgit's Perl and multiple ChangeLogs have been edited
601
602         Reviewed by David Kilzer.
603
604         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
605         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
606         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
607
608 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
609
610         [Win] Unreviewed build fix after r76248.
611
612         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
613
614 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
615
616         Reviewed by Csaba Osztrogonác.
617
618         Refactoring of the custom allocation framework
619         https://bugs.webkit.org/show_bug.cgi?id=49897
620
621         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
622         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
623         equivalent macro implementation at the necessary places.
624 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
625
626         Unreviewed. 
627
628         Adding myself to committers.py.
629
630         * Scripts/webkitpy/common/config/committers.py:
631
632 2011-01-20  Adam Barth  <abarth@webkit.org>
633
634         Reviewed by Tony Chang.
635
636         Chromium builders don't delete unversioned directories when DEPS change
637         https://bugs.webkit.org/show_bug.cgi?id=52745
638
639         If we pass this option to gclient sync, gclient will delete directories
640         that are no longer part of DEPS instead of leaving them around to
641         confuse us later.  Apparently, the downstream buildbots use this option
642         already.
643
644         * Scripts/update-webkit-chromium:
645
646 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
647
648         Unreviewed, build fix - I pulled this patch in to fix an issue
649         revealed by r76195 running on some new bots). Also fix a couple
650         of other issues revealed in testing.
651
652         nrwt: remove fs refs from layout_package/json*
653
654         https://bugs.webkit.org/show_bug.cgi?id=52754
655
656         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
657         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
658         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
659         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
660         * Scripts/webkitpy/layout_tests/port/base.py:
661
662 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
663
664         Unreviewed, build fix.
665
666         Fix a couple of minor bugs discovered while bringing up new bots
667         for testing.
668
669         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
670         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
671
672 2011-01-19  James Robinson  <jamesr@chromium.org>
673
674         Unreviewed, rolling out r76194.
675         http://trac.webkit.org/changeset/76194
676         https://bugs.webkit.org/show_bug.cgi?id=51218
677
678         Caused mysterious compile failure on the chromium win
679         build.webkit.org bots
680
681         * DumpRenderTree/chromium/WebViewHost.cpp:
682         (WebViewHost::paintInvalidatedRegion):
683         * DumpRenderTree/chromium/WebViewHost.h:
684
685 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
686
687         Reviewed by Mihai Parparita.
688
689         remove fs refs from test_runner, dump_render_tree_thread
690
691         https://bugs.webkit.org/show_bug.cgi?id=52753
692
693         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
694         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
695         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
696         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
697
698 2011-01-19  James Robinson  <jamesr@chromium.org>
699
700         Reviewed by Darin Fisher.
701
702         Implement mozilla's requestAnimationFrame API
703         https://bugs.webkit.org/show_bug.cgi?id=51218
704
705         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
706
707         * DumpRenderTree/chromium/WebViewHost.cpp:
708         (invokeScheduleComposite):
709         (WebViewHost::scheduleAnimation):
710         (WebViewHost::paintInvalidatedRegion):
711         * DumpRenderTree/chromium/WebViewHost.h:
712
713 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
714
715         Unreviewed, build fix.
716
717         Fix a few incorrect "self._filesystem" references introduced in
718         r76184.
719
720         * Scripts/webkitpy/layout_tests/port/chromium.py:
721         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
722
723 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
724
725         Reviewed by Mihai Parparita.
726
727         add a .sep property, abspath(), isabs(), mtime(), and
728         open_text_file_for_writing() to filesystem modules. Some of
729         these properties are not needed in this patch but will be needed
730         in subsequent patches (I'm doing this to avoid having to track
731         multiple versions of a single file).
732
733         Also, change most of the port/* modules to use the filesystem
734         objects instead of referencing the filesystem directly.
735
736         https://bugs.webkit.org/show_bug.cgi?id=52748
737
738         * Scripts/webkitpy/common/system/filesystem.py:
739         * Scripts/webkitpy/common/system/filesystem_mock.py:
740         * Scripts/webkitpy/layout_tests/port/__init__.py:
741         * Scripts/webkitpy/layout_tests/port/base.py:
742         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
743         * Scripts/webkitpy/layout_tests/port/chromium.py:
744         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
745         * Scripts/webkitpy/layout_tests/port/config.py:
746         * Scripts/webkitpy/layout_tests/port/test.py:
747         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
748
749 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
750
751         Reviewed by Anders Carlsson.
752
753         If resetting between tests times out, treat it as a WebProcess crash
754         https://bugs.webkit.org/show_bug.cgi?id=52757
755
756         * WebKitTestRunner/TestController.cpp:
757         (WTR::TestController::runTest):
758
759 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
760
761         Reviewed by Darin Adler.
762
763         https://bugs.webkit.org/show_bug.cgi?id=52739
764         Make it possible for a WebKit2 client to print headers and footers
765
766         Added dummy implementations for new printing UIClient calls.
767
768         * MiniBrowser/mac/BrowserWindowController.m:
769         (-[BrowserWindowController awakeFromNib]):
770         * WebKitTestRunner/TestController.cpp:
771         (WTR::createOtherPage):
772         (WTR::TestController::initialize):
773
774 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
775
776         Reviewed by Ojan Vafai.
777
778         Change webkitpy/layout_tests/port/test.py to use the
779         in-memory filesystem for cleaner unit testing. This
780         change allows us to kill a lot of code that was
781         specific to the test port, at the cost of being a
782         little less clear about how things would work if
783         you didn't have a filesystem.
784
785         https://bugs.webkit.org/show_bug.cgi?id=52605
786
787         * Scripts/webkitpy/layout_tests/port/test.py:
788
789 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
790
791         Unreviewed, build fix.
792
793         Fix test failure caused by committing attachment 79368 instead
794         of attachment 79461 on bug 52604.
795
796         * Scripts/webkitpy/common/system/filesystem_mock.py:
797
798 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
799
800         Reviewed by Mihai Parparita.
801
802         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
803         unit testing. os.walk() is too much of a hassle to implement on
804         top of the in-memory mock filesystem and adding the necessary
805         interface to files_under() gives clients a cleaner API anyway
806         (for this particular usage model).
807
808         https://bugs.webkit.org/show_bug.cgi?id=52691
809
810         * Scripts/webkitpy/common/system/filesystem.py:
811         * Scripts/webkitpy/common/system/filesystem_mock.py:
812         * Scripts/webkitpy/layout_tests/port/test_files.py:
813         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
814
815 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
816
817         Reviewed by Tony Chang.
818
819         Change more modules in the layout-tests code to use the
820         filesystem wrapper for cleaner unit testing.
821
822         This patch also adds the glob() wrapper to the filesystem
823         abstraction.
824         
825         https://bugs.webkit.org/show_bug.cgi?id=52604
826
827         * Scripts/webkitpy/layout_tests/port/test_files.py:
828         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
829         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
830         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
831         * Scripts/webkitpy/common/system/filesystem.py:
832         * Scripts/webkitpy/common/system/filesystem_mock.py:
833
834 2011-01-19  Levi Weintraub  <leviw@chromium.org>
835
836         Unreviewed.
837
838         Updating my email addresses and irc nick.
839
840         * Scripts/webkitpy/common/config/committers.py:
841
842 2011-01-19  Tony Chang  <tony@chromium.org>
843
844         Reviewed by Mihai Parparita.
845
846         [chromium] [linux] if check-sys-deps fails, output the failure reason
847         https://bugs.webkit.org/show_bug.cgi?id=52671
848
849         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
850             error handler functions.
851         * Scripts/webkitpy/layout_tests/port/chromium.py:
852             output the error text from --check-sys-deps
853         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
854
855 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
856
857         Reviewed by Andreas Kling.
858
859         [Qt] QtTestBrowser crashes when closing if Facebook is opened
860         https://bugs.webkit.org/show_bug.cgi?id=52554
861         
862         QtNetworkAccessManager is created in a thread and set as
863         member variable in QWebPage. When the thread is destroyed
864         the object is still used. So fix will set the object to
865         NULL once the thread is destroyed.
866
867         * QtTestBrowser/launcherwindow.cpp:
868         (LauncherWindow::~LauncherWindow):
869
870 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
871
872         Rubber stamped by Csaba Osztrogonac
873
874         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
875
876 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
877
878         Reviewed by Tony Chang.
879
880         new-run-webkit-tests: add a --build-directory command line argument
881
882         Official Google Chrome builds use a non-standard build directory
883         location. This patch adds a --build-directory argument that
884         allows that location to be specified on the command line. Only
885         Chromium-based builds will use this flag for now, but anyone can
886         in the future.
887
888         There are no unit tests for this since it's difficult to test
889         until mock filesystems are fully supported in the code. This was
890         tested by hand for now.
891
892         https://bugs.webkit.org/show_bug.cgi?id=52694
893
894         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
895         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
896         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
897         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
898
899 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
900
901         Not reviewed. Bot fix.
902
903         Remove an inadvertently committed debugging print.
904
905         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
906         (LayoutTestController::notifyDone):
907
908 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
909
910         Reviewed by Sam Weinig.
911
912         WebKitTestRunner should track loading more like DumpRenderTree
913         https://bugs.webkit.org/show_bug.cgi?id=52692
914
915         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
916         This makes some tests that call notifyDone multiple times pass.
917         
918         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
919         (WTR::InjectedBundle::InjectedBundle):
920         (WTR::InjectedBundle::done):
921         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
922         (WTR::InjectedBundle::topLoadingFrame):
923         (WTR::InjectedBundle::setTopLoadingFrame):
924         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
925         (WTR::InjectedBundlePage::InjectedBundlePage):
926         (WTR::InjectedBundlePage::stopLoading):
927         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
928         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
929         (WTR::InjectedBundlePage::didFinishLoadForFrame):
930         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
931         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
932         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
933         (WTR::LayoutTestController::notifyDone):
934         * WebKitTestRunner/TestController.cpp:
935         (WTR::TestController::didReceiveMessageFromInjectedBundle):
936
937 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
938
939         Reviewed by Kent Tamura.
940
941         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
942         https://bugs.webkit.org/show_bug.cgi?id=52678
943         
944         Update path now that WebKit is inside Source.
945
946         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
947
948 2011-01-18  Robert Hogan  <robert@webkit.org>
949
950         Reviewed by Simon Hausmann.
951
952         [Qt] http/tests/incremental/slow-utf8-text.pl fails
953         https://bugs.webkit.org/show_bug.cgi?id=44282
954
955         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
956         (WebCore::DumpRenderTree::dump):
957
958 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
959
960         Reviewed by Mihai Parparita.
961
962         Fix a small race condition that could cause the unit tests for
963         new-run-webkit-tests to fail in a multithreaded environment.
964         There was a small window in the code where one thread would
965         check to see if a thread had raised an exception, do something,
966         and then check to see if the thread was alive. If the other
967         thread raised an exception and exited in between these two
968         steps, the exception would be lost. Flipping the order of the
969         two checks fixes the race, since we will now always check for an
970         exception on the thread before exiting.
971
972         https://bugs.webkit.org/show_bug.cgi?id=51579
973
974         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
975
976 2011-01-18  Eric Seidel  <eric@webkit.org>
977
978         Reviewed by Adam Barth.
979
980         commit-queue dies when test archiving fails
981         https://bugs.webkit.org/show_bug.cgi?id=52617
982
983         I looked at the machine and it had 10 archives already
984         thus find_unused_name was returning None.  I've upped
985         the limit to 100 (per bug) and tested the case where
986         find_unused_name returns None (making archive return None).
987
988         * Scripts/webkitpy/common/system/workspace.py:
989         * Scripts/webkitpy/common/system/workspace_unittest.py:
990         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
991         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
992         * Scripts/webkitpy/tool/commands/queues.py:
993
994 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
995
996         Reviewed by Ojan Vafai.
997
998         Update rebaseline-chromium-webkit-tests unit tests to use a mock
999         filesystem. Also fix a couple of "with" statements missed by
1000         r76050.
1001
1002         https://bugs.webkit.org/show_bug.cgi?id=52487
1003
1004         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1005
1006 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1007
1008         Reviewed by Martin Robinson.
1009
1010         [Gtk] Build fixes for gtk3 build
1011         https://bugs.webkit.org/show_bug.cgi?id=52648
1012
1013         * DumpRenderTree/gtk/EventSender.cpp:
1014         (beginDragWithFilesCallback):
1015
1016 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1017
1018         Reviewed by Mihai Parparita.
1019
1020         Update rebaseline-chromium-webkit-tests to use filesystem objects
1021         instead of direct references to os.path, shutil, tempfile, etc.
1022
1023         This patch doesn't change anything, but will allow subsequent
1024         patches to change the unit tests to no longer use the real
1025         filesystem.
1026
1027         This patch adds a bunch more methods to the filesystem object as
1028         well.
1029
1030         https://bugs.webkit.org/show_bug.cgi?id=52482
1031
1032         * Scripts/webkitpy/common/system/filesystem.py:
1033         * Scripts/webkitpy/common/system/filesystem_mock.py:
1034         * Scripts/webkitpy/tool/commands/queues.py:
1035         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1036         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1037
1038 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1039
1040         Reviewed by Mihai Parparita.
1041
1042         new-run-webkit-tests shouldn't crash when you try to run a
1043         directory containing only skipped files.
1044
1045         https://bugs.webkit.org/show_bug.cgi?id=52478
1046         
1047         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1048         * Scripts/webkitpy/layout_tests/port/test.py:
1049         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1050
1051 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1052
1053         Reviewed by Gustavo Noronha Silva.
1054
1055         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1056         https://bugs.webkit.org/show_bug.cgi?id=40833
1057
1058         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1059         GTK+ event sender.
1060         (dragWithFilesDragDataGetCallback): Added.
1061         (dragWithFilesDragEndCallback): Added.
1062         (beginDragWithFilesCallback): Added.
1063
1064 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1065
1066         Reviewed by Adam Barth.
1067
1068         ews: Add additional watcher to efl ews
1069         https://bugs.webkit.org/show_bug.cgi?id=52613
1070
1071         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1072
1073         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1074
1075 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1076
1077         Reviewed by Alexey Proskuryakov.
1078
1079         Fix some headers with missing or misspelled #ifndef guards
1080         https://bugs.webkit.org/show_bug.cgi?id=52545
1081
1082         * DumpRenderTree/chromium/TestEventPrinter.h:
1083         * DumpRenderTree/chromium/WebPreferences.h:
1084
1085 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1086
1087         Reviewed by Anders Carlsson.
1088
1089         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1090         navigating back to an unreachable URL
1091         https://bugs.webkit.org/show_bug.cgi?id=52388
1092
1093         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1094
1095         * DumpRenderTree/LayoutTestController.cpp:
1096         (queueLoadHTMLStringCallback):
1097         (LayoutTestController::queueLoadHTMLString):
1098         (LayoutTestController::queueLoadAlternateHTMLString):
1099         * DumpRenderTree/LayoutTestController.h:
1100
1101         * DumpRenderTree/WorkQueueItem.h:
1102         (LoadHTMLStringItem::LoadHTMLStringItem):
1103
1104         * DumpRenderTree/chromium/LayoutTestController.cpp:
1105         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1106         (WorkItemLoadHTMLString::run):
1107         (LayoutTestController::queueLoadHTMLString):
1108
1109         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1110         (LoadHTMLStringItem::invoke):
1111         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1112         (LoadHTMLStringItem::invoke):
1113         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1114         (LoadHTMLStringItem::invoke):
1115
1116 2011-01-17  Dan Bernstein  <mitz@apple.com>
1117
1118         Rubber-stamped by Mark Rowe.
1119
1120         Update xcodeproj svn:ignore to include xcuserdata.
1121
1122         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1123         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1124         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1125         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1126         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1127
1128 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1129
1130         Unreviewed fix after r75908.
1131
1132         Move WebKit into Source
1133         https://bugs.webkit.org/show_bug.cgi?id=52530
1134
1135         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1136
1137 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1138
1139         Unreviewed.
1140
1141         Remove accidentally committed debug printing after r75908.
1142
1143         * Scripts/webkitdirs.pm:
1144
1145 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1146
1147         Unreviewed.
1148
1149         Add myself to committers list
1150         https://bugs.webkit.org/show_bug.cgi?id=52566
1151
1152         * Scripts/webkitpy/common/config/committers.py:
1153
1154 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1155
1156         Reviewed by Jeremy Orlow.
1157
1158         GeolocationController should call stopUpdating on destruction
1159         https://bugs.webkit.org/show_bug.cgi?id=52216
1160
1161         fast/dom/Geolocation/window-close-crash.html requires that a
1162         Geolocation watch be started in a secondary window. Consequently,
1163         we need to allow geolocation permission and provide a mock
1164         geolocation position for the secondary window's
1165         GeolocationClientMock.
1166
1167         * DumpRenderTree/chromium/LayoutTestController.cpp:
1168         (LayoutTestController::setGeolocationPermission):
1169         (LayoutTestController::setMockGeolocationPosition):
1170         (LayoutTestController::setMockGeolocationError):
1171         * DumpRenderTree/chromium/TestShell.h:
1172         (TestShell::windowList):
1173
1174 2011-01-16  Adam Barth  <abarth@webkit.org>
1175
1176         Update more include paths to reflect WebKit move.
1177
1178         * DumpRenderTree/chromium/EventSender.cpp:
1179         (EventSender::keyDown):
1180         (EventSender::needsShiftModifier):
1181         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1182         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1183
1184 2011-01-16  Kent Tamura  <tkent@chromium.org>
1185
1186         Unreviewed, Chromium build fix.
1187
1188         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1189
1190 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1191
1192         Build fix for GTK+ after source directory movement.
1193
1194         * GNUmakefile.am: Correct include paths.
1195
1196 2011-01-16  Adam Barth  <abarth@webkit.org>
1197
1198         Teach svn-apply about WebKit move.
1199
1200         * Scripts/VCSUtils.pm:
1201
1202 2011-01-16  Adam Barth  <abarth@webkit.org>
1203
1204         Rubber-stamped by Eric Seidel.
1205
1206         Move WebKit into Source
1207         https://bugs.webkit.org/show_bug.cgi?id=52530
1208
1209         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1210         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1211         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1212         * DumpRenderTree/qt/GCControllerQt.cpp:
1213         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1214         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1215         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1216         * DumpRenderTree/wscript:
1217         * QtTestBrowser/launcherwindow.h:
1218         * Scripts/build-webkit:
1219         * Scripts/webkitdirs.pm:
1220
1221 2011-01-15  Adam Barth  <abarth@webkit.org>
1222
1223         Teach svn-apply about WebKit2 move.
1224
1225         * Scripts/VCSUtils.pm:
1226
1227 2011-01-15  Adam Barth  <abarth@webkit.org>
1228
1229         Rubber-stamped by Eric Seidel.
1230
1231         Move WebKit2 into Source
1232         https://bugs.webkit.org/show_bug.cgi?id=52438
1233
1234         * MiniBrowser/qt/MiniBrowser.pro:
1235         * Scripts/build-webkit:
1236         * Scripts/do-file-rename:
1237         * Scripts/do-webcore-rename:
1238         * Scripts/test-webkitpy:
1239         * Scripts/webkitdirs.pm:
1240         * Scripts/webkitpy/style/checker.py:
1241         * WebKitTestRunner/DerivedSources.pro:
1242         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1243         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1244
1245 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1246
1247         Reviewed by David Levin.
1248
1249         [chromium] remove obsolete createView method
1250         https://bugs.webkit.org/show_bug.cgi?id=52437
1251
1252         * DumpRenderTree/chromium/WebViewHost.cpp:
1253         (WebViewHost::createView):
1254         * DumpRenderTree/chromium/WebViewHost.h:
1255
1256 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1257
1258         Reviewed by Geoff Garen.
1259
1260         ShouldLoadResourceForFrame should use strings, not URLs.
1261         https://bugs.webkit.org/show_bug.cgi?id=52476
1262
1263         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1264         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1265         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1266
1267 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1268
1269         Reviewed by David Levin.
1270
1271         Add Tony Gentilcore as a reviewer
1272         https://bugs.webkit.org/show_bug.cgi?id=52480
1273
1274         * Scripts/webkitpy/common/config/committers.py:
1275
1276 2011-01-14  David Levin  <levin@chromium.org>
1277
1278         Reviewed by Eric Seidel.
1279
1280         check-webkit-style: _FunctionState should keep track of where the function name starts.
1281         https://bugs.webkit.org/show_bug.cgi?id=52454
1282
1283         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1284         _FunctionState and logic for setting it correctly.
1285         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1286
1287 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1288
1289         Reviewed by David Levin.
1290
1291         Add support to DumpRenderTree to use the GPU rather than software renderer
1292         https://bugs.webkit.org/show_bug.cgi?id=52333
1293
1294         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1295         (main):
1296         * Scripts/webkitpy/layout_tests/port/chromium.py:
1297         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1298
1299 2011-01-14  Tony Chang  <tony@chromium.org>
1300
1301         Reviewed by Kent Tamura.
1302
1303         [chromium] update fonts.conf to fix 6 linux tests in drt
1304         https://bugs.webkit.org/show_bug.cgi?id=52411
1305
1306         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1307             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1308
1309 2011-01-14  Eric Seidel  <eric@webkit.org>
1310
1311         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1312
1313         Reviewed by Adam Barth.
1314
1315         Fix when running Tools/Scripts/check-webkit-style without arguments.
1316         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1317
1318         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1319         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1320
1321 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1322
1323         Reviewed by David Levin.
1324
1325         Store the tempdir object in a variable so it doesn't get deleted too early.
1326         https://bugs.webkit.org/show_bug.cgi?id=51875
1327
1328         * Scripts/update-webkit-auxiliary-libs:
1329         * Scripts/update-webkit-support-libs:
1330
1331 2011-01-14  Eric Seidel  <eric@webkit.org>
1332
1333         Unreviewed.  Make it work in python 2.5.
1334
1335         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1336         https://bugs.webkit.org/show_bug.cgi?id=49158
1337
1338         * Scripts/webkitpy/common/checkout/api_unittest.py:
1339
1340 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1341
1342         Unreviewed, rolling out r75774.
1343         http://trac.webkit.org/changeset/75774
1344         https://bugs.webkit.org/show_bug.cgi?id=52431
1345
1346         gtk builds were broken (Requested by loislo2 on #webkit).
1347
1348         * Scripts/webkitpy/common/checkout/scm.py:
1349
1350 2011-01-14  David Levin  <levin@chromium.org>
1351
1352         Reviewed by Shinichiro Hamaji.
1353
1354         check-webkit-style: _FunctionState should detect pure functions.
1355         https://bugs.webkit.org/show_bug.cgi?id=52428
1356
1357         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1358         is a pure virtual function.
1359         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1360         virtual functions are correctly detected.
1361
1362 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1363
1364         Reviewed by Yury Semikhatsky.
1365
1366         Just small fix for problem with check-webkit-style.
1367         It just didn't work for this patch.
1368         Old code can't concatenate a list of strings with None.
1369
1370         * Scripts/webkitpy/common/checkout/scm.py:
1371
1372 2011-01-13  David Levin  <levin@chromium.org>
1373
1374         Reviewed by Shinichiro Hamaji.
1375
1376         check-webkit-style: _FunctionState should use Position to know where items are.
1377         https://bugs.webkit.org/show_bug.cgi?id=52424
1378
1379         * Scripts/webkitpy/style/checkers/cpp.py:
1380         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1381         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1382         did some minor clean-up.
1383         (*): Other changes are simply about converting to use the Position's in_FunctionState
1384         instead of line numbers.
1385         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1386         to verify the positions stored in _FunctionState.
1387
1388 2011-01-13  Eric Seidel  <eric@webkit.org>
1389
1390         Reviewed by David Levin.
1391
1392         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1393         https://bugs.webkit.org/show_bug.cgi?id=49158
1394
1395         This is not the most elegant, but it is a very safe fix to this bug.
1396         One advantage of catching ScriptError like this instead of adding a
1397         new added_or_modified_files or fixing all changed_files callers
1398         to use a more specific change_files variant, is that we catch
1399         all kinds of ScriptErrors which might cause our (non-essential)
1400         suggest-reviewers code to fail out.  This should make passing
1401         --suggest-reviewers to webkit-patch upload much more robust
1402         and may even make it possible for us to make it default.
1403
1404         The root of the problem here is that SCM.changed_files includes
1405         deleted ChangeLog paths (from moves, etc) which then when we ask
1406         SVN/Git for the contents of the file at that revision, the command
1407         errors out and Executive.run_command raises a ScriptError.
1408
1409         In the future we might fix this differently by making all current
1410         callers of chagned_files use a more specific method for requesting
1411         what types of changes they're interested in (adds, modifies, deletes, etc.)
1412
1413         * Scripts/webkitpy/common/checkout/api.py:
1414         * Scripts/webkitpy/common/checkout/api_unittest.py:
1415
1416 2011-01-13  Dan Bernstein  <mitz@apple.com>
1417
1418         Reviewed by Alexey Proskuryakov.
1419
1420         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1421         https://bugs.webkit.org/show_bug.cgi?id=52419
1422
1423         Allow to further control the behavior of the willSendRequest delegate callback by making it
1424         set a different URL in the new request.
1425
1426         * DumpRenderTree/LayoutTestController.cpp:
1427         (addURLToRedirectCallback): Added.
1428         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1429         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1430         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1431         * DumpRenderTree/LayoutTestController.h:
1432         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1433         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1434         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1435         change the URL in the new request to the redirect destination.
1436
1437 2011-01-13  Eric Seidel  <eric@webkit.org>
1438
1439         Reviewed by Mihai Parparita.
1440
1441         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1442         https://bugs.webkit.org/show_bug.cgi?id=52416
1443
1444         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1445         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1446
1447         I also added FIXMEs about the changed_files returning deleted files problem
1448         which is causing the other most common exception for suggest-reviewers
1449         (and is probably breaking sheriff-bots blame detection).
1450
1451         * Scripts/webkitpy/common/checkout/api.py:
1452         * Scripts/webkitpy/common/checkout/api_unittest.py:
1453         * Scripts/webkitpy/common/checkout/scm.py:
1454
1455 2011-01-13  Eric Seidel  <eric@webkit.org>
1456
1457         Reviewed by Adam Barth.
1458
1459         results archives from commit-queue are too large to upload
1460         https://bugs.webkit.org/show_bug.cgi?id=52405
1461
1462         * Scripts/webkitpy/common/system/filesystem.py:
1463         * Scripts/webkitpy/common/system/filesystem_mock.py:
1464         * Scripts/webkitpy/tool/commands/queues.py:
1465
1466 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1467
1468         Reviewed by Martin Robinson.
1469
1470         [gtk] Zero-sized font does not yet work
1471         https://bugs.webkit.org/show_bug.cgi?id=49793
1472
1473         Set minimum-font-size to 0 for the DRT.
1474
1475         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1476         (resetDefaultsToConsistentValues):
1477
1478 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1479
1480         Reviewed by Darin Adler.
1481
1482         Make old-run-webkit-tests more robust on buildbots
1483         https://bugs.webkit.org/show_bug.cgi?id=52364
1484
1485         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1486
1487 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1488
1489         Reviewed by Darin Adler.
1490
1491         Make old-run-webkit-tests more robust on buildbots
1492         https://bugs.webkit.org/show_bug.cgi?id=52364
1493
1494         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1495
1496 2011-01-13  Tony Chang  <tony@chromium.org>
1497
1498         Reviewed by Kent Tamura.
1499
1500         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1501         https://bugs.webkit.org/show_bug.cgi?id=52332
1502
1503         Forked Info.plist is not longer needed.
1504
1505         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1506
1507 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1508
1509         Reviewed by Timothy Hatcher.
1510
1511         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1512         to be passed directly to WebInspector.UIString
1513
1514         https://bugs.webkit.org/show_bug.cgi?id=52365
1515
1516         * Scripts/check-inspector-strings:
1517
1518 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1519
1520         Unreviewed, rolling out r74881.
1521         http://trac.webkit.org/changeset/74881
1522         https://bugs.webkit.org/show_bug.cgi?id=52357
1523
1524         The EFL builder has been red for days (Requested by abarth on
1525         #webkit).
1526
1527         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1528         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1529
1530 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1531
1532         Reviewed by David Levin.
1533
1534         Add beforeunload support to WebKitTestRunner
1535         https://bugs.webkit.org/show_bug.cgi?id=52353
1536         
1537         This makes a number of currently failing tests pass.
1538
1539         * WebKitTestRunner/TestController.cpp:
1540         (WTR::runBeforeUnloadConfirmPanel):
1541         (WTR::createOtherPage):
1542         (WTR::TestController::initialize):
1543
1544 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1545
1546         Reviewed by Sam Weinig.
1547
1548         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1549         https://bugs.webkit.org/show_bug.cgi?id=52330
1550
1551         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1552         a web process crash.
1553         * WebKitTestRunner/TestController.cpp:
1554         (WTR::TestController::initialize): Set up a processDidCrash
1555         callback.
1556         (WTR::TestController::processDidCrash): Report that the Web process
1557         crashed.
1558         * WebKitTestRunner/TestController.h:
1559
1560 2011-01-12  David Levin  <levin@chromium.org>
1561
1562         Reviewed by Shinichiro Hamaji.
1563
1564         check-webkit-style -- close_expression function doesn't work correctly.
1565         https://bugs.webkit.org/show_bug.cgi?id=52272
1566
1567         * Scripts/webkitpy/style/checkers/cpp.py:
1568         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1569         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1570         generally useful (for upcoming code changes).
1571         (close_expression): Changed to use Position for input and output.
1572         Also, fixed many bugs such as only working correctly for parenthesis,
1573         not working correctly if given an offset in a line and not finding
1574         the real closing element if there were multiple closing elements in
1575         the same line.
1576         (detect_functions): Adjusted due to the change in arguments for
1577         close_expression.
1578         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1579         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1580         two positions are the same.
1581         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1582         (CppStyleTest.test_close_expression): Added tests to catch the issues
1583         that were fixed.
1584
1585 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1586
1587         Unreviewed, rolling out r75576.
1588         http://trac.webkit.org/changeset/75576
1589         https://bugs.webkit.org/show_bug.cgi?id=52304
1590
1591         broke rebaseline-chromium-webkit-test (Requested by thakis on
1592         #webkit).
1593
1594         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1595         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1596         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1597         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1598         * Scripts/webkitpy/layout_tests/port/base.py:
1599         * Scripts/webkitpy/layout_tests/port/chromium.py:
1600         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1601         * Scripts/webkitpy/layout_tests/port/test.py:
1602         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1603         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1604         * Scripts/webkitpy/style/checkers/test_expectations.py:
1605         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1606
1607 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1608
1609         Reviewed by Darin Adler.
1610
1611         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1612         https://bugs.webkit.org/show_bug.cgi?id=52307
1613
1614         * Scripts/old-run-webkit-tests:
1615
1616 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1617
1618         Reviewed by Martin Robinson.
1619
1620         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1621         https://bugs.webkit.org/show_bug.cgi?id=50867
1622
1623         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1624         TestNetscapePlugin.cpp 
1625
1626         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1627         * Scripts/webkitdirs.pm:
1628
1629 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1630
1631         Reviewed by Pavel Feldman.
1632
1633         Add check-inspector-strings script.
1634
1635         https://bugs.webkit.org/show_bug.cgi?id=52295
1636
1637         * Scripts/check-inspector-strings: Added.
1638
1639 2011-01-12  Adam Roben  <aroben@apple.com>
1640
1641         Advertise the .testnetscape file extension on Windows
1642
1643         Fixes <http://webkit.org/b/52298>
1644         plugins/no-mime-with-valid-extension.html fails on Windows
1645
1646         Reviewed by Dan Bernstein.
1647
1648         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1649         FileExtents field to map the .testnetscape file extension to the
1650         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1651
1652 2011-01-12  Adam Barth  <abarth@webkit.org>
1653
1654         Reviewed by Eric Seidel.
1655
1656         Make webkit-patch support subdirectories for SVN checkouts
1657         https://bugs.webkit.org/show_bug.cgi?id=52261
1658
1659         os.relpath does not exist on Python 2.5, so we need to call our version
1660         of the API.
1661
1662         * Scripts/webkitpy/common/checkout/scm.py:
1663
1664 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1665
1666         Reviewed by Eric Seidel.
1667
1668         Close additional pages opened during a test once the test completes.
1669         https://bugs.webkit.org/show_bug.cgi?id=52276
1670
1671         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1672         (WTR::InjectedBundle::done):
1673
1674 2011-01-11  David Levin  <levin@chromium.org>
1675
1676         Reviewed by Eric Seidel.
1677
1678         Errors should be separated from the command line in bot messages.
1679         https://bugs.webkit.org/show_bug.cgi?id=52275
1680
1681         * Scripts/webkitpy/common/system/executive.py:
1682         (ScriptError.message_with_output): Added a newline to separate the command
1683         line from the errors.
1684         * Scripts/webkitpy/common/system/executive_unittest.py:
1685         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1686         paths in message_with_output.
1687
1688 2011-01-11  Eric Seidel  <eric@webkit.org>
1689
1690         Unreviewed.
1691
1692         commit-queue should know how to upload archived results (for test flakes or general failures)
1693         https://bugs.webkit.org/show_bug.cgi?id=52048
1694
1695         The zips are mostly empty due to forgetting -r.
1696         Expected diffs were not being pulled from the archive due
1697         to the archive having longer paths than I realized.
1698
1699         * Scripts/webkitpy/common/system/workspace.py:
1700         * Scripts/webkitpy/common/system/workspace_unittest.py:
1701         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1702         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1703
1704 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1705
1706         Reviewed by Ojan Vafai.
1707
1708         The current modifier parsing code in test_expectations is
1709         fragile and hard-coded, so it's not easy to understand the logic
1710         or easily add new types of modifiers (like GPU vs. CPU testing
1711         for graphics tests, or 32-bit vs. 64-bit differences).
1712
1713         This is the first of two patches that will add in more generic
1714         support and then eliminate the GPU-specific test expectations
1715         files for Chromium.
1716
1717         This patch adds two standalone objects for handling modifiers. The
1718         rules for interpreting modifiers, precedence, and conflicts are
1719         given in the docstring to the ModifierMatcher class, which
1720         returns ModifierMatchResult objects.
1721         
1722         This patch also adds routines to the Port interface and a
1723         default set of values in the base object, in order to obtain the
1724         values needed on a given test run. These values are then passed
1725         to the expectation parser. This also allows us to clean up the
1726         logic used to lint all of the different configurations in a
1727         single test_expectations.txt file.
1728
1729         The next patch will merge in the separate GPU expectations file.
1730
1731         https://bugs.webkit.org/show_bug.cgi?id=51222
1732
1733         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1734         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1735         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1736         * Scripts/webkitpy/layout_tests/port/base.py:
1737         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1738         * Scripts/webkitpy/layout_tests/port/chromium.py:
1739         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1740         * Scripts/webkitpy/layout_tests/port/test.py:
1741         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1742         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1743
1744 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1745
1746         Reviewed by Adam Barth.
1747
1748         Make webkit-patch support subdirectories for SVN checkouts
1749         https://bugs.webkit.org/show_bug.cgi?id=52261
1750
1751         * Scripts/webkitpy/common/checkout/scm.py:
1752         * Scripts/webkitpy/style_references.py:
1753         * Scripts/webkitpy/tool/main.py:
1754         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1755
1756 2011-01-11  Eric Seidel  <eric@webkit.org>
1757
1758         Unreviewed.
1759
1760         commit-queue should know how to upload archived results (for test flakes or general failures)
1761         https://bugs.webkit.org/show_bug.cgi?id=52048
1762
1763         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1764         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1765
1766         * Scripts/webkitpy/common/system/workspace.py:
1767         * Scripts/webkitpy/common/system/workspace_unittest.py:
1768         * Scripts/webkitpy/tool/commands/queues.py:
1769
1770 2011-01-11  Sam Weinig  <sam@webkit.org>
1771
1772         Roll r75474 back in.
1773
1774 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1775
1776         Reviewed by Kenneth Rohde Christiansen.
1777
1778         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1779         https://bugs.webkit.org/show_bug.cgi?id=51204
1780
1781         * QtTestBrowser/webpage.h:
1782         (QtNAMThread::QtNAMThread):
1783         (QtNAMThread::networkAccessManager):
1784         (QtNAMThread::run):
1785
1786 2011-01-11  Peter Varga  <pvarga@webkit.org>
1787
1788         Unreviewed.
1789
1790         Add myself to committers' list.
1791
1792         * Scripts/webkitpy/common/config/committers.py:
1793
1794 2011-01-11  Eric Seidel  <eric@webkit.org>
1795
1796         Reviewed by Adam Barth.
1797
1798         commit-queue should know how to upload archived results (for test flakes or general failures)
1799         https://bugs.webkit.org/show_bug.cgi?id=52048
1800
1801         Now the queue will always upload results.  Either the entire zip, or just
1802         the diffs.txt in the case of text failures.
1803
1804         This should make understanding flakes much easier, and paves the way
1805         for having the EWS run layout tests (and upload failures).
1806
1807         In order to upload .zip files I had to teach bugzilla.py to autodetect
1808         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1809         for .patch files, I have it add one before calling guess_type.
1810
1811         We may find that always uploading the whole zip instead of just the -diffs.txt
1812         file is preferable, but for now I'm keeping the old behavior because it makes
1813         quickly understanding text failures easy.
1814
1815         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1816         * Scripts/webkitpy/common/system/workspace.py: Added.
1817         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1818         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1819         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1820         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1821         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1822         * Scripts/webkitpy/tool/commands/queues.py:
1823         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1824
1825 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1826
1827         Unreviewed, rolling out r75464.
1828         http://trac.webkit.org/changeset/75464
1829         https://bugs.webkit.org/show_bug.cgi?id=52193
1830
1831         Followup rollout for 75474 (Requested by Ossy on #webkit).
1832
1833         * MiniBrowser/mac/BrowserWindowController.m:
1834         (-[BrowserWindowController awakeFromNib]):
1835         * MiniBrowser/win/BrowserView.cpp:
1836         (BrowserView::create):
1837         * WebKitTestRunner/TestController.cpp:
1838         (WTR::createOtherPage):
1839         (WTR::TestController::initialize):
1840
1841 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1842
1843         Reviewed by Csaba Osztrogonác.
1844
1845         [Qt] Baseline qt_minimal configuration
1846         https://bugs.webkit.org/show_bug.cgi?id=51313
1847
1848         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1849         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1850         QT_NO_UNDOSTACK guard.
1851
1852         * QtTestBrowser/launcherwindow.cpp:
1853         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1854         guards.
1855         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1856         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1857         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1858         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1859
1860         * QtTestBrowser/launcherwindow.h:
1861         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1862         * QtTestBrowser/locationedit.h: Ditto.
1863
1864         * QtTestBrowser/mainwindow.cpp:
1865         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1866         QT_NO_UNDOSTACK guards.
1867         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1868         (MainWindow::changeLocation): Ditto.
1869         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1870         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1871
1872         * QtTestBrowser/webpage.cpp:
1873         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1874         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1875
1876         * QtTestBrowser/webview.cpp:
1877         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1878         (WebViewGraphicsBased::animatedYFlip): Ditto.
1879
1880 2011-01-10  Sam Weinig  <sam@webkit.org>
1881
1882         Fix build.
1883
1884         * MiniBrowser/mac/BrowserWindowController.m:
1885         (-[BrowserWindowController awakeFromNib]):
1886         * MiniBrowser/win/BrowserView.cpp:
1887         (BrowserView::create):
1888         * WebKitTestRunner/TestController.cpp:
1889         (WTR::createOtherPage):
1890         (WTR::TestController::initialize):
1891
1892 2011-01-10  Eric Seidel  <eric@webkit.org>
1893
1894         Reviewed by Ojan Vafai.
1895
1896         style-queue messages are way too long for big patches
1897         https://bugs.webkit.org/show_bug.cgi?id=52161
1898
1899         We definitely could build much fancier list-to-string-with-limit functions
1900         but this should be sufficient for our needs at the moment.
1901
1902         * Scripts/webkitpy/common/system/executive.py:
1903         * Scripts/webkitpy/common/system/executive_unittest.py:
1904
1905 2011-01-10  Tony Chang  <tony@chromium.org>
1906
1907         Unreviewed, rolling out r75398.
1908         http://trac.webkit.org/changeset/75398
1909         https://bugs.webkit.org/show_bug.cgi?id=52008
1910
1911         Some layout tests are crashing on Chromium Win.
1912
1913         * DumpRenderTree/chromium/WebViewHost.cpp:
1914         (WebViewHost::updatePaintRect):
1915         * DumpRenderTree/chromium/WebViewHost.h:
1916
1917 2011-01-10  Adam Roben  <aroben@apple.com>
1918
1919         Roll out r75392
1920
1921         It isn't needed now that r75289 has been rolled out.
1922
1923         * Scripts/run-javascriptcore-tests:
1924
1925 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1926
1927         Reviewed by Anders Carlsson.
1928
1929         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1930         https://bugs.webkit.org/show_bug.cgi?id=52160
1931
1932         * WebKitTestRunner/mac/TestControllerMac.mm:
1933         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1934         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1935         anyway.
1936
1937 2011-01-10  Tony Chang  <tony@chromium.org>
1938
1939         Reviewed by Mihai Parparita.
1940
1941         [chromium] fix for animated gif layout tests
1942         https://bugs.webkit.org/show_bug.cgi?id=52008
1943
1944         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1945             to trigger gif animations.
1946         (WebViewHostPaintTask::WebViewHostPaintTask):
1947         (WebViewHostPaintTask::runIfValid):
1948         (WebViewHost::updatePaintRect):
1949         * DumpRenderTree/chromium/WebViewHost.h:
1950         (WebViewHost::taskList):
1951
1952 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1953
1954         Reviewed by Xan Lopez.
1955
1956         [GTK] Fix gtk2 compilation for master
1957         https://bugs.webkit.org/show_bug.cgi?id=51885
1958
1959         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1960         (createBitmapContextFromWebView): Replaced the old
1961         gdk_drawable_get_size with gdk_pixmap_get_size.
1962
1963 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1964
1965         Reviewed by Laszlo Gombos.
1966
1967         [WINCE] Reenable NPAPI after r75203
1968         https://bugs.webkit.org/show_bug.cgi?id=52109
1969
1970         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1971         it with !isEfl(), because EFL port does not support NPAPI (yet).
1972
1973         * Scripts/build-webkit:
1974
1975 2011-01-10  Adam Roben  <aroben@apple.com>
1976
1977         Skip some asserting JS tests
1978
1979         See <http://webkit.org/b/52156>.
1980
1981         * Scripts/run-javascriptcore-tests:
1982
1983 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1984
1985         Reviewed by Xan Lopez.
1986
1987         [GTK] build-webkit disable Blob support via arguments passed to automake
1988         https://bugs.webkit.org/show_bug.cgi?id=52097
1989
1990         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1991         build-webkit.
1992
1993 2011-01-10  Adam Roben  <aroben@apple.com>
1994
1995         Use the same name and description for TestNetscapePlugin on Windows and
1996         Mac
1997
1998         Fixes <http://webkit.org/b/52151>
1999         fast/frames/iframe-reparenting-plugins.html fails on Windows
2000
2001         Reviewed by Steve Falkenburg.
2002
2003         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2004         the name and description from Mac's Info.plist.
2005
2006 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2007
2008         Reviewed by Laszlo Gombos.
2009
2010         [Qt][WK2] Guard gcc-specific syntax
2011
2012         Non-gcc based compliers choke on the "-include"
2013         syntax for preinclude, place guard around it.
2014
2015         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2016         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2017
2018 2011-01-10  Andreas Kling  <kling@webkit.org>
2019
2020         Reviewed by Simon Hausmann.
2021
2022         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2023         https://bugs.webkit.org/show_bug.cgi?id=52111
2024
2025         When getting a createNewPage() callback from QWKPage, create the
2026         new page with the same QWKContext as the page that is passed to
2027         the callback.
2028
2029         * MiniBrowser/qt/BrowserView.h:
2030         * MiniBrowser/qt/BrowserWindow.cpp:
2031         (newPageFunction):
2032         (BrowserWindow::BrowserWindow):
2033         * MiniBrowser/qt/BrowserWindow.h:
2034
2035 2011-01-10  Andreas Kling  <kling@webkit.org>
2036
2037         Reviewed by Kenneth Rohde Christiansen.
2038
2039         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2040
2041         BrowserView set its own useless createNewPage() callback on QWKPage.
2042         This was immediately overridden by BrowserWindow anyway, so remove
2043         the BrowserView one.
2044
2045         * MiniBrowser/qt/BrowserView.cpp:
2046         (BrowserView::BrowserView):
2047
2048 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2049
2050         Reviewed by Jeremy Orlow.
2051
2052         [Chromium] Remove non-client-based Geolocation code
2053         https://bugs.webkit.org/show_bug.cgi?id=50921
2054
2055         * DumpRenderTree/chromium/LayoutTestController.cpp:
2056         (LayoutTestController::setGeolocationPermission):
2057         (LayoutTestController::setMockGeolocationPosition):
2058         (LayoutTestController::setMockGeolocationError):
2059         * DumpRenderTree/chromium/WebViewHost.cpp:
2060         (WebViewHost::geolocationClientMock):
2061         (WebViewHost::reset):
2062         * DumpRenderTree/chromium/WebViewHost.h:
2063
2064 2011-01-10  Eric Seidel  <eric@webkit.org>
2065
2066         Reviewed by Adam Barth.
2067
2068         Commit bot tried to land r? cq+ patch
2069         https://bugs.webkit.org/show_bug.cgi?id=36638
2070
2071         It should now be possible to post a patch with r? and cq+ and the
2072         commit-queue will correctly wait for the r+ before attempting to land the patch.
2073         (This was a feature requested by several users.)
2074
2075         One caveat: We don't actually reject r-, cq+ patches from the queue
2076         (we just ignore them), but I think that's OK for now.
2077
2078         I also noticed that setting r- once a commit-queue node had grabbed
2079         a patch would not properly cancel the landing.  That's fixed and
2080         tested in this patch.
2081
2082         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2083         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2084         * Scripts/webkitpy/tool/bot/feeders.py:
2085         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2086
2087 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2088
2089         Reviewed by Kenneth Rohde Christiansen.
2090
2091         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2092         https://bugs.webkit.org/show_bug.cgi?id=51934
2093
2094         When accessing the network from the destructor of QWebPage, the network access manager
2095         was already deleted because the object WebPage was already destructed.
2096
2097         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2098         The object is now destructed in the destructor of QObject.
2099
2100         * QtTestBrowser/webpage.cpp:
2101         (WebPage::WebPage):
2102         (WebPage::setQnamThreaded):
2103         * QtTestBrowser/webpage.h:
2104         (QtNAMThread::QtNAMThread):
2105
2106 2011-01-08  Eric Seidel  <eric@webkit.org>
2107
2108         Reviewed by Ojan Vafai.
2109
2110         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2111         https://bugs.webkit.org/show_bug.cgi?id=52067
2112
2113         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2114         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2115
2116         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2117
2118 2011-01-08  Eric Seidel  <eric@webkit.org>
2119
2120         Reviewed by Mihai Parparita.
2121
2122         commit-queue hangs when the ChangeLog diff is bad
2123         https://bugs.webkit.org/show_bug.cgi?id=52072
2124
2125         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2126         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2127
2128 2011-01-08  Adam Barth  <abarth@webkit.org>
2129
2130         Teach svn-apply how to re-write WebCore to Source/WebCore.
2131
2132         * Scripts/VCSUtils.pm:
2133
2134 2011-01-07  Adam Barth  <abarth@webkit.org>
2135
2136         Rubber-stamped by Eric Seidel.
2137
2138         Move WebCore to Source
2139         https://bugs.webkit.org/show_bug.cgi?id=52050
2140
2141         Update the tools to understand WebCore's new location.
2142
2143         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2144         * DumpRenderTree/wscript:
2145         * GNUmakefile.am:
2146         * Scripts/build-webkit:
2147         * Scripts/do-file-rename:
2148         * Scripts/do-webcore-rename:
2149         * Scripts/generate-qt-inspector-resource:
2150         * Scripts/prepare-ChangeLog:
2151         * Scripts/run-bindings-tests:
2152         * Scripts/update-iexploder-cssproperties:
2153         * Scripts/update-sources-list.py:
2154         * Scripts/update-webkit-localizable-strings:
2155         * Scripts/webkitdirs.pm:
2156         * Scripts/webkitpy/common/config/build.py:
2157         * Scripts/webkitpy/common/config/build_unittest.py:
2158         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2159         * Scripts/webkitpy/style/checker.py:
2160         * Scripts/webkitpy/style/checker_unittest.py:
2161         * WebKitTestRunner/DerivedSources.pro:
2162         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2163         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2164         * wx/browser/wscript:
2165         * wx/build/settings.py:
2166
2167 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2168
2169         Reviewed by Sam Weinig.
2170
2171         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2172         https://bugs.webkit.org/show_bug.cgi?id=52086
2173
2174         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2175         (WTR::InjectedBundle::didReceiveMessage):
2176         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2177         (WTR::LayoutTestController::notifyDone):
2178         * WebKitTestRunner/TestController.cpp:
2179         (WTR::TestController::resetStateToConsistentValues):
2180         (WTR::TestController::run):
2181
2182 2011-01-07  James Robinson  <jamesr@chromium.org>
2183
2184         Revert "Implement mozilla's animationTime property"
2185         https://bugs.webkit.org/show_bug.cgi?id=51952
2186
2187         This approach isn't quite right.
2188
2189         * DumpRenderTree/chromium/WebViewHost.cpp:
2190         (WebViewHost::paintInvalidatedRegion):
2191
2192 2011-01-07  Adam Roben  <aroben@apple.com>
2193
2194         Build master fix
2195
2196         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2197         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2198
2199 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2200
2201         Reviewed by Csaba Osztrogonác.
2202
2203         run-qtwebkit-tests should be able to kill a testsuite.
2204
2205         Add new option in the script that can setup a timeout for a test.
2206         If the test execution takes more then specified time then the test
2207         would be terminated.
2208
2209         [Qt] run-qtwebkit-tests needs timeout
2210         https://bugs.webkit.org/show_bug.cgi?id=51894
2211
2212         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2213         * Scripts/run-qtwebkit-tests:
2214
2215 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2216
2217         Unreviewed fix after r75233.
2218
2219         Based on idea from Eric Seidel.
2220
2221         Add remote zip file handling to webkitpy.
2222         https://bugs.webkit.org/show_bug.cgi?id=50901
2223
2224         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2225
2226 2011-01-07  Shane Stephens  <shanestephens@google.com>
2227
2228         Reviewed by Eric Seidel.
2229
2230         svn-apply: should support git binary delta diffs
2231         https://bugs.webkit.org/show_bug.cgi?id=38864
2232
2233         * Scripts/VCSUtils.pm:
2234         * Scripts/svn-apply:
2235
2236 2011-01-06  Julie Parent  <jparent@chromium.org>
2237
2238         Reviewed by Eric Seidel.
2239
2240         Test Result Server not removing old results.
2241         https://bugs.webkit.org/show_bug.cgi?id=52012
2242
2243         * TestResultServer/model/jsonresults.py:
2244         Fix off-by-one: Truncate if >= num_runs, not just >.
2245         * TestResultServer/model/jsonresults_unittest.py:
2246         Add unit test to test that merging in a new result with the same value
2247         as the last result causes previous result to fall off.
2248
2249 2011-01-06  James Kozianski  <koz@chromium.org>
2250
2251         Reviewed by Mihai Parparita.
2252
2253         Add classes to provide a consistent interface to a set of files.
2254         https://bugs.webkit.org/show_bug.cgi?id=50901
2255
2256         These classes allow us to write code that is agnostic to whether a
2257         particular set of files resides in a local directory or in a zip file
2258         on a remote machine.
2259
2260         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2261         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2262         * Scripts/webkitpy/common/system/fileset.py: Added.
2263         * Scripts/webkitpy/common/system/filesystem.py:
2264         * Scripts/webkitpy/common/system/filesystem_mock.py:
2265         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2266         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2267
2268 2011-01-06  Eric Seidel  <eric@webkit.org>
2269
2270         Reviewed by Adam Barth.
2271
2272         NetworkTransaction should log the url it is retrying
2273         https://bugs.webkit.org/show_bug.cgi?id=52043
2274
2275         * Scripts/webkitpy/common/net/networktransaction.py:
2276         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2277
2278 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2279
2280         Windows build fix.
2281         Import os before using it.
2282
2283         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2284
2285 2011-01-06  Eric Seidel  <eric@webkit.org>
2286
2287         Reviewed by Adam Barth.
2288
2289         StyleQueue fails to report errors when patches have many files
2290         https://bugs.webkit.org/show_bug.cgi?id=52042
2291
2292         This is one of at least two errors preventing style error reporting at the moment.
2293         When we moved to passing the list of files to check explicitly,
2294         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2295         We could change the type of the QueueStatus.message type, or we could
2296         just teach statusserver.py how to clamp values (and warn when it does).
2297         I chose the latter path.
2298
2299         * Scripts/webkitpy/common/net/statusserver.py:
2300
2301 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2302
2303         Reviewed by Stephanie Lewis.
2304         
2305         Fix syntax error in script.
2306
2307         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2308         https://bugs.webkit.org/show_bug.cgi?id=51996
2309
2310         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2311
2312 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2313
2314         Unreviewed, fixing WinCE build after r75196.
2315
2316         WinCE port does not (yet) support NPAPI.
2317
2318         * Scripts/build-webkit:
2319
2320 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2321
2322         Reviewed by Darin Adler.
2323
2324         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2325         https://bugs.webkit.org/show_bug.cgi?id=52015
2326
2327         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2328         after the platform has been detected, otherwise the script will
2329         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2330         detection.
2331
2332 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2333
2334         Reviewed by Eric Seidel.
2335
2336         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2337         https://bugs.webkit.org/show_bug.cgi?id=51346
2338
2339         * Scripts/build-webkit:
2340
2341 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2342
2343         Reviewed by Adam Roben.
2344
2345         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2346         https://bugs.webkit.org/show_bug.cgi?id=51996
2347         
2348         After the configuration directory change, we were archiving the incorrect directory for
2349         build product, so we were running tests on the wrong binaries.
2350         
2351         This change archives the correct directory, and also unarchives it into a configuration-
2352         specific directory.
2353
2354         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2355         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2356
2357 2011-01-06  Eric Seidel  <eric@webkit.org>
2358
2359         Reviewed by Mihai Parparita.
2360
2361         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2362         https://bugs.webkit.org/show_bug.cgi?id=52002
2363
2364         See an example of this here:
2365         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2366
2367         It's due to the fact that we pass around TestFailure() instance
2368         objects and yet expect them to all compare to be the same.
2369
2370         This is bad.  We should either have shared instances of these values
2371         or we should just pass around the class names.  There are already hacks
2372         in place to make TestFailure objects pass equality tests, I just added
2373         a __hash__ implementation so they can be used in sets as expected.
2374
2375         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2376         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2377
2378 2011-01-06  Evan Martin  <evan@chromium.org>
2379
2380         Reviewed by Tony Chang.
2381
2382         [gdb] handle inaccessible memory and UChar*
2383         https://bugs.webkit.org/show_bug.cgi?id=52003
2384
2385         To pretty-print a UChar*, we just grope around in the memory
2386         looking for a terminating NUL.  We need to handle the exception
2387         that can occur when we poke into an invalid location.
2388
2389         Additionally, the logic for choosing which pretty-printer would
2390         early return before hitting the point where we'd use the UChar*
2391         printer.  (Did this ever work?  How did it regress?)
2392
2393         * gdb/webkit.py:
2394
2395 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2396
2397         Reviewed by Ada Chan.
2398
2399         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2400         https://bugs.webkit.org/show_bug.cgi?id=51969
2401         
2402         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2403
2404         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2405         (WTR::InjectedBundlePage::InjectedBundlePage):
2406         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2407         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2408
2409 2011-01-06  James Robinson  <jamesr@chromium.org>
2410
2411         Reviewed by Simon Fraser.
2412
2413         Implement mozilla's animationTime property
2414         https://bugs.webkit.org/show_bug.cgi?id=51952
2415
2416         Chromium DRT support for webkitAnimationTime.
2417
2418         * DumpRenderTree/chromium/WebViewHost.cpp:
2419         (WebViewHost::paintInvalidatedRegion):
2420
2421 2011-01-06  Julie Parent  <jparent@chromium.org>
2422
2423         Reviewed by Tony Chang.
2424
2425         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2426         https://bugs.webkit.org/show_bug.cgi?id=51217
2427
2428         * TestResultServer/model/jsonresults.py:
2429         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2430         Adds missing documentation.
2431         * TestResultServer/model/jsonresults_unittest.py:
2432         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2433         Update test_merge to take a number of builds to truncate at.
2434
2435 2011-01-06  Adam Barth  <abarth@webkit.org>
2436
2437         Reviewed by Eric Seidel.
2438
2439         The EWS should log outside of the working directory
2440         https://bugs.webkit.org/show_bug.cgi?id=51986
2441
2442         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2443         script, which will actually clean the working copy back to a pristine
2444         state instead of leaving untracked directories and ignored files.
2445
2446         * Scripts/webkitpy/tool/commands/queues.py:
2447         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2448
2449 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2450
2451         Windows build fix.
2452         Back out attempted change to built-product-archive.
2453
2454         * BuildSlaveSupport/built-product-archive:
2455
2456 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2457
2458         Windows build fix.
2459         Include configuration name when unpacking a build archive.
2460
2461         Needed, since we split Windows build results into configuration-specific directories
2462         under WebKitOutputDir.
2463
2464         * BuildSlaveSupport/built-product-archive:
2465
2466 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2467
2468         Reviewed by Darin Adler.
2469
2470         Debug and Release builds on Windows clobber each other
2471         https://bugs.webkit.org/show_bug.cgi?id=49185
2472
2473         Changes the structure of WebKitBuild build products directory so we
2474         completely separate each build configuration into independent directories.
2475         
2476         Although we previously had per-configuration directories for obj, this change adds
2477         per-configuration directories for bin, lib, obj, and include. Each configuration's
2478         build products are stored within a directory inside of WebKitBuild.
2479         
2480         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2481         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2482
2483         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2484         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2485         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2486         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2487         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2488         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2489         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2490         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2491         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2492         * FindSafari/FindSafari.vcproj:
2493         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2494         * MiniBrowser/MiniBrowserPostBuild.cmd:
2495         * MiniBrowser/MiniBrowserPreBuild.cmd:
2496         * Scripts/webkitdirs.pm:
2497         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2498         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2499         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2500         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2501         * TestWebKitAPI/win/copy-resources.cmd:
2502         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2503         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2504         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2505         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2506         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2507         * WebKitTestRunner/win/InjectedBundle.vcproj:
2508         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2509         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2510         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2511         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2512         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2513         * WinLauncher/WinLauncherCommon.vsprops:
2514         * WinLauncher/WinLauncherPostBuild.cmd:
2515         * WinLauncher/WinLauncherPreBuild.cmd:
2516
2517 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2518
2519         Reviewed by Ariya Hidayat.
2520
2521         [Qt] TestNetscapePlugin doesn't link on OS X
2522         https://bugs.webkit.org/show_bug.cgi?id=51948
2523
2524         Only add a dependency on libX11 on X11 systems
2525
2526         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2527
2528 2011-01-05  Jeff Miller  <jeffm@apple.com>
2529
2530         Reviewed by Adam Roben.
2531
2532         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2533         https://bugs.webkit.org/show_bug.cgi?id=51970
2534
2535         * Scripts/webkitpy/style/checker.py:
2536         Add -readability/naming for WebKit2 C API directories.
2537
2538 2011-01-05  Eric Seidel  <eric@webkit.org>
2539
2540         Unreviewed, just fixing one more log error from my previous python patch.
2541
2542         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2543         https://bugs.webkit.org/show_bug.cgi?id=51802
2544
2545         webkit-patch failure-reason was logging about parsing errors
2546         due to my misunderstanding of how BeautifulSoup.findAll worked.
2547
2548         Fixed, and added a unit test.
2549
2550         * Scripts/webkitpy/common/net/layouttestresults.py:
2551         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2552
2553 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2554
2555         Reviewed by Kenneth Rohde Christiansen.
2556
2557         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2558         https://bugs.webkit.org/show_bug.cgi?id=51951
2559
2560         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2561         to create new window from WebKit.
2562
2563         * MiniBrowser/qt/BrowserWindow.cpp:
2564         (newPageFunction):
2565         (BrowserWindow::BrowserWindow):
2566         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2567         (BrowserWindow::newWindow):
2568         (BrowserWindow::updateUserAgentList):
2569         (BrowserWindow::showUserAgentDialog):
2570         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2571         define the type of the backing store used for new windows.
2572         * MiniBrowser/qt/main.cpp:
2573         (main):
2574
2575 2011-01-05  Eric Seidel  <eric@webkit.org>
2576
2577         Reviewed by Ojan Vafai.
2578
2579         commit-queue should report failure type when reporting flaky tests
2580         https://bugs.webkit.org/show_bug.cgi?id=51900
2581
2582         This patch was a ridiculous amount of plumbing.  In the end I like
2583         the NRWT-style TestResult class even less.  But now we're passing
2584         a list of TestResult objects from the queue to the FlakyTestReporter.
2585         Thus the FlakyTestReporter can more easily report what type of failure
2586         occurred.
2587
2588         In the process, I found that I was not alone in finding TestResult
2589         cumbersome to use.  A bunch of code was trying to create a TestResult
2590         object with default values.  However since the constructor didn't make
2591         this easy, some places were getting it wrong (including the TestResult unit test)!
2592         I've fixed the TestResult constructor to have default values for non-essential
2593         arguments.
2594
2595         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2596         * Scripts/webkitpy/common/net/layouttestresults.py:
2597         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2598         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2599         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2600         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2601         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2602         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2603         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2604         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2605         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2606         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2607         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2608         * Scripts/webkitpy/tool/commands/queues.py:
2609         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2610
2611 2011-01-05  Eric Seidel  <eric@webkit.org>
2612
2613         Unreviewed.
2614
2615         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2616         https://bugs.webkit.org/show_bug.cgi?id=51802
2617
2618         Add another unit test to cover a previously missing import.
2619
2620         * Scripts/webkitpy/common/net/layouttestresults.py:
2621         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2622
2623 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2624
2625         Reviewed by David Levin.
2626
2627         Add mihaip@chromium.org as a reviewer
2628         https://bugs.webkit.org/show_bug.cgi?id=51966
2629         
2630         Add myself as a reviewer.
2631
2632         * Scripts/webkitpy/common/config/committers.py:
2633
2634 2011-01-05  James Simonsen  <simonjam@chromium.org>
2635
2636         Unreviewed. Adding myself to the list of committers.
2637
2638         * Scripts/webkitpy/common/config/committers.py:
2639
2640 2011-01-05  Eric Seidel  <eric@webkit.org>
2641
2642         Unreviewed.
2643
2644         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2645         https://bugs.webkit.org/show_bug.cgi?id=51802
2646
2647         Fix two exceptions seen on the bots after my original commit.
2648
2649         * Scripts/webkitpy/common/net/layouttestresults.py:
2650         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2651
2652 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2653
2654         Reviewed by Andreas Kling.
2655
2656         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2657         https://bugs.webkit.org/show_bug.cgi?id=51750
2658
2659         * QtTestBrowser/main.cpp:
2660         (LauncherApplication::handleUserOptions):
2661          Local storage settings can be enable form command line arguments for
2662          QtTestBrowser.
2663
2664 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2665
2666         Reviewed by Martin Robinson.
2667
2668         GTK: AX: DRT needs to use correct root object method.
2669         https://bugs.webkit.org/show_bug.cgi?id=51911
2670
2671         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2672         (AccessibilityController::rootElement):
2673
2674 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2675
2676         Rubber-stamped by Csaba Osztrogonác.
2677
2678         Based on idea from Péter Gál.
2679
2680         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2681
2682 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2683
2684         Reviewed by Adam Barth.
2685
2686         sheriff-bot should be able to do multi-revision rollouts
2687         https://bugs.webkit.org/show_bug.cgi?id=51176
2688
2689         * Scripts/webkitpy/tool/bot/irc_command.py:
2690         * Scripts/webkitpy/tool/bot/sheriff.py:
2691         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2692
2693 2011-01-05  Eric Seidel  <eric@webkit.org>
2694
2695         Reviewed by Adam Barth.
2696
2697         queues.webkit.org should have per-bot status pages
2698         https://bugs.webkit.org/show_bug.cgi?id=51906
2699
2700         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2701         statuses from a single queue.  Now that we have many bots servicing
2702         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2703         you care about scroll off the end of the 15-message limit on the main page.
2704
2705         Eventually we should probably rename /queue-status to /queue or /queues,
2706         but that's fodder for another patch.
2707
2708         * QueueStatusServer/handlers/queuestatus.py:
2709         * QueueStatusServer/index.yaml:
2710         * QueueStatusServer/main.py:
2711         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2712          - This probably should use a custom filter instead of hard-coding
2713            the URL scheme here, but I couldn't figure out how to easily
2714            create such a filter.  Most filters work with "strings" so we can't
2715            pass the status object.  We could add a method to the status
2716            object and call that, but that seemed a bit strange too.
2717         * QueueStatusServer/templates/queuestatus.html:
2718
2719 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2720
2721         Unreviewed. Adding myself to the list of committers.
2722
2723         * Scripts/webkitpy/common/config/committers.py:
2724
2725 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2726
2727         Reviewed by David Levin.
2728
2729         check-webkit-style treated some macros with parentheses after #elif as function calls
2730         https://bugs.webkit.org/show_bug.cgi?id=51695
2731
2732         Ingore function call space checking in any preprocessor directives
2733         (things starting with #). Change search() to match() because 
2734         preprocessor directives are supposed to be in the beginning of lines.
2735
2736         * Scripts/webkitpy/style/checkers/cpp.py:
2737         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2738
2739 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2740
2741         Reviewed by Tony Chang.
2742
2743         Change the --multi-load test option to --stress-opt
2744         https://bugs.webkit.org/show_bug.cgi?id=50751
2745
2746         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2747         (runTest):
2748         (main):
2749         * DumpRenderTree/chromium/TestShell.cpp:
2750         (TestShell::TestShell):
2751         * DumpRenderTree/chromium/TestShell.h:
2752         (TestShell::stressOpt):
2753         (TestShell::setStressOpt):
2754         (TestShell::stressDeopt):
2755         (TestShell::setStressDeopt):
2756         (TestShell::javaScriptFlags):
2757         (TestShell::setJavaScriptFlags):
2758         * Scripts/webkitpy/layout_tests/port/chromium.py:
2759         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2760
2761 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2762
2763         Reviewed by Sam Weinig.
2764
2765         WK2: Support Accessibility
2766         https://bugs.webkit.org/show_bug.cgi?id=51859
2767
2768         Use rootObject() method to get top of accessibility tree.
2769
2770         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2771         (AccessibilityController::focusedElement):
2772         (AccessibilityController::rootElement):
2773
2774 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2775
2776         Reviewed by Darin Adler.
2777
2778         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2779         https://bugs.webkit.org/show_bug.cgi?id=51846
2780
2781         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2782         back to GRefPtr.
2783
2784 2011-01-04  Zhe Su  <suzhe@chromium.org>
2785
2786         Reviewed by Kenneth Russell.
2787
2788         Fix insertText, setMarkedText and unmarkText methods of
2789         TextInputController to call corresponding methods of WebKit::WebView
2790         rather than WebKit::WebFrame. This change matches the behavior of
2791         chromium browser.
2792         insertText corresponds to WebView::confirmComposition(text)
2793         setMarkedText corresponds to WebView::setComposition(...)
2794         unmarkText corresponds to WebView::confirmComposition()
2795         https://bugs.webkit.org/show_bug.cgi?id=51693
2796
2797         * DumpRenderTree/chromium/TextInputController.cpp:
2798         (TextInputController::insertText):
2799         (TextInputController::setMarkedText):
2800         (TextInputController::unmarkText):
2801
2802 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2803
2804         Reviewed by Laszlo Gombos.
2805
2806         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2807
2808         On Symbian productDir points to the source directory. Removing all the
2809         empty files from the productDir directory corrupts the svn repository.
2810
2811         * Scripts/build-webkit:
2812
2813 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2814
2815         Reviewed by Adam Barth.
2816
2817         [Qt] Add SelectAll option to the context menu for the editor
2818         https://bugs.webkit.org/show_bug.cgi?id=50049
2819
2820         Set shortcut for the SelectAll action.
2821
2822         * QtTestBrowser/mainwindow.cpp:
2823         (MainWindow::buildUI):
2824
2825 2011-01-03  David Levin  <levin@chromium.org>
2826
2827         Reviewed by Eric Seidel.
2828
2829         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2830         https://bugs.webkit.org/show_bug.cgi?id=51842
2831
2832         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2833         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2834
2835 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2836
2837         Reviewed by David Kilzer.
2838
2839         [WINCE] Adds a build slave.
2840         https://bugs.webkit.org/show_bug.cgi?id=50523
2841
2842         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2843         entry for a release build of the WinCE port.
2844         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2845         flag to build the WinCE port.
2846
2847 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2848
2849         Reviewed by David Kilzer.
2850
2851         Add WinCE support to build-webkit
2852         https://bugs.webkit.org/show_bug.cgi?id=51642
2853
2854         * Scripts/build-webkit:
2855         * Scripts/webkitdirs.pm:
2856
2857 2011-01-03  Eric Seidel  <eric@webkit.org>
2858
2859         Reviewed by Adam Barth.
2860
2861         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2862         https://bugs.webkit.org/show_bug.cgi?id=51802
2863
2864         I'm not the biggest fan of the test_failures or test_results classes,
2865         but it's better to have one shared set of classes, than separate ones
2866         for new vs. old run-webkit-test result handling.
2867
2868         This moves the ORWT results class "LayoutTestResults" over to using
2869         TestResult and TestFailure classes, making it easy for us to
2870         make all our sheriff-bot and other webkitpy code NRWT ready.
2871
2872         This also makes it a trivial patch to generate results.json information
2873         from ORWT results.html files (for flaky test analysis, etc.) as well
2874         as making it a one-liner to report test failure types when the
2875         commit-queue sees flaky tests.
2876
2877         This patch tried not to add new functionality, but only to replace
2878         the guts of LayoutTestResults, while adding unit tests and hoping
2879         not to break anything.
2880
2881         I also moved callers which assumed User.prompt* were static/class methods
2882         to using them as instance methods (since we'll eventually want to make them such).
2883
2884         In the process of re-writing things, I broke the rebaseline command, so I wrote
2885         a unit test to catch my breakage were I do do so again in the future.
2886
2887         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2888         * Scripts/webkitpy/common/net/layouttestresults.py:
2889         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2890         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2891         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2892         * Scripts/webkitpy/tool/commands/queries.py:
2893         * Scripts/webkitpy/tool/commands/rebaseline.py:
2894         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2895         * Scripts/webkitpy/tool/mocktool.py:
2896
2897 2011-01-03  Adam Barth  <abarth@webkit.org>
2898
2899         Reviewed by Simon Fraser.
2900
2901         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2902         https://bugs.webkit.org/show_bug.cgi?id=51840
2903
2904         * Scripts/webkitpy/common/checkout/scm.py:
2905
2906 2011-01-03  Adam Barth  <abarth@webkit.org>
2907
2908         Reviewed by Simon Fraser.
2909
2910         webkit-patch should only hide update output if --quiet
2911         https://bugs.webkit.org/show_bug.cgi?id=51838
2912
2913         As requested by smfr.
2914
2915         * Scripts/webkitpy/tool/steps/update.py:
2916
2917 2011-01-03  Adam Barth  <abarth@webkit.org>
2918
2919         Reviewed by David Levin.
2920
2921         commit-queue shouldn't reject patches twice if two bots process the same patch
2922         https://bugs.webkit.org/show_bug.cgi?id=51805
2923
2924         Before raising an error, we first check whether the patch is still in
2925         the commit-queue.  This check is still racy, of course, but the time
2926         window is much smaller.
2927
2928         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2929
2930 2011-01-03  Sam Weinig  <sam@webkit.org>
2931
2932         Reviewed by Anders Carlsson.
2933
2934         Make run-api-tests less chatty.
2935         https://bugs.webkit.org/show_bug.cgi?id=51831
2936
2937         - Make script quiet by default and add --verbose option (replacing --quiet).
2938         - When not verbose, pipe stdout and stderr to devnull.
2939
2940         * Scripts/run-api-tests:
2941
2942 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2943
2944         Unreviewed. Adding myself to committers.py.
2945
2946         * Scripts/webkitpy/common/config/committers.py:
2947
2948 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2949
2950         Reviewed by Xan Lopez.
2951
2952         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2953         https://bugs.webkit.org/show_bug.cgi?id=51806
2954
2955         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2956         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2957         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2958         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2959         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2960         so make it 'WebKitBuild/Release/.libs'
2961
2962         * Scripts/webkitdirs.pm: 
2963
2964 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2965
2966         Reviewed by Adam Barth.
2967
2968         Make EFL a core builder
2969         https://bugs.webkit.org/show_bug.cgi?id=51804
2970
2971         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2972         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2973
2974 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2975
2976         [Qt] Unreviewed fix after r74855 and r74875.
2977
2978         * BuildSlaveSupport/built-product-archive:
2979          - Create directories explicitly.
2980          - Pass shell=True to subprocess.call().
2981
2982 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2983
2984         [Qt] Unreviewed fix after r74855.
2985
2986         Move JavaScriptCore to Source
2987         https://bugs.webkit.org/show_bug.cgi?id=51604
2988
2989         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2990
2991 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2992
2993         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2994
2995         Move JavaScriptCore to Source
2996         https://bugs.webkit.org/show_bug.cgi?id=51604
2997
2998         * Scripts/webkitdirs.pm:
2999
3000 2011-01-02  Robert Hogan  <robert@webkit.org>
3001
3002         Unreviewed, build fix.
3003
3004         [Qt] Fix DRT build after 74855
3005
3006         * DumpRenderTree/qt/DumpRenderTree.pro:
3007
3008 2011-01-01  Adam Barth  <abarth@webkit.org>
3009
3010         Remove the assumption from the Qt and Gtk builds that every project is
3011         in the root directory.
3012
3013         * Scripts/build-webkit:
3014
3015 2011-01-01  Adam Barth  <abarth@webkit.org>
3016
3017         Reviewed by Eric Seidel.
3018
3019         Teach svn-apply how to apply patches even though JavaScriptCore has moved
3020         https://bugs.webkit.org/show_bug.cgi?id=51796
3021
3022         After this change, svn-apply will magically apply patches to
3023         JavaScriptCore/foo to Source/JavaScriptCore/foo.
3024
3025         * Scripts/VCSUtils.pm:
3026
3027 2011-01-01  Adam Barth  <abarth@webkit.org>
3028
3029         Reviewed by Eric Seidel.
3030
3031         Move JavaScriptCore to Source
3032         https://bugs.webkit.org/show_bug.cgi?id=51604
3033
3034         Update references to JavaScriptCore to point to the new location.
3035
3036         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3037         * DumpRenderTree/qt/DumpRenderTree.pro:
3038         * DumpRenderTree/qt/ImageDiff.pro:
3039         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3040         * DumpRenderTree/wscript:
3041         * Scripts/build-jsc:
3042         * Scripts/build-webkit:
3043         * Scripts/do-file-rename:
3044         * Scripts/do-webcore-rename:
3045         * Scripts/run-javascriptcore-tests:
3046         * Scripts/update-javascriptcore-test-results:
3047         * Scripts/webkitdirs.pm:
3048         * Scripts/webkitpy/common/config/build_unittest.py:
3049         * Scripts/webkitpy/style/checker.py:
3050         * Scripts/webkitpy/style/checker_unittest.py:
3051         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3052         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3053         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3054         * wx/build/settings.py:
3055
3056 2011-01-01  Adam Barth  <abarth@webkit.org>
3057
3058         Reviewed by Eric Seidel.
3059
3060         Move Sources to Source
3061         https://bugs.webkit.org/show_bug.cgi?id=51794
3062
3063         Update scripts to point to the new location.
3064
3065         * Scripts/build-webkit:
3066         * Scripts/do-file-rename:
3067         * Scripts/do-webcore-rename:
3068         * Scripts/webkitpy/common/config/build.py:
3069         * Scripts/webkitpy/common/config/build_unittest.py:
3070
3071 2010-12-31  Kent Tamura  <tkent@chromium.org>
3072
3073         Reviewed by Eric Seidel.
3074
3075         [DRT/Chromium] Enable mock spell checker on non-OSX
3076         https://bugs.webkit.org/show_bug.cgi?id=51401
3077
3078         * DumpRenderTree/chromium/WebViewHost.cpp:
3079         (WebViewHost::spellCheck):
3080
3081 2010-12-31  Adam Barth  <abarth@webkit.org>
3082
3083         Reviewed by Ariya Hidayat.
3084
3085         Remove Tools/Scripts/wkstyle
3086         https://bugs.webkit.org/show_bug.cgi?id=51774
3087
3088         This script appears to not have been touched in a while and seems to
3089         have been replaced by check-webkit-style.
3090
3091         * Scripts/wkstyle: Removed.
3092
3093 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3094
3095         Unreviewed. Coding style fix.
3096
3097         * DumpRenderTree/chromium/TestShell.h:
3098
3099 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3100
3101         Reviewed by Pavel Feldman.
3102
3103         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
3104
3105         It was a problem with Chromium DRT. DevToolsAgent object instance was
3106         attached not only to the inspected page but to the DevTools window too.
3107         As result all the inspector files were interpreted as a content of inspected page
3108         and were transfered to the DevTools scripts panel for debugging etc.
3109
3110         https://bugs.webkit.org/show_bug.cgi?id=51735
3111
3112         * DumpRenderTree/chromium/TestShell.cpp:
3113         (TestShell::TestShell):
3114         (TestShell::bindJSObjectsToWindow):
3115         (TestShell::createNewWindow):
3116         * DumpRenderTree/chromium/TestShell.h:
3117
3118 2010-12-31  Adam Barth  <abarth@webkit.org>
3119
3120         Rubber-stamped by Eric Seidel.
3121
3122         Move PageLoadTests to PerformanceTests/PageLoad
3123         https://bugs.webkit.org/show_bug.cgi?id=51771
3124
3125         Update references to PageLoadTests to point to the new location.
3126
3127         * Scripts/run-pageloadtest:
3128         * Scripts/webkitpy/common/config/build.py:
3129
3130 2010-12-31  Adam Barth  <abarth@webkit.org>
3131
3132         Rubber-stamped by Eric Seidel.
3133
3134         Move SunSpider into PerformanceTests
3135         https://bugs.webkit.org/show_bug.cgi?id=51769
3136
3137         Update these scripts to point to the new location.
3138
3139         * Scripts/run-sunspider:
3140         * Scripts/sunspider-compare-results:
3141
3142 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
3143
3144         Reviewed by Kent Tamura.
3145
3146         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3147         https://bugs.webkit.org/show_bug.cgi?id=51728
3148         
3149         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3150         to render top-level scrollbars. This makes them match the Mac port's
3151         use of an NSScrollView, which means that we'll be able to share more
3152         pixel baselines.
3153         
3154         The new rendering code will not be activated until the 
3155         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3156         ScrollbarThemeChromiumMac.
3157
3158         * DumpRenderTree/DumpRenderTree.gypi:
3159         * DumpRenderTree/chromium/TestShellMac.mm:
3160         (platformInit):
3161         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3162         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3163         (+[FakeActiveWindow alwaysActiveWindow]):
3164         (+[FakeActiveWindow alwaysInactiveWindow]):
3165         (-[FakeActiveWindow initWithActiveControls:]):
3166         (-[FakeActiveWindow _hasActiveControls]):
3167         (WebThemeEngineDRTMac::paintScrollbarThumb):
3168         (stateToHIEnableState):
3169         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3170         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3171
3172 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3173
3174         Reviewed by David Kilzer.
3175
3176         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3177         used
3178         https://bugs.webkit.org/show_bug.cgi?id=51672
3179
3180         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3181         with USE_SYSTEM_MALLOC=1
3182         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3183         with USE_SYSTEM_MALLOC=1
3184
3185 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3186
3187         Reviewed by David Kilzer.
3188
3189         [Qt] [Symbian] Fix build-webkit script for Symbian
3190         https://bugs.webkit.org/show_bug.cgi?id=51509
3191
3192         Set the OUTPUT_DIR for Symbian to be the same as the source
3193         directory.
3194
3195         * Scripts/webkitdirs.pm:
3196
3197 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3198
3199         Reviewed by Darin Adler.
3200
3201         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3202         https://bugs.webkit.org/show_bug.cgi?id=51758
3203
3204         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3205
3206         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3207         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3208
3209 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3210
3211         Unreviewed WinCE buildfix.
3212
3213         * WinCELauncher/main.cpp: Add missing include.
3214
3215 2010-12-29  Daniel Bates  <dbates@rim.com>
3216
3217         Reviewed by Darin Adler.
3218
3219         svn-apply updates date of wrong change log entry for a change log diff that
3220         contains two consecutive entries with the same author and date
3221         https://bugs.webkit.org/show_bug.cgi?id=46061
3222
3223         Fixes an issue where the date of the wrong change log entry may be modified.
3224         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3225         in a ChangeLog file to the top of the file.
3226
3227         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3228         diff when it detects that the diff inserts a change log entry earlier in a
3229         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3230         change. With the advent of the commit-queue this functionality of bailing out
3231         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3232         Instead, we should always move the change log entry to the top of the ChangeLog file.
3233
3234         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3235         the date line of the correct change log entry in a ChangeLog diff.
3236
3237         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3238
3239         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3240           Updated the following unit tests now that we move entries inserted earlier to the top:
3241           - "fixChangeLogPatch: New entry inserted in middle."
3242             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3243
3244           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3245             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3246
3247         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3248
3249 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3250
3251         Reviewed by Eric Seidel.
3252
3253         [Qt] Fixed compatibility with gold linker on X11 platforms
3254         https://bugs.webkit.org/show_bug.cgi?id=51700
3255
3256         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3257         Linked TestNetscapePlugin with libX11 on Unix platforms
3258
3259 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3260
3261         Reviewed by Darin Adler.
3262
3263         Circular dependency in webkitpy.common.checkout.changelog module
3264         https://bugs.webkit.org/show_bug.cgi?id=50475
3265
3266         Remove automatic import of api.Checkout module when any checkout/
3267         submodule is imported (e.g.: when checkout.scm.Git is imported).
3268
3269         * Scripts/webkitpy/common/checkout/__init__.py:
3270
3271 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3272
3273         Reviewed by Ojan Vafai.
3274
3275         prepare-ChangeLog should support the -g option for specifying the git-commit
3276         https://bugs.webkit.org/show_bug.cgi?id=51708
3277
3278         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3279         webkit-patch, though the exact meaning of the two options remain different.
3280
3281         * Scripts/prepare-ChangeLog: Add -g.
3282
3283 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3284
3285         Reviewed by Simon Hausmann.
3286
3287         [Qt] Fix compilation with Qt in namespace
3288         https://bugs.webkit.org/show_bug.cgi?id=51701
3289
3290         * QtTestBrowser/webview.h:
3291
3292 2010-12-28  Daniel Bates  <dbates@rim.com>
3293
3294         Reviewed by Sam Weinig.
3295
3296         Substitute // MARK: for compiler-specific #pragma mark
3297         https://bugs.webkit.org/show_bug.cgi?id=51657
3298
3299         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3300         substituting  "// MARK:" for "#pragma mark", which provides
3301         analogous code-bookmarking functionality under Xcode.
3302
3303         Also, for consistency, we should substitute "// MARK:" for compiler-
3304         specific "#pragma mark" in the source files for the Mac port.
3305
3306         * DumpRenderTree/AccessibilityTextMarker.cpp:
3307         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3308         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3309         * DumpRenderTree/mac/ObjCController.m:
3310         * MiniBrowser/mac/AppDelegate.m:
3311         * MiniBrowser/mac/BrowserWindowController.m:
3312
3313 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3314
3315         Reviewed by Eric Seidel.
3316
3317         Add --no-build option to run-sunspider
3318         https://bugs.webkit.org/show_bug.cgi?id=51658
3319
3320         * Scripts/run-sunspider: add --no-build flag to skip building
3321         phase.
3322
3323 2010-12-27  Daniel Bates  <dbates@rim.com>
3324
3325         Rubber-stamped by Martin Robinson.
3326
3327         Append the directory Tools/DumpRenderTree to the list of directories that
3328         do-webcore-rename should search so that it can rename DRT files and
3329         source code.
3330
3331         * Scripts/do-webcore-rename:
3332
3333 2010-12-27  Eric Seidel  <eric@webkit.org>
3334
3335         Reviewed by Adam Barth.
3336
3337         build-webkit should detect missing Java SDK and explain how to install it
3338         https://bugs.webkit.org/show_bug.cgi?id=51651
3339
3340         * Scripts/build-webkit:
3341
3342 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3343
3344         Reviewed by Daniel Bates.
3345
3346         [GTK] Add support for build-jsc
3347         https://bugs.webkit.org/show_bug.cgi?id=51625
3348
3349         Add GTK+ support to build-jsc now that building the jsc executable as
3350         a standalone target is easy.
3351
3352         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3353         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3354         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3355         and pass it along to buildAutotoolsProject.
3356
3357 2010-12-27  David Levin  <levin@chromium.org>
3358
3359         Reviewed by Eric Seidel.
3360
3361         check-webkit-style check for meaningless variable names in function declarations.
3362         https://bugs.webkit.org/show_bug.cgi?id=51523
3363
3364         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3365         from the new check and whitespace/parens because the syntax is unusual and
3366         produced a fair number of positives for these checks.
3367         * Scripts/webkitpy/style/checkers/cpp.py:
3368         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3369         and parameter names when determining if the parameter name is useless.
3370         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3371         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3372         format.
3373         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3374         text or an acronym of it.
3375         (check_function_definition): Checks function definitions for meaningless variable names.
3376         (process_line): Added call to check_function_definition.
3377         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3378         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3379         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3380         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3381         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3382         because when only checking a snippet, there are a lot of bogus functions.
3383         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3384         that I put there previously and just noticed.
3385         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3386         check_function_definition and process_line.
3387
3388 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3389
3390         Reviewed by Martin Robinson.
3391
3392         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3393         https://bugs.webkit.org/show_bug.cgi?id=51591
3394
3395         Flash plugin uses gtk2 that is incompatible with gtk3 making
3396         webkit crash when it's built with gtk3.
3397
3398         * GtkLauncher/main.c:
3399         (main):
3400
3401 2010-12-25  Adam Barth  <abarth@webkit.org>
3402
3403         Reviewed by Eric Seidel.
3404
3405         Move ANGLE to Sources/ThirdParty
3406         https://bugs.webkit.org/show_bug.cgi?id=51605
3407
3408         * Scripts/build-webkit:
3409           - Point to the new ANGLE location.
3410
3411 2010-12-26  David Levin  <levin@chromium.org>
3412
3413         Reviewed by Eric Seidel.
3414
3415         check-webkit-style should be able to parse function declaration parameters.
3416         https://bugs.webkit.org/show_bug.cgi?id=51451
3417
3418         * Scripts/webkitpy/style/checkers/cpp.py:
3419         (Position.__init__): Holds simple position information (row, column).
3420         (Parameter.__init__): Holds information about a parameter.
3421         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3422         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3423         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3424         (find_parameter_name_index): Finds where the parameter name is.
3425         (parameter_list): Generates the list of parameters for a function.
3426         (_FunctionState.begin): Added information to allow determining the parameters
3427         on demand.
3428         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3429         (detect_functions): Improve function detection for operator functions and
3430         determine where the parameters end and pass that to _FunctionState.begin.
3431         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3432         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3433         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3434         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3435         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3436         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3437         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3438         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3439         the parameters found.
3440         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3441         detection test to verify that we catch the operator functions.
3442         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3443         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3444         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3445         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3446         test_function_length_check_definition_severity1_for_test.
3447
3448 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3449
3450         Unreviewed WinCE buildfix after r74334.
3451
3452         * CMakeListsWinCE.txt:
3453
3454 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3455
3456         Unreviewed, rolling out r74632.
3457         http://trac.webkit.org/changeset/74632
3458         https://bugs.webkit.org/show_bug.cgi?id=51600
3459
3460         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3461         on #webkit).
3462
3463         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3464         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3465
3466 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3467
3468         Reviewed by Kenneth Rohde Christiansen.
3469
3470         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3471         https://bugs.webkit.org/show_bug.cgi?id=43528
3472
3473         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3474         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3475         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3476         called.
3477
3478         * EWebLauncher/main.c:
3479         (browserCreate):
3480
3481 2010-12-24  Eric Seidel  <eric@webkit.org>
3482
3483         Reviewed by Adam Barth.
3484
3485         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3486         https://bugs.webkit.org/show_bug.cgi?id=28291
3487
3488         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3489         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3490         to strings with find in the diff.
3491         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3492
3493         * Scripts/webkitpy/common/checkout/api.py:
3494         * Scripts/webkitpy/common/checkout/diff_parser.py:
3495         * Scripts/webkitpy/tool/steps/abstractstep.py:
3496         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3497         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3498         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3499         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3500
3501 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3502
3503         Reviewed by Kenneth Russell.
3504
3505         Modify new-run-webkit-tests to shut up and exit when all the threads
3506         are wedged so that test runs complete faster and we don't end up
3507         w/ enormous log files.
3508
3509         https://bugs.webkit.org/show_bug.cgi?id=51572
3510
3511         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3512         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3513
3514 2010-12-24  Eric Seidel  <eric@webkit.org>
3515
3516         Reviewed by David Levin.
3517
3518         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3519         https://bugs.webkit.org/show_bug.cgi?id=51549
3520
3521         I've had multiple people ask me about the commit-queue's behavior
3522         regarding reporting flaky tests.  I figured it would be best to just
3523         have the queue explain itself in the bugs it files.
3524
3525         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3526         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3527
3528 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3529
3530         Reviewed by Eric Seidel.
3531
3532         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3533         https://bugs.webkit.org/show_bug.cgi?id=51467
3534
3535         * Scripts/webkitpy/style/checker.py:
3536         * Scripts/webkitpy/style/checker_unittest.py:
3537
3538 2010-12-23  Adam Barth  <abarth@webkit.org>
3539
3540         Rubber-stamped by Eric Seidel.
3541
3542         Move JavaScriptGlue into Sources
3543         https://bugs.webkit.org/show_bug.cgi?id=51583
3544
3545         These tools refer to JavaScriptGlue and need to be updated to its new
3546         location.
3547
3548         * Scripts/build-webkit:
3549         * Scripts/do-file-rename:
3550         * Scripts/do-webcore-rename:
3551         * Scripts/webkitpy/common/config/build.py:
3552         * Scripts/webkitpy/common/config/build_unittest.py:
3553
3554 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3555
3556         Reviewed by Eric Seidel.
3557
3558         Bug 51539 - update iexploder scripts to point to new location
3559
3560         * Scripts/run-iexploder-tests:
3561         * Scripts/update-iexploder-cssproperties:
3562
3563 2010-12-23  Evan Martin  <evan@chromium.org>
3564
3565         Reviewed by Ryosuke Niwa.
3566
3567         [chromium] LayoutTestController warning in float->int conversion
3568         https://bugs.webkit.org/show_bug.cgi?id=51553
3569
3570         Rather than reading an int, converting to a float, then getting a compiler
3571         warning on passing the float to something that expects an int, instead
3572         just pass around ints.
3573
3574         No tests, fixes a compiler warning.
3575
3576         * DumpRenderTree/chromium/LayoutTestController.cpp:
3577         (parsePageSizeParameters):
3578         (LayoutTestController::pageNumberForElementById):
3579         (LayoutTestController::numberOfPages):
3580
3581 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3582
3583         Reviewed by Darin Adler.
3584
3585         Bug 51537 - iexploder needs cleanup
3586         
3587         * iExploder/htdocs: Removed.
3588         * iExploder/htdocs/config.rb: Removed.
3589         * iExploder/htdocs/cssproperties.in: Removed.
3590         * iExploder/htdocs/cssvalues.in: Removed.
3591         * iExploder/htdocs/htmlattrs.in: Removed.
3592         * iExploder/htdocs/htmltags.in: Removed.
3593         * iExploder/htdocs/htmlvalues.in: Removed.
3594         * iExploder/htdocs/iexploder.cgi: Removed.
3595         * iExploder/htdocs/iexploder.rb: Removed.
3596         * iExploder/htdocs/index.html: Removed.
3597         * iExploder/htdocs/webserver.rb: Removed.
3598         * iExploder/iexploder-1.7.2/output: Removed.
3599         * iExploder/tools: Removed.
3600         * iExploder/tools/lasthit.rb: Removed.
3601         * iExploder/tools/osx_last_crash.rb: Removed.
3602         * iExploder/tools/showtest.rb: Removed.
3603
3604 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3605
3606         Reviewed by Kenneth Rohde Christiansen.
3607
3608         [EFL] Make 'single' the default backing store in EWebLauncher
3609         https://bugs.webkit.org/show_bug.cgi?id=51534
3610
3611         'single' is the simplest backing store and the one intended to be the
3612         default in the test browser. By mistake the tiled backing store was
3613         left as default in r72617.
3614
3615         * EWebLauncher/main.c:
3616         (browserCreate): ditto.
3617
3618 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3619
3620         Reviewed by Kenneth Rohde Christiansen.
3621
3622         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3623         https://bugs.webkit.org/show_bug.cgi?id=51533
3624
3625         There's no point in concatenating env("HOME") with "blah", so remove
3626         option from EWebLauncher.
3627
3628         * EWebLauncher/main.c:
3629         (main): ditto.
3630
3631 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3632
3633         Reviewed by Eric Seidel.
3634
3635         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3636
3637         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3638         I just discovered that we have two additional GC runs per each WebViewHost.
3639         Test_shell had no such calls.
3640         These gc runs eat 15% of cpu time.
3641
3642         https://bugs.webkit.org/show_bug.cgi?id=51479
3643
3644         * DumpRenderTree/chromium/WebViewHost.cpp:
3645         (WebViewHost::~WebViewHost):
3646
3647 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3648
3649         Reviewed by Ojan Vafai.
3650
3651         This change splits out the TestRunner class into its own file.
3652         When we fork the code for message passing, we will create a new
3653         TestRunner, and this change will allow that to be more modular.
3654
3655         While we're at it, split out TestInput and ResultSummary into
3656         their own files, to reduce the size of run_webkit_tests to
3657         something more managable.
3658
3659         https://bugs.webkit.org/show_bug.cgi?id=51092
3660
3661         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3662         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3663         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3664         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3665         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3666         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3667         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3668
3669  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3670
3671         Reviewed by Ojan Vafai.
3672
3673         nrwt multiprocessing - start over, prepare to fork the code
3674  
3675         This code cleans up the signatures and implementation of the
3676         TestRunner class so we can easily fork it to run either the
3677         stable implementation or the new, unstable message-passing
3678         implementation. The two variants will have different
3679         implementations of the run_tests() method. We will switch
3680         between the two based on the setting for the '--worker-model'
3681         switch. We rename the two currently valid values to 'old-inline'
3682         and 'old-threads'.
3683
3684         https://bugs.webkit.org/show_bug.cgi?id=51081
3685
3686         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3687         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3688
3689 2010-12-22  Victor Wang  <victorw@chromium.org>
3690
3691         Reviewed by Darin Fisher.
3692
3693         [Chromium] Update chromium archive test result url in rebaseline script.
3694
3695         https://bugs.webkit.org/show_bug.cgi?id=51503
3696
3697         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3698
3699 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3700
3701         Reviewed by Alice Liu.
3702
3703         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3704         Verified on Chrome, Safari, and IE.
3705         With this change, we will record memory from a parent browser window and all child processes.
3706
3707         * record-memory-win/main.cpp:
3708         (ProcessArgs):
3709         (PrintUsage):
3710         (getMemoryInfo):
3711         (printProcessInfo):
3712         (evalProcesses):
3713         (UseImage):
3714         (QueryContinuously):
3715         (ElapsedTime):
3716
3717 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3718
3719         Unreviewed rollout r74489, because it was missing changelog.
3720
3721         * record-memory-win/main.cpp:
3722         
3723 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3724
3725         Adding myself as a reviewer.
3726
3727         * Scripts/webkitpy/common/config/committers.py:
3728
3729 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3730
3731         Unreviewed.  Adding myself to committers.py.
3732
3733         * Scripts/webkitpy/common/config/committers.py:
3734
3735 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3736
3737         Reviewed by Kenneth Rohde Christiansen.
3738
3739         TestNetscapePlugIn should use #if defined
3740         https://bugs.webkit.org/show_bug.cgi?id=51471
3741
3742         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3743         (NP_Initialize):
3744         (NPP_New):
3745
3746 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3747
3748         Reviewed by Yury Semikhatsky.
3749
3750         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3751
3752         DevTools window should be closed explicitly because it has custom deinitialization code.
3753
3754         https://bugs.webkit.org/show_bug.cgi?id=50722
3755
3756         * DumpRenderTree/chromium/TestShell.cpp:
3757         (TestShell::closeRemainingWindows):
3758
3759 2010-12-22  David Levin  <levin@chromium.org>
3760
3761         Reviewed by Shinichiro Hamaji.
3762
3763         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3764         https://bugs.webkit.org/show_bug.cgi?id=51452
3765
3766         * Scripts/webkitpy/style/checkers/cpp.py:
3767         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3768         Using the file extension if possible but falling back to the file contents if we have a header file.
3769         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3770         (_FileState.is_c_or_objective_c):
3771         (check_using_std): Changed to using _FileState to determine the file type.
3772         (check_max_min_macros): Ditto.
3773         (check_for_null): Ditto.
3774         (check_style): Changed the parameters to various calls since they now need _FileState
3775         to determine the file type.
3776         (check_language): Added the file_state parameter so it could be passed
3777         to check_identifier_name_in_declaration.
3778         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3779         this is an Objective C file.
3780         (_process_lines): Added information for the _FileState constructor (and moved the
3781         call to a place that had the information).
3782         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3783         (CppFunctionsTest.test_is_c