2011-01-08 Eric Seidel <eric@webkit.org>
[WebKit.git] / Tools / ChangeLog
1 2011-01-08  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Ojan Vafai.
4
5         test_failures.py should not mention TestShell (long live DumpRenderTree!)
6         https://bugs.webkit.org/show_bug.cgi?id=52067
7
8         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
9         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
10
11         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
12
13 2011-01-08  Eric Seidel  <eric@webkit.org>
14
15         Reviewed by Mihai Parparita.
16
17         commit-queue hangs when the ChangeLog diff is bad
18         https://bugs.webkit.org/show_bug.cgi?id=52072
19
20         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
21         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
22
23 2011-01-08  Adam Barth  <abarth@webkit.org>
24
25         Teach svn-apply how to re-write WebCore to Source/WebCore.
26
27         * Scripts/VCSUtils.pm:
28
29 2011-01-07  Adam Barth  <abarth@webkit.org>
30
31         Rubber-stamped by Eric Seidel.
32
33         Move WebCore to Source
34         https://bugs.webkit.org/show_bug.cgi?id=52050
35
36         Update the tools to understand WebCore's new location.
37
38         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
39         * DumpRenderTree/wscript:
40         * GNUmakefile.am:
41         * Scripts/build-webkit:
42         * Scripts/do-file-rename:
43         * Scripts/do-webcore-rename:
44         * Scripts/generate-qt-inspector-resource:
45         * Scripts/prepare-ChangeLog:
46         * Scripts/run-bindings-tests:
47         * Scripts/update-iexploder-cssproperties:
48         * Scripts/update-sources-list.py:
49         * Scripts/update-webkit-localizable-strings:
50         * Scripts/webkitdirs.pm:
51         * Scripts/webkitpy/common/config/build.py:
52         * Scripts/webkitpy/common/config/build_unittest.py:
53         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
54         * Scripts/webkitpy/style/checker.py:
55         * Scripts/webkitpy/style/checker_unittest.py:
56         * WebKitTestRunner/DerivedSources.pro:
57         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
58         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
59         * wx/browser/wscript:
60         * wx/build/settings.py:
61
62 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
63
64         Reviewed by Sam Weinig.
65
66         Make WebKitTestRunner rest between loads more robust to avoid test crashes
67         https://bugs.webkit.org/show_bug.cgi?id=52086
68
69         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
70         (WTR::InjectedBundle::didReceiveMessage):
71         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
72         (WTR::LayoutTestController::notifyDone):
73         * WebKitTestRunner/TestController.cpp:
74         (WTR::TestController::resetStateToConsistentValues):
75         (WTR::TestController::run):
76
77 2011-01-07  James Robinson  <jamesr@chromium.org>
78
79         Revert "Implement mozilla's animationTime property"
80         https://bugs.webkit.org/show_bug.cgi?id=51952
81
82         This approach isn't quite right.
83
84         * DumpRenderTree/chromium/WebViewHost.cpp:
85         (WebViewHost::paintInvalidatedRegion):
86
87 2011-01-07  Adam Roben  <aroben@apple.com>
88
89         Build master fix
90
91         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
92         (RunWebKitTests.start): Don't try to concatenate a list and a string.
93
94 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
95
96         Reviewed by Csaba Osztrogonác.
97
98         run-qtwebkit-tests should be able to kill a testsuite.
99
100         Add new option in the script that can setup a timeout for a test.
101         If the test execution takes more then specified time then the test
102         would be terminated.
103
104         [Qt] run-qtwebkit-tests needs timeout
105         https://bugs.webkit.org/show_bug.cgi?id=51894
106
107         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
108         * Scripts/run-qtwebkit-tests:
109
110 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
111
112         Unreviewed fix after r75233.
113
114         Based on idea from Eric Seidel.
115
116         Add remote zip file handling to webkitpy.
117         https://bugs.webkit.org/show_bug.cgi?id=50901
118
119         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
120
121 2011-01-07  Shane Stephens  <shanestephens@google.com>
122
123         Reviewed by Eric Seidel.
124
125         svn-apply: should support git binary delta diffs
126         https://bugs.webkit.org/show_bug.cgi?id=38864
127
128         * Scripts/VCSUtils.pm:
129         * Scripts/svn-apply:
130
131 2011-01-06  Julie Parent  <jparent@chromium.org>
132
133         Reviewed by Eric Seidel.
134
135         Test Result Server not removing old results.
136         https://bugs.webkit.org/show_bug.cgi?id=52012
137
138         * TestResultServer/model/jsonresults.py:
139         Fix off-by-one: Truncate if >= num_runs, not just >.
140         * TestResultServer/model/jsonresults_unittest.py:
141         Add unit test to test that merging in a new result with the same value
142         as the last result causes previous result to fall off.
143
144 2011-01-06  James Kozianski  <koz@chromium.org>
145
146         Reviewed by Mihai Parparita.
147
148         Add classes to provide a consistent interface to a set of files.
149         https://bugs.webkit.org/show_bug.cgi?id=50901
150
151         These classes allow us to write code that is agnostic to whether a
152         particular set of files resides in a local directory or in a zip file
153         on a remote machine.
154
155         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
156         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
157         * Scripts/webkitpy/common/system/fileset.py: Added.
158         * Scripts/webkitpy/common/system/filesystem.py:
159         * Scripts/webkitpy/common/system/filesystem_mock.py:
160         * Scripts/webkitpy/common/system/zipfileset.py: Added.
161         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
162
163 2011-01-06  Eric Seidel  <eric@webkit.org>
164
165         Reviewed by Adam Barth.
166
167         NetworkTransaction should log the url it is retrying
168         https://bugs.webkit.org/show_bug.cgi?id=52043
169
170         * Scripts/webkitpy/common/net/networktransaction.py:
171         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
172
173 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
174
175         Windows build fix.
176         Import os before using it.
177
178         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
179
180 2011-01-06  Eric Seidel  <eric@webkit.org>
181
182         Reviewed by Adam Barth.
183
184         StyleQueue fails to report errors when patches have many files
185         https://bugs.webkit.org/show_bug.cgi?id=52042
186
187         This is one of at least two errors preventing style error reporting at the moment.
188         When we moved to passing the list of files to check explicitly,
189         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
190         We could change the type of the QueueStatus.message type, or we could
191         just teach statusserver.py how to clamp values (and warn when it does).
192         I chose the latter path.
193
194         * Scripts/webkitpy/common/net/statusserver.py:
195
196 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
197
198         Reviewed by Stephanie Lewis.
199         
200         Fix syntax error in script.
201
202         Windows bots need to archive/unarchive builds to/from configuration-specific directories
203         https://bugs.webkit.org/show_bug.cgi?id=51996
204
205         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
206
207 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
208
209         Unreviewed, fixing WinCE build after r75196.
210
211         WinCE port does not (yet) support NPAPI.
212
213         * Scripts/build-webkit:
214
215 2011-01-06  Xan Lopez  <xlopez@igalia.com>
216
217         Reviewed by Darin Adler.
218
219         File::Spec->rel2abs in sunspider-compare-results mangles parameters
220         https://bugs.webkit.org/show_bug.cgi?id=52015
221
222         * Scripts/sunspider-compare-results: call rel2abs on our arguments
223         after the platform has been detected, otherwise the script will
224         mangle things like '--gtk' into '/a/path/--gtk', breaking the
225         detection.
226
227 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
228
229         Reviewed by Eric Seidel.
230
231         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
232         https://bugs.webkit.org/show_bug.cgi?id=51346
233
234         * Scripts/build-webkit:
235
236 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
237
238         Reviewed by Adam Roben.
239
240         Windows bots need to archive/unarchive builds to/from configuration-specific directories
241         https://bugs.webkit.org/show_bug.cgi?id=51996
242         
243         After the configuration directory change, we were archiving the incorrect directory for
244         build product, so we were running tests on the wrong binaries.
245         
246         This change archives the correct directory, and also unarchives it into a configuration-
247         specific directory.
248
249         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
250         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
251
252 2011-01-06  Eric Seidel  <eric@webkit.org>
253
254         Reviewed by Mihai Parparita.
255
256         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
257         https://bugs.webkit.org/show_bug.cgi?id=52002
258
259         See an example of this here:
260         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
261
262         It's due to the fact that we pass around TestFailure() instance
263         objects and yet expect them to all compare to be the same.
264
265         This is bad.  We should either have shared instances of these values
266         or we should just pass around the class names.  There are already hacks
267         in place to make TestFailure objects pass equality tests, I just added
268         a __hash__ implementation so they can be used in sets as expected.
269
270         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
271         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
272
273 2011-01-06  Evan Martin  <evan@chromium.org>
274
275         Reviewed by Tony Chang.
276
277         [gdb] handle inaccessible memory and UChar*
278         https://bugs.webkit.org/show_bug.cgi?id=52003
279
280         To pretty-print a UChar*, we just grope around in the memory
281         looking for a terminating NUL.  We need to handle the exception
282         that can occur when we poke into an invalid location.
283
284         Additionally, the logic for choosing which pretty-printer would
285         early return before hitting the point where we'd use the UChar*
286         printer.  (Did this ever work?  How did it regress?)
287
288         * gdb/webkit.py:
289
290 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
291
292         Reviewed by Ada Chan.
293
294         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
295         https://bugs.webkit.org/show_bug.cgi?id=51969
296         
297         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
298
299         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
300         (WTR::InjectedBundlePage::InjectedBundlePage):
301         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
302         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
303
304 2011-01-06  James Robinson  <jamesr@chromium.org>
305
306         Reviewed by Simon Fraser.
307
308         Implement mozilla's animationTime property
309         https://bugs.webkit.org/show_bug.cgi?id=51952
310
311         Chromium DRT support for webkitAnimationTime.
312
313         * DumpRenderTree/chromium/WebViewHost.cpp:
314         (WebViewHost::paintInvalidatedRegion):
315
316 2011-01-06  Julie Parent  <jparent@chromium.org>
317
318         Reviewed by Tony Chang.
319
320         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
321         https://bugs.webkit.org/show_bug.cgi?id=51217
322
323         * TestResultServer/model/jsonresults.py:
324         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
325         Adds missing documentation.
326         * TestResultServer/model/jsonresults_unittest.py:
327         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
328         Update test_merge to take a number of builds to truncate at.
329
330 2011-01-06  Adam Barth  <abarth@webkit.org>
331
332         Reviewed by Eric Seidel.
333
334         The EWS should log outside of the working directory
335         https://bugs.webkit.org/show_bug.cgi?id=51986
336
337         This patch prepare us for using git clean -x -d -f in the EWS wrapper
338         script, which will actually clean the working copy back to a pristine
339         state instead of leaving untracked directories and ignored files.
340
341         * Scripts/webkitpy/tool/commands/queues.py:
342         * Scripts/webkitpy/tool/commands/queues_unittest.py:
343
344 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
345
346         Windows build fix.
347         Back out attempted change to built-product-archive.
348
349         * BuildSlaveSupport/built-product-archive:
350
351 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
352
353         Windows build fix.
354         Include configuration name when unpacking a build archive.
355
356         Needed, since we split Windows build results into configuration-specific directories
357         under WebKitOutputDir.
358
359         * BuildSlaveSupport/built-product-archive:
360
361 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
362
363         Reviewed by Darin Adler.
364
365         Debug and Release builds on Windows clobber each other
366         https://bugs.webkit.org/show_bug.cgi?id=49185
367
368         Changes the structure of WebKitBuild build products directory so we
369         completely separate each build configuration into independent directories.
370         
371         Although we previously had per-configuration directories for obj, this change adds
372         per-configuration directories for bin, lib, obj, and include. Each configuration's
373         build products are stored within a directory inside of WebKitBuild.
374         
375         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
376         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
377
378         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
379         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
380         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
381         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
382         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
383         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
384         * DumpRenderTree/win/ImageDiffCommon.vsprops:
385         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
386         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
387         * FindSafari/FindSafari.vcproj:
388         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
389         * MiniBrowser/MiniBrowserPostBuild.cmd:
390         * MiniBrowser/MiniBrowserPreBuild.cmd:
391         * Scripts/webkitdirs.pm:
392         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
393         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
394         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
395         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
396         * TestWebKitAPI/win/copy-resources.cmd:
397         * WebKitAPITest/WebKitAPITestCommon.vsprops:
398         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
399         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
400         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
401         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
402         * WebKitTestRunner/win/InjectedBundle.vcproj:
403         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
404         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
405         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
406         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
407         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
408         * WinLauncher/WinLauncherCommon.vsprops:
409         * WinLauncher/WinLauncherPostBuild.cmd:
410         * WinLauncher/WinLauncherPreBuild.cmd:
411
412 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
413
414         Reviewed by Ariya Hidayat.
415
416         [Qt] TestNetscapePlugin doesn't link on OS X
417         https://bugs.webkit.org/show_bug.cgi?id=51948
418
419         Only add a dependency on libX11 on X11 systems
420
421         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
422
423 2011-01-05  Jeff Miller  <jeffm@apple.com>
424
425         Reviewed by Adam Roben.
426
427         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
428         https://bugs.webkit.org/show_bug.cgi?id=51970
429
430         * Scripts/webkitpy/style/checker.py:
431         Add -readability/naming for WebKit2 C API directories.
432
433 2011-01-05  Eric Seidel  <eric@webkit.org>
434
435         Unreviewed, just fixing one more log error from my previous python patch.
436
437         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
438         https://bugs.webkit.org/show_bug.cgi?id=51802
439
440         webkit-patch failure-reason was logging about parsing errors
441         due to my misunderstanding of how BeautifulSoup.findAll worked.
442
443         Fixed, and added a unit test.
444
445         * Scripts/webkitpy/common/net/layouttestresults.py:
446         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
447
448 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
449
450         Reviewed by Kenneth Rohde Christiansen.
451
452         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
453         https://bugs.webkit.org/show_bug.cgi?id=51951
454
455         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
456         to create new window from WebKit.
457
458         * MiniBrowser/qt/BrowserWindow.cpp:
459         (newPageFunction):
460         (BrowserWindow::BrowserWindow):
461         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
462         (BrowserWindow::newWindow):
463         (BrowserWindow::updateUserAgentList):
464         (BrowserWindow::showUserAgentDialog):
465         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
466         define the type of the backing store used for new windows.
467         * MiniBrowser/qt/main.cpp:
468         (main):
469
470 2011-01-05  Eric Seidel  <eric@webkit.org>
471
472         Reviewed by Ojan Vafai.
473
474         commit-queue should report failure type when reporting flaky tests
475         https://bugs.webkit.org/show_bug.cgi?id=51900
476
477         This patch was a ridiculous amount of plumbing.  In the end I like
478         the NRWT-style TestResult class even less.  But now we're passing
479         a list of TestResult objects from the queue to the FlakyTestReporter.
480         Thus the FlakyTestReporter can more easily report what type of failure
481         occurred.
482
483         In the process, I found that I was not alone in finding TestResult
484         cumbersome to use.  A bunch of code was trying to create a TestResult
485         object with default values.  However since the constructor didn't make
486         this easy, some places were getting it wrong (including the TestResult unit test)!
487         I've fixed the TestResult constructor to have default values for non-essential
488         arguments.
489
490         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
491         * Scripts/webkitpy/common/net/layouttestresults.py:
492         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
493         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
494         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
495         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
496         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
497         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
498         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
499         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
500         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
501         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
502         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
503         * Scripts/webkitpy/tool/commands/queues.py:
504         * Scripts/webkitpy/tool/commands/queues_unittest.py:
505
506 2011-01-05  Eric Seidel  <eric@webkit.org>
507
508         Unreviewed.
509
510         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
511         https://bugs.webkit.org/show_bug.cgi?id=51802
512
513         Add another unit test to cover a previously missing import.
514
515         * Scripts/webkitpy/common/net/layouttestresults.py:
516         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
517
518 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
519
520         Reviewed by David Levin.
521
522         Add mihaip@chromium.org as a reviewer
523         https://bugs.webkit.org/show_bug.cgi?id=51966
524         
525         Add myself as a reviewer.
526
527         * Scripts/webkitpy/common/config/committers.py:
528
529 2011-01-05  James Simonsen  <simonjam@chromium.org>
530
531         Unreviewed. Adding myself to the list of committers.
532
533         * Scripts/webkitpy/common/config/committers.py:
534
535 2011-01-05  Eric Seidel  <eric@webkit.org>
536
537         Unreviewed.
538
539         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
540         https://bugs.webkit.org/show_bug.cgi?id=51802
541
542         Fix two exceptions seen on the bots after my original commit.
543
544         * Scripts/webkitpy/common/net/layouttestresults.py:
545         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
546
547 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
548
549         Reviewed by Andreas Kling.
550
551         [Qt]Add local storage settings to QtTestBrowser command line arguments 
552         https://bugs.webkit.org/show_bug.cgi?id=51750
553
554         * QtTestBrowser/main.cpp:
555         (LauncherApplication::handleUserOptions):
556          Local storage settings can be enable form command line arguments for
557          QtTestBrowser.
558
559 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
560
561         Reviewed by Martin Robinson.
562
563         GTK: AX: DRT needs to use correct root object method.
564         https://bugs.webkit.org/show_bug.cgi?id=51911
565
566         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
567         (AccessibilityController::rootElement):
568
569 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
570
571         Rubber-stamped by Csaba Osztrogonác.
572
573         Based on idea from Péter Gál.
574
575         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
576
577 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
578
579         Reviewed by Adam Barth.
580
581         sheriff-bot should be able to do multi-revision rollouts
582         https://bugs.webkit.org/show_bug.cgi?id=51176
583
584         * Scripts/webkitpy/tool/bot/irc_command.py:
585         * Scripts/webkitpy/tool/bot/sheriff.py:
586         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
587
588 2011-01-05  Eric Seidel  <eric@webkit.org>
589
590         Reviewed by Adam Barth.
591
592         queues.webkit.org should have per-bot status pages
593         https://bugs.webkit.org/show_bug.cgi?id=51906
594
595         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
596         statuses from a single queue.  Now that we have many bots servicing
597         some queues (commit-queue, win-ews, etc.) its easy to have the messages
598         you care about scroll off the end of the 15-message limit on the main page.
599
600         Eventually we should probably rename /queue-status to /queue or /queues,
601         but that's fodder for another patch.
602
603         * QueueStatusServer/handlers/queuestatus.py:
604         * QueueStatusServer/index.yaml:
605         * QueueStatusServer/main.py:
606         * QueueStatusServer/templates/includes/singlequeuestatus.html:
607          - This probably should use a custom filter instead of hard-coding
608            the URL scheme here, but I couldn't figure out how to easily
609            create such a filter.  Most filters work with "strings" so we can't
610            pass the status object.  We could add a method to the status
611            object and call that, but that seemed a bit strange too.
612         * QueueStatusServer/templates/queuestatus.html:
613
614 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
615
616         Unreviewed. Adding myself to the list of committers.
617
618         * Scripts/webkitpy/common/config/committers.py:
619
620 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
621
622         Reviewed by David Levin.
623
624         check-webkit-style treated some macros with parentheses after #elif as function calls
625         https://bugs.webkit.org/show_bug.cgi?id=51695
626
627         Ingore function call space checking in any preprocessor directives
628         (things starting with #). Change search() to match() because 
629         preprocessor directives are supposed to be in the beginning of lines.
630
631         * Scripts/webkitpy/style/checkers/cpp.py:
632         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
633
634 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
635
636         Reviewed by Tony Chang.
637
638         Change the --multi-load test option to --stress-opt
639         https://bugs.webkit.org/show_bug.cgi?id=50751
640
641         * DumpRenderTree/chromium/DumpRenderTree.cpp:
642         (runTest):
643         (main):
644         * DumpRenderTree/chromium/TestShell.cpp:
645         (TestShell::TestShell):
646         * DumpRenderTree/chromium/TestShell.h:
647         (TestShell::stressOpt):
648         (TestShell::setStressOpt):
649         (TestShell::stressDeopt):
650         (TestShell::setStressDeopt):
651         (TestShell::javaScriptFlags):
652         (TestShell::setJavaScriptFlags):
653         * Scripts/webkitpy/layout_tests/port/chromium.py:
654         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
655
656 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
657
658         Reviewed by Sam Weinig.
659
660         WK2: Support Accessibility
661         https://bugs.webkit.org/show_bug.cgi?id=51859
662
663         Use rootObject() method to get top of accessibility tree.
664
665         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
666         (AccessibilityController::focusedElement):
667         (AccessibilityController::rootElement):
668
669 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
670
671         Reviewed by Darin Adler.
672
673         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
674         https://bugs.webkit.org/show_bug.cgi?id=51846
675
676         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
677         back to GRefPtr.
678
679 2011-01-04  Zhe Su  <suzhe@chromium.org>
680
681         Reviewed by Kenneth Russell.
682
683         Fix insertText, setMarkedText and unmarkText methods of
684         TextInputController to call corresponding methods of WebKit::WebView
685         rather than WebKit::WebFrame. This change matches the behavior of
686         chromium browser.
687         insertText corresponds to WebView::confirmComposition(text)
688         setMarkedText corresponds to WebView::setComposition(...)
689         unmarkText corresponds to WebView::confirmComposition()
690         https://bugs.webkit.org/show_bug.cgi?id=51693
691
692         * DumpRenderTree/chromium/TextInputController.cpp:
693         (TextInputController::insertText):
694         (TextInputController::setMarkedText):
695         (TextInputController::unmarkText):
696
697 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
698
699         Reviewed by Laszlo Gombos.
700
701         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
702
703         On Symbian productDir points to the source directory. Removing all the
704         empty files from the productDir directory corrupts the svn repository.
705
706         * Scripts/build-webkit:
707
708 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
709
710         Reviewed by Adam Barth.
711
712         [Qt] Add SelectAll option to the context menu for the editor
713         https://bugs.webkit.org/show_bug.cgi?id=50049
714
715         Set shortcut for the SelectAll action.
716
717         * QtTestBrowser/mainwindow.cpp:
718         (MainWindow::buildUI):
719
720 2011-01-03  David Levin  <levin@chromium.org>
721
722         Reviewed by Eric Seidel.
723
724         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
725         https://bugs.webkit.org/show_bug.cgi?id=51842
726
727         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
728         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
729
730 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
731
732         Reviewed by David Kilzer.
733
734         [WINCE] Adds a build slave.
735         https://bugs.webkit.org/show_bug.cgi?id=50523
736
737         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
738         entry for a release build of the WinCE port.
739         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
740         flag to build the WinCE port.
741
742 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
743
744         Reviewed by David Kilzer.
745
746         Add WinCE support to build-webkit
747         https://bugs.webkit.org/show_bug.cgi?id=51642
748
749         * Scripts/build-webkit:
750         * Scripts/webkitdirs.pm:
751
752 2011-01-03  Eric Seidel  <eric@webkit.org>
753
754         Reviewed by Adam Barth.
755
756         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
757         https://bugs.webkit.org/show_bug.cgi?id=51802
758
759         I'm not the biggest fan of the test_failures or test_results classes,
760         but it's better to have one shared set of classes, than separate ones
761         for new vs. old run-webkit-test result handling.
762
763         This moves the ORWT results class "LayoutTestResults" over to using
764         TestResult and TestFailure classes, making it easy for us to
765         make all our sheriff-bot and other webkitpy code NRWT ready.
766
767         This also makes it a trivial patch to generate results.json information
768         from ORWT results.html files (for flaky test analysis, etc.) as well
769         as making it a one-liner to report test failure types when the
770         commit-queue sees flaky tests.
771
772         This patch tried not to add new functionality, but only to replace
773         the guts of LayoutTestResults, while adding unit tests and hoping
774         not to break anything.
775
776         I also moved callers which assumed User.prompt* were static/class methods
777         to using them as instance methods (since we'll eventually want to make them such).
778
779         In the process of re-writing things, I broke the rebaseline command, so I wrote
780         a unit test to catch my breakage were I do do so again in the future.
781
782         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
783         * Scripts/webkitpy/common/net/layouttestresults.py:
784         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
785         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
786         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
787         * Scripts/webkitpy/tool/commands/queries.py:
788         * Scripts/webkitpy/tool/commands/rebaseline.py:
789         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
790         * Scripts/webkitpy/tool/mocktool.py:
791
792 2011-01-03  Adam Barth  <abarth@webkit.org>
793
794         Reviewed by Simon Fraser.
795
796         webkit-patch shouldn't waste time cleaning a working directory that's already clean
797         https://bugs.webkit.org/show_bug.cgi?id=51840
798
799         * Scripts/webkitpy/common/checkout/scm.py:
800
801 2011-01-03  Adam Barth  <abarth@webkit.org>
802
803         Reviewed by Simon Fraser.
804
805         webkit-patch should only hide update output if --quiet
806         https://bugs.webkit.org/show_bug.cgi?id=51838
807
808         As requested by smfr.
809
810         * Scripts/webkitpy/tool/steps/update.py:
811
812 2011-01-03  Adam Barth  <abarth@webkit.org>
813
814         Reviewed by David Levin.
815
816         commit-queue shouldn't reject patches twice if two bots process the same patch
817         https://bugs.webkit.org/show_bug.cgi?id=51805
818
819         Before raising an error, we first check whether the patch is still in
820         the commit-queue.  This check is still racy, of course, but the time
821         window is much smaller.
822
823         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
824
825 2011-01-03  Sam Weinig  <sam@webkit.org>
826
827         Reviewed by Anders Carlsson.
828
829         Make run-api-tests less chatty.
830         https://bugs.webkit.org/show_bug.cgi?id=51831
831
832         - Make script quiet by default and add --verbose option (replacing --quiet).
833         - When not verbose, pipe stdout and stderr to devnull.
834
835         * Scripts/run-api-tests:
836
837 2011-01-03  Pratik Solanki  <psolanki@apple.com>
838
839         Unreviewed. Adding myself to committers.py.
840
841         * Scripts/webkitpy/common/config/committers.py:
842
843 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
844
845         Reviewed by Xan Lopez.
846
847         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
848         https://bugs.webkit.org/show_bug.cgi?id=51806
849
850         Originally, the $libraryName is 'JavaScriptCore'. When building release 
851         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
852         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
853         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
854         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
855         so make it 'WebKitBuild/Release/.libs'
856
857         * Scripts/webkitdirs.pm: 
858
859 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
860
861         Reviewed by Adam Barth.
862
863         Make EFL a core builder
864         https://bugs.webkit.org/show_bug.cgi?id=51804
865
866         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
867         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
868
869 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
870
871         [Qt] Unreviewed fix after r74855 and r74875.
872
873         * BuildSlaveSupport/built-product-archive:
874          - Create directories explicitly.
875          - Pass shell=True to subprocess.call().
876
877 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
878
879         [Qt] Unreviewed fix after r74855.
880
881         Move JavaScriptCore to Source
882         https://bugs.webkit.org/show_bug.cgi?id=51604
883
884         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
885
886 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
887
888         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
889
890         Move JavaScriptCore to Source
891         https://bugs.webkit.org/show_bug.cgi?id=51604
892
893         * Scripts/webkitdirs.pm:
894
895 2011-01-02  Robert Hogan  <robert@webkit.org>
896
897         Unreviewed, build fix.
898
899         [Qt] Fix DRT build after 74855
900
901         * DumpRenderTree/qt/DumpRenderTree.pro:
902
903 2011-01-01  Adam Barth  <abarth@webkit.org>
904
905         Remove the assumption from the Qt and Gtk builds that every project is
906         in the root directory.
907
908         * Scripts/build-webkit:
909
910 2011-01-01  Adam Barth  <abarth@webkit.org>
911
912         Reviewed by Eric Seidel.
913
914         Teach svn-apply how to apply patches even though JavaScriptCore has moved
915         https://bugs.webkit.org/show_bug.cgi?id=51796
916
917         After this change, svn-apply will magically apply patches to
918         JavaScriptCore/foo to Source/JavaScriptCore/foo.
919
920         * Scripts/VCSUtils.pm:
921
922 2011-01-01  Adam Barth  <abarth@webkit.org>
923
924         Reviewed by Eric Seidel.
925
926         Move JavaScriptCore to Source
927         https://bugs.webkit.org/show_bug.cgi?id=51604
928
929         Update references to JavaScriptCore to point to the new location.
930
931         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
932         * DumpRenderTree/qt/DumpRenderTree.pro:
933         * DumpRenderTree/qt/ImageDiff.pro:
934         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
935         * DumpRenderTree/wscript:
936         * Scripts/build-jsc:
937         * Scripts/build-webkit:
938         * Scripts/do-file-rename:
939         * Scripts/do-webcore-rename:
940         * Scripts/run-javascriptcore-tests:
941         * Scripts/update-javascriptcore-test-results:
942         * Scripts/webkitdirs.pm:
943         * Scripts/webkitpy/common/config/build_unittest.py:
944         * Scripts/webkitpy/style/checker.py:
945         * Scripts/webkitpy/style/checker_unittest.py:
946         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
947         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
948         * WebKitTestRunner/qt/WebKitTestRunner.pro:
949         * wx/build/settings.py:
950
951 2011-01-01  Adam Barth  <abarth@webkit.org>
952
953         Reviewed by Eric Seidel.
954
955         Move Sources to Source
956         https://bugs.webkit.org/show_bug.cgi?id=51794
957
958         Update scripts to point to the new location.
959
960         * Scripts/build-webkit:
961         * Scripts/do-file-rename:
962         * Scripts/do-webcore-rename:
963         * Scripts/webkitpy/common/config/build.py:
964         * Scripts/webkitpy/common/config/build_unittest.py:
965
966 2010-12-31  Kent Tamura  <tkent@chromium.org>
967
968         Reviewed by Eric Seidel.
969
970         [DRT/Chromium] Enable mock spell checker on non-OSX
971         https://bugs.webkit.org/show_bug.cgi?id=51401
972
973         * DumpRenderTree/chromium/WebViewHost.cpp:
974         (WebViewHost::spellCheck):
975
976 2010-12-31  Adam Barth  <abarth@webkit.org>
977
978         Reviewed by Ariya Hidayat.
979
980         Remove Tools/Scripts/wkstyle
981         https://bugs.webkit.org/show_bug.cgi?id=51774
982
983         This script appears to not have been touched in a while and seems to
984         have been replaced by check-webkit-style.
985
986         * Scripts/wkstyle: Removed.
987
988 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
989
990         Unreviewed. Coding style fix.
991
992         * DumpRenderTree/chromium/TestShell.h:
993
994 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
995
996         Reviewed by Pavel Feldman.
997
998         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
999
1000         It was a problem with Chromium DRT. DevToolsAgent object instance was
1001         attached not only to the inspected page but to the DevTools window too.
1002         As result all the inspector files were interpreted as a content of inspected page
1003         and were transfered to the DevTools scripts panel for debugging etc.
1004
1005         https://bugs.webkit.org/show_bug.cgi?id=51735
1006
1007         * DumpRenderTree/chromium/TestShell.cpp:
1008         (TestShell::TestShell):
1009         (TestShell::bindJSObjectsToWindow):
1010         (TestShell::createNewWindow):
1011         * DumpRenderTree/chromium/TestShell.h:
1012
1013 2010-12-31  Adam Barth  <abarth@webkit.org>
1014
1015         Rubber-stamped by Eric Seidel.
1016
1017         Move PageLoadTests to PerformanceTests/PageLoad
1018         https://bugs.webkit.org/show_bug.cgi?id=51771
1019
1020         Update references to PageLoadTests to point to the new location.
1021
1022         * Scripts/run-pageloadtest:
1023         * Scripts/webkitpy/common/config/build.py:
1024
1025 2010-12-31  Adam Barth  <abarth@webkit.org>
1026
1027         Rubber-stamped by Eric Seidel.
1028
1029         Move SunSpider into PerformanceTests
1030         https://bugs.webkit.org/show_bug.cgi?id=51769
1031
1032         Update these scripts to point to the new location.
1033
1034         * Scripts/run-sunspider:
1035         * Scripts/sunspider-compare-results:
1036
1037 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
1038
1039         Reviewed by Kent Tamura.
1040
1041         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
1042         https://bugs.webkit.org/show_bug.cgi?id=51728
1043         
1044         Add implementation of the Mac WebThemeEngine that uses an NSScroller
1045         to render top-level scrollbars. This makes them match the Mac port's
1046         use of an NSScrollView, which means that we'll be able to share more
1047         pixel baselines.
1048         
1049         The new rendering code will not be activated until the 
1050         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
1051         ScrollbarThemeChromiumMac.
1052
1053         * DumpRenderTree/DumpRenderTree.gypi:
1054         * DumpRenderTree/chromium/TestShellMac.mm:
1055         (platformInit):
1056         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
1057         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
1058         (+[FakeActiveWindow alwaysActiveWindow]):
1059         (+[FakeActiveWindow alwaysInactiveWindow]):
1060         (-[FakeActiveWindow initWithActiveControls:]):
1061         (-[FakeActiveWindow _hasActiveControls]):
1062         (WebThemeEngineDRTMac::paintScrollbarThumb):
1063         (stateToHIEnableState):
1064         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1065         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1066
1067 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
1068
1069         Reviewed by David Kilzer.
1070
1071         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
1072         used
1073         https://bugs.webkit.org/show_bug.cgi?id=51672
1074
1075         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
1076         with USE_SYSTEM_MALLOC=1
1077         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
1078         with USE_SYSTEM_MALLOC=1
1079
1080 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1081
1082         Reviewed by David Kilzer.
1083
1084         [Qt] [Symbian] Fix build-webkit script for Symbian
1085         https://bugs.webkit.org/show_bug.cgi?id=51509
1086
1087         Set the OUTPUT_DIR for Symbian to be the same as the source
1088         directory.
1089
1090         * Scripts/webkitdirs.pm:
1091
1092 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
1093
1094         Reviewed by Darin Adler.
1095
1096         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
1097         https://bugs.webkit.org/show_bug.cgi?id=51758
1098
1099         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
1100
1101         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
1102         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
1103
1104 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1105
1106         Unreviewed WinCE buildfix.
1107
1108         * WinCELauncher/main.cpp: Add missing include.
1109
1110 2010-12-29  Daniel Bates  <dbates@rim.com>
1111
1112         Reviewed by Darin Adler.
1113
1114         svn-apply updates date of wrong change log entry for a change log diff that
1115         contains two consecutive entries with the same author and date
1116         https://bugs.webkit.org/show_bug.cgi?id=46061
1117
1118         Fixes an issue where the date of the wrong change log entry may be modified.
1119         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
1120         in a ChangeLog file to the top of the file.
1121
1122         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
1123         diff when it detects that the diff inserts a change log entry earlier in a
1124         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
1125         change. With the advent of the commit-queue this functionality of bailing out
1126         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
1127         Instead, we should always move the change log entry to the top of the ChangeLog file.
1128
1129         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
1130         the date line of the correct change log entry in a ChangeLog diff.
1131
1132         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
1133
1134         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1135           Updated the following unit tests now that we move entries inserted earlier to the top:
1136           - "fixChangeLogPatch: New entry inserted in middle."
1137             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
1138
1139           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
1140             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
1141
1142         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
1143
1144 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
1145
1146         Reviewed by Eric Seidel.
1147
1148         [Qt] Fixed compatibility with gold linker on X11 platforms
1149         https://bugs.webkit.org/show_bug.cgi?id=51700
1150
1151         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1152         Linked TestNetscapePlugin with libX11 on Unix platforms
1153
1154 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1155
1156         Reviewed by Darin Adler.
1157
1158         Circular dependency in webkitpy.common.checkout.changelog module
1159         https://bugs.webkit.org/show_bug.cgi?id=50475
1160
1161         Remove automatic import of api.Checkout module when any checkout/
1162         submodule is imported (e.g.: when checkout.scm.Git is imported).
1163
1164         * Scripts/webkitpy/common/checkout/__init__.py:
1165
1166 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
1167
1168         Reviewed by Ojan Vafai.
1169
1170         prepare-ChangeLog should support the -g option for specifying the git-commit
1171         https://bugs.webkit.org/show_bug.cgi?id=51708
1172
1173         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
1174         webkit-patch, though the exact meaning of the two options remain different.
1175
1176         * Scripts/prepare-ChangeLog: Add -g.
1177
1178 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
1179
1180         Reviewed by Simon Hausmann.
1181
1182         [Qt] Fix compilation with Qt in namespace
1183         https://bugs.webkit.org/show_bug.cgi?id=51701
1184
1185         * QtTestBrowser/webview.h:
1186
1187 2010-12-28  Daniel Bates  <dbates@rim.com>
1188
1189         Reviewed by Sam Weinig.
1190
1191         Substitute // MARK: for compiler-specific #pragma mark
1192         https://bugs.webkit.org/show_bug.cgi?id=51657
1193
1194         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
1195         substituting  "// MARK:" for "#pragma mark", which provides
1196         analogous code-bookmarking functionality under Xcode.
1197
1198         Also, for consistency, we should substitute "// MARK:" for compiler-
1199         specific "#pragma mark" in the source files for the Mac port.
1200
1201         * DumpRenderTree/AccessibilityTextMarker.cpp:
1202         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
1203         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1204         * DumpRenderTree/mac/ObjCController.m:
1205         * MiniBrowser/mac/AppDelegate.m:
1206         * MiniBrowser/mac/BrowserWindowController.m:
1207
1208 2010-12-28  Xan Lopez  <xlopez@igalia.com>
1209
1210         Reviewed by Eric Seidel.
1211
1212         Add --no-build option to run-sunspider
1213         https://bugs.webkit.org/show_bug.cgi?id=51658
1214
1215         * Scripts/run-sunspider: add --no-build flag to skip building
1216         phase.
1217
1218 2010-12-27  Daniel Bates  <dbates@rim.com>
1219
1220         Rubber-stamped by Martin Robinson.
1221
1222         Append the directory Tools/DumpRenderTree to the list of directories that
1223         do-webcore-rename should search so that it can rename DRT files and
1224         source code.
1225
1226         * Scripts/do-webcore-rename:
1227
1228 2010-12-27  Eric Seidel  <eric@webkit.org>
1229
1230         Reviewed by Adam Barth.
1231
1232         build-webkit should detect missing Java SDK and explain how to install it
1233         https://bugs.webkit.org/show_bug.cgi?id=51651
1234
1235         * Scripts/build-webkit:
1236
1237 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
1238
1239         Reviewed by Daniel Bates.
1240
1241         [GTK] Add support for build-jsc
1242         https://bugs.webkit.org/show_bug.cgi?id=51625
1243
1244         Add GTK+ support to build-jsc now that building the jsc executable as
1245         a standalone target is easy.
1246
1247         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
1248         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
1249         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
1250         and pass it along to buildAutotoolsProject.
1251
1252 2010-12-27  David Levin  <levin@chromium.org>
1253
1254         Reviewed by Eric Seidel.
1255
1256         check-webkit-style check for meaningless variable names in function declarations.
1257         https://bugs.webkit.org/show_bug.cgi?id=51523
1258
1259         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
1260         from the new check and whitespace/parens because the syntax is unusual and
1261         produced a fair number of positives for these checks.
1262         * Scripts/webkitpy/style/checkers/cpp.py:
1263         (_convert_to_lower_with_underscores): Used as a canonical form for type names
1264         and parameter names when determining if the parameter name is useless.
1265         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
1266         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
1267         format.
1268         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
1269         text or an acronym of it.
1270         (check_function_definition): Checks function definitions for meaningless variable names.
1271         (process_line): Added call to check_function_definition.
1272         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1273         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
1274         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
1275         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
1276         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
1277         because when only checking a snippet, there are a lot of bogus functions.
1278         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
1279         that I put there previously and just noticed.
1280         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
1281         check_function_definition and process_line.
1282
1283 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1284
1285         Reviewed by Martin Robinson.
1286
1287         [GTK] Disable flash plugin in GtkLauncher when using gtk3
1288         https://bugs.webkit.org/show_bug.cgi?id=51591
1289
1290         Flash plugin uses gtk2 that is incompatible with gtk3 making
1291         webkit crash when it's built with gtk3.
1292
1293         * GtkLauncher/main.c:
1294         (main):
1295
1296 2010-12-25  Adam Barth  <abarth@webkit.org>
1297
1298         Reviewed by Eric Seidel.
1299
1300         Move ANGLE to Sources/ThirdParty
1301         https://bugs.webkit.org/show_bug.cgi?id=51605
1302
1303         * Scripts/build-webkit:
1304           - Point to the new ANGLE location.
1305
1306 2010-12-26  David Levin  <levin@chromium.org>
1307
1308         Reviewed by Eric Seidel.
1309
1310         check-webkit-style should be able to parse function declaration parameters.
1311         https://bugs.webkit.org/show_bug.cgi?id=51451
1312
1313         * Scripts/webkitpy/style/checkers/cpp.py:
1314         (Position.__init__): Holds simple position information (row, column).
1315         (Parameter.__init__): Holds information about a parameter.
1316         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
1317         (SingleLineView.convert_column_to_row): Returns the original row given a column.
1318         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
1319         (find_parameter_name_index): Finds where the parameter name is.
1320         (parameter_list): Generates the list of parameters for a function.
1321         (_FunctionState.begin): Added information to allow determining the parameters
1322         on demand.
1323         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
1324         (detect_functions): Improve function detection for operator functions and
1325         determine where the parameters end and pass that to _FunctionState.begin.
1326         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1327         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
1328         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
1329         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
1330         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
1331         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
1332         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
1333         (FunctionDetectionTest.perform_function_detection): Added support for verifying
1334         the parameters found.
1335         (FunctionDetectionTest.test_function_declaration_detection): Added more function
1336         detection test to verify that we catch the operator functions.
1337         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
1338         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
1339         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
1340         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
1341         test_function_length_check_definition_severity1_for_test.
1342
1343 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
1344
1345         Unreviewed WinCE buildfix after r74334.
1346
1347         * CMakeListsWinCE.txt:
1348
1349 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1350
1351         Unreviewed, rolling out r74632.
1352         http://trac.webkit.org/changeset/74632
1353         https://bugs.webkit.org/show_bug.cgi?id=51600
1354
1355         makes test-webkitpy hang forever on GTK (Requested by philn-tp
1356         on #webkit).
1357
1358         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1359         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1360
1361 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
1362
1363         Reviewed by Kenneth Rohde Christiansen.
1364
1365         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
1366         https://bugs.webkit.org/show_bug.cgi?id=43528
1367
1368         Remove on_resize because ewk_view_fixed_layout_size_set should not be
1369         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
1370         FrameView, rendering was ignored when _ewk_view_smart_calculate was
1371         called.
1372
1373         * EWebLauncher/main.c:
1374         (browserCreate):
1375
1376 2010-12-24  Eric Seidel  <eric@webkit.org>
1377
1378         Reviewed by Adam Barth.
1379
1380         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
1381         https://bugs.webkit.org/show_bug.cgi?id=28291
1382
1383         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
1384         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
1385         to strings with find in the diff.
1386         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
1387
1388         * Scripts/webkitpy/common/checkout/api.py:
1389         * Scripts/webkitpy/common/checkout/diff_parser.py:
1390         * Scripts/webkitpy/tool/steps/abstractstep.py:
1391         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1392         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
1393         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1394         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1395
1396 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
1397
1398         Reviewed by Kenneth Russell.
1399
1400         Modify new-run-webkit-tests to shut up and exit when all the threads
1401         are wedged so that test runs complete faster and we don't end up
1402         w/ enormous log files.
1403
1404         https://bugs.webkit.org/show_bug.cgi?id=51572
1405
1406         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1407         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1408
1409 2010-12-24  Eric Seidel  <eric@webkit.org>
1410
1411         Reviewed by David Levin.
1412
1413         commit-queue should better explain how it will re-open bugs and follow duplicate chains
1414         https://bugs.webkit.org/show_bug.cgi?id=51549
1415
1416         I've had multiple people ask me about the commit-queue's behavior
1417         regarding reporting flaky tests.  I figured it would be best to just
1418         have the queue explain itself in the bugs it files.
1419
1420         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1421         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1422
1423 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
1424
1425         Reviewed by Eric Seidel.
1426
1427         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
1428         https://bugs.webkit.org/show_bug.cgi?id=51467
1429
1430         * Scripts/webkitpy/style/checker.py:
1431         * Scripts/webkitpy/style/checker_unittest.py:
1432
1433 2010-12-23  Adam Barth  <abarth@webkit.org>
1434
1435         Rubber-stamped by Eric Seidel.
1436
1437         Move JavaScriptGlue into Sources
1438         https://bugs.webkit.org/show_bug.cgi?id=51583
1439
1440         These tools refer to JavaScriptGlue and need to be updated to its new
1441         location.
1442
1443         * Scripts/build-webkit:
1444         * Scripts/do-file-rename:
1445         * Scripts/do-webcore-rename:
1446         * Scripts/webkitpy/common/config/build.py:
1447         * Scripts/webkitpy/common/config/build_unittest.py:
1448
1449 2010-12-23  Lucas Forschler  <lforschler@apple.com>
1450
1451         Reviewed by Eric Seidel.
1452
1453         Bug 51539 - update iexploder scripts to point to new location
1454
1455         * Scripts/run-iexploder-tests:
1456         * Scripts/update-iexploder-cssproperties:
1457
1458 2010-12-23  Evan Martin  <evan@chromium.org>
1459
1460         Reviewed by Ryosuke Niwa.
1461
1462         [chromium] LayoutTestController warning in float->int conversion
1463         https://bugs.webkit.org/show_bug.cgi?id=51553
1464
1465         Rather than reading an int, converting to a float, then getting a compiler
1466         warning on passing the float to something that expects an int, instead
1467         just pass around ints.
1468
1469         No tests, fixes a compiler warning.
1470
1471         * DumpRenderTree/chromium/LayoutTestController.cpp:
1472         (parsePageSizeParameters):
1473         (LayoutTestController::pageNumberForElementById):
1474         (LayoutTestController::numberOfPages):
1475
1476 2010-12-23  Lucas Forschler  <lforschler@apple.com>
1477
1478         Reviewed by Darin Adler.
1479
1480         Bug 51537 - iexploder needs cleanup
1481         
1482         * iExploder/htdocs: Removed.
1483         * iExploder/htdocs/config.rb: Removed.
1484         * iExploder/htdocs/cssproperties.in: Removed.
1485         * iExploder/htdocs/cssvalues.in: Removed.
1486         * iExploder/htdocs/htmlattrs.in: Removed.
1487         * iExploder/htdocs/htmltags.in: Removed.
1488         * iExploder/htdocs/htmlvalues.in: Removed.
1489         * iExploder/htdocs/iexploder.cgi: Removed.
1490         * iExploder/htdocs/iexploder.rb: Removed.
1491         * iExploder/htdocs/index.html: Removed.
1492         * iExploder/htdocs/webserver.rb: Removed.
1493         * iExploder/iexploder-1.7.2/output: Removed.
1494         * iExploder/tools: Removed.
1495         * iExploder/tools/lasthit.rb: Removed.
1496         * iExploder/tools/osx_last_crash.rb: Removed.
1497         * iExploder/tools/showtest.rb: Removed.
1498
1499 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1500
1501         Reviewed by Kenneth Rohde Christiansen.
1502
1503         [EFL] Make 'single' the default backing store in EWebLauncher
1504         https://bugs.webkit.org/show_bug.cgi?id=51534
1505
1506         'single' is the simplest backing store and the one intended to be the
1507         default in the test browser. By mistake the tiled backing store was
1508         left as default in r72617.
1509
1510         * EWebLauncher/main.c:
1511         (browserCreate): ditto.
1512
1513 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1514
1515         Reviewed by Kenneth Rohde Christiansen.
1516
1517         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
1518         https://bugs.webkit.org/show_bug.cgi?id=51533
1519
1520         There's no point in concatenating env("HOME") with "blah", so remove
1521         option from EWebLauncher.
1522
1523         * EWebLauncher/main.c:
1524         (main): ditto.
1525
1526 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
1527
1528         Reviewed by Eric Seidel.
1529
1530         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
1531
1532         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
1533         I just discovered that we have two additional GC runs per each WebViewHost.
1534         Test_shell had no such calls.
1535         These gc runs eat 15% of cpu time.
1536
1537         https://bugs.webkit.org/show_bug.cgi?id=51479
1538
1539         * DumpRenderTree/chromium/WebViewHost.cpp:
1540         (WebViewHost::~WebViewHost):
1541
1542 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
1543
1544         Reviewed by Ojan Vafai.
1545
1546         This change splits out the TestRunner class into its own file.
1547         When we fork the code for message passing, we will create a new
1548         TestRunner, and this change will allow that to be more modular.
1549
1550         While we're at it, split out TestInput and ResultSummary into
1551         their own files, to reduce the size of run_webkit_tests to
1552         something more managable.
1553
1554         https://bugs.webkit.org/show_bug.cgi?id=51092
1555
1556         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1557         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
1558         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1559         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1560         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
1561         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1562         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1563
1564  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
1565
1566         Reviewed by Ojan Vafai.
1567
1568         nrwt multiprocessing - start over, prepare to fork the code
1569  
1570         This code cleans up the signatures and implementation of the
1571         TestRunner class so we can easily fork it to run either the
1572         stable implementation or the new, unstable message-passing
1573         implementation. The two variants will have different
1574         implementations of the run_tests() method. We will switch
1575         between the two based on the setting for the '--worker-model'
1576         switch. We rename the two currently valid values to 'old-inline'
1577         and 'old-threads'.
1578
1579         https://bugs.webkit.org/show_bug.cgi?id=51081
1580
1581         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1582         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1583
1584 2010-12-22  Victor Wang  <victorw@chromium.org>
1585
1586         Reviewed by Darin Fisher.
1587
1588         [Chromium] Update chromium archive test result url in rebaseline script.
1589
1590         https://bugs.webkit.org/show_bug.cgi?id=51503
1591
1592         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1593
1594 2010-12-22  Lucas Forschler  <lforschler@apple.com>
1595
1596         Reviewed by Alice Liu.
1597
1598         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
1599         Verified on Chrome, Safari, and IE.
1600         With this change, we will record memory from a parent browser window and all child processes.
1601
1602         * record-memory-win/main.cpp:
1603         (ProcessArgs):
1604         (PrintUsage):
1605         (getMemoryInfo):
1606         (printProcessInfo):
1607         (evalProcesses):
1608         (UseImage):
1609         (QueryContinuously):
1610         (ElapsedTime):
1611
1612 2010-12-22  Lucas Forschler  <lforschler@apple.com>
1613
1614         Unreviewed rollout r74489, because it was missing changelog.
1615
1616         * record-memory-win/main.cpp:
1617         
1618 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
1619
1620         Adding myself as a reviewer.
1621
1622         * Scripts/webkitpy/common/config/committers.py:
1623
1624 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
1625
1626         Unreviewed.  Adding myself to committers.py.
1627
1628         * Scripts/webkitpy/common/config/committers.py:
1629
1630 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
1631
1632         Reviewed by Kenneth Rohde Christiansen.
1633
1634         TestNetscapePlugIn should use #if defined
1635         https://bugs.webkit.org/show_bug.cgi?id=51471
1636
1637         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1638         (NP_Initialize):
1639         (NPP_New):
1640
1641 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
1642
1643         Reviewed by Yury Semikhatsky.
1644
1645         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
1646
1647         DevTools window should be closed explicitly because it has custom deinitialization code.
1648
1649         https://bugs.webkit.org/show_bug.cgi?id=50722
1650
1651         * DumpRenderTree/chromium/TestShell.cpp:
1652         (TestShell::closeRemainingWindows):
1653
1654 2010-12-22  David Levin  <levin@chromium.org>
1655
1656         Reviewed by Shinichiro Hamaji.
1657
1658         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
1659         https://bugs.webkit.org/show_bug.cgi?id=51452
1660
1661         * Scripts/webkitpy/style/checkers/cpp.py:
1662         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
1663         Using the file extension if possible but falling back to the file contents if we have a header file.
1664         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
1665         (_FileState.is_c_or_objective_c):
1666         (check_using_std): Changed to using _FileState to determine the file type.
1667         (check_max_min_macros): Ditto.
1668         (check_for_null): Ditto.
1669         (check_style): Changed the parameters to various calls since they now need _FileState
1670         to determine the file type.
1671         (check_language): Added the file_state parameter so it could be passed
1672         to check_identifier_name_in_declaration.
1673         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
1674         this is an Objective C file.
1675         (_process_lines): Added information for the _FileState constructor (and moved the
1676         call to a place that had the information).
1677         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1678         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
1679         its functionality.
1680         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
1681
1682 2010-12-21  Andy Estes  <aestes@apple.com>
1683
1684         Reviewed by Mark Rowe.
1685
1686         Do not build non-Intel architectures for WebKit2-related projects.
1687         https://bugs.webkit.org/show_bug.cgi?id=51440
1688
1689         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
1690         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1691         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1692
1693 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
1694
1695         Reviewed by Darin Fisher.
1696
1697         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
1698         https://bugs.webkit.org/show_bug.cgi?id=51406 
1699         
1700         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
1701         to WebThemeEngineDRTWin and update references everywhere.
1702
1703         * DumpRenderTree/DumpRenderTree.gypi:
1704         * DumpRenderTree/chromium/TestShellWin.cpp:
1705         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
1706         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
1707         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
1708         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
1709
1710 2010-12-21  Anders Carlsson  <andersca@apple.com>
1711
1712         Reviewed by John Sullivan.
1713
1714         Clicking missing plug-in text does not show a sheet
1715         https://bugs.webkit.org/show_bug.cgi?id=51403
1716
1717         Update for changes to the WebPageUIClient.
1718
1719         * MiniBrowser/mac/BrowserWindowController.m:
1720         (-[BrowserWindowController awakeFromNib]):
1721         * WebKitTestRunner/TestController.cpp:
1722         (WTR::createOtherPage):
1723         (WTR::TestController::initialize):
1724
1725 2010-12-21  Eric Seidel  <eric@webkit.org>
1726
1727         Reviewed by Adam Barth.
1728
1729         commit-queue will report constant failures as flaky if other tests flake
1730         https://bugs.webkit.org/show_bug.cgi?id=51272
1731
1732         This patch just removes functionality and adds testing.
1733         Previously we attempted to report flaky tests when we had
1734         two different tests fail in a row.  However, since we stop
1735         running the tests at the first failure, our code was wrong in
1736         trying to determine flakiness from the incomplete runs.
1737
1738         Originally I posted an alternate patch:
1739         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
1740         which fixed our flaky logic in this case, however it was decided
1741         that that patch would be too difficult to maintain, so now
1742         I'm just removing the broken logic.
1743
1744         This will dramatically cut-down on our flaky-test false positives
1745         at the (small) cost of the queues being unable to report
1746         any flakiness if the tree is very flaky.  (With at least one test
1747         flaking on every run, we'll never report failures anymore.)  I think
1748         this is a tradeoff worth making.
1749
1750         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1751         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1752
1753 2010-12-20  Eric Seidel  <eric@webkit.org>
1754
1755         Reviewed by Adam Barth.
1756
1757         commit-queue wrongly rejects patches when it can't update itself
1758         https://bugs.webkit.org/show_bug.cgi?id=46636
1759
1760         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1761         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1762         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1763
1764 2010-12-20  Adam Barth  <abarth@webkit.org>
1765
1766         Move web sites to Websites directory
1767         https://bugs.webkit.org/show_bug.cgi?id=51323
1768
1769         Update references to BugsSite to point to the new location.
1770
1771         This patch was never officially reviewed (because it was too large to
1772         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
1773         Rowe gave me the green light.
1774
1775         * Scripts/old-run-webkit-tests:
1776         * Scripts/webkitpy/common/config/build.py:
1777         * Scripts/webkitpy/common/config/build_unittest.py:
1778         * Scripts/webkitpy/common/prettypatch.py:
1779         * Scripts/webkitpy/layout_tests/port/base.py:
1780         * Scripts/webkitpy/style/main.py:
1781
1782 2010-12-20  Adrienne Walker  <enne@google.com>
1783
1784         Unreviewed. Adding myself to the list of committers.
1785
1786         * webkitpy/common/config/committers.py:
1787
1788 2010-12-20  Mark Rowe  <mrowe@apple.com>
1789
1790         Reviewed by Dan Bernstein.
1791
1792         <rdar://problem/8757601> Don't install header files in to the Resources directory.
1793
1794         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
1795         Resources directory.
1796
1797 2010-12-20  Eric Seidel  <eric@webkit.org>
1798
1799         Reviewed by Adam Barth.
1800
1801         commit-queue should include bot id when attaching failure diffs
1802         https://bugs.webkit.org/show_bug.cgi?id=51280
1803
1804         This is a tiny change to include the bot id in the name of the attachment.
1805         Most of this diff is just changing the unit test expectations
1806         now that I hid the comment printing when the comment is None.
1807
1808         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1809         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1810         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1811         * Scripts/webkitpy/tool/mocktool.py:
1812
1813 2010-12-20  Jeff Miller  <jeffm@apple.com>
1814
1815         Reviewed by Dan Bernstein.
1816
1817         Tools/vcbin/midl.exe needs to be rebuilt
1818         https://bugs.webkit.org/show_bug.cgi?id=51347
1819
1820         * vcbin/midl.exe: Rebuilt.
1821
1822 2010-12-20  David Levin  <levin@chromium.org>
1823
1824         Reviewed by Ariya Hidayat.
1825
1826         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
1827         https://bugs.webkit.org/show_bug.cgi?id=51343
1828
1829         Follow up from the WebKitTools -> Tools rename.
1830
1831         * Scripts/webkit-tools-completion.sh:
1832
1833 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
1834
1835         Reviewed by James Robinson.
1836
1837         new-run-webkit-tests ignores trailing EOL differences in text tests
1838         https://bugs.webkit.org/show_bug.cgi?id=36983
1839
1840         Changed the handling of new-line characters within new-run-webkit-tests
1841         to match old-run-webkit-tests.  Differences in leading and trailing empty
1842         lines in text expectation files are no longer ignored.
1843
1844         * Scripts/webkitpy/layout_tests/port/base.py:
1845         * Scripts/webkitpy/layout_tests/port/test.py:
1846         Added unit tests.  Removed old duplicate unit test entries.
1847         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1848
1849 2010-12-20  David Levin  <levin@chromium.org>
1850
1851         Reviewed by Shinichiro Hamaji.
1852
1853         check-webkit-style should detect function declarations (and trivial functions).
1854         https://bugs.webkit.org/show_bug.cgi?id=51303
1855
1856         * Scripts/webkitpy/style/checkers/cpp.py:
1857         (_FunctionState.begin): Add is_declaration and changed the line count
1858         start to begin at -1 (which will keep the results consistent, since
1859         the starting line number passed in is one less in this change).
1860         (detect_functions): changed function detection to now catch trivial
1861         functions and declarations.
1862         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
1863         of the function as this may look at return values (when processing
1864         a declaration).
1865         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1866         (FunctionDetectionTest.perform_function_detection): Basic mechanics
1867         of testing the function detection.
1868         (FunctionDetectionTest.test_basic_function_detection): Test a simple
1869         function.
1870         (FunctionDetectionTest.test_function_declaration_detection): Test a
1871         declaration.
1872         (FunctionDetectionTest.test_non_functions): A test case for a case
1873         that caused the code to fail due to the { being in quotes.
1874         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
1875         cases to help catch false alarms for return values.
1876         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
1877         we don't get false alarms for member variables either.
1878
1879 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
1880
1881         Reviewed by Antonio Gomes.
1882
1883         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
1884         https://bugs.webkit.org/show_bug.cgi?id=51319
1885
1886         * CMakeListsEfl.txt:
1887
1888 2010-12-18  Adam Barth  <abarth@webkit.org>
1889
1890         Reviewed by Sam Weinig.
1891
1892         Move WebKitExamplePlugins to Examples
1893         https://bugs.webkit.org/show_bug.cgi?id=51291
1894
1895         * Scripts/webkitpy/common/config/build.py:
1896
1897 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
1898
1899         Unreviewed Qt buildfix after r74301.
1900
1901         Rename WebKitTools to Tools
1902         https://bugs.webkit.org/show_bug.cgi?id=49861
1903
1904         * MiniBrowser/DerivedSources.pro:
1905         * MiniBrowser/qt/MiniBrowser.pro:
1906
1907 2010-12-17  Dan Bernstein  <mitz@apple.com>
1908
1909         Reviewed by Simon Fraser.
1910
1911         Rename WebKitTools to Tools
1912         https://bugs.webkit.org/show_bug.cgi?id=49861
1913
1914         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1915         * CodeCoverage/README:
1916         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1917         (WebCore::DumpRenderTree::initializeFonts):
1918         * EWSTools/start-commit-queue.sh:
1919         * EWSTools/start-queue.sh:
1920         * GNUmakefile.am:
1921         * MIDLWrapper/MIDLWrapper.cpp:
1922         (wmain):
1923         * MiniBrowser/qt/MiniBrowser.pro:
1924         * Scripts/build-api-tests:
1925         * Scripts/build-dumprendertree:
1926         * Scripts/build-webkit:
1927         * Scripts/build-webkittestrunner:
1928         * Scripts/generate-coverage-data:
1929         * Scripts/old-run-webkit-tests:
1930         * Scripts/run-api-tests:
1931         * Scripts/run-iexploder-tests:
1932         * Scripts/run-javascriptcore-tests:
1933         * Scripts/run-mangleme-tests:
1934         * Scripts/run-sunspider:
1935         * Scripts/run-webkit-websocketserver:
1936         * Scripts/sunspider-compare-results:
1937         * Scripts/test-webkitperl:
1938         * Scripts/test-webkitpy:
1939         * Scripts/update-iexploder-cssproperties:
1940         * Scripts/update-webkit:
1941         * Scripts/update-webkit-localizable-strings:
1942         * Scripts/webkitdirs.pm:
1943         * Scripts/webkitpy/common/checkout/scm.py:
1944         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1945         * Scripts/webkitpy/common/config/committervalidator.py:
1946         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1947         * Scripts/webkitpy/common/config/ports.py:
1948         * Scripts/webkitpy/common/config/ports_unittest.py:
1949         * Scripts/webkitpy/common/system/logutils_unittest.py:
1950         * Scripts/webkitpy/common/system/ospath_unittest.py:
1951         * Scripts/webkitpy/layout_tests/port/chromium.py:
1952         * Scripts/webkitpy/layout_tests/port/config.py:
1953         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1954         * Scripts/webkitpy/layout_tests/port/http_server.py:
1955         * Scripts/webkitpy/layout_tests/port/test.py:
1956         * Scripts/webkitpy/style/checker.py:
1957         * Scripts/webkitpy/style/checker_unittest.py:
1958         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1959         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1960         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1961         * WebKitTestRunner/DerivedSources.pro:
1962         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1963         (WTR::activateFonts):
1964         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1965         * wx/build/build_utils.py:
1966
1967 2010-12-16  Antonio Gomes  <agomes@rim.com>
1968
1969         Reviewed by Martin Robinson.
1970
1971         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
1972         https://bugs.webkit.org/show_bug.cgi?id=51163
1973
1974         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
1975         GTK+'s DRT should also reset to UNIX after each test execution.
1976
1977         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1978         (resetDefaultsToConsistentValues):
1979
1980 2010-12-17  David Levin  <levin@chromium.org>
1981
1982         Reviewed by Eric Seidel.
1983
1984         check-webkit-style should understand WTF #include guards
1985         https://bugs.webkit.org/show_bug.cgi?id=44911
1986
1987         * Scripts/webkitpy/style/checkers/cpp.py:
1988         (get_header_guard_cpp_variable): modify to suggest the WTF style
1989         of header guard when appropriate.
1990         (check_for_header_guard): handle multiple return values from
1991         get_header_guard_cpp_variable
1992         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1993         (CppStyleTest.test_build_header_guard): Added tests for the WTF
1994         header style.
1995
1996 2010-12-16  David Levin  <levin@chromium.org>
1997
1998         Reviewed by Eric Seidel.
1999
2000         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2001         https://bugs.webkit.org/show_bug.cgi?id=51210
2002
2003         The error only shows up when using python 2.6 or later.
2004
2005         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2006         the decprecated field error,message with something equivalent.
2007
2008 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2009
2010         Reviewed by Eric Seidel.
2011
2012         Add --exit-after-n-failures/crashes to NRWT
2013         https://bugs.webkit.org/show_bug.cgi?id=51160
2014         
2015         Abort test run (in a similar way to how control-C is handled) when
2016         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
2017         that number of unexpected failures/crashes/timeouts.
2018
2019         * Scripts/webkitpy/layout_tests/port/test.py:
2020         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2021         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2022
2023 2010-12-16  David Levin  <levin@chromium.org>
2024
2025         Reviewed by Shinichiro Hamaji.
2026
2027         check-webkit-style unit tests has some duplicate boilerplate code.
2028         https://bugs.webkit.org/show_bug.cgi?id=49519
2029
2030         * Scripts/webkitpy/style/checkers/cpp.py:
2031         (update_include_state): Replaced the "io" parameter with the global
2032         configuration _unit_test_config. This allowed not calling into
2033         functions at a low level and also not plumbing through the injection
2034         information through many levels of code.
2035         (check_for_include_what_you_use): Ditto.
2036         (process_file_data): Added the ability to set up the unit test config
2037         to allow for injection.
2038         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2039         (ErrorCollector.__init__): Added support for having a filter for errors.
2040         (ErrorCollector.__call__): Ditto.
2041         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
2042         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
2043         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
2044         functions in the cpp.py with generic processing and a filter that
2045         indicates what errors should be kept.
2046         (CppStyleTestBase.perform_multi_line_lint): Ditto.
2047         (CppStyleTestBase.perform_language_rules_check): Ditto.
2048         (CppStyleTestBase.perform_function_lengths_check): Ditto.
2049         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
2050         (CppStyleTestBase.perform_include_what_you_use): Ditto.
2051         (CppStyleTest.test_multi_line_comments): Added another
2052         error message which applies to the test case.
2053         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
2054         to not have config.h, since it is processed as a header file.
2055         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
2056         style and indentation in checked code.
2057         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
2058         Fixed line number.
2059         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
2060         Ditto.
2061
2062 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2063
2064         Unreviewed, rolling out r74136.
2065         http://trac.webkit.org/changeset/74136
2066         https://bugs.webkit.org/show_bug.cgi?id=51135
2067
2068         r74136 breaks chromium canary bots because some tests are not
2069         rebaselined correctly to resolve EOL differences (Requested by
2070         jianli on #webkit).
2071
2072         * Scripts/webkitpy/layout_tests/port/base.py:
2073         * Scripts/webkitpy/layout_tests/port/test.py:
2074         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2075
2076 2010-12-15  Adam Roben  <aroben@apple.com>
2077
2078         Teach check-webkit-style to check .vcproj and .vsprops files for XML
2079         syntax errors
2080
2081         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
2082         XML syntax errors in .vcproj/.vsprops files
2083
2084         Reviewed by Dave Levin.
2085
2086         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
2087         that should be treated as XML and that should be allowed to contain
2088         carriage returns. (These lists happen to be identical currently.)
2089         (FileType): Added a new XML type.
2090         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
2091         Just does a simple file extension check.
2092         (CheckerDispatcher._file_type): Added a case for XML files.
2093         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
2094         files (surprise!).
2095         (StyleProcessor.process): Ask the dispatcher whether we should pass the
2096         lines through the carriage checker.
2097
2098         * Scripts/webkitpy/style/checker_unittest.py:
2099         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
2100         Added. Checks a few file names to see if carriage returns are allowed
2101         or not.
2102         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
2103         other assert_checker_* functions.
2104         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2105         test_*_paths functions.
2106         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2107         test_*_paths functions.
2108         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
2109         file from this test case, as vcproj files now have a type.
2110         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
2111         Added. Similar to the other should_* functions.
2112         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
2113         Added. Checks that carriage returns aren't checked for or stripped for
2114         allowed files.
2115
2116         * Scripts/webkitpy/style/checkers/xml.py: Added.
2117         (XMLChecker.__init__): Simple init method.
2118         (XMLChecker.check): Pass each line through the expat parser, and record
2119         a style error for any errors thrown by the parser.
2120
2121         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
2122         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
2123         produce a style error.
2124         (XMLCheckerTest.assert_error): Checks that the given XML produces an
2125         error of the given category on the given line.
2126         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
2127         checking that the XMLChecker constructor works properly.
2128         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
2129         cause a style error (see, e.g., r73887).
2130         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
2131         cause a style error (see, e.g., r73773).
2132         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
2133         properly.
2134         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
2135         tags cause a style error (see, e.g., r72795).
2136         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
2137         style error.
2138
2139 2010-12-15  Lucas Forschler  <lforschler@apple.com>
2140
2141         Reviewed by Stephanie Lewis.
2142
2143         https://bugs.webkit.org/show_bug.cgi?id=51117
2144         Add a new leopard test bot
2145         really really commit to trunk this time.
2146
2147         * BuildSlaveSupport/build.webkit.org-config/config.json:
2148
2149 2010-12-15  Sam Weinig  <sam@webkit.org>
2150
2151         Reviewed by Anders Carlsson.
2152
2153         WebKit2: Can't add files to an <input type=file>
2154         https://bugs.webkit.org/show_bug.cgi?id=51087
2155
2156         * MiniBrowser/mac/BrowserWindowController.m:
2157         (runOpenPanel):
2158         (-[BrowserWindowController awakeFromNib]):
2159         Add simple implementation of runOpenPanel callback.
2160
2161         * MiniBrowser/win/BrowserView.cpp:
2162         (BrowserView::create):
2163         * WebKitTestRunner/TestController.cpp:
2164         (WTR::createOtherPage):
2165         (WTR::TestController::initialize):
2166         Stub out runOpenPanel callback. 
2167
2168 2010-12-14  Eric Seidel  <eric@webkit.org>
2169
2170         Reviewed by Adam Barth.
2171
2172         commit-queue should upload failure diffs when tests flake
2173         https://bugs.webkit.org/show_bug.cgi?id=51051
2174
2175         To make this testable I needed to pipe FileSystem down onto tool.
2176         We've wanted it there for a long time anyway.
2177
2178         This patch is kinda a big hack.  But we don't have a nice
2179         way to read results.html files.  I think this will need further
2180         revision before this code actually feels clean.
2181
2182         As part of testing this change, I had to make MockBugzilla.create_bug
2183         actually return an id (like it should) which required updating
2184         a few other unit test results (for the better).
2185
2186         The results_matching_keys change in layouttestresults/rebasline
2187         was an alternate path which I decided not to use in the end, but
2188         I left the change as it seemed an improvement.
2189
2190         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2191         * Scripts/webkitpy/common/net/layouttestresults.py:
2192         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2193         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2194         * Scripts/webkitpy/tool/commands/queues.py:
2195         * Scripts/webkitpy/tool/commands/rebaseline.py:
2196         * Scripts/webkitpy/tool/main.py:
2197         * Scripts/webkitpy/tool/mocktool.py:
2198
2199 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
2200
2201         Reviewed by James Robinson.
2202
2203         new-run-webkit-tests ignores trailing EOL differences in text tests
2204         https://bugs.webkit.org/show_bug.cgi?id=36983
2205
2206         Changed the handling of new-line characters within new-run-webkit-tests
2207         to match old-run-webkit-tests.  Differences in leading and trailing empty
2208         lines in text expectation files are no longer ignored.
2209
2210         * Scripts/webkitpy/layout_tests/port/base.py:
2211         * Scripts/webkitpy/layout_tests/port/test.py:
2212         Added unit tests.  Removed old duplicate unit test entries.
2213         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2214
2215 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2216
2217         Reviewed by Adam Barth.
2218
2219         make status-bubble white-space:nowrap so we can measure it's width without wrapping
2220         https://bugs.webkit.org/show_bug.cgi?id=51149
2221
2222         * QueueStatusServer/templates/statusbubble.html:
2223
2224 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2225
2226         Reviewed by Adam Barth.
2227
2228         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
2229         https://bugs.webkit.org/show_bug.cgi?id=51125
2230
2231         * QueueStatusServer/templates/statusbubble.html:
2232
2233 2010-12-15  Darin Adler  <darin@apple.com>
2234
2235         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
2236
2237 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2238
2239         Unreviewed, rolling out r74117.
2240         http://trac.webkit.org/changeset/74117
2241         https://bugs.webkit.org/show_bug.cgi?id=51113
2242
2243         This broke the GTK1 build. (Requested by mrobinson on
2244         #webkit).
2245
2246         * Scripts/webkitdirs.pm:
2247
2248 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
2249
2250         Reviewed by Martin Robinson.
2251
2252         Change generate-forwarding-headers.pl for GTK port usage 
2253         (https://bugs.webkit.org/show_bug.cgi?id=37369)
2254
2255         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
2256
2257 2010-12-14  Kent Tamura  <tkent@chromium.org>
2258
2259         Reviewed by Jian Li.
2260
2261         [DRT/Chromium] Remove another unnecessary error message
2262         https://bugs.webkit.org/show_bug.cgi?id=51083
2263
2264         * DumpRenderTree/chromium/WebViewHost.cpp:
2265         (WebViewHost::didInvalidateRect):
2266
2267 2010-12-14  Lucas Forschler  <lforschler@apple.com>
2268
2269         Reviewed by Stephanie Lewis.
2270
2271         Add a new Leopard Debug Test WK2 Bot
2272
2273         * BuildSlaveSupport/build.webkit.org-config/config.json:
2274
2275 2010-12-14  Ojan Vafai  <ojan@chromium.org>
2276
2277         Fix python unittests after http://trac.webkit.org/changeset/74070.
2278
2279         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2280
2281 2010-12-14  Kent Tamura  <tkent@chromium.org>
2282
2283         Reviewed by Jian Li.
2284
2285         [DRT/Chromium] Remove a unnecessary error message
2286         https://bugs.webkit.org/show_bug.cgi?id=51069
2287
2288         * DumpRenderTree/chromium/WebViewHost.cpp:
2289         (WebViewHost::paintInvalidatedRegion):
2290
2291 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
2292
2293         Reviewed by Ojan Vafai.
2294
2295         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
2296         https://bugs.webkit.org/show_bug.cgi?id=48926
2297
2298         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2299         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
2300
2301 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2302
2303         Reviewed by Eric Seidel.
2304
2305         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
2306         https://bugs.webkit.org/show_bug.cgi?id=50231
2307
2308         Guard CONFIG+=link_pkgconfig with !symbian.
2309
2310         * DumpRenderTree/qt/DumpRenderTree.pro:
2311         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2312         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2313
2314 2010-12-14  Philippe Normand  <pnormand@igalia.com>
2315
2316         Reviewed by Ojan Vafai.
2317
2318         [new-run-webkit-tests] expectations parsing is slow
2319         https://bugs.webkit.org/show_bug.cgi?id=50635
2320
2321         Avoid expensive iteration of all the tests when checking if a test
2322         file is to be skipped or not.
2323
2324         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2325         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2326         * Scripts/webkitpy/layout_tests/port/test.py:
2327
2328 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
2329
2330         Reviewed by Xan Lopez.
2331
2332         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
2333         https://bugs.webkit.org/show_bug.cgi?id=27048
2334
2335         Add support in DRT for checking whether an accessibility UI
2336         element is focusable and/or focused. Implemented for GTK.
2337
2338         * DumpRenderTree/AccessibilityUIElement.cpp:
2339         (getIsFocusedCallback): New.
2340         (getIsFocusableCallback): New.
2341         (AccessibilityUIElement::getJSClass): Add the new available
2342         callbacks for isFocused and isFocusable.
2343         * DumpRenderTree/AccessibilityUIElement.h:
2344         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2345         (AccessibilityUIElement::isFocused): New, implemented by checking
2346         whether the related AtkState value is in the object's state set.
2347         (AccessibilityUIElement::isFocusable): Ditto.
2348         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2349         (AccessibilityUIElement::isFocused): New, dummy implementation.
2350         (AccessibilityUIElement::isFocusable): Ditto.
2351         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2352         (AccessibilityUIElement::isFocused): Ditto.
2353         (AccessibilityUIElement::isFocusable): Ditto.
2354
2355 2010-12-14  Eric Seidel  <eric@webkit.org>
2356
2357         Reviewed by Ojan Vafai.
2358
2359         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
2360         https://bugs.webkit.org/show_bug.cgi?id=50715
2361
2362         This patch makes webkit-patch print the following:
2363
2364         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
2365         Install a 64-bit git for better performance, see:
2366         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
2367
2368         I wrote this mostly because I have approximately 8 machines that I use
2369         and making sure each one is using a good Git install seemed folly.
2370         webkit-patch makes a lot of git calls, so using a fast git can shave
2371         several seconds in every invocation.  See the webkit-dev thread for more info.
2372
2373         This message will print twice during 'webkit-patch upload',
2374         once from webkit-patch and once from check-webkit-style.
2375
2376         Unfortunately there is no good way to test this due to how machine-dependent
2377         the code is.  I considered writing a test for the log message, but it seemed not worth it.
2378
2379         * Scripts/webkitpy/common/checkout/scm.py:
2380
2381 2010-12-13  Eric Seidel  <eric@webkit.org>
2382
2383         Reviewed by Adam Barth.
2384
2385         FlakyTestReporter doesn't understand bots running from multiple email addresses
2386         https://bugs.webkit.org/show_bug.cgi?id=50960
2387
2388         This explains at least one of the dupes of:
2389         https://bugs.webkit.org/show_bug.cgi?id=50863
2390         that we saw filed by the commit-queue this morning.
2391         I think the other one was explained by my previous fix to result counting code.
2392
2393         Since this is really hard to test with a unit test, instead I
2394         create a new (possibly useful in the future) command
2395         which given a layout test path will return you
2396         the one bug which our tools would assume it the flaky test bug.
2397         If some other script wants to use bug-for-test we'll
2398         need to extend it with some options like --create-if-missing or similar.
2399
2400         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2401         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2402         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2403         * Scripts/webkitpy/tool/commands/__init__.py:
2404         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
2405
2406 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
2407
2408         Reviewed by James Robinson.
2409
2410         Add option to build-webkit to not build WebKit2
2411         https://bugs.webkit.org/show_bug.cgi?id=50988
2412         
2413         Add support for a --no-webkit2 option to build-webkit. It seems to save
2414         ~1 minute from clean builds and ~10 seconds from no-op builds.
2415
2416         * Scripts/build-webkit:
2417
2418 2010-12-13  Lucas Forschler  <lforschler@apple.com>
2419
2420         Reviewed by Dave Kilzer.
2421
2422         Update iexploder from 1.3.2 to 1.7.2
2423         Move 1.3.2 into its own subdir
2424         Add 1.7.2 into its own subdir
2425         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
2426
2427         * Scripts/run-iexploder-tests:
2428         * Scripts/update-iexploder-cssproperties:
2429         * iExploder/CHANGELOG.txt: Removed.
2430         * iExploder/LICENSE.txt: Removed.
2431         * iExploder/README.txt: Removed.
2432         * iExploder/htdocs: Removed.
2433         * iExploder/iexploder-1.3.2: Added.
2434         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
2435         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
2436         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
2437         * iExploder/iexploder-1.3.2/htdocs: Added.
2438         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
2439         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
2440         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
2441         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
2442         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
2443         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
2444         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
2445         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
2446         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
2447         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
2448         * iExploder/iexploder-1.3.2/tools: Added.
2449         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
2450         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
2451         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
2452         * iExploder/iexploder-1.7.2: Added.
2453         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
2454         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
2455         * iExploder/iexploder-1.7.2/README.txt: Added.
2456         * iExploder/iexploder-1.7.2/output: Added.
2457         * iExploder/iexploder-1.7.2/src: Added.
2458         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
2459         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
2460         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
2461         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
2462         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
2463         * iExploder/iexploder-1.7.2/src/css-properties: Added.
2464         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
2465         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
2466         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
2467         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
2468         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
2469         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
2470         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
2471         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
2472         * iExploder/iexploder-1.7.2/src/css-values: Added.
2473         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
2474         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
2475         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
2476         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
2477         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
2478         * iExploder/iexploder-1.7.2/src/headers: Added.
2479         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
2480         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
2481         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
2482         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
2483         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
2484         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
2485         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
2486         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
2487         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
2488         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
2489         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
2490         * iExploder/iexploder-1.7.2/src/html-tags: Added.
2491         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
2492         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
2493         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
2494         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
2495         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
2496         * iExploder/iexploder-1.7.2/src/html-values: Added.
2497         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
2498         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
2499         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
2500         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
2501         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
2502         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
2503         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
2504         * iExploder/iexploder-1.7.2/src/index.html: Added.
2505         * iExploder/iexploder-1.7.2/src/media: Added.
2506         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
2507         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
2508         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
2509         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
2510         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
2511         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
2512         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
2513         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
2514         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
2515         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
2516         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
2517         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
2518         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
2519         * iExploder/iexploder-1.7.2/src/mime-types: Added.
2520         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
2521         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
2522         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
2523         * iExploder/iexploder-1.7.2/src/protocols: Added.
2524         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
2525         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
2526         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
2527         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
2528         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
2529         * iExploder/iexploder-1.7.2/src/version.rb: Added.
2530         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
2531         * iExploder/iexploder-1.7.2/testcases: Added.
2532         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
2533         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
2534         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
2535         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
2536         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
2537         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
2538         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
2539         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
2540         * iExploder/iexploder-1.7.2/tools: Added.
2541         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
2542         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
2543         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
2544         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
2545         * iExploder/tools: Removed.
2546
2547 2010-12-13  Sam Weinig  <sam@webkit.org>
2548
2549         Reviewed by Anders Carlsson.
2550
2551         Remove associated page concept from WKView constructor
2552         https://bugs.webkit.org/show_bug.cgi?id=50983
2553
2554         Step 1: Remove associate page constructors from WKView and make
2555         all views use the shared namespace for the context.
2556
2557         * TestWebKitAPI/PlatformWebView.h:
2558         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2559         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2560         * WebKitTestRunner/PlatformWebView.h:
2561         * WebKitTestRunner/TestController.cpp:
2562         (WTR::createOtherPage):
2563         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2564         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2565         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2566
2567 2010-12-13  Sam Weinig  <sam@webkit.org>
2568
2569         Reviewed by Anders Carlsson.
2570
2571         Change the WebKit2 public API so there is no explicit WKPageNamespace object
2572         https://bugs.webkit.org/show_bug.cgi?id=50898
2573
2574         * MiniBrowser/mac/AppDelegate.h:
2575         * MiniBrowser/mac/AppDelegate.m:
2576         * MiniBrowser/mac/BrowserWindowController.h:
2577         * MiniBrowser/mac/BrowserWindowController.m:
2578         * MiniBrowser/win/BrowserView.cpp:
2579         Convert MiniBrowser to not use PageNamespaces.
2580
2581         * TestWebKitAPI/PlatformWebView.h:
2582         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2583         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2584         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2585         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2586         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2587         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2588         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2589         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2590         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2591         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2592         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2593         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2594         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2595         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2596         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2597         Convert TestWebKitAPI to not use PageNamespaces.
2598
2599         * WebKitTestRunner/PlatformWebView.h:
2600         * WebKitTestRunner/TestController.cpp:
2601         * WebKitTestRunner/TestController.h:
2602         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2603         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2604         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2605         Convert WebKitTestRunner to not use PageNamespaces.
2606
2607 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2608
2609         Reviewed by Eric Seidel.
2610
2611         webkit-patch rollout should be able to do multi-revision rollouts
2612         https://bugs.webkit.org/show_bug.cgi?id=33336
2613
2614         Make it possible to pass more than one revision to webkit-patch.
2615
2616         * Scripts/webkitpy/common/checkout/api.py:
2617         * Scripts/webkitpy/common/checkout/changelog.py:
2618         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2619         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2620         * Scripts/webkitpy/tool/commands/download.py:
2621         * Scripts/webkitpy/tool/commands/download_unittest.py:
2622         * Scripts/webkitpy/tool/mocktool.py:
2623         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2624         * Scripts/webkitpy/tool/steps/revertrevision.py:
2625
2626 2010-12-13  Eric Seidel  <eric@webkit.org>
2627
2628         Unreviewed.
2629
2630         Teach webkit-patch how to search bugzilla
2631         https://bugs.webkit.org/show_bug.cgi?id=50500
2632
2633         webkit-patch bug-search fails when there is only one result.
2634         Turns out we needed a bit more logic in our result count parsing code.
2635
2636         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2637         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2638
2639 2010-12-13  Antti Koivisto  <antti@apple.com>
2640
2641         Reviewed by Alexey Proskuryakov.
2642
2643         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
2644         https://bugs.webkit.org/show_bug.cgi?id=50758
2645
2646         * DumpRenderTree/LayoutTestController.cpp:
2647         (setSerializeHTTPLoadsCallback):
2648         (LayoutTestController::staticFunctions):
2649         * DumpRenderTree/LayoutTestController.h:
2650         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2651         (LayoutTestController::setSerializeHTTPLoads):
2652         * DumpRenderTree/mac/DumpRenderTree.mm:
2653         (resetDefaultsToConsistentValues):
2654         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2655         (LayoutTestController::setSerializeHTTPLoads):
2656         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2657         (LayoutTestController::setSerializeHTTPLoads):
2658
2659 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
2660
2661         Reviewed by Ojan Vafai.
2662
2663         Remove "use-drt" option from test step command line, since the option was removed in r73748.
2664         https://bugs.webkit.org/show_bug.cgi?id=50936
2665
2666         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
2667
2668 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
2669
2670         Reviewed by Csaba Osztrogonác.
2671
2672         Add revlink to BuildBot status
2673         https://bugs.webkit.org/show_bug.cgi?id=50914
2674
2675         This adds a hyperlink to trac changeset on the revision numbers. 
2676
2677         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2678
2679 2010-12-13  Andras Becsi  <abecsi@webkit.org>
2680
2681         Reviewed by Csaba Osztrogonác.
2682
2683         [Qt][WK2] Fix build if WebKitTools are not available
2684         https://bugs.webkit.org/show_bug.cgi?id=50242
2685
2686         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
2687         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
2688         * MiniBrowser/DerivedSources.pro: Added.
2689
2690 2010-12-13  Eric Seidel  <eric@webkit.org>
2691
2692         Reviewed by Adam Barth.
2693
2694         EWS Queues should remove orpahned pyc files before starting
2695         https://bugs.webkit.org/show_bug.cgi?id=50904
2696
2697         A previous check added a platform.py which caused
2698         EWS bots on some platforms to hit an import exception.
2699         The platform.py file was removed in a subsequent commit, but
2700         the EWS bots in question stayed stuck.  This change will
2701         fix those bots once restarted (and prevent this in the future).
2702
2703         I also went ahead and unified start-queue and start-commit-queue
2704         since they were nearly identical.  I also added bot_id support
2705         to both force all EWSes to have bot ids as well as get rid of the one
2706         remaining reason why I had my own copies of these scripts.
2707         Hopefully this will be enough to get all the other bot admins
2708         (ahem, Adam, ahem) to move to using these checked in copies as well.
2709
2710         * EWSTools/start-commit-queue.sh: Removed.
2711         * EWSTools/start-queue.sh:
2712
2713 2010-10-28  MORITA Hajime  <morrita@google.com>
2714
2715         Reviewed by Ojan Vafai.
2716
2717         spellcheck does not check pasted text
2718         https://bugs.webkit.org/show_bug.cgi?id=40092
2719
2720         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
2721         to control the setting.
2722
2723         * DumpRenderTree/LayoutTestController.cpp:
2724         (setAsynchronousSpellCheckingEnabledCallback):
2725         (LayoutTestController::staticFunctions):
2726         * DumpRenderTree/LayoutTestController.h:
2727         * DumpRenderTree/chromium/LayoutTestController.h:
2728         * DumpRenderTree/chromium/LayoutTestController.cpp:
2729         (LayoutTestController::LayoutTestController):
2730         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2731         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2732         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2733         * DumpRenderTree/mac/DumpRenderTree.mm:
2734         (resetDefaultsToConsistentValues):
2735         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2736         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2737         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2738         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2739         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2740         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2741         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2742         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2743         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2744
2745 2010-12-12  Sam Weinig  <sam@webkit.org>
2746
2747         Reviewed by Anders Carlsson.
2748
2749         Fix failing API test. It turns out that a pop-state event
2750         is sent before every fragment navigation, so we have to test
2751         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
2752
2753         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2754         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2755
2756 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
2757
2758         Reviewed by Eric Seidel.
2759
2760         [GTK] Add new-run-webkit-tests support to gtk
2761         https://bugs.webkit.org/show_bug.cgi?id=50681
2762
2763         Adding the basic support to run the new-run-webkit-tests.
2764
2765         * Scripts/webkitpy/layout_tests/port/gtk.py:
2766
2767 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
2768
2769         Reviewed by Kenneth Rohde Christiansen.
2770
2771         [Qt] Mock DeviceOrientation client for DRT
2772         https://bugs.webkit.org/show_bug.cgi?id=47490
2773
2774         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2775         (WebCore::DumpRenderTree::DumpRenderTree):
2776         (WebCore::DumpRenderTree::~DumpRenderTree):
2777         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2778         (LayoutTestController::setMockDeviceOrientation):
2779
2780 2010-12-11  Philippe Normand  <pnormand@igalia.com>
2781
2782         Reviewed by Gustavo Noronha Silva.
2783
2784         [GTK] launcher: disable the Mozilla-style fullscreen API
2785         https://bugs.webkit.org/show_bug.cgi?id=50874
2786
2787         Disabling the fullscreen API until its implementation for GTK is
2788         mature enough. The webview setting for it is already FALSE by
2789         default.
2790
2791         * GtkLauncher/main.c:
2792         (createWindow):
2793
2794 2010-12-10  Eric Seidel  <eric@webkit.org>
2795
2796         Reviewed by Adam Barth.
2797
2798         commit-queue flaky test messages show cryptic version information for mac os x
2799         https://bugs.webkit.org/show_bug.cgi?id=50864
2800
2801         Turns out platform.platform() returns kernel version information
2802         which isn't helpful, and just plain confusing on Mac
2803         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
2804
2805         So I've updated PlatformInfo.display_name() to special case
2806         mac.  I also found a bad use of sys.platform in the process
2807         and fixed that.  (sys.platform always returns 'darwin' on mac).
2808
2809         * Scripts/webkitpy/common/system/platforminfo.py:
2810         * Scripts/webkitpy/common/system/user.py:
2811         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2812         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2813         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2814
2815 2010-12-10  Eric Seidel  <eric@webkit.org>
2816
2817         Unreviewed.
2818
2819         Exception seen while reporting flaky test with commit-queue.
2820         Just a missing include.
2821
2822         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2823         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2824
2825 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
2826
2827         Reviewed by Eric Seidel.
2828
2829         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
2830         https://bugs.webkit.org/show_bug.cgi?id=50796
2831
2832         Also updating the test code to use JSONResultsGeneratorBase and
2833         to improve test coverage for incremental cases.
2834
2835         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2836         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2837
2838 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
2839
2840         Reviewed by Darin Adler.
2841
2842         prepare-ChangeLog --help doesn't mention --bug shorthand -b
2843         https://bugs.webkit.org/show_bug.cgi?id=50835
2844
2845         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
2846
2847 2010-12-10  Eric Seidel  <eric@webkit.org>
2848
2849         Reviewed by Adam Barth.
2850
2851         Bugs created by the commit-queue should all block on a master bug
2852         https://bugs.webkit.org/show_bug.cgi?id=50857
2853
2854         This makes all bugs created by the commit-queue block on:
2855         https://bugs.webkit.org/show_bug.cgi?id=50856
2856
2857         In the process of testing this, I found that the existing
2858         create_bug code was wrong.  I also found that existing
2859         unit tests for create-rollout used invalid values
2860         for options.blocks.  I fixed both issues and tested.
2861
2862         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2863         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2864         * Scripts/webkitpy/tool/commands/commandtest.py:
2865         * Scripts/webkitpy/tool/commands/download_unittest.py:
2866         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2867         * Scripts/webkitpy/tool/mocktool.py:
2868         * Scripts/webkitpy/tool/steps/options.py:
2869
2870 2010-12-10  Eric Seidel  <eric@webkit.org>
2871
2872         Reviewed by Adam Barth.
2873
2874         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
2875         https://bugs.webkit.org/show_bug.cgi?id=50853
2876
2877         I also discovered when doing this that the code was posting
2878         the comment on the wrong bug, but that's fixed here too.
2879
2880         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2881         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2882         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2883         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2884         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2885         * Scripts/webkitpy/tool/mocktool.py:
2886
2887 2010-12-10  Anders Carlsson  <andersca@apple.com>
2888
2889         Reviewed by John Sullivan.
2890
2891         Make WKContextGetStatistics gather global statistics
2892         https://bugs.webkit.org/show_bug.cgi?id=50850
2893
2894         Remove the code that gets the statistics and fills in the per context
2895         statistics information for now.
2896
2897         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
2898         (-[BrowserStatisticsWindowController refreshStatistics:]):
2899
2900 2010-12-10  Eric Seidel  <eric@webkit.org>
2901
2902         Unreviewed.
2903
2904         commit-queue should report port/platform information when commenting on flaky test bugs
2905         https://bugs.webkit.org/show_bug.cgi?id=50839
2906
2907         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
2908         which was only used by new run webkit tests (and clearly not unit tested).
2909
2910         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
2911         * Scripts/webkitpy/tool/main.py:
2912         * Scripts/webkitpy/tool/mocktool.py:
2913
2914 2010-12-10  Eric Seidel  <eric@webkit.org>
2915
2916         Reviewed by Tony Chang.
2917
2918         commit-queue should report port/platform information when commenting on flaky test bugs
2919         https://bugs.webkit.org/show_bug.cgi?id=50839
2920
2921         This was a suggestion from Tony Chang this morning.
2922         I added a platform.py class so I could easily mock the platform call,
2923         but that may not be the final solution for this mocking.
2924         We'll try it and see.
2925
2926         * Scripts/webkitpy/common/system/platform.py: Added.
2927         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2928         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2929         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2930         * Scripts/webkitpy/tool/main.py:
2931         * Scripts/webkitpy/tool/mocktool.py:
2932
2933 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
2934
2935         Reviewed by Joseph Pecoraro.
2936
2937         Bug 43455 - [Qt]: Implement Application Cache Quotas
2938         https://bugs.webkit.org/show_bug.cgi?id=43455
2939
2940         Introduce functions to allow new appcache layout test origin-quota.html
2941         to work correctly under Qt.
2942
2943         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2944         (WebCore::DumpRenderTree::DumpRenderTree):
2945         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
2946         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2947
2948         Introduce functions to allow new appcache layout test origin-quota.html
2949         to be successful under qt. Changes required because LayoutTestControllerQt
2950         does not inherit from LayoutController.
2951
2952         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2953         (LayoutTestController::reset):
2954         (LayoutTestController::clearAllApplicationCaches):
2955         (LayoutTestController::setApplicationCacheOriginQuota):
2956         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2957         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
2958         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
2959
2960 2010-12-10  Eric Seidel  <eric@webkit.org>
2961
2962         Reviewed by Adam Barth.
2963
2964         Move buildbot.py into its own module so we can split it out into one-file-per-class
2965         https://bugs.webkit.org/show_bug.cgi?id=50806
2966
2967         We're adding more buildbot logic these days, so it makes sense
2968         to give buildbot its own module.
2969
2970         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
2971         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
2972         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
2973         * Scripts/webkitpy/common/net/failuremap.py:
2974         * Scripts/webkitpy/common/net/regressionwindow.py:
2975         * Scripts/webkitpy/tool/commands/rebaseline.py:
2976
2977 2010-12-10  Tony Chang  <tony@chromium.org>
2978
2979         Reviewed by Eric Seidel.
2980
2981         Use FileSystem::remove when cleaning up http lock files
2982         https://bugs.webkit.org/show_bug.cgi?id=50830
2983
2984         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2985
2986 2010-12-10  Joone Hur  <joone@kldp.org>
2987
2988         Reviewed by Martin Robinson.
2989
2990         [GTK] DRT needs layoutTestController.setCacheModel
2991         https://bugs.webkit.org/show_bug.cgi?id=50705
2992         
2993         webkit_set_cache_mode() is called to set the cache model.
2994         
2995         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2996         (LayoutTestController::setCacheModel): Set the cache model. 
2997
2998 2010-12-10  Tony Chang  <tony@chromium.org>
2999
3000         Reviewed by Ojan Vafai.
3001
3002         [chromium] remove --use-drt and add --use-test-shell
3003         https://bugs.webkit.org/show_bug.cgi?id=50701
3004
3005         * Scripts/webkitpy/common/config/ports.py:
3006         * Scripts/webkitpy/common/config/ports_unittest.py:
3007         * Scripts/webkitpy/layout_tests/port/chromium.py:
3008         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3009         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3010         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3011         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3012         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3013         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3014         * Scripts/webkitpy/layout_tests/port/webkit.py:
3015         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3016         * Scripts/webkitpy/style/checkers/test_expectations.py:
3017         * Scripts/webkitpy/tool/commands/queries.py:
3018
3019 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
3020
3021         Reviewed by Steve Block.
3022
3023         [Chromium] Implement mocks for client-based geolocation
3024         https://bugs.webkit.org/show_bug.cgi?id=46895
3025
3026         * DumpRenderTree/chromium/LayoutTestController.cpp:
3027         (LayoutTestController::setGeolocationPermission):
3028         (LayoutTestController::setMockGeolocationPosition):
3029         (LayoutTestController::setMockGeolocationError):
3030         * DumpRenderTree/chromium/LayoutTestController.h:
3031         * DumpRenderTree/chromium/WebViewHost.cpp:
3032         (WebViewHost::geolocationClient):
3033         (WebViewHost::geolocationClientMock):
3034         (WebViewHost::reset):
3035         * DumpRenderTree/chromium/WebViewHost.h:
3036
3037 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
3038
3039         Reviewed by Martin Robinson.
3040
3041         [GTK] Add hasSpellingMarker support to the DRT
3042         https://bugs.webkit.org/show_bug.cgi?id=50739
3043
3044         Implemented the hasSpellingMarker to support spelling tests.
3045
3046         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3047         (LayoutTestController::hasSpellingMarker):
3048
3049 2010-12-10  Eric Seidel  <eric@webkit.org>
3050
3051         Reviewed by Ojan Vafai.
3052
3053         webkit-patch: not possible to use build-and-test with local commits
3054         https://bugs.webkit.org/show_bug.cgi?id=33378
3055
3056         Make --no-clean not even check if we have local commits.
3057         It's unclear to me why the code was originally written this way.
3058         I was unable to dig up a reason from svn history.
3059
3060         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3061         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3062
3063 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
3064
3065         Reviewed by Martin Robinson.
3066
3067         [GTK] AX: implement isEnabled in DRT
3068         https://bugs.webkit.org/show_bug.cgi?id=50814
3069
3070         Implement AccessibilityUIElement::isEnabled() for GTK.
3071
3072         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3073         (checkElementState): New function to refactor common code.
3074         (AccessibilityUIElement::isEnabled): Implement this by checking
3075         the current state of the AtkObject.
3076         (AccessibilityUIElement::isSelected): Use the new
3077         checkElementState function.
3078
3079 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3080
3081         Reviewed by Kenneth Rohde Christiansen.
3082
3083         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
3084         https://bugs.webkit.org/show_bug.cgi?id=50750
3085
3086         * MiniBrowser/qt/BrowserView.cpp:
3087         (BrowserView::BrowserView):
3088         * MiniBrowser/qt/BrowserView.h:
3089         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3090         (WTR::WebView::WebView):
3091
3092 2010-12-10  Joone Hur  <joone@kldp.org>
3093
3094         Reviewed by Xan Lopez.
3095
3096         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
3097         https://bugs.webkit.org/show_bug.cgi?id=50808
3098
3099         Unskipping the following test cases:
3100         userscripts/mixed-case-stylesheet.html
3101         userscripts/simple-stylesheet.html
3102         userscripts/user-style-all-frames.html
3103
3104         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3105         (LayoutTestController::addUserStyleSheet):
3106
3107 2010-12-10  Joone Hur  <joone@kldp.org>
3108
3109         Reviewed by Eric Seidel.
3110
3111         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
3112         https://bugs.webkit.org/show_bug.cgi?id=50783
3113
3114         This patch allows to unskip the following test cases:
3115         printing/page-rule-selection.html
3116         printing/page-format-data.html
3117
3118         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3119         (LayoutTestController::pageProperty): Added.
3120         (LayoutTestController::isPageBoxVisible): Ditto.
3121         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
3122         (LayoutTestController::addUserStyleSheet): Ditto.
3123
3124 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3125
3126         Reviewed by Kenneth Rohde Christiansen.
3127
3128         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
3129
3130         A menu allows to switch QNAM back to the same thread.
3131
3132         * QtTestBrowser/launcherwindow.cpp:
3133         (LauncherWindow::initializeView):
3134         (LauncherWindow::createChrome):
3135         (LauncherWindow::toggleThreadedQnam):
3136         * QtTestBrowser/launcherwindow.h:
3137         (WindowOptions::WindowOptions):
3138         * QtTestBrowser/webpage.cpp:
3139         (WebPage::WebPage):
3140         (WebPage::setQnamThreaded):
3141         * QtTestBrowser/webpage.h:
3142         (QnamThread::QnamThread):
3143         (QnamThread::~QnamThread):
3144         (QnamThread::networkAccessManager):
3145         (QnamThread::run):
3146
3147 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
3148
3149         Reviewed by Xan Lopez.
3150
3151         [Gtk] style="font-family: courier" makes text disappear
3152         https://bugs.webkit.org/show_bug.cgi?id=47452
3153
3154         Add a test that verifies that fonts without valid charmaps are
3155         never selected.
3156
3157         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3158         (initializeFonts): Initialize DRT with our font (derived from Ahem)
3159         that has no valid charmap.
3160         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
3161         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
3162         settings which may disable selection of bitmap fonts.
3163
3164 2010-12-10  Eric Seidel  <eric@webkit.org>
3165
3166         Unreviewed.
3167
3168         The commit-queue should file bugs about flaky tests it encounters
3169         https://bugs.webkit.org/show_bug.cgi?id=50803
3170
3171         create_bug_for_flaky_test was insufficiently tested, thus buggy.
3172         Now it's tested.
3173
3174         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3175         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3176
3177 2010-12-10  Eric Seidel  <eric@webkit.org>
3178
3179         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
3180
3181         The commit-queue should file bugs about flaky tests it encounters
3182         https://bugs.webkit.org/show_bug.cgi?id=50803
3183
3184         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3185
3186 2010-12-09  Eric Seidel  <eric@webkit.org>
3187
3188         Reviewed by Adam Barth.
3189
3190         The commit-queue should file bugs about flaky tests it encounters
3191         https://bugs.webkit.org/show_bug.cgi?id=50803
3192
3193         This change got a bit big.  I also added a new config.urls file
3194         because I needed to share the view_source_url code with committervalidator.py.
3195
3196         This adds a new class FlakyTestReporter which holds all the logic about
3197         reporting flaky tests to bugzilla.
3198
3199         Right now this code knows how to look up bugs for flaky tests.
3200         If it can't find a bug filed from the commit-queue, it will open a new
3201         one, ccing the relevant people and adding information about the failure.
3202
3203         It is not yet smart enough to chase down duplicate chains, or to include
3204         the actual failure diff.  But those can be added in later iterations.
3205
3206         * Scripts/webkitpy/common/checkout/api.py:
3207         * Scripts/webkitpy/common/checkout/changelog.py:
3208         * Scripts/webkitpy/common/checkout/commitinfo.py:
3209         * Scripts/webkitpy/common/config/committervalidator.py:
3210         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3211         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3212         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
3213         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3214         * Scripts/webkitpy/tool/bot/irc_command.py:
3215         * Scripts/webkitpy/tool/bot/sheriff.py:
3216         * Scripts/webkitpy/tool/commands/download.py:
3217         * Scripts/webkitpy/tool/commands/queues.py:
3218         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3219         * Scripts/webkitpy/tool/comments.py:
3220         * Scripts/webkitpy/tool/mocktool.py:
3221         * Scripts/webkitpy/tool/steps/commit.py:
3222
3223 2010-12-09  Eric Seidel  <eric@webkit.org>
3224
3225         Reviewed by Adam Barth.
3226
3227         Teach webkit-patch how to search bugzilla
3228         https://bugs.webkit.org/show_bug.cgi?id=50500
3229
3230         This is a step towards teaching webkitpy how to file
3231         new bugs for flaky tests and update them when new flakes occur.
3232
3233         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3234         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3235         * Scripts/webkitpy/tool/commands/__init__.py:
3236         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
3237
3238 2010-12-09  Adam Barth  <abarth@webkit.org>
3239
3240         Reviewed by Ojan Vafai.
3241
3242         commit-queue errors out due to local commits
3243         https://bugs.webkit.org/show_bug.cgi?id=50766
3244
3245         We seem to be tripping over having local commits in the working copy a
3246         lot recently.  I don't quite fully understand what the issue is, but
3247         this patch attempts to solve the problem by adding an explicit clean
3248         step before processing a patch.  Previously, we did the cleaning as
3249         part of the apply-attachment step, so this might not actually fix the
3250         problem.
3251
3252         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3253         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3254         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3255
3256 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
3257
3258         Reviewed by Ojan Vafai.
3259
3260         Make new-run-webkit-tests --lint-test-files log slightly better
3261         messages and return -1 if lint fails. Remove the
3262         'suppress_errors' keyword param to the TestExpectationsFile
3263         class, and clean up logging and exception raising for error
3264         handling. Also add more unit tests and clean up the unit test code a bit.
3265
3266         https://bugs.webkit.org/show_bug.cgi?id=50205
3267
3268         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3269         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3270         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
3271         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
3272         * Scripts/webkitpy/layout_tests/port/chromium.py:
3273         * Scripts/webkitpy/style/checkers/test_expectations.py:
3274         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3275
3276 2010-12-09  Tony Chang  <tony@chromium.org>
3277
3278         Unreviewed, fix for windows code.  We were catching the wrong
3279         exception in Windows.
3280
3281         * Scripts/webkitpy/common/system/filesystem.py:
3282
3283 2010-12-09  Antonio Gomes  <agomes@rim.com>
3284
3285         Reviewed by Martin Robinson.
3286
3287         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
3288         https://bugs.webkit.org/show_bug.cgi?id=48429
3289
3290         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
3291
3292         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3293         (LayoutTestController::workerThreadCount):
3294
3295 2010-12-06  Philippe Normand  <pnormand@igalia.com>
3296
3297         Reviewed by Martin Robinson.
3298
3299         [GTK] Support the Mozilla-style Fullscreen Javascript API
3300         https://bugs.webkit.org/show_bug.cgi?id=50572
3301
3302         Enable the Javascript Fullscreen support in the GtkLauncher. Also
3303         make DRT update the Chrome when the WebView settings have been
3304         reset to consistent values.
3305
3306         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3307         (resetDefaultsToConsistentValues):
3308         * GtkLauncher/main.c:
3309         (create_window):
3310         * Scripts/build-webkit:
3311
3312 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
3313
3314         Reviewed by Tor Arne Vestbø
3315
3316         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
3317         https://bugs.webkit.org/show_bug.cgi?id=50742
3318
3319         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
3320
3321         * Scripts/webkitdirs.pm:
3322
3323 2010-12-09  Joone Hur  <joone@kldp.org>
3324
3325          Reviewed by Martin Robinson.
3326
3327          [GTK] Support for viewport meta tag
3328          https://bugs.webkit.org/show_bug.cgi?id=45443
3329
3330          Add support for testing the viewport properties for WebKitGtk.
3331
3332          * DumpRenderTree/LayoutTestController.cpp:
3333          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
3334          (LayoutTestController::staticFunctions):
3335          * DumpRenderTree/LayoutTestController.h:
3336          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3337          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
3338          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3339          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3340          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3341          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3342          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3343          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3344          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3345          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3346
3347 2010-12-08  William Siegrist <wsiegrist@apple.com>
3348
3349         Reviewed by Eric Seidel.
3350
3351         Migrate buildbot.py from xmlrpc to json.
3352         https://bugs.webkit.org/show_bug.cgi?id=50647
3353
3354         * Scripts/webkitpy/common/net/buildbot.py:
3355
3356 2010-12-08  Tony Chang  <tony@chromium.org>
3357
3358         Reviewed by Eric Seidel.
3359
3360         make starting the websocket server more reliable on windows
3361         https://bugs.webkit.org/show_bug.cgi?id=50712
3362
3363         * Scripts/webkitpy/common/system/filesystem.py:
3364         (remove): Substitute method for os.remove to retry on error on Windows
3365         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3366         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
3367
3368 2010-12-08  Jessie Berlin  <jberlin@apple.com>
3369
3370         Reviewed by Adam Roben.
3371
3372         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
3373         https://bugs.webkit.org/show_bug.cgi?id=50656
3374
3375         * MiniBrowser/mac/BrowserWindowController.m:
3376         (-[BrowserWindowController awakeFromNib]):
3377         Indicate that exceededDatabaseQuota is not implemented.
3378         * MiniBrowser/win/BrowserView.cpp:
3379         (BrowserView::create):
3380         Ditto.
3381         * WebKitTestRunner/TestController.cpp:
3382         (WTR::createOtherPage):
3383         Ditto.
3384         (WTR::TestController::initialize):
3385         Ditto.
3386
3387 2010-12-08  Antonio Gomes  <agomes@rim.com>
3388
3389         Reviewed by Martin Robinson.
3390
3391         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
3392         https://bugs.webkit.org/show_bug.cgi?id=48429
3393
3394         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
3395         * webkit_gc_collect_javascript_objects;
3396         * webkit_gc_collect_javascript_objects_on_alternate_thread;
3397         * webkit_gc_count_javascript_objects;
3398         * webkit_web_frame_layout.
3399
3400         These were all only used by GTK+ DRT.
3401
3402         * DumpRenderTree/gtk/EventSender.cpp:
3403         (dispatchEvent):
3404         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3405         (GCController::collect):
3406         (GCController::collectOnAlternateThread):
3407         (GCController::getJSObjectCount):
3408
3409 2010-12-07  Tony Chang  <tony@chromium.org>
3410
3411         Reviewed by Ojan Vafai.
3412
3413         [chromium] force NRWT to use DRT
3414         https://bugs.webkit.org/show_bug.cgi?id=50359
3415
3416         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3417
3418 2010-12-06  Sam Weinig  <sam@webkit.org>
3419
3420         Reviewed by Anders Carlsson.
3421
3422         Generalize didChangeLocationWithinPageForFrame for all same document navigations
3423         https://bugs.webkit.org/show_bug.cgi?id=50584
3424
3425         * MiniBrowser/mac/BrowserWindowController.m:
3426         (didSameDocumentNavigationForFrame):
3427         (-[BrowserWindowController awakeFromNib]):
3428         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
3429         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3430         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3431         (TestWebKitAPI::TEST):
3432         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3433         (WTR::InjectedBundlePage::InjectedBundlePage):
3434         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
3435         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3436         * WebKitTestRunner/TestController.cpp:
3437         (WTR::TestController::initialize):
3438
3439 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
3440
3441         Reviewed by Ojan Vafai.
3442
3443         Make TestResultsServer return 404 for non-existing results files.
3444         https://bugs.webkit.org/show_bug.cgi?id=50581
3445
3446         * TestResultServer/handlers/testfilehandler.py:
3447
3448 2010-12-06  Tony Chang  <tony@chromium.org>
3449
3450         Reviewed by Ojan Vafai.
3451
3452         [chromium] fix an assert hit in DRT
3453         https://bugs.webkit.org/show_bug.cgi?id=50575
3454
3455         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
3456         semantics.
3457
3458         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
3459         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
3460         WTF::RefCountedBase::ref()).
3461
3462         * DumpRenderTree/chromium/TestWebWorker.h:
3463         (TestWebWorker::TestWebWorker):
3464
3465 2010-12-02  Ojan Vafai  <ojan@chromium.org>
3466
3467         Reviewed by Eric Seidel.
3468
3469         make webkit-patch command work when the git branch is not synced to the remote svn branch
3470         https://bugs.webkit.org/show_bug.cgi?id=50424
3471
3472         * Scripts/webkitpy/common/checkout/scm.py:
3473         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3474
3475 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
3476
3477         Reviewed by Andreas Kling.
3478
3479         [WINCE] Add build system
3480         https://bugs.webkit.org/show_bug.cgi?id=50522
3481
3482         * CMakeListsWinCE.txt: Added.
3483
3484 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
3485
3486         Reviewed by Tony Chang.
3487
3488         Allow the Chromium port to have Leopard-specific baselines
3489         https://bugs.webkit.org/show_bug.cgi?id=50506
3490
3491         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3492
3493 2010-12-03  Tony Chang  <tony@chromium.org>
3494
3495         Reviewed by Kent Tamura.
3496
3497         [chromium] fix 2 bugs with inspector tests in DRT
3498         https://bugs.webkit.org/show_bug.cgi?id=50492
3499
3500         Tasks can outlive the tasklist (even when canceled) so this was
3501         causing a crash when ~WebTask() ran.  Avoid this by unregistering
3502         when a task is canceled.
3503
3504         Also fix an assert when closing devtool windows by copying some
3505         logic from test_shell.
3506
3507         * DumpRenderTree/chromium/Task.cpp:
3508         (WebTask::~WebTask):
3509         (TaskList::revokeAll):
3510         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
3511             the tasklist (since the task can outlive the tasklist).
3512         * DumpRenderTree/chromium/TestShell.h:
3513         (TestShell::devToolsWebView):
3514         * DumpRenderTree/chromium/WebViewHost.cpp:
3515         (WebViewHost::~WebViewHost): Don't load about:blank when closing
3516             a window if the window has devtools loaded.  This avoids an
3517             ASSERT and matches test_shell.
3518
3519 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
3520
3521         Reviewed by Martin Robinson.
3522
3523         [GTK] Fix GtkLauncher.c style, use webkit style
3524         https://bugs.webkit.org/show_bug.cgi?id=50542
3525
3526         * GtkLauncher/main.c:
3527         (activateUriEntryCb):
3528         (updateTitle):
3529         (linkHoverCb):
3530         (notifyTitleCb):
3531         (notifyLoadStatusCb):
3532         (notifyProgressCb):
3533         (destroyCb):
3534         (goBackCb):
3535         (goForwardCb):
3536         (create_webViewCb):
3537         (webViewReadyCb):
3538         (closeWebViewCb):
3539         (createBrowser):
3540         (createStatusbar):
3541         (createToolbar):
3542         (createWindow):
3543         (main):
3544
3545 2010-12-04  Antonio Gomes  <agomes@rim.com>
3546
3547         Reviewed by Martin Robinson.
3548
3549         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
3550         https://bugs.webkit.org/show_bug.cgi?id=48429
3551
3552         Moved more private method declared with WEBKIT_API to
3553         DumpRenderTreeSupportGtk, since they were only being used by DRT.
3554
3555         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3556         (resetDefaultsToConsistentValues):
3557         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3558         (LayoutTestController::addOriginAccessWhitelistEntry):
3559         (LayoutTestController::execCommand):
3560         (LayoutTestController::isCommandEnabled):
3561
3562 2010-12-04  Antonio Gomes  <agomes@rim.com>
3563
3564         Reviewed by Andreas Kling.
3565
3566         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
3567
3568         Method was removed by http://trac.webkit.org/changeset/71604
3569
3570         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3571
3572 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
3573
3574         Reviewed by Xan Lopez.
3575
3576         [GTK] Fix compilation warnings reported by clang
3577         https://bugs.webkit.org/show_bug.cgi?id=50252
3578
3579         * GtkLauncher/main.c:
3580         (create_window): The create_statusbar function does not have
3581         parameters.
3582
3583 2010-12-05  Robert Hogan  <robert@webkit.org>
3584
3585         Reviewed by Andreas Kling.
3586
3587         [Qt] Zero-sized font does not yet work
3588
3589         Fix fast/text/font-size-zero.html
3590
3591         Copy other ports by setting minimumFontSize to 0 for DRT runs.
3592
3593         https://bugs.webkit.org/show_bug.cgi?id=49759
3594
3595         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3596         (WebCore::WebPage::WebPage):
3597
3598 2010-12-04  Sam Weinig  <sam@webkit.org>
3599
3600         Reviewed by Jon Honeycutt.
3601
3602         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
3603         https://bugs.webkit.org/show_bug.cgi?id=50511
3604
3605         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
3606         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
3607
3608         * MiniBrowser/mac/BrowserWindowController.m:
3609         (didChangeLocationWithinPageForFrame):
3610         (-[BrowserWindowController awakeFromNib]):
3611         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
3612         * TestWebKitAPI/PlatformUtilities.cpp:
3613         (TestWebKitAPI::Util::toWK):
3614         * TestWebKitAPI/PlatformUtilities.h:
3615         (TestWebKitAPI::Util::adoptWK):
3616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3617         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
3618         (TestWebKitAPI::nullJavaScriptCallback):
3619         (TestWebKitAPI::didFinishLoadForFrame):
3620         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
3621         (TestWebKitAPI::TEST):
3622         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
3623         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3624         * TestWebKitAPI/win/copy-resources.cmd:
3625         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3626         (WTR::InjectedBundlePage::InjectedBundlePage):
3627         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
3628         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3629         * WebKitTestRunner/TestController.cpp:
3630         (WTR::TestController::initialize):
3631
3632 2010-11-08  Antonio Gomes  <agomes@rim.com>
3633
3634         Reviewed by Martin Robinson.
3635
3636         [Gtk] Populate DumpRenderTreeSupportGtk
3637         https://bugs.webkit.org/show_bug.cgi?id=48429
3638
3639         Made the previous calls to webkit_web_frame* functions defined as private
3640         APIs in webkitprivate.h go through DRTSupportGtk.
3641
3642         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3643         (AccessibilityController::focusedElement):
3644         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3645         (dumpFramesAsText):
3646         (resetDefaultsToConsistentValues):
3647         (dump):
3648         (webViewDocumentLoadFinished):
3649         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3650         (LayoutTestController::counterValueForElementById):
3651         (LayoutTestController::pageNumberForElementById):
3652         (LayoutTestController::numberOfPages):
3653         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3654         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3655         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3656         (LayoutTestController::numberOfActiveAnimations):
3657         (LayoutTestController::suspendAnimations):
3658         (LayoutTestController::resumeAnimations):
3659         (LayoutTestController::markerTextForListItem):
3660
3661 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
3662
3663         Reviewed by Tony Chang.
3664
3665         Rebaseline server: use pretty text diff output
3666         https://bugs.webkit.org/show_bug.cgi?id=50484
3667         
3668         Serve *-pretty-diff.html for text diff output.
3669
3670         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3671         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3672         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3673         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3674
3675 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3676
3677         Unreviewed, rolling out r73302.
3678         http://trac.webkit.org/changeset/73302
3679         https://bugs.webkit.org/show_bug.cgi?id=50499
3680
3681         Causes crashes in debug LayoutTests (Requested by xan_ on
3682         #webkit).
3683
3684         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3685         (AccessibilityUIElement::AccessibilityUIElement):
3686         (AccessibilityUIElement::parentElementCallback):
3687         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3688         * DumpRenderTree/chromium/CppBoundClass.cpp:
3689         * DumpRenderTree/chromium/CppBoundClass.h:
3690
3691 2010-12-03  Sam Weinig  <sam@webkit.org>
3692
3693         Reviewed by Maciej Stachowiak.
3694
3695         Enable <a ping> for Mac/Windows/WebKit2 builds
3696         <rdar://problem/8504473>
3697         https://bugs.webkit.org/show_bug.cgi?id=50488
3698
3699         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3700         (TestWebKitAPI::TEST): Test that the default value of
3701         WKPreferencesGetHyperlinkAuditingEnabled is true.
3702
3703 2010-12-03  Chris Guillory  <chris.guillory@google.com>
3704
3705         Reviewed by Chris Fleizach.
3706
3707         Include the FrameView widget of a RenderWidget in the accessibility tree.
3708         https://bugs.webkit.org/show_bug.cgi?id=49106
3709
3710         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3711         (AccessibilityUIElement::AccessibilityUIElement):
3712         (AccessibilityUIElement::parentElementCallback):
3713         (AccessibilityUIElement::isEqualCallback):
3714         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3715         * DumpRenderTree/chromium/CppBoundClass.cpp:
3716         (CppBoundClass::getFromCppVariant):
3717         * DumpRenderTree/chromium/CppBoundClass.h:
3718
3719 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
3720
3721         Reviewed by Tony Chang.
3722
3723         Rebaseline server: organize tests by state, add dry run mode
3724         https://bugs.webkit.org/show_bug.cgi?id=50473
3725         
3726         Group tests in the menu by state, so that it's easier to see after
3727         processing the queue which failed.
3728         
3729       &nbs