1 2016-03-30 Daniel Bates <dabates@apple.com>
3 run-webkit-tests must create parent directory of user's cache directory before running tests
4 https://bugs.webkit.org/show_bug.cgi?id=156009
5 <rdar://problem/25442682>
7 Reviewed by Alexey Proskuryakov.
9 The script run-webkit-tests must create the parent directory of the user's cache directory
10 before running tests because a WebKit2 child process expects that this directory exists
13 The script run-webkit-tests influences the path chosen by a WebKit2 child process for the
14 user's temporary directory and user's cache directory via the environment variable
15 DIRHELPER_USER_DIR_SUFFIX. For the user's temporary directory, run-webkit-tests creates it
16 as part of setting up the test environment. But run-webkit-tests does not create the user's
17 cache directory. Therefore there is race between the time AppKit creates it and when the
18 launched WebContent and Network processes query for the path to the user's cache directory
19 such that the OS may return the empty string to the WebContent and Network processes if
20 queried for this directory before AppKit creates it.
22 * Scripts/webkitpy/port/base.py:
23 (Port._path_to_user_cache_directory): Added. Base class implementation that returns the
24 empty string. We will override this method for the OS X port to return the path to the
25 user's cache directory with the specified suffix.
26 (Port.remove_cache_directory): Deleted.
27 * Scripts/webkitpy/port/driver.py:
28 (Driver.__init__): Initialize self._driver_user_directory_suffix and self._driver_user_cache_directory
29 to the suffix to use for the user's temporary and cache directories and the path to the
30 user's cache directory, respectively.
31 (Driver._setup_environ_for_driver): Modified to set the environment variable DIRHELPER_USER_DIR_SUFFIX
32 to self._driver_user_directory_suffix.
33 (Driver._start): Compute the user directory suffix and the path to the user's cache
34 directory. Create the user's cache directory (if applicable).
35 (Driver.stop): Modified to remove directory self._driver_user_cache_directory (if applicable).
36 * Scripts/webkitpy/port/mac.py:
37 (MacPort.user_cache_directory): Added. Overrides Port._path_to_user_cache_directory().
38 (MacPort.remove_cache_directory): Deleted.
40 2016-03-29 Benjamin Poulain <bpoulain@apple.com>
42 [WTF] Removing a smart pointer from HashTable issues two stores to the same location
43 https://bugs.webkit.org/show_bug.cgi?id=155676
45 Reviewed by Darin Adler.
47 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
48 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
50 2016-03-29 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
52 Add machine-readable results for JSC stress tests
53 https://bugs.webkit.org/show_bug.cgi?id=155771
55 Reviewed by Darin Adler and Dean Johnson
57 Add an option to output JSC stress test results to a user-specified file in JSON format.
59 * Scripts/run-javascriptcore-tests:
60 (runJSCStressTests): Add JSON output support
61 (readAllLines): Remove trailing newline from the end of each item
63 2016-03-29 Alex Christensen <achristensen@webkit.org>
67 * TestWebKitAPI/PlatformWin.cmake:
69 2016-03-29 Timothy Hatcher <timothy@apple.com>
71 Update WebKit nightly to have a red needle to better match Safari
73 https://bugs.webkit.org/show_bug.cgi?id=155983
75 Reviewed by Joseph Pecoraro.
77 * WebKitLauncher/webkit.icns:
79 2016-03-28 Joanmarie Diggs <jdiggs@igalia.com>
81 Adding myself as a reviewer.
85 * Scripts/webkitpy/common/config/contributors.json:
87 2016-03-25 Dewei Zhu <dewei_zhu@apple.com>
89 Dromaeo patch used by run-benchmark should not include an invalid address.
90 https://bugs.webkit.org/show_bug.cgi?id=155910
92 Reviewed by Ryosuke Niwa.
94 Should not use invalid 'http://127.0.0.1/Icons/w3c_home' in the patched version of test.
95 * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
97 2016-03-25 Daniel Bates <dabates@apple.com>
99 Add WebKitSystemInterface for iOS 9.3
100 https://bugs.webkit.org/show_bug.cgi?id=155893
102 Rubber-stamped by Alexey Proskuryakov.
104 * Scripts/copy-webkitlibraries-to-product-directory:
106 2016-03-25 Daniel Bates <dabates@apple.com>
108 Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK()
109 in copy-webkitlibraries-to-product-directory
110 https://bugs.webkit.org/show_bug.cgi?id=155869
112 Reviewed by Alexey Proskuryakov.
114 It is sufficient and more direct to call webkitdirs::determineXcodeSDK() instead of
115 webkitdirs::willUseIOSDeviceSDK() to process the --sdk/--device/--ios-simulator command
118 * Scripts/copy-webkitlibraries-to-product-directory:
120 2016-03-25 Konstantin Tokarev <annulen@yandex.ru>
122 Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.
123 https://bugs.webkit.org/show_bug.cgi?id=155882
125 Reviewed by Michael Catanzaro.
127 It was already enabled in all trunk ports, and is required for
128 WebInspectorUI to work.
130 * Scripts/webkitperl/FeatureList.pm:
132 2016-03-24 Jeremy Zerfas <WebKit@JeremyZerfas.com>
134 Improve update-webkit-dependency script.
135 https://bugs.webkit.org/show_bug.cgi?id=155576
137 Reviewed by Brent Fulgham.
139 * Scripts/update-webkit-dependency:
140 -Updated script to also use ETags for helping to determine whether dependency is up to date.
141 -Updated script so it usually won't need to download the entire dependency each time it is
143 -Updated script to ensure zip file contains expected directories before trying to install.
144 -Added some more error checking and improved error messages.
145 (lastModifiedToUnixTime): Deleted.
147 * Scripts/update-webkit-wincairo-libs:
148 -Corrected comment about what script does.
150 2016-03-24 Bill Ming <mbbill@gmail.com>
152 Fix webkitpy tests after r198617
153 https://bugs.webkit.org/show_bug.cgi?id=155827
155 Reviewed by Alex Christensen.
157 * Scripts/webkitpy/tool/steps/confirmdiff.py:
158 (ConfirmDiff._show_pretty_diff):
160 2016-03-23 Bill Ming <mbbill@gmail.com>
162 webkit-patch failed to open pretty diff on Windows
163 https://bugs.webkit.org/show_bug.cgi?id=155827
165 Reviewed by Alex Christensen.
167 * Scripts/webkitpy/tool/steps/confirmdiff.py:
168 (ConfirmDiff._show_pretty_diff):
170 2016-03-23 Jer Noble <jer.noble@apple.com>
172 [ios-sim] RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForVideoButNotAudioPlayback failing
173 https://bugs.webkit.org/show_bug.cgi?id=155764
175 Reviewed by Eric Carlson.
177 Remove the requirement for media elements to have webkit-playsinline attributes on iOS.
179 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
180 (RequiresUserActionForPlaybackTest::SetUp):
182 2016-03-23 Anders Carlsson <andersca@apple.com>
184 Crash when using KVO from within -[WebView initWithCoder:]
185 https://bugs.webkit.org/show_bug.cgi?id=155816
186 rdar://problem/17073265
188 Reviewed by Dan Bernstein.
192 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
193 * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Added.
194 (-[EarlyKVOCrashResponder initWithWebView:]):
195 (-[EarlyKVOCrashResponder initWithCoder:]):
196 (-[EarlyKVOCrashResponder dealloc]):
197 (-[EarlyKVOCrashResponder encodeWithCoder:]):
198 (TestWebKitAPI::TEST):
200 2016-03-23 Lucas Forschler <lforschler@apple.com>
202 Teach kill-old-processes about perl 5.18.
204 Reviewed by Alexey Proskuryakov
206 * BuildSlaveSupport/kill-old-processes:
209 2016-03-22 Keith Rollin <krollin@apple.com>
211 Unreviewed: add Keith Rollin to the committers list.
213 * Scripts/webkitpy/common/config/contributors.json:
215 2016-03-22 Per Arne Vollan <peavo@outlook.com>
217 [Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround
218 https://bugs.webkit.org/show_bug.cgi?id=141499
220 Reviewed by Brent Fulgham.
222 As we have moved on to VS2015, this workaround is no longer needed.
224 * DumpRenderTree/cg/ImageDiffCG.cpp:
226 * DumpRenderTree/win/DumpRenderTree.cpp:
228 * DumpRenderTree/win/ImageDiffCairo.cpp:
230 * MiniBrowser/win/Common.cpp:
232 * TestWebKitAPI/win/main.cpp:
234 * win/DLLLauncher/DLLLauncherMain.cpp:
237 2016-03-22 Yusuke Suzuki <utatane.tea@gmail.com>
239 [JSC] ASMBench cannot be run without JSBENCH_PATH
240 https://bugs.webkit.org/show_bug.cgi?id=155751
242 Reviewed by Saam Barati.
244 Check ASMBENCH_PATH instead of JSBENCH_PATH for ASMBench files.
246 * Scripts/run-jsc-benchmarks:
248 2016-03-21 Brent Fulgham <bfulgham@apple.com>
250 [Win] SharedBuffer::copy() can cause a segmentation fault.
251 https://bugs.webkit.org/show_bug.cgi?id=155739
253 Reviewed by Ryosuke Niwa.
255 * TestWebKitAPI/PlatformWin.cmake: Build and run the
258 2016-03-22 Csaba Osztrogonác <ossy@webkit.org>
260 [buildbot] Move ARM Linux bots to JSCOnly port
261 https://bugs.webkit.org/show_bug.cgi?id=155655
263 Reviewed by Lucas Forschler.
265 * BuildSlaveSupport/build.webkit.org-config/config.json:
266 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
267 (ConfigureBuild.__init__):
268 (appendCustomBuildFlags):
271 (BuildAndRemoteJSCTestsFactory):
272 (BuildAndRemoteJSCTestsFactory.__init__):
273 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
274 * BuildSlaveSupport/clean-build:
277 2016-03-21 Brent Fulgham <bfulgham@apple.com>
279 Improve SharedBuffer testing
280 https://bugs.webkit.org/show_bug.cgi?id=93078
281 <rdar://problem/25277829>
283 Reviewed by Ryosuke Niwa.
285 Based on a Blink patch by Huang Dongsung <luxtella@company100.net>.
286 <https://src.chromium.org/viewvc/blink?revision=153850&view=revision,
287 and a Blink patch by <tyoshino@chromium.org>
288 <https://src.chromium.org/viewvc/blink?view=rev&revision=151617>
290 Add three test cases from the Blink project that cover various append,
291 copy, and createArrayBuffer calls.
293 * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
294 (TestWebKitAPI::TEST_F):
296 2016-03-21 Hyungwook Lee <hyungwook.lee@navercorp.com>
298 [Win] Connect layoutTestController.findString() to support testing
299 https://bugs.webkit.org/show_bug.cgi?id=50234
301 Reviewed by Alex Christensen.
303 Implement TestRunner::findString().
305 * DumpRenderTree/win/TestRunnerWin.cpp:
306 (TestRunner::findString):
308 2016-03-20 Dan Bernstein <mitz@apple.com>
310 [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR
311 https://bugs.webkit.org/show_bug.cgi?id=155707
312 <rdar://problem/24980691>
314 Reviewed by Darin Adler.
316 * ContentExtensionTester/Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR
317 based on the last component of MACOSX_DEPLOYMENT_TARGET.
318 * ContentExtensionTester/Configurations/DebugRelease.xcconfig: For engineering builds,
319 preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.
321 Similarly for these projects:
323 * DumpRenderTree/mac/Configurations/Base.xcconfig:
324 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
325 * LayoutTestRelay/Configurations/Base.xcconfig:
326 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
327 * MiniBrowser/Configurations/Base.xcconfig:
328 * MiniBrowser/Configurations/DebugRelease.xcconfig:
329 * TestWebKitAPI/Configurations/Base.xcconfig:
330 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
331 * WebEditingTester/Configurations/Base.xcconfig:
332 * WebEditingTester/Configurations/DebugRelease.xcconfig:
333 * WebKitTestRunner/Configurations/Base.xcconfig:
334 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
336 2016-03-20 Dan Bernstein <mitz@apple.com>
338 Update build settings
340 Rubber-stamped by Andy Estes.
342 * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
343 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
344 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
345 * MiniBrowser/Configurations/DebugRelease.xcconfig:
346 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
347 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Synced up to the ones in ../Source.
348 * WebEditingTester/Configurations/DebugRelease.xcconfig:
349 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
350 * asan/asan.xcconfig:
352 2016-03-18 Sam Weinig <sam@webkit.org>
354 Add test for HashMap::ensure that shows that moving into the lambda does not incure extra cost
355 https://bugs.webkit.org/show_bug.cgi?id=155621
357 Reviewed by Alex Christensen.
359 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
360 (TestWebKitAPI::ObjectWithRefLogger::ObjectWithRefLogger):
361 (TestWebKitAPI::testMovingUsingEnsure):
362 (TestWebKitAPI::testMovingUsingAdd):
363 Add tests ensuring that objects moved into a map using ensure don't
364 have extra ref-churn.
366 2016-03-17 Tim Horton <timothy_horton@apple.com>
368 Fix some deprecation warnings in WebEditingTester
369 https://bugs.webkit.org/show_bug.cgi?id=155601
371 Reviewed by Simon Fraser.
373 * WebEditingTester/AppDelegate.m:
374 (-[WebEditingAppDelegate showOperations:]):
375 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
377 2016-03-17 Tim Horton <timothy_horton@apple.com>
379 Find-in-page indicator in Mail viewer is the wrong scale and cut off
380 https://bugs.webkit.org/show_bug.cgi?id=155605
381 <rdar://problem/23948165>
383 Reviewed by Simon Fraser.
385 * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
387 Add a test that ensures that the find result image is correctly @2x.
388 The NSImage size should be in points.
390 2016-03-16 Commit Queue <commit-queue@webkit.org>
392 Unreviewed, rolling out r198187.
393 https://bugs.webkit.org/show_bug.cgi?id=155564
395 Potentially break testing on iOS (Requested by Guest23 on
400 "Add twisted-15.5.0 module to
401 webkitpy.thirdparty.autoinstalled."
402 https://bugs.webkit.org/show_bug.cgi?id=154667
403 http://trac.webkit.org/changeset/198187
405 2016-03-16 David Kilzer <ddkilzer@apple.com>
407 check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI
408 <http://webkit.org/b/155445>
410 Reviewed by Darin Adler.
412 * Scripts/webkitpy/style/checker.py:
413 (_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks
414 on TestWebKitAPI since this project uses a config.h header as of
415 r95188. Also remove references to WebKitAPITest, which ceased
418 * Scripts/webkitpy/style/checker_unittest.py:
419 (GlobalVariablesTest.test_path_rules_specifier): Add tests.
420 Remove reference to WebKitAPITest project.
422 2016-03-16 Tim Horton <timothy_horton@apple.com>
424 [mac] Printing test snapshots are upside-down after r198242
425 https://bugs.webkit.org/show_bug.cgi?id=155543
427 Reviewed by Simon Fraser.
429 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
430 (createPagedBitmapContext):
431 Flip printing snapshots in DRT so that everything is right-side-up.
433 2016-03-16 Alexey Proskuryakov <ap@apple.com>
435 Update unit test for iOS debug queues.
437 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
439 2016-03-16 Jiewen Tan <jiewen_tan@apple.com>
441 URL Parsing should signal failure for illegal IDN
442 https://bugs.webkit.org/show_bug.cgi?id=154945
443 <rdar://problem/8014795>
445 Reviewed by Brent Fulgham.
447 * MiniBrowser/mac/WK2BrowserWindowController.m:
448 (-[WK2BrowserWindowController fetch:]):
449 * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
450 (TestWebKitAPI::TEST):
452 2016-03-15 Tim Horton <timothy_horton@apple.com>
454 [iOS Simulator] Test result snapshots are upside down
455 https://bugs.webkit.org/show_bug.cgi?id=154761
457 Reviewed by Simon Fraser.
459 * WebKitTestRunner/cg/TestInvocationCG.cpp:
460 (WTR::createCGContextFromImage):
461 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
462 In r97104, Simon added code to take WindowServer snapshots, which came
463 in flipped, and added code to flip them back. At this point, WindowServer
464 snapshots got flipped, and software snapshots did not.
466 In r140067, Simon noticed that WindowServer ref test images were upside-down
467 on Mac (not sure why this changed), so turned off the flipping code (but
468 didn't delete it!). Now, WindowServer snapshots and software snapshots both
471 In r190304, Carlos added an enum for the source of the snapshot ("WebView"
472 for window server snapshots, and "WebContent" for software snapshots),
473 and - critically - changed the flipping logic to flip software snapshots!
475 We didn't notice this on Mac because at this point we've made it so that
476 we *always* have WindowServer snapshots, but on iOS we still don't have
477 WindowServer snapshots, so now they're flipped.
479 And that's how we got here.
481 To restore the behavior from r140067, and correctly unflip snapshots on
482 iOS, just delete this code.
484 2016-03-15 Alexey Proskuryakov <ap@apple.com>
486 run-api-tests doesn't print test name when the test crashes
487 https://bugs.webkit.org/show_bug.cgi?id=155476
489 Reviewed by Daniel Bates.
491 * Scripts/run-api-tests: Print "UNEXPECTEDLY EXITED" with a test name when output
492 doesn't contain the test name yet. Changed test name output to always be before raw
495 2016-03-15 Chris Dumez <cdumez@apple.com>
497 Unreviewed, rolling out r198203.
499 Favorites view is no longer loading on iOS
503 "URL Parsing should signal failure for illegal IDN"
504 https://bugs.webkit.org/show_bug.cgi?id=154945
505 http://trac.webkit.org/changeset/198203
507 2016-03-15 Jiewen Tan <jiewen_tan@apple.com>
509 URL Parsing should signal failure for illegal IDN
510 https://bugs.webkit.org/show_bug.cgi?id=154945
511 <rdar://problem/8014795>
513 Reviewed by Brent Fulgham.
515 * MiniBrowser/mac/WK2BrowserWindowController.m:
516 (-[WK2BrowserWindowController fetch:]):
517 * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
518 (TestWebKitAPI::TEST):
520 2016-03-14 Chris Dumez <cdumez@apple.com>
522 Unreviewed, rolling out r197981.
524 Caused a massive PLT regression on Mac.
528 "Font antialiasing (smoothing) changes when elements are
529 rendered into compositing layers"
530 https://bugs.webkit.org/show_bug.cgi?id=23364
531 http://trac.webkit.org/changeset/197981
533 2016-03-14 Dewei Zhu <dewei_zhu@apple.com>
535 Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled.
536 https://bugs.webkit.org/show_bug.cgi?id=154667
538 Reviewed by Ryosuke Niwa and Simon Fraser.
540 Add twisted-15.5.0 to webkitpy.thirdparty.autoinstalled.
541 Minor fix for twsited_http_server used by run-benchmark that we should only stop http server while recieving 'GET /shutdown'.
543 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
544 (ServerControl.render_POST): Deleted.
545 * Scripts/webkitpy/thirdparty/__init__.py:
546 (AutoinstallImportHook.find_module):
547 (AutoinstallImportHook._install_twisted_15_5_0):
548 * Scripts/webkitpy/thirdparty/__init___unittest.py:
549 (ThirdpartyTest.test_imports):
551 2016-03-14 Mark Lam <mark.lam@apple.com>
553 Need to distinguish between Symbol() and Symbol("").
554 https://bugs.webkit.org/show_bug.cgi?id=155438
556 Reviewed by Saam Barati.
558 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
559 (TestWebKitAPI::TEST):
560 - Test that the a symbol with an empty string is not equivalent to a null symbol.
562 2016-03-14 David Kilzer <ddkilzer@apple.com>
564 Remove blank lines after #include "config.h"
566 Follow-up fix from review comments on Bug 155394.
568 * TestWebKitAPI/PlatformUtilities.cpp:
569 * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
571 2016-03-14 Frederic Wang <fred.wang@free.fr>
573 Unreviewed: Add my professional email address.
575 * Scripts/webkitpy/common/config/contributors.json:
577 2016-03-14 Youenn Fablet <youenn.fablet@crf.canon.fr>
579 Web platform test server should not try to launch servers on already bound sockets
580 https://bugs.webkit.org/show_bug.cgi?id=141157
582 Reviewed by Darin Adler.
584 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
585 (wpt_config_json): Load WPT config from LayoutTests/imported/w3c/resources/config.json.
586 (base_url): Refactored to use wpt_config_json routine.
587 (WebPlatformTestServer.__init__): Fill port mappings according WPT config.
589 2016-03-13 Joseph Pecoraro <pecoraro@apple.com>
591 Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards
592 https://bugs.webkit.org/show_bug.cgi?id=155417
594 Reviewed by Yusuke Suzuki.
596 * Scripts/webkitperl/FeatureList.pm:
597 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
599 2016-03-13 Dean Jackson <dino@apple.com>
601 DRT should enable WebGL by default on Mac
602 https://bugs.webkit.org/show_bug.cgi?id=155419
603 <rdar://problem/25136981>
605 Reviewed by Sam Weinig.
607 For some reason, lost in time, WebGL was enabled
608 by default on trunk, but disabled by default
609 in DumpRenderTree when using WebKit 1. This
610 was very annoying, because each test had
611 an explicit command to enable it.
613 * DumpRenderTree/mac/DumpRenderTree.mm:
614 (resetWebPreferencesToConsistentValues): Deleted WebGL line.
616 2016-03-13 Konstantin Tokarev <annulen@yandex.ru>
618 Added new port JSCOnly.
619 https://bugs.webkit.org/show_bug.cgi?id=154512
621 Reviewed by Michael Catanzaro.
623 This port allows to build JavaScriptCore engine with minimal
627 * Scripts/webkitdirs.pm:
628 (argumentsForConfiguration):
629 (executableProductDir):
632 (wrapperPrefixIfNeeded):
633 (generateBuildSystemFromCMakeProject):
634 (buildCMakeGeneratedProject):
636 2016-03-13 David Kilzer <ddkilzer@apple.com>
638 TestWebKitAPI: fix linker warnings
639 <http://webkit.org/b/155394>
641 Reviewed by Darin Adler.
643 * TestWebKitAPI/CMakeLists.txt:
644 - Add RefLogger.cpp source file.
645 - Add other missing cross-platform source files.
646 - Add FIXMEs about RunLoop.cpp and about missing
647 platform-specific source files.
648 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
649 - Add RefLogger.cpp source file.
651 * TestWebKitAPI/Counters.cpp:
652 (DeleterCounter<ConstructorDestructorCounter>::deleterCount):
653 Move specific declaration here to fix linker warning.
654 * TestWebKitAPI/Counters.h:
655 (DeleterCounter<T>::deleterCount): Remove declaration of global
658 * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Added.
659 (TestWebKitAPI::log): Added. Move inline definition in
660 RefLogger.h to here to fix linker warning.
662 * TestWebKitAPI/Tests/WTF/RefLogger.h:
663 (TestWebKitAPI::log): Replace inline function with declaration.
665 2016-03-12 David Kilzer <ddkilzer@apple.com>
667 REGRESSION (r178615): Fix incorrect case in included header for WeakPtr.cpp
669 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Change "test.h" to
670 "Test.h" to fix incorrect case. This was discovered when adding
671 WeakPtr.cpp to CMakeLists.txt for the patch on Bug 155394.
673 2016-03-12 David Kilzer <ddkilzer@apple.com>
675 run-webkit-tests: handle Darwin framework/library environment variables more consistently
676 <http://webkit.org/b/155392>
678 Reviewed by Daniel Bates.
680 These changes will make it possible to pass through environment
681 variables from the run-webkit-tests command-line.
683 * Scripts/webkitpy/port/base.py:
684 (Port.to.setup_environ_for_server): Add DYLD_FRAMEWORK_PATH,
685 __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_LIBRARY_PATH to the
686 list of variables to keep from the run-webkit-test environment.
688 * Scripts/webkitpy/port/driver.py:
689 (Driver._append_environment_variable_path): Add method to append
690 a path to an environment variable, or set the path if the
691 variable doesn't exist.
692 (Driver._setup_environ_for_driver): Extract build_root_path into
693 a local variable. Use Driver._append_environment_variable_path
694 to extend DYLD_LIBRARY_PATH, __XPC_DYLD_LIBRARY_PATH,
695 DYLD_FRAMEWORK_PATH and __XPC_DYLD_FRAMEWORK_PATH instead of
698 * Scripts/webkitpy/port/driver_unittest.py:
699 (DriverTest.test__append_environment_variable_path): Add test
700 method to test Driver._append_environment_variable_path.
702 2016-03-11 Alexey Proskuryakov <ap@apple.com>
704 [ios-sim debug] API test WTF_Lock.ContendedShortSection and WTF_ParkingLot.UnparkOneFifty timing out
705 https://bugs.webkit.org/show_bug.cgi?id=155276
707 [ios-sim] API test WTF_Condition.TenProducersTenConsumersOneSlot timing out
708 https://bugs.webkit.org/show_bug.cgi?id=155345
710 [iOS Simulator] API test timeout: WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
711 https://bugs.webkit.org/show_bug.cgi?id=153997
712 <rdar://problem/23580034>
714 <rdar://problem/23580018> TestWebKitAPI Timeout: WTF_ParkingLot.UnparkOneFifty
716 Rubber-stamped by Filip Pizlo.
718 * Scripts/run-api-tests: These tests are pretty slow. Increase API test timeout.
720 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Start running WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
723 2016-03-11 Jer Noble <jer.noble@apple.com>
725 [ios-sim debug] API tests RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForAudioButNotVideoPlayback asserting
726 https://bugs.webkit.org/show_bug.cgi?id=155365
728 Reviewed by Darin Adler.
730 Allow tests running on iOS simulator to play video inline, avoiding this assert.
732 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
733 (RequiresUserActionForPlaybackTest::SetUp):
735 2016-03-11 Frederic Wang <fwang@igalia.com>
737 [jhbuild] Disable LLVM OCaml bindings.
738 https://bugs.webkit.org/show_bug.cgi?id=153274
740 Reviewed by Michael Catanzaro.
742 * gtk/jhbuild.modules: disable all (actually only OCaml) bindings for LLVM.
744 2016-03-11 Commit Queue <commit-queue@webkit.org>
746 Unreviewed, rolling out r197495.
747 https://bugs.webkit.org/show_bug.cgi?id=155369
749 LLVM is needed to run update-webkitgtk-libs reliably
750 (Requested by mcatanzaro on #webkit).
754 "[jhbuild] Remove LLVM dependency."
755 https://bugs.webkit.org/show_bug.cgi?id=153274
756 http://trac.webkit.org/changeset/197495
758 2016-03-11 Youenn Fablet <youenn.fablet@crf.canon.fr>
760 WTF should have a similar function as equalLettersIgnoringASCIICase to match beginning of strings
761 https://bugs.webkit.org/show_bug.cgi?id=153419
763 Reviewed by Darin Adler.
765 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
766 (TestWebKitAPI::TEST): Adding test case for startsWithLettersIgnoringASCIICase.
769 2016-03-10 Simon Fraser <simon.fraser@apple.com>
771 Font antialiasing (smoothing) changes when elements are rendered into compositing layers
772 https://bugs.webkit.org/show_bug.cgi?id=23364
774 Reviewed by Tim Horton.
776 Turn off smoothed layer text because it affects many layout test results.
778 * DumpRenderTree/mac/DumpRenderTree.mm:
779 (resetWebViewToConsistentStateBeforeTesting):
780 * WebKitTestRunner/TestController.cpp:
781 (WTR::TestController::resetStateToConsistentValues):
783 2016-03-10 Jer Noble <jer.noble@apple.com>
785 Partial roll-out of r197953; test fails because encode/decode support of those properties were never added.
787 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
790 2016-03-10 Myles C. Maxfield <mmaxfield@apple.com>
792 [OS X] Main frame scrollbars should appear on the left on RTL systems
793 https://bugs.webkit.org/show_bug.cgi?id=155149
795 Reviewed by Simon Fraser.
797 Setting the volatile default needs to be done early, so it is
798 plumbed through the injected bundle's initialization routine.
800 Control of RTL scrollbars is handled by putting the string
801 <!-- webkit-test-runner [ rtlScrollbars=true ] -->
802 on the first line of a test.
804 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
805 (WTR::shouldUseRTLScrollbars):
806 (WTR::InjectedBundle::platformInitialize):
807 * WebKitTestRunner/TestController.cpp:
808 (WTR::TestController::generatePageConfiguration):
809 (WTR::updateTestOptionsFromTestHeader):
810 (WTR::TestController::getInjectedBundleInitializationUserData):
811 * WebKitTestRunner/TestController.h:
812 * WebKitTestRunner/TestOptions.h:
813 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
814 (WTR::PlatformWebView::viewSupportsOptions):
816 2016-03-08 Jer Noble <jer.noble@apple.com>
818 Add separate WK and WK2 preferences for requiring user gestures for video media, distinct from user gestures for media generally
819 https://bugs.webkit.org/show_bug.cgi?id=155141
821 Reviewed by Beth Dakin.
823 Set the default values for media preferences unconditionally, not just on PLATFORM(IOS). Set "video requires user gesture"
824 to sane defaults in addition to "audio requires user gesture" and (in the case of DumpREnderTree) instead of "media requires user gesture".
826 Add a new test of WK2 user gesture requirement preferences.
828 * DumpRenderTree/mac/DumpRenderTree.mm:
829 (resetWebPreferencesToConsistentValues):
830 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
831 * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
832 * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
833 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Added.
834 (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]):
835 (-[RequiresUserActionForPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
836 (RequiresUserActionForPlaybackTest::SetUp):
837 (RequiresUserActionForPlaybackTest::createWebView):
838 (RequiresUserActionForPlaybackTest::testVideoWithAudio):
839 (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
840 (RequiresUserActionForPlaybackTest::testAudioOnly):
842 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
845 2016-03-10 Brian Burg <bburg@apple.com>
847 Web Inspector: should be able to run protocol and input generator scripts from any directory
848 https://bugs.webkit.org/show_bug.cgi?id=155307
850 Reviewed by Joseph Pecoraro.
852 * Scripts/webkitpy/inspector/main.py:
853 (InspectorGeneratorTests.main):
854 * Scripts/webkitpy/replay/main.py:
855 (InputGeneratorTests.main):
856 Compute the current SCM based on the location of the script being executed, not
857 the $CWD which could be anything. There's rarely a good reason to use $CWD.
859 2016-03-10 David Kilzer <ddkilzer@apple.com>
861 [iOS] DumpRenderTree crashes when accessing window.testRunner.inspectorTestStubURL
862 <http://webkit.org/b/155295>
864 Reviewed by Brent Fulgham.
866 * DumpRenderTree/mac/TestRunnerMac.mm:
867 (TestRunner::inspectorTestStubURL): Always return nullptr for
868 PLATFORM(IOS). This matches what we did in r192604 for
869 WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm.
871 2016-03-10 Frederic Wang <fwang@igalia.com>
873 [GTK] Add support for WOFF2
874 https://bugs.webkit.org/show_bug.cgi?id=152616
876 Reviewed by Carlos Garcia Campos.
878 * Scripts/webkitpy/style/checker.py: Only verify basic style for third party modules brotli and woff2.
880 2016-03-09 Ryosuke Niwa <rniwa@webkit.org>
882 Add runtime flags for shadow DOM and custom elements
883 https://bugs.webkit.org/show_bug.cgi?id=155213
885 Reviewed by Dean Jackson.
887 Always enable shadow DOM and custom elements during testing.
889 * DumpRenderTree/mac/DumpRenderTree.mm:
890 (resetWebPreferencesToConsistentValues):
891 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
892 (WTR::InjectedBundle::beginTesting):
893 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
894 (WTR::TestRunner::setShadowDOMEnabled): Added.
895 * WebKitTestRunner/InjectedBundle/TestRunner.h:
897 2016-03-09 Brent Fulgham <bfulgham@apple.com>
899 Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes test breakage
900 https://bugs.webkit.org/show_bug.cgi?id=155265
901 <rdar://problem/11101440>
903 Reviewed by Andy Estes.
905 WK2 localStorage tests need the 'AllowUniversalAccessFromFileURLs' preference set by default.
906 Tests that confirm blocking localStorage manually set the flag to "False" in the test.
908 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
909 (WTR::initializeWebViewConfiguration): Set the default state to the correct value.
911 2016-03-09 David Kilzer <ddkilzer@apple.com>
913 check-webkit-style: fix false-positive warnings about @try/@catch blocks in Objective-C++ source files
914 <http://webkit.org/b/155273>
916 Reviewed by Andy Estes.
918 * Scripts/webkitpy/style/checkers/cpp.py:
919 (check_spacing_for_function_call): Ignore @catch lines.
920 (check_braces): Ditto.
921 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
922 (CppStyleTest.test_brace_at_begin_of_line): Add test case.
924 2016-03-09 Jason Marcell <jmarcell@apple.com>
926 Removing reference to Dashboard.Repository.Internal.trac from open source unit tests.
927 https://bugs.webkit.org/show_bug.cgi?id=155274
929 Reviewed by Alexey Proskuryakov.
931 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:
932 (setup): Deleted. In bug 154180 we removed Dashboard.Repository.Internal which was causing an
933 error in the unit tests.
935 2016-03-09 Aakash Jain <aakash_jain@apple.com>
937 use ulimit command to check process limit in webkitpy
938 https://bugs.webkit.org/show_bug.cgi?id=155260
940 Reviewed by Alexey Proskuryakov.
942 * Scripts/webkitpy/port/ios.py:
943 (IOSSimulatorPort.default_child_processes): Use ulimit command output instead of
944 launchctl limit maxproc command.
946 2016-03-09 Alexey Proskuryakov <ap@apple.com>
948 Stop building armv7 on iOS device builders
949 https://bugs.webkit.org/show_bug.cgi?id=155246
951 Reviewed by David Kilzer.
953 * BuildSlaveSupport/build.webkit.org-config/config.json: Building both armv7 and
954 armv7s makes the bots unnecessarily slow. We can catch super rare v7-only regressions
957 * Scripts/webkitpy/common/config/ews.json: Changed EWS to match, as we always want
958 EWS configuration to be verified by buildbot queues.
960 * Scripts/webkitdirs.pm:
961 * Scripts/webkitpy/port/ios.py:
962 Changed default to arm64. I think that the default is probably not used in any
963 practical scenarios, but it's nice to make it more sensible.
965 2016-03-09 Alexey Proskuryakov <ap@apple.com>
967 Add iOS Simulator EWS to bot watcher's dashboard
968 https://bugs.webkit.org/show_bug.cgi?id=155220
970 Reviewed by Lucas Forschler.
972 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
974 2016-03-09 Brent Fulgham <bfulgham@apple.com>
976 Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
977 https://bugs.webkit.org/show_bug.cgi?id=155185
978 <rdar://problem/11101440>
980 Reviewed by Anders Carlsson.
982 * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
983 (TestWebKitAPI::TEST): Allow local file accesss to run test.
984 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
986 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
989 2016-03-09 Tim Horton <timothy_horton@apple.com>
991 Removing and re-adding a script message handler with the same name results in an unusable message handler
992 https://bugs.webkit.org/show_bug.cgi?id=155223
994 Reviewed by Sam Weinig.
996 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
998 Add a test ensuring that it is possible to remove and re-add a script message handler
999 with the same name and still dispatch messages to it.
1001 2016-03-08 Alexey Proskuryakov <ap@apple.com>
1003 Fix iOS Simulator EWS.
1005 Unreviewed build fix.
1007 * Scripts/webkitpy/common/config/ports.py:
1009 2016-03-08 Aakash Jain <aakash_jain@apple.com>
1011 Booting multiple iOS simulator parallely fails sometimes
1012 https://bugs.webkit.org/show_bug.cgi?id=155208
1013 <rdar://problem/25019651>
1015 Reviewed by Darin Adler.
1017 * Scripts/webkitpy/port/ios.py:
1018 (IOSSimulatorPort.setup_test_run): Increase the time delay between subsequent
1021 2016-03-08 Alexey Proskuryakov <ap@apple.com>
1023 Add iOS debug testers to flakiness dashboard
1024 https://bugs.webkit.org/show_bug.cgi?id=155206
1026 Reviewed by Darin Adler.
1028 * TestResultServer/static-dashboards/builders.jsonp:
1030 2016-03-08 Oliver Hunt <oliver@apple.com>
1032 Start moving to separated writable and executable mappings in the JIT
1033 https://bugs.webkit.org/show_bug.cgi?id=155178
1035 Reviewed by Fil Pizlo.
1037 Making run-jsc-benchmarks slightly happier on my machine.
1039 * Scripts/run-jsc-benchmarks:
1041 2016-03-08 Anders Carlsson <andersca@apple.com>
1043 Use NSUInteger instead of NSWindowStyleMask.
1045 * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1047 2016-03-08 Anders Carlsson <andersca@apple.com>
1051 We intentionally don't use AppKitCompatibilityDeclarations.h here, since we want
1052 MiniBrowser to build without WTF.
1054 * MiniBrowser/mac/AppDelegate.m:
1055 (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1056 * MiniBrowser/mac/BrowserWindowController.m:
1057 (-[BrowserWindowController windowDidLoad]):
1058 * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1060 2016-03-08 Alexey Proskuryakov <ap@apple.com>
1062 Add iOS simulator EWS that runs tests
1063 https://bugs.webkit.org/show_bug.cgi?id=155175
1065 Reviewed by Lucas Forschler.
1067 * QueueStatusServer/config/queues.py:
1068 * Scripts/webkitpy/common/config/ews.json:
1069 * Scripts/webkitpy/common/config/ports.py:
1071 2016-03-08 Commit Queue <commit-queue@webkit.org>
1073 Unreviewed, rolling out r197793 and r197799.
1074 https://bugs.webkit.org/show_bug.cgi?id=155195
1076 something weird happened while landing this and everything
1077 broke (Requested by olliej on #webkit).
1079 Reverted changesets:
1081 "Start moving to separated writable and executable mappings in
1083 https://bugs.webkit.org/show_bug.cgi?id=155178
1084 http://trac.webkit.org/changeset/197793
1086 "arm64 build fix after r197793."
1087 http://trac.webkit.org/changeset/197799
1089 2016-03-08 Oliver Hunt <oliver@apple.com>
1091 Start moving to separated writable and executable mappings in the JIT
1092 https://bugs.webkit.org/show_bug.cgi?id=155178
1094 Reviewed by Filip Pizlo.
1096 Making run-jsc-benchmarks slightly happier on my machine.
1098 * Scripts/run-jsc-benchmarks:
1100 2016-03-08 Daniel Bates <dabates@apple.com>
1102 Support iterating over an OptionSet and checking if it is empty
1103 https://bugs.webkit.org/show_bug.cgi?id=154941
1104 <rdar://problem/24964187>
1106 Reviewed by Darin Adler.
1108 Add tests to ensure that we do not regression both iteration of an OptionSet and
1109 determining whether an OptionSet is empty.
1111 * TestWebKitAPI/Test.h:
1112 (TestWebKitAPI::Util::assertStrongEnum): Helper function to assert two strong enum type for equality.
1113 * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
1114 (TestWebKitAPI::TEST):
1116 2016-03-08 Alexey Proskuryakov <ap@apple.com>
1118 Add debug iOS Simulator bots to the dashboard
1119 https://bugs.webkit.org/show_bug.cgi?id=155157
1121 Reviewed by Darin Adler.
1123 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1125 2016-03-08 Alejandro G. Castro <alex@igalia.com>
1127 Unreviewed EFL build fix after r197752.
1129 * Scripts/webkitperl/FeatureList.pm: Avoid MEDIA_STREAM
1130 compilation by default until EFL bumps gstreamer to 1.6.
1132 2016-03-08 Alejandro G. Castro <alex@igalia.com>
1134 [GTK] [EFL] Avoid running mediastream tests by default until we compile by default
1135 https://bugs.webkit.org/show_bug.cgi?id=153540
1137 Reviewed by Philippe Normand.
1139 After bumping gstreamer to 1.6.3 in r196804 we can enable again
1140 compilation of mediastream and running the tests.
1142 * Scripts/run-gtk-tests:
1143 (TestRunner): Enable again the UserMedia API test.
1144 * Scripts/webkitperl/FeatureList.pm: Enable the compilation of the
1145 mediastream by default.
1146 * gtk/jhbuild-webrtc.modules: Removed the specific jhbuild modules
1148 * gtk/jhbuild.modules: Bumped the openwebrtc version to the one we
1149 are currently using.
1151 2016-03-07 Jon Lee <jonlee@apple.com>
1153 Update perf bot configuration for Animometer
1154 https://bugs.webkit.org/show_bug.cgi?id=155134
1156 Reviewed by Ryosuke Niwa.
1158 * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Refactor the patch
1159 to work with the latest version of the harness.
1160 * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Bump up the timeout,
1161 and use the latest version of the harness.
1163 2016-03-07 Joanmarie Diggs <jdiggs@igalia.com>
1165 [GTK][jhbuild] OpenWebRTC build fails with GCC 6.0
1166 https://bugs.webkit.org/show_bug.cgi?id=154839
1168 Reviewed by Michael Catanzaro.
1170 Add '-Wno-error' to jhbuildrc; remove it from the module sets for macos.
1172 * gtk/jhbuild-webrtc.modules:
1173 * gtk/jhbuild.modules:
1176 2016-03-07 Aakash Jain <aakash_jain@apple.com>
1178 webkitpy should verify timestamp from CrashLogs while collecting all crash logs
1179 https://bugs.webkit.org/show_bug.cgi?id=155000
1180 <rdar://problem/24860219>
1182 Reviewed by Alexey Proskuryakov.
1184 * Scripts/webkitpy/common/system/crashlogs.py:
1185 (CrashLogs._find_all_logs_darwin): Make sure that crash log timestamp is within expected
1186 time range, because file modification time is not always accurate.
1187 (CrashLogs.get_timestamp_from_logs): Parse the timestamp from logs.
1188 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1189 (CrashLogsTest.test_get_timestamp_from_logs_darwin): Testcase for above function.
1191 2016-03-06 Alexey Proskuryakov <ap@apple.com>
1193 build-webkit prints an error on iOS simulator bots
1194 https://bugs.webkit.org/show_bug.cgi?id=155078
1196 Reviewed by Dan Bernstein.
1198 This happens when build-layouttestrelay sets $xcodeSDK to undefined, to use host SDK.
1200 * Scripts/webkitdirs.pm: (buildXCodeProject): There is no need to pass -sdk, because
1201 XcodeOptions() already passes SDKROOT as appropriate.
1203 * Scripts/build-layouttestrelay: Added a FIXME. Resetting $xcodeSDK doesn't reset
1204 any other configuration variables that were derived from its initial value, like $portName.
1206 2016-03-05 Tim Horton <timothy_horton@apple.com>
1208 Create a DOMHTMLVideoElement when wrapping <video> elements
1209 https://bugs.webkit.org/show_bug.cgi?id=155084
1210 <rdar://problem/24997193>
1212 Reviewed by Dan Bernstein.
1214 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1215 * TestWebKitAPI/Tests/mac/DOMHTMLVideoElementWrapper.mm: Added.
1216 (-[VideoWrapperFrameLoadDelegate webView:didFinishLoadForFrame:]):
1217 (TestWebKitAPI::TEST):
1218 Add an API test for this behavior.
1220 2016-03-05 Carlos Alberto Lopez Perez <clopez@igalia.com>
1222 [GTK] Fix logging details after r197505 (Run the run-benchmark script on the performance bot.)
1223 https://bugs.webkit.org/show_bug.cgi?id=154595
1227 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1228 (start): Use logging.exception when a test fails in order to get the details about the error.
1230 2016-03-04 Alexey Proskuryakov <ap@apple.com>
1232 Add iOS simulator debug bots
1233 https://bugs.webkit.org/show_bug.cgi?id=155053
1235 Reviewed by Lucas Forschler.
1237 * BuildSlaveSupport/build.webkit.org-config/config.json:
1239 2016-03-04 Brent Fulgham <bfulgham@apple.com>
1241 [WK2] Gather resource load statistics
1242 https://bugs.webkit.org/show_bug.cgi?id=154278
1243 <rdar://problem/24702892>
1245 Reviewed by Andy Estes.
1247 * MiniBrowser/mac/AppDelegate.m:
1248 (defaultConfiguration): Retrieve state of the ResourceLoadStatisticsEnabled setting.
1249 * MiniBrowser/mac/SettingsController.m:
1250 (-[SettingsController _populateMenu]): Move setting from WK1-only to be
1251 universally applicable.
1252 * MiniBrowser/mac/WK2BrowserWindowController.m:
1253 (-[WK2BrowserWindowController didChangeSettings]): Recognize when the
1254 Resource Load Statistics flag has changed.
1256 2016-03-04 Alex Christensen <achristensen@webkit.org>
1258 Remove vcxproj build system
1259 https://bugs.webkit.org/show_bug.cgi?id=154388
1261 Rubber-stamped by Brent Fulgham.
1263 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree: Removed.
1264 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Removed.
1265 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: Removed.
1266 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters: Removed.
1267 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props: Removed.
1268 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: Removed.
1269 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props: Removed.
1270 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Removed.
1271 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Removed.
1272 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props: Removed.
1273 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props: Removed.
1274 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Removed.
1275 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props: Removed.
1276 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Removed.
1277 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Removed.
1278 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Removed.
1279 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props: Removed.
1280 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Removed.
1281 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Removed.
1282 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: Removed.
1283 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props: Removed.
1284 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Removed.
1285 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props: Removed.
1286 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Removed.
1287 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: Removed.
1288 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props: Removed.
1289 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props: Removed.
1290 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Removed.
1291 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props: Removed.
1292 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPostBuild.cmd: Removed.
1293 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd: Removed.
1294 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Removed.
1295 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props: Removed.
1296 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Removed.
1297 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: Removed.
1298 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters: Removed.
1299 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props: Removed.
1300 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props: Removed.
1301 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPostBuild.cmd: Removed.
1302 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd: Removed.
1303 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Removed.
1304 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props: Removed.
1305 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Removed.
1306 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Removed.
1307 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Removed.
1308 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Removed.
1309 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Removed.
1310 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Removed.
1311 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Removed.
1312 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Removed.
1313 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Removed.
1314 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Removed.
1315 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Removed.
1316 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Removed.
1317 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Removed.
1318 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Removed.
1319 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Removed.
1320 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Removed.
1321 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Removed.
1322 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Removed.
1323 * TestWebKitAPI/TestWebKitAPI.vcxproj: Removed.
1324 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Removed.
1325 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Removed.
1326 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Removed.
1327 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Removed.
1328 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Removed.
1329 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props: Removed.
1330 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Removed.
1331 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Removed.
1332 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Removed.
1333 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Removed.
1334 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props: Removed.
1335 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Removed.
1336 * win/AssembleBuildLogs: Removed.
1337 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Removed.
1338 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Removed.
1339 * win/AssembleBuildLogs/AssembleLogs.cmd: Removed.
1340 * win/AssembleBuildLogs/README: Removed.
1342 2016-03-04 Myles C. Maxfield <mmaxfield@apple.com>
1344 Whitespace causes font-variant: all-small-caps to synthesize
1345 https://bugs.webkit.org/show_bug.cgi?id=155004
1346 <rdar://problem/24630796>
1348 Reviewed by Darin Adler.
1350 * DumpRenderTree/mac/DumpRenderTree.mm:
1351 (allowedFontFamilySet):
1352 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1353 (WTR::allowedFontFamilySet):
1354 * WebKitTestRunner/mac/TestControllerMac.mm:
1355 (WTR::allowedFontFamilySet):
1357 2016-03-04 Myles C. Maxfield <mmaxfield@apple.com>
1359 [iOS] Crash during font loading when injected bundle cancels load
1360 https://bugs.webkit.org/show_bug.cgi?id=155001
1362 Reviewed by Tim Horton.
1364 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1365 * TestWebKitAPI/Tests/WebKit2/Ahem.ttf: Added.
1366 * TestWebKitAPI/Tests/WebKit2/webfont.html: Added.
1367 * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: Added.
1368 (-[Myles webView:didFinishNavigation:]):
1370 * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresourcePlugIn.mm: Added.
1371 (-[CancelFontSubresourcePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1372 (-[CancelFontSubresourcePlugIn webProcessPlugInBrowserContextController:frame:willSendRequestForResource:request:redirectResponse:]):
1374 2016-03-04 Konstantin Tokarev <annulen@yandex.ru>
1376 [check-webkit-style] Added checks for redundant virtual specifiers.
1377 https://bugs.webkit.org/show_bug.cgi?id=155017
1379 Reviewed by Darin Adler.
1381 Added 3 new checks related to virtual, override, and final specifiers:
1383 1. When "override" is present, "virtual" is redundant.
1384 2. When "final" is present, "virtual" is redundant.
1385 3. When "final" is present, "override" is redundant.
1387 * Scripts/webkitpy/style/checkers/cpp.py:
1388 (_FunctionState.begin):
1389 (_FunctionState.is_virtual):
1390 (_check_parameter_name_against_text):
1391 (_error_redundant_specifier):
1392 (check_function_definition):
1394 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1395 (FunctionDetectionTest.perform_function_detection):
1396 (FunctionDetectionTest.test_basic_function_detection):
1397 (FunctionDetectionTest.test_function_declaration_detection):
1398 (FunctionDetectionTest.test_pure_function_detection):
1399 (FunctionDetectionTest.test_override_and_final_function_detection):
1400 (FunctionDetectionTest.test_non_functions):
1401 (FunctionDetectionTest.test_parameter_list):
1403 2016-03-03 Darin Adler <darin@apple.com>
1406 Remove "virtual" from all lines that have both "virtual" and "override".
1407 https://bugs.webkit.org/show_bug.cgi?id=155005
1409 Reviewed by Geoffrey Garen.
1411 * Scripts/do-webcore-rename: Added more regular expressions to make sure we always
1412 use either override or final, not both, and to remove virtual from all lines that
1413 have both virtual and final.
1415 2016-03-03 Darin Adler <darin@apple.com>
1417 Remove "virtual" from all lines that have both "virtual" and "override".
1418 https://bugs.webkit.org/show_bug.cgi?id=155005
1420 Reviewed by Geoffrey Garen.
1422 * Scripts/do-webcore-rename: Added a regular expression to this script to do the job.
1424 2016-03-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
1426 [GTK] Unreviewed fix after r197505 (Run the run-benchmark script on the performance bot.)
1427 https://bugs.webkit.org/show_bug.cgi?id=154595
1429 Unreviewed fix after r197505.
1431 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1432 (RunBenchmarkTests.start):
1434 2016-03-03 Daniel Bates <dabates@apple.com>
1436 Add unit tests for WTF::OptionSet
1437 https://bugs.webkit.org/show_bug.cgi?id=154925
1438 <rdar://problem/24964211>
1440 Reviewed by Darin Adler.
1442 Add tests to ensure that we do not regress the behavior of WTF::OptionSet.
1444 * TestWebKitAPI/CMakeLists.txt: Add file TestWebKitAPI/Tests/WTF/OptionSet.cpp.
1445 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1446 * TestWebKitAPI/Tests/WTF/OptionSet.cpp: Added.
1447 (TestWebKitAPI::TEST):
1449 2016-03-03 Commit Queue <commit-queue@webkit.org>
1451 Unreviewed, rolling out r197442.
1452 https://bugs.webkit.org/show_bug.cgi?id=154967
1454 Broke tests, and also uses a wrong approach (Requested by ap
1459 "Disable FTL JIT testing on 32-bit JSC tester bots"
1460 https://bugs.webkit.org/show_bug.cgi?id=154858
1461 http://trac.webkit.org/changeset/197442
1463 2016-03-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
1465 [GTK] Run the run-benchmark script on the performance bot.
1466 https://bugs.webkit.org/show_bug.cgi?id=154595
1468 Reviewed by Carlos Garcia Campos.
1470 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add new RunBenchmarkTests step on the perf bots (only for the GTK+ port at this moment).
1471 (RunBenchmarkTests):
1472 (RunBenchmarkTests.start):
1473 (RunBenchmarkTests.getText):
1474 (RunBenchmarkTests.getText2):
1475 (BuildAndPerfTestFactory.__init__):
1476 (DownloadAndPerfTestFactory.__init__):
1477 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add new test for RunBenchmarkTests and update expected steps of GTK+ perf bot.
1479 (RunBenchmarkTest.assertResults):
1480 (RunBenchmarkTest.test_success):
1481 (RunBenchmarkTest.test_tests_failed):
1482 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Log both the current iteration as also the total iterations for the current benchmark/plan.
1483 (BenchmarkRunner._run_benchmark):
1484 * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Use python logging also for errors.
1485 (GTKMiniBrowserDriver.close_browsers):
1486 * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Implement support for running all available benchmark plans.
1491 2016-03-03 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1493 [EFL] Remove u-szeged.hu SVN mirror in EFL perf bot
1494 https://bugs.webkit.org/show_bug.cgi?id=154960
1496 Reviewed by Csaba Osztrogonác.
1498 * BuildSlaveSupport/build.webkit.org-config/config.json: Remove szeged univ's svn mirror.
1499 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1501 2016-03-03 Frederic Wang <fwang@igalia.com>
1503 [jhbuild] Remove LLVM dependency.
1504 https://bugs.webkit.org/show_bug.cgi?id=153274
1506 Reviewed by Carlos Garcia Campos.
1508 * gtk/jhbuild.modules:
1510 2016-03-02 Alejandro G. Castro <alex@igalia.com>
1512 Unreviewed build fix for media-stream after r197114.
1514 * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1515 (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
1517 2016-03-01 Csaba Osztrogonác <ossy@webkit.org>
1519 Disable FTL JIT testing on 32-bit JSC tester bots
1520 https://bugs.webkit.org/show_bug.cgi?id=154858
1522 Reviewed by Saam Barati.
1524 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1527 2016-03-01 Dean Johnson <dean_johnson@apple.com>
1530 https://bugs.webkit.org/show_bug.cgi?id=154880
1532 Reviewed by Alexey Proskuryakov.
1534 * Scripts/copy-webkitlibraries-to-product-directory:
1536 2016-02-29 Chris Dumez <cdumez@apple.com>
1538 Have parseHTMLInteger() / parseHTMLNonNegativeInteger() use WTF::Optional
1539 https://bugs.webkit.org/show_bug.cgi?id=154845
1541 Reviewed by Ryosuke Niwa.
1543 Update API tests accordingly.
1545 * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
1546 (TestWebKitAPI::testParseHTMLInteger):
1547 (TestWebKitAPI::parseHTMLIntegerFails):
1548 (TestWebKitAPI::testParseHTMLNonNegativeInteger):
1549 (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
1550 (TestWebKitAPI::TEST): Deleted.
1552 2016-02-29 Simon Fraser <simon.fraser@apple.com>
1554 Remove the experimental feature of antialiased font dilation
1555 https://bugs.webkit.org/show_bug.cgi?id=154843
1557 Reviewed by Zalan Bujtas.
1559 Remove the "antialiased font dilation" code path, and related prefs.
1561 * DumpRenderTree/mac/DumpRenderTree.mm:
1562 (resetWebPreferencesToConsistentValues): Deleted.
1563 * WebKitTestRunner/TestController.cpp:
1564 (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1566 2016-02-29 Brady Eidson <beidson@apple.com>
1568 Fix timing flakiness in test I added in http://trac.webkit.org/changeset/197372
1572 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html:
1573 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
1574 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1575 (TEST): Sometimes a third message from the first html file was leaking through. The message is expected
1576 so we should always wait for it and make sure we got it.
1578 2016-02-29 Brady Eidson <beidson@apple.com>
1580 Modern IDB: WebKit 2 IPC layer easily confused about multiple web processes being connected.
1581 https://bugs.webkit.org/show_bug.cgi?id=154837
1583 Reviewed by Alex Christensen.
1585 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1586 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Added.
1587 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Added.
1588 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Added.
1590 2016-02-29 Joanmarie Diggs <jdiggs@igalia.com>
1592 [GTK][jhbuild] GLib build fails with GCC 6.0
1593 https://bugs.webkit.org/show_bug.cgi?id=154825
1595 Use the upstream work-around. https://bugzilla.gnome.org/show_bug.cgi?id=761550
1597 Reviewed by Csaba Osztrogonác.
1599 * gtk/jhbuild.modules: Apply upstream path.
1600 * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Added.
1602 2016-02-29 Filip Pizlo <fpizlo@apple.com>
1604 We've been running Octane/regexp all wrong in run-jsc-benchmarks
1605 https://bugs.webkit.org/show_bug.cgi?id=154827
1607 Reviewed by Andreas Kling.
1609 Octane v.2 and JetStream v.1.1 run this benchmark with warmup. This script was running
1610 it without warmup. This patches fixes this by making this script run it with warmup.
1612 This fix shows that my last patch, which added FTL support for regexp, was actually a 3%
1613 speed-up on Octane/regexp, not a slow-down as the ChangeLog claimed.
1615 It discovered this bug because for each Octane test that I want to debug, I usually make
1616 a standalone .js file that contains the whole test along with a miniharness - usually
1617 a plain loop - that runs it almost like it would for real but with whatever hacks I'm
1618 using for debugging. When I wrote such a thing for regexp, I used a ~20 iteration warmup
1619 to match the one second of warmup that this benchmark gets in Octane. To my surprise,
1620 this quite faithful regexp runner did not see the regression that run-jsc-benchmarks
1621 saw. That's when I found out that run-jsc-benchmarks was running it wrong.
1623 The reason for the no-warmup slow-down is that the FTL is actually fairly expensive to
1624 run on some of these very large functions in the regexp benchmark. I don't think we can
1625 do anything about that, and I'd argue that the speed-up we see after the compilation is
1626 done suggests that it was worth it.
1628 * Scripts/run-jsc-benchmarks:
1630 2016-02-29 Gavin Barraclough <barraclough@apple.com>
1632 RefCounter<T>::Event -> RefCounterEvent
1633 https://bugs.webkit.org/show_bug.cgi?id=154767
1635 Reviewed by Darin Adler.
1637 RefCounter<T>::Event is kinda verbose to use, and there is no need for this
1638 to be specific to a particular typeof RefCounter. Move the enum class up to
1639 the top level & rename to RefCounterEvent.
1641 * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1642 (TestWebKitAPI::TEST):
1644 2016-02-29 Csaba Osztrogonác <ossy@webkit.org>
1646 Remove more LLVM related cruft
1647 https://bugs.webkit.org/show_bug.cgi?id=154821
1649 Reviewed by Darin Adler.
1651 * Scripts/build-jsc:
1652 * Scripts/build-webkit:
1653 * Scripts/copy-webkitlibraries-to-product-directory:
1654 * Scripts/export-llvm-build: Removed.
1655 * Scripts/run-jsc-stress-tests:
1657 2016-02-28 Sam Weinig <sam@webkit.org>
1659 Reimplement WKPageGroup in terms of WKUserContentController
1660 https://bugs.webkit.org/show_bug.cgi?id=154804
1662 Reviewed by Dan Bernstein.
1664 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1665 * TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Added.
1667 2016-02-28 Sam Weinig <sam@webkit.org>
1669 Bind _WKUserStyleSheets to WKUserContentWorlds to allow for grouping of user content by associating to a world
1670 https://bugs.webkit.org/show_bug.cgi?id=154798
1672 Reviewed by Dan Bernstein.
1674 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1675 Add tests for removing _WKUserStyleSheets and WKUserScripts
1677 2016-02-27 Alexey Proskuryakov <ap@apple.com>
1679 Silence leaks under TextCodecICU::registerCodecs
1680 https://bugs.webkit.org/show_bug.cgi?id=154737
1682 Reviewed by Darin Adler.
1684 * Scripts/webkitpy/port/leakdetector.py:
1685 (LeakDetector._callstacks_to_exclude_from_leaks):
1687 2016-02-26 Michael Catanzaro <mcatanzaro@igalia.com>
1689 [GTK] Fix incorrect cast
1693 * MiniBrowser/gtk/main.c:
1694 (createBrowserWindow):
1696 2016-02-26 Chris Dumez <cdumez@apple.com>
1698 Fix the behavior of reflecting IDL attributes of type unsigned long
1699 https://bugs.webkit.org/show_bug.cgi?id=154771
1701 Reviewed by Ryosuke Niwa.
1703 Update API tests to cover the fixes to the parseHTMLNonNegativeInteger()
1705 - "-0" is parsed as 0.
1706 - Range boundaries are now [0; 2147483647].
1708 * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
1709 (TestWebKitAPI::TEST):
1711 2016-02-26 Brady Eidson <beidson@apple.com>
1713 Modern IDB: New database versions are never committed to SQLite.
1714 <rdar://problem/24860952> and https://bugs.webkit.org/show_bug.cgi?id=154741
1716 Modern IDB: If a database handle is not open, files are not actually deleted from disk
1717 https://bugs.webkit.org/show_bug.cgi?id=154756
1719 Reviewed by Alex Christensen.
1721 This also happens to test the previously untested fix for http://trac.webkit.org/changeset/197190
1723 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1724 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Added.
1725 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Added.
1726 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Added.
1727 (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]):
1728 (-[IndexedDBMessageHandler userContentController:didReceiveScriptMessage:]):
1731 2016-02-26 Commit Queue <commit-queue@webkit.org>
1733 Unreviewed, rolling out r197216.
1734 https://bugs.webkit.org/show_bug.cgi?id=154766
1736 Test simply needs updated result (Requested by litherum on
1741 "Unreviewed, rolling out r197158."
1742 https://bugs.webkit.org/show_bug.cgi?id=154758
1743 http://trac.webkit.org/changeset/197216
1745 2016-02-26 Alexey Proskuryakov <ap@apple.com>
1747 [iOS Simulator] Reftests don't work
1748 https://bugs.webkit.org/show_bug.cgi?id=154764
1750 Reviewed by Daniel Bates.
1752 * Scripts/webkitpy/port/image_diff.py: (IOSSimulatorImageDiffer._start):
1753 Use simctl instead of sim.
1755 2016-02-26 Chris Dumez <cdumez@apple.com>
1757 Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger
1758 https://bugs.webkit.org/show_bug.cgi?id=154714
1760 Reviewed by Darin Adler.
1762 Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger as per:
1763 - https://html.spec.whatwg.org/multipage/infrastructure.html#signed-integers
1764 - https://html.spec.whatwg.org/multipage/infrastructure.html#non-negative-integers
1766 * TestWebKitAPI/PlatformEfl.cmake:
1767 * TestWebKitAPI/PlatformGTK.cmake:
1768 * TestWebKitAPI/PlatformWin.cmake:
1769 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1770 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1771 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1772 * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp: Added.
1773 (TestWebKitAPI::testParseHTMLInteger):
1774 (TestWebKitAPI::parseHTMLIntegerFails):
1775 (TestWebKitAPI::TEST):
1776 (TestWebKitAPI::testParseHTMLNonNegativeInteger):
1777 (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
1779 2016-02-26 Commit Queue <commit-queue@webkit.org>
1781 Unreviewed, rolling out r197158.
1782 https://bugs.webkit.org/show_bug.cgi?id=154758
1784 This change did not fix the failing test (Requested by
1785 ryanhaddad on #webkit).
1789 "REGRESSION(r195795): [WK2] fast/text/crash-complex-text-
1790 surrogate.html is flakey"
1791 https://bugs.webkit.org/show_bug.cgi?id=154709
1792 http://trac.webkit.org/changeset/197158
1794 2016-02-26 Anders Carlsson <andersca@apple.com>
1796 WKWebsiteDataStore/WKWebsiteDataRecord needs to provide size information about each type of data
1797 https://bugs.webkit.org/show_bug.cgi?id=154750
1798 rdar://problem/23861395
1800 Reviewed by Tim Horton.
1802 * MiniBrowser/mac/WK2BrowserWindowController.m:
1803 (-[WK2BrowserWindowController fetchWebsiteData:]):
1804 Use the new WKWebsiteDataStore SPI to compute data sizes.
1806 2016-02-25 Gavin Barraclough <barraclough@apple.com>
1808 RefCounter value changed callback should be called on all changes (not just zero edge).
1809 https://bugs.webkit.org/show_bug.cgi?id=154699
1811 Reviewed by Geoff Garen.
1813 RefCounter currently only triggers a callback when the count goes from zero
1814 to non-zero and vice-versa. Change that, to be useful to more clients.
1816 * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1817 (TestWebKitAPI::TEST):
1818 - Updated for change in RefCounter callback siganture & behaviour.
1820 2016-02-25 Sam Weinig <sam@webkit.org>
1822 Allow WKUserScripts to be run in isolated worlds
1823 https://bugs.webkit.org/show_bug.cgi?id=154701
1825 Reviewed by Anders Carlsson.
1827 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1828 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorld.mm: Added.
1829 (-[SimpleDelegate webView:didFinishNavigation:]):
1830 (-[UserContentWorldRemoteObject didObserveNormalWorld]):
1831 (-[UserContentWorldRemoteObject didObserveWorldWithName:]):
1832 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldPlugIn.mm: Added.
1833 (-[_WKUserContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1834 (-[_WKUserContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
1835 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldProtocol.h: Added.
1837 2016-02-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
1839 W3C test importer should have an option to clean the destination directory
1840 https://bugs.webkit.org/show_bug.cgi?id=152685
1842 Reviewed by Darin Adler.
1844 Adding --clean-dest-dir option to W3C test importer.
1845 When this option is set, all files in the destination directory will be deleted
1846 except for WebKit specific files (test expectations, .gitignore...) before new tests import.
1847 Dangling test expectations are removed after tests import.'
1849 Adding unit test and minor refactoring for the other tests.
1851 * Scripts/webkitpy/w3c/test_importer.py:
1852 (parse_args): Add '--clean-dest-dir' option.
1853 (TestImporter.do_import):
1854 (TestImporter._is_baseline): helper routine to capture -expected.txt files.
1856 (TestImporter._should_not_keep_when_importing): helper routine to filter files that should not be cleaned before importing.
1857 (TestImporter.clean_destination_directory):
1858 (TestImporter.remove_dangling_expectations):
1859 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1860 (TestImporterTest._parse_options):
1861 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
1862 (TestImporterTest.test_import_dir_with_no_tests):
1863 (TestImporterTest.test_import_dir_with_empty_init_py):
1864 (test_clean_directory_option):
1866 2016-02-25 Myles C. Maxfield <mmaxfield@apple.com>
1868 REGRESSION(r195795): [WK2] fast/text/crash-complex-text-surrogate.html is flakey
1869 https://bugs.webkit.org/show_bug.cgi?id=154709
1870 <rdar://problem/24483596>
1872 Reviewed by Dan Bernstein.
1874 Force auto-activation rules to a consistent state.
1876 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1877 (WTR::InjectedBundle::platformInitialize):
1879 2016-02-25 Jiewen Tan <jiewen_tan@apple.com>
1881 Unreivewed build fix for r197150.
1883 * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
1885 2016-02-25 Jiewen Tan <jiewen_tan@apple.com>
1887 Restrict information passed with navigation action which is triggered by untrusted event
1888 https://bugs.webkit.org/show_bug.cgi?id=154571
1889 <rdar://problem/15967937>
1891 Reviewed by Andy Estes.
1893 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1894 * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm: Added.
1895 (-[WKNavigationActionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1896 (TestWebKitAPI::TEST):
1897 (-[NavigationActionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1898 * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.html: Added.
1900 2016-02-25 Gavin Barraclough <barraclough@apple.com>
1902 Should template RefCounter instead of RefCounter::Token
1903 https://bugs.webkit.org/show_bug.cgi?id=154691
1905 Reviewed by Anders Carlsson.
1907 Mechanical update per RefCounter interface change.
1909 * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1910 (TestWebKitAPI::TEST):
1912 2016-02-25 Skachkov Aleksandr <gskachkov@gmail.com>
1914 Unreviewed: Add Aleksandr Skachkov as a commiter
1916 * Scripts/webkitpy/common/config/contributors.json:
1918 2016-02-25 Sam Weinig <sam@webkit.org>
1920 HashMap::ensure() should return an AddResult like all the other add-like functions
1921 https://bugs.webkit.org/show_bug.cgi?id=154680
1923 Reviewed by Anders Carlsson.
1925 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1926 (TestWebKitAPI::TEST):
1927 Update tests to use/test the new AddResult result.
1929 2016-02-25 Alexey Proskuryakov <ap@apple.com>
1931 Enable MallocScribble when detecting leaks
1932 https://bugs.webkit.org/show_bug.cgi?id=154679
1934 Reviewed by Geoffrey Garen.
1936 * Scripts/webkitpy/port/ios.py:
1937 (IOSSimulatorPort.setup_environ_for_server):
1938 * Scripts/webkitpy/port/mac.py:
1939 (MacPort.setup_environ_for_server):
1940 * Scripts/webkitpy/port/mac_unittest.py:
1941 (MacTest.test_setup_environ_for_server):
1943 2016-02-25 Eric Carlson <eric.carlson@apple.com>
1945 Unreviewed, fix iOS builds after r197114.
1947 * WebKitTestRunner/TestController.cpp:
1948 (WTR::createCanonicalUUIDString):
1949 (WTR::TestController::saltForOrigin):
1951 2016-02-25 Eric Carlson <eric.carlson@apple.com>
1953 [MediaStream] MediaDeviceInfo deviceId and groupId must be unique to the page's origin
1954 https://bugs.webkit.org/show_bug.cgi?id=153163
1955 <rdar://problem/24334526>
1957 Reviewed by Tim Horton.
1959 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1960 (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Take top level document origin.
1961 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1963 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1964 (WTR::TestRunner::setUserMediaPermissionForOrigin): Ditto.
1965 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1967 * WebKitTestRunner/TestController.cpp:
1968 (WTR::decidePolicyForUserMediaPermissionRequest): Pass through top level document origin.
1969 (WTR::checkUserMediaPermissionForOrigin): Ditto.
1970 (WTR::TestController::resetStateToConsistentValues): m_userMediaOriginPermissions -> m_cahcedUserMediaPermissions.
1971 (WTR::originUserVisibleName): Return a String.
1972 (WTR::userMediaOriginHash): Create a hash of the origin plus top level document origin.
1973 (WTR::TestController::saltForOrigin): Return salt for an origin.
1974 (WTR::TestController::setUserMediaPermissionForOrigin): Return permission for an origin.
1975 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1976 (WTR::TestController::handleUserMediaPermissionRequest):
1977 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1978 (WTR::OriginSettings::OriginSettings): New, class to cache settings for an origin.
1979 (WTR::OriginSettings::persistentPermission): Persistent permissions for origin.
1980 (WTR::OriginSettings::setPersistentPermission): Set permissions for origin.
1981 (WTR::OriginSettings::persistentSalt): Return the persistent salt for the origin, if any.
1982 (WTR::OriginSettings::setPersistentSalt): Set the persistent salt for the origin
1983 (WTR::OriginSettings::ephemeralSalts): Return hashmap used to store per-frame salts.
1984 * WebKitTestRunner/TestController.h:
1986 * WebKitTestRunner/TestInvocation.cpp:
1987 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1989 2016-02-24 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
1991 [web-animations] Add AnimationTimeline, DocumentTimeline and add extensions to Document interface
1992 https://bugs.webkit.org/show_bug.cgi?id=151688
1994 Reviewed by Dean Jackson.
1996 Enables the WEB_ANIMATIONS compiler switch by default.
1998 * Scripts/webkitperl/FeatureList.pm:
2000 2016-02-24 Youenn Fablet <youenn.fablet@crf.canon.fr>
2002 W3C importer should generate all web-platform-tests submodules descriptions
2003 https://bugs.webkit.org/show_bug.cgi?id=154587
2005 Reviewed by Darin Adler.
2007 Updated submodules description format (removing submodule name as it is the last string of the path really).
2008 Added git subroutines.
2010 * Scripts/webkitpy/common/checkout/scm/git.py:
2013 (Git.init_submodules):
2014 (Git.submodules_status):
2015 (Git.deinit_submodules):
2016 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2017 (WebPlatformTestServer._install_modules): Updated to submodule name removal.
2018 * Scripts/webkitpy/w3c/test_downloader.py:
2019 (TestDownloader._git_submodules_description): Updated to cope with recursive submodules (use of submodule init/deinit).
2020 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2021 (TestImporterTest.test_submodules_generation): Reactivated partially this test.
2023 2016-02-23 Dan Bernstein <mitz@apple.com>
2025 [Xcode] Linker errors display mangled names, but no longer should
2026 https://bugs.webkit.org/show_bug.cgi?id=154632
2028 Reviewed by Sam Weinig.
2030 * ContentExtensionTester/Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
2031 * DumpRenderTree/mac/Configurations/Base.xcconfig: Ditto.
2032 * LayoutTestRelay/Configurations/Base.xcconfig: Ditto.
2033 * MiniBrowser/Configurations/Base.xcconfig: Ditto.
2034 * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2035 * WebEditingTester/Configurations/Base.xcconfig: Ditto.
2036 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2038 2016-02-23 Anders Carlsson <andersca@apple.com>
2040 WKWebView should implement NSCoding
2041 https://bugs.webkit.org/show_bug.cgi?id=137160
2043 Reviewed by Dan Bernstein.
2047 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2050 2016-02-23 Anders Carlsson <andersca@apple.com>
2052 WKProcessPool should conform to NSCoding
2053 https://bugs.webkit.org/show_bug.cgi?id=154608
2055 Reviewed by Sam Weinig.
2059 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2062 2016-02-23 Anders Carlsson <andersca@apple.com>
2064 WKWebsiteDataStore should conform to NSCoding
2065 https://bugs.webkit.org/show_bug.cgi?id=154605
2067 Reviewed by Dan Bernstein.
2069 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2072 2016-02-23 Anders Carlsson <andersca@apple.com>
2074 WKWebViewConfiguration should conform to NSCoding
2075 https://bugs.webkit.org/show_bug.cgi?id=154602
2077 Reviewed by Beth Dakin.
2079 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2082 2016-02-23 Anders Carlsson <andersca@apple.com>
2084 WKPreferences should conform to NSCoding
2085 https://bugs.webkit.org/show_bug.cgi?id=154597
2087 Reviewed by Sam Weinig.
2089 Test encoding and decoding WKPreferences.
2091 * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2095 2016-02-23 Anders Carlsson <andersca@apple.com>
2099 * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
2100 (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]):
2102 2016-02-23 Carlos Alberto Lopez Perez <clopez@igalia.com>
2104 [GTK] Allow to run the WebKitGTK+ MiniBrowser with the run-benchmark script.
2105 https://bugs.webkit.org/show_bug.cgi?id=153993
2107 Reviewed by Carlos Garcia Campos.
2109 * MiniBrowser/gtk/main.c:
2110 (createBrowserWindow): Support --geometry argument for MiniBrowser.
2111 We use this on the gtk_minibrowser_driver script to start the MiniBrowser maximized.
2112 * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Fix loading of subclasses:
2113 The base class has to be loaded first, otherwise any subclase referencing it will give import error.
2114 In OSX the ordering of os.listdir() causes the base class (browser_driver.py) to be first on the list, but not on Linux.
2115 By specifiying the name of the base class file, we ensure it is always loaded first on any system despite the ordering of listdir.
2116 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2117 (BrowserDriverFactory.create):
2118 * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py: Added.
2120 (GTKBrowserDriver.prepare_env):
2121 (GTKBrowserDriver.restore_env):
2122 (GTKBrowserDriver.close_browsers):
2123 (GTKBrowserDriver._launch_process):
2124 (GTKBrowserDriver._terminate_processes):
2125 (GTKBrowserDriver._screen_size):
2126 * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Added.
2127 (GTKMiniBrowserDriver):
2128 (GTKMiniBrowserDriver.prepare_env):
2129 (GTKMiniBrowserDriver.launch_url):
2130 (GTKMiniBrowserDriver.close_browsers):
2131 * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Fix loading of subclasses. See description above.
2132 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2133 (SimpleHTTPServerDriver):
2134 (SimpleHTTPServerDriver.kill_server): Check if the server is still running before trying to terminate it.
2135 Usually the server ends gracefully (no need to terminate it), so this was causing ugly errors on the log.
2136 * Scripts/webkitpy/benchmark_runner/utils.py: Fix loading of subclasses. See description above.
2139 2016-02-23 Alejandro G. Castro <alex@igalia.com>
2141 [GTK] Missing configuration patch for openh264 compilation
2142 https://bugs.webkit.org/show_bug.cgi?id=154455
2144 This patch is required for the openh264 compilation with the
2145 jhbuild-webrtc.modules. The code was implemented by Alessandro
2148 Reviewed by Philippe Normand.
2150 * gtk/patches/openh264-configure.patch: Added.
2152 2016-02-20 Olivier Blin <olivier.blin@softathome.com>
2154 [cmake] Use ICU include dirs in WebKit2 and WebKitTestRunner
2155 https://bugs.webkit.org/show_bug.cgi?id=154479
2157 Reviewed by Michael Catanzaro.
2159 * WebKitTestRunner/CMakeLists.txt:
2161 2016-02-19 Konstantin Tokarev <annulen@yandex.ru>
2163 [GTK] Fixed link error when G_DEFINE_AUTOPTR_CLEANUP_FUNC is not defined.
2164 https://bugs.webkit.org/show_bug.cgi?id=154467
2166 Reviewed by Michael Catanzaro.
2168 * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp:
2172 2016-02-19 Brady Eidson <beidson@apple.com>
2174 Add "databaseProcessDidCrash" to the WKContextClient; Adopt it in WKTR.
2175 https://bugs.webkit.org/show_bug.cgi?id=154428
2177 Reviewed by Jer Noble.
2179 * WebKitTestRunner/TestController.cpp:
2180 (WTR::TestController::generatePageConfiguration):
2181 (WTR::TestController::databaseProcessName):
2182 (WTR::TestController::databaseProcessDidCrash):
2183 * WebKitTestRunner/TestController.h:
2185 2016-02-18 Philippe Normand <pnormand@igalia.com>
2187 [GStreamer] Bump internal jhbuild versions to 1.6.3
2188 https://bugs.webkit.org/show_bug.cgi?id=149594
2190 Reviewed by Michael Catanzaro.
2192 * gtk/jhbuild.modules: Bump to GStreamer 1.6.3.
2193 * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
2194 * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
2195 * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
2197 2016-02-18 Brent Fulgham <bfulgham@apple.com>
2199 Extend HashCountedSet with a method to efficiently set the count of an entry
2200 https://bugs.webkit.org/show_bug.cgi?id=154352
2202 Reviewed by Geoffrey Garen.
2204 * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
2205 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2206 * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
2208 2016-02-18 Commit Queue <commit-queue@webkit.org>
2210 Unreviewed, rolling out r196791.
2211 https://bugs.webkit.org/show_bug.cgi?id=154438
2213 broke windows build (Requested by alexchristensen on #webkit).
2217 "Extend HashCountedSet with a method to efficiently set the
2219 https://bugs.webkit.org/show_bug.cgi?id=154352
2220 http://trac.webkit.org/changeset/196791
2222 2016-02-18 Brent Fulgham <bfulgham@apple.com>
2224 Extend HashCountedSet with a method to efficiently set the count of an entry
2225 https://bugs.webkit.org/show_bug.cgi?id=154352
2227 Reviewed by Geoffrey Garen.
2229 * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
2230 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2231 * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
2233 2016-02-18 Anders Carlsson <andersca@apple.com>
2235 Get rid of the --target-web-process and --use-web-process-xpc-service options.
2237 Rubber-stamped by Dan Bernstein.
2239 We now always use XPC, and --target-web-process is no longer supported.
2241 * Scripts/webkitdirs.pm:
2242 (execMacWebKitAppForDebugging):
2243 (shouldTargetWebProcess): Deleted.
2244 (determineShouldTargetWebProcess): Deleted.
2245 (shouldUseXPCServiceForWebProcess): Deleted.
2246 (determineShouldUseXPCServiceForWebProcess): Deleted.
2247 (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Deleted.
2248 (argumentsForRunAndDebugMacWebKitApp): Deleted.
2250 2016-02-18 Ryan Haddad <ryanhaddad@apple.com>
2252 Skip API test WTF_ParkingLot.UnparkOneFiftyThenFiftyAll on ios-simulator
2253 https://bugs.webkit.org/show_bug.cgi?id=153997
2255 Reviewed by Filip Pizlo.
2257 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2259 2016-02-18 Jer Noble <jer.noble@apple.com>
2261 run-webkit-httpd should use webkitpy to run httpd.
2262 https://bugs.webkit.org/show_bug.cgi?id=154271
2264 Reviewed by Alexey Proskuryakov.
2266 Update run-webkit-httpd to use webkitpy.port to launch httpd. Pass on http_port and http_all_interface
2267 options to match the current run-webkit-httpd (optional) behavior.
2269 * Scripts/run-webkit-httpd:
2272 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2273 (LayoutTestApacheHttpd.__init__):
2274 * Scripts/webkitpy/layout_tests/servers/http_server.py:
2275 (Lighttpd._prepare_config):
2276 * Scripts/webkitpy/port/base.py:
2277 (Port.to.start_http_server):
2279 2016-02-18 Filip Pizlo <fpizlo@apple.com>
2281 Remove remaining references to LLVM, and make sure comments refer to the backend as "B3" not "LLVM"
2282 https://bugs.webkit.org/show_bug.cgi?id=154383
2284 Reviewed by Saam Barati.
2286 * Scripts/run-jsc-stress-tests:
2288 2016-02-17 Filip Pizlo <fpizlo@apple.com>
2290 Remove LLVM dependencies from WebKit
2291 https://bugs.webkit.org/show_bug.cgi?id=154323
2293 Reviewed by Antti Koivisto and Benjamin Poulain.
2295 * Scripts/copy-webkitlibraries-to-product-directory:
2296 (isContentOfFileEqualToString):
2297 (fileContains): Deleted.
2298 (buildLLVM): Deleted.
2299 (symlinkLLVMLibrariesIfNeeded): Deleted.
2301 2016-02-16 Sam Weinig <sam@webkit.org>
2303 Add an ensure function on HashMap that takes a key and a function to make the lazy value initialization idiom easier
2304 https://bugs.webkit.org/show_bug.cgi?id=134857
2306 Reviewed by Geoffrey Garen.
2308 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2309 Add tests for HashMap::ensure.
2311 2016-02-17 Nan Wang <n_wang@apple.com>
2313 AX: Implement sentence related text marker functions using TextIterator
2314 https://bugs.webkit.org/show_bug.cgi?id=154312
2316 Reviewed by Chris Fleizach.
2318 * DumpRenderTree/AccessibilityUIElement.cpp:
2319 (nextParagraphEndTextMarkerForTextMarkerCallback):
2320 (sentenceTextMarkerRangeForTextMarkerCallback):
2321 (previousSentenceStartTextMarkerForTextMarkerCallback):
2322 (nextSentenceEndTextMarkerForTextMarkerCallback):
2323 (setSelectedVisibleTextRangeCallback):
2324 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2325 (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2326 (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2327 (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2328 (AccessibilityUIElement::getJSClass):
2329 * DumpRenderTree/AccessibilityUIElement.h:
2330 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2331 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2332 (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2333 (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2334 (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2335 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2336 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2337 (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2338 (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2339 (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2340 (AccessibilityUIElement::supportedActions):
2341 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2342 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2343 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2344 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2345 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2346 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2347 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2348 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2349 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2350 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2351 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2352 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2353 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2354 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2355 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2356 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2357 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2358 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2359 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2360 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2361 (WTR::_convertMathMultiscriptPairsToString):
2363 2016-02-15 Brent Fulgham <bfulgham@apple.com>
2365 [Mac] Gather some rudimentary statistics during resource load
2366 https://bugs.webkit.org/show_bug.cgi?id=153575
2367 <rdar://problem/24075254>
2369 Reviewed by Brady Eidson.
2371 * MiniBrowser/mac/SettingsController.h:
2372 * MiniBrowser/mac/SettingsController.m:
2373 (-[SettingsController _populateMenu]): Add menu item for new debug flag.
2374 (-[SettingsController toggleResourceLoadStatisticsEnabled:]): Added.
2375 (-[SettingsController resourceLoadStatisticsEnabled]): Added.
2376 * MiniBrowser/mac/WK1BrowserWindowController.m:
2377 (-[WK1BrowserWindowController didChangeSettings]): React to changes in
2378 users's desire to track resource load statistics.
2380 2016-02-15 Csaba Osztrogonác <ossy@webkit.org>
2382 [EFL] Update Tools/efl/install-dependencies
2383 https://bugs.webkit.org/show_bug.cgi?id=154239
2385 Reviewed by Michael Catanzaro.
2387 * efl/install-dependencies:
2389 2016-02-15 Alex Christensen <achristensen@webkit.org>
2391 Fix internal Windows build of projects built after WebKit
2392 https://bugs.webkit.org/show_bug.cgi?id=154249
2393 rdar://problem/24644805
2395 Reviewed by Chris Dumez.
2397 * DumpRenderTree/PlatformWin.cmake:
2398 * MiniBrowser/win/CMakeLists.txt:
2399 Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree
2400 more like projects built internally after WebKit. They should only need to use what
2401 is in ForwardingHeaders/WebKit.
2403 2016-02-12 Nan Wang <n_wang@apple.com>
2405 AX: Implement paragraph related text marker functions using TextIterator
2406 https://bugs.webkit.org/show_bug.cgi?id=154098
2407 <rdar://problem/24269675>
2409 Reviewed by Chris Fleizach.
2411 * DumpRenderTree/AccessibilityUIElement.cpp:
2412 (nextWordEndTextMarkerForTextMarkerCallback):
2413 (paragraphTextMarkerRangeForTextMarkerCallback):
2414 (previousParagraphStartTextMarkerForTextMarkerCallback):
2415 (nextParagraphEndTextMarkerForTextMarkerCallback):
2416 (setSelectedVisibleTextRangeCallback):
2417 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2418 (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2419 (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2420 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2421 (AccessibilityUIElement::getJSClass):
2422 * DumpRenderTree/AccessibilityUIElement.h:
2423 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2424 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2425 (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2426 (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2427 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2428 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2429 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2430 (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2431 (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2432 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2433 (AccessibilityUIElement::supportedActions):
2434 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2435 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2436 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2437 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2438 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2439 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2440 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2441 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2442 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2443 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2444 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2445 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2446 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2447 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2448 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2449 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2450 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2451 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2452 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2453 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2454 (WTR::_convertMathMultiscriptPairsToString):
2456 2016-02-12 Jason Marcell <jmarcell@apple.com>
2458 Open source bot watcher's dashboard fails assertion in BuildbotQueue.prototype.compareIterationsByRevisions
2459 https://bugs.webkit.org/show_bug.cgi?id=154180
2461 Reviewed by Alexey Proskuryakov.
2463 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Remove reference to Internal
2466 2016-02-12 Jer Noble <jer.noble@apple.com>
2468 [Mac] Adopt MediaResourceLoader (instead of CachedResourceLoader) in WebCoreNSURLSession.
2469 https://bugs.webkit.org/show_bug.cgi?id=154136
2471 Reviewed by Alex Christensen.
2473 Use a MediaResourceLoader instead of a CachedResourceLoader for WebCoreNSURLSession.
2475 Drive-by fix: generate USE and ENABLE macros for TestWebKitAPI by adding FEATURE_DEFINES
2476 to GCC_PREPROCESSOR_DEFINES.
2478 * TestWebKitAPI/Configurations/Base.xcconfig:
2479 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2480 (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2481 (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
2482 (TestWebKitAPI::TEST_F):
2484 2016-02-11 Dana Burkart <dburkart@apple.com>
2486 Large logs can bring down the webkit master
2487 https://bugs.webkit.org/show_bug.cgi?id=122112
2489 Reviewed by Lucas Forschler.
2491 Implement the suggested fix of throwing away stdout / stderr.
2493 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2494 (RunWebKit1LeakTests):
2496 2016-02-10 Jason Marcell <jmarcell@apple.com>
2498 Remove calls to parseInt in order to work with non-integer revisions
2499 https://bugs.webkit.org/show_bug.cgi?id=153820
2501 Reviewed by Daniel Bates.
2503 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2504 (BuildbotIteration.prototype.sourceStampChanges): Remove calls to parseInt in order to work with non-integer
2506 (BuildbotIteration.prototype._parseData): Ditto.
2507 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2508 (BuildbotQueue.prototype.update): Ditto.
2509 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:
2510 (MockBuildbotQueueView.prototype._latestProductiveIteration): Change integers to strings in test code.
2511 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
2512 (MockTrac.prototype.get oldestRecordedRevisionNumber): Ditto.
2513 (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
2514 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Ditto.
2516 2016-02-10 Jason Marcell <jmarcell@apple.com>
2518 Teach dashboard code to compare non-integer revisions
2519 https://bugs.webkit.org/show_bug.cgi?id=152345
2521 Reviewed by Daniel Bates.
2523 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2524 (BuildbotQueue.prototype.compareIterationsByRevisions): Compare non-integer revisions.
2525 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2526 (BuildbotQueueView.prototype._appendPendingRevisionCount): Use Trac.indexOfRevision in order to compare non-integer
2527 revisions. Also uses new Trac.commitsOnBranchLaterThanRevision method.
2528 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Ditto.
2529 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Use Trac.indexOfRevision in order to compare non-integer
2530 revisions. Also uses new Trac.nextRevision method to calculate a revision range.
2531 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
2532 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2533 (Trac.prototype._commitsOnBranch): Renamed this to indicate that it should be a private method used by the latter two new
2535 (Trac.prototype.commitsOnBranchLaterThanRevision): Finds revisions on a branch later than the specified revision.
2536 (Trac.prototype.commitsOnBranchInRevisionRange): Finds revisions on a branch within a specified range.
2537 (Trac.prototype.nextRevision): Finds the next revision after a given revision on a specific branch.
2538 (Trac.prototype.indexOfRevision): Finds the index of a given revision within the recordedCommits array.
2539 (Trac.prototype.commitsOnBranch): Deleted. Renamed to _commitsOnBranch.
2540 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests.
2542 2016-02-09 Nan Wang <n_wang@apple.com>
2544 AX: Implement word related text marker functions using TextIterator
2545 https://bugs.webkit.org/show_bug.cgi?id=153939
2546 <rdar://problem/24269605>
2548 Reviewed by Chris Fleizach.
2550 * DumpRenderTree/AccessibilityUIElement.cpp:
2551 (endTextMarkerCallback):
2552 (leftWordTextMarkerRangeForTextMarkerCallback):
2553 (rightWordTextMarkerRangeForTextMarkerCallback):
2554 (previousWordStartTextMarkerForTextMarkerCallback):
2555 (nextWordEndTextMarkerForTextMarkerCallback):
2556 (setSelectedVisibleTextRangeCallback):
2557 (AccessibilityUIElement::setSelectedVisibleTextRange):
2558 (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2559 (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2560 (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2561 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2562 (AccessibilityUIElement::getJSClass):
2563 * DumpRenderTree/AccessibilityUIElement.h:
2564 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2565 (AccessibilityUIElement::setSelectedVisibleTextRange):
2566 (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2567 (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2568 (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2569 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2570 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2571 (AccessibilityUIElement::setSelectedVisibleTextRange):
2572 (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2573 (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2574 (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2575 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2576 (AccessibilityUIElement::supportedActions):
2577 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2578 (WTR::AccessibilityUIElement::setBoolAttributeValue):
2579 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2580 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2581 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2582 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2583 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2584 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2585 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2586 (WTR::AccessibilityUIElement::endTextMarker):
2587 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2588 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2589 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2590 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2591 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2592 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2593 (WTR::AccessibilityUIElement::endTextMarker):
2594 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2595 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2596 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2597 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2598 (WTR::_convertMathMultiscriptPairsToString):
2600 2016-02-09 Csaba Osztrogonác <ossy@webkit.org>
2602 [EFL] Remove eail related cruft after r195725
2603 https://bugs.webkit.org/show_bug.cgi?id=154030
2605 Reviewed by Alex Christensen.
2609 2016-02-09 Csaba Osztrogonác <ossy@webkit.org>
2611 [EFL] Remove LLVM related cruft after r196077
2612 https://bugs.webkit.org/show_bug.cgi?id=154031
2614 Reviewed by Alex Christensen.
2616 * efl/jhbuild.modules:
2617 * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
2618 * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
2619 * efl/patches/llvm-version-arm64.patch: Removed.
2621 2016-02-05 Aakash Jain <aakash_jain@apple.com>
2623 tests fail if display sleeps while run-webkit-tests is running
2624 https://bugs.webkit.org/show_bug.cgi?id=153919
2626 Reviewed by Alexey Proskuryakov.
2628 * DumpRenderTree/mac/LayoutTestHelper.m:
2629 (addDisplaySleepAssertion): Add the assertion so that the display doesn't turn off.
2630 (releaseDisplaySleepAssertion): Release the DisplaySleep Assertion.
2631 (simpleSignalHandler): Release the DisplaySleepAssertion in case of any iterrupt.
2633 2016-02-05 Alex Christensen <achristensen@webkit.org>
2635 Fix iOS API tests after r196082
2636 https://bugs.webkit.org/show_bug.cgi?id=153900
2638 Reviewed by Jer Noble.
2640 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2641 (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2642 [WebView initialize] doesn't call JSC::initializeThreading on iOS.
2644 2016-02-04 Jason Marcell <jmarcell@apple.com>
2646 The status message for passing combined builder queues should say "all builds succeeded" when expanded.
2647 https://bugs.webkit.org/show_bug.cgi?id=153882
2649 Reviewed by Alexey Proskuryakov.
2651 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2652 (BuildbotCombinedQueueView.prototype.update): Set status to "all builds succeeded" for combined builder queues
2655 2016-02-03 Filip Pizlo <fpizlo@apple.com>
2657 run-jsc-stress-tests should be better at telling you details about test failures
2658 https://bugs.webkit.org/show_bug.cgi?id=153845
2660 Reviewed by Geoffrey Garen.
2662 Here's an example of the contents of results/resultsByFamily, one of the new files that this
2663 generates, for some local testing I'm doing. Notice how it groups families of tests together.
2665 You won't see this unless you cat results/resultsByFamily.
2667 regress.yaml/Regress/radar-24289839.js:
2668 regress.yaml/Regress/radar-24289839.js.default: PASS
2669 regress.yaml/Regress/radar-24289839.js.ftl: PASS
2670 regress.yaml/Regress/radar-24289839.js.ftl-no-cjit: FAIL
2671 regress.yaml/Regress/radar-24289839.js.ftl-eager-no-cjit: FAIL
2673 regress.yaml/Regress/radar-24290639.js:
2674 regress.yaml/Regress/radar-24290639.js.default: PASS
2675 regress.yaml/Regress/radar-24290639.js.ftl: PASS
2676 regress.yaml/Regress/radar-24290639.js.ftl-no-cjit: PASS
2677 regress.yaml/Regress/radar-24290639.js.ftl-eager-no-cjit: FAIL
2679 regress.yaml/Regress/radar-24290670.js: FAILED
2681 * Scripts/run-jsc-stress-tests:
2683 2016-02-03 Carlos Garcia Campos <cgarcia@igalia.com>
2685 [WTR] Crash in EventSendingController::contextClick() when context menu event is not handled
2686 https://bugs.webkit.org/show_bug.cgi?id=153835
2688 Reviewed by Martin Robinson.
2690 WKBundlePageCopyContextMenuAtPointInWindow() returns nullptr when
2691 the context menu event is not handled, but we are using the
2692 returned value without null checking it.
2694 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2695 (WTR::EventSendingController::contextClick):
2697 2016-02-03 Jason Marcell <jmarcell@apple.com>
2699 Format revisions for display according to repository type
2700 https://bugs.webkit.org/show_bug.cgi?id=153818
2702 Reviewed by Alexey Proskuryakov.
2704 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2705 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Use new _formatRevisionForDisplay to display revisions according
2707 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
2708 (BuildbotQueueView.prototype._formatRevisionForDisplay): Formats revisions for display according to repository type.
2709 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test new
2710 _formatRevisionForDisplay function.
2712 2016-02-03 Aakash Jain <aakash_jain@apple.com>
2714 Logs/CoreSimulator filling up OS disk on WebKit testers
2715 https://bugs.webkit.org/show_bug.cgi?id=153853
2716 <rdar://problem/24496003>
2718 Reviewed by Alexey Proskuryakov.
2720 * Scripts/webkitpy/port/ios.py:
2721 (IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.
2723 2016-02-03 Brian Burg <bburg@apple.com>
2725 git-add-reviewer should work when run from a subdirectory within the repository
2726 https://bugs.webkit.org/show_bug.cgi?id=153842
2728 Reviewed by David Kilzer.
2730 There are two problems that needed to be fixed:
2732 - We can't assume .git is in $PWD/.git
2733 - We can't specify absolute paths to `git commit`
2735 Fix these problems using the helpers in VCSUtils that were added to
2736 fix this same issue for prepare-changeCogs.
2738 * Scripts/VCSUtils.pm: Export gitDirectory()
2739 * Scripts/git-add-reviewer:
2740 (nonInteractive): Cache gitDirectory() result.
2743 (changeLogsForCommit): Make paths relative.
2745 2016-02-03 Jer Noble <jer.noble@apple.com>
2747 Yet another Yosemite build fix.
2749 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2751 2016-02-03 Jer Noble <jer.noble@apple.com>
2753 iOS build fix after Yosemite build fix broke iOS build.
2755 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2757 2016-02-03 Jer Noble <jer.noble@apple.com>
2759 Yosemite build fix; hide the entire WebCoreNSURLSessionDataTask class from Yosemite and prior.
2761 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2763 2016-02-03 Joonghun Park <jh718.park@samsung.com>
2765 [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
2766 https://bugs.webkit.org/show_bug.cgi?id=153827
2768 Reviewed by Michael Catanzaro.
2770 When an array is passed to subroutines as argument in perl,
2771 a list containing its element is returned from the array.
2772 Currently @$ arguments are being passed, then it is going to be one list
2773 including all the elements not only from @ but also from $.
2774 As a result, --cmakeargs option's value is included in @cmakeArgs
2775 at generateBuildSystemFromCMakeProject subroutine,
2776 so $additionalCMakeArgs doesn't needed anymore.
2778 * Scripts/webkitdirs.pm:
2779 (generateBuildSystemFromCMakeProject):
2781 2016-02-03 Jer Noble <jer.noble@apple.com>
2783 [Mac] Wrap a resource and resource loader in a NSURLSession-like object for use by lower level frameworks
2784 https://bugs.webkit.org/show_bug.cgi?id=153669
2786 Reviewed by Alex Christensen.
2788 Add an API test for WebCoreNSURLSession, testing that it behaves like a regulare NSURLSession, including
2789 calling appropriate NSURLSessionDelegate callbacks.
2791 Drive-by fix: Add a FeatureDefines.xcconfig to TestWebKitAPI. Without this, the ENABLE macros in WebCore
2792 header files will not match the one used when compiling WebCore, leading to strange crashes and weird
2793 inconsistencies when calling, e.g., inline methods.
2795 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added.
2796 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2797 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2798 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: Added.
2799 (-[TestNSURLSessionLoaderDelegate webView:didCommitLoadForFrame:]):
2800 (-[TestNSURLSessionDataDelegate URLSession:task:didCompleteWithError:]):
2801 (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
2802 (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveData:]):
2803 (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2804 (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
2805 (TestWebKitAPI::TEST_F):
2807 2016-02-03 Konstantin Tokarev <annulen@yandex.ru>
2809 [webkitdirs] Clarify logic behind is{PortName} functions.
2810 https://bugs.webkit.org/show_bug.cgi?id=153554
2812 Reviewed by Michael Catanzaro.
2814 * Scripts/webkitdirs.pm:
2815 (prohibitUnknownPort): This function makes determinePortName()
2817 (determinePortName): Added new function which decides which port are
2818 we building based on command line switches and platform defaults.
2819 (portName): Added getter for determined $portName.
2820 (isEfl): Modified to use portName().
2822 (isWinCairo): Ditto.
2823 (isAppleMacWebKit): Ditto.
2824 (isAppleWinWebKit): Ditto.
2825 (isIOSWebKit): Ditto.
2826 (cmakeBasedPortName): Return portName() with capitalized first letter.
2827 (determineIsEfl): Deleted.
2828 (determineIsGtk): Deleted.
2829 (determineIsWinCairo): Deleted.
2831 * Scripts/build-jsc: Call prohibitUnknownPort().
2832 * Scripts/run-minibrowser: Ditto.
2833 * Scripts/webkitperl/FeatureList.pm: Ditto.
2834 * Scripts/update-webkit: Call determinePortName() instead of
2835 determineIsWinCairo().
2837 2016-02-02 Dan Bernstein <mitz@apple.com>
2839 Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
2840 https://bugs.webkit.org/show_bug.cgi?id=153683
2842 Reviewed by Darin Adler.
2844 * Scripts/webkitpy/port/driver.py:
2845 (Driver._setup_environ_for_driver): Reverted change from r196013. DUMPRENDERTREE_TEMP is not
2846 used by any code in the Web Content process. If that ever changed, we should send it over
2847 as a bundle parameter.
2849 * Scripts/webkitpy/port/ios.py:
2850 (IOSSimulatorPort.setup_environ_for_server): Reverted change from r196013.
2852 * Scripts/webkitpy/port/mac.py:
2853 (MacPort.setup_environ_for_server): Ditto.
2855 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2856 (WTR::InjectedBundle::platformInitialize): Set XML_CATALOG_FILES in the Web Process
2857 environment. This is early enough that libxml2 has not been initialized yet.
2859 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2860 (WTR::InjectedBundle::platformInitialize): Ditto.
2862 2016-02-02 Dan Bernstein <mitz@apple.com>
2864 Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
2865 https://bugs.webkit.org/show_bug.cgi?id=153683
2867 Reviewed by Alexey Proskuryakov.
2869 Ensure that XML_CATALOG_FILES is set in the Web Content service’s environment as well.
2871 * Scripts/webkitpy/port/driver.py:
2872 (Driver._setup_environ_for_driver): Also set __XPC_DUMPRENDERTREE_TEMP.
2873 * Scripts/webkitpy/port/ios.py:
2874 (IOSSimulatorPort.setup_environ_for_server): Set __XPC_XML_CATALOG_FILES.
2875 * Scripts/webkitpy/port/mac.py:
2876 (MacPort.setup_environ_for_server): Ditto.
2878 2016-01-29 Grzegorz Czajkowski <g.czajkowski@samsung.com>
2880 [EFL] Virtual Keyboard overlaps MiniBrowser's WebView
2881 https://bugs.webkit.org/show_bug.cgi?id=153009
2883 Reviewed by Gyuyoung Kim.
2885 On mobile, virtual keyboard represented by ecore_imf module appears on
2886 the top of application layer usually covering bottom part of the screen.
2887 If the web page contains the editable content on the bottom of the page
2888 it will be overlapped by keyboard which prevents user from seeing the
2891 Pack MiniBrowser layout into conformant widget to allow EFL to guess
2892 the space that will be required by the keyboard, finally resizing it
2893 to the desired size. As a result, webview gets resized and scrolled
2894 into focused elements which makes the editable elements visible while
2897 More details about elm_conformant widger can be found at:
2898 https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
2899 https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
2901 * MiniBrowser/efl/main.c:
2902 (window_create): pack a box into conformant widget.
2904 2016-02-02 Alejandro G. Castro <alex@igalia.com>
2906 [GTK][EFL] Upgrade OpenWebRTC dependency
2907 https://bugs.webkit.org/show_bug.cgi?id=153489
2909 Reviewed by Philippe Normand.
2911 * Scripts/run-gtk-tests:
2912 (TestRunner): Avoid running the mediastream API test.
2913 * Scripts/webkitperl/FeatureList.pm: Stop compiling mediastream by
2914 default for gtk and efl.
2915 * gtk/jhbuild-webrtc.modules: Added modules files with
2916 dependencies required to compile and test the mediastream.
2918 2016-02-01 Jason Marcell <jmarcell@apple.com>
2920 Add code to parse the git branches out of the Trac RSS feed
2921 https://bugs.webkit.org/show_bug.cgi?id=153624
2923 Reviewed by Daniel Bates.
2925 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2926 (Trac.prototype.commitsOnBranch): Update filter to check for Git branches.
2927 (Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to
2928 "branches" and updated the code to work with an array instead of a string.
2929 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
2930 (MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS.
2931 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test
2932 fixture that contains XML with a Git branch.
2933 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git
2934 branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant.
2936 2016-02-01 Brady Eidson <beidson@apple.com>
2938 Add command line flag to DRT to output the number of tests completed in server mode.
2939 https://bugs.webkit.org/show_bug.cgi?id=153750
2941 Reviewed by Darin Adler.
2943 * DumpRenderTree/mac/DumpRenderTree.mm:
2944 (initializeGlobalsFromCommandLineOptions):
2945 (runTestingServerLoop):
2947 2016-02-01 Jason Marcell <jmarcell@apple.com>
2949 Improvements to botwatcher's dashboard unit tests.
2950 https://bugs.webkit.org/show_bug.cgi?id=153621
2952 Reviewed by Darin Adler.
2954 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
2955 (PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
2956 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
2957 (MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
2958 _popoverLinesForCommitRange have to traverse commits from different branches.
2959 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
2960 in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
2961 _revisionContentWithPopoverForIteration.
2963 2016-02-01 Jason Marcell <jmarcell@apple.com>
2965 Refactor to add event listeners and start periodic updates for all trac instances.
2966 https://bugs.webkit.org/show_bug.cgi?id=153609
2968 Reviewed by Darin Adler.
2970 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2971 (BuildbotQueueView): Adding event listeners for all trac instances.
2972 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates
2973 for all trac instances.
2975 2016-01-31 Darin Adler <darin@apple.com>
2977 Replace CaseFoldingHash with ASCIICaseInsensitiveHash
2978 https://bugs.webkit.org/show_bug.cgi?id=153639
2980 Reviewed by Filip Pizlo.
2982 * Scripts/do-webcore-rename: Use script to do this rename.
2984 2016-01-30 Commit Queue <commit-queue@webkit.org>
2986 Unreviewed, rolling out r195911.
2987 https://bugs.webkit.org/show_bug.cgi?id=153723
2989 Caused frequent assertion failures on bots (Requested by ap on
2994 "Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
2995 https://bugs.webkit.org/show_bug.cgi?id=153639
2996 http://trac.webkit.org/changeset/195911
2998 2016-01-30 Darin Adler <darin@apple.com>
3000 Replace CaseFoldingHash with ASCIICaseInsensitiveHash
3001 https://bugs.webkit.org/show_bug.cgi?id=153639
3003 Reviewed by Filip Pizlo.
3005 * Scripts/do-webcore-rename: Use script to do this rename.
3007 2016-01-30 Ryosuke Niwa <rniwa@webkit.org>
3009 TouchList should be retargeted
3010 https://bugs.webkit.org/show_bug.cgi?id=149592
3012 Reviewed by Antti Koivisto.
3014 Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with
3015 multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature.
3017 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
3018 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3019 (WTR::UIScriptController::touchDownAtPoint): Added.
3020 (WTR::UIScriptController::liftUpAtPoint): Added.
3021 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3022 * WebKitTestRunner/ios/HIDEventGenerator.h:
3023 * WebKitTestRunner/ios/HIDEventGenerator.mm:
3024 (-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits.
3025 (-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up.
3026 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3027 (WTR::UIScriptController::touchDownAtPoint): Added.
3028 (WTR::UIScriptController::liftUpAtPoint): Added.
3030 2016-01-30 Yusuke Suzuki <utatane.tea@gmail.com>
3032 Enable SamplingProfiler on POSIX environment
3033 https://bugs.webkit.org/show_bug.cgi?id=153584
3035 Reviewed by Michael Saboff.
3037 * Scripts/run-jsc-stress-tests:
3039 2016-01-29 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
3041 update-webkit-dependency fails to fetch updates through firewall on Windows
3042 https://bugs.webkit.org/show_bug.cgi?id=153619
3044 Reviewed by Myles C. Maxfield.
3046 On Windows, when a firewall is present we need to read proxy settings
3047 from environment variables.
3049 This patch relies on the following environment variables being set:
3053 * Scripts/update-webkit-dependency:
3055 2016-01-28 Dan Bernstein <mitz@apple.com>
3057 [Cocoa] Use the non-Development variants of XPC services for development
3058 https://bugs.webkit.org/show_bug.cgi?id=152545
3060 Reviewed by Darin Adler.
3062 * Scripts/webkitdirs.pm:
3063 (setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well.
3065 * Scripts/webkitpy/port/driver.py:
3066 (Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are
3067 set in the XPC services as well.
3069 * Scripts/webkitpy/port/ios.py:
3070 (IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and
3071 Guard Malloc are enabled in XPC services as well.
3073 * Scripts/webkitpy/port/mac.py:
3074 (MacPort.setup_environ_for_server): Ditto.
3076 2016-01-28 Csaba Osztrogonác <ossy@webkit.org>
3078 Unreviewed buildfix after r195743.
3080 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3081 (WTR::AccessibilityUIElement::isPressActionSupported):
3083 2016-01-12 Jer Noble <jer.noble@apple.com>
3085 Custom protocol loading through AVFoundation does not support byte-range requests.
3086 https://bugs.webkit.org/show_bug.cgi?id=152919
3087 <rdar://problem/23664657>
3089 Reviewed by Alex Christensen.
3091 Add tests for new ParsedContntRange class.
3093 * TestWebKitAPI/PlatformWin.cmake:
3094 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3095 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3096 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3097 * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added.
3098 (TestWebKitAPI::TEST):
3100 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
3102 Use isAnyWindows() instead of isCygwin() || isWindows() in Perl scripts.
3103 https://bugs.webkit.org/show_bug.cgi?id=153594
3105 Reviewed by Alex Christensen.
3107 * Scripts/webkitdirs.pm:
3108 (determineNumberOfCPUs):
3112 (wrapperPrefixIfNeeded):
3113 (cmakeGeneratedBuildfile):
3114 (generateBuildSystemFromCMakeProject):
3115 * Scripts/webkitperl/features.pm:
3116 (libraryContainsSymbol):
3118 2016-01-28 Chris Dumez <cdumez@apple.com>
3120 Unreviewed, rolling out r195742.
3126 "[webkitdirs] Clarify logic behind is{PortName} functions."
3127 https://bugs.webkit.org/show_bug.cgi?id=153554
3128 http://trac.webkit.org/changeset/195742
3130 2016-01-28 Darin Adler <darin@apple.com>
3132 Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
3133 https://bugs.webkit.org/show_bug.cgi?id=153411
3135 Reviewed by Ryosuke Niwa.
3137 * Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we
3138 have removed the function instead.
3140 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3141 (TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we
3142 added overloads for const char*.
3144 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3145 (WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase.
3146 (WTR::AccessibilityUIElement::hasPopup): Ditto.
3147 * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
3148 (WTR::testPathFromURL): Ditto.
3150 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
3152 [webkitdirs] Clarify logic behind is{PortName} functions.
3153 https://bugs.webkit.org/show_bug.cgi?id=153554
3155 Reviewed by Darin Adler.
3157 * Scripts/webkitdirs.pm:
3158 (determinePortName): Added new function which decides which port are
3159 we building based on command line switches and platform defaults.
3160 (portName): Added getter for determined $portName.
3161 (isEfl): Modified to use portName().
3163 (isWinCairo): Ditto.
3164 (isAppleMacWebKit): Ditto.
3165 (isAppleWinWebKit): Ditto.
3166 (isIOSWebKit): Ditto.
3167 (cmakeBasedPortName): Code replaced with portName() call.
3168 (determineIsEfl): Deleted.
3169 (determineIsGtk): Deleted.
3170 (determineIsWinCairo): Deleted.
3172 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
3174 [webkitdirs] Don't pass cmakeBasedPortName around.
3175 https://bugs.webkit.org/show_bug.cgi?id=153589
3177 Reviewed by Darin Adler.
3179 It should be local function of webkitdirs.pm instead.
3181 * Scripts/build-jsc: Don't pass cmakeBasedPortName to
3182 buildCMakeProjectOrExit().
3183 * Scripts/build-webkit: Don't pass cmakeBasedPortName to
3184 buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject().
3185 * Scripts/run-efl-tests: Don't pass cmakeBasedPortName to
3186 generateBuildSystemFromCMakeProject().
3187 * Scripts/webkitdirs.pm: Don't export cmakeBasedPortName.
3188 (generateBuildSystemFromCMakeProject): Removed $port argument as we
3189 can get it from cmakeBasedPortName().
3190 (buildCMakeProjectOrExit): Ditto.
3192 2016-01-28 Gwang Yoon Hwang <yoon@igalia.com>
3194 [GStreamer] Clean up includes and headers related with GStreamerGL
3195 https://bugs.webkit.org/show_bug.cgi?id=153590
3197 Reviewed by Philippe Normand.
3199 * Scripts/webkitpy/style/checker.py: Skips
3200 include_order check for MediaPlayerPrivateGStreamerBase.cpp
3201 Removes VideoSinkGStreamer1.cpp which doesn't exist anymore.
3203 2016-01-27 Krzysztof Czech <k.czech@samsung.com>
3205 [EFL] Remove unused accessibility related code
3206 https://bugs.webkit.org/show_bug.cgi?id=153543
3208 Reviewed by Darin Adler.
3210 Removed reference to EAIL library.
3211 It not going to be support anymore. There have been changes in
3212 EFL/Elementary in terms of the accessibility and we should
3215 * efl/jhbuild-optional.modules:
3217 2016-01-27 Daniel Bates <dabates@apple.com>
3219 Remove WebKitSystemInterface for iOS SDK < 9
3220 https://bugs.webkit.org/show_bug.cgi?id=153570
3222 Reviewed by Andy Estes.
3224 * Scripts/copy-webkitlibraries-to-product-directory:
3226 2016-01-27 Jason Marcell <jmarcell@apple.com>
3228 Fix bugs caused by incorrect usage of "branch" vs. "branchName".
3229 https://bugs.webkit.org/show_bug.cgi?id=153330
3231 Reviewed by Daniel Bates.
3233 In an earlier patch we started using the name "branch" to indicate a branch object, whereas
3234 "branchName" implies that the variable or property in question is simply a string. We fixed some
3235 inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
3236 spotted in BuildbotQueueView.js.
3238 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3239 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
3240 Changed branchName to branch.name in call to commitsOnBranch.
3241 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
3242 _popoverLinesForCommitRange.
3243 (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
3244 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
3245 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
3248 2016-01-27 Ryosuke Niwa <rniwa@webkit.org>
3250 Add API to access closed shadowRoot in InjectedBundle
3251 https://bugs.webkit.org/show_bug.cgi?id=153533
3253 Reviewed by Antti Koivisto.
3255 Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
3257 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3258 * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
3259 (TestWebKitAPI::runJavaScriptAlert):
3260 (TestWebKitAPI::TEST):
3261 * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
3262 (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
3263 (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
3265 2016-01-27 Jason Marcell <jmarcell@apple.com>
3267 Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
3268 https://bugs.webkit.org/show_bug.cgi?id=153332
3270 Reviewed by Alexey Proskuryakov.
3272 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3273 (Trac.prototype._xmlTimelineURL): Uses new function.
3274 (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
3275 logic for parsing git hashes.
3276 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
3277 Trac._parseRevisionFromURL.
3279 2016-01-27 Alexey Proskuryakov <ap@apple.com>
3281 Remove Mavericks from the flakiness dashboard
3282 https://bugs.webkit.org/show_bug.cgi?id=153521
3284 Reviewed by Dan Bernstein.
3286 * TestResultServer/static-dashboards/builders.jsonp:
3287 * TestResultServer/static-dashboards/flakiness_dashboard.js:
3289 2016-01-27 Alexey Proskuryakov <ap@apple.com>
3291 Remove ENABLE_CURRENTSRC
3292 https://bugs.webkit.org/show_bug.cgi?id=153545
3294 Reviewed by Simon Fraser.
3296 * Scripts/webkitperl/FeatureList.pm:
3298 2016-01-26 Jason Marcell <jmarcell@apple.com>
3300 Sort incoming commits via date instead of revision number.
3301 https://bugs.webkit.org/show_bug.cgi?id=153467
3303 Reviewed by Alexey Proskuryakov.
3305 Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
3306 for sorting revisions. Instead we use the commit date to sort revisions chronologically.
3308 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3309 (Trac.prototype._loaded): Sort via date instead of revision number.
3310 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
3311 (MockTrac): Fix up the mock data to look more like real-world data.
3312 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
3313 Fake RSS feed that adds three more commits.
3314 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
3317 2016-01-26 I-Ting Liu <iting_liu@apple.com>
3319 Add a test for WebKit::stringMatchesWildcardString.
3320 https://bugs.webkit.org/show_bug.cgi?id=153090
3322 Reviewed by Darin Adler.
3324 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3325 Add the file to the project.
3327 * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
3328 (TestWebKitAPI::TEST):
3329 Test that a string matches another string that may contain wildcard characters.
3331 2016-01-26 Konstantin Tokarev <annulen@yandex.ru>
3333 [webkitdirs] Removed check for bison, gperf, and flex.
3334 https://bugs.webkit.org/show_bug.cgi?id=153496
3336 Reviewed by Alex Christensen.
3338 This prerequisites are checked in WebKitCommon.cmake and don't
3339 have to be in $PATH.
3341 * Scripts/webkitdirs.pm:
3342 (checkRequiredSystemConfig):
3344 2016-01-26 Konstantin Tokarev <annulen@yandex.ru>
3346 [webkitdirs] isCMakeBuild should be true by default
3347 https://bugs.webkit.org/show_bug.cgi?id=153497
3349 Reviewed by Michael Catanzaro.
3351 * Scripts/webkitdirs.pm:
3354 2016-01-26 Daniel Bates <dabates@apple.com>
3356 Add WebKitSystemInterface for iOS 9.2
3357 https://bugs.webkit.org/show_bug.cgi?id=153355
3359 Rubber-stamped by David Kilzer.
3361 * Scripts/copy-webkitlibraries-to-product-directory:
3363 2016-01-26 Daniel Bates <dabates@apple.com>
3365 WebKitTestRunner: Credential cache is not cleared between tests
3366 https://bugs.webkit.org/show_bug.cgi?id=153407
3367 <rdar://problem/24280834>
3369 Reviewed by Alexey Proskuryakov.
3371 * WebKitTestRunner/TestController.cpp:
3372 (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
3373 to clear cached credentials.
3375 2016-01-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
3377 kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
3378 https://bugs.webkit.org/show_bug.cgi?id=153483
3380 Reviewed by Csaba Osztrogonác.
3382 * BuildSlaveSupport/kill-old-processes:
3383 (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
3385 2016-01-25 Simon Fraser <simon.fraser@apple.com>
3387 Give the layout test results file a <title> showing the date and time the tests were run
3388 https://bugs.webkit.org/show_bug.cgi?id=153187
3390 Reviewed by Darin Adler.
3392 Include a 'date' property in the JSON with the date and time the tests completed.
3394 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3395 (summarize_results):
3397 2016-01-25 Commit Queue <commit-queue@webkit.org>
3399 Unreviewed, rolling out r195543.
3400 https://bugs.webkit.org/show_bug.cgi?id=153451
3402 regressed performance of test bots by ~6% (Requested by dydz
3407 "WebKitTestRunner: Credential cache is not cleared between
3409 https://bugs.webkit.org/show_bug.cgi?id=153407
3410 http://trac.webkit.org/changeset/195543
3412 2016-01-25 Aakash Jain <aakash_jain@apple.com>
3414 Failing to upload to flakiness dashboard should not be a hard error
3415 https://bugs.webkit.org/show_bug.cgi?id=153444
3416 <rdar://problem/22146294>
3418 Reviewed by Alexey Proskuryakov.
3420 * Scripts/webkitpy/layout_tests/controllers/manager.py:
3421 (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
3423 2016-01-25 Daniel Bates <dabates@apple.com>
3425 WebKitTestRunner: Credential cache is not cleared between tests
3426 https://bugs.webkit.org/show_bug.cgi?id=153407
3427 <rdar://problem/24280834>
3429 Reviewed by Brady Eidson.
3431 * WebKitTestRunner/TestController.cpp:
3432 (WTR::TestController::resetStateToConsistentValues): Reset testing network session
3433 to clear cached credentials.
3435 2016-01-24 Dan Bernstein <mitz@apple.com>
3437 Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
3439 * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
3441 2016-01-22 Enrica Casucci <enrica@apple.com>
3443 Unreviewed build fix after http://trac.webkit.org/changeset/195474.
3445 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3446 (WTR::TestController::platformCreateWebView):
3448 2016-01-22 Tim Horton <timothy_horton@apple.com>
3450 Add a test for iOS arrow-key repeat
3451 https://bugs.webkit.org/show_bug.cgi?id=152857
3452 <rdar://problem/24017380>
3454 Reviewed by Darin Adler.
3456 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
3457 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3458 (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
3459 (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
3460 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3461 * WebKitTestRunner/ios/HIDEventGenerator.h:
3462 * WebKitTestRunner/ios/HIDEventGenerator.mm:
3463 (-[HIDEventGenerator keyPress:completionBlock:]):
3464 (-[HIDEventGenerator keyDown:completionBlock:]):
3465 (-[HIDEventGenerator keyUp:completionBlock:]):
3466 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3467 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
3468 (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
3469 (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
3470 Make it possible to independently send keyUp/keyDown, instead of just paired.
3472 2016-01-22 Tim Horton <timothy_horton@apple.com>
3474 Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
3475 https://bugs.webkit.org/show_bug.cgi?id=153193
3476 <rdar://problem/24222034>
3478 Reviewed by Darin Adler.
3480 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3481 (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
3483 Add a test that exhibits the problems we're fixing here.
3484 Before, it would both log and assert in debug, and crash in release.
3485 Now it runs happily to completion.
3487 2016-01-22 Enrica Casucci <enrica@apple.com>
3489 Add support for testing data detection.
3490 https://bugs.webkit.org/show_bug.cgi?id=153360
3492 Reviewed by Tim Horton.
3494 Adding a new testing option (useDataDetection) to turn on
3495 data detection when running the a test.
3497 * WebKitTestRunner/TestController.cpp:
3498 (WTR::updateTestOptionsFromTestHeader):
3499 * WebKitTestRunner/TestOptions.h:
3500 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3501 (WTR::TestController::platformCreateWebView):
3503 2016-01-21 Simon Fraser <simon.fraser@apple.com>
3505 Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
3506 https://bugs.webkit.org/show_bug.cgi?id=153334
3508 Reviewed by Zalan Bujtas.
3510 Evaluating expressions in the LayoutUnit summary provider seems to cause
3511 re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
3514 * lldb/lldb_webkit.py:
3515 (WebCoreLayoutUnitProvider.to_string):
3517 2016-01-21 Filip Pizlo <fpizlo@apple.com>
3519 display-profiler-output should be able to display code blocks sorted by machine counts
3520 https://bugs.webkit.org/show_bug.cgi?id=153298
3522 Reviewed by Oliver Hunt.
3524 * Scripts/display-profiler-output:
3526 2016-01-21 Julien Isorce <j.isorce@samsung.com>
3528 Ensure to use compatible liborc version with wanted gstreamer version
3529 https://bugs.webkit.org/show_bug.cgi?id=153276
3531 For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
3532 The user may have a very recent liborc installed on his system.
3534 Reviewed by Philippe Normand.
3536 * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
3537 * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
3539 2016-01-21 Nan Wang <n_wang@apple.com>
3541 AX: [IOS] Implement next/previous text marker functions using TextIterator
3542 https://bugs.webkit.org/show_bug.cgi?id=153292
3543 <rdar://problem/24268243>
3545 Reviewed by Chris Fleizach.
3547 Made text marker tests available on iOS.
3549 * DumpRenderTree/AccessibilityTextMarker.h:
3550 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3551 * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
3552 (AccessibilityTextMarker::AccessibilityTextMarker):
3553 (AccessibilityTextMarker::~AccessibilityTextMarker):
3554 (AccessibilityTextMarker::isEqual):
3555 (AccessibilityTextMarker::platformTextMarker):
3556 (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3557 (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
3558 (AccessibilityTextMarkerRange::isEqual):
3559 (AccessibilityTextMarkerRange::platformTextMarkerRange):
3560 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3561 (AccessibilityUIElement::pathDescription):
3562 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3563 (AccessibilityUIElement::textMarkerRangeForElement):
3564 (AccessibilityUIElement::selectedTextMarkerRange):
3565 (AccessibilityUIElement::resetSelectedTextMarkerRange):
3566 (AccessibilityUIElement::textMarkerRangeLength):
3567 (AccessibilityUIElement::textMarkerRangeForMarkers):
3568 (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3569 (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3570 (AccessibilityUIElement::accessibilityElementForTextMarker):
3571 (AccessibilityUIElement::endTextMarkerForBounds):
3572 (AccessibilityUIElement::startTextMarkerForBounds):
3573 (AccessibilityUIElement::textMarkerForPoint):
3574 (AccessibilityUIElement::previousTextMarker):
3575 (AccessibilityUIElement::nextTextMarker):
3576 (AccessibilityUIElement::stringForTextMarkerRange):
3577 (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3578 (AccessibilityUIElement::indexForTextMarker):
3579 (AccessibilityUIElement::isTextMarkerValid):
3580 (AccessibilityUIElement::textMarkerForIndex):
3581 (AccessibilityUIElement::startTextMarker):
3582 (AccessibilityUIElement::endTextMarker):
3583 (AccessibilityUIElement::setSelectedVisibleTextRange):
3584 (AccessibilityUIElement::getLinkedUIElements):
3585 * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3586 (AccessibilityTextMarkerRange::platformTextMarkerRange):
3587 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3588 (AccessibilityUIElement::removeSelection):
3589 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3590 (AccessibilityUIElement::setSelectedVisibleTextRange):
3591 (AccessibilityUIElement::supportedActions):
3592 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3593 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
3594 (WTR::AccessibilityUIElement::textMarkerRangeLength):
3595 (WTR::AccessibilityUIElement::previousTextMarker):
3596 (WTR::AccessibilityUIElement::nextTextMarker):
3597 (WTR::AccessibilityUIElement::stringForTextMarkerRange):
3598 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
3599 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3600 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3601 (WTR::AccessibilityUIElement::endTextMarkerForBounds):
3602 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
3603 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3605 2016-01-20 Filip Pizlo <fpizlo@apple.com>
3607 Unreviewed, revert accidental unreviewed commit.
3609 * Scripts/display-profiler-output:
3611 2016-01-20 Jason Marcell <jmarcell@apple.com>
3613 Refactor compareIterations to remove duplicate code.
3614 https://bugs.webkit.org/show_bug.cgi?id=152913
3616 Reviewed by Daniel Bates.
3618 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3619 (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
3620 (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
3621 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
3622 the same behavior before and after refactor.
3624 2016-01-20 Dana Burkart <dburkart@apple.com>
3626 Botwatcher's dashboard should show an 'X' when the build is broken
3627 https://bugs.webkit.org/show_bug.cgi?id=152507
3629 Reviewed by David Kilzer.
3631 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
3632 (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
3633 (BuildbotStaticAnalyzerQueueView.prototype.update):
3635 2016-01-19 Jason Marcell <jmarcell@apple.com>
3637 Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
3638 https://bugs.webkit.org/show_bug.cgi?id=153262
3640 Reviewed by Alexey Proskuryakov.
3642 Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
3643 such cases this revisionContentForIteration method does not have any content to return, thus the
3646 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3647 (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
3649 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
3651 [GTK] Runtime critical warnings when loading a URL after a session restore
3652 https://bugs.webkit.org/show_bug.cgi?id=153233
3654 Reviewed by Michael Catanzaro.
3658 * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
3660 (testWebKitWebViewNavigationAfterSessionRestore):
3663 2016-01-19 Michael Catanzaro <mcatanzaro@igalia.com>
3665 [GTK] Remove jhbuild-optional.modules
3666 https://bugs.webkit.org/show_bug.cgi?id=152964
3668 Reviewed by Alex Christensen.
3670 * gtk/jhbuild-optional.modules: Removed.
3671 * gtk/jhbuild.modules:
3673 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
3675 [GTK] Add support to load/save session in MiniBrowser
3676 https://bugs.webkit.org/show_bug.cgi?id=153201
3678 Reviewed by Michael Catanzaro.
3680 It makes it easier to test the new WebView session API.
3682 * MiniBrowser/gtk/BrowserWindow.c:
3683 (browserWindowFinalize): Free the session file path.
3684 (browserWindowSaveSession): Save the current WebView session if
3685 there's a session file path.
3686 (browserWindowDeleteEvent): Call browserWindowSaveSession().
3687 (browser_window_load_session): Try to load the session from the
3688 given file path, otherwise fall back to homepage and keep the
3689 session file to save the session on window close.
3690 * MiniBrowser/gtk/BrowserWindow.h:
3691 * MiniBrowser/gtk/main.c:
3692 (createBrowserWindow): Pass the given session file path when
3693 shouldLoadSession is TRUE.
3694 (main): Only allow to restore/save session when MiniBrowser is
3695 launched without URL arguments.
3697 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
3699 Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
3701 Geolocation is no longer allowed for unique origins after r195075.
3703 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3704 (testWebViewGeolocationPermissionRequests):
3706 2016-01-18 Carlos Alberto Lopez Perez <clopez@igalia.com>
3708 [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
3709 https://bugs.webkit.org/show_bug.cgi?id=153216
3711 Reviewed by Michael Catanzaro.
3713 * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
3714 (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
3716 2016-01-18 Nan Wang <n_wang@apple.com>
3718 AX: [Mac] Implement next/previous text marker functions using TextIterator
3719 https://bugs.webkit.org/show_bug.cgi?id=152728
3721 Reviewed by Chris Fleizach.
3723 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3724 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
3726 2016-01-18 Csaba Osztrogonác <ossy@webkit.org>
3728 [cmake] Add testair to the build system
3729 https://bugs.webkit.org/show_bug.cgi?id=153126
3731 Reviewed by Michael Catanzaro.