Revert accidentally commited change.
[WebKit.git] / Tools / ChangeLog
1 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
2
3         Revert accidentally commited change.
4
5         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
6         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
7
8 2011-03-28  Tony Chang  <tony@chromium.org>
9
10         Reviewed by Adam Barth.
11
12         [chromium] have DRT write the png checksum into a png comment
13         https://bugs.webkit.org/show_bug.cgi?id=57255
14
15         * DumpRenderTree/chromium/TestShell.cpp:
16         (TestShell::dumpImage):
17
18 2011-03-28  Adele Peterson  <adele@apple.com>
19
20         Removing Qt stub, since it doesn't use the same header as the others.
21
22         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
23
24 2011-03-28  Adele Peterson  <adele@apple.com>
25
26         Added a few more stubs.
27
28         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
29         (LayoutTestController::hasGrammarMarker):
30         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
31         (LayoutTestController::hasGrammarMarker):
32         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
33         (LayoutTestController::hasGrammarMarker):
34
35 2011-03-28  Adele Peterson  <adele@apple.com>
36
37         Build fix.
38
39         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
40         (LayoutTestController::hasGrammarMarker):
41
42 2011-03-28  Adele Peterson  <adele@apple.com>
43
44         Reviewed by Eric Seidel.
45
46         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
47         https://bugs.webkit.org/show_bug.cgi?id=57173
48
49         * DumpRenderTree/LayoutTestController.cpp:
50         (hasGrammarMarkerCallback): Added.
51         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
52         * DumpRenderTree/LayoutTestController.h:
53         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
54         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
55
56 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
57
58         Reviewed by Benjamin Poulain.
59
60         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
61         https://bugs.webkit.org/show_bug.cgi?id=57087
62
63         Trivial typo fix after r82082.
64
65         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
66         (WTR::activateFonts):
67
68 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
69
70         Reviewed by Andreas Kling.
71
72         Add myself to the committers list.
73
74         * Scripts/webkitpy/common/config/committers.py:
75
76 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
77
78         Reviewed by Sam Weinig.
79
80         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
81         to link against WebKit.framework for now.
82
83         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
84
85 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
86
87         Reviewed by Andreas Kling.
88
89         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
90         https://bugs.webkit.org/show_bug.cgi?id=57087
91
92         Disable QT_ASCII_CAST_WARNINGS for applications.
93
94         * DumpRenderTree/qt/DumpRenderTree.pro:
95         * DumpRenderTree/qt/ImageDiff.pro:
96         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
97         * MiniBrowser/qt/MiniBrowser.pro:
98         * QtTestBrowser/QtTestBrowser.pro:
99         * WebKitTestRunner/qt/WebKitTestRunner.pro:
100
101 2011-03-28  Andreas Kling  <kling@webkit.org>
102
103         Reviewed by Kenneth Rohde Christiansen.
104
105         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
106         https://bugs.webkit.org/show_bug.cgi?id=57224
107
108         * QtTestBrowser/mainwindow.cpp:
109         (MainWindow::buildUI):
110         (MainWindow::onTitleChanged):
111         * QtTestBrowser/mainwindow.h:
112
113 2011-03-27  Jer Noble  <jer.noble@apple.com>
114
115         Reviewed by Maciej Stachowiak.
116
117         Full Screen: disable keyboard access by default
118         https://bugs.webkit.org/show_bug.cgi?id=56684
119
120         Accept the withKeyboard parameter to supportsFullScreenForElement.
121
122         * DumpRenderTree/mac/UIDelegate.mm:
123         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
124
125 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
126
127         Reviewed by David Levin.
128
129         check-webkit-style should check ChangeLog for a valid bug number
130         https://bugs.webkit.org/show_bug.cgi?id=57184
131
132         * Scripts/webkitpy/style/checker.py:
133         * Scripts/webkitpy/style/checker_unittest.py:
134         * Scripts/webkitpy/style/checkers/changelog.py: Added.
135         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
136
137 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
138
139         Reviewed by Andreas Kling.
140
141         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
142         https://bugs.webkit.org/show_bug.cgi?id=57087
143
144         Use explicit conversion for string to avoid depending on the default codec
145         installed by the user code.
146
147         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
148         (WTR::activateFonts):
149
150 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
151
152         Revert inadvertantly committed changes.
153
154         * Scripts/old-run-webkit-tests:
155         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
156
157 2011-03-26  Andreas Kling  <kling@webkit.org>
158
159         Reviewed by Kenneth Rohde Christiansen.
160
161         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
162         https://bugs.webkit.org/show_bug.cgi?id=57162
163
164         * QtTestBrowser/QtTestBrowser.qrc:
165         * QtTestBrowser/favicon.png: Added.
166         * QtTestBrowser/locationedit.cpp:
167         (defaultPageIcon):
168         (LocationEdit::LocationEdit):
169         (LocationEdit::setPageIcon):
170         (LocationEdit::resizeEvent):
171         (LocationEdit::updateInternalGeometry):
172         * QtTestBrowser/locationedit.h:
173         * QtTestBrowser/mainwindow.cpp:
174         (MainWindow::buildUI):
175         (MainWindow::onIconChanged):
176         (MainWindow::onLoadStarted):
177         * QtTestBrowser/mainwindow.h:
178
179 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
180
181         Reviewed by Xan Lopez.
182
183         [GTK] Force DumpRenderTree to use 96 DPI
184         https://bugs.webkit.org/show_bug.cgi?id=56866
185
186         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
187         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
188
189         * DumpRenderTree/gtk/DumpRenderTree.cpp:
190         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
191         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
192         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
193
194 2011-03-25  Andy Estes  <aestes@apple.com>
195
196         Reviewed by Adele Peterson.
197
198         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
199         https://bugs.webkit.org/show_bug.cgi?id=49016
200
201         TestNetscapePlugIn needs to register support for an image MIME type so
202         we can test that the embed tag prefers plug-ins to render image MIME
203         types.
204
205         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
206         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
207         (NP_GetMIMEDescription): Ditto.
208         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
209
210 2011-03-25  Jessie Berlin  <jberlin@apple.com>
211
212         Reviewed by Sam Weinig.
213
214         WebKit2: Need to be able to set and get the Cookie Storage Policy.
215         https://bugs.webkit.org/show_bug.cgi?id=50780
216
217         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
218
219         The test is named "CookieManager" so that we can eventually exercise more of the
220         CookieManager functionality in the test.
221
222         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
223         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
224         Assert that the policy returned is equal to the policy set in
225         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
226         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
227         Set the policy to something different than the user's policy and get the policy again.
228         (TestWebKitAPI::didFinishLoadForFrame):
229         Get the user's policy so that it can be restored at the end of the test.
230         (TestWebKitAPI::TEST):
231         Load about:blank so that the Web Process gets instatiated (needed to get the
232         CookieManager).
233
234         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
235         Add CookieManager.cpp.
236
237 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
238
239         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
240
241         * wx/build/settings.py:
242
243 2011-03-24  Ilya Sherman  <isherman@chromium.org>
244
245         Reviewed by Adam Roben.
246
247         Implement layoutTestController.setAutoFilled in DRT on Windows
248         https://bugs.webkit.org/show_bug.cgi?id=56828
249
250         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
251         (LayoutTestController::setAutofilled): Implemented.
252
253 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
254
255         Unreviewed build correction.
256
257         Correct vsprops file for Debug variant of the CFLite build.
258         Disable a CFNETWORK-specific test when building for CFLite.
259
260         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
261         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
262
263 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
264
265         Reviewed by Adam Barth.
266
267         fix regressions introduced in 81908 - there were a couple of
268         code paths that only fired under python 2.5 that I missed.
269
270         Also change a couple of 'python' references to sys.executable
271         in order to handle runing test-webkitpy with a binary other than
272         something called 'python'.
273
274         https://bugs.webkit.org/show_bug.cgi?id=57063
275
276         * Scripts/webkitpy/layout_tests/port/mac.py:
277         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
278         * Scripts/webkitpy/test/cat.py:
279         * Scripts/webkitpy/test/echo.py:
280
281 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
282
283         Unreviewed build correction.
284
285         Add a stub implementation of the TestInvocation dumping logic.
286         Update project files to reflect new file.
287
288         * WebKitTestRunner/cairo: Added.
289         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
290         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
291         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
292
293 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
294
295         Reviewed by Tony Chang.
296
297         new-run-webkit-tests: clean up worker model defaults. This
298         changes the default behavior to 'threads' instead of
299         'old-threads', and clarifies that chromium-win-* and
300         chromium-mac-leopard are exceptions.
301
302         https://bugs.webkit.org/show_bug.cgi?id=56971
303
304         * Scripts/webkitpy/layout_tests/port/base.py:
305         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
306         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
307         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
308         * Scripts/webkitpy/layout_tests/port/test.py:
309         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
310
311 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
312
313         Reviewed by Darin Adler.
314
315         Media Stream API: fix the order of the options in build-webkit.
316         https://bugs.webkit.org/show_bug.cgi?id=56949
317
318         Fix the order of the options in build-webkit.
319
320         * Scripts/build-webkit:
321
322 2011-03-23  Adam Klein  <adamk@chromium.org>
323
324         Reviewed by Mihai Parparita.
325
326         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
327         https://bugs.webkit.org/show_bug.cgi?id=56884
328
329         This option will be utilized by Chromium's ui_tests to allow
330         referencing js-test-resources from a layout test over HTTP.
331
332         * Scripts/new-run-webkit-httpd:
333         Added --layout_tests_dir option.
334         * Scripts/webkitpy/layout_tests/port/http_server.py:
335         Plumbed through as layout_tests_dir param.
336
337 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
338
339         Reviewed by Mihai Parparita.
340
341         new-run-webkit-tests: run tests in ascending alphabetical order per
342         dir. This is a second attempt at the fix; the first attempt, in 
343         r81597, broke the behavior on the old-inline and old-threads
344         worker models.
345
346         https://bugs.webkit.org/show_bug.cgi?id=56760
347
348         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
349         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
350         * Scripts/webkitpy/layout_tests/port/test.py:
351         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
352
353 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
354
355         Reviewed by Martin Robinson.
356
357         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
358         https://bugs.webkit.org/show_bug.cgi?id=56953
359
360         Print the string for the detail of 'property-change' signal.
361
362         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
363         (axObjectEventListener): Print the detail string.
364
365 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
366
367         Reviewed by Pavel Feldman.
368
369         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
370         https://bugs.webkit.org/show_bug.cgi?id=56843
371
372         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
373         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
374
375 2011-03-22  Eric Seidel  <eric@webkit.org>
376
377         Reviewed by Adam Barth.
378
379         Teach update-webkit about gyp
380         https://bugs.webkit.org/show_bug.cgi?id=56881
381
382         This makes it possible for someone who builds from Xcode
383         to just run update-webkit --gyp and have the project files
384         generated after update automatically.
385
386         I also added a stand-alone "generate-project-files" script
387         wrapping Source/gyp/configure.  This makes running gyp simpler
388         since most people will not have gyp or Source/gyp in their path.
389
390         * Scripts/build-webkit:
391         * Scripts/generate-project-files: Added.
392         * Scripts/update-webkit:
393
394 2011-03-22  Anton D'Auria  <adauria@apple.com>
395
396         Reviewed by Alexey Proskuryakov.
397
398         Add +[WebApplicationCache getOriginsWithCache]
399         https://bugs.webkit.org/show_bug.cgi?id=56722
400
401         * DumpRenderTree/LayoutTestController.cpp:
402         (originsWithApplicationCacheCallback):
403         (LayoutTestController::staticFunctions):
404         * DumpRenderTree/LayoutTestController.h:
405         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
406         (LayoutTestController::originsWithApplicationCache):
407         * DumpRenderTree/chromium/LayoutTestController.h:
408         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
409         (LayoutTestController::originsWithApplicationCache):
410         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
411         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
412         (LayoutTestController::originsWithApplicationCache):
413         (LayoutTestController::originsWithLocalStorage):
414         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
415         (LayoutTestController::originsWithApplicationCache):
416         * DumpRenderTree/qt/LayoutTestControllerQt.h:
417         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
418         (LayoutTestController::originsWithApplicationCache):
419         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
420         (LayoutTestController::originsWithApplicationCache):
421
422 2011-03-22  Eric Seidel  <eric@webkit.org>
423
424         Reviewed by Adam Barth.
425
426         Add support to build-webkit for building with gyp-generated project files
427         https://bugs.webkit.org/show_bug.cgi?id=56877
428
429         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
430         Eventually we'll want to support gyp-generated projects in a more general manner.
431
432         * Scripts/build-webkit:
433
434 2011-03-22  David Kilzer  <ddkilzer@apple.com>
435
436         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
437
438         Reviewed by Joseph Pecoraro.
439
440         * Scripts/build-webkit: Updated usage statement to include
441         --dsym.
442         * Scripts/webkitdirs.pm: Added $generateDsym variable.
443         (generateDsym): Added. Call determineGenerateDsym() and
444         return $generateDsym.
445         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
446         $generateDsym.
447         (argumentsForXcode): Added.  Returns additional arguments for
448         xcodebuild based on command-line switches.
449         (XcodeOptions): Updated to include argumentsForXcode() in the
450         array returned.
451
452 2011-03-22  Adam Roben  <aroben@apple.com>
453
454         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
455
456         These bots are consistently green again.
457
458         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
459         core builders
460
461         Rubber-stamped by Antti Koivisto.
462
463         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
464         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
465
466         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
467         (BuildBotTest.test_builder_name_regexps): Updated expectations.
468
469 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
470
471         Unreviewed, rolling out r81597.
472         http://trac.webkit.org/changeset/81597
473         https://bugs.webkit.org/show_bug.cgi?id=56801
474
475         Change results in lots of unexpected flaky on the dashboard.
476         (Requested by pfeldman on #webkit).
477
478         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
479         * Scripts/webkitpy/layout_tests/port/test.py:
480         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
481
482 2011-03-21  Sam Weinig  <sam@webkit.org>
483
484         Fix failing tests on the WebKit2 bots.
485
486         * WebKitTestRunner/TestController.cpp:
487         (WTR::TestController::resetStateToConsistentValues):
488
489 2011-03-21  Daniel Sievers  <sievers@google.com>
490
491         Reviewed by Simon Fraser.
492
493         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
494         https://bugs.webkit.org/show_bug.cgi?id=56139
495
496         * DumpRenderTree/chromium/DumpRenderTree.cpp:
497         (main):
498         * DumpRenderTree/chromium/LayoutTestController.cpp:
499         (LayoutTestController::LayoutTestController):
500         (LayoutTestController::layerTreeAsText):
501         * DumpRenderTree/chromium/LayoutTestController.h:
502         (LayoutTestController::setShowDebugLayerTree):
503         * DumpRenderTree/chromium/TestShell.cpp:
504         (TestShell::runFileTest):
505         (TestShell::dump):
506         * DumpRenderTree/chromium/TestShell.h:
507         (TestParams::TestParams):
508
509 2011-03-21  Adam Roben  <aroben@apple.com>
510
511         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
512
513         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
514         output as plain text
515
516         Reviewed by David Kilzer.
517
518         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
519         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
520         to the master.
521         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
522         since we're running on the build master, not the slave. Instead, turn the raw source of
523         actual.html which the build slave uploaded into an HTML log.
524
525 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
526
527         Reviewed by Mihai Parparita.
528
529         new-run-webkit-tests: run tests in ascending alphabetical order per dir
530         https://bugs.webkit.org/show_bug.cgi?id=56760
531
532         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
533         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
534         * Scripts/webkitpy/layout_tests/port/test.py:
535
536 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
537
538         Reviewed by Steve Block.
539
540         Media Stream API patch 0: adding compilation guards.
541         https://bugs.webkit.org/show_bug.cgi?id=56458
542
543         Adding options to enable the media stream API feature in Chromium.
544
545         * Scripts/build-webkit:
546
547 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
548
549         Reviewed by Laszlo Gombos.
550
551         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
552         https://bugs.webkit.org/show_bug.cgi?id=56323
553
554         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
555         "--stdout" or "--stderr" option.
556
557         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
558         (WebCore::DumpRenderTree::~DumpRenderTree):
559         (WebCore::DumpRenderTree::processArgsLine):
560         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
561         * DumpRenderTree/qt/DumpRenderTreeQt.h:
562         (WebCore::DumpRenderTree::setRedirectOutputFileName):
563         (WebCore::DumpRenderTree::setRedirectErrorFileName):
564         * DumpRenderTree/qt/main.cpp:
565         (isOption):
566         (takeOptionValue):
567         (printUsage):
568         (main):
569
570 2011-03-21  Adam Roben  <aroben@apple.com>
571
572         Fix exceptions on the buildbot due to my last change
573
574         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
575         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
576
577 2011-03-21  Adam Roben  <aroben@apple.com>
578
579         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
580
581         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
582         output as plain text
583
584         Reviewed by Darin Adler.
585
586         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
587         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
588         logs.
589         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
590         the build master. This will correctly treat it as HTML.
591
592 2011-03-20  Bill Budge  <bbudge@chromium.org>
593
594         Reviewed by Adam Barth.
595
596         Rename ThreadSafeShared to ThreadSafeRefCounted
597         https://bugs.webkit.org/show_bug.cgi?id=56714
598
599         No new tests. Exposes no new functionality.
600
601         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
602         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
603         * Scripts/do-webcore-rename:
604
605 2011-03-19  Anton D'Auria  <adauria@apple.com>
606
607         Reviewed by Dan Bernstein.
608
609         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
610         https://bugs.webkit.org/show_bug.cgi?id=56719
611
612         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
613         (LayoutTestController::clearApplicationCacheForOrigin):
614
615 2011-03-19  Anton D'Auria  <adauria@apple.com>
616
617         Reviewed by Alexey Proskuryakov.
618
619         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
620         https://bugs.webkit.org/show_bug.cgi?id=56415
621
622         * DumpRenderTree/LayoutTestController.cpp:
623         (clearApplicationCacheForOriginCallback):
624         (LayoutTestController::staticFunctions):
625         * DumpRenderTree/LayoutTestController.h:
626         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
627         (LayoutTestController::LayoutTestController):
628         (LayoutTestController::clearAllApplicationCaches):
629         (LayoutTestController::clearApplicationCacheForOrigin): 
630         * DumpRenderTree/chromium/LayoutTestController.h:
631         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
632         (LayoutTestController::clearApplicationCacheForOrigin):
633         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
634         (LayoutTestController::clearApplicationCacheForOrigin):
635         * DumpRenderTree/qt/LayoutTestControllerQt.h:
636         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
637         (LayoutTestController::clearApplicationCacheForOrigin):
638         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
639         (LayoutTestController::clearApplicationCacheForOrigin):
640
641 2011-03-18  Dan Bernstein  <mitz@apple.com>
642
643         Revised build fix for r81135.
644
645         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
646         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
647
648 2011-03-18  Adam Roben  <aroben@apple.com>
649
650         Windows build fix
651
652         * WebKitTestRunner/config.h: Add a missing #endif.
653
654 2011-03-18  Andreas Kling  <kling@webkit.org>
655
656         Unbreak Qt build after r81494.
657
658         * WebKitTestRunner/qt/TestInvocationQt.cpp:
659         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
660
661 2011-03-18  Sam Weinig  <sam@webkit.org>
662
663         Fix windows build. This was really Adam Roben's fault. I swear!
664
665         * WebKitTestRunner/config.h:
666
667 2011-03-18  Sam Weinig  <sam@webkit.org>
668
669         Reviewed by Adam Roben.
670
671         Pixel tests don't work in WebKitTestRunner on Windows
672         https://bugs.webkit.org/show_bug.cgi?id=56630
673
674         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
675         built-in snapshotting instead of using the window server on the Mac.
676
677         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
678         (WTR::InjectedBundle::InjectedBundle):
679         (WTR::InjectedBundle::didReceiveMessage):
680         (WTR::InjectedBundle::beginTesting):
681         (WTR::InjectedBundle::done):
682         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
683         (WTR::InjectedBundle::setPixelResult):
684         (WTR::InjectedBundle::shouldDumpPixels):
685         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
686         (WTR::InjectedBundlePage::dump):
687         Take the snapshot in the bundle and send it to the UIProcess for dumping.
688
689         * WebKitTestRunner/TestInvocation.cpp:
690         (WTR::TestInvocation::invoke):
691         (WTR::TestInvocation::dump):
692         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
693         * WebKitTestRunner/TestInvocation.h:
694         * WebKitTestRunner/cg: Added.
695         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
696         (WTR::createCGContextFromImage):
697         (WTR::computeMD5HashStringForContext):
698         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
699         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
700         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
701
702         * WebKitTestRunner/win/TestInvocationWin.cpp:
703         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
704         Keep stub for Cairo build.
705
706         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
707         Add CG configuration.
708
709         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
710         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
711         Add new files.
712
713 2011-03-18  Adam Roben  <aroben@apple.com>
714
715         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
716
717         Rubber-stamped by Simon Fraser.
718
719         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
720         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
721         overflow-y:overlay so that the scrollbar doesn't overlay the content.
722
723 2011-03-18  Adam Roben  <aroben@apple.com>
724
725         Don't ellipsize long or indented function names in Leaks Viewer
726
727         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
728         scrollbar
729
730         Reviewed by Simon Fraser.
731
732         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
733         (.data-grid .data-container):
734         (.data-grid td > div, .data-grid th > div):
735         Allow the contents to extend to the right.
736
737 2011-03-18  Adam Roben  <aroben@apple.com>
738
739         Fix some leaks in DRT seen on the leaks bot
740
741         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
742         setWillSendRequestClearHeaderCallback in DRT are leaky
743
744         Reviewed by Alexey Proskuryakov.
745
746         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
747
748         * DumpRenderTree/LayoutTestController.cpp:
749         (addURLToRedirectCallback):
750         (setWillSendRequestClearHeaderCallback):
751         Use OwnArrayPtr to cause the strings to be deleted.
752
753 2011-03-18  Adam Roben  <aroben@apple.com>
754
755         Fix a NSURLCredential leak seen on the leaks bot
756
757         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
758         connection:didReceiveAuthenticationChallenge:] is leaky
759
760         Reviewed by John Sullivan.
761
762         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
763         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
764         cause the NSURLCredential to be released.
765
766 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
767
768         Unreviewed.
769
770         Remove unnecessary brackets around my email address.
771
772         * Scripts/webkitpy/common/config/committers.py:
773
774 2011-03-18  Adam Roben  <aroben@apple.com>
775         
776         Remove some files I accidentally added in r81454
777
778         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
779         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
780
781 2011-03-18  Adam Roben  <aroben@apple.com>
782
783         Ignore an NSNumberFormatter leak on SnowLeopard
784
785         * Scripts/old-run-webkit-tests:
786         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
787         getObjectValue:forString:errorDescription:].
788
789 2011-03-18  Adam Roben  <aroben@apple.com>
790
791         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
792
793         Rubber-stamped by Mark Rowe.
794
795         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
796         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
797         released.
798
799 2011-03-17  Adam Roben  <aroben@apple.com>
800
801         Address a review comment I missed in r81445
802
803         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
804         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
805         leaked bytes to speed up searching on long lines.
806
807 2011-03-17  Adam Roben  <aroben@apple.com>
808
809         Mark leaky builds orange, even if all regression tests passed
810
811         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
812         build.webkit.org when all tests pass even though there are still leaks
813
814         Reviewed by Dan Bernstein.
815
816         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
817         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
818         be marked orange if this build step generates warnings.
819
820 2011-03-17  Adam Roben  <aroben@apple.com>
821
822         Allow values in Leaks Viewer to be shown as percentages
823
824         Double-clicking on a column will toggle between showing percentages and showing real values.
825
826         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
827         number of leaked bytes in Leaks Viewer
828
829         Reviewed by Joe Pecoraro.
830
831         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
832         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
833         node's totalTime, which is used in calculating percentages.
834
835         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
836         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
837         showing them as percentages.
838
839 2011-03-17  Adam Roben  <aroben@apple.com>
840
841         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
842
843         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
844         the number of leaked allocations. And the new Average column shows the average number of
845         leaked bytes per call.
846
847         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
848         just how many allocations
849
850         Reviewed by Joe Pecoraro.
851
852         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
853         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
854         line and store it with the leak stack.
855         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
856         properties.
857         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
858         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
859         .numberOfCalls now holds the number of leaked allocations.
860
861         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
862         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
863         appear.
864         (monkeyPatchInspectorObjects): Format the values as bytes.
865
866 2011-03-17  Adam Roben  <aroben@apple.com>
867
868         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
869
870         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
871         regression tests
872
873         Reviewed by James Robinson.
874
875         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
876         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
877         is always populated, even when all regression tests pass.
878
879 2011-03-10  Hayato Ito  <hayato@chromium.org>
880
881         Reviewed by Tony Chang.
882
883         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
884
885         https://bugs.webkit.org/show_bug.cgi?id=56076
886
887         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
888
889 2011-03-17  Adam Roben  <aroben@apple.com>
890
891         Skip a compositing-sensitive test when accelerated compositing is disabled
892
893         Reviewed by Sam Weinig.
894
895         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
896         accelerated compositing is disabled.
897
898 2011-03-17  Adam Roben  <aroben@apple.com>
899
900         Start using PlatformSpecificScheduler for the Mac builders
901
902         The current set of file/directory patterns should work for Mac builders. We may discover
903         that there are more files and directories we can exclude from the Mac builds, but they can
904         be added later.
905
906         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
907
908         Reviewed by Mark Rowe.
909
910         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
911         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
912
913         * Scripts/webkitpy/common/config/build.py:
914         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
915         cleaned up patterns a little bit.
916
917         * Scripts/webkitpy/common/config/build_unittest.py:
918         (ShouldBuildTest): Fixed some expected results.
919         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
920         platforms.
921
922 2011-03-17  Jeff Miller  <jeffm@apple.com>
923
924         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
925         
926         *.mode*
927         *.pbxuser
928         *.perspective*
929         project.xcworkspace
930         xcuserdata
931
932         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
933         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
934         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
935         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
936         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
937
938 2011-03-17  Adam Roben  <aroben@apple.com>
939
940         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
941
942         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
943         mac-wk2
944
945         Reviewed by Anders Carlsson.
946
947         * Scripts/old-run-webkit-tests:
948         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
949         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
950         we're running in WebKit2 mode.
951
952 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
953
954         Reviewed by Yury Semikhatsky.
955
956         Web Inspector: Clean up Inspector strings.
957         https://bugs.webkit.org/show_bug.cgi?id=56557
958
959         Modify the script to deal correctly with "\xNN" escapes, and to
960         check strings in Chromium's DevTools.js.
961
962         * Scripts/check-inspector-strings:
963
964 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
965
966         Reviewed by Benjamin Poulain.
967
968         Update autoinstall to install mechanize 0.2.4
969         https://bugs.webkit.org/show_bug.cgi?id=56499
970
971         Newer versions of mechanize support HTTPS proxies, which is necessary
972         for people using webkit-patch behind firewalls.
973
974         * Scripts/webkitpy/common/system/autoinstall.py:
975         * Scripts/webkitpy/thirdparty/__init__.py:
976
977 2011-03-16  Sam Weinig  <sam@webkit.org>
978
979         Reviewed by Adam Roben.
980
981         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
982         https://bugs.webkit.org/show_bug.cgi?id=56541
983
984         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
985         (WTR::InjectedBundlePage::willSendRequestForFrame):
986         Check for an empty host in addition to a null host.  This bug was introduced
987         when porting off of the KURL code and onto the WKURLRef version.
988
989 2011-03-16  Sam Weinig  <sam@webkit.org>
990
991         Reviewed by Adam Roben.
992
993         Add Lucas Forschler to the list of WebKit committers.
994
995         * Scripts/webkitpy/common/config/committers.py:
996
997 2011-03-16  Sam Weinig  <sam@webkit.org>
998
999         Reviewed upon and dictated through Adam Roben.
1000
1001         Escape crashing function names in results.html. This fixes an issue
1002         when a crash involves a type with templates.
1003
1004         * Scripts/old-run-webkit-tests:
1005
1006 2011-03-16  Daniel Sievers  <sievers@google.com>
1007
1008         Reviewed by James Robinson.
1009
1010         Add setting to always force compositing mode
1011         https://bugs.webkit.org/show_bug.cgi?id=56156
1012
1013         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1014         (main):
1015         * DumpRenderTree/chromium/TestShell.cpp:
1016         (TestShell::TestShell):
1017         (TestShell::resetWebSettings):
1018         * DumpRenderTree/chromium/TestShell.h:
1019         (TestShell::setForceCompositingMode):
1020         * DumpRenderTree/chromium/WebPreferences.cpp:
1021         (WebPreferences::reset):
1022         (WebPreferences::applyTo):
1023         * DumpRenderTree/chromium/WebPreferences.h:
1024
1025 2011-03-15  Hayato Ito  <hayato@chromium.org>
1026
1027         Reviewed by Ojan Vafai.
1028
1029         Ignore files that will be used by reftests in old-run-webkit-tests.
1030
1031         https://bugs.webkit.org/show_bug.cgi?id=55936
1032
1033         * Scripts/old-run-webkit-tests:
1034
1035 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
1036
1037         Reviewed by Adam Roben.
1038
1039         Function relativeScriptsDir doesn't return the correct relative
1040         Scripts directory.
1041
1042         * Scripts/webkitdirs.pm:
1043         (relativeScriptsDir): Ensure we use the directory that contains
1044         webkitdirs.pm, not the one that contains the original script that
1045         was invoked.
1046
1047 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1048
1049         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
1050         fix to link against the Security framework after recent WebKitSystemInterface changes.
1051
1052         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1053         (LayoutTestController::originsWithLocalStorage):
1054         * wx/build/settings.py:
1055         * wx/build/waf_extensions.py:
1056
1057 2011-03-15  Sam Weinig  <sam@webkit.org>
1058
1059         Reviewed by Darin Adler.
1060
1061         Add script to convert a patch to a prettypatch and show in the default browser
1062         https://bugs.webkit.org/show_bug.cgi?id=56416
1063
1064         This can be used either like
1065             $ svn-create-patch | show-pretty-diff
1066         or
1067             $ show-pretty-diff patch.diff
1068
1069         * Scripts/show-pretty-diff: Added.
1070
1071 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
1072
1073         Rubber-stamped by Adam Roben.
1074
1075         Adding myself as a reviewer.
1076
1077         * Scripts/webkitpy/common/config/committers.py:
1078
1079 2011-03-15  Anders Carlsson  <andersca@apple.com>
1080
1081         Try to fix the Windows build.
1082
1083         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1084         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1085
1086 2011-03-15  Anders Carlsson  <andersca@apple.com>
1087
1088         Reviewed by Sam Weinig.
1089
1090         Make sure that NP_Shutdown is always the last NPP function called
1091         https://bugs.webkit.org/show_bug.cgi?id=56391
1092
1093         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
1094
1095         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1096         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1097         (PluginTest::PluginTest):
1098         (PluginTest::NP_Shutdown):
1099         (PluginTest::registerNPShutdownFunction):
1100         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1101         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
1102         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
1103         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1104         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
1105         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
1106         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
1107         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
1108         (NPDeallocateCalledBeforeNPShutdown::shutdown):
1109         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1110         (NP_Shutdown):
1111         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1112         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1113         * GNUmakefile.am:
1114
1115 2011-03-15  Ilya Sherman  <isherman@chromium.org>
1116
1117         Reviewed by Tony Chang.
1118
1119         Autofilled form elements are assigned fixed background color but not text color
1120         https://bugs.webkit.org/show_bug.cgi?id=48382
1121
1122         * DumpRenderTree/LayoutTestController.cpp:
1123         (setAutofilledCallback): Added.
1124         (LayoutTestController::staticFunctions):
1125         * DumpRenderTree/LayoutTestController.h:
1126         * DumpRenderTree/chromium/LayoutTestController.cpp:
1127         (LayoutTestController::LayoutTestController):
1128         (LayoutTestController::setAutofilled): Added.
1129         * DumpRenderTree/chromium/LayoutTestController.h:
1130         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1131         (LayoutTestController::setAutofilled): Added.
1132         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1133         (LayoutTestController::setAutofilled): Added.
1134         (LayoutTestController::setValueForUser): Style tweak.
1135         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1136         (LayoutTestController::setAutofilled): Added (stub).
1137         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1138         (LayoutTestController::setAutofilled): Added (stub).
1139
1140 2011-03-15  Dan Bernstein  <mitz@apple.com>
1141
1142         Build fix after r81135.
1143
1144         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1145
1146 2011-03-15  Dan Bernstein  <mitz@apple.com>
1147
1148         Build fix after r81135.
1149
1150         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1151         * WebKitTestRunner/mac/TestControllerMac.mm:
1152         * WebKitTestRunner/mac/TestInvocationMac.mm:
1153         * WebKitTestRunner/mac/main.mm:
1154
1155 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
1156
1157         Reviewed by Adam Barth.
1158
1159         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
1160         https://bugs.webkit.org/show_bug.cgi?id=56349
1161
1162         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
1163         on platforms where we use it. Copied from DumpRenderTree.pro.
1164
1165 2011-03-15  Dan Bernstein  <mitz@apple.com>
1166
1167         Build fix after r81135.
1168
1169         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1170         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
1171
1172 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1173
1174         Reviewed by Darin Adler.
1175
1176         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
1177         info into the headers rather than in export symbol definition files, but disable it on 
1178         all platforms initially so we can deal with port build issues one port at a time.
1179         
1180         https://bugs.webkit.org/show_bug.cgi?id=27551
1181
1182         * DumpRenderTree/cg/ImageDiffCG.cpp:
1183         * DumpRenderTree/chromium/config.h:
1184         * DumpRenderTree/config.h:
1185         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1186         * TestWebKitAPI/TestWebKitAPIPrefix.h:
1187         * WebKitAPITest/HostWindow.cpp:
1188         * WebKitAPITest/TestsController.cpp:
1189         * WebKitAPITest/config.h: Added.
1190         * WebKitAPITest/main.cpp:
1191         * WebKitAPITest/tests/WebViewDestruction.cpp:
1192         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
1193         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1194         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1195         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1196         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1197         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1198         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1199         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1200         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1201         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1202         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
1203         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
1204         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1205         * WebKitTestRunner/TestController.cpp:
1206         * WebKitTestRunner/TestInvocation.cpp:
1207         * WebKitTestRunner/config.h: Added.
1208         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1209         * WebKitTestRunner/qt/TestControllerQt.cpp:
1210         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1211         * WebKitTestRunner/qt/main.cpp:
1212         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1213         * WebKitTestRunner/win/TestControllerWin.cpp:
1214         * WebKitTestRunner/win/TestInvocationWin.cpp:
1215         * WebKitTestRunner/win/main.cpp:
1216         * wx/build/settings.py:
1217
1218 2011-03-15  Hayato Ito  <hayato@chromium.org>
1219
1220         Reviewed by Shinichiro Hamaji.
1221
1222         [NRWT] Add support for reftests to new-run-webkit-tests.
1223
1224         https://bugs.webkit.org/show_bug.cgi?id=55457
1225
1226         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1227         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1228         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1229         * Scripts/webkitpy/layout_tests/port/base.py:
1230         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1231         * Scripts/webkitpy/layout_tests/port/test.py:
1232         * Scripts/webkitpy/layout_tests/port/test_files.py:
1233         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1234
1235 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
1236
1237         Reviewed by Martin Robinson.
1238
1239         [GTK] Fix compilation warning after r80892
1240         https://bugs.webkit.org/show_bug.cgi?id=56302
1241
1242         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1243         (LayoutTestController::originsWithLocalStorage):
1244
1245 2011-03-15  Robert Hogan  <robert@webkit.org>
1246
1247         Reviewed by Adam Barth.
1248
1249         Document the qmakearg argument, and hint how to build webkit2 on Qt
1250         https://bugs.webkit.org/show_bug.cgi?id=56326
1251
1252         * Scripts/build-webkit: add --qmakearg to build-webkit --help
1253
1254 2011-03-15  Adam Roben  <aroben@apple.com>
1255
1256         Make Windows 7 Release (Tests) a core builder
1257
1258         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
1259         give it a few more days of greenness first.
1260
1261         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
1262
1263         Reviewed by Sam Weinig.
1264
1265         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1266         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
1267
1268         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1269         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
1270         Updated the core regexps to match the buildbot module. Updated the expected results to match
1271         the current set of core builders.
1272
1273 2011-03-14  Adam Roben  <aroben@apple.com>
1274
1275         Add forgotten file from r81116
1276
1277         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
1278
1279 2011-03-14  Sam Weinig  <sam@webkit.org>
1280
1281         Reviewed by Adam Roben.
1282
1283         about:blank fake responses don't get serialized when sent the UIProcess
1284         <rdar://problem/9108119>
1285         https://bugs.webkit.org/show_bug.cgi?id=56357
1286
1287         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
1288         (TestWebKitAPI::decidePolicyForResponse):
1289         (TestWebKitAPI::TEST):
1290         Add test that loads of about:blank have a response with a MIMEType of text/html.
1291
1292         * TestWebKitAPI/PlatformUtilities.h:
1293         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1294         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1295         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1296         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1297         Add helper to get the MIMEType from a WKURLResponse.
1298
1299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1300         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1301         Add new files.
1302
1303 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
1304
1305         Reviewed by Kenneth Rohde Christiansen.
1306
1307         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
1308         https://bugs.webkit.org/show_bug.cgi?id=56006
1309
1310         * QtTestBrowser/launcherwindow.cpp:
1311         (LauncherWindow::initializeView):
1312         * QtTestBrowser/main.cpp:
1313         (LauncherApplication::handleUserOptions):
1314
1315 2011-03-14  James Kozianski  <koz@chromium.org>
1316
1317         Reviewed by Ojan Vafai.
1318
1319         Add method to make BuildBot return test outputs
1320         https://bugs.webkit.org/show_bug.cgi?id=54374
1321
1322         The Builder.latest_cached_build will be used by the new rebaseline
1323         script to determine the build to use baselines from.
1324
1325         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1326         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1327
1328 2011-03-14  Adam Roben  <aroben@apple.com>
1329
1330         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
1331
1332         Reviewed by Sam Weinig.
1333
1334         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
1335         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
1336         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
1337         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
1338         ensure the web process is initialized, then ask the bundle to run the test and assert that
1339         it succeeded.
1340
1341         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
1342         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
1343         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
1344         handle a given URL.
1345         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
1346         URL type cannot be handled).
1347         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
1348         result.
1349
1350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1351         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1352         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1353         Added new files to the project.
1354
1355 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1356
1357         Unreviewed, rolling out r81094.
1358         http://trac.webkit.org/changeset/81094
1359         https://bugs.webkit.org/show_bug.cgi?id=56355
1360
1361         Broke the chromium DRT related build. (Requested by dave_levin
1362         on #webkit).
1363
1364         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1365         (main):
1366         * DumpRenderTree/chromium/LayoutTestController.cpp:
1367         (LayoutTestController::LayoutTestController):
1368         (LayoutTestController::layerTreeAsText):
1369         * DumpRenderTree/chromium/LayoutTestController.h:
1370         * DumpRenderTree/chromium/TestShell.cpp:
1371         (TestShell::runFileTest):
1372         (TestShell::dump):
1373         * DumpRenderTree/chromium/TestShell.h:
1374         (TestParams::TestParams):
1375
1376 2011-03-14  Daniel Sievers  <sievers@google.com>
1377
1378         Reviewed by Simon Fraser.
1379
1380         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1381         https://bugs.webkit.org/show_bug.cgi?id=56139
1382
1383         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1384         (main):
1385         * DumpRenderTree/chromium/LayoutTestController.cpp:
1386         (LayoutTestController::LayoutTestController):
1387         (LayoutTestController::layerTreeAsText):
1388         * DumpRenderTree/chromium/LayoutTestController.h:
1389         (LayoutTestController::setShowDebugLayerTree):
1390         * DumpRenderTree/chromium/TestShell.cpp:
1391         (TestShell::runFileTest):
1392         (TestShell::dump):
1393         * DumpRenderTree/chromium/TestShell.h:
1394         (TestParams::TestParams):
1395
1396 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
1397
1398         Reviewed by Adam Roben.
1399
1400         [Qt][WK2]Unbreak InjectedBundle on Qt
1401         https://bugs.webkit.org/show_bug.cgi?id=54109
1402
1403         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1404         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
1405         API's instead of KURL to analyze the URL.
1406         * WebKitTestRunner/StringFunctions.h:
1407         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
1408         in the WebKitTestRunner project.
1409         (WTR::toWK): Use adoptWK.
1410         (WTR::operator<<): Added helper for printing a WKURL.
1411         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
1412         against WebCore.
1413
1414 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
1415
1416         Reviewed by Kenneth Rohde Christiansen.
1417
1418         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
1419         https://bugs.webkit.org/show_bug.cgi?id=56321
1420
1421         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
1422         to the list of exceptions for WebKit2 C API headers.
1423
1424 2011-03-14  Adam Roben  <aroben@apple.com>
1425
1426         Show the list of recent leaky builds in reverse chronological order
1427
1428         Previously they were being shown in a deterministic but surprising order based on
1429         lexicographically sorting the build offsets (-1, -10, -2, -3...).
1430
1431         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
1432
1433         Reviewed by Darin Adler.
1434
1435         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1436         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
1437         callback.
1438
1439 2011-03-14  Adam Roben  <aroben@apple.com>
1440
1441         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
1442
1443         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
1444         analyze
1445
1446         Reviewed by David Kilzer and Joe Pecoraro.
1447
1448         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1449         (#url-prompt): Made this a bit taller to make room for the list of builds.
1450
1451         (#recent-builds-loading-indicator):
1452         (#recent-builds-list):
1453         Added styles for the build list and loading indicator.
1454
1455         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1456         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
1457         it. This will unescape it.
1458         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
1459         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
1460         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
1461         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
1462         prompt UI.
1463         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
1464         now also used when a recent build is clicked.
1465
1466         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
1467         (RecentBuildsLoader): Store the callback.
1468         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
1469         builder. Find the revision number, leak count, and results URL for each one. Pass the
1470         resulting info to our callback.
1471
1472         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
1473         (range): Added this helper function to return an array containing the integers [0, n).
1474
1475         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
1476         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
1477
1478 2011-03-14  Mark Rowe  <mrowe@apple.com>
1479
1480         Reviewed by Adam Roben.
1481
1482         Fix two memory leaks within LayoutTestController's storage support.
1483
1484         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1485         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
1486         by JSStringCreateWithCFString.
1487         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
1488         allocate.
1489
1490 2011-03-14  Mark Rowe  <mrowe@apple.com>
1491
1492         Reviewed by Oliver Hunt.
1493
1494         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
1495
1496         * DumpRenderTree/LayoutTestController.cpp:
1497         (LayoutTestController::staticFunctions): Remove duplicate entries.
1498
1499 2011-03-14  Alice Liu  <alice.liu@apple.com>
1500
1501         Reviewed by Dan Bernstein.
1502
1503         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
1504
1505         * DumpRenderTree/mac/PerlSupport/Makefile:
1506         Add whitespace when joining "-arch" with the architectures passed in as arguments.
1507
1508 2011-03-14  Daniel Bates  <dbates@rim.com>
1509
1510         https://bugs.webkit.org/show_bug.cgi?id=55438
1511         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
1512         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
1513
1514         * Scripts/build-webkit:
1515
1516 2011-03-14  Daniel Bates  <dbates@rim.com>
1517
1518         Reviewed by David Kilzer.
1519
1520         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
1521         https://bugs.webkit.org/show_bug.cgi?id=55438
1522
1523         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
1524         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
1525         CMake arguments for feature defines.
1526
1527         * Scripts/build-webkit:
1528           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
1529           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
1530           - Sorted forward declarations.
1531           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
1532             Modified call sites as needed.
1533         * Scripts/webkitdirs.pm:
1534           - Added cleanCMakeGeneratedProject() to clean a CMake build.
1535           - Added buildCMakeGeneratedProject() to build using generated build system.
1536           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
1537           - Added generateBuildSystemFromCMakeProject() to generate the build system from
1538             a CMake project.
1539           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
1540
1541 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
1542
1543         Reviewed by Steve Block.
1544
1545         Detach Geolocation from Frame when Page destroyed.
1546         https://bugs.webkit.org/show_bug.cgi?id=52877
1547
1548         Extend the layout test controller to expose the number of pending
1549         geolocation requests, so that we can test that the requests have
1550         been cancelled on page close.
1551
1552         * DumpRenderTree/LayoutTestController.cpp:
1553         (numberOfPendingGeolocationPermissionRequestsCallback):
1554         (LayoutTestController::staticFunctions):
1555         * DumpRenderTree/LayoutTestController.h:
1556         * DumpRenderTree/chromium/LayoutTestController.cpp:
1557         (LayoutTestController::LayoutTestController):
1558         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1559         * DumpRenderTree/chromium/LayoutTestController.h:
1560         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1561         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1562         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1563         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1564         * DumpRenderTree/mac/UIDelegate.h:
1565         * DumpRenderTree/mac/UIDelegate.mm:
1566         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1567         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1568         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1569         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1570         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1571         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1572         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1573         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1574
1575
1576 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1577
1578         Unreviewed. Modify my email address in committers.py.
1579
1580         * Scripts/webkitpy/common/config/committers.py:
1581
1582 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
1583
1584         Reviewed by Kenneth Rohde Christiansen.
1585
1586         [Qt] QtLauncher does not load the same set of fonts as the DRT
1587         https://bugs.webkit.org/show_bug.cgi?id=34959
1588
1589         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
1590         When this option is used the webkit fonts are loaded the same
1591         as they are in DumpRenderTree.  This option can be used on
1592         QtTestBrowser and run-launcher.  It can only be used
1593         on Linux systems with FcInit and is configured as such.
1594
1595         * QtTestBrowser/launcherwindow.h:
1596         (WindowOptions::WindowOptions):
1597         * QtTestBrowser/main.cpp:
1598         (initWebKitTestFonts):
1599         (launcherMain):
1600         (LauncherApplication::handleUserOptions):
1601
1602 2011-03-12  Dan Bernstein  <mitz@apple.com>
1603
1604         Reviewed by Mark Rowe.
1605
1606         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
1607         DumpRenderTree is being built for.
1608
1609         * DumpRenderTree/mac/PerlSupport/Makefile:
1610
1611 2011-03-12  Dan Bernstein  <mitz@apple.com>
1612
1613         Suggested by Mark Rowe.
1614
1615         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
1616         as they were before r80915.
1617
1618 2011-03-12  Anders Carlsson  <andersca@apple.com>
1619
1620         Reviewed by Sam Weinig.
1621
1622         Should be able to download a PDF to the Downloads folder
1623         https://bugs.webkit.org/show_bug.cgi?id=56256
1624
1625         * MiniBrowser/mac/BrowserWindowController.m:
1626         (-[BrowserWindowController awakeFromNib]):
1627         * WebKitTestRunner/TestController.cpp:
1628         (WTR::TestController::createOtherPage):
1629         (WTR::TestController::initialize):
1630         Update for API changes.
1631
1632 2011-03-11  Anton D'Auria  <adauria@apple.com>
1633
1634         Reviewed and landed by Brady Eidson.
1635
1636         https://bugs.webkit.org/show_bug.cgi?id=51878
1637         Add WebKit1 API to view and delete local storage
1638
1639         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
1640
1641         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1642         * DumpRenderTree/LayoutTestController.cpp:
1643         (syncLocalStorageCallback):
1644         (observeStorageTrackerNotificationsCallback):
1645         (deleteAllLocalStorageCallback):
1646         (deleteLocalStorageForOriginCallback):
1647         (originsWithLocalStorageCallback):
1648         (LayoutTestController::staticFunctions):
1649         * DumpRenderTree/LayoutTestController.h:
1650         * DumpRenderTree/StorageTrackerDelegate.h: Added.
1651         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
1652         (-[StorageTrackerDelegate init]):
1653         (-[StorageTrackerDelegate logNotifications:controller:]):
1654         (-[StorageTrackerDelegate originModified:]):
1655         (-[StorageTrackerDelegate dealloc]):
1656         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
1657         * DumpRenderTree/chromium/LayoutTestController.cpp:
1658         (LayoutTestController::LayoutTestController):
1659         (LayoutTestController::deleteAllLocalStorage):
1660         (LayoutTestController::originsWithLocalStorage):
1661         (LayoutTestController::deleteLocalStorageForOrigin):
1662         (observeStorageTrackerNotifications):
1663         (syncLocalStorage):
1664         * DumpRenderTree/chromium/LayoutTestController.h:
1665         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1666         (LayoutTestController::originsWithLocalStorage):
1667         (LayoutTestController::deleteAllLocalStorage):
1668         (LayoutTestController::deleteLocalStorageForOrigin):
1669         (LayoutTestController::observeStorageTrackerNotifications):
1670         (LayoutTestController::syncLocalStorage):
1671         * DumpRenderTree/mac/DumpRenderTree.mm:
1672         (resetDefaultsToConsistentValues):
1673         (allocateGlobalControllers):
1674         (releaseGlobalControllers):
1675         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1676         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1677         (LayoutTestController::syncLocalStorage):
1678         (LayoutTestController::observeStorageTrackerNotifications):
1679         (LayoutTestController::deleteAllLocalStorage):
1680         (LayoutTestController::originsWithLocalStorage):
1681         (LayoutTestController::deleteLocalStorageForOrigin):
1682         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1683         (LayoutTestController::originsWithLocalStorage):
1684         (LayoutTestController::deleteAllLocalStorage):
1685         (LayoutTestController::deleteLocalStorageForOrigin):
1686         (LayoutTestController::observeStorageTrackerNotifications):
1687         (LayoutTestController::syncLocalStorage):
1688         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1689         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1690         (LayoutTestController::clearAllApplicationCaches):
1691         (LayoutTestController::syncLocalStorage):
1692         (LayoutTestController::observeStorageTrackerNotifications):
1693         (LayoutTestController::clearAllDatabases):
1694         (LayoutTestController::deleteAllLocalStorage):
1695         (LayoutTestController::originsWithLocalStorage):
1696         (LayoutTestController::deleteLocalStorageForOrigin):
1697         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1698         (LayoutTestController::syncLocalStorage):
1699         (LayoutTestController::observeStorageTrackerNotifications):
1700         (LayoutTestController::clearAllDatabases):
1701         (LayoutTestController::deleteAllLocalStorage):
1702         (LayoutTestController::originsWithLocalStorage):
1703         (LayoutTestController::deleteLocalStorageForOrigin):
1704
1705 2011-03-11  Jessie Berlin  <jberlin@apple.com>
1706
1707         Reviewed by Adam Roben.
1708
1709         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
1710         Process has finished launching.
1711         https://bugs.webkit.org/show_bug.cgi?id=56208
1712
1713         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
1714         (TestWebKitAPI::TEST):
1715         Test that calling WKContextClearResourceCaches works with both options when called before
1716         the Web Process is valid.
1717
1718         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1719         Add the new test.
1720         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1721         Ditto.
1722
1723 2011-03-11  Adam Roben  <aroben@apple.com>
1724
1725         Make it possible to view all leaks from a build at once in Leaks Viewer
1726
1727         You can now give Leaks Viewer the URL of a build results page (e.g.,
1728         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
1729         will load all the leaks files from that build.
1730
1731         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
1732         files from a particular build at once, rather than one at a time
1733
1734         Reviewed by David Kilzer.
1735
1736         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
1737         (LeaksLoader): Initialize our properties.
1738         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
1739         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
1740         from that page.
1741         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
1742         so it can provide feedback. Then load each one and pass it to the client.
1743         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
1744         it into a DOM, pull out all the links to leaks files, and load each one.
1745
1746         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
1747         (LeaksParser): Initialize our worker.
1748         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
1749
1750         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
1751         This code mostly came from Worker.js.
1752         (LeaksParserWorker): Initialize our profile.
1753         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
1754         profile.
1755         (LeaksParserWorker.prototype._parseLeaks):
1756         (LeaksParserWorker.prototype._createNode):
1757         (LeaksParserWorker.prototype._incorporateLeaks):
1758         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
1759         version of createProfile which adds to this.profile instead of making a new profile each
1760         time.
1761         (onmessage): Parse the file and send back the new profile.
1762
1763         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1764         (#loading-indicator):
1765         (#spinner):
1766         (#loading-indicator-label):
1767         Tweaked styles to accomodate a longer label.
1768
1769         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1770         (LeaksViewer.loaded): Set up a loader and parser.
1771
1772         (LeaksViewer.get filesLeftToParse):
1773         (LeaksViewer.set filesLeftToParse):
1774         Added these simple accessors.
1775
1776         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
1777         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
1778         the parser.
1779         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
1780         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
1781         _loadLeaksFromURL function).
1782         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
1783         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
1784         loading indicator, including the number of files being loaded.
1785         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
1786         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
1787         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
1788         _loadingIndicatorText.
1789
1790         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
1791         (getResource): Moved here from LeaksViewer.js.
1792
1793         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
1794         LeaksParserWorker.js.
1795
1796         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
1797         files, added a #loading-indicator-label element, and tweaked the prompt wording.
1798
1799 2011-03-11  Adam Roben  <aroben@apple.com>
1800
1801         Don't trigger a build when build.webkit.org's HTML files are modified
1802
1803         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
1804
1805         Reviewed by Dan Bernstein.
1806
1807         * Scripts/webkitpy/common/config/build.py:
1808         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
1809         directories that shouldn't trigger builds. Re-sorted the list.
1810
1811         * Scripts/webkitpy/common/config/build_unittest.py:
1812         (ShouldBuildTest): Added a test to cover the above change.
1813
1814 2011-03-11  Adam Roben  <aroben@apple.com>
1815
1816         Roll out r80848
1817
1818         It was accidentally committed.
1819
1820         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1821         (LeaksViewer._loadLeaksFromURL):
1822
1823 2011-03-11  Tony Chang  <tony@chromium.org>
1824
1825         Reviewed by Ojan Vafai.
1826
1827         kill hung lighttpd processes on the chromium win bot
1828         https://bugs.webkit.org/show_bug.cgi?id=56152
1829
1830         Sometimes this process doesn't exit and it holds on to
1831         a log file that we can't delete or copy, causing the tests
1832         to go red.
1833
1834         * BuildSlaveSupport/win/kill-old-processes:
1835
1836 2011-03-11  Ilya Sherman  <isherman@chromium.org>
1837
1838         Reviewed by Kent Tamura.
1839
1840         [Chromium] missing HTMLInputElement::setValueForUser() to tests
1841         https://bugs.webkit.org/show_bug.cgi?id=55854
1842
1843         * DumpRenderTree/chromium/LayoutTestController.cpp:
1844         (LayoutTestController::LayoutTestController):
1845         (LayoutTestController::setValueForUser): Added.
1846         * DumpRenderTree/chromium/LayoutTestController.h:
1847
1848 2011-03-10  Peter Kasting  <pkasting@google.com>
1849
1850         Reviewed by Dimitri Glazkov.
1851
1852         Clean up some gross code in TestShellWin.cpp.  No functional change.
1853         https://bugs.webkit.org/show_bug.cgi?id=56048
1854
1855         * DumpRenderTree/chromium/TestShellWin.cpp:
1856         (checkLayoutTestSystemDependencies):
1857
1858 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
1859
1860         Reviewed by Laszlo Gombos.
1861
1862         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
1863
1864         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1865         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
1866
1867 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1868
1869         Reviewed by Kenneth Rohde Christiansen.
1870
1871         [EFL] Make single backing store the default for EWebLauncher
1872         https://bugs.webkit.org/show_bug.cgi?id=55753
1873
1874         Set single backing store the default for EWebLauncher.
1875
1876         * EWebLauncher/main.c:
1877         (main):
1878
1879 2011-03-10  Adam Roben  <aroben@apple.com>
1880
1881         Ignore errors from files being held open when creating a test result archive
1882
1883         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
1884         fails to delete the results directory
1885
1886         Reviewed by Mark Rowe.
1887
1888         * BuildSlaveSupport/test-result-archive:
1889         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
1890         thrown when a process is holding a file open.
1891
1892 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1893
1894         Unreviewed, rolling out r80701.
1895         http://trac.webkit.org/changeset/80701
1896         https://bugs.webkit.org/show_bug.cgi?id=56126
1897
1898         fast/dom/Geolocation/window-close-crash.html fails on Snow
1899         Leopard release builds (Requested by mihaip on #webkit).
1900
1901         * DumpRenderTree/LayoutTestController.cpp:
1902         (LayoutTestController::staticFunctions):
1903         * DumpRenderTree/LayoutTestController.h:
1904         * DumpRenderTree/chromium/LayoutTestController.cpp:
1905         (LayoutTestController::LayoutTestController):
1906         * DumpRenderTree/chromium/LayoutTestController.h:
1907         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1908         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1909         * DumpRenderTree/mac/UIDelegate.h:
1910         * DumpRenderTree/mac/UIDelegate.mm:
1911         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1912         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1913         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1914         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1915
1916 2011-03-10  Philippe Normand  <pnormand@igalia.com>
1917
1918         Reviewed by Gustavo Noronha Silva.
1919
1920         [GTK] run-gtk-tests doesn't fail if a test crashes
1921         https://bugs.webkit.org/show_bug.cgi?id=56089
1922
1923         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
1924         even if a test crashes. So run the tests individually and if a
1925         test fails remember its exit code so run-gtk-test fails too, if
1926         required.
1927
1928 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
1929
1930         Reviewed by Dmitry Titov.
1931
1932         Detach Geolocation from Frame when Page destroyed.
1933         https://bugs.webkit.org/show_bug.cgi?id=52877
1934
1935         Extend the layout test controller to expose the number of pending
1936         geolocation requests, so that we can test that the requests have
1937         been cancelled on page close.
1938
1939         * DumpRenderTree/LayoutTestController.cpp:
1940         (numberOfPendingGeolocationPermissionRequestsCallback):
1941         (LayoutTestController::staticFunctions):
1942         * DumpRenderTree/LayoutTestController.h:
1943         * DumpRenderTree/chromium/LayoutTestController.cpp:
1944         (LayoutTestController::LayoutTestController):
1945         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1946         * DumpRenderTree/chromium/LayoutTestController.h:
1947         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1948         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1949         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1950         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1951         * DumpRenderTree/mac/UIDelegate.h:
1952         * DumpRenderTree/mac/UIDelegate.mm:
1953         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1954         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1955         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1956         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1957         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1958         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1959         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1960         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1961
1962
1963 2011-03-09  Adam Roben  <aroben@apple.com>
1964
1965         Hide Leaks Viewer's URL prompt by default
1966
1967         We will show it as needed. I think I left it visible by default by accident after doing some
1968         testing.
1969
1970         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
1971         URL is passed as a query parameter, but does
1972
1973         Reviewed by Simon Fraser.
1974
1975         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
1976
1977 2011-03-09  Adam Roben  <aroben@apple.com>
1978
1979         Don't use Element.classList or box-shadow in Leaks Viewer
1980
1981         They aren't supported by Safari 5. Luckily we have substitutes for them!
1982
1983         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
1984
1985         Reviewed by Simon Fraser.
1986
1987         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1988         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
1989
1990         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1991         (LeaksViewer.urlPromptButtonClicked):
1992         (LeaksViewer._displayURLPrompt):
1993         (LeaksViewer._setLoadingIndicatorHidden):
1994         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
1995
1996 2011-03-09  Adam Roben  <aroben@apple.com>
1997
1998         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
1999
2000         Rubber-stamped by David Kilzer.
2001
2002         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2003
2004 2011-03-09  Adam Roben  <aroben@apple.com>
2005
2006         Add a Leaks Viewer tool to build.webkit.org
2007
2008         This tool parses leaks from the files generated by the leaks bot and displays them in a
2009         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
2010         code).
2011
2012         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
2013         be passed to the tool via the "url" query parameter.
2014
2015         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
2016         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
2017         Inspector's Heavy profile view. But it's still pretty useful as-is.
2018
2019         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
2020
2021         Reviewed by Darin Adler.
2022
2023         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
2024         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
2025         (#url-prompt): This is the prompt itself.
2026
2027         (#loading-indicator):
2028         (#loading-indicator > img):
2029         These show a spinner in the bottom-right when we're loading a leaks file.
2030
2031         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
2032         as percentages.
2033
2034         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
2035         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
2036         URL if one wasn't given to us as a query parameter).
2037
2038         (LeaksViewer.get loading):
2039         (LeaksViewer.set loading):
2040         (LeaksViewer.get url):
2041         (LeaksViewer.set url):
2042         Pretty simple accessors.
2043
2044         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
2045         prompt.
2046         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
2047         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
2048         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
2049         the profile to the Web Inspector code once it's been created.
2050         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
2051         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
2052         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
2053         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
2054
2055         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
2056         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
2057         (ProfilerAgent.getProfile): Store the callback.
2058         (ProfilerAgent.profileReady): Call the callback.
2059         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
2060         count and total leak counts as real values, not percentages or milliseconds.
2061
2062         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
2063         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
2064         (parseLeaks): Extract call stacks out of a leaks file.
2065         (createNode): Helper function to create a new empty profile node.
2066         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
2067         WebInspector.ProfileView.
2068
2069         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
2070
2071 2011-03-09  Dan Bernstein  <mitz@apple.com>
2072
2073         Reviewed by Adam Roben.
2074
2075         Combine multiple --ignore-tests values
2076         https://bugs.webkit.org/show_bug.cgi?id=56016
2077
2078         * Scripts/old-run-webkit-tests:
2079
2080 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
2081
2082         Reviewed by David Levin.
2083
2084         Adding myself to the committer file.
2085
2086         * Scripts/webkitpy/common/config/committers.py:
2087
2088 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2089
2090         Rubber-stamped by Adam Roben.
2091
2092         Fix two leaks I introduced into the API tests.
2093
2094         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2095         (TestWebKitAPI::TEST):
2096
2097 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2098
2099         Reviewed by Anders Carlsson.
2100
2101         Crash in CFNetwork visiting google.com
2102         https://bugs.webkit.org/show_bug.cgi?id=55958
2103
2104         Add a test for not trying to copy a null CFURLResponse.
2105
2106         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
2107         (TestWebKitAPI::TEST):
2108         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2109
2110 2011-03-08  Hayato Ito  <hayato@chromium.org>
2111
2112         Reviewed by Ojan Vafai.
2113
2114         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
2115
2116         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
2117
2118         https://bugs.webkit.org/show_bug.cgi?id=55450
2119
2120         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2121
2122 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2123
2124         Reviewed by Martin Robinson.
2125
2126         [GTK] Add layoutTestController.setValueForUser() after r80412
2127         https://bugs.webkit.org/show_bug.cgi?id=55862
2128
2129         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2130         (LayoutTestController::setValueForUser): Implement setValueForUser()
2131
2132 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
2133
2134         Reviewed by Adam Barth.
2135
2136         Add script_shell_command to WebKitPort
2137         https://bugs.webkit.org/show_bug.cgi?id=55925
2138
2139         Add a central place where we generate the shell command from the script name.
2140         This function will be used later to detect the correct script interpreter on Win32.
2141
2142         * Scripts/webkitpy/common/config/ports.py:
2143         * Scripts/webkitpy/layout_tests/port/base.py:
2144         * Scripts/webkitpy/tool/steps/abstractstep.py:
2145         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2146
2147 2011-03-07  Ojan Vafai  <ojan@chromium.org>
2148
2149         Reviewed by Adam Barth.
2150
2151         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
2152         https://bugs.webkit.org/show_bug.cgi?id=55749
2153
2154         * Scripts/webkitpy/tool/commands/upload.py:
2155         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2156         * Scripts/webkitpy/tool/steps/__init__.py:
2157         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
2158         * Scripts/webkitpy/tool/steps/options.py:
2159
2160 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
2161
2162         Reviewed by David Levin.
2163
2164         Add support for DataTransferItems
2165         https://bugs.webkit.org/show_bug.cgi?id=55115
2166
2167         Enable data transfer items in DRT.
2168
2169         * DumpRenderTree/chromium/TestShell.cpp:
2170         (TestShell::TestShell):
2171
2172 2011-03-06  Ojan Vafai  <ojan@chromium.org>
2173
2174         Reviewed by Tony Chang.
2175
2176         [test dashboard] pull treemap files
2177         https://bugs.webkit.org/show_bug.cgi?id=55852
2178
2179         * TestResultServer/handlers/dashboardhandler.py:
2180
2181 2011-03-03  Hayato Ito  <hayato@chromium.org>
2182
2183         Reviewed by Mihai Parparita.
2184
2185         [NRWT] Clear output image file used by DumpRenderTree to make sure the
2186         previous image should not be used in the ChromiumDriver.
2187
2188         Also make sure that output image from the ChromiumDriver should be ''
2189         (empty string) if a test crashes for consistency with the WebKitDriver
2190         implementation.
2191
2192         https://bugs.webkit.org/show_bug.cgi?id=55746
2193
2194         * Scripts/webkitpy/layout_tests/port/chromium.py:
2195
2196 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
2197
2198         Reviewed by Martin Robinson.
2199
2200         [Gtk] fast/js/navigator-language.html fails locally
2201         https://bugs.webkit.org/show_bug.cgi?id=55880
2202
2203         Add LANG variable to the clean environment when running
2204         old-run-webkit-tests script.
2205
2206         * Scripts/old-run-webkit-tests:
2207
2208 2011-03-07  Tony Chang  <tony@chromium.org>
2209
2210         Reviewed by Mihai Parparita.
2211
2212         [Chromium] Find .checksum files without .pngs and vice-versa
2213         https://bugs.webkit.org/show_bug.cgi?id=55236
2214
2215         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
2216             mismatched results.
2217
2218 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
2219
2220         Reviewed by Beth Dakin.
2221
2222         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
2223         https://bugs.webkit.org/show_bug.cgi?id=55706
2224
2225         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
2226
2227         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2228         (AccessibilityController::focusedElement):
2229            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
2230            because it could change at any time.
2231         (AccessibilityController::rootElement):
2232
2233 2011-03-07  Sam Weinig  <sam@webkit.org>
2234
2235         Reviewed by Anders Carlsson.
2236
2237         Add unableToImplementPolicy callback for WebKit2 policy client
2238         <rdar://problem/9071902>
2239         https://bugs.webkit.org/show_bug.cgi?id=55884
2240
2241         * MiniBrowser/mac/BrowserWindowController.m:
2242         (-[BrowserWindowController awakeFromNib]):
2243         Update policy client initialization struct for new member.
2244
2245 2011-03-07  Sam Weinig  <sam@webkit.org>
2246
2247         Reviewed by Anders Carlsson.
2248
2249         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2250         https://bugs.webkit.org/show_bug.cgi?id=55827
2251
2252         * MiniBrowser/mac/BrowserWindowController.m:
2253         (decidePolicyForResponse):
2254         (-[BrowserWindowController awakeFromNib]):
2255         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2256         (TestWebKitAPI::decidePolicyForResponse):
2257         (TestWebKitAPI::TEST):
2258         Update tools for new name.
2259
2260 2011-03-06  Daniel Bates  <dbates@rim.com>
2261
2262         Reviewed by Eric Seidel and David Kilzer.
2263
2264         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
2265         https://bugs.webkit.org/show_bug.cgi?id=55503
2266
2267         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
2268         in checkForJavaSDK().
2269
2270         Also, remove extraneous space in function prototype for unlinkZeroFiles.
2271
2272         * Scripts/build-webkit:
2273
2274 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
2275
2276         Reviewed by Sam Weinig.
2277
2278         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
2279
2280         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2281         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
2282             by willSendRequestForFrame. The API expects a retained reference to the URL request.
2283
2284 2011-03-05  Ilya Sherman  <isherman@chromium.org>
2285
2286         Reviewed by Darin Adler.
2287
2288         HTMLInputElement::setValue() should schedule change event when the element is focused
2289         In service of https://code.google.com/p/chromium/issues/detail?id=42716
2290         https://bugs.webkit.org/show_bug.cgi?id=53160
2291
2292         * DumpRenderTree/LayoutTestController.cpp:
2293         (setValueForUserCallback):
2294         (LayoutTestController::staticFunctions):
2295         * DumpRenderTree/LayoutTestController.h:
2296         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2297         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2298         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2299         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
2300         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2301         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2302         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2303         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2304         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2305         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2306
2307 2011-03-04  Mark Rowe  <mrowe@apple.com>
2308
2309         Reviewed by Alexey Proskuryakov.
2310
2311         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
2312
2313         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
2314         
2315         * DumpRenderTree/mac/CheckedMalloc.cpp:
2316         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
2317         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
2318         and then restore the initial protection flags when we're done.
2319
2320 2011-03-04  Evan Martin  <evan@chromium.org>
2321
2322         Reviewed by Tony Chang.
2323
2324         [gdb] pretty-print KURL in gdb
2325         https://bugs.webkit.org/show_bug.cgi?id=55788
2326
2327         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
2328         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
2329         pretty-printing.
2330
2331 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2332
2333         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
2334
2335         Reviewed by Darin Adler.
2336
2337         * TestWebKitAPI/JavaScriptTest.cpp:
2338         (TestWebKitAPI::javaScriptCallback):
2339         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2340         (TestWebKitAPI::didRunJavaScript):
2341         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2342         (TestWebKitAPI::nullJavaScriptCallback):
2343         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2344         (TestWebKitAPI::didRunJavaScript):
2345
2346 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2347
2348         Make run-api-tests show failed if a test fails.
2349
2350         https://webkit.org/b/55725
2351
2352         Reviewed by Sam Weinig.
2353
2354         * Scripts/run-api-tests:
2355         (runTest): Remove "my" from the nested $result assignment so the
2356         check outside the condition sees the real result.
2357
2358 2011-03-02  MORITA Hajime  <morrita@google.com>
2359
2360         Reviewed by Kent Tamura.
2361
2362         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
2363         https://bugs.webkit.org/show_bug.cgi?id=55434
2364
2365         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
2366         and passed the object webkit_support::PostDelayedTask directly.
2367
2368         Note that the change keeps postTask() as is because it has a
2369         semantics taht webkit_support::PostDelayedTask() has; It jumps to
2370         the main thread.
2371
2372         * DumpRenderTree/chromium/Task.cpp:
2373         (postDelayedTask):
2374         * DumpRenderTree/chromium/Task.h:
2375         (WebTask::Run):
2376
2377 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2378
2379         Reviewed by Kenneth Rohde Christiansen.
2380
2381         [QT] Implement mock client-based geolocation for layout testing
2382         https://bugs.webkit.org/show_bug.cgi?id=54334
2383
2384         Implement testing for Client-Based geolocation for QtWebkit.
2385
2386         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2387         (WebCore::DumpRenderTree::DumpRenderTree):
2388         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2389         (LayoutTestController::reset):
2390         (LayoutTestController::setGeolocationPermission):
2391         (LayoutTestController::setMockGeolocationError):
2392         (LayoutTestController::setMockGeolocationPosition):
2393
2394 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2395
2396         Unreviewed, rolling out r80237.
2397         http://trac.webkit.org/changeset/80237
2398         https://bugs.webkit.org/show_bug.cgi?id=55714
2399
2400         Windows bots aren't ready to be core (Requested by aroben on
2401         #webkit).
2402
2403         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2404         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2405
2406 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
2407
2408         Reviewed by Tony Chang.
2409
2410         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
2411         https://bugs.webkit.org/show_bug.cgi?id=55694
2412         
2413         Fixes for interruptions in NRWT:
2414         - Make TestRunInterruptedException be pickleable correctly (the base
2415           Exception class defines a __reduce__ that does not include the reason)
2416         - Fix ordering of returned arguments from TestRunner2._run_tests
2417           (interrupted and keyboard_interrupted were reversed)
2418         - Fix cancel_workers callsites (was using old name).
2419         - In handle_exception re-raise actual exception instance that was thrown
2420
2421         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2422         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2423         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2424         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2425
2426 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
2427
2428         Unreviewed.
2429
2430         Adding myself as a committer.
2431
2432         * Scripts/webkitpy/common/config/committers.py:
2433
2434 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
2435
2436         Reviewed by Mihai Parparita.
2437
2438         Teach sheriffbot to answer whois commands
2439         https://bugs.webkit.org/show_bug.cgi?id=55687
2440
2441         * Scripts/webkitpy/tool/bot/irc_command.py:
2442         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2443         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2444
2445 2011-03-03  Victoria Kirst  <vrk@google.com>
2446
2447         Reviewed by Eric Carlson.
2448
2449         Enable media tests in chromium-gpu/test_expectations
2450         https://bugs.webkit.org/show_bug.cgi?id=53608
2451
2452         Add media folder to the list of GPU test paths.
2453
2454         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2455
2456 2011-03-03  Adam Roben  <aroben@apple.com>
2457
2458         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
2459
2460         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
2461         incorrect parsing of absolute Windows-style file: URLs
2462
2463         Reviewed by Tim Hatcher.
2464
2465         * WebKitTestRunner/TestInvocation.cpp:
2466         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
2467         <http://webkit.org/b/55683>.
2468
2469 2011-03-03  Tony Chang  <tony@chromium.org>
2470
2471         Reviewed by Dimitri Glazkov.
2472
2473         [chromium] Run kill-old-processes on the chromium-win bot too
2474         https://bugs.webkit.org/show_bug.cgi?id=55630
2475
2476         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2477         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
2478
2479 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2480
2481         Reviewed by Martin Robinson.
2482
2483         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
2484         https://bugs.webkit.org/show_bug.cgi?id=53960
2485
2486         * DumpRenderTree/gtk/EventSender.cpp:
2487         (sendClick):
2488         (scheduleAsynchronousClickCallback):
2489
2490 2011-03-03  Adam Roben  <aroben@apple.com>
2491
2492         Look for Windows-style paths when checking whether a test is an Inspector test
2493
2494         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
2495         out or crash on Windows 7 Release (WebKit2 Tests)
2496
2497         Reviewed by Darin Adler.
2498
2499         * WebKitTestRunner/TestInvocation.cpp:
2500         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
2501         Windows.
2502
2503 2011-03-03  Adam Roben  <aroben@apple.com>
2504
2505         Make Windows 7 Release (Tests) a core builder
2506
2507         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2508         give it a few more days of greenness first.
2509
2510         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2511
2512         Reviewed by Andreas Kling.
2513
2514         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2515         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2516
2517         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2518         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2519         Updated the core regexps to match the buildbot module. Updated the expected results to match
2520         the current set of core builders.
2521
2522 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
2523
2524         Reviewed by Andreas Kling.
2525
2526         Adding myself as a reviewer.
2527
2528         * Scripts/webkitpy/common/config/committers.py:
2529
2530 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
2531
2532         Reviewed by Xan Lopez.
2533
2534         [GTK] Extended application cache database API and added unit tests file.
2535         https://bugs.webkit.org/show_bug.cgi?id=55335
2536
2537         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
2538         of webkit_application_cache_set_maximum_size due to API exposal.
2539
2540 2011-03-02  Ojan Vafai  <ojan@chromium.org>
2541
2542         Reviewed by Adam Barth.
2543
2544         make webkit-patch upload work for security bugs
2545         https://bugs.webkit.org/show_bug.cgi?id=55655
2546
2547         The problem is that we shell out to prepare-ChangeLog,
2548         which does not authenticate with bugzilla. All it needs from
2549         bugzilla is the bug title though. We just pass it through from
2550         webkit-patch instead.
2551
2552         * Scripts/prepare-ChangeLog:
2553         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2554         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2555
2556 2011-03-01  Ojan Vafai  <ojan@chromium.org>
2557
2558         Reviewed by Tony Chang.
2559
2560         [test-dashboard] make gtest JSON match layout-tests JSON
2561         https://bugs.webkit.org/show_bug.cgi?id=55556
2562
2563         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
2564         Make this code match.
2565
2566         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2567
2568 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
2569
2570         Reviewed by Tony Chang.
2571
2572         NRWT - implement Linux Hardy 64-bit port support. This involves
2573         adding support for non-'x86' architectures and updating the
2574         "deduplicate_tests" script to correctly understand that
2575         port.name() is not always equal to basename(port.baseline_path()).
2576
2577         This change introduces two new port names: 'chromium-linux-x86'
2578         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
2579         flag will cause the code to determine which one to use at
2580         runtime, just like we currently do with 'chromium-win'.
2581
2582         https://bugs.webkit.org/show_bug.cgi?id=55535
2583
2584         * Scripts/webkitpy/common/system/executive_mock.py:
2585           Handle 'return_stderr' keyword arg to run_command()
2586         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2587         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2588         * Scripts/webkitpy/layout_tests/port/base.py:
2589         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2590         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2591         * Scripts/webkitpy/layout_tests/port/factory.py:
2592         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2593
2594 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
2595
2596         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
2597         update symlinks accordingly.
2598
2599         * wx/packaging/build-mac-installer.py:
2600
2601 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2602
2603         Unreviewed, rolling out r80139.
2604         http://trac.webkit.org/changeset/80139
2605         https://bugs.webkit.org/show_bug.cgi?id=55620
2606
2607         failing and crashing tests on Snow Leopard bot (Requested by
2608         mihaip1 on #webkit).
2609
2610         * DumpRenderTree/LayoutTestController.cpp:
2611         (LayoutTestController::staticFunctions):
2612         * DumpRenderTree/LayoutTestController.h:
2613         * DumpRenderTree/chromium/LayoutTestController.cpp:
2614         (LayoutTestController::LayoutTestController):
2615         * DumpRenderTree/chromium/LayoutTestController.h:
2616         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2617         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2618         * DumpRenderTree/mac/UIDelegate.h:
2619         * DumpRenderTree/mac/UIDelegate.mm:
2620         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2621         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2622         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2623         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2624
2625 2011-03-02  Adam Roben  <aroben@apple.com>
2626
2627         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
2628
2629         This matches DumpRenderTree on Windows.
2630
2631         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
2632         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
2633         in WebKit2
2634
2635         Reviewed by Beth Dakin.
2636
2637         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2638         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
2639         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
2640
2641 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
2642
2643         Reviewed by David Levin.
2644
2645         Add feature define for data transfer items
2646         https://bugs.webkit.org/show_bug.cgi?id=55510
2647
2648         * Scripts/build-webkit:
2649
2650 2011-03-02  Adam Roben  <aroben@apple.com>
2651
2652         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
2653
2654         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
2655         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
2656         the former location, but was getting lucky on some SnowLeopard machines because symlinks
2657         were being created there pointing into DiagnosticReports. For machines without these
2658         symlinks, crash logs were not getting captured.
2659
2660         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
2661         SnowLeopard machines
2662
2663         Reviewed by Eric Seidel.
2664
2665         * Scripts/old-run-webkit-tests:
2666         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
2667
2668 2011-03-02  Adam Roben  <aroben@apple.com>
2669
2670         Don't try to capture crash logs on platforms that haven't implemented that feature
2671
2672         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
2673         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
2674
2675         Reviewed by Joseph Pecoraro.
2676
2677         * Scripts/old-run-webkit-tests:
2678         (captureSavedCrashLog): Bail if we don't have a crash log glob.
2679         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
2680         strictly required to fix bug 55504, but seems worthwhile.
2681
2682 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
2683
2684         Reviewed by Dmitry Titov.
2685
2686         Detach Geolocation from Frame when Page destroyed.
2687         https://bugs.webkit.org/show_bug.cgi?id=52877
2688
2689         Extend the layout test controller to expose the number of pending
2690         geolocation requests, so that we can test that the requests have
2691         been cancelled on page close.
2692
2693         * DumpRenderTree/LayoutTestController.cpp:
2694         (numberOfPendingGeolocationPermissionRequestsCallback):
2695         (LayoutTestController::staticFunctions):
2696         * DumpRenderTree/LayoutTestController.h:
2697         * DumpRenderTree/chromium/LayoutTestController.cpp:
2698         (LayoutTestController::LayoutTestController):
2699         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2700         * DumpRenderTree/chromium/LayoutTestController.h:
2701         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2702         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2703         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2704         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2705         * DumpRenderTree/mac/UIDelegate.h:
2706         * DumpRenderTree/mac/UIDelegate.mm:
2707         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2708         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2709         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2710         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2711         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2712         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2713         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2714         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2715
2716
2717 2011-03-01  Kent Tamura  <tkent@chromium.org>
2718
2719         Reviewed by Dimitri Glazkov.
2720
2721         Assertion fails when a form validation bubble appears
2722         https://bugs.webkit.org/show_bug.cgi?id=55550
2723
2724         Test: fast/forms/interactive-validation-attach-assertion.html
2725
2726         * DumpRenderTree/chromium/WebPreferences.cpp:
2727         (WebPreferences::applyTo): Enable the interactive validation feature by
2728           default. This matches to Chromium browser.
2729
2730 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2731
2732         Reviewed by Kent Tamura.
2733
2734         Remove efl port style exception of Webcore/JavaScriptCore
2735         https://bugs.webkit.org/show_bug.cgi?id=55549
2736
2737         WebCore and JavaScriptCore need to adhere WebKit coding style.
2738
2739         * Scripts/webkitpy/style/checker.py:
2740
2741 2011-03-01  Tony Chang  <tony@chromium.org>
2742
2743         Reviewed by Ojan Vafai.
2744
2745         [chromium] clean up temp files on chromium-mac builder too
2746         https://bugs.webkit.org/show_bug.cgi?id=55525
2747
2748         * BuildSlaveSupport/chromium/remove-crash-logs:
2749
2750 2011-02-28  Ojan Vafai  <ojan@chromium.org>
2751
2752         Reviewed by Tony Chang.
2753
2754         wrap json in a function call to afford cross-domain loading
2755         https://bugs.webkit.org/show_bug.cgi?id=55353
2756
2757         Also delete the code that compacts the JSON. It turns out this
2758         breaks the rebaseline tool and is probably a premature optimization anyways.
2759
2760         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2761         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2762         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2763         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2764
2765 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2766
2767         Unreviewed, rolling out r80079.
2768         http://trac.webkit.org/changeset/80079
2769         https://bugs.webkit.org/show_bug.cgi?id=55547
2770
2771         "Broke the Win debug build?" (Requested by dcheng on #webkit).
2772
2773         * Scripts/build-webkit:
2774
2775 2011-03-01  Mark Rowe  <mrowe@apple.com>
2776
2777         Reviewed by Sam Weinig.
2778
2779         Update verification scripts to handle WebKit2.
2780
2781         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
2782         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
2783         WebKit2.
2784
2785 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
2786
2787         Reviewed by David Levin.
2788
2789         Add feature define for data transfer items
2790         https://bugs.webkit.org/show_bug.cgi?id=55510
2791
2792         * Scripts/build-webkit:
2793
2794 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
2795
2796         Reviewed by Timothy Hatcher.
2797
2798         All Console Messages should be passed to ChromeClients.
2799         https://bugs.webkit.org/show_bug.cgi?id=54926
2800
2801         Update DumpRenderTree's UIDelegate to use the new console message delegate.
2802
2803         * DumpRenderTree/mac/UIDelegate.mm:
2804         (-[UIDelegate webView:addMessageToConsole:withSource:]):
2805
2806 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
2807
2808         Reviewed by Adam Barth.
2809
2810         Tragically, we stopped running the python unit tests
2811         on Chromium Win just as I was getting them to be green.
2812         This patch turns them back on.
2813
2814         https://bugs.webkit.org/show_bug.cgi?id=55521
2815
2816         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2817
2818 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
2819
2820         Reviewed by Adam Roben.
2821
2822         Disable
2823         webkitpy.common.system.executive_unittest.ExecutiveTest.\
2824            test_kill_all fails on win until it can be properly triaged.
2825
2826         https://bugs.webkit.org/show_bug.cgi?id=54790
2827
2828         * Scripts/webkitpy/common/system/executive_unittest.py:
2829
2830     2011-03-01  Helder Correia  <helder@sencha.com>
2831
2832             Unreviewed. Add myself to committers.py.
2833
2834             * Scripts/webkitpy/common/config/committers.py:
2835
2836 2011-03-01  Adam Roben  <aroben@apple.com>
2837
2838         Give up if a crash log for the web process is taking too long to be saved on Windows
2839
2840         This should keep the bots from getting stuck while waiting for a crash log, if writing a
2841         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
2842
2843         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
2844         to be saved for the web process
2845
2846         Reviewed by Steve Falkenburg.
2847
2848         * WebKitTestRunner/win/TestControllerWin.cpp:
2849         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
2850         Generalized the code slightly to handle the optional object to wait on.
2851         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
2852         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
2853         prevent us from waiting forever.
2854
2855 2011-03-01  Adam Roben  <aroben@apple.com>
2856
2857         Give WebKitLauncherWin's PDB file a name different from WebKit's
2858
2859         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
2860         fighting over the same PDB file, meaning that one of them was going to lose and not have
2861         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
2862
2863         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
2864         runs (due to missing symbols)
2865
2866         Reviewed by David Kilzer.
2867
2868         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
2869         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
2870
2871 2011-03-01  Adam Roben  <aroben@apple.com>
2872
2873         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
2874
2875         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
2876         --exit-after-n-crashes-or-timeouts limit
2877
2878         Reviewed by David Kilzer.
2879
2880         * Scripts/old-run-webkit-tests:
2881         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
2882         the number of tests that caused the web process to crash when exiting early.
2883
2884 2011-03-01  Adam Roben  <aroben@apple.com>
2885
2886         Save a crash log when the web process crashes
2887
2888         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
2889         until it has finished crashing, which guarantees that the crash log will have had time to be
2890         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
2891         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
2892
2893         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
2894         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
2895
2896         Reviewed by Sam Weinig.
2897
2898         * Scripts/old-run-webkit-tests:
2899         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
2900         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
2901         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
2902         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
2903         WebProces_*.crash files when the web process crashes.
2904
2905         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2906         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
2907         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
2908         along to platformInitialize.
2909
2910         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
2911
2912         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2913         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
2914
2915         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2916         (WTR::InjectedBundle::platformInitialize):
2917         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2918         (WTR::InjectedBundle::platformInitialize):
2919         Updated function signature.
2920
2921         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
2922         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
2923         webProcessCrashingEvent, then lets the crash continue as normal.
2924
2925         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
2926         event we should use to tell the UI process we're crashing from the initializationUserData,
2927         and get a handle to that event.
2928
2929         * WebKitTestRunner/TestController.cpp:
2930         (WTR::TestController::TestController): Initialize new members.
2931         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
2932         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
2933         when a crash log is being saved on Windows. Exit right away if specified. (This is the
2934         default.)
2935
2936         * WebKitTestRunner/TestController.h: Added new members.
2937
2938         * WebKitTestRunner/win/TestControllerWin.cpp:
2939         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
2940         us it's crashing.
2941         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
2942         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
2943         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
2944         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
2945         so the test harness will know the web process has crashed and not try to kill us, then wait
2946         for the web process to finish crashing so a crash log will have time to be saved.
2947         (WTR::toWK): Simple hepler function.
2948         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
2949         process should use to tell us it is crashing in the context's initialization user data.
2950
2951 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
2952
2953         Reviewed by Tony Gentilcore.
2954
2955         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
2956         https://bugs.webkit.org/show_bug.cgi?id=55476
2957
2958         Chromium Win uses BuildAndTestFactory, not TestFactory.
2959
2960         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
2961
2962 2011-03-01  Adam Roben  <aroben@apple.com>
2963
2964         Test that the WebKit2 responsiveness timer doesn't fire too early
2965
2966         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
2967         early on Windows
2968
2969         Reviewed by Anders Carlsson.
2970
2971         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
2972
2973         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
2974         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2975         (TestWebKitAPI::didFinishLoadForFrame):
2976         (TestWebKitAPI::processDidBecomeUnresponsive):
2977         (TestWebKitAPI::setInjectedBundleClient):
2978         (TestWebKitAPI::setPageLoaderClient):
2979         Simple helper functions.
2980
2981         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
2982         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
2983         the responsiveness timer to start, but the web process should unpause before it has a chance
2984         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
2985
2986         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
2987         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
2988         Call up to the base class.
2989         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
2990         pause, sleep for 0.5 seconds, then send back a message saying we paused.
2991
2992         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2993         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
2994         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2995         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
2996
2997         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2998         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2999         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3000         Added new files.
3001
3002 2011-03-01  Andras Becsi  <abecsi@webkit.org>
3003
3004         Reviewed by Csaba Osztrogonác.
3005
3006         [Qt] Clean up the project files and move common options to WebKit.pri.
3007
3008         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
3009
3010
3011 2011-03-01  Adam Roben  <aroben@apple.com>
3012
3013         Skip another multiprocessing test on Windows
3014
3015         It is sometimes failing (and may be leaving child Python processes around).
3016         <http://webkit.org/b/55087> tracks the failure.
3017
3018         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
3019         (FuncitonTests.test_get__processes): Skip this test on Windows.
3020
3021 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
3022
3023         Reviewed by Pavel Feldman.
3024
3025         Web Inspector: reduce inspector tests flakiness.
3026         https://bugs.webkit.org/show_bug.cgi?id=55401
3027
3028         * DumpRenderTree/chromium/TestShell.cpp:
3029         (TestShell::runFileTest):
3030         * DumpRenderTree/chromium/WebPreferences.cpp:
3031         (WebPreferences::reset):
3032
3033 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
3034
3035         Reviewed by James Robinson.
3036
3037         NRWT should still upload results when it exits early due to too many failures
3038         https://bugs.webkit.org/show_bug.cgi?id=55432
3039         
3040         Only keyboard interrupts should prevent results from being uploaded.
3041
3042         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3043         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3044
3045 2011-02-28  Alice Liu  <alice.liu@apple.com>
3046
3047         Reviewed by Adam Roben and Gavin Barraclough.
3048
3049         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
3050         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
3051
3052         * TestWebKitAPI/InjectedBundleController.h:
3053         (TestWebKitAPI::InjectedBundleController::bundle):
3054         * TestWebKitAPI/PlatformWebView.h:
3055         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
3056         (TestWebKitAPI::didFinishLoadForFrame):
3057         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3058         (TestWebKitAPI::setPageLoaderClient):
3059         (TestWebKitAPI::TEST):
3060         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
3061         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
3062         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
3063         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
3064         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3065         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3066         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3067         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3068         
3069         Added files to:
3070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3071         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3072         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3073
3074 2011-02-28  Adam Roben  <aroben@apple.com>
3075
3076         Start running InjectedBundle API tests on Windows
3077
3078         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
3079
3080         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
3081
3082         Reviewed by Darin Adler.
3083
3084         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
3085         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
3086         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
3087         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
3088         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
3089         These are just extracted from TestWebKitAPI.vcproj.
3090
3091         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
3092         up the DLL's filename.
3093
3094         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
3095         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
3096         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
3097
3098         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
3099         "all" configuration.
3100
3101         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
3102         injected bundle tests. Let VS resort things.
3103
3104         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
3105
3106 2011-02-28  Adam Roben  <aroben@apple.com>
3107
3108         Add a test for the paint rect passed via WM_PAINT to windowless plugins
3109
3110         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
3111         Large portions of pages with plugins paint black
3112
3113         Reviewed by Anders Carlsson.
3114
3115         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3116         (PluginTest::NPP_HandleEvent):
3117         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3118         Added NPP_HandleEvent. Just returns 0 at this level.
3119
3120         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
3121         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
3122         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
3123         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
3124         WM_PAINT has the expected coordinates.
3125
3126         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3127         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
3128         else.
3129
3130         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
3131         resort things.
3132
3133         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3134         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
3135         This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
3136         webView:didFinishLoadForFrame:] in DumpRenderTree.
3137
3138         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3139         (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
3140         can start running.
3141
3142 2011-02-28  Adam Roben  <aroben@apple.com>
3143
3144         Tell MiniBrowser's WKViews that they're in a window
3145
3146         Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
3147
3148         Reviewed by Anders Carlsson.
3149
3150         * MiniBrowser/win/BrowserView.cpp:
3151         (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
3152
3153 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
3154
3155         Reviewed by Csaba Osztrogonác.
3156
3157         The new QML tests require QML_IMPORT_PATH variable to be set in order to
3158         load the proper plugin.
3159
3160         * Scripts/run-qtwebkit-tests:
3161
3162 2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>
3163
3164         Unreviewed, fix spelling mistake.
3165
3166         hardware-accelated => hardware-accelerated.
3167
3168         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3169
3170 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
3171
3172         Reviewed by Andreas Kling.
3173
3174         Made sure that the build-webkit --qmake argument is always respected.
3175
3176         Previously, it would be respected during the build, but not during
3177         the early feature detection. The build would also fail if qmake was
3178         not in your path, even if you specified --qmake with a valid qmake
3179         binary.
3180
3181         [Qt] WebKit patches required to work with a modularized version of Qt
3182         https://bugs.webkit.org/show_bug.cgi?id=53916
3183
3184         * Scripts/build-webkit:
3185         * Scripts/webkitdirs.pm:
3186
3187 2011-02-27  Ojan Vafai  <ojan@chromium.org>
3188
3189         Fix failing tests from http://trac.webkit.org/changeset/79837.
3190
3191         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3192         This was just a mistake that would break if someone tried printing with this configuration.
3193         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3194         Method signature changed. Didn't notice that this method was being calling in a unittest.
3195
3196 2011-02-24  Hayato Ito  <hayato@chromium.org>
3197
3198         Reviewed by Eric Seidel.
3199
3200         [NRWT] Remove test_types/* classes.
3201
3202         This is the last patch in the series of efforts which tried to remove test_types classes.
3203         A single_test_runner module will take over responsibilities of test_type classes.
3204
3205         From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
3206
3207         https://bugs.webkit.org/show_bug.cgi?id=55123
3208
3209         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3210         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3211         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3212         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3213         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
3214         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
3215         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
3216         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
3217         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
3218         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
3219
3220 2011-02-25  Ojan Vafai  <ojan@chromium.org>
3221
3222         Reviewed by Tony Chang.
3223
3224         Change results.json format to the one used by unexpected_results.json
3225         https://bugs.webkit.org/show_bug.cgi?id=52267
3226
3227         Also add runtimes in milliseconds to the JSON and make the output format more compact.
3228         Named the file full_results.json to avoid conflicting with the results.json
3229         file the test-results server currently serves up.
3230
3231         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3232         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3233         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3234         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3235         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3236         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3237
3238 2011-02-27  Adam Roben  <aroben@apple.com>
3239
3240         Followup fix to r79827
3241
3242         * DumpRenderTree/win/UIDelegate.cpp:
3243         (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
3244         lastPathComponent. This matches what we did here before r79827, and matches Mac.
3245
3246 2011-02-27  Dan Bernstein  <mitz@apple.com>
3247
3248         Reviewed by Adam Roben.
3249
3250         Make bisect-builds print a trac link for the regression range
3251         https://bugs.webkit.org/show_bug.cgi?id=55331
3252
3253         * Scripts/bisect-builds:
3254
3255 2011-02-27  Adam Roben  <aroben@apple.com>
3256
3257         Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
3258
3259         Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
3260         EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
3261         fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
3262
3263         Reviewed by Anders Carlsson.
3264
3265         * DumpRenderTree/win/EditingDelegate.cpp:
3266         (indexOfFirstWordCharacter):
3267         (wordLength):
3268         Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
3269
3270 2011-02-27  Adam Roben  <aroben@apple.com>
3271
3272         Make ResourceLoadDelegate print URLs relative to the main resource on Windows
3273
3274         This matches Mac. (In fact, the code was ported from Mac!)
3275
3276         Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
3277         match Mac
3278
3279         Reviewed by Anders Carlsson.
3280
3281         * DumpRenderTree/win/DumpRenderTree.cpp:
3282         (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
3283         (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
3284         _drt_descriptionSuitableForTestResult].
3285         (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
3286
3287         * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
3288
3289         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
3290         DumpRenderTree.cpp.
3291
3292 2011-02-27  Adam Roben  <aroben@apple.com>
3293
3294         Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
3295
3296         This makes Bugzilla autocompletion work correctly.
3297
3298         * Scripts/webkitpy/common/config/committers.py:
3299
3300 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
3301
3302         Reviewed by Andreas Kling.
3303
3304         [Qt] fast/loader/user-stylesheet-fast-path.html fails
3305         https://bugs.webkit.org/show_bug.cgi?id=50911
3306
3307         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3308         (LayoutTestController::setUserStyleSheetLocation):
3309         Use QUrl::fromEncoded since the passed string is already encoded.
3310
3311 2011-02-27  Adam Roben  <aroben@apple.com>
3312
3313         Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
3314
3315         Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
3316         is different from old-run-webkit-test's. Because of this, the path to the crash log file
3317         (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
3318         details.
3319
3320         Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
3321         --results-directory path is used (like on the test slaves)
3322
3323         Reviewed by Dan Bernstein.
3324
3325         * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
3326         made $testResultsDirectory an absolute path.
3327
3328 2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>
3329
3330         Reviewed by Adam Barth.
3331
3332         m_dumpAccessibilityNotifications should be initialized.
3333         https://bugs.webkit.org/show_bug.cgi?id=54874
3334
3335         * DumpRenderTree/chromium/AccessibilityController.cpp:
3336         (AccessibilityController::AccessibilityController):
3337
3338 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3339
3340         Reviewed by Pavel Feldman.
3341
3342         DumpRenderTree should reset frame opener between tests.
3343         https://bugs.webkit.org/show_bug.cgi?id=54874
3344
3345         Added clearOpener() calls between tests.
3346         Some tests are using window.open() to change current window location.
3347         This changes window.opener property whose nullity is checked before
3348         showing xml viewer.
3349
3350         * DumpRenderTree/chromium/TestShell.cpp:
3351         (TestShell::resetTestController):
3352         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3353         (resetDefaultsToConsistentValues):
3354         * DumpRenderTree/mac/DumpRenderTree.mm:
3355         (resetWebViewToConsistentStateBeforeTesting):
3356         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3357         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3358         * DumpRenderTree/win/DumpRenderTree.cpp:
3359         (resetWebViewToConsistentStateBeforeTesting):
3360         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3361         (WTR::InjectedBundlePage::reset):
3362
3363 2011-02-26  Yael Aharon  <yael.aharon@nokia.com>
3364
3365         Reviewed by Andreas Kling.
3366
3367         [Qt] Fix the focus in MiniBrowser.
3368         https://bugs.webkit.org/show_bug.cgi?id=55288
3369
3370         Give focus to the web view when a load starts.
3371
3372         * MiniBrowser/qt/BrowserWindow.cpp:
3373         (BrowserWindow::urlChanged):
3374
3375 2011-02-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3376
3377         Reviewed by Adam Barth.
3378
3379         [EFL] Add coding style exceptions for EFL port
3380         https://bugs.webkit.org/show_bug.cgi?id=54733
3381
3382         The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
3383         underscore-sparated values. But, style checking rule have found parameter_name errors
3384         in efl directories so far.
3385
3386         * Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
3387
3388 2011-02-26  David Levin  <levin@chromium.org>
3389
3390         Reviewed by Darin Adler.
3391
3392         check-webkit-style should check for spaces after periods in comments
3393         https://bugs.webkit.org/show_bug.cgi?id=55253
3394
3395         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
3396         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests
3397           and fixed the name of one related test.
3398
3399 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3400
3401         Reviewed by Andreas Kling.
3402
3403         Make it possible to test the targetdensity-dpi support
3404         https://bugs.webkit.org/show_bug.cgi?id=55142
3405
3406         Test the viewport meta tag feature targetdensity-dpi by
3407         adding extra arguments to dumpConfigurationForViewport
3408
3409         Add the new arguments to the shared header and all
3410         implementation.
3411
3412         * DumpRenderTree/LayoutTestController.cpp:
3413         (dumpConfigurationForViewportCallback):
3414         * DumpRenderTree/LayoutTestController.h:
3415         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3416         (LayoutTestController::dumpConfigurationForViewport):
3417         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3418         (LayoutTestController::dumpConfigurationForViewport):
3419         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3420         (LayoutTestController::dumpConfigurationForViewport):
3421         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3422         (LayoutTestController::dumpConfigurationForViewport):
3423         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3424         (LayoutTestController::dumpConfigurationForViewport):
3425         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3426
3427 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
3428
3429         Unreviewed, rolling out r79764.
3430         http://trac.webkit.org/changeset/79764
3431         https://bugs.webkit.org/show_bug.cgi?id=55295
3432
3433         "broke Chromium builds" (Requested by rniwa on #webkit).
3434
3435         * DumpRenderTree/chromium/TestShell.cpp:
3436         (TestShell::resetTestController):
3437         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3438         (resetDefaultsToConsistentValues):
3439         * DumpRenderTree/mac/DumpRenderTree.mm:
3440         (resetWebViewToConsistentStateBeforeTesting):
3441         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3442         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3443         * DumpRenderTree/win/DumpRenderTree.cpp:
3444         (resetWebViewToConsistentStateBeforeTesting):
3445         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3446         (WTR::InjectedBundlePage::reset):
3447
3448 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
3449
3450         Reviewed by David Kilzer.
3451
3452         https://bugs.webkit.org/show_bug.cgi?id=48781
3453
3454         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
3455
3456         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
3457         should paint the default broken image when an image fails to load or decode.
3458
3459         * DumpRenderTree/LayoutTestController.cpp:
3460         (LayoutTestController::LayoutTestController):
3461         (setShouldPaintBrokenImageCallback):
3462         (LayoutTestController::staticFunctions):
3463         (LayoutTestController::setShouldPaintBrokenImage):
3464         * DumpRenderTree/LayoutTestController.h:
3465         (LayoutTestController::shouldPaintBrokenImage):
3466         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3467         (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
3468
3469 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3470
3471         Reviewed by Pavel Feldman.
3472
3473         DumpRenderTree should reset frame opener between tests.
3474         https://bugs.webkit.org/show_bug.cgi?id=54874
3475
3476         Added clearOpener() calls between tests.
3477         Some tests are using window.open() to change current window location.
3478         This changes window.opener property whose nullity is checked before
3479         showing xml viewer.
3480
3481         * DumpRenderTree/chromium/TestShell.cpp:
3482         (TestShell::resetTestController):
3483         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3484         (resetDefaultsToConsistentValues):
3485         * DumpRenderTree/mac/DumpRenderTree.mm:
3486         (resetWebViewToConsistentStateBeforeTesting):
3487         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3488         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3489         * DumpRenderTree/win/DumpRenderTree.cpp:
3490         (resetWebViewToConsistentStateBeforeTesting):
3491         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3492         (WTR::InjectedBundlePage::reset):
3493
3494 2011-02-25  Lukasz Slachciak  <l.slachciak@samsung.com>
3495
3496         Reviewed by Kenneth Rohde Christiansen.
3497
3498         [EFL] Added EWebLauncher command line option to turn on/off frame flattening
3499         https://bugs.webkit.org/show_bug.cgi?id=54809
3500
3501         * EWebLauncher/main.c: Handling -f option added.
3502         (on_key_down):
3503         (browserCreate):
3504         (main):
3505
3506 2011-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3507
3508         Unreviewed, rolling out r79324.
3509         http://trac.webkit.org/changeset/79324
3510         https://bugs.webkit.org/show_bug.cgi?id=55260
3511
3512         Leopard Debug is once again running out of address space while
3513         linking (Requested by aroben on #webkit).
3514
3515         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3516         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3517
3518 2011-02-25  Tony Chang  <tony@chromium.org>
3519
3520         Reviewed by James Robinson.
3521
3522         Clean up temp files left by crashing DRTs on chromium-win
3523         https://bugs.webkit.org/show_bug.cgi?id=55182
3524
3525         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3526         * BuildSlaveSupport/chromium/remove-crash-logs: Added.
3527
3528 2011-02-25  Adam Roben  <aroben@apple.com>
3529
3530         Double-check that modifying the registry worked
3531
3532         On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
3533         still return a successful exit code. So we double-check here that the value we tried to
3534         write to the registry was really written.
3535
3536         Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
3537         logs on Windows Vista/7
3538
3539         Reviewed by Darin Adler.
3540
3541         * Scripts/old-run-webkit-tests:
3542         (writeRegistryString): After trying to write the string value, check that it was really
3543         written.
3544
3545 2011-02-25  Adam Roben  <aroben@apple.com>
3546
3547         Set the 32-bit post-mortem debugger on 64-bit OSes
3548
3549         The post-mortem debugger is controlled by some registry values in
3550         HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
3551         set the values in that key, which will be used for 64-bit apps, or in the equivalent key
3552         under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
3553         WebKitTestRunner are 32-bit, we want to use the latter location.
3554
3555         Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
3556         64-bit apps, but should set it for 32-bit apps instead
3557
3558         Reviewed by Darin Adler.
3559
3560         * Scripts/old-run-webkit-tests:
3561         (readRegistryString):
3562         (writeRegistryString):
3563         Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
3564         Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
3565         Passing --wow32 on a 32-bit OS will not have any effect.
3566
3567 2011-02-25  Adam Roben  <aroben@apple.com>
3568
3569         Clean up code to set up crash log saving on Windows
3570
3571         Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly
3572
3573         Reviewed by David Kilzer.
3574
3575         * Scripts/old-run-webkit-tests:
3576         (readRegistryString):
3577         (writeRegistryString):
3578         Moved code to read strings from and write strings to the registry here...
3579
3580         (setUpWindowsCrashLogSaving): ...from here.
3581
3582 2011-02-25  Adam Roben  <aroben@apple.com>
3583
3584         Work around Cygwin's crash-suppression behavior
3585
3586         Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
3587         inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
3588         invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
3589         when our test apps launch to work around Cygwin's behavior.
3590
3591         Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
3592         debugger) when launched from Cygwin 1.7
3593
3594         Reviewed by Darin Adler.
3595
3596         * DumpRenderTree/win/DumpRenderTree.cpp:
3597         (main):
3598         * TestWebKitAPI/win/main.cpp:
3599         (main):
3600         * WebKitAPITest/main.cpp:
3601         (main):
3602         * WebKitTestRunner/win/TestControllerWin.cpp:
3603         (WTR::TestController::platformInitialize):
3604         Call ::SetErrorMode(0) to undo Cygwin's folly.
3605
3606 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3607
3608         Reviewed by Andreas Kling.
3609
3610         [Qt] Revert the support for QNAM affined to a different thread.
3611         https://bugs.webkit.org/show_bug.cgi?id=55149
3612
3613         Qt 4.8 will have QNAM use its own thread internally by default,
3614         no need to keep this complexity in WebKit.
3615
3616         This mainly reverts:
3617         http://trac.webkit.org/changeset/73710
3618         http://trac.webkit.org/changeset/73712
3619
3620         * QtTestBrowser/launcherwindow.cpp:
3621         (LauncherWindow::~LauncherWindow):
3622         (LauncherWindow::initializeView):
3623         (LauncherWindow::createChrome):
3624         * QtTestBrowser/launcherwindow.h:
3625         (WindowOptions::WindowOptions):
3626         * QtTestBrowser/webpage.cpp:
3627         (WebPage::WebPage):
3628         * QtTestBrowser/webpage.h:
3629
3630 2011-02-24  Adam Barth  <abarth@webkit.org>
3631
3632         Reviewed by Eric Seidel.
3633
3634         Add a script for creating gypi files
3635         https://bugs.webkit.org/show_bug.cgi?id=55113
3636
3637         This is a trivial script to create gypi files from the source code in
3638         the current directory.
3639
3640         * Scripts/make-gypi: Added.
3641
3642 2011-02-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3643
3644         Unreviewed, rolling out r79628.
3645         http://trac.webkit.org/changeset/79628
3646         https://bugs.webkit.org/show_bug.cgi?id=55195
3647
3648         "broke chromium win tests" (Requested by dpranke on #webkit).
3649
3650         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3651         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3652
3653 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
3654
3655         Reviewed by Mihai Parparita.
3656
3657         rebaseline-chromium-webkit-tests can't handle GPU variants
3658         https://bugs.webkit.org/show_bug.cgi?id=55002
3659
3660         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3661         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3662
3663 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
3664
3665         Reviewed by Mihai Parparita.
3666
3667         nrwt: log command used to start web server to --verbose
3668
3669         https://bugs.webkit.org/show_bug.cgi?id=55188
3670
3671         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3672         * Scripts/webkitpy/layout_tests/port/http_server.py:
3673
3674 2011-02-24  Victoria Kirst  <vrk@google.com>
3675
3676         Reviewed by Mihai Parparita.
3677
3678         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
3679         https://bugs.webkit.org/show_bug.cgi?id=55089
3680
3681         This adds an alias into the media/ directory so that http/tests/media
3682         tests can access the media resources when running in an httpd process.
3683
3684         * Scripts/webkitperl/httpd.pm:
3685         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3686         * Scripts/webkitpy/layout_tests/port/http_server.py:
3687
3688 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
3689
3690         Reviewed by Mihai Parparita.
3691
3692         nrwt: enable multiple processes by default on Chromium Win.
3693
3694         https://bugs.webkit.org/show_bug.cgi?id=55163
3695
3696         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3697         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3698
3699 2011-02-24  Sam Weinig  <sam@webkit.org>
3700
3701         Attempt to fix Qt.
3702
3703         * WebKitTestRunner/TestInvocation.cpp:
3704
3705 2011-02-24  James Robinson  <jamesr@chromium.org>
3706
3707         Unreviewed, rolling out r79598.
3708         http://trac.webkit.org/changeset/79598
3709         https://bugs.webkit.org/show_bug.cgi?id=55089
3710
3711         Appears to be causing trouble with httpd on windows
3712
3713         * Scripts/webkitperl/httpd.pm:
3714         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3715         * Scripts/webkitpy/layout_tests/port/http_server.py:
3716
3717 2011-02-24  Sam Weinig  <sam@webkit.org>
3718
3719         Reviewed by Darin Adler.
3720
3721         Add basic pixel testing support to WebKitTestRunner
3722         https://bugs.webkit.org/show_bug.cgi?id=55161
3723
3724         * Scripts/old-run-webkit-tests:
3725         Don't print color space information when using WebKitTestRunner since
3726         we don't need to change the screen.
3727
3728         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3729         (WTR::InjectedBundle::initialize):
3730         Add call to initializePlatformDefaults.
3731         
3732         (WTR::InjectedBundle::done):
3733         Return a dictionary on completion with both the text output and pixel dump override.