0d71aa18be7349875ca25dd09fe3d744febf8dde
[WebKit.git] / Tools / ChangeLog
1 2017-06-16  Alex Christensen  <achristensen@webkit.org>
2
3         Show punycode to user if a URL has dotless i or j followed by diacritic dot
4         https://bugs.webkit.org/show_bug.cgi?id=173431
5
6         Reviewed by Darin Adler.
7
8         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
9         (TestWebKitAPI::TEST):
10
11 2017-06-16  Chris Dumez  <cdumez@apple.com>
12
13         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
14         https://bugs.webkit.org/show_bug.cgi?id=173472
15         <rdar://problem/28858817>
16
17         Reviewed by Brady Eidson.
18
19         Add API test coverage.
20
21         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
23         (TEST):
24
25 2017-06-16  Brady Eidson  <beidson@apple.com>
26
27         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
28         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
29
30         Reviewed by Daniel Bates.
31
32         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
33
34 2017-06-16  Chris Dumez  <cdumez@apple.com>
35
36         DRT fails to reset page visibility between tests
37         https://bugs.webkit.org/show_bug.cgi?id=173485
38
39         Reviewed by Alexey Proskuryakov.
40
41         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
42         Fix this to address flakiness.
43
44         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
45         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
46         The test became flaky without the DRT change and was no longer flaky with the DRT
47         change.
48
49         WebKitTestRunner already does this.
50
51         * DumpRenderTree/mac/DumpRenderTree.mm:
52         (resetWebViewToConsistentStateBeforeTesting):
53
54 2017-06-16  Alex Christensen  <achristensen@webkit.org>
55
56         Implement basic authentication in MiniBrowser
57         https://bugs.webkit.org/show_bug.cgi?id=173443
58
59         Reviewed by Tim Horton.
60
61         * MiniBrowser/mac/WK2BrowserWindowController.m:
62         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
63
64 2017-06-16  Jer Noble  <jer.noble@apple.com>
65
66         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
67         https://bugs.webkit.org/show_bug.cgi?id=173398
68         <rdar://problem/32592961>
69
70         Reviewed by Eric Carlson.
71
72         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
73         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
74         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
75         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
76         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
77         (TestWebKitAPI::TEST):
78         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
79
80 2017-06-16  Matt Lewis  <jlewis3@apple.com>
81
82         Unreviewed, rolling out r218375.
83
84         The API test MediaStreamTrackDetached is still timing out
85         after the patch
86
87         Reverted changeset:
88
89         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
90         reports no recording to WebKit clients"
91         https://bugs.webkit.org/show_bug.cgi?id=173398
92         http://trac.webkit.org/changeset/218375
93
94 2017-06-15  Jer Noble  <jer.noble@apple.com>
95
96         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
97         https://bugs.webkit.org/show_bug.cgi?id=173398
98         <rdar://problem/32592961>
99
100         Reviewed by Eric Carlson.
101
102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
103         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
104         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
105         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
106         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
107         (TestWebKitAPI::TEST):
108         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
109
110 2017-06-15  Matt Lewis  <jlewis3@apple.com>
111
112         Unreviewed, rolling out r218365.
113
114         The revision caused API timeouts on all builds.
115
116         Reverted changeset:
117
118         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
119         reports no recording to WebKit clients"
120         https://bugs.webkit.org/show_bug.cgi?id=173398
121         http://trac.webkit.org/changeset/218365
122
123 2017-06-15  Jer Noble  <jer.noble@apple.com>
124
125         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
126         https://bugs.webkit.org/show_bug.cgi?id=173398
127         <rdar://problem/32592961>
128
129         Reviewed by Eric Carlson.
130
131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
132         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
133         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
134         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
135         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
136         (TestWebKitAPI::TEST):
137         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
138
139 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
140
141         REGRESSION(r218344): [WPE] Thousands of layout test crashes
142         https://bugs.webkit.org/show_bug.cgi?id=173433
143
144         Unreviewed.
145
146         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
147
148 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
149
150         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
151         https://bugs.webkit.org/show_bug.cgi?id=173061
152
153         Reviewed by Žan Doberšek.
154
155         Launch dyz <https://github.com/Igalia/dyz> with the script
156         run-minibrowser for the wpe port. It is now built as part of the
157         WPE dependencies with JHBuild.
158
159         * Scripts/run-minibrowser:
160         * Scripts/webkitdirs.pm:
161         (launcherPath):
162         (launcherName):
163         * wpe/install-dependencies: Luajit is needed for building dyz.
164         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
165
166 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
167
168         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
169         https://bugs.webkit.org/show_bug.cgi?id=173338
170         <rdar://problem/32777720>
171
172         Reviewed by Tim Horton.
173
174         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
175         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
176         these remaining items on drop.
177
178         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
179         (TestWebKitAPI::TEST):
180         * TestWebKitAPI/ios/DataInteractionSimulator.h:
181         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
182
183         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
184
185         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
186
187 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
188
189         [Win] Crash in accessibility layout test.
190         https://bugs.webkit.org/show_bug.cgi?id=173401
191
192         Reviewed by Brent Fulgham.
193
194         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
195         member will be automatically released when the _variant_t object goes out of scope if the vt member
196         does not equal VT_UNKNOWN | VT_BYREF.
197         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
198
199         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
200         (AccessibilityUIElement::titleUIElement):
201
202 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
203
204         [GTK] Add API to allow overriding popup menus
205         https://bugs.webkit.org/show_bug.cgi?id=172905
206
207         Reviewed by Michael Catanzaro.
208
209         Add a unit test to check the new API.
210
211         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
212         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
213         (OptionMenuTest::OptionMenuTest):
214         (OptionMenuTest::~OptionMenuTest):
215         (OptionMenuTest::destroyMenu):
216         (OptionMenuTest::showOptionMenuCallback):
217         (OptionMenuTest::menuCloseCallback):
218         (OptionMenuTest::showOptionMenu):
219         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
220         (OptionMenuTest::close):
221         (OptionMenuTest::activateItem):
222         (OptionMenuTest::selectItem):
223         (testOptionMenuSimple):
224         (testOptionMenuGroups):
225         (testOptionMenuActivate):
226         (testOptionMenuSelect):
227         (beforeAll):
228         (afterAll):
229
230 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
231
232         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
233         https://bugs.webkit.org/show_bug.cgi?id=173399
234
235         Reviewed by Per Arne Vollan.
236
237         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
238         Curl port needs to do nothing because libcurl doesn't have disk cache.
239
240         * DumpRenderTree/win/DumpRenderTree.cpp:
241         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
242         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
243
244 2017-06-14  Tomas Popela  <tpopela@redhat.com>
245
246         [GTK] integer expression expected if running Tools/gtk/install-dependencies
247         https://bugs.webkit.org/show_bug.cgi?id=173356
248
249         Reviewed by Michael Catanzaro.
250
251         Use the correct operator to compare the strings.
252
253         * gtk/install-dependencies:
254
255 2017-06-14  Commit Queue  <commit-queue@webkit.org>
256
257         Unreviewed, rolling out r218285.
258         https://bugs.webkit.org/show_bug.cgi?id=173391
259
260         API test fails on iOS (Requested by alexchristensen on
261         #webkit).
262
263         Reverted changeset:
264
265         "Add SPI for immediate injection of user scripts"
266         https://bugs.webkit.org/show_bug.cgi?id=173342
267         http://trac.webkit.org/changeset/218285
268
269 2017-06-14  Chris Dumez  <cdumez@apple.com>
270
271         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
272         https://bugs.webkit.org/show_bug.cgi?id=173384
273         <rdar://problem/32723779>
274
275         Reviewed by Dan Bernstein.
276
277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
278         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
279         Add API test coverage.
280
281         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
282         (TestWebKitAPI::Util::sleep):
283         Update implementation of Util::sleep() so that we actually run the run loop.
284         Otherwise, we don't process events while sleeping.
285
286 2017-06-14  Alex Christensen  <achristensen@webkit.org>
287
288         Add SPI for immediate injection of user scripts
289         https://bugs.webkit.org/show_bug.cgi?id=173342
290         <rdar://problem/29202285>
291
292         Reviewed by Brady Eidson.
293
294         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
295         (waitForMessage):
296         (TEST):
297
298 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
299
300         Add WPE to the flakiness dashboard
301         https://bugs.webkit.org/show_bug.cgi?id=173365
302
303         Reviewed by Carlos Alberto Lopez Perez.
304
305         * TestResultServer/static-dashboards/builders.jsonp:
306         * TestResultServer/static-dashboards/flakiness_dashboard.js:
307         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
308         (resetGlobals):
309         * TestResultServer/static-dashboards/loader_unittests.js:
310
311 2017-06-14  Brady Eidson  <beidson@apple.com>
312
313         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
314         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
315
316         Reviewed by Alex Christensen.
317
318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
319         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
320         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
321         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
322         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
323         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
324         (TEST):
325
326 2017-06-14  Tim Horton  <timothy_horton@apple.com>
327
328         WKContentViewEditingActions API test always fails
329         https://bugs.webkit.org/show_bug.cgi?id=173374
330
331         Reviewed by Wenson Hsieh.
332
333         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
334         (TEST):
335         selectAll isn't working, because canPerformAction for selectAll returns NO
336         if selectionIsNone (which is true in the non-contenteditable case).
337         Instead, make use of r218180's test page, which knows how to select itself.
338         Also, reset the pasteboard at the beginning of the test to reduce confusion
339         (I landed the test broken because my simulator had the correct text
340         stuck in its pasteboard).
341
342 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
343
344         Configure screen scale for running layout tests on plus devices
345         https://bugs.webkit.org/show_bug.cgi?id=173319
346
347         Reviewed by Tim Horton.
348
349         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
350         * DumpRenderTree/mac/DumpRenderTree.mm:
351         (dumpRenderTree): Set screen scale to 2.0.
352         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
353         add _setScale for UIScreen.
354         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
355         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
356         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
357         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
358         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
359         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
360         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
361         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
362         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
363         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
364
365 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
366
367         Add iOS 11 support to the bot watcher's dashboard
368         https://bugs.webkit.org/show_bug.cgi?id=173369
369
370         Reviewed by Lucas Forschler.
371
372         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
373         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
374         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
375         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
376         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
377         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
378
379 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
380
381         [GTK][WPE] Raise the timeout values for layout tests
382         https://bugs.webkit.org/show_bug.cgi?id=173368
383
384         Reviewed by Carlos Garcia Campos.
385
386         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
387         When running under valgrind a 10x multiplier is applied.
388
389         * Scripts/webkitpy/port/gtk.py:
390         (GtkPort.default_timeout_ms):
391         * Scripts/webkitpy/port/gtk_unittest.py:
392         (GtkPortTest.test_default_timeout_ms):
393         * Scripts/webkitpy/port/wpe.py:
394         (WPEPort.default_timeout_ms):
395         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
396         (WPEPortTest):
397         (WPEPortTest.make_port):
398         (WPEPortTest.test_default_timeout_ms):
399         (WPEPortTest.test_get_crash_log):
400
401 2017-06-14  Alex Christensen  <achristensen@webkit.org>
402
403         Test persistent WKHTTPCookieStorages on iOS.
404         https://bugs.webkit.org/show_bug.cgi?id=173284
405
406         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
407         (TEST):
408         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
409
410 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
411
412         [Win] DRT should not use disk cache.
413         https://bugs.webkit.org/show_bug.cgi?id=173361
414
415         Reviewed by Darin Adler.
416
417         Like on macOS/iOS, DRT on Windows should only use memory cache.
418
419         * DumpRenderTree/win/DumpRenderTree.cpp:
420         (setDefaultsToConsistentValuesForTesting):
421         (prepareConsistentTestingEnvironment):
422
423 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
424
425         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
426         https://bugs.webkit.org/show_bug.cgi?id=171668
427
428         Reviewed by Jer Noble.
429
430         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
431         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
432         Infinity when the double value passed as argument is greater than 2^64.
433
434         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
435         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
436         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
437         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
438         method. No behavior change for rational MediaTime.
439
440         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
441         (TestWebKitAPI::TEST):
442
443 2017-06-13  Alex Christensen  <achristensen@webkit.org>
444
445         Test persistent WKHTTPCookieStorages on iOS
446         https://bugs.webkit.org/show_bug.cgi?id=173284
447         <rdar://problem/32260156>
448
449         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
450         (TEST):
451
452 2017-06-13  Matt Rajca  <mrajca@apple.com>
453
454         WebsitePolicies: let clients select specific autoplay quirks
455         https://bugs.webkit.org/show_bug.cgi?id=173343
456
457         Reviewed by Alex Christensen.
458
459         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
460         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
461         (TEST): Updated tests.
462
463 2017-06-13  Daniel Bates  <dabates@apple.com>
464
465         Implement W3C Secure Contexts Draft Specification
466         https://bugs.webkit.org/show_bug.cgi?id=158121
467         <rdar://problem/26012994>
468
469         Reviewed by Brent Fulgham.
470
471         Part 4
472
473         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
474         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
475         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
476
477         * DumpRenderTree/TestOptions.h:
478         * DumpRenderTree/TestOptions.mm:
479         (TestOptions::TestOptions):
480         * DumpRenderTree/mac/DumpRenderTree.mm:
481         (setWebPreferencesForTestOptions):
482         * DumpRenderTree/win/DumpRenderTree.cpp:
483         (enableExperimentalFeatures):
484         * WebKitTestRunner/TestController.cpp:
485         (WTR::TestController::resetPreferencesToConsistentValues):
486         (WTR::updateTestOptionsFromTestHeader):
487         * WebKitTestRunner/TestOptions.h:
488         (WTR::TestOptions::hasSameInitializationOptions):
489
490 2017-06-13  Alex Christensen  <achristensen@webkit.org>
491
492         Test persistent WKHTTPCookieStorages on iOS
493         https://bugs.webkit.org/show_bug.cgi?id=173284
494         <rdar://problem/32260156>
495
496         Reviewed by Alexey Proskuryakov.
497
498         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
499         (TEST):
500
501 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
502
503         [GTK] Blob download doesn't work
504         https://bugs.webkit.org/show_bug.cgi?id=172442
505
506         Reviewed by Carlos Alberto Lopez Perez.
507
508         Add a unit test to check blob downloads.
509
510         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
511         (testBlobDownload):
512         (beforeAll):
513
514 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
515
516         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
517         https://bugs.webkit.org/show_bug.cgi?id=173316
518
519         Reviewed by Alex Christensen.
520
521         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
522
523         * gtk/manifest.txt.in:
524
525 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
526
527         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
528         https://bugs.webkit.org/show_bug.cgi?id=173315
529
530         Reviewed by Darin Adler.
531
532         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
533         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
534         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
535         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
536         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
537         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
538         WKGeolocationManagerRef is not destroyed.
539
540         * WebKitTestRunner/GeolocationProviderMock.cpp:
541         (WTR::GeolocationProviderMock::GeolocationProviderMock):
542         * WebKitTestRunner/GeolocationProviderMock.h:
543
544 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
545
546         Unable to paste text that was copied from a page into the universal search field
547         https://bugs.webkit.org/show_bug.cgi?id=173293
548         <rdar://problem/32440918>
549
550         Reviewed by Ryosuke Niwa.
551
552         Adds 2 new unit tests for copying plain and rich selected web content.
553         See WebCore and WebKit ChangeLogs for more detail.
554
555         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
556         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
557         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
558         (TestWebKitAPI::dataForPasteboardType):
559         (TestWebKitAPI::setUpWebViewForPasteboardTests):
560         (TestWebKitAPI::TEST):
561
562 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
563
564         AX: [ATK] Implement missing AtkRelation types
565         https://bugs.webkit.org/show_bug.cgi?id=155494
566
567         Reviewed by Darin Adler.
568
569         Add additional methods to test ARIA properties which are exposed via
570         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
571
572         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
573         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
574         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
575         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
576         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
577         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
578         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
579         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
580         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
581         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
582         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
583         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
584         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
585         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
586         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
587         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
588         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
589         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
590
591 2017-06-12  Daniel Bates  <dabates@apple.com>
592
593         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
594         https://bugs.webkit.org/show_bug.cgi?id=173286
595         <rdar://problem/32726102>
596
597         Reviewed by Brent Fulgham.
598
599         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
600         (TestWebKitAPI::TEST_F):
601
602 2017-06-12  Lucas Forschler  <lforschler@apple.com>
603
604         <rdar://problem/32683422>
605         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
606
607         Reviewed by Conrad Schultz.
608
609         * Scripts/copy-webkitlibraries-to-product-directory:
610
611 2017-06-12  Tim Horton  <timothy_horton@apple.com>
612
613         [iOS] Cmd-C doesn't copy text from WKWebView
614         https://bugs.webkit.org/show_bug.cgi?id=173277
615         <rdar://problem/32396742>
616
617         Reviewed by Dan Bernstein.
618
619         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
620         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
621         Add a test ensuring that -copy on WKContentView will cause text to be copied.
622
623 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
624
625         [WebCrypto] Remove experimental feature flag of SubtleCrypto
626         https://bugs.webkit.org/show_bug.cgi?id=173197
627         <rdar://problem/32688148>
628
629         Reviewed by Brent Fulgham.
630
631         * DumpRenderTree/mac/DumpRenderTree.mm:
632         (enableExperimentalFeatures):
633         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
634         (WTR::InjectedBundle::beginTesting):
635         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
636         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
637         * WebKitTestRunner/InjectedBundle/TestRunner.h:
638
639 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
640
641         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
642         https://bugs.webkit.org/show_bug.cgi?id=173238
643         <rdar://problem/31943370>
644
645         Reviewed by Ryosuke Niwa and Tim Horton.
646
647         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
648         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
649         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
650
651         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
652         (TestWebKitAPI::TEST):
653         * TestWebKitAPI/ios/DataInteractionSimulator.h:
654         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
655         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
656         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
657
658 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
659
660         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
661         https://bugs.webkit.org/show_bug.cgi?id=173225
662         <rdar://problem/32713144>
663
664         Reviewed by Tim Horton.
665
666         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
667         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
668
669         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
670         (TestWebKitAPI::TEST):
671
672 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
673
674         Return correct process names for iOS on-device testing
675         https://bugs.webkit.org/show_bug.cgi?id=173263
676
677         Reviewed by Alex Christensen.
678
679         When running tests on iOS devices, process names do not end with '.Development'
680         as they do on Mac and iOS simulator.
681
682         * WebKitTestRunner/TestController.cpp:
683         (WTR::TestController::webProcessName): Return correct process name without '.Development'
684         for iOS on-device testing.
685         (WTR::TestController::networkProcessName): Ditto.
686         (WTR::TestController::databaseProcessName): Ditto.
687
688 2017-06-12  Chris Dumez  <cdumez@apple.com>
689
690         Regression(r217867): Legacy SessionHistoryEntryData format should not change
691         https://bugs.webkit.org/show_bug.cgi?id=173267
692         <rdar://problem/32701257>
693
694         Reviewed by Simon Fraser.
695
696         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
697         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
698         though as this covers the crash that r217867 was fixing.
699
700         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
701         (TestWebKitAPI::createSessionStateData):
702         (TestWebKitAPI::TEST):
703         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
704
705 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
706
707         [GTK] Stop dismissing menus attached to the web view for every injected event
708         https://bugs.webkit.org/show_bug.cgi?id=172708
709
710         Reviewed by Alex Christensen.
711
712         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
713         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
714         events while the menu is open.
715
716         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
717         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
718         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
719         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
720
721 2017-06-12  Miguel Gomez  <magomez@igalia.com>
722
723         [GTK][WPE] Enable GStreamer GL on development builds
724         https://bugs.webkit.org/show_bug.cgi?id=173248
725
726         Enable GStreamer GL for GTK and WPE.
727
728         Reviewed by Carlos Garcia Campos.
729
730         * Scripts/webkitperl/FeatureList.pm:
731
732 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
733
734         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
735
736         Notifications are no longer cleared on page navigation.
737
738         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
739         (testWebViewNotification):
740
741 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
742
743         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
744
745         DBus interface and object path names were updated in r217831.
746
747         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
748
749 2017-06-10  Dan Bernstein  <mitz@apple.com>
750
751         Reverted r218056 because it made the IDE reindex constantly.
752
753         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
754         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
755         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
756         * MiniBrowser/Configurations/DebugRelease.xcconfig:
757         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
758         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
759         * WebEditingTester/Configurations/DebugRelease.xcconfig:
760         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
761
762 2017-06-10  Dan Bernstein  <mitz@apple.com>
763
764         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
765         https://bugs.webkit.org/show_bug.cgi?id=173223
766
767         Reviewed by Sam Weinig.
768
769         The rebuilds were happening due to a difference in the compiler options that the IDE and
770         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
771         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
772         specify an appropriate path in CLANG_INDEX_STORE_PATH.
773
774         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
775         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
776         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
777         * MiniBrowser/Configurations/DebugRelease.xcconfig:
778         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
779         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
780         * WebEditingTester/Configurations/DebugRelease.xcconfig:
781         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
782
783 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
784
785         webkitpy: Reduce polling in ServerProcess
786         https://bugs.webkit.org/show_bug.cgi?id=173116
787
788         Reviewed by Ryosuke Niwa.
789
790         We should be smarter about polling. We do not need to poll every time a line is read from
791         stdout and stderr since lines are usually read from cached data. We should only poll
792         when extracting that cached data from stdout and stderr.
793
794         * Scripts/webkitpy/port/driver.py:
795         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
796         and on ServerProcess to poll the process if not data is available in stdout and stderr.
797         * Scripts/webkitpy/port/driver_unittest.py:
798         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
799         ServerProcess.
800         * Scripts/webkitpy/port/server_process.py:
801         (ServerProcess._read): Allow for data to be read from _output even if the process has
802         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
803         * Scripts/webkitpy/port/server_process_mock.py:
804         (MockServerProcess): Add number_of_times_polled.
805         (MockServerProcess.poll): Increment number_of_times_polled.
806         (MockServerProcess.has_crashed): Poll before returning crash state.
807         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
808         just like a ServerProcess would.
809         (MockServerProcess.read_stdout): Ditto.
810         * Scripts/webkitpy/port/server_process_unittest.py:
811         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
812         process from ending before stdout and stderr are read. This is the reason this test was flakey.
813         (TestServerProcess):
814         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
815         the processes is polled.
816         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
817         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
818
819 2017-06-10  Andy Estes  <aestes@apple.com>
820
821         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
822         https://bugs.webkit.org/show_bug.cgi?id=173190
823         <rdar://problem/31360659>
824
825         Reviewed by Brady Eidson.
826         
827         Added a release assert that tries to create a proper test failure if the web process crashes.
828
829         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
830         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
831
832 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
833
834         [iOS DnD] Add a hook to perform two-step drops in editable content
835         https://bugs.webkit.org/show_bug.cgi?id=172992
836         <rdar://problem/32590174>
837
838         Reviewed by Tim Horton.
839
840         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
841         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
842                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
843
844         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
845         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
846         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
847
848         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
849         be overridden. Currently, this is overridden to just return true.
850
851         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
852         (TestWebKitAPI::TEST):
853         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
854         (WTR::InjectedBundlePage::InjectedBundlePage):
855
856 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
857
858         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
859         https://bugs.webkit.org/show_bug.cgi?id=173103
860
861         Reviewed by Xabier Rodriguez-Calvar.
862
863         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
864         when building the WPE port through build-webkit.
865
866 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
867
868         [WPE] Enable MEDIA_SOURCE for build-webkit builds
869         https://bugs.webkit.org/show_bug.cgi?id=173136
870
871         Reviewed by Xabier Rodriguez-Calvar.
872
873         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
874
875 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
876
877         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
878         https://bugs.webkit.org/show_bug.cgi?id=173098
879
880         Reviewed by Žan Doberšek.
881
882         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
883         assuming that all tests containing forms define ids for the form elements like
884         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
885
886         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
887         (formControlsAssociatedCallback):
888
889 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
890
891         webkitpy: Run sample/spindump on iOS devices
892         https://bugs.webkit.org/show_bug.cgi?id=171881
893         <rdar://problem/32084602>
894
895         Reviewed by Daniel Bates.
896
897         * Scripts/webkitpy/port/darwin.py:
898         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
899         requires sudo to run spindump.
900         * Scripts/webkitpy/port/ios_device.py:
901         (IOSDevicePort.look_for_new_samples): Deleted.
902         (IOSDevicePort.sample_process): Deleted.
903         * Scripts/webkitpy/port/ios_device_unittest.py:
904         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
905         (IOSDeviceTest.test_spindump):
906         (IOSDeviceTest.test_sample_process):
907         (IOSDeviceTest.test_sample_process_exception):
908         * Scripts/webkitpy/port/ios_simulator_unittest.py:
909         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
910
911 2017-06-08  Keith Miller  <keith_miller@apple.com>
912
913         WebAssembly: We should only create wrappers for functions that can be exported
914         https://bugs.webkit.org/show_bug.cgi?id=173088
915
916         Reviewed by Saam Barati.
917
918         Add quick mode for wasm tests.
919
920         * Scripts/run-jsc-stress-tests:
921
922 2017-06-08  Darin Adler  <darin@apple.com>
923
924         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
925         https://bugs.webkit.org/show_bug.cgi?id=173106
926
927         Reviewed by Sam Weinig.
928
929         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
930         destroyed last.
931         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
932         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
933
934 2017-06-07  Dan Bernstein  <mitz@apple.com>
935
936         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
937         https://bugs.webkit.org/show_bug.cgi?id=173086
938
939         Reviewed by Andy Estes.
940
941         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
942         (TEST):
943
944 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
945
946         Add High Sierra support to WebKit tools
947         https://bugs.webkit.org/show_bug.cgi?id=173080
948
949         Rubber-stamped by Daniel Bates.
950
951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
955         Added dashboard support.
956
957         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
958         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
959         Trigger the right build queues on check-in.
960
961         * Scripts/webkitpy/common/system/platforminfo.py:
962         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
963         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
964         * Scripts/webkitpy/port/mac.py:
965         * Scripts/webkitpy/port/mac_unittest.py:
966         * TestResultServer/static-dashboards/flakiness_dashboard.js:
967         Added cases for Sierra, and updated tests for new baseline search paths.
968
969 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
970
971         Unreviewed, rolling out r217902.
972
973         This change appears to have caused imported/w3c/web-platform-
974         tests/fetch/api/cors tests to fail on El Capitan.
975
976         Reverted changeset:
977
978         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
979         https://bugs.webkit.org/show_bug.cgi?id=172930
980         http://trac.webkit.org/changeset/217902
981
982 2017-06-07  Daniel Bates  <dabates@apple.com>
983
984         Teach run-webkit-tests how to run HTTPS Web Platform Tests
985         https://bugs.webkit.org/show_bug.cgi?id=172930
986         <rdar://problem/32570201>
987
988         Reviewed by Youenn Fablet.
989
990         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
991         that is conditioned on the page being delivered over a secure protocol. One example of such
992         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
993
994         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
995         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
996         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
997
998         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
999         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
1000         to the Web Platform Tests HTTPS server.
1001         * Scripts/webkitpy/port/base.py:
1002         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
1003         * Scripts/webkitpy/port/driver.py:
1004         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
1005         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
1006         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
1007         indicate that they should be considered private instance variables.
1008         (Driver.is_web_platform_test): Update code for renamed instance variables.
1009         (Driver):
1010         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
1011         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
1012         determine the base URL to use to access the test.
1013         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
1014         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
1015
1016 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
1017
1018         Support removal of authentication data through the Website data store API.
1019         https://bugs.webkit.org/show_bug.cgi?id=171217
1020
1021         Reviewed by Brady Eidson.
1022
1023         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1024         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1025         (WTR::InjectedBundle::didReceiveMessageToPage):
1026         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1027         (WTR::TestRunner::removeAllSessionCredentials):
1028         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
1029         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1030         * WebKitTestRunner/TestController.h:
1031         * WebKitTestRunner/TestInvocation.cpp:
1032         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1033         (WTR::TestInvocation::didRemoveAllSessionCredentials):
1034         * WebKitTestRunner/TestInvocation.h:
1035         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1036         (WTR::TestController::removeAllSessionCredentials):
1037
1038 2017-06-07  Charlie Turner  <cturner@igalia.com>
1039
1040         Add Charlie Turner as contributor
1041         https://bugs.webkit.org/show_bug.cgi?id=173055
1042
1043         Reviewed by Carlos Alberto Lopez Perez.
1044
1045         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
1046         of webkit-patch upload, which reordered some fields and removed a newline.
1047
1048         * Scripts/webkitpy/common/config/contributors.json:
1049
1050 2017-06-06  Chris Dumez  <cdumez@apple.com>
1051
1052         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
1053         https://bugs.webkit.org/show_bug.cgi?id=173033
1054         <rdar://problem/32591099>
1055
1056         Reviewed by Simon Fraser.
1057
1058         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
1059         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
1060
1061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1062         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
1063         (TestWebKitAPI::didFinishLoadForFrame):
1064         (TestWebKitAPI::setPageLoaderClient):
1065         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
1066         (TestWebKitAPI::TEST):
1067
1068 2017-06-06  Andy Estes  <aestes@apple.com>
1069
1070         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
1071         https://bugs.webkit.org/show_bug.cgi?id=172849
1072         <rdar://problem/32567454>
1073
1074         Reviewed by Darin Adler.
1075
1076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1077         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
1078         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1079         (TestWebKitAPI::TEST):
1080
1081 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
1082
1083         [preload] Conditional support for media preloading and align media `as` values.
1084         https://bugs.webkit.org/show_bug.cgi?id=172501
1085
1086         Reviewed by Dean Jackson.
1087
1088         Turn on media preloading preference for tests.
1089
1090         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
1091         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
1092         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
1093
1094 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
1095
1096         webkitpy: Return correct process names from SimulatorProcess
1097         https://bugs.webkit.org/show_bug.cgi?id=172940
1098
1099         Reviewed by Aakash Jain.
1100
1101         * Scripts/webkitpy/port/darwin.py:
1102         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
1103         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
1104         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
1105         * Scripts/webkitpy/port/driver.py:
1106         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
1107         _server_process.name() will not return the correct process name for iOS.
1108         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
1109         (Driver._read_block): Ditto.
1110         * Scripts/webkitpy/port/driver_unittest.py:
1111         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
1112         process_name() instead of name().
1113         * Scripts/webkitpy/port/server_process.py:
1114         (ServerProcess._start): Use process_name() instead of name().
1115         (ServerProcess.stop): Ditto.
1116         (ServerProcess.name): Deleted.
1117         * Scripts/webkitpy/port/simulator_process.py:
1118         (SimulatorProcess.process_name): Check the provided bundle for the process name.
1119
1120 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
1121
1122         test-webkitpy: stop forking unsafely from within a spawned process
1123         https://bugs.webkit.org/show_bug.cgi?id=172774
1124
1125         Reviewed by Darin Adler.
1126
1127         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1128         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
1129         it's going to be used.
1130         (Builder.force_build):
1131
1132 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
1133
1134         webkitpy: Process crash-logs for iOS devices
1135         https://bugs.webkit.org/show_bug.cgi?id=171976
1136         <rdar://problem/32134551>
1137
1138         Reviewed by David Kilzer.
1139
1140         When running layout tests on an iOS device, crash logs should be processed.
1141         Implement crash log searching and parsing for iOS devices.
1142
1143         * Scripts/webkitpy/common/system/crashlogs.py:
1144         (CrashLogs): Moved process regular expression for Darwin to class variable.
1145         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
1146         (CrashLogs.find_newest_log): Add iOS as a potential platform.
1147         (CrashLogs.find_all_logs): Ditto.
1148         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
1149         Do not assume that a Darwin crash log starts with the process.
1150         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
1151         shared code for parsing Darwin crash logs.
1152         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
1153         object so that crash logs already on the system before testing are not parsed.
1154         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
1155         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
1156         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
1157         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1158         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
1159         * Scripts/webkitpy/common/system/systemhost.py:
1160         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
1161         systems is just the crashlog, use this behavior by default.
1162         * Scripts/webkitpy/common/system/systemhost_mock.py:
1163         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
1164         systems is just the crashlog, use this behavior by default.
1165         * Scripts/webkitpy/port/apple.py:
1166         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
1167         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
1168         the system before testing begins
1169         * Scripts/webkitpy/port/base.py:
1170         (Port._get_crash_log): Pass optional target host when getting crash logs.
1171         * Scripts/webkitpy/port/darwin.py:
1172         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
1173         CrashLogs object.
1174         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
1175         logs to be skipped to CrashLogs object.
1176         * Scripts/webkitpy/port/darwin_testcase.py:
1177         (DarwinTest.test_get_crash_log): Removed unused local function.
1178         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
1179         * Scripts/webkitpy/port/device.py:
1180         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
1181         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
1182         * Scripts/webkitpy/port/driver.py:
1183         (Driver._get_crash_log): Pass optional target host when getting crash logs.
1184         * Scripts/webkitpy/port/gtk.py:
1185         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
1186         * Scripts/webkitpy/port/ios.py: Ditto.
1187         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
1188         to be skipped for each host.
1189         * Scripts/webkitpy/port/ios_device.py:
1190         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
1191         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
1192         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
1193         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
1194         host is specified. Else, search all connected devices for the specified crash-log.
1195         (IOSDevicePort.look_for_new_crash_logs): Deleted.
1196         * Scripts/webkitpy/port/ios_device_unittest.py:
1197         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
1198         (IOSDeviceTest.test_get_crash_log): Ditto.
1199         * Scripts/webkitpy/port/simulator_process.py:
1200         (SimulatorProcess.process_name): Check the provided bundle for the process name.
1201         * Scripts/webkitpy/port/win.py:
1202         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
1203         logs to be skipped to CrashLogs object.
1204         * Scripts/webkitpy/port/wpe.py:
1205         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
1206
1207 2017-06-06  David Kilzer  <ddkilzer@apple.com>
1208
1209         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
1210         <https://webkit.org/b/172804>
1211
1212         Reviewed by Darin Adler.
1213
1214         WTF_ATTRIBUTE_PRINTF() only works outside the current
1215         compilation unit if it's on the declaration, not the
1216         implementation, of a function or class method.
1217
1218         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1219         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1220         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1221         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1222         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
1223         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1224         - Remove redundant CRASH() macro definition.  Use the one from
1225           <wtf/Assertions.h> instead.
1226
1227 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
1228
1229         Move Resource Timing / User Timing from experimental features into main preferences
1230         https://bugs.webkit.org/show_bug.cgi?id=172950
1231
1232         Reviewed by Darin Adler.
1233
1234         * DumpRenderTree/mac/DumpRenderTree.mm:
1235         (enableExperimentalFeatures):
1236         (resetWebPreferencesToConsistentValues):
1237         * DumpRenderTree/win/DumpRenderTree.cpp:
1238         (enableExperimentalFeatures):
1239         (resetWebPreferencesToConsistentValues):
1240         * WebKitTestRunner/TestController.cpp:
1241         (WTR::TestController::resetPreferencesToConsistentValues):
1242         Move out no longer experimental features to the main list.
1243
1244 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1245
1246         [WPE] Add an install-dependencies script
1247         https://bugs.webkit.org/show_bug.cgi?id=172948
1248
1249         Reviewed by Žan Doberšek.
1250
1251         It is based on the gtk/install-dependencies script.
1252         Includes support for Debian based distrubutions, Fedora and Arch.
1253         It has been tested on a minimal Debian 9 chroot.
1254
1255         * wpe/install-dependencies: Added.
1256
1257 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1258
1259         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
1260         https://bugs.webkit.org/show_bug.cgi?id=172891
1261         <rdar://problem/32204540>
1262
1263         Reviewed by Darin Adler.
1264
1265         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
1266         contenteditable. See WebCore ChangeLog for more details.
1267
1268         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1269         (TestWebKitAPI::TEST):
1270
1271 2017-06-05  Daniel Bates  <dabates@apple.com>
1272
1273         webkitpy: Abstract Executive class
1274         https://bugs.webkit.org/show_bug.cgi?id=172928
1275         <rdar://problem/32569531>
1276
1277         Reviewed by Ryosuke Niwa.
1278
1279         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
1280         This will make it straightforward to create additional derived classes that
1281         adhere to the same interface, say for iOS on-device testing.
1282
1283         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
1284         (AbstractExecutive):
1285         (AbstractExecutive.run_and_throw_if_fail):
1286         (AbstractExecutive.cpu_count):
1287         (AbstractExecutive.interpreter_for_script):
1288         (AbstractExecutive.shell_command_for_script):
1289         (AbstractExecutive.kill_process):
1290         (AbstractExecutive.check_running_pid):
1291         (AbstractExecutive.running_pids):
1292         (AbstractExecutive.wait_newest):
1293         (AbstractExecutive.wait_limited):
1294         (AbstractExecutive.interrupt):
1295         (AbstractExecutive.default_error_handler):
1296         (AbstractExecutive.ignore_error):
1297         (AbstractExecutive._stringify_args):
1298         (AbstractExecutive.command_for_printing):
1299         (AbstractExecutive.run_command):
1300         (AbstractExecutive.popen):
1301         (AbstractExecutive.run_in_parallel):
1302         * Scripts/webkitpy/common/system/executive.py:
1303         (Executive):
1304         (Executive.cpu_count):
1305         (Executive.running_pids):
1306         (Executive.kill_all):
1307         (Executive._compute_stdin):
1308         (Executive.interpreter_for_script): Deleted.
1309         (Executive.shell_command_for_script): Deleted.
1310         (Executive.wait_newest): Deleted.
1311         (Executive.wait_limited): Deleted.
1312         (Executive.default_error_handler): Deleted.
1313         (Executive.ignore_error): Deleted.
1314         (Executive.command_for_printing): Deleted.
1315
1316 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
1317
1318         webkitpy: Add iOS to platform
1319         https://bugs.webkit.org/show_bug.cgi?id=172931
1320
1321         Reviewed by Daniel Bates.
1322
1323         * Scripts/webkitpy/common/system/platforminfo.py:
1324         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
1325         (PlatformInfo.is_ios): Added.
1326         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
1327         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1328         (MockPlatformInfo.is_ios): Added.
1329
1330 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1331
1332         [WPE][JHBuild] Switch github repository from git:// to https://
1333         https://bugs.webkit.org/show_bug.cgi?id=172921
1334
1335         Reviewed by Alex Christensen.
1336
1337         * wpe/jhbuild.modules:
1338
1339 2017-06-05  Tim Horton  <timothy_horton@apple.com>
1340
1341         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
1342         https://bugs.webkit.org/show_bug.cgi?id=172887
1343         <rdar://problem/32546061>
1344
1345         Reviewed by Sam Weinig.
1346
1347         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1348         (WTR::UIScriptController::applyAutocorrection):
1349         applyAutocorrection can call its completion handler synchronously,
1350         which makes UIScriptController unhappy (see bug 172884).
1351
1352 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
1353
1354         webkitpy: Add contextmanager to disable logging for a block
1355         https://bugs.webkit.org/show_bug.cgi?id=172876
1356
1357         Reviewed by Daniel Bates.
1358
1359         Add a context manager which will use an OutputCapture object to capture logging
1360         in a block and hold it in a variable.
1361
1362         * Scripts/webkitpy/common/system/outputcapture.py:
1363         (OutputCaptureScope):
1364         (OutputCaptureScope.__init__): Construct with OutputCapture object.
1365         (OutputCaptureScope.__enter__): Begin capturing output. 
1366         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
1367         output and retain the resulting log.
1368         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
1369         (OutputCaptureTest.test_output_capture_scope): Added.
1370
1371 2017-06-02  Zalan Bujtas  <zalan@apple.com>
1372
1373         Cleanup FrameView::autoSizeIfEnabled.
1374         https://bugs.webkit.org/show_bug.cgi?id=172889
1375         <rdar://problem/32550783>
1376
1377         Reviewed by Tim Horton.
1378
1379         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1380         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
1381         (TEST):
1382
1383 2017-06-02  Chris Dumez  <cdumez@apple.com>
1384
1385         ResourceLoadStatistics are not using unique paths during test runs
1386         https://bugs.webkit.org/show_bug.cgi?id=172861
1387         <rdar://problem/32442251>
1388
1389         Reviewed by Darin Adler.
1390
1391         Make sure WebKitTestRunner sets a temporary path for saving resource
1392         load statistics.
1393
1394         * WebKitTestRunner/TestController.cpp:
1395         (WTR::TestController::generateContextConfiguration):
1396
1397 2017-06-02  Brady Eidson  <beidson@apple.com>
1398
1399         Prevent scheme handlers from handling all built-in URL schemes.
1400         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
1401
1402         Reviewed by Andy Estes.
1403
1404         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1405
1406 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
1407
1408         [JSCOnly] Build static jsc.exe on Windows
1409         https://bugs.webkit.org/show_bug.cgi?id=172833
1410
1411         Reviewed by Konstantin Tokarev.
1412
1413         * CMakeLists.txt:
1414         * Scripts/build-jsc:
1415
1416 2017-06-02  Zalan Bujtas  <zalan@apple.com>
1417
1418         Disable ViewportSizeForViewportUnits tests on iOS.
1419         https://bugs.webkit.org/show_bug.cgi?id=172872
1420
1421         Reviewed by Tim Horton.
1422
1423         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
1424
1425 2017-06-02  Zalan Bujtas  <zalan@apple.com>
1426
1427         Allow clients to override viewport size for CSS viewport units.
1428         https://bugs.webkit.org/show_bug.cgi?id=172838
1429         <rdar://problem/32523441>
1430
1431         Reviewed by Tim Horton.
1432
1433         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1434         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
1435         (TEST):
1436
1437 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
1438
1439         Get <chrono> out of StdLibExtras.h
1440         https://bugs.webkit.org/show_bug.cgi?id=172744
1441
1442         Reviewed by Zalan Bujtas.
1443
1444         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1445
1446 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
1447
1448         [WPE] Enable SUBTLE_CRYPTO
1449         https://bugs.webkit.org/show_bug.cgi?id=172756
1450
1451         Reviewed by Michael Catanzaro.
1452
1453         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
1454         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
1455         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
1456         exhausting entropy when running the crypto layout tests.
1457
1458 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1459
1460         [GTK] Bump GTK+ and its dependencies in jhbuild
1461         https://bugs.webkit.org/show_bug.cgi?id=171918
1462
1463         Reviewed by Carlos Alberto Lopez Perez.
1464
1465         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1466         (WTR::initializeGtkSettings):
1467         * gtk/jhbuild.modules:
1468         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
1469         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
1470
1471 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1472
1473         [GTK] Bump wayland and weston in jhbuild
1474         https://bugs.webkit.org/show_bug.cgi?id=171921
1475
1476         Reviewed by Carlos Alberto Lopez Perez.
1477
1478         * gtk/jhbuild.modules:
1479         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
1480
1481 2017-06-01  Andy Estes  <aestes@apple.com>
1482
1483         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
1484         https://bugs.webkit.org/show_bug.cgi?id=172828
1485
1486         Reviewed by Beth Dakin.
1487
1488         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1489
1490 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
1491
1492         webkitpy: Remove unneeded simulator teardown
1493         https://bugs.webkit.org/show_bug.cgi?id=171891
1494
1495         Reviewed by Aakash Jain.
1496
1497         * Scripts/webkitpy/port/ios_simulator.py:
1498         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
1499         for communication between Python and WebKitTestRunner/DumpRenderTree.
1500
1501 2017-06-01  Keith Miller  <keith_miller@apple.com>
1502
1503         Undo rollout in r217638 with bug fix
1504         https://bugs.webkit.org/show_bug.cgi?id=172824
1505
1506         Unreviewed, reland patch with unused set_state code removed.
1507
1508         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1509         (runThreadMessageTest):
1510         (TEST):
1511
1512 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
1513
1514         webkitpy: Do not send 0 or -1 as a pid to kill_process
1515         https://bugs.webkit.org/show_bug.cgi?id=172818
1516
1517         Reviewed by Darin Adler.
1518
1519         Sending a signal to process 0 will result in all processes in the group receiving 
1520         the signal. Sending a signal to process -1 will result in all non-system processes
1521         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
1522         should consider these cases
1523
1524         * Scripts/webkitpy/common/system/executive.py:
1525         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
1526         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
1527         never be running, although os.kill may succeed.
1528         * Scripts/webkitpy/port/simulator_process.py:
1529         (SimulatorProcess.stop): Do not kill process if it is undefined.
1530
1531 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
1532
1533         JSC EWS bot does not run on WTF only patches
1534         https://bugs.webkit.org/show_bug.cgi?id=172777
1535         rdar://problem/32495975
1536
1537         Reviewed by Aakash Jain.
1538
1539         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1540         (CheckPatchRelevance): Add a missing comma.
1541
1542 2017-05-31  Commit Queue  <commit-queue@webkit.org>
1543
1544         Unreviewed, rolling out r217611 and r217631.
1545         https://bugs.webkit.org/show_bug.cgi?id=172785
1546
1547         "caused wasm-hashset-many.html to become flaky." (Requested by
1548         keith_miller on #webkit).
1549
1550         Reverted changesets:
1551
1552         "Reland r216808, underlying lldb bug has been fixed."
1553         https://bugs.webkit.org/show_bug.cgi?id=172759
1554         http://trac.webkit.org/changeset/217611
1555
1556         "Use dispatch queues for mach exceptions"
1557         https://bugs.webkit.org/show_bug.cgi?id=172775
1558         http://trac.webkit.org/changeset/217631
1559
1560 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
1561
1562         EWS bots should reboot themselves more frequently
1563         https://bugs.webkit.org/show_bug.cgi?id=172402
1564
1565         Reviewed by Alexey Proskuryakov.
1566
1567         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
1568
1569         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
1570
1571 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
1572
1573         Reallocate hardware for iOS bots.
1574         https://bugs.webkit.org/show_bug.cgi?id=172657
1575
1576         Reviewed by Alexey Proskuryakov.
1577
1578         * BuildSlaveSupport/build.webkit.org-config/config.json:
1579
1580 2017-05-31  Andy Estes  <aestes@apple.com>
1581
1582         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
1583         https://bugs.webkit.org/show_bug.cgi?id=172366
1584
1585         Reviewed by Daniel Bates.
1586
1587         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1588
1589 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
1590
1591         Unreviewed, add Jiewen Tan as a reviewer
1592
1593         * Scripts/webkitpy/common/config/contributors.json:
1594
1595 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
1596
1597         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
1598         https://bugs.webkit.org/show_bug.cgi?id=172770
1599
1600         Reviewed by Michael Catanzaro.
1601
1602         * MiniBrowser/gtk/BrowserWindow.c:
1603         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
1604         which caused the body of the if-clause to be accidentally empty.
1605
1606 2017-05-31  Keith Miller  <keith_miller@apple.com>
1607
1608         Reland r216808, underlying lldb bug has been fixed.
1609         https://bugs.webkit.org/show_bug.cgi?id=172759
1610
1611         Unreviewed, relanding old patch. See: rdar://problem/31183352
1612
1613         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1614         (runThreadMessageTest):
1615         (TEST):
1616
1617 2017-05-31  Matt Lewis  <jlewis3@apple.com>
1618
1619         Unreviewed, rolling out r217603.
1620
1621         This patch broke the internal builds.
1622
1623         Reverted changeset:
1624
1625         "Get <chrono> out of StdLibExtras.h"
1626         https://bugs.webkit.org/show_bug.cgi?id=172744
1627         http://trac.webkit.org/changeset/217603
1628
1629 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
1630
1631         Make ResourceLoadStatistics testing more reliable
1632         https://bugs.webkit.org/show_bug.cgi?id=172730
1633         <rdar://problem/32028373>
1634
1635         Reviewed by Andy Estes.
1636
1637         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
1638         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
1639
1640         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1641         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1642
1643 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1644
1645         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
1646         https://bugs.webkit.org/show_bug.cgi?id=172757
1647
1648         Reviewed by Xabier Rodriguez-Calvar.
1649
1650         When needed, add the jhbuild wrapper at the beginning of the array
1651         that will be invoked to execute the run-jsc-stress-test or testapi
1652         commands.
1653
1654         * Scripts/run-javascriptcore-tests:
1655         (runJSCStressTests):
1656         * Scripts/webkitdirs.pm:
1657         (shouldUseJhbuild):
1658
1659 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
1660
1661         Get <chrono> out of StdLibExtras.h
1662         https://bugs.webkit.org/show_bug.cgi?id=172744
1663
1664         Reviewed by Saam Barati.
1665
1666         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1667
1668 2017-05-30  Tim Horton  <timothy_horton@apple.com>
1669
1670         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
1671         https://bugs.webkit.org/show_bug.cgi?id=172735
1672         <rdar://problem/32015977>
1673
1674         Reviewed by Enrica Casucci.
1675
1676         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1677         (WTR::UIScriptController::applyAutocorrection):
1678         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1679         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1680         (WTR::UIScriptController::applyAutocorrection):
1681         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1682         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1683         (WTR::UIScriptController::applyAutocorrection):
1684         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
1685         because I don't know how to tap the button in the autocorrection bar from a test.
1686
1687 2017-05-30  Daniel Bates  <dabates@apple.com>
1688
1689         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
1690         https://bugs.webkit.org/show_bug.cgi?id=172671
1691
1692         Reviewed by Alex Christensen.
1693
1694         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
1695         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
1696
1697         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
1698         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
1699         to trigger a navigation to test it.
1700         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
1701         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
1702
1703 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
1704
1705         webkitpy: Start servers before setting-up for testing
1706         https://bugs.webkit.org/show_bug.cgi?id=172176
1707         <rdar://problem/32225538>
1708
1709         Reviewed by Alexey Proskuryakov.
1710
1711         On-device testing requires that servers are started before ports set-up their
1712         test environments.
1713
1714         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1715         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
1716         Servers are unconditionally stopped on exit.
1717         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
1718         Manager now stops servers.
1719         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
1720         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
1721         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1722         (Manager.__init__): Delay construction of the test runner until we can determine
1723         if servers need to be started.
1724         (Manager.run): Determine if servers need to be started and construct the test runner.
1725         Shut servers down when the test run is finished.
1726         (Manager._run_tests): Move the determination of servers to run into Manager.run.
1727         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1728         (is_wpt_server_running): Server is not running if no config is found.
1729         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1730         (PyWebSocket.is_running): Check if this WebSocket server is running.
1731         * Scripts/webkitpy/port/base.py:
1732         (Port.__init__): Define secure WebSocket server.
1733         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
1734
1735 2017-05-30  Daniel Bates  <dabates@apple.com>
1736
1737         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
1738         https://bugs.webkit.org/show_bug.cgi?id=172603
1739         <rdar://problem/32471306>
1740
1741         Reviewed by Brady Eidson.
1742
1743         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
1744         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
1745         unloading is initiated for a page that registered a onbeforeunload handler.
1746
1747         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
1748         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
1749         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
1750
1751         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
1752         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
1753         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
1754         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
1755
1756         * MiniBrowser/mac/WK2BrowserWindowController.m:
1757         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1758         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
1759         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
1760         (sawDialog):
1761         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1762         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1763         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1764
1765 2017-05-30  Alex Christensen  <achristensen@webkit.org>
1766
1767         Update libwebrtc configuration
1768         https://bugs.webkit.org/show_bug.cgi?id=172727
1769
1770         Reviewed by Geoffrey Garen.
1771
1772         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1773
1774 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1775
1776         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
1777         https://bugs.webkit.org/show_bug.cgi?id=172702
1778
1779         Reviewed by Alex Christensen.
1780
1781         EGL PlatformDisplay needs to be shut down before existing a
1782         program on Windows.
1783
1784         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
1785         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
1786         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1787         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
1788
1789 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
1790
1791         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
1792         https://bugs.webkit.org/show_bug.cgi?id=172709
1793
1794         Reviewed by Brent Fulgham.
1795
1796         Exit fullscreen mode after a fullscreen test.
1797
1798         * DumpRenderTree/win/DumpRenderTree.cpp:
1799         (resetWebViewToConsistentStateBeforeTesting):
1800
1801 2017-05-30  Antti Koivisto  <antti@apple.com>
1802
1803         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
1804         https://bugs.webkit.org/show_bug.cgi?id=172713
1805
1806         Reviewed by Zalan Bujtas.
1807
1808         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1809         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
1810
1811             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
1812             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
1813             because on Mac WK1 it may get invoked from middle of a layout.
1814
1815             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
1816
1817 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1818
1819         Add a WPE EWS queue
1820         https://bugs.webkit.org/show_bug.cgi?id=172693
1821
1822         Reviewed by Carlos Garcia Campos.
1823
1824         * QueueStatusServer/config/queues.py:
1825         * QueueStatusServer/model/queues.py: Capitalize the name of the
1826         port on the tooltip of the bubbles. Do the same for the GTK port.
1827         (Queue.display_name):
1828         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
1829         for the GTK+ EWS also. Set for both ports as watcher the alias
1830         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
1831         * Scripts/webkitpy/common/config/ports.py:
1832         (DeprecatedPort.port):
1833         (WpePort):
1834         (WpePort.build_webkit_command):
1835         (WpePort.run_webkit_tests_command):
1836         * Scripts/webkitpy/common/config/ports_unittest.py:
1837         (DeprecatedPortTest):
1838         (DeprecatedPortTest.test_wpe_port):
1839         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1840         (test_ews_name):
1841
1842 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
1843
1844         Unreviewed. Bumping the WPEBackend-mesa dependency version.
1845
1846         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
1847         priorities for IPC communication.
1848
1849 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
1850
1851         [JSC] Map and Set constructors should have fast path for cloning
1852         https://bugs.webkit.org/show_bug.cgi?id=172413
1853
1854         Reviewed by Saam Barati.
1855
1856         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1857         (TestWebKitAPI::TEST):
1858
1859 2017-05-27  Zalan Bujtas  <zalan@apple.com>
1860
1861         enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
1862         https://bugs.webkit.org/show_bug.cgi?id=172676
1863
1864         Reviewed by Simon Fraser.
1865
1866         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
1867         (TestWebKitAPI::TEST):
1868
1869 2017-05-26  Zalan Bujtas  <zalan@apple.com>
1870
1871         TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
1872         https://bugs.webkit.org/show_bug.cgi?id=172674
1873
1874         Reviewed by Simon Fraser.
1875
1876         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
1877         (TestWebKitAPI::TEST):
1878
1879 2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1880
1881         Add test resources back into TestWebKitAPI Copy Resources phase
1882
1883         Rubber-stamped by Beth Dakin.
1884
1885         Add two files back into the Copy Resources phase after they were unintentionally
1886         removed in r217447 and r217496.
1887
1888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1889
1890 2017-05-26  Beth Dakin  <bdakin@apple.com>
1891
1892         Media documents inside iframes should not get controls in the TouchBar unless the 
1893         video is playing
1894         https://bugs.webkit.org/show_bug.cgi?id=172620
1895         -and corresponding-
1896         rdar://problem/32165477
1897
1898         Reviewed by Jon Lee.
1899
1900         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1901         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1902         (TestWebKitAPI::TEST):
1903         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
1904
1905 2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>
1906
1907         _WKUserStyleSheet and WKUserScript leak string data
1908         https://bugs.webkit.org/show_bug.cgi?id=172583
1909         <rdar://problem/32395209>
1910
1911         Reviewed by Sam Weinig.
1912
1913         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1914         We should not have been adopting an autoreleased object.
1915
1916 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
1917
1918         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
1919         https://bugs.webkit.org/show_bug.cgi?id=172554
1920         <rdar://problem/31247133>
1921
1922         Reviewed by Simon Fraser.
1923
1924         Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
1925         simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
1926         leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
1927         we should just tear down and rebuild the window whenever we need a layer-backed WebView.
1928         We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
1929         codepath.
1930
1931         * DumpRenderTree/TestOptions.h:
1932         * DumpRenderTree/TestOptions.mm:
1933         (TestOptions::TestOptions):
1934         (TestOptions::webViewIsCompatibleWithOptions):
1935         * DumpRenderTree/mac/DumpRenderTree.mm:
1936         (shouldIgnoreWebCoreNodeLeaks):
1937         (allowedFontFamilySet):
1938         (-[DRTMockScroller rectForPart:]):
1939         (-[DRTMockScroller drawKnob]):
1940         (-[DRTMockScroller drawRect:]):
1941         (createWebViewAndOffscreenWindow):
1942         (initializeGlobalsFromCommandLineOptions):
1943         (prepareConsistentTestingEnvironment):
1944         (dumpRenderTree):
1945         (dumpAudio):
1946         (dumpHistoryItem):
1947         (dumpBackForwardListForWebView):
1948         (resetWebViewToConsistentStateBeforeTesting):
1949         (WebThreadLockAfterDelegateCallbacksHaveCompleted):
1950         (runTest):
1951
1952 2017-05-25  Sam Weinig  <sam@webkit.org>
1953
1954         [WebIDL] Use the term 'operation' more consistently
1955         https://bugs.webkit.org/show_bug.cgi?id=172601
1956
1957         Reviewed by Chris Dumez.
1958
1959         We were using the term 'operation', a WebIDL term for function-like
1960         constructs, inconsistently in the code generator. Now, when we use
1961         'operation' when referring to the IDL concept (usually the object the
1962         parser produces) and 'function' when referring to code being generated.
1963
1964         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1965         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1966
1967 2017-05-25  Jer Noble  <jer.noble@apple.com>
1968
1969         Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.
1970
1971         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
1972
1973 2017-05-25  Jer Noble  <jer.noble@apple.com>
1974
1975         System sleeps while playing to wireless target, ending stream.
1976         https://bugs.webkit.org/show_bug.cgi?id=172541
1977
1978         Reviewed by Eric Carlson.
1979
1980         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1981         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
1982         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
1983         (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
1984         (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1985         (TestWebKitAPI::simulateKeyDown):
1986         (TestWebKitAPI::hasAssertionType):
1987         (TestWebKitAPI::TEST):
1988
1989 2017-05-25  Commit Queue  <commit-queue@webkit.org>
1990
1991         Unreviewed, rolling out r217423 and r217424.
1992         https://bugs.webkit.org/show_bug.cgi?id=172607
1993
1994         These caused an api failure on all testers. (Requested by
1995         mlewis13 on #webkit).
1996
1997         Reverted changesets:
1998
1999         "REGRESSION (r216977): 4 leaks introduced in new
2000         WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
2001         https://bugs.webkit.org/show_bug.cgi?id=172558
2002         http://trac.webkit.org/changeset/217423
2003
2004         "REGRESSION (r217423): Fix last-second typo in 'auto'"
2005         http://trac.webkit.org/changeset/217424
2006
2007 2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>
2008
2009         [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
2010         https://bugs.webkit.org/show_bug.cgi?id=172355
2011
2012         Reviewed by Chris Fleizach.
2013
2014         Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
2015         versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
2016         releases which support the new platform footnote accessibility role.
2017
2018         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2019         * gtk/jhbuild.modules:
2020
2021 2017-05-25  David Kilzer  <ddkilzer@apple.com>
2022
2023         REGRESSION (r217423): Fix last-second typo in 'auto'
2024
2025         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2026         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.
2027
2028 2017-05-24  David Kilzer  <ddkilzer@apple.com>
2029
2030         REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
2031         <https://webkit.org/b/172558>
2032
2033         Reviewed by Sam Weinig.
2034
2035         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2036         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.
2037
2038 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
2039
2040         [CMake] Consolidate CMake code related to Cairo
2041         https://bugs.webkit.org/show_bug.cgi?id=172568
2042
2043         Reviewed by Alex Christensen.
2044
2045         * DumpRenderTree/config.h:
2046         * TestWebKitAPI/config.h:
2047
2048 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2049
2050         Plumb additional image metadata to item providers when beginning data interaction on an image
2051         https://bugs.webkit.org/show_bug.cgi?id=172536
2052         <rdar://problem/32371300>
2053
2054         Reviewed by Beth Dakin.
2055
2056         Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
2057         source item providers.
2058
2059         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2060         (checkSuggestedNameAndEstimatedSize):
2061         (TestWebKitAPI::TEST):
2062
2063 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
2064
2065         [Win] Create unique network storage session for each DRT.
2066         https://bugs.webkit.org/show_bug.cgi?id=172540
2067
2068         Reviewed by Brent Fulgham.
2069
2070         During layout testing, each DRT instance should have its own network storage session.
2071
2072         * DumpRenderTree/win/DumpRenderTree.cpp:
2073         (prepareConsistentTestingEnvironment):
2074
2075 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2076
2077         Respect image UTIs when writing to item providers when beginning data interaction on an image
2078         https://bugs.webkit.org/show_bug.cgi?id=172436
2079         <rdar://problem/31786569>
2080
2081         Reviewed by Beth Dakin.
2082
2083         Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
2084         details.
2085
2086         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2087         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
2088         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.
2089
2090         Create a new test page containing a GIF and a file input.
2091
2092         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2093         (checkTypeIdentifierIsRegisteredAtIndex):
2094         (TestWebKitAPI::TEST):
2095
2096 2017-05-23  Per Arne Vollan  <pvollan@apple.com>
2097
2098         [Win] Increase test timeout for slow tests.
2099         https://bugs.webkit.org/show_bug.cgi?id=172449
2100
2101         Reviewed by Alexey Proskuryakov.
2102
2103         Instead of using a fixed timeout of 30 seconds for all tests, we should use the
2104         timeout member in the TestRunner class.
2105
2106         * DumpRenderTree/win/TestRunnerWin.cpp:
2107         (TestRunner::setWaitToDump):
2108
2109 2017-05-15  Matt Rajca  <mrajca@apple.com>
2110
2111         Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
2112         https://bugs.webkit.org/show_bug.cgi?id=172138
2113
2114         Reviewed by Alex Christensen.
2115
2116         Added API tests.
2117
2118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2119         * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
2120         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2121         (TEST):
2122         * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.
2123
2124 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
2125
2126         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
2127         https://bugs.webkit.org/show_bug.cgi?id=172522
2128         rdar://problem/31071812
2129
2130         Reviewed by Sam Weinig.
2131
2132         Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
2133         We set this in the .xib file now.
2134
2135         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2136
2137 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
2138
2139         Snapshotting via -renderInContext: should do synchronous image decodes
2140         https://bugs.webkit.org/show_bug.cgi?id=172485
2141         rdar://problem/32276146
2142
2143         Reviewed by Tim Horton.
2144
2145         New API test.
2146
2147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2148         * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.
2149         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
2150         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
2151         (TestWebKitAPI::getPixelIndex):
2152         (TestWebKitAPI::TEST):
2153
2154 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
2155
2156         Remove dead ENABLE(FONT_LOAD_EVENTS) code
2157         https://bugs.webkit.org/show_bug.cgi?id=172517
2158
2159         Rubber-stamped by Simon Fraser.
2160
2161         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2162
2163 2017-05-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2164
2165         Multiple links should be inserted separately when performing data interaction
2166         https://bugs.webkit.org/show_bug.cgi?id=172489
2167         <rdar://problem/31510832>
2168
2169         Reviewed by Dan Bernstein.
2170
2171         Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.
2172
2173         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2174         (TestWebKitAPI::TEST):
2175
2176 2017-05-23  Tim Horton  <timothy_horton@apple.com>
2177
2178         REGRESSION: API test WebKit2.WKObject is failing
2179         https://bugs.webkit.org/show_bug.cgi?id=172497
2180         <rdar://problem/31694641>
2181
2182         Reviewed by Geoff Garen.
2183
2184         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2185         (TestWebKitAPI::TEST):
2186         Add a test that ensures that we pretend to at least be *some* kind of
2187         NSString, which my first fix would not have passed.
2188
2189 2017-05-23  youenn fablet  <youenn@apple.com>
2190
2191         There should be an easy way to run HTTP/WPT served tests on a browser
2192         https://bugs.webkit.org/show_bug.cgi?id=172068
2193
2194         Reviewed by Sam Weinig.
2195
2196         Adding a new script open-layout-test to open a layout-test in a
2197         browser and making sure it is served as done through run-webkit-tests.
2198         In case tests should be run using a server, detecting whether the
2199         server are running. If not, calling run-webkit-httpd to run the
2200         servers and open the URL in a browser.
2201         Otherwise, open directly the URL.
2202
2203         Adding an option in run-webkit-httpd to open an URL after having
2204         started the servers.
2205
2206         Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
2207         This allows running run-webkit-httpd once and not having to restart
2208         servers everytime a test should be served.
2209
2210         Moving most of run-webkit-httpd logic in its own python file to reuse
2211         it in open-layout-test script.
2212
2213         Adding routines to check whether HTTP and WPT servers are running.
2214
2215         * Scripts/open-layout-test: Added.
2216         (parse_args):
2217         (main):
2218         * Scripts/run-webkit-httpd:
2219         (main):
2220         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2221         (LayoutTestFinder.find_tests):
2222         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2223         (LayoutTestRunner.run_tests):
2224         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2225         (parse_args):
2226         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2227         (HttpServerBase._is_server_running_on_all_ports):
2228         (HttpServerBase):
2229         (HttpServerBase._is_running_on_port):
2230         (HttpServerBase._check_that_all_ports_are_available):
2231         (is_http_server_running):
2232         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.
2233         (parse_args):
2234         (main):
2235         (run_server):
2236         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2237         (is_wpt_server_running):
2238         * Scripts/webkitpy/port/base.py:
2239         (Port.to.is_http_server_running):
2240         (Port.to):
2241         (Port.to.is_wpt_server_running):
2242         (Port.to.start_web_platform_test_server):
2243         * Scripts/webkitpy/port/driver.py:
2244         (DriverProxy.is_web_platform_test):
2245         (DriverProxy):
2246         (DriverProxy.is_webkit_specific_web_platform_test):
2247
2248 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
2249
2250         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
2251         https://bugs.webkit.org/show_bug.cgi?id=171984
2252
2253         Reviewed by Antti Koivisto.
2254
2255         * DumpRenderTree/mac/DumpRenderTree.mm:
2256         (enableExperimentalFeatures):
2257         * WebKitTestRunner/TestController.cpp:
2258         (WTR::TestController::resetPreferencesToConsistentValues):
2259
2260 2017-05-20  Alex Christensen  <achristensen@webkit.org>
2261
2262         REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
2263         https://bugs.webkit.org/show_bug.cgi?id=172406
2264         <rdar://32109532>
2265
2266         Reviewed by Brady Eidson.
2267
2268         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
2269         (TestWebKitAPI::checkBuffer):
2270         (TestWebKitAPI::TEST_F):
2271
2272 2017-05-22  Jason Marcell  <jmarcell@apple.com>
2273
2274         Do not enter Subversion-specific logic when parsing Git-based Trac data.
2275         https://bugs.webkit.org/show_bug.cgi?id=172433
2276         <rdar://problem/32234188>
2277
2278         Reviewed by Alexey Proskuryakov.
2279
2280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2281         (Trac.prototype._convertCommitInfoElementToObject):
2282
2283 2017-05-22  Tim Horton  <timothy_horton@apple.com>
2284
2285         ExplicitSnapshotsChangeUponNavigation API test often fails
2286         https://bugs.webkit.org/show_bug.cgi?id=172475
2287         <rdar://problem/31688322>
2288
2289         Reviewed by Simon Fraser.
2290
2291         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2292         (-[TestWKWebView _setUpTestWindow:]):
2293         Make TestWKWebView's window layer-backed. This is now the default,
2294         and it's also easy to accidentally write a test that depends on it
2295         (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
2296         which becomes layer backed, just like the WKWebView, but with no
2297         common layer-backed ancestor).
2298
2299 2017-05-22  youenn fablet  <youenn@apple.com>
2300
2301         Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
2302         https://bugs.webkit.org/show_bug.cgi?id=172426
2303
2304         Reviewed by Chris Dumez.
2305
2306         * Scripts/webkitpy/w3c/test_importer.py:
2307         (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.
2308
2309 2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>
2310
2311         Unreviewed, change my status to reviewer and fill "expertise" field
2312
2313         * Scripts/webkitpy/common/config/contributors.json:
2314
2315 2017-05-22  Tomas Popela  <tpopela@redhat.com>
2316
2317         Remove some of the EFL port leftovers
2318         https://bugs.webkit.org/show_bug.cgi?id=172440
2319
2320         Reviewed by Carlos Garcia Campos.
2321
2322         * BuildSlaveSupport/built-product-archive:
2323         (archiveBuiltProduct):
2324         (extractBuiltProduct):
2325         * BuildSlaveSupport/test-result-archive:
2326         (archiveTestResults):
2327         * ImageDiff/PlatformEfl.cmake: Removed.
2328         * Scripts/run-efl-tests: Removed.
2329         * Scripts/webkit-build-directory:
2330         * Scripts/webkitpy/common/config/contributionareas.py:
2331         * Scripts/webkitpy/common/config/watchlist:
2332         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2333         (parse_args):
2334         (_set_up_derived_options):
2335         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2336         (PerfTestsRunner.__init__):
2337         * Scripts/webkitpy/style/checker.py:
2338         * Scripts/webkitpy/style/checker_unittest.py:
2339         (GlobalVariablesTest.test_path_rules_specifier):
2340         * gtk/manifest.txt.in:
2341         * jhbuild/jhbuild-wrapper:
2342
2343 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2344
2345         Unreviewed. Do not include WPE files in GTK+ tarballs.
2346
2347         * gtk/manifest.txt.in:
2348
2349 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2350
2351         [GTK] Add webkit_context_menu_item_new_from_gaction
2352         https://bugs.webkit.org/show_bug.cgi?id=159631
2353
2354         Reviewed by Michael Catanzaro.
2355
2356         Update context menu tests to check the new GAction API.
2357
2358         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2359         (testContextMenuPopulateMenu):
2360
2361 2017-05-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2362
2363         [GTK] Remove Firefox user agent quirk for Google domains
2364         https://bugs.webkit.org/show_bug.cgi?id=171941
2365
2366         Reviewed by Carlos Garcia Campos.
2367
2368         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2369         (TestWebKitAPI::TEST):
2370         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.
2371
2372 2017-05-20  Ting-Wei Lan  <lantw44@gmail.com>
2373
2374         [GTK] gtkdoc-fixxref needs --module argument to work
2375         https://bugs.webkit.org/show_bug.cgi?id=172415
2376
2377         Reviewed by Michael Catanzaro.
2378
2379         * gtk/gtkdoc.py:
2380         (GTKDoc._run_gtkdoc_fixxref):
2381
2382 2017-05-20  Alexey Proskuryakov  <ap@apple.com>
2383
2384         make-new-script-test should create tests that use js-test.js, not js-test-pre.js
2385         https://bugs.webkit.org/show_bug.cgi?id=172416
2386
2387         Reviewed by Daniel Bates.
2388
2389         * Scripts/make-new-script-test:
2390
2391 2017-05-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2392
2393         [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
2394         https://bugs.webkit.org/show_bug.cgi?id=172267
2395
2396         Reviewed by Per Arne Vollan.
2397
2398         TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
2399         TestWebCoreLib should link only with WebCore. And, TestWebKitLib
2400         should link only with WebKit.
2401
2402         Unfortunately, there is a layer violation at the moment.
2403         WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
2404         in WebKit. This change contains a stub of loadResourceIntoBuffer
2405         in TestWebCoreLib for the workaround.
2406
2407         * TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
2408         TestWebCoreLib. Do not link WebCore to TestWebKitLib.
2409         * TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
2410         (loadResourceIntoBuffer): Added a stub.
2411
2412 2017-05-19  Simon Fraser  <simon.fraser@apple.com>
2413
2414         Fix dump-class-layout to handle different file architectures
2415         https://bugs.webkit.org/show_bug.cgi?id=172392
2416
2417         Reviewed by Zalan Bujtas.
2418
2419         Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
2420         and use the first architecture reported. Also add a "--architecture" argument
2421         to allow the user to specify an architecture.
2422
2423         * Scripts/dump-class-layout:
2424         (import_lldb):
2425         (verify_type_recursive):
2426         (get_first_file_architecture):
2427         (dump_class):
2428         (main):
2429         (find_build_directory): Deleted.
2430
2431 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
2432
2433         Unreviewed infrastructure fix.
2434
2435         * Scripts/webkitpy/port/ios_simulator.py:
2436         (IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
2437
2438 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
2439
2440         webkitpy: Use simctl boot to run multiple simulators at once
2441         https://bugs.webkit.org/show_bug.cgi?id=172374
2442
2443         Reviewed by Alexey Proskuryakov.
2444
2445         * Scripts/webkitpy/common/system/platforminfo.py:
2446         (PlatformInfo.xcode_version): Return the current version of Xcode.
2447         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2448         (MockPlatformInfo.xcode_version): Return version 8.0 for testing.
2449         * Scripts/webkitpy/port/ios_simulator.py:
2450         (IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
2451         run multiple Simulator.app instances.
2452         (IOSSimulatorPort._create_simulators): Only copy the simulator app for older
2453         versions of Xcode.
2454         (IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
2455         an older version of Xcode.
2456
2457 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2458
2459         Unreviewed, fix the build on the latest internal SDK.
2460
2461         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2462         (TestWebKitAPI::TEST):
2463
2464 2017-05-19  Filip Pizlo  <fpizlo@apple.com>
2465
2466         arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
2467         https://bugs.webkit.org/show_bug.cgi?id=172369
2468
2469         Reviewed by Mark Lam.
2470         
2471         Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
2472         would be a good idea to write this down.
2473
2474         * Scripts/run-jsc-stress-tests:
2475
2476 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
2477
2478         webkitpy: Layout tests which have no output will succeed
2479         https://bugs.webkit.org/show_bug.cgi?id=172322
2480         <rdar://problem/32258350>
2481
2482         Reviewed by David Kilzer.
2483
2484         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2485         (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.
2486         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2487         (determine_result_type): FailureNotTested means that the test could not be loaded. This
2488         is classified as a MISSING failure.
2489         (FailureNotTested): Added.
2490         (FailureNotTested.message):
2491
2492 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2493
2494         Add SixSpeed benchmark to PerformanceTests
2495         https://bugs.webkit.org/show_bug.cgi?id=172326
2496
2497         Reviewed by Sam Weinig.
2498
2499         * Scripts/run-jsc-benchmarks:
2500
2501 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2502
2503         [WK1] MiniBrowser should navigate when handling a dropped URL
2504         https://bugs.webkit.org/show_bug.cgi?id=172350
2505
2506         Reviewed by Tim Horton.
2507
2508         Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.
2509
2510         * MiniBrowser/mac/WK1BrowserWindowController.m:
2511         (-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
2512
2513 2017-05-18  Ryosuke Niwa  <rniwa@webkit.org>
2514
2515         REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
2516         https://bugs.webkit.org/show_bug.cgi?id=172077
2517
2518         Reviewed by Chris Dumez.
2519
2520         Fixed perftest.py by updating the lines to ignore in Speedometer.
2521
2522         Also start report the results as "Speedometer" instead of "DoYouEvenBench/Full.html" to perf.webkit.org.
2523
2524         * Scripts/webkitpy/performance_tests/perftest.py:
2525         (PerfTest._lines_to_ignore_in_parser_result): Updated for Speedometer 2.0.
2526         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2527         (PerfTestsRunner._collect_tests): Use "Speedometer" instead of "Speedometer/index.html" as the test name.
2528         (_generate_results_dict): Removed the workaround to keep reporting Speedometer as DoYouEvenBench.
2529         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2530         (MainTest.test_collect_tests_with_index_html_and_resources): Added.
2531
2532 2017-05-18  Andy Estes  <aestes@apple.com>
2533
2534         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
2535         https://bugs.webkit.org/show_bug.cgi?id=172305
2536
2537         Reviewed by Anders Carlsson.
2538
2539         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2540
2541 2017-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2542
2543         Selection around attachment elements should not persist when beginning a drag
2544         https://bugs.webkit.org/show_bug.cgi?id=172319
2545         <rdar://problem/32283008>
2546
2547         Reviewed by Tim Horton.
2548
2549         Tests that temporary selection around an attachment does not persist longer than it needs to.
2550
2551         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2552         (TestWebKitAPI::TEST):
2553
2554 2017-05-18  John Wilander  <wilander@apple.com>
2555
2556         Resource Load Statistics: Grandfather domains for existing data records
2557         https://bugs.webkit.org/show_bug.cgi?id=172155
2558         <rdar://problem/24913532>
2559
2560         Reviewed by Alex Christensen.
2561
2562         Adds test infrastructure needed for the added functionality.
2563
2564         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2565         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2566         (WTR::InjectedBundle::didReceiveMessageToPage):
2567         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2568         (WTR::TestRunner::setStatisticsGrandfathered):
2569         (WTR::TestRunner::isStatisticsGrandfathered):
2570         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2571         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
2572         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2573         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2574         * WebKitTestRunner/TestController.cpp:
2575         (WTR::TestController::setStatisticsGrandfathered):
2576         (WTR::TestController::isStatisticsGrandfathered):
2577         (WTR::TestController::setStatisticsGrandfatheringTime):
2578         * WebKitTestRunner/TestController.h:
2579         * WebKitTestRunner/TestInvocation.cpp:
2580         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2581
2582 2017-05-18  Saam Barati  <sbarati@apple.com>
2583
2584         WebAssembly: perform stack checks
2585         https://bugs.webkit.org/show_bug.cgi?id=165546
2586         <rdar://problem/29760307>
2587
2588         Reviewed by Filip Pizlo.
2589
2590         Add some new testing modes for using and not using fast TLS wasm contexts.
2591
2592         * Scripts/run-jsc-stress-tests:
2593
2594 2017-05-18  Daniel Bates  <dabates@apple.com>
2595
2596         REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
2597         window CSP when object-src 'none' is set
2598         https://bugs.webkit.org/show_bug.cgi?id=172038
2599         <rdar://problem/32258262>
2600
2601         Reviewed by Andy Estes.
2602
2603         Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
2604         When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().
2605
2606         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2607         (NPP_New):
2608
2609 2017-05-18  Per Arne Vollan  <pvollan@apple.com>
2610
2611         [Win] Many layout tests are failing.
2612         https://bugs.webkit.org/show_bug.cgi?id=172286
2613
2614         Reviewed by Brent Fulgham.
2615
2616         Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
2617  
2618         * DumpRenderTree/win/TestRunnerWin.cpp:
2619         (TestRunner::grantWebNotificationPermission):
2620         (TestRunner::denyWebNotificationPermission):
2621         (TestRunner::removeAllWebNotificationPermissions):
2622         (TestRunner::simulateWebNotificationClick):
2623
2624 2017-05-18  Don Olmstead  <don.olmstead@am.sony.com>
2625
2626         [Win] Remove usage of _snprintf
2627         https://bugs.webkit.org/show_bug.cgi?id=172251
2628
2629         Reviewed by Per Arne Vollan.
2630
2631         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2632         * MiniBrowser/win/PageLoadTestClient.cpp:
2633         (PageLoadTestClient::dumpRunStatistics):
2634
2635 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
2636
2637         Unreviewed, rolling out r217014.
2638
2639         This change caused mac-wk2 LayoutTests to exit early due to
2640         crashes.
2641
2642         Reverted changeset:
2643
2644         "Resource Load Statistics: Grandfather domains for existing
2645         data records"
2646         https://bugs.webkit.org/show_bug.cgi?id=172155
2647         http://trac.webkit.org/changeset/217014
2648
2649 2017-05-17  John Wilander  <wilander@apple.com>
2650
2651         Resource Load Statistics: Grandfather domains for existing data records
2652         https://bugs.webkit.org/show_bug.cgi?id=172155
2653         <rdar://problem/24913532>
2654
2655         Reviewed by Alex Christensen.
2656
2657         Adds test infrastructure needed for the added functionality.
2658
2659         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2660         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2661         (WTR::InjectedBundle::didReceiveMessageToPage):
2662         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2663         (WTR::TestRunner::setStatisticsGrandfathered):
2664         (WTR::TestRunner::isStatisticsGrandfathered):
2665         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2666         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
2667         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2668         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2669         * WebKitTestRunner/TestController.cpp:
2670         (WTR::TestController::setStatisticsGrandfathered):
2671         (WTR::TestController::isStatisticsGrandfathered):
2672         (WTR::TestController::setStatisticsGrandfatheringTime):
2673         * WebKitTestRunner/TestController.h:
2674         * WebKitTestRunner/TestInvocation.cpp:
2675         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2676
2677 2017-05-17  Alex Christensen  <achristensen@webkit.org>
2678
2679         Fix ios-simulator API test after r216977
2680         https://bugs.webkit.org/show_bug.cgi?id=171987
2681
2682         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2683         (TEST):
2684         <rdar://problem/32260156> covers the investigation of this, but fixing it is 
2685         not as urgent as having the rest of this working. Notably the ephemeral part of the
2686         test works, so something is just wrong with the persistent part.
2687
2688 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
2689
2690         Unreviewed, rolling out r216955.
2691
2692         This change caused strange behavior with web-platform-tests
2693         locally and on EWS.
2694
2695         Reverted changeset:
2696
2697         "webkitpy: Start servers before setting-up for testing"
2698         https://bugs.webkit.org/show_bug.cgi?id=172176
2699         http://trac.webkit.org/changeset/216955
2700
2701 2017-05-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2702
2703         A URL type is vended for a non-URL plain text string when starting data interaction
2704         https://bugs.webkit.org/show_bug.cgi?id=172228
2705         <rdar://problem/32166729>
2706
2707         Reviewed by Andy Estes.
2708
2709         Adds two new data interaction tests, SinglePlainTextWordTypeIdentifiers and SinglePlainTextURLTypeIdentifiers,
2710         to verify that a URL UTI is not vended when beginning a data interaction on a single word, but that a URL is
2711         still vended when beginning data interaction on something that resembles a link.
2712
2713         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2714
2715 2017-05-17  David Kilzer  <ddkilzer@apple.com>
2716
2717         BlobDataFileReference::generateReplacementFile() should use mkstemp()
2718         <https://webkit.org/b/172192>
2719
2720         Reviewed by Brent Fulgham.
2721
2722         * Scripts/webkitpy/style/checkers/cpp.py:
2723         (check_language): Add check for mktemp.
2724         (CppChecker): Add 'security/temp_file' category.
2725         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2726         (CppStyleTest.test_insecure_temp_file): Add test.
2727
2728 2017-05-17  Devin Rousso  <drousso@apple.com>
2729
2730         Unreviewed, change my email.
2731
2732         * Scripts/webkitpy/common/config/contributors.json:
2733
2734 2017-05-17  Matt Lewis  <jlewis3@apple.com>
2735
2736         Unreviewed, rolling out r216974.
2737
2738         Revision caused consistent timeouts on all platforms.
2739
2740         Reverted changeset:
2741
2742         "Add a RuntimeEnabledFeature for display: contents, defaulted
2743         to false."
2744         https://bugs.webkit.org/show_bug.cgi?id=171984
2745         http://trac.webkit.org/changeset/216974
2746
2747 2017-05-17  Alex Christensen  <achristensen@webkit.org>
2748
2749         Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
2750         https://bugs.webkit.org/show_bug.cgi?id=171987
2751
2752         Reviewed by Brady Eidson.
2753
2754         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2755         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2756         (TEST):
2757
2758 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
2759
2760         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
2761         https://bugs.webkit.org/show_bug.cgi?id=171984
2762
2763         Reviewed by Antti Koivisto.
2764
2765         * DumpRenderTree/mac/DumpRenderTree.mm:
2766         (enableExperimentalFeatures):
2767         * WebKitTestRunner/TestController.cpp:
2768         (WTR::TestController::resetPreferencesToConsistentValues):
2769
2770 2017-05-16  Timothy Horton  <timothy_horton@apple.com>
2771
2772         Fix the build
2773
2774         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2775         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2776
2777 2017-05-16  Tim Horton  <timothy_horton@apple.com>
2778
2779         PageVisibilityStateWithWindowChanges tests sometimes time out
2780         https://bugs.webkit.org/show_bug.cgi?id=172202
2781         <rdar://problem/29653266>
2782
2783         Reviewed by Dean Jackson.
2784
2785         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2786         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2787         Make sure the window is miniaturizable, otherwise, in some cases, miniaturize: will not work.
2788
2789 2017-05-16  Jonathan Bedard  <jbedard@apple.com>
2790
2791         webkitpy: Start servers before setting-up for testing
2792         https://bugs.webkit.org/show_bug.cgi?id=172176
2793         <rdar://problem/32225538>
2794
2795         Reviewed by Alexey Proskuryakov.
2796
2797         On-device testing requires that servers are started before ports set-up their
2798         test environments.
2799
2800         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2801         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
2802         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer.
2803         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2804         (Manager.__init__): Delay construction of the test runner until we can determine
2805         if servers need to be started.
2806         (Manager.run): Determine if servers need to be started and construct the test runner.
2807         (Manager._run_tests): Move the determination of servers to run into Manager.run.
2808
2809 2017-05-16  Adrian Perez de Castro  <aperez@igalia.com>
2810
2811         Unreviewed, adding myself to contributors.json
2812
2813         * Scripts/webkitpy/common/config/contributors.json:
2814
2815 2017-05-16  Claudio Saavedra  <csaavedra@igalia.com>
2816
2817         [GTK] Tests that always pass when run alone, but fail in the bots
2818         https://bugs.webkit.org/show_bug.cgi?id=168572
2819
2820         Reviewed by Michael Catanzaro.
2821
2822         PlatformWebView::viewSupportsOptions() is basically a comparison
2823         that checks that the passed options are the ones supported by the
2824         web view. There is no reason for them to be implemented for each
2825         platform differently. In fact doing so causes issues each time a
2826         new option is added, if the corresponding platform implementation
2827         is not updated accordingly.
2828
2829         A consequence of not updating the viewSupportOptions()
2830         implementations when new options are added is that tests that need
2831         these options might fail if they are executed after a test that
2832         didn't need the option, as the webview will be reused even if the
2833         option is not supported. This cannot be spotted when running the
2834         tests individually. See bug #165133 for other example of the same
2835         problem.
2836
2837         Remove the platform implementations and make the comparison a
2838         method of the TestOptions structure, so that the check is in one
2839         place. For the time being, only include in the comparison the
2840         options that were checked in the mac platform, which seem to be
2841         the only ones relevant this far (unless newer ones have also been
2842         forgotten).
2843
2844         * WebKitTestRunner/PlatformWebView.h:
2845         (WTR::PlatformWebView::viewSupportsOptions): Use the method
2846         defined below.
2847         * WebKitTestRunner/TestOptions.h:
2848         (WTR::TestOptions::hasSameInitializationOptions): Added.
2849         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2850         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2851         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2852         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2853         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2854         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2855         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
2856         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2857
2858 2017-05-15  Yusuke Suzuki  <utatane.tea@gmail.com>
2859
2860         [JSC] Build testapi in non Apple ports
2861         https://bugs.webkit.org/show_bug.cgi?id=172103
2862
2863         Reviewed by Filip Pizlo.
2864
2865         Now testapi is drived in JSCOnly, GTK and WPE ports too.
2866
2867         * Scripts/build-jsc:
2868         * Scripts/run-javascriptcore-tests:
2869
2870 2017-05-15  Youenn Fablet  <youenn@apple.com>
2871
2872         WPT test importer should not account for slow manual tests
2873         https://bugs.webkit.org/show_bug.cgi?id=172127
2874
2875         Reviewed by Ryosuke Niwa.
2876
2877         Making sure manual tests are not triggering updating tests-options.json file.
2878
2879         * Scripts/webkitpy/w3c/test_importer.py:
2880         (TestImporter.find_importable_tests):
2881         (TestImporter._already_identified_as_resource_file):
2882         (TestImporter.update_tests_options):
2883         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2884         (test_manual_slow_test):
2885
2886 2017-05-15  Jonathan Bedard  <jbedard@apple.com>
2887
2888         webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
2889         https://bugs.webkit.org/show_bug.cgi?id=172142
2890
2891         Reviewed by Tim Horton.
2892
2893         * Scripts/webkitpy/xcode/simulator.py:
2894         (Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
2895         around runtime identifiers.
2896         * Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.
2897
2898 2017-05-15  Ryosuke Niwa  <rniwa@webkit.org>
2899
2900         Update ARES-6 plan file to use the latest version
2901         https://bugs.webkit.org/show_bug.cgi?id=172139
2902
2903         Reviewed by Keith Miller.
2904
2905         Include r216538.
2906
2907         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2908
2909 2017-05-15  Jeremy Jones  <jeremyj@apple.com>
2910
2911         Disable Picture In Picture API tests on unsupported platforms.
2912         https://bugs.webkit.org/show_bug.cgi?id=172125
2913         rdar://problem/32199477
2914
2915         Reviewed by Simon Fraser.
2916
2917         The callbacks and allowing picture-in-picture require new SPI.
2918
2919         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
2920
2921 2017-05-15  Brady Eidson  <beidson@apple.com>
2922
2923         [ios-simulator] API test WKWebView.ClearAppCache is failing.
2924         https://bugs.webkit.org/show_bug.cgi?id=172120
2925
2926         Unreviewed test gardening.
2927
2928         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2929         (TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.
2930           Restoring that code fixes this.
2931
2932 2017-05-15  Timothy Horton  <timothy_horton@apple.com>
2933
2934         Null deref under WebContentReader::readURL when interacting with a file URL
2935         https://bugs.webkit.org/show_bug.cgi?id=172045
2936         <rdar://problem/25880647>
2937
2938         Reviewed by Wenson Hsieh.
2939
2940         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2941         (TestWebKitAPI::TEST):
2942         The text of the file URL is pasted because a textual version of it gets
2943         onto the pasteboard. However, this test would have crashed before. Also
2944         tests that we don't make an <a>.
2945
2946 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
2947
2948         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
2949         https://bugs.webkit.org/show_bug.cgi?id=172071
2950
2951         Reviewed by Alexey Proskuryakov.
2952
2953         * DumpRenderTree/win/DumpRenderTree.cpp:
2954         (resetWebPreferencesToConsistentValues):
2955
2956 2017-05-14  Chris Dumez  <cdumez@apple.com>
2957
2958         Drop PassRefPtr class from WTF
2959         https://bugs.webkit.org/show_bug.cgi?id=172091
2960
2961         Reviewed by Alex Christensen.
2962
2963         Drop API test coverage.
2964
2965         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2966         (TestWebKitAPI::TEST):
2967         (TestWebKitAPI::passWithPassRefPtr): Deleted.
2968
2969 2017-05-13  Eric Carlson  <eric.carlson@apple.com>
2970
2971         [MediaStream] deviceId constraint doesn't work with getUserMedia
2972         https://bugs.webkit.org/show_bug.cgi?id=171877
2973         <rdar://problem/31899730>
2974
2975         Reviewed by Jer Noble.
2976
2977         The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
2978         implement the "checkUserMediaPermission" callback.
2979         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2980         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
2981         (TestWebKitAPI::checkUserMediaPermissionCallback):
2982         (TestWebKitAPI::TEST):
2983
2984         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:
2985         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2986
2987 2017-05-13  Chris Dumez  <cdumez@apple.com>
2988
2989         Stop using RefPtr::release()
2990         https://bugs.webkit.org/show_bug.cgi?id=172074
2991
2992         Reviewed by Geoffrey Garen.
2993
2994         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2995         (TestWebKitAPI::TEST):
2996
2997 2017-05-13  Commit Queue  <commit-queue@webkit.org>
2998
2999         Unreviewed, rolling out r216808.
3000         https://bugs.webkit.org/show_bug.cgi?id=172075
3001
3002         caused lldb to hang when debugging (Requested by smfr on
3003         #webkit).
3004
3005         Reverted changeset:
3006
3007         "Use Mach exceptions instead of signals where possible"
3008         https://bugs.webkit.org/show_bug.cgi?id=171865
3009         http://trac.webkit.org/changeset/216808
3010
3011 2017-05-12  Alex Christensen  <achristensen@webkit.org>
3012
3013         Rename WKContentExtension to WKContentRuleList
3014         https://bugs.webkit.org/show_bug.cgi?id=172053
3015         <rdar://problem/32141005>
3016
3017         Reviewed by Geoffrey Garen.
3018
3019         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:
3020         (WKContentRuleListStoreTest::SetUp):
3021         (TEST_F):
3022         (-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3023         (WKContentExtensionStoreTest::SetUp): Deleted.
3024         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3025
3026 2017-05-12  Keith Miller  <keith_miller@apple.com>
3027
3028         Use Mach exceptions instead of signals where possible
3029         https://bugs.webkit.org/show_bug.cgi?id=171865
3030
3031         Reviewed by Mark Lam.
3032
3033         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3034         (runThreadMessageTest):
3035         (TEST):
3036
3037 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
3038
3039         Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
3040         https://bugs.webkit.org/show_bug.cgi?id=172048
3041         rdar://problem/32163054
3042
3043         Reviewed by Simon Fraser.
3044
3045         Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.
3046
3047         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
3048         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
3049         (hasVideoInPictureInPictureDidChange):
3050         (-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
3051         (-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
3052         (TestWebKitAPI::TEST):
3053
3054 2017-05-12  Brady Eidson  <beidson@apple.com>
3055
3056         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3057         https://bugs.webkit.org/show_bug.cgi?id=172030
3058
3059         Unreviewed - Test gardening
3060
3061         Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
3062         before the test starts.
3063
3064         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3065         (defaultWebsiteCacheDirectory):
3066         (defaultApplicationCacheDirectory):
3067         (TEST):
3068         (defaultWebsiteDataDirectory): Deleted.
3069
3070 2017-05-12  David Quesada  <david_quesada@apple.com>
3071
3072         Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
3073         https://bugs.webkit.org/show_bug.cgi?id=172000
3074         rdar://problem/32144756
3075
3076         Reviewed by Simon Fraser.
3077
3078         Added API tests to verify that WKWebView provides the expected value for
3079         _visibleContentRect in various configurations. (i.e. not inside a scrollview,
3080         inside a scrollview but not clipped, clipped by an ancestor scrollview,
3081         clipped by the webview's _enclosingViewForExposedRectComputation)
3082
3083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3084         * TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.
3085         (-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
3086         (TestWebKitAPI::TEST):
3087
3088 2017-05-12  Brady Eidson  <beidson@apple.com>
3089
3090         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3091         https://bugs.webkit.org/show_bug.cgi?id=172030
3092
3093         Unreviewed - Test gardening, in effect...
3094
3095         More exploration as to why this continues to fail on the bots.
3096         
3097         This change should give us a smoking gun.
3098         
3099         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3100         (TEST):
3101
3102 2017-05-12  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3103
3104         [GTK] Fix compile warnings in PlatformImageCairo.cpp
3105         https://bugs.webkit.org/show_bug.cgi?id=171850
3106
3107         Reviewed by Michael Catanzaro.
3108
3109         * ImageDiff/cairo/PlatformImageCairo.cpp:
3110         (ImageDiff::PlatformImage::createFromStdin):
3111         (ImageDiff::PlatformImage::writeAsPNGToStdout):
3112
3113 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
3114
3115         Add UIClient callback for when picture-in-picture is activated.
3116         https://bugs.webkit.org/show_bug.cgi?id=172023
3117
3118         Reviewed by Simon Fraser.
3119
3120         Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.
3121
3122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3123         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
3124         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.
3125         (onLoadedCompletedCallback):
3126         (waitUntilOnLoadIsCompleted):
3127         (didFinishLoadForFrame):
3128         (setHasVideoInPictureInPicture):
3129         (TestWebKitAPI::TEST):
3130
3131 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
3132
3133         Unreviewed follow-up to r216776.
3134
3135         * Scripts/webkitpy/port/base.py:
3136         (Port.path_to_crash_logs): Raise not implemented.
3137         * Scripts/webkitpy/port/test.py:
3138         (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
3139         * Scripts/webkitpy/port/win.py:
3140         (WinPort.path_to_crash_logs): Ditto.
3141
3142 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
3143
3144         Bot watcher's dashboard shows results links twice sometimes
3145         https://bugs.webkit.org/show_bug.cgi?id=172043
3146
3147         Reviewed by Tim Horton.
3148
3149         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3150         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
3151
3152 2017-05-12  Brady Eidson  <beidson@apple.com>
3153
3154         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3155         https://bugs.webkit.org/show_bug.cgi?id=172030
3156
3157         Unreviewed - Test gardening, in effect...
3158
3159         This failure is only being seen by the bots.
3160         
3161         I believe this test is utterly broken in the first place; when it checks the .wal file's
3162         size that is not actually an indicator that the records were deleted.
3163         
3164         But that isn't what's coming up as failure on the bots.
3165         
3166         This patch is an attempt to:
3167         1 - More forcefully clear the Website data directory of leftovers before the test starts.
3168         2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.
3169
3170         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3171         (defaultWebsiteDataDirectory):
3172         (defaultApplicationCacheDirectory):
3173         (TEST):
3174
3175 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
3176
3177         webkitpy: Pass directory with crash logs into CrashLogs
3178         https://bugs.webkit.org/show_bug.cgi?id=172033
3179         <rdar://problem/32157616>
3180
3181         Reviewed by Daniel Bates.
3182
3183         Refactor CrashLogs and the callers of CrashLogs so that the port object owns
3184         the location of crash logs.
3185
3186         * Scripts/webkitpy/common/system/crashlogs.py:
3187         (CrashLogs.__init__): Pass mandatory crash_log_directory when constructing.
3188         (CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
3189         generating one.
3190         (CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
3191         self._results_directory.
3192         (CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
3193         generating one.
3194         (CrashLogs._log_directory_darwin): Moved to port.
3195         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path
3196         to the crash log is no longer owned by CrashLogs.
3197         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general
3198         directory for uploading crash logs. Note that crash logs are only supported on Mac
3199         and Windows.
3200         * Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
3201         * Scripts/webkitpy/port/base.py:
3202         (Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
3203         to be in the results directory.
3204         * Scripts/webkitpy/port/darwin.py:
3205         (DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
3206         (DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
3207         (DarwinPort._get_crash_log): Ditto.
3208         * Scripts/webkitpy/port/darwin_testcase.py:
3209         (DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
3210         the path to crash logs.
3211         * Scripts/webkitpy/port/ios_device.py:
3212         (IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.
3213         * Scripts/webkitpy/port/ios_device_unittest.py:
3214         (IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.
3215         * Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
3216         * Scripts/webkitpy/port/mac.py: Ditto.
3217         * Scripts/webkitpy/port/test.py:
3218         (TestDriver.run_test): Use port specific crash log path when retrieving crash logs.
3219         * Scripts/webkitpy/port/win.py:
3220         (WinPort._get_crash_log): Ditto.
3221         * Scripts/webkitpy/tool/commands/queries.py:
3222         (execute): Construct a port object since this is the object which owns the path to crash logs.
3223
3224 2017-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3225
3226         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.
3227
3228         In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
3229         URL parameter using the default value "about:blank" when not provided.
3230
3231         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3232         (testWebViewCreateNavigationData):
3233
3234 2017-05-11  Youenn Fablet  <youenn@apple.com>
3235
3236         Allow WPT server to serve specific WebKit test
3237         https://bugs.webkit.org/show_bug.cgi?id=171479
3238
3239         Reviewed by Ryosuke Niwa.
3240
3241         Adding a new mount point to WPT server.
3242         It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.
3243
3244         Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.
3245
3246         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3247         (Manager.__init__):
3248         (Manager._is_http_test):
3249         (Manager._needs_web_platform_test):
3250         (Manager._run_tests):
3251         (Manager._is_web_platform_test): Deleted.
3252         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3253         (build_routes):
3254         (main):
3255         * Scripts/webkitpy/port/driver.py:
3256         (Driver):
3257         (Driver.is_webkit_specific_web_platform_test):
3258         (Driver.test_to_uri):
3259         (Driver._command_from_driver_input):
3260
3261 2017-05-11  Brady Eidson  <beidson@apple.com>
3262
3263         [WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
3264         <rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994
3265
3266         Reviewed by Andy Estes.
3267         Informal review by Maureen Daum.
3268
3269         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3270         (TEST):
3271
3272 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
3273
3274         REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
3275         https://bugs.webkit.org/show_bug.cgi?id=171989
3276
3277         Reviewed by Brian Burg.
3278
3279         * lldb/lldb_webkit.py:
3280         (WTFStringImplProvider.get_data8):
3281         (WTFStringImplProvider.get_data16):
3282         m_data8 and m_data16 are now part of the superclass StringImplShape
3283         instead of directly in StringImpl. So first get the shape by getting
3284         index 0, and the data properties are the same offset within that.
3285
3286 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
3287
3288         Remove Vibration API
3289         https://bugs.webkit.org/show_bug.cgi?id=171766
3290
3291         Rubber-stamped by Alexey Proskuryakov.
3292
3293         * Scripts/webkitperl/FeatureList.pm:
3294
3295 2017-05-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3296
3297         Add WPE release bots
3298         https://bugs.webkit.org/show_bug.cgi?id=171973
3299
3300         Reviewed by Žan Doberšek.
3301
3302         This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
3303         It also adds a new WPE buildbot category.
3304
3305         * BuildSlaveSupport/build.webkit.org-config/config.json:
3306         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3307         (InstallWpeDependencies):
3308         (appendCustomBuildFlags):
3309         (Factory.__init__):
3310         (loadBuilderConfig):
3311         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3312         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3313
3314 2017-05-09  Sam Weinig  <sam@webkit.org>
3315
3316         Remove support for legacy Notifications
3317         https://bugs.webkit.org/show_bug.cgi?id=171487
3318
3319         Reviewed by Jon Lee.
3320
3321         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3322         (DRTDesktopNotificationPresenter::checkNotificationPermission):
3323         * Scripts/webkitperl/FeatureList.pm:
3324         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3325         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
3326
3327 2017-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3328
3329         Remove user agent quirk for Slack
3330         https://bugs.webkit.org/show_bug.cgi?id=171869
3331
3332         Reviewed by Carlos Garcia Campos.
3333
3334         Remove the corresponding test.
3335
3336         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3337         (TestWebKitAPI::TEST):
3338
3339 2017-05-10  Commit Queue  <commit-queue@webkit.org>
3340
3341         Unreviewed, rolling out r216578.
3342         https://bugs.webkit.org/show_bug.cgi?id=171920
3343
3344         Broke the GTK+ build with Wayland enabled (Requested by KaL on
3345         #webkit).
3346
3347         Reverted changeset:
3348
3349         "[GTK] Bump GTK+ and its dependencies in jhbuild"
3350         https://bugs.webkit.org/show_bug.cgi?id=171918
3351         http://trac.webkit.org/changeset/216578
3352
3353 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3354
3355         [GTK] Bump GTK+ and its dependencies in jhbuild
3356         https://bugs.webkit.org/show_bug.cgi?id=171918
3357
3358         Reviewed by Carlos Alberto Lopez Perez.
3359
3360         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3361         (WTR::initializeGtkSettings):
3362         * gtk/jhbuild.modules:
3363         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
3364         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
3365
3366 2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>
3367
3368         [Win] Set CMake args in build-webkit
3369         https://bugs.webkit.org/show_bug.cgi?id=171436
3370
3371         Reviewed by Per Arne Vollan.
3372
3373         * Scripts/build-webkit:
3374
3375 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3376
3377         ImageDiff: Add CG implementation for new ImageDiff
3378         https://bugs.webkit.org/show_bug.cgi?id=170608
3379
3380         Reviewed Alex Christensen.
3381
3382         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3383         * DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
3384         * DumpRenderTree/win/ImageDiffWin.cpp: Removed.
3385         * ImageDiff/CMakeLists.txt:
3386         * ImageDiff/Cairo.cmake:
3387         * ImageDiff/ImageDiff.cpp:
3388         (main):
3389         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3390         * ImageDiff/PlatformImage.cpp:
3391         * ImageDiff/PlatformImage.h:
3392         * ImageDiff/cairo/PlatformImageCairo.cpp:
3393         * ImageDiff/cg/ImageDiff.cpp: Removed.
3394         * ImageDiff/cg/PlatformImageCG.cpp: Added.
3395         (ImageDiff::PlatformImage::createFromStdin):
3396         (ImageDiff::PlatformImage::createFromDiffData):
3397         (ImageDiff::PlatformImage::PlatformImage):
3398         (ImageDiff::PlatformImage::~PlatformImage):
3399         (ImageDiff::PlatformImage::width):
3400         (ImageDiff::PlatformImage::height):
3401         (ImageDiff::PlatformImage::rowBytes):
3402         (ImageDiff::PlatformImage::hasAlpha):
3403         (ImageDiff::PlatformImage::pixels):
3404         (ImageDiff::PlatformImage::writeAsPNGToStdout):
3405
3406 2017-05-10  Zan Dobersek  <zdobersek@igalia.com>
3407
3408         Enable FTL JIT by default on AArch64
3409         https://bugs.webkit.org/show_bug.cgi?id=144039
3410
3411         Reviewed by Yusuke Suzuki.
3412
3413         * Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
3414         * Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
3415         as an unsupported FTL platform.
3416         * Scripts/webkitdirs.pm:
3417         (isARM64): Returns 1 if the determined architecture is 'arm64'.
3418         * Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
3419
3420 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
3421
3422         webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
3423         https://bugs.webkit.org/show_bug.cgi?id=170857
3424         <rdar://problem/31635373>
3425
3426         Reviewed by Aakash Jain.
3427
3428         Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
3429         code to search for crash logs.
3430
3431         * Scripts/webkitpy/port/darwin.py:
3432         (DarwinPort._get_crash_log): Moved from MacPort.
3433         * Scripts/webkitpy/port/darwin_testcase.py:
3434         (DarwinTest.test_get_crash_log): Moved from MacTest.
3435         * Scripts/webkitpy/port/ios_device.py:
3436         (IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
3437         devices must search for crash-logs remotely.
3438         * Scripts/webkitpy/port/ios_simulator.py:
3439         (IOSSimulatorPort._get_crash_log): Deleted.
3440         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3441         (IOSSimulatorTest.test_get_crash_log): Deleted.
3442         * Scripts/webkitpy/port/mac.py:
3443         (MacPort._get_crash_log): Moved to DarwinPort
3444         * Scripts/webkitpy/port/mac_unittest.py:
3445         (MacTest.test_get_crash_log): Moved to DarwinTest.
3446
3447 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
3448
3449         build ImageDiff with host SDK from Make
3450         https://bugs.webkit.org/show_bug.cgi?id=171835
3451
3452         Reviewed by Alexey Proskuryakov.
3453
3454         ImageDiff should be built for the default SDK and default architecture when
3455         the SDKROOT is set to either iOS device or iOS simulator. Check the
3456         DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.
3457
3458         * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
3459         * Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.
3460
3461 2017-05-09  Matt Lewis  <jlewis3@apple.com>
3462
3463         Unreviewed, adding myself to contributors.json
3464
3465         * Scripts/webkitpy/common/config/contributors.json:
3466
3467 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
3468
3469         REGRESSION: ImageDiff not building with make
3470         https://bugs.webkit.org/show_bug.cgi?id=171788
3471
3472         Reviewed by Alex Christensen.
3473
3474         * Makefile: Build ImageDiff for all platforms.
3475
3476 2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3477
3478         [Win] ImageDiff isn't built since Bug 168945
3479         https://bugs.webkit.org/show_bug.cgi?id=171847
3480
3481         Reviewed by Alex Christensen.
3482
3483         * CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
3484         * ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
3485         * ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.
3486
3487 2017-05-09  Zan Dobersek  <zdobersek@igalia.com>
3488
3489         Upstream the WPE port
3490         https://bugs.webkit.org/show_bug.cgi?id=171110
3491
3492         Reviewed by Alex Christensen.
3493
3494         webkit-dev thread:
3495         https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html
3496
3497         Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
3498         In-file changes removed from this ChangeLog entry for brevity.
3499
3500         * BuildSlaveSupport/built-product-archive:
3501         * BuildSlaveSupport/test-result-archive:
3502         * CMakeLists.txt:
3503         * ImageDiff/PlatformWPE.cmake: Added.
3504         * Scripts/build-dumprendertree:
3505         * Scripts/build-webkit:
3506         * Scripts/build-webkittestrunner:
3507         * Scripts/update-webkit-libs-jhbuild:
3508         * Scripts/update-webkitwpe-libs: Added.
3509         * Scripts/webkitdirs.pm:
3510         * Scripts/webkitperl/FeatureList.pm:
3511         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3512         * Scripts/webkitpy/port/factory.py:
3513         * Scripts/webkitpy/port/wpe.py: Added.
3514         * TestWebKitAPI/PlatformWPE.cmake: Added.
3515         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3516         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
3517         * TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3518         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3519         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3520         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3521         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3523         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3524         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
3525         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
3526         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
3527         * WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3528         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3529         * WebKitTestRunner/PlatformWPE.cmake: Added.
3530         * WebKitTestRunner/PlatformWebView.h:
3531         * WebKitTestRunner/TestController.cpp:
3532         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
3533         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
3534         * WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
3535         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
3536         * WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
3537         * WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3538         * jhbuild/jhbuild-wrapper:
3539         * wpe/generate-inspector-gresource-manifest.py: Added.
3540         * wpe/jhbuild.modules: Added.
3541         * wpe/jhbuildrc: Added.
3542         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
3543         * wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
3544         * wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
3545         * wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
3546         * wpe/patches/glib-warning-fix.patch: Added.
3547         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
3548         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
3549         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3550         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3551         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.
3552
3553 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
3554
3555         Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
3556         https://bugs.webkit.org/show_bug.cgi?id=169421
3557         <rdar://problem/30950171>
3558
3559         Reviewed by Tim Horton.
3560
3561         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3562         (createBitmapContextFromWebView): Implement for IOSurface.
3563         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3564         (WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.
3565
3566 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
3567
3568         buildbot: Cleanup simulators after running tests
3569         https://bugs.webkit.org/show_bug.cgi?id=171679
3570
3571         Reviewed by Aakash Jain.
3572
3573         simctl is partitioned for each user. Since kill-old-processes
3574         is run as root, we need to specify the buildbot user when tearing
3575         down simulators between steps.
3576
3577         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3578         (KillOldProcesses): Pass buildbot user to kill-old-processes.
3579         * BuildSlaveSupport/kill-old-processes:
3580         (main): Specify the user for simctl if one has been provided.
3581
3582 2017-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3583
3584         REGRESSION(r216179): [GTK] Script install-dependencies misses liborc
3585         https://bugs.webkit.org/show_bug.cgi?id=171681
3586
3587         Reviewed by Carlos Garcia Campos.
3588
3589         * gtk/install-dependencies:
3590
3591 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3592
3593         Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.
3594
3595         Glib uses now Unicode quotes in error messages.
3596
3597         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
3598         (testWebKitConsoleMessageNetworkError):
3599
3600 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3601
3602         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404.
3603
3604         Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
3605         should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
3606         characters to the input. Also fix typo in the function name.
3607
3608         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3609         (testWebViewJavaScriptDialogs):
3610
3611 2017-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3612
3613         [GTK] Cannot sign in with new Google sign-in page
3614         https://bugs.webkit.org/show_bug.cgi?id=171770
3615
3616         Unreviewed. This just adds a test.
3617
3618         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3619         (TestWebKitAPI::TEST):
3620
3621 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
3622
3623         [iOS WK2] Make rotation tests more reliable
3624         https://bugs.webkit.org/show_bug.cgi?id=171778
3625
3626         Reviewed by Tim Horton.
3627
3628         Switching between "safari-style" rotation and normal rotation left state on the WKWebView
3629         that would cause later viewport-sensitive tests to fail. The WKWebView would be left
3630         with override layout parameters, and an override orientation, and these caused viewport
3631         size to leak into later tests, and WebCore orientation to not get reset correctly.
3632
3633         Also, WKWebView was unregistering for UIWindowDidRotateNotification notifications when
3634         an override orientation was set, and would never re-register, causing lost orientationchanged
3635         events.
3636
3637         Fix by exposing WKWebView SPI to clear the various bits of overide state. Also don't unregister
3638         from the UIWindowDidRotateNotification notification; it's already ignored anyway if it fires.
3639
3640         Also wait for a visible content rect update after resizing the WKWebVeiw between tests, to make sure
3641         the WebProcess is caught up before proceeding with the test.
3642
3643         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3644         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
3645         * WebKitTestRunner/ios/TestControllerIOS.mm:
3646         (WTR::TestController::platformResetStateToConsistentValues):
3647         (WTR::TestController::platformConfigureViewForTest):
3648
3649 2017-05-06  Csaba Osztrogonác  <ossy@webkit.org>
3650
3651         [Mac][cmake] Buildfix after r216047
3652         https://bugs.webkit.org/show_bug.cgi?id=171769
3653
3654         Unreviewed buildfix.
3655
3656         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3657
3658 2017-05-05  Brady Eidson  <beidson@apple.com>
3659
3660         API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
3661         <rdar://problem/31977294> and https://bugs.webkit.org/show_bug.cgi?id=171513
3662
3663         Reviewed by Andy Estes.
3664
3665         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3666         (TEST):
3667
3668 2017-05-05  Brian Burg  <bburg@apple.com>
3669
3670         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
3671         https://bugs.webkit.org/show_bug.cgi?id=171748
3672         <rdar://problem/32027327>
3673
3674         Reviewed by Michael Catanzaro.
3675
3676         Remove temporary workaround now that the assertion failure is fixed.
3677
3678         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3679         (TEST):
3680
3681 2017-05-05  Simon Fraser  <simon.fraser@apple.com>
3682
3683         Make it possible to test rotation in iOS WebKitTestRunner
3684         https://bugs.webkit.org/show_bug.cgi?id=171755
3685
3686         Reviewed by Tim Horton.
3687
3688         Add to UIScriptController:
3689             void simulateRotation(DeviceOrientation orientation, object callback);
3690             void simulateRotationLikeSafari(DeviceOrientation orientation, object callback);
3691
3692         The former just does a view resize, as a simple WKWebView app would do. The second does
3693         animation more like MobileSafari, using _begin/_endAnimatedResize. and associated override
3694         layout size and interface orientation. The two behaviors produce different resize and
3695         orientationchange events and sizes, and both need to be tested.
3696
3697         Rotation is initiated by a call on UIDevice, and responded to by the root view controller,
3698         which is now a custom subclass (PlatformWebViewController).
3699
3700         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3701         (WTR::UIScriptController::simulateRotation):
3702         (WTR::UIScriptController::simulateRotationLikeSafari):
3703         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3704         (WTR::UIScriptController::simulateRotation):
3705         (WTR::UIScriptController::simulateRotationLikeSafari):
3706         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3707         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3708         (WTR::toDeviceOrientation):
3709         (WTR::UIScriptController::simulateRotation):
3710         (WTR::UIScriptController::simulateRotationLikeSafari):
3711         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3712         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3713         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3714         (-[TestRunnerWKWebView dealloc]):
3715         (-[TestRunnerWKWebView _didEndRotation]):
3716         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3717         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
3718         (WTR::PlatformWebView::PlatformWebView):
3719         * WebKitTestRunner/ios/TestControllerIOS.mm:
3720         (WTR::TestController::platformResetStateToConsistentValues):
3721         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3722         (WTR::toUIDeviceOrientation):
3723         (WTR::UIScriptController::simulateRotation):
3724         (WTR::UIScriptController::simulateRotationLikeSafari):
3725         (WTR::UIScriptController::platformClearAllCallbacks):
3726         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3727         (WTR::UIScriptController::simulateRotation):
3728         (WTR::UIScriptController::simulateRotationLikeSafari):
3729
3730 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
3731
3732         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
3733         https://bugs.webkit.org/show_bug.cgi?id=168945
3734         <rdar://problem/30745695>
3735
3736         Reviewed by David Kilzer.
3737
3738         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
3739         target SDK. These two changes must happen simultaneously because some archives will
3740         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
3741
3742         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
3743         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
3744         tools directory still includes ImageDiff.
3745         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
3746         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
3747         * Scripts/webkitpy/port/darwin.py: 
3748         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
3749         locally or when running archives.
3750         * Scripts/webkitpy/port/image_diff.py:
3751         (IOSSimulatorImageDiffer): Deleted.
3752         * Scripts/webkitpy/port/ios_simulator.py:
3753         (IOSSimulatorPort.diff_image): Deleted.
3754
3755 2017-05-05  Brian Burg  <bburg@apple.com>
3756
3757         API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
3758         https://bugs.webkit.org/show_bug.cgi?id=171748
3759
3760         Unreviewed test gardening.
3761
3762         The assertion failure will be investigated separately in order to avoid rolling out
3763         the fix for "secure" cookies. This assertion fails even without r216258 applied.
3764
3765         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3766         (TEST):
3767
3768 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
3769
3770         Unreviewed, rolling out r216260.
3771
3772         Breaks internal iOS testers
3773
3774         Reverted changeset:
3775
3776         "Use ImageDiff built by host SDK and remove ImageDiff from
3777         DumpRenderTree"
3778         https://bugs.webkit.org/show_bug.cgi?id=168945
3779         http://trac.webkit.org/changeset/216260
3780
3781 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
3782
3783         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
3784         https://bugs.webkit.org/show_bug.cgi?id=168945
3785         <rdar://problem/30745695>
3786
3787         Reviewed by David Kilzer.
3788
3789         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
3790         target SDK. These two changes must happen simultaneously because some archives will
3791         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
3792
3793         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
3794         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
3795         tools directory still includes ImageDiff.
3796         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
3797         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
3798         * Scripts/webkitpy/port/darwin.py: 
3799         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
3800         locally or when running archives.
3801         * Scripts/webkitpy/port/image_diff.py:
3802         (IOSSimulatorImageDiffer): Deleted.
3803         * Scripts/webkitpy/port/ios_simulator.py:
3804         (IOSSimulatorPort.diff_image): Deleted.
3805
3806 2017-05-05  Brian Burg  <bburg@apple.com>
3807
3808         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
3809         https://bugs.webkit.org/show_bug.cgi?id=171700
3810         <rdar://problem/32017975>
3811
3812         Reviewed by Brady Eidson.
3813
3814         Fix a mistake in the test that should have caught this bug.
3815
3816         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3817         (TEST):
3818         The assertions that were meant to check round-tripping were actually checking
3819         the properties of the original cookie objects, not the round-tripped ones.
3820         This test now fails without the bugfix and passes when it is applied.
3821
3822 2017-05-05  Daniel Bates  <dabates@apple.com>
3823
3824         Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
3825         https://bugs.webkit.org/show_bug.cgi?id=171698
3826
3827         Reviewed by Darin Adler.
3828
3829         We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
3830         so that we get pretty diff output when the actual string differs from the expected
3831         string as opposed to seeing a boolean result. The former makes makes it straightforward
3832         to diagnose a regression without reading the code for the test or instrumenting it to
3833         determine the actual string that was compared.
3834
3835         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3836         (TestWebKitAPI::TEST):
3837         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
3838         (TestWebKitAPI::TEST_F):
3839         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
3840         (TestWebKitAPI::TEST_F):
3841
3842 2017-05-05  Chris Dumez  <cdumez@apple.com>
3843
3844         Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
3845         https://bugs.webkit.org/show_bug.cgi?id=171624
3846
3847         Reviewed by Dan Bernstein.
3848
3849         Extend API test coverage to cover crashes in addition to terminations requested by the client.
3850
3851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3852         * TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp.
3853         (TestWebKitAPI::webProcessWasTerminatedByClient):
3854         (TestWebKitAPI::webProcessCrashed):
3855         (TestWebKitAPI::TEST):
3856
3857 2017-05-04  Mark Lam  <mark.lam@apple.com>
3858
3859         DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
3860         https://bugs.webkit.org/show_bug.cgi?id=171716
3861         <rdar://problem/30878027>
3862
3863         Reviewed by Saam Barati.
3864
3865         setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
3866         does JS conversion and therefore, potentially JS allocations) and accessing
3867         methods of internal JS data structures (which may do JS invocation, etc).
3868
3869         * DumpRenderTree/TestRunner.cpp:
3870         (setAudioResultCallback):
3871
3872 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
3873
3874         buildbot: Cleanup simulators after running tests
3875         https://bugs.webkit.org/show_bug.cgi?id=171679
3876         <rdar://problem/31994361>
3877
3878         Reviewed by Aakash Jain.
3879
3880         We shutdown the simulator process between tests, but in some cases, this is not
3881         sufficient. Explicitly shutdown every booted simulator.
3882
3883         * BuildSlaveSupport/kill-old-processes:
3884         (main): Shutdown all booted simulators.
3885
3886 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3887
3888         [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
3889         https://bugs.webkit.org/show_bug.cgi?id=171644
3890
3891         Reviewed by Michael Catanzaro.
3892
3893         Check that only one WebKitWebContext can have automation enabled.
3894
3895         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
3896         (testAutomationSessionRequestSession):
3897
3898 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3899
3900         [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
3901         https://bugs.webkit.org/show_bug.cgi?id=171724
3902
3903         Reviewed by Michael Catanzaro.
3904
3905         It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
3906
3907         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3908         (WTR::timeoutSource):
3909
3910 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3911
3912         Unreviewed. Fix wrong assert after r215176.
3913
3914         Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
3915         could also be RGB24 when created from a web view snapshot.
3916
3917         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3918         (WTR::computeMD5HashStringForCairoSurface):
3919
3920 2017-05-04  Brian Burg  <bburg@apple.com>
3921
3922         lldb_webkit.py should provide a type summary for WebCore::URL
3923         https://bugs.webkit.org/show_bug.cgi?id=171670
3924
3925         Reviewed by Jer Noble.
3926
3927         Just print out the underlying string using the WTFString provider.
3928
3929         * lldb/lldb_webkit.py:
3930         (__lldb_init_module):
3931         (WebCoreURL_SummaryProvider):
3932         (WebCoreURLProvider):
3933         (WebCoreURLProvider.__init__):
3934         (WebCoreURLProvider.to_string):
3935
3936 2017-05-04  Commit Queue  <commit-queue@webkit.org>
3937
3938         Unreviewed, rolling out r216206.
3939         https://bugs.webkit.org/show_bug.cgi?id=171714
3940
3941         Multiple LayoutTests crashing in Document::page() (Requested
3942         by ap on #webkit).
3943
3944         Reverted changeset:
3945
3946         "Remove support for legacy Notifications"
3947         https://bugs.webkit.org/show_bug.cgi?id=171487
3948         http://trac.webkit.org/changeset/216206
3949
3950 2017-05-04  Mark Lam  <mark.lam@apple.com>
3951
3952         API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
3953         https://bugs.webkit.org/show_bug.cgi?id=171702
3954
3955         Reviewed by Filip Pizlo.
3956
3957         The test was supposed to use the MAKE_STATIC_STRING_IMPL macro.  I had previously
3958         changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
3959         confirm that the test will detect a regression.  Unfortunately, I forgot to
3960         change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
3961         This patch fixes that.
3962
3963         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3964         (TestWebKitAPI::neverDestroyedString):
3965
3966 2017-05-04  Ryan Haddad  <ryanhaddad@apple.com>
3967
3968         Disable failing API test WebKit2.ResizeWithHiddenContentDoesNotHang.
3969         https://bugs.webkit.org/show_bug.cgi?id=170195
3970
3971         Unreviewed test gardening.
3972
3973         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3974         (TEST):
3975
3976 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
3977
3978         [Win] Remove redundant macros that are set in the CMake config
3979         https://bugs.webkit.org/show_bug.cgi?id=171571
3980
3981         Reviewed by Brent Fulgham.
3982
3983         * DumpRenderTree/config.h:
3984         * MiniBrowser/win/stdafx.h:
3985         * TestWebKitAPI/config.h:
3986
3987 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
3988
3989         Add testRunner.display() to force displaying the web page for testing
3990         https://bugs.webkit.org/show_bug.cgi?id=171694
3991
3992         Reviewed by Simon Fraser.
3993
3994         Unlike testRunner.displayAndTrackRepaints(), this new function forces 
3995         drawing the web page but without track repaints.
3996
3997         * DumpRenderTree/TestRunner.cpp:
3998         (displayCallback):
3999         (TestRunner::staticFunctions):
4000         * DumpRenderTree/TestRunner.h:
4001         * DumpRenderTree/mac/TestRunnerMac.mm:
4002         (TestRunner::display):
4003         * DumpRenderTree/win/TestRunnerWin.cpp:
4004         (TestRunner::display):
4005         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4006         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4007         (WTR::TestRunner::display):
4008         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4009
4010 2017-05-04  Mark Lam  <mark.lam@apple.com>
4011
4012         NeverDestroyed<String>(ASCIILiteral(...)) is not thread safe.
4013         https://bugs.webkit.org/show_bug.cgi?id=171586
4014         <rdar://problem/31873190>
4015
4016         Reviewed by Yusuke Suzuki.
4017
4018         API test for exercising StaticStringImpl and the MAKE_STATIC_STRING_IMPL macro.
4019
4020         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4021         (TestWebKitAPI::neverDestroyedString):
4022         (TestWebKitAPI::getNeverDestroyedStringAtStackDepth):
4023         (TestWebKitAPI::TEST):
4024
4025 2017-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
4026
4027         [WK2] Add support for keeping the selection in a focused editable element when dragging begins
4028         https://bugs.webkit.org/show_bug.cgi?id=171585
4029         <rdar://problem/31544320>
4030
4031         Reviewed by Beth Dakin and Zalan Bujtas.
4032
4033         Adds 1 new unit test and tweaks existing tests to check that when first responder status is lost after beginning
4034         a drag while editing, content is still moved (and not copied) when performing data interaction on a different
4035         element. ContentEditableMoveParagraphs checks that content can be shifted within a single element via a move
4036         operation rather than a copy.
4037
4038         See WebCore ChangeLog for more details.
4039
4040         Tests:  DataInteractionSimulator.ContentEditableToContentEditable
4041                 DataInteractionSimulator.ContentEditableToTextarea
4042                 DataInteractionSimulator.ContentEditableMoveParagraphs
4043                 DataInteractionSimulator.TextAreaToInput
4044
4045         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4046         * TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Added.
4047         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4048         (TestWebKitAPI::TEST):
4049         * TestWebKitAPI/ios/DataInteractionSimulator.h:
4050         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
4051         (-[DataInteractionSimulator initWithWebView:]):
4052         (-[DataInteractionSimulator dealloc]):
4053         (-[DataInteractionSimulator _advanceProgress]):
4054         (-[DataInteractionSimulator waitForInputSession]):
4055         (-[DataInteractionSimulator _webView:focusShouldStartInputSession:]):
4056         (-[DataInteractionSimulator _webView:didStartInputSession:]):
4057
4058 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
4059
4060         Rename TestRunner.display() to TestRunner::displayAndTrackRepaints()
4061         https://bugs.webkit.org/show_bug.cgi?id=171641
4062
4063         Reviewed by Simon Fraser.
4064
4065         The plan is to add back the TestRunner.display() which does the display
4066         only without track repaints.
4067
4068         * DumpRenderTree/DumpRenderTree.h:
4069         * DumpRenderTree/TestRunner.cpp:
4070         (displayAndTrackRepaintsCallback):
4071         (TestRunner::staticFunctions):
4072         (displayCallback): Deleted.
4073         (displayInvalidatedRegionCallback): Deleted.
4074         * DumpRenderTree/TestRunner.h:
4075         * DumpRenderTree/mac/DumpRenderTree.mm:
4076         (displayWebView):
4077         (displayAndTrackRepaintsWebView):
4078         * DumpRenderTree/mac/TestRunnerMac.mm:
4079         (TestRunner::displayAndTrackRepaints):
4080         (TestRunner::display): Deleted.
4081         * DumpRenderTree/win/TestRunnerWin.cpp:
4082         (TestRunner::displayAndTrackRepaints):
4083         (TestRunner::display): Deleted.
4084         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4085         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4086         (WTR::TestRunner::displayAndTrackRepaints):
4087         (WTR::TestRunner::display): Deleted.
4088         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4089
4090 2017-05-04  Brady Eidson  <beidson@apple.com>
4091
4092         [ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
4093         https://bugs.webkit.org/show_bug.cgi?id=171513
4094
4095         Unreviewed gardening.
4096
4097         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
4098         (TEST): Skip the failing parts of the test on iOS for now.
4099
4100 2017-05-03  Jonathan Bedard  <jbedard@apple.com>
4101
4102         Make ImageDiff stand-alone
4103         https://bugs.webkit.org/show_bug.cgi?id=168939
4104
4105         Reviewed by David Kilzer.
4106
4107         Create ImageDiff without dependencies on bmalloc and WTF so that it exists as a
4108         stand-alone project. Note that this change does not eliminate the ImageDiff inside
4109         the DumpRenderTree project.
4110
4111         * ImageDiff/ImageDiff.xcodeproj: Added.
4112         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj: Added.
4113         * ImageDiff/Makefile: Use ImageDiff project.
4114         * ImageDiff/PlatformMac.cmake: Added.
4115         * ImageDiff/PlatformWin.cmake: Added.
4116         * ImageDiff/cg: Added.
4117         * ImageDiff/cg/Configurations: Added.
4118         * ImageDiff/cg/Configurations/Base.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/Base.xcconfig.
4119         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig.
4120         * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig.
4121         * ImageDiff/cg/ImageDiff.cpp: Copied from Tools/DumpRenderTree/cg/ImageDiffCG.cpp.
4122         (createImageFromStdin): Stop using RetainPtr.
4123         (createDifferenceImage): Ditto.
4124         (main): Ditto.
4125         * Scripts/build-imagediff: Stop building WTF and bmalloc.
4126
4127 2017-05-04  Sam Weinig  <sam@webkit.org>
4128
4129         Remove support for legacy Notifications
4130         https://bugs.webkit.org/show_bug.cgi?id=171487
4131
4132         Reviewed by Jon Lee.
4133
4134         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
4135         (DRTDesktopNotificationPresenter::checkNotificationPermission):
4136         * Scripts/webkitperl/FeatureList.pm:
4137         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4138         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
4139
4140 2017-05-04  Andy Estes  <aestes@apple.com>
4141
4142         Give +testwebkitapi_configurationWithTestPlugInClassName: a shorter name
4143         https://bugs.webkit.org/show_bug.cgi?id=171673
4144
4145         Reviewed by Dan Bernstein.
4146
4147         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
4148         (TEST):
4149         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4150         (TEST):
4151         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
4152         (TEST):
4153         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
4154         (TEST):
4155         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
4156         (TEST):
4157         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
4158         (configurationWithContentFilterSettings):
4159         (-[LazilyLoadPlatformFrameworksController init]):
4160         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
4161         (TEST):
4162         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
4163         (runTestWithWidth):
4164         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
4165         (TEST):
4166         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4167         (TestWebKitAPI::TEST):
4168         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
4169         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
4170         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
4171         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Renamed to
4172         +_test_configurationWithTestPlugInClassName:
4173
4174 2017-05-04  Eric Carlson  <eric.carlson@apple.com>
4175
4176         [MediaStream] Allow host application to enable/disable media capture
4177         https://bugs.webkit.org/show_bug.cgi?id=171292
4178         <rdar://problem/31821492>
4179
4180         Reviewed by Jer Noble.
4181
4182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4183         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
4184         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
4185         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
4186         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4187         (MediaCaptureDisabledTest::SetUp):
4188         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4189         (TEST_F):
4190         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
4191
4192 2017-05-04  Caio Lima  <ticaiolima@gmail.com>
4193
4194         Unreviewed, Adding self to contributors.json
4195
4196         * Scripts/webkitpy/common/config/contributors.json: Added name.
4197
4198 2017-05-04  Konstantin Tokarev  <annulen@yandex.ru>
4199
4200         Fix compilation with ICU 59.1
4201         https://bugs.webkit.org/show_bug.cgi?id=171612
4202
4203         Reviewed by Mark Lam.
4204
4205         ICU 59.1 has broken source compatibility. Now it defines UChar as
4206         char16_t, which does not allow automatic type conversion from unsigned
4207         short in C++ code.
4208
4209         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
4210         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
4211
4212 2017-05-04  Andy Estes  <aestes@apple.com>
4213
4214         [Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]
4215         https://bugs.webkit.org/show_bug.cgi?id=171646
4216         <rdar://problem/30306321>
4217
4218         Reviewed by Tim Horton.
4219
4220         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
4221         (runTestWithWidth):
4222         (TEST):
4223         (-[RenderedImageWithOptionsObject didRenderImageWithSize:]): Deleted.
4224         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm:
4225         (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4226         (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
4227         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
4228         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h:
4229
4230 2017-05-04  Adrian Perez de Castro  <aperez@igalia.com>
4231
4232         [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+
4233         https://bugs.webkit.org/show_bug.cgi?id=171649
4234
4235         Reviewed by Carlos Garcia Campos.
4236
4237         Add two patches picked from the upstream repository to fix building of
4238         the Fontconfig module in JHBuild. Additionally, this needed a patch to
4239         add "autogen.sh" as it is not included in release tarballs. Also:
4240         building the module with srcdir!=builddir prevents "fcobjshash.gperf"
4241         being regenerated (which is needed) so this is disabled for the
4242         Fontconfig module.
4243
4244         * gtk/jhbuild.modules:
4245         * gtk/patches/fontconfig-2.11.1-add-autogen.patch: Added.
4246         * gtk/patches/fontconfig-Avoid-conflicts-with-integer-width-macros-from-TS-18661-1-2014.patch: Added.
4247         * gtk/patches/fontconfig-Fix-the-build-issue-with-gperf-3.1.patch: Added.
4248
4249 2017-05-04  Commit Queue  <commit-queue@webkit.org>
4250
4251         Unreviewed, rolling out r216172.
4252         https://bugs.webkit.org/show_bug.cgi?id=171654
4253
4254         FTBFS for iOS due to missing WebPageProxy::stopMediaCapture()
4255         implementation. (Requested by ddkilzer on #webkit).
4256
4257         Reverted changeset:
4258
4259         "[MediaStream] Allow host application to enable/disable media
4260         capture"
4261         https://bugs.webkit.org/show_bug.cgi?id=171292
4262         http://trac.webkit.org/changeset/216172
4263
4264 2017-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4265
4266         [GTK] Bump GStreamer version to 1.10.4 in jhbuild
4267         https://bugs.webkit.org/show_bug.cgi?id=171595
4268
4269         Reviewed by Xabier Rodriguez-Calvar.
4270
4271         * gtk/jhbuild.modules:
4272         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
4273         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
4274         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Removed.
4275         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Removed.
4276         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
4277         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
4278         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
4279
4280 2017-05-03  Saam Barati  <sbarati@apple.com>
4281
4282         How we build polymorphic cases is wrong when making a call from Wasm
4283         https://bugs.webkit.org/show_bug.cgi?id=171527
4284
4285         Reviewed by JF Bastien.
4286
4287         * Scripts/run-jsc-stress-tests:
4288
4289 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
4290
4291         [MediaStream] Allow host application to enable/disable media capture
4292         https://bugs.webkit.org/show_bug.cgi?id=171292
4293         <rdar://problem/31821492>
4294
4295         Reviewed by Jer Noble.
4296
4297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4298         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
4299         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
4300         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
4301         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4302         (MediaCaptureDisabledTest::SetUp):
4303         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4304         (TEST_F):
4305         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
4306
4307 2017-05-03  John Wilander  <wilander@apple.com>
4308
4309         Resource Load Statistics: Remove all statistics for modifiedSince website data removals
4310         https://bugs.webkit.org/show_bug.cgi?id=171584
4311         <rdar://problem/24702576>
4312
4313         Reviewed by Brent Fulgham.
4314
4315         New function to call the clear function that takes a modifiedSince parameter.
4316
4317         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4318         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4319         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
4320         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4321         * WebKitTestRunner/TestController.cpp:
4322         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
4323         * WebKitTestRunner/TestController.h:
4324         * WebKitTestRunner/TestInvocation.cpp:
4325         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4326
4327 2017-05-03  Commit Queue  <commit-queue@webkit.org>
4328
4329         Unreviewed, rolling out r216160 and r216161.
4330         https://bugs.webkit.org/show_bug.cgi?id=171640
4331
4332         These changes broke the iOS build. (Requested by mlewis13 on
4333         #webkit).
4334
4335         Reverted changesets:
4336
4337         "[MediaStream] Allow host application to enable/disable media
4338         capture"
4339         https://bugs.webkit.org/show_bug.cgi?id=171292
4340         http://trac.webkit.org/changeset/216160
4341
4342         "[MediaStream] Allow host application to enable/disable media
4343         capture"
4344         https://bugs.webkit.org/show_bug.cgi?id=171292
4345         http://trac.webkit.org/changeset/216161
4346
4347 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
4348
4349         [MediaStream] Allow host application to enable/disable media capture
4350         https://bugs.webkit.org/show_bug.cgi?id=171292
4351         <rdar://problem/31821492>
4352
4353         Reviewed by Jer Noble.
4354
4355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4356         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
4357         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
4358         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
4359         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4360         (MediaCaptureDisabledTest::SetUp):
4361         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4362         (TEST_F):
4363         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
4364
4365 2017-04-26  Jiewen Tan  <jiewen_tan@apple.com>
4366
4367         [WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys
4368         https://bugs.webkit.org/show_bug.cgi?id=171350
4369         <rdar://problem/28600836>
4370
4371         Patched by Brady Eidson.
4372
4373         Reviewed by Brent Fulgham.
4374
4375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4376         * TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Added.
4377         (TestWebKitAPI::runJavaScriptAlert):
4378         (TestWebKitAPI::decidePolicyForNavigationAction):
4379         (TestWebKitAPI::decidePolicyForNavigationResponse):
4380         (TestWebKitAPI::TEST):
4381         * TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Added.
4382
4383 2017-05-03  Simon Fraser  <simon.fraser@apple.com>
4384
4385         Have WKWebView call _updateVisibleContentRects for the current transaction if possible, rather than always delaying
4386         https://bugs.webkit.org/show_bug.cgi?id=171619
4387         https://bugs.webkit.org/show_bug.cgi?id=170195
4388
4389         Reviewed by Tim Horton.
4390
4391         Re-enable WebKit2.ResizeWithHiddenContentDoesNotHang.
4392
4393         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
4394         (TEST):
4395
4396 2017-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4397
4398         YouTube user agent quirk breaks new YouTube
4399         https://bugs.webkit.org/show_bug.cgi?id=171603
4400
4401         Reviewed by Carlos Garcia Campos.
4402
4403         Remove the YouTube quirk test.
4404
4405         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4406         (TestWebKitAPI::TEST):
4407
4408 2017-05-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
4409