[Scripts] Fix missing variable warnings from svn-create-patch when there are untracke...
[WebKit.git] / Tools / ChangeLog
1 2017-07-16  Sam Weinig  <sam@webkit.org>
2
3         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
4         https://bugs.webkit.org/show_bug.cgi?id=174575
5
6         Reviewed by Brady Eidson.
7
8         * Scripts/svn-create-patch:
9         (findModificationType):
10         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
11         default value of "unknown".
12
13         (generateFileList):
14         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
15         for untracked, which matches our old behavior.
16
17 2017-07-17  Charlie Turner  <cturner@igalia.com>
18
19         Add some missing build dependencies on Fedora
20         https://bugs.webkit.org/show_bug.cgi?id=174578
21
22         Unreviewed dependency update.
23
24         * gtk/install-dependencies:
25
26 2017-07-16  Brady Eidson  <beidson@apple.com>
27
28         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
29         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
30
31         Reviewed by Tim Horton.
32
33         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
34         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
35         (TEST):
36
37 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
38
39         [GTK] Sort inspector GResource manifest to ensure reproducible builds
40         https://bugs.webkit.org/show_bug.cgi?id=174540
41
42         Reviewed by Michael Catanzaro.
43
44         * gtk/generate-inspector-gresource-manifest.py:
45         (get_filenames): sort list of input files
46
47 2017-07-15  Brady Eidson  <beidson@apple.com>
48
49         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
50         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
51
52         Reviewed by Tim Horton.
53
54         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
55         (TEST): Make this test more reliable by clearing everything beforehand.
56
57 2017-07-15  David Kilzer  <ddkilzer@apple.com>
58
59         Make it possible to extend check-webkit-style with Apple-internal checkers
60         <https://webkit.org/b/174464>
61         <rdar://problem/25564402>
62
63         Reviewed by Darin Adler.
64
65         * Scripts/webkitpy/style/checker.py: Import apple_additions.
66         (_all_categories): Add categories from apple_additions() if it
67         exists.
68         (CheckerDispatcher._create_checker): Create python checker
69         from apple_additions() if it exists.
70
71 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
72
73         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
74         https://bugs.webkit.org/show_bug.cgi?id=174539
75         <rdar://problem/33307395>
76
77         Reviewed by Darin Adler.
78
79         Adds a new unit test suite to cover action sheet popover presentation.
80
81         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
82         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
83         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
84         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
85
86         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
87
88         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
89         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
90
91         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
92
93         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
94         (TestWebKitAPI::TEST):
95
96 2017-07-15  Sam Weinig  <sam@webkit.org>
97
98         [Scripts] Make svn-create-patch work better when called in sub directories
99         https://bugs.webkit.org/show_bug.cgi?id=174551
100
101         Reviewed by Darin Adler.
102
103         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
104           by ensuring that the prefix is applied as is done in generateDiff.
105         - Silence output of explanatory lines from svn stat (" > move to ...")
106           that show up in STDERR when running svn-create-patch.
107         - Add verbose logging that I found useful while debugging this issue.
108
109         * Scripts/svn-create-patch:
110         (findBaseUrl):
111         (findMimeType):
112         (findSourceFileAndRevision):
113         (generateDiff):
114         (generateFileList):
115         (manufacturePatchForAdditionWithHistory):
116
117 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
118
119         Unreviewed build fix after r219537.
120
121         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
122
123 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
124
125         Add iOS 11 SPI
126         https://bugs.webkit.org/show_bug.cgi?id=174430
127         <rdar://problem/33269288>
128
129         Reviewed by Tim Horton.
130
131         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
132         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
133         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
134
135 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
136
137         Failing to install on iPad simulators
138         https://bugs.webkit.org/show_bug.cgi?id=174532
139         <rdar://problem/33328347>
140
141         Reviewed by Stephanie Lewis.
142
143         * Scripts/webkitpy/xcode/simulated_device.py:
144         (SimulatedDevice.install_app): Place install command in retry try-except block.
145
146 2017-07-14  Jeff Miller  <jeffm@apple.com>
147
148         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
149         https://bugs.webkit.org/show_bug.cgi?id=174524
150
151         Reviewed by Sam Weinig.
152
153         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
154         (TEST):
155         Renamed TestParameter to TestParameter1.
156         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
157
158         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
159         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
160         Observe changes for two bundle parameters.
161
162         (-[BundleParametersPlugIn dealloc]):
163         Remove observers for two bundle parameters.
164
165 2017-07-14  Commit Queue  <commit-queue@webkit.org>
166
167         Unreviewed, rolling out r219510.
168         https://bugs.webkit.org/show_bug.cgi?id=174525
169
170         Need to revert length() == 0 check for null string (Requested
171         by yusukesuzuki on #webkit).
172
173         Reverted changeset:
174
175         "[WTF] Newly added AtomicStringImpl should use BufferInternal
176         static string if StringImpl is static"
177         https://bugs.webkit.org/show_bug.cgi?id=174501
178         http://trac.webkit.org/changeset/219510
179
180 2017-07-14  Jer Noble  <jer.noble@apple.com>
181
182         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
183         https://bugs.webkit.org/show_bug.cgi?id=174514
184
185         Reviewed by Sam Weinig.
186
187         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
188         (TestWebKitAPI::TEST_F):
189
190 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
191
192         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
193         https://bugs.webkit.org/show_bug.cgi?id=174501
194
195         Reviewed by Darin Adler.
196
197         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
198         (TestWebKitAPI::TEST):
199
200 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
201
202         Bring mac expectations in-line with other platforms
203         https://bugs.webkit.org/show_bug.cgi?id=174472
204         <rdar://problem/33297388>
205
206         Reviewed by David Kilzer.
207
208         The override order for Mac test expectations does not conform to the pattern used by iOS,
209         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
210
211             platform/mac-wk2
212             platform/wk2
213             platform/mac-elcapitan
214             platform/mac-sierra
215             generic
216
217         After this change, El Capitan's baseline search path looks like this:
218
219             platform/mac-sierra-wk2
220             platform/mac-sierra
221             platform/mac-wk2
222             platform/wk2
223             generic
224
225         * Scripts/webkitpy/port/mac.py:
226         (MacPort.__init__): If a specific version is specified in the port name, use that
227         as the os version.
228         (MacPort.default_baseline_search_path): Expectation search paths should work the
229         same way they do on other ports. Port + version overrides port, port overrides generic
230         and wk1/wk2 should override expectations for the two combined.
231         * Scripts/webkitpy/port/mac_unittest.py:
232         (MacTest.test_tests_for_other_platforms): Deleted.
233         (MacTest._assert_search_path): Deleted.
234         (MacTest.test_baseline_search_path): Deleted.
235         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
236         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
237         (test_rebaseline_test_and_print_scm_changes): Ditto.
238         (test_rebaseline_and_copy_test): Ditto.
239         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
240         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
241         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
242
243 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
244
245         Fix style checker unit test
246
247         Unreviewed WebKit2 => WebKit fixup.
248
249         * Scripts/webkitpy/style/checker_unittest.py:
250         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
251
252 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
253
254         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
255
256         Unreviewed build fix.
257
258         r219492 missed one hunk from its partial revert of r219489.
259         This patch reverts that hunk.
260
261         * TestWebKitAPI/CMakeLists.txt:
262
263 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
264
265         Use the old WebKit/WebKit2 targets for CMake builds.
266
267         Unreviewed build fix.
268
269         We can update the target names to match the Framework names in a future patch.
270         This is a partial revert of r219489.
271
272         * TestWebKitAPI/CMakeLists.txt:
273         WebKitLegacy => WebKit
274         WebKit => WebKit2
275
276 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
277
278         Fix TestWebKit API.
279         https://bugs.webkit.org/show_bug.cgi?id=174164
280         rdar://problem/33137595
281
282         Reviewed by Dan Bernstein.
283
284         * TestWebKitAPI/CMakeLists.txt:
285         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
286         * TestWebKitAPI/PlatformGTK.cmake:
287
288 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
289
290         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
291         https://bugs.webkit.org/show_bug.cgi?id=174164
292         rdar://problem/33137595
293
294         Reviewed by Dan Bernstein.
295
296         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
297         (ShouldBuildTest):
298         * DumpRenderTree/mac/Configurations/Base.xcconfig:
299         * Scripts/build-webkit:
300         * Scripts/do-file-rename:
301         * Scripts/do-webcore-rename:
302         * Scripts/update-webkit-localizable-strings:
303         * Scripts/webkitpy/common/config/watchlist:
304         * Scripts/webkitpy/style/checker.py:
305         * Scripts/webkitpy/style/checkers/featuredefines.py:
306         * gtk/make-dist.py:
307         (ensure_version_if_possible):
308         * gtk/manifest.txt.in:
309
310 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
311
312         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
313         https://bugs.webkit.org/show_bug.cgi?id=174162
314         rdar://problem/33137594
315
316         Reviewed by Dan Bernstein.
317
318         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
319
320         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
321         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
322         * EWSTools/configure-clang-linux.sh:
323         * Scripts/build-webkit:
324         * Scripts/do-file-rename:
325         * Scripts/do-webcore-rename:
326         * Scripts/update-webkit-localizable-strings:
327         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
328         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
329         * Scripts/webkitpy/style/checkers/featuredefines.py:
330         * gtk/manifest.txt.in:
331
332 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
333
334         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
335         https://bugs.webkit.org/show_bug.cgi?id=174438
336         <rdar://problem/33277112>
337
338         Reviewed by Aakash Jain.
339
340         Given a patch, this will convert the changes from the path to the new directory structure.
341
342         * Scripts/rebase-patch-after-webkit-move: Added.
343         (append_source): Append 'Source' to the provided path.
344         (is_editable_line): Return true if a line the script expects to modify.
345         (needs_rebase): Return if a line needs to be rebased based on it's content.
346         (rebase_line): Rebase the provided line.
347         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
348         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
349         were provided.
350
351 2017-07-12  Nan Wang  <n_wang@apple.com>
352
353         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
354         https://bugs.webkit.org/show_bug.cgi?id=174393
355         <rdar://problem/33248006>
356
357         Reviewed by Chris Fleizach.
358
359         * DumpRenderTree/AccessibilityUIElement.cpp:
360         (textMarkerRangeMatchesTextNearMarkersCallback):
361         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
362         (AccessibilityUIElement::getJSClass):
363         * DumpRenderTree/AccessibilityUIElement.h:
364         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
365         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
366         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
367         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
368         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
369         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
370         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
371         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
372
373 2017-07-12  Matt Lewis  <jlewis3@apple.com>
374
375         Unreviewed, rolling out r219409.
376
377         The revision caused the Windows builds to fail.
378
379         Reverted changeset:
380
381         "AX: [iOS] Implement a way to retrieve a text marker range
382         with desired text that is closest to a position"
383         https://bugs.webkit.org/show_bug.cgi?id=174393
384         http://trac.webkit.org/changeset/219409
385
386 2017-07-12  Nan Wang  <n_wang@apple.com>
387
388         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
389         https://bugs.webkit.org/show_bug.cgi?id=174393
390         <rdar://problem/33248006>
391
392         Reviewed by Chris Fleizach.
393
394         * DumpRenderTree/AccessibilityUIElement.cpp:
395         (textMarkerRangeMatchesTextNearMarkersCallback):
396         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
397         (AccessibilityUIElement::getJSClass):
398         * DumpRenderTree/AccessibilityUIElement.h:
399         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
400         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
401         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
402         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
403         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
404         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
405         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
406         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
407
408 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
409
410         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
411         https://bugs.webkit.org/show_bug.cgi?id=174197
412
413         Reviewed by Darin Adler.
414
415         This bit me the first time I tried to submit a patch to WebKit, and still I have
416         to manually edit the ChangeLog every time I use the script.
417
418         This generates a more convenient and standard ChangeLog entry.
419
420         * Scripts/prepare-ChangeLog:
421         (generateNewChangeLogs):
422
423 2017-07-12  Matt Lewis  <jlewis3@apple.com>
424
425         Unreviewed, rolling out r219401.
426
427         This revision rolled out the previous patch, but after talking
428         with reviewer, a rebaseline is what was needed.Rolling back in
429         before rebaseline.
430
431         Reverted changeset:
432
433         "Unreviewed, rolling out r219379."
434         https://bugs.webkit.org/show_bug.cgi?id=174400
435         http://trac.webkit.org/changeset/219401
436
437 2017-07-12  Matt Lewis  <jlewis3@apple.com>
438
439         Unreviewed, rolling out r219379.
440
441         This revision caused a consistent failure in the test
442         fast/dom/Window/property-access-on-cached-window-after-frame-
443         removed.html.
444
445         Reverted changeset:
446
447         "Remove NAVIGATOR_HWCONCURRENCY"
448         https://bugs.webkit.org/show_bug.cgi?id=174400
449         http://trac.webkit.org/changeset/219379
450
451 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
452
453         [WPE] Use libepoxy
454         https://bugs.webkit.org/show_bug.cgi?id=172104
455
456         Reviewed by Michael Catanzaro.
457
458         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
459         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
460
461 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
462
463         [GTK][WPE] Align Jhbuild patches for GStreamer packages
464         https://bugs.webkit.org/show_bug.cgi?id=174363
465
466         Reviewed by Michael Catanzaro.
467
468         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
469         between the GTK+ and WPE port. There's no reason for the two ports to apply
470         different patches over same versions of GStreamer releases.
471
472         This aligns the two ports on this specific issue. Next we'll look into
473         creating a single GStreamer-specific Jhbuild moduleset that will allow us
474         to keep these patches in a single place, avoiding duplicate files.
475
476         * gtk/jhbuild.modules:
477         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
478         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
479         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
480         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
481
482 2017-07-11  Dean Jackson  <dino@apple.com>
483
484         Remove NAVIGATOR_HWCONCURRENCY
485         https://bugs.webkit.org/show_bug.cgi?id=174400
486
487         Reviewed by Sam Weinig.
488
489         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
490
491 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
492
493         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
494         https://bugs.webkit.org/show_bug.cgi?id=174239
495
496         Reviewed by Brady Eidson.
497
498         Create windows with specific features set and make sure those are properly reflected in the
499         WKWindowFeatures object.
500
501         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
502         (resetToConsistentState):
503         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
504         (TEST):
505
506 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
507
508         Do not duplicate files when deleting directories with svn 1.9
509         https://bugs.webkit.org/show_bug.cgi?id=174339
510         <rdar://problem/33226781>
511
512         Reviewed by David Kilzer.
513
514         * Scripts/svn-create-patch:
515         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
516         (generateFileList): Determine which files are deleted because they are part of a
517         directory being deleted.
518
519 2017-07-11  Dean Jackson  <dino@apple.com>
520
521         Rolling out r219372.
522
523         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
524
525 2017-07-11  Dean Jackson  <dino@apple.com>
526
527         Remove NAVIGATOR_HWCONCURRENCY
528         https://bugs.webkit.org/show_bug.cgi?id=174400
529
530         Reviewed by Sam Weinig.
531
532         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
533
534 2017-07-11  Lucas Forschler  <lforschler@apple.com>
535
536         Teach build workers to fetch archives from S3.
537         https://bugs.webkit.org/show_bug.cgi?id=174384
538
539         Reviewed by Aakash Jain.
540
541         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
542         (DownloadBuiltProduct):
543
544 2017-07-11  Lucas Forschler  <lforschler@apple.com>
545
546         Configure buildbot to transfer all archives to S3.
547         Previously this was Mac only, but it's time to expand!
548         https://bugs.webkit.org/show_bug.cgi?id=174378
549         
550         Reviewed by Aakash Jain.
551
552         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
553         (BuildFactory.__init__):
554
555 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
556
557         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
558         https://bugs.webkit.org/show_bug.cgi?id=174350
559
560         Reviewed by Xabier Rodriguez-Calvar.
561
562         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
563         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
564         patches are removed. The patches for gst-plugins-good are updated, removing
565         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
566         rtpbin elements that will help with the EMEv3 development.
567
568         * wpe/jhbuild.modules:
569         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
570         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
571         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
572         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
573         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
574         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
575         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
576         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
577         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
578
579 2017-07-10  John Wilander  <wilander@apple.com>
580
581         Resource Load Statistics: Prune statistics in orders of importance
582         https://bugs.webkit.org/show_bug.cgi?id=174215
583         <rdar://problem/33164403>
584
585         Reviewed by Chris Dumez.
586
587         Nest infrastructure. Adds these functions:
588         1. testRunner.setStatisticsLastSeen()
589         2. setStatisticsMaxStatisticsEntries()
590         3. setStatisticsPruneEntriesDownTo()
591
592         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
593         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
594         (WTR::TestRunner::setStatisticsLastSeen):
595         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
596         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
597         * WebKitTestRunner/InjectedBundle/TestRunner.h:
598         * WebKitTestRunner/TestController.cpp:
599         (WTR::TestController::setStatisticsLastSeen):
600         (WTR::TestController::setMaxStatisticsEntries):
601         (WTR::TestController::setPruneEntriesDownTo):
602         * WebKitTestRunner/TestController.h:
603         * WebKitTestRunner/TestInvocation.cpp:
604         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
605         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
606         (WTR::TestController::setStatisticsLastSeen):
607         (WTR::TestController::setStatisticsMaxStatisticsEntries):
608         (WTR::TestController::setStatisticsPruneEntriesDownTo):
609
610 2017-07-03  Brian Burg  <bburg@apple.com>
611
612         Web Replay: remove some unused code
613         https://bugs.webkit.org/show_bug.cgi?id=173903
614
615         Rubber-stamped by Joseph Pecoraro.
616
617         * Scripts/run-input-generator-tests: Removed.
618         * Scripts/webkitpy/replay/__init__.py: Removed.
619         * Scripts/webkitpy/replay/main.py: Removed.
620
621 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
622
623         [WPE] Fix layout test baseline and TestExpectations hierarchy
624         https://bugs.webkit.org/show_bug.cgi?id=174092
625
626         Reviewed by Michael Catanzaro.
627
628         Like for the GTK+ port, override the default_baseline_search_path() and
629         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
630         Both methods operate on a short list of search paths that defaults to 'wpe' and
631         'wk2', along with any other user-specified platform directory.
632
633         The test_expectations_file_position() method is overridden for testing purposes,
634         and relevant unit tests are added.
635
636         * Scripts/webkitpy/port/wpe.py:
637         (WPEPort._search_paths):
638         (WPEPort):
639         (WPEPort.default_baseline_search_path):
640         (WPEPort._port_specific_expectations_files):
641         (WPEPort.test_expectations_file_position):
642         * Scripts/webkitpy/port/wpe_unittest.py:
643         (WPEPortTest.test_default_baseline_search_path):
644         (WPEPortTest):
645         (WPEPortTest.test_port_specific_expectations_files):
646
647 2017-07-10  Chris Dumez  <cdumez@apple.com>
648
649         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
650         https://bugs.webkit.org/show_bug.cgi?id=174301
651
652         Reviewed by Brent Fulgham.
653
654         Rename some of the testRunner API for clarity and to better match what it calls
655         internally.
656
657         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
658         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
659         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
660         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
661         * WebKitTestRunner/InjectedBundle/TestRunner.h:
662         * WebKitTestRunner/TestController.cpp:
663         (WTR::TestController::statisticsUpdateCookiePartitioning):
664         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
665         * WebKitTestRunner/TestController.h:
666         * WebKitTestRunner/TestInvocation.cpp:
667         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
668         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
669         (WTR::TestController::statisticsUpdateCookiePartitioning):
670         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
671
672 2017-07-10  Charlie Turner  <cturner@igalia.com>
673
674         [GStreamer] Live twitch.tv videos do not play
675         https://bugs.webkit.org/show_bug.cgi?id=174222
676
677         Reviewed by Michael Catanzaro.
678
679         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
680         fixes videos not playing on twitch.tv.
681
682         * gtk/jhbuild.modules:
683
684 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
685
686         Add WebGL2 configuration option to build-webkit
687         https://bugs.webkit.org/show_bug.cgi?id=174251
688
689         Reviewed by Michael Catanzaro.
690
691         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
692         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
693         is marked as enabled for the Apple Cocoa ports.
694
695 2017-07-08  Chris Dumez  <cdumez@apple.com>
696
697         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
698         https://bugs.webkit.org/show_bug.cgi?id=174290
699
700         Reviewed by Brent Fulgham.
701
702         Rename testRunner API to match the new internal API names.
703
704         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
705         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
706         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
707         (WTR::TestRunner::statisticsSubmitTelemetry):
708         * WebKitTestRunner/InjectedBundle/TestRunner.h:
709         * WebKitTestRunner/TestController.cpp:
710         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
711         (WTR::TestController::statisticsSubmitTelemetry):
712         * WebKitTestRunner/TestController.h:
713         * WebKitTestRunner/TestInvocation.cpp:
714         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
715         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
716         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
717         (WTR::TestController::statisticsSubmitTelemetry):
718
719 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
720
721         Drop NOSNIFF compile flag
722         https://bugs.webkit.org/show_bug.cgi?id=174289
723
724         Reviewed by Michael Catanzaro.
725
726         * Scripts/webkitperl/FeatureList.pm:
727         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
728
729 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
730
731         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
732         https://bugs.webkit.org/show_bug.cgi?id=174219
733         <rdar://problem/32083177>
734
735         Reviewed by Ryosuke Niwa.
736
737         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
738         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
739         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
740         place.
741
742         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
743         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
744         no action is taken when dropping.
745
746         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
747         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
748         (TestWebKitAPI::TEST):
749         * TestWebKitAPI/ios/DataInteractionSimulator.h:
750         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
751         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
752         (-[MockDragDropSession allowsMoveOperation]):
753         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
754         (-[MockDataInteractionSession initWithWindow:allowMove:]):
755         (-[DataInteractionSimulator initWithWebView:]):
756         (-[DataInteractionSimulator runFrom:to:]):
757         (-[DataInteractionSimulator _advanceProgress]):
758         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
759         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
760         (-[MockDataInteractionSession initWithWindow:]): Deleted.
761
762 2017-07-07  Commit Queue  <commit-queue@webkit.org>
763
764         Unreviewed, rolling out r219238, r219239, and r219241.
765         https://bugs.webkit.org/show_bug.cgi?id=174265
766
767         "fast/workers/dedicated-worker-lifecycle.html is flaky"
768         (Requested by yusukesuzuki on #webkit).
769
770         Reverted changesets:
771
772         "[WTF] Implement WTF::ThreadGroup"
773         https://bugs.webkit.org/show_bug.cgi?id=174081
774         http://trac.webkit.org/changeset/219238
775
776         "Unreviewed, build fix after r219238"
777         https://bugs.webkit.org/show_bug.cgi?id=174081
778         http://trac.webkit.org/changeset/219239
779
780         "Unreviewed, CLoop build fix after r219238"
781         https://bugs.webkit.org/show_bug.cgi?id=174081
782         http://trac.webkit.org/changeset/219241
783
784 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
785
786         [GTK][WPE] Enable X-Content-Type-Options: nosniff
787         https://bugs.webkit.org/show_bug.cgi?id=174250
788
789         Reviewed by Carlos Alberto Lopez Perez.
790
791         * Scripts/webkitperl/FeatureList.pm:
792
793 2017-07-07  Charlie Turner  <cturner@igalia.com>
794         [GStreamer] vid.me videos do not play
795         https://bugs.webkit.org/show_bug.cgi?id=172240
796
797         Reviewed by Xabier Rodriguez-Calvar.
798
799         Build httpsoupsrc again for use in adaptive streaming pipelines, and
800         have the existing libsoup build against GNOME to avoid header drift
801         against GStreamer's linked Soup library.
802
803         * gtk/jhbuild.modules:
804
805 2017-07-06  Lucas Forschler  <lforschler@apple.com>
806
807         Write a support script to enable buildbot to upload to S3
808         https://bugs.webkit.org/show_bug.cgi?id=174196
809         
810         Reviewed by Stephanie Lewis.
811
812         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
813         (uploadToS3):
814         (archiveExists):
815
816 2017-07-06  Lucas Forschler  <lforschler@apple.com>
817
818         Enabling uploading archives to S3.
819         https://bugs.webkit.org/show_bug.cgi?id=174198
820         
821         Reviewed by Stephanie Lewis.
822
823         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
824         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
825         (UploadMinifiedBuiltProduct): Upload minified archive to build master
826         (TransferToS3): Transfer full and minified archives to S3
827
828 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
829
830         [WTF] Implement WTF::ThreadGroup
831         https://bugs.webkit.org/show_bug.cgi?id=174081
832
833         Reviewed by Mark Lam.
834
835         Add WTF::ThreadGroup tests.
836
837         * TestWebKitAPI/CMakeLists.txt:
838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
839         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
840         (TestWebKitAPI::TEST):
841
842 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
843
844         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
845         https://bugs.webkit.org/show_bug.cgi?id=174150
846
847         Reviewed by Mark Lam.
848
849         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
850         (TestWebKitAPI::TEST):
851         * TestWebKitAPI/TestsController.cpp:
852         (TestWebKitAPI::TestsController::TestsController):
853
854 2017-07-06  Lucas Forschler  <lforschler@apple.com>
855
856         Enabling uploading archives to S3.
857         https://bugs.webkit.org/show_bug.cgi?id=174198
858         
859         Reviewed by Lucas Forschler.
860
861         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
862         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
863         (UploadMinifiedBuiltProduct): Upload minified archive to build master
864         (TransferToS3): Transfer full and minified archives to S3
865
866 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
867
868         [GTK][WPE] kill-old-process should kill more webkit related process
869         https://bugs.webkit.org/show_bug.cgi?id=174220
870
871         Reviewed by Michael Catanzaro.
872
873         Generate list of possible webkit-related process names and add
874         them to the list of process to kill.
875         Also update the possible system related process for GTK+/WPE.
876
877         * BuildSlaveSupport/kill-old-processes:
878         (listAllWebKitPrograms):
879         (main):
880
881 2017-07-06  Chris Dumez  <cdumez@apple.com>
882
883         FileMonitor should not be ref counted
884         https://bugs.webkit.org/show_bug.cgi?id=174166
885
886         Reviewed by Brent Fulgham.
887
888         Update the API tests to reflect the API change.
889
890         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
891         (TestWebKitAPI::TEST_F):
892
893 2017-07-06  Commit Queue  <commit-queue@webkit.org>
894
895         Unreviewed, rolling out r219194.
896         https://bugs.webkit.org/show_bug.cgi?id=174207
897
898         it broke some layout tests (Requested by clopez on #webkit).
899
900         Reverted changeset:
901
902         "[GStreamer] vid.me videos do not play"
903         https://bugs.webkit.org/show_bug.cgi?id=172240
904         http://trac.webkit.org/changeset/219194
905
906 2017-07-06  Matt Lewis  <jlewis3@apple.com>
907
908         Unreviewed, rolling out r219178.
909
910         This caused a consistent failure with the API test
911         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
912
913         Reverted changeset:
914
915         "[WTF] Clean up StringStatics.cpp by using
916         LazyNeverDestroyed<> for Atoms"
917         https://bugs.webkit.org/show_bug.cgi?id=174150
918         http://trac.webkit.org/changeset/219178
919
920 2017-07-06  Alicia Boya García  <aboya@igalia.com>
921
922         Add CWD to Perl library path (no longer the default since 5.26.0)
923         https://bugs.webkit.org/show_bug.cgi?id=174200
924
925         Reviewed by Michael Catanzaro.
926
927         * Scripts/webkitpy/tool/commands/setupgitclone.py:
928         (SetupGitClone._get_username_and_email):
929
930 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
931
932         Unreviewed, update my email address.
933
934         * Scripts/webkitpy/common/config/contributors.json:
935
936 2017-07-06  Charlie Turner  <cturner@igalia.com>
937         [GStreamer] vid.me videos do not play
938         https://bugs.webkit.org/show_bug.cgi?id=172240
939
940         Reviewed by Xabier Rodriguez-Calvar.
941
942         Build httpsoupsrc again for use in adaptive streaming pipelines, and
943         have the existing libsoup build against GNOME to avoid header drift
944         against GStreamer's linked Soup library.
945
946         * gtk/jhbuild.modules:
947
948 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
949
950         [WTF] Move SoftLinking.h into WTF
951         https://bugs.webkit.org/show_bug.cgi?id=174000
952
953         Reviewed by Alex Christensen.
954
955         * DumpRenderTree/mac/TestRunnerMac.mm:
956         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
957         (test_primary_header):
958         (ErrorCollector.__init__): Deleted.
959         (ErrorCollector.__call__): Deleted.
960         (ErrorCollector.results): Deleted.
961         (ErrorCollector.result_list): Deleted.
962         (ErrorCollector.verify_all_categories_are_seen): Deleted.
963         (MockIo.open): Deleted.
964         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
965         (CppFunctionsTest.test_create_acronym): Deleted.
966         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
967         (CppFunctionsTest.test_parameter): Deleted.
968         (CppFunctionsTest.test_single_line_view): Deleted.
969         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
970         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
971         (CppFunctionsTest.test_parameter_list): Deleted.
972         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
973         (CppStyleTestBase.process_file_data): Deleted.
974         (CppStyleTestBase.perform_lint): Deleted.
975         (CppStyleTestBase.perform_single_line_lint): Deleted.
976         (CppStyleTestBase.perform_multi_line_lint): Deleted.
977         (CppStyleTestBase.perform_language_rules_check): Deleted.
978         (CppStyleTestBase.perform_function_lengths_check): Deleted.
979         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
980         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
981         (CppStyleTestBase.perform_include_what_you_use): Deleted.
982         (CppStyleTestBase.perform_header_guard_check): Deleted.
983         (CppStyleTestBase.assert_lint): Deleted.
984         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
985         (CppStyleTestBase.assert_multi_line_lint): Deleted.
986         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
987         (CppStyleTestBase.assert_language_rules_check): Deleted.
988         (CppStyleTestBase.assert_include_what_you_use): Deleted.
989         (CppStyleTestBase.assert_header_guard): Deleted.
990         (CppStyleTestBase.assert_blank_lines_check): Deleted.
991         (CppStyleTestBase.assert_positions_equal): Deleted.
992         (FunctionDetectionTest.test_basic_function_detection): Deleted.
993         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
994         (FunctionDetectionTest.test_pure_function_detection): Deleted.
995         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
996         (FunctionDetectionTest.test_ignore_macros): Deleted.
997         (FunctionDetectionTest.test_non_functions): Deleted.
998         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
999         (FunctionDetectionTest.test_parameter_list): Deleted.
1000         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
1001         (CppStyleTest.test_asm_lines_ignored): Deleted.
1002         (CppStyleTest.test_get_line_width): Deleted.
1003         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
1004         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
1005         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
1006         (CppStyleTest.test_position): Deleted.
1007         (CppStyleTest.test_rfind_in_lines): Deleted.
1008         (CppStyleTest.test_close_expression): Deleted.
1009         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
1010         (CppStyleTest.test_cstyle_cast): Deleted.
1011         (CppStyleTest.test_runtime_casting): Deleted.
1012         (CppStyleTest.test_runtime_selfinit): Deleted.
1013         (CppStyleTest.test_runtime_rtti): Deleted.
1014         (CppStyleTest.test_static_cast_readability): Deleted.
1015         (CppStyleTest.test_check_for_unnamed_params): Deleted.
1016         (CppStyleTest.void): Deleted.
1017         (CppStyleTest.test_deprecated_cast): Deleted.
1018         (CppStyleTest.test_mock_method): Deleted.
1019         (CppStyleTest.test_sizeof_type): Deleted.
1020         (CppStyleTest.cases): Deleted.
1021         (CppStyleTest.for): Deleted.
1022         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
1023         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
1024         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
1025         (CppStyleTest.test_include_what_you_use): Deleted.
1026         (CppStyleTest.test_files_belong_to_same_module): Deleted.
1027         (CppStyleTest.test_cleanse_line): Deleted.
1028         (CppStyleTest.test_multi_line_comments): Deleted.
1029         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
1030         (CppStyleTest.test_multiline_strings): Deleted.
1031         (CppStyleTest.test_platformh_comments): Deleted.
1032         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
1033         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
1034         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
1035         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
1036         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
1037         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
1038         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
1039         (CppStyleTest.test_check_posix_threading): Deleted.
1040         (CppStyleTest.test_insecure_string_operations): Deleted.
1041         (CppStyleTest.test_format_strings): Deleted.
1042         (CppStyleTest.test_insecure_temp_file): Deleted.
1043         (CppStyleTest.test_variable_length_array_detection): Deleted.
1044         (CppStyleTest.test_braces): Deleted.
1045         (CppStyleTest.test_check_check): Deleted.
1046         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
1047         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
1048         (CppStyleTest.test_spacing_for_fncall): Deleted.
1049         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
1050         (CppStyleTest.test_spacing_before_braces): Deleted.
1051         (CppStyleTest.test_spacing_between_braces): Deleted.
1052         (CppStyleTest.test_spacing_before_brackets): Deleted.
1053         (CppStyleTest.test_cpp_lambda_functions): Deleted.
1054         (CppStyleTest.test_objective_c_block): Deleted.
1055         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
1056         (CppStyleTest.test_spacing_around_else): Deleted.
1057         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
1058         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
1059         (CppStyleTest.test_operator_methods): Deleted.
1060         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
1061         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
1062         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
1063         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
1064         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
1065         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
1066         (CppStyleTest.test_space_after_comment_marker): Deleted.
1067         (CppStyleTest.test_newline_at_eof): Deleted.
1068         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
1069         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
1070         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
1071         (CppStyleTest.test_invalid_utf8): Deleted.
1072         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
1073         (CppStyleTest.test_is_blank_line): Deleted.
1074         (CppStyleTest.test_blank_lines_check): Deleted.
1075         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
1076         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
1077         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
1078         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
1079         (CppStyleTest.test_comma): Deleted.
1080         (CppStyleTest.test_declaration): Deleted.
1081         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
1082         (CppStyleTest.test_indent): Deleted.
1083         (CppStyleTest.test_indent.Foo): Deleted.
1084         (CppStyleTest.test_not_alabel): Deleted.
1085         (CppStyleTest.test_tab): Deleted.
1086         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
1087         (CppStyleTest.test_build_class): Deleted.
1088         (CppStyleTest.test_build_class.definitions): Deleted.
1089         (CppStyleTest.test_build_class.Foo): Deleted.
1090         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
1091         (CppStyleTest.test_build_end_comment): Deleted.
1092         (CppStyleTest.test_build_forward_decl): Deleted.
1093         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
1094         (CppStyleTest.test_build_header_guard): Deleted.
1095         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
1096         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
1097         (CppStyleTest.test_build_printf_format): Deleted.
1098         (CppStyleTest.test_runtime_printf_format): Deleted.
1099         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
1100         (CppStyleTest.test_build_storage_class): Deleted.
1101         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
1102         (CppStyleTest.test_build_storage_class.declaration): Deleted.
1103         (CppStyleTest.test_build_storage_class.after): Deleted.
1104         (CppStyleTest.test_build_storage_class.is): Deleted.
1105         (CppStyleTest.test_legal_copyright): Deleted.
1106         (CppStyleTest.test_invalid_increment): Deleted.
1107         (CppStyleTest.test_enum_bitfields): Deleted.
1108         (CppStyleTest.test_plain_integral_bitfields): Deleted.
1109         (CleansedLinesTest.test_init_empty): Deleted.
1110         (CleansedLinesTest.test_collapse_strings): Deleted.
1111         (OrderOfIncludesTest.tearDown): Deleted.
1112         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
1113         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
1114         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
1115         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
1116         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
1117         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
1118         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
1119         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
1120         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
1121         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
1122         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
1123         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
1124         (OrderOfIncludesTest.test_primary_header): Deleted.
1125         (OrderOfIncludesTest.test_public_primary_header): Deleted.
1126         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
1127         (OrderOfIncludesTest.test_classify_include): Deleted.
1128         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
1129         (CheckForFunctionLengthsTest.tearDown): Deleted.
1130         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
1131         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
1132         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
1133         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
1134         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
1135         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
1136         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
1137         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
1138         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
1139         (CheckForFunctionLengthsTest.function_body): Deleted.
1140         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
1141         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
1142         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
1143         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
1144         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
1145         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
1146         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
1147         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
1148         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
1149         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
1150         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
1151         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
1152         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
1153         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
1154         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
1155         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
1156         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
1157         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
1158         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
1159         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
1160         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
1161         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
1162         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
1163         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
1164         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
1165         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
1166         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
1167         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
1168         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
1169         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
1170         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
1171         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
1172         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
1173         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
1174         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
1175         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
1176         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
1177         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
1178         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
1179         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
1180         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
1181         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
1182         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
1183         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
1184         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
1185         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
1186         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
1187         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
1188         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
1189         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
1190         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
1191         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
1192         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
1193         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
1194         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
1195         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
1196         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
1197         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
1198         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
1199         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
1200         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
1201         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
1202         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
1203         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
1204         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
1205         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
1206         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
1207         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
1208         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
1209         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
1210         (LeakyPatternTest.test_get_dc): Deleted.
1211         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
1212         (LeakyPatternTest.test_own_get_dc): Deleted.
1213         (LeakyPatternTest.test_create_dc): Deleted.
1214         (LeakyPatternTest.test_create_compatible_dc): Deleted.
1215         (WebKitStyleTest.test_indentation): Deleted.
1216         (WebKitStyleTest.test_indentation.Foo): Deleted.
1217         (WebKitStyleTest.test_indentation.Document): Deleted.
1218         (WebKitStyleTest.test_spacing): Deleted.
1219         (WebKitStyleTest.test_line_breaking): Deleted.
1220         (WebKitStyleTest.test_braces): Deleted.
1221         (WebKitStyleTest.test_braces.MyClass): Deleted.
1222         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
1223         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
1224         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
1225         (WebKitStyleTest.test_null_false_zero): Deleted.
1226         (WebKitStyleTest.test_directive_indentation): Deleted.
1227         (WebKitStyleTest.test_using_std): Deleted.
1228         (WebKitStyleTest.test_using_namespace): Deleted.
1229         (WebKitStyleTest.test_max_macro): Deleted.
1230         (WebKitStyleTest.test_min_macro): Deleted.
1231         (WebKitStyleTest.test_wtf_move): Deleted.
1232         (WebKitStyleTest.test_ctype_fucntion): Deleted.
1233         (WebKitStyleTest.test_names): Deleted.
1234         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
1235         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
1236         (WebKitStyleTest.test_names.declarations): Deleted.
1237         (WebKitStyleTest.test_names.struct): Deleted.
1238         (WebKitStyleTest.test_names.VectorType): Deleted.
1239         (WebKitStyleTest.test_parameter_names): Deleted.
1240         (WebKitStyleTest.test_comments): Deleted.
1241         (WebKitStyleTest.test_webkit_export_check): Deleted.
1242         (WebKitStyleTest.test_member_initialization_list): Deleted.
1243         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
1244         (WebKitStyleTest.test_other): Deleted.
1245         (CppCheckerTest.mock_handle_style_error): Deleted.
1246         (CppCheckerTest._checker): Deleted.
1247         (CppCheckerTest.test_init): Deleted.
1248         (CppCheckerTest.test_eq): Deleted.
1249         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
1250         (CppCheckerTest.test_ne): Deleted.
1251         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1252         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1253         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1254         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1255         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1256         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1257
1258 2017-07-05  Saam Barati  <sbarati@apple.com>
1259
1260         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
1261         https://bugs.webkit.org/show_bug.cgi?id=174188
1262         <rdar://problem/30581423>
1263
1264         Reviewed by Mark Lam.
1265
1266         * Scripts/run-jsc-stress-tests:
1267
1268 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1269
1270         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1271         https://bugs.webkit.org/show_bug.cgi?id=174150
1272
1273         Reviewed by Mark Lam.
1274
1275         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1276         (TestWebKitAPI::TEST):
1277
1278 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1279
1280         Remove copy of ICU headers from WebKit
1281         https://bugs.webkit.org/show_bug.cgi?id=116407
1282
1283         Reviewed by Alex Christensen.
1284
1285         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1286         * TestWebKitAPI/Configurations/Base.xcconfig:
1287         * WebKitTestRunner/Configurations/Base.xcconfig:
1288
1289 2017-07-05  Chris Dumez  <cdumez@apple.com>
1290
1291         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
1292         https://bugs.webkit.org/show_bug.cgi?id=174163
1293         <rdar://problem/33067518>
1294
1295         Reviewed by Alex Christensen.
1296
1297         Add API test coverage.
1298
1299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1300         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
1301         (TEST):
1302
1303 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1304
1305         When dragging a selection, clearing the selection in dragstart should not crash the web process
1306         https://bugs.webkit.org/show_bug.cgi?id=174142
1307         <rdar://problem/33067501>
1308
1309         Reviewed by Tim Horton.
1310
1311         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
1312         drag is starting up.
1313
1314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1315         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
1316         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1317         (TestWebKitAPI::TEST):
1318
1319 2017-07-05  Daniel Bates  <dabates@apple.com>
1320
1321         Do not pass API::FrameInfo for source frame or clear out page of target frame on
1322         API navigation
1323         https://bugs.webkit.org/show_bug.cgi?id=174170
1324         <rdar://problem/33140328>
1325
1326         Reviewed by Brady Eidson.
1327
1328         Update tests as needed for the behavior change.
1329
1330         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1331         (TEST):
1332
1333 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
1334
1335         Add WebKitPrivateFrameworkStubs for iOS 11
1336         https://bugs.webkit.org/show_bug.cgi?id=173988
1337
1338         Reviewed by David Kilzer.
1339
1340         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
1341         should use the same directory for private framework stubs.
1342         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1343
1344 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
1345
1346         [MediaStream] Protect request and web view during gUM client callback
1347         https://bugs.webkit.org/show_bug.cgi?id=174096
1348         <rdar://problem/32833102>
1349
1350         Reviewed by Youenn Fablet.
1351
1352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1353         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
1354
1355 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1356
1357         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
1358
1359         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1360
1361 2017-07-05  Matt Lewis  <jlewis3@apple.com>
1362
1363         Unreviewed, rolling out r219128.
1364
1365         Spoke with engineer who originally submitted, Patch for APi
1366         test to follow.
1367
1368         Reverted changeset:
1369
1370         "Unreviewed, rolling out r219070."
1371         https://bugs.webkit.org/show_bug.cgi?id=174082
1372         http://trac.webkit.org/changeset/219128
1373
1374 2017-07-05  Matt Lewis  <jlewis3@apple.com>
1375
1376         Unreviewed, rolling out r219070.
1377
1378         This revision caused consistent failures of the API test
1379         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
1380
1381         Reverted changeset:
1382
1383         "Pasting single words copied to UIPasteboard inserts URLs in
1384         editable areas"
1385         https://bugs.webkit.org/show_bug.cgi?id=174082
1386         http://trac.webkit.org/changeset/219070
1387
1388 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1389
1390         Remove unused EFL logo from bot watcher dashboard
1391         https://bugs.webkit.org/show_bug.cgi?id=174136
1392
1393         Reviewed by Alexey Proskuryakov.
1394
1395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
1396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
1397
1398 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1399
1400         [GTK] Add more GTK bots to dashboard
1401         https://bugs.webkit.org/show_bug.cgi?id=174129
1402
1403         Reviewed by Carlos Alberto Lopez Perez.
1404
1405         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
1406         them.
1407
1408         This also changes the sort order to put WPE above GTK so that it's not buried under all the
1409         less-essential GTK bots.
1410
1411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1412         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1413         (WebKitBuildbot):
1414
1415 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1416
1417         [WPE] Add WPE to bot watcher dashboard
1418         https://bugs.webkit.org/show_bug.cgi?id=174119
1419
1420         Reviewed by Alexey Proskuryakov.
1421
1422         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
1423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
1424         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
1425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1427         (WebKitBuildbot):
1428         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1429         (table.queue-grid tr.platform.linux-wpe img.logo):
1430
1431 2017-07-03  Lucas Forschler  <lforschler@apple.com>
1432
1433         https://bugs.webkit.org/show_bug.cgi?id=174105
1434         
1435         Reviewed by Stephanie Lewis.
1436
1437         * BuildSlaveSupport/built-product-archive:
1438         (main): Add a -minify parser option
1439         (createZip): Pass along the optional Minify argument if requested
1440         (minifySource): This will trim down archives, logic limited to Mac platform.
1441
1442 2017-07-03  Matt Rajca  <mrajca@apple.com>
1443
1444         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
1445         https://bugs.webkit.org/show_bug.cgi?id=174103
1446
1447         Reviewed by Alex Christensen.
1448
1449         Added an API test.
1450
1451         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
1452         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1453         (TEST): Added test.
1454         * TestWebKitAPI/cocoa/TestWKWebView.h:
1455         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1456         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
1457
1458 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1459
1460         Unreviewed, rolling out r219103.
1461
1462         Caused multiple build failures.
1463
1464         Reverted changeset:
1465
1466         "Remove copy of ICU headers from WebKit"
1467         https://bugs.webkit.org/show_bug.cgi?id=116407
1468         http://trac.webkit.org/changeset/219103
1469
1470 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1471
1472         Remove copy of ICU headers from WebKit
1473         https://bugs.webkit.org/show_bug.cgi?id=116407
1474
1475         Reviewed by Alex Christensen.
1476
1477         Use WTF's copy of ICU headers.
1478
1479         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1480         * TestWebKitAPI/Configurations/Base.xcconfig:
1481         * WebKitTestRunner/Configurations/Base.xcconfig:
1482
1483 2017-07-03  Brady Eidson  <beidson@apple.com>
1484
1485         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
1486         https://bugs.webkit.org/show_bug.cgi?id=174073
1487
1488         Reviewed by Andy Estes.
1489
1490         * DumpRenderTree/mac/TestRunnerMac.mm:
1491         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
1492
1493         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
1494         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
1495
1496 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1497
1498         Unreviewed, rolling out r219083.
1499
1500         The revision caused an API failure on all testing platforms.
1501
1502         Reverted changeset:
1503
1504         "[MediaStream] Protect request and web view during gUM client
1505         callback"
1506         https://bugs.webkit.org/show_bug.cgi?id=174096
1507         http://trac.webkit.org/changeset/219083
1508
1509 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
1510
1511         webkitpy: Properly number duplicated crashlogs
1512         https://bugs.webkit.org/show_bug.cgi?id=172002
1513
1514         Reviewed by Aakash Jain.
1515
1516         * Scripts/webkitpy/common/system/crashlogs.py:
1517         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
1518         an increasing integer.
1519         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1520         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
1521         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
1522         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
1523
1524 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
1525
1526         WebContent processes crash when the network process crashes with pending connection requests
1527         https://bugs.webkit.org/show_bug.cgi?id=174065
1528         <rdar://problem/30359835>
1529
1530         Reviewed by Tim Horton.
1531
1532         Add a API to ensure UI process tries to relaunch a new network process when the network process
1533         crashes with pending network connection requests.
1534
1535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1536         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
1537         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1538         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1539         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
1540
1541 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
1542
1543         [MediaStream] Protect request and web view during gUM client callback
1544         https://bugs.webkit.org/show_bug.cgi?id=174096
1545         <rdar://problem/32833102>
1546
1547         Reviewed by Youenn Fablet.
1548
1549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1550         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
1551
1552 2017-07-03  Andy Estes  <aestes@apple.com>
1553
1554         [Xcode] Add an experimental setting to build with ccache
1555         https://bugs.webkit.org/show_bug.cgi?id=173875
1556
1557         Reviewed by Tim Horton.
1558
1559         On systems that already have ccache(1) installed, this patch adds experimental support for
1560         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
1561
1562         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
1563         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
1564         find the toolchain from which to run clang, and then invokes ccache with the required
1565         arguments.
1566
1567         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
1568         precompiled headers to work properly [1].
1569
1570         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
1571         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
1572         during linking.
1573         
1574         [1] https://ccache.samba.org/manual.html#_precompiled_headers
1575
1576         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
1577         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
1578         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
1579         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
1580         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
1581         * ccache/README.md: Added.
1582         * ccache/ccache-clang: Added.
1583         * ccache/ccache-clang++: Added.
1584         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
1585
1586 2017-07-03  Alex Christensen  <achristensen@webkit.org>
1587
1588         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
1589         https://bugs.webkit.org/show_bug.cgi?id=174051
1590
1591         Reviewed by Tim Horton.
1592
1593         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1594         (TestWebKitAPI::TEST_F):
1595
1596 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1597
1598         Unreviewed, rolling out r219024.
1599
1600         This patch cause 3 didferent test to fail.
1601
1602         Reverted changeset:
1603
1604         "REGRESSION(r215096) Queries of URLs with non-special schemes
1605         should not percent-encode single quotes"
1606         https://bugs.webkit.org/show_bug.cgi?id=174051
1607         http://trac.webkit.org/changeset/219024
1608
1609 2017-07-03  Chris Dumez  <cdumez@apple.com>
1610
1611         Drop ResourceLoadStatisticsStore's statisticsLock
1612         https://bugs.webkit.org/show_bug.cgi?id=174080
1613
1614         Reviewed by Brent Fulgham.
1615
1616         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
1617
1618         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1619         (WTR::TestController::isStatisticsPrevalentResource):
1620         (WTR::TestController::isStatisticsHasHadUserInteraction):
1621         (WTR::TestController::isStatisticsGrandfathered):
1622
1623 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1624
1625         Pasting single words copied to UIPasteboard inserts URLs in editable areas
1626         https://bugs.webkit.org/show_bug.cgi?id=174082
1627         <rdar://problem/33046992>
1628
1629         Reviewed by Tim Horton.
1630
1631         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
1632
1633         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1634         (TestWebKitAPI::setUpWebViewForPasteboardTests):
1635         (TestWebKitAPI::TEST):
1636
1637 2017-07-02  Brady Eidson  <beidson@apple.com>
1638
1639         Add API test for all parts of WebKit1 API related to favicons.
1640         https://bugs.webkit.org/show_bug.cgi?id=174069
1641
1642         Reviewed by Andy Estes.
1643
1644         These two API tests cover all WebKit1 API related to icons.
1645         
1646         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1647         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
1648         (mainResourceData):
1649         (defaultFaviconData):
1650         (customFaviconData):
1651         (imageFromData):
1652         (+[IconLoadingProtocol canInitWithRequest:]):
1653         (+[IconLoadingProtocol canonicalRequestForRequest:]):
1654         (-[IconLoadingProtocol startLoading]):
1655         (-[IconLoadingProtocol stopLoading]):
1656         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1657         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
1658         (TestWebKitAPI::TEST):
1659
1660 2017-07-01  Dan Bernstein  <mitz@apple.com>
1661
1662         [iOS] Remove code only needed when building for iOS 9.x
1663         https://bugs.webkit.org/show_bug.cgi?id=174068
1664
1665         Reviewed by Tim Horton.
1666
1667         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1668         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1669         (WTR::initializeWebViewConfiguration):
1670         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1671         (-[HIDEventGenerator _createIOHIDEventType:]):
1672
1673 2017-07-01  Brady Eidson  <beidson@apple.com>
1674
1675         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
1676         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
1677
1678         Reviewed by Alex Christensen.
1679
1680         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1681
1682 2017-07-01  Dan Bernstein  <mitz@apple.com>
1683
1684         [macOS] Remove code only needed when building for OS X Yosemite
1685         https://bugs.webkit.org/show_bug.cgi?id=174067
1686
1687         Reviewed by Tim Horton.
1688
1689         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1690         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1691         * DumpRenderTree/mac/DumpRenderTree.mm:
1692         (setDefaultsToConsistentValuesForTesting):
1693         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1694         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
1695         * MiniBrowser/Configurations/Base.xcconfig:
1696         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1697         * TestWebKitAPI/Configurations/Base.xcconfig:
1698         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1699         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1700         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1701         (TestWebKitAPI::TEST_F):
1702         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1703         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
1704         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1705         (TestWebKitAPI::TEST_F):
1706         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1707         (TestWebKitAPI::TEST):
1708         * WebKitTestRunner/Configurations/Base.xcconfig:
1709         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1710         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1711         (WTR::InjectedBundle::platformInitialize):
1712         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1713         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
1714
1715 2017-07-01  Chris Dumez  <cdumez@apple.com>
1716
1717         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
1718         https://bugs.webkit.org/show_bug.cgi?id=174060
1719
1720         Reviewed by Brent Fulgham.
1721
1722         Port WebKitTestRunner over to the new Cocoa SPI.
1723
1724         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1725         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1726         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1727         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
1728         no-ops since this code runs in the WebContent process, not the
1729         UIProcess.
1730
1731         * WebKitTestRunner/TestController.cpp:
1732         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1733
1734 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
1735
1736         Unreviewed mac build fix.
1737
1738         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
1739         (TestWebKitAPI::TEST):
1740
1741 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
1742
1743         Add API to get WKActivatedElementInfo
1744         https://bugs.webkit.org/show_bug.cgi?id=174001
1745         <rdar://problem/29165518>
1746         
1747         Tests for now SPI to get activatedElementInfo.
1748
1749         Reviewed by Tim Horton.
1750
1751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1752         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
1753         (TestWebKitAPI::TEST):
1754
1755 2017-06-30  Chris Dumez  <cdumez@apple.com>
1756
1757         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
1758         https://bugs.webkit.org/show_bug.cgi?id=174038
1759
1760         Reviewed by Brent Fulgham.
1761
1762         Fix typo in API name.
1763
1764         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1765         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1766         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1767         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1768         * WebKitTestRunner/TestController.cpp:
1769         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1770         * WebKitTestRunner/TestController.h:
1771         * WebKitTestRunner/TestInvocation.cpp:
1772         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1773
1774 2017-06-30  Alex Christensen  <achristensen@webkit.org>
1775
1776         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
1777         https://bugs.webkit.org/show_bug.cgi?id=174051
1778         <rdar://problem/33002846>
1779
1780         Reviewed by Tim Horton.
1781
1782         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1783         (TestWebKitAPI::TEST_F):
1784
1785 2017-06-30  Daniel Bates  <dabates@apple.com>
1786
1787         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
1788         https://bugs.webkit.org/show_bug.cgi?id=165160
1789         <rdar://problem/29451999>
1790
1791         Reviewed by Brady Eidson.
1792
1793         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
1794         for navigations and window creation.
1795
1796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1797         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
1798         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
1799         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
1800         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1801         (TEST):
1802
1803 2017-06-29  Jer Noble  <jer.noble@apple.com>
1804
1805         Make Legacy EME API controlled by RuntimeEnabled setting.
1806         https://bugs.webkit.org/show_bug.cgi?id=173994
1807
1808         Reviewed by Sam Weinig.
1809
1810         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1811
1812 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
1813
1814         Follow-up fix for r218996
1815
1816         Unreviewed infrastructure fix.
1817
1818         Repeated calls to 'ios_version' make the log noisy, memoize the function.
1819
1820         * Scripts/webkitpy/port/ios_simulator.py:
1821         (IOSSimulatorPort): Memoize ios_version().
1822
1823 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1824
1825         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
1826         https://bugs.webkit.org/show_bug.cgi?id=174017
1827         <rdar://problem/32959782>
1828
1829         Reviewed by Simon Fraser.
1830
1831         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
1832         changes, the caret would appear outside of the iframe.
1833
1834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1835         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
1836         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1837         (checkDragCaretRectIsContainedInRect):
1838         (TestWebKitAPI::TEST):
1839         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1840         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1841         (-[DataInteractionSimulator _resetSimulatedState]):
1842         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
1843         (-[DataInteractionSimulator _advanceProgress]):
1844         (-[DataInteractionSimulator lastKnownDragCaretRect]):
1845
1846 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
1847
1848         Add support for different versions of iOS when loading test expectations
1849         https://bugs.webkit.org/show_bug.cgi?id=173774
1850         <rdar://problem/32951132>
1851
1852         Rubber-stamped by Aakash Jain.
1853
1854         When running layout tests, we should support multiple version of iOS the same way we do Mac.
1855
1856         * Scripts/webkitpy/port/ios.py:
1857         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
1858         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
1859         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
1860         * Scripts/webkitpy/port/ios_device.py:
1861         (IOSDevicePort.ios_version): Ask connected devices for implementation.
1862         * Scripts/webkitpy/port/ios_device_unittest.py:
1863         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
1864         (IOSDeviceTest.test_baseline_searchpath): Ditto.
1865         (IOSDeviceTest.test_expectations_ordering): Ditto.
1866         * Scripts/webkitpy/port/ios_simulator.py:
1867         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
1868         ask the platform.
1869
1870 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
1871
1872         Fontconfig build breaks with glibc 2.15+
1873         https://bugs.webkit.org/show_bug.cgi?id=174019
1874
1875         Reviewed by Carlos Alberto Lopez Perez.
1876
1877         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
1878
1879         * wpe/jhbuild.modules:
1880         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
1881
1882 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1883
1884         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
1885         https://bugs.webkit.org/show_bug.cgi?id=174010
1886         <rdar://problem/32597802>
1887
1888         Reviewed by Tim Horton.
1889
1890         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
1891         snapshot fails for any reason.
1892
1893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1894         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
1895         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1896         (TestWebKitAPI::TEST):
1897
1898 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
1899
1900         AX: Cannot call setValue() on contenteditable or ARIA text controls
1901         https://bugs.webkit.org/show_bug.cgi?id=173520
1902
1903         Reviewed by Ryosuke Niwa.
1904
1905         Add setValue() method to WKTR (already existed in DRT).
1906
1907         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1908         (WTR::AccessibilityUIElement::setValue):
1909         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1910         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1911         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1912         (WTR::AccessibilityUIElement::setValue):
1913
1914 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
1915
1916         getBoundingClientRect returns wrong value for combination of page zoom and scroll
1917         https://bugs.webkit.org/show_bug.cgi?id=173841
1918         rdar://problem/32983841
1919
1920         Reviewed by Dean Jackson.
1921
1922         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
1923         always did text zooming.
1924
1925         * MiniBrowser/mac/WK1BrowserWindowController.m:
1926         (-[WK1BrowserWindowController zoomIn:]):
1927         (-[WK1BrowserWindowController zoomOut:]):
1928         (-[WK1BrowserWindowController canResetZoom]):
1929         (-[WK1BrowserWindowController resetZoom:]):
1930
1931 2017-06-29  John Wilander  <wilander@apple.com>
1932
1933         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
1934         https://bugs.webkit.org/show_bug.cgi?id=173940
1935         <rdar://problem/33018125>
1936
1937         Reviewed by Brent Fulgham.
1938
1939         This change allows the TestController to turn off
1940         regular resource load statistics telemetry submission
1941         and to manually control when telemetry is calculated
1942         and submitted.
1943
1944         * WebKitTestRunner/TestController.cpp:
1945         (WTR::TestController::initialize):
1946             Turns off automatic resource load statistics telemetry submission.
1947
1948 2017-06-29  Commit Queue  <commit-queue@webkit.org>
1949
1950         Unreviewed, rolling out r218512.
1951         https://bugs.webkit.org/show_bug.cgi?id=173981
1952
1953         "It changes the behavior of the JS API's JSEvaluateScript
1954         which breaks TurboTax" (Requested by saamyjoon on #webkit).
1955
1956         Reverted changeset:
1957
1958         "test262: Completion values for control flow do not match the
1959         spec"
1960         https://bugs.webkit.org/show_bug.cgi?id=171265
1961         http://trac.webkit.org/changeset/218512
1962
1963 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
1964
1965         Add WebKitSystemInterface for iOS 11
1966         https://bugs.webkit.org/show_bug.cgi?id=173936
1967
1968         Reviewed by Lucas Forschler.
1969
1970         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
1971
1972 2017-06-28  Keith Miller  <keith_miller@apple.com>
1973
1974         VMTraps has some races
1975         https://bugs.webkit.org/show_bug.cgi?id=173941
1976
1977         Reviewed by Michael Saboff.
1978
1979         Add new testing mode for testing the Watchdog with our stress
1980         tests.
1981
1982         * Scripts/run-jsc-stress-tests:
1983
1984 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1985
1986         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
1987         https://bugs.webkit.org/show_bug.cgi?id=173877
1988
1989         Reviewed by Brady Eidson.
1990
1991         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
1992         the next tests.
1993
1994         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1995         (testGetFavicon):
1996
1997 2017-06-28  Tim Horton  <timothy_horton@apple.com>
1998
1999         MobileSafari was constantly using 10-15% CPU viewing a PDF
2000         https://bugs.webkit.org/show_bug.cgi?id=173944
2001         <rdar://problem/33039910>
2002
2003         Reviewed by Simon Fraser.
2004
2005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2006         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2007         Add a test that we ever call the stable presentation update callback
2008         when we have a WKPDFView up, instead of infinitely looping.
2009
2010 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2011
2012         Prevent displaying URLs with small capital letters
2013         https://bugs.webkit.org/show_bug.cgi?id=173949
2014         <rdar://problem/32952058>
2015
2016         Reviewed by Brent Fulgham.
2017
2018         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2019         (TestWebKitAPI::TEST):
2020
2021 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2022
2023         Unreviewed test fix.
2024
2025         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
2026
2027         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
2028
2029 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2030
2031         Teach ResourceLoadStatistics to recognize changes in the file system
2032         https://bugs.webkit.org/show_bug.cgi?id=173800
2033         <rdar://problem/32937842>
2034
2035         Reviewed by Chris Dumez.
2036
2037         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2038         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
2039         (TestWebKitAPI::FileMonitorTest::tempFilePath):
2040         (TestWebKitAPI::handleFileModification):
2041         (TestWebKitAPI::handleFileDeletion):
2042         (TestWebKitAPI::resetTestState):
2043         (TestWebKitAPI::TEST_F):
2044
2045 2017-06-28  Brady Eidson  <beidson@apple.com>
2046
2047         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
2048         https://bugs.webkit.org/show_bug.cgi?id=173874
2049
2050         Reviewed by Alex Christensen.
2051
2052         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2053
2054 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
2055
2056         Unreviewed, adding Don Olmstead to contributors.json
2057
2058         * Scripts/webkitpy/common/config/contributors.json:
2059
2060 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2061
2062         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
2063         https://bugs.webkit.org/show_bug.cgi?id=173886
2064         <rdar://problem/32543191>
2065
2066         Reviewed by Andy Estes.
2067
2068         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2069         (ParsedRange::ParsedRange):
2070         (-[TestSchemeHandler initWithVideoData:]):
2071         (-[TestSchemeHandler webView:startURLSchemeTask:]):
2072         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
2073         (TEST):
2074
2075 2017-06-27  JF Bastien  <jfbastien@apple.com>
2076
2077         WebAssembly: running out of executable memory should throw OoM
2078         https://bugs.webkit.org/show_bug.cgi?id=171537
2079         <rdar://problem/32963338>
2080
2081         Reviewed by Saam Barati.
2082
2083         * Scripts/run-jsc-stress-tests: add a configuration which runs the
2084         tests under limited executable memory and avoids non-WebAssembly
2085         code generation so that we more reliably run out of executable
2086         memory in WebAssembly.
2087
2088 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2089
2090         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
2091         https://bugs.webkit.org/show_bug.cgi?id=173854
2092         <rdar://problem/32236827>
2093
2094         Reviewed by Ryosuke Niwa and Tim Horton.
2095
2096         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
2097
2098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2099         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
2100         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2101         (TestWebKitAPI::TEST):
2102
2103 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
2104
2105         [PAL] Add symbol export macros for PAL
2106         https://bugs.webkit.org/show_bug.cgi?id=171519
2107
2108         Reviewed by Konstantin Tokarev.
2109
2110         * DumpRenderTree/config.h:
2111         * TestWebKitAPI/CMakeLists.txt:
2112         * TestWebKitAPI/config.h:
2113         * WebKitTestRunner/config.h:
2114
2115 2017-06-27  John Wilander  <wilander@apple.com>
2116
2117         Resource Load Statistics: Add telemetry
2118         https://bugs.webkit.org/show_bug.cgi?id=173499
2119         <rdar://problem/32826094>
2120
2121         Reviewed by Brent Fulgham.
2122
2123         Adds three new testRunner functions:
2124         - installStatisticsDidRunTelemetryCallback()
2125         - statisticsFireTelemetryHandler()
2126         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
2127
2128         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2129         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2130         (WTR::InjectedBundle::didReceiveMessageToPage):
2131         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2132         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
2133         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
2134         (WTR::TestRunner::statisticsFireTelemetryHandler):
2135         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2136         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2137         * WebKitTestRunner/TestController.cpp:
2138         (WTR::TestController::resetStateToConsistentValues):
2139         (WTR::TestController::statisticsFireTelemetryHandler):
2140         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2141         * WebKitTestRunner/TestController.h:
2142         * WebKitTestRunner/TestInvocation.cpp:
2143         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2144
2145 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
2146
2147         Add missing includes to fix compilation error on FreeBSD
2148         https://bugs.webkit.org/show_bug.cgi?id=172919
2149
2150         Reviewed by Mark Lam.
2151
2152         * ImageDiff/cairo/PlatformImageCairo.cpp:
2153
2154 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
2155
2156         Unreviewed, rolling out r218783.
2157
2158         Causing accessibility/mac/setting-attributes-is-
2159         asynchronous.html to crash consistently on mac-wk2 Debug
2160
2161         Reverted changeset:
2162
2163         "AX: Cannot call setValue() on contenteditable or ARIA text
2164         controls"
2165         https://bugs.webkit.org/show_bug.cgi?id=173520
2166         http://trac.webkit.org/changeset/218783
2167
2168 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2169
2170         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
2171         https://bugs.webkit.org/show_bug.cgi?id=173825
2172
2173         Reviewed by Saam Barati.
2174
2175         * DumpRenderTree/JavaScriptThreading.cpp:
2176         (runJavaScriptThread):
2177         (startJavaScriptThreads):
2178         * DumpRenderTree/mac/DumpRenderTree.mm:
2179         (runThread):
2180         (runPthread):
2181         (testThreadIdentifierMap):
2182
2183 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2184
2185         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
2186         <https://webkit.org/b/173837>
2187
2188         Reviewed by Geoffrey Garen.
2189
2190         The clang static analyzer can't reason about objects that are
2191         assigned to a delegate as +1 retained, and then released
2192         later in a different method when the delegate is cleared.
2193
2194         Instead, use a common idiom where the object setting the
2195         delegate retains it as an instance variable on initialization.
2196         Then the same object clears the delegate and releases its
2197         instance variable during teardown.
2198
2199         Also add EXPECT_TRUE() tests to make sure the delegate objects
2200         match before teardown.
2201
2202         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2203         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2204         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2205         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2206         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2207         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
2208
2209 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2210
2211         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
2212         <https://webkit.org/b/173836>
2213
2214         Reviewed by Brady Eidson.
2215
2216         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2217         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
2218         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
2219         objects in this test.
2220
2221 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
2222
2223         [ATK] Add support for aria-details and aria-errormessage
2224         https://bugs.webkit.org/show_bug.cgi?id=172588
2225
2226         Reviewed by Chris Fleizach.
2227
2228         Add additional methods to test ARIA properties which are exposed via
2229         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
2230         to versions which support the details and error-message relation types.
2231
2232         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2233         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2234         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2235         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2236         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2237         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2238         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2239         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2240         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2241         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2242         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2243         * gtk/jhbuild.modules:
2244
2245 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2246
2247         Unreviewed. Add libfii to GTK+ install dependencies script.
2248
2249         * gtk/install-dependencies:
2250
2251 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2252
2253         Unreviewed, rolling out r215190.
2254
2255         Broke product select element on GNOME Bugzilla
2256
2257         Reverted changeset:
2258
2259         "[GTK] Misplaced right click menu on web page due to
2260         deprecated gtk_menu_popup()"
2261         https://bugs.webkit.org/show_bug.cgi?id=170553
2262         http://trac.webkit.org/changeset/215190
2263
2264 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
2265
2266         Remove Reflect.enumerate
2267         https://bugs.webkit.org/show_bug.cgi?id=173806
2268
2269         Reviewed by Yusuke Suzuki.
2270
2271         * Scripts/run-jsc-stress-tests:
2272
2273 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
2274
2275         AX: Cannot call setValue() on contenteditable or ARIA text controls
2276         https://bugs.webkit.org/show_bug.cgi?id=173520
2277
2278         Reviewed by Ryosuke Niwa.
2279
2280         Add setValue() method to WKTR (already existed in DRT).
2281
2282         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2283         (WTR::AccessibilityUIElement::setValue):
2284         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2285         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2286         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2287         (WTR::AccessibilityUIElement::setValue):
2288
2289 2017-06-23  Keith Miller  <keith_miller@apple.com>
2290
2291         Switch VMTraps to use halt instructions rather than breakpoint instructions
2292         https://bugs.webkit.org/show_bug.cgi?id=173677
2293
2294         Reviewed by JF Bastien.
2295
2296         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2297         (TEST):
2298
2299 2017-06-23  Youenn Fablet  <youenn@apple.com>
2300
2301         Set getUserMedia permission to true by default on WTR
2302         https://bugs.webkit.org/show_bug.cgi?id=173610
2303
2304         Reviewed by Alex Christensen.
2305
2306         Adding a way to reset the getUserMedia permission to pending.
2307
2308         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2309         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2310         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
2311         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2312         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2313         (WTR::TestRunner::setUserMediaPermissionAsUnset):
2314         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2315         * WebKitTestRunner/TestController.cpp:
2316         (WTR::TestController::resetStateToConsistentValues):
2317         (WTR::TestController::setUserMediaPermissionAsUnset):
2318         * WebKitTestRunner/TestController.h:
2319         * WebKitTestRunner/TestInvocation.cpp:
2320         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2321
2322 2017-06-23  Alex Christensen  <achristensen@webkit.org>
2323
2324         Add SPI to WKURLSchemeTask for redirection
2325         https://bugs.webkit.org/show_bug.cgi?id=173730
2326
2327         Reviewed by Brady Eidson.
2328
2329         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2330         (-[SchemeHandler webView:startURLSchemeTask:]):
2331         (-[SchemeHandler webView:stopURLSchemeTask:]):
2332         (TEST):
2333         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
2334         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
2335         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
2336         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
2337         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
2338
2339 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2340
2341         [WPE] Use JSC API to send script messages from web extension in tests
2342         https://bugs.webkit.org/show_bug.cgi?id=173757
2343
2344         Reviewed by Žan Doberšek.
2345
2346         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
2347         to run postMessage().
2348
2349         Fixes: /wpe/WebKitSecurityManager/file-xhr
2350                /wpe/WebKitConsoleMessage/console-api
2351                /wpe/WebKitConsoleMessage/js-exception
2352                /wpe/WebKitConsoleMessage/network-error
2353                /wpe/WebKitConsoleMessage/security-error
2354
2355         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2356         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
2357         (beforeAll): Ditto.
2358         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2359         (testWebContextSecurityFileXHR): Ditto.
2360         (beforeAll): Ditto.
2361         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2362         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
2363         (pageCreatedCallback): Remove ifdefs.
2364
2365 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2366
2367         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
2368
2369         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
2370         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
2371         doesn't exist yet in WPE.
2372
2373         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2374         (testWebViewJavaScriptDialogs):
2375         (testWebViewWindowProperties):
2376
2377 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2378
2379         [GTK] Upgrade pixman and cairo in jhbuild
2380         https://bugs.webkit.org/show_bug.cgi?id=173710
2381
2382         Reviewed by Carlos Alberto Lopez Perez.
2383
2384         * gtk/jhbuild.modules:
2385
2386 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2387
2388         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
2389         https://bugs.webkit.org/show_bug.cgi?id=173711
2390
2391         Reviewed by Carlos Alberto Lopez Perez.
2392
2393         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
2394         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
2395
2396         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2397         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
2398
2399 2017-06-22  David Kilzer  <ddkilzer@apple.com>
2400
2401         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
2402         <https://webkit.org/b/173721>
2403
2404         Reviewed by Joseph Pecoraro.
2405
2406         Use RetainPtr<> to create NSMutableDictionary and NSNumber
2407         objects to fix leaks and to avoid the autoreleasepool.
2408
2409         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
2410         (TEST):
2411
2412 2017-06-22  Matt Lewis  <jlewis3@apple.com>
2413
2414         Unreviewed, rolling out r218633.
2415
2416         The test is failing frequently on Sierra Debug and Windows
2417
2418         Reverted changeset:
2419
2420         "AX: Cannot call setValue() on contenteditable or ARIA text
2421         controls"
2422         https://bugs.webkit.org/show_bug.cgi?id=173520
2423         http://trac.webkit.org/changeset/218633
2424
2425 2017-06-22  David Kilzer  <ddkilzer@apple.com>
2426
2427         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
2428         <https://webkit.org/b/173690>
2429
2430         Reviewed by Chris Dumez.
2431
2432         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
2433         ownership of malloc()-ed memory, then frees it when it's
2434         released.  These tests were passing global variables into the
2435         method, which is not malloc()-ed memory, which violates the API
2436         contract.
2437
2438         The fix is to switch to use
2439         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
2440         NO for the last argument.
2441
2442         Caught by the clang static analyzer.
2443
2444         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2445         (TEST):
2446         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2447         (TEST):
2448
2449 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2450
2451         [GTK] Upgrade Harfbuzz to version 1.4.2
2452         https://bugs.webkit.org/show_bug.cgi?id=173592
2453
2454         Reviewed by Carlos Alberto Lopez Perez.
2455
2456         * gtk/jhbuild.modules:
2457
2458 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2459
2460         [WPE] Update WPEBackend-mesa
2461         https://bugs.webkit.org/show_bug.cgi?id=173705
2462
2463         Reviewed by Carlos Alberto Lopez Perez.
2464
2465         A crash has been fixed, needed for unit tests to work.
2466
2467         * wpe/jhbuild.modules:
2468
2469 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2470
2471         Remove unused coordinated graphics C API
2472         https://bugs.webkit.org/show_bug.cgi?id=173706
2473
2474         Reviewed by Žan Doberšek.
2475
2476         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
2477         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
2478         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
2479         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
2480         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
2481         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
2482
2483 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2484
2485         [WPE] Build glib API tests
2486         https://bugs.webkit.org/show_bug.cgi?id=173702
2487
2488         Reviewed by Žan Doberšek.
2489
2490         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
2491         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
2492         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
2493         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
2494         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
2495         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
2496         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
2497         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
2498         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
2499         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
2500         and implement the missing features.
2501
2502         * CMakeLists.txt:
2503         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
2504         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2505         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2506         (testAutomationSessionRequestSession):
2507         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2508         (testWebKitWebViewSessionState):
2509         (testWebKitWebViewSessionStateWithFormData):
2510         (testWebKitWebViewNavigationAfterSessionRestore):
2511         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2512         (beforeAll):
2513         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2514         (testCookieManagerEphemeral):
2515         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2516         (testBlobDownload):
2517         (beforeAll):
2518         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2519         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2520         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2521         (testProcessPerWebView):
2522         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2523         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2524         (testWebViewCreateNavigationData):
2525         (testWebViewJavaScriptDialogs):
2526         (testWebViewWindowProperties):
2527         (testWebViewMouseTarget):
2528         (testWebViewGeolocationPermissionRequests):
2529         (testWebViewUserMediaPermissionRequests):
2530         (testWebViewAudioOnlyUserMediaPermissionRequests):
2531         (testWebViewFileChooserRequest):
2532         (beforeAll):
2533         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2534         (beforeAll):
2535         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2536         (testPrivateBrowsing):
2537         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2538         (testFindControllerHide):
2539         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2540         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2541         (testWebKitSettings):
2542         (beforeAll):
2543         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2544         (testWebViewNewWithUserContentManager):
2545         (beforeAll):
2546         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2547         (testWebContextEphemeral):
2548         (testWebContextProxySettings):
2549         (beforeAll):
2550         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2551         (testWebViewWebContext):
2552         (testWebViewWebContextLifetime):
2553         (testWebViewEphemeral):
2554         (testWebViewSettings):
2555         (testWebViewCanShowMIMEType):
2556         (testWebViewPageVisibility):
2557         (testWebViewIsPlayingAudio):
2558         (beforeAll):
2559         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2560         (testWebsiteDataEphemeral):
2561         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2562         (documentLoadedCallback):
2563         (pageCreatedCallback):
2564         (methodCallCallback):
2565         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
2566         * TestWebKitAPI/glib/CMakeLists.txt:
2567         * TestWebKitAPI/glib/PlatformGTK.cmake:
2568         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2569         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2570         (main):
2571         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2572         (Test::adoptView):
2573         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2574         (WebKitTestBus::run):
2575         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2576         (WebViewTest::~WebViewTest):
2577         (WebViewTest::initializeWebView):
2578         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
2579         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
2580         (WebViewTest::platformDestroy):
2581         (WebViewTest::platformInitializeWebView):
2582         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
2583         (WebViewTest::resizeView):
2584         (WebViewTest::hideView):
2585         (parentWindowMapped):
2586         (WebViewTest::showInWindow):
2587         (WebViewTest::showInWindowAndWaitUntilMapped):
2588         (WebViewTest::mouseMoveTo):
2589         (WebViewTest::clickMouseButton):
2590         (WebViewTest::emitPopupMenuSignal):
2591         (WebViewTest::keyStroke):
2592         (WebViewTest::doMouseButtonEvent):
2593         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
2594         (WebViewTest::platformDestroy):
2595         (WebViewTest::platformInitializeWebView):
2596         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
2597         (WebViewTest::resizeView):
2598         (WebViewTest::hideView):
2599         (WebViewTest::mouseMoveTo):
2600         (WebViewTest::clickMouseButton):
2601         (WebViewTest::keyStroke):
2602
2603 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2604
2605         [GTK] Move WebKit2 GLib API tests to glib directories
2606         https://bugs.webkit.org/show_bug.cgi?id=173642
2607
2608         Reviewed by Žan Doberšek.
2609
2610         * CMakeLists.txt:
2611         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
2612         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
2613         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
2614         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
2615         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
2616         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
2617         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
2618         (testWebKitConsoleMessageNetworkError):
2619         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
2620         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
2621         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
2622         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
2623         (testLoadFromGResource):
2624         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
2625         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
2626         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
2627         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
2628         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
2629         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
2630         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
2631         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
2632         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
2633         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
2634         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
2635         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
2636         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
2637         (testWebViewRunJavaScript):
2638         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
2639         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
2640         (registerGResource):
2641         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
2642         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
2643         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
2644         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
2645         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
2646         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
2647         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
2648         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
2649         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
2650         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
2651         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
2652         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
2653         * TestWebKitAPI/glib/CMakeLists.txt: Added.
2654         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
2655         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
2656         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
2657         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
2658         (registerGResource):
2659         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
2660         (Test::getResourcesDir):
2661         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
2662         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
2663         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
2664         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
2665         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
2666         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
2667
2668 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2669
2670         [WPE] Add initial web extensions API
2671         https://bugs.webkit.org/show_bug.cgi?id=173640
2672
2673         Reviewed by Žan Doberšek.
2674
2675         Add style checker exceptions for WPE web extensions API files.
2676
2677         * Scripts/webkitpy/style/checker.py:
2678
2679 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2680
2681         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
2682         https://bugs.webkit.org/show_bug.cgi?id=173659
2683         <rdar://problem/32879788>
2684
2685         Reviewed by Tim Horton.
2686
2687         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
2688
2689         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
2690
2691         Augment this test page to log dragend and dragstart events on the drag source as well.
2692
2693         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2694         (checkStringArraysAreEqual):
2695         (TestWebKitAPI::TEST):
2696
2697 2017-06-21  Antoine Quint  <graouts@apple.com>
2698
2699         Ensure DRT always logs rAF suspension debugging code
2700         https://bugs.webkit.org/show_bug.cgi?id=173681
2701
2702         Reviewed by Tim "Mr. T" Horton.
2703
2704         * DumpRenderTree/mac/DumpRenderTree.mm:
2705         (resetWebPreferencesToConsistentValues):
2706
2707 2017-06-21  Chris Dumez  <cdumez@apple.com>
2708
2709         Allow constructing a WTF:Function from a function pointer
2710         https://bugs.webkit.org/show_bug.cgi?id=173660
2711
2712         Reviewed by Alex Christensen.
2713
2714         Add API test coverage.
2715
2716         * TestWebKitAPI/Tests/WTF/Function.cpp:
2717         (TestWebKitAPI::returnThree):
2718         (TestWebKitAPI::returnFour):
2719         (TestWebKitAPI::returnPassedValue):
2720         (TestWebKitAPI::TEST):
2721
2722 2017-06-21  Antoine Quint  <graouts@apple.com>
2723
2724         Add logging to identify when the Page suspends scripted animations
2725         https://bugs.webkit.org/show_bug.cgi?id=173626
2726
2727         Reviewed by Tim Horton.
2728
2729         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
2730
2731         * DumpRenderTree/mac/DumpRenderTree.mm:
2732         (resetWebPreferencesToConsistentValues):
2733
2734 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
2735
2736         AX: Cannot call setValue() on contenteditable or ARIA text controls
2737         https://bugs.webkit.org/show_bug.cgi?id=173520
2738
2739         Reviewed by Ryosuke Niwa.
2740
2741         Add setValue() method to WKTR (already existed in DRT).
2742
2743         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2744         (WTR::AccessibilityUIElement::setValue):
2745         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2746         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2747         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2748         (WTR::AccessibilityUIElement::setValue):
2749
2750 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
2751
2752         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
2753         as one of the dependencies required to build the product.
2754
2755         Rubber-stamped by Carlos Garcia Campos.
2756
2757         * gtk/install-dependencies:
2758         * wpe/install-dependencies:
2759
2760 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
2761
2762         Disable font variations on macOS Sierra and iOS 10
2763         https://bugs.webkit.org/show_bug.cgi?id=173618
2764         <rdar://problem/32879164>
2765
2766         Reviewed by Jon Lee.
2767
2768         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2769
2770 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2771
2772         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
2773         https://bugs.webkit.org/show_bug.cgi?id=173578
2774         <rdar://problem/32825028>
2775
2776         Reviewed by Tim Horton.
2777
2778         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
2779         a custom popover does not cause dragging to fail when the popover is presented.
2780
2781         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2782         (-[DataInteractionSimulator _advanceProgress]):
2783
2784 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2785
2786         [WPE] Add initial implementation of glib API
2787         https://bugs.webkit.org/show_bug.cgi?id=173546
2788
2789         Reviewed by Žan Doberšek.
2790
2791         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
2792         include WPE glib API files.
2793
2794         * Scripts/webkitperl/FeatureList.pm:
2795         * Scripts/webkitpy/style/checker.py:
2796         * Scripts/webkitpy/style/checkers/cpp.py:
2797         (check_identifier_name_in_declaration):
2798
2799 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2800
2801         [GTK] Upgrade to ICU to version 57.1
2802         https://bugs.webkit.org/show_bug.cgi?id=173538
2803
2804         Reviewed by Žan Doberšek.
2805
2806         * gtk/jhbuild.modules:
2807
2808 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2809
2810         [GTK] Remove unneeded modules from the jhbuild
2811         https://bugs.webkit.org/show_bug.cgi?id=170540
2812
2813         Reviewed by Michael Catanzaro.
2814
2815         We are building libxslt and libffi that we don't really need to build from sources.
2816
2817         * gtk/jhbuild.modules:
2818
2819 2017-06-19  Frederic Wang  <fwang@igalia.com>
2820
2821         [Mac] Add an experimental feature setting for async frame scrolling
2822         https://bugs.webkit.org/show_bug.cgi?id=173359
2823
2824         Reviewed by Simon Fraser.
2825
2826         * DumpRenderTree/mac/DumpRenderTree.mm:
2827         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
2828         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
2829         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2830         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
2831
2832 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
2833
2834         Unreviewed, adding myself to contributors.json
2835
2836         * Scripts/webkitpy/common/config/contributors.json:
2837
2838 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
2839
2840         test262: Completion values for control flow do not match the spec
2841         https://bugs.webkit.org/show_bug.cgi?id=171265
2842
2843         Reviewed by Saam Barati.
2844
2845         * Scripts/run-jsc-stress-tests:
2846         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
2847
2848 2017-06-19  Zalan Bujtas  <zalan@apple.com>
2849
2850         Opening certain mails brings up a mail that grows indefinitely.
2851         https://bugs.webkit.org/show_bug.cgi?id=173562
2852         <rdar://problem/32766579>
2853
2854         Reviewed by Tim Horton.
2855
2856         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2857         (TEST):
2858
2859 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2860
2861         [iOS DnD] Support .zip archives for file uploads via drag and drop
2862         https://bugs.webkit.org/show_bug.cgi?id=173511
2863         <rdar://problem/32521025>
2864
2865         Reviewed by Tim Horton.
2866
2867         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
2868         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
2869
2870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2871         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
2872         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2873         (testZIPArchive):
2874         (TestWebKitAPI::TEST):
2875
2876 2017-06-18  Darin Adler  <darin@apple.com>
2877
2878         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
2879         https://bugs.webkit.org/show_bug.cgi?id=173526
2880
2881         Reviewed by Sam Weinig.
2882
2883         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
2884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2885
2886         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
2887         tests for assignment before destruction ones.
2888
2889         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
2890         as a function, so it can be used in WTF::Function tests.
2891
2892         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
2893         Added tests for swap and for assignment before deref.
2894
2895         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
2896         to inline everything. Also removed the unnecessary clearing of the log every time
2897         the DerivedRefLogger constructor is called.
2898         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
2899
2900         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
2901         Added tests for assignment before deref and similar for releaseNonNull.
2902
2903 2017-06-19  Sam Weinig  <sam@webkit.org>
2904
2905         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
2906         https://bugs.webkit.org/show_bug.cgi?id=173513
2907
2908         Reviewed by Alex Christensen.
2909
2910         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2911         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2912         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
2913
2914 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
2915
2916         [Win] fast/dom/assign-to-window-status.html is flaky.
2917         https://bugs.webkit.org/show_bug.cgi?id=173512
2918
2919         Reviewed by Alex Christensen.
2920
2921         We should not dump status callbacks when test is done.
2922
2923         * DumpRenderTree/win/UIDelegate.cpp:
2924         (UIDelegate::setStatusText):
2925
2926 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2927
2928         [WPE][JHBuild] Update WPEBackend-mesa
2929         https://bugs.webkit.org/show_bug.cgi?id=173433
2930
2931         Unreviewed.
2932
2933         Update WPEBackend-mesa back (like it was done originally in r218344)
2934         after fixing the issue with the DISPLAY environment variables that
2935         caused the crashes.
2936
2937         * wpe/jhbuild.modules:
2938
2939 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2940
2941         Rename unit test file after r218482
2942         https://bugs.webkit.org/show_bug.cgi?id=173483
2943
2944         Unreviewed.
2945
2946         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
2947
2948 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2949
2950         Unreviewed. Fix wrong style checker condition added in r218487.
2951
2952         * Scripts/webkitpy/style/checkers/cpp.py:
2953         (check_identifier_name_in_declaration):
2954
2955 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
2956
2957         Missing <functional> includes make builds fail with GCC 7.x
2958         https://bugs.webkit.org/show_bug.cgi?id=173544
2959
2960         Unreviewed gardening.
2961
2962         Fix compilation with GCC 7.
2963
2964         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2965         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
2966
2967 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2968
2969         [GTK] Move GTK+ API files that could be shared to glib dirs
2970         https://bugs.webkit.org/show_bug.cgi?id=173545
2971
2972         Reviewed by Žan Doberšek.
2973
2974         Update paths of GTK+ API in watchlist and style checker.
2975
2976         * Scripts/webkitpy/common/config/watchlist:
2977         * Scripts/webkitpy/style/checker.py:
2978         * Scripts/webkitpy/style/checkers/cpp.py:
2979         (check_identifier_name_in_declaration):
2980
2981 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2982
2983         Port setup_environ_for_server should not set environment variables related with the driver.
2984         https://bugs.webkit.org/show_bug.cgi?id=173483
2985
2986         Reviewed by Carlos Garcia Campos.
2987
2988         The port setup_environ_for_server() should not set environment variables
2989         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
2990         This varibles should be only set on the driver setup_environ_for_test().
2991
2992         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
2993         into the test environment even when running the tests with a driver
2994         that is not the Xorg or Xvfb one.
2995
2996         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
2997         (Port.to.setup_environ_for_server):
2998         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
2999         (Driver._setup_environ_for_driver):
3000         * Scripts/webkitpy/port/driver_unittest.py:
3001         (DriverTest.test_setup_environ_for_test):
3002         (DriverTest):
3003         (DriverTest.test_setup_environ_base_vars):
3004         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
3005         (GtkPort.setup_environ_for_server):
3006         * Scripts/webkitpy/port/wayland_unittest.py: Added.
3007         (WaylandDriverTest):
3008         (WaylandDriverTest.make_driver):
3009         (WaylandDriverTest.make_environment):
3010         (WaylandDriverTest.test_checkdriver):
3011         (WaylandDriverTest.test_environment_needed_variables):
3012         (WaylandDriverTest.test_environment_forbidden_variables):
3013         (WaylandDriverTest.test_environment_optional_variables):
3014         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
3015         (WaylandDriver.check_driver):
3016         (WaylandDriver._setup_environ_for_test):
3017         * Scripts/webkitpy/port/xorgdriver.py:
3018         (XorgDriver.check_driver):
3019         (XorgDriver._setup_environ_for_test):
3020         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
3021         (XorgDriverTest):
3022         (XorgDriverTest.make_driver):
3023         (XorgDriverTest.make_environment):
3024         (XorgDriverTest.test_checkdriver):
3025         (XorgDriverTest.test_environment_needed_variables):
3026         (XorgDriverTest.test_environment_forbidden_variables):
3027         (XorgDriverTest.test_environment_optional_variables):
3028         * Scripts/webkitpy/port/xvfbdriver.py:
3029         (XvfbDriver._setup_environ_for_test):
3030         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3031         (XvfbDriverTest.assertDriverStartSuccessful):
3032
3033
3034 2017-05-14 Frederic Wang  <fwang@igalia.com>
3035
3036         Add heuristic to avoid flattening "fullscreen" iframes
3037         https://bugs.webkit.org/show_bug.cgi?id=171914
3038
3039         Reviewed by Simon Fraser.
3040
3041         * DumpRenderTree/mac/DumpRenderTree.mm:
3042         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
3043
3044 2017-06-18  Chris Dumez  <cdumez@apple.com>
3045
3046         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
3047         https://bugs.webkit.org/show_bug.cgi?id=173522
3048         <rdar://problem/31185739>
3049
3050         Reviewed by Darin Adler.
3051
3052         Add API test for re-entering Function's assignment operators.
3053
3054         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3055         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
3056         (TestWebKitAPI::TestObject::TestObject):
3057         (TestWebKitAPI::TestObject::~TestObject):
3058         (TestWebKitAPI::TestObject::operator()):
3059         (TestWebKitAPI::TEST):
3060
3061 2017-06-16  Dan Bernstein  <mitz@apple.com>
3062
3063         [Cocoa] Some declarations have missing or incorrect availability attributes
3064         https://bugs.webkit.org/show_bug.cgi?id=173508
3065
3066         Reviewed by Tim Horton.
3067
3068         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
3069         (TestWebKitAPI::TEST): Updated for renames.
3070
3071 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3072
3073         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
3074         https://bugs.webkit.org/show_bug.cgi?id=173366
3075         <rdar://problem/32767014>
3076
3077         Reviewed by Tim Horton.
3078
3079         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
3080         change in behavior.
3081
3082         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3084         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
3085         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
3086         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
3087         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
3088         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
3089         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
3090         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
3091         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
3092         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
3093         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
3094         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
3095         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
3096         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3097         (-[MockDragDropSession initWithItems:location:window:]):
3098         (-[MockDragDropSession allowsMoveOperation]):
3099         (-[MockDragDropSession isRestrictedToDraggingApplication]):
3100         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
3101         (-[MockDragDropSession canLoadObjectsOfClass:]):
3102         (-[MockDragDropSession canLoadObjectsOfClasses:]):
3103         (-[MockDragDropSession items]):
3104         (-[MockDragDropSession setItems:]):
3105         (-[MockDragDropSession locationInView:]):
3106         (-[MockDataOperationSession initWithProviders:location:window:]):
3107         (-[MockDataOperationSession session]):
3108         (-[MockDataOperationSession isLocal]):
3109         (-[MockDataOperationSession progress]):
3110         (-[MockDataOperationSession setProgressIndicatorStyle:]):
3111         (-[MockDataOperationSession progressIndicatorStyle]):
3112         (-[MockDataOperationSession operationMask]):
3113         (-[MockDataOperationSession localDragSession]):
3114         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
3115         (-[MockDataOperationSession canCreateItemsOfClass:]):
3116         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
3117         (-[MockDataInteractionSession initWithWindow:]):
3118         (-[MockDataInteractionSession localOperationMask]):
3119         (-[MockDataInteractionSession externalOperationMask]):
3120         (-[MockDataInteractionSession session]):
3121         (-[DataInteractionSimulator _advanceProgress]):
3122
3123 2017-06-16  Alex Christensen  <achristensen@webkit.org>
3124
3125         Show punycode to user if a URL has dotless i or j followed by diacritic dot
3126         https://bugs.webkit.org/show_bug.cgi?id=173431
3127
3128         Reviewed by Darin Adler.
3129
3130         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3131         (TestWebKitAPI::TEST):
3132
3133 2017-06-16  Chris Dumez  <cdumez@apple.com>
3134
3135         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
3136         https://bugs.webkit.org/show_bug.cgi?id=173472
3137         <rdar://problem/28858817>
3138
3139         Reviewed by Brady Eidson.
3140
3141         Add API test coverage.
3142
3143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3144         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
3145         (TEST):
3146
3147 2017-06-16  Brady Eidson  <beidson@apple.com>
3148
3149         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
3150         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
3151
3152         Reviewed by Daniel Bates.
3153
3154         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
3155
3156 2017-06-16  Chris Dumez  <cdumez@apple.com>
3157
3158         DRT fails to reset page visibility between tests
3159         https://bugs.webkit.org/show_bug.cgi?id=173485
3160
3161         Reviewed by Alexey Proskuryakov.
3162
3163         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
3164         Fix this to address flakiness.
3165
3166         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
3167         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
3168         The test became flaky without the DRT change and was no longer flaky with the DRT
3169         change.
3170
3171         WebKitTestRunner already does this.
3172
3173         * DumpRenderTree/mac/DumpRenderTree.mm:
3174         (resetWebViewToConsistentStateBeforeTesting):
3175
3176 2017-06-16  Alex Christensen  <achristensen@webkit.org>
3177
3178         Implement basic authentication in MiniBrowser
3179         https://bugs.webkit.org/show_bug.cgi?id=173443
3180
3181         Reviewed by Tim Horton.
3182
3183         * MiniBrowser/mac/WK2BrowserWindowController.m:
3184         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3185
3186 2017-06-16  Jer Noble  <jer.noble@apple.com>
3187
3188         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
3189         https://bugs.webkit.org/show_bug.cgi?id=173398
3190         <rdar://problem/32592961>
3191
3192         Reviewed by Eric Carlson.
3193
3194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3195         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
3196         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3197         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3198         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
3199         (TestWebKitAPI::TEST):
3200         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
3201
3202 2017-06-16  Matt Lewis  <jlewis3@apple.com>
3203
3204         Unreviewed, rolling out r218375.
3205
3206         The API test MediaStreamTrackDetached is still timing out
3207         after the patch
3208
3209         Reverted changeset:
3210
3211         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
3212         reports no recording to WebKit clients"
3213         https://bugs.webkit.org/show_bug.cgi?id=173398
3214         http://trac.webkit.org/changeset/218375
3215
3216 2017-06-15  Jer Noble  <jer.noble@apple.com>
3217
3218         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
3219         https://bugs.webkit.org/show_bug.cgi?id=173398
3220         <rdar://problem/32592961>
3221
3222         Reviewed by Eric Carlson.
3223
3224         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3225         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
3226         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3227         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3228         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
3229         (TestWebKitAPI::TEST):
3230         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
3231
3232 2017-06-15  Matt Lewis  <jlewis3@apple.com>
3233
3234         Unreviewed, rolling out r218365.
3235
3236         The revision caused API timeouts on all builds.
3237
3238         Reverted changeset:
3239
3240         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
3241         reports no recording to WebKit clients"
3242         https://bugs.webkit.org/show_bug.cgi?id=173398
3243         http://trac.webkit.org/changeset/218365
3244
3245 2017-06-15  Jer Noble  <jer.noble@apple.com>
3246
3247         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
3248         https://bugs.webkit.org/show_bug.cgi?id=173398
3249         <rdar://problem/32592961>
3250
3251         Reviewed by Eric Carlson.
3252
3253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3254         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
3255         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3256         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3257         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
3258         (TestWebKitAPI::TEST):
3259         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
3260
3261 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3262
3263         REGRESSION(r218344): [WPE] Thousands of layout test crashes
3264         https://bugs.webkit.org/show_bug.cgi?id=173433
3265
3266         Unreviewed.
3267
3268         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
3269
3270 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3271
3272         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
3273         https://bugs.webkit.org/show_bug.cgi?id=173061
3274
3275         Reviewed by Žan Doberšek.
3276
3277         Launch dyz <https://github.com/Igalia/dyz> with the script
3278         run-minibrowser for the wpe port. It is now built as part of the
3279         WPE dependencies with JHBuild.
3280
3281         * Scripts/run-minibrowser:
3282         * Scripts/webkitdirs.pm:
3283         (launcherPath):
3284         (launcherName):
3285         * wpe/install-dependencies: Luajit is needed for building dyz.
3286         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
3287
3288 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3289
3290         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
3291         https://bugs.webkit.org/show_bug.cgi?id=173338
3292         <rdar://problem/32777720>
3293
3294         Reviewed by Tim Horton.
3295
3296         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
3297         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
3298         these remaining items on drop.
3299
3300         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3301         (TestWebKitAPI::TEST):
3302         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3303         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3304
3305         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
3306
3307         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
3308
3309 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
3310
3311         [Win] Crash in accessibility layout test.
3312         https://bugs.webkit.org/show_bug.cgi?id=173401
3313
3314         Reviewed by Brent Fulgham.
3315
3316         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
3317         member will be automatically released when the _variant_t object goes out of scope if the vt member
3318         does not equal VT_UNKNOWN | VT_BYREF.
3319         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
3320
3321         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3322         (AccessibilityUIElement::titleUIElement):
3323
3324 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3325
3326         [GTK] Add API to allow overriding popup menus
3327         https://bugs.webkit.org/show_bug.cgi?id=172905
3328
3329         Reviewed by Michael Catanzaro.
3330
3331         Add a unit test to check the new API.
3332
3333         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3334         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
3335         (OptionMenuTest::OptionMenuTest):
3336         (OptionMenuTest::~OptionMenuTest):
3337         (OptionMenuTest::destroyMenu):
3338         (OptionMenuTest::showOptionMenuCallback):
3339         (OptionMenuTest::menuCloseCallback):
3340         (OptionMenuTest::showOptionMenu):
3341         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
3342         (OptionMenuTest::close):
3343         (OptionMenuTest::activateItem):
3344         (OptionMenuTest::selectItem):
3345         (testOptionMenuSimple):
3346         (testOptionMenuGroups):
3347         (testOptionMenuActivate):
3348         (testOptionMenuSelect):
3349         (beforeAll):
3350         (afterAll):
3351
3352 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
3353
3354         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
3355         https://bugs.webkit.org/show_bug.cgi?id=173399
3356
3357         Reviewed by Per Arne Vollan.
3358
3359         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
3360         Curl port needs to do nothing because libcurl doesn't have disk cache.
3361
3362         * DumpRenderTree/win/DumpRenderTree.cpp:
3363         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
3364         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
3365
3366 2017-06-14  Tomas Popela  <tpopela@redhat.com>
3367
3368         [GTK] integer expression expected if running Tools/gtk/install-dependencies
3369         https://bugs.webkit.org/show_bug.cgi?id=173356
3370
3371         Reviewed by Michael Catanzaro.
3372
3373         Use the correct operator to compare the strings.
3374
3375         * gtk/install-dependencies:
3376
3377 2017-06-14  Commit Queue  <commit-queue@webkit.org>
3378
3379         Unreviewed, rolling out r218285.
3380         https://bugs.webkit.org/show_bug.cgi?id=173391
3381
3382         API test fails on iOS (Requested by alexchristensen on
3383         #webkit).
3384
3385         Reverted changeset:
3386
3387         "Add SPI for immediate injection of user scripts"
3388         https://bugs.webkit.org/show_bug.cgi?id=173342
3389         http://trac.webkit.org/changeset/218285
3390
3391 2017-06-14  Chris Dumez  <cdumez@apple.com>
3392
3393         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
3394         https://bugs.webkit.org/show_bug.cgi?id=173384
3395         <rdar://problem/32723779>
3396
3397         Reviewed by Dan Bernstein.
3398
3399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3400         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
3401         Add API test coverage.
3402
3403         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3404         (TestWebKitAPI::Util::sleep):
3405         Update implementation of Util::sleep() so that we actually run the run loop.
3406         Otherwise, we don't process events while sleeping.
3407
3408 2017-06-14  Alex Christensen  <achristensen@webkit.org>
3409
3410         Add SPI for immediate injection of user scripts
3411         https://bugs.webkit.org/show_bug.cgi?id=173342
3412         <rdar://problem/29202285>
3413
3414         Reviewed by Brady Eidson.
3415
3416         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3417         (waitForMessage):
3418         (TEST):
3419
3420 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
3421
3422         Add WPE to the flakiness dashboard
3423         https://bugs.webkit.org/show_bug.cgi?id=173365
3424
3425         Reviewed by Carlos Alberto Lopez Perez.
3426
3427         * TestResultServer/static-dashboards/builders.jsonp:
3428         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3429         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3430         (resetGlobals):
3431         * TestResultServer/static-dashboards/loader_unittests.js:
3432
3433 2017-06-14  Brady Eidson  <beidson@apple.com>
3434
3435         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
3436         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
3437
3438         Reviewed by Alex Christensen.
3439
3440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3441         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
3442         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
3443         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
3444         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
3445         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
3446         (TEST):
3447
3448 2017-06-14  Tim Horton  <timothy_horton@apple.com>
3449
3450         WKContentViewEditingActions API test always fails
3451         https://bugs.webkit.org/show_bug.cgi?id=173374
3452
3453         Reviewed by Wenson Hsieh.
3454
3455         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
3456         (TEST):
3457         selectAll isn't working, because canPerformAction for selectAll returns NO
3458         if selectionIsNone (which is true in the non-contenteditable case).
3459         Instead, make use of r218180's test page, which knows how to select itself.
3460         Also, reset the pasteboard at the beginning of the test to reduce confusion
3461         (I landed the test broken because my simulator had the correct text
3462         stuck in its pasteboard).
3463
3464 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
3465
3466         Configure screen scale for running layout tests on plus devices
3467         https://bugs.webkit.org/show_bug.cgi?id=173319
3468
3469         Reviewed by Tim Horton.
3470
3471         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
3472         * DumpRenderTree/mac/DumpRenderTree.mm:
3473         (dumpRenderTree): Set screen scale to 2.0.
3474         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
3475         add _setScale for UIScreen.
3476         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
3477         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
3478         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
3479         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
3480         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
3481         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
3482         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
3483         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
3484         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
3485         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
3486
3487 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
3488
3489         Add iOS 11 support to the bot watcher's dashboard
3490         https://bugs.webkit.org/show_bug.cgi?id=173369
3491
3492         Reviewed by Lucas Forschler.
3493
3494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
3495         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
3496         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
3497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
3498         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3499         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3500
3501 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3502
3503         [GTK][WPE] Raise the timeout values for layout tests
3504         https://bugs.webkit.org/show_bug.cgi?id=173368
3505
3506         Reviewed by Carlos Garcia Campos.
3507
3508         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
3509         When running under valgrind a 10x multiplier is applied.
3510
3511         * Scripts/webkitpy/port/gtk.py:
3512         (GtkPort.default_timeout_ms):
3513         * Scripts/webkitpy/port/gtk_unittest.py:
3514         (GtkPortTest.test_default_timeout_ms):
3515         * Scripts/webkitpy/port/wpe.py:
3516         (WPEPort.default_timeout_ms):
3517         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
3518         (WPEPortTest):
3519         (WPEPortTest.make_port):
3520         (WPEPortTest.test_default_timeout_ms):
3521         (WPEPortTest.test_get_crash_log):
3522
3523 2017-06-14  Alex Christensen  <achristensen@webkit.org>
3524
3525         Test persistent WKHTTPCookieStorages on iOS.
3526         https://bugs.webkit.org/show_bug.cgi?id=173284
3527
3528         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3529         (TEST):
3530         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
3531
3532 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
3533
3534         [Win] DRT should not use disk cache.
3535         https://bugs.webkit.org/show_bug.cgi?id=173361
3536
3537         Reviewed by Darin Adler.
3538
3539         Like on macOS/iOS, DRT on Windows should only use memory cache.
3540
3541         * DumpRenderTree/win/DumpRenderTree.cpp:
3542         (setDefaultsToConsistentValuesForTesting):
3543         (prepareConsistentTestingEnvironment):
3544
3545 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
3546
3547         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
3548         https://bugs.webkit.org/show_bug.cgi?id=171668
3549
3550         Reviewed by Jer Noble.
3551
3552         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
3553         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
3554         Infinity when the double value passed as argument is greater than 2^64.
3555
3556         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
3557         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
3558         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
3559         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
3560         method. No behavior change for rational MediaTime.
3561
3562         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
3563         (TestWebKitAPI::TEST):
3564
3565 2017-06-13  Alex Christensen  <achristensen@webkit.org>
3566
3567         Test persistent WKHTTPCookieStorages on iOS
3568         https://bugs.webkit.org/show_bug.cgi?id=173284
3569         <rdar://problem/32260156>
3570
3571         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3572         (TEST):
3573
3574 2017-06-13  Matt Rajca  <mrajca@apple.com>
3575
3576         WebsitePolicies: let clients select specific autoplay quirks
3577         https://bugs.webkit.org/show_bug.cgi?id=173343
3578
3579         Reviewed by Alex Christensen.
3580
3581         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3582         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3583         (TEST): Updated tests.
3584
3585 2017-06-13  Daniel Bates  <dabates@apple.com>
3586
3587         Implement W3C Secure Contexts Draft Specification
3588         https://bugs.webkit.org/show_bug.cgi?id=158121
3589         <rdar://problem/26012994>
3590
3591         Reviewed by Brent Fulgham.
3592
3593         Part 4
3594
3595         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
3596         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
3597         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3598
3599         * DumpRenderTree/TestOptions.h:
3600         * DumpRenderTree/TestOptions.mm:
3601         (TestOptions::TestOptions):
3602         * DumpRenderTree/mac/DumpRenderTree.mm:
3603         (setWebPreferencesForTestOptions):
3604         * DumpRenderTree/win/DumpRenderTree.cpp:
3605         (enableExperimentalFeatures):
3606         * WebKitTestRunner/TestController.cpp:
3607         (WTR::TestController::resetPreferencesToConsistentValues):
3608         (WTR::updateTestOptionsFromTestHeader):
3609         * WebKitTestRunner/TestOptions.h:
3610         (WTR::TestOptions::hasSameInitializationOptions):
3611
3612 2017-06-13  Alex Christensen  <achristensen@webkit.org>
3613
3614         Test persistent WKHTTPCookieStorages on iOS
3615         https://bugs.webkit.org/show_bug.cgi?id=173284
3616         <rdar://problem/32260156>
3617
3618         Reviewed by Alexey Proskuryakov.
3619
3620         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3621         (TEST):
3622
3623 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3624
3625         [GTK] Blob download doesn't work
3626         https://bugs.webkit.org/show_bug.cgi?id=172442
3627
3628         Reviewed by Carlos Alberto Lopez Perez.
3629
3630         Add a unit test to check blob downloads.
3631
3632         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3633         (testBlobDownload):
3634         (beforeAll):
3635
3636 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3637
3638         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
3639         https://bugs.webkit.org/show_bug.cgi?id=173316
3640
3641         Reviewed by Alex Christensen.
3642
3643         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
3644
3645         * gtk/manifest.txt.in:
3646
3647 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3648
3649         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
3650         https://bugs.webkit.org/show_bug.cgi?id=173315
3651
3652         Reviewed by Darin Adler.
3653
3654         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
3655         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
3656         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
3657         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
3658         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
3659         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
3660         WKGeolocationManagerRef is not destroyed.
3661
3662         * WebKitTestRunner/GeolocationProviderMock.cpp:
3663         (WTR::GeolocationProviderMock::GeolocationProviderMock):
3664         * WebKitTestRunner/GeolocationProviderMock.h:
3665
3666 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3667
3668         Unable to paste text that was copied from a page into the universal search field
3669         https://bugs.webkit.org/show_bug.cgi?id=173293
3670         <rdar://problem/32440918>
3671
3672         Reviewed by Ryosuke Niwa.
3673
3674         Adds 2 new unit tests for copying plain and rich selected web content.
3675         See WebCore and WebKit ChangeLogs for more detail.
3676
3677         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3678         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
3679         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
3680         (TestWebKitAPI::dataForPasteboardType):
3681         (TestWebKitAPI::setUpWebViewForPasteboardTests):
3682         (TestWebKitAPI::TEST):
3683
3684 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
3685
3686         AX: [ATK] Implement missing AtkRelation types
3687         https://bugs.webkit.org/show_bug.cgi?id=155494
3688
3689         Reviewed by Darin Adler.
3690
3691         Add additional methods to test ARIA properties which are exposed via
3692         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
3693
3694         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3695         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
3696         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
3697         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
3698         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
3699         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
3700         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtInd