2011-02-01 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / Tools / ChangeLog
1 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         new-run-webkit-tests: add first stub of test_runner2. This
6         will add support for the 'inline', 'threads', and 'processes'
7         flags to --worker-model, but for now the implementatios just
8         fall back on the old ones.
9
10         https://bugs.webkit.org/show_bug.cgi?id=53157
11
12         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
13         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
14
15 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
16
17         Reviewed by James Robinson.
18
19         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
20         https://bugs.webkit.org/show_bug.cgi?id=53522
21
22         * Scripts/run-chromium-webkit-unit-tests:
23
24 2011-02-01  Adam Barth  <abarth@webkit.org>
25
26         Reviewed by Mihai Parparita.
27
28         Using Control-C to cancel webkit-patch or other python tools causes
29         unpleasant traceback console spew
30         https://bugs.webkit.org/show_bug.cgi?id=53462
31
32         Catch the exception and don't print the stack trace.
33
34         * Scripts/webkit-patch:
35
36 2011-02-01  Scott Cameron  <sccameron@rim.com>
37
38         Reviewed by Daniel Bates.
39
40         Use Windows format for MinGW HTTPD path.
41         https://bugs.webkit.org/show_bug.cgi?id=53503
42
43         * Scripts/webkitperl/httpd.pm:
44           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
45             so that we don't have to escape the space characters in the path. Also,
46             changed path to Windows-style path and removed FIXME comment.
47
48 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
49
50         Reviewed by Andreas Kling.
51
52         [Qt][WK2] Add a way to use shared process model in MiniBrowser
53         https://bugs.webkit.org/show_bug.cgi?id=53090
54
55         * MiniBrowser/qt/BrowserView.cpp:
56         (BrowserView::BrowserView): Removed the m_context member.
57         From now the context is guaranteed to be non-null and we
58         don't need to store that in the object.
59         * MiniBrowser/qt/BrowserView.h:
60         * MiniBrowser/qt/BrowserWindow.cpp:
61         Added static bool to determine that new windows need to be
62         created with their own context or not. Use the same context
63         and web process by default to be inilne with the other ports.
64         (BrowserWindow::BrowserWindow):
65         (BrowserWindow::newWindow):
66         * MiniBrowser/qt/BrowserWindow.h:
67         * MiniBrowser/qt/main.cpp:
68         (main): Added command line switch to be able to use the
69         non-shared process model. Simplify the handling of the command line
70         switches a little bit.
71
72 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
73
74         Reviewed by Andreas Kling.
75
76         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
77         https://bugs.webkit.org/show_bug.cgi?id=53491
78
79         * MiniBrowser/qt/BrowserWindow.cpp:
80         (BrowserWindow::BrowserWindow):
81         (BrowserWindow::toggleFullScreenMode):
82         * MiniBrowser/qt/BrowserWindow.h:
83
84 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
85
86         Reviewed by Andreas Kling.
87
88         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
89         https://bugs.webkit.org/show_bug.cgi?id=53489
90
91         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
92         to Settings menu.
93
94         * MiniBrowser/qt/BrowserWindow.cpp:
95         (BrowserWindow::BrowserWindow):
96         (BrowserWindow::toggleFrameFlattening):
97         (BrowserWindow::toggleDisableJavaScript):
98         (BrowserWindow::toggleAutoLoadImages):
99         * MiniBrowser/qt/BrowserWindow.h:
100
101 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
102
103         Reviewed by Tony Chang.
104
105         [Chromium] Switch chromium-mac to use ChromiumDriver
106         https://bugs.webkit.org/show_bug.cgi?id=53461
107         
108         For the sake of consistency with the other Chromium platforms (and so
109         that chromium-mac picks up special flags like --enable-hardware-gpu),
110         switch chromium-mac from the WebKitDriver to ChromiumDriver.
111
112         * Scripts/webkitpy/layout_tests/port/chromium.py:
113
114 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
115
116         Reviewed by Mihai Parparita.
117
118         The current modifier parsing code in test_expectations is
119         fragile and hard-coded, so it's not easy to understand the logic
120         or easily add new types of modifiers (like GPU vs. CPU testing
121         for graphics tests, or 32-bit vs. 64-bit differences).
122
123         This is the first of two patches that will add in more generic
124         support and then eliminate the GPU-specific test expectations
125         files for Chromium.
126
127         This patch adds two standalone objects for handling modifiers. The
128         rules for interpreting modifiers, precedence, and conflicts are
129         given in the docstring to the ModifierMatcher class, which
130         returns ModifierMatchResult objects.
131         
132         This patch also adds routines to the Port interface and a
133         default set of values in the base object, in order to obtain the
134         values needed on a given test run. These values are then passed
135         to the expectation parser. This also allows us to clean up the
136         logic used to lint all of the different configurations in a
137         single test_expectations.txt file.
138
139         The next patch will merge in the separate GPU expectations file.
140
141         https://bugs.webkit.org/show_bug.cgi?id=51222
142
143         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
144         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
145         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
146         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
147         * Scripts/webkitpy/layout_tests/port/base.py:
148         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
149         * Scripts/webkitpy/layout_tests/port/chromium.py:
150         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
151         * Scripts/webkitpy/layout_tests/port/test.py:
152         * Scripts/webkitpy/layout_tests/port/webkit.py:
153         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
154         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
155         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
156         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
157         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
158
159 2011-01-31  Scott Cameron  <sccameron@rim.com>
160
161         Reviewed by Daniel Bates.
162
163         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
164         https://bugs.webkit.org/show_bug.cgi?id=50036
165
166         This will add an Apache2.2 configuration file and modifies scripts to allow
167         running an httpd server in an MSYS environment.
168
169         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
170         in order to allow for simple installation/execution.  Simply install the latest
171         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
172         be able to execute run-webkit-httpd.
173         
174
175         * Scripts/run-webkit-httpd:
176         * Scripts/webkitperl/httpd.pm:
177
178 2011-01-31  Tony Chang  <tony@chromium.org>
179
180         Reviewed by Eric Seidel.
181
182         mac DRT should report RTL scroll offset relative to top right corner
183         https://bugs.webkit.org/show_bug.cgi?id=53324
184
185         * DumpRenderTree/mac/DumpRenderTree.mm:
186         (dumpFrameScrollPosition):
187
188 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
189
190         Reviewed by Andreas Kling.
191
192         [Qt] Add Take Screen Shot action to MiniBrowser
193         https://bugs.webkit.org/show_bug.cgi?id=53422
194
195         Add Take Screen Shot action to MiniBrowser's view menu.
196
197         * MiniBrowser/qt/BrowserWindow.cpp:
198         (BrowserWindow::BrowserWindow):
199         (BrowserWindow::screenshot):
200         * MiniBrowser/qt/BrowserWindow.h:
201
202 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
203
204         Reviewed by Xan Lopez.
205
206         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
207         https://bugs.webkit.org/show_bug.cgi?id=53379
208
209         Remove left over #ifdef's. I thought all of the conditional code
210         had been freed from the condition, but I forgot to check DRT.
211
212         * DumpRenderTree/gtk/DumpRenderTree.cpp:
213         (resetDefaultsToConsistentValues):
214         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
215         (LayoutTestController::setAlwaysAcceptCookies):
216
217 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
218
219         Unreviewed, build fix.
220
221         Fix regression introduced in r77093 - path.rsplit() doesn't
222         take keyword arguments.
223
224         https://bugs.webkit.org/show_bug.cgi?id=53326
225
226         * Scripts/webkitpy/common/system/filesystem_mock.py:
227
228 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
229
230         Reviewed by Mihai Parparita.
231
232         Add more unit tests for rebaseline-chromium-webkit-tests. This
233         change involves restructuring a bunch of r-c-w-t code to make it
234         more testable as well. We also add wrapper classes for handling
235         testing zip files and fetching URLs.
236
237         https://bugs.webkit.org/show_bug.cgi?id=53040
238
239         * Scripts/webkitpy/common/system/urlfetcher.py:
240         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
241         * Scripts/webkitpy/common/system/zipfileset_mock.py:
242         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
243         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
244         * Scripts/webkitpy/tool/mocktool.py:
245
246 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
247
248         Reviewed by Eric Seidel.
249
250         Clean up of the filesystem-related modules used in webkitpy.
251         I've added relpath() to the filesystem interface, modified
252         ospath.relpath() so that it could work with the filesystem
253         interface, and modified the fileset* routines to use the
254         filesystem interface consistently.
255
256         This patch also adds a close() routine to the fileset routines
257         to indicate that the caller is done with the fileset. This
258         allows zipfileset to clean up after itself when it creates
259         tempfiles to store downloads.
260
261         https://bugs.webkit.org/show_bug.cgi?id=53326
262
263         * Scripts/webkitpy/common/system/directoryfileset.py:
264         * Scripts/webkitpy/common/system/fileset.py:
265         * Scripts/webkitpy/common/system/filesystem.py:
266         * Scripts/webkitpy/common/system/filesystem_mock.py:
267         * Scripts/webkitpy/common/system/filesystem_unittest.py:
268         * Scripts/webkitpy/common/system/ospath.py:
269         * Scripts/webkitpy/common/system/zipfileset.py:
270         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
271
272 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
273
274         Reviewed by Csaba Osztrogonác.
275
276         [Qt][WK2]REGRESSION (r76991): Fix build errors
277         https://bugs.webkit.org/show_bug.cgi?id=53400
278
279         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
280         and remove WebKit2Prefix.h from the build.
281         * MiniBrowser/qt/MiniBrowser.pro:
282
283 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
284
285         Unreviewed.
286
287         [Qt][WK2] Buildfix.
288
289         * MiniBrowser/qt/MiniBrowser.pro:
290
291 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
292
293         Reviewed by Adam Roben.
294         
295         define NOMINMAX when building ImageDiff, as we do elsewhere.
296
297         Add various clampToInt() methods to MathExtras.h
298         https://bugs.webkit.org/show_bug.cgi?id=52910
299
300         * DumpRenderTree/win/ImageDiffCommon.vsprops:
301
302 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
303
304         Reviewed by Darin Adler.
305
306         WebKitTestRunner needs layoutTestController.setPOSIXLocale
307         https://bugs.webkit.org/show_bug.cgi?id=42682
308
309         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
310         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
311         (WTR::InjectedBundle::resetLocalSettings):
312         (WTR::InjectedBundle::didReceiveMessage):
313         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
314         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
315         (WTR::LayoutTestController::setPOSIXLocale):
316         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
317
318 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
319  
320          Reviewed by Mihai Parparita.
321  
322          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
323  
324          This patch re-enables this test and changes it to
325          handle all of the mac platform versions, not just the one
326          it is running on.
327  
328          https://bugs.webkit.org/show_bug.cgi?id=53356
329  
330          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
331  
332 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
333
334         Unreviewed, build fix.
335
336         Take two. The fix in 77023 didn't work, because we were
337         still calling path.abspath_to_uri, which calls _cygpath under
338         the covers, and it appears the cygpath on the bots does
339         something different than it does on my machine. This patch
340         removes the calls to path.abspath_to_uri, so it should be safe.
341         If it doesn't work, I'll roll it out along with r76982 and 77023.
342
343         https://bugs.webkit.org/show_bug.cgi?id=53126
344
345         * Scripts/webkitpy/layout_tests/port/test.py:
346
347 2011-01-28  David Kilzer  <ddkilzer@apple.com>
348
349         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
350         <http://webkit.org/b/53353>
351
352         Reviewed by Mark Rowe.
353
354         * Scripts/webkitdirs.pm:
355         (checkRequiredSystemConfig): Check the Xcode marketing version
356         in addition to the DevCoreTools build version before complaining
357         about an old version of Xcode.  Also make the Mac OS X version
358         check use Perl's built-in version string comparitor.
359
360 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
361
362         Unreviewed, build fix.
363
364         Work around breakage on Win 7 Release bot caused by r76982
365         and the fact that windows ports use "file:////" instead of
366         "file:///". Ideally the test code should be isolated from
367         this, but it isn't yet. Will fix properly in a bit.
368
369         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
370
371 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
372
373         Reviewed by Tony Chang.
374
375         new-run-webkit-tests: change worker model values to
376         "old-inline", "old-threads" in preparation for test_runner2 /
377         multiprocessing changes.
378
379         https://bugs.webkit.org/show_bug.cgi?id=53156
380
381         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
382         * Scripts/webkitpy/layout_tests/port/base.py:
383         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
384         * Scripts/webkitpy/layout_tests/port/mac.py:
385         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
386
387 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
388
389         Reviewed by Tony Chang.
390
391         committers.py - add an IRC nickname for dpranke
392         https://bugs.webkit.org/show_bug.cgi?id=53335
393
394         * Scripts/webkitpy/common/config/committers.py:
395
396 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
397
398         Reviewed by Tony Chang.
399
400         new-run-webkit-tests: add a "mock DRT" port implementation
401         and a separate class that emulates what we expect the
402         DumpRenderTree behavior to be.
403
404         This will eventually replace port/dryrun.py and allow us to get
405         better test coverage of the new-run-webkit-tests code as well as
406         a reference for what new-run-webkit-tests expects from DRT.
407
408         This is the first attempt at this, and it is pretty bare-boned. It
409         really only has been tested on the 'mac' port (and a little on
410         the 'chromium-mac' port.
411
412         https://bugs.webkit.org/show_bug.cgi?id=53126
413
414         * Scripts/webkitpy/common/system/filesystem_mock.py:
415         * Scripts/webkitpy/layout_tests/port/dryrun.py:
416         * Scripts/webkitpy/layout_tests/port/factory.py:
417         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
418         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
419         * Scripts/webkitpy/layout_tests/port/test.py:
420
421 2011-01-28  Pratik Solanki  <psolanki@apple.com>
422
423         Unreviewed. Removing .swp file checked in by mistake.
424
425         * Scripts/.webkitdirs.pm.swp: Removed.
426
427 2011-01-28  Pratik Solanki  <psolanki@apple.com>
428
429         Reviewed by David Kilzer.
430
431         Space not necessary for undefined feature
432         https://bugs.webkit.org/show_bug.cgi?id=53317
433
434         * Scripts/build-webkit:
435
436 2011-01-28  Chang Shu  <chang.shu@nokia.com>
437
438         Reviewed by Andreas Kling.
439
440         Reset NetworkAccessManager to clean up credentials from previous tests.
441         This change causes no performance overhead either.
442         https://bugs.webkit.org/show_bug.cgi?id=36688
443
444         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
445         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
446         (WebCore::DumpRenderTree::open):
447         * DumpRenderTree/qt/DumpRenderTreeQt.h:
448
449 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
450
451         Reviewed by Andreas Kling.
452
453         [Qt] Add Zoom Text Only action to MiniBrowser
454         https://bugs.webkit.org/show_bug.cgi?id=53297
455
456         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
457
458         * MiniBrowser/qt/BrowserWindow.cpp:
459         (BrowserWindow::BrowserWindow):
460         (BrowserWindow::zoomIn):
461         (BrowserWindow::zoomOut):
462         (BrowserWindow::resetZoom):
463         (BrowserWindow::toggleZoomTextOnly):
464         (BrowserWindow::applyZoom):
465         * MiniBrowser/qt/BrowserWindow.h:
466
467 2011-01-28  Adam Barth  <abarth@webkit.org>
468
469         Reviewed by Eric Seidel.
470
471         Add webkit-patch roll-chromium-deps
472         https://bugs.webkit.org/show_bug.cgi?id=53288
473
474         This command updates the Source/WebKit/chromium/DEPS file with the
475         last-known good revision of Chromium (or a revision specified on the
476         command line).  I'd eventually like to turn this into a SheriffBot
477         command, but this is the first step.
478
479         This patch somewhat sprawled because I needed to move a bunch of code
480         out of ChangeLog that should never have been there in the first place.
481         Also, I had to fix a bug in MockUser in order to test the new command.
482
483         * Scripts/webkitpy/common/checkout/api.py:
484         * Scripts/webkitpy/common/checkout/changelog.py:
485         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
486         * Scripts/webkitpy/common/checkout/deps.py: Added.
487         * Scripts/webkitpy/common/config/urls.py:
488         * Scripts/webkitpy/tool/commands/__init__.py:
489         * Scripts/webkitpy/tool/commands/download_unittest.py:
490         * Scripts/webkitpy/tool/commands/roll.py: Added.
491         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
492         * Scripts/webkitpy/tool/commands/upload_unittest.py:
493         * Scripts/webkitpy/tool/mocktool.py:
494         * Scripts/webkitpy/tool/steps/__init__.py:
495         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
496         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
497         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
498         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
499         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
500         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
501
502 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
503
504         Reviewed by Laszlo Gombos.
505
506         Get rid of prefix header dependency for WebKit2 build system
507         https://bugs.webkit.org/show_bug.cgi?id=50174
508
509         Change the style checker so that it enforces config.h include for
510         WebKit2.
511
512         * Scripts/webkitpy/style/checker.py:
513
514 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
515
516         Reviewed by Darin Adler.
517
518         execCommand("Paste") doesn't work in WebKitTestRunner
519         https://bugs.webkit.org/show_bug.cgi?id=52785
520
521         Enable both of the settings needed to allow paste.
522         
523         * WebKitTestRunner/TestController.cpp:
524         (WTR::TestController::resetStateToConsistentValues):
525
526 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
527
528         Reviewed by Andreas Kling.
529
530         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
531         https://bugs.webkit.org/show_bug.cgi?id=48440
532
533         Preserve user input when toggling use of QGraphicsView
534
535         * QtTestBrowser/launcherwindow.cpp:
536         (LauncherWindow::initializeView):
537         (LauncherWindow::loadFinished):
538         * QtTestBrowser/launcherwindow.h:
539         * QtTestBrowser/mainwindow.cpp:
540         (MainWindow::addressUrl):
541         * QtTestBrowser/mainwindow.h:
542
543 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
544
545         Reviewed by Mihai Parparita.
546
547         new-run-webkit-tests: turn off pixel tests correctly by default
548         for webkit-based ports. r70013 (bug 47510) used
549         port.set_option_default() to attempt to set default values, but
550         that didn't work correctly. I have removed set_option_default
551         for now since it was only being used in two places and in three
552         useless unit tests. There is a separate bug open to fix the
553         option parsing (48095), so this workaround is fine for now.
554
555         https://bugs.webkit.org/show_bug.cgi?id=53217
556
557         * Scripts/webkitpy/layout_tests/port/webkit.py:
558         * Scripts/webkitpy/layout_tests/port/base.py:
559         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
560
561 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
562
563         Rubber-stamped by Ariya Hidayat.
564
565         Trivial crash fix in WTR.
566
567         * WebKitTestRunner/TestController.cpp:
568         (WTR::TestController::initialize): Increase the size
569         of the vector by one to be able to store the null character.
570
571 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
572
573         Reviewed by Csaba Osztrogonác.
574
575         [Qt][WK2] WTR should be initialized in the same way as DRT
576         https://bugs.webkit.org/show_bug.cgi?id=53240
577
578         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
579         (WTR::activateFonts): Added missing initialization steps.
580
581 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
582
583         Unreviewed. 
584
585         Adding myself to committers.py.
586
587         * Scripts/webkitpy/common/config/committers.py:
588
589 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
590
591         Reviewed by Csaba Osztrogonác.
592
593         [Qt] [Symbian] Move project files into Source
594         https://bugs.webkit.org/show_bug.cgi?id=52891
595
596         Fix the Symbian build after the project files
597         are moved to Source directory. On Symbian qmake
598         needs to run in the same directory where the main
599         pro files (WebKit.pro, Tools.pro) are located.
600
601         * Scripts/webkitdirs.pm: Change to the directory where the pro file
602         is located before running qmake for Symbian. Qmake on Symbian
603         does not properly honor the "-o" option, work it around by setting
604         the name of the Makefile to bld.inf.
605
606 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
607
608         Reviewed by Andreas Kling.
609
610         [Qt] Add simple zooming features to MiniBrowser
611         https://bugs.webkit.org/show_bug.cgi?id=53231
612
613         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
614
615         * MiniBrowser/qt/BrowserWindow.cpp:
616         (BrowserWindow::BrowserWindow):
617         (BrowserWindow::zoomIn):
618         (BrowserWindow::zoomOut):
619         (BrowserWindow::resetZoom):
620         (BrowserWindow::updateUserAgentList):
621         (BrowserWindow::applyZoom):
622         * MiniBrowser/qt/BrowserWindow.h:
623
624 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
625
626         Reviewed by Dan Bernstein.
627
628         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
629         https://bugs.webkit.org/show_bug.cgi?id=42319
630         
631         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
632
633         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
634         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
635         (WTR::LayoutTestController::showWebInspector):
636         (WTR::LayoutTestController::closeWebInspector):
637         (WTR::LayoutTestController::evaluateInWebInspector):
638         (WTR::LayoutTestController::setTimelineProfilingEnabled):
639         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
640         * WebKitTestRunner/TestInvocation.cpp:
641         (WTR::shouldOpenWebInspector):
642         (WTR::TestInvocation::invoke):
643         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
644
645 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
646
647         Reviewed by Xan Lopez.
648
649         [GTK] Pixel dumps do not include scrollbars in output images
650         https://bugs.webkit.org/show_bug.cgi?id=53216
651
652         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
653         that have scrollbars.
654
655         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
656         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
657         instead of the web view itself.
658
659 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
660
661         Reviewed by Mihai Parparita.
662
663         Fix regression introduced in r76322 ... new-run-webkit-tests
664         was attempting to save the image diff output as a UTF-8-encoded
665         file.
666
667         https://bugs.webkit.org/show_bug.cgi?id=53210
668
669         * Scripts/webkitpy/layout_tests/port/webkit.py:
670
671 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
672
673         Unreviewed, rolling out r76709.
674         http://trac.webkit.org/changeset/76709
675         https://bugs.webkit.org/show_bug.cgi?id=53194
676
677         "broke python tests on non-snowleopard platforms" (Requested
678         by dpranke on #webkit).
679
680         * Scripts/webkitpy/layout_tests/port/factory.py:
681         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
682         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
683
684 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
685
686         Reviewed by Tony Chang.
687
688         new-run-webkit-tests: add a "mock DRT" port implementation
689         and a separate class that emulates what we expect the
690         DumpRenderTree behavior to be.
691
692         This will eventually replace port/dryrun.py and allow us to get
693         better test coverage of the new-run-webkit-tests code as well as
694         a reference for what new-run-webkit-tests expects from DRT.
695
696         This is the first attempt at this, and it is pretty bare-boned. It
697         really only has been tested on the 'mac' port (and a little on
698         the 'chromium-mac' port.
699
700         https://bugs.webkit.org/show_bug.cgi?id=53126
701
702         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
703         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
704         * Scripts/webkitpy/layout_tests/port/factory.py:
705
706 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
707
708         Reviewed by Tony Chang.
709
710         Add '--no-timeout' option to Chromium DRT to ease debugging.
711         https://bugs.webkit.org/show_bug.cgi?id=52873
712
713         * DumpRenderTree/chromium/DumpRenderTree.cpp:
714         (main):
715
716 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
717
718         Reviewed by Andreas Kling.
719
720         [Qt] Fix qt_minimal build
721         https://bugs.webkit.org/show_bug.cgi?id=53172
722
723         * QtTestBrowser/locationedit.h:
724
725 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
726
727         Reviewed by Antonio Gomes.
728
729         QtTestBrowser should have a UI Setting to disable plugins
730         https://bugs.webkit.org/show_bug.cgi?id=52408
731         
732         Added a new action item named "Disable Plugins"
733         under the "Settings" menu. 
734
735         * QtTestBrowser/launcherwindow.cpp:
736         (LauncherWindow::createChrome):
737         (LauncherWindow::togglePlugins):
738         * QtTestBrowser/launcherwindow.h:
739
740 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
741
742         Reviewed by Adam Barth.
743
744         Move main CMakeLists.txt into Source directory
745         https://bugs.webkit.org/show_bug.cgi?id=52888
746
747         * Scripts/webkitdirs.pm:
748
749 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
750
751         Reviewed by Eric Seidel.
752
753         Improve label text in submit-to-ews
754         https://bugs.webkit.org/show_bug.cgi?id=53130
755
756         * QueueStatusServer/templates/submittoews.html:
757
758 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
759
760         Reviewed by Antonio Gomes.
761
762         QtTestBrowser should have a UI Settings to prevent loading images
763         https://bugs.webkit.org/show_bug.cgi?id=52409
764         
765         Added a new action item named "DisableAutoLoadImages"
766         under the "Settings" menu 
767
768         * QtTestBrowser/launcherwindow.cpp:
769         (LauncherWindow::createChrome):
770         (LauncherWindow::toggleAutoLoadImages):
771         * QtTestBrowser/launcherwindow.h:
772
773 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
774
775         Reviewed by Tony Chang.
776
777         Minor bug fixes and cleanup for filesystem wrappers, port/* test
778         classes, test_expectations.py. This change adds "test-win" and
779         "test-mac" variants to the test port so that we can better test
780         rebaselining, and adds a MockUser() object for reuse in testing.
781
782         https://bugs.webkit.org/show_bug.cgi?id=53036
783
784         * Scripts/webkitpy/common/system/filesystem.py:
785         * Scripts/webkitpy/common/system/filesystem_mock.py:
786         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
787         * Scripts/webkitpy/layout_tests/port/factory.py:
788         * Scripts/webkitpy/layout_tests/port/base.py:
789         * Scripts/webkitpy/layout_tests/port/test.py:
790         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
791         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
792         * Scripts/webkitpy/tool/mocktool.py:
793
794 2011-01-25  Tony Chang  <tony@chromium.org>
795
796         Reviewed by Dimitri Glazkov.
797
798         [chromium] remove unused layoutTestController callback
799         https://bugs.webkit.org/show_bug.cgi?id=53103
800
801         This method is used by a test_shell_test, but not needed by DRT.
802
803         * DumpRenderTree/chromium/LayoutTestController.cpp:
804         (LayoutTestController::LayoutTestController):
805         * DumpRenderTree/chromium/LayoutTestController.h:
806
807 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
808
809         Reviewed by Andreas Kling.
810
811         [GTK] Remove 64 bits release bot from the buildbot master
812         https://bugs.webkit.org/show_bug.cgi?id=52899
813
814         Removes the 64 bits release slave from the buildbot configuration,
815         so that we can use it as an EWS.
816
817         * BuildSlaveSupport/build.webkit.org-config/config.json:
818
819 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
820
821         Reviewed by Dan Bernstein.
822
823         Implement database quota callback to fix storage tests on WebKit2 bot
824         https://bugs.webkit.org/show_bug.cgi?id=53064
825
826         * WebKitTestRunner/TestController.cpp:
827         (WTR::exceededDatabaseQuota):
828         (WTR::TestController::createOtherPage):
829         (WTR::TestController::initialize):
830
831 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
832
833         Reviewed by Anders Carlsson.
834
835         Use designated temp directory for the database for WebKit2
836         https://bugs.webkit.org/show_bug.cgi?id=53052
837         
838         Adopt the new WK2 API for this.
839
840         * WebKitTestRunner/TestController.cpp:
841         (WTR::TestController::libraryPathForTesting):
842         (WTR::TestController::initialize):
843         * WebKitTestRunner/TestController.h:
844         * WebKitTestRunner/mac/TestControllerMac.mm:
845         (WTR::TestController::platformLibraryPathForTesting):
846         * WebKitTestRunner/qt/TestControllerQt.cpp:
847         (WTR::TestController::platformLibraryPathForTesting):
848         * WebKitTestRunner/win/TestControllerWin.cpp:
849         (WTR::TestController::platformLibraryPathForTesting):
850
851 2011-01-24  Lucas Forschler  <lforschler@apple.com>
852
853         Reviewed by Stephanie Lewis.
854
855         Add a new Leopard test bot.
856
857         * BuildSlaveSupport/build.webkit.org-config/config.json:
858
859 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
860
861         Reviewed by Adam Barth.
862
863         Add EFL Builder to core waterfall
864         https://bugs.webkit.org/show_bug.cgi?id=52704
865
866         Add EFL Builder to the core waterfall again.
867
868         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
869         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
870
871 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
872
873         Reviewed by Tony Chang.
874
875         new-run-webkit-tests fails to start HTTP server if there are proxy settings
876         https://bugs.webkit.org/show_bug.cgi?id=52872
877
878         Force disabling proxy to resolve the problem.
879
880         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
881         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
882
883 2011-01-24  Andreas Kling  <kling@webkit.org>
884
885         Reviewed by Darin Adler.
886
887         check-webkit-style: Update exemptions following Source/ move.
888         https://bugs.webkit.org/show_bug.cgi?id=53017
889
890         * Scripts/webkitpy/style/checker.py:
891         * Scripts/webkitpy/style/checker_unittest.py:
892
893 2011-01-24  Andras Becsi  <abecsi@webkit.org>
894
895         Rubber-stamped by Csaba Osztrogonác.
896
897         [Qt] Move project files into Source
898         https://bugs.webkit.org/show_bug.cgi?id=52891
899
900         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
901
902 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
903
904         Reviewed by Yury Semikhatsky.
905
906         Web Inspector: Find duplicate strings in localizedStrings.js
907
908         https://bugs.webkit.org/show_bug.cgi?id=53005
909
910         * Scripts/check-inspector-strings:
911
912 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
913
914         Reviewed by Andreas Kling.
915
916         [Qt] Regroup MiniBrowser's menubar and add open file action
917         https://bugs.webkit.org/show_bug.cgi?id=53000
918
919         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
920
921         * MiniBrowser/qt/BrowserWindow.cpp:
922         (BrowserWindow::BrowserWindow):
923         (BrowserWindow::openFile):
924         (BrowserWindow::~BrowserWindow):
925         * MiniBrowser/qt/BrowserWindow.h:
926
927 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
928
929         Unreviewed fix after r76496
930
931         [Qt] Move project files into Source
932         https://bugs.webkit.org/show_bug.cgi?id=52891
933
934         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
935         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
936         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
937
938 2011-01-24  Andras Becsi  <abecsi@webkit.org>
939
940         Reviewed by Csaba Osztrogonác.
941
942         [Qt] Move project files into Source
943         https://bugs.webkit.org/show_bug.cgi?id=52891
944
945         * DerivedSources.pro: Renamed from DerivedSources.pro.
946         * DumpRenderTree/qt/DumpRenderTree.pro:
947         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
948         * MiniBrowser/DerivedSources.pro:
949         * MiniBrowser/qt/MiniBrowser.pro:
950         * QtTestBrowser/QtTestBrowser.pro:
951         * Scripts/webkitdirs.pm:
952         * Tools.pro: Added.
953         * WebKitTestRunner/DerivedSources.pro:
954         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
955         * WebKitTestRunner/qt/WebKitTestRunner.pro:
956
957 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
958
959         Reviewed by Dan Bernstein.
960
961         Beefed up --threaded mode to catch even more kinds of errors.
962         https://bugs.webkit.org/show_bug.cgi?id=52971
963
964         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
965         context group to force JSC to mark multiple threads. (This used to be
966         the default, but it changed in SnowLeopard.)
967         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
968         to give threading mistakes more chances to show themselves.
969         (startJavaScriptThreads):
970         (stopJavaScriptThreads):
971
972 2011-01-22  Robert Hogan  <robert@webkit.org>
973
974         Reviewed by Andreas Kling.
975
976         [Qt] Support layoutTestController.addURLToRedirect()
977         https://bugs.webkit.org/show_bug.cgi?id=52956
978
979         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
980         (LayoutTestController::addURLToRedirect):
981         * DumpRenderTree/qt/LayoutTestControllerQt.h:
982
983 2011-01-22  Robert Hogan  <robert@webkit.org>
984
985         Reviewed by Kenneth Rohde Christiansen.
986
987         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
988         https://bugs.webkit.org/show_bug.cgi?id=49802
989
990         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
991         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
992         (WebCore::DumpRenderTree::open):
993
994 2011-01-21  Adam Barth  <abarth@webkit.org>
995
996         Reviewed by Maciej Stachowiak.
997
998         Disable mac_unittest.py that fails on some of the Mac bots
999         https://bugs.webkit.org/show_bug.cgi?id=52947
1000
1001         As noted in the comment, this test does not appear to be correct
1002         because the function this test is testing returns different results
1003         depending on which flavor of Mac the test is run on.  This patch
1004         disable the test.  Hopefully we can re-enable the test once we've
1005         probably insulated the test from its environment.
1006
1007         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1008
1009 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1010
1011         Reviewed by Mihai Parparita.
1012
1013         Fix bug introduced in r76322 that caused NRWT to not actually
1014         read the Skipped files properly.
1015
1016         https://bugs.webkit.org/show_bug.cgi?id=52771
1017
1018         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1019         * Scripts/webkitpy/layout_tests/port/webkit.py:
1020         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1021
1022 2011-01-21  Sam Weinig  <sam@webkit.org>
1023
1024         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1025
1026         WebKitTestRunner needs the HOME environment variable to be set.
1027         <rdar://problem/8896573>
1028
1029         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1030         it exists.
1031
1032 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1033
1034         Reviewed by Eric Seidel.
1035
1036         Suppress a few remaining integration tests so that none of the
1037         layout_test unit tests ever read from the filesystem or launch
1038         subprocesses that aren't part of the unit tests.
1039
1040         Also fix a minor bug in the printing unit tests that was
1041         incorrectly relying on sys.argv.
1042
1043         https://bugs.webkit.org/show_bug.cgi?id=52863
1044
1045         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1046         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1047         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1048
1049 2011-01-21  Darin Adler  <darin@apple.com>
1050
1051        Fix Mac build.
1052
1053         * MiniBrowser/mac/BrowserWindowController.m:
1054         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1055
1056 2011-01-20  Darin Adler  <darin@apple.com>
1057
1058         Reviewed by Dan Bernstein.
1059
1060         WebKit2: Implement showModalDialog
1061         https://bugs.webkit.org/show_bug.cgi?id=52855
1062
1063         This fixes WebKitTestRunner to compile, but more work is probably
1064         needed to get it to pass the tests.
1065
1066         * WebKitTestRunner/TestController.cpp:
1067         (WTR::TestController::runModal): Added. Calls through to the
1068         platform-specific version of runModal.
1069         (WTR::TestController::createOtherPage): Changed to be a private
1070         static member function so it can refer to runModal, which is
1071         a private static member function.
1072         (WTR::TestController::initialize): Pass 0 for the runModal
1073         function since we don't need to run the main window modal.
1074         I suspect this is wrong and will need to change.
1075         * WebKitTestRunner/TestController.h: Added declarations for
1076         the functions added above.
1077         * WebKitTestRunner/mac/TestControllerMac.mm:
1078         (WTR::TestController::runModal): Added. Untested implementation.
1079         * WebKitTestRunner/qt/TestControllerQt.cpp:
1080         (WTR::TestController::runModal): Added.
1081         * WebKitTestRunner/win/TestControllerWin.cpp:
1082         (WTR::TestController::runModal): Added.
1083
1084 2011-01-21  Eric Seidel  <eric@webkit.org>
1085
1086         Reviewed by Adam Barth.
1087
1088         Split Host object off from WebKitPatch for easier re-use
1089         https://bugs.webkit.org/show_bug.cgi?id=52284
1090
1091         new-run-webkit-tests and other tools are eventually going to want one of these.
1092         Basically you need to inherit from this class if you want to pretend to be a
1093         self.tool object for Steps/Commands.
1094
1095         * Scripts/webkitpy/common/host.py: Added.
1096         * Scripts/webkitpy/tool/main.py:
1097
1098 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1099
1100         Reviewed by Adam Barth.
1101
1102         Disable the tests that start and stop the http server and web
1103         server, so that we don't have to worry about port collisions on
1104         the bots.
1105
1106         https://bugs.webkit.org/show_bug.cgi?id=52861
1107
1108         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1109
1110 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1111
1112         Reviewed by Eric Seidel.
1113
1114         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1115         
1116         https://bugs.webkit.org/show_bug.cgi?id=52772
1117         
1118         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1119
1120 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1121
1122         Reviewed by Eric Siedel.
1123
1124         nrwt: clean up almost all remaining port references, remove
1125         unnecessary import clauses. The only remaining references are
1126         in places where a mock filesystem makes no sense or can't be
1127         used, and in one routine in port/google_chrome_unittest that
1128         I'll rewrite in a separate patch.
1129
1130         https://bugs.webkit.org/show_bug.cgi?id=52771
1131
1132         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1133         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1134         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1135         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1136         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1137         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1138         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1139         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1140         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1141         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1142         * Scripts/webkitpy/layout_tests/port/gtk.py:
1143         * Scripts/webkitpy/layout_tests/port/mac.py:
1144         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1145         * Scripts/webkitpy/layout_tests/port/qt.py:
1146         * Scripts/webkitpy/layout_tests/port/webkit.py:
1147         * Scripts/webkitpy/layout_tests/port/win.py:
1148         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1149
1150 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1151
1152         Reviewed by Mihai Parparita.
1153
1154         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1155
1156         https://bugs.webkit.org/show_bug.cgi?id=52762
1157
1158         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1159         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1160
1161 2011-01-20  Tony Chang  <tony@chromium.org>
1162
1163         Reviewed by Ojan Vafai.
1164
1165         [chromium] fix the paths used for the rebaseline tool
1166         https://bugs.webkit.org/show_bug.cgi?id=52857
1167
1168         Some of the bots were renamed so the path to grab the results zip
1169         file has changed.
1170
1171         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1172
1173 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1174
1175         Reviewed by Tony Chang.
1176
1177         Fix bug introduced in r72688 / bug 52768 that broke the
1178         generation of the output filename links in the results.html
1179         output. Apparently none of the unit tests actually checked to
1180         make sure the generated links were correct :(
1181
1182         https://bugs.webkit.org/show_bug.cgi?id=52854
1183
1184         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1185         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1186
1187 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1188
1189         Reviewed by Darin Adler.
1190
1191         https://bugs.webkit.org/show_bug.cgi?id=52849
1192         Make window.print work with WebKit2
1193
1194         * MiniBrowser/mac/BrowserWindowController.m:
1195         (-[BrowserWindowController awakeFromNib]):
1196         * WebKitTestRunner/TestController.cpp:
1197         (WTR::createOtherPage):
1198         (WTR::TestController::initialize):
1199         Added zeroes to WKPageUIClient structures to avoid build failures.
1200
1201 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1202
1203         Reviewed by Eric Seidel.
1204
1205         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1206
1207         https://bugs.webkit.org/show_bug.cgi?id=52756
1208
1209         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1210         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1211         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1212         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1213         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1214         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1215
1216 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1217
1218         Reviewed by Antonio Gomes.
1219
1220         QtTestBrowser should have a seperate menu for Settings
1221         https://bugs.webkit.org/show_bug.cgi?id=52817
1222         
1223         Added a new menu item named "Settings"
1224         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1225
1226         * QtTestBrowser/launcherwindow.cpp:
1227         (LauncherWindow::createChrome):
1228
1229 2011-01-20  Sam Weinig  <sam@webkit.org>
1230
1231         Reviewed by John Sullivan.
1232
1233         Update update-webkit-localizable-strings with new path to WebKit.
1234
1235         * Scripts/update-webkit-localizable-strings:
1236
1237 2011-01-20  James Robinson  <jamesr@chromium.org>
1238
1239         Reviewed by Darin Fisher.
1240
1241         Implement mozilla's requestAnimationFrame API
1242         https://bugs.webkit.org/show_bug.cgi?id=51218
1243
1244         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1245
1246         * DumpRenderTree/chromium/WebViewHost.cpp:
1247         (invokeScheduleComposite):
1248         (WebViewHost::scheduleAnimation):
1249         (WebViewHost::paintInvalidatedRegion):
1250         * DumpRenderTree/chromium/WebViewHost.h:
1251
1252 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1253
1254         Reviewed by Adam Roben.
1255
1256         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1257         https://bugs.webkit.org/show_bug.cgi?id=42327
1258
1259         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1260         for methods that take their normal arguments but also a JSContextRef.
1261         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1262         for evaluateScriptInIsolatedWorld.
1263         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1264         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1265         this call is for an isolated world.
1266         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1267         (WTR::worldMap): Helper to create a world map.
1268         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1269         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1270         added LayoutTestController API.
1271         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1272
1273 2011-01-19  Adam Roben  <aroben@apple.com>
1274
1275         Convert paths in environment variables back to msys-style inside commit-log-editor
1276
1277         When this script gets run from inside git commit, msys-style paths in the environment will
1278         have been turned into Windows-style paths with forward slashes. This screws up functions
1279         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1280         the paths back to msys-style before doing anything else.
1281
1282         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1283         using msysgit's Perl and multiple ChangeLogs have been edited
1284
1285         Reviewed by David Kilzer.
1286
1287         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1288         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1289         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1290
1291 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1292
1293         [Win] Unreviewed build fix after r76248.
1294
1295         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1296
1297 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1298
1299         Reviewed by Csaba Osztrogonác.
1300
1301         Refactoring of the custom allocation framework
1302         https://bugs.webkit.org/show_bug.cgi?id=49897
1303
1304         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1305         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1306         equivalent macro implementation at the necessary places.
1307 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1308
1309         Unreviewed. 
1310
1311         Adding myself to committers.py.
1312
1313         * Scripts/webkitpy/common/config/committers.py:
1314
1315 2011-01-20  Adam Barth  <abarth@webkit.org>
1316
1317         Reviewed by Tony Chang.
1318
1319         Chromium builders don't delete unversioned directories when DEPS change
1320         https://bugs.webkit.org/show_bug.cgi?id=52745
1321
1322         If we pass this option to gclient sync, gclient will delete directories
1323         that are no longer part of DEPS instead of leaving them around to
1324         confuse us later.  Apparently, the downstream buildbots use this option
1325         already.
1326
1327         * Scripts/update-webkit-chromium:
1328
1329 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1330
1331         Unreviewed, build fix - I pulled this patch in to fix an issue
1332         revealed by r76195 running on some new bots). Also fix a couple
1333         of other issues revealed in testing.
1334
1335         nrwt: remove fs refs from layout_package/json*
1336
1337         https://bugs.webkit.org/show_bug.cgi?id=52754
1338
1339         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1340         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1341         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1342         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1343         * Scripts/webkitpy/layout_tests/port/base.py:
1344
1345 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1346
1347         Unreviewed, build fix.
1348
1349         Fix a couple of minor bugs discovered while bringing up new bots
1350         for testing.
1351
1352         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1353         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1354
1355 2011-01-19  James Robinson  <jamesr@chromium.org>
1356
1357         Unreviewed, rolling out r76194.
1358         http://trac.webkit.org/changeset/76194
1359         https://bugs.webkit.org/show_bug.cgi?id=51218
1360
1361         Caused mysterious compile failure on the chromium win
1362         build.webkit.org bots
1363
1364         * DumpRenderTree/chromium/WebViewHost.cpp:
1365         (WebViewHost::paintInvalidatedRegion):
1366         * DumpRenderTree/chromium/WebViewHost.h:
1367
1368 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1369
1370         Reviewed by Mihai Parparita.
1371
1372         remove fs refs from test_runner, dump_render_tree_thread
1373
1374         https://bugs.webkit.org/show_bug.cgi?id=52753
1375
1376         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1377         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1378         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1379         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1380
1381 2011-01-19  James Robinson  <jamesr@chromium.org>
1382
1383         Reviewed by Darin Fisher.
1384
1385         Implement mozilla's requestAnimationFrame API
1386         https://bugs.webkit.org/show_bug.cgi?id=51218
1387
1388         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1389
1390         * DumpRenderTree/chromium/WebViewHost.cpp:
1391         (invokeScheduleComposite):
1392         (WebViewHost::scheduleAnimation):
1393         (WebViewHost::paintInvalidatedRegion):
1394         * DumpRenderTree/chromium/WebViewHost.h:
1395
1396 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1397
1398         Unreviewed, build fix.
1399
1400         Fix a few incorrect "self._filesystem" references introduced in
1401         r76184.
1402
1403         * Scripts/webkitpy/layout_tests/port/chromium.py:
1404         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1405
1406 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1407
1408         Reviewed by Mihai Parparita.
1409
1410         add a .sep property, abspath(), isabs(), mtime(), and
1411         open_text_file_for_writing() to filesystem modules. Some of
1412         these properties are not needed in this patch but will be needed
1413         in subsequent patches (I'm doing this to avoid having to track
1414         multiple versions of a single file).
1415
1416         Also, change most of the port/* modules to use the filesystem
1417         objects instead of referencing the filesystem directly.
1418
1419         https://bugs.webkit.org/show_bug.cgi?id=52748
1420
1421         * Scripts/webkitpy/common/system/filesystem.py:
1422         * Scripts/webkitpy/common/system/filesystem_mock.py:
1423         * Scripts/webkitpy/layout_tests/port/__init__.py:
1424         * Scripts/webkitpy/layout_tests/port/base.py:
1425         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1426         * Scripts/webkitpy/layout_tests/port/chromium.py:
1427         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1428         * Scripts/webkitpy/layout_tests/port/config.py:
1429         * Scripts/webkitpy/layout_tests/port/test.py:
1430         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1431
1432 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1433
1434         Reviewed by Anders Carlsson.
1435
1436         If resetting between tests times out, treat it as a WebProcess crash
1437         https://bugs.webkit.org/show_bug.cgi?id=52757
1438
1439         * WebKitTestRunner/TestController.cpp:
1440         (WTR::TestController::runTest):
1441
1442 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1443
1444         Reviewed by Darin Adler.
1445
1446         https://bugs.webkit.org/show_bug.cgi?id=52739
1447         Make it possible for a WebKit2 client to print headers and footers
1448
1449         Added dummy implementations for new printing UIClient calls.
1450
1451         * MiniBrowser/mac/BrowserWindowController.m:
1452         (-[BrowserWindowController awakeFromNib]):
1453         * WebKitTestRunner/TestController.cpp:
1454         (WTR::createOtherPage):
1455         (WTR::TestController::initialize):
1456
1457 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1458
1459         Reviewed by Ojan Vafai.
1460
1461         Change webkitpy/layout_tests/port/test.py to use the
1462         in-memory filesystem for cleaner unit testing. This
1463         change allows us to kill a lot of code that was
1464         specific to the test port, at the cost of being a
1465         little less clear about how things would work if
1466         you didn't have a filesystem.
1467
1468         https://bugs.webkit.org/show_bug.cgi?id=52605
1469
1470         * Scripts/webkitpy/layout_tests/port/test.py:
1471
1472 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1473
1474         Unreviewed, build fix.
1475
1476         Fix test failure caused by committing attachment 79368 instead
1477         of attachment 79461 on bug 52604.
1478
1479         * Scripts/webkitpy/common/system/filesystem_mock.py:
1480
1481 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1482
1483         Reviewed by Mihai Parparita.
1484
1485         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1486         unit testing. os.walk() is too much of a hassle to implement on
1487         top of the in-memory mock filesystem and adding the necessary
1488         interface to files_under() gives clients a cleaner API anyway
1489         (for this particular usage model).
1490
1491         https://bugs.webkit.org/show_bug.cgi?id=52691
1492
1493         * Scripts/webkitpy/common/system/filesystem.py:
1494         * Scripts/webkitpy/common/system/filesystem_mock.py:
1495         * Scripts/webkitpy/layout_tests/port/test_files.py:
1496         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1497
1498 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1499
1500         Reviewed by Tony Chang.
1501
1502         Change more modules in the layout-tests code to use the
1503         filesystem wrapper for cleaner unit testing.
1504
1505         This patch also adds the glob() wrapper to the filesystem
1506         abstraction.
1507         
1508         https://bugs.webkit.org/show_bug.cgi?id=52604
1509
1510         * Scripts/webkitpy/layout_tests/port/test_files.py:
1511         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1512         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1513         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1514         * Scripts/webkitpy/common/system/filesystem.py:
1515         * Scripts/webkitpy/common/system/filesystem_mock.py:
1516
1517 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1518
1519         Unreviewed.
1520
1521         Updating my email addresses and irc nick.
1522
1523         * Scripts/webkitpy/common/config/committers.py:
1524
1525 2011-01-19  Tony Chang  <tony@chromium.org>
1526
1527         Reviewed by Mihai Parparita.
1528
1529         [chromium] [linux] if check-sys-deps fails, output the failure reason
1530         https://bugs.webkit.org/show_bug.cgi?id=52671
1531
1532         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1533             error handler functions.
1534         * Scripts/webkitpy/layout_tests/port/chromium.py:
1535             output the error text from --check-sys-deps
1536         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1537
1538 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1539
1540         Reviewed by Andreas Kling.
1541
1542         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1543         https://bugs.webkit.org/show_bug.cgi?id=52554
1544         
1545         QtNetworkAccessManager is created in a thread and set as
1546         member variable in QWebPage. When the thread is destroyed
1547         the object is still used. So fix will set the object to
1548         NULL once the thread is destroyed.
1549
1550         * QtTestBrowser/launcherwindow.cpp:
1551         (LauncherWindow::~LauncherWindow):
1552
1553 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1554
1555         Rubber stamped by Csaba Osztrogonac
1556
1557         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1558
1559 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1560
1561         Reviewed by Tony Chang.
1562
1563         new-run-webkit-tests: add a --build-directory command line argument
1564
1565         Official Google Chrome builds use a non-standard build directory
1566         location. This patch adds a --build-directory argument that
1567         allows that location to be specified on the command line. Only
1568         Chromium-based builds will use this flag for now, but anyone can
1569         in the future.
1570
1571         There are no unit tests for this since it's difficult to test
1572         until mock filesystems are fully supported in the code. This was
1573         tested by hand for now.
1574
1575         https://bugs.webkit.org/show_bug.cgi?id=52694
1576
1577         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1578         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1579         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1580         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1581
1582 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1583
1584         Not reviewed. Bot fix.
1585
1586         Remove an inadvertently committed debugging print.
1587
1588         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1589         (LayoutTestController::notifyDone):
1590
1591 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1592
1593         Reviewed by Sam Weinig.
1594
1595         WebKitTestRunner should track loading more like DumpRenderTree
1596         https://bugs.webkit.org/show_bug.cgi?id=52692
1597
1598         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1599         This makes some tests that call notifyDone multiple times pass.
1600         
1601         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1602         (WTR::InjectedBundle::InjectedBundle):
1603         (WTR::InjectedBundle::done):
1604         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1605         (WTR::InjectedBundle::topLoadingFrame):
1606         (WTR::InjectedBundle::setTopLoadingFrame):
1607         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1608         (WTR::InjectedBundlePage::InjectedBundlePage):
1609         (WTR::InjectedBundlePage::stopLoading):
1610         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1611         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1612         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1613         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1614         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1615         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1616         (WTR::LayoutTestController::notifyDone):
1617         * WebKitTestRunner/TestController.cpp:
1618         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1619
1620 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1621
1622         Reviewed by Kent Tamura.
1623
1624         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1625         https://bugs.webkit.org/show_bug.cgi?id=52678
1626         
1627         Update path now that WebKit is inside Source.
1628
1629         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1630
1631 2011-01-18  Robert Hogan  <robert@webkit.org>
1632
1633         Reviewed by Simon Hausmann.
1634
1635         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1636         https://bugs.webkit.org/show_bug.cgi?id=44282
1637
1638         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1639         (WebCore::DumpRenderTree::dump):
1640
1641 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1642
1643         Reviewed by Mihai Parparita.
1644
1645         Fix a small race condition that could cause the unit tests for
1646         new-run-webkit-tests to fail in a multithreaded environment.
1647         There was a small window in the code where one thread would
1648         check to see if a thread had raised an exception, do something,
1649         and then check to see if the thread was alive. If the other
1650         thread raised an exception and exited in between these two
1651         steps, the exception would be lost. Flipping the order of the
1652         two checks fixes the race, since we will now always check for an
1653         exception on the thread before exiting.
1654
1655         https://bugs.webkit.org/show_bug.cgi?id=51579
1656
1657         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1658
1659 2011-01-18  Eric Seidel  <eric@webkit.org>
1660
1661         Reviewed by Adam Barth.
1662
1663         commit-queue dies when test archiving fails
1664         https://bugs.webkit.org/show_bug.cgi?id=52617
1665
1666         I looked at the machine and it had 10 archives already
1667         thus find_unused_name was returning None.  I've upped
1668         the limit to 100 (per bug) and tested the case where
1669         find_unused_name returns None (making archive return None).
1670
1671         * Scripts/webkitpy/common/system/workspace.py:
1672         * Scripts/webkitpy/common/system/workspace_unittest.py:
1673         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1674         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1675         * Scripts/webkitpy/tool/commands/queues.py:
1676
1677 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1678
1679         Reviewed by Ojan Vafai.
1680
1681         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1682         filesystem. Also fix a couple of "with" statements missed by
1683         r76050.
1684
1685         https://bugs.webkit.org/show_bug.cgi?id=52487
1686
1687         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1688
1689 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1690
1691         Reviewed by Martin Robinson.
1692
1693         [Gtk] Build fixes for gtk3 build
1694         https://bugs.webkit.org/show_bug.cgi?id=52648
1695
1696         * DumpRenderTree/gtk/EventSender.cpp:
1697         (beginDragWithFilesCallback):
1698
1699 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1700
1701         Reviewed by Mihai Parparita.
1702
1703         Update rebaseline-chromium-webkit-tests to use filesystem objects
1704         instead of direct references to os.path, shutil, tempfile, etc.
1705
1706         This patch doesn't change anything, but will allow subsequent
1707         patches to change the unit tests to no longer use the real
1708         filesystem.
1709
1710         This patch adds a bunch more methods to the filesystem object as
1711         well.
1712
1713         https://bugs.webkit.org/show_bug.cgi?id=52482
1714
1715         * Scripts/webkitpy/common/system/filesystem.py:
1716         * Scripts/webkitpy/common/system/filesystem_mock.py:
1717         * Scripts/webkitpy/tool/commands/queues.py:
1718         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1719         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1720
1721 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1722
1723         Reviewed by Mihai Parparita.
1724
1725         new-run-webkit-tests shouldn't crash when you try to run a
1726         directory containing only skipped files.
1727
1728         https://bugs.webkit.org/show_bug.cgi?id=52478
1729         
1730         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1731         * Scripts/webkitpy/layout_tests/port/test.py:
1732         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1733
1734 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1735
1736         Reviewed by Gustavo Noronha Silva.
1737
1738         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1739         https://bugs.webkit.org/show_bug.cgi?id=40833
1740
1741         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1742         GTK+ event sender.
1743         (dragWithFilesDragDataGetCallback): Added.
1744         (dragWithFilesDragEndCallback): Added.
1745         (beginDragWithFilesCallback): Added.
1746
1747 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1748
1749         Reviewed by Adam Barth.
1750
1751         ews: Add additional watcher to efl ews
1752         https://bugs.webkit.org/show_bug.cgi?id=52613
1753
1754         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1755
1756         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1757
1758 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1759
1760         Reviewed by Alexey Proskuryakov.
1761
1762         Fix some headers with missing or misspelled #ifndef guards
1763         https://bugs.webkit.org/show_bug.cgi?id=52545
1764
1765         * DumpRenderTree/chromium/TestEventPrinter.h:
1766         * DumpRenderTree/chromium/WebPreferences.h:
1767
1768 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1769
1770         Reviewed by Anders Carlsson.
1771
1772         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1773         navigating back to an unreachable URL
1774         https://bugs.webkit.org/show_bug.cgi?id=52388
1775
1776         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1777
1778         * DumpRenderTree/LayoutTestController.cpp:
1779         (queueLoadHTMLStringCallback):
1780         (LayoutTestController::queueLoadHTMLString):
1781         (LayoutTestController::queueLoadAlternateHTMLString):
1782         * DumpRenderTree/LayoutTestController.h:
1783
1784         * DumpRenderTree/WorkQueueItem.h:
1785         (LoadHTMLStringItem::LoadHTMLStringItem):
1786
1787         * DumpRenderTree/chromium/LayoutTestController.cpp:
1788         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1789         (WorkItemLoadHTMLString::run):
1790         (LayoutTestController::queueLoadHTMLString):
1791
1792         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1793         (LoadHTMLStringItem::invoke):
1794         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1795         (LoadHTMLStringItem::invoke):
1796         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1797         (LoadHTMLStringItem::invoke):
1798
1799 2011-01-17  Dan Bernstein  <mitz@apple.com>
1800
1801         Rubber-stamped by Mark Rowe.
1802
1803         Update xcodeproj svn:ignore to include xcuserdata.
1804
1805         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1806         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1807         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1808         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1809         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1810
1811 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1812
1813         Unreviewed fix after r75908.
1814
1815         Move WebKit into Source
1816         https://bugs.webkit.org/show_bug.cgi?id=52530
1817
1818         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1819
1820 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1821
1822         Unreviewed.
1823
1824         Remove accidentally committed debug printing after r75908.
1825
1826         * Scripts/webkitdirs.pm:
1827
1828 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1829
1830         Unreviewed.
1831
1832         Add myself to committers list
1833         https://bugs.webkit.org/show_bug.cgi?id=52566
1834
1835         * Scripts/webkitpy/common/config/committers.py:
1836
1837 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1838
1839         Reviewed by Jeremy Orlow.
1840
1841         GeolocationController should call stopUpdating on destruction
1842         https://bugs.webkit.org/show_bug.cgi?id=52216
1843
1844         fast/dom/Geolocation/window-close-crash.html requires that a
1845         Geolocation watch be started in a secondary window. Consequently,
1846         we need to allow geolocation permission and provide a mock
1847         geolocation position for the secondary window's
1848         GeolocationClientMock.
1849
1850         * DumpRenderTree/chromium/LayoutTestController.cpp:
1851         (LayoutTestController::setGeolocationPermission):
1852         (LayoutTestController::setMockGeolocationPosition):
1853         (LayoutTestController::setMockGeolocationError):
1854         * DumpRenderTree/chromium/TestShell.h:
1855         (TestShell::windowList):
1856
1857 2011-01-16  Adam Barth  <abarth@webkit.org>
1858
1859         Update more include paths to reflect WebKit move.
1860
1861         * DumpRenderTree/chromium/EventSender.cpp:
1862         (EventSender::keyDown):
1863         (EventSender::needsShiftModifier):
1864         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1865         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1866
1867 2011-01-16  Kent Tamura  <tkent@chromium.org>
1868
1869         Unreviewed, Chromium build fix.
1870
1871         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1872
1873 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1874
1875         Build fix for GTK+ after source directory movement.
1876
1877         * GNUmakefile.am: Correct include paths.
1878
1879 2011-01-16  Adam Barth  <abarth@webkit.org>
1880
1881         Teach svn-apply about WebKit move.
1882
1883         * Scripts/VCSUtils.pm:
1884
1885 2011-01-16  Adam Barth  <abarth@webkit.org>
1886
1887         Rubber-stamped by Eric Seidel.
1888
1889         Move WebKit into Source
1890         https://bugs.webkit.org/show_bug.cgi?id=52530
1891
1892         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1893         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1894         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1895         * DumpRenderTree/qt/GCControllerQt.cpp:
1896         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1897         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1898         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1899         * DumpRenderTree/wscript:
1900         * QtTestBrowser/launcherwindow.h:
1901         * Scripts/build-webkit:
1902         * Scripts/webkitdirs.pm:
1903
1904 2011-01-15  Adam Barth  <abarth@webkit.org>
1905
1906         Teach svn-apply about WebKit2 move.
1907
1908         * Scripts/VCSUtils.pm:
1909
1910 2011-01-15  Adam Barth  <abarth@webkit.org>
1911
1912         Rubber-stamped by Eric Seidel.
1913
1914         Move WebKit2 into Source
1915         https://bugs.webkit.org/show_bug.cgi?id=52438
1916
1917         * MiniBrowser/qt/MiniBrowser.pro:
1918         * Scripts/build-webkit:
1919         * Scripts/do-file-rename:
1920         * Scripts/do-webcore-rename:
1921         * Scripts/test-webkitpy:
1922         * Scripts/webkitdirs.pm:
1923         * Scripts/webkitpy/style/checker.py:
1924         * WebKitTestRunner/DerivedSources.pro:
1925         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1926         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1927
1928 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1929
1930         Reviewed by David Levin.
1931
1932         [chromium] remove obsolete createView method
1933         https://bugs.webkit.org/show_bug.cgi?id=52437
1934
1935         * DumpRenderTree/chromium/WebViewHost.cpp:
1936         (WebViewHost::createView):
1937         * DumpRenderTree/chromium/WebViewHost.h:
1938
1939 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1940
1941         Reviewed by Geoff Garen.
1942
1943         ShouldLoadResourceForFrame should use strings, not URLs.
1944         https://bugs.webkit.org/show_bug.cgi?id=52476
1945
1946         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1947         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1948         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1949
1950 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1951
1952         Reviewed by David Levin.
1953
1954         Add Tony Gentilcore as a reviewer
1955         https://bugs.webkit.org/show_bug.cgi?id=52480
1956
1957         * Scripts/webkitpy/common/config/committers.py:
1958
1959 2011-01-14  David Levin  <levin@chromium.org>
1960
1961         Reviewed by Eric Seidel.
1962
1963         check-webkit-style: _FunctionState should keep track of where the function name starts.
1964         https://bugs.webkit.org/show_bug.cgi?id=52454
1965
1966         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1967         _FunctionState and logic for setting it correctly.
1968         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1969
1970 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1971
1972         Reviewed by David Levin.
1973
1974         Add support to DumpRenderTree to use the GPU rather than software renderer
1975         https://bugs.webkit.org/show_bug.cgi?id=52333
1976
1977         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1978         (main):
1979         * Scripts/webkitpy/layout_tests/port/chromium.py:
1980         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1981
1982 2011-01-14  Tony Chang  <tony@chromium.org>
1983
1984         Reviewed by Kent Tamura.
1985
1986         [chromium] update fonts.conf to fix 6 linux tests in drt
1987         https://bugs.webkit.org/show_bug.cgi?id=52411
1988
1989         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1990             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1991
1992 2011-01-14  Eric Seidel  <eric@webkit.org>
1993
1994         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1995
1996         Reviewed by Adam Barth.
1997
1998         Fix when running Tools/Scripts/check-webkit-style without arguments.
1999         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2000
2001         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2002         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2003
2004 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2005
2006         Reviewed by David Levin.
2007
2008         Store the tempdir object in a variable so it doesn't get deleted too early.
2009         https://bugs.webkit.org/show_bug.cgi?id=51875
2010
2011         * Scripts/update-webkit-auxiliary-libs:
2012         * Scripts/update-webkit-support-libs:
2013
2014 2011-01-14  Eric Seidel  <eric@webkit.org>
2015
2016         Unreviewed.  Make it work in python 2.5.
2017
2018         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2019         https://bugs.webkit.org/show_bug.cgi?id=49158
2020
2021         * Scripts/webkitpy/common/checkout/api_unittest.py:
2022
2023 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2024
2025         Unreviewed, rolling out r75774.
2026         http://trac.webkit.org/changeset/75774
2027         https://bugs.webkit.org/show_bug.cgi?id=52431
2028
2029         gtk builds were broken (Requested by loislo2 on #webkit).
2030
2031         * Scripts/webkitpy/common/checkout/scm.py:
2032
2033 2011-01-14  David Levin  <levin@chromium.org>
2034
2035         Reviewed by Shinichiro Hamaji.
2036
2037         check-webkit-style: _FunctionState should detect pure functions.
2038         https://bugs.webkit.org/show_bug.cgi?id=52428
2039
2040         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2041         is a pure virtual function.
2042         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2043         virtual functions are correctly detected.
2044
2045 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2046
2047         Reviewed by Yury Semikhatsky.
2048
2049         Just small fix for problem with check-webkit-style.
2050         It just didn't work for this patch.
2051         Old code can't concatenate a list of strings with None.
2052
2053         * Scripts/webkitpy/common/checkout/scm.py:
2054
2055 2011-01-13  David Levin  <levin@chromium.org>
2056
2057         Reviewed by Shinichiro Hamaji.
2058
2059         check-webkit-style: _FunctionState should use Position to know where items are.
2060         https://bugs.webkit.org/show_bug.cgi?id=52424
2061
2062         * Scripts/webkitpy/style/checkers/cpp.py:
2063         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2064         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2065         did some minor clean-up.
2066         (*): Other changes are simply about converting to use the Position's in_FunctionState
2067         instead of line numbers.
2068         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2069         to verify the positions stored in _FunctionState.
2070
2071 2011-01-13  Eric Seidel  <eric@webkit.org>
2072
2073         Reviewed by David Levin.
2074
2075         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2076         https://bugs.webkit.org/show_bug.cgi?id=49158
2077
2078         This is not the most elegant, but it is a very safe fix to this bug.
2079         One advantage of catching ScriptError like this instead of adding a
2080         new added_or_modified_files or fixing all changed_files callers
2081         to use a more specific change_files variant, is that we catch
2082         all kinds of ScriptErrors which might cause our (non-essential)
2083         suggest-reviewers code to fail out.  This should make passing
2084         --suggest-reviewers to webkit-patch upload much more robust
2085         and may even make it possible for us to make it default.
2086
2087         The root of the problem here is that SCM.changed_files includes
2088         deleted ChangeLog paths (from moves, etc) which then when we ask
2089         SVN/Git for the contents of the file at that revision, the command
2090         errors out and Executive.run_command raises a ScriptError.
2091
2092         In the future we might fix this differently by making all current
2093         callers of chagned_files use a more specific method for requesting
2094         what types of changes they're interested in (adds, modifies, deletes, etc.)
2095
2096         * Scripts/webkitpy/common/checkout/api.py:
2097         * Scripts/webkitpy/common/checkout/api_unittest.py:
2098
2099 2011-01-13  Dan Bernstein  <mitz@apple.com>
2100
2101         Reviewed by Alexey Proskuryakov.
2102
2103         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2104         https://bugs.webkit.org/show_bug.cgi?id=52419
2105
2106         Allow to further control the behavior of the willSendRequest delegate callback by making it
2107         set a different URL in the new request.
2108
2109         * DumpRenderTree/LayoutTestController.cpp:
2110         (addURLToRedirectCallback): Added.
2111         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2112         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2113         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2114         * DumpRenderTree/LayoutTestController.h:
2115         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2116         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2117         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2118         change the URL in the new request to the redirect destination.
2119
2120 2011-01-13  Eric Seidel  <eric@webkit.org>
2121
2122         Reviewed by Mihai Parparita.
2123
2124         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2125         https://bugs.webkit.org/show_bug.cgi?id=52416
2126
2127         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2128         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2129
2130         I also added FIXMEs about the changed_files returning deleted files problem
2131         which is causing the other most common exception for suggest-reviewers
2132         (and is probably breaking sheriff-bots blame detection).
2133
2134         * Scripts/webkitpy/common/checkout/api.py:
2135         * Scripts/webkitpy/common/checkout/api_unittest.py:
2136         * Scripts/webkitpy/common/checkout/scm.py:
2137
2138 2011-01-13  Eric Seidel  <eric@webkit.org>
2139
2140         Reviewed by Adam Barth.
2141
2142         results archives from commit-queue are too large to upload
2143         https://bugs.webkit.org/show_bug.cgi?id=52405
2144
2145         * Scripts/webkitpy/common/system/filesystem.py:
2146         * Scripts/webkitpy/common/system/filesystem_mock.py:
2147         * Scripts/webkitpy/tool/commands/queues.py:
2148
2149 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2150
2151         Reviewed by Martin Robinson.
2152
2153         [gtk] Zero-sized font does not yet work
2154         https://bugs.webkit.org/show_bug.cgi?id=49793
2155
2156         Set minimum-font-size to 0 for the DRT.
2157
2158         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2159         (resetDefaultsToConsistentValues):
2160
2161 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2162
2163         Reviewed by Darin Adler.
2164
2165         Make old-run-webkit-tests more robust on buildbots
2166         https://bugs.webkit.org/show_bug.cgi?id=52364
2167
2168         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2169
2170 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2171
2172         Reviewed by Darin Adler.
2173
2174         Make old-run-webkit-tests more robust on buildbots
2175         https://bugs.webkit.org/show_bug.cgi?id=52364
2176
2177         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2178
2179 2011-01-13  Tony Chang  <tony@chromium.org>
2180
2181         Reviewed by Kent Tamura.
2182
2183         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2184         https://bugs.webkit.org/show_bug.cgi?id=52332
2185
2186         Forked Info.plist is not longer needed.
2187
2188         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2189
2190 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2191
2192         Reviewed by Timothy Hatcher.
2193
2194         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2195         to be passed directly to WebInspector.UIString
2196
2197         https://bugs.webkit.org/show_bug.cgi?id=52365
2198
2199         * Scripts/check-inspector-strings:
2200
2201 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2202
2203         Unreviewed, rolling out r74881.
2204         http://trac.webkit.org/changeset/74881
2205         https://bugs.webkit.org/show_bug.cgi?id=52357
2206
2207         The EFL builder has been red for days (Requested by abarth on
2208         #webkit).
2209
2210         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2211         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2212
2213 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2214
2215         Reviewed by David Levin.
2216
2217         Add beforeunload support to WebKitTestRunner
2218         https://bugs.webkit.org/show_bug.cgi?id=52353
2219         
2220         This makes a number of currently failing tests pass.
2221
2222         * WebKitTestRunner/TestController.cpp:
2223         (WTR::runBeforeUnloadConfirmPanel):
2224         (WTR::createOtherPage):
2225         (WTR::TestController::initialize):
2226
2227 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2228
2229         Reviewed by Sam Weinig.
2230
2231         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2232         https://bugs.webkit.org/show_bug.cgi?id=52330
2233
2234         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2235         a web process crash.
2236         * WebKitTestRunner/TestController.cpp:
2237         (WTR::TestController::initialize): Set up a processDidCrash
2238         callback.
2239         (WTR::TestController::processDidCrash): Report that the Web process
2240         crashed.
2241         * WebKitTestRunner/TestController.h:
2242
2243 2011-01-12  David Levin  <levin@chromium.org>
2244
2245         Reviewed by Shinichiro Hamaji.
2246
2247         check-webkit-style -- close_expression function doesn't work correctly.
2248         https://bugs.webkit.org/show_bug.cgi?id=52272
2249
2250         * Scripts/webkitpy/style/checkers/cpp.py:
2251         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2252         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2253         generally useful (for upcoming code changes).
2254         (close_expression): Changed to use Position for input and output.
2255         Also, fixed many bugs such as only working correctly for parenthesis,
2256         not working correctly if given an offset in a line and not finding
2257         the real closing element if there were multiple closing elements in
2258         the same line.
2259         (detect_functions): Adjusted due to the change in arguments for
2260         close_expression.
2261         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2262         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2263         two positions are the same.
2264         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2265         (CppStyleTest.test_close_expression): Added tests to catch the issues
2266         that were fixed.
2267
2268 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2269
2270         Unreviewed, rolling out r75576.
2271         http://trac.webkit.org/changeset/75576
2272         https://bugs.webkit.org/show_bug.cgi?id=52304
2273
2274         broke rebaseline-chromium-webkit-test (Requested by thakis on
2275         #webkit).
2276
2277         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2278         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2279         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2280         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2281         * Scripts/webkitpy/layout_tests/port/base.py:
2282         * Scripts/webkitpy/layout_tests/port/chromium.py:
2283         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2284         * Scripts/webkitpy/layout_tests/port/test.py:
2285         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2286         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2287         * Scripts/webkitpy/style/checkers/test_expectations.py:
2288         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2289
2290 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2291
2292         Reviewed by Darin Adler.
2293
2294         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2295         https://bugs.webkit.org/show_bug.cgi?id=52307
2296
2297         * Scripts/old-run-webkit-tests:
2298
2299 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2300
2301         Reviewed by Martin Robinson.
2302
2303         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2304         https://bugs.webkit.org/show_bug.cgi?id=50867
2305
2306         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2307         TestNetscapePlugin.cpp 
2308
2309         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2310         * Scripts/webkitdirs.pm:
2311
2312 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2313
2314         Reviewed by Pavel Feldman.
2315
2316         Add check-inspector-strings script.
2317
2318         https://bugs.webkit.org/show_bug.cgi?id=52295
2319
2320         * Scripts/check-inspector-strings: Added.
2321
2322 2011-01-12  Adam Roben  <aroben@apple.com>
2323
2324         Advertise the .testnetscape file extension on Windows
2325
2326         Fixes <http://webkit.org/b/52298>
2327         plugins/no-mime-with-valid-extension.html fails on Windows
2328
2329         Reviewed by Dan Bernstein.
2330
2331         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2332         FileExtents field to map the .testnetscape file extension to the
2333         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2334
2335 2011-01-12  Adam Barth  <abarth@webkit.org>
2336
2337         Reviewed by Eric Seidel.
2338
2339         Make webkit-patch support subdirectories for SVN checkouts
2340         https://bugs.webkit.org/show_bug.cgi?id=52261
2341
2342         os.relpath does not exist on Python 2.5, so we need to call our version
2343         of the API.
2344
2345         * Scripts/webkitpy/common/checkout/scm.py:
2346
2347 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2348
2349         Reviewed by Eric Seidel.
2350
2351         Close additional pages opened during a test once the test completes.
2352         https://bugs.webkit.org/show_bug.cgi?id=52276
2353
2354         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2355         (WTR::InjectedBundle::done):
2356
2357 2011-01-11  David Levin  <levin@chromium.org>
2358
2359         Reviewed by Eric Seidel.
2360
2361         Errors should be separated from the command line in bot messages.
2362         https://bugs.webkit.org/show_bug.cgi?id=52275
2363
2364         * Scripts/webkitpy/common/system/executive.py:
2365         (ScriptError.message_with_output): Added a newline to separate the command
2366         line from the errors.
2367         * Scripts/webkitpy/common/system/executive_unittest.py:
2368         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2369         paths in message_with_output.
2370
2371 2011-01-11  Eric Seidel  <eric@webkit.org>
2372
2373         Unreviewed.
2374
2375         commit-queue should know how to upload archived results (for test flakes or general failures)
2376         https://bugs.webkit.org/show_bug.cgi?id=52048
2377
2378         The zips are mostly empty due to forgetting -r.
2379         Expected diffs were not being pulled from the archive due
2380         to the archive having longer paths than I realized.
2381
2382         * Scripts/webkitpy/common/system/workspace.py:
2383         * Scripts/webkitpy/common/system/workspace_unittest.py:
2384         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2385         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2386
2387 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2388
2389         Reviewed by Ojan Vafai.
2390
2391         The current modifier parsing code in test_expectations is
2392         fragile and hard-coded, so it's not easy to understand the logic
2393         or easily add new types of modifiers (like GPU vs. CPU testing
2394         for graphics tests, or 32-bit vs. 64-bit differences).
2395
2396         This is the first of two patches that will add in more generic
2397         support and then eliminate the GPU-specific test expectations
2398         files for Chromium.
2399
2400         This patch adds two standalone objects for handling modifiers. The
2401         rules for interpreting modifiers, precedence, and conflicts are
2402         given in the docstring to the ModifierMatcher class, which
2403         returns ModifierMatchResult objects.
2404         
2405         This patch also adds routines to the Port interface and a
2406         default set of values in the base object, in order to obtain the
2407         values needed on a given test run. These values are then passed
2408         to the expectation parser. This also allows us to clean up the
2409         logic used to lint all of the different configurations in a
2410         single test_expectations.txt file.
2411
2412         The next patch will merge in the separate GPU expectations file.
2413
2414         https://bugs.webkit.org/show_bug.cgi?id=51222
2415
2416         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2417         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2418         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2419         * Scripts/webkitpy/layout_tests/port/base.py:
2420         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2421         * Scripts/webkitpy/layout_tests/port/chromium.py:
2422         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2423         * Scripts/webkitpy/layout_tests/port/test.py:
2424         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2425         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2426
2427 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2428
2429         Reviewed by Adam Barth.
2430
2431         Make webkit-patch support subdirectories for SVN checkouts
2432         https://bugs.webkit.org/show_bug.cgi?id=52261
2433
2434         * Scripts/webkitpy/common/checkout/scm.py:
2435         * Scripts/webkitpy/style_references.py:
2436         * Scripts/webkitpy/tool/main.py:
2437         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2438
2439 2011-01-11  Eric Seidel  <eric@webkit.org>
2440
2441         Unreviewed.
2442
2443         commit-queue should know how to upload archived results (for test flakes or general failures)
2444         https://bugs.webkit.org/show_bug.cgi?id=52048
2445
2446         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2447         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2448
2449         * Scripts/webkitpy/common/system/workspace.py:
2450         * Scripts/webkitpy/common/system/workspace_unittest.py:
2451         * Scripts/webkitpy/tool/commands/queues.py:
2452
2453 2011-01-11  Sam Weinig  <sam@webkit.org>
2454
2455         Roll r75474 back in.
2456
2457 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2458
2459         Reviewed by Kenneth Rohde Christiansen.
2460
2461         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2462         https://bugs.webkit.org/show_bug.cgi?id=51204
2463
2464         * QtTestBrowser/webpage.h:
2465         (QtNAMThread::QtNAMThread):
2466         (QtNAMThread::networkAccessManager):
2467         (QtNAMThread::run):
2468
2469 2011-01-11  Peter Varga  <pvarga@webkit.org>
2470
2471         Unreviewed.
2472
2473         Add myself to committers' list.
2474
2475         * Scripts/webkitpy/common/config/committers.py:
2476
2477 2011-01-11  Eric Seidel  <eric@webkit.org>
2478
2479         Reviewed by Adam Barth.
2480
2481         commit-queue should know how to upload archived results (for test flakes or general failures)
2482         https://bugs.webkit.org/show_bug.cgi?id=52048
2483
2484         Now the queue will always upload results.  Either the entire zip, or just
2485         the diffs.txt in the case of text failures.
2486
2487         This should make understanding flakes much easier, and paves the way
2488         for having the EWS run layout tests (and upload failures).
2489
2490         In order to upload .zip files I had to teach bugzilla.py to autodetect
2491         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2492         for .patch files, I have it add one before calling guess_type.
2493
2494         We may find that always uploading the whole zip instead of just the -diffs.txt
2495         file is preferable, but for now I'm keeping the old behavior because it makes
2496         quickly understanding text failures easy.
2497
2498         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2499         * Scripts/webkitpy/common/system/workspace.py: Added.
2500         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2501         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2502         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2503         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2504         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2505         * Scripts/webkitpy/tool/commands/queues.py:
2506         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2507
2508 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2509
2510         Unreviewed, rolling out r75464.
2511         http://trac.webkit.org/changeset/75464
2512         https://bugs.webkit.org/show_bug.cgi?id=52193
2513
2514         Followup rollout for 75474 (Requested by Ossy on #webkit).
2515
2516         * MiniBrowser/mac/BrowserWindowController.m:
2517         (-[BrowserWindowController awakeFromNib]):
2518         * MiniBrowser/win/BrowserView.cpp:
2519         (BrowserView::create):
2520         * WebKitTestRunner/TestController.cpp:
2521         (WTR::createOtherPage):
2522         (WTR::TestController::initialize):
2523
2524 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2525
2526         Reviewed by Csaba Osztrogonác.
2527
2528         [Qt] Baseline qt_minimal configuration
2529         https://bugs.webkit.org/show_bug.cgi?id=51313
2530
2531         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2532         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2533         QT_NO_UNDOSTACK guard.
2534
2535         * QtTestBrowser/launcherwindow.cpp:
2536         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2537         guards.
2538         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2539         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2540         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2541         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2542
2543         * QtTestBrowser/launcherwindow.h:
2544         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2545         * QtTestBrowser/locationedit.h: Ditto.
2546
2547         * QtTestBrowser/mainwindow.cpp:
2548         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2549         QT_NO_UNDOSTACK guards.
2550         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2551         (MainWindow::changeLocation): Ditto.
2552         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2553         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2554
2555         * QtTestBrowser/webpage.cpp:
2556         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2557         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2558
2559         * QtTestBrowser/webview.cpp:
2560         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2561         (WebViewGraphicsBased::animatedYFlip): Ditto.
2562
2563 2011-01-10  Sam Weinig  <sam@webkit.org>
2564
2565         Fix build.
2566
2567         * MiniBrowser/mac/BrowserWindowController.m:
2568         (-[BrowserWindowController awakeFromNib]):
2569         * MiniBrowser/win/BrowserView.cpp:
2570         (BrowserView::create):
2571         * WebKitTestRunner/TestController.cpp:
2572         (WTR::createOtherPage):
2573         (WTR::TestController::initialize):
2574
2575 2011-01-10  Eric Seidel  <eric@webkit.org>
2576
2577         Reviewed by Ojan Vafai.
2578
2579         style-queue messages are way too long for big patches
2580         https://bugs.webkit.org/show_bug.cgi?id=52161
2581
2582         We definitely could build much fancier list-to-string-with-limit functions
2583         but this should be sufficient for our needs at the moment.
2584
2585         * Scripts/webkitpy/common/system/executive.py:
2586         * Scripts/webkitpy/common/system/executive_unittest.py:
2587
2588 2011-01-10  Tony Chang  <tony@chromium.org>
2589
2590         Unreviewed, rolling out r75398.
2591         http://trac.webkit.org/changeset/75398
2592         https://bugs.webkit.org/show_bug.cgi?id=52008
2593
2594         Some layout tests are crashing on Chromium Win.
2595
2596         * DumpRenderTree/chromium/WebViewHost.cpp:
2597         (WebViewHost::updatePaintRect):
2598         * DumpRenderTree/chromium/WebViewHost.h:
2599
2600 2011-01-10  Adam Roben  <aroben@apple.com>
2601
2602         Roll out r75392
2603
2604         It isn't needed now that r75289 has been rolled out.
2605
2606         * Scripts/run-javascriptcore-tests:
2607
2608 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2609
2610         Reviewed by Anders Carlsson.
2611
2612         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2613         https://bugs.webkit.org/show_bug.cgi?id=52160
2614
2615         * WebKitTestRunner/mac/TestControllerMac.mm:
2616         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2617         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2618         anyway.
2619
2620 2011-01-10  Tony Chang  <tony@chromium.org>
2621
2622         Reviewed by Mihai Parparita.
2623
2624         [chromium] fix for animated gif layout tests
2625         https://bugs.webkit.org/show_bug.cgi?id=52008
2626
2627         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2628             to trigger gif animations.
2629         (WebViewHostPaintTask::WebViewHostPaintTask):
2630         (WebViewHostPaintTask::runIfValid):
2631         (WebViewHost::updatePaintRect):
2632         * DumpRenderTree/chromium/WebViewHost.h:
2633         (WebViewHost::taskList):
2634
2635 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2636
2637         Reviewed by Xan Lopez.
2638
2639         [GTK] Fix gtk2 compilation for master
2640         https://bugs.webkit.org/show_bug.cgi?id=51885
2641
2642         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2643         (createBitmapContextFromWebView): Replaced the old
2644         gdk_drawable_get_size with gdk_pixmap_get_size.
2645
2646 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2647
2648         Reviewed by Laszlo Gombos.
2649
2650         [WINCE] Reenable NPAPI after r75203
2651         https://bugs.webkit.org/show_bug.cgi?id=52109
2652
2653         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2654         it with !isEfl(), because EFL port does not support NPAPI (yet).
2655
2656         * Scripts/build-webkit:
2657
2658 2011-01-10  Adam Roben  <aroben@apple.com>
2659
2660         Skip some asserting JS tests
2661
2662         See <http://webkit.org/b/52156>.
2663
2664         * Scripts/run-javascriptcore-tests:
2665
2666 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2667
2668         Reviewed by Xan Lopez.
2669
2670         [GTK] build-webkit disable Blob support via arguments passed to automake
2671         https://bugs.webkit.org/show_bug.cgi?id=52097
2672
2673         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2674         build-webkit.
2675
2676 2011-01-10  Adam Roben  <aroben@apple.com>
2677
2678         Use the same name and description for TestNetscapePlugin on Windows and
2679         Mac
2680
2681         Fixes <http://webkit.org/b/52151>
2682         fast/frames/iframe-reparenting-plugins.html fails on Windows
2683
2684         Reviewed by Steve Falkenburg.
2685
2686         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2687         the name and description from Mac's Info.plist.
2688
2689 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2690
2691         Reviewed by Laszlo Gombos.
2692
2693         [Qt][WK2] Guard gcc-specific syntax
2694
2695         Non-gcc based compliers choke on the "-include"
2696         syntax for preinclude, place guard around it.
2697
2698         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2699         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2700
2701 2011-01-10  Andreas Kling  <kling@webkit.org>
2702
2703         Reviewed by Simon Hausmann.
2704
2705         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2706         https://bugs.webkit.org/show_bug.cgi?id=52111
2707
2708         When getting a createNewPage() callback from QWKPage, create the
2709         new page with the same QWKContext as the page that is passed to
2710         the callback.
2711
2712         * MiniBrowser/qt/BrowserView.h:
2713         * MiniBrowser/qt/BrowserWindow.cpp:
2714         (newPageFunction):
2715         (BrowserWindow::BrowserWindow):
2716         * MiniBrowser/qt/BrowserWindow.h:
2717
2718 2011-01-10  Andreas Kling  <kling@webkit.org>
2719
2720         Reviewed by Kenneth Rohde Christiansen.
2721
2722         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2723
2724         BrowserView set its own useless createNewPage() callback on QWKPage.
2725         This was immediately overridden by BrowserWindow anyway, so remove
2726         the BrowserView one.
2727
2728         * MiniBrowser/qt/BrowserView.cpp:
2729         (BrowserView::BrowserView):
2730
2731 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2732
2733         Reviewed by Jeremy Orlow.
2734
2735         [Chromium] Remove non-client-based Geolocation code
2736         https://bugs.webkit.org/show_bug.cgi?id=50921
2737
2738         * DumpRenderTree/chromium/LayoutTestController.cpp:
2739         (LayoutTestController::setGeolocationPermission):
2740         (LayoutTestController::setMockGeolocationPosition):
2741         (LayoutTestController::setMockGeolocationError):
2742         * DumpRenderTree/chromium/WebViewHost.cpp:
2743         (WebViewHost::geolocationClientMock):
2744         (WebViewHost::reset):
2745         * DumpRenderTree/chromium/WebViewHost.h:
2746
2747 2011-01-10  Eric Seidel  <eric@webkit.org>
2748
2749         Reviewed by Adam Barth.
2750
2751         Commit bot tried to land r? cq+ patch
2752         https://bugs.webkit.org/show_bug.cgi?id=36638
2753
2754         It should now be possible to post a patch with r? and cq+ and the
2755         commit-queue will correctly wait for the r+ before attempting to land the patch.
2756         (This was a feature requested by several users.)
2757
2758         One caveat: We don't actually reject r-, cq+ patches from the queue
2759         (we just ignore them), but I think that's OK for now.
2760
2761         I also noticed that setting r- once a commit-queue node had grabbed
2762         a patch would not properly cancel the landing.  That's fixed and
2763         tested in this patch.
2764
2765         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2766         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2767         * Scripts/webkitpy/tool/bot/feeders.py:
2768         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2769
2770 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2771
2772         Reviewed by Kenneth Rohde Christiansen.
2773
2774         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2775         https://bugs.webkit.org/show_bug.cgi?id=51934
2776
2777         When accessing the network from the destructor of QWebPage, the network access manager
2778         was already deleted because the object WebPage was already destructed.
2779
2780         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2781         The object is now destructed in the destructor of QObject.
2782
2783         * QtTestBrowser/webpage.cpp:
2784         (WebPage::WebPage):
2785         (WebPage::setQnamThreaded):
2786         * QtTestBrowser/webpage.h:
2787         (QtNAMThread::QtNAMThread):
2788
2789 2011-01-08  Eric Seidel  <eric@webkit.org>
2790
2791         Reviewed by Ojan Vafai.
2792
2793         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2794         https://bugs.webkit.org/show_bug.cgi?id=52067
2795
2796         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2797         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2798
2799         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2800
2801 2011-01-08  Eric Seidel  <eric@webkit.org>
2802
2803         Reviewed by Mihai Parparita.
2804
2805         commit-queue hangs when the ChangeLog diff is bad
2806         https://bugs.webkit.org/show_bug.cgi?id=52072
2807
2808         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2809         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2810
2811 2011-01-08  Adam Barth  <abarth@webkit.org>
2812
2813         Teach svn-apply how to re-write WebCore to Source/WebCore.
2814
2815         * Scripts/VCSUtils.pm:
2816
2817 2011-01-07  Adam Barth  <abarth@webkit.org>
2818
2819         Rubber-stamped by Eric Seidel.
2820
2821         Move WebCore to Source
2822         https://bugs.webkit.org/show_bug.cgi?id=52050
2823
2824         Update the tools to understand WebCore's new location.
2825
2826         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2827         * DumpRenderTree/wscript:
2828         * GNUmakefile.am:
2829         * Scripts/build-webkit:
2830         * Scripts/do-file-rename:
2831         * Scripts/do-webcore-rename:
2832         * Scripts/generate-qt-inspector-resource:
2833         * Scripts/prepare-ChangeLog:
2834         * Scripts/run-bindings-tests:
2835         * Scripts/update-iexploder-cssproperties:
2836         * Scripts/update-sources-list.py:
2837         * Scripts/update-webkit-localizable-strings:
2838         * Scripts/webkitdirs.pm:
2839         * Scripts/webkitpy/common/config/build.py:
2840         * Scripts/webkitpy/common/config/build_unittest.py:
2841         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2842         * Scripts/webkitpy/style/checker.py:
2843         * Scripts/webkitpy/style/checker_unittest.py:
2844         * WebKitTestRunner/DerivedSources.pro:
2845         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2846         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2847         * wx/browser/wscript:
2848         * wx/build/settings.py:
2849
2850 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2851
2852         Reviewed by Sam Weinig.
2853
2854         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2855         https://bugs.webkit.org/show_bug.cgi?id=52086
2856
2857         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2858         (WTR::InjectedBundle::didReceiveMessage):
2859         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2860         (WTR::LayoutTestController::notifyDone):
2861         * WebKitTestRunner/TestController.cpp:
2862         (WTR::TestController::resetStateToConsistentValues):
2863         (WTR::TestController::run):
2864
2865 2011-01-07  James Robinson  <jamesr@chromium.org>
2866
2867         Revert "Implement mozilla's animationTime property"
2868         https://bugs.webkit.org/show_bug.cgi?id=51952
2869
2870         This approach isn't quite right.
2871
2872         * DumpRenderTree/chromium/WebViewHost.cpp:
2873         (WebViewHost::paintInvalidatedRegion):
2874
2875 2011-01-07  Adam Roben  <aroben@apple.com>
2876
2877         Build master fix
2878
2879         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2880         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2881
2882 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2883
2884         Reviewed by Csaba Osztrogonác.
2885
2886         run-qtwebkit-tests should be able to kill a testsuite.
2887
2888         Add new option in the script that can setup a timeout for a test.
2889         If the test execution takes more then specified time then the test
2890         would be terminated.
2891
2892         [Qt] run-qtwebkit-tests needs timeout
2893         https://bugs.webkit.org/show_bug.cgi?id=51894
2894
2895         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2896         * Scripts/run-qtwebkit-tests:
2897
2898 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2899
2900         Unreviewed fix after r75233.
2901
2902         Based on idea from Eric Seidel.
2903
2904         Add remote zip file handling to webkitpy.
2905         https://bugs.webkit.org/show_bug.cgi?id=50901
2906
2907         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2908
2909 2011-01-07  Shane Stephens  <shanestephens@google.com>
2910
2911         Reviewed by Eric Seidel.
2912
2913         svn-apply: should support git binary delta diffs
2914         https://bugs.webkit.org/show_bug.cgi?id=38864
2915
2916         * Scripts/VCSUtils.pm:
2917         * Scripts/svn-apply:
2918
2919 2011-01-06  Julie Parent  <jparent@chromium.org>
2920
2921         Reviewed by Eric Seidel.
2922
2923         Test Result Server not removing old results.
2924         https://bugs.webkit.org/show_bug.cgi?id=52012
2925
2926         * TestResultServer/model/jsonresults.py:
2927         Fix off-by-one: Truncate if >= num_runs, not just >.
2928         * TestResultServer/model/jsonresults_unittest.py:
2929         Add unit test to test that merging in a new result with the same value
2930         as the last result causes previous result to fall off.
2931
2932 2011-01-06  James Kozianski  <koz@chromium.org>
2933
2934         Reviewed by Mihai Parparita.
2935
2936         Add classes to provide a consistent interface to a set of files.
2937         https://bugs.webkit.org/show_bug.cgi?id=50901
2938
2939         These classes allow us to write code that is agnostic to whether a
2940         particular set of files resides in a local directory or in a zip file
2941         on a remote machine.
2942
2943         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2944         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2945         * Scripts/webkitpy/common/system/fileset.py: Added.
2946         * Scripts/webkitpy/common/system/filesystem.py:
2947         * Scripts/webkitpy/common/system/filesystem_mock.py:
2948         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2949         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2950
2951 2011-01-06  Eric Seidel  <eric@webkit.org>
2952
2953         Reviewed by Adam Barth.
2954
2955         NetworkTransaction should log the url it is retrying
2956         https://bugs.webkit.org/show_bug.cgi?id=52043
2957
2958         * Scripts/webkitpy/common/net/networktransaction.py:
2959         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2960
2961 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2962
2963         Windows build fix.
2964         Import os before using it.
2965
2966         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2967
2968 2011-01-06  Eric Seidel  <eric@webkit.org>
2969
2970         Reviewed by Adam Barth.
2971
2972         StyleQueue fails to report errors when patches have many files
2973         https://bugs.webkit.org/show_bug.cgi?id=52042
2974
2975         This is one of at least two errors preventing style error reporting at the moment.
2976         When we moved to passing the list of files to check explicitly,
2977         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2978         We could change the type of the QueueStatus.message type, or we could
2979         just teach statusserver.py how to clamp values (and warn when it does).
2980         I chose the latter path.
2981
2982         * Scripts/webkitpy/common/net/statusserver.py:
2983
2984 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2985
2986         Reviewed by Stephanie Lewis.
2987         
2988         Fix syntax error in script.
2989
2990         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2991         https://bugs.webkit.org/show_bug.cgi?id=51996
2992
2993         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2994
2995 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2996
2997         Unreviewed, fixing WinCE build after r75196.
2998
2999         WinCE port does not (yet) support NPAPI.
3000
3001         * Scripts/build-webkit:
3002
3003 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3004
3005         Reviewed by Darin Adler.
3006
3007         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3008         https://bugs.webkit.org/show_bug.cgi?id=52015
3009
3010         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3011         after the platform has been detected, otherwise the script will
3012         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3013         detection.
3014
3015 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3016
3017         Reviewed by Eric Seidel.
3018
3019         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3020         https://bugs.webkit.org/show_bug.cgi?id=51346
3021
3022         * Scripts/build-webkit:
3023
3024 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3025
3026         Reviewed by Adam Roben.
3027
3028         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3029         https://bugs.webkit.org/show_bug.cgi?id=51996
3030         
3031         After the configuration directory change, we were archiving the incorrect directory for
3032         build product, so we were running tests on the wrong binaries.
3033         
3034         This change archives the correct directory, and also unarchives it into a configuration-
3035         specific directory.
3036
3037         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3038         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3039
3040 2011-01-06  Eric Seidel  <eric@webkit.org>
3041
3042         Reviewed by Mihai Parparita.
3043
3044         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3045         https://bugs.webkit.org/show_bug.cgi?id=52002
3046
3047         See an example of this here:
3048         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3049
3050         It's due to the fact that we pass around TestFailure() instance
3051         objects and yet expect them to all compare to be the same.
3052
3053         This is bad.  We should either have shared instances of these values
3054         or we should just pass around the class names.  There are already hacks
3055         in place to make TestFailure objects pass equality tests, I just added
3056         a __hash__ implementation so they can be used in sets as expected.
3057
3058         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3059         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3060
3061 2011-01-06  Evan Martin  <evan@chromium.org>
3062
3063         Reviewed by Tony Chang.
3064
3065         [gdb] handle inaccessible memory and UChar*
3066         https://bugs.webkit.org/show_bug.cgi?id=52003
3067
3068         To pretty-print a UChar*, we just grope around in the memory
3069         looking for a terminating NUL.  We need to handle the exception
3070         that can occur when we poke into an invalid location.
3071
3072         Additionally, the logic for choosing which pretty-printer would
3073         early return before hitting the point where we'd use the UChar*
3074         printer.  (Did this ever work?  How did it regress?)
3075
3076         * gdb/webkit.py:
3077
3078 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3079
3080         Reviewed by Ada Chan.
3081
3082         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3083         https://bugs.webkit.org/show_bug.cgi?id=51969
3084         
3085         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3086
3087         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3088         (WTR::InjectedBundlePage::InjectedBundlePage):
3089         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3090         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3091
3092 2011-01-06  James Robinson  <jamesr@chromium.org>
3093
3094         Reviewed by Simon Fraser.
3095
3096         Implement mozilla's animationTime property
3097         https://bugs.webkit.org/show_bug.cgi?id=51952
3098
3099         Chromium DRT support for webkitAnimationTime.
3100
3101         * DumpRenderTree/chromium/WebViewHost.cpp:
3102         (WebViewHost::paintInvalidatedRegion):
3103
3104 2011-01-06  Julie Parent  <jparent@chromium.org>
3105
3106         Reviewed by Tony Chang.
3107
3108         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3109         https://bugs.webkit.org/show_bug.cgi?id=51217
3110
3111         * TestResultServer/model/jsonresults.py:
3112         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3113         Adds missing documentation.
3114         * TestResultServer/model/jsonresults_unittest.py:
3115         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3116         Update test_merge to take a number of builds to truncate at.
3117
3118 2011-01-06  Adam Barth  <abarth@webkit.org>
3119
3120         Reviewed by Eric Seidel.
3121
3122         The EWS should log outside of the working directory
3123         https://bugs.webkit.org/show_bug.cgi?id=51986
3124
3125         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3126         script, which will actually clean the working copy back to a pristine
3127         state instead of leaving untracked directories and ignored files.
3128
3129         * Scripts/webkitpy/tool/commands/queues.py:
3130         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3131
3132 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3133
3134         Windows build fix.
3135         Back out attempted change to built-product-archive.
3136
3137         * BuildSlaveSupport/built-product-archive:
3138
3139 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3140
3141         Windows build fix.
3142         Include configuration name when unpacking a build archive.
3143
3144         Needed, since we split Windows build results into configuration-specific directories
3145         under WebKitOutputDir.
3146
3147         * BuildSlaveSupport/built-product-archive:
3148
3149 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3150
3151         Reviewed by Darin Adler.
3152
3153         Debug and Release builds on Windows clobber each other
3154         https://bugs.webkit.org/show_bug.cgi?id=49185
3155
3156         Changes the structure of WebKitBuild build products directory so we
3157         completely separate each build configuration into independent directories.
3158         
3159         Although we previously had per-configuration directories for obj, this change adds
3160         per-configuration directories for bin, lib, obj, and include. Each configuration's
3161         build products are stored within a directory inside of WebKitBuild.
3162         
3163         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3164         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3165
3166         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3167         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3168         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3169         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3170         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3171         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3172         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3173         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3174         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3175         * FindSafari/FindSafari.vcproj:
3176         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3177         * MiniBrowser/MiniBrowserPostBuild.cmd:
3178         * MiniBrowser/MiniBrowserPreBuild.cmd:
3179         * Scripts/webkitdirs.pm:
3180         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3181         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3182         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3183         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3184         * TestWebKitAPI/win/copy-resources.cmd:
3185         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3186         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3187         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3188         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3189         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3190         * WebKitTestRunner/win/InjectedBundle.vcproj:
3191         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3192         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3193         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3194         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3195         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3196         * WinLauncher/WinLauncherCommon.vsprops:
3197         * WinLauncher/WinLauncherPostBuild.cmd:
3198         * WinLauncher/WinLauncherPreBuild.cmd:
3199
3200 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3201
3202         Reviewed by Ariya Hidayat.
3203
3204         [Qt] TestNetscapePlugin doesn't link on OS X
3205         https://bugs.webkit.org/show_bug.cgi?id=51948
3206
3207         Only add a dependency on libX11 on X11 systems
3208
3209         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3210
3211 2011-01-05  Jeff Miller  <jeffm@apple.com>
3212
3213         Reviewed by Adam Roben.
3214
3215         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3216         https://bugs.webkit.org/show_bug.cgi?id=51970
3217
3218         * Scripts/webkitpy/style/checker.py:
3219         Add -readability/naming for WebKit2 C API directories.
3220
3221 2011-01-05  Eric Seidel  <eric@webkit.org>
3222
3223         Unreviewed, just fixing one more log error from my previous python patch.
3224
3225         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3226         https://bugs.webkit.org/show_bug.cgi?id=51802
3227
3228         webkit-patch failure-reason was logging about parsing errors
3229         due to my misunderstanding of how BeautifulSoup.findAll worked.
3230
3231         Fixed, and added a unit test.
3232
3233         * Scripts/webkitpy/common/net/layouttestresults.py:
3234         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3235
3236 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3237
3238         Reviewed by Kenneth Rohde Christiansen.
3239
3240         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3241         https://bugs.webkit.org/show_bug.cgi?id=51951
3242
3243         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3244         to create new window from WebKit.
3245
3246         * MiniBrowser/qt/BrowserWindow.cpp:
3247         (newPageFunction):
3248         (BrowserWindow::BrowserWindow):
3249         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3250         (BrowserWindow::newWindow):
3251         (BrowserWindow::updateUserAgentList):
3252         (BrowserWindow::showUserAgentDialog):
3253         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3254         define the type of the backing store used for new windows.
3255         * MiniBrowser/qt/main.cpp:
3256         (main):
3257
3258 2011-01-05  Eric Seidel  <eric@webkit.org>
3259
3260         Reviewed by Ojan Vafai.
3261
3262         commit-queue should report failure type when reporting flaky tests
3263         https://bugs.webkit.org/show_bug.cgi?id=51900
3264
3265         This patch was a ridiculous amount of plumbing.  In the end I like
3266         the NRWT-style TestResult class even less.  But now we're passing
3267         a list of TestResult objects from the queue to the FlakyTestReporter.
3268         Thus the FlakyTestReporter can more easily report what type of failure
3269         occurred.
3270
3271         In the process, I found that I was not alone in finding TestResult
3272         cumbersome to use.  A bunch of code was trying to create a TestResult
3273         object with default values.  However since the constructor didn't make
3274         this easy, some places were getting it wrong (including the TestResult unit test)!
3275         I've fixed the TestResult constructor to have default values for non-essential
3276         arguments.
3277
3278         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3279         * Scripts/webkitpy/common/net/layouttestresults.py:
3280         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3281         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3282         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3283         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3284         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3285         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3286         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3287         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3288         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3289         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3290         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3291         * Scripts/webkitpy/tool/commands/queues.py:
3292         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3293
3294 2011-01-05  Eric Seidel  <eric@webkit.org>
3295
3296         Unreviewed.
3297
3298         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3299         https://bugs.webkit.org/show_bug.cgi?id=51802
3300
3301         Add another unit test to cover a previously missing import.
3302
3303         * Scripts/webkitpy/common/net/layouttestresults.py:
3304         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3305
3306 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3307
3308         Reviewed by David Levin.
3309
3310         Add mihaip@chromium.org as a reviewer
3311         https://bugs.webkit.org/show_bug.cgi?id=51966
3312         
3313         Add myself as a reviewer.
3314
3315         * Scripts/webkitpy/common/config/committers.py:
3316
3317 2011-01-05  James Simonsen  <simonjam@chromium.org>
3318
3319         Unreviewed. Adding myself to the list of committers.
3320
3321         * Scripts/webkitpy/common/config/committers.py:
3322
3323 2011-01-05  Eric Seidel  <eric@webkit.org>
3324
3325         Unreviewed.
3326
3327         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3328         https://bugs.webkit.org/show_bug.cgi?id=51802
3329
3330         Fix two exceptions seen on the bots after my original commit.
3331
3332         * Scripts/webkitpy/common/net/layouttestresults.py:
3333         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3334
3335 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3336
3337         Reviewed by Andreas Kling.
3338
3339         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3340         https://bugs.webkit.org/show_bug.cgi?id=51750
3341
3342         * QtTestBrowser/main.cpp:
3343         (LauncherApplication::handleUserOptions):
3344          Local storage settings can be enable form command line arguments for
3345          QtTestBrowser.
3346
3347 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3348
3349         Reviewed by Martin Robinson.
3350
3351         GTK: AX: DRT needs to use correct root object method.
3352         https://bugs.webkit.org/show_bug.cgi?id=51911
3353
3354         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3355         (AccessibilityController::rootElement):
3356
3357 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3358
3359         Rubber-stamped by Csaba Osztrogonác.
3360
3361         Based on idea from Péter Gál.
3362
3363         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3364
3365 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3366
3367         Reviewed by Adam Barth.
3368
3369         sheriff-bot should be able to do multi-revision rollouts
3370         https://bugs.webkit.org/show_bug.cgi?id=51176
3371
3372         * Scripts/webkitpy/tool/bot/irc_command.py:
3373         * Scripts/webkitpy/tool/bot/sheriff.py:
3374         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3375
3376 2011-01-05  Eric Seidel  <eric@webkit.org>
3377
3378         Reviewed by Adam Barth.
3379
3380         queues.webkit.org should have per-bot status pages
3381         https://bugs.webkit.org/show_bug.cgi?id=51906
3382
3383         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3384         statuses from a single queue.  Now that we have many bots servicing
3385         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3386         you care about scroll off the end of the 15-message limit on the main page.
3387
3388         Eventually we should probably rename /queue-status to /queue or /queues,
3389         but that's fodder for another patch.
3390
3391         * QueueStatusServer/handlers/queuestatus.py:
3392         * QueueStatusServer/index.yaml:
3393         * QueueStatusServer/main.py:
3394         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3395          - This probably should use a custom filter instead of hard-coding
3396            the URL scheme here, but I couldn't figure out how to easily
3397            create such a filter.  Most filters work with "strings" so we can't
3398            pass the status object.  We could add a method to the status
3399            object and call that, but that seemed a bit strange too.
3400         * QueueStatusServer/templates/queuestatus.html:
3401
3402 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3403
3404         Unreviewed. Adding myself to the list of committers.
3405
3406         * Scripts/webkitpy/common/config/committers.py:
3407
3408 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3409
3410         Reviewed by David Levin.
3411
3412         check-webkit-style treated some macros with parentheses after #elif as function calls
3413         https://bugs.webkit.org/show_bug.cgi?id=51695
3414
3415         Ingore function call space checking in any preprocessor directives
3416         (things starting with #). Change search() to match() because 
3417         preprocessor directives are supposed to be in the beginning of lines.
3418
3419         * Scripts/webkitpy/style/checkers/cpp.py:
3420         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3421
3422 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3423
3424         Reviewed by Tony Chang.
3425
3426         Change the --multi-load test option to --stress-opt
3427         https://bugs.webkit.org/show_bug.cgi?id=50751
3428
3429         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3430         (runTest):
3431         (main):
3432         * DumpRenderTree/chromium/TestShell.cpp:
3433         (TestShell::TestShell):
3434         * DumpRenderTree/chromium/TestShell.h:
3435         (TestShell::stressOpt):
3436         (TestShell::setStressOpt):
3437         (TestShell::stressDeopt):
3438         (TestShell::setStressDeopt):
3439         (TestShell::javaScriptFlags):
3440         (TestShell::setJavaScriptFlags):
3441         * Scripts/webkitpy/layout_tests/port/chromium.py:
3442         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3443
3444 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3445
3446         Reviewed by Sam Weinig.
3447
3448         WK2: Support Accessibility
3449         https://bugs.webkit.org/show_bug.cgi?id=51859
3450
3451         Use rootObject() method to get top of accessibility tree.
3452
3453         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3454         (AccessibilityController::focusedElement):
3455         (AccessibilityController::rootElement):
3456
3457 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3458
3459         Reviewed by Darin Adler.
3460
3461         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3462         https://bugs.webkit.org/show_bug.cgi?id=51846
3463
3464         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3465         back to GRefPtr.
3466
3467 2011-01-04  Zhe Su  <suzhe@chromium.org>
3468
3469         Reviewed by Kenneth Russell.
3470
3471         Fix insertText, setMarkedText and unmarkText methods of
3472         TextInputController to call corresponding methods of WebKit::WebView
3473         rather than WebKit::WebFrame. This change matches the behavior of
3474         chromium browser.
3475         insertText corresponds to WebView::confirmComposition(text)
3476         setMarkedText corresponds to WebView::setComposition(...)
3477         unmarkText corresponds to WebView::confirmComposition()
3478         https://bugs.webkit.org/show_bug.cgi?id=51693
3479
3480         * DumpRenderTree/chromium/TextInputController.cpp:
3481         (TextInputController::insertText):
3482         (TextInputController::setMarkedText):
3483         (TextInputController::unmarkText):
3484
3485 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3486
3487         Reviewed by Laszlo Gombos.
3488
3489         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3490
3491         On Symbian productDir points to the source directory. Removing all the
3492         empty files from the productDir directory corrupts the svn repository.
3493
3494         * Scripts/build-webkit:
3495
3496 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3497
3498         Reviewed by Adam Barth.
3499
3500         [Qt] Add SelectAll option to the context menu for the editor
3501         https://bugs.webkit.org/show_bug.cgi?id=50049
3502
3503         Set shortcut for the SelectAll action.
3504
3505         * QtTestBrowser/mainwindow.cpp:
3506         (MainWindow::buildUI):
3507
3508 2011-01-03  David Levin  <levin@chromium.org>
3509
3510         Reviewed by Eric Seidel.
3511
3512         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3513         https://bugs.webkit.org/show_bug.cgi?id=51842
3514
3515         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3516         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3517
3518 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3519
3520         Reviewed by David Kilzer.
3521
3522         [WINCE] Adds a build slave.
3523         https://bugs.webkit.org/show_bug.cgi?id=50523
3524
3525         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
3526         entry for a release build of the WinCE port.
3527         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
3528         flag to build the WinCE port.
3529
3530 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3531
3532         Reviewed by David Kilzer.
3533
3534         Add WinCE support to build-webkit
3535         https://bugs.webkit.org/show_bug.cgi?id=51642
3536
3537         * Scripts/build-webkit:
3538         * Scripts/webkitdirs.pm:
3539
3540 2011-01-03  Eric Seidel  <eric@webkit.org>
3541
3542         Reviewed by Adam Barth.
3543
3544         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3545         https://bugs.webkit.org/show_bug.cgi?id=51802
3546
3547         I'm not the biggest fan of the test_failures or test_results classes,
3548         but it's better to have one shared set of classes, than separate ones
3549         for new vs. old run-webkit-test result handling.
3550
3551         This moves the ORWT results class "LayoutTestResults" over to using
3552         TestResult and TestFailure classes, making it easy for us to
3553         make all our sheriff-bot and other webkitpy code NRWT ready.
3554
3555         This also makes it a trivial patch to generate results.json information
3556         from ORWT results.html files (for flaky test analysis, etc.) as well
3557         as making it a one-liner to report test failure types when the
3558         commit-queue sees flaky tests.
3559
3560         This patch tried not to add new functionality, but only to replace
3561         the guts of LayoutTestResults, while adding unit tests and hoping
3562         not to break anything.
3563
3564         I also moved callers which assumed User.prompt* were static/class methods
3565         to using them as instance methods (since we'll eventually want to make them such).
3566
3567         In the process of re-writing things, I broke the rebaseline command, so I wrote
3568         a unit test to catch my breakage were I do do so again in the future.
3569
3570         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3571         * Scripts/webkitpy/common/net/layouttestresults.py:
3572         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3573         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3574         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3575         * Scripts/webkitpy/tool/commands/queries.py:
3576         * Scripts/webkitpy/tool/commands/rebaseline.py:
3577         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3578         * Scripts/webkitpy/tool/mocktool.py:
3579
3580 2011-01-03  Adam Barth  <abarth@webkit.org>
3581
3582         Reviewed by Simon Fraser.
3583
3584         webkit-patch shouldn't waste time cleaning a working directory that's already clean
3585         https://bugs.webkit.org/show_bug.cgi?id=51840
3586
3587         * Scripts/webkitpy/common/checkout/scm.py:
3588
3589 2011-01-03  Adam Barth  <abarth@webkit.org>
3590
3591         Reviewed by Simon Fraser.
3592
3593         webkit-patch should only hide update output if --quiet
3594         https://bugs.webkit.org/show_bug.cgi?id=51838
3595
3596         As requested by smfr.
3597
3598         * Scripts/webkitpy/tool/steps/update.py:
3599
3600 2011-01-03  Adam Barth  <abarth@webkit.org>
3601
3602         Reviewed by David Levin.
3603
3604         commit-queue shouldn't reject patches twice if two bots process the same patch
3605         https://bugs.webkit.org/show_bug.cgi?id=51805
3606
3607         Before raising an error, we first check whether the patch is still in
3608         the commit-queue.  This check is still racy, of course, but the time
3609         window is much smaller.
3610
3611         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3612
3613 2011-01-03  Sam Weinig  <sam@webkit.org>
3614
3615         Reviewed by Anders Carlsson.
3616
3617         Make run-api-tests less chatty.
3618         https://bugs.webkit.org/show_bug.cgi?id=51831
3619
3620         - Make script quiet by default and add --verbose option (replacing --quiet).
3621         - When not verbose, pipe stdout and stderr to devnull.
3622
3623         * Scripts/run-api-tests:
3624
3625 2011-01-03  Pratik Solanki  <psolanki@apple.com>
3626
3627         Unreviewed. Adding myself to committers.py.
3628
3629         * Scripts/webkitpy/common/config/committers.py:
3630
3631 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
3632
3633         Reviewed by Xan Lopez.
3634
3635         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
3636         https://bugs.webkit.org/show_bug.cgi?id=51806
3637
3638         Originally, the $libraryName is 'JavaScriptCore'. When building release 
3639         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
3640         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
3641         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
3642         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
3643         so make it 'WebKitBuild/Release/.libs'
3644
3645         * Scripts/webkitdirs.pm: 
3646
3647 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
3648
3649         Reviewed by Adam Barth.
3650
3651         Make EFL a core builder
3652         https://bugs.webkit.org/show_bug.cgi?id=51804
3653
3654         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3655         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3656
3657 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3658
3659         [Qt] Unreviewed fix after r74855 and r74875.
3660
3661         * BuildSlaveSupport/built-product-archive:
3662          - Create directories explicitly.
3663          - Pass shell=True to subprocess.call().
3664
3665 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3666
3667         [Qt] Unreviewed fix after r74855.
3668
3669         Move JavaScriptCore to Source
3670         https://bugs.webkit.org/show_bug.cgi?id=51604
3671
3672         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
3673
3674 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3675
3676         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
3677
3678         Move JavaScriptCore to Source
3679         https://bugs.webkit.org/show_bug.cgi?id=51604
3680
3681         * Scripts/webkitdirs.pm:
3682
3683 2011-01-02  Robert Hogan  <robert@webkit.org>
3684
3685         Unreviewed, build fix.
3686
3687         [Qt] Fix DRT build after 74855
3688
3689         * DumpRenderTree/qt/DumpRenderTree.pro:
3690
3691 2011-01-01  Adam Barth  <abarth@webkit.org>
3692
3693         Remove the assumption from the Qt and Gtk builds that every project is
3694         in the root directory.
3695
3696         * Scripts/build-webkit:
3697
3698 2011-01-01  Adam Barth  <abarth@webkit.org>
3699
3700         Reviewed by Eric Seidel.
3701
3702         Teach svn-apply how to apply patches even though JavaScriptCore has moved
3703         https://bugs.webkit.org/show_bug.cgi?id=51796
3704
3705         After this change, svn-apply will magically apply patches to
3706         JavaScriptCore/foo to Source/JavaScriptCore/foo.
3707
3708         * Scripts/VCSUtils.pm:
3709
3710 2011-01-01  Adam Barth  <abarth@webkit.org>
3711
3712         Reviewed by Eric Seidel.
3713
3714         Move JavaScriptCore to Source
3715         https://bugs.webkit.org/show_bug.cgi?id=51604
3716
3717         Update references to JavaScriptCore to point to the new location.
3718
3719         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3720         * DumpRenderTree/qt/DumpRenderTree.pro:
3721         * DumpRenderTree/qt/ImageDiff.pro:
3722         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3723         * DumpRenderTree/wscript:
3724         * Scripts/build-jsc:
3725         * Scripts/build-webkit:
3726         * Scripts/do-file-rename:
3727         * Scripts/do-webcore-rename:
3728         * Scripts/run-javascriptcore-tests:
3729         * Scripts/update-javascriptcore-test-results:
3730         * Scripts/webkitdirs.pm:
3731         * Scripts/webkitpy/common/config/build_unittest.py:
3732         * Scripts/webkitpy/style/checker.py:
3733         * Scripts/webkitpy/style/checker_unittest.py:
3734         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3735         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3736         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3737         * wx/build/settings.py:
3738
3739 2011-01-01  Adam Barth  <abarth@webkit.org>
3740
3741         Reviewed by Eric Seidel.
3742
3743         Move Sources to Source
3744         https://bugs.webkit.org/show_bug.cgi?id=51794
3745
3746         Update scripts to point to the new location.
3747
3748         * Scripts/build-webkit:
3749         * Scripts/do-file-rename:
3750         * Scripts/do-webcore-rename:
3751         * Scripts/webkitpy/common/config/build.py:
3752         * Scripts/webkitpy/common/config/build_unittest.py:
3753
3754 2010-12-31  Kent Tamura  <tkent@chromium.org>
3755
3756         Reviewed by Eric Seidel.
3757
3758         [DRT/Chromium] Enable mock spell checker on non-OSX
3759         https://bugs.webkit.org/show_bug.cgi?id=51401
3760
3761         * DumpRenderTree/chromium/WebViewHost.cpp:
3762         (WebViewHost::spellCheck):
3763
3764 2010-12-31  Adam Barth  <abarth@webkit.org>
3765
3766         Reviewed by Ariya Hidayat.
3767
3768         Remove Tools/Scripts/wkstyle
3769         https://bugs.webkit.org/show_bug.cgi?id=51774
3770
3771         This script appears to not have been touched in a while and seems to
3772         have been replaced by check-webkit-style.
3773
3774         * Scripts/wkstyle: Removed.
3775
3776 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3777
3778         Unreviewed. Coding style fix.
3779
3780         * DumpRenderTree/chromium/TestShell.h:
3781
3782 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3783
3784         Reviewed by Pavel Feldman.
3785
3786         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
3787
3788         It was a problem with Chromium DRT. DevToolsAgent object instance was
3789         attached not only to the inspected page but to the DevTools window too.
3790         As result all the inspector files were interpreted as a content of inspected page
3791         and were transfered to the DevTools scripts panel for debugging etc.
3792
3793         https://bugs.webkit.org/show_bug.cgi?id=51735
3794