2011-03-30 Maciej Stachowiak <mjs@apple.com>
[WebKit.git] / Tools / ChangeLog
1 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Adam Barth.
4
5         make webkit-patch upload respect -d
6         https://bugs.webkit.org/show_bug.cgi?id=57425
7
8         * Scripts/webkitpy/common/checkout/scm.py:
9         * Scripts/webkitpy/tool/steps/commit.py:
10
11 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
12
13         Reviewed by Adam Barth.
14
15         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
16         https://bugs.webkit.org/show_bug.cgi?id=57429
17
18         * Scripts/webkitpy/common/checkout/scm.py:
19
20 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
21
22         Unreviewed, rolling out r82383.
23         http://trac.webkit.org/changeset/82383
24         https://bugs.webkit.org/show_bug.cgi?id=57417
25
26         "nrwt isn't shutting down cleanly" (Requested by dpranke on
27         #webkit).
28
29         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
30         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
31         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
32
33 2011-03-29  Kent Tamura  <tkent@chromium.org>
34
35         Reviewed by Dimitri Glazkov.
36
37         Make validation message bubble testable
38         https://bugs.webkit.org/show_bug.cgi?id=57290
39
40         * DumpRenderTree/mac/DumpRenderTree.mm:
41         (createWebViewAndOffscreenWindow): Change a setting so that validation
42           bubbles isn't hidden automatically.
43
44 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
45
46         Reviewed by Ojan Vafai.
47
48         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
49
50         It's a bit unclear whether multiple threads or multiple
51         processes will be a better model on windows. This change will
52         test threads for now while we're still working out the bugs in
53         multiple-processes.
54
55         https://bugs.webkit.org/show_bug.cgi?id=57410
56
57         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
58         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
59         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
60
61 2011-03-29  David Levin  <levin@chromium.org>
62
63         Reviewed by Shinichiro Hamaji.
64
65         check-webkit-style confused by two ChangeLog entries in a row from same user
66         https://bugs.webkit.org/show_bug.cgi?id=57250
67
68         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
69         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
70         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
71           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
72           checking more than that would be very messey.
73         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
74         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
75
76 2011-03-29  Kent Tamura  <tkent@chromium.org>
77
78         Reviewed by Dimitri Glazkov.
79
80         [Mac] Enable interactive-validation tests on Mac DRT
81         https://bugs.webkit.org/show_bug.cgi?id=57308
82
83         * DumpRenderTree/mac/DumpRenderTree.mm:
84         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
85
86 2011-03-29  Chang Shu  <cshu@webkit.org>
87
88         Reviewed by Kenneth Rohde Christiansen.
89
90         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
91         https://bugs.webkit.org/show_bug.cgi?id=42692
92
93         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
94         (WTR::InjectedBundle::beginTesting):
95         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
96         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
97         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
98
99 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
100
101         Reviewed by Xan Lopez.
102
103         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
104         https://bugs.webkit.org/show_bug.cgi?id=57067
105
106         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
107         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
108         update DRT and pixel results as hundreds of results will need to be updated.
109
110         * DumpRenderTree/gtk/DumpRenderTree.cpp:
111         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
112         by overriding the theme RC/CSS files.
113
114 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
115
116         Reviewed by Adam Roben.
117
118         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
119         https://bugs.webkit.org/show_bug.cgi?id=57394
120
121         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
122         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
123         the IDE. To avoid this, add a separate vsprops file for each project configuration that
124         contains the required inherited property sheets.
125
126         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
127         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
128         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
129         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
130         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
131         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
132         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
133         * DumpRenderTree/win/DumpRenderTree.vcproj:
134         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
135         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
136         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
137         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
138         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
139         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
140         * DumpRenderTree/win/ImageDiff.vcproj:
141         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
142         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
143         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
144         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
145         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
146         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
147         * FindSafari/FindSafari.vcproj:
148         * FindSafari/FindSafariDebug.vsprops: Added.
149         * FindSafari/FindSafariDebugAll.vsprops: Added.
150         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
151         * FindSafari/FindSafariRelease.vsprops: Added.
152         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
153         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
154         * FindSafari/FindSafariReleasePGO.vsprops: Added.
155         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
156         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
157         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
158         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
159         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
160         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
161         * MiniBrowser/MiniBrowser.vcproj:
162         * WebKitAPITest/WebKitAPITest.vcproj:
163         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
164         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
165         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
166         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
167         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
168         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
169         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
170         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
171         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
172         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
173         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
174         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
175         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
176         * WebKitTestRunner/win/InjectedBundle.vcproj:
177         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
178         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
179         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
180         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
181         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
182         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
183         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
184         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
185         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
186         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
187         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
188         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
189         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
190         * WinLauncher/WinLauncher.vcproj:
191         * WinLauncher/WinLauncherDebug.vsprops: Added.
192         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
193         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
194         * WinLauncher/WinLauncherRelease.vsprops: Added.
195         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
196         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
197         * record-memory-win/record-memory-win.vcproj:
198         * record-memory-win/record-memory-winDebug.vsprops: Added.
199         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
200         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
201         * record-memory-win/record-memory-winRelease.vsprops: Added.
202         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
203         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
204
205 2011-03-29  Adam Barth  <abarth@webkit.org>
206
207         Reviewed by Darin Adler.
208
209         test_runner2.py can crash due to undefined variable
210         https://bugs.webkit.org/show_bug.cgi?id=57356
211
212         Replace reference to undefined variable with a variable that's actually
213         defined.  AFAICT, there's no way to test this code.
214
215         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
216
217 2011-03-29  Tony Chang  <tony@chromium.org>
218
219         Reviewed by Eric Seidel.
220
221         cleanup rebaseline-chromium-webkit-tests
222         https://bugs.webkit.org/show_bug.cgi?id=57375
223
224         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
225             - Split _extract_and_add_new_baselines into 3 functions
226             - Reduce the amount of line wrapping (the file already has lines
227               over 80 col, so may as well try to make the file consistent)
228             - Remove unnecessary ()s
229
230 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
231
232         Reviewed by Adam Roben.
233
234         Make WinCairo a core builder.
235         https://bugs.webkit.org/show_bug.cgi?id=57373
236
237         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
238         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
239
240 2011-03-29  Timothy Hatcher  <timothy@apple.com>
241
242         Update update-webkit-localizable-strings to understand that WebKit and
243         WebKit2 strings go in WebCore.
244
245         Also make extract-localizable-strings optionally use an exclude file. No individual
246         warnings are produced about unlocalized strings when there is no exclude file. This
247         is needed for WebCore, since there are too many bare strings.
248
249         https://webkit.org/b/57354
250
251         Reviewed by Sam Weinig.
252
253         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
254         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
255
256 2011-03-29  Darin Adler  <darin@apple.com>
257
258         Reviewed by Adam Roben.
259
260         WebKit2 bundle page needs to offer generated file hooks
261         https://bugs.webkit.org/show_bug.cgi?id=57279
262
263         (Land missing part of the original patch after r82289.)
264
265         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
266         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
267
268 2011-03-29  Tony Chang  <tony@chromium.org>
269
270         Reviewed by Ojan Vafai.
271
272         [chromium] NRWT should be able to read checksums from png comments
273         https://bugs.webkit.org/show_bug.cgi?id=57280
274
275         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
276             from a file.
277         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
278         * Scripts/webkitpy/common/system/filesystem_mock.py:
279         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
280             if the -checksum.txt file doesn't exist, try looking in the png.
281         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
282         * Scripts/webkitpy/layout_tests/port/test.py:
283         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
284             2k for a png comment with the checksum
285         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
286
287 2011-03-29  Philippe Normand  <pnormand@igalia.com>
288
289         Rubber-stamped by Gustavo Noronha Silva.
290
291         [GTK] http/tests/uri/username-with-no-hostname.html fails
292         https://bugs.webkit.org/show_bug.cgi?id=57325
293
294         * DumpRenderTree/gtk/DumpRenderTree.cpp:
295         (willSendRequestCallback): URI host value check done case-insensitively.
296
297 2011-03-29  Philippe Normand  <pnormand@igalia.com>
298
299         Reviewed by Martin Robinson.
300
301         [GTK] http/tests/uri/username-with-no-hostname.html fails
302         https://bugs.webkit.org/show_bug.cgi?id=57325
303
304         * DumpRenderTree/gtk/DumpRenderTree.cpp:
305         (willSendRequestCallback): Check URI before submitting the request
306         to WebCore.
307
308 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
309
310         Reviewed by Ojan Vafai.
311
312         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
313         https://bugs.webkit.org/show_bug.cgi?id=57303
314
315         * DumpRenderTree/chromium/EventSender.cpp:
316         (EventSender::doDragDrop):
317         (EventSender::beginDragWithFiles):
318
319 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
320
321         Reviewed by Andreas Kling.
322
323         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
324         https://bugs.webkit.org/show_bug.cgi?id=57314
325
326         Provide possibility to print loaded urls to the standard output.
327
328         * MiniBrowser/qt/BrowserWindow.cpp:
329         (BrowserWindow::BrowserWindow):
330         (BrowserWindow::printURL):
331         * MiniBrowser/qt/BrowserWindow.h:
332         * MiniBrowser/qt/MiniBrowserApplication.cpp:
333         (MiniBrowserApplication::handleUserOptions):
334         * MiniBrowser/qt/MiniBrowserApplication.h:
335         (WindowOptions::WindowOptions):
336         * QtTestBrowser/launcherwindow.cpp:
337         (LauncherWindow::initializeView):
338         (LauncherWindow::printURL):
339         (LauncherWindow::cloneWindow):
340         * QtTestBrowser/launcherwindow.h:
341         (WindowOptions::WindowOptions):
342         * QtTestBrowser/main.cpp:
343         (LauncherApplication::handleUserOptions):
344
345 2011-03-29  Gabor Loki  <loki@webkit.org>
346
347         Rubber-stamped by Csaba Osztrogonác.
348
349         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
350         https://bugs.webkit.org/show_bug.cgi?id=56918
351
352         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
353
354 2011-03-28  Gabor Loki  <loki@webkit.org>
355
356         Reviewed by Csaba Osztrogonác.
357
358         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
359         https://bugs.webkit.org/show_bug.cgi?id=56918
360
361         * Scripts/build-jsc:
362         * Scripts/webkitdirs.pm:
363
364 2011-03-28  Andrew Foster  <andrewf@chromium.org>
365
366         Reviewed by Ojan Vafai.
367
368         webkit-patch should be more intelligent about whether a bug applies to a patch
369         Create a new function, parse_bug_id_from_changelog() which determines
370         that a bug is related to a patch by parsing the output generated from
371         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
372         the description of a patch.
373         https://bugs.webkit.org/show_bug.cgi?id=56989
374
375         * Scripts/webkitpy/common/checkout/api.py:
376         * Scripts/webkitpy/common/checkout/changelog.py:
377         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
378         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
379         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
380         * Scripts/webkitpy/style/checkers/changelog.py:
381         * Scripts/webkitpy/tool/commands/upload.py:
382
383 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
384
385         Revert accidentally commited change.
386
387         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
388         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
389
390 2011-03-28  Tony Chang  <tony@chromium.org>
391
392         Reviewed by Adam Barth.
393
394         [chromium] have DRT write the png checksum into a png comment
395         https://bugs.webkit.org/show_bug.cgi?id=57255
396
397         * DumpRenderTree/chromium/TestShell.cpp:
398         (TestShell::dumpImage):
399
400 2011-03-28  Adele Peterson  <adele@apple.com>
401
402         Removing Qt stub, since it doesn't use the same header as the others.
403
404         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
405
406 2011-03-28  Adele Peterson  <adele@apple.com>
407
408         Added a few more stubs.
409
410         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
411         (LayoutTestController::hasGrammarMarker):
412         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
413         (LayoutTestController::hasGrammarMarker):
414         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
415         (LayoutTestController::hasGrammarMarker):
416
417 2011-03-28  Adele Peterson  <adele@apple.com>
418
419         Build fix.
420
421         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
422         (LayoutTestController::hasGrammarMarker):
423
424 2011-03-28  Adele Peterson  <adele@apple.com>
425
426         Reviewed by Eric Seidel.
427
428         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
429         https://bugs.webkit.org/show_bug.cgi?id=57173
430
431         * DumpRenderTree/LayoutTestController.cpp:
432         (hasGrammarMarkerCallback): Added.
433         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
434         * DumpRenderTree/LayoutTestController.h:
435         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
436         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
437
438 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
439
440         Reviewed by Benjamin Poulain.
441
442         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
443         https://bugs.webkit.org/show_bug.cgi?id=57087
444
445         Trivial typo fix after r82082.
446
447         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
448         (WTR::activateFonts):
449
450 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
451
452         Reviewed by Andreas Kling.
453
454         Add myself to the committers list.
455
456         * Scripts/webkitpy/common/config/committers.py:
457
458 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
459
460         Reviewed by Sam Weinig.
461
462         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
463         to link against WebKit.framework for now.
464
465         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
466
467 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
468
469         Reviewed by Andreas Kling.
470
471         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
472         https://bugs.webkit.org/show_bug.cgi?id=57087
473
474         Disable QT_ASCII_CAST_WARNINGS for applications.
475
476         * DumpRenderTree/qt/DumpRenderTree.pro:
477         * DumpRenderTree/qt/ImageDiff.pro:
478         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
479         * MiniBrowser/qt/MiniBrowser.pro:
480         * QtTestBrowser/QtTestBrowser.pro:
481         * WebKitTestRunner/qt/WebKitTestRunner.pro:
482
483 2011-03-28  Andreas Kling  <kling@webkit.org>
484
485         Reviewed by Kenneth Rohde Christiansen.
486
487         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
488         https://bugs.webkit.org/show_bug.cgi?id=57224
489
490         * QtTestBrowser/mainwindow.cpp:
491         (MainWindow::buildUI):
492         (MainWindow::onTitleChanged):
493         * QtTestBrowser/mainwindow.h:
494
495 2011-03-27  Jer Noble  <jer.noble@apple.com>
496
497         Reviewed by Maciej Stachowiak.
498
499         Full Screen: disable keyboard access by default
500         https://bugs.webkit.org/show_bug.cgi?id=56684
501
502         Accept the withKeyboard parameter to supportsFullScreenForElement.
503
504         * DumpRenderTree/mac/UIDelegate.mm:
505         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
506
507 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
508
509         Reviewed by David Levin.
510
511         check-webkit-style should check ChangeLog for a valid bug number
512         https://bugs.webkit.org/show_bug.cgi?id=57184
513
514         * Scripts/webkitpy/style/checker.py:
515         * Scripts/webkitpy/style/checker_unittest.py:
516         * Scripts/webkitpy/style/checkers/changelog.py: Added.
517         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
518
519 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
520
521         Reviewed by Andreas Kling.
522
523         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
524         https://bugs.webkit.org/show_bug.cgi?id=57087
525
526         Use explicit conversion for string to avoid depending on the default codec
527         installed by the user code.
528
529         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
530         (WTR::activateFonts):
531
532 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
533
534         Revert inadvertantly committed changes.
535
536         * Scripts/old-run-webkit-tests:
537         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
538
539 2011-03-26  Andreas Kling  <kling@webkit.org>
540
541         Reviewed by Kenneth Rohde Christiansen.
542
543         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
544         https://bugs.webkit.org/show_bug.cgi?id=57162
545
546         * QtTestBrowser/QtTestBrowser.qrc:
547         * QtTestBrowser/favicon.png: Added.
548         * QtTestBrowser/locationedit.cpp:
549         (defaultPageIcon):
550         (LocationEdit::LocationEdit):
551         (LocationEdit::setPageIcon):
552         (LocationEdit::resizeEvent):
553         (LocationEdit::updateInternalGeometry):
554         * QtTestBrowser/locationedit.h:
555         * QtTestBrowser/mainwindow.cpp:
556         (MainWindow::buildUI):
557         (MainWindow::onIconChanged):
558         (MainWindow::onLoadStarted):
559         * QtTestBrowser/mainwindow.h:
560
561 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
562
563         Reviewed by Xan Lopez.
564
565         [GTK] Force DumpRenderTree to use 96 DPI
566         https://bugs.webkit.org/show_bug.cgi?id=56866
567
568         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
569         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
570
571         * DumpRenderTree/gtk/DumpRenderTree.cpp:
572         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
573         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
574         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
575
576 2011-03-25  Andy Estes  <aestes@apple.com>
577
578         Reviewed by Adele Peterson.
579
580         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
581         https://bugs.webkit.org/show_bug.cgi?id=49016
582
583         TestNetscapePlugIn needs to register support for an image MIME type so
584         we can test that the embed tag prefers plug-ins to render image MIME
585         types.
586
587         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
588         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
589         (NP_GetMIMEDescription): Ditto.
590         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
591
592 2011-03-25  Jessie Berlin  <jberlin@apple.com>
593
594         Reviewed by Sam Weinig.
595
596         WebKit2: Need to be able to set and get the Cookie Storage Policy.
597         https://bugs.webkit.org/show_bug.cgi?id=50780
598
599         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
600
601         The test is named "CookieManager" so that we can eventually exercise more of the
602         CookieManager functionality in the test.
603
604         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
605         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
606         Assert that the policy returned is equal to the policy set in
607         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
608         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
609         Set the policy to something different than the user's policy and get the policy again.
610         (TestWebKitAPI::didFinishLoadForFrame):
611         Get the user's policy so that it can be restored at the end of the test.
612         (TestWebKitAPI::TEST):
613         Load about:blank so that the Web Process gets instatiated (needed to get the
614         CookieManager).
615
616         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
617         Add CookieManager.cpp.
618
619 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
620
621         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
622
623         * wx/build/settings.py:
624
625 2011-03-24  Ilya Sherman  <isherman@chromium.org>
626
627         Reviewed by Adam Roben.
628
629         Implement layoutTestController.setAutoFilled in DRT on Windows
630         https://bugs.webkit.org/show_bug.cgi?id=56828
631
632         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
633         (LayoutTestController::setAutofilled): Implemented.
634
635 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
636
637         Unreviewed build correction.
638
639         Correct vsprops file for Debug variant of the CFLite build.
640         Disable a CFNETWORK-specific test when building for CFLite.
641
642         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
643         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
644
645 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
646
647         Reviewed by Adam Barth.
648
649         fix regressions introduced in 81908 - there were a couple of
650         code paths that only fired under python 2.5 that I missed.
651
652         Also change a couple of 'python' references to sys.executable
653         in order to handle runing test-webkitpy with a binary other than
654         something called 'python'.
655
656         https://bugs.webkit.org/show_bug.cgi?id=57063
657
658         * Scripts/webkitpy/layout_tests/port/mac.py:
659         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
660         * Scripts/webkitpy/test/cat.py:
661         * Scripts/webkitpy/test/echo.py:
662
663 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
664
665         Unreviewed build correction.
666
667         Add a stub implementation of the TestInvocation dumping logic.
668         Update project files to reflect new file.
669
670         * WebKitTestRunner/cairo: Added.
671         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
672         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
673         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
674
675 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
676
677         Reviewed by Tony Chang.
678
679         new-run-webkit-tests: clean up worker model defaults. This
680         changes the default behavior to 'threads' instead of
681         'old-threads', and clarifies that chromium-win-* and
682         chromium-mac-leopard are exceptions.
683
684         https://bugs.webkit.org/show_bug.cgi?id=56971
685
686         * Scripts/webkitpy/layout_tests/port/base.py:
687         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
688         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
689         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
690         * Scripts/webkitpy/layout_tests/port/test.py:
691         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
692
693 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
694
695         Reviewed by Darin Adler.
696
697         Media Stream API: fix the order of the options in build-webkit.
698         https://bugs.webkit.org/show_bug.cgi?id=56949
699
700         Fix the order of the options in build-webkit.
701
702         * Scripts/build-webkit:
703
704 2011-03-23  Adam Klein  <adamk@chromium.org>
705
706         Reviewed by Mihai Parparita.
707
708         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
709         https://bugs.webkit.org/show_bug.cgi?id=56884
710
711         This option will be utilized by Chromium's ui_tests to allow
712         referencing js-test-resources from a layout test over HTTP.
713
714         * Scripts/new-run-webkit-httpd:
715         Added --layout_tests_dir option.
716         * Scripts/webkitpy/layout_tests/port/http_server.py:
717         Plumbed through as layout_tests_dir param.
718
719 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
720
721         Reviewed by Mihai Parparita.
722
723         new-run-webkit-tests: run tests in ascending alphabetical order per
724         dir. This is a second attempt at the fix; the first attempt, in 
725         r81597, broke the behavior on the old-inline and old-threads
726         worker models.
727
728         https://bugs.webkit.org/show_bug.cgi?id=56760
729
730         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
731         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
732         * Scripts/webkitpy/layout_tests/port/test.py:
733         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
734
735 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
736
737         Reviewed by Martin Robinson.
738
739         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
740         https://bugs.webkit.org/show_bug.cgi?id=56953
741
742         Print the string for the detail of 'property-change' signal.
743
744         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
745         (axObjectEventListener): Print the detail string.
746
747 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
748
749         Reviewed by Pavel Feldman.
750
751         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
752         https://bugs.webkit.org/show_bug.cgi?id=56843
753
754         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
755         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
756
757 2011-03-22  Eric Seidel  <eric@webkit.org>
758
759         Reviewed by Adam Barth.
760
761         Teach update-webkit about gyp
762         https://bugs.webkit.org/show_bug.cgi?id=56881
763
764         This makes it possible for someone who builds from Xcode
765         to just run update-webkit --gyp and have the project files
766         generated after update automatically.
767
768         I also added a stand-alone "generate-project-files" script
769         wrapping Source/gyp/configure.  This makes running gyp simpler
770         since most people will not have gyp or Source/gyp in their path.
771
772         * Scripts/build-webkit:
773         * Scripts/generate-project-files: Added.
774         * Scripts/update-webkit:
775
776 2011-03-22  Anton D'Auria  <adauria@apple.com>
777
778         Reviewed by Alexey Proskuryakov.
779
780         Add +[WebApplicationCache getOriginsWithCache]
781         https://bugs.webkit.org/show_bug.cgi?id=56722
782
783         * DumpRenderTree/LayoutTestController.cpp:
784         (originsWithApplicationCacheCallback):
785         (LayoutTestController::staticFunctions):
786         * DumpRenderTree/LayoutTestController.h:
787         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
788         (LayoutTestController::originsWithApplicationCache):
789         * DumpRenderTree/chromium/LayoutTestController.h:
790         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
791         (LayoutTestController::originsWithApplicationCache):
792         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
793         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
794         (LayoutTestController::originsWithApplicationCache):
795         (LayoutTestController::originsWithLocalStorage):
796         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
797         (LayoutTestController::originsWithApplicationCache):
798         * DumpRenderTree/qt/LayoutTestControllerQt.h:
799         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
800         (LayoutTestController::originsWithApplicationCache):
801         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
802         (LayoutTestController::originsWithApplicationCache):
803
804 2011-03-22  Eric Seidel  <eric@webkit.org>
805
806         Reviewed by Adam Barth.
807
808         Add support to build-webkit for building with gyp-generated project files
809         https://bugs.webkit.org/show_bug.cgi?id=56877
810
811         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
812         Eventually we'll want to support gyp-generated projects in a more general manner.
813
814         * Scripts/build-webkit:
815
816 2011-03-22  David Kilzer  <ddkilzer@apple.com>
817
818         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
819
820         Reviewed by Joseph Pecoraro.
821
822         * Scripts/build-webkit: Updated usage statement to include
823         --dsym.
824         * Scripts/webkitdirs.pm: Added $generateDsym variable.
825         (generateDsym): Added. Call determineGenerateDsym() and
826         return $generateDsym.
827         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
828         $generateDsym.
829         (argumentsForXcode): Added.  Returns additional arguments for
830         xcodebuild based on command-line switches.
831         (XcodeOptions): Updated to include argumentsForXcode() in the
832         array returned.
833
834 2011-03-22  Adam Roben  <aroben@apple.com>
835
836         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
837
838         These bots are consistently green again.
839
840         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
841         core builders
842
843         Rubber-stamped by Antti Koivisto.
844
845         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
846         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
847
848         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
849         (BuildBotTest.test_builder_name_regexps): Updated expectations.
850
851 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
852
853         Unreviewed, rolling out r81597.
854         http://trac.webkit.org/changeset/81597
855         https://bugs.webkit.org/show_bug.cgi?id=56801
856
857         Change results in lots of unexpected flaky on the dashboard.
858         (Requested by pfeldman on #webkit).
859
860         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
861         * Scripts/webkitpy/layout_tests/port/test.py:
862         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
863
864 2011-03-21  Sam Weinig  <sam@webkit.org>
865
866         Fix failing tests on the WebKit2 bots.
867
868         * WebKitTestRunner/TestController.cpp:
869         (WTR::TestController::resetStateToConsistentValues):
870
871 2011-03-21  Daniel Sievers  <sievers@google.com>
872
873         Reviewed by Simon Fraser.
874
875         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
876         https://bugs.webkit.org/show_bug.cgi?id=56139
877
878         * DumpRenderTree/chromium/DumpRenderTree.cpp:
879         (main):
880         * DumpRenderTree/chromium/LayoutTestController.cpp:
881         (LayoutTestController::LayoutTestController):
882         (LayoutTestController::layerTreeAsText):
883         * DumpRenderTree/chromium/LayoutTestController.h:
884         (LayoutTestController::setShowDebugLayerTree):
885         * DumpRenderTree/chromium/TestShell.cpp:
886         (TestShell::runFileTest):
887         (TestShell::dump):
888         * DumpRenderTree/chromium/TestShell.h:
889         (TestParams::TestParams):
890
891 2011-03-21  Adam Roben  <aroben@apple.com>
892
893         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
894
895         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
896         output as plain text
897
898         Reviewed by David Kilzer.
899
900         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
901         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
902         to the master.
903         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
904         since we're running on the build master, not the slave. Instead, turn the raw source of
905         actual.html which the build slave uploaded into an HTML log.
906
907 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
908
909         Reviewed by Mihai Parparita.
910
911         new-run-webkit-tests: run tests in ascending alphabetical order per dir
912         https://bugs.webkit.org/show_bug.cgi?id=56760
913
914         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
915         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
916         * Scripts/webkitpy/layout_tests/port/test.py:
917
918 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
919
920         Reviewed by Steve Block.
921
922         Media Stream API patch 0: adding compilation guards.
923         https://bugs.webkit.org/show_bug.cgi?id=56458
924
925         Adding options to enable the media stream API feature in Chromium.
926
927         * Scripts/build-webkit:
928
929 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
930
931         Reviewed by Laszlo Gombos.
932
933         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
934         https://bugs.webkit.org/show_bug.cgi?id=56323
935
936         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
937         "--stdout" or "--stderr" option.
938
939         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
940         (WebCore::DumpRenderTree::~DumpRenderTree):
941         (WebCore::DumpRenderTree::processArgsLine):
942         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
943         * DumpRenderTree/qt/DumpRenderTreeQt.h:
944         (WebCore::DumpRenderTree::setRedirectOutputFileName):
945         (WebCore::DumpRenderTree::setRedirectErrorFileName):
946         * DumpRenderTree/qt/main.cpp:
947         (isOption):
948         (takeOptionValue):
949         (printUsage):
950         (main):
951
952 2011-03-21  Adam Roben  <aroben@apple.com>
953
954         Fix exceptions on the buildbot due to my last change
955
956         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
957         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
958
959 2011-03-21  Adam Roben  <aroben@apple.com>
960
961         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
962
963         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
964         output as plain text
965
966         Reviewed by Darin Adler.
967
968         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
969         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
970         logs.
971         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
972         the build master. This will correctly treat it as HTML.
973
974 2011-03-20  Bill Budge  <bbudge@chromium.org>
975
976         Reviewed by Adam Barth.
977
978         Rename ThreadSafeShared to ThreadSafeRefCounted
979         https://bugs.webkit.org/show_bug.cgi?id=56714
980
981         No new tests. Exposes no new functionality.
982
983         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
984         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
985         * Scripts/do-webcore-rename:
986
987 2011-03-19  Anton D'Auria  <adauria@apple.com>
988
989         Reviewed by Dan Bernstein.
990
991         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
992         https://bugs.webkit.org/show_bug.cgi?id=56719
993
994         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
995         (LayoutTestController::clearApplicationCacheForOrigin):
996
997 2011-03-19  Anton D'Auria  <adauria@apple.com>
998
999         Reviewed by Alexey Proskuryakov.
1000
1001         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
1002         https://bugs.webkit.org/show_bug.cgi?id=56415
1003
1004         * DumpRenderTree/LayoutTestController.cpp:
1005         (clearApplicationCacheForOriginCallback):
1006         (LayoutTestController::staticFunctions):
1007         * DumpRenderTree/LayoutTestController.h:
1008         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
1009         (LayoutTestController::LayoutTestController):
1010         (LayoutTestController::clearAllApplicationCaches):
1011         (LayoutTestController::clearApplicationCacheForOrigin): 
1012         * DumpRenderTree/chromium/LayoutTestController.h:
1013         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
1014         (LayoutTestController::clearApplicationCacheForOrigin):
1015         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
1016         (LayoutTestController::clearApplicationCacheForOrigin):
1017         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1018         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
1019         (LayoutTestController::clearApplicationCacheForOrigin):
1020         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
1021         (LayoutTestController::clearApplicationCacheForOrigin):
1022
1023 2011-03-18  Dan Bernstein  <mitz@apple.com>
1024
1025         Revised build fix for r81135.
1026
1027         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1028         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1029
1030 2011-03-18  Adam Roben  <aroben@apple.com>
1031
1032         Windows build fix
1033
1034         * WebKitTestRunner/config.h: Add a missing #endif.
1035
1036 2011-03-18  Andreas Kling  <kling@webkit.org>
1037
1038         Unbreak Qt build after r81494.
1039
1040         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1041         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1042
1043 2011-03-18  Sam Weinig  <sam@webkit.org>
1044
1045         Fix windows build. This was really Adam Roben's fault. I swear!
1046
1047         * WebKitTestRunner/config.h:
1048
1049 2011-03-18  Sam Weinig  <sam@webkit.org>
1050
1051         Reviewed by Adam Roben.
1052
1053         Pixel tests don't work in WebKitTestRunner on Windows
1054         https://bugs.webkit.org/show_bug.cgi?id=56630
1055
1056         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
1057         built-in snapshotting instead of using the window server on the Mac.
1058
1059         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1060         (WTR::InjectedBundle::InjectedBundle):
1061         (WTR::InjectedBundle::didReceiveMessage):
1062         (WTR::InjectedBundle::beginTesting):
1063         (WTR::InjectedBundle::done):
1064         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1065         (WTR::InjectedBundle::setPixelResult):
1066         (WTR::InjectedBundle::shouldDumpPixels):
1067         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1068         (WTR::InjectedBundlePage::dump):
1069         Take the snapshot in the bundle and send it to the UIProcess for dumping.
1070
1071         * WebKitTestRunner/TestInvocation.cpp:
1072         (WTR::TestInvocation::invoke):
1073         (WTR::TestInvocation::dump):
1074         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1075         * WebKitTestRunner/TestInvocation.h:
1076         * WebKitTestRunner/cg: Added.
1077         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
1078         (WTR::createCGContextFromImage):
1079         (WTR::computeMD5HashStringForContext):
1080         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1081         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1082         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
1083
1084         * WebKitTestRunner/win/TestInvocationWin.cpp:
1085         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1086         Keep stub for Cairo build.
1087
1088         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
1089         Add CG configuration.
1090
1091         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1092         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1093         Add new files.
1094
1095 2011-03-18  Adam Roben  <aroben@apple.com>
1096
1097         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
1098
1099         Rubber-stamped by Simon Fraser.
1100
1101         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1102         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
1103         overflow-y:overlay so that the scrollbar doesn't overlay the content.
1104
1105 2011-03-18  Adam Roben  <aroben@apple.com>
1106
1107         Don't ellipsize long or indented function names in Leaks Viewer
1108
1109         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
1110         scrollbar
1111
1112         Reviewed by Simon Fraser.
1113
1114         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1115         (.data-grid .data-container):
1116         (.data-grid td > div, .data-grid th > div):
1117         Allow the contents to extend to the right.
1118
1119 2011-03-18  Adam Roben  <aroben@apple.com>
1120
1121         Fix some leaks in DRT seen on the leaks bot
1122
1123         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
1124         setWillSendRequestClearHeaderCallback in DRT are leaky
1125
1126         Reviewed by Alexey Proskuryakov.
1127
1128         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
1129
1130         * DumpRenderTree/LayoutTestController.cpp:
1131         (addURLToRedirectCallback):
1132         (setWillSendRequestClearHeaderCallback):
1133         Use OwnArrayPtr to cause the strings to be deleted.
1134
1135 2011-03-18  Adam Roben  <aroben@apple.com>
1136
1137         Fix a NSURLCredential leak seen on the leaks bot
1138
1139         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
1140         connection:didReceiveAuthenticationChallenge:] is leaky
1141
1142         Reviewed by John Sullivan.
1143
1144         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1145         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
1146         cause the NSURLCredential to be released.
1147
1148 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
1149
1150         Unreviewed.
1151
1152         Remove unnecessary brackets around my email address.
1153
1154         * Scripts/webkitpy/common/config/committers.py:
1155
1156 2011-03-18  Adam Roben  <aroben@apple.com>
1157         
1158         Remove some files I accidentally added in r81454
1159
1160         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
1161         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
1162
1163 2011-03-18  Adam Roben  <aroben@apple.com>
1164
1165         Ignore an NSNumberFormatter leak on SnowLeopard
1166
1167         * Scripts/old-run-webkit-tests:
1168         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
1169         getObjectValue:forString:errorDescription:].
1170
1171 2011-03-18  Adam Roben  <aroben@apple.com>
1172
1173         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
1174
1175         Rubber-stamped by Mark Rowe.
1176
1177         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1178         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
1179         released.
1180
1181 2011-03-17  Adam Roben  <aroben@apple.com>
1182
1183         Address a review comment I missed in r81445
1184
1185         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1186         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
1187         leaked bytes to speed up searching on long lines.
1188
1189 2011-03-17  Adam Roben  <aroben@apple.com>
1190
1191         Mark leaky builds orange, even if all regression tests passed
1192
1193         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
1194         build.webkit.org when all tests pass even though there are still leaks
1195
1196         Reviewed by Dan Bernstein.
1197
1198         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1199         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
1200         be marked orange if this build step generates warnings.
1201
1202 2011-03-17  Adam Roben  <aroben@apple.com>
1203
1204         Allow values in Leaks Viewer to be shown as percentages
1205
1206         Double-clicking on a column will toggle between showing percentages and showing real values.
1207
1208         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
1209         number of leaked bytes in Leaks Viewer
1210
1211         Reviewed by Joe Pecoraro.
1212
1213         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1214         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
1215         node's totalTime, which is used in calculating percentages.
1216
1217         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1218         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
1219         showing them as percentages.
1220
1221 2011-03-17  Adam Roben  <aroben@apple.com>
1222
1223         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
1224
1225         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
1226         the number of leaked allocations. And the new Average column shows the average number of
1227         leaked bytes per call.
1228
1229         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
1230         just how many allocations
1231
1232         Reviewed by Joe Pecoraro.
1233
1234         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1235         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
1236         line and store it with the leak stack.
1237         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
1238         properties.
1239         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
1240         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
1241         .numberOfCalls now holds the number of leaked allocations.
1242
1243         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1244         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
1245         appear.
1246         (monkeyPatchInspectorObjects): Format the values as bytes.
1247
1248 2011-03-17  Adam Roben  <aroben@apple.com>
1249
1250         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
1251
1252         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
1253         regression tests
1254
1255         Reviewed by James Robinson.
1256
1257         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1258         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
1259         is always populated, even when all regression tests pass.
1260
1261 2011-03-10  Hayato Ito  <hayato@chromium.org>
1262
1263         Reviewed by Tony Chang.
1264
1265         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
1266
1267         https://bugs.webkit.org/show_bug.cgi?id=56076
1268
1269         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1270
1271 2011-03-17  Adam Roben  <aroben@apple.com>
1272
1273         Skip a compositing-sensitive test when accelerated compositing is disabled
1274
1275         Reviewed by Sam Weinig.
1276
1277         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
1278         accelerated compositing is disabled.
1279
1280 2011-03-17  Adam Roben  <aroben@apple.com>
1281
1282         Start using PlatformSpecificScheduler for the Mac builders
1283
1284         The current set of file/directory patterns should work for Mac builders. We may discover
1285         that there are more files and directories we can exclude from the Mac builds, but they can
1286         be added later.
1287
1288         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
1289
1290         Reviewed by Mark Rowe.
1291
1292         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
1293         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
1294
1295         * Scripts/webkitpy/common/config/build.py:
1296         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
1297         cleaned up patterns a little bit.
1298
1299         * Scripts/webkitpy/common/config/build_unittest.py:
1300         (ShouldBuildTest): Fixed some expected results.
1301         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
1302         platforms.
1303
1304 2011-03-17  Jeff Miller  <jeffm@apple.com>
1305
1306         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
1307         
1308         *.mode*
1309         *.pbxuser
1310         *.perspective*
1311         project.xcworkspace
1312         xcuserdata
1313
1314         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1315         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1316         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1317         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1318         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1319
1320 2011-03-17  Adam Roben  <aroben@apple.com>
1321
1322         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
1323
1324         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
1325         mac-wk2
1326
1327         Reviewed by Anders Carlsson.
1328
1329         * Scripts/old-run-webkit-tests:
1330         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
1331         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
1332         we're running in WebKit2 mode.
1333
1334 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
1335
1336         Reviewed by Yury Semikhatsky.
1337
1338         Web Inspector: Clean up Inspector strings.
1339         https://bugs.webkit.org/show_bug.cgi?id=56557
1340
1341         Modify the script to deal correctly with "\xNN" escapes, and to
1342         check strings in Chromium's DevTools.js.
1343
1344         * Scripts/check-inspector-strings:
1345
1346 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
1347
1348         Reviewed by Benjamin Poulain.
1349
1350         Update autoinstall to install mechanize 0.2.4
1351         https://bugs.webkit.org/show_bug.cgi?id=56499
1352
1353         Newer versions of mechanize support HTTPS proxies, which is necessary
1354         for people using webkit-patch behind firewalls.
1355
1356         * Scripts/webkitpy/common/system/autoinstall.py:
1357         * Scripts/webkitpy/thirdparty/__init__.py:
1358
1359 2011-03-16  Sam Weinig  <sam@webkit.org>
1360
1361         Reviewed by Adam Roben.
1362
1363         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
1364         https://bugs.webkit.org/show_bug.cgi?id=56541
1365
1366         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1367         (WTR::InjectedBundlePage::willSendRequestForFrame):
1368         Check for an empty host in addition to a null host.  This bug was introduced
1369         when porting off of the KURL code and onto the WKURLRef version.
1370
1371 2011-03-16  Sam Weinig  <sam@webkit.org>
1372
1373         Reviewed by Adam Roben.
1374
1375         Add Lucas Forschler to the list of WebKit committers.
1376
1377         * Scripts/webkitpy/common/config/committers.py:
1378
1379 2011-03-16  Sam Weinig  <sam@webkit.org>
1380
1381         Reviewed upon and dictated through Adam Roben.
1382
1383         Escape crashing function names in results.html. This fixes an issue
1384         when a crash involves a type with templates.
1385
1386         * Scripts/old-run-webkit-tests:
1387
1388 2011-03-16  Daniel Sievers  <sievers@google.com>
1389
1390         Reviewed by James Robinson.
1391
1392         Add setting to always force compositing mode
1393         https://bugs.webkit.org/show_bug.cgi?id=56156
1394
1395         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1396         (main):
1397         * DumpRenderTree/chromium/TestShell.cpp:
1398         (TestShell::TestShell):
1399         (TestShell::resetWebSettings):
1400         * DumpRenderTree/chromium/TestShell.h:
1401         (TestShell::setForceCompositingMode):
1402         * DumpRenderTree/chromium/WebPreferences.cpp:
1403         (WebPreferences::reset):
1404         (WebPreferences::applyTo):
1405         * DumpRenderTree/chromium/WebPreferences.h:
1406
1407 2011-03-15  Hayato Ito  <hayato@chromium.org>
1408
1409         Reviewed by Ojan Vafai.
1410
1411         Ignore files that will be used by reftests in old-run-webkit-tests.
1412
1413         https://bugs.webkit.org/show_bug.cgi?id=55936
1414
1415         * Scripts/old-run-webkit-tests:
1416
1417 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
1418
1419         Reviewed by Adam Roben.
1420
1421         Function relativeScriptsDir doesn't return the correct relative
1422         Scripts directory.
1423
1424         * Scripts/webkitdirs.pm:
1425         (relativeScriptsDir): Ensure we use the directory that contains
1426         webkitdirs.pm, not the one that contains the original script that
1427         was invoked.
1428
1429 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1430
1431         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
1432         fix to link against the Security framework after recent WebKitSystemInterface changes.
1433
1434         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1435         (LayoutTestController::originsWithLocalStorage):
1436         * wx/build/settings.py:
1437         * wx/build/waf_extensions.py:
1438
1439 2011-03-15  Sam Weinig  <sam@webkit.org>
1440
1441         Reviewed by Darin Adler.
1442
1443         Add script to convert a patch to a prettypatch and show in the default browser
1444         https://bugs.webkit.org/show_bug.cgi?id=56416
1445
1446         This can be used either like
1447             $ svn-create-patch | show-pretty-diff
1448         or
1449             $ show-pretty-diff patch.diff
1450
1451         * Scripts/show-pretty-diff: Added.
1452
1453 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
1454
1455         Rubber-stamped by Adam Roben.
1456
1457         Adding myself as a reviewer.
1458
1459         * Scripts/webkitpy/common/config/committers.py:
1460
1461 2011-03-15  Anders Carlsson  <andersca@apple.com>
1462
1463         Try to fix the Windows build.
1464
1465         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1466         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1467
1468 2011-03-15  Anders Carlsson  <andersca@apple.com>
1469
1470         Reviewed by Sam Weinig.
1471
1472         Make sure that NP_Shutdown is always the last NPP function called
1473         https://bugs.webkit.org/show_bug.cgi?id=56391
1474
1475         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
1476
1477         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1478         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1479         (PluginTest::PluginTest):
1480         (PluginTest::NP_Shutdown):
1481         (PluginTest::registerNPShutdownFunction):
1482         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1483         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
1484         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
1485         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1486         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
1487         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
1488         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
1489         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
1490         (NPDeallocateCalledBeforeNPShutdown::shutdown):
1491         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1492         (NP_Shutdown):
1493         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1494         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1495         * GNUmakefile.am:
1496
1497 2011-03-15  Ilya Sherman  <isherman@chromium.org>
1498
1499         Reviewed by Tony Chang.
1500
1501         Autofilled form elements are assigned fixed background color but not text color
1502         https://bugs.webkit.org/show_bug.cgi?id=48382
1503
1504         * DumpRenderTree/LayoutTestController.cpp:
1505         (setAutofilledCallback): Added.
1506         (LayoutTestController::staticFunctions):
1507         * DumpRenderTree/LayoutTestController.h:
1508         * DumpRenderTree/chromium/LayoutTestController.cpp:
1509         (LayoutTestController::LayoutTestController):
1510         (LayoutTestController::setAutofilled): Added.
1511         * DumpRenderTree/chromium/LayoutTestController.h:
1512         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1513         (LayoutTestController::setAutofilled): Added.
1514         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1515         (LayoutTestController::setAutofilled): Added.
1516         (LayoutTestController::setValueForUser): Style tweak.
1517         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1518         (LayoutTestController::setAutofilled): Added (stub).
1519         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1520         (LayoutTestController::setAutofilled): Added (stub).
1521
1522 2011-03-15  Dan Bernstein  <mitz@apple.com>
1523
1524         Build fix after r81135.
1525
1526         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1527
1528 2011-03-15  Dan Bernstein  <mitz@apple.com>
1529
1530         Build fix after r81135.
1531
1532         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1533         * WebKitTestRunner/mac/TestControllerMac.mm:
1534         * WebKitTestRunner/mac/TestInvocationMac.mm:
1535         * WebKitTestRunner/mac/main.mm:
1536
1537 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
1538
1539         Reviewed by Adam Barth.
1540
1541         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
1542         https://bugs.webkit.org/show_bug.cgi?id=56349
1543
1544         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
1545         on platforms where we use it. Copied from DumpRenderTree.pro.
1546
1547 2011-03-15  Dan Bernstein  <mitz@apple.com>
1548
1549         Build fix after r81135.
1550
1551         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1552         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
1553
1554 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1555
1556         Reviewed by Darin Adler.
1557
1558         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
1559         info into the headers rather than in export symbol definition files, but disable it on 
1560         all platforms initially so we can deal with port build issues one port at a time.
1561         
1562         https://bugs.webkit.org/show_bug.cgi?id=27551
1563
1564         * DumpRenderTree/cg/ImageDiffCG.cpp:
1565         * DumpRenderTree/chromium/config.h:
1566         * DumpRenderTree/config.h:
1567         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1568         * TestWebKitAPI/TestWebKitAPIPrefix.h:
1569         * WebKitAPITest/HostWindow.cpp:
1570         * WebKitAPITest/TestsController.cpp:
1571         * WebKitAPITest/config.h: Added.
1572         * WebKitAPITest/main.cpp:
1573         * WebKitAPITest/tests/WebViewDestruction.cpp:
1574         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
1575         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1576         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1577         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1578         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1579         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1580         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1581         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1582         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1583         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1584         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
1585         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
1586         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1587         * WebKitTestRunner/TestController.cpp:
1588         * WebKitTestRunner/TestInvocation.cpp:
1589         * WebKitTestRunner/config.h: Added.
1590         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1591         * WebKitTestRunner/qt/TestControllerQt.cpp:
1592         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1593         * WebKitTestRunner/qt/main.cpp:
1594         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1595         * WebKitTestRunner/win/TestControllerWin.cpp:
1596         * WebKitTestRunner/win/TestInvocationWin.cpp:
1597         * WebKitTestRunner/win/main.cpp:
1598         * wx/build/settings.py:
1599
1600 2011-03-15  Hayato Ito  <hayato@chromium.org>
1601
1602         Reviewed by Shinichiro Hamaji.
1603
1604         [NRWT] Add support for reftests to new-run-webkit-tests.
1605
1606         https://bugs.webkit.org/show_bug.cgi?id=55457
1607
1608         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1609         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1610         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1611         * Scripts/webkitpy/layout_tests/port/base.py:
1612         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1613         * Scripts/webkitpy/layout_tests/port/test.py:
1614         * Scripts/webkitpy/layout_tests/port/test_files.py:
1615         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1616
1617 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
1618
1619         Reviewed by Martin Robinson.
1620
1621         [GTK] Fix compilation warning after r80892
1622         https://bugs.webkit.org/show_bug.cgi?id=56302
1623
1624         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1625         (LayoutTestController::originsWithLocalStorage):
1626
1627 2011-03-15  Robert Hogan  <robert@webkit.org>
1628
1629         Reviewed by Adam Barth.
1630
1631         Document the qmakearg argument, and hint how to build webkit2 on Qt
1632         https://bugs.webkit.org/show_bug.cgi?id=56326
1633
1634         * Scripts/build-webkit: add --qmakearg to build-webkit --help
1635
1636 2011-03-15  Adam Roben  <aroben@apple.com>
1637
1638         Make Windows 7 Release (Tests) a core builder
1639
1640         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
1641         give it a few more days of greenness first.
1642
1643         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
1644
1645         Reviewed by Sam Weinig.
1646
1647         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1648         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
1649
1650         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1651         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
1652         Updated the core regexps to match the buildbot module. Updated the expected results to match
1653         the current set of core builders.
1654
1655 2011-03-14  Adam Roben  <aroben@apple.com>
1656
1657         Add forgotten file from r81116
1658
1659         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
1660
1661 2011-03-14  Sam Weinig  <sam@webkit.org>
1662
1663         Reviewed by Adam Roben.
1664
1665         about:blank fake responses don't get serialized when sent the UIProcess
1666         <rdar://problem/9108119>
1667         https://bugs.webkit.org/show_bug.cgi?id=56357
1668
1669         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
1670         (TestWebKitAPI::decidePolicyForResponse):
1671         (TestWebKitAPI::TEST):
1672         Add test that loads of about:blank have a response with a MIMEType of text/html.
1673
1674         * TestWebKitAPI/PlatformUtilities.h:
1675         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1676         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1677         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1678         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1679         Add helper to get the MIMEType from a WKURLResponse.
1680
1681         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1682         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1683         Add new files.
1684
1685 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
1686
1687         Reviewed by Kenneth Rohde Christiansen.
1688
1689         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
1690         https://bugs.webkit.org/show_bug.cgi?id=56006
1691
1692         * QtTestBrowser/launcherwindow.cpp:
1693         (LauncherWindow::initializeView):
1694         * QtTestBrowser/main.cpp:
1695         (LauncherApplication::handleUserOptions):
1696
1697 2011-03-14  James Kozianski  <koz@chromium.org>
1698
1699         Reviewed by Ojan Vafai.
1700
1701         Add method to make BuildBot return test outputs
1702         https://bugs.webkit.org/show_bug.cgi?id=54374
1703
1704         The Builder.latest_cached_build will be used by the new rebaseline
1705         script to determine the build to use baselines from.
1706
1707         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1708         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1709
1710 2011-03-14  Adam Roben  <aroben@apple.com>
1711
1712         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
1713
1714         Reviewed by Sam Weinig.
1715
1716         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
1717         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
1718         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
1719         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
1720         ensure the web process is initialized, then ask the bundle to run the test and assert that
1721         it succeeded.
1722
1723         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
1724         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
1725         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
1726         handle a given URL.
1727         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
1728         URL type cannot be handled).
1729         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
1730         result.
1731
1732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1733         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1734         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1735         Added new files to the project.
1736
1737 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1738
1739         Unreviewed, rolling out r81094.
1740         http://trac.webkit.org/changeset/81094
1741         https://bugs.webkit.org/show_bug.cgi?id=56355
1742
1743         Broke the chromium DRT related build. (Requested by dave_levin
1744         on #webkit).
1745
1746         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1747         (main):
1748         * DumpRenderTree/chromium/LayoutTestController.cpp:
1749         (LayoutTestController::LayoutTestController):
1750         (LayoutTestController::layerTreeAsText):
1751         * DumpRenderTree/chromium/LayoutTestController.h:
1752         * DumpRenderTree/chromium/TestShell.cpp:
1753         (TestShell::runFileTest):
1754         (TestShell::dump):
1755         * DumpRenderTree/chromium/TestShell.h:
1756         (TestParams::TestParams):
1757
1758 2011-03-14  Daniel Sievers  <sievers@google.com>
1759
1760         Reviewed by Simon Fraser.
1761
1762         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1763         https://bugs.webkit.org/show_bug.cgi?id=56139
1764
1765         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1766         (main):
1767         * DumpRenderTree/chromium/LayoutTestController.cpp:
1768         (LayoutTestController::LayoutTestController):
1769         (LayoutTestController::layerTreeAsText):
1770         * DumpRenderTree/chromium/LayoutTestController.h:
1771         (LayoutTestController::setShowDebugLayerTree):
1772         * DumpRenderTree/chromium/TestShell.cpp:
1773         (TestShell::runFileTest):
1774         (TestShell::dump):
1775         * DumpRenderTree/chromium/TestShell.h:
1776         (TestParams::TestParams):
1777
1778 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
1779
1780         Reviewed by Adam Roben.
1781
1782         [Qt][WK2]Unbreak InjectedBundle on Qt
1783         https://bugs.webkit.org/show_bug.cgi?id=54109
1784
1785         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1786         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
1787         API's instead of KURL to analyze the URL.
1788         * WebKitTestRunner/StringFunctions.h:
1789         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
1790         in the WebKitTestRunner project.
1791         (WTR::toWK): Use adoptWK.
1792         (WTR::operator<<): Added helper for printing a WKURL.
1793         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
1794         against WebCore.
1795
1796 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
1797
1798         Reviewed by Kenneth Rohde Christiansen.
1799
1800         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
1801         https://bugs.webkit.org/show_bug.cgi?id=56321
1802
1803         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
1804         to the list of exceptions for WebKit2 C API headers.
1805
1806 2011-03-14  Adam Roben  <aroben@apple.com>
1807
1808         Show the list of recent leaky builds in reverse chronological order
1809
1810         Previously they were being shown in a deterministic but surprising order based on
1811         lexicographically sorting the build offsets (-1, -10, -2, -3...).
1812
1813         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
1814
1815         Reviewed by Darin Adler.
1816
1817         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1818         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
1819         callback.
1820
1821 2011-03-14  Adam Roben  <aroben@apple.com>
1822
1823         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
1824
1825         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
1826         analyze
1827
1828         Reviewed by David Kilzer and Joe Pecoraro.
1829
1830         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1831         (#url-prompt): Made this a bit taller to make room for the list of builds.
1832
1833         (#recent-builds-loading-indicator):
1834         (#recent-builds-list):
1835         Added styles for the build list and loading indicator.
1836
1837         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1838         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
1839         it. This will unescape it.
1840         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
1841         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
1842         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
1843         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
1844         prompt UI.
1845         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
1846         now also used when a recent build is clicked.
1847
1848         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
1849         (RecentBuildsLoader): Store the callback.
1850         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
1851         builder. Find the revision number, leak count, and results URL for each one. Pass the
1852         resulting info to our callback.
1853
1854         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
1855         (range): Added this helper function to return an array containing the integers [0, n).
1856
1857         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
1858         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
1859
1860 2011-03-14  Mark Rowe  <mrowe@apple.com>
1861
1862         Reviewed by Adam Roben.
1863
1864         Fix two memory leaks within LayoutTestController's storage support.
1865
1866         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1867         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
1868         by JSStringCreateWithCFString.
1869         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
1870         allocate.
1871
1872 2011-03-14  Mark Rowe  <mrowe@apple.com>
1873
1874         Reviewed by Oliver Hunt.
1875
1876         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
1877
1878         * DumpRenderTree/LayoutTestController.cpp:
1879         (LayoutTestController::staticFunctions): Remove duplicate entries.
1880
1881 2011-03-14  Alice Liu  <alice.liu@apple.com>
1882
1883         Reviewed by Dan Bernstein.
1884
1885         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
1886
1887         * DumpRenderTree/mac/PerlSupport/Makefile:
1888         Add whitespace when joining "-arch" with the architectures passed in as arguments.
1889
1890 2011-03-14  Daniel Bates  <dbates@rim.com>
1891
1892         https://bugs.webkit.org/show_bug.cgi?id=55438
1893         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
1894         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
1895
1896         * Scripts/build-webkit:
1897
1898 2011-03-14  Daniel Bates  <dbates@rim.com>
1899
1900         Reviewed by David Kilzer.
1901
1902         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
1903         https://bugs.webkit.org/show_bug.cgi?id=55438
1904
1905         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
1906         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
1907         CMake arguments for feature defines.
1908
1909         * Scripts/build-webkit:
1910           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
1911           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
1912           - Sorted forward declarations.
1913           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
1914             Modified call sites as needed.
1915         * Scripts/webkitdirs.pm:
1916           - Added cleanCMakeGeneratedProject() to clean a CMake build.
1917           - Added buildCMakeGeneratedProject() to build using generated build system.
1918           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
1919           - Added generateBuildSystemFromCMakeProject() to generate the build system from
1920             a CMake project.
1921           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
1922
1923 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
1924
1925         Reviewed by Steve Block.
1926
1927         Detach Geolocation from Frame when Page destroyed.
1928         https://bugs.webkit.org/show_bug.cgi?id=52877
1929
1930         Extend the layout test controller to expose the number of pending
1931         geolocation requests, so that we can test that the requests have
1932         been cancelled on page close.
1933
1934         * DumpRenderTree/LayoutTestController.cpp:
1935         (numberOfPendingGeolocationPermissionRequestsCallback):
1936         (LayoutTestController::staticFunctions):
1937         * DumpRenderTree/LayoutTestController.h:
1938         * DumpRenderTree/chromium/LayoutTestController.cpp:
1939         (LayoutTestController::LayoutTestController):
1940         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1941         * DumpRenderTree/chromium/LayoutTestController.h:
1942         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1943         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1944         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1945         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1946         * DumpRenderTree/mac/UIDelegate.h:
1947         * DumpRenderTree/mac/UIDelegate.mm:
1948         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1949         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1950         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1951         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1952         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1953         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1954         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1955         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1956
1957
1958 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1959
1960         Unreviewed. Modify my email address in committers.py.
1961
1962         * Scripts/webkitpy/common/config/committers.py:
1963
1964 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
1965
1966         Reviewed by Kenneth Rohde Christiansen.
1967
1968         [Qt] QtLauncher does not load the same set of fonts as the DRT
1969         https://bugs.webkit.org/show_bug.cgi?id=34959
1970
1971         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
1972         When this option is used the webkit fonts are loaded the same
1973         as they are in DumpRenderTree.  This option can be used on
1974         QtTestBrowser and run-launcher.  It can only be used
1975         on Linux systems with FcInit and is configured as such.
1976
1977         * QtTestBrowser/launcherwindow.h:
1978         (WindowOptions::WindowOptions):
1979         * QtTestBrowser/main.cpp:
1980         (initWebKitTestFonts):
1981         (launcherMain):
1982         (LauncherApplication::handleUserOptions):
1983
1984 2011-03-12  Dan Bernstein  <mitz@apple.com>
1985
1986         Reviewed by Mark Rowe.
1987
1988         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
1989         DumpRenderTree is being built for.
1990
1991         * DumpRenderTree/mac/PerlSupport/Makefile:
1992
1993 2011-03-12  Dan Bernstein  <mitz@apple.com>
1994
1995         Suggested by Mark Rowe.
1996
1997         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
1998         as they were before r80915.
1999
2000 2011-03-12  Anders Carlsson  <andersca@apple.com>
2001
2002         Reviewed by Sam Weinig.
2003
2004         Should be able to download a PDF to the Downloads folder
2005         https://bugs.webkit.org/show_bug.cgi?id=56256
2006
2007         * MiniBrowser/mac/BrowserWindowController.m:
2008         (-[BrowserWindowController awakeFromNib]):
2009         * WebKitTestRunner/TestController.cpp:
2010         (WTR::TestController::createOtherPage):
2011         (WTR::TestController::initialize):
2012         Update for API changes.
2013
2014 2011-03-11  Anton D'Auria  <adauria@apple.com>
2015
2016         Reviewed and landed by Brady Eidson.
2017
2018         https://bugs.webkit.org/show_bug.cgi?id=51878
2019         Add WebKit1 API to view and delete local storage
2020
2021         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
2022
2023         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2024         * DumpRenderTree/LayoutTestController.cpp:
2025         (syncLocalStorageCallback):
2026         (observeStorageTrackerNotificationsCallback):
2027         (deleteAllLocalStorageCallback):
2028         (deleteLocalStorageForOriginCallback):
2029         (originsWithLocalStorageCallback):
2030         (LayoutTestController::staticFunctions):
2031         * DumpRenderTree/LayoutTestController.h:
2032         * DumpRenderTree/StorageTrackerDelegate.h: Added.
2033         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
2034         (-[StorageTrackerDelegate init]):
2035         (-[StorageTrackerDelegate logNotifications:controller:]):
2036         (-[StorageTrackerDelegate originModified:]):
2037         (-[StorageTrackerDelegate dealloc]):
2038         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
2039         * DumpRenderTree/chromium/LayoutTestController.cpp:
2040         (LayoutTestController::LayoutTestController):
2041         (LayoutTestController::deleteAllLocalStorage):
2042         (LayoutTestController::originsWithLocalStorage):
2043         (LayoutTestController::deleteLocalStorageForOrigin):
2044         (observeStorageTrackerNotifications):
2045         (syncLocalStorage):
2046         * DumpRenderTree/chromium/LayoutTestController.h:
2047         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2048         (LayoutTestController::originsWithLocalStorage):
2049         (LayoutTestController::deleteAllLocalStorage):
2050         (LayoutTestController::deleteLocalStorageForOrigin):
2051         (LayoutTestController::observeStorageTrackerNotifications):
2052         (LayoutTestController::syncLocalStorage):
2053         * DumpRenderTree/mac/DumpRenderTree.mm:
2054         (resetDefaultsToConsistentValues):
2055         (allocateGlobalControllers):
2056         (releaseGlobalControllers):
2057         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2058         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2059         (LayoutTestController::syncLocalStorage):
2060         (LayoutTestController::observeStorageTrackerNotifications):
2061         (LayoutTestController::deleteAllLocalStorage):
2062         (LayoutTestController::originsWithLocalStorage):
2063         (LayoutTestController::deleteLocalStorageForOrigin):
2064         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2065         (LayoutTestController::originsWithLocalStorage):
2066         (LayoutTestController::deleteAllLocalStorage):
2067         (LayoutTestController::deleteLocalStorageForOrigin):
2068         (LayoutTestController::observeStorageTrackerNotifications):
2069         (LayoutTestController::syncLocalStorage):
2070         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2071         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2072         (LayoutTestController::clearAllApplicationCaches):
2073         (LayoutTestController::syncLocalStorage):
2074         (LayoutTestController::observeStorageTrackerNotifications):
2075         (LayoutTestController::clearAllDatabases):
2076         (LayoutTestController::deleteAllLocalStorage):
2077         (LayoutTestController::originsWithLocalStorage):
2078         (LayoutTestController::deleteLocalStorageForOrigin):
2079         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2080         (LayoutTestController::syncLocalStorage):
2081         (LayoutTestController::observeStorageTrackerNotifications):
2082         (LayoutTestController::clearAllDatabases):
2083         (LayoutTestController::deleteAllLocalStorage):
2084         (LayoutTestController::originsWithLocalStorage):
2085         (LayoutTestController::deleteLocalStorageForOrigin):
2086
2087 2011-03-11  Jessie Berlin  <jberlin@apple.com>
2088
2089         Reviewed by Adam Roben.
2090
2091         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
2092         Process has finished launching.
2093         https://bugs.webkit.org/show_bug.cgi?id=56208
2094
2095         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
2096         (TestWebKitAPI::TEST):
2097         Test that calling WKContextClearResourceCaches works with both options when called before
2098         the Web Process is valid.
2099
2100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2101         Add the new test.
2102         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2103         Ditto.
2104
2105 2011-03-11  Adam Roben  <aroben@apple.com>
2106
2107         Make it possible to view all leaks from a build at once in Leaks Viewer
2108
2109         You can now give Leaks Viewer the URL of a build results page (e.g.,
2110         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
2111         will load all the leaks files from that build.
2112
2113         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
2114         files from a particular build at once, rather than one at a time
2115
2116         Reviewed by David Kilzer.
2117
2118         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
2119         (LeaksLoader): Initialize our properties.
2120         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
2121         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
2122         from that page.
2123         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
2124         so it can provide feedback. Then load each one and pass it to the client.
2125         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
2126         it into a DOM, pull out all the links to leaks files, and load each one.
2127
2128         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
2129         (LeaksParser): Initialize our worker.
2130         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
2131
2132         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
2133         This code mostly came from Worker.js.
2134         (LeaksParserWorker): Initialize our profile.
2135         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
2136         profile.
2137         (LeaksParserWorker.prototype._parseLeaks):
2138         (LeaksParserWorker.prototype._createNode):
2139         (LeaksParserWorker.prototype._incorporateLeaks):
2140         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
2141         version of createProfile which adds to this.profile instead of making a new profile each
2142         time.
2143         (onmessage): Parse the file and send back the new profile.
2144
2145         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2146         (#loading-indicator):
2147         (#spinner):
2148         (#loading-indicator-label):
2149         Tweaked styles to accomodate a longer label.
2150
2151         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2152         (LeaksViewer.loaded): Set up a loader and parser.
2153
2154         (LeaksViewer.get filesLeftToParse):
2155         (LeaksViewer.set filesLeftToParse):
2156         Added these simple accessors.
2157
2158         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
2159         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
2160         the parser.
2161         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
2162         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
2163         _loadLeaksFromURL function).
2164         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
2165         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
2166         loading indicator, including the number of files being loaded.
2167         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
2168         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
2169         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
2170         _loadingIndicatorText.
2171
2172         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
2173         (getResource): Moved here from LeaksViewer.js.
2174
2175         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
2176         LeaksParserWorker.js.
2177
2178         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
2179         files, added a #loading-indicator-label element, and tweaked the prompt wording.
2180
2181 2011-03-11  Adam Roben  <aroben@apple.com>
2182
2183         Don't trigger a build when build.webkit.org's HTML files are modified
2184
2185         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
2186
2187         Reviewed by Dan Bernstein.
2188
2189         * Scripts/webkitpy/common/config/build.py:
2190         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
2191         directories that shouldn't trigger builds. Re-sorted the list.
2192
2193         * Scripts/webkitpy/common/config/build_unittest.py:
2194         (ShouldBuildTest): Added a test to cover the above change.
2195
2196 2011-03-11  Adam Roben  <aroben@apple.com>
2197
2198         Roll out r80848
2199
2200         It was accidentally committed.
2201
2202         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2203         (LeaksViewer._loadLeaksFromURL):
2204
2205 2011-03-11  Tony Chang  <tony@chromium.org>
2206
2207         Reviewed by Ojan Vafai.
2208
2209         kill hung lighttpd processes on the chromium win bot
2210         https://bugs.webkit.org/show_bug.cgi?id=56152
2211
2212         Sometimes this process doesn't exit and it holds on to
2213         a log file that we can't delete or copy, causing the tests
2214         to go red.
2215
2216         * BuildSlaveSupport/win/kill-old-processes:
2217
2218 2011-03-11  Ilya Sherman  <isherman@chromium.org>
2219
2220         Reviewed by Kent Tamura.
2221
2222         [Chromium] missing HTMLInputElement::setValueForUser() to tests
2223         https://bugs.webkit.org/show_bug.cgi?id=55854
2224
2225         * DumpRenderTree/chromium/LayoutTestController.cpp:
2226         (LayoutTestController::LayoutTestController):
2227         (LayoutTestController::setValueForUser): Added.
2228         * DumpRenderTree/chromium/LayoutTestController.h:
2229
2230 2011-03-10  Peter Kasting  <pkasting@google.com>
2231
2232         Reviewed by Dimitri Glazkov.
2233
2234         Clean up some gross code in TestShellWin.cpp.  No functional change.
2235         https://bugs.webkit.org/show_bug.cgi?id=56048
2236
2237         * DumpRenderTree/chromium/TestShellWin.cpp:
2238         (checkLayoutTestSystemDependencies):
2239
2240 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
2241
2242         Reviewed by Laszlo Gombos.
2243
2244         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
2245
2246         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2247         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
2248
2249 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2250
2251         Reviewed by Kenneth Rohde Christiansen.
2252
2253         [EFL] Make single backing store the default for EWebLauncher
2254         https://bugs.webkit.org/show_bug.cgi?id=55753
2255
2256         Set single backing store the default for EWebLauncher.
2257
2258         * EWebLauncher/main.c:
2259         (main):
2260
2261 2011-03-10  Adam Roben  <aroben@apple.com>
2262
2263         Ignore errors from files being held open when creating a test result archive
2264
2265         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
2266         fails to delete the results directory
2267
2268         Reviewed by Mark Rowe.
2269
2270         * BuildSlaveSupport/test-result-archive:
2271         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
2272         thrown when a process is holding a file open.
2273
2274 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2275
2276         Unreviewed, rolling out r80701.
2277         http://trac.webkit.org/changeset/80701
2278         https://bugs.webkit.org/show_bug.cgi?id=56126
2279
2280         fast/dom/Geolocation/window-close-crash.html fails on Snow
2281         Leopard release builds (Requested by mihaip on #webkit).
2282
2283         * DumpRenderTree/LayoutTestController.cpp:
2284         (LayoutTestController::staticFunctions):
2285         * DumpRenderTree/LayoutTestController.h:
2286         * DumpRenderTree/chromium/LayoutTestController.cpp:
2287         (LayoutTestController::LayoutTestController):
2288         * DumpRenderTree/chromium/LayoutTestController.h:
2289         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2290         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2291         * DumpRenderTree/mac/UIDelegate.h:
2292         * DumpRenderTree/mac/UIDelegate.mm:
2293         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2294         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2295         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2296         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2297
2298 2011-03-10  Philippe Normand  <pnormand@igalia.com>
2299
2300         Reviewed by Gustavo Noronha Silva.
2301
2302         [GTK] run-gtk-tests doesn't fail if a test crashes
2303         https://bugs.webkit.org/show_bug.cgi?id=56089
2304
2305         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
2306         even if a test crashes. So run the tests individually and if a
2307         test fails remember its exit code so run-gtk-test fails too, if
2308         required.
2309
2310 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
2311
2312         Reviewed by Dmitry Titov.
2313
2314         Detach Geolocation from Frame when Page destroyed.
2315         https://bugs.webkit.org/show_bug.cgi?id=52877
2316
2317         Extend the layout test controller to expose the number of pending
2318         geolocation requests, so that we can test that the requests have
2319         been cancelled on page close.
2320
2321         * DumpRenderTree/LayoutTestController.cpp:
2322         (numberOfPendingGeolocationPermissionRequestsCallback):
2323         (LayoutTestController::staticFunctions):
2324         * DumpRenderTree/LayoutTestController.h:
2325         * DumpRenderTree/chromium/LayoutTestController.cpp:
2326         (LayoutTestController::LayoutTestController):
2327         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2328         * DumpRenderTree/chromium/LayoutTestController.h:
2329         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2330         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2331         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2332         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2333         * DumpRenderTree/mac/UIDelegate.h:
2334         * DumpRenderTree/mac/UIDelegate.mm:
2335         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2336         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2337         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2338         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2339         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2340         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2341         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2342         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2343
2344
2345 2011-03-09  Adam Roben  <aroben@apple.com>
2346
2347         Hide Leaks Viewer's URL prompt by default
2348
2349         We will show it as needed. I think I left it visible by default by accident after doing some
2350         testing.
2351
2352         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
2353         URL is passed as a query parameter, but does
2354
2355         Reviewed by Simon Fraser.
2356
2357         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2358
2359 2011-03-09  Adam Roben  <aroben@apple.com>
2360
2361         Don't use Element.classList or box-shadow in Leaks Viewer
2362
2363         They aren't supported by Safari 5. Luckily we have substitutes for them!
2364
2365         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
2366
2367         Reviewed by Simon Fraser.
2368
2369         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2370         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
2371
2372         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2373         (LeaksViewer.urlPromptButtonClicked):
2374         (LeaksViewer._displayURLPrompt):
2375         (LeaksViewer._setLoadingIndicatorHidden):
2376         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
2377
2378 2011-03-09  Adam Roben  <aroben@apple.com>
2379
2380         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
2381
2382         Rubber-stamped by David Kilzer.
2383
2384         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2385
2386 2011-03-09  Adam Roben  <aroben@apple.com>
2387
2388         Add a Leaks Viewer tool to build.webkit.org
2389
2390         This tool parses leaks from the files generated by the leaks bot and displays them in a
2391         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
2392         code).
2393
2394         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
2395         be passed to the tool via the "url" query parameter.
2396
2397         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
2398         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
2399         Inspector's Heavy profile view. But it's still pretty useful as-is.
2400
2401         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
2402
2403         Reviewed by Darin Adler.
2404
2405         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
2406         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
2407         (#url-prompt): This is the prompt itself.
2408
2409         (#loading-indicator):
2410         (#loading-indicator > img):
2411         These show a spinner in the bottom-right when we're loading a leaks file.
2412
2413         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
2414         as percentages.
2415
2416         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
2417         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
2418         URL if one wasn't given to us as a query parameter).
2419
2420         (LeaksViewer.get loading):
2421         (LeaksViewer.set loading):
2422         (LeaksViewer.get url):
2423         (LeaksViewer.set url):
2424         Pretty simple accessors.
2425
2426         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
2427         prompt.
2428         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
2429         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
2430         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
2431         the profile to the Web Inspector code once it's been created.
2432         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
2433         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
2434         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
2435         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
2436
2437         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
2438         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
2439         (ProfilerAgent.getProfile): Store the callback.
2440         (ProfilerAgent.profileReady): Call the callback.
2441         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
2442         count and total leak counts as real values, not percentages or milliseconds.
2443
2444         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
2445         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
2446         (parseLeaks): Extract call stacks out of a leaks file.
2447         (createNode): Helper function to create a new empty profile node.
2448         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
2449         WebInspector.ProfileView.
2450
2451         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
2452
2453 2011-03-09  Dan Bernstein  <mitz@apple.com>
2454
2455         Reviewed by Adam Roben.
2456
2457         Combine multiple --ignore-tests values
2458         https://bugs.webkit.org/show_bug.cgi?id=56016
2459
2460         * Scripts/old-run-webkit-tests:
2461
2462 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
2463
2464         Reviewed by David Levin.
2465
2466         Adding myself to the committer file.
2467
2468         * Scripts/webkitpy/common/config/committers.py:
2469
2470 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2471
2472         Rubber-stamped by Adam Roben.
2473
2474         Fix two leaks I introduced into the API tests.
2475
2476         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2477         (TestWebKitAPI::TEST):
2478
2479 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2480
2481         Reviewed by Anders Carlsson.
2482
2483         Crash in CFNetwork visiting google.com
2484         https://bugs.webkit.org/show_bug.cgi?id=55958
2485
2486         Add a test for not trying to copy a null CFURLResponse.
2487
2488         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
2489         (TestWebKitAPI::TEST):
2490         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2491
2492 2011-03-08  Hayato Ito  <hayato@chromium.org>
2493
2494         Reviewed by Ojan Vafai.
2495
2496         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
2497
2498         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
2499
2500         https://bugs.webkit.org/show_bug.cgi?id=55450
2501
2502         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2503
2504 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2505
2506         Reviewed by Martin Robinson.
2507
2508         [GTK] Add layoutTestController.setValueForUser() after r80412
2509         https://bugs.webkit.org/show_bug.cgi?id=55862
2510
2511         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2512         (LayoutTestController::setValueForUser): Implement setValueForUser()
2513
2514 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
2515
2516         Reviewed by Adam Barth.
2517
2518         Add script_shell_command to WebKitPort
2519         https://bugs.webkit.org/show_bug.cgi?id=55925
2520
2521         Add a central place where we generate the shell command from the script name.
2522         This function will be used later to detect the correct script interpreter on Win32.
2523
2524         * Scripts/webkitpy/common/config/ports.py:
2525         * Scripts/webkitpy/layout_tests/port/base.py:
2526         * Scripts/webkitpy/tool/steps/abstractstep.py:
2527         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2528
2529 2011-03-07  Ojan Vafai  <ojan@chromium.org>
2530
2531         Reviewed by Adam Barth.
2532
2533         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
2534         https://bugs.webkit.org/show_bug.cgi?id=55749
2535
2536         * Scripts/webkitpy/tool/commands/upload.py:
2537         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2538         * Scripts/webkitpy/tool/steps/__init__.py:
2539         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
2540         * Scripts/webkitpy/tool/steps/options.py:
2541
2542 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
2543
2544         Reviewed by David Levin.
2545
2546         Add support for DataTransferItems
2547         https://bugs.webkit.org/show_bug.cgi?id=55115
2548
2549         Enable data transfer items in DRT.
2550
2551         * DumpRenderTree/chromium/TestShell.cpp:
2552         (TestShell::TestShell):
2553
2554 2011-03-06  Ojan Vafai  <ojan@chromium.org>
2555
2556         Reviewed by Tony Chang.
2557
2558         [test dashboard] pull treemap files
2559         https://bugs.webkit.org/show_bug.cgi?id=55852
2560
2561         * TestResultServer/handlers/dashboardhandler.py:
2562
2563 2011-03-03  Hayato Ito  <hayato@chromium.org>
2564
2565         Reviewed by Mihai Parparita.
2566
2567         [NRWT] Clear output image file used by DumpRenderTree to make sure the
2568         previous image should not be used in the ChromiumDriver.
2569
2570         Also make sure that output image from the ChromiumDriver should be ''
2571         (empty string) if a test crashes for consistency with the WebKitDriver
2572         implementation.
2573
2574         https://bugs.webkit.org/show_bug.cgi?id=55746
2575
2576         * Scripts/webkitpy/layout_tests/port/chromium.py:
2577
2578 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
2579
2580         Reviewed by Martin Robinson.
2581
2582         [Gtk] fast/js/navigator-language.html fails locally
2583         https://bugs.webkit.org/show_bug.cgi?id=55880
2584
2585         Add LANG variable to the clean environment when running
2586         old-run-webkit-tests script.
2587
2588         * Scripts/old-run-webkit-tests:
2589
2590 2011-03-07  Tony Chang  <tony@chromium.org>
2591
2592         Reviewed by Mihai Parparita.
2593
2594         [Chromium] Find .checksum files without .pngs and vice-versa
2595         https://bugs.webkit.org/show_bug.cgi?id=55236
2596
2597         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
2598             mismatched results.
2599
2600 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
2601
2602         Reviewed by Beth Dakin.
2603
2604         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
2605         https://bugs.webkit.org/show_bug.cgi?id=55706
2606
2607         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
2608
2609         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2610         (AccessibilityController::focusedElement):
2611            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
2612            because it could change at any time.
2613         (AccessibilityController::rootElement):
2614
2615 2011-03-07  Sam Weinig  <sam@webkit.org>
2616
2617         Reviewed by Anders Carlsson.
2618
2619         Add unableToImplementPolicy callback for WebKit2 policy client
2620         <rdar://problem/9071902>
2621         https://bugs.webkit.org/show_bug.cgi?id=55884
2622
2623         * MiniBrowser/mac/BrowserWindowController.m:
2624         (-[BrowserWindowController awakeFromNib]):
2625         Update policy client initialization struct for new member.
2626
2627 2011-03-07  Sam Weinig  <sam@webkit.org>
2628
2629         Reviewed by Anders Carlsson.
2630
2631         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2632         https://bugs.webkit.org/show_bug.cgi?id=55827
2633
2634         * MiniBrowser/mac/BrowserWindowController.m:
2635         (decidePolicyForResponse):
2636         (-[BrowserWindowController awakeFromNib]):
2637         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2638         (TestWebKitAPI::decidePolicyForResponse):
2639         (TestWebKitAPI::TEST):
2640         Update tools for new name.
2641
2642 2011-03-06  Daniel Bates  <dbates@rim.com>
2643
2644         Reviewed by Eric Seidel and David Kilzer.
2645
2646         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
2647         https://bugs.webkit.org/show_bug.cgi?id=55503
2648
2649         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
2650         in checkForJavaSDK().
2651
2652         Also, remove extraneous space in function prototype for unlinkZeroFiles.
2653
2654         * Scripts/build-webkit:
2655
2656 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
2657
2658         Reviewed by Sam Weinig.
2659
2660         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
2661
2662         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2663         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
2664             by willSendRequestForFrame. The API expects a retained reference to the URL request.
2665
2666 2011-03-05  Ilya Sherman  <isherman@chromium.org>
2667
2668         Reviewed by Darin Adler.
2669
2670         HTMLInputElement::setValue() should schedule change event when the element is focused
2671         In service of https://code.google.com/p/chromium/issues/detail?id=42716
2672         https://bugs.webkit.org/show_bug.cgi?id=53160
2673
2674         * DumpRenderTree/LayoutTestController.cpp:
2675         (setValueForUserCallback):
2676         (LayoutTestController::staticFunctions):
2677         * DumpRenderTree/LayoutTestController.h:
2678         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2679         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2680         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2681         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
2682         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2683         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2684         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2685         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2686         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2687         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2688
2689 2011-03-04  Mark Rowe  <mrowe@apple.com>
2690
2691         Reviewed by Alexey Proskuryakov.
2692
2693         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
2694
2695         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
2696         
2697         * DumpRenderTree/mac/CheckedMalloc.cpp:
2698         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
2699         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
2700         and then restore the initial protection flags when we're done.
2701
2702 2011-03-04  Evan Martin  <evan@chromium.org>
2703
2704         Reviewed by Tony Chang.
2705
2706         [gdb] pretty-print KURL in gdb
2707         https://bugs.webkit.org/show_bug.cgi?id=55788
2708
2709         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
2710         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
2711         pretty-printing.
2712
2713 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2714
2715         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
2716
2717         Reviewed by Darin Adler.
2718
2719         * TestWebKitAPI/JavaScriptTest.cpp:
2720         (TestWebKitAPI::javaScriptCallback):
2721         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2722         (TestWebKitAPI::didRunJavaScript):
2723         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2724         (TestWebKitAPI::nullJavaScriptCallback):
2725         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2726         (TestWebKitAPI::didRunJavaScript):
2727
2728 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2729
2730         Make run-api-tests show failed if a test fails.
2731
2732         https://webkit.org/b/55725
2733
2734         Reviewed by Sam Weinig.
2735
2736         * Scripts/run-api-tests:
2737         (runTest): Remove "my" from the nested $result assignment so the
2738         check outside the condition sees the real result.
2739
2740 2011-03-02  MORITA Hajime  <morrita@google.com>
2741
2742         Reviewed by Kent Tamura.
2743
2744         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
2745         https://bugs.webkit.org/show_bug.cgi?id=55434
2746
2747         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
2748         and passed the object webkit_support::PostDelayedTask directly.
2749
2750         Note that the change keeps postTask() as is because it has a
2751         semantics taht webkit_support::PostDelayedTask() has; It jumps to
2752         the main thread.
2753
2754         * DumpRenderTree/chromium/Task.cpp:
2755         (postDelayedTask):
2756         * DumpRenderTree/chromium/Task.h:
2757         (WebTask::Run):
2758
2759 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2760
2761         Reviewed by Kenneth Rohde Christiansen.
2762
2763         [QT] Implement mock client-based geolocation for layout testing
2764         https://bugs.webkit.org/show_bug.cgi?id=54334
2765
2766         Implement testing for Client-Based geolocation for QtWebkit.
2767
2768         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2769         (WebCore::DumpRenderTree::DumpRenderTree):
2770         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2771         (LayoutTestController::reset):
2772         (LayoutTestController::setGeolocationPermission):
2773         (LayoutTestController::setMockGeolocationError):
2774         (LayoutTestController::setMockGeolocationPosition):
2775
2776 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2777
2778         Unreviewed, rolling out r80237.
2779         http://trac.webkit.org/changeset/80237
2780         https://bugs.webkit.org/show_bug.cgi?id=55714
2781
2782         Windows bots aren't ready to be core (Requested by aroben on
2783         #webkit).
2784
2785         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2786         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2787
2788 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
2789
2790         Reviewed by Tony Chang.
2791
2792         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
2793         https://bugs.webkit.org/show_bug.cgi?id=55694
2794         
2795         Fixes for interruptions in NRWT:
2796         - Make TestRunInterruptedException be pickleable correctly (the base
2797           Exception class defines a __reduce__ that does not include the reason)
2798         - Fix ordering of returned arguments from TestRunner2._run_tests
2799           (interrupted and keyboard_interrupted were reversed)
2800         - Fix cancel_workers callsites (was using old name).
2801         - In handle_exception re-raise actual exception instance that was thrown
2802
2803         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2804         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2805         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2806         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2807
2808 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
2809
2810         Unreviewed.
2811
2812         Adding myself as a committer.
2813
2814         * Scripts/webkitpy/common/config/committers.py:
2815
2816 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
2817
2818         Reviewed by Mihai Parparita.
2819
2820         Teach sheriffbot to answer whois commands
2821         https://bugs.webkit.org/show_bug.cgi?id=55687
2822
2823         * Scripts/webkitpy/tool/bot/irc_command.py:
2824         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2825         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2826
2827 2011-03-03  Victoria Kirst  <vrk@google.com>
2828
2829         Reviewed by Eric Carlson.
2830
2831         Enable media tests in chromium-gpu/test_expectations
2832         https://bugs.webkit.org/show_bug.cgi?id=53608
2833
2834         Add media folder to the list of GPU test paths.
2835
2836         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2837
2838 2011-03-03  Adam Roben  <aroben@apple.com>
2839
2840         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
2841
2842         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
2843         incorrect parsing of absolute Windows-style file: URLs
2844
2845         Reviewed by Tim Hatcher.
2846
2847         * WebKitTestRunner/TestInvocation.cpp:
2848         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
2849         <http://webkit.org/b/55683>.
2850
2851 2011-03-03  Tony Chang  <tony@chromium.org>
2852
2853         Reviewed by Dimitri Glazkov.
2854
2855         [chromium] Run kill-old-processes on the chromium-win bot too
2856         https://bugs.webkit.org/show_bug.cgi?id=55630
2857
2858         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2859         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
2860
2861 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2862
2863         Reviewed by Martin Robinson.
2864
2865         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
2866         https://bugs.webkit.org/show_bug.cgi?id=53960
2867
2868         * DumpRenderTree/gtk/EventSender.cpp:
2869         (sendClick):
2870         (scheduleAsynchronousClickCallback):
2871
2872 2011-03-03  Adam Roben  <aroben@apple.com>
2873
2874         Look for Windows-style paths when checking whether a test is an Inspector test
2875
2876         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
2877         out or crash on Windows 7 Release (WebKit2 Tests)
2878
2879         Reviewed by Darin Adler.
2880
2881         * WebKitTestRunner/TestInvocation.cpp:
2882         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
2883         Windows.
2884
2885 2011-03-03  Adam Roben  <aroben@apple.com>
2886
2887         Make Windows 7 Release (Tests) a core builder
2888
2889         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2890         give it a few more days of greenness first.
2891
2892         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2893
2894         Reviewed by Andreas Kling.
2895
2896         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2897         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2898
2899         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2900         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2901         Updated the core regexps to match the buildbot module. Updated the expected results to match
2902         the current set of core builders.
2903
2904 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
2905
2906         Reviewed by Andreas Kling.
2907
2908         Adding myself as a reviewer.
2909
2910         * Scripts/webkitpy/common/config/committers.py:
2911
2912 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
2913
2914         Reviewed by Xan Lopez.
2915
2916         [GTK] Extended application cache database API and added unit tests file.
2917         https://bugs.webkit.org/show_bug.cgi?id=55335
2918
2919         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
2920         of webkit_application_cache_set_maximum_size due to API exposal.
2921
2922 2011-03-02  Ojan Vafai  <ojan@chromium.org>
2923
2924         Reviewed by Adam Barth.
2925
2926         make webkit-patch upload work for security bugs
2927         https://bugs.webkit.org/show_bug.cgi?id=55655
2928
2929         The problem is that we shell out to prepare-ChangeLog,
2930         which does not authenticate with bugzilla. All it needs from
2931         bugzilla is the bug title though. We just pass it through from
2932         webkit-patch instead.
2933
2934         * Scripts/prepare-ChangeLog:
2935         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2936         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2937
2938 2011-03-01  Ojan Vafai  <ojan@chromium.org>
2939
2940         Reviewed by Tony Chang.
2941
2942         [test-dashboard] make gtest JSON match layout-tests JSON
2943         https://bugs.webkit.org/show_bug.cgi?id=55556
2944
2945         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
2946         Make this code match.
2947
2948         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2949
2950 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
2951
2952         Reviewed by Tony Chang.
2953
2954         NRWT - implement Linux Hardy 64-bit port support. This involves
2955         adding support for non-'x86' architectures and updating the
2956         "deduplicate_tests" script to correctly understand that
2957         port.name() is not always equal to basename(port.baseline_path()).
2958
2959         This change introduces two new port names: 'chromium-linux-x86'
2960         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
2961         flag will cause the code to determine which one to use at
2962         runtime, just like we currently do with 'chromium-win'.
2963
2964         https://bugs.webkit.org/show_bug.cgi?id=55535
2965
2966         * Scripts/webkitpy/common/system/executive_mock.py:
2967           Handle 'return_stderr' keyword arg to run_command()
2968         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2969         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2970         * Scripts/webkitpy/layout_tests/port/base.py:
2971         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2972         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2973         * Scripts/webkitpy/layout_tests/port/factory.py:
2974         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2975
2976 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
2977
2978         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
2979         update symlinks accordingly.
2980
2981         * wx/packaging/build-mac-installer.py:
2982
2983 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2984
2985         Unreviewed, rolling out r80139.
2986         http://trac.webkit.org/changeset/80139
2987         https://bugs.webkit.org/show_bug.cgi?id=55620
2988
2989         failing and crashing tests on Snow Leopard bot (Requested by
2990         mihaip1 on #webkit).
2991
2992         * DumpRenderTree/LayoutTestController.cpp:
2993         (LayoutTestController::staticFunctions):
2994         * DumpRenderTree/LayoutTestController.h:
2995         * DumpRenderTree/chromium/LayoutTestController.cpp:
2996         (LayoutTestController::LayoutTestController):
2997         * DumpRenderTree/chromium/LayoutTestController.h:
2998         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2999         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3000         * DumpRenderTree/mac/UIDelegate.h:
3001         * DumpRenderTree/mac/UIDelegate.mm:
3002         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3003         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3004         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3005         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3006
3007 2011-03-02  Adam Roben  <aroben@apple.com>
3008
3009         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
3010
3011         This matches DumpRenderTree on Windows.
3012
3013         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
3014         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
3015         in WebKit2
3016
3017         Reviewed by Beth Dakin.
3018
3019         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3020         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
3021         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
3022
3023 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
3024
3025         Reviewed by David Levin.
3026
3027         Add feature define for data transfer items
3028         https://bugs.webkit.org/show_bug.cgi?id=55510
3029
3030         * Scripts/build-webkit:
3031
3032 2011-03-02  Adam Roben  <aroben@apple.com>
3033
3034         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
3035
3036         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
3037         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
3038         the former location, but was getting lucky on some SnowLeopard machines because symlinks
3039         were being created there pointing into DiagnosticReports. For machines without these
3040         symlinks, crash logs were not getting captured.
3041
3042         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
3043         SnowLeopard machines
3044
3045         Reviewed by Eric Seidel.
3046
3047         * Scripts/old-run-webkit-tests:
3048         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
3049
3050 2011-03-02  Adam Roben  <aroben@apple.com>
3051
3052         Don't try to capture crash logs on platforms that haven't implemented that feature
3053
3054         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
3055         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
3056
3057         Reviewed by Joseph Pecoraro.
3058
3059         * Scripts/old-run-webkit-tests:
3060         (captureSavedCrashLog): Bail if we don't have a crash log glob.
3061         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
3062         strictly required to fix bug 55504, but seems worthwhile.
3063
3064 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
3065
3066         Reviewed by Dmitry Titov.
3067
3068         Detach Geolocation from Frame when Page destroyed.
3069         https://bugs.webkit.org/show_bug.cgi?id=52877
3070
3071         Extend the layout test controller to expose the number of pending
3072         geolocation requests, so that we can test that the requests have
3073         been cancelled on page close.
3074
3075         * DumpRenderTree/LayoutTestController.cpp:
3076         (numberOfPendingGeolocationPermissionRequestsCallback):
3077         (LayoutTestController::staticFunctions):
3078         * DumpRenderTree/LayoutTestController.h:
3079         * DumpRenderTree/chromium/LayoutTestController.cpp:
3080         (LayoutTestController::LayoutTestController):
3081         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3082         * DumpRenderTree/chromium/LayoutTestController.h:
3083         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3084         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3085         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3086         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3087         * DumpRenderTree/mac/UIDelegate.h:
3088         * DumpRenderTree/mac/UIDelegate.mm:
3089         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3090         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3091         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3092         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3093         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3094         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3095         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3096         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3097
3098
3099 2011-03-01  Kent Tamura  <tkent@chromium.org>
3100
3101         Reviewed by Dimitri Glazkov.
3102
3103         Assertion fails when a form validation bubble appears
3104         https://bugs.webkit.org/show_bug.cgi?id=55550
3105
3106         Test: fast/forms/interactive-validation-attach-assertion.html
3107
3108         * DumpRenderTree/chromium/WebPreferences.cpp:
3109         (WebPreferences::applyTo): Enable the interactive validation feature by
3110           default. This matches to Chromium browser.
3111
3112 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3113
3114         Reviewed by Kent Tamura.
3115
3116         Remove efl port style exception of Webcore/JavaScriptCore
3117         https://bugs.webkit.org/show_bug.cgi?id=55549
3118
3119         WebCore and JavaScriptCore need to adhere WebKit coding style.
3120
3121         * Scripts/webkitpy/style/checker.py:
3122
3123 2011-03-01  Tony Chang  <tony@chromium.org>
3124
3125         Reviewed by Ojan Vafai.
3126
3127         [chromium] clean up temp files on chromium-mac builder too
3128         https://bugs.webkit.org/show_bug.cgi?id=55525
3129
3130         * BuildSlaveSupport/chromium/remove-crash-logs:
3131
3132 2011-02-28  Ojan Vafai  <ojan@chromium.org>
3133
3134         Reviewed by Tony Chang.
3135
3136         wrap json in a function call to afford cross-domain loading
3137         https://bugs.webkit.org/show_bug.cgi?id=55353
3138
3139         Also delete the code that compacts the JSON. It turns out this
3140         breaks the rebaseline tool and is probably a premature optimization anyways.
3141
3142         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3143         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3144         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3145         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3146
3147 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3148
3149         Unreviewed, rolling out r80079.
3150         http://trac.webkit.org/changeset/80079
3151         https://bugs.webkit.org/show_bug.cgi?id=55547
3152
3153         "Broke the Win debug build?" (Requested by dcheng on #webkit).
3154
3155         * Scripts/build-webkit:
3156
3157 2011-03-01  Mark Rowe  <mrowe@apple.com>
3158
3159         Reviewed by Sam Weinig.
3160
3161         Update verification scripts to handle WebKit2.
3162
3163         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
3164         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
3165         WebKit2.
3166
3167 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
3168
3169         Reviewed by David Levin.
3170
3171         Add feature define for data transfer items
3172         https://bugs.webkit.org/show_bug.cgi?id=55510
3173
3174         * Scripts/build-webkit:
3175
3176 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
3177
3178         Reviewed by Timothy Hatcher.
3179
3180         All Console Messages should be passed to ChromeClients.
3181         https://bugs.webkit.org/show_bug.cgi?id=54926
3182
3183         Update DumpRenderTree's UIDelegate to use the new console message delegate.
3184
3185         * DumpRenderTree/mac/UIDelegate.mm:
3186         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3187
3188 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3189
3190         Reviewed by Adam Barth.
3191
3192         Tragically, we stopped running the python unit tests
3193         on Chromium Win just as I was getting them to be green.
3194         This patch turns them back on.
3195
3196         https://bugs.webkit.org/show_bug.cgi?id=55521
3197
3198         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3199
3200 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3201
3202         Reviewed by Adam Roben.
3203
3204         Disable
3205         webkitpy.common.system.executive_unittest.ExecutiveTest.\
3206            test_kill_all fails on win until it can be properly triaged.
3207
3208         https://bugs.webkit.org/show_bug.cgi?id=54790
3209
3210         * Scripts/webkitpy/common/system/executive_unittest.py:
3211
3212     2011-03-01  Helder Correia  <helder@sencha.com>
3213
3214             Unreviewed. Add myself to committers.py.
3215
3216             * Scripts/webkitpy/common/config/committers.py:
3217
3218 2011-03-01  Adam Roben  <aroben@apple.com>
3219
3220         Give up if a crash log for the web process is taking too long to be saved on Windows
3221
3222         This should keep the bots from getting stuck while waiting for a crash log, if writing a
3223         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
3224
3225         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
3226         to be saved for the web process
3227
3228         Reviewed by Steve Falkenburg.
3229
3230         * WebKitTestRunner/win/TestControllerWin.cpp:
3231         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
3232         Generalized the code slightly to handle the optional object to wait on.
3233         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
3234         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
3235         prevent us from waiting forever.
3236
3237 2011-03-01  Adam Roben  <aroben@apple.com>
3238
3239         Give WebKitLauncherWin's PDB file a name different from WebKit's
3240
3241         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
3242         fighting over the same PDB file, meaning that one of them was going to lose and not have
3243         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
3244
3245         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
3246         runs (due to missing symbols)
3247
3248         Reviewed by David Kilzer.
3249
3250         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
3251         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
3252
3253 2011-03-01  Adam Roben  <aroben@apple.com>
3254
3255         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
3256
3257         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
3258         --exit-after-n-crashes-or-timeouts limit
3259
3260         Reviewed by David Kilzer.
3261
3262         * Scripts/old-run-webkit-tests:
3263         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
3264         the number of tests that caused the web process to crash when exiting early.
3265
3266 2011-03-01  Adam Roben  <aroben@apple.com>
3267
3268         Save a crash log when the web process crashes
3269
3270         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
3271         until it has finished crashing, which guarantees that the crash log will have had time to be
3272         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
3273         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
3274
3275         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
3276         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
3277
3278         Reviewed by Sam Weinig.
3279
3280         * Scripts/old-run-webkit-tests:
3281         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
3282         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
3283         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
3284         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
3285         WebProces_*.crash files when the web process crashes.
3286
3287         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3288         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
3289         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
3290         along to platformInitialize.
3291
3292         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
3293
3294         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3295         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
3296
3297         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3298         (WTR::InjectedBundle::platformInitialize):
3299         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3300         (WTR::InjectedBundle::platformInitialize):
3301         Updated function signature.
3302
3303         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
3304         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
3305         webProcessCrashingEvent, then lets the crash continue as normal.
3306
3307         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
3308         event we should use to tell the UI process we're crashing from the initializationUserData,
3309         and get a handle to that event.
3310
3311         * WebKitTestRunner/TestController.cpp:
3312         (WTR::TestController::TestController): Initialize new members.
3313         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
3314         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
3315         when a crash log is being saved on Windows. Exit right away if specified. (This is the
3316         default.)
3317
3318         * WebKitTestRunner/TestController.h: Added new members.
3319
3320         * WebKitTestRunner/win/TestControllerWin.cpp:
3321         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
3322         us it's crashing.
3323         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
3324         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
3325         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
3326         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
3327         so the test harness will know the web process has crashed and not try to kill us, then wait
3328         for the web process to finish crashing so a crash log will have time to be saved.
3329         (WTR::toWK): Simple hepler function.
3330         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
3331         process should use to tell us it is crashing in the context's initialization user data.
3332
3333 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
3334
3335         Reviewed by Tony Gentilcore.
3336
3337         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
3338         https://bugs.webkit.org/show_bug.cgi?id=55476
3339
3340         Chromium Win uses BuildAndTestFactory, not TestFactory.
3341
3342         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
3343
3344 2011-03-01  Adam Roben  <aroben@apple.com>
3345
3346         Test that the WebKit2 responsiveness timer doesn't fire too early
3347
3348         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
3349         early on Windows
3350
3351         Reviewed by Anders Carlsson.
3352
3353         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
3354
3355         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
3356         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3357         (TestWebKitAPI::didFinishLoadForFrame):
3358         (TestWebKitAPI::processDidBecomeUnresponsive):
3359         (TestWebKitAPI::setInjectedBundleClient):
3360         (TestWebKitAPI::setPageLoaderClient):
3361         Simple helper functions.
3362
3363         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
3364         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
3365         the responsiveness timer to start, but the web process should unpause before it has a chance
3366         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
3367
3368         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
3369         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
3370         Call up to the base class.
3371         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
3372         pause, sleep for 0.5 seconds, then send back a message saying we paused.
3373
3374         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3375         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
3376         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3377         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
3378
3379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3380         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3381         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3382         Added new files.
3383
3384 2011-03-01  Andras Becsi  <abecsi@webkit.org>
3385
3386         Reviewed by Csaba Osztrogonác.
3387
3388         [Qt] Clean up the project files and move common options to WebKit.pri.
3389
3390         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
3391
3392
3393 2011-03-01  Adam Roben  <aroben@apple.com>
3394
3395         Skip another multiprocessing test on Windows
3396
3397         It is sometimes failing (and may be leaving child Python processes around).
3398         <http://webkit.org/b/55087> tracks the failure.
3399
3400         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
3401         (FuncitonTests.test_get__processes): Skip this test on Windows.
3402
3403 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
3404
3405         Reviewed by Pavel Feldman.
3406
3407         Web Inspector: reduce inspector tests flakiness.
3408         https://bugs.webkit.org/show_bug.cgi?id=55401
3409
3410         * DumpRenderTree/chromium/TestShell.cpp:
3411         (TestShell::runFileTest):
3412         * DumpRenderTree/chromium/WebPreferences.cpp:
3413         (WebPreferences::reset):
3414
3415 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
3416
3417         Reviewed by James Robinson.
3418
3419         NRWT should still upload results when it exits early due to too many failures
3420         https://bugs.webkit.org/show_bug.cgi?id=55432
3421         
3422         Only keyboard interrupts should prevent results from being uploaded.
3423
3424         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3425         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3426
3427 2011-02-28  Alice Liu  <alice.liu@apple.com>
3428
3429         Reviewed by Adam Roben and Gavin Barraclough.
3430
3431         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
3432         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
3433
3434         * TestWebKitAPI/InjectedBundleController.h:
3435         (TestWebKitAPI::InjectedBundleController::bundle):
3436         * TestWebKitAPI/PlatformWebView.h:
3437         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
3438         (TestWebKitAPI::didFinishLoadForFrame):
3439         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3440         (TestWebKitAPI::setPageLoaderClient):
3441         (TestWebKitAPI::TEST):
3442         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
3443         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
3444         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
3445         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
3446         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3447         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3448         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3449         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3450         
3451         Added files to:
3452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3453         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3454         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3455
3456 2011-02-28  Adam Roben  <aroben@apple.com>
3457
3458         Start running InjectedBundle API tests on Windows
3459
3460         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
3461
3462         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
3463
3464         Reviewed by Darin Adler.
3465
3466         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
3467         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
3468         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
3469         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
3470         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
3471         These are just extracted from TestWebKitAPI.vcproj.
3472
3473         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
3474         up the DLL's filename.
3475
3476         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
3477         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
3478         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
3479
3480         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
3481         "all" configuration.
3482
3483         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
3484         injected bundle tests. Let VS resort things.
3485
3486         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
3487
3488 2011-02-28  Adam Roben  <aroben@apple.com>
3489
3490         Add a test for the paint rect passed via WM_PAINT to windowless plugins
3491
3492         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
3493         Large portions of pages with plugins paint black
3494
3495         Reviewed by Anders Carlsson.
3496
3497         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3498         (PluginTest::NPP_HandleEvent):
3499         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3500         Added NPP_HandleEvent. Just returns 0 at this level.
3501
3502         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
3503         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
3504         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
3505         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
3506         WM_PAINT has the expected coordinates.
3507
3508         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3509         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
3510         else.
3511
3512         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
3513         resort things.
3514
3515         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3516         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
3517         This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
3518         webView:didFinishLoadForFrame:] in DumpRenderTree.
3519
3520         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3521         (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
3522         can start running.
3523
3524 2011-02-28  Adam Roben  <aroben@apple.com>
3525
3526         Tell MiniBrowser's WKViews that they're in a window
3527
3528         Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
3529
3530         Reviewed by Anders Carlsson.
3531
3532         * MiniBrowser/win/BrowserView.cpp:
3533         (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
3534
3535 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
3536
3537         Reviewed by Csaba Osztrogonác.
3538
3539         The new QML tests require QML_IMPORT_PATH variable to be set in order to
3540         load the proper plugin.
3541
3542         * Scripts/run-qtwebkit-tests:
3543
3544 2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>
3545
3546         Unreviewed, fix spelling mistake.
3547
3548         hardware-accelated => hardware-accelerated.
3549
3550         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3551
3552 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
3553
3554         Reviewed by Andreas Kling.
3555
3556         Made sure that the build-webkit --qmake argument is always respected.
3557
3558         Previously, it would be respected during the build, but not during
3559         the early feature detection. The build would also fail if qmake was
3560         not in your path, even if you specified --qmake with a valid qmake
3561         binary.
3562
3563         [Qt] WebKit patches required to work with a modularized version of Qt
3564         https://bugs.webkit.org/show_bug.cgi?id=53916
3565
3566         * Scripts/build-webkit:
3567         * Scripts/webkitdirs.pm:
3568
3569 2011-02-27  Ojan Vafai  <ojan@chromium.org>
3570
3571         Fix failing tests from http://trac.webkit.org/changeset/79837.
3572
3573         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3574         This was just a mistake that would break if someone tried printing with this configuration.
3575         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3576         Method signature changed. Didn't notice that this method was being calling in a unittest.
3577
3578 2011-02-24  Hayato Ito  <hayato@chromium.org>
3579
3580         Reviewed by Eric Seidel.
3581
3582         [NRWT] Remove test_types/* classes.
3583
3584         This is the last patch in the series of efforts which tried to remove test_types classes.
3585         A single_test_runner module will take over responsibilities of test_type classes.
3586
3587         From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
3588
3589         https://bugs.webkit.org/show_bug.cgi?id=55123
3590
3591         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3592         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3593         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3594         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3595         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
3596         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
3597         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
3598         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
3599         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
3600         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
3601
3602 2011-02-25  Ojan Vafai  <ojan@chromium.org>
3603
3604         Reviewed by Tony Chang.
3605
3606         Change results.json format to the one used by unexpected_results.json
3607         https://bugs.webkit.org/show_bug.cgi?id=52267
3608
3609         Also add runtimes in milliseconds to the JSON and make the output format more compact.
3610         Named the file full_results.json to avoid conflicting with the results.json
3611         file the test-results server currently serves up.
3612
3613         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3614         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3615         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3616         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3617         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3618         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3619
3620 2011-02-27  Adam Roben  <aroben@apple.com>
3621
3622         Followup fix to r79827
3623
3624         * DumpRenderTree/win/UIDelegate.cpp:
3625         (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
3626         lastPathComponent. This matches what we did here before r79827, and matches Mac.
3627
3628 2011-02-27  Dan Bernstein  <mitz@apple.com>
3629
3630         Reviewed by Adam Roben.
3631
3632         Make bisect-builds print a trac link for the regression range
3633         https://bugs.webkit.org/show_bug.cgi?id=55331
3634
3635         * Scripts/bisect-builds:
3636
3637 2011-02-27  Adam Roben  <aroben@apple.com>
3638
3639         Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
3640
3641         Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
3642         EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
3643         fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
3644
3645         Reviewed by Anders Carlsson.
3646
3647         * DumpRenderTree/win/EditingDelegate.cpp:
3648         (indexOfFirstWordCharacter):
3649         (wordLength):
3650         Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
3651
3652 2011-02-27  Adam Roben  <aroben@apple.com>
3653
3654         Make ResourceLoadDelegate print URLs relative to the main resource on Windows
3655
3656         This matches Mac. (In fact, the code was ported from Mac!)
3657
3658         Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
3659         match Mac
3660
3661         Reviewed by Anders Carlsson.
3662
3663         * DumpRenderTree/win/DumpRenderTree.cpp:
3664         (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
3665         (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
3666         _drt_descriptionSuitableForTestResult].
3667         (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
3668
3669         * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
3670
3671         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
3672         DumpRenderTree.cpp.
3673
3674 2011-02-27  Adam Roben  <aroben@apple.com>
3675
3676         Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
3677
3678         This makes Bugzilla autocompletion work correctly.
3679
3680         * Scripts/webkitpy/common/config/committers.py:
3681
3682 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
3683
3684         Reviewed by Andreas Kling.
3685
3686         [Qt] fast/loader/user-stylesheet-fast-path.html fails
3687         https://bugs.webkit.org/show_bug.cgi?id=50911
3688
3689         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3690         (LayoutTestController::setUserStyleSheetLocation):
3691         Use QUrl::fromEncoded since the passed string is already encoded.
3692
3693 2011-02-27  Adam Roben  <aroben@apple.com>
3694
3695         Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
3696
3697         Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
3698         is different from old-run-webkit-test's. Because of this, the path to the crash log file
3699         (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
3700         details.
3701
3702         Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
3703         --results-directory path is used (like on the test slaves)
3704
3705         Reviewed by Dan Bernstein.
3706
3707         * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
3708         made $testResultsDirectory an absolute path.
3709
3710 2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>
3711
3712         Reviewed by Adam Barth.
3713
3714         m_dumpAccessibilityNotifications should be initialized.
3715         https://bugs.webkit.org/show_bug.cgi?id=54874
3716
3717         * DumpRenderTree/chromium/AccessibilityController.cpp:
3718         (AccessibilityController::AccessibilityController):
3719
3720 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>