[Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
[WebKit.git] / Source / WebKitLegacy / mac / ChangeLog
1 2017-07-18  Andy Estes  <aestes@apple.com>
2
3         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
4         https://bugs.webkit.org/show_bug.cgi?id=174631
5
6         Reviewed by Tim Horton.
7
8         * Configurations/Base.xcconfig:
9
10 2017-07-18  Andy Estes  <aestes@apple.com>
11
12         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
13         https://bugs.webkit.org/show_bug.cgi?id=174631
14
15         Reviewed by Sam Weinig.
16
17         * Configurations/Base.xcconfig:
18
19 2017-07-18  Andy Estes  <aestes@apple.com>
20
21         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
22         https://bugs.webkit.org/show_bug.cgi?id=174631
23
24         Reviewed by Dan Bernstein.
25
26         * Configurations/Base.xcconfig:
27
28 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
29
30         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
31         https://bugs.webkit.org/show_bug.cgi?id=174640
32         <rdar://problem/33297400>
33
34         Reviewed by Tim Horton.
35
36         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
37         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
38         web thread here, to match the other WebView drag and drop SPI methods.
39
40         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
41         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
42         should make this robust against future UIKit changes that could make this no longer the case.
43
44         * WebView/WebView.mm:
45         (-[WebView _requestStartDataInteraction:globalPosition:]):
46         (-[WebView _dataInteractionCaretRect]):
47
48 2017-07-18  Andy Estes  <aestes@apple.com>
49
50         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
51         https://bugs.webkit.org/show_bug.cgi?id=174631
52
53         Reviewed by Darin Adler.
54
55         * Configurations/Base.xcconfig:
56
57 2017-07-17  Sam Weinig  <sam@webkit.org>
58
59         [WebIDL] Remove custom bindings that require non-caching JS strings
60         https://bugs.webkit.org/show_bug.cgi?id=174552
61
62         Reviewed by Darin Adler.
63
64         * DOM/DOMHTMLCanvasElement.mm:
65         (-[DOMHTMLCanvasElement toDataURL:]):
66         Update to account for implementation now returning an UncachedString.
67
68 2017-07-17  Darin Adler  <darin@apple.com>
69
70         Improve use of NeverDestroyed
71         https://bugs.webkit.org/show_bug.cgi?id=174348
72
73         Reviewed by Sam Weinig.
74
75         * Misc/WebStringTruncator.mm:
76         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
77         NeverDestroyed<RetainPtr> with just an NSFont * global.
78
79         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
80         NeverDestroyed.h.
81         * Storage/WebDatabaseManager.mm: Ditto.
82         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
83         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
84
85         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
86         (aeDescFromJSValue): Removed double hashing by using the return value from
87         add rather than calling contains before calling add.
88
89 2017-07-14  Jer Noble  <jer.noble@apple.com>
90
91         Allow clients to override their own hardware media requirements where no fallback media exists.
92         https://bugs.webkit.org/show_bug.cgi?id=174426
93         <rdar://problem/32537704>
94
95         Reviewed by Eric Carlson.
96
97         Add a new WebPreferences property to control WebCore's new
98         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
99
100         * WebView/WebPreferenceKeysPrivate.h:
101         * WebView/WebPreferences.mm:
102         (+[WebPreferences initialize]):
103         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
104         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
105         * WebView/WebPreferencesPrivate.h:
106         * WebView/WebView.mm:
107         (-[WebView _preferencesChanged:]):
108
109 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
110
111         Async image decoding for large images should be disabled by default
112         https://bugs.webkit.org/show_bug.cgi?id=174432
113
114         Reviewed by Simon Fraser.
115
116         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
117         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
118         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
119            a child view instead of propagating PaintBehaviorSnapshotting.
120         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
121            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
122
123         * WebView/WebFrame.mm:
124         (-[WebFrame _paintBehaviorForDestinationContext:]):
125         (-[WebFrame _drawRect:contentsOnly:]):
126         * WebView/WebHTMLView.mm:
127         (imageFromRect):
128
129 2017-07-12  Daniel Bates  <dabates@apple.com>
130
131         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
132         https://bugs.webkit.org/show_bug.cgi?id=174427
133
134         Rubber-stamped by Brady Eidson.
135
136         * WebView/WebPDFView.mm:
137         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
138
139 2017-07-12  Matt Lewis  <jlewis3@apple.com>
140
141         Unreviewed, rolling out r219401.
142
143         This revision rolled out the previous patch, but after talking
144         with reviewer, a rebaseline is what was needed.Rolling back in
145         before rebaseline.
146
147         Reverted changeset:
148
149         "Unreviewed, rolling out r219379."
150         https://bugs.webkit.org/show_bug.cgi?id=174400
151         http://trac.webkit.org/changeset/219401
152
153 2017-07-12  Matt Lewis  <jlewis3@apple.com>
154
155         Unreviewed, rolling out r219379.
156
157         This revision caused a consistent failure in the test
158         fast/dom/Window/property-access-on-cached-window-after-frame-
159         removed.html.
160
161         Reverted changeset:
162
163         "Remove NAVIGATOR_HWCONCURRENCY"
164         https://bugs.webkit.org/show_bug.cgi?id=174400
165         http://trac.webkit.org/changeset/219379
166
167 2017-07-11  Dean Jackson  <dino@apple.com>
168
169         Remove NAVIGATOR_HWCONCURRENCY
170         https://bugs.webkit.org/show_bug.cgi?id=174400
171
172         * Configurations/FeatureDefines.xcconfig:
173
174 2017-07-11  Dean Jackson  <dino@apple.com>
175
176         Rolling out r219372.
177
178         * Configurations/FeatureDefines.xcconfig:
179
180 2017-07-11  Dean Jackson  <dino@apple.com>
181
182         Remove NAVIGATOR_HWCONCURRENCY
183         https://bugs.webkit.org/show_bug.cgi?id=174400
184
185         * Configurations/FeatureDefines.xcconfig:
186
187 2017-07-03  Brian Burg  <bburg@apple.com>
188
189         Web Replay: remove some unused code
190         https://bugs.webkit.org/show_bug.cgi?id=173903
191
192         Rubber-stamped by Joseph Pecoraro.
193
194         * Configurations/FeatureDefines.xcconfig:
195
196 2017-07-09  Brady Eidson  <beidson@apple.com>
197
198         Remove some obsolete WebKitVersionChecks.
199         https://bugs.webkit.org/show_bug.cgi?id=174294
200
201         Reviewed by Dan Bernstein.
202
203         * Misc/WebKitVersionChecks.h:
204
205         * WebView/WebHTMLView.mm:
206         (-[WebHTMLView hitTest:]):
207
208         * WebView/WebView.mm:
209         (shouldRespectPriorityInCSSAttributeSetters):
210         (-[WebView _commonInitializationWithFrameName:groupName:]):
211         (-[WebView _preferencesChanged:]):
212         (shouldTransformsAffectOverflow): Deleted.
213         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
214
215 2017-07-08  Brady Eidson  <beidson@apple.com>
216
217         Remove some obsolete RuntimeApplicationChecks.
218         https://bugs.webkit.org/show_bug.cgi?id=174293
219
220         Reviewed by Dan Bernstein.
221
222         * Misc/WebKitVersionChecks.h:
223         * WebView/WebView.mm:
224         (+[WebView enableWebThread]):
225         (-[WebView _needsPreHTML5ParserQuirks]):
226
227 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
228
229         Drop NOSNIFF compile flag
230         https://bugs.webkit.org/show_bug.cgi?id=174289
231
232         Reviewed by Michael Catanzaro.
233
234         * Configurations/FeatureDefines.xcconfig:
235
236 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
237
238         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
239         https://bugs.webkit.org/show_bug.cgi?id=174150
240
241         Reviewed by Mark Lam.
242
243         * DOM/DOM.mm:
244         (lookupElementClass):
245
246 2017-07-06  Brady Eidson  <beidson@apple.com>
247
248         Add logging to first attempt to use the WebIconDatabase class.
249         https://bugs.webkit.org/show_bug.cgi?id=174190
250
251         Reviewed by Andy Estes.
252
253         * Misc/WebIconDatabase.mm:
254         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
255         * Misc/WebKitVersionChecks.h:
256
257 2017-07-06  Matt Lewis  <jlewis3@apple.com>
258
259         Unreviewed, rolling out r219178.
260
261         This caused a consistent failure with the API test
262         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
263
264         Reverted changeset:
265
266         "[WTF] Clean up StringStatics.cpp by using
267         LazyNeverDestroyed<> for Atoms"
268         https://bugs.webkit.org/show_bug.cgi?id=174150
269         http://trac.webkit.org/changeset/219178
270
271 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
272
273         [WTF] Move SoftLinking.h into WTF
274         https://bugs.webkit.org/show_bug.cgi?id=174000
275
276         Reviewed by Alex Christensen.
277
278         * Plugins/WebNetscapePluginView.mm:
279         * Plugins/WebPluginController.mm:
280         * WebCoreSupport/WebInspectorClient.mm:
281         * WebView/WebFullScreenController.mm:
282         * WebView/WebImmediateActionController.mm:
283         * WebView/WebView.mm:
284
285 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
286
287         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
288         https://bugs.webkit.org/show_bug.cgi?id=174150
289
290         Reviewed by Mark Lam.
291
292         * DOM/DOM.mm:
293         (lookupElementClass):
294
295 2017-07-05  Brady Eidson  <beidson@apple.com>
296
297         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
298         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
299
300         Reviewed by Alex Christensen.
301
302         Adopt to the new constructor for FrameLoadRequest.
303
304         * WebView/WebPDFView.mm:
305         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
306
307 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
308
309         Make WebKit's public headers on Mac and iOS C++ module safe
310         https://bugs.webkit.org/show_bug.cgi?id=174175
311
312         Reviewed by Alex Christensen.
313
314         Fixed the header files.
315
316         * Misc/WebDownload.h:
317         * Misc/WebKitErrors.h:
318         * Plugins/WebPluginContainer.h:
319         * WebView/WebResourceLoadDelegate.h:
320
321 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
322
323         Remove copy of ICU headers from WebKit
324         https://bugs.webkit.org/show_bug.cgi?id=116407
325
326         Reviewed by Alex Christensen.
327
328         Use WTF's copy of ICU headers.
329
330         * Configurations/WebKitLegacy.xcconfig:
331         * icu/unicode/localpointer.h: Removed.
332         * icu/unicode/parseerr.h: Removed.
333         * icu/unicode/platform.h: Removed.
334         * icu/unicode/ptypes.h: Removed.
335         * icu/unicode/putil.h: Removed.
336         * icu/unicode/uchar.h: Removed.
337         * icu/unicode/uconfig.h: Removed.
338         * icu/unicode/ucurr.h: Removed.
339         * icu/unicode/uidna.h: Removed.
340         * icu/unicode/uiter.h: Removed.
341         * icu/unicode/umachine.h: Removed.
342         * icu/unicode/unorm.h: Removed.
343         * icu/unicode/unorm2.h: Removed.
344         * icu/unicode/urename.h: Removed.
345         * icu/unicode/uscript.h: Removed.
346         * icu/unicode/ustring.h: Removed.
347         * icu/unicode/utf.h: Removed.
348         * icu/unicode/utf16.h: Removed.
349         * icu/unicode/utf8.h: Removed.
350         * icu/unicode/utf_old.h: Removed.
351         * icu/unicode/utypes.h: Removed.
352         * icu/unicode/uvernum.h: Removed.
353         * icu/unicode/uversion.h: Removed.
354
355 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
356
357         Add WebKitPrivateFrameworkStubs for iOS 11
358         https://bugs.webkit.org/show_bug.cgi?id=173988
359
360         Reviewed by David Kilzer.
361
362         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
363         use the same directory for private framework stubs.
364
365 2017-07-03  Matt Lewis  <jlewis3@apple.com>
366
367         Unreviewed, rolling out r219103.
368
369         Caused multiple build failures.
370
371         Reverted changeset:
372
373         "Remove copy of ICU headers from WebKit"
374         https://bugs.webkit.org/show_bug.cgi?id=116407
375         http://trac.webkit.org/changeset/219103
376
377 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
378
379         Remove copy of ICU headers from WebKit
380         https://bugs.webkit.org/show_bug.cgi?id=116407
381
382         Reviewed by Alex Christensen.
383
384         Use WTF's copy of ICU headers.
385
386         * Configurations/WebKitLegacy.xcconfig:
387         * icu/unicode/localpointer.h: Removed.
388         * icu/unicode/parseerr.h: Removed.
389         * icu/unicode/platform.h: Removed.
390         * icu/unicode/ptypes.h: Removed.
391         * icu/unicode/putil.h: Removed.
392         * icu/unicode/uchar.h: Removed.
393         * icu/unicode/uconfig.h: Removed.
394         * icu/unicode/ucurr.h: Removed.
395         * icu/unicode/uidna.h: Removed.
396         * icu/unicode/uiter.h: Removed.
397         * icu/unicode/umachine.h: Removed.
398         * icu/unicode/unorm.h: Removed.
399         * icu/unicode/unorm2.h: Removed.
400         * icu/unicode/urename.h: Removed.
401         * icu/unicode/uscript.h: Removed.
402         * icu/unicode/ustring.h: Removed.
403         * icu/unicode/utf.h: Removed.
404         * icu/unicode/utf16.h: Removed.
405         * icu/unicode/utf8.h: Removed.
406         * icu/unicode/utf_old.h: Removed.
407         * icu/unicode/utypes.h: Removed.
408         * icu/unicode/uvernum.h: Removed.
409         * icu/unicode/uversion.h: Removed.
410
411 2017-07-03  Brady Eidson  <beidson@apple.com>
412
413         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
414         https://bugs.webkit.org/show_bug.cgi?id=174073
415
416         Reviewed by Andy Estes.
417
418         WebView now keeps a direct copy of its main frame icon as a member variable.
419         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
420         
421         This change causes a progression in KVO observation of the mainFrameIcon property as we now
422         have both the old icon and new icon at the time it changes.
423
424         * WebCoreSupport/WebFrameLoaderClient.h:
425         * WebCoreSupport/WebFrameLoaderClient.mm:
426         (WebFrameLoaderClient::prepareForDataSourceReplacement):
427         (WebFrameLoaderClient::getLoadDecisionForIcons):
428         (WebFrameLoaderClient::finishedLoadingIcon):
429         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
430         (WebFrameLoaderClient::registerForIconNotification): Deleted.
431
432         * WebView/WebView.mm:
433         (+[WebView _setIconLoadingEnabled:]):
434         (+[WebView _isIconLoadingEnabled]):
435         (-[WebView mainFrameIcon]):
436         (-[WebView _setMainFrameIcon:]):
437         (-[WebView _receivedIconChangedNotification:]): Deleted.
438         (-[WebView _registerForIconNotification:]): Deleted.
439         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
440         * WebView/WebViewData.h:
441         * WebView/WebViewInternal.h:
442         * WebView/WebViewPrivate.h:
443
444 2017-07-03  Sam Weinig  <sam@webkit.org>
445
446         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
447         https://bugs.webkit.org/show_bug.cgi?id=174083
448
449         Reviewed by Alex Christensen.
450
451         * Configurations/FeatureDefines.xcconfig:
452         Add ENABLE_NAVIGATOR_STANDALONE.
453
454 2017-07-03  Tim Horton  <timothy_horton@apple.com>
455
456         Expose unobscuredSafeAreaInsets on WebView
457         https://bugs.webkit.org/show_bug.cgi?id=174075
458         <rdar://problem/33096997>
459
460         Reviewed by Beth Dakin.
461
462         * WebView/WebView.mm:
463         (-[WebView _setUnobscuredSafeAreaInsets:]):
464         (-[WebView _unobscuredSafeAreaInsets]):
465         * WebView/WebViewPrivate.h:
466         Expose unobscuredSafeAreaInsets as a new private property on WebView,
467         similar to how it is exposed in WebKit2.
468
469 2017-07-03  Andy Estes  <aestes@apple.com>
470
471         [Xcode] Add an experimental setting to build with ccache
472         https://bugs.webkit.org/show_bug.cgi?id=173875
473
474         Reviewed by Tim Horton.
475
476         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
477
478 2017-07-03  Tim Horton  <timothy_horton@apple.com>
479
480         Expose WebPreferences for viewport-fit and constant() properties
481         https://bugs.webkit.org/show_bug.cgi?id=174072
482         <rdar://problem/33096639>
483
484         Reviewed by Ryosuke Niwa.
485
486         * WebView/WebPreferenceKeysPrivate.h:
487         * WebView/WebPreferences.mm:
488         (-[WebPreferences viewportFitEnabled]):
489         (-[WebPreferences setViewportFitEnabled:]):
490         (-[WebPreferences constantPropertiesEnabled]):
491         (-[WebPreferences setConstantPropertiesEnabled:]):
492         * WebView/WebPreferencesPrivate.h:
493         * WebView/WebView.mm:
494         (-[WebView _preferencesChanged:]):
495
496 2017-07-01  Tim Horton  <timothy_horton@apple.com>
497
498         Expose viewport-fit value to UIKit via viewport arguments dictionary
499         https://bugs.webkit.org/show_bug.cgi?id=174071
500         <rdar://problem/33096620>
501
502         Reviewed by Wenson Hsieh.
503
504         * History/WebHistoryItem.mm:
505         * History/WebHistoryItemPrivate.h:
506         Add another dictionary key and three values.
507
508 2017-07-01  Dan Bernstein  <mitz@apple.com>
509
510         [iOS] Remove code only needed when building for iOS 9.x
511         https://bugs.webkit.org/show_bug.cgi?id=174068
512
513         Reviewed by Tim Horton.
514
515         * Configurations/FeatureDefines.xcconfig:
516
517 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
518
519         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
520         https://bugs.webkit.org/show_bug.cgi?id=174004
521
522         Reviewed by Simon Fraser.
523
524         * WebCoreSupport/WebPluginInfoProvider.mm:
525
526 2017-07-01  Dan Bernstein  <mitz@apple.com>
527
528         [macOS] Remove code only needed when building for OS X Yosemite
529         https://bugs.webkit.org/show_bug.cgi?id=174067
530
531         Reviewed by Tim Horton.
532
533         * Configurations/Base.xcconfig:
534         * Configurations/DebugRelease.xcconfig:
535         * Configurations/FeatureDefines.xcconfig:
536         * Configurations/Version.xcconfig:
537         * Plugins/WebBasePluginPackage.mm:
538         (-[WebBasePluginPackage getPluginInfoFromPLists]):
539         * WebCoreSupport/PopupMenuMac.mm:
540         (PopupMenuMac::show):
541         * WebCoreSupport/WebInspectorClient.mm:
542         (WebInspectorFrontendClient::startWindowDrag):
543         (-[WebInspectorWindowController window]):
544         * WebView/WebView.mm:
545         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
546
547 2017-06-30  Daniel Bates  <dabates@apple.com>
548
549         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
550         https://bugs.webkit.org/show_bug.cgi?id=165160
551         <rdar://problem/29451999>
552
553         Reviewed by Brady Eidson.
554
555         Pass the document that is requesting the load to the loader.
556
557         * WebView/WebPDFView.mm:
558         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
559
560 2017-06-29  Jer Noble  <jer.noble@apple.com>
561
562         Make Legacy EME API controlled by RuntimeEnabled setting.
563         https://bugs.webkit.org/show_bug.cgi?id=173994
564
565         Reviewed by Sam Weinig.
566
567         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
568
569         * Configurations/FeatureDefines.xcconfig:
570         * WebView/WebPreferenceKeysPrivate.h:
571         * WebView/WebPreferences.mm:
572         (+[WebPreferences initialize]):
573         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
574         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
575         * WebView/WebPreferencesPrivate.h:
576         * WebView/WebView.mm:
577         (-[WebView _preferencesChanged:]):
578
579 2017-06-30  Chris Dumez  <cdumez@apple.com>
580
581         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
582         https://bugs.webkit.org/show_bug.cgi?id=174013
583
584         Reviewed by Brent Fulgham.
585
586         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
587         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
588
589         * WebView/WebView.mm:
590         (-[WebView _commonInitializationWithFrameName:groupName:]):
591
592 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
593
594         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
595         https://bugs.webkit.org/show_bug.cgi?id=174017
596         <rdar://problem/32959782>
597
598         Reviewed by Simon Fraser.
599
600         Use root view coordinates when computing the drag caret rect.
601
602         * WebView/WebView.mm:
603         (-[WebView _dataInteractionCaretRect]):
604
605 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
606
607         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
608         https://bugs.webkit.org/show_bug.cgi?id=173899
609         rdar://problem/32994474
610
611         Reviewed by Tim Horton.
612
613         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
614         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
615         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
616
617         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
618         documentView is a WebHTMLView.
619
620         * WebView/WebFrame.mm:
621         (-[WebFrame _webHTMLDocumentView]):
622         (-[WebFrame _paintBehaviorForDestinationContext:]):
623         (-[WebFrame _drawRect:contentsOnly:]):
624         (-[WebFrame setTimeoutsPaused:]):
625         (-[WebFrame prepareForPause]):
626         (-[WebFrame resumeFromPause]):
627         (-[WebFrame resetTextAutosizingBeforeLayout]):
628         * WebView/WebHTMLView.mm:
629         (-[WebHTMLView drawLayer:inContext:]):
630         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
631         * WebView/WebHTMLViewInternal.h:
632
633 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
634
635         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
636         https://bugs.webkit.org/show_bug.cgi?id=173854
637         <rdar://problem/32236827>
638
639         Reviewed by Ryosuke Niwa and Tim Horton.
640
641         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
642         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
643
644         * WebView/WebView.mm:
645         (-[WebView _startDrag:]):
646         (-[WebView _dragSourceAction]):
647         (-[WebView _draggedLinkTitle]):
648         (-[WebView _draggedLinkURL]):
649         (-[WebView _draggedElementBounds]):
650         (-[WebView _endedDataInteraction:global:]):
651         * WebView/WebViewData.h:
652         * WebView/WebViewPrivate.h:
653
654 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
655
656         Refactor drag start codepaths to plumb a DragItem to client layers
657         https://bugs.webkit.org/show_bug.cgi?id=173832
658         Work towards <rdar://problem/32236827>
659
660         Reviewed by Ryosuke Niwa and Tim Horton.
661
662         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
663         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
664         to _startDrag: to match logic used to start a drag on other platforms.
665
666         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
667         through the DragItem struct.
668
669         * WebCoreSupport/WebDragClient.h:
670         * WebCoreSupport/WebDragClient.mm:
671         (WebDragClient::startDrag):
672         (WebDragClient::dragSourceActionMaskForPoint):
673         (WebDragClient::willPerformDragSourceAction):
674         (WebDragClient::beginDrag):
675         * WebView/WebView.mm:
676         (-[WebView _startDrag:]):
677         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
678         * WebView/WebViewInternal.h:
679
680 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
681
682         Remove excessive headers from JavaScriptCore
683         https://bugs.webkit.org/show_bug.cgi?id=173812
684
685         Reviewed by Darin Adler.
686
687         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
688         * WebView/WebView.mm:
689
690 2017-06-23  Tim Horton  <timothy_horton@apple.com>
691
692         Remove an unused typedef from WebFrameLoaderClient
693         https://bugs.webkit.org/show_bug.cgi?id=173795
694
695         Reviewed by Simon Fraser.
696
697         * WebCoreSupport/WebFrameLoaderClient.h:
698         This unused typedef in the global namespace conflicts with one in a macOS system header.
699         Also... it's unused.
700         Remove it.
701
702 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
703
704         Remove excessive headers from WebCore/{bindings,css,dom}
705         https://bugs.webkit.org/show_bug.cgi?id=173766
706
707         Reviewed by Simon Fraser.
708
709         * DOM/DOMInternal.mm:
710
711 2017-06-22  Daniel Bates  <dabates@apple.com>
712
713         Make FrameLoadRequest a move-only type
714         https://bugs.webkit.org/show_bug.cgi?id=173682
715
716         Reviewed by Alex Christensen and Darin Adler.
717
718         A FrameLoadRequest groups together the information to perform a load into a single object
719         that is more manageable to pass around than its constituent parts. Code that receives a
720         FrameLoadRequest is expected to extract out the information it needs to complete its task.
721         And it does not make sense to re-use the same FrameLoadRequest object for more than one
722         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
723
724         * Plugins/WebPluginController.mm:
725         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
726         * WebView/WebPDFView.mm:
727         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
728
729 2017-06-21  Antoine Quint  <graouts@apple.com>
730
731         Ensure DRT always logs rAF suspension debugging code
732         https://bugs.webkit.org/show_bug.cgi?id=173681
733
734         Reviewed by Tim "Mr. T" Horton.
735
736         * WebView/WebPreferenceKeysPrivate.h:
737         * WebView/WebPreferences.mm:
738         (+[WebPreferences initialize]):
739         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
740         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
741         * WebView/WebPreferencesPrivate.h:
742         * WebView/WebView.mm:
743         (-[WebView _preferencesChanged:]):
744
745 2017-06-21  Daniel Bates  <dabates@apple.com>
746
747         Cleanup FrameLoadRequest
748         https://bugs.webkit.org/show_bug.cgi?id=173564
749         <rdar://problem/32903570>
750
751         Reviewed by Brent Fulgham.
752
753         * WebView/WebPDFView.mm:
754         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
755         into a local variable and use C++11 brace initialization syntax to make it easier to identify
756         the arguments passed to FrameLoader::loadFrameRequest().
757
758 2017-06-21  Antoine Quint  <graouts@apple.com>
759
760         Add logging to identify when the Page suspends scripted animations
761         https://bugs.webkit.org/show_bug.cgi?id=173626
762
763         Reviewed by Tim Horton.
764
765         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
766         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
767
768         * WebView/WebPreferenceKeysPrivate.h:
769         * WebView/WebPreferences.mm:
770         (+[WebPreferences initialize]):
771         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
772         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
773         * WebView/WebPreferencesPrivate.h:
774         * WebView/WebView.mm:
775         (-[WebView _preferencesChanged:]):
776
777 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
778
779         Disable font variations on macOS Sierra and iOS 10
780         https://bugs.webkit.org/show_bug.cgi?id=173618
781         <rdar://problem/32879164>
782
783         Reviewed by Jon Lee.
784
785         * Configurations/FeatureDefines.xcconfig:
786
787 2017-06-20  Daniel Bates  <dabates@apple.com>
788
789         Have FrameLoadRequest takes a Frame& instead of a Frame*
790         https://bugs.webkit.org/show_bug.cgi?id=173614
791         <rdar://problem/32884890>
792
793         Reviewed by Brent Fulgham.
794
795         * Plugins/WebPluginController.mm:
796         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
797         * WebView/WebFrame.mm:
798         (-[WebFrame loadRequest:]):
799         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
800
801 2017-06-19  Frederic Wang  <fwang@igalia.com>
802
803         [Mac] Add an experimental feature setting for async frame scrolling
804         https://bugs.webkit.org/show_bug.cgi?id=173359
805
806         Reviewed by Simon Fraser.
807
808         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
809         * WebView/WebPreferences.mm:
810         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
811         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
812         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
813         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
814         * WebView/WebView.mm:
815         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
816         scrolling.
817
818 2017-06-19  Chris Dumez  <cdumez@apple.com>
819
820         Use WTF::Function instead of std::function in more places in WebCore/
821         https://bugs.webkit.org/show_bug.cgi?id=173535
822
823         Reviewed by Antti Koivisto.
824
825         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
826
827         * WebCoreSupport/WebFrameLoaderClient.h:
828         * WebCoreSupport/WebFrameLoaderClient.mm:
829         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
830         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
831         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
832         (WebFrameLoaderClient::dispatchWillSubmitForm):
833         (WebFrameLoaderClient::setUpPolicyListener):
834         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
835         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
836
837 2017-05-14 Frederic Wang  <fwang@igalia.com>
838
839         Add heuristic to avoid flattening "fullscreen" iframes
840         https://bugs.webkit.org/show_bug.cgi?id=171914
841
842         Reviewed by Simon Fraser.
843
844         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
845
846         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
847         * WebView/WebPreferences.mm:
848         (+[WebPreferences initialize]): Handle frame flattening as an enum.
849         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
850         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
851         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
852         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
853         * WebView/WebPreferencesPrivate.h: Ditto.
854         * WebView/WebView.mm:
855         (-[WebView _preferencesChanged:]): Ditto.
856         * WebView/WebPreferencesPrivate.h: Add new enum definition.
857
858 2017-06-17  Chris Dumez  <cdumez@apple.com>
859
860         Use WTF::Function instead of std::function in WebKit2/
861         https://bugs.webkit.org/show_bug.cgi?id=173504
862
863         Reviewed by Darin Adler.
864
865         Use WTF::Function instead of std::function in WebKit2/ to avoid
866         unnecessary copying.
867
868         * Plugins/Hosted/HostedNetscapePluginStream.h:
869         * Plugins/Hosted/HostedNetscapePluginStream.mm:
870         (WebKit::HostedNetscapePluginStream::willSendRequest):
871         * Plugins/WebNetscapePluginStream.h:
872         * Plugins/WebNetscapePluginStream.mm:
873         (WebNetscapePluginStream::willSendRequest):
874         * WebCoreSupport/WebPaymentCoordinatorClient.h:
875         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
876         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
877         (WebPaymentCoordinatorClient::openPaymentSetup):
878
879 2017-06-16  Sam Weinig  <sam@webkit.org>
880
881         [WebIDL] Remove custom bindings for HTMLDocument
882         https://bugs.webkit.org/show_bug.cgi?id=173444
883
884         Reviewed by Darin Adler.
885
886         * DOM/DOMHTMLDocument.mm:
887         (-[DOMHTMLDocument linkColor]):
888         (-[DOMHTMLDocument setLinkColor:]):
889         (-[DOMHTMLDocument write:]):
890         (-[DOMHTMLDocument writeln:]):
891         Update for new signature of write/writeln and rename of linkColor to linkColorForBindings.
892
893 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
894
895         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
896         https://bugs.webkit.org/show_bug.cgi?id=173366
897         <rdar://problem/32767014>
898
899         Reviewed by Tim Horton.
900
901         Move pieces of iOS WebKit1 drag and drop implementation into OpenSource. No change in behavior.
902
903         * Configurations/FeatureDefines.xcconfig:
904         * WebCoreSupport/WebDragClient.mm:
905         (WebDragClient::useLegacyDragClient):
906         (WebDragClient::willPerformDragDestinationAction):
907         (WebDragClient::dragSourceActionMaskForPoint):
908         (WebDragClient::willPerformDragSourceAction):
909         (WebDragClient::startDrag):
910         (WebDragClient::beginDrag):
911         (WebDragClient::declareAndWriteDragImage):
912         (WebDragClient::declareAndWriteAttachment):
913         (WebDragClient::didConcludeEditDrag):
914         * WebView/WebView.mm:
915         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
916         (-[WebView _getDataInteractionData]):
917         (-[WebView dragDataForSession:client:global:operation:]):
918         (-[WebView _enteredDataInteraction:client:global:operation:]):
919         (-[WebView _updatedDataInteraction:client:global:operation:]):
920         (-[WebView _exitedDataInteraction:client:global:operation:]):
921         (-[WebView _performDataInteraction:client:global:operation:]):
922         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
923         (-[WebView _endedDataInteraction:global:]):
924         (-[WebView _didConcludeEditDataInteraction]):
925         (floatRectsForCGRectArray): Deleted.
926         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]): Deleted.
927         * WebView/WebViewData.h:
928         * WebView/WebViewData.mm:
929         (-[WebViewPrivate dealloc]):
930         * WebView/WebViewPrivate.h:
931
932 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
933
934         [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default
935         https://bugs.webkit.org/show_bug.cgi?id=173454
936         <rdar://problem/31720671>
937
938         Reviewed by Tim Horton.
939
940         Adds -webView:dragDestinationActionMaskForSession: as SPI to WebUIDelegate.
941         If unimplemented, the default UI delegate allows all actions except for URL loading.
942
943         * DefaultDelegates/WebDefaultUIDelegate.mm:
944         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForSession:]):
945         * WebView/WebUIDelegatePrivate.h:
946         * WebView/WebView.mm:
947         (-[WebView dragDestinationActionMaskForSession:]):
948
949 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
950
951         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
952         https://bugs.webkit.org/show_bug.cgi?id=173338
953         <rdar://problem/32777720>
954
955         Reviewed by Tim Horton.
956
957         Rename updatePreferredTypeIdentifiers to updateSupportedTypeIdentifiers.
958
959         * WebCoreSupport/WebPlatformStrategies.h:
960         * WebCoreSupport/WebPlatformStrategies.mm:
961         (WebPlatformStrategies::updateSupportedTypeIdentifiers):
962         (WebPlatformStrategies::updatePreferredTypeIdentifiers): Deleted.
963
964 2017-06-13  Daniel Bates  <dabates@apple.com>
965
966         Implement W3C Secure Contexts Draft Specification
967         https://bugs.webkit.org/show_bug.cgi?id=158121
968         <rdar://problem/26012994>
969
970         Reviewed by Brent Fulgham.
971
972         Part 4
973
974         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
975
976         * WebView/WebPreferenceKeysPrivate.h:
977         * WebView/WebPreferences.mm:
978         (+[WebPreferences initialize]):
979         (-[WebPreferences isSecureContextAttributeEnabled]):
980         (-[WebPreferences setIsSecureContextAttributeEnabled:]):
981         * WebView/WebPreferencesPrivate.h:
982         * WebView/WebView.mm:
983         (-[WebView _preferencesChanged:]):
984
985 2017-06-13  Sam Weinig  <sam@webkit.org>
986
987         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
988         https://bugs.webkit.org/show_bug.cgi?id=80733
989
990         Reviewed by Chris Dumez.
991
992         * DOM/DOMUtility.mm:
993         (createDOMWrapper):
994         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
995         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
996         * WebView/WebFrame.mm:
997         (-[WebFrame _attachScriptDebugger]):
998         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
999
1000 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
1001
1002         [WebCrypto] Remove experimental feature flag of SubtleCrypto
1003         https://bugs.webkit.org/show_bug.cgi?id=173197
1004         <rdar://problem/32688148>
1005
1006         Reviewed by Brent Fulgham.
1007
1008         * WebView/WebPreferences.mm:
1009         (+[WebPreferences initialize]):
1010         (-[WebPreferences subtleCryptoEnabled]): Deleted.
1011         (-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
1012         * WebView/WebPreferencesPrivate.h:
1013         * WebView/WebView.mm:
1014         (-[WebView _preferencesChanged:]):
1015
1016 2017-06-10  Dan Bernstein  <mitz@apple.com>
1017
1018         Reverted r218056 because it made the IDE reindex constantly.
1019
1020         * Configurations/DebugRelease.xcconfig:
1021
1022 2017-06-10  Dan Bernstein  <mitz@apple.com>
1023
1024         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
1025         https://bugs.webkit.org/show_bug.cgi?id=173223
1026
1027         Reviewed by Sam Weinig.
1028
1029         The rebuilds were happening due to a difference in the compiler options that the IDE and
1030         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
1031         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
1032         specify an appropriate path in CLANG_INDEX_STORE_PATH.
1033
1034         * Configurations/DebugRelease.xcconfig:
1035
1036 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1037
1038         [iOS DnD] Add a hook to perform two-step drops in editable content
1039         https://bugs.webkit.org/show_bug.cgi?id=172992
1040         <rdar://problem/32590174>
1041
1042         Reviewed by Tim Horton.
1043
1044         Adds a new SPI to WebUIKitDelegate to allow WK1 clients to override default drop behavior. Returning YES from
1045         -performTwoStepDrop:atDestination:isMove: will prevent content from being inserted on drop in WebKit; otherwise,
1046         returning NO will continue with default WebKit behavior.
1047
1048         * WebCoreSupport/WebEditorClient.h:
1049         * WebCoreSupport/WebEditorClient.mm:
1050         (WebEditorClient::performTwoStepDrop):
1051
1052 2017-06-08  Jer Noble  <jer.noble@apple.com>
1053
1054         Clients of the WK2 C-API don't have their mediaContentTypesRequiringHardwareSupport setting initialized correctly.
1055         https://bugs.webkit.org/show_bug.cgi?id=173091
1056
1057         Reviewed by Eric Carlson.
1058
1059         * WebView/WebPreferences.mm:
1060         (+[WebPreferences initialize]):
1061
1062 2017-06-07  Jer Noble  <jer.noble@apple.com>
1063
1064         Clean-up: RenderElement.h includes headers it doesn't use
1065         https://bugs.webkit.org/show_bug.cgi?id=173046
1066
1067         Reviewed by Andy Estes.
1068
1069         * WebView/WebImmediateActionController.mm:
1070
1071 2017-06-07  Zalan Bujtas  <zalan@apple.com>
1072
1073         [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
1074         https://bugs.webkit.org/show_bug.cgi?id=173044
1075         <rdar://problem/32449338>
1076
1077         Reviewed by Tim Horton.
1078
1079         Cache the current device orientation so that we don't have to lift the WebThread lock
1080         to collect it.
1081
1082         * WebView/WebFrame.mm:
1083         (-[WebFrame deviceOrientationChanged]):
1084         * WebView/WebView.mm:
1085         (-[WebView _commonInitializationWithFrameName:groupName:]):
1086         (-[WebView _setDeviceOrientation:]):
1087         (-[WebView _deviceOrientation]):
1088         * WebView/WebViewData.h:
1089         * WebView/WebViewInternal.h:
1090
1091 2017-06-06  Jer Noble  <jer.noble@apple.com>
1092
1093         [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
1094         https://bugs.webkit.org/show_bug.cgi?id=173008
1095
1096         Reviewed by Eric Carlson.
1097
1098         Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
1099
1100         * WebView/WebPreferenceKeysPrivate.h:
1101         * WebView/WebPreferences.mm:
1102         (+[WebPreferences initialize]):
1103         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
1104         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
1105         * WebView/WebPreferencesPrivate.h:
1106         * WebView/WebView.mm:
1107         (-[WebView _preferencesChanged:]):
1108
1109 2017-06-06  Youenn Fablet  <youenn@apple.com>
1110
1111         Add an option to disable getUserMedia prompt in case of mock capture sources
1112         https://bugs.webkit.org/show_bug.cgi?id=172981
1113         <rdar://problem/32580325>
1114
1115         Reviewed by Eric Carlson.
1116
1117         Defining the option, getter and setter.
1118
1119         * WebView/WebPreferences.mm:
1120         (+[WebPreferences initialize]):
1121         (-[WebPreferences mockCaptureDevicesPromptEnabled]):
1122         (-[WebPreferences setMockCaptureDevicesPromptEnabled:]):
1123         * WebView/WebPreferencesPrivate.h:
1124
1125 2017-06-05  Dan Bernstein  <mitz@apple.com>
1126
1127         Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.
1128
1129         * WebView/WebView.mm:
1130         (-[WebView updateMediaTouchBar]):
1131         * WebView/WebViewData.h:
1132
1133 2017-06-03  Darin Adler  <darin@apple.com>
1134
1135         Streamline handling of attributes, using references as much as possible
1136         https://bugs.webkit.org/show_bug.cgi?id=172899
1137
1138         Reviewed by Chris Dumez.
1139
1140         * WebView/WebHTMLRepresentation.mm:
1141         (matchLabelsAgainstElement): Added handling of nullptr since nothing guarantees the
1142         passed in element can't be null. Removed unnecessary conversion from NSString to String
1143         and then back to NSString.
1144
1145 2017-06-01  Andy Estes  <aestes@apple.com>
1146
1147         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
1148         https://bugs.webkit.org/show_bug.cgi?id=172828
1149
1150         Reviewed by Beth Dakin.
1151
1152         * Configurations/FeatureDefines.xcconfig:
1153
1154 2017-05-31  Andy Estes  <aestes@apple.com>
1155
1156         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
1157         https://bugs.webkit.org/show_bug.cgi?id=172366
1158
1159         Reviewed by Daniel Bates.
1160
1161         * Configurations/FeatureDefines.xcconfig:
1162
1163 2017-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1164
1165         Only include DataDetectorsUI headers in iOS
1166         https://bugs.webkit.org/show_bug.cgi?id=172633
1167
1168         Reviewed by David Kilzer.
1169
1170         Enable data detectors only on iOS and not other variants of iOS.
1171
1172         * WebCoreSupport/WebFrameLoaderClient.mm:
1173
1174 2017-05-30  Alex Christensen  <achristensen@webkit.org>
1175
1176         Update libwebrtc configuration
1177         https://bugs.webkit.org/show_bug.cgi?id=172727
1178
1179         Reviewed by Geoffrey Garen.
1180
1181         * Configurations/FeatureDefines.xcconfig:
1182
1183 2017-05-28  Dan Bernstein  <mitz@apple.com>
1184
1185         [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
1186         https://bugs.webkit.org/show_bug.cgi?id=172691
1187
1188         Reviewed by Tim Horton.
1189
1190         * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
1191
1192 2017-05-26  Brent Fulgham  <bfulgham@apple.com>
1193
1194         [WK2] Address thread safety issues with ResourceLoadStatistics
1195         https://bugs.webkit.org/show_bug.cgi?id=172519
1196         <rdar://problem/31707642>
1197
1198         Reviewed by Chris Dumez.
1199
1200         Create a new WorkQueue for the ResourceLoadStatistics store to use for processing data.
1201
1202         * WebView/WebView.mm:
1203         (WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Pass WorkQueue to the observer.
1204
1205 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
1206
1207         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
1208         https://bugs.webkit.org/show_bug.cgi?id=172554
1209         <rdar://problem/31247133>
1210
1211         Reviewed by Simon Fraser.
1212
1213         Update an overridden internal AppKit function to the new signature.
1214
1215         * WebView/WebHTMLView.mm:
1216         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
1217         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1218         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
1219         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1220
1221 2017-05-24  Jer Noble  <jer.noble@apple.com>
1222
1223         Rename DisplaySleepDisabler -> SleepDisabler
1224         https://bugs.webkit.org/show_bug.cgi?id=172478
1225
1226         Reviewed by Sam Weinig.
1227
1228         * WebView/WebFullScreenController.h:
1229
1230 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
1231
1232         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
1233         https://bugs.webkit.org/show_bug.cgi?id=172522
1234         rdar://problem/31071812
1235
1236         Reviewed by Tim Horton.
1237
1238         There's no need to consult -[NSWindow viewsNeedDisplay] on newer OSes. It was
1239         added in r58623, and modified in r61204 for Carbon apps, but with more recent AppKit
1240         versions this synchronization is no longer required.
1241
1242         * WebView/WebView.mm:
1243         (LayerFlushController::flushLayers):
1244
1245 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
1246
1247         Snapshotting via -renderInContext: should do synchronous image decodes
1248         https://bugs.webkit.org/show_bug.cgi?id=172485
1249         rdar://problem/32276146
1250
1251         Reviewed by Tim Horton.
1252
1253         Remove the _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap: SPI that no longer
1254         has any callers.
1255
1256         * Plugins/WebBaseNetscapePluginView.h:
1257         * Plugins/WebBaseNetscapePluginView.mm:
1258         (-[WebBaseNetscapePluginView inFlatteningPaint]): Deleted.
1259         * WebView/WebFrame.mm:
1260         (-[WebFrame _paintBehaviorForDestinationContext:]):
1261         (-[WebFrame _drawRect:contentsOnly:]):
1262         (-[WebFrame _shouldFlattenCompositingLayers:]): Deleted.
1263         * WebView/WebHTMLView.mm:
1264         (imageFromRect):
1265         * WebView/WebView.mm:
1266         (-[WebView _commonInitializationWithFrameName:groupName:]):
1267         (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): Deleted.
1268         (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]): Deleted.
1269         * WebView/WebViewData.h:
1270         * WebView/WebViewPrivate.h:
1271
1272 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
1273
1274         Remove dead ENABLE(FONT_LOAD_EVENTS) code
1275         https://bugs.webkit.org/show_bug.cgi?id=172517
1276
1277         Rubber-stamped by Simon Fraser.
1278
1279         * Configurations/FeatureDefines.xcconfig:
1280
1281 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
1282
1283         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1284         https://bugs.webkit.org/show_bug.cgi?id=171984
1285
1286         Reviewed by Antti Koivisto.
1287
1288         * WebView/WebPreferenceKeysPrivate.h:
1289         * WebView/WebPreferences.mm:
1290         (+[WebPreferences initialize]):
1291         (-[WebPreferences displayContentsEnabled]):
1292         (-[WebPreferences setDisplayContentsEnabled:]):
1293         * WebView/WebPreferencesPrivate.h:
1294         * WebView/WebView.mm:
1295         (-[WebView _preferencesChanged:]):
1296
1297 2017-05-22  Youenn Fablet  <youenn@apple.com>
1298
1299         Remove AVAudioCaptureSource
1300         https://bugs.webkit.org/show_bug.cgi?id=172360
1301
1302         Reviewed by Sam Weinig.
1303
1304         Removing the handling of AVAudio/CoreAudio capture source dynamic switch.
1305
1306         * WebView/WebPreferenceKeysPrivate.h:
1307         * WebView/WebPreferences.mm:
1308         (+[WebPreferences initialize]):
1309         (-[WebPreferences useAVFoundationAudioCapture]): Deleted.
1310         (-[WebPreferences setUseAVFoundationAudioCapture:]): Deleted.
1311         * WebView/WebPreferencesPrivate.h:
1312         * WebView/WebView.mm:
1313         (-[WebView _preferencesChanged:]):
1314
1315 2017-05-22  Sam Weinig  <sam@webkit.org>
1316
1317         [WebIDL] Support callbacks with arbitrary return types
1318         https://bugs.webkit.org/show_bug.cgi?id=172407
1319
1320         Reviewed by Chris Dumez.
1321
1322         * DOM/DOM.mm:
1323         (-[DOMNodeFilter acceptNode:]):
1324         Update for CallbackResult adoption in the base class.
1325
1326         * DOM/DOMNodeIterator.mm:
1327         * DOM/DOMTreeWalker.mm:
1328         Update to account for new WebCore implementation return types. We return nil
1329         if there was an exception, since retains the existing behavior if a javascript
1330         NodeFilter had been used (an exception would cause all nodes to be rejected,
1331         thus returning nullptr).
1332
1333         * DOM/ObjCNodeFilterCondition.h:
1334         * DOM/ObjCNodeFilterCondition.mm:
1335         Update to match new interface of NodeFilterCondition.
1336
1337 2017-05-18  Sam Weinig  <sam@webkit.org>
1338
1339         [WebIDL] Remove the need for the generator to know about native type mapping
1340         https://bugs.webkit.org/show_bug.cgi?id=172310
1341
1342         Reviewed by Darin Adler.
1343
1344         * DOM/DOM.mm:
1345         (-[DOMNodeFilter acceptNode:]):
1346         Update to pass Node by reference.
1347
1348 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1349
1350         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
1351         https://bugs.webkit.org/show_bug.cgi?id=172098
1352
1353         Reviewed by Saam Barati.
1354
1355         * Plugins/Hosted/ProxyInstance.mm:
1356         * Plugins/Hosted/ProxyRuntimeObject.mm:
1357
1358 2017-05-18  Andy Estes  <aestes@apple.com>
1359
1360         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
1361         https://bugs.webkit.org/show_bug.cgi?id=172305
1362
1363         Reviewed by Anders Carlsson.
1364
1365         * Configurations/FeatureDefines.xcconfig:
1366
1367 2017-05-18  Commit Queue  <commit-queue@webkit.org>
1368
1369         Unreviewed, rolling out r217031, r217032, and r217037.
1370         https://bugs.webkit.org/show_bug.cgi?id=172293
1371
1372         cause linking errors in Windows (Requested by yusukesuzuki on
1373         #webkit).
1374
1375         Reverted changesets:
1376
1377         "[JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass"
1378         https://bugs.webkit.org/show_bug.cgi?id=172098
1379         http://trac.webkit.org/changeset/217031
1380
1381         "Unreviewed, rebaseline for newly added ClassInfo"
1382         https://bugs.webkit.org/show_bug.cgi?id=172098
1383         http://trac.webkit.org/changeset/217032
1384
1385         "Unreviewed, fix debug and non-JIT build"
1386         https://bugs.webkit.org/show_bug.cgi?id=172098
1387         http://trac.webkit.org/changeset/217037
1388
1389 2017-05-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1390
1391         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
1392         https://bugs.webkit.org/show_bug.cgi?id=172098
1393
1394         Reviewed by Saam Barati.
1395
1396         * Plugins/Hosted/ProxyInstance.mm:
1397         * Plugins/Hosted/ProxyRuntimeObject.mm:
1398
1399 2017-05-17  Matt Lewis  <jlewis3@apple.com>
1400
1401         Unreviewed, rolling out r216974.
1402
1403         Revision caused consistent timeouts on all platforms.
1404
1405         Reverted changeset:
1406
1407         "Add a RuntimeEnabledFeature for display: contents, defaulted
1408         to false."
1409         https://bugs.webkit.org/show_bug.cgi?id=171984
1410         http://trac.webkit.org/changeset/216974
1411
1412 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
1413
1414         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1415         https://bugs.webkit.org/show_bug.cgi?id=171984
1416
1417         Reviewed by Antti Koivisto.
1418
1419         * WebView/WebPreferenceKeysPrivate.h:
1420         * WebView/WebPreferences.mm:
1421         (+[WebPreferences initialize]):
1422         (-[WebPreferences displayContentsEnabled]):
1423         (-[WebPreferences setDisplayContentsEnabled:]):
1424         * WebView/WebPreferencesPrivate.h:
1425         * WebView/WebView.mm:
1426         (-[WebView _preferencesChanged:]):
1427
1428 2017-05-16  Sam Weinig  <sam@webkit.org>
1429
1430         Bring Notification.idl up to spec
1431         https://bugs.webkit.org/show_bug.cgi?id=172156
1432
1433         Reviewed by Chris Dumez.
1434
1435         * WebCoreSupport/WebNotificationClient.h:
1436         * WebCoreSupport/WebNotificationClient.mm:
1437         (generateNotificationID):
1438         (WebNotificationClient::show):
1439         (WebNotificationClient::cancel):
1440         (WebNotificationClient::clearNotifications):
1441         (WebNotificationClient::notificationObjectDestroyed):
1442         (WebNotificationClient::requestPermission):
1443         (WebNotificationClient::hasPendingPermissionRequests):
1444         (WebNotificationClient::checkPermission):
1445         (-[WebNotificationPolicyListener allow]):
1446         (-[WebNotificationPolicyListener deny]):
1447         * WebView/WebNotification.mm:
1448         (-[WebNotification iconURL]):
1449         (-[WebNotification dir]):
1450         Simplify #ifdefs and update for enum vs String usage.
1451
1452 2017-05-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
1453
1454         Do not delete asynchronously decoded frames for large images if their clients are in the viewport
1455         https://bugs.webkit.org/show_bug.cgi?id=170640
1456
1457         Reviewed by Simon Fraser.
1458
1459         Enable the async decoding for large images.
1460
1461         * WebView/WebView.mm:
1462         (-[WebView _preferencesChanged:]):
1463
1464 2017-05-15  Jer Noble  <jer.noble@apple.com>
1465
1466         Add experimental setting to allow document gesture interaction to fulfill media playback gesture requirement
1467         https://bugs.webkit.org/show_bug.cgi?id=172131
1468
1469         Reviewed by Eric Carlson.
1470
1471         * WebView/WebPreferenceKeysPrivate.h:
1472         * WebView/WebPreferences.mm:
1473         (+[WebPreferences initialize]):
1474         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
1475         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
1476         * WebView/WebPreferencesPrivate.h:
1477
1478 2017-05-12  Chris Dumez  <cdumez@apple.com>
1479
1480         Drop uses of PassRefPtr in WebKit/mac
1481         https://bugs.webkit.org/show_bug.cgi?id=172066
1482
1483         Reviewed by Sam Weinig.
1484
1485         * History/WebBackForwardListInternal.h:
1486         * History/WebHistoryItem.mm:
1487         (kit):
1488         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
1489         * History/WebHistoryItemInternal.h:
1490         * Plugins/Hosted/HostedNetscapePluginStream.h:
1491         (WebKit::HostedNetscapePluginStream::create):
1492         * Plugins/Hosted/NetscapePluginHostManager.h:
1493         * Plugins/Hosted/NetscapePluginHostManager.mm:
1494         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1495         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1496         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1497         (WebKit::NetscapePluginInstanceProxy::PluginRequest::create):
1498         (WebKit::NetscapePluginInstanceProxy::create):
1499         (WebKit::NetscapePluginInstanceProxy::setManualStream):
1500         * Plugins/Hosted/ProxyInstance.h:
1501         (WebKit::ProxyInstance::create):
1502         * Plugins/Hosted/ProxyInstance.mm:
1503         (WebKit::ProxyInstance::ProxyInstance):
1504         (WebKit::ProxyInstance::newRuntimeObject):
1505         * Plugins/Hosted/ProxyRuntimeObject.h:
1506         (WebKit::ProxyRuntimeObject::create):
1507         * Plugins/Hosted/ProxyRuntimeObject.mm:
1508         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
1509         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1510         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1511         (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1512         * Plugins/WebBaseNetscapePluginView.h:
1513         * Plugins/WebBaseNetscapePluginView.mm:
1514         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1515         * Plugins/WebNetscapePluginStream.h:
1516         (WebNetscapePluginStream::create):
1517         * Plugins/WebNetscapePluginView.h:
1518         * Plugins/WebNetscapePluginView.mm:
1519         (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1520         * WebCoreSupport/WebChromeClient.mm:
1521         * WebCoreSupport/WebEditorClient.mm:
1522         * WebCoreSupport/WebNotificationClient.mm:
1523         (WebNotificationClient::requestPermission):
1524         (-[WebNotificationPolicyListener initWithCallback:]):
1525         * WebCoreSupport/WebOpenPanelResultListener.mm:
1526         * WebCoreSupport/WebUserMediaClient.mm:
1527         (WebUserMediaClient::requestUserMediaAccess):
1528         (WebUserMediaClient::enumerateMediaDevices):
1529         (-[WebUserMediaPolicyListener initWithUserMediaRequest:]):
1530         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
1531         * WebView/WebArchive.mm:
1532         (-[WebArchivePrivate initWithCoreArchive:]):
1533         (-[WebArchivePrivate setCoreArchive:]):
1534         (-[WebArchive initWithData:]):
1535         (-[WebArchive subframeArchives]):
1536         (-[WebArchive _initWithCoreLegacyWebArchive:]):
1537         * WebView/WebArchiveInternal.h:
1538         * WebView/WebDataSource.mm:
1539         (WebDataSourcePrivate::WebDataSourcePrivate):
1540         (WebDataSourcePrivate::~WebDataSourcePrivate):
1541         (-[WebDataSource _initWithDocumentLoader:]):
1542         * WebView/WebDataSourceInternal.h:
1543         * WebView/WebDeviceOrientation.mm:
1544         (-[WebDeviceOrientation initWithCoreDeviceOrientation:]):
1545         * WebView/WebDeviceOrientationInternal.h:
1546         * WebView/WebFrame.mm:
1547         (-[WebFrame _convertToDOMRange:]):
1548         (-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
1549         * WebView/WebFrameInternal.h:
1550         * WebView/WebFullScreenController.h:
1551         * WebView/WebFullScreenController.mm:
1552         (-[WebFullScreenController setElement:]):
1553         * WebView/WebGeolocationPosition.mm:
1554         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1555         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1556         * WebView/WebHTMLView.mm:
1557         (currentKeyboardEvent):
1558         * WebView/WebResource.mm:
1559         * WebView/WebScriptWorld.mm:
1560         (-[WebScriptWorld initWithWorld:]):
1561         (+[WebScriptWorld standardWorld]):
1562         (+[WebScriptWorld findOrCreateWorld:]):
1563         * WebView/WebViewData.h:
1564         (LayerFlushController::create):
1565
1566 2017-05-11  Chris Dumez  <cdumez@apple.com>
1567
1568         Drop remaining uses of PassRefPtr in WebCore
1569         https://bugs.webkit.org/show_bug.cgi?id=172013
1570
1571         Reviewed by Yusuke Suzuki.
1572
1573         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1574         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1575         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
1576         (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
1577         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1578         (-[WebHostedNetscapePluginView createPluginBindingsInstance:]):
1579
1580 2017-05-11  Tim Horton  <timothy_horton@apple.com>
1581
1582         Mail spins launching spell checker when typing
1583         https://bugs.webkit.org/show_bug.cgi?id=171986
1584         <rdar://problem/26305327>
1585
1586         Reviewed by Beth Dakin.
1587
1588         * WebView/WebView.mm:
1589         (-[WebView setEditable:]):
1590         Asynchronously pre-warm the spell checker when a WebView becomes editable.
1591
1592 2017-05-09  Sam Weinig  <sam@webkit.org>
1593
1594         Remove support for legacy Notifications
1595         https://bugs.webkit.org/show_bug.cgi?id=171487
1596
1597         Reviewed by Jon Lee.
1598
1599         * Configurations/FeatureDefines.xcconfig:
1600         * WebCoreSupport/WebNotificationClient.h:
1601         * WebCoreSupport/WebNotificationClient.mm:
1602         * WebView/WebNotification.mm:
1603         * WebView/WebNotificationInternal.h:
1604         * WebView/WebView.mm:
1605         (-[WebView _commonInitializationWithFrameName:groupName:]):
1606         (-[WebView _notificationIDForTesting:]):
1607         Remove legacy notification specific code.
1608
1609 2017-05-10  Chris Dumez  <cdumez@apple.com>
1610
1611         Simplify relationship between Attr and Element now that Attr is childless
1612         https://bugs.webkit.org/show_bug.cgi?id=171909
1613
1614         Reviewed by Ryosuke Niwa.
1615
1616         Build fix.
1617
1618         * DOM/DOMAttr.mm:
1619         (-[DOMAttr value]):
1620         (-[DOMAttr setValue:]):
1621
1622 2017-05-08  Chris Dumez  <cdumez@apple.com>
1623
1624         Move 'style' from Element to HTMLElement / SVGElement and make it settable
1625         https://bugs.webkit.org/show_bug.cgi?id=171795
1626
1627         Reviewed by Alex Christensen.
1628
1629         Build fix.
1630
1631         * DOM/DOMElement.mm:
1632         (-[DOMElement style]):
1633         * WebCoreSupport/WebEditorClient.mm:
1634         (WebEditorClient::shouldApplyStyle):
1635         * WebView/WebFrame.mm:
1636         (-[WebFrame _typingStyle]):
1637
1638 2017-05-06  Chris Dumez  <cdumez@apple.com>
1639
1640         Align our IDL files with the latest DOM specification
1641         https://bugs.webkit.org/show_bug.cgi?id=171777
1642
1643         Reviewed by Sam Weinig.
1644
1645         Build fix.
1646
1647         * DOM/DOMDocument.mm:
1648         (-[DOMDocument readyState]):
1649
1650 2017-05-05  Jeremy Jones  <jeremyj@apple.com>
1651
1652         REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
1653         https://bugs.webkit.org/show_bug.cgi?id=171610
1654         <rdar://problem/31976820>
1655
1656         Reviewed by Eric Carlson.
1657
1658         Fullscreen state gets confused because WK1 WebChromeClient doesn't implement exitVideoFullscreenToModeWithoutAnimation.
1659
1660         * WebCoreSupport/WebChromeClient.h:
1661         * WebCoreSupport/WebChromeClient.mm:
1662         (WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):
1663
1664 2017-05-04  Commit Queue  <commit-queue@webkit.org>
1665
1666         Unreviewed, rolling out r216206.
1667         https://bugs.webkit.org/show_bug.cgi?id=171714
1668
1669         Multiple LayoutTests crashing in Document::page() (Requested
1670         by ap on #webkit).
1671
1672         Reverted changeset:
1673
1674         "Remove support for legacy Notifications"
1675         https://bugs.webkit.org/show_bug.cgi?id=171487
1676         http://trac.webkit.org/changeset/216206
1677
1678 2017-05-04  Jeremy Jones  <jeremyj@apple.com>
1679
1680         UIColor +whiteColor and +clearColor are ambiguous and need to be casted when soft linked.
1681         https://bugs.webkit.org/show_bug.cgi?id=171704
1682
1683         Reviewed by Jer Noble.
1684
1685         Fix build by casting result of +whiteColor to UIColor.
1686
1687         * WebView/WebView.mm:
1688         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
1689
1690 2017-05-04  Sam Weinig  <sam@webkit.org>
1691
1692         Remove support for legacy Notifications
1693         https://bugs.webkit.org/show_bug.cgi?id=171487
1694
1695         Reviewed by Jon Lee.
1696
1697         * Configurations/FeatureDefines.xcconfig:
1698         * WebCoreSupport/WebNotificationClient.h:
1699         * WebCoreSupport/WebNotificationClient.mm:
1700         * WebView/WebNotification.mm:
1701         * WebView/WebNotificationInternal.h:
1702         * WebView/WebView.mm:
1703         (-[WebView _commonInitializationWithFrameName:groupName:]):
1704         (-[WebView _notificationIDForTesting:]):
1705         Remove legacy notification specific code.
1706
1707 2017-05-03  Joseph Pecoraro  <pecoraro@apple.com>
1708
1709         [Cocoa] Stop exporting symbols for ivars that were made private
1710         https://bugs.webkit.org/show_bug.cgi?id=171631
1711
1712         Reviewed by Dan Bernstein.
1713
1714         * WebKit.exp:
1715
1716 2017-05-01  Chris Dumez  <cdumez@apple.com>
1717
1718         Remove some usage of PassRefPtr in editing code
1719         https://bugs.webkit.org/show_bug.cgi?id=171490
1720
1721         Reviewed by Darin Adler.
1722
1723         * WebView/WebFrame.mm:
1724         (-[WebFrame dictationResultMetadataForRange:]):
1725         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1726
1727 2017-05-01  Beth Dakin  <bdakin@apple.com>
1728
1729         On-screen panel for candidate bar is in the wrong place when the caret is at the 
1730         start of a paragraph
1731         https://bugs.webkit.org/show_bug.cgi?id=171453
1732         -and corresponding-
1733         rdar://problem/29779764
1734
1735         Reviewed by Tim Horton.
1736
1737         This bug only happens when the caret is at the beginning of the paragraph, and it 
1738         is because Range::absoluteTextQuads() returns no quads in this case. I think it 
1739         might be correct that absoluteTextQuads() returns no quads in this case, so this 
1740         patch fixes the bug at the call site by using absoluteCaretBounds() in this case.
1741
1742         * WebCoreSupport/WebEditorClient.mm:
1743         (WebEditorClient::handleRequestedCandidates):
1744
1745 2017-04-30  Dan Bernstein  <mitz@apple.com>
1746
1747         [Cocoa] Replaces uses of [get…() alloc] with alloc…Instance()
1748         https://bugs.webkit.org/show_bug.cgi?id=171485
1749
1750         Reviewed by Geoffrey Garen.
1751
1752         * WebView/WebView.mm:
1753         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1754         (-[WebUITextIndicatorData initWithImage:scale:]):
1755
1756 2017-04-28  Youenn Fablet  <youenn@apple.com>
1757
1758         Adding a runtime flag specific to MediaDevices
1759         https://bugs.webkit.org/show_bug.cgi?id=171433
1760
1761         Reviewed by Geoffrey Garen.
1762
1763         Adding a preference for MediaDevices.
1764         Setting media devices runtime flag to false by default.
1765         Setting peer connection and media stream flags to true by default.
1766
1767         * WebView/WebPreferenceKeysPrivate.h:
1768         * WebView/WebPreferences.mm:
1769         (+[WebPreferences initialize]):
1770         (-[WebPreferences mediaDevicesEnabled]):
1771         (-[WebPreferences setMediaDevicesEnabled:]):
1772         * WebView/WebPreferencesPrivate.h:
1773         * WebView/WebView.mm:
1774         (-[WebView _preferencesChanged:]):
1775
1776 2017-04-27  Chris Dumez  <cdumez@apple.com>
1777
1778         Align colspan/rowspan limits with the latest HTML specification
1779         https://bugs.webkit.org/show_bug.cgi?id=171322
1780
1781         Reviewed by Darin Adler.
1782
1783         ObjC bindings build fix.
1784
1785         * DOM/DOMHTMLTableCellElement.mm:
1786         (-[DOMHTMLTableCellElement colSpan]):
1787         (-[DOMHTMLTableCellElement setColSpan:]):
1788
1789 2017-04-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
1790
1791         REGRESSION(r213764): Async decoding of animated images is disabled for ImageDocument
1792         https://bugs.webkit.org/show_bug.cgi?id=170333
1793
1794         Reviewed by Simon Fraser.
1795
1796         Disbale the async decoding for large images for now.
1797
1798         * WebView/WebView.mm:
1799         (-[WebView _preferencesChanged:]):
1800
1801 2017-04-27  Alex Christensen  <achristensen@webkit.org>
1802
1803         Modernize Frame.h
1804         https://bugs.webkit.org/show_bug.cgi?id=171357
1805
1806         Reviewed by Andy Estes.
1807
1808         * WebCoreSupport/WebEditorClient.h:
1809         * WebCoreSupport/WebEditorClient.mm:
1810         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
1811
1812 2017-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1813
1814         [WK1] Tweak the data interaction SPI to indicate whether or not a data interaction was handled
1815         https://bugs.webkit.org/show_bug.cgi?id=171369
1816         <rdar://problem/31858853>
1817
1818         Reviewed by Dan Bernstein.
1819
1820         Introduce a new SPI hook intended to replace performDataInteraction:client:global:operation: that
1821         returns whether or not the data interaction was handled. Due to the difference only in return type
1822         and some staging constraints, this version is prefixed with "_tryTo".
1823
1824         * WebView/WebView.mm:
1825         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
1826         * WebView/WebViewPrivate.h:
1827
1828 2017-04-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1829
1830         WebItemProviderPasteboard should not synchronously load provided data
1831         https://bugs.webkit.org/show_bug.cgi?id=171341
1832         <rdar://problem/31614010>
1833
1834         Reviewed by Tim Horton.
1835
1836         Adds client-layer plumbing for updatePreferredTypeIdentifiers. See WebCore ChangeLog for more details.
1837
1838         * WebCoreSupport/WebPlatformStrategies.h:
1839         * WebCoreSupport/WebPlatformStrategies.mm:
1840         (WebPlatformStrategies::updatePreferredTypeIdentifiers):
1841
1842 2017-04-26  Zalan Bujtas  <zalan@apple.com>
1843
1844         RTL: recent searches popover is displayed in incorrect location
1845         https://bugs.webkit.org/show_bug.cgi?id=171338
1846         <rdar://problem/31377807>
1847
1848         Reviewed by Dean Jackson.
1849
1850         Add RTL support for the pop-under branch.
1851
1852         * WebCoreSupport/PopupMenuMac.mm:
1853         (PopupMenuMac::show):
1854
1855 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
1856
1857         Limit allowed size of document.title to avoid locking WebKit clients
1858         https://bugs.webkit.org/show_bug.cgi?id=165113
1859         <rdar://problem/28324389>
1860
1861         Reviewed by Darin Adler.
1862
1863         When a web application attempts to set an extremely long title, truncate the
1864         title to a more reasonable size.
1865
1866         We do this at at the presentation layer, rather than in the DOM, so that we do
1867         not affect script function. Instead, we merely limit display to a level that is
1868         reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
1869         layer, so it is a waste of effort to send across IPC.
1870
1871         * WebCoreSupport/WebFrameLoaderClient.h:
1872         * WebCoreSupport/WebFrameLoaderClient.mm:
1873         (WebFrameLoaderClient::dispatchDidReceiveTitle):
1874
1875 2017-04-25  Daniel Bates  <dabates@apple.com>
1876
1877         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
1878         https://bugs.webkit.org/show_bug.cgi?id=136452
1879         <rdar://problem/23412620>
1880
1881         Reviewed by Brent Fulgham.
1882
1883         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
1884
1885         * Configurations/FeatureDefines.xcconfig:
1886
1887 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1888
1889         Support reading NSURL titles from the pasteboard when performing data interaction
1890         https://bugs.webkit.org/show_bug.cgi?id=171156
1891         <rdar://problem/31356937>
1892
1893         Reviewed by Tim Horton.
1894
1895         Add a new WK1 SPI property, -[WebFrame hasRichlyEditableDragCaret].
1896
1897         * WebCoreSupport/WebPlatformStrategies.h:
1898         * WebCoreSupport/WebPlatformStrategies.mm:
1899         (WebPlatformStrategies::readURLFromPasteboard):
1900         * WebView/WebFrame.mm:
1901         (-[WebFrame hasRichlyEditableDragCaret]):
1902         * WebView/WebFramePrivate.h:
1903
1904 2017-04-24  Andy VanWagoner  <thetalecrafter@gmail.com>
1905
1906         Clean up ICU headers
1907         https://bugs.webkit.org/show_bug.cgi?id=170997
1908
1909         Reviewed by JF Bastien.
1910
1911         Update all icu headers to 55.1
1912
1913         * icu/README: Explain ICU headers for OS X better
1914         * icu/unicode/localpointer.h:
1915         (LocalPointer::LocalPointer):
1916         (LocalPointer::adoptInsteadAndCheckErrorCode):
1917         * icu/unicode/platform.h:
1918         * icu/unicode/putil.h:
1919         * icu/unicode/uchar.h:
1920         * icu/unicode/uconfig.h:
1921         * icu/unicode/ucurr.h:
1922         * icu/unicode/uidna.h:
1923         * icu/unicode/umachine.h:
1924         * icu/unicode/urename.h:
1925         * icu/unicode/uscript.h:
1926         * icu/unicode/ustring.h:
1927         * icu/unicode/utf8.h:
1928         * icu/unicode/utypes.h:
1929         * icu/unicode/uvernum.h:
1930
1931 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1932
1933         Respect fidelity order when reading web content from item providers
1934         https://bugs.webkit.org/show_bug.cgi?id=171155
1935         <rdar://problem/31356937>
1936
1937         Reviewed by Tim Horton.
1938
1939         Adjusts for changes in WebCore (see WebCore/ChangeLog for more details).
1940
1941         * WebCoreSupport/WebPlatformStrategies.h:
1942         * WebCoreSupport/WebPlatformStrategies.mm:
1943         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex):
1944
1945 2017-04-24  Alex Christensen  <achristensen@webkit.org>
1946
1947         Reduce copies and allocations in SharedBuffer::append
1948         https://bugs.webkit.org/show_bug.cgi?id=170956
1949
1950         Reviewed by Andreas Kling.
1951
1952         * WebView/WebArchive.mm:
1953         (-[WebArchive initWithData:]):
1954         * WebView/WebFrame.mm:
1955         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1956         * WebView/WebResource.mm:
1957         (-[WebResource initWithCoder:]):
1958         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1959
1960 2017-04-24  Dan Bernstein  <mitz@apple.com>
1961
1962         [Cocoa] Some ivars are needlessly @protected
1963         https://bugs.webkit.org/show_bug.cgi?id=171208
1964
1965         Reviewed by Anders Carlsson
1966
1967         Made ivars @private where possible.
1968
1969         * Misc/WebUserContentURLPattern.h:
1970         * Plugins/WebPluginDatabase.h:
1971         * Storage/WebDatabaseQuotaManager.h:
1972         * WebCoreSupport/WebSecurityOriginPrivate.h:
1973         * WebInspector/WebInspector.h:
1974         * WebView/WebDeviceOrientation.h:
1975         * WebView/WebDeviceOrientationProviderMock.h:
1976         * WebView/WebGeolocationPosition.h:
1977         * WebView/WebHTMLRepresentation.h:
1978         * WebView/WebNotification.h:
1979
1980 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1981
1982         Support writing link titles to the pasteboard when beginning data interaction on a link
1983         https://bugs.webkit.org/show_bug.cgi?id=171154
1984         <rdar://problem/31356937>
1985
1986         Reviewed by Andy Estes.
1987
1988         Adjust for some changes in WebCore to introduce a separate codepath for writing PasteboardURLs. See WebCore
1989         and WebKit2 ChangeLogs for more details.
1990
1991         * WebCoreSupport/WebPlatformStrategies.h:
1992         * WebCoreSupport/WebPlatformStrategies.mm:
1993         (WebPlatformStrategies::writeToPasteboard):
1994
1995 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1996
1997         Unreviewed, rolling out r215608.
1998
1999         Hundreds of test failures on GTK bot
2000
2001         Reverted changeset:
2002
2003         "Reduce copies and allocations in SharedBuffer::append"
2004         https://bugs.webkit.org/show_bug.cgi?id=170956
2005         http://trac.webkit.org/changeset/215608
2006
2007 2017-04-21  Alex Christensen  <achristensen@webkit.org>
2008
2009         Reduce copies and allocations in SharedBuffer::append
2010         https://bugs.webkit.org/show_bug.cgi?id=170956
2011
2012         Reviewed by Andreas Kling.
2013
2014         * WebView/WebArchive.mm:
2015         (-[WebArchive initWithData:]):
2016         * WebView/WebFrame.mm:
2017         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
2018         * WebView/WebResource.mm:
2019         (-[WebResource initWithCoder:]):
2020         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
2021
2022 2017-04-20  Dewei Zhu  <dewei_zhu@apple.com>
2023
2024         Build fix to start using C++14.
2025         https://bugs.webkit.org/show_bug.cgi?id=171038
2026
2027         Reviewed by Alex Christensen.
2028
2029         Use 'c++14' instead of 'c++11' in order to use 'auto' in lambda.
2030
2031         * Configurations/WebKitLegacy.xcconfig:
2032
2033 2017-04-19  Youenn Fablet  <youenn@apple.com>
2034
2035         [Mac] Allow customizing H264 encoder
2036         https://bugs.webkit.org/show_bug.cgi?id=170829
2037
2038         Reviewed by Alex Christensen.
2039
2040         * Configurations/FeatureDefines.xcconfig:
2041
2042 2017-04-19  Anders Carlsson  <andersca@apple.com>
2043
2044         Stop using deprecated APIs, part 3
2045         https://bugs.webkit.org/show_bug.cgi?id=171003
2046         rdar://problem/31589635
2047
2048         Reviewed by Tim Horton.
2049
2050         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2051         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2052         (WebPaymentCoordinatorClient::cancelPaymentSession):
2053         Update for WebCore changes.
2054
2055 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2056
2057         [WK2] Support DataTransfer::files() when performing a DHTML data interaction
2058         https://bugs.webkit.org/show_bug.cgi?id=170880
2059         <rdar://problem/31314689>
2060
2061         Reviewed by Tim Horton.
2062
2063         Adjust for a change in PasteboardStrategy. See WebCore ChangeLog for more details.
2064
2065         * WebCoreSupport/WebPlatformStrategies.h:
2066         * WebCoreSupport/WebPlatformStrategies.mm:
2067         (WebPlatformStrategies::getFilenamesForDataInteraction):
2068
2069 2017-04-17  Youenn Fablet  <youenn@apple.com>
2070
2071         Disable outdated WritableStream API
2072         https://bugs.webkit.org/show_bug.cgi?id=170749
2073         <rdar://problem/31446233>
2074
2075         Reviewed by Alex Christensen.
2076
2077         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
2078         - A STREAMS_API compilation flag.
2079         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
2080
2081         * Configurations/FeatureDefines.xcconfig:
2082         * WebView/WebPreferenceKeysPrivate.h:
2083         * WebView/WebPreferences.mm:
2084         (+[WebPreferences initialize]):
2085         (-[WebPreferences readableByteStreamAPIEnabled]):
2086         (-[WebPreferences setReadableByteStreamAPIEnabled:]):
2087         (-[WebPreferences writableStreamAPIEnabled]):
2088         (-[WebPreferences setWritableStreamAPIEnabled:]):
2089         * WebView/WebPreferencesPrivate.h:
2090         * WebView/WebView.mm:
2091         (-[WebView _preferencesChanged:]):
2092
2093 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2094
2095         [WK2] Support data interaction of files into file inputs
2096         https://bugs.webkit.org/show_bug.cgi?id=170803
2097         <rdar://problem/31286130>
2098
2099         Reviewed by Tim Horton.
2100
2101         Add boilerplate plumbing for fetching the number of files in the pasteboard.
2102
2103         * WebCoreSupport/WebPlatformStrategies.h:
2104         * WebCoreSupport/WebPlatformStrategies.mm:
2105         (WebPlatformStrategies::getNumberOfFiles):
2106
2107 2017-04-14  Mark Lam  <mark.lam@apple.com>
2108
2109         Update architectures in xcconfig files.
2110         https://bugs.webkit.org/show_bug.cgi?id=170867
2111         <rdar://problem/31628104>
2112
2113         Reviewed by Joseph Pecoraro.
2114
2115         * Configurations/FeatureDefines.xcconfig:
2116
2117 2017-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2118
2119         [WK2] Support Icon creation from file URLs on iOS
2120         https://bugs.webkit.org/show_bug.cgi?id=170809
2121         <rdar://problem/31286130>
2122
2123         Reviewed by Tim Horton.
2124
2125         Adjust for changes in the ChromeClient in WebCore.
2126
2127         * WebCoreSupport/WebChromeClient.h:
2128         * WebCoreSupport/WebChromeClient.mm:
2129         (WebChromeClient::loadIconForFiles):
2130         (WebChromeClient::createIconForFiles):
2131
2132 2017-04-12  Dan Bernstein  <mitz@apple.com>
2133
2134         [Mac] Future-proof .xcconfig files
2135         https://bugs.webkit.org/show_bug.cgi?id=170802
2136
2137         Reviewed by Tim Horton.
2138
2139         * Configurations/Base.xcconfig:
2140         * Configurations/DebugRelease.xcconfig:
2141         * Configurations/FeatureDefines.xcconfig:
2142         * Configurations/Version.xcconfig:
2143
2144 2017-04-12  Beth Dakin  <bdakin@apple.com>
2145
2146         Build fix.
2147
2148         * WebView/WebViewData.h:
2149
2150 2017-04-12  Brian Weinstein  <bweinstein@apple.com>
2151
2152         Should always override -[WebStorageManager init].
2153         https://bugs.webkit.org/show_bug.cgi?id=170787
2154         -and corresponding-
2155         rdar://problem/31371835
2156
2157         Reviewed by Anders Carlsson.
2158
2159         * Storage/WebStorageManager.mm:
2160         (-[WebStorageManager init]):
2161
2162 2017-04-12  Beth Dakin  <bdakin@apple.com>
2163
2164         Speculative build fix. 
2165
2166         * WebView/WebViewData.h:
2167
2168 2017-04-12  Beth Dakin  <bdakin@apple.com>
2169
2170         Adopt AVKit name change from AVFunctionBar* to AVTouchBar*
2171         https://bugs.webkit.org/show_bug.cgi?id=170693
2172         -and corresponding-
2173         rdar://problem/31230018
2174
2175         Reviewed by Sam Weinig.
2176
2177         Since the new names only apply to some versions of macOS, this patch uses typedefs 
2178         for the older OS’s. SO:
2179
2180         AVFunctionBarScrubber is now AVTouchBarScrubber
2181
2182         AVFunctionBarPlaybackControlsProvider is now AVTouchBarPlaybackControlsProvider
2183
2184         AVFunctionBarMediaSelectionOption is now AVTouchBarMediaSelectionOption
2185
2186         And the protocol AVFunctionBarPlaybackControlsControlling is now 
2187         AVTouchBarPlaybackControlsControlling
2188
2189         Soft links and allocations cannot use the typedefs.
2190         * WebView/WebView.mm:
2191         (-[WebView updateMediaTouchBar]):
2192         * WebView/WebViewData.h:
2193
2194 2017-04-11  Dean Jackson  <dino@apple.com>
2195
2196         Disable outdated WritableStream API
2197         https://bugs.webkit.org/show_bug.cgi?id=170749
2198         <rdar://problem/31446233>
2199
2200         Reviewed by Tim Horton.
2201
2202         The API we implement is no longer accurate. Disable it until we
2203         are compatible with the new specification
2204
2205         * Configurations/FeatureDefines.xcconfig:
2206
2207 2017-04-11  Dan Bernstein  <mitz@apple.com>
2208
2209         [iOS] Simple HTML documents should allow non-markup JavaScript
2210         https://bugs.webkit.org/show_bug.cgi?id=170734
2211
2212         Reviewed by Sam Weinig.
2213
2214         * WebView/WebView.mm:
2215         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Enabled scripting
2216           but disabled scripting markup.
2217
2218 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2219
2220         Revert r215217
2221         https://bugs.webkit.org/show_bug.cgi?id=170703
2222
2223         * Configurations/FeatureDefines.xcconfig:
2224
2225 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2226
2227         Continue enabling WebRTC
2228         https://bugs.webkit.org/show_bug.cgi?id=170703
2229
2230         Reviewed by Youenn Fablet.
2231
2232         * Configurations/FeatureDefines.xcconfig:
2233
2234 2017-04-10  Anders Carlsson  <andersca@apple.com>
2235
2236         Remove call to WKShowKeyAndMain
2237         https://bugs.webkit.org/show_bug.cgi?id=170691
2238         rdar://problem/31050032
2239
2240         Reviewed by Beth Dakin.
2241
2242         * Carbon/CarbonWindowAdapter.mm:
2243         (-[CarbonWindowAdapter makeKeyWindow]):
2244
2245 2017-04-10  Jeremy Jones  <jeremyj@apple.com>
2246
2247         Add CoreAudioCaptureSource.
2248         https://bugs.webkit.org/show_bug.cgi?id=170112
2249         rdar://problem/30293338
2250
2251         Reviewed by Eric Carlson.
2252
2253         Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio.
2254
2255         * WebView/WebPreferenceKeysPrivate.h:
2256         * WebView/WebPreferences.mm:
2257         (+[WebPreferences initialize]):
2258         (-[WebPreferences useAVFoundationAudioCapture]):
2259         (-[WebPreferences setUseAVFoundationAudioCapture:]):
2260         * WebView/WebPreferencesPrivate.h:
2261         * WebView/WebView.mm:
2262         (-[WebView _preferencesChanged:]):
2263
2264 2017-04-10  Chris Dumez  <cdumez@apple.com>
2265
2266         Drop Timer::startOneShot() overload taking a double
2267         https://bugs.webkit.org/show_bug.cgi?id=170659
2268
2269         Reviewed by Yusuke Suzuki.
2270
2271         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
2272
2273         * Plugins/WebNetscapePluginView.mm:
2274         (PluginTimer::start):
2275         * Storage/WebStorageManager.mm:
2276         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
2277
2278 2017-04-09  Chris Dumez  <cdumez@apple.com>
2279
2280         Drop Timer::startRepeating() overload taking a double
2281         https://bugs.webkit.org/show_bug.cgi?id=170656
2282
2283         Reviewed by Yusuke Suzuki.
2284
2285         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
2286
2287         * Plugins/WebNetscapePluginView.mm:
2288         (PluginTimer::start):
2289
2290 2017-04-09  Chris Dumez  <cdumez@apple.com>
2291
2292         Start dropping Timer API dealing with double
2293         https://bugs.webkit.org/show_bug.cgi?id=170649
2294
2295         Reviewed by Yusuke Suzuki.
2296
2297         Start dropping Timer API dealing with double as people should use Seconds now.
2298
2299         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2300         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2301         (WebKit::NetscapePluginInstanceProxy::loadRequest):
2302         * Plugins/WebNetscapePluginStream.mm:
2303         (WebNetscapePluginStream::deliverData):
2304
2305 2017-04-08  Chris Dumez  <cdumez@apple.com>
2306
2307         Drop std::chrono support from Timer class
2308         https://bugs.webkit.org/show_bug.cgi?id=170645
2309
2310         Reviewed by Sam Weinig.
2311
2312         Drop std::chrono support from Timer class now that we prefer using Seconds type.
2313
2314         * WebView/WebView.mm:
2315         (+[WebView _setCacheModel:]):
2316
2317 2017-04-08  Youenn Fablet  <youenn@apple.com>
2318
2319         WebRTC tests gardening
2320         https://bugs.webkit.org/show_bug.cgi?id=170508
2321
2322         Reviewed by Eric Carlson.
2323
2324         * Configurations/FeatureDefines.xcconfig:
2325
2326 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
2327
2328         Unreviewed, rolling out r215046.
2329
2330         This change broke internal builds.
2331
2332         Reverted changeset:
2333
2334         "WebRTC tests gardening"
2335         https://bugs.webkit.org/show_bug.cgi?id=170508
2336         http://trac.webkit.org/changeset/215046
2337
2338 2017-04-06  Tim Horton  <timothy_horton@apple.com>
2339
2340         Obj-C bindings build fails with CSS_DEVICE_ADAPTATION turned on
2341         https://bugs.webkit.org/show_bug.cgi?id=170566
2342
2343         Reviewed by Simon Fraser.
2344
2345         * DOM/DOMCSS.mm:
2346         (kitClass):
2347         Use the WebCore-side enum for this, since that's actually what we're switching over.
2348         This allows us to handle values here without adding them to the API header.
2349         All of the other kitClass() functions work the same way.
2350         Also, unindent for style purposes.
2351
2352 2017-04-06  Youenn Fablet  <youenn@apple.com>
2353
2354         WebRTC tests gardening
2355         https://bugs.webkit.org/show_bug.cgi?id=170508
2356
2357         Reviewed by Eric Carlson.
2358
2359         * Configurations/FeatureDefines.xcconfig:
2360
2361 2017-04-04  Megan Gardner  <megan_gardner@apple.com>
2362
2363         Fix leaks in WebUITextIndicatorData
2364         https://bugs.webkit.org/show_bug.cgi?id=170480
2365
2366         Reviewed by Wenson Hsieh.
2367
2368         Removes extraneous retains.
2369
2370         * WebView/WebView.mm:
2371         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2372
2373 2017-04-04  Tim Horton  <timothy_horton@apple.com>
2374
2375         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
2376         https://bugs.webkit.org/show_bug.cgi?id=165801
2377         <rdar://problem/29649535>
2378
2379         Reviewed by Wenson Hsieh.
2380
2381         * WebView/WebView.mm:
2382         (incrementFrame):
2383         Adjust to the new CanWrap enum.
2384
2385 2017-03-27  Joseph Pecoraro  <pecoraro@apple.com>
2386
2387         Web Inspector: Saving files should not suggest the top level directory
2388         https://bugs.webkit.org/show_bug.cgi?id=170085
2389         <rdar://problem/30197794>
2390
2391         Reviewed by Matt Baker.
2392
2393         * WebCoreSupport/WebInspectorClient.mm:
2394         (WebInspectorFrontendClient::save):
2395         Don't set panel.directoryURL unless we have a good suggestion.
2396
2397 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2398
2399         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
2400         https://bugs.webkit.org/show_bug.cgi?id=169168
2401         <rdar://problem/30688374>
2402
2403         Reviewed by Tim Horton.
2404
2405         Refactors WebDragClient::actionMaskForDrag to take platform data only, rather than the entire DragData. See the
2406         WebCore ChangeLog entry for more details. Also renames WebDefaultUIDelegate.m to WebDefaultUIDelegate.mm, since
2407         we need to import a C++ header for linkedOnOrAfter().
2408
2409         The default delegate implementation of webView:dragDestinationActionMaskForDraggingInfo: now checks if the current
2410         application is linking against 10.12 or earlier, and if so, will allow any drag destination action instead of
2411         the new default value of everything but DragDestinationActionLoad.
2412
2413         * DefaultDelegates/WebDefaultUIDelegate.mm: Renamed from Source/WebKit/mac/DefaultDelegates/WebDefaultUIDelegate.m.
2414         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
2415         * Misc/WebKitVersionChecks.h:
2416         * WebCoreSupport/WebDragClient.h:
2417         * WebCoreSupport/WebDragClient.mm:
2418         (WebDragClient::actionMaskForDrag): Deleted.
2419         * WebView/WebView.mm:
2420         (-[WebView draggingEntered:]):
2421         (-[WebView draggingUpdated:]):
2422
2423 2017-03-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2424
2425         Add support for showing the platform data interaction caret
2426         https://bugs.webkit.org/show_bug.cgi?id=169898
2427         <rdar://problem/31146295>
2428
2429         Reviewed by Beth Dakin.
2430
2431         Plumb the dataInteractionCaretRect through WebView SPI to WebKit1 clients.
2432
2433         * WebView/WebView.mm:
2434         (-[WebView _dataInteractionCaretRect]):
2435         * WebView/WebViewPrivate.h:
2436
2437 2017-03-22  Dan Bernstein  <mitz@apple.com>
2438
2439         [iOS] downloadableBinaryFontsEnabled is set to false in -initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:
2440         https://bugs.webkit.org/show_bug.cgi?id=169967
2441         <rdar://problem/30406898>
2442
2443         Reviewed by Anders Carlsson.
2444
2445         * WebView/WebView.mm:
2446         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Removed call to
2447           Settings::downloadableBinaryFontsEnabled. The default is true.
2448
2449 2017-03-22  Andy Estes  <aestes@apple.com>
2450
2451         [QuickLook] Rename QuickLookHandle to PreviewLoader
2452         https://bugs.webkit.org/show_bug.cgi?id=169961
2453
2454         Reviewed by Andreas Kling.
2455
2456         * WebCoreSupport/WebFrameLoaderClient.h:
2457         * WebCoreSupport/WebFrameLoaderClient.mm:
2458         (WebFrameLoaderClient::createPreviewLoaderClient):
2459         (WebFrameLoaderClient::createQuickLookHandleClient): Deleted.
2460
2461 2017-03-21  Anders Carlsson  <andersca@apple.com>
2462
2463         Remove bogus availability annotations from DOM SPI headers.
2464         rdar://problem/31015675
2465
2466         Rubber-stamped by Dan Bernstein.
2467
2468         * DOM/DOMHTMLMediaElement.h:
2469         * DOM/DOMHTMLVideoElement.h:
2470         * DOM/DOMMediaError.h:
2471         * DOM/DOMTextEvent.h:
2472         * DOM/DOMTimeRanges.h:
2473         * DOM/DOMTokenList.h:
2474
2475 2017-03-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2476
2477         Teach TextIndicator to estimate the background color of the given Range
2478         https://bugs.webkit.org/show_bug.cgi?id=169869
2479         <rdar://problem/31127272>
2480
2481         Reviewed by Anders Carlsson and Simon Fraser.
2482
2483         Plumb the estimated background color for WebKit1 clients through a new property in WebUITextIndicatorData.
2484
2485         * WebView/WebView.mm:
2486         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2487         (-[WebUITextIndicatorData dealloc]):
2488         * WebView/WebViewPrivate.h:
2489
2490 2017-03-20  Dan Bernstein  <mitz@apple.com>
2491
2492         [Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
2493         https://bugs.webkit.org/show_bug.cgi?id=169861
2494
2495         Reviewed by Sam Weinig.
2496
2497         * MigrateHeaders.make: Touch the PrivateHeaders directory when migrating a header into it.
2498         * postprocess-headers.sh: Preserve the timestamp on the headers directories. Write out the
2499           timestamp file used by the Xcode project to determine whether to run the script.
2500
2501 2017-03-19  Alexey Proskuryakov  <ap@apple.com>
2502
2503         WebHTMLView is useless as WebResourceHandler
2504         https://bugs.webkit.org/show_bug.cgi?id=169857
2505
2506         Reviewed by Dan Bernstein.
2507
2508         * WebView/WebHTMLView.mm:
2509         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2510         WebHTMLView doesnt implement any of WebResourceHandler methods.
2511
2512 2017-03-17  Michael Saboff  <msaboff@apple.com>
2513
2514         Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK
2515         https://bugs.webkit.org/show_bug.cgi?id=169817
2516
2517         Reviewed by Filip Pizlo.
2518
2519         * Configurations/FeatureDefines.xcconfig:
2520
2521 2017-03-17  Antti Koivisto  <antti@apple.com>
2522
2523         Add a reload policy where only expired subresources are revalidated
2524         https://bugs.webkit.org/show_bug.cgi?id=169756
2525
2526         Reviewed by Andreas Kling.
2527
2528         * WebView/WebFrame.mm:
2529         (toWebFrameLoadType):
2530         (-[WebFrame reload]):
2531         (-[WebFrame reloadFromOrigin]):
2532
2533 2017-03-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2534
2535         [WK1] Support animated transitions when performing a data interaction operation
2536         https://bugs.webkit.org/show_bug.cgi?id=169805
2537         <rdar://problem/31045767>
2538
2539         Reviewed by Beth Dakin and Megan Gardner.
2540
2541         Adds WebKit1 support for animated transitions when performing a data interaction operation. See per-method changes
2542         for more details.
2543
2544         * DOM/DOMElement.h:
2545         * DOM/DOMElement.mm:
2546         (-[DOMElement boundsInRootViewSpace]):
2547
2548         Introduce -[DOMElement boundsInRootViewSpace], which returns the bounds of the element in root view coordinates.
2549
2550         * WebCoreSupport/WebDragClient.h:
2551         (): Deleted.
2552         * WebCoreSupport/WebDragClient.mm:
2553         (WebDragClient::didConcludeEditDrag):
2554
2555         Add boilerplate plumbing.
2556
2557         * WebView/WebView.mm:
2558         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2559
2560         Add contentImageWithoutSelection and contentImageWithoutSelectionRectInRootViewCoordinates to WebUITextIndicatorData.
2561
2562         (floatRectsForCGRectArray):
2563         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
2564
2565         Introduces a SPI helper method in WebView that clients can use to generate an image of a text platter given an
2566         image of some text, as well as clipping rects to apply to the image.
2567
2568         (-[WebView _dataOperationTextIndicator]):
2569
2570         Add SPI to fetch the text indicator used to drive animations for the current data operation.
2571
2572         (-[WebView _didConcludeEditDataInteraction]):
2573         * WebView/WebViewData.h:
2574         * WebView/WebViewInternal.h:
2575         * WebView/WebViewPrivate.h:
2576
2577 2017-03-16  Simon Fraser  <simon.fraser@apple.com>
2578
2579         Improve the system tracing points
2580         https://bugs.webkit.org/show_bug.cgi?id=169790
2581
2582         Reviewed by Zalan Bujtas.
2583
2584         Use a more cohesive set of system trace points that give a good overview of what
2585         WebKit is doing. Added points for resource loading, render tree building, sync messages
2586         to the web process, async image decode, WASM and fetching cookies.
2587
2588         * WebView/WebHTMLView.mm:
2589         (-[WebHTMLView drawRect:]):
2590
2591 2017-03-16  Youenn Fablet  <youenn@apple.com>
2592
2593         Wrap legacy WebRTC API in runtime flag
2594         https://bugs.webkit.org/show_bug.cgi?id=169646
2595
2596         Reviewed by Alex Christensen.
2597
2598         * WebView/WebPreferenceKeysPrivate.h:
2599         * WebView/WebPreferences.mm:
2600         (+[WebPreferences initialize]):
2601         (-[WebPreferences webRTCLegacyAPIEnabled]):
2602         (-[WebPreferences setWebRTCLegacyAPIEnabled:]):
2603         * WebView/WebPreferencesPrivate.h:
2604         * WebView/WebView.mm:
2605         (-[WebView _preferencesChanged:]):
2606
2607 2017-03-14  Megan Gardner  <megan_gardner@apple.com>
2608
2609         Correctly export WebItemProviderPasteboard
2610         https://bugs.webkit.org/show_bug.cgi?id=169578
2611
2612         Reviewed by Tim Horton.
2613
2614         * MigrateHeaders.make:
2615
2616 2017-03-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2617
2618         [WK2] Data interaction tests occasionally hit assertions in debug builds
2619         https://bugs.webkit.org/show_bug.cgi?id=169002
2620         <rdar://problem/30994806>
2621
2622         Reviewed by Tim Horton.
2623
2624         Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.
2625
2626         * WebView/WebHTMLView.mm:
2627         (-[WebHTMLView _updateSelectionForInputManager]):
2628         * WebView/WebView.mm:
2629         (-[WebView updateTextTouchBar]):
2630
2631 2017-03-13  Anders Carlsson  <andersca@apple.com>
2632
2633         Fix build warnings.
2634
2635         * WebCoreSupport/WebInspectorClient.mm:
2636         (WebInspectorFrontendClient::save):
2637         (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2638
2639 2017-03-11  Brady Eidson  <beidson@apple.com>
2640
2641         Cleanup "addCookie" and its sole user.
2642         https://bugs.webkit.org/show_bug.cgi?id=169486
2643
2644         Reviewed by Brian Burg.
2645
2646         * WebCoreSupport/WebPlatformStrategies.h:
2647         * WebCoreSupport/WebPlatformStrategies.mm:
2648         (WebPlatformStrategies::addCookie): Deleted.
2649
2650 2017-03-10  Alex Christensen  <achristensen@webkit.org>
2651
2652         Fix watch and tv builds after r213294
2653         https://bugs.webkit.org/show_bug.cgi?id=169508
2654
2655         Reviewed by Dan Bernstein.
2656
2657         * Configurations/FeatureDefines.xcconfig:
2658
2659 2017-03-10  Alex Christensen  <achristensen@webkit.org>
2660
2661         Fix CMake build.
2662
2663         * WebView/WebNotification.h:
2664         Don't assume we have already included something that includes NSObject.h.
2665
2666 2017-03-09  Daniel Bates  <dabates@apple.com>
2667
2668         Guard Credential Management implementation behind a runtime enabled feature flag
2669         https://bugs.webkit.org/show_bug.cgi?id=169364
2670         <rdar://problem/30957425>
2671
2672         Reviewed by Brent Fulgham.
2673
2674         Add WebKit preference for Credential Management (disabled by default).
2675
2676         * WebView/WebPreferenceKeysPrivate.h:
2677         * WebView/WebPreferences.mm:
2678         (+[WebPreferences initialize]):
2679         (-[WebPreferences credentialManagementEnabled]): Added.
2680         (-[WebPreferences setCredentialManagementEnabled:]): Added.
2681         * WebView/WebPreferencesPrivate.h:
2682         * WebView/WebView.mm:
2683         (-[WebView _preferencesChanged:]):
2684
2685 2017-03-09  Anders Carlsson  <andersca@apple.com>
2686
2687         Add delegate support to WebCore
2688         https://bugs.webkit.org/show_bug.cgi?id=169427
2689         Part of rdar://problem/28880714.
2690
2691         Reviewed by Geoffrey Garen.
2692
2693         * Configurations/FeatureDefines.xcconfig:
2694         Add feature define.
2695
2696 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
2697
2698         Fix DataInteraction guards
2699         https://bugs.webkit.org/show_bug.cgi?id=169404
2700
2701         Reviewed by Wenson Hsieh.
2702
2703         * WebCoreSupport/WebDragClient.mm:
2704
2705 2017-03-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2706
2707         Add plumbing for WebCore to notify WebKit2 when an edit drag has concluded
2708         https://bugs.webkit.org/show_bug.cgi?id=169392
2709         <rdar://problem/30882974>
2710
2711         Reviewed by Tim Horton.
2712
2713         Add a stub implementation of WebDragClient::didConcludeEditDrag.
2714
2715         * WebCoreSupport/WebDragClient.h:
2716
2717 2017-03-08  Anders Carlsson  <andersca@apple.com>
2718
2719         Simplify the PaymentCoordinator interface
2720         https://bugs.webkit.org/show_bug.cgi?id=169382
2721         Part of rdar://problem/28880714.
2722
2723         Reviewed by Tim Horton.
2724
2725         Update for PaymentCoordinatorClient changes.
2726
2727         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2728         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2729         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
2730         (WebPaymentCoordinatorClient::completeShippingContactSelection):
2731         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
2732         (WebPaymentCoordinatorClient::completePaymentSession):
2733
2734 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
2735
2736         Fix for dependency fix
2737         https://bugs.webkit.org/show_bug.cgi?id=169369
2738
2739         Reviewed by Beth Dakin.
2740
2741         * WebView/WebViewPrivate.h:
2742
2743 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
2744
2745         Fix Project Dependency
2746         https://bugs.webkit.org/show_bug.cgi?id=169340
2747
2748         Unreviewed Dependency Fix.
2749
2750         * WebView/WebViewPrivate.h:
2751
2752 2017-03-07  Alexey Proskuryakov  <ap@apple.com>
2753
2754         WebKitLegacy should re-export symbols from WebCore on watchos and tvos
2755         https://bugs.webkit.org/show_bug.cgi?id=169341
2756         <rdar://problem/30913788>
2757
2758         Reviewed by Dan Bernstein.
2759
2760         * MigrateHeaders.make:
2761
2762 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
2763
2764         Have fixedPositionCreatesStackingContext be on by default everywhere
2765         https://bugs.webkit.org/show_bug.cgi?id=169334
2766
2767         Reviewed by Zalan Bujtas.
2768
2769         It makes no sense to have web-exposed CSS functionality be different based on setting,
2770         and other browser are now aligned with having position:fixed create stacking context.
2771
2772         So remove the fixedPositionCreatesStackingContext setting and have StyleResolver::adjustRenderStyle()
2773         always force stacking context for position:fixed.
2774
2775         * WebView/WebView.mm:
2776         (-[WebView _preferencesChanged:]):
2777
2778 2017-03-06  Simon Fraser  <simon.fraser@apple.com>
2779
2780         Initialize the subpixelAntialiasedLayerTextEnabled Setting in WebKit1
2781         https://bugs.webkit.org/show_bug.cgi?id=169230
2782
2783         Reviewed by Tim Horton.
2784
2785         * WebView/WebView.mm:
2786         (-[WebView _preferencesChanged:]):
2787
2788 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
2789
2790         Enable SubpixelAntialiasedLayerTextEnabled by default on some versions of macOS
2791         https://bugs.webkit.org/show_bug.cgi?id=169329
2792
2793         Reviewed by Tim Horton.
2794
2795         If the macOS version is > 101300, enable subpixelAntialiasedLayerTextEnabled.
2796
2797         * WebView/WebPreferences.mm:
2798         (+[WebPreferences initialize]):
2799
2800 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
2801
2802         Additional DataInteraction Support
2803         https://bugs.webkit.org/show_bug.cgi?id=169316
2804         <rdar://problem/30884234>
2805
2806         Reviewed by Wenson Hsieh.
2807
2808         Add stub implementations to WebView for methods that handle data interaction
2809
2810         * WebView/WebView.mm:
2811         (-[WebView _enteredDataInteraction:client:global:operation:]):
2812         (-[WebView _updatedDataInteraction:client:global:operation:]):
2813         (-[WebView _exitedDataInteraction:client:global:operation:]):
2814         (-[WebView _performDataInteraction:client:global:operation:]):
2815         (-[WebView _endedDataInteraction:global:]):
2816         * WebView/WebViewPrivate.h:
2817
2818 2017-03-07  Dean Jackson  <dino@apple.com>
2819
2820         Some platforms won't be able to create a GPUDevice
2821         https://bugs.webkit.org/show_bug.cgi?id=169314
2822         <rdar://problems/30907521>
2823
2824         Reviewed by Jon Lee.
2825
2826         Disable WEB_GPU on the iOS Simulator.
2827
2828         * Configurations/FeatureDefines.xcconfig:
2829
2830 2017-03-07  Maureen Daum  <mdaum@apple.com>
2831
2832         Correctly check for an empty database file.
2833         <rdar://problem/30542242> Removing Website Data not working (WebSQL directories being left behind)
2834         https://bugs.webkit.org/show_bug.cgi?id=169256
2835
2836         Reviewed by Brady Eidson.
2837
2838         Check if the folder for an origin's WebSQL databases is empty after trying to delete
2839         all of its files. Currently we check if the deletedDatabaseFileCount matches the number
2840         of files that were in the folder. However, when we delete the actual database file in
2841         DatabaseTracker::deleteDatabaseFileIfEmpty(), the shm and wal files get deleted along with
2842         the database file, but deletedDatabaseFileCount only gets incremented once.
2843
2844         * Storage/WebDatabaseManager.mm:
2845         (+[WebDatabaseManager removeEmptyDatabaseFiles]):
2846         Delete the folder if it is empty.
2847
2848 2017-03-06  Michael Saboff  <msaboff@apple.com>
2849
2850         Unreviewed build fix to add
2851         -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
2852         for objective C++ files.
2853
2854         * Configurations/WebKitLegacy.xcconfig:
2855
2856 2017-03-06  Michael Saboff  <msaboff@apple.com>
2857
2858         Take advantage of fast permissions switching of JIT memory for devices that support it
2859         https://bugs.webkit.org/show_bug.cgi?id=169155
2860
2861         Reviewed by Saam Barati.
2862
2863         Updated the Xcode config files to match what is in the JavaScriptCore ones.
2864
2865         * Configurations/FeatureDefines.xcconfig:
2866
2867 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
2868
2869         Expand font-weight and font-stretch to take any number
2870         https://bugs.webkit.org/show_bug.cgi?id=168889
2871
2872         Reviewed by Simon Fraser.
2873
2874         Migrate off old enum types.
2875
2876         * WebCoreSupport/PopupMenuMac.mm:
2877         (PopupMenuMac::populate):
2878         * WebView/WebHTMLView.mm:
2879         (fontNameForDescription):
2880         * WebView/WebView.mm:
2881         (-[WebView updateTextTouchBar]):
2882
2883 2017-03-03  Dean Jackson  <dino@apple.com>
2884
2885         Add WebGPU compile flag and experimental feature flag
2886         https://bugs.webkit.org/show_bug.cgi?id=169161
2887         <rdar://problem/30846689>
2888
2889         Reviewed by Tim Horton.
2890
2891         Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
2892         and an InternalSetting.
2893
2894         * Configurations/FeatureDefines.xcconfig:
2895         * WebView/WebPreferenceKeysPrivate.h:
2896         * WebView/WebPreferences.mm:
2897         (+[WebPreferences initialize]):
2898         (-[WebPreferences webGPUEnabled]):
2899         (-[WebPreferences setWebGPUEnabled:]):
2900         * WebView/WebPreferencesPrivate.h:
2901         * WebView/WebView.mm:
2902         (-[WebView _preferencesChanged:]):
2903
2904 2017-03-03  Alexey Proskuryakov  <ap@apple.com>
2905
2906         Build fix
2907         rdar://problem/30825660
2908
2909         Suggested by Dan Bernstein.
2910
2911         * Configurations/WebKitLegacy.xcconfig:
2912
2913 2017-03-02  Sam Weinig  <sam@webkit.org>
2914
2915         Rename htmlediting.h/cpp to Editing.h/cpp
2916         https://bugs.webkit.org/show_bug.cgi?id=169103
2917
2918         Reviewed by Alex Christensen.
2919
2920         * DOM/DOMUIKitExtensions.mm:
2921         * WebView/WebFrame.mm:
2922         * WebView/WebView.mm:
2923
2924 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2925
2926         Fix 32-bit
2927         https://bugs.webkit.org/show_bug.cgi?id=169114
2928
2929         Reviewed by Alex Christensen.
2930
2931         * WebView/WebView.mm:
2932
2933 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2934
2935         More guard fixing
2936         https://bugs.webkit.org/show_bug.cgi?id=169112
2937
2938         Reviewed by Alex Christensen.
2939
2940         Fixed an internal build.
2941
2942         * WebView/WebView.mm:
2943         * WebView/WebViewPrivate.h:
2944
2945 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
2946
2947         Data Interaction build fixes
2948         https://bugs.webkit.org/show_bug.cgi?id=169096
2949
2950         Reviewed by Tim Horton.
2951
2952         Guards weren't all correct, also missed a selector name change.
2953
2954         * WebView/WebView.mm:
2955         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
2956         * WebView/WebViewData.h:
2957         * WebView/WebViewData.mm:
2958         (-[WebViewPrivate dealloc]):
2959
2960 2017-03-02  Alex Christensen  <achristensen@webkit.org>
2961
2962         Continue enabling WebRTC
2963         https://bugs.webkit.org/show_bug.cgi?id=169056
2964
2965         Reviewed by Jon Lee.
2966
2967         * Configurations/FeatureDefines.xcconfig:
2968
2969 2017-03-01  Megan Gardner  <megan_gardner@apple.com>
2970
2971         Data interaction support for WK1
2972         https://bugs.webkit.org/show_bug.cgi?id=169062
2973
2974         Reviewed by Wenson Hsieh.
2975
2976         Support for data interaction in WebKit1
2977
2978         * WebCoreSupport/WebDragClient.mm:
2979         * WebView/WebView.mm:
2980         (-[WebUITextIndicatorData initWithImage:TextIndicatorData:scale:]):
2981         (-[WebUITextIndicatorData initWithImage:scale:]):
2982         (-[WebUITextIndicatorData dealloc]):
2983         (-[WebView _requestStartDataInteraction:globalPosition:]):
2984         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
2985         (-[WebView _getDataInteractionData]):
2986         * WebView/WebViewData.h:
2987         * WebView/WebViewData.mm:
2988         (-[WebViewPrivate dealloc]):
2989         * WebView/WebViewInternal.h:
2990         * WebView/WebViewPrivate.h:
2991
2992 2017-03-02  Youenn Fablet  <youenn@apple.com>
2993
2994         [WebRTC] Activate ICE candidate privacy policy
2995         https://bugs.webkit.org/show_bug.cgi?id=168975
2996
2997         Reviewed by Alex Christensen.
2998
2999         * WebView/WebPreferenceKeysPrivate.h:
3000         * WebView/WebPreferences.mm:
3001         (-[WebPreferences enumeratingAllNetworkInterfacesEnabled]):
3002         (-[WebPreferences setEnumeratingAllNetworkInterfacesEnabled:]):
3003         (-[WebPreferences iceCandidateFilteringEnabled]):
3004         (-[WebPreferences setIceCandidateFilteringEnabled:]):
3005         * WebView/WebPreferencesPrivate.h:
3006
3007 2017-03-01  Alex Christensen  <achristensen@webkit.org>
3008
3009         Unreviewed, rolling out r213259.
3010
3011         Broke an internal build
3012
3013         Reverted changeset:
3014
3015         "Continue enabling WebRTC"
3016         https://bugs.webkit.org/show_bug.cgi?id=169056
3017         http://trac.webkit.org/changeset/213259
3018
3019 2017-03-01  Alex Christensen  <achristensen@webkit.org>
3020
3021         Continue enabling WebRTC
3022         https://bugs.webkit.org/show_bug.cgi?id=169056
3023
3024         Reviewed by Jon Lee.
3025
3026         * Configurations/FeatureDefines.xcconfig:
3027
3028 2017-02-27  Alex Christensen  <achristensen@webkit.org>
3029
3030         Begin enabling WebRTC on 64-bit
3031         https://bugs.webkit.org/show_bug.cgi?id=168915
3032
3033         Reviewed by Eric Carlson.
3034
3035         * Configurations/FeatureDefines.xcconfig:
3036
3037 2017-02-27  Aakash Jain  <aakash_jain@apple.com>
3038
3039         Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
3040         https://bugs.webkit.org/show_bug.cgi?id=168919
3041
3042         Reviewed by Tim Horton.
3043
3044         * Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
3045         * migrate-headers.sh: Run the migrate-headers script for installapi phase.
3046
3047 2017-02-27  Alex Christensen  <achristensen@webkit.org>
3048
3049         [libwebrtc] Enable WebRTC in some Production Builds
3050         https://bugs.webkit.org/show_bug.cgi?id=168858
3051
3052         * Configurations/FeatureDefines.xcconfig:
3053
3054 2017-02-26  Alexey Proskuryakov  <ap@apple.com>
3055
3056         Don't import RetainPtr in WebNotification.h
3057         https://bugs.webkit.org/show_bug.cgi?id=168876
3058
3059         Reviewed by Dan Bernstein.
3060
3061         This is an Objective-C SPI header.
3062
3063         * WebView/WebNotification.h:
3064         * WebView/WebNotification.mm:
3065         (-[WebNotification initWithCoreNotification:notificationID:]):
3066         (-[WebNotification dealloc]):
3067
3068 2017-02-26  Aakash Jain  <aakash_jain@apple.com>
3069
3070         Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
3071         https://bugs.webkit.org/show_bug.cgi?id=168819
3072
3073         Reviewed by Dan Bernstein.
3074
3075         * Configurations/WebKitLegacy.xcconfig:
3076
3077 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
3078
3079         Export Objective-C symbols for variables in Webkit SPI
3080         https://bugs.webkit.org/show_bug.cgi?id=168758
3081
3082         Reviewed by Alexey Proskuryakov.
3083
3084         * Configurations/WebKitLegacy.xcconfig: using separate .exp file for i386.
3085         * WebKit.exp: Added various Objective-C symbols.
3086
3087 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
3088
3089         Move instance members from WKQuadObject to implementation file
3090         https://bugs.webkit.org/show_bug.cgi?id=168740
3091
3092         Reviewed by Tim Horton.
3093
3094         * DOM/DOM.mm: Moving instance member to implementation file.
3095         * DOM/DOMExtensions.h: Ditto.
3096
3097 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
3098
3099         Move iOS specific symbols to WebKit.ios.exp
3100         https://bugs.webkit.org/show_bug.cgi?id=168726
3101
3102         Reviewed by Alexey Proskuryakov.
3103
3104         * WebKit.exp:
3105
3106 2017-02-21  Youenn Fablet  <youenn@apple.com>
3107
3108         [WebRTC][Mac] Activate libwebrtc
3109         https://bugs.webkit.org/show_bug.cgi?id=167293
3110         <rdar://problem/30401864>
3111
3112         Reviewed by Alex Christensen.
3113
3114         * Configurations/FeatureDefines.xcconfig:
3115
3116 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3117
3118         Export various NSString symbols from WebFramePrivate.h
3119         https://bugs.webkit.org/show_bug.cgi?id=168702
3120
3121         Reviewed by Alexey Proskuryakov.
3122
3123         * WebKit.exp:
3124
3125 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3126
3127         Export various NSString symbols from WebPreferencesPrivate.h
3128         https://bugs.webkit.org/show_bug.cgi?id=168701
3129
3130         Reviewed by Alexey Proskuryakov.
3131
3132         * WebKit.exp:
3133
3134 2017-02-21  Joseph Pecoraro  <pecoraro@apple.com>
3135
3136         Add missing WebConsoleMessage string key
3137         https://bugs.webkit.org/show_bug.cgi?id=168690
3138
3139         Reviewed by Alexey Proskuryakov.
3140
3141         * WebKit.exp:
3142         * WebView/WebUIDelegatePrivate.h:
3143         This key has an implementation but was not extern / exported like the others.
3144
3145 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3146
3147         Export various NSString symbols from WebViewPrivate.h
3148         https://bugs.webkit.org/show_bug.cgi?id=168689
3149
3150         Reviewed by Alexey Proskuryakov.
3151
3152         * WebKit.exp:
3153
3154 2017-02-21  Commit Queue  <commit-queue@webkit.org>
3155
3156         Unreviewed, rolling out r212768.
3157         https://bugs.webkit.org/show_bug.cgi?id=168698
3158
3159         Rolling out since this would break other projects. (Requested
3160         by aakashjain on #webkit).
3161
3162         Reverted changeset:
3163
3164         "[iOS] Remove old WebKit1 MemoryMeasure helper."
3165         https://bugs.webkit.org/show_bug.cgi?id=168675
3166         http://trac.webkit.org/changeset/212768
3167
3168 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
3169
3170         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
3171         https://bugs.webkit.org/show_bug.cgi?id=168620
3172         <rdar://problem/30617772>
3173
3174         Reviewed by Tim Horton.
3175
3176         * WebView/WebPreferenceKeysPrivate.h:
3177         * WebView/WebPreferences.mm:
3178         (+[WebPreferences initialize]):
3179         (-[WebPreferences subpixelAntialiasedLayerTextEnabled]):
3180         (-[WebPreferences setSubpixelAntialiasedLayerTextEnabled:]):
3181         * WebView/WebPreferencesPrivate.h:
3182
3183 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3184
3185         Export various NSString symbols from WebUIDelegatePrivate.h
3186         https://bugs.webkit.org/show_bug.cgi?id=168679
3187
3188         Reviewed by Joseph Pecoraro.
3189
3190         * WebKit.exp:
3191
3192 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3193
3194         Export symbols for various classes present in webkit SPI
3195         https://bugs.webkit.org/show_bug.cgi?id=168674
3196
3197         Reviewed by Dan Bernstein.
3198
3199         * WebKit.exp:
3200
3201 2017-02-21  Andreas Kling  <akling@apple.com>
3202
3203         [iOS] Remove old WebKit1 MemoryMeasure helper.
3204         <https://webkit.org/b/168675>
3205
3206         Reviewed by Sam Weinig.
3207
3208         * Configurations/WebKitLegacy.xcconfig:
3209         * Misc/WebCache.mm:
3210         (+[WebCache emptyInMemoryResources]):
3211         * WebView/WebView.mm:
3212
3213 2017-02-21  Andreas Kling  <akling@apple.com>
3214
3215         [iOS] WebKit1 should use shared memory pressure handler code.
3216         <https://webkit.org/b/168653>
3217
3218         Reviewed by Antti Koivisto.
3219
3220         Register a WebThread-aware memory callback with the shared MemoryPressureHandler
3221         and get rid of the old iOS WebKit1 specific implementation. Some of it was even
3222         dead code since MobileSafari has been using WebKit2 for quite a while.
3223
3224         * WebView/WebView.h:
3225         * WebView/WebView.mm:
3226         (WebInstallMemoryPressureHandler):
3227         (+[WebView _handleMemoryWarning]): Deleted.
3228         (+[WebView registerForMemoryNotifications]): Deleted.
3229         (+[WebView releaseFastMallocMemoryOnCurrentThread]): Deleted.
3230         (+[WebView garbageCollectNow]): Deleted.
3231         (+[WebView purgeInactiveFontData]): Deleted.
3232         (+[WebView drainLayerPool]): Deleted.
3233         (+[WebView discardAllCompiledCode]): Deleted.
3234         (+[WebView _clearMemoryPressure]): Deleted.
3235         (+[WebView _shouldWaitForMemoryClearMessage]): Deleted.
3236         * WebView/WebViewPrivate.h:
3237
3238 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3239
3240         Stop exporting interface WebCoreScrollView on iOS
3241         https://bugs.webkit.org/show_bug.cgi?id=168536
3242
3243         Reviewed by Dan Bernstein.
3244
3245         * WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
3246         * WebKit.mac.exp: Ditto.
3247         * WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.
3248
3249 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3250
3251         Exclude various mac-specific header files from iOS build
3252         https://bugs.webkit.org/show_bug.cgi?id=168621
3253
3254         Reviewed by Dan Bernstein.
3255
3256         * Configurations/WebKitLegacy.xcconfig:
3257
3258 2017-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3259
3260         Add plumbing to the UI process for TextIndicatorData when computing the drag image
3261         https://bugs.webkit.org/show_bug.cgi?id=168583
3262         Work towards <rdar://problem/30313681>
3263
3264         Accounts for changes in WebCore -- see Source/WebCore/ChangeLog for more details.
3265
3266         Reviewed by Tim Horton.
3267
3268         * WebView/WebHTMLView.mm:
3269         (-[WebHTMLView _selectionDraggingImage]):
3270         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
3271
3272 2017-02-17  Anders Carlsson  <andersca@apple.com>
3273
3274         Add a new drag code path and use it for dragging plain text
3275         https://bugs.webkit.org/show_bug.cgi?id=168534
3276
3277         Reviewed by Geoffrey Garen.
3278
3279         * WebCoreSupport/WebDragClient.h:
3280         Add new members.
3281
3282         * WebCoreSupport/WebDragClient.mm:
3283         (WebDragClient::useLegacyDragClient):
3284         Return false here.
3285
3286         (WebDragClient::beginDrag):
3287         New client member function. Create an NSDraggingItem and use it to begin a dragging session.
3288
3289         * WebView/WebHTMLView.mm:
3290         (-[WebHTMLView draggingSession:sourceOperationMaskForDraggingContext:]):
3291         Get the source operation mask from WebCore.
3292
3293         (-[WebHTMLView draggingSession:endedAtPoint:operation:]):
3294         Send a fake mouse up event.
3295
3296         * WebView/WebHTMLViewInternal.h:
3297         Declare that WebHTMLView conforms to NSDraggingSource.
3298
3299 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
3300
3301         List of WebCore symbols to re-export from WebKitLegacy should be built automatically
3302         https://bugs.webkit.org/show_bug.cgi?id=168342
3303         rdar://problem/26182266
3304
3305         Reviewed by Tim Horton.
3306
3307         * MigrateHeaders.make: On iOS only, process re-exported headers to build a list of
3308         symbols to re-export.
3309
3310 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3311
3312         Stop exporting DOMTokenList from WebKit
3313         https://bugs.webkit.org/show_bug.cgi?id=168544
3314
3315         Reviewed by Alexey Proskuryakov.
3316
3317         * WebKit.exp:
3318
3319 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
3320
3321         Clean up how WebKit exports _WebCreateFragment
3322         https://bugs.webkit.org/show_bug.cgi?id=168579
3323
3324         Reviewed by Dan Bernstein.
3325
3326         * WebCoreSupport/WebCreateFragmentInternal.h: Added a private header.
3327         * WebCoreSupport/WebEditorClient.mm: Include the new header that declares _WebCreateFragment.
3328
3329 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3330
3331         Stop exporting DOMNodeFilter
3332         https://bugs.webkit.org/show_bug.cgi?id=168542
3333
3334         Reviewed by Alexey Proskuryakov.
3335
3336         * WebKit.exp:
3337
3338 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
3339
3340         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
3341         https://bugs.webkit.org/show_bug.cgi?id=167693
3342
3343         Reviewed by Sergio Villar Senin.
3344
3345         * Configurations/FeatureDefines.xcconfig:
3346         * WebView/WebPreferences.mm:
3347         (+[WebPreferences initialize]):
3348         * WebView/WebView.mm:
3349         (-[WebView _preferencesChanged:]):
3350
3351 2017-02-15  Brady Eidson  <beidson@apple.com>
3352
3353         Stop backing up localStorage databases to iCloud by default.
3354         <rdar://problem/29045531> and https://bugs.webkit.org/show_bug.cgi?id=168388
3355
3356         Reviewed by Geoffrey Garen.
3357
3358         * Misc/WebKitVersionChecks.h:
3359         * Misc/WebKitVersionChecks.mm: Renamed from Source/WebKit/mac/Misc/WebKitVersionChecks.m.
3360         (WebKitLinkedOnOrAfter):
3361         (setWebKitLinkTimeVersion):
3362         (WebKitLinkTimeVersion):
3363         (linkedOnOrAfter):
3364
3365         * Storage/WebStorageManager.mm:
3366         (WebKitInitializeStorageIfNecessary):
3367
3368 2017-02-16  Daniel Bates  <dabates@apple.com>
3369
3370         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
3371         https://bugs.webkit.org/show_bug.cgi?id=168417
3372         <rdar://problem/30541748>
3373
3374         Reviewed by Brent Fulgham.
3375
3376         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
3377         Widget* as it is always called with a valid Widget.
3378
3379         * WebCoreSupport/WebFrameLoaderClient.h:
3380         * WebCoreSupport/WebFrameLoaderClient.mm:
3381         (WebFrameLoaderClient::redirectDataToPlugin):
3382         * WebKit.order: Remove symbol for WebFrameLoaderClient::redirectDataToPlugin() that took a Widget*
3383         as it no longer exists. I am unclear if this file is still meaningful as it was last modified in
3384         r180570 (2 years ago) though Xcode still references this ordering file (why?).
3385
3386 2017-02-16  Yusuke Suzuki  <utatane.tea@gmail.com>
3387
3388         [JSC] Drop PassRefPtr in inspector/
3389         https://bugs.webkit.org/show_bug.cgi?id=168420
3390
3391         Reviewed by Alex Christensen.
3392
3393         * WebView/WebScriptDebugger.mm:
3394         (WebScriptDebugger::handlePause):
3395
3396 2017-02-16  Simon Fraser  <simon.fraser@apple.com>
3397
3398         Clean up use of some CALayer-related SPI
3399         https://bugs.webkit.org/show_bug.cgi?id=168401
3400
3401         Reviewed by Tim Horton.
3402
3403         Include CALayer.h not CATiledLayer.h.
3404
3405         * WebInspector/WebNodeHighlight.h:
3406
3407 2017-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3408
3409         Fix the build after r212379
3410
3411         Rubber-stamped by Anders Carlsson.
3412
3413         * WebCoreSupport/WebDragClient.mm:
3414         (WebDragClient::startDrag):
3415
3416 2017-02-15  Anders Carlsson  <andersca@apple.com>
3417
3418         Modernize DragClient::startDrag somewhat
3419         https://bugs.webkit.org/show_bug.cgi?id=168379
3420
3421         Reviewed by Tim Horton.
3422
3423         Update for WebCore changes.
3424
3425         * WebCoreSupport/WebDragClient.h:
3426         * WebCoreSupport/WebDragClient.mm:
3427         (WebDragClient::startDrag):
3428
3429 2017-02-14  Dean Jackson  <dino@apple.com>
3430
3431         Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
3432         https://bugs.webkit.org/show_bug.cgi?id=168339
3433
3434         Reviewed by Simon Fraser.
3435
3436         Use a better name.
3437
3438         * WebView/WebPreferenceKeysPrivate.h:
3439         * WebView/WebPreferences.mm:
3440         (+[WebPreferences initialize]):
3441         (-[WebPreferences forceLowPowerGPUForWebGL]):
3442         (-[WebPreferences setForceLowPowerGPUForWebGL:]):
3443         (-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
3444         (-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.
3445         * WebView/WebPreferencesPrivate.h:
3446         * WebView/WebView.mm:
3447         (-[WebView _preferencesChanged:]):
3448
3449 2017-02-14  Chris Dumez  <cdumez@apple.com>
3450
3451         HTML Form Validation bubble should take minimum font size setting into consideration
3452         https://bugs.webkit.org/show_bug.cgi?id=168271
3453         <rdar://problem/29869869>
3454
3455         Reviewed by Simon Fraser.
3456
3457         * WebView/WebView.mm:
3458         (-[WebView _contentsOfUserInterfaceItem:]):
3459         Return font size used in the validation bubble.
3460
3461         (-[WebView showFormValidationMessage:withAnchorRect:]):
3462         Pass minimum font size setting when constructing the validation bubble.
3463
3464 2017-02-14  Anders Carlsson  <andersca@apple.com>
3465
3466         Remove an unused delegate method
3467         https://bugs.webkit.org/show_bug.cgi?id=168328
3468
3469         Reviewed by Wenson Hsieh.
3470
3471         * DefaultDelegates/WebDefaultUIDelegate.m:
3472         (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.
3473
3474 2017-02-14  Alexey Proskuryakov  <ap@apple.com>
3475
3476         WebCore shouldn't export SystemMemory.h
3477         https://bugs.webkit.org/show_bug.cgi?id=168285
3478
3479         Reviewed by Alex Christensen.
3480
3481         * MigrateHeaders.make: And WebKit shouldn't re-export it.
3482
3483 2017-02-13  Alexey Proskuryakov  <ap@apple.com>
3484
3485         WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
3486         https://bugs.webkit.org/show_bug.cgi?id=168282
3487
3488         Reviewed by Dan Bernstein.
3489
3490         * MigrateHeaders.make:
3491
3492 2017-02-12  Dan Bernstein  <mitz@apple.com>
3493
3494         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
3495
3496         * WebView/WebHTMLView.mm:
3497         (createShareMenuItem): Use non-deprecated method.
3498
3499 2017-02-12  Dan Bernstein  <mitz@apple.com>
3500
3501         [Cocoa] Some -respondsToSelector: checks are unnecessary
3502         https://bugs.webkit.org/show_bug.cgi?id=168183
3503
3504         Reviewed by Tim Horton.
3505
3506         * WebView/WebFullScreenController.mm:
3507         (-[WebFullScreenController applicationDidResignActive:]): Removed check whether NSWindow
3508           responds to -isOnActiveSpace.
3509         (-[WebFullScreenController exitFullScreen]): Ditto.
3510         (-[WebFullScreenController _updateMenuAndDockForFullScreen]): Removed check whether
3511           NSApplication responds to -setPresentationOptions.
3512
3513         * WebView/WebHTMLView.mm:
3514         (createShareMenuItem): Removed unnecessary -respondsToSelector: check.
3515         (-[WebHTMLView otherMouseDown:]): Ditto.
3516
3517         * WebView/WebImmediateActionController.mm:
3518         (-[WebImmediateActionController _clearImmediateActionState]): Ditto.
3519         (-[WebImmediateActionController _animationControllerForDataDetectedText]): Ditto.
3520
3521         * WebView/WebView.mm:
3522         (-[WebView _didStartProvisionalLoadForFrame:]): Removed redundant nil check.
3523         (+[WebView _setCacheModel:]): Removed unnecessary -respondsToSelector: check.
3524
3525 2017-02-10  Daniel Bates  <dabates@apple.com>
3526
3527         Detach frame from document when entering page cache
3528         https://bugs.webkit.org/show_bug.cgi?id=166774
3529         <rdar://problem/29904368>
3530
3531         Reviewed by Chris Dumez.
3532
3533         * WebView/WebPreferenceKeysPrivate.h:
3534         * WebView/WebPreferences.mm:
3535         (+[WebPreferences initialize]):
3536         (-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
3537         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
3538         * WebView/WebPreferencesPrivate.h:
3539         * WebView/WebView.mm:
3540         (-[WebView _preferencesChanged:]):
3541
3542 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
3543
3544         [Resource Timing] Enable Resource Timing by default in Tests
3545         https://bugs.webkit.org/show_bug.cgi?id=168145
3546
3547         Reviewed by Ryosuke Niwa.
3548
3549         * WebView/WebPreferenceKeysPrivate.h:
3550         * WebView/WebPreferences.mm:
3551         (+[WebPreferences initialize]):
3552         (-[WebPreferences resourceTimingEnabled]):
3553         (-[WebPreferences setResourceTimingEnabled:]):
3554         * WebView/WebPreferencesPrivate.h:
3555         * WebView/WebView.mm:
3556         (-[WebView _preferencesChanged:]):
3557
3558 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
3559
3560         cleanup WebLocalizableStrings.
3561         https://bugs.webkit.org/show_bug.cgi?id=168078
3562
3563         Reviewed by Alexey Proskuryakov.
3564
3565         * Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle 
3566         as it's for each framework's own consumption, and never needs to be exported.
3567
3568 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
3569
3570         WebResourceLoadDelegatePrivate.h cannot be imported standalone
3571         https://bugs.webkit.org/show_bug.cgi?id=168096
3572
3573         Reviewed by Alexey Proskuryakov.
3574
3575         * WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger. 
3576
3577 2017-02-09  Antti Koivisto  <antti@apple.com>
3578
3579         Remove most cases of #if ENABLE(CACHE_PARTITIONING)
3580         https://bugs.webkit.org/show_bug.cgi?id=167990
3581
3582         Reviewed by Sam Weinig.
3583
3584         * Misc/WebCache.mm:
3585         (+[WebCache addImageToCache:forURL:forFrame:]):
3586         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3587         * WebCoreSupport/WebSystemInterface.mm:
3588         (InitWebCoreSystemInterface):
3589
3590 2017-02-07  Alexey Proskuryakov  <ap@apple.com>
3591
3592         Don't migrate WebKit DOM headers in MigrateHeaders.make
3593         https://bugs.webkit.org/show_bug.cgi?id=167608
3594
3595         Reviewed by Darin Adler.
3596
3597         Stop migrating DOM headers that are now in WebKit.
3598
3599         * DOM/DOMDOMImplementation.h: Removed.
3600         * DOM/DOMDOMImplementation.mm: Removed.
3601         * DOM/DOMDOMImplementationInternal.h: Removed.
3602         * DOM/DOMDOMTokenList.h: Removed.
3603         * DOM/DOMDOMTokenList.mm: Removed.
3604         * DOM/DOMDOMTokenListInternal.h: Removed.
3605         * DOM/DOMImplementation.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.h.
3606         * DOM/DOMImplementation.mm: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.mm.
3607         * DOM/DOMImplementationInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementationInternal.h.
3608         * DOM/DOMTokenList.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.h.
3609         * DOM/DOMTokenList.mm: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.mm.
3610         * DOM/DOMTokenListInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenListInternal.h.
3611         As the files are not in WebCore any more, there is no need to differentiate from
3612         WebCore internal headers with the same name. This makes it possible to make these
3613         headers private using Xcode mechanisms, as opposed to copying with a shell script.
3614
3615         * DOM/DOMElement.mm: Removed "using namespace WebCore". Other DOM implementation
3616         files don't have it.
3617
3618         * DOM/DOMCore.h:
3619         * DOM/DOMDocument.mm:
3620         * DOM/DOMHTMLAnchorElement.mm:
3621         * DOM/DOMHTMLAreaElement.mm:
3622         * DOM/DOMHTMLLinkElement.mm:
3623         * DOM/DOMUtility.mm:
3624         No more "DOMDOM".
3625
3626         * WebKit.exp:
3627         No more "DOMDOM". DOMDOMTokenList was not directly exposed via an SPI header, so
3628         renaming it is likely to be safe.
3629
3630         * MigrateHeaders.make: Don't migrate WebKit headers.
3631
3632         * Configurations/WebKitLegacy.xcconfig: Don't include two iOS specific SPI headers
3633         on macOS.
3634
3635 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
3636
3637         Don't re-export PluginData.h from WebKit
3638         https://bugs.webkit.org/show_bug.cgi?id=168020
3639
3640         Reviewed by Alexey Proskuryakov.
3641
3642         * MigrateHeaders.make: Removed PluginData.h
3643
3644 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
3645
3646         Don't re-export WKUtilities.h from WebKit
3647         https://bugs.webkit.org/show_bug.cgi?id=167977
3648
3649         Reviewed by Alexey Proskuryakov.
3650
3651         * MigrateHeaders.make: Removed WKUtilities.h
3652
3653 2017-02-06  Alex Christensen  <achristensen@webkit.org>
3654
3655         credentials should be partitioned by main document domain
3656         https://bugs.webkit.org/show_bug.cgi?id=166998
3657         rdar://problem/22901123
3658
3659         Reviewed by Brady Eidson.
3660
3661         * Misc/WebDownload.mm:
3662         * Plugins/WebBaseNetscapePluginView.mm:
3663         (WebKit::getAuthenticationInfo):
3664         Don't use partitioned credentials for WebKit1 plugins or downloads.
3665         Downloads should be authenticated before becoming a download anyways.
3666
3667 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3668
3669         Rename AnimationController to CSSAnimationController
3670         https://bugs.webkit.org/show_bug.cgi?id=167829
3671
3672         Reviewed by Simon Fraser.
3673
3674         * WebView/WebFrame.mm:
3675         * WebView/WebView.mm:
3676
3677 2017-02-03  Chris Dumez  <cdumez@apple.com>
3678
3679         Dismiss HTML form validation popover when pressing Escape key
3680         https://bugs.webkit.org/show_bug.cgi?id=167716
3681         <rdar://problem/29872943>
3682
3683         Reviewed by Simon Fraser.
3684
3685         Override ValidationMessageClient::hideAnyValidationMessage().
3686
3687         * WebCoreSupport/WebValidationMessageClient.h:
3688         * WebCoreSupport/WebValidationMessageClient.mm:
3689         (WebValidationMessageClient::hideAnyValidationMessage):
3690
3691 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3692
3693         Drag images should be anchored to the mouse location
3694         https://bugs.webkit.org/show_bug.cgi?id=167690
3695         <rdar://problem/30295261>
3696
3697         Reviewed by Enrica Casucci.
3698
3699         Adds some plumbing for the anchor point in the WK1 client layer.
3700
3701         * WebCoreSupport/WebDragClient.h:
3702         * WebCoreSupport/WebDragClient.mm:
3703         (WebDragClient::startDrag):
3704
3705 2017-02-02  Chris Dumez  <cdumez@apple.com>
3706
3707         Rename Node::inDocument() to isConnected()
3708         https://bugs.webkit.org/show_bug.cgi?id=167743
3709
3710         Reviewed by Sam Weinig.
3711
3712         Rename Node::inDocument() to isConnected() to match the DOM specification more closely:
3713         - https://dom.spec.whatwg.org/#connected
3714
3715         * DOM/DOMNode.mm:
3716         (-[DOMNode isConnected]):
3717         * WebView/WebFrame.mm:
3718         (-[WebFrame selectNSRange:onElement:]):
3719
3720 2017-02-02  Chris Dumez  <cdumez@apple.com>
3721
3722         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
3723         https://bugs.webkit.org/show_bug.cgi?id=167738
3724         <rdar://problem/30229990>
3725
3726         Reviewed by Andreas Kling.
3727
3728         The BackForwardClient no longer needs to worry about removing HistoryItems
3729         from the PageCache now that WebCore takes care of it.
3730
3731         * History/BackForwardList.mm:
3732         (BackForwardList::close):
3733
3734 2017-02-02  Yongjun Zhang  <yongjun_zhang@apple.com>
3735
3736         In iOS, we should take background assertion when accessing localstorage databases.
3737         https://bugs.webkit.org/show_bug.cgi?id=165478
3738
3739         Move database transaction background task handling code from WebDatabaseManager to
3740         WebCore's WebSQLiteDatabaseTrackerClient.
3741
3742         Reviewed by Brady Eidson.
3743
3744         * Storage/WebDatabaseManager.mm:
3745         * Storage/WebDatabaseManagerInternal.h: Remove a category for background task handling.
3746         * WebCoreSupport/WebApplicationCache.mm:
3747         (+[WebApplicationCache initializeWithBundleIdentifier:]): Use WebCore::WebSQLiteDatabaseTrackerClient.
3748         * WebView/WebView.mm:
3749         (-[WebView _commonInitializationWithFrameName:groupName:]): Ditto.
3750
3751 2017-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3752
3753         [WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
3754         https://bugs.webkit.org/show_bug.cgi?id=167695
3755         <rdar://problem/30305390>
3756
3757         Reviewed by Sam Weinig.
3758
3759         Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
3760         exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
3761         is destroyed.
3762
3763         * WebView/WebView.mm:
3764         (-[WebView _commonInitializationWithFrameName:groupName:]):
3765
3766 2017-01-31  Joseph Pecoraro  <pecoraro@apple.com>
3767
3768         ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category
3769         https://bugs.webkit.org/show_bug.cgi?id=167684
3770
3771         Reviewed by Dan Bernstein.
3772
3773         * DOM/DOMHTML.mm:
3774         (-[DOMHTMLInputElement _isAutofilled]): Deleted.
3775         (-[DOMHTMLInputElement _setAutofilled:]): Deleted.
3776         Consolidate in the WebDOMOperationsPrivate category.
3777
3778         * DOM/DOMPrivate.h:
3779         Include WebDOMOperationsPrivate header to get other DOM Private categories.
3780
3781         * DOM/WebDOMOperations.mm:
3782         (-[DOMHTMLInputElement _isAutofilled]):
3783         * DOM/WebDOMOperationsPrivate.h:
3784         Include getter alongside the setter.
3785
3786 2017-01-31  Jessie Berlin  <jberlin@webkit.org>
3787
3788         Build fix.
3789
3790         * Misc/WebNSPasteboardExtras.mm:
3791         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3792         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3793         * WebView/WebHTMLView.mm:
3794         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3795         (-[WebHTMLView copyFont:]):
3796
3797 2017-01-30  Andy Estes  <aestes@apple.com>
3798
3799         [QuickLook] FrameLoaderClient should return the new QuickLookHandleClient it creates
3800         https://bugs.webkit.org/show_bug.cgi?id=167625
3801
3802         Reviewed by Andreas Kling.
3803
3804         * WebCoreSupport/WebFrameLoaderClient.h: Declared createQuickLookHandleClient().
3805         * WebCoreSupport/WebFrameLoaderClient.mm:
3806         (WebFrameLoaderClient::createQuickLookHandleClient): Renamed from didCreateQuickLookHandle().
3807         (WebFrameLoaderClient::didCreateQuickLookHandle): Renamed to createQuickLookHandleClient().
3808
3809 2017-01-30  Chris Dumez  <cdumez@apple.com>
3810
3811         Drop legacy Attributes.isId attribute
3812         https://bugs.webkit.org/show_bug.cgi?id=167603
3813
3814         Reviewed by Ryosuke Niwa.
3815
3816         Keep Attr.isId in ObjC bindings.
3817
3818         * DOM/DOMAttr.mm:
3819         (-[DOMAttr isId]):
3820
3821 2017-01-30  Andreas Kling  <akling@apple.com>
3822
3823         [macOS] WebHTMLView has an internal retain cycle with its flagsChangedEventMonitor.
3824         <https://webkit.org/b/167580>
3825
3826         Reviewed by Antti Koivisto.
3827
3828         Avoid the implicit strong capture of self by keeping it in a __block variable.
3829         Also add code to dealloc to unregister the event monitor, since it will otherwise leak.
3830         This fixes huge WebHTMLView leaks seen on the leaks bot.
3831
3832         * WebView/WebHTMLView.mm:
3833         (-[WebHTMLViewPrivate dealloc]):
3834         (-[WebHTMLView viewDidMoveToWindow]):
3835
3836 2017-01-29  Andy Estes  <aestes@apple.com>
3837
3838         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
3839         https://bugs.webkit.org/show_bug.cgi?id=167563
3840         <rdar://problem/30253207>
3841
3842         Reviewed by Andreas Kling.
3843
3844         Instead of only saving QuickLook documents to a temporary file when the client is
3845         MobileSafari, base this decision on a WebPreference that clients can choose to enable.
3846
3847         This also changes the SPI for accessing the temporary file path and UTI. Instead of
3848         -[WebView quickLookContentForURL:], which requires the client to pass the response URL of
3849         the frame that saved the QuickLook document, the content dictionary is now stored as a
3850         property of WebDataSource.
3851
3852         This also removes the manual lifetime management of the QLPreviewConverter from
3853         QuickLookDocumentWriter. The QLPreviewConverter is kept alive by DocumentLoader these days,
3854         which ensures it lives long enough to respond to subresource requests.
3855
3856         New API test: QuickLook.LegacyQuickLookContent
3857
3858         * WebCoreSupport/WebFrameLoaderClient.mm:
3859         (WebFrameLoaderClient::didCreateQuickLookHandle): Moved the logic of deciding whether to
3860         write a temporary file to here from the QuickLookDocumentWriter constructor.
3861         * WebView/WebDataSource.mm: Declared _quickLookContent.
3862         (-[WebDataSource _quickLookContent]):
3863         (-[WebDataSource _setQuickLookContent:]):
3864         * WebView/WebDataSourceInternal.h: Overrode _quickLookContent as a read/write property.
3865         * WebView/WebDataSourcePrivate.h: Declared _quickLookContent as a readonly property.
3866         * WebView/WebPreferenceKeysPrivate.h: Defined WebKitQuickLookDocumentSavingPreferenceKey.
3867         * WebView/WebPreferences.mm:
3868         (-[WebPreferences quickLookDocumentSavingEnabled]):
3869         (-[WebPreferences setQuickLookDocumentSavingEnabled:]):
3870         * WebView/WebPreferencesPrivate.h: Declared property quickLookDocumentSavingEnabled.
3871         * WebView/WebView.mm:
3872         (-[WebView quickLookContentForURL:]): Changed to always return nil.
3873         * WebView/WebViewPrivate.h: Added a comment stating that clients should use
3874         -[WebDataSource _quickLookContent] instead.
3875
3876 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
3877
3878         Add Link Preload as an off-by-default experimental feature menu item.
3879         https://bugs.webkit.org/show_bug.cgi?id=167201
3880
3881         Reviewed by Ryosuke Niwa.
3882
3883         * WebView/WebPreferenceKeysPrivate.h:
3884         * WebView/WebPreferences.mm:
3885         (-[WebPreferences linkPreloadEnabled]):
3886         (-[WebPreferences setLinkPreloadEnabled:]):
3887         * WebView/WebPreferencesPrivate.h:
3888         * WebView/WebView.mm:
3889         (-[WebView _preferencesChanged:]):
3890
3891 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
3892
3893         Add User Timing Experimental Feature
3894         https://bugs.webkit.org/show_bug.cgi?id=167542
3895         <rdar://problem/22746307>
3896
3897         Reviewed by Ryosuke Niwa.
3898
3899         * WebView/WebPreferenceKeysPrivate.h:
3900         * WebView/WebPreferences.mm:
3901         (+[WebPreferences initialize]):
3902         (-[WebPreferences userTimingEnabled]):
3903         (-[WebPreferences setUserTimingEnabled:]):
3904         * WebView/WebPreferencesPrivate.h:
3905         * WebView/WebView.mm:
3906         (-[WebView _preferencesChanged:]):
3907         Add setting for User Timing runtime enabled feature.
3908
3909 2017-01-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3910
3911         [WK1] Do not prevent the drag client from initializing on Mac
3912         https://bugs.webkit.org/show_bug.cgi?id=167541
3913
3914         Reviewed by Dan Bernstein.
3915
3916         Fixes fallout from r211192. To ensure compability with WebKit clients, we need to ensure that WebDragClient is
3917         initialized everywhere when creating a WebView. Stub out method implementations as no-ops for non-Mac platforms.
3918         This caused certain clients, such as Mail, to crash when a webView closes due to  null dereference.
3919
3920         * WebCoreSupport/WebDragClient.mm:
3921         (WebDragClient::WebDragClient):
3922         (WebDragClient::actionMaskForDrag):
3923         (WebDragClient::willPerformDragDestinationAction):
3924         (WebDragClient::dragSourceActionMaskForPoint):
3925         (WebDragClient::willPerformDragSourceAction):
3926         (WebDragClient::startDrag):
3927         (WebDragClient::declareAndWriteDragImage):
3928         (WebDragClient::declareAndWriteAttachment):
3929         * WebView/WebView.mm:
3930         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3931
3932 2017-01-26  Chris Dumez  <cdumez@apple.com>
3933
3934         Crash when navigating back to a page in PacheCache when one of its frames has been removed
3935         https://bugs.webkit.org/show_bug.cgi?id=167421
3936         <rdar://problem/30188490>
3937
3938         Reviewed by Darin Adler.
3939
3940         Add a new setting allowing layout tests to enable PageCache in a window
3941         that has an opener, for convenience.
3942
3943         * WebView/WebPreferenceKeysPrivate.h:
3944         * WebView/WebPreferences.mm:
3945         (+[WebPreferences initialize]):
3946         (-[WebPreferences allowsPageCacheWithWindowOpener]):
3947         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]):
3948         * WebView/WebPreferencesPrivate.h:
3949         * WebView/WebView.mm:
3950         (-[WebView _preferencesChanged:]):
3951
3952 2017-01-26  Keith Miller  <keith_miller@apple.com>
3953
3954         classInfo should take a VM so it is not materialized from the object on each call
3955         https://bugs.webkit.org/show_bug.cgi?id=167424
3956
3957         Rubber Stamped by Michael Saboff.
3958
3959         Previously, classInfo() would get the VM from the target's
3960         MarkedBlock.  Most callers already have a VM on hand, so it is
3961         wasteful to compute the VM from the marked block every time. This
3962         patch refactors some of the most common callers of classInfo(),
3963         jsDynamicCast and inherits to take a VM as well.
3964
3965         * DOM/DOM.mm:
3966         (+[DOMNode _nodeFromJSWrapper:]):
3967         * DOM/DOMUtility.mm:
3968         (createDOMWrapper):
3969         * DOM/WebDOMOperations.mm:
3970         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3971         (WebKit::getObjectID):
3972         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
3973         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
3974         * Plugins/Hosted/ProxyInstance.mm:
3975         (WebKit::ProxyRuntimeMethod::finishCreation):
3976         (WebKit::ProxyInstance::invokeMethod):
3977         * Plugins/Hosted/ProxyRuntimeObject.mm:
3978         (WebKit::ProxyRuntimeObject::finishCreation):
3979         * WebView/WebFrame.mm:
3980         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3981         * WebView/WebView.mm:
3982         (+[WebView _reportException:inContext:]):
3983         (aeDescFromJSValue):
3984         (-[WebView _notificationIDForTesting:]):
3985
3986 2017-01-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3987
3988         REGRESSION (r207483): Touch Bar: Lists and BIU Buttons Missing from Touch Bar in HTML Notes
3989         https://bugs.webkit.org/show_bug.cgi?id=167472
3990         <rdar://problem/30149809>
3991
3992         Reviewed by Beth Dakin.
3993
3994         Revision 207483 caused the touch bar to stop showing up in HTML Notes due to -updateTextTouchBar not
3995         initializing the text touch bar and causing -makeTouchBar to return nil while processing a mouse click. The
3996         purpose of bailing out of the update was to prevent the text touch bar from thrashing during a selection drag.
3997         If the text touch bar doesn't exist yet, we don't have to worry about its appearance flickering from a different
3998         previous state, so we should just allow the touch bar to update instead.
3999
4000         * WebView/WebView.mm:
4001         (-[WebView updateTextTouchBar]):
4002
4003 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
4004
4005         Crash when setting custom scale factor.
4006         https://bugs.webkit.org/show_bug.cgi?id=167369
4007
4008         Reviewed by Sam Weinig.
4009
4010         Add null pointer check.
4011
4012         * WebView/WebView.mm:
4013         (-[WebView _setCustomBackingScaleFactor:]):
4014
4015 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4016
4017         Refactor drag and drop implementation on Mac
4018         https://bugs.webkit.org/show_bug.cgi?id=167427
4019
4020         Reviewed by Enrica Casucci.
4021
4022         Refactor some WebKit1 code on the Mac pertaining to drag and drop. See WebCore ChangeLog for more details.
4023
4024         * Misc/WebNSPasteboardExtras.h:
4025         * WebCoreSupport/WebDragClient.mm:
4026         * WebView/WebFrame.mm:
4027         * WebView/WebFrameInternal.h:
4028         * WebView/WebHTMLView.mm:
4029         * WebView/WebView.mm:
4030         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
4031
4032 2017-01-24  Youenn Fablet  <youennf@gmail.com>
4033
4034         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
4035         https://bugs.webkit.org/show_bug.cgi?id=167294
4036
4037         Reviewed by Alex Christensen.
4038
4039         * WebView/WebView.mm:
4040         (-[WebView _commonInitializationWithFrameName:groupName:]):
4041
4042 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4043
4044         Add support for named pasteboards, pasteboard strategies and platform pasteboards
4045         https://bugs.webkit.org/show_bug.cgi?id=167404
4046
4047         Reviewed by Enrica Casucci.
4048
4049         Adds pasteboard name as an argument to pasteboard-related WebPlatformStrategy methods.
4050
4051         * WebCoreSupport/WebPlatformStrategies.h:
4052         * WebCoreSupport/WebPlatformStrategies.mm:
4053         (WebPlatformStrategies::writeToPasteboard):
4054         (WebPlatformStrategies::getPasteboardItemsCount):
4055         (WebPlatformStrategies::readBufferFromPasteboard):
4056         (WebPlatformStrategies::readURLFromPasteboard):
4057         (WebPlatformStrategies::readStringFromPasteboard):
4058
4059 2017-01-25  Aakash Jain  <aakash_jain@apple.com>
4060
4061         LoadWebLocalizedStrings method should be moved in correct file
4062         https://bugs.webkit.org/show_bug.cgi?id=167393
4063
4064         Reviewed by Alexey Proskuryakov.
4065
4066         * Misc/WebLocalizableStrings.h: Deleted LoadWebLocalizedStrings method.
4067         * Misc/WebLocalizableStrings.mm:
4068         (LoadWebLocalizedStringsTimerCallback): Deleted, moved to WebUIKitSupport.mm
4069         (LoadWebLocalizedStrings): Deleted, moved to WebUIKitSupport.mm
4070
4071 2017-01-24  Zalan Bujtas  <zalan@apple.com>
4072
4073         Add simple line layout toggle to MiniBrowser
4074         https://bugs.webkit.org/show_bug.cgi?id=167405
4075
4076         Reviewed by Andreas Kling.
4077
4078         * WebView/WebPreferenceKeysPrivate.h:
4079         * WebView/WebPreferences.mm:
4080         (+[WebPreferences initialize]):
4081         (-[WebPreferences simpleLineLayoutEnabled]):
4082         (-[WebPreferences setSimpleLineLayoutEnabled:]):
4083         * WebView/WebPreferencesPrivate.h:
4084         * WebView/WebView.mm:
4085         (-[WebView _preferencesChanged:]):
4086
4087 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
4088
4089         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
4090         https://bugs.webkit.org/show_bug.cgi?id=167394
4091
4092         Reviewed by Ryosuke Niwa.
4093
4094         * Configurations/FeatureDefines.xcconfig:
4095
4096 2017-01-23  Chris Dumez  <cdumez@apple.com>
4097
4098         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
4099         https://bugs.webkit.org/show_bug.cgi?id=167308
4100         <rdar://problem/30144964>
4101
4102         Unreviewed, do a partial revert of r211033 to fix assertion.
4103
4104         * WebCoreSupport/WebChromeClient.h:
4105         * WebCoreSupport/WebChromeClient.mm:
4106         (WebChromeClient::exitFullScreenForElement):
4107
4108 2017-01-23  Joseph Pecoraro  <pecoraro@apple.com>
4109
4110         Remove allowWindowOpenWithoutUserGesture setting
4111         https://bugs.webkit.org/show_bug.cgi?id=167301
4112
4113         Reviewed by Darin Adler.
4114
4115         * WebView/WebView.mm:
4116         (-[WebView _preferencesChanged:]):
4117         Use the equivalent existing setting.
4118
4119 2017-01-20  Darin Adler  <darin@apple.com>
4120
4121         Remove PassRefPtr from "page" directory of WebCore, also deploy references
4122         https://bugs.webkit.org/show_bug.cgi?id=167224
4123
4124         Reviewed by Chris Dumez.
4125
4126         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
4127         (-[WebApplicationCacheQuotaManager quota]): Pass reference.
4128
4129         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
4130         * WebCoreSupport/WebChromeClient.mm:
4131         (WebChromeClient::focusedElementChanged): Ditto.
4132         (WebChromeClient::createWindow): Ditto.
4133         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
4134         (WebChromeClient::runJavaScriptAlert): Ditto.
4135         (WebChromeClient::runJavaScriptConfirm): Ditto.
4136         (WebChromeClient::runJavaScriptPrompt): Ditto.
4137         (WebChromeClient::contentsSizeChanged): Ditto.
4138         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
4139         (WebChromeClient::print): Ditto.
4140         (WebChromeClient::exceededDatabaseQuota): Ditto.
4141         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
4142         (WebChromeClient::createColorChooser): Ditto.
4143         (WebChromeClient::elementDidFocus): Ditto.
4144         (WebChromeClient::elementDidBlur): Ditto.
4145         (WebChromeClient::createPopupMenu): Ditto.
4146         (WebChromeClient::createSearchPopupMenu): Ditto.
4147         (WebChromeClient::attachRootGraphicsLayer): Ditto.
4148         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
4149         (WebChromeClient::supportsFullScreenForElement): Ditto.
4150         (WebChromeClient::enterFullScreenForElement): Ditto.
4151         (WebChromeClient::exitFullScreenForElement): Ditto.
4152
4153         * WebView/WebFrame.mm:
4154         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
4155         Updated for change to the appendChild function.
4156
4157 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
4158
4159         Remove -[WebFrame sendOrientationChangeEvent:] which is unused
4160         https://bugs.webkit.org/show_bug.cgi?id=167276
4161
4162         Reviewed by Alex Christensen.
4163         
4164         It was usurped by -deviceOrientationChanged in 2014.
4165
4166         * WebView/WebFrame.mm:
4167         (-[WebFrame sendOrientationChangeEvent:]): Deleted.
4168         * WebView/WebFramePrivate.h:
4169
4170 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
4171
4172         Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
4173         https://bugs.webkit.org/show_bug.cgi?id=167271
4174
4175         Reviewed by Alex Christensen.
4176         
4177         -_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
4178         overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),
4179
4180         * WebView/WebView.mm:
4181         (-[WebView _contentsSizeRespectingOverflow]): Deleted.
4182         * WebView/WebViewPrivate.h:
4183
4184 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
4185
4186         Remove never changing IndexedDB RuntimeEnabledFeature
4187         https://bugs.webkit.org/show_bug.cgi?id=167278
4188
4189         Reviewed by Darin Adler.
4190
4191         * WebView/WebView.mm:
4192         (-[WebView _preferencesChanged:]):
4193
4194 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
4195
4196         Cleanup RuntimeEnabledFeatures
4197         https://bugs.webkit.org/show_bug.cgi?id=167228
4198
4199         Reviewed by Simon Fraser.
4200
4201         * WebView/WebView.mm:
4202         (-[WebView _preferencesChanged:]):
4203
4204 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
4205
4206         Remove outdated ENABLE(CSP_NEXT) build flag
4207         https://bugs.webkit.org/show_bug.cgi?id=167252
4208
4209         Reviewed by Brent Fulgham.
4210
4211         * Configurations/FeatureDefines.xcconfig:
4212
4213 2017-01-20  Antoine Quint  <graouts@apple.com>
4214
4215         [Modern Media Controls] Turn modern media controls on by default
4216         https://bugs.webkit.org/show_bug.cgi?id=165668
4217
4218         Reviewed by Dean Jackson.
4219
4220         Enabled modern media controls by default in WK1.
4221
4222         * WebView/WebPreferences.mm:
4223         (+[WebPreferences initialize]):
4224
4225 2017-01-19  Chris Dumez  <cdumez@apple.com>
4226
4227         iterable<> should be enabled on WK1
4228         https://bugs.webkit.org/show_bug.cgi?id=167221