Remove STREAMS_API compilation guard
[WebKit.git] / Source / WebKitLegacy / mac / ChangeLog
1 2017-08-04  Youenn Fablet  <youenn@apple.com>
2
3         Remove STREAMS_API compilation guard
4         https://bugs.webkit.org/show_bug.cgi?id=175165
5
6         Reviewed by Darin Adler.
7
8         * Configurations/FeatureDefines.xcconfig:
9         * WebView/WebPreferences.mm:
10         (+[WebPreferences initialize]):
11         * WebView/WebView.mm:
12         (-[WebView _preferencesChanged:]):
13
14 2017-08-03  Brian Burg  <bburg@apple.com>
15
16         Remove ENABLE(WEB_SOCKET) guards
17         https://bugs.webkit.org/show_bug.cgi?id=167044
18
19         Reviewed by Joseph Pecoraro.
20
21         * Configurations/FeatureDefines.xcconfig:
22         * WebView/WebPreferencesPrivate.h:
23
24 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
25
26         [PAL] Move spi/cf directory into PAL
27         https://bugs.webkit.org/show_bug.cgi?id=175057
28
29         Reviewed by Antti Koivisto.
30
31         * Plugins/Hosted/HostedNetscapePluginStream.mm:
32         * Plugins/WebNetscapePluginStream.mm:
33         * WebCoreSupport/WebFrameNetworkingContext.mm:
34         * WebView/WebPreferences.mm:
35         * WebView/WebView.mm:
36
37 2017-08-03  Youenn Fablet  <youenn@apple.com>
38
39         Remove FETCH_API compilation guard
40         https://bugs.webkit.org/show_bug.cgi?id=175154
41
42         Reviewed by Chris Dumez.
43
44         * Configurations/FeatureDefines.xcconfig:
45         * WebView/WebPreferences.mm:
46         (+[WebPreferences initialize]):
47         * WebView/WebView.mm:
48         (-[WebView _preferencesChanged:]):
49
50 2017-08-03  Brady Eidson  <beidson@apple.com>
51
52         Add SW IDLs and stub out basic functionality.
53         https://bugs.webkit.org/show_bug.cgi?id=175115
54
55         Reviewed by Chris Dumez.
56
57         * Configurations/FeatureDefines.xcconfig:
58
59 2017-08-02  Sam Weinig  <sam@webkit.org>
60
61         [WebIDL] Convert MutationCallback to be a normal generated callback
62         https://bugs.webkit.org/show_bug.cgi?id=174140
63
64         Reviewed by Darin Adler.
65
66         * DOM/DOMDocument.mm:
67         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
68         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
69         Pass, now necessary, Document to NativeNodeFilter constructor.
70
71 2017-08-01  Chris Dumez  <cdumez@apple.com>
72
73         Add initial support for navigator.sendBeacon
74         https://bugs.webkit.org/show_bug.cgi?id=175007
75         <rdar://problem/33547728>
76
77         Reviewed by Sam Weinig.
78
79         Add setting to toggle support for the Beacon API (it is disabled by default).
80
81         * WebView/WebPreferenceKeysPrivate.h:
82         * WebView/WebPreferences.mm:
83         (+[WebPreferences initialize]):
84         (-[WebPreferences beaconAPIEnabled]):
85         (-[WebPreferences setBeaconAPIEnabled:]):
86         * WebView/WebPreferencesPrivate.h:
87         * WebView/WebView.mm:
88         (-[WebView _preferencesChanged:]):
89
90 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
91
92         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
93         https://bugs.webkit.org/show_bug.cgi?id=174437
94
95         Reviewed by Darin Adler.
96
97         Remove redundant Web- prefix from classes in WebKit namespace.
98
99         * WebView/WebView.mm:
100         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
101         * WebView/WebViewData.h:
102         * WebView/WebViewData.mm:
103
104 2017-07-26  Brian Burg  <bburg@apple.com>
105
106         Remove WEB_TIMING feature flag
107         https://bugs.webkit.org/show_bug.cgi?id=174795
108
109         Reviewed by Alex Christensen.
110
111         * Configurations/FeatureDefines.xcconfig:
112
113 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
114
115         Async image decoding for large images should be disabled after the first time a tile is painted
116         https://bugs.webkit.org/show_bug.cgi?id=174451
117         <rdar://problem/31246421>
118
119         Reviewed by Simon Fraser.
120
121         * WebView/WebFrame.mm:
122         (-[WebFrame _paintBehaviorForDestinationContext:]):
123         (-[WebFrame _drawRect:contentsOnly:]):
124         * WebView/WebHTMLView.mm:
125         (imageFromRect):
126
127 2017-07-23  Darin Adler  <darin@apple.com>
128
129         More NeverDestroyed and related cleanup
130         https://bugs.webkit.org/show_bug.cgi?id=174745
131
132         Reviewed by Alex Christensen.
133
134         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
135         for names that aren't even used in this file.
136         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
137         -[NSArray arrayWithObject:].
138         (-[DOMNode absoluteQuads]): Ditto.
139         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
140         of writing out various types.
141         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
142         syntax instea of -[NSArray arrayWithObject:].
143         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
144         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
145         of writing out various types.
146         (-[DOMHTMLImageElement mimeType]): Ditto.
147
148 2017-07-24  Chris Dumez  <cdumez@apple.com>
149
150         ExceptionCode enumeration should use modern exception names
151         https://bugs.webkit.org/show_bug.cgi?id=174794
152
153         Reviewed by Geoffrey Garen.
154
155         * DOM/ExceptionHandlers.mm:
156         (raiseNotSupportedErrorException):
157
158 2017-07-23  Chris Dumez  <cdumez@apple.com>
159
160         Drop ExceptionCodeDescription class
161         https://bugs.webkit.org/show_bug.cgi?id=174757
162
163         Reviewed by Darin Adler.
164
165         Stop using ExceptionCodeDescription.
166
167         * DOM/ExceptionHandlers.mm:
168         (raiseDOMErrorException):
169
170 2017-07-21  Andreas Kling  <akling@apple.com>
171
172         Use more references in event dispatch code
173         https://bugs.webkit.org/show_bug.cgi?id=174681
174
175         Reviewed by Geoffrey Garen.
176
177         * DOM/ObjCEventListener.h:
178         * DOM/ObjCEventListener.mm:
179         (WebCore::ObjCEventListener::handleEvent):
180         * WebCoreSupport/WebFrameLoaderClient.mm:
181         (NetscapePluginWidget::handleEvent):
182
183 2017-07-21  Brady Eidson  <beidson@apple.com>
184
185         Get rid of WebCore IconDatabase code.
186         https://bugs.webkit.org/show_bug.cgi?id=174700
187
188         Reviewed by Tim Horton.
189
190         * Misc/WebCoreStatistics.mm:
191         (+[WebCoreStatistics iconPageURLMappingCount]):
192         (+[WebCoreStatistics iconRetainedPageURLCount]):
193         (+[WebCoreStatistics iconRecordCount]):
194         (+[WebCoreStatistics iconsWithDataCount]):
195         * WebCoreSupport/WebFrameLoaderClient.h:
196         * WebCoreSupport/WebFrameLoaderClient.mm:
197         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
198         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
199         * WebView/WebView.mm:
200         (-[WebView mainFrameIconURL]):
201
202 2017-07-20  Chris Dumez  <cdumez@apple.com>
203
204         Drop legacy XPathException type
205         https://bugs.webkit.org/show_bug.cgi?id=174679
206
207         Reviewed by Sam Weinig.
208
209         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
210         no longer expose XPathException.
211
212         * DOM/ExceptionHandlers.mm:
213         (raiseDOMErrorException):
214
215 2017-07-20  Chris Dumez  <cdumez@apple.com>
216
217         Unreviewed, rolling out r219706.
218
219         Broke iOS build
220
221         Reverted changeset:
222
223         "Drop legacy XPathException type"
224         https://bugs.webkit.org/show_bug.cgi?id=174679
225         http://trac.webkit.org/changeset/219706
226
227 2017-07-20  Chris Dumez  <cdumez@apple.com>
228
229         Drop legacy XPathException type
230         https://bugs.webkit.org/show_bug.cgi?id=174679
231
232         Reviewed by Sam Weinig.
233
234         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
235         no longer expose XPathException.
236
237         * DOM/ExceptionHandlers.mm:
238         (raiseDOMErrorException):
239         * WebKit.exp:
240
241 2017-07-20  Chris Dumez  <cdumez@apple.com>
242
243         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
244         https://bugs.webkit.org/show_bug.cgi?id=174660
245
246         Reviewed by Geoffrey Garen.
247
248         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
249         This essentially replaces a branch to figure out if the new size is less or greater than the
250         current size by an assertion.
251
252         * Plugins/WebNetscapePluginView.mm:
253         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
254
255 2017-07-20  Brady Eidson  <beidson@apple.com>
256
257         Deprecate WebIconDatabase in WebKitLegacy/mac.
258         https://bugs.webkit.org/show_bug.cgi?id=174607
259
260         Reviewed by Alex Christensen.
261
262         This patch:
263         1 - Formally deprecates WebIconDatabase (which was never API anyways)
264         2 - Guts the class to where it can only return the default icon at the small size
265         3 - Reworks other parts of WebKitLegacy that used it for anything to either
266             use something else or to not do anything.
267         
268         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
269         and that patch will remove all of the last remnants of WebIconDatabase.
270         
271         * History/WebHistoryItem.mm:
272         (-[WebHistoryItem icon]):
273
274         * Misc/WebIconDatabase.h:
275         * Misc/WebIconDatabase.mm:
276         (-[WebIconDatabase init]):
277         (-[WebIconDatabase iconForURL:withSize:cache:]):
278         (-[WebIconDatabase iconForURL:withSize:]):
279         (-[WebIconDatabase defaultIconWithSize:]):
280         (-[WebIconDatabase defaultIconForURL:withSize:]):
281         (-[WebIconDatabase iconURLForURL:]):
282         (-[WebIconDatabase retainIconForURL:]):
283         (-[WebIconDatabase releaseIconForURL:]):
284         (+[WebIconDatabase delayDatabaseCleanup]):
285         (+[WebIconDatabase allowDatabaseCleanup]):
286         (-[WebIconDatabase setDelegate:]):
287         (-[WebIconDatabase delegate]):
288         (+[WebIconDatabase initialize]): Deleted.
289         (-[WebIconDatabase isEnabled]): Deleted.
290         (-[WebIconDatabase setEnabled:]): Deleted.
291         (-[WebIconDatabase removeAllIcons]): Deleted.
292         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
293         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
294         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
295         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
296         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
297         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
298         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
299         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
300         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
301         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
302         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
303         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
304         (-[WebIconDatabase _databaseDirectory]): Deleted.
305         (webGetNSImage): Deleted.
306
307         * Misc/WebIconDatabaseDelegate.h: Removed.
308         * Misc/WebIconDatabaseInternal.h: Removed.
309         * Misc/WebIconDatabasePrivate.h: Removed.
310
311         * WebCoreSupport/WebFrameLoaderClient.mm:
312         (webGetNSImage):
313
314         * WebCoreSupport/WebIconDatabaseClient.mm:
315         (WebIconDatabaseClient::didRemoveAllIcons):
316         (WebIconDatabaseClient::didImportIconURLForPageURL):
317
318         * WebView/WebView.mm:
319         (-[WebView setFrameLoadDelegate:]):
320         (-[WebView mainFrameIcon]):
321
322 2017-07-18  Andy Estes  <aestes@apple.com>
323
324         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
325         https://bugs.webkit.org/show_bug.cgi?id=174631
326
327         Reviewed by Tim Horton.
328
329         * Configurations/Base.xcconfig:
330
331 2017-07-18  Andy Estes  <aestes@apple.com>
332
333         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
334         https://bugs.webkit.org/show_bug.cgi?id=174631
335
336         Reviewed by Sam Weinig.
337
338         * Configurations/Base.xcconfig:
339
340 2017-07-18  Andy Estes  <aestes@apple.com>
341
342         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
343         https://bugs.webkit.org/show_bug.cgi?id=174631
344
345         Reviewed by Dan Bernstein.
346
347         * Configurations/Base.xcconfig:
348
349 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
350
351         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
352         https://bugs.webkit.org/show_bug.cgi?id=174640
353         <rdar://problem/33297400>
354
355         Reviewed by Tim Horton.
356
357         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
358         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
359         web thread here, to match the other WebView drag and drop SPI methods.
360
361         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
362         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
363         should make this robust against future UIKit changes that could make this no longer the case.
364
365         * WebView/WebView.mm:
366         (-[WebView _requestStartDataInteraction:globalPosition:]):
367         (-[WebView _dataInteractionCaretRect]):
368
369 2017-07-18  Andy Estes  <aestes@apple.com>
370
371         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
372         https://bugs.webkit.org/show_bug.cgi?id=174631
373
374         Reviewed by Darin Adler.
375
376         * Configurations/Base.xcconfig:
377
378 2017-07-17  Sam Weinig  <sam@webkit.org>
379
380         [WebIDL] Remove custom bindings that require non-caching JS strings
381         https://bugs.webkit.org/show_bug.cgi?id=174552
382
383         Reviewed by Darin Adler.
384
385         * DOM/DOMHTMLCanvasElement.mm:
386         (-[DOMHTMLCanvasElement toDataURL:]):
387         Update to account for implementation now returning an UncachedString.
388
389 2017-07-17  Darin Adler  <darin@apple.com>
390
391         Improve use of NeverDestroyed
392         https://bugs.webkit.org/show_bug.cgi?id=174348
393
394         Reviewed by Sam Weinig.
395
396         * Misc/WebStringTruncator.mm:
397         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
398         NeverDestroyed<RetainPtr> with just an NSFont * global.
399
400         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
401         NeverDestroyed.h.
402         * Storage/WebDatabaseManager.mm: Ditto.
403         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
404         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
405
406         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
407         (aeDescFromJSValue): Removed double hashing by using the return value from
408         add rather than calling contains before calling add.
409
410 2017-07-14  Jer Noble  <jer.noble@apple.com>
411
412         Allow clients to override their own hardware media requirements where no fallback media exists.
413         https://bugs.webkit.org/show_bug.cgi?id=174426
414         <rdar://problem/32537704>
415
416         Reviewed by Eric Carlson.
417
418         Add a new WebPreferences property to control WebCore's new
419         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
420
421         * WebView/WebPreferenceKeysPrivate.h:
422         * WebView/WebPreferences.mm:
423         (+[WebPreferences initialize]):
424         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
425         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
426         * WebView/WebPreferencesPrivate.h:
427         * WebView/WebView.mm:
428         (-[WebView _preferencesChanged:]):
429
430 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
431
432         Async image decoding for large images should be disabled by default
433         https://bugs.webkit.org/show_bug.cgi?id=174432
434
435         Reviewed by Simon Fraser.
436
437         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
438         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
439         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
440            a child view instead of propagating PaintBehaviorSnapshotting.
441         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
442            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
443
444         * WebView/WebFrame.mm:
445         (-[WebFrame _paintBehaviorForDestinationContext:]):
446         (-[WebFrame _drawRect:contentsOnly:]):
447         * WebView/WebHTMLView.mm:
448         (imageFromRect):
449
450 2017-07-12  Daniel Bates  <dabates@apple.com>
451
452         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
453         https://bugs.webkit.org/show_bug.cgi?id=174427
454
455         Rubber-stamped by Brady Eidson.
456
457         * WebView/WebPDFView.mm:
458         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
459
460 2017-07-12  Matt Lewis  <jlewis3@apple.com>
461
462         Unreviewed, rolling out r219401.
463
464         This revision rolled out the previous patch, but after talking
465         with reviewer, a rebaseline is what was needed.Rolling back in
466         before rebaseline.
467
468         Reverted changeset:
469
470         "Unreviewed, rolling out r219379."
471         https://bugs.webkit.org/show_bug.cgi?id=174400
472         http://trac.webkit.org/changeset/219401
473
474 2017-07-12  Matt Lewis  <jlewis3@apple.com>
475
476         Unreviewed, rolling out r219379.
477
478         This revision caused a consistent failure in the test
479         fast/dom/Window/property-access-on-cached-window-after-frame-
480         removed.html.
481
482         Reverted changeset:
483
484         "Remove NAVIGATOR_HWCONCURRENCY"
485         https://bugs.webkit.org/show_bug.cgi?id=174400
486         http://trac.webkit.org/changeset/219379
487
488 2017-07-11  Dean Jackson  <dino@apple.com>
489
490         Remove NAVIGATOR_HWCONCURRENCY
491         https://bugs.webkit.org/show_bug.cgi?id=174400
492
493         * Configurations/FeatureDefines.xcconfig:
494
495 2017-07-11  Dean Jackson  <dino@apple.com>
496
497         Rolling out r219372.
498
499         * Configurations/FeatureDefines.xcconfig:
500
501 2017-07-11  Dean Jackson  <dino@apple.com>
502
503         Remove NAVIGATOR_HWCONCURRENCY
504         https://bugs.webkit.org/show_bug.cgi?id=174400
505
506         * Configurations/FeatureDefines.xcconfig:
507
508 2017-07-03  Brian Burg  <bburg@apple.com>
509
510         Web Replay: remove some unused code
511         https://bugs.webkit.org/show_bug.cgi?id=173903
512
513         Rubber-stamped by Joseph Pecoraro.
514
515         * Configurations/FeatureDefines.xcconfig:
516
517 2017-07-09  Brady Eidson  <beidson@apple.com>
518
519         Remove some obsolete WebKitVersionChecks.
520         https://bugs.webkit.org/show_bug.cgi?id=174294
521
522         Reviewed by Dan Bernstein.
523
524         * Misc/WebKitVersionChecks.h:
525
526         * WebView/WebHTMLView.mm:
527         (-[WebHTMLView hitTest:]):
528
529         * WebView/WebView.mm:
530         (shouldRespectPriorityInCSSAttributeSetters):
531         (-[WebView _commonInitializationWithFrameName:groupName:]):
532         (-[WebView _preferencesChanged:]):
533         (shouldTransformsAffectOverflow): Deleted.
534         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
535
536 2017-07-08  Brady Eidson  <beidson@apple.com>
537
538         Remove some obsolete RuntimeApplicationChecks.
539         https://bugs.webkit.org/show_bug.cgi?id=174293
540
541         Reviewed by Dan Bernstein.
542
543         * Misc/WebKitVersionChecks.h:
544         * WebView/WebView.mm:
545         (+[WebView enableWebThread]):
546         (-[WebView _needsPreHTML5ParserQuirks]):
547
548 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
549
550         Drop NOSNIFF compile flag
551         https://bugs.webkit.org/show_bug.cgi?id=174289
552
553         Reviewed by Michael Catanzaro.
554
555         * Configurations/FeatureDefines.xcconfig:
556
557 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
558
559         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
560         https://bugs.webkit.org/show_bug.cgi?id=174150
561
562         Reviewed by Mark Lam.
563
564         * DOM/DOM.mm:
565         (lookupElementClass):
566
567 2017-07-06  Brady Eidson  <beidson@apple.com>
568
569         Add logging to first attempt to use the WebIconDatabase class.
570         https://bugs.webkit.org/show_bug.cgi?id=174190
571
572         Reviewed by Andy Estes.
573
574         * Misc/WebIconDatabase.mm:
575         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
576         * Misc/WebKitVersionChecks.h:
577
578 2017-07-06  Matt Lewis  <jlewis3@apple.com>
579
580         Unreviewed, rolling out r219178.
581
582         This caused a consistent failure with the API test
583         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
584
585         Reverted changeset:
586
587         "[WTF] Clean up StringStatics.cpp by using
588         LazyNeverDestroyed<> for Atoms"
589         https://bugs.webkit.org/show_bug.cgi?id=174150
590         http://trac.webkit.org/changeset/219178
591
592 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
593
594         [WTF] Move SoftLinking.h into WTF
595         https://bugs.webkit.org/show_bug.cgi?id=174000
596
597         Reviewed by Alex Christensen.
598
599         * Plugins/WebNetscapePluginView.mm:
600         * Plugins/WebPluginController.mm:
601         * WebCoreSupport/WebInspectorClient.mm:
602         * WebView/WebFullScreenController.mm:
603         * WebView/WebImmediateActionController.mm:
604         * WebView/WebView.mm:
605
606 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
607
608         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
609         https://bugs.webkit.org/show_bug.cgi?id=174150
610
611         Reviewed by Mark Lam.
612
613         * DOM/DOM.mm:
614         (lookupElementClass):
615
616 2017-07-05  Brady Eidson  <beidson@apple.com>
617
618         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
619         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
620
621         Reviewed by Alex Christensen.
622
623         Adopt to the new constructor for FrameLoadRequest.
624
625         * WebView/WebPDFView.mm:
626         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
627
628 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
629
630         Make WebKit's public headers on Mac and iOS C++ module safe
631         https://bugs.webkit.org/show_bug.cgi?id=174175
632
633         Reviewed by Alex Christensen.
634
635         Fixed the header files.
636
637         * Misc/WebDownload.h:
638         * Misc/WebKitErrors.h:
639         * Plugins/WebPluginContainer.h:
640         * WebView/WebResourceLoadDelegate.h:
641
642 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
643
644         Remove copy of ICU headers from WebKit
645         https://bugs.webkit.org/show_bug.cgi?id=116407
646
647         Reviewed by Alex Christensen.
648
649         Use WTF's copy of ICU headers.
650
651         * Configurations/WebKitLegacy.xcconfig:
652         * icu/unicode/localpointer.h: Removed.
653         * icu/unicode/parseerr.h: Removed.
654         * icu/unicode/platform.h: Removed.
655         * icu/unicode/ptypes.h: Removed.
656         * icu/unicode/putil.h: Removed.
657         * icu/unicode/uchar.h: Removed.
658         * icu/unicode/uconfig.h: Removed.
659         * icu/unicode/ucurr.h: Removed.
660         * icu/unicode/uidna.h: Removed.
661         * icu/unicode/uiter.h: Removed.
662         * icu/unicode/umachine.h: Removed.
663         * icu/unicode/unorm.h: Removed.
664         * icu/unicode/unorm2.h: Removed.
665         * icu/unicode/urename.h: Removed.
666         * icu/unicode/uscript.h: Removed.
667         * icu/unicode/ustring.h: Removed.
668         * icu/unicode/utf.h: Removed.
669         * icu/unicode/utf16.h: Removed.
670         * icu/unicode/utf8.h: Removed.
671         * icu/unicode/utf_old.h: Removed.
672         * icu/unicode/utypes.h: Removed.
673         * icu/unicode/uvernum.h: Removed.
674         * icu/unicode/uversion.h: Removed.
675
676 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
677
678         Add WebKitPrivateFrameworkStubs for iOS 11
679         https://bugs.webkit.org/show_bug.cgi?id=173988
680
681         Reviewed by David Kilzer.
682
683         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
684         use the same directory for private framework stubs.
685
686 2017-07-03  Matt Lewis  <jlewis3@apple.com>
687
688         Unreviewed, rolling out r219103.
689
690         Caused multiple build failures.
691
692         Reverted changeset:
693
694         "Remove copy of ICU headers from WebKit"
695         https://bugs.webkit.org/show_bug.cgi?id=116407
696         http://trac.webkit.org/changeset/219103
697
698 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
699
700         Remove copy of ICU headers from WebKit
701         https://bugs.webkit.org/show_bug.cgi?id=116407
702
703         Reviewed by Alex Christensen.
704
705         Use WTF's copy of ICU headers.
706
707         * Configurations/WebKitLegacy.xcconfig:
708         * icu/unicode/localpointer.h: Removed.
709         * icu/unicode/parseerr.h: Removed.
710         * icu/unicode/platform.h: Removed.
711         * icu/unicode/ptypes.h: Removed.
712         * icu/unicode/putil.h: Removed.
713         * icu/unicode/uchar.h: Removed.
714         * icu/unicode/uconfig.h: Removed.
715         * icu/unicode/ucurr.h: Removed.
716         * icu/unicode/uidna.h: Removed.
717         * icu/unicode/uiter.h: Removed.
718         * icu/unicode/umachine.h: Removed.
719         * icu/unicode/unorm.h: Removed.
720         * icu/unicode/unorm2.h: Removed.
721         * icu/unicode/urename.h: Removed.
722         * icu/unicode/uscript.h: Removed.
723         * icu/unicode/ustring.h: Removed.
724         * icu/unicode/utf.h: Removed.
725         * icu/unicode/utf16.h: Removed.
726         * icu/unicode/utf8.h: Removed.
727         * icu/unicode/utf_old.h: Removed.
728         * icu/unicode/utypes.h: Removed.
729         * icu/unicode/uvernum.h: Removed.
730         * icu/unicode/uversion.h: Removed.
731
732 2017-07-03  Brady Eidson  <beidson@apple.com>
733
734         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
735         https://bugs.webkit.org/show_bug.cgi?id=174073
736
737         Reviewed by Andy Estes.
738
739         WebView now keeps a direct copy of its main frame icon as a member variable.
740         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
741         
742         This change causes a progression in KVO observation of the mainFrameIcon property as we now
743         have both the old icon and new icon at the time it changes.
744
745         * WebCoreSupport/WebFrameLoaderClient.h:
746         * WebCoreSupport/WebFrameLoaderClient.mm:
747         (WebFrameLoaderClient::prepareForDataSourceReplacement):
748         (WebFrameLoaderClient::getLoadDecisionForIcons):
749         (WebFrameLoaderClient::finishedLoadingIcon):
750         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
751         (WebFrameLoaderClient::registerForIconNotification): Deleted.
752
753         * WebView/WebView.mm:
754         (+[WebView _setIconLoadingEnabled:]):
755         (+[WebView _isIconLoadingEnabled]):
756         (-[WebView mainFrameIcon]):
757         (-[WebView _setMainFrameIcon:]):
758         (-[WebView _receivedIconChangedNotification:]): Deleted.
759         (-[WebView _registerForIconNotification:]): Deleted.
760         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
761         * WebView/WebViewData.h:
762         * WebView/WebViewInternal.h:
763         * WebView/WebViewPrivate.h:
764
765 2017-07-03  Sam Weinig  <sam@webkit.org>
766
767         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
768         https://bugs.webkit.org/show_bug.cgi?id=174083
769
770         Reviewed by Alex Christensen.
771
772         * Configurations/FeatureDefines.xcconfig:
773         Add ENABLE_NAVIGATOR_STANDALONE.
774
775 2017-07-03  Tim Horton  <timothy_horton@apple.com>
776
777         Expose unobscuredSafeAreaInsets on WebView
778         https://bugs.webkit.org/show_bug.cgi?id=174075
779         <rdar://problem/33096997>
780
781         Reviewed by Beth Dakin.
782
783         * WebView/WebView.mm:
784         (-[WebView _setUnobscuredSafeAreaInsets:]):
785         (-[WebView _unobscuredSafeAreaInsets]):
786         * WebView/WebViewPrivate.h:
787         Expose unobscuredSafeAreaInsets as a new private property on WebView,
788         similar to how it is exposed in WebKit2.
789
790 2017-07-03  Andy Estes  <aestes@apple.com>
791
792         [Xcode] Add an experimental setting to build with ccache
793         https://bugs.webkit.org/show_bug.cgi?id=173875
794
795         Reviewed by Tim Horton.
796
797         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
798
799 2017-07-03  Tim Horton  <timothy_horton@apple.com>
800
801         Expose WebPreferences for viewport-fit and constant() properties
802         https://bugs.webkit.org/show_bug.cgi?id=174072
803         <rdar://problem/33096639>
804
805         Reviewed by Ryosuke Niwa.
806
807         * WebView/WebPreferenceKeysPrivate.h:
808         * WebView/WebPreferences.mm:
809         (-[WebPreferences viewportFitEnabled]):
810         (-[WebPreferences setViewportFitEnabled:]):
811         (-[WebPreferences constantPropertiesEnabled]):
812         (-[WebPreferences setConstantPropertiesEnabled:]):
813         * WebView/WebPreferencesPrivate.h:
814         * WebView/WebView.mm:
815         (-[WebView _preferencesChanged:]):
816
817 2017-07-01  Tim Horton  <timothy_horton@apple.com>
818
819         Expose viewport-fit value to UIKit via viewport arguments dictionary
820         https://bugs.webkit.org/show_bug.cgi?id=174071
821         <rdar://problem/33096620>
822
823         Reviewed by Wenson Hsieh.
824
825         * History/WebHistoryItem.mm:
826         * History/WebHistoryItemPrivate.h:
827         Add another dictionary key and three values.
828
829 2017-07-01  Dan Bernstein  <mitz@apple.com>
830
831         [iOS] Remove code only needed when building for iOS 9.x
832         https://bugs.webkit.org/show_bug.cgi?id=174068
833
834         Reviewed by Tim Horton.
835
836         * Configurations/FeatureDefines.xcconfig:
837
838 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
839
840         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
841         https://bugs.webkit.org/show_bug.cgi?id=174004
842
843         Reviewed by Simon Fraser.
844
845         * WebCoreSupport/WebPluginInfoProvider.mm:
846
847 2017-07-01  Dan Bernstein  <mitz@apple.com>
848
849         [macOS] Remove code only needed when building for OS X Yosemite
850         https://bugs.webkit.org/show_bug.cgi?id=174067
851
852         Reviewed by Tim Horton.
853
854         * Configurations/Base.xcconfig:
855         * Configurations/DebugRelease.xcconfig:
856         * Configurations/FeatureDefines.xcconfig:
857         * Configurations/Version.xcconfig:
858         * Plugins/WebBasePluginPackage.mm:
859         (-[WebBasePluginPackage getPluginInfoFromPLists]):
860         * WebCoreSupport/PopupMenuMac.mm:
861         (PopupMenuMac::show):
862         * WebCoreSupport/WebInspectorClient.mm:
863         (WebInspectorFrontendClient::startWindowDrag):
864         (-[WebInspectorWindowController window]):
865         * WebView/WebView.mm:
866         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
867
868 2017-06-30  Daniel Bates  <dabates@apple.com>
869
870         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
871         https://bugs.webkit.org/show_bug.cgi?id=165160
872         <rdar://problem/29451999>
873
874         Reviewed by Brady Eidson.
875
876         Pass the document that is requesting the load to the loader.
877
878         * WebView/WebPDFView.mm:
879         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
880
881 2017-06-29  Jer Noble  <jer.noble@apple.com>
882
883         Make Legacy EME API controlled by RuntimeEnabled setting.
884         https://bugs.webkit.org/show_bug.cgi?id=173994
885
886         Reviewed by Sam Weinig.
887
888         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
889
890         * Configurations/FeatureDefines.xcconfig:
891         * WebView/WebPreferenceKeysPrivate.h:
892         * WebView/WebPreferences.mm:
893         (+[WebPreferences initialize]):
894         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
895         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
896         * WebView/WebPreferencesPrivate.h:
897         * WebView/WebView.mm:
898         (-[WebView _preferencesChanged:]):
899
900 2017-06-30  Chris Dumez  <cdumez@apple.com>
901
902         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
903         https://bugs.webkit.org/show_bug.cgi?id=174013
904
905         Reviewed by Brent Fulgham.
906
907         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
908         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
909
910         * WebView/WebView.mm:
911         (-[WebView _commonInitializationWithFrameName:groupName:]):
912
913 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
914
915         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
916         https://bugs.webkit.org/show_bug.cgi?id=174017
917         <rdar://problem/32959782>
918
919         Reviewed by Simon Fraser.
920
921         Use root view coordinates when computing the drag caret rect.
922
923         * WebView/WebView.mm:
924         (-[WebView _dataInteractionCaretRect]):
925
926 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
927
928         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
929         https://bugs.webkit.org/show_bug.cgi?id=173899
930         rdar://problem/32994474
931
932         Reviewed by Tim Horton.
933
934         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
935         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
936         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
937
938         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
939         documentView is a WebHTMLView.
940
941         * WebView/WebFrame.mm:
942         (-[WebFrame _webHTMLDocumentView]):
943         (-[WebFrame _paintBehaviorForDestinationContext:]):
944         (-[WebFrame _drawRect:contentsOnly:]):
945         (-[WebFrame setTimeoutsPaused:]):
946         (-[WebFrame prepareForPause]):
947         (-[WebFrame resumeFromPause]):
948         (-[WebFrame resetTextAutosizingBeforeLayout]):
949         * WebView/WebHTMLView.mm:
950         (-[WebHTMLView drawLayer:inContext:]):
951         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
952         * WebView/WebHTMLViewInternal.h:
953
954 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
955
956         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
957         https://bugs.webkit.org/show_bug.cgi?id=173854
958         <rdar://problem/32236827>
959
960         Reviewed by Ryosuke Niwa and Tim Horton.
961
962         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
963         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
964
965         * WebView/WebView.mm:
966         (-[WebView _startDrag:]):
967         (-[WebView _dragSourceAction]):
968         (-[WebView _draggedLinkTitle]):
969         (-[WebView _draggedLinkURL]):
970         (-[WebView _draggedElementBounds]):
971         (-[WebView _endedDataInteraction:global:]):
972         * WebView/WebViewData.h:
973         * WebView/WebViewPrivate.h:
974
975 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
976
977         Refactor drag start codepaths to plumb a DragItem to client layers
978         https://bugs.webkit.org/show_bug.cgi?id=173832
979         Work towards <rdar://problem/32236827>
980
981         Reviewed by Ryosuke Niwa and Tim Horton.
982
983         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
984         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
985         to _startDrag: to match logic used to start a drag on other platforms.
986
987         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
988         through the DragItem struct.
989
990         * WebCoreSupport/WebDragClient.h:
991         * WebCoreSupport/WebDragClient.mm:
992         (WebDragClient::startDrag):
993         (WebDragClient::dragSourceActionMaskForPoint):
994         (WebDragClient::willPerformDragSourceAction):
995         (WebDragClient::beginDrag):
996         * WebView/WebView.mm:
997         (-[WebView _startDrag:]):
998         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
999         * WebView/WebViewInternal.h:
1000
1001 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
1002
1003         Remove excessive headers from JavaScriptCore
1004         https://bugs.webkit.org/show_bug.cgi?id=173812
1005
1006         Reviewed by Darin Adler.
1007
1008         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1009         * WebView/WebView.mm:
1010
1011 2017-06-23  Tim Horton  <timothy_horton@apple.com>
1012
1013         Remove an unused typedef from WebFrameLoaderClient
1014         https://bugs.webkit.org/show_bug.cgi?id=173795
1015
1016         Reviewed by Simon Fraser.
1017
1018         * WebCoreSupport/WebFrameLoaderClient.h:
1019         This unused typedef in the global namespace conflicts with one in a macOS system header.
1020         Also... it's unused.
1021         Remove it.
1022
1023 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
1024
1025         Remove excessive headers from WebCore/{bindings,css,dom}
1026         https://bugs.webkit.org/show_bug.cgi?id=173766
1027
1028         Reviewed by Simon Fraser.
1029
1030         * DOM/DOMInternal.mm:
1031
1032 2017-06-22  Daniel Bates  <dabates@apple.com>
1033
1034         Make FrameLoadRequest a move-only type
1035         https://bugs.webkit.org/show_bug.cgi?id=173682
1036
1037         Reviewed by Alex Christensen and Darin Adler.
1038
1039         A FrameLoadRequest groups together the information to perform a load into a single object
1040         that is more manageable to pass around than its constituent parts. Code that receives a
1041         FrameLoadRequest is expected to extract out the information it needs to complete its task.
1042         And it does not make sense to re-use the same FrameLoadRequest object for more than one
1043         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
1044
1045         * Plugins/WebPluginController.mm:
1046         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
1047         * WebView/WebPDFView.mm:
1048         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1049
1050 2017-06-21  Antoine Quint  <graouts@apple.com>
1051
1052         Ensure DRT always logs rAF suspension debugging code
1053         https://bugs.webkit.org/show_bug.cgi?id=173681
1054
1055         Reviewed by Tim "Mr. T" Horton.
1056
1057         * WebView/WebPreferenceKeysPrivate.h:
1058         * WebView/WebPreferences.mm:
1059         (+[WebPreferences initialize]):
1060         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
1061         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
1062         * WebView/WebPreferencesPrivate.h:
1063         * WebView/WebView.mm:
1064         (-[WebView _preferencesChanged:]):
1065
1066 2017-06-21  Daniel Bates  <dabates@apple.com>
1067
1068         Cleanup FrameLoadRequest
1069         https://bugs.webkit.org/show_bug.cgi?id=173564
1070         <rdar://problem/32903570>
1071
1072         Reviewed by Brent Fulgham.
1073
1074         * WebView/WebPDFView.mm:
1075         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
1076         into a local variable and use C++11 brace initialization syntax to make it easier to identify
1077         the arguments passed to FrameLoader::loadFrameRequest().
1078
1079 2017-06-21  Antoine Quint  <graouts@apple.com>
1080
1081         Add logging to identify when the Page suspends scripted animations
1082         https://bugs.webkit.org/show_bug.cgi?id=173626
1083
1084         Reviewed by Tim Horton.
1085
1086         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
1087         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
1088
1089         * WebView/WebPreferenceKeysPrivate.h:
1090         * WebView/WebPreferences.mm:
1091         (+[WebPreferences initialize]):
1092         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
1093         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
1094         * WebView/WebPreferencesPrivate.h:
1095         * WebView/WebView.mm:
1096         (-[WebView _preferencesChanged:]):
1097
1098 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
1099
1100         Disable font variations on macOS Sierra and iOS 10
1101         https://bugs.webkit.org/show_bug.cgi?id=173618
1102         <rdar://problem/32879164>
1103
1104         Reviewed by Jon Lee.
1105
1106         * Configurations/FeatureDefines.xcconfig:
1107
1108 2017-06-20  Daniel Bates  <dabates@apple.com>
1109
1110         Have FrameLoadRequest takes a Frame& instead of a Frame*
1111         https://bugs.webkit.org/show_bug.cgi?id=173614
1112         <rdar://problem/32884890>
1113
1114         Reviewed by Brent Fulgham.
1115
1116         * Plugins/WebPluginController.mm:
1117         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
1118         * WebView/WebFrame.mm:
1119         (-[WebFrame loadRequest:]):
1120         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1121
1122 2017-06-19  Frederic Wang  <fwang@igalia.com>
1123
1124         [Mac] Add an experimental feature setting for async frame scrolling
1125         https://bugs.webkit.org/show_bug.cgi?id=173359
1126
1127         Reviewed by Simon Fraser.
1128
1129         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
1130         * WebView/WebPreferences.mm:
1131         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
1132         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
1133         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
1134         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
1135         * WebView/WebView.mm:
1136         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
1137         scrolling.
1138
1139 2017-06-19  Chris Dumez  <cdumez@apple.com>
1140
1141         Use WTF::Function instead of std::function in more places in WebCore/
1142         https://bugs.webkit.org/show_bug.cgi?id=173535
1143
1144         Reviewed by Antti Koivisto.
1145
1146         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
1147
1148         * WebCoreSupport/WebFrameLoaderClient.h:
1149         * WebCoreSupport/WebFrameLoaderClient.mm:
1150         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1151         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1152         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1153         (WebFrameLoaderClient::dispatchWillSubmitForm):
1154         (WebFrameLoaderClient::setUpPolicyListener):
1155         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
1156         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
1157
1158 2017-05-14 Frederic Wang  <fwang@igalia.com>
1159
1160         Add heuristic to avoid flattening "fullscreen" iframes
1161         https://bugs.webkit.org/show_bug.cgi?id=171914
1162
1163         Reviewed by Simon Fraser.
1164
1165         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
1166
1167         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
1168         * WebView/WebPreferences.mm:
1169         (+[WebPreferences initialize]): Handle frame flattening as an enum.
1170         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
1171         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
1172         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
1173         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
1174         * WebView/WebPreferencesPrivate.h: Ditto.
1175         * WebView/WebView.mm:
1176         (-[WebView _preferencesChanged:]): Ditto.
1177         * WebView/WebPreferencesPrivate.h: Add new enum definition.
1178
1179 2017-06-17  Chris Dumez  <cdumez@apple.com>
1180
1181         Use WTF::Function instead of std::function in WebKit2/
1182         https://bugs.webkit.org/show_bug.cgi?id=173504
1183
1184         Reviewed by Darin Adler.
1185
1186         Use WTF::Function instead of std::function in WebKit2/ to avoid
1187         unnecessary copying.
1188
1189         * Plugins/Hosted/HostedNetscapePluginStream.h:
1190         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1191         (WebKit::HostedNetscapePluginStream::willSendRequest):
1192         * Plugins/WebNetscapePluginStream.h:
1193         * Plugins/WebNetscapePluginStream.mm:
1194         (WebNetscapePluginStream::willSendRequest):
1195         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1196         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1197         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
1198         (WebPaymentCoordinatorClient::openPaymentSetup):
1199
1200 2017-06-16  Sam Weinig  <sam@webkit.org>
1201
1202         [WebIDL] Remove custom bindings for HTMLDocument
1203         https://bugs.webkit.org/show_bug.cgi?id=173444
1204
1205         Reviewed by Darin Adler.
1206
1207         * DOM/DOMHTMLDocument.mm:
1208         (-[DOMHTMLDocument linkColor]):
1209         (-[DOMHTMLDocument setLinkColor:]):
1210         (-[DOMHTMLDocument write:]):
1211         (-[DOMHTMLDocument writeln:]):
1212         Update for new signature of write/writeln and rename of linkColor to linkColorForBindings.
1213
1214 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1215
1216         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
1217         https://bugs.webkit.org/show_bug.cgi?id=173366
1218         <rdar://problem/32767014>
1219
1220         Reviewed by Tim Horton.
1221
1222         Move pieces of iOS WebKit1 drag and drop implementation into OpenSource. No change in behavior.
1223
1224         * Configurations/FeatureDefines.xcconfig:
1225         * WebCoreSupport/WebDragClient.mm:
1226         (WebDragClient::useLegacyDragClient):
1227         (WebDragClient::willPerformDragDestinationAction):
1228         (WebDragClient::dragSourceActionMaskForPoint):
1229         (WebDragClient::willPerformDragSourceAction):
1230         (WebDragClient::startDrag):
1231         (WebDragClient::beginDrag):
1232         (WebDragClient::declareAndWriteDragImage):
1233         (WebDragClient::declareAndWriteAttachment):
1234         (WebDragClient::didConcludeEditDrag):
1235         * WebView/WebView.mm:
1236         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
1237         (-[WebView _getDataInteractionData]):
1238         (-[WebView dragDataForSession:client:global:operation:]):
1239         (-[WebView _enteredDataInteraction:client:global:operation:]):
1240         (-[WebView _updatedDataInteraction:client:global:operation:]):
1241         (-[WebView _exitedDataInteraction:client:global:operation:]):
1242         (-[WebView _performDataInteraction:client:global:operation:]):
1243         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
1244         (-[WebView _endedDataInteraction:global:]):
1245         (-[WebView _didConcludeEditDataInteraction]):
1246         (floatRectsForCGRectArray): Deleted.
1247         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]): Deleted.
1248         * WebView/WebViewData.h:
1249         * WebView/WebViewData.mm:
1250         (-[WebViewPrivate dealloc]):
1251         * WebView/WebViewPrivate.h:
1252
1253 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1254
1255         [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default
1256         https://bugs.webkit.org/show_bug.cgi?id=173454
1257         <rdar://problem/31720671>
1258
1259         Reviewed by Tim Horton.
1260
1261         Adds -webView:dragDestinationActionMaskForSession: as SPI to WebUIDelegate.
1262         If unimplemented, the default UI delegate allows all actions except for URL loading.
1263
1264         * DefaultDelegates/WebDefaultUIDelegate.mm:
1265         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForSession:]):
1266         * WebView/WebUIDelegatePrivate.h:
1267         * WebView/WebView.mm:
1268         (-[WebView dragDestinationActionMaskForSession:]):
1269
1270 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1271
1272         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
1273         https://bugs.webkit.org/show_bug.cgi?id=173338
1274         <rdar://problem/32777720>
1275
1276         Reviewed by Tim Horton.
1277
1278         Rename updatePreferredTypeIdentifiers to updateSupportedTypeIdentifiers.
1279
1280         * WebCoreSupport/WebPlatformStrategies.h:
1281         * WebCoreSupport/WebPlatformStrategies.mm:
1282         (WebPlatformStrategies::updateSupportedTypeIdentifiers):
1283         (WebPlatformStrategies::updatePreferredTypeIdentifiers): Deleted.
1284
1285 2017-06-13  Daniel Bates  <dabates@apple.com>
1286
1287         Implement W3C Secure Contexts Draft Specification
1288         https://bugs.webkit.org/show_bug.cgi?id=158121
1289         <rdar://problem/26012994>
1290
1291         Reviewed by Brent Fulgham.
1292
1293         Part 4
1294
1295         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
1296
1297         * WebView/WebPreferenceKeysPrivate.h:
1298         * WebView/WebPreferences.mm:
1299         (+[WebPreferences initialize]):
1300         (-[WebPreferences isSecureContextAttributeEnabled]):
1301         (-[WebPreferences setIsSecureContextAttributeEnabled:]):
1302         * WebView/WebPreferencesPrivate.h:
1303         * WebView/WebView.mm:
1304         (-[WebView _preferencesChanged:]):
1305
1306 2017-06-13  Sam Weinig  <sam@webkit.org>
1307
1308         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
1309         https://bugs.webkit.org/show_bug.cgi?id=80733
1310
1311         Reviewed by Chris Dumez.
1312
1313         * DOM/DOMUtility.mm:
1314         (createDOMWrapper):
1315         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1316         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
1317         * WebView/WebFrame.mm:
1318         (-[WebFrame _attachScriptDebugger]):
1319         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
1320
1321 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
1322
1323         [WebCrypto] Remove experimental feature flag of SubtleCrypto
1324         https://bugs.webkit.org/show_bug.cgi?id=173197
1325         <rdar://problem/32688148>
1326
1327         Reviewed by Brent Fulgham.
1328
1329         * WebView/WebPreferences.mm:
1330         (+[WebPreferences initialize]):
1331         (-[WebPreferences subtleCryptoEnabled]): Deleted.
1332         (-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
1333         * WebView/WebPreferencesPrivate.h:
1334         * WebView/WebView.mm:
1335         (-[WebView _preferencesChanged:]):
1336
1337 2017-06-10  Dan Bernstein  <mitz@apple.com>
1338
1339         Reverted r218056 because it made the IDE reindex constantly.
1340
1341         * Configurations/DebugRelease.xcconfig:
1342
1343 2017-06-10  Dan Bernstein  <mitz@apple.com>
1344
1345         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
1346         https://bugs.webkit.org/show_bug.cgi?id=173223
1347
1348         Reviewed by Sam Weinig.
1349
1350         The rebuilds were happening due to a difference in the compiler options that the IDE and
1351         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
1352         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
1353         specify an appropriate path in CLANG_INDEX_STORE_PATH.
1354
1355         * Configurations/DebugRelease.xcconfig:
1356
1357 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1358
1359         [iOS DnD] Add a hook to perform two-step drops in editable content
1360         https://bugs.webkit.org/show_bug.cgi?id=172992
1361         <rdar://problem/32590174>
1362
1363         Reviewed by Tim Horton.
1364
1365         Adds a new SPI to WebUIKitDelegate to allow WK1 clients to override default drop behavior. Returning YES from
1366         -performTwoStepDrop:atDestination:isMove: will prevent content from being inserted on drop in WebKit; otherwise,
1367         returning NO will continue with default WebKit behavior.
1368
1369         * WebCoreSupport/WebEditorClient.h:
1370         * WebCoreSupport/WebEditorClient.mm:
1371         (WebEditorClient::performTwoStepDrop):
1372
1373 2017-06-08  Jer Noble  <jer.noble@apple.com>
1374
1375         Clients of the WK2 C-API don't have their mediaContentTypesRequiringHardwareSupport setting initialized correctly.
1376         https://bugs.webkit.org/show_bug.cgi?id=173091
1377
1378         Reviewed by Eric Carlson.
1379
1380         * WebView/WebPreferences.mm:
1381         (+[WebPreferences initialize]):
1382
1383 2017-06-07  Jer Noble  <jer.noble@apple.com>
1384
1385         Clean-up: RenderElement.h includes headers it doesn't use
1386         https://bugs.webkit.org/show_bug.cgi?id=173046
1387
1388         Reviewed by Andy Estes.
1389
1390         * WebView/WebImmediateActionController.mm:
1391
1392 2017-06-07  Zalan Bujtas  <zalan@apple.com>
1393
1394         [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
1395         https://bugs.webkit.org/show_bug.cgi?id=173044
1396         <rdar://problem/32449338>
1397
1398         Reviewed by Tim Horton.
1399
1400         Cache the current device orientation so that we don't have to lift the WebThread lock
1401         to collect it.
1402
1403         * WebView/WebFrame.mm:
1404         (-[WebFrame deviceOrientationChanged]):
1405         * WebView/WebView.mm:
1406         (-[WebView _commonInitializationWithFrameName:groupName:]):
1407         (-[WebView _setDeviceOrientation:]):
1408         (-[WebView _deviceOrientation]):
1409         * WebView/WebViewData.h:
1410         * WebView/WebViewInternal.h:
1411
1412 2017-06-06  Jer Noble  <jer.noble@apple.com>
1413
1414         [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
1415         https://bugs.webkit.org/show_bug.cgi?id=173008
1416
1417         Reviewed by Eric Carlson.
1418
1419         Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
1420
1421         * WebView/WebPreferenceKeysPrivate.h:
1422         * WebView/WebPreferences.mm:
1423         (+[WebPreferences initialize]):
1424         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
1425         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
1426         * WebView/WebPreferencesPrivate.h:
1427         * WebView/WebView.mm:
1428         (-[WebView _preferencesChanged:]):
1429
1430 2017-06-06  Youenn Fablet  <youenn@apple.com>
1431
1432         Add an option to disable getUserMedia prompt in case of mock capture sources
1433         https://bugs.webkit.org/show_bug.cgi?id=172981
1434         <rdar://problem/32580325>
1435
1436         Reviewed by Eric Carlson.
1437
1438         Defining the option, getter and setter.
1439
1440         * WebView/WebPreferences.mm:
1441         (+[WebPreferences initialize]):
1442         (-[WebPreferences mockCaptureDevicesPromptEnabled]):
1443         (-[WebPreferences setMockCaptureDevicesPromptEnabled:]):
1444         * WebView/WebPreferencesPrivate.h:
1445
1446 2017-06-05  Dan Bernstein  <mitz@apple.com>
1447
1448         Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.
1449
1450         * WebView/WebView.mm:
1451         (-[WebView updateMediaTouchBar]):
1452         * WebView/WebViewData.h:
1453
1454 2017-06-03  Darin Adler  <darin@apple.com>
1455
1456         Streamline handling of attributes, using references as much as possible
1457         https://bugs.webkit.org/show_bug.cgi?id=172899
1458
1459         Reviewed by Chris Dumez.
1460
1461         * WebView/WebHTMLRepresentation.mm:
1462         (matchLabelsAgainstElement): Added handling of nullptr since nothing guarantees the
1463         passed in element can't be null. Removed unnecessary conversion from NSString to String
1464         and then back to NSString.
1465
1466 2017-06-01  Andy Estes  <aestes@apple.com>
1467
1468         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
1469         https://bugs.webkit.org/show_bug.cgi?id=172828
1470
1471         Reviewed by Beth Dakin.
1472
1473         * Configurations/FeatureDefines.xcconfig:
1474
1475 2017-05-31  Andy Estes  <aestes@apple.com>
1476
1477         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
1478         https://bugs.webkit.org/show_bug.cgi?id=172366
1479
1480         Reviewed by Daniel Bates.
1481
1482         * Configurations/FeatureDefines.xcconfig:
1483
1484 2017-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1485
1486         Only include DataDetectorsUI headers in iOS
1487         https://bugs.webkit.org/show_bug.cgi?id=172633
1488
1489         Reviewed by David Kilzer.
1490
1491         Enable data detectors only on iOS and not other variants of iOS.
1492
1493         * WebCoreSupport/WebFrameLoaderClient.mm:
1494
1495 2017-05-30  Alex Christensen  <achristensen@webkit.org>
1496
1497         Update libwebrtc configuration
1498         https://bugs.webkit.org/show_bug.cgi?id=172727
1499
1500         Reviewed by Geoffrey Garen.
1501
1502         * Configurations/FeatureDefines.xcconfig:
1503
1504 2017-05-28  Dan Bernstein  <mitz@apple.com>
1505
1506         [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
1507         https://bugs.webkit.org/show_bug.cgi?id=172691
1508
1509         Reviewed by Tim Horton.
1510
1511         * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
1512
1513 2017-05-26  Brent Fulgham  <bfulgham@apple.com>
1514
1515         [WK2] Address thread safety issues with ResourceLoadStatistics
1516         https://bugs.webkit.org/show_bug.cgi?id=172519
1517         <rdar://problem/31707642>
1518
1519         Reviewed by Chris Dumez.
1520
1521         Create a new WorkQueue for the ResourceLoadStatistics store to use for processing data.
1522
1523         * WebView/WebView.mm:
1524         (WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Pass WorkQueue to the observer.
1525
1526 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
1527
1528         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
1529         https://bugs.webkit.org/show_bug.cgi?id=172554
1530         <rdar://problem/31247133>
1531
1532         Reviewed by Simon Fraser.
1533
1534         Update an overridden internal AppKit function to the new signature.
1535
1536         * WebView/WebHTMLView.mm:
1537         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
1538         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1539         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
1540         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1541
1542 2017-05-24  Jer Noble  <jer.noble@apple.com>
1543
1544         Rename DisplaySleepDisabler -> SleepDisabler
1545         https://bugs.webkit.org/show_bug.cgi?id=172478
1546
1547         Reviewed by Sam Weinig.
1548
1549         * WebView/WebFullScreenController.h:
1550
1551 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
1552
1553         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
1554         https://bugs.webkit.org/show_bug.cgi?id=172522
1555         rdar://problem/31071812
1556
1557         Reviewed by Tim Horton.
1558
1559         There's no need to consult -[NSWindow viewsNeedDisplay] on newer OSes. It was
1560         added in r58623, and modified in r61204 for Carbon apps, but with more recent AppKit
1561         versions this synchronization is no longer required.
1562
1563         * WebView/WebView.mm:
1564         (LayerFlushController::flushLayers):
1565
1566 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
1567
1568         Snapshotting via -renderInContext: should do synchronous image decodes
1569         https://bugs.webkit.org/show_bug.cgi?id=172485
1570         rdar://problem/32276146
1571
1572         Reviewed by Tim Horton.
1573
1574         Remove the _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap: SPI that no longer
1575         has any callers.
1576
1577         * Plugins/WebBaseNetscapePluginView.h:
1578         * Plugins/WebBaseNetscapePluginView.mm:
1579         (-[WebBaseNetscapePluginView inFlatteningPaint]): Deleted.
1580         * WebView/WebFrame.mm:
1581         (-[WebFrame _paintBehaviorForDestinationContext:]):
1582         (-[WebFrame _drawRect:contentsOnly:]):
1583         (-[WebFrame _shouldFlattenCompositingLayers:]): Deleted.
1584         * WebView/WebHTMLView.mm:
1585         (imageFromRect):
1586         * WebView/WebView.mm:
1587         (-[WebView _commonInitializationWithFrameName:groupName:]):
1588         (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): Deleted.
1589         (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]): Deleted.
1590         * WebView/WebViewData.h:
1591         * WebView/WebViewPrivate.h:
1592
1593 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
1594
1595         Remove dead ENABLE(FONT_LOAD_EVENTS) code
1596         https://bugs.webkit.org/show_bug.cgi?id=172517
1597
1598         Rubber-stamped by Simon Fraser.
1599
1600         * Configurations/FeatureDefines.xcconfig:
1601
1602 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
1603
1604         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1605         https://bugs.webkit.org/show_bug.cgi?id=171984
1606
1607         Reviewed by Antti Koivisto.
1608
1609         * WebView/WebPreferenceKeysPrivate.h:
1610         * WebView/WebPreferences.mm:
1611         (+[WebPreferences initialize]):
1612         (-[WebPreferences displayContentsEnabled]):
1613         (-[WebPreferences setDisplayContentsEnabled:]):
1614         * WebView/WebPreferencesPrivate.h:
1615         * WebView/WebView.mm:
1616         (-[WebView _preferencesChanged:]):
1617
1618 2017-05-22  Youenn Fablet  <youenn@apple.com>
1619
1620         Remove AVAudioCaptureSource
1621         https://bugs.webkit.org/show_bug.cgi?id=172360
1622
1623         Reviewed by Sam Weinig.
1624
1625         Removing the handling of AVAudio/CoreAudio capture source dynamic switch.
1626
1627         * WebView/WebPreferenceKeysPrivate.h:
1628         * WebView/WebPreferences.mm:
1629         (+[WebPreferences initialize]):
1630         (-[WebPreferences useAVFoundationAudioCapture]): Deleted.
1631         (-[WebPreferences setUseAVFoundationAudioCapture:]): Deleted.
1632         * WebView/WebPreferencesPrivate.h:
1633         * WebView/WebView.mm:
1634         (-[WebView _preferencesChanged:]):
1635
1636 2017-05-22  Sam Weinig  <sam@webkit.org>
1637
1638         [WebIDL] Support callbacks with arbitrary return types
1639         https://bugs.webkit.org/show_bug.cgi?id=172407
1640
1641         Reviewed by Chris Dumez.
1642
1643         * DOM/DOM.mm:
1644         (-[DOMNodeFilter acceptNode:]):
1645         Update for CallbackResult adoption in the base class.
1646
1647         * DOM/DOMNodeIterator.mm:
1648         * DOM/DOMTreeWalker.mm:
1649         Update to account for new WebCore implementation return types. We return nil
1650         if there was an exception, since retains the existing behavior if a javascript
1651         NodeFilter had been used (an exception would cause all nodes to be rejected,
1652         thus returning nullptr).
1653
1654         * DOM/ObjCNodeFilterCondition.h:
1655         * DOM/ObjCNodeFilterCondition.mm:
1656         Update to match new interface of NodeFilterCondition.
1657
1658 2017-05-18  Sam Weinig  <sam@webkit.org>
1659
1660         [WebIDL] Remove the need for the generator to know about native type mapping
1661         https://bugs.webkit.org/show_bug.cgi?id=172310
1662
1663         Reviewed by Darin Adler.
1664
1665         * DOM/DOM.mm:
1666         (-[DOMNodeFilter acceptNode:]):
1667         Update to pass Node by reference.
1668
1669 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1670
1671         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
1672         https://bugs.webkit.org/show_bug.cgi?id=172098
1673
1674         Reviewed by Saam Barati.
1675
1676         * Plugins/Hosted/ProxyInstance.mm:
1677         * Plugins/Hosted/ProxyRuntimeObject.mm:
1678
1679 2017-05-18  Andy Estes  <aestes@apple.com>
1680
1681         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
1682         https://bugs.webkit.org/show_bug.cgi?id=172305
1683
1684         Reviewed by Anders Carlsson.
1685
1686         * Configurations/FeatureDefines.xcconfig:
1687
1688 2017-05-18  Commit Queue  <commit-queue@webkit.org>
1689
1690         Unreviewed, rolling out r217031, r217032, and r217037.
1691         https://bugs.webkit.org/show_bug.cgi?id=172293
1692
1693         cause linking errors in Windows (Requested by yusukesuzuki on
1694         #webkit).
1695
1696         Reverted changesets:
1697
1698         "[JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass"
1699         https://bugs.webkit.org/show_bug.cgi?id=172098
1700         http://trac.webkit.org/changeset/217031
1701
1702         "Unreviewed, rebaseline for newly added ClassInfo"
1703         https://bugs.webkit.org/show_bug.cgi?id=172098
1704         http://trac.webkit.org/changeset/217032
1705
1706         "Unreviewed, fix debug and non-JIT build"
1707         https://bugs.webkit.org/show_bug.cgi?id=172098
1708         http://trac.webkit.org/changeset/217037
1709
1710 2017-05-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1711
1712         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
1713         https://bugs.webkit.org/show_bug.cgi?id=172098
1714
1715         Reviewed by Saam Barati.
1716
1717         * Plugins/Hosted/ProxyInstance.mm:
1718         * Plugins/Hosted/ProxyRuntimeObject.mm:
1719
1720 2017-05-17  Matt Lewis  <jlewis3@apple.com>
1721
1722         Unreviewed, rolling out r216974.
1723
1724         Revision caused consistent timeouts on all platforms.
1725
1726         Reverted changeset:
1727
1728         "Add a RuntimeEnabledFeature for display: contents, defaulted
1729         to false."
1730         https://bugs.webkit.org/show_bug.cgi?id=171984
1731         http://trac.webkit.org/changeset/216974
1732
1733 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
1734
1735         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1736         https://bugs.webkit.org/show_bug.cgi?id=171984
1737
1738         Reviewed by Antti Koivisto.
1739
1740         * WebView/WebPreferenceKeysPrivate.h:
1741         * WebView/WebPreferences.mm:
1742         (+[WebPreferences initialize]):
1743         (-[WebPreferences displayContentsEnabled]):
1744         (-[WebPreferences setDisplayContentsEnabled:]):
1745         * WebView/WebPreferencesPrivate.h:
1746         * WebView/WebView.mm:
1747         (-[WebView _preferencesChanged:]):
1748
1749 2017-05-16  Sam Weinig  <sam@webkit.org>
1750
1751         Bring Notification.idl up to spec
1752         https://bugs.webkit.org/show_bug.cgi?id=172156
1753
1754         Reviewed by Chris Dumez.
1755
1756         * WebCoreSupport/WebNotificationClient.h:
1757         * WebCoreSupport/WebNotificationClient.mm:
1758         (generateNotificationID):
1759         (WebNotificationClient::show):
1760         (WebNotificationClient::cancel):
1761         (WebNotificationClient::clearNotifications):
1762         (WebNotificationClient::notificationObjectDestroyed):
1763         (WebNotificationClient::requestPermission):
1764         (WebNotificationClient::hasPendingPermissionRequests):
1765         (WebNotificationClient::checkPermission):
1766         (-[WebNotificationPolicyListener allow]):
1767         (-[WebNotificationPolicyListener deny]):
1768         * WebView/WebNotification.mm:
1769         (-[WebNotification iconURL]):
1770         (-[WebNotification dir]):
1771         Simplify #ifdefs and update for enum vs String usage.
1772
1773 2017-05-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
1774
1775         Do not delete asynchronously decoded frames for large images if their clients are in the viewport
1776         https://bugs.webkit.org/show_bug.cgi?id=170640
1777
1778         Reviewed by Simon Fraser.
1779
1780         Enable the async decoding for large images.
1781
1782         * WebView/WebView.mm:
1783         (-[WebView _preferencesChanged:]):
1784
1785 2017-05-15  Jer Noble  <jer.noble@apple.com>
1786
1787         Add experimental setting to allow document gesture interaction to fulfill media playback gesture requirement
1788         https://bugs.webkit.org/show_bug.cgi?id=172131
1789
1790         Reviewed by Eric Carlson.
1791
1792         * WebView/WebPreferenceKeysPrivate.h:
1793         * WebView/WebPreferences.mm:
1794         (+[WebPreferences initialize]):
1795         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
1796         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
1797         * WebView/WebPreferencesPrivate.h:
1798
1799 2017-05-12  Chris Dumez  <cdumez@apple.com>
1800
1801         Drop uses of PassRefPtr in WebKit/mac
1802         https://bugs.webkit.org/show_bug.cgi?id=172066
1803
1804         Reviewed by Sam Weinig.
1805
1806         * History/WebBackForwardListInternal.h:
1807         * History/WebHistoryItem.mm:
1808         (kit):
1809         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
1810         * History/WebHistoryItemInternal.h:
1811         * Plugins/Hosted/HostedNetscapePluginStream.h:
1812         (WebKit::HostedNetscapePluginStream::create):
1813         * Plugins/Hosted/NetscapePluginHostManager.h:
1814         * Plugins/Hosted/NetscapePluginHostManager.mm:
1815         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1816         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1817         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1818         (WebKit::NetscapePluginInstanceProxy::PluginRequest::create):
1819         (WebKit::NetscapePluginInstanceProxy::create):
1820         (WebKit::NetscapePluginInstanceProxy::setManualStream):
1821         * Plugins/Hosted/ProxyInstance.h:
1822         (WebKit::ProxyInstance::create):
1823         * Plugins/Hosted/ProxyInstance.mm:
1824         (WebKit::ProxyInstance::ProxyInstance):
1825         (WebKit::ProxyInstance::newRuntimeObject):
1826         * Plugins/Hosted/ProxyRuntimeObject.h:
1827         (WebKit::ProxyRuntimeObject::create):
1828         * Plugins/Hosted/ProxyRuntimeObject.mm:
1829         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
1830         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1831         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1832         (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1833         * Plugins/WebBaseNetscapePluginView.h:
1834         * Plugins/WebBaseNetscapePluginView.mm:
1835         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1836         * Plugins/WebNetscapePluginStream.h:
1837         (WebNetscapePluginStream::create):
1838         * Plugins/WebNetscapePluginView.h:
1839         * Plugins/WebNetscapePluginView.mm:
1840         (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
1841         * WebCoreSupport/WebChromeClient.mm:
1842         * WebCoreSupport/WebEditorClient.mm:
1843         * WebCoreSupport/WebNotificationClient.mm:
1844         (WebNotificationClient::requestPermission):
1845         (-[WebNotificationPolicyListener initWithCallback:]):
1846         * WebCoreSupport/WebOpenPanelResultListener.mm:
1847         * WebCoreSupport/WebUserMediaClient.mm:
1848         (WebUserMediaClient::requestUserMediaAccess):
1849         (WebUserMediaClient::enumerateMediaDevices):
1850         (-[WebUserMediaPolicyListener initWithUserMediaRequest:]):
1851         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
1852         * WebView/WebArchive.mm:
1853         (-[WebArchivePrivate initWithCoreArchive:]):
1854         (-[WebArchivePrivate setCoreArchive:]):
1855         (-[WebArchive initWithData:]):
1856         (-[WebArchive subframeArchives]):
1857         (-[WebArchive _initWithCoreLegacyWebArchive:]):
1858         * WebView/WebArchiveInternal.h:
1859         * WebView/WebDataSource.mm:
1860         (WebDataSourcePrivate::WebDataSourcePrivate):
1861         (WebDataSourcePrivate::~WebDataSourcePrivate):
1862         (-[WebDataSource _initWithDocumentLoader:]):
1863         * WebView/WebDataSourceInternal.h:
1864         * WebView/WebDeviceOrientation.mm:
1865         (-[WebDeviceOrientation initWithCoreDeviceOrientation:]):
1866         * WebView/WebDeviceOrientationInternal.h:
1867         * WebView/WebFrame.mm:
1868         (-[WebFrame _convertToDOMRange:]):
1869         (-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
1870         * WebView/WebFrameInternal.h:
1871         * WebView/WebFullScreenController.h:
1872         * WebView/WebFullScreenController.mm:
1873         (-[WebFullScreenController setElement:]):
1874         * WebView/WebGeolocationPosition.mm:
1875         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1876         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1877         * WebView/WebHTMLView.mm:
1878         (currentKeyboardEvent):
1879         * WebView/WebResource.mm:
1880         * WebView/WebScriptWorld.mm:
1881         (-[WebScriptWorld initWithWorld:]):
1882         (+[WebScriptWorld standardWorld]):
1883         (+[WebScriptWorld findOrCreateWorld:]):
1884         * WebView/WebViewData.h:
1885         (LayerFlushController::create):
1886
1887 2017-05-11  Chris Dumez  <cdumez@apple.com>
1888
1889         Drop remaining uses of PassRefPtr in WebCore
1890         https://bugs.webkit.org/show_bug.cgi?id=172013
1891
1892         Reviewed by Yusuke Suzuki.
1893
1894         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1895         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1896         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
1897         (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
1898         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1899         (-[WebHostedNetscapePluginView createPluginBindingsInstance:]):
1900
1901 2017-05-11  Tim Horton  <timothy_horton@apple.com>
1902
1903         Mail spins launching spell checker when typing
1904         https://bugs.webkit.org/show_bug.cgi?id=171986
1905         <rdar://problem/26305327>
1906
1907         Reviewed by Beth Dakin.
1908
1909         * WebView/WebView.mm:
1910         (-[WebView setEditable:]):
1911         Asynchronously pre-warm the spell checker when a WebView becomes editable.
1912
1913 2017-05-09  Sam Weinig  <sam@webkit.org>
1914
1915         Remove support for legacy Notifications
1916         https://bugs.webkit.org/show_bug.cgi?id=171487
1917
1918         Reviewed by Jon Lee.
1919
1920         * Configurations/FeatureDefines.xcconfig:
1921         * WebCoreSupport/WebNotificationClient.h:
1922         * WebCoreSupport/WebNotificationClient.mm:
1923         * WebView/WebNotification.mm:
1924         * WebView/WebNotificationInternal.h:
1925         * WebView/WebView.mm:
1926         (-[WebView _commonInitializationWithFrameName:groupName:]):
1927         (-[WebView _notificationIDForTesting:]):
1928         Remove legacy notification specific code.
1929
1930 2017-05-10  Chris Dumez  <cdumez@apple.com>
1931
1932         Simplify relationship between Attr and Element now that Attr is childless
1933         https://bugs.webkit.org/show_bug.cgi?id=171909
1934
1935         Reviewed by Ryosuke Niwa.
1936
1937         Build fix.
1938
1939         * DOM/DOMAttr.mm:
1940         (-[DOMAttr value]):
1941         (-[DOMAttr setValue:]):
1942
1943 2017-05-08  Chris Dumez  <cdumez@apple.com>
1944
1945         Move 'style' from Element to HTMLElement / SVGElement and make it settable
1946         https://bugs.webkit.org/show_bug.cgi?id=171795
1947
1948         Reviewed by Alex Christensen.
1949
1950         Build fix.
1951
1952         * DOM/DOMElement.mm:
1953         (-[DOMElement style]):
1954         * WebCoreSupport/WebEditorClient.mm:
1955         (WebEditorClient::shouldApplyStyle):
1956         * WebView/WebFrame.mm:
1957         (-[WebFrame _typingStyle]):
1958
1959 2017-05-06  Chris Dumez  <cdumez@apple.com>
1960
1961         Align our IDL files with the latest DOM specification
1962         https://bugs.webkit.org/show_bug.cgi?id=171777
1963
1964         Reviewed by Sam Weinig.
1965
1966         Build fix.
1967
1968         * DOM/DOMDocument.mm:
1969         (-[DOMDocument readyState]):
1970
1971 2017-05-05  Jeremy Jones  <jeremyj@apple.com>
1972
1973         REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
1974         https://bugs.webkit.org/show_bug.cgi?id=171610
1975         <rdar://problem/31976820>
1976
1977         Reviewed by Eric Carlson.
1978
1979         Fullscreen state gets confused because WK1 WebChromeClient doesn't implement exitVideoFullscreenToModeWithoutAnimation.
1980
1981         * WebCoreSupport/WebChromeClient.h:
1982         * WebCoreSupport/WebChromeClient.mm:
1983         (WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):
1984
1985 2017-05-04  Commit Queue  <commit-queue@webkit.org>
1986
1987         Unreviewed, rolling out r216206.
1988         https://bugs.webkit.org/show_bug.cgi?id=171714
1989
1990         Multiple LayoutTests crashing in Document::page() (Requested
1991         by ap on #webkit).
1992
1993         Reverted changeset:
1994
1995         "Remove support for legacy Notifications"
1996         https://bugs.webkit.org/show_bug.cgi?id=171487
1997         http://trac.webkit.org/changeset/216206
1998
1999 2017-05-04  Jeremy Jones  <jeremyj@apple.com>
2000
2001         UIColor +whiteColor and +clearColor are ambiguous and need to be casted when soft linked.
2002         https://bugs.webkit.org/show_bug.cgi?id=171704
2003
2004         Reviewed by Jer Noble.
2005
2006         Fix build by casting result of +whiteColor to UIColor.
2007
2008         * WebView/WebView.mm:
2009         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
2010
2011 2017-05-04  Sam Weinig  <sam@webkit.org>
2012
2013         Remove support for legacy Notifications
2014         https://bugs.webkit.org/show_bug.cgi?id=171487
2015
2016         Reviewed by Jon Lee.
2017
2018         * Configurations/FeatureDefines.xcconfig:
2019         * WebCoreSupport/WebNotificationClient.h:
2020         * WebCoreSupport/WebNotificationClient.mm:
2021         * WebView/WebNotification.mm:
2022         * WebView/WebNotificationInternal.h:
2023         * WebView/WebView.mm:
2024         (-[WebView _commonInitializationWithFrameName:groupName:]):
2025         (-[WebView _notificationIDForTesting:]):
2026         Remove legacy notification specific code.
2027
2028 2017-05-03  Joseph Pecoraro  <pecoraro@apple.com>
2029
2030         [Cocoa] Stop exporting symbols for ivars that were made private
2031         https://bugs.webkit.org/show_bug.cgi?id=171631
2032
2033         Reviewed by Dan Bernstein.
2034
2035         * WebKit.exp:
2036
2037 2017-05-01  Chris Dumez  <cdumez@apple.com>
2038
2039         Remove some usage of PassRefPtr in editing code
2040         https://bugs.webkit.org/show_bug.cgi?id=171490
2041
2042         Reviewed by Darin Adler.
2043
2044         * WebView/WebFrame.mm:
2045         (-[WebFrame dictationResultMetadataForRange:]):
2046         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2047
2048 2017-05-01  Beth Dakin  <bdakin@apple.com>
2049
2050         On-screen panel for candidate bar is in the wrong place when the caret is at the 
2051         start of a paragraph
2052         https://bugs.webkit.org/show_bug.cgi?id=171453
2053         -and corresponding-
2054         rdar://problem/29779764
2055
2056         Reviewed by Tim Horton.
2057
2058         This bug only happens when the caret is at the beginning of the paragraph, and it 
2059         is because Range::absoluteTextQuads() returns no quads in this case. I think it 
2060         might be correct that absoluteTextQuads() returns no quads in this case, so this 
2061         patch fixes the bug at the call site by using absoluteCaretBounds() in this case.
2062
2063         * WebCoreSupport/WebEditorClient.mm:
2064         (WebEditorClient::handleRequestedCandidates):
2065
2066 2017-04-30  Dan Bernstein  <mitz@apple.com>
2067
2068         [Cocoa] Replaces uses of [get…() alloc] with alloc…Instance()
2069         https://bugs.webkit.org/show_bug.cgi?id=171485
2070
2071         Reviewed by Geoffrey Garen.
2072
2073         * WebView/WebView.mm:
2074         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2075         (-[WebUITextIndicatorData initWithImage:scale:]):
2076
2077 2017-04-28  Youenn Fablet  <youenn@apple.com>
2078
2079         Adding a runtime flag specific to MediaDevices
2080         https://bugs.webkit.org/show_bug.cgi?id=171433
2081
2082         Reviewed by Geoffrey Garen.
2083
2084         Adding a preference for MediaDevices.
2085         Setting media devices runtime flag to false by default.
2086         Setting peer connection and media stream flags to true by default.
2087
2088         * WebView/WebPreferenceKeysPrivate.h:
2089         * WebView/WebPreferences.mm:
2090         (+[WebPreferences initialize]):
2091         (-[WebPreferences mediaDevicesEnabled]):
2092         (-[WebPreferences setMediaDevicesEnabled:]):
2093         * WebView/WebPreferencesPrivate.h:
2094         * WebView/WebView.mm:
2095         (-[WebView _preferencesChanged:]):
2096
2097 2017-04-27  Chris Dumez  <cdumez@apple.com>
2098
2099         Align colspan/rowspan limits with the latest HTML specification
2100         https://bugs.webkit.org/show_bug.cgi?id=171322
2101
2102         Reviewed by Darin Adler.
2103
2104         ObjC bindings build fix.
2105
2106         * DOM/DOMHTMLTableCellElement.mm:
2107         (-[DOMHTMLTableCellElement colSpan]):
2108         (-[DOMHTMLTableCellElement setColSpan:]):
2109
2110 2017-04-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
2111
2112         REGRESSION(r213764): Async decoding of animated images is disabled for ImageDocument
2113         https://bugs.webkit.org/show_bug.cgi?id=170333
2114
2115         Reviewed by Simon Fraser.
2116
2117         Disbale the async decoding for large images for now.
2118
2119         * WebView/WebView.mm:
2120         (-[WebView _preferencesChanged:]):
2121
2122 2017-04-27  Alex Christensen  <achristensen@webkit.org>
2123
2124         Modernize Frame.h
2125         https://bugs.webkit.org/show_bug.cgi?id=171357
2126
2127         Reviewed by Andy Estes.
2128
2129         * WebCoreSupport/WebEditorClient.h:
2130         * WebCoreSupport/WebEditorClient.mm:
2131         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
2132
2133 2017-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2134
2135         [WK1] Tweak the data interaction SPI to indicate whether or not a data interaction was handled
2136         https://bugs.webkit.org/show_bug.cgi?id=171369
2137         <rdar://problem/31858853>
2138
2139         Reviewed by Dan Bernstein.
2140
2141         Introduce a new SPI hook intended to replace performDataInteraction:client:global:operation: that
2142         returns whether or not the data interaction was handled. Due to the difference only in return type
2143         and some staging constraints, this version is prefixed with "_tryTo".
2144
2145         * WebView/WebView.mm:
2146         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
2147         * WebView/WebViewPrivate.h:
2148
2149 2017-04-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2150
2151         WebItemProviderPasteboard should not synchronously load provided data
2152         https://bugs.webkit.org/show_bug.cgi?id=171341
2153         <rdar://problem/31614010>
2154
2155         Reviewed by Tim Horton.
2156
2157         Adds client-layer plumbing for updatePreferredTypeIdentifiers. See WebCore ChangeLog for more details.
2158
2159         * WebCoreSupport/WebPlatformStrategies.h:
2160         * WebCoreSupport/WebPlatformStrategies.mm:
2161         (WebPlatformStrategies::updatePreferredTypeIdentifiers):
2162
2163 2017-04-26  Zalan Bujtas  <zalan@apple.com>
2164
2165         RTL: recent searches popover is displayed in incorrect location
2166         https://bugs.webkit.org/show_bug.cgi?id=171338
2167         <rdar://problem/31377807>
2168
2169         Reviewed by Dean Jackson.
2170
2171         Add RTL support for the pop-under branch.
2172
2173         * WebCoreSupport/PopupMenuMac.mm:
2174         (PopupMenuMac::show):
2175
2176 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
2177
2178         Limit allowed size of document.title to avoid locking WebKit clients
2179         https://bugs.webkit.org/show_bug.cgi?id=165113
2180         <rdar://problem/28324389>
2181
2182         Reviewed by Darin Adler.
2183
2184         When a web application attempts to set an extremely long title, truncate the
2185         title to a more reasonable size.
2186
2187         We do this at at the presentation layer, rather than in the DOM, so that we do
2188         not affect script function. Instead, we merely limit display to a level that is
2189         reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
2190         layer, so it is a waste of effort to send across IPC.
2191
2192         * WebCoreSupport/WebFrameLoaderClient.h:
2193         * WebCoreSupport/WebFrameLoaderClient.mm:
2194         (WebFrameLoaderClient::dispatchDidReceiveTitle):
2195
2196 2017-04-25  Daniel Bates  <dabates@apple.com>
2197
2198         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
2199         https://bugs.webkit.org/show_bug.cgi?id=136452
2200         <rdar://problem/23412620>
2201
2202         Reviewed by Brent Fulgham.
2203
2204         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
2205
2206         * Configurations/FeatureDefines.xcconfig:
2207
2208 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2209
2210         Support reading NSURL titles from the pasteboard when performing data interaction
2211         https://bugs.webkit.org/show_bug.cgi?id=171156
2212         <rdar://problem/31356937>
2213
2214         Reviewed by Tim Horton.
2215
2216         Add a new WK1 SPI property, -[WebFrame hasRichlyEditableDragCaret].
2217
2218         * WebCoreSupport/WebPlatformStrategies.h:
2219         * WebCoreSupport/WebPlatformStrategies.mm:
2220         (WebPlatformStrategies::readURLFromPasteboard):
2221         * WebView/WebFrame.mm:
2222         (-[WebFrame hasRichlyEditableDragCaret]):
2223         * WebView/WebFramePrivate.h:
2224
2225 2017-04-24  Andy VanWagoner  <thetalecrafter@gmail.com>
2226
2227         Clean up ICU headers
2228         https://bugs.webkit.org/show_bug.cgi?id=170997
2229
2230         Reviewed by JF Bastien.
2231
2232         Update all icu headers to 55.1
2233
2234         * icu/README: Explain ICU headers for OS X better
2235         * icu/unicode/localpointer.h:
2236         (LocalPointer::LocalPointer):
2237         (LocalPointer::adoptInsteadAndCheckErrorCode):
2238         * icu/unicode/platform.h:
2239         * icu/unicode/putil.h:
2240         * icu/unicode/uchar.h:
2241         * icu/unicode/uconfig.h:
2242         * icu/unicode/ucurr.h:
2243         * icu/unicode/uidna.h:
2244         * icu/unicode/umachine.h:
2245         * icu/unicode/urename.h:
2246         * icu/unicode/uscript.h:
2247         * icu/unicode/ustring.h:
2248         * icu/unicode/utf8.h:
2249         * icu/unicode/utypes.h:
2250         * icu/unicode/uvernum.h:
2251
2252 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2253
2254         Respect fidelity order when reading web content from item providers
2255         https://bugs.webkit.org/show_bug.cgi?id=171155
2256         <rdar://problem/31356937>
2257
2258         Reviewed by Tim Horton.
2259
2260         Adjusts for changes in WebCore (see WebCore/ChangeLog for more details).
2261
2262         * WebCoreSupport/WebPlatformStrategies.h:
2263         * WebCoreSupport/WebPlatformStrategies.mm:
2264         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex):
2265
2266 2017-04-24  Alex Christensen  <achristensen@webkit.org>
2267
2268         Reduce copies and allocations in SharedBuffer::append
2269         https://bugs.webkit.org/show_bug.cgi?id=170956
2270
2271         Reviewed by Andreas Kling.
2272
2273         * WebView/WebArchive.mm:
2274         (-[WebArchive initWithData:]):
2275         * WebView/WebFrame.mm:
2276         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
2277         * WebView/WebResource.mm:
2278         (-[WebResource initWithCoder:]):
2279         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
2280
2281 2017-04-24  Dan Bernstein  <mitz@apple.com>
2282
2283         [Cocoa] Some ivars are needlessly @protected
2284         https://bugs.webkit.org/show_bug.cgi?id=171208
2285
2286         Reviewed by Anders Carlsson
2287
2288         Made ivars @private where possible.
2289
2290         * Misc/WebUserContentURLPattern.h:
2291         * Plugins/WebPluginDatabase.h:
2292         * Storage/WebDatabaseQuotaManager.h:
2293         * WebCoreSupport/WebSecurityOriginPrivate.h:
2294         * WebInspector/WebInspector.h:
2295         * WebView/WebDeviceOrientation.h:
2296         * WebView/WebDeviceOrientationProviderMock.h:
2297         * WebView/WebGeolocationPosition.h:
2298         * WebView/WebHTMLRepresentation.h:
2299         * WebView/WebNotification.h:
2300
2301 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2302
2303         Support writing link titles to the pasteboard when beginning data interaction on a link
2304         https://bugs.webkit.org/show_bug.cgi?id=171154
2305         <rdar://problem/31356937>
2306
2307         Reviewed by Andy Estes.
2308
2309         Adjust for some changes in WebCore to introduce a separate codepath for writing PasteboardURLs. See WebCore
2310         and WebKit2 ChangeLogs for more details.
2311
2312         * WebCoreSupport/WebPlatformStrategies.h:
2313         * WebCoreSupport/WebPlatformStrategies.mm:
2314         (WebPlatformStrategies::writeToPasteboard):
2315
2316 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2317
2318         Unreviewed, rolling out r215608.
2319
2320         Hundreds of test failures on GTK bot
2321
2322         Reverted changeset:
2323
2324         "Reduce copies and allocations in SharedBuffer::append"
2325         https://bugs.webkit.org/show_bug.cgi?id=170956
2326         http://trac.webkit.org/changeset/215608
2327
2328 2017-04-21  Alex Christensen  <achristensen@webkit.org>
2329
2330         Reduce copies and allocations in SharedBuffer::append
2331         https://bugs.webkit.org/show_bug.cgi?id=170956
2332
2333         Reviewed by Andreas Kling.
2334
2335         * WebView/WebArchive.mm:
2336         (-[WebArchive initWithData:]):
2337         * WebView/WebFrame.mm:
2338         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
2339         * WebView/WebResource.mm:
2340         (-[WebResource initWithCoder:]):
2341         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
2342
2343 2017-04-20  Dewei Zhu  <dewei_zhu@apple.com>
2344
2345         Build fix to start using C++14.
2346         https://bugs.webkit.org/show_bug.cgi?id=171038
2347
2348         Reviewed by Alex Christensen.
2349
2350         Use 'c++14' instead of 'c++11' in order to use 'auto' in lambda.
2351
2352         * Configurations/WebKitLegacy.xcconfig:
2353
2354 2017-04-19  Youenn Fablet  <youenn@apple.com>
2355
2356         [Mac] Allow customizing H264 encoder
2357         https://bugs.webkit.org/show_bug.cgi?id=170829
2358
2359         Reviewed by Alex Christensen.
2360
2361         * Configurations/FeatureDefines.xcconfig:
2362
2363 2017-04-19  Anders Carlsson  <andersca@apple.com>
2364
2365         Stop using deprecated APIs, part 3
2366         https://bugs.webkit.org/show_bug.cgi?id=171003
2367         rdar://problem/31589635
2368
2369         Reviewed by Tim Horton.
2370
2371         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2372         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2373         (WebPaymentCoordinatorClient::cancelPaymentSession):
2374         Update for WebCore changes.
2375
2376 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2377
2378         [WK2] Support DataTransfer::files() when performing a DHTML data interaction
2379         https://bugs.webkit.org/show_bug.cgi?id=170880
2380         <rdar://problem/31314689>
2381
2382         Reviewed by Tim Horton.
2383
2384         Adjust for a change in PasteboardStrategy. See WebCore ChangeLog for more details.
2385
2386         * WebCoreSupport/WebPlatformStrategies.h:
2387         * WebCoreSupport/WebPlatformStrategies.mm:
2388         (WebPlatformStrategies::getFilenamesForDataInteraction):
2389
2390 2017-04-17  Youenn Fablet  <youenn@apple.com>
2391
2392         Disable outdated WritableStream API
2393         https://bugs.webkit.org/show_bug.cgi?id=170749
2394         <rdar://problem/31446233>
2395
2396         Reviewed by Alex Christensen.
2397
2398         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
2399         - A STREAMS_API compilation flag.
2400         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
2401
2402         * Configurations/FeatureDefines.xcconfig:
2403         * WebView/WebPreferenceKeysPrivate.h:
2404         * WebView/WebPreferences.mm:
2405         (+[WebPreferences initialize]):
2406         (-[WebPreferences readableByteStreamAPIEnabled]):
2407         (-[WebPreferences setReadableByteStreamAPIEnabled:]):
2408         (-[WebPreferences writableStreamAPIEnabled]):
2409         (-[WebPreferences setWritableStreamAPIEnabled:]):
2410         * WebView/WebPreferencesPrivate.h:
2411         * WebView/WebView.mm:
2412         (-[WebView _preferencesChanged:]):
2413
2414 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2415
2416         [WK2] Support data interaction of files into file inputs
2417         https://bugs.webkit.org/show_bug.cgi?id=170803
2418         <rdar://problem/31286130>
2419
2420         Reviewed by Tim Horton.
2421
2422         Add boilerplate plumbing for fetching the number of files in the pasteboard.
2423
2424         * WebCoreSupport/WebPlatformStrategies.h:
2425         * WebCoreSupport/WebPlatformStrategies.mm:
2426         (WebPlatformStrategies::getNumberOfFiles):
2427
2428 2017-04-14  Mark Lam  <mark.lam@apple.com>
2429
2430         Update architectures in xcconfig files.
2431         https://bugs.webkit.org/show_bug.cgi?id=170867
2432         <rdar://problem/31628104>
2433
2434         Reviewed by Joseph Pecoraro.
2435
2436         * Configurations/FeatureDefines.xcconfig:
2437
2438 2017-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2439
2440         [WK2] Support Icon creation from file URLs on iOS
2441         https://bugs.webkit.org/show_bug.cgi?id=170809
2442         <rdar://problem/31286130>
2443
2444         Reviewed by Tim Horton.
2445
2446         Adjust for changes in the ChromeClient in WebCore.
2447
2448         * WebCoreSupport/WebChromeClient.h:
2449         * WebCoreSupport/WebChromeClient.mm:
2450         (WebChromeClient::loadIconForFiles):
2451         (WebChromeClient::createIconForFiles):
2452
2453 2017-04-12  Dan Bernstein  <mitz@apple.com>
2454
2455         [Mac] Future-proof .xcconfig files
2456         https://bugs.webkit.org/show_bug.cgi?id=170802
2457
2458         Reviewed by Tim Horton.
2459
2460         * Configurations/Base.xcconfig:
2461         * Configurations/DebugRelease.xcconfig:
2462         * Configurations/FeatureDefines.xcconfig:
2463         * Configurations/Version.xcconfig:
2464
2465 2017-04-12  Beth Dakin  <bdakin@apple.com>
2466
2467         Build fix.
2468
2469         * WebView/WebViewData.h:
2470
2471 2017-04-12  Brian Weinstein  <bweinstein@apple.com>
2472
2473         Should always override -[WebStorageManager init].
2474         https://bugs.webkit.org/show_bug.cgi?id=170787
2475         -and corresponding-
2476         rdar://problem/31371835
2477
2478         Reviewed by Anders Carlsson.
2479
2480         * Storage/WebStorageManager.mm:
2481         (-[WebStorageManager init]):
2482
2483 2017-04-12  Beth Dakin  <bdakin@apple.com>
2484
2485         Speculative build fix. 
2486
2487         * WebView/WebViewData.h:
2488
2489 2017-04-12  Beth Dakin  <bdakin@apple.com>
2490
2491         Adopt AVKit name change from AVFunctionBar* to AVTouchBar*
2492         https://bugs.webkit.org/show_bug.cgi?id=170693
2493         -and corresponding-
2494         rdar://problem/31230018
2495
2496         Reviewed by Sam Weinig.
2497
2498         Since the new names only apply to some versions of macOS, this patch uses typedefs 
2499         for the older OS’s. SO:
2500
2501         AVFunctionBarScrubber is now AVTouchBarScrubber
2502
2503         AVFunctionBarPlaybackControlsProvider is now AVTouchBarPlaybackControlsProvider
2504
2505         AVFunctionBarMediaSelectionOption is now AVTouchBarMediaSelectionOption
2506
2507         And the protocol AVFunctionBarPlaybackControlsControlling is now 
2508         AVTouchBarPlaybackControlsControlling
2509
2510         Soft links and allocations cannot use the typedefs.
2511         * WebView/WebView.mm:
2512         (-[WebView updateMediaTouchBar]):
2513         * WebView/WebViewData.h:
2514
2515 2017-04-11  Dean Jackson  <dino@apple.com>
2516
2517         Disable outdated WritableStream API
2518         https://bugs.webkit.org/show_bug.cgi?id=170749
2519         <rdar://problem/31446233>
2520
2521         Reviewed by Tim Horton.
2522
2523         The API we implement is no longer accurate. Disable it until we
2524         are compatible with the new specification
2525
2526         * Configurations/FeatureDefines.xcconfig:
2527
2528 2017-04-11  Dan Bernstein  <mitz@apple.com>
2529
2530         [iOS] Simple HTML documents should allow non-markup JavaScript
2531         https://bugs.webkit.org/show_bug.cgi?id=170734
2532
2533         Reviewed by Sam Weinig.
2534
2535         * WebView/WebView.mm:
2536         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Enabled scripting
2537           but disabled scripting markup.
2538
2539 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2540
2541         Revert r215217
2542         https://bugs.webkit.org/show_bug.cgi?id=170703
2543
2544         * Configurations/FeatureDefines.xcconfig:
2545
2546 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2547
2548         Continue enabling WebRTC
2549         https://bugs.webkit.org/show_bug.cgi?id=170703
2550
2551         Reviewed by Youenn Fablet.
2552
2553         * Configurations/FeatureDefines.xcconfig:
2554
2555 2017-04-10  Anders Carlsson  <andersca@apple.com>
2556
2557         Remove call to WKShowKeyAndMain
2558         https://bugs.webkit.org/show_bug.cgi?id=170691
2559         rdar://problem/31050032
2560
2561         Reviewed by Beth Dakin.
2562
2563         * Carbon/CarbonWindowAdapter.mm:
2564         (-[CarbonWindowAdapter makeKeyWindow]):
2565
2566 2017-04-10  Jeremy Jones  <jeremyj@apple.com>
2567
2568         Add CoreAudioCaptureSource.
2569         https://bugs.webkit.org/show_bug.cgi?id=170112
2570         rdar://problem/30293338
2571
2572         Reviewed by Eric Carlson.
2573
2574         Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio.
2575
2576         * WebView/WebPreferenceKeysPrivate.h:
2577         * WebView/WebPreferences.mm:
2578         (+[WebPreferences initialize]):
2579         (-[WebPreferences useAVFoundationAudioCapture]):
2580         (-[WebPreferences setUseAVFoundationAudioCapture:]):
2581         * WebView/WebPreferencesPrivate.h:
2582         * WebView/WebView.mm:
2583         (-[WebView _preferencesChanged:]):
2584
2585 2017-04-10  Chris Dumez  <cdumez@apple.com>
2586
2587         Drop Timer::startOneShot() overload taking a double
2588         https://bugs.webkit.org/show_bug.cgi?id=170659
2589
2590         Reviewed by Yusuke Suzuki.
2591
2592         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
2593
2594         * Plugins/WebNetscapePluginView.mm:
2595         (PluginTimer::start):
2596         * Storage/WebStorageManager.mm:
2597         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
2598
2599 2017-04-09  Chris Dumez  <cdumez@apple.com>
2600
2601         Drop Timer::startRepeating() overload taking a double
2602         https://bugs.webkit.org/show_bug.cgi?id=170656
2603
2604         Reviewed by Yusuke Suzuki.
2605
2606         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
2607
2608         * Plugins/WebNetscapePluginView.mm:
2609         (PluginTimer::start):
2610
2611 2017-04-09  Chris Dumez  <cdumez@apple.com>
2612
2613         Start dropping Timer API dealing with double
2614         https://bugs.webkit.org/show_bug.cgi?id=170649
2615
2616         Reviewed by Yusuke Suzuki.
2617
2618         Start dropping Timer API dealing with double as people should use Seconds now.
2619
2620         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2621         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2622         (WebKit::NetscapePluginInstanceProxy::loadRequest):
2623         * Plugins/WebNetscapePluginStream.mm:
2624         (WebNetscapePluginStream::deliverData):
2625
2626 2017-04-08  Chris Dumez  <cdumez@apple.com>
2627
2628         Drop std::chrono support from Timer class
2629         https://bugs.webkit.org/show_bug.cgi?id=170645
2630
2631         Reviewed by Sam Weinig.
2632
2633         Drop std::chrono support from Timer class now that we prefer using Seconds type.
2634
2635         * WebView/WebView.mm:
2636         (+[WebView _setCacheModel:]):
2637
2638 2017-04-08  Youenn Fablet  <youenn@apple.com>
2639
2640         WebRTC tests gardening
2641         https://bugs.webkit.org/show_bug.cgi?id=170508
2642
2643         Reviewed by Eric Carlson.
2644
2645         * Configurations/FeatureDefines.xcconfig:
2646
2647 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
2648
2649         Unreviewed, rolling out r215046.
2650
2651         This change broke internal builds.
2652
2653         Reverted changeset:
2654
2655         "WebRTC tests gardening"
2656         https://bugs.webkit.org/show_bug.cgi?id=170508
2657         http://trac.webkit.org/changeset/215046
2658
2659 2017-04-06  Tim Horton  <timothy_horton@apple.com>
2660
2661         Obj-C bindings build fails with CSS_DEVICE_ADAPTATION turned on
2662         https://bugs.webkit.org/show_bug.cgi?id=170566
2663
2664         Reviewed by Simon Fraser.
2665
2666         * DOM/DOMCSS.mm:
2667         (kitClass):
2668         Use the WebCore-side enum for this, since that's actually what we're switching over.
2669         This allows us to handle values here without adding them to the API header.
2670         All of the other kitClass() functions work the same way.
2671         Also, unindent for style purposes.
2672
2673 2017-04-06  Youenn Fablet  <youenn@apple.com>
2674
2675         WebRTC tests gardening
2676         https://bugs.webkit.org/show_bug.cgi?id=170508
2677
2678         Reviewed by Eric Carlson.
2679
2680         * Configurations/FeatureDefines.xcconfig:
2681
2682 2017-04-04  Megan Gardner  <megan_gardner@apple.com>
2683
2684         Fix leaks in WebUITextIndicatorData
2685         https://bugs.webkit.org/show_bug.cgi?id=170480
2686
2687         Reviewed by Wenson Hsieh.
2688
2689         Removes extraneous retains.
2690
2691         * WebView/WebView.mm:
2692         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2693
2694 2017-04-04  Tim Horton  <timothy_horton@apple.com>
2695
2696         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
2697         https://bugs.webkit.org/show_bug.cgi?id=165801
2698         <rdar://problem/29649535>
2699
2700         Reviewed by Wenson Hsieh.
2701
2702         * WebView/WebView.mm:
2703         (incrementFrame):
2704         Adjust to the new CanWrap enum.
2705
2706 2017-03-27  Joseph Pecoraro  <pecoraro@apple.com>
2707
2708         Web Inspector: Saving files should not suggest the top level directory
2709         https://bugs.webkit.org/show_bug.cgi?id=170085
2710         <rdar://problem/30197794>
2711
2712         Reviewed by Matt Baker.
2713
2714         * WebCoreSupport/WebInspectorClient.mm:
2715         (WebInspectorFrontendClient::save):
2716         Don't set panel.directoryURL unless we have a good suggestion.
2717
2718 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2719
2720         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
2721         https://bugs.webkit.org/show_bug.cgi?id=169168
2722         <rdar://problem/30688374>
2723
2724         Reviewed by Tim Horton.
2725
2726         Refactors WebDragClient::actionMaskForDrag to take platform data only, rather than the entire DragData. See the
2727         WebCore ChangeLog entry for more details. Also renames WebDefaultUIDelegate.m to WebDefaultUIDelegate.mm, since
2728         we need to import a C++ header for linkedOnOrAfter().
2729
2730         The default delegate implementation of webView:dragDestinationActionMaskForDraggingInfo: now checks if the current
2731         application is linking against 10.12 or earlier, and if so, will allow any drag destination action instead of
2732         the new default value of everything but DragDestinationActionLoad.
2733
2734         * DefaultDelegates/WebDefaultUIDelegate.mm: Renamed from Source/WebKit/mac/DefaultDelegates/WebDefaultUIDelegate.m.
2735         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
2736         * Misc/WebKitVersionChecks.h:
2737         * WebCoreSupport/WebDragClient.h:
2738         * WebCoreSupport/WebDragClient.mm:
2739         (WebDragClient::actionMaskForDrag): Deleted.
2740         * WebView/WebView.mm:
2741         (-[WebView draggingEntered:]):
2742         (-[WebView draggingUpdated:]):
2743
2744 2017-03-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2745
2746         Add support for showing the platform data interaction caret
2747         https://bugs.webkit.org/show_bug.cgi?id=169898
2748         <rdar://problem/31146295>
2749
2750         Reviewed by Beth Dakin.
2751
2752         Plumb the dataInteractionCaretRect through WebView SPI to WebKit1 clients.
2753
2754         * WebView/WebView.mm:
2755         (-[WebView _dataInteractionCaretRect]):
2756         * WebView/WebViewPrivate.h:
2757
2758 2017-03-22  Dan Bernstein  <mitz@apple.com>
2759
2760         [iOS] downloadableBinaryFontsEnabled is set to false in -initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:
2761         https://bugs.webkit.org/show_bug.cgi?id=169967
2762         <rdar://problem/30406898>
2763
2764         Reviewed by Anders Carlsson.
2765
2766         * WebView/WebView.mm:
2767         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Removed call to
2768           Settings::downloadableBinaryFontsEnabled. The default is true.
2769
2770 2017-03-22  Andy Estes  <aestes@apple.com>
2771
2772         [QuickLook] Rename QuickLookHandle to PreviewLoader
2773         https://bugs.webkit.org/show_bug.cgi?id=169961
2774
2775         Reviewed by Andreas Kling.
2776
2777         * WebCoreSupport/WebFrameLoaderClient.h:
2778         * WebCoreSupport/WebFrameLoaderClient.mm:
2779         (WebFrameLoaderClient::createPreviewLoaderClient):
2780         (WebFrameLoaderClient::createQuickLookHandleClient): Deleted.
2781
2782 2017-03-21  Anders Carlsson  <andersca@apple.com>
2783
2784         Remove bogus availability annotations from DOM SPI headers.
2785         rdar://problem/31015675
2786
2787         Rubber-stamped by Dan Bernstein.
2788
2789         * DOM/DOMHTMLMediaElement.h:
2790         * DOM/DOMHTMLVideoElement.h:
2791         * DOM/DOMMediaError.h:
2792         * DOM/DOMTextEvent.h:
2793         * DOM/DOMTimeRanges.h:
2794         * DOM/DOMTokenList.h:
2795
2796 2017-03-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2797
2798         Teach TextIndicator to estimate the background color of the given Range
2799         https://bugs.webkit.org/show_bug.cgi?id=169869
2800         <rdar://problem/31127272>
2801
2802         Reviewed by Anders Carlsson and Simon Fraser.
2803
2804         Plumb the estimated background color for WebKit1 clients through a new property in WebUITextIndicatorData.
2805
2806         * WebView/WebView.mm:
2807         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2808         (-[WebUITextIndicatorData dealloc]):
2809         * WebView/WebViewPrivate.h:
2810
2811 2017-03-20  Dan Bernstein  <mitz@apple.com>
2812
2813         [Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
2814         https://bugs.webkit.org/show_bug.cgi?id=169861
2815
2816         Reviewed by Sam Weinig.
2817
2818         * MigrateHeaders.make: Touch the PrivateHeaders directory when migrating a header into it.
2819         * postprocess-headers.sh: Preserve the timestamp on the headers directories. Write out the
2820           timestamp file used by the Xcode project to determine whether to run the script.
2821
2822 2017-03-19  Alexey Proskuryakov  <ap@apple.com>
2823
2824         WebHTMLView is useless as WebResourceHandler
2825         https://bugs.webkit.org/show_bug.cgi?id=169857
2826
2827         Reviewed by Dan Bernstein.
2828
2829         * WebView/WebHTMLView.mm:
2830         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2831         WebHTMLView doesnt implement any of WebResourceHandler methods.
2832
2833 2017-03-17  Michael Saboff  <msaboff@apple.com>
2834
2835         Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK
2836         https://bugs.webkit.org/show_bug.cgi?id=169817
2837
2838         Reviewed by Filip Pizlo.
2839
2840         * Configurations/FeatureDefines.xcconfig:
2841
2842 2017-03-17  Antti Koivisto  <antti@apple.com>
2843
2844         Add a reload policy where only expired subresources are revalidated
2845         https://bugs.webkit.org/show_bug.cgi?id=169756
2846
2847         Reviewed by Andreas Kling.
2848
2849         * WebView/WebFrame.mm:
2850         (toWebFrameLoadType):
2851         (-[WebFrame reload]):
2852         (-[WebFrame reloadFromOrigin]):
2853
2854 2017-03-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2855
2856         [WK1] Support animated transitions when performing a data interaction operation
2857         https://bugs.webkit.org/show_bug.cgi?id=169805
2858         <rdar://problem/31045767>
2859
2860         Reviewed by Beth Dakin and Megan Gardner.
2861
2862         Adds WebKit1 support for animated transitions when performing a data interaction operation. See per-method changes
2863         for more details.
2864
2865         * DOM/DOMElement.h:
2866         * DOM/DOMElement.mm:
2867         (-[DOMElement boundsInRootViewSpace]):
2868
2869         Introduce -[DOMElement boundsInRootViewSpace], which returns the bounds of the element in root view coordinates.
2870
2871         * WebCoreSupport/WebDragClient.h:
2872         (): Deleted.
2873         * WebCoreSupport/WebDragClient.mm:
2874         (WebDragClient::didConcludeEditDrag):
2875
2876         Add boilerplate plumbing.
2877
2878         * WebView/WebView.mm:
2879         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
2880
2881         Add contentImageWithoutSelection and contentImageWithoutSelectionRectInRootViewCoordinates to WebUITextIndicatorData.
2882
2883         (floatRectsForCGRectArray):
2884         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
2885
2886         Introduces a SPI helper method in WebView that clients can use to generate an image of a text platter given an
2887         image of some text, as well as clipping rects to apply to the image.
2888
2889         (-[WebView _dataOperationTextIndicator]):
2890
2891         Add SPI to fetch the text indicator used to drive animations for the current data operation.
2892
2893         (-[WebView _didConcludeEditDataInteraction]):
2894         * WebView/WebViewData.h:
2895         * WebView/WebViewInternal.h:
2896         * WebView/WebViewPrivate.h:
2897
2898 2017-03-16  Simon Fraser  <simon.fraser@apple.com>
2899
2900         Improve the system tracing points
2901         https://bugs.webkit.org/show_bug.cgi?id=169790
2902
2903         Reviewed by Zalan Bujtas.
2904
2905         Use a more cohesive set of system trace points that give a good overview of what
2906         WebKit is doing. Added points for resource loading, render tree building, sync messages
2907         to the web process, async image decode, WASM and fetching cookies.
2908
2909         * WebView/WebHTMLView.mm:
2910         (-[WebHTMLView drawRect:]):
2911
2912 2017-03-16  Youenn Fablet  <youenn@apple.com>
2913
2914         Wrap legacy WebRTC API in runtime flag
2915         https://bugs.webkit.org/show_bug.cgi?id=169646
2916
2917         Reviewed by Alex Christensen.
2918
2919         * WebView/WebPreferenceKeysPrivate.h:
2920         * WebView/WebPreferences.mm:
2921         (+[WebPreferences initialize]):
2922         (-[WebPreferences webRTCLegacyAPIEnabled]):
2923         (-[WebPreferences setWebRTCLegacyAPIEnabled:]):
2924         * WebView/WebPreferencesPrivate.h:
2925         * WebView/WebView.mm:
2926         (-[WebView _preferencesChanged:]):
2927
2928 2017-03-14  Megan Gardner  <megan_gardner@apple.com>
2929
2930         Correctly export WebItemProviderPasteboard
2931         https://bugs.webkit.org/show_bug.cgi?id=169578
2932
2933         Reviewed by Tim Horton.
2934
2935         * MigrateHeaders.make:
2936
2937 2017-03-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2938
2939         [WK2] Data interaction tests occasionally hit assertions in debug builds
2940         https://bugs.webkit.org/show_bug.cgi?id=169002
2941         <rdar://problem/30994806>
2942
2943         Reviewed by Tim Horton.
2944
2945         Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.
2946
2947         * WebView/WebHTMLView.mm:
2948         (-[WebHTMLView _updateSelectionForInputManager]):
2949         * WebView/WebView.mm:
2950         (-[WebView updateTextTouchBar]):
2951
2952 2017-03-13  Anders Carlsson  <andersca@apple.com>
2953
2954         Fix build warnings.
2955
2956         * WebCoreSupport/WebInspectorClient.mm:
2957         (WebInspectorFrontendClient::save):
2958         (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2959
2960 2017-03-11  Brady Eidson  <beidson@apple.com>
2961
2962         Cleanup "addCookie" and its sole user.
2963         https://bugs.webkit.org/show_bug.cgi?id=169486
2964
2965         Reviewed by Brian Burg.
2966
2967         * WebCoreSupport/WebPlatformStrategies.h:
2968         * WebCoreSupport/WebPlatformStrategies.mm:
2969         (WebPlatformStrategies::addCookie): Deleted.
2970
2971 2017-03-10  Alex Christensen  <achristensen@webkit.org>
2972
2973         Fix watch and tv builds after r213294
2974         https://bugs.webkit.org/show_bug.cgi?id=169508
2975
2976         Reviewed by Dan Bernstein.
2977
2978         * Configurations/FeatureDefines.xcconfig:
2979
2980 2017-03-10  Alex Christensen  <achristensen@webkit.org>
2981
2982         Fix CMake build.
2983
2984         * WebView/WebNotification.h:
2985         Don't assume we have already included something that includes NSObject.h.
2986
2987 2017-03-09  Daniel Bates  <dabates@apple.com>
2988
2989         Guard Credential Management implementation behind a runtime enabled feature flag
2990         https://bugs.webkit.org/show_bug.cgi?id=169364
2991         <rdar://problem/30957425>
2992
2993         Reviewed by Brent Fulgham.
2994
2995         Add WebKit preference for Credential Management (disabled by default).
2996
2997         * WebView/WebPreferenceKeysPrivate.h:
2998         * WebView/WebPreferences.mm:
2999         (+[WebPreferences initialize]):
3000         (-[WebPreferences credentialManagementEnabled]): Added.
3001         (-[WebPreferences setCredentialManagementEnabled:]): Added.
3002         * WebView/WebPreferencesPrivate.h:
3003         * WebView/WebView.mm:
3004         (-[WebView _preferencesChanged:]):
3005
3006 2017-03-09  Anders Carlsson  <andersca@apple.com>
3007
3008         Add delegate support to WebCore
3009         https://bugs.webkit.org/show_bug.cgi?id=169427
3010         Part of rdar://problem/28880714.
3011
3012         Reviewed by Geoffrey Garen.
3013
3014         * Configurations/FeatureDefines.xcconfig:
3015         Add feature define.
3016
3017 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
3018
3019         Fix DataInteraction guards
3020         https://bugs.webkit.org/show_bug.cgi?id=169404
3021
3022         Reviewed by Wenson Hsieh.
3023
3024         * WebCoreSupport/WebDragClient.mm:
3025
3026 2017-03-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3027
3028         Add plumbing for WebCore to notify WebKit2 when an edit drag has concluded
3029         https://bugs.webkit.org/show_bug.cgi?id=169392
3030         <rdar://problem/30882974>
3031
3032         Reviewed by Tim Horton.
3033
3034         Add a stub implementation of WebDragClient::didConcludeEditDrag.
3035
3036         * WebCoreSupport/WebDragClient.h:
3037
3038 2017-03-08  Anders Carlsson  <andersca@apple.com>
3039
3040         Simplify the PaymentCoordinator interface
3041         https://bugs.webkit.org/show_bug.cgi?id=169382
3042         Part of rdar://problem/28880714.
3043
3044         Reviewed by Tim Horton.
3045
3046         Update for PaymentCoordinatorClient changes.
3047
3048         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3049         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3050         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
3051         (WebPaymentCoordinatorClient::completeShippingContactSelection):
3052         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
3053         (WebPaymentCoordinatorClient::completePaymentSession):
3054
3055 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
3056
3057         Fix for dependency fix
3058         https://bugs.webkit.org/show_bug.cgi?id=169369
3059
3060         Reviewed by Beth Dakin.
3061
3062         * WebView/WebViewPrivate.h:
3063
3064 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
3065
3066         Fix Project Dependency
3067         https://bugs.webkit.org/show_bug.cgi?id=169340
3068
3069         Unreviewed Dependency Fix.
3070
3071         * WebView/WebViewPrivate.h:
3072
3073 2017-03-07  Alexey Proskuryakov  <ap@apple.com>
3074
3075         WebKitLegacy should re-export symbols from WebCore on watchos and tvos
3076         https://bugs.webkit.org/show_bug.cgi?id=169341
3077         <rdar://problem/30913788>
3078
3079         Reviewed by Dan Bernstein.
3080
3081         * MigrateHeaders.make:
3082
3083 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
3084
3085         Have fixedPositionCreatesStackingContext be on by default everywhere
3086         https://bugs.webkit.org/show_bug.cgi?id=169334
3087
3088         Reviewed by Zalan Bujtas.
3089
3090         It makes no sense to have web-exposed CSS functionality be different based on setting,
3091         and other browser are now aligned with having position:fixed create stacking context.
3092
3093         So remove the fixedPositionCreatesStackingContext setting and have StyleResolver::adjustRenderStyle()
3094         always force stacking context for position:fixed.
3095
3096         * WebView/WebView.mm:
3097         (-[WebView _preferencesChanged:]):
3098
3099 2017-03-06  Simon Fraser  <simon.fraser@apple.com>
3100
3101         Initialize the subpixelAntialiasedLayerTextEnabled Setting in WebKit1
3102         https://bugs.webkit.org/show_bug.cgi?id=169230
3103
3104         Reviewed by Tim Horton.
3105
3106         * WebView/WebView.mm:
3107         (-[WebView _preferencesChanged:]):
3108
3109 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
3110
3111         Enable SubpixelAntialiasedLayerTextEnabled by default on some versions of macOS
3112         https://bugs.webkit.org/show_bug.cgi?id=169329
3113
3114         Reviewed by Tim Horton.
3115
3116         If the macOS version is > 101300, enable subpixelAntialiasedLayerTextEnabled.
3117
3118         * WebView/WebPreferences.mm:
3119         (+[WebPreferences initialize]):
3120
3121 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
3122
3123         Additional DataInteraction Support
3124         https://bugs.webkit.org/show_bug.cgi?id=169316
3125         <rdar://problem/30884234>
3126
3127         Reviewed by Wenson Hsieh.
3128
3129         Add stub implementations to WebView for methods that handle data interaction
3130
3131         * WebView/WebView.mm:
3132         (-[WebView _enteredDataInteraction:client:global:operation:]):
3133         (-[WebView _updatedDataInteraction:client:global:operation:]):
3134         (-[WebView _exitedDataInteraction:client:global:operation:]):
3135         (-[WebView _performDataInteraction:client:global:operation:]):
3136         (-[WebView _endedDataInteraction:global:]):
3137         * WebView/WebViewPrivate.h:
3138
3139 2017-03-07  Dean Jackson  <dino@apple.com>
3140
3141         Some platforms won't be able to create a GPUDevice
3142         https://bugs.webkit.org/show_bug.cgi?id=169314
3143         <rdar://problems/30907521>
3144
3145         Reviewed by Jon Lee.
3146
3147         Disable WEB_GPU on the iOS Simulator.
3148
3149         * Configurations/FeatureDefines.xcconfig:
3150
3151 2017-03-07  Maureen Daum  <mdaum@apple.com>
3152
3153         Correctly check for an empty database file.
3154         <rdar://problem/30542242> Removing Website Data not working (WebSQL directories being left behind)
3155         https://bugs.webkit.org/show_bug.cgi?id=169256
3156
3157         Reviewed by Brady Eidson.
3158
3159         Check if the folder for an origin's WebSQL databases is empty after trying to delete
3160         all of its files. Currently we check if the deletedDatabaseFileCount matches the number
3161         of files that were in the folder. However, when we delete the actual database file in
3162         DatabaseTracker::deleteDatabaseFileIfEmpty(), the shm and wal files get deleted along with
3163         the database file, but deletedDatabaseFileCount only gets incremented once.
3164
3165         * Storage/WebDatabaseManager.mm:
3166         (+[WebDatabaseManager removeEmptyDatabaseFiles]):
3167         Delete the folder if it is empty.
3168
3169 2017-03-06  Michael Saboff  <msaboff@apple.com>
3170
3171         Unreviewed build fix to add
3172         -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
3173         for objective C++ files.
3174
3175         * Configurations/WebKitLegacy.xcconfig:
3176
3177 2017-03-06  Michael Saboff  <msaboff@apple.com>
3178
3179         Take advantage of fast permissions switching of JIT memory for devices that support it
3180         https://bugs.webkit.org/show_bug.cgi?id=169155
3181
3182         Reviewed by Saam Barati.
3183
3184         Updated the Xcode config files to match what is in the JavaScriptCore ones.
3185
3186         * Configurations/FeatureDefines.xcconfig:
3187
3188 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
3189
3190         Expand font-weight and font-stretch to take any number
3191         https://bugs.webkit.org/show_bug.cgi?id=168889
3192
3193         Reviewed by Simon Fraser.
3194
3195         Migrate off old enum types.
3196
3197         * WebCoreSupport/PopupMenuMac.mm:
3198         (PopupMenuMac::populate):
3199         * WebView/WebHTMLView.mm:
3200         (fontNameForDescription):
3201         * WebView/WebView.mm:
3202         (-[WebView updateTextTouchBar]):
3203
3204 2017-03-03  Dean Jackson  <dino@apple.com>
3205
3206         Add WebGPU compile flag and experimental feature flag
3207         https://bugs.webkit.org/show_bug.cgi?id=169161
3208         <rdar://problem/30846689>
3209
3210         Reviewed by Tim Horton.
3211
3212         Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
3213         and an InternalSetting.
3214
3215         * Configurations/FeatureDefines.xcconfig:
3216         * WebView/WebPreferenceKeysPrivate.h:
3217         * WebView/WebPreferences.mm:
3218         (+[WebPreferences initialize]):
3219         (-[WebPreferences webGPUEnabled]):
3220         (-[WebPreferences setWebGPUEnabled:]):
3221         * WebView/WebPreferencesPrivate.h:
3222         * WebView/WebView.mm:
3223         (-[WebView _preferencesChanged:]):
3224
3225 2017-03-03  Alexey Proskuryakov  <ap@apple.com>
3226
3227         Build fix
3228         rdar://problem/30825660
3229
3230         Suggested by Dan Bernstein.
3231
3232         * Configurations/WebKitLegacy.xcconfig:
3233
3234 2017-03-02  Sam Weinig  <sam@webkit.org>
3235
3236         Rename htmlediting.h/cpp to Editing.h/cpp
3237         https://bugs.webkit.org/show_bug.cgi?id=169103
3238
3239         Reviewed by Alex Christensen.
3240
3241         * DOM/DOMUIKitExtensions.mm:
3242         * WebView/WebFrame.mm:
3243         * WebView/WebView.mm:
3244
3245 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
3246
3247         Fix 32-bit
3248         https://bugs.webkit.org/show_bug.cgi?id=169114
3249
3250         Reviewed by Alex Christensen.
3251
3252         * WebView/WebView.mm:
3253
3254 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
3255
3256         More guard fixing
3257         https://bugs.webkit.org/show_bug.cgi?id=169112
3258
3259         Reviewed by Alex Christensen.
3260
3261         Fixed an internal build.
3262
3263         * WebView/WebView.mm:
3264         * WebView/WebViewPrivate.h:
3265
3266 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
3267
3268         Data Interaction build fixes
3269         https://bugs.webkit.org/show_bug.cgi?id=169096
3270
3271         Reviewed by Tim Horton.
3272
3273         Guards weren't all correct, also missed a selector name change.
3274
3275         * WebView/WebView.mm:
3276         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
3277         * WebView/WebViewData.h:
3278         * WebView/WebViewData.mm:
3279         (-[WebViewPrivate dealloc]):
3280
3281 2017-03-02  Alex Christensen  <achristensen@webkit.org>
3282
3283         Continue enabling WebRTC
3284         https://bugs.webkit.org/show_bug.cgi?id=169056
3285
3286         Reviewed by Jon Lee.
3287
3288         * Configurations/FeatureDefines.xcconfig:
3289
3290 2017-03-01  Megan Gardner  <megan_gardner@apple.com>
3291
3292         Data interaction support for WK1
3293         https://bugs.webkit.org/show_bug.cgi?id=169062
3294
3295         Reviewed by Wenson Hsieh.
3296
3297         Support for data interaction in WebKit1
3298
3299         * WebCoreSupport/WebDragClient.mm:
3300         * WebView/WebView.mm:
3301         (-[WebUITextIndicatorData initWithImage:TextIndicatorData:scale:]):
3302         (-[WebUITextIndicatorData initWithImage:scale:]):
3303         (-[WebUITextIndicatorData dealloc]):
3304         (-[WebView _requestStartDataInteraction:globalPosition:]):
3305         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
3306         (-[WebView _getDataInteractionData]):
3307         * WebView/WebViewData.h:
3308         * WebView/WebViewData.mm:
3309         (-[WebViewPrivate dealloc]):
3310         * WebView/WebViewInternal.h:
3311         * WebView/WebViewPrivate.h:
3312
3313 2017-03-02  Youenn Fablet  <youenn@apple.com>
3314
3315         [WebRTC] Activate ICE candidate privacy policy
3316         https://bugs.webkit.org/show_bug.cgi?id=168975
3317
3318         Reviewed by Alex Christensen.
3319
3320         * WebView/WebPreferenceKeysPrivate.h:
3321         * WebView/WebPreferences.mm:
3322         (-[WebPreferences enumeratingAllNetworkInterfacesEnabled]):
3323         (-[WebPreferences setEnumeratingAllNetworkInterfacesEnabled:]):
3324         (-[WebPreferences iceCandidateFilteringEnabled]):
3325         (-[WebPreferences setIceCandidateFilteringEnabled:]):
3326         * WebView/WebPreferencesPrivate.h:
3327
3328 2017-03-01  Alex Christensen  <achristensen@webkit.org>
3329
3330         Unreviewed, rolling out r213259.
3331
3332         Broke an internal build
3333
3334         Reverted changeset:
3335
3336         "Continue enabling WebRTC"
3337         https://bugs.webkit.org/show_bug.cgi?id=169056
3338         http://trac.webkit.org/changeset/213259
3339
3340 2017-03-01  Alex Christensen  <achristensen@webkit.org>
3341
3342         Continue enabling WebRTC
3343         https://bugs.webkit.org/show_bug.cgi?id=169056
3344
3345         Reviewed by Jon Lee.
3346
3347         * Configurations/FeatureDefines.xcconfig:
3348
3349 2017-02-27  Alex Christensen  <achristensen@webkit.org>
3350
3351         Begin enabling WebRTC on 64-bit
3352         https://bugs.webkit.org/show_bug.cgi?id=168915
3353
3354         Reviewed by Eric Carlson.
3355
3356         * Configurations/FeatureDefines.xcconfig:
3357
3358 2017-02-27  Aakash Jain  <aakash_jain@apple.com>
3359
3360         Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
3361         https://bugs.webkit.org/show_bug.cgi?id=168919
3362
3363         Reviewed by Tim Horton.
3364
3365         * Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
3366         * migrate-headers.sh: Run the migrate-headers script for installapi phase.
3367
3368 2017-02-27  Alex Christensen  <achristensen@webkit.org>
3369
3370         [libwebrtc] Enable WebRTC in some Production Builds
3371         https://bugs.webkit.org/show_bug.cgi?id=168858
3372
3373         * Configurations/FeatureDefines.xcconfig:
3374
3375 2017-02-26  Alexey Proskuryakov  <ap@apple.com>
3376
3377         Don't import RetainPtr in WebNotification.h
3378         https://bugs.webkit.org/show_bug.cgi?id=168876
3379
3380         Reviewed by Dan Bernstein.
3381
3382         This is an Objective-C SPI header.
3383
3384         * WebView/WebNotification.h:
3385         * WebView/WebNotification.mm:
3386         (-[WebNotification initWithCoreNotification:notificationID:]):
3387         (-[WebNotification dealloc]):
3388
3389 2017-02-26  Aakash Jain  <aakash_jain@apple.com>
3390
3391         Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
3392         https://bugs.webkit.org/show_bug.cgi?id=168819
3393
3394         Reviewed by Dan Bernstein.
3395
3396         * Configurations/WebKitLegacy.xcconfig:
3397
3398 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
3399
3400         Export Objective-C symbols for variables in Webkit SPI
3401         https://bugs.webkit.org/show_bug.cgi?id=168758
3402
3403         Reviewed by Alexey Proskuryakov.
3404
3405         * Configurations/WebKitLegacy.xcconfig: using separate .exp file for i386.
3406         * WebKit.exp: Added various Objective-C symbols.
3407
3408 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
3409
3410         Move instance members from WKQuadObject to implementation file
3411         https://bugs.webkit.org/show_bug.cgi?id=168740
3412
3413         Reviewed by Tim Horton.
3414
3415         * DOM/DOM.mm: Moving instance member to implementation file.
3416         * DOM/DOMExtensions.h: Ditto.
3417
3418 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
3419
3420         Move iOS specific symbols to WebKit.ios.exp
3421         https://bugs.webkit.org/show_bug.cgi?id=168726
3422
3423         Reviewed by Alexey Proskuryakov.
3424
3425         * WebKit.exp:
3426
3427 2017-02-21  Youenn Fablet  <youenn@apple.com>
3428
3429         [WebRTC][Mac] Activate libwebrtc
3430         https://bugs.webkit.org/show_bug.cgi?id=167293
3431         <rdar://problem/30401864>
3432
3433         Reviewed by Alex Christensen.
3434
3435         * Configurations/FeatureDefines.xcconfig:
3436
3437 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3438
3439         Export various NSString symbols from WebFramePrivate.h
3440         https://bugs.webkit.org/show_bug.cgi?id=168702
3441
3442         Reviewed by Alexey Proskuryakov.
3443
3444         * WebKit.exp:
3445
3446 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3447
3448         Export various NSString symbols from WebPreferencesPrivate.h
3449         https://bugs.webkit.org/show_bug.cgi?id=168701
3450
3451         Reviewed by Alexey Proskuryakov.
3452
3453         * WebKit.exp:
3454
3455 2017-02-21  Joseph Pecoraro  <pecoraro@apple.com>
3456
3457         Add missing WebConsoleMessage string key
3458         https://bugs.webkit.org/show_bug.cgi?id=168690
3459
3460         Reviewed by Alexey Proskuryakov.
3461
3462         * WebKit.exp:
3463         * WebView/WebUIDelegatePrivate.h:
3464         This key has an implementation but was not extern / exported like the others.
3465
3466 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3467
3468         Export various NSString symbols from WebViewPrivate.h
3469         https://bugs.webkit.org/show_bug.cgi?id=168689
3470
3471         Reviewed by Alexey Proskuryakov.
3472
3473         * WebKit.exp:
3474
3475 2017-02-21  Commit Queue  <commit-queue@webkit.org>
3476
3477         Unreviewed, rolling out r212768.
3478         https://bugs.webkit.org/show_bug.cgi?id=168698
3479
3480         Rolling out since this would break other projects. (Requested
3481         by aakashjain on #webkit).
3482
3483         Reverted changeset:
3484
3485         "[iOS] Remove old WebKit1 MemoryMeasure helper."
3486         https://bugs.webkit.org/show_bug.cgi?id=168675
3487         http://trac.webkit.org/changeset/212768
3488
3489 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
3490
3491         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
3492         https://bugs.webkit.org/show_bug.cgi?id=168620
3493         <rdar://problem/30617772>
3494
3495         Reviewed by Tim Horton.
3496
3497         * WebView/WebPreferenceKeysPrivate.h:
3498         * WebView/WebPreferences.mm:
3499         (+[WebPreferences initialize]):
3500         (-[WebPreferences subpixelAntialiasedLayerTextEnabled]):
3501         (-[WebPreferences setSubpixelAntialiasedLayerTextEnabled:]):
3502         * WebView/WebPreferencesPrivate.h:
3503
3504 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3505
3506         Export various NSString symbols from WebUIDelegatePrivate.h
3507         https://bugs.webkit.org/show_bug.cgi?id=168679
3508
3509         Reviewed by Joseph Pecoraro.
3510
3511         * WebKit.exp:
3512
3513 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
3514
3515         Export symbols for various classes present in webkit SPI
3516         https://bugs.webkit.org/show_bug.cgi?id=168674
3517
3518         Reviewed by Dan Bernstein.
3519
3520         * WebKit.exp:
3521
3522 2017-02-21  Andreas Kling  <akling@apple.com>
3523
3524         [iOS] Remove old WebKit1 MemoryMeasure helper.
3525         <https://webkit.org/b/168675>
3526
3527         Reviewed by Sam Weinig.
3528
3529         * Configurations/WebKitLegacy.xcconfig:
3530         * Misc/WebCache.mm:
3531         (+[WebCache emptyInMemoryResources]):
3532         * WebView/WebView.mm:
3533
3534 2017-02-21  Andreas Kling  <akling@apple.com>
3535
3536         [iOS] WebKit1 should use shared memory pressure handler code.
3537         <https://webkit.org/b/168653>
3538
3539         Reviewed by Antti Koivisto.
3540
3541         Register a WebThread-aware memory callback with the shared MemoryPressureHandler
3542         and get rid of the old iOS WebKit1 specific implementation. Some of it was even
3543         dead code since MobileSafari has been using WebKit2 for quite a while.
3544
3545         * WebView/WebView.h:
3546         * WebView/WebView.mm:
3547         (WebInstallMemoryPressureHandler):
3548         (+[WebView _handleMemoryWarning]): Deleted.
3549         (+[WebView registerForMemoryNotifications]): Deleted.
3550         (+[WebView releaseFastMallocMemoryOnCurrentThread]): Deleted.
3551         (+[WebView garbageCollectNow]): Deleted.
3552         (+[WebView purgeInactiveFontData]): Deleted.
3553         (+[WebView drainLayerPool]): Deleted.
3554         (+[WebView discardAllCompiledCode]): Deleted.
3555         (+[WebView _clearMemoryPressure]): Deleted.
3556         (+[WebView _shouldWaitForMemoryClearMessage]): Deleted.
3557         * WebView/WebViewPrivate.h:
3558
3559 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3560
3561         Stop exporting interface WebCoreScrollView on iOS
3562         https://bugs.webkit.org/show_bug.cgi?id=168536
3563
3564         Reviewed by Dan Bernstein.
3565
3566         * WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
3567         * WebKit.mac.exp: Ditto.
3568         * WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.
3569
3570 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3571
3572         Exclude various mac-specific header files from iOS build
3573         https://bugs.webkit.org/show_bug.cgi?id=168621
3574
3575         Reviewed by Dan Bernstein.
3576
3577         * Configurations/WebKitLegacy.xcconfig:
3578
3579 2017-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3580
3581         Add plumbing to the UI process for TextIndicatorData when computing the drag image
3582         https://bugs.webkit.org/show_bug.cgi?id=168583
3583         Work towards <rdar://problem/30313681>
3584
3585         Accounts for changes in WebCore -- see Source/WebCore/ChangeLog for more details.
3586
3587         Reviewed by Tim Horton.
3588
3589         * WebView/WebHTMLView.mm:
3590         (-[WebHTMLView _selectionDraggingImage]):
3591         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
3592
3593 2017-02-17  Anders Carlsson  <andersca@apple.com>
3594
3595         Add a new drag code path and use it for dragging plain text
3596         https://bugs.webkit.org/show_bug.cgi?id=168534
3597
3598         Reviewed by Geoffrey Garen.
3599
3600         * WebCoreSupport/WebDragClient.h:
3601         Add new members.
3602
3603         * WebCoreSupport/WebDragClient.mm:
3604         (WebDragClient::useLegacyDragClient):
3605         Return false here.
3606
3607         (WebDragClient::beginDrag):
3608         New client member function. Create an NSDraggingItem and use it to begin a dragging session.
3609
3610         * WebView/WebHTMLView.mm:
3611         (-[WebHTMLView draggingSession:sourceOperationMaskForDraggingContext:]):
3612         Get the source operation mask from WebCore.
3613
3614         (-[WebHTMLView draggingSession:endedAtPoint:operation:]):
3615         Send a fake mouse up event.
3616
3617         * WebView/WebHTMLViewInternal.h:
3618         Declare that WebHTMLView conforms to NSDraggingSource.
3619
3620 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
3621
3622         List of WebCore symbols to re-export from WebKitLegacy should be built automatically
3623         https://bugs.webkit.org/show_bug.cgi?id=168342
3624         rdar://problem/26182266
3625
3626         Reviewed by Tim Horton.
3627
3628         * MigrateHeaders.make: On iOS only, process re-exported headers to build a list of
3629         symbols to re-export.
3630
3631 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3632
3633         Stop exporting DOMTokenList from WebKit
3634         https://bugs.webkit.org/show_bug.cgi?id=168544
3635
3636         Reviewed by Alexey Proskuryakov.
3637
3638         * WebKit.exp:
3639
3640 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
3641
3642         Clean up how WebKit exports _WebCreateFragment
3643         https://bugs.webkit.org/show_bug.cgi?id=168579
3644
3645         Reviewed by Dan Bernstein.
3646
3647         * WebCoreSupport/WebCreateFragmentInternal.h: Added a private header.
3648         * WebCoreSupport/WebEditorClient.mm: Include the new header that declares _WebCreateFragment.
3649
3650 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
3651
3652         Stop exporting DOMNodeFilter
3653         https://bugs.webkit.org/show_bug.cgi?id=168542
3654
3655         Reviewed by Alexey Proskuryakov.
3656
3657         * WebKit.exp:
3658
3659 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
3660
3661         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
3662         https://bugs.webkit.org/show_bug.cgi?id=167693
3663
3664         Reviewed by Sergio Villar Senin.
3665
3666         * Configurations/FeatureDefines.xcconfig:
3667         * WebView/WebPreferences.mm:
3668         (+[WebPreferences initialize]):
3669         * WebView/WebView.mm:
3670         (-[WebView _preferencesChanged:]):
3671
3672 2017-02-15  Brady Eidson  <beidson@apple.com>
3673
3674         Stop backing up localStorage databases to iCloud by default.
3675         <rdar://problem/29045531> and https://bugs.webkit.org/show_bug.cgi?id=168388
3676
3677         Reviewed by Geoffrey Garen.
3678
3679         * Misc/WebKitVersionChecks.h:
3680         * Misc/WebKitVersionChecks.mm: Renamed from Source/WebKit/mac/Misc/WebKitVersionChecks.m.
3681         (WebKitLinkedOnOrAfter):
3682         (setWebKitLinkTimeVersion):
3683         (WebKitLinkTimeVersion):
3684         (linkedOnOrAfter):
3685
3686         * Storage/WebStorageManager.mm:
3687         (WebKitInitializeStorageIfNecessary):
3688
3689 2017-02-16  Daniel Bates  <dabates@apple.com>
3690
3691         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
3692         https://bugs.webkit.org/show_bug.cgi?id=168417
3693         <rdar://problem/30541748>
3694
3695         Reviewed by Brent Fulgham.
3696
3697         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
3698         Widget* as it is always called with a valid Widget.
3699
3700         * WebCoreSupport/WebFrameLoaderClient.h:
3701         * WebCoreSupport/WebFrameLoaderClient.mm:
3702         (WebFrameLoaderClient::redirectDataToPlugin):
3703         * WebKit.order: Remove symbol for WebFrameLoaderClient::redirectDataToPlugin() that took a Widget*
3704         as it no longer exists. I am unclear if this file is still meaningful as it was last modified in
3705         r180570 (2 years ago) though Xcode still references this ordering file (why?).
3706
3707 2017-02-16  Yusuke Suzuki  <utatane.tea@gmail.com>
3708
3709         [JSC] Drop PassRefPtr in inspector/
3710         https://bugs.webkit.org/show_bug.cgi?id=168420
3711
3712         Reviewed by Alex Christensen.
3713
3714         * WebView/WebScriptDebugger.mm:
3715         (WebScriptDebugger::handlePause):
3716
3717 2017-02-16  Simon Fraser  <simon.fraser@apple.com>
3718
3719         Clean up use of some CALayer-related SPI
3720         https://bugs.webkit.org/show_bug.cgi?id=168401
3721
3722         Reviewed by Tim Horton.
3723
3724         Include CALayer.h not CATiledLayer.h.
3725
3726         * WebInspector/WebNodeHighlight.h:
3727
3728 2017-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3729
3730         Fix the build after r212379
3731
3732         Rubber-stamped by Anders Carlsson.
3733
3734         * WebCoreSupport/WebDragClient.mm:
3735         (WebDragClient::startDrag):
3736
3737 2017-02-15  Anders Carlsson  <andersca@apple.com>
3738
3739         Modernize DragClient::startDrag somewhat
3740         https://bugs.webkit.org/show_bug.cgi?id=168379
3741
3742         Reviewed by Tim Horton.
3743
3744         Update for WebCore changes.
3745
3746         * WebCoreSupport/WebDragClient.h:
3747         * WebCoreSupport/WebDragClient.mm:
3748         (WebDragClient::startDrag):
3749
3750 2017-02-14  Dean Jackson  <dino@apple.com>
3751
3752         Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
3753         https://bugs.webkit.org/show_bug.cgi?id=168339
3754
3755         Reviewed by Simon Fraser.
3756
3757         Use a better name.
3758
3759         * WebView/WebPreferenceKeysPrivate.h:
3760         * WebView/WebPreferences.mm:
3761         (+[WebPreferences initialize]):
3762         (-[WebPreferences forceLowPowerGPUForWebGL]):
3763         (-[WebPreferences setForceLowPowerGPUForWebGL:]):
3764         (-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
3765         (-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.
3766         * WebView/WebPreferencesPrivate.h:
3767         * WebView/WebView.mm:
3768         (-[WebView _preferencesChanged:]):
3769
3770 2017-02-14  Chris Dumez  <cdumez@apple.com>
3771
3772         HTML Form Validation bubble should take minimum font size setting into consideration
3773         https://bugs.webkit.org/show_bug.cgi?id=168271
3774         <rdar://problem/29869869>
3775
3776         Reviewed by Simon Fraser.
3777
3778         * WebView/WebView.mm:
3779         (-[WebView _contentsOfUserInterfaceItem:]):
3780         Return font size used in the validation bubble.
3781
3782         (-[WebView showFormValidationMessage:withAnchorRect:]):
3783         Pass minimum font size setting when constructing the validation bubble.
3784
3785 2017-02-14  Anders Carlsson  <andersca@apple.com>
3786
3787         Remove an unused delegate method
3788         https://bugs.webkit.org/show_bug.cgi?id=168328
3789
3790         Reviewed by Wenson Hsieh.
3791
3792         * DefaultDelegates/WebDefaultUIDelegate.m:
3793         (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.
3794
3795 2017-02-14  Alexey Proskuryakov  <ap@apple.com>
3796
3797         WebCore shouldn't export SystemMemory.h
3798         https://bugs.webkit.org/show_bug.cgi?id=168285
3799
3800         Reviewed by Alex Christensen.
3801
3802         * MigrateHeaders.make: And WebKit shouldn't re-export it.
3803
3804 2017-02-13  Alexey Proskuryakov  <ap@apple.com>
3805
3806         WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
3807         https://bugs.webkit.org/show_bug.cgi?id=168282
3808
3809         Reviewed by Dan Bernstein.
3810
3811         * MigrateHeaders.make:
3812
3813 2017-02-12  Dan Bernstein  <mitz@apple.com>
3814
3815         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
3816
3817         * WebView/WebHTMLView.mm:
3818         (createShareMenuItem): Use non-deprecated method.
3819
3820 2017-02-12  Dan Bernstein  <mitz@apple.com>
3821
3822         [Cocoa] Some -respondsToSelector: checks are unnecessary
3823         https://bugs.webkit.org/show_bug.cgi?id=168183
3824
3825         Reviewed by Tim Horton.
3826
3827         * WebView/WebFullScreenController.mm:
3828         (-[WebFullScreenController applicationDidResignActive:]): Removed check whether NSWindow
3829           responds to -isOnActiveSpace.
3830         (-[WebFullScreenController exitFullScreen]): Ditto.
3831         (-[WebFullScreenController _updateMenuAndDockForFullScreen]): Removed check whether
3832           NSApplication responds to -setPresentationOptions.
3833
3834         * WebView/WebHTMLView.mm:
3835         (createShareMenuItem): Removed unnecessary -respondsToSelector: check.
3836         (-[WebHTMLView otherMouseDown:]): Ditto.
3837
3838         * WebView/WebImmediateActionController.mm:
3839         (-[WebImmediateActionController _clearImmediateActionState]): Ditto.
3840         (-[WebImmediateActionController _animationControllerForDataDetectedText]): Ditto.
3841
3842         * WebView/WebView.mm:
3843         (-[WebView _didStartProvisionalLoadForFrame:]): Removed redundant nil check.
3844         (+[WebView _setCacheModel:]): Removed unnecessary -respondsToSelector: check.
3845
3846 2017-02-10  Daniel Bates  <dabates@apple.com>
3847
3848         Detach frame from document when entering page cache
3849         https://bugs.webkit.org/show_bug.cgi?id=166774
3850         <rdar://problem/29904368>
3851
3852         Reviewed by Chris Dumez.
3853
3854         * WebView/WebPreferenceKeysPrivate.h:
3855         * WebView/WebPreferences.mm:
3856         (+[WebPreferences initialize]):
3857         (-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
3858         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
3859         * WebView/WebPreferencesPrivate.h:
3860         * WebView/WebView.mm:
3861         (-[WebView _preferencesChanged:]):
3862
3863 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
3864
3865         [Resource Timing] Enable Resource Timing by default in Tests
3866         https://bugs.webkit.org/show_bug.cgi?id=168145
3867
3868         Reviewed by Ryosuke Niwa.
3869
3870         * WebView/WebPreferenceKeysPrivate.h:
3871         * WebView/WebPreferences.mm:
3872         (+[WebPreferences initialize]):
3873         (-[WebPreferences resourceTimingEnabled]):
3874         (-[WebPreferences setResourceTimingEnabled:]):
3875         * WebView/WebPreferencesPrivate.h:
3876         * WebView/WebView.mm:
3877         (-[WebView _preferencesChanged:]):
3878
3879 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
3880
3881         cleanup WebLocalizableStrings.
3882         https://bugs.webkit.org/show_bug.cgi?id=168078
3883
3884         Reviewed by Alexey Proskuryakov.
3885
3886         * Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle 
3887         as it's for each framework's own consumption, and never needs to be exported.
3888
3889 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
3890
3891         WebResourceLoadDelegatePrivate.h cannot be imported standalone
3892         https://bugs.webkit.org/show_bug.cgi?id=168096
3893
3894         Reviewed by Alexey Proskuryakov.
3895
3896         * WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger. 
3897
3898 2017-02-09  Antti Koivisto  <antti@apple.com>
3899
3900         Remove most cases of #if ENABLE(CACHE_PARTITIONING)
3901         https://bugs.webkit.org/show_bug.cgi?id=167990
3902
3903         Reviewed by Sam Weinig.
3904
3905         * Misc/WebCache.mm:
3906         (+[WebCache addImageToCache:forURL:forFrame:]):
3907         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3908         * WebCoreSupport/WebSystemInterface.mm:
3909         (InitWebCoreSystemInterface):
3910
3911 2017-02-07  Alexey Proskuryakov  <ap@apple.com>
3912
3913         Don't migrate WebKit DOM headers in MigrateHeaders.make
3914         https://bugs.webkit.org/show_bug.cgi?id=167608
3915
3916         Reviewed by Darin Adler.
3917
3918         Stop migrating DOM headers that are now in WebKit.
3919
3920         * DOM/DOMDOMImplementation.h: Removed.
3921         * DOM/DOMDOMImplementation.mm: Removed.
3922         * DOM/DOMDOMImplementationInternal.h: Removed.
3923         * DOM/DOMDOMTokenList.h: Removed.
3924         * DOM/DOMDOMTokenList.mm: Removed.
3925         * DOM/DOMDOMTokenListInternal.h: Removed.
3926         * DOM/DOMImplementation.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.h.
3927         * DOM/DOMImplementation.mm: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.mm.
3928         * DOM/DOMImplementationInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementationInternal.h.
3929         * DOM/DOMTokenList.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.h.
3930         * DOM/DOMTokenList.mm: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.mm.
3931         * DOM/DOMTokenListInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenListInternal.h.
3932         As the files are not in WebCore any more, there is no need to differentiate from
3933         WebCore internal headers with the same name. This makes it possible to make these
3934         headers private using Xcode mechanisms, as opposed to copying with a shell script.
3935
3936         * DOM/DOMElement.mm: Removed "using namespace WebCore". Other DOM implementation
3937         files don't have it.
3938
3939         * DOM/DOMCore.h:
3940         * DOM/DOMDocument.mm:
3941         * DOM/DOMHTMLAnchorElement.mm:
3942         * DOM/DOMHTMLAreaElement.mm:
3943         * DOM/DOMHTMLLinkElement.mm:
3944         * DOM/DOMUtility.mm:
3945         No more "DOMDOM".
3946
3947         * WebKit.exp:
3948         No more "DOMDOM". DOMDOMTokenList was not directly exposed via an SPI header, so
3949         renaming it is likely to be safe.
3950
3951         * MigrateHeaders.make: Don't migrate WebKit headers.
3952
3953         * Configurations/WebKitLegacy.xcconfig: Don't include two iOS specific SPI headers
3954         on macOS.
3955
3956 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
3957
3958         Don't re-export PluginData.h from WebKit
3959         https://bugs.webkit.org/show_bug.cgi?id=168020
3960
3961         Reviewed by Alexey Proskuryakov.
3962
3963         * MigrateHeaders.make: Removed PluginData.h
3964
3965 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
3966
3967         Don't re-export WKUtilities.h from WebKit
3968         https://bugs.webkit.org/show_bug.cgi?id=167977
3969
3970         Reviewed by Alexey Proskuryakov.
3971
3972         * MigrateHeaders.make: Removed WKUtilities.h
3973
3974 2017-02-06  Alex Christensen  <achristensen@webkit.org>
3975
3976         credentials should be partitioned by main document domain
3977         https://bugs.webkit.org/show_bug.cgi?id=166998
3978         rdar://problem/22901123
3979
3980         Reviewed by Brady Eidson.
3981
3982         * Misc/WebDownload.mm:
3983         * Plugins/WebBaseNetscapePluginView.mm:
3984         (WebKit::getAuthenticationInfo):
3985         Don't use partitioned credentials for WebKit1 plugins or downloads.
3986         Downloads should be authenticated before becoming a download anyways.
3987
3988 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3989
3990         Rename AnimationController to CSSAnimationController
3991         https://bugs.webkit.org/show_bug.cgi?id=167829
3992
3993         Reviewed by Simon Fraser.
3994
3995         * WebView/WebFrame.mm:
3996         * WebView/WebView.mm:
3997
3998 2017-02-03  Chris Dumez  <cdumez@apple.com>
3999
4000         Dismiss HTML form validation popover when pressing Escape key
4001         https://bugs.webkit.org/show_bug.cgi?id=167716
4002         <rdar://problem/29872943>
4003
4004         Reviewed by Simon Fraser.
4005
4006         Override ValidationMessageClient::hideAnyValidationMessage().
4007
4008         * WebCoreSupport/WebValidationMessageClient.h:
4009         * WebCoreSupport/WebValidationMessageClient.mm:
4010         (WebValidationMessageClient::hideAnyValidationMessage):
4011
4012 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
4013
4014         Drag images should be anchored to the mouse location
4015         https://bugs.webkit.org/show_bug.cgi?id=167690
4016         <rdar://problem/30295261>
4017
4018         Reviewed by Enrica Casucci.
4019
4020         Adds some plumbing for the anchor point in the WK1 client layer.
4021
4022         * WebCoreSupport/WebDragClient.h:
4023         * WebCoreSupport/WebDragClient.mm:
4024         (WebDragClient::startDrag):
4025
4026 2017-02-02  Chris Dumez  <cdumez@apple.com>
4027
4028         Rename Node::inDocument() to isConnected()
4029         https://bugs.webkit.org/show_bug.cgi?id=167743
4030
4031         Reviewed by Sam Weinig.
4032
4033         Rename Node::inDocument() to isConnected() to match the DOM specification more closely:
4034         - https://dom.spec.whatwg.org/#connected
4035
4036         * DOM/DOMNode.mm:
4037         (-[DOMNode isConnected]):
4038         * WebView/WebFrame.mm:
4039         (-[WebFrame selectNSRange:onElement:]):
4040
4041 2017-02-02  Chris Dumez  <cdumez@apple.com>
4042
4043         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
4044         https://bugs.webkit.org/show_bug.cgi?id=167738
4045         <rdar://problem/30229990>
4046
4047         Reviewed by Andreas Kling.
4048
4049         The BackForwardClient no longer needs to worry about removing HistoryItems
4050         from the PageCache now that WebCore takes care of it.
4051
4052         * History/BackForwardList.mm:
4053         (BackForwardList::close):
4054
4055 2017-02-02  Yongjun Zhang  <yongjun_zhang@apple.com>
4056
4057         In iOS, we should take background assertion when accessing localstorage databases.
4058         https://bugs.webkit.org/show_bug.cgi?id=165478
4059
4060         Move database transaction background task handling code from WebDatabaseManager to
4061         WebCore's WebSQLiteDatabaseTrackerClient.
4062
4063         Reviewed by Brady Eidson.
4064
4065         * Storage/WebDatabaseManager.mm:
4066         * Storage/WebDatabaseManagerInternal.h: Remove a category for background task handling.
4067         * WebCoreSupport/WebApplicationCache.mm:
4068         (+[WebApplicationCache initializeWithBundleIdentifier:]): Use WebCore::WebSQLiteDatabaseTrackerClient.
4069         * WebView/WebView.mm:
4070         (-[WebView _commonInitializationWithFrameName:groupName:]): Ditto.
4071
4072 2017-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
4073
4074         [WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
4075         https://bugs.webkit.org/show_bug.cgi?id=167695
4076         <rdar://problem/30305390>
4077
4078         Reviewed by Sam Weinig.
4079
4080         Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
4081         exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
4082         is destroyed.
4083
4084         * WebView/WebView.mm:
4085         (-[WebView _commonInitializationWithFrameName:groupName:]):
4086
4087 2017-01-31  Joseph Pecoraro  <pecoraro@apple.com>
4088
4089         ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category
4090         https://bugs.webkit.org/show_bug.cgi?id=167684
4091
4092         Reviewed by Dan Bernstein.
4093
4094         * DOM/DOMHTML.mm:
4095         (-[DOMHTMLInputElement _isAutofilled]): Deleted.
4096         (-[DOMHTMLInputElement _setAutofilled:]): Deleted.
4097         Consolidate in the WebDOMOperationsPrivate category.
4098
4099         * DOM/DOMPrivate.h:
4100         Include WebDOMOperationsPrivate header to get other DOM Private categories.
4101
4102         * DOM/WebDOMOperations.mm:
4103         (-[DOMHTMLInputElement _isAutofilled]):
4104         * DOM/WebDOMOperationsPrivate.h:
4105         Include getter alongside the setter.
4106
4107 2017-01-31  Jessie Berlin  <jberlin@webkit.org>
4108
4109         Build fix.
4110
4111         * Misc/WebNSPasteboardExtras.mm:
4112         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
4113         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
4114         * WebView/WebHTMLView.mm:
4115         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
4116         (-[WebHTMLView copyFont:]):
4117
4118 2017-01-30  Andy Estes  <aestes@apple.com>
4119
4120         [QuickLook] FrameLoaderClient should return the new QuickLookHandleClient it creates
4121         https://bugs.webkit.org/show_bug.cgi?id=167625
4122
4123         Reviewed by Andreas Kling.
4124
4125         * WebCoreSupport/WebFrameLoaderClient.h: Declared createQuickLookHandleClient().
4126         * WebCoreSupport/WebFrameLoaderClient.mm:
4127         (WebFrameLoaderClient::createQuickLookHandleClient): Renamed from didCreateQuickLookHandle().
4128         (WebFrameLoaderClient::didCreateQuickLookHandle): Renamed to createQuickLookHandleClient().
4129
4130 2017-01-30  Chris Dumez  <cdumez@apple.com>
4131
4132         Drop legacy Attributes.isId attribute
4133         https://bugs.webkit.org/show_bug.cgi?id=167603
4134
4135         Reviewed by Ryosuke Niwa.
4136
4137         Keep Attr.isId in ObjC bindings.
4138
4139         * DOM/DOMAttr.mm:
4140         (-[DOMAttr isId]):
4141
4142 2017-01-30  Andreas Kling  <akling@apple.com>
4143
4144         [macOS] WebHTMLView has an internal retain cycle with its flagsChangedEventMonitor.
4145         <https://webkit.org/b/167580>
4146
4147         Reviewed by Antti Koivisto.
4148
4149         Avoid the implicit strong capture of self by keeping it in a __block variable.
4150         Also add code to dealloc to unregister the event monitor, since it will otherwise leak.
4151         This fixes huge WebHTMLView leaks seen on the leaks bot.
4152
4153         * WebView/WebHTMLView.mm:
4154         (-[WebHTMLViewPrivate dealloc]):
4155         (-[WebHTMLView viewDidMoveToWindow]):
4156
4157 2017-01-29  Andy Estes  <aestes@apple.com>
4158
4159         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
4160         https://bugs.webkit.org/show_bug.cgi?id=167563
4161         <rdar://problem/30253207>
4162
4163         Reviewed by Andreas Kling.
4164
4165         Instead of only saving QuickLook documents to a temporary file when the client is
4166         MobileSafari, base this decision on a WebPreference that clients can choose to enable.
4167
4168         This also changes the SPI for accessing the temporary file path and UTI. Instead of
4169         -[WebView quickLookContentForURL:], which requires the client to pass the response URL of
4170         the frame that saved the QuickLook document, the content dictionary is now stored as a
4171         property of WebDataSource.
4172
4173         This also removes the manual lifetime management of the QLPreviewConverter from
4174         QuickLookDocumentWriter. The QLPreviewConverter is kept alive by DocumentLoader these days,
4175         which ensures it lives long enough to respond to subresource requests.
4176
4177         New API test: QuickLook.LegacyQuickLookContent
4178
4179         * WebCoreSupport/WebFrameLoaderClient.mm:
4180         (WebFrameLoaderClient::didCreateQuickLookHandle): Moved the logic of deciding whether to
4181         write a temporary file to here from the QuickLookDocumentWriter constructor.
4182         * WebView/WebDataSource.mm: Declared _quickLookContent.
4183         (-[WebDataSource _quickLookContent]):
4184         (-[WebDataSource _setQuickLookContent:]):
4185         * WebView/WebDataSourceInternal.h: Overrode _quickLookContent as a read/write property.
4186         * WebView/WebDataSourcePrivate.h: Declared _quickLookContent as a readonly property.
4187         * WebView/WebPreferenceKeysPrivate.h: Defined WebKitQuickLookDocumentSavingPreferenceKey.
4188         * WebView/WebPreferences.mm:
4189         (-[WebPreferences quickLookDocumentSavingEnabled]):
4190         (-[WebPreferences setQuickLookDocumentSavingEnabled:]):
4191         * WebView/WebPreferencesPrivate.h: Declared property quickLookDocumentSavingEnabled.
4192         * WebView/WebView.mm:
4193         (-[WebView quickLookContentForURL:]): Changed to always return nil.
4194         * WebView/WebViewPrivate.h: Added a comment stating that clients should use
4195         -[WebDataSource _quickLookContent] instead.
4196
4197 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
4198
4199         Add Link Preload as an off-by-default experimental feature menu item.
4200         https://bugs.webkit.org/show_bug.cgi?id=167201
4201
4202         Reviewed by Ryosuke Niwa.
4203
4204         * WebView/WebPreferenceKeysPrivate.h:
4205         * WebView/WebPreferences.mm:
4206         (-[WebPreferences linkPreloadEnabled]):
4207         (-[WebPreferences setLinkPreloadEnabled:]):
4208         * WebView/WebPreferencesPrivate.h:
4209         * WebView/WebView.mm:
4210         (-[WebView _preferencesChanged:]):
4211
4212 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
4213
4214         Add User Timing Experimental Feature
4215         https://bugs.webkit.org/show_bug.cgi?id=167542
4216         <rdar://problem/22746307>
4217
4218         Reviewed by Ryosuke Niwa.
4219
4220         * WebView/WebPreferenceKeysPrivate.h:
4221         * WebView/WebPreferences.mm:
4222         (+[WebPreferences initialize]):
4223         (-[WebPreferences userTimingEnabled]):
4224         (-[WebPreferences setUserTimingEnabled:]):
4225         * WebView/WebPreferencesPrivate.h:
4226         * WebView/WebView.mm:
4227         (-[WebView _preferencesChanged:]):
4228         Add setting for User Timing runtime enabled feature.
4229
4230 2017-01-27  Wenson Hsieh  <wenson_hsieh@apple.com>
4231
4232         [WK1] Do not prevent the drag client from initializing on Mac
4233         https://bugs.webkit.org/show_bug.cgi?id=167541
4234
4235         Reviewed by Dan Bernstein.