d962c8dc42cd44f373388d210555ebfaece3fab0
[WebKit.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
2
3         Failures from mach port reference handling should be fatal
4         https://bugs.webkit.org/show_bug.cgi?id=184202
5         <rdar://problem/37771114>
6
7         Reviewed by Anders Carlsson.
8
9         * Plugins/Hosted/NetscapePluginHostManager.mm:
10         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
11
12 2018-04-03  Andy Estes  <aestes@apple.com>
13
14         [Mac] Prioritize file promises over filenames during drag and drop
15         https://bugs.webkit.org/show_bug.cgi?id=184237
16         <rdar://problem/38278076>
17
18         Reviewed by Wenson Hsieh.
19
20         * WebView/WebView.mm:
21         (-[WebView performDragOperation:]):
22
23 2018-04-03  Chris Dumez  <cdumez@apple.com>
24
25         Drop MainFrame class
26         https://bugs.webkit.org/show_bug.cgi?id=184191
27
28         Reviewed by Darin Adler.
29
30         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
31         relationship between the Page and the MainFrame.
32
33         This is ground work for introducing LocalFrame / RemoteFrame concepts.
34
35         * WebCoreSupport/WebDragClient.mm:
36         * WebCoreSupport/WebFrameLoaderClient.mm:
37         * WebCoreSupport/WebInspectorClient.mm:
38         * WebCoreSupport/WebPlatformStrategies.mm:
39         * WebCoreSupport/WebPluginInfoProvider.mm:
40         * WebView/WebFrame.mm:
41         * WebView/WebFrameView.mm:
42         * WebView/WebHTMLView.mm:
43         * WebView/WebView.mm:
44
45 2018-04-02  Jer Noble  <jer.noble@apple.com>
46
47         Enable Legacy EME for all WebKit & WebKitLegacy clients
48         https://bugs.webkit.org/show_bug.cgi?id=184018
49         <rdar://problem/34887387>
50
51         Reviewed by Eric Carlson.
52
53         * WebView/WebPreferences.mm:
54         (+[WebPreferences initialize]):
55
56 2018-03-29  JF Bastien  <jfbastien@apple.com>
57
58         Use Forward.h instead of forward-declaring WTF::String
59         https://bugs.webkit.org/show_bug.cgi?id=184172
60         <rdar://problem/39026146>
61
62         Reviewed by Yusuke Suzuki.
63
64         As part of #184164 I'm changing WTF::String, and the forward
65         declarations are just wrong because I'm making it templated. We
66         should use Forward.h anyways, so do that instead.
67
68         * WebView/WebScriptDebugger.h:
69
70 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
71
72         Protect against invalid mach ports returned by mach_port_request_notification
73         https://bugs.webkit.org/show_bug.cgi?id=184106
74         <rdar://problem/37865316>
75
76         Reviewed by Chris Dumez.
77
78         * Plugins/Hosted/NetscapePluginHostProxy.mm:
79         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
80         and clean up if it experienced an error.
81         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
82
83 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
84
85         Avoid uninitialized mach ports
86         https://bugs.webkit.org/show_bug.cgi?id=184090
87         <rdar://problem/37261129>
88
89         Reviewed by Chris Dumez.
90
91         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
92         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
93         there is a potential for us to try to use invalid ports.
94
95         We should always check return values, and ensure that the mach port variables we seek to initialize are
96         kept in a valid state.
97
98         Reviewed by Chris Dumez.
99
100         * Plugins/Hosted/NetscapePluginHostManager.h:
101         * Plugins/Hosted/NetscapePluginHostManager.mm:
102         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
103         port is passed to an API function.
104         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
105         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
106         * Plugins/Hosted/NetscapePluginHostProxy.h:
107         * Plugins/Hosted/NetscapePluginHostProxy.mm:
108         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
109         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
110         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
111         (WKPCStatusText): Ditto.
112         (WKPCLoadURL): Ditto.
113         (WKPCCancelLoadURL): Ditto.
114         (WKPCInvalidateRect): Ditto.
115         (WKPCGetScriptableNPObjectReply): Ditto.
116         (WKPCBooleanReply): Ditto.
117         (WKPCBooleanAndDataReply): Ditto.
118         (WKPCInstantiatePluginReply): Ditto.
119         (WKPCGetWindowNPObject): Ditto.
120         (WKPCGetPluginElementNPObject): Ditto.
121         (WKPCForgetBrowserObject): Ditto.
122         (WKPCEvaluate): Ditto.
123         (WKPCGetStringIdentifier): Ditto.
124         (WKPCGetIntIdentifier): Ditto.
125         (WKPCInvoke): Ditto.
126         (WKPCInvokeDefault): Ditto.
127         (WKPCConstruct): Ditto.
128         (WKPCGetProperty): Ditto.
129         (WKPCSetProperty): Ditto.
130         (WKPCRemoveProperty): Ditto.
131         (WKPCHasProperty): Ditto.
132         (WKPCHasMethod): Ditto.
133         (WKPCIdentifierInfo): Ditto.
134         (WKPCEnumerate): Ditto.
135         (WKPCSetMenuBarVisible): Ditto.
136         (WKPCSetFullscreenWindowIsShowing): Ditto.
137         (WKPCSetModal): Ditto.
138         (WKPCGetCookies): Ditto.
139         (WKPCGetProxy): Ditto.
140         (WKPCSetCookies): Ditto.
141         (WKPCGetAuthenticationInfo): Ditto.
142         (WKPCConvertPoint): Ditto.
143         (WKPCLayerHostingModeChanged): Ditto.
144         (WKPCSetException): Ditto.
145
146 2018-03-26  Tim Horton  <timothy_horton@apple.com>
147
148         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
149         https://bugs.webkit.org/show_bug.cgi?id=184030
150         <rdar://problem/38895281>
151
152         Reviewed by Dan Bernstein.
153
154         * Configurations/Base.xcconfig:
155
156 2018-03-26  Chris Dumez  <cdumez@apple.com>
157
158         Use SecurityOriginData more consistently in Service Worker code
159         https://bugs.webkit.org/show_bug.cgi?id=183969
160
161         Reviewed by Darin Adler.
162
163         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
164
165         * Storage/WebDatabaseManager.mm:
166         (-[WebDatabaseManager databasesWithOrigin:]):
167         (-[WebDatabaseManager deleteOrigin:]):
168         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
169         * Storage/WebDatabaseQuotaManager.mm:
170         (-[WebDatabaseQuotaManager usage]):
171         (-[WebDatabaseQuotaManager quota]):
172         (-[WebDatabaseQuotaManager setQuota:]):
173         * Storage/WebStorageManager.mm:
174         (-[WebStorageManager deleteOrigin:]):
175         * WebCoreSupport/WebSecurityOrigin.mm:
176         (-[WebSecurityOrigin databaseIdentifier]):
177         (-[WebSecurityOrigin usage]):
178         (-[WebSecurityOrigin quota]):
179         (-[WebSecurityOrigin setQuota:]):
180
181 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
182
183         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
184         https://bugs.webkit.org/show_bug.cgi?id=183911
185         <rdar://problem/38762306>
186
187         Reviewed by Youenn Fablet.
188
189         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
190
191         * WebView/WebView.mm:
192         (+[WebView initialize]):
193
194 2018-03-26  Alex Christensen  <achristensen@webkit.org>
195
196         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
197         https://bugs.webkit.org/show_bug.cgi?id=183965
198
199         Reviewed by Chris Dumez.
200
201         * WebCoreSupport/WebFrameLoaderClient.h:
202         * WebCoreSupport/WebFrameLoaderClient.mm:
203         (WebFrameLoaderClient::willCacheResponse const):
204
205 2018-03-25  Commit Queue  <commit-queue@webkit.org>
206
207         Unreviewed, rolling out r229954.
208         https://bugs.webkit.org/show_bug.cgi?id=184000
209
210         Caused many layout tests to crash on Apple High Sierra,
211         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
212         by dydz on #webkit).
213
214         Reverted changeset:
215
216         "Use SecurityOriginData more consistently in Service Worker
217         code"
218         https://bugs.webkit.org/show_bug.cgi?id=183969
219         https://trac.webkit.org/changeset/229954
220
221 2018-03-24  Chris Dumez  <cdumez@apple.com>
222
223         Use SecurityOriginData more consistently in Service Worker code
224         https://bugs.webkit.org/show_bug.cgi?id=183969
225
226         Reviewed by Darin Adler.
227
228         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
229
230         * Storage/WebDatabaseManager.mm:
231         (-[WebDatabaseManager databasesWithOrigin:]):
232         (-[WebDatabaseManager deleteOrigin:]):
233         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
234         * Storage/WebDatabaseQuotaManager.mm:
235         (-[WebDatabaseQuotaManager usage]):
236         (-[WebDatabaseQuotaManager quota]):
237         (-[WebDatabaseQuotaManager setQuota:]):
238         * Storage/WebStorageManager.mm:
239         (-[WebStorageManager deleteOrigin:]):
240         * WebCoreSupport/WebSecurityOrigin.mm:
241         (-[WebSecurityOrigin databaseIdentifier]):
242         (-[WebSecurityOrigin usage]):
243         (-[WebSecurityOrigin quota]):
244         (-[WebSecurityOrigin setQuota:]):
245
246 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
247
248         Fix the build
249
250         * WebView/WebView.mm:
251
252 2018-03-23  Tim Horton  <timothy_horton@apple.com>
253
254         Fix the build with no pasteboard
255         https://bugs.webkit.org/show_bug.cgi?id=183973
256
257         Reviewed by Dan Bernstein.
258
259         * Configurations/FeatureDefines.xcconfig:
260         * WebView/WebView.mm:
261         (-[WebView _requestStartDataInteraction:globalPosition:]):
262         (-[WebView _getDataInteractionData]):
263         (-[WebView _dataOperationTextIndicator]):
264         (-[WebView _dragSourceAction]):
265         (-[WebView _draggedLinkTitle]):
266         (-[WebView _draggedLinkURL]):
267         (-[WebView _draggedElementBounds]):
268         (-[WebView _enteredDataInteraction:client:global:operation:]):
269         (-[WebView _updatedDataInteraction:client:global:operation:]):
270         (-[WebView _exitedDataInteraction:client:global:operation:]):
271         (-[WebView _performDataInteraction:client:global:operation:]):
272         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
273         (-[WebView _endedDataInteraction:global:]):
274         (-[WebView _dataInteractionCaretRect]):
275         * WebView/WebViewPrivate.h:
276
277 2018-03-23  Tim Horton  <timothy_horton@apple.com>
278
279         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
280         https://bugs.webkit.org/show_bug.cgi?id=183960
281         <rdar://problem/38812356>
282
283         Reviewed by Dan Bernstein.
284
285         * Configurations/WebKitLegacy.xcconfig:
286
287 2018-03-23  Tim Horton  <timothy_horton@apple.com>
288
289         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
290         https://bugs.webkit.org/show_bug.cgi?id=183954
291         <rdar://problem/38808858>
292
293         Reviewed by Dan Bernstein.
294
295         * WebView/WebPreferences.mm:
296         (-[WebPreferences setAudioSessionCategoryOverride:]):
297
298 2018-03-23  Tim Horton  <timothy_horton@apple.com>
299
300         Adopt WK_PLATFORM_NAME in WebKitLegacy
301         https://bugs.webkit.org/show_bug.cgi?id=183948
302         <rdar://problem/38803908>
303
304         Reviewed by Dan Bernstein.
305
306         * Configurations/WebKitLegacy.xcconfig:
307         * MigrateHeaders.make:
308         * postprocess-headers.sh:
309
310 2018-03-23  Brady Eidson  <beidson@apple.com>
311
312         Go to back/forward list items after a process-swapped navigation.
313         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
314
315         Reviewed by Andy Estes.
316
317         * WebView/WebView.mm:
318         (-[WebView _loadBackForwardListFromOtherView:]):
319         (-[WebView goToBackForwardItem:]):
320
321 2018-03-22  Tim Horton  <timothy_horton@apple.com>
322
323         Improve readability of WebCore's OTHER_LDFLAGS
324         https://bugs.webkit.org/show_bug.cgi?id=183909
325         <rdar://problem/38760992>
326
327         Reviewed by Dan Bernstein.
328
329         * Configurations/Base.xcconfig:
330         * Configurations/FeatureDefines.xcconfig:
331
332 2018-03-20  Tim Horton  <timothy_horton@apple.com>
333
334         Enable the minimal simulator feature flag when appropriate
335         https://bugs.webkit.org/show_bug.cgi?id=183807
336
337         Reviewed by Dan Bernstein.
338
339         * Configurations/FeatureDefines.xcconfig:
340
341 2018-03-20  Tim Horton  <timothy_horton@apple.com>
342
343         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
344         https://bugs.webkit.org/show_bug.cgi?id=183758
345         <rdar://problem/38017644>
346
347         Reviewed by Dan Bernstein.
348
349         * Configurations/FeatureDefines.xcconfig:
350
351 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
352
353         Clear style colors when setting default appearance
354         https://bugs.webkit.org/show_bug.cgi?id=183759
355
356         Reviewed by Tim Horton.
357
358         Colors are cached and need to be cleared and recalculated.
359         Refactor to do all style recalcs together.
360
361         * WebView/WebView.mm:
362         (-[WebView _setDefaultAppearanceAndClearStyle]):
363         (-[WebView _setUseSystemAppearance:]):
364         (-[WebView effectiveAppearanceDidChange]):
365
366 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
367
368         Unreviewed, another quick fix for r229699
369
370         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
371
372         * Configurations/FeatureDefines.xcconfig:
373
374 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
375
376         Ensure that style is updated when the effective appearance changes
377         https://bugs.webkit.org/show_bug.cgi?id=183690
378         <rdar://problem/38385900>
379
380         Reviewed by Tim Horton and Wenson Hsieh.
381
382         Respond to and respect the effective appearance changing.
383
384         * WebView/WebView.mm:
385         (-[WebView _setUseSystemAppearance:]):
386         (-[WebView effectiveAppearanceDidChange]):
387
388 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
389
390         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
391         https://bugs.webkit.org/show_bug.cgi?id=183677
392
393         Reviewed by Tim Horton.
394
395         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
396
397         * DOM/DOM.mm:
398         (-[DOMHTMLLinkElement _mediaQueryMatches]):
399
400 2018-03-14  Tim Horton  <timothy_horton@apple.com>
401
402         Fix the build after r229567
403
404         * Configurations/FeatureDefines.xcconfig:
405
406 2018-03-12  Tim Horton  <timothy_horton@apple.com>
407
408         Stop using SDK conditionals to control feature definitions
409         https://bugs.webkit.org/show_bug.cgi?id=183430
410         <rdar://problem/38251619>
411
412         Reviewed by Dan Bernstein.
413
414         * Configurations/FeatureDefines.xcconfig:
415         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
416
417 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
418
419         Runtime flag for link prefetch and remove link subresource.
420         https://bugs.webkit.org/show_bug.cgi?id=183540
421
422         Reviewed by Chris Dumez.
423
424         Remove the LINK_PREFETCH build time flag.
425
426         * Configurations/FeatureDefines.xcconfig:
427
428 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
429
430         Remove GridLayout runtime flag
431         https://bugs.webkit.org/show_bug.cgi?id=183484
432
433         Reviewed by Myles C. Maxfield.
434
435         The Grid Layout feature has been enabled by default for almost a
436         year, so I think it's time to remove the runtime flag and the
437
438         * WebView/WebPreferenceKeysPrivate.h:
439         * WebView/WebPreferences.mm:
440         (+[WebPreferences initialize]):
441         * WebView/WebPreferencesPrivate.h:
442         * WebView/WebView.mm:
443         (-[WebView _preferencesChanged:]):
444
445 2018-03-12  Antoine Quint  <graouts@apple.com>
446
447         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
448         https://bugs.webkit.org/show_bug.cgi?id=183504
449         <rdar://problem/38372965>
450
451         Reviewed by Dean Jackson and Jon Lee.
452
453         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
454         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
455
456         * WebView/WebPreferenceKeysPrivate.h:
457         * WebView/WebPreferences.mm:
458         (+[WebPreferences initialize]):
459         (-[WebPreferences setModernMediaControlsEnabled:]):
460         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
461         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
462         * WebView/WebPreferencesPrivate.h:
463         * WebView/WebView.mm:
464         (-[WebView _preferencesChanged:]):
465
466 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
467
468         Media query for default appearance
469         https://bugs.webkit.org/show_bug.cgi?id=183539
470         <rdar://problem/38326388>
471
472         Reviewed by Tim Horton.
473
474         Write a media query to evaluate appearance.
475
476         * WebView/WebView.mm:
477         (-[WebView _commonInitializationWithFrameName:groupName:]):
478         (-[WebView _setUseSystemAppearance:]):
479
480 2018-03-09  Andy Estes  <aestes@apple.com>
481
482         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
483         https://bugs.webkit.org/show_bug.cgi?id=183489
484         <rdar://problem/38267517>
485
486         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
487         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
488         to issue a sandbox extension for this directory, but for security reasons App Sandbox
489         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
490         block with a nil error and a valid file URL, but no file will actually exist at that URL.
491
492         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
493         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
494         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
495         drop destination.
496
497         Reviewed by Wenson Hsieh.
498
499         * WebView/WebView.mm:
500         (-[WebView performDragOperation:]):
501
502 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
503
504         Allow WebViews to disable system appearance
505         https://bugs.webkit.org/show_bug.cgi?id=183418
506         <rdar://problem/36975642>
507
508         Reviewed by Tim Horton.
509
510         Allow webviews to choose whether or not to follow the default system appearance.
511
512         * WebView/WebView.mm:
513         (-[WebView _setUseSystemAppearance:]):
514         (-[WebView _useSystemAppearance]):
515         * WebView/WebViewPrivate.h:
516
517 2018-03-08  Youenn Fablet  <youenn@apple.com>
518
519         libwebrtc update broke internal builds
520         https://bugs.webkit.org/show_bug.cgi?id=183454
521
522         Reviewed by Eric Carlson.
523
524         * Configurations/WebKitLegacy.xcconfig:
525
526 2018-03-08  Chris Dumez  <cdumez@apple.com>
527
528         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
529         https://bugs.webkit.org/show_bug.cgi?id=183455
530         <rdar://problem/38191749>
531
532         Reviewed by Youenn Fablet.
533
534         Add a null check for the page as we have evidence from crashes that it can be null.
535         Other functions in WebFrameNetworkingContext already null check the page as well,
536         not just the frame so this is consistent.
537
538         * WebCoreSupport/WebFrameNetworkingContext.mm:
539         (WebFrameNetworkingContext::storageSession const):
540
541 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
542
543         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
544         https://bugs.webkit.org/show_bug.cgi?id=183429
545
546         Reviewed by Mark Lam.
547
548         * DOM/DOM.mm:
549         (+[DOMNode _nodeFromJSWrapper:]):
550         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
551         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
552         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
553         * Plugins/Hosted/ProxyInstance.mm:
554         (WebKit::ProxyInstance::invokeMethod):
555         * WebView/WebView.mm:
556         (aeDescFromJSValue):
557
558 2018-03-08  Tim Horton  <timothy_horton@apple.com>
559
560         Stop linking ApplicationServices directly
561         https://bugs.webkit.org/show_bug.cgi?id=182867
562         <rdar://problem/38252142>
563
564         Reviewed by Alex Christensen.
565
566         The frameworks that we use that live inside ApplicationServices
567         have mostly moved out, so import them directly.
568
569         * Carbon/CarbonUtils.h:
570         * WebKitPrefix.h:
571         * WebView/WebHTMLView.mm:
572         * WebView/WebPDFView.mm:
573
574 2018-03-07  Tim Horton  <timothy_horton@apple.com>
575
576         Sort and separate FeatureDefines.xcconfig
577         https://bugs.webkit.org/show_bug.cgi?id=183427
578
579         Reviewed by Dan Bernstein.
580
581         * Configurations/FeatureDefines.xcconfig:
582         Sort and split FeatureDefines into paragraphs
583         (to make it easier to sort later).
584
585 2018-03-07  Youenn Fablet  <youenn@apple.com>
586
587         Match unsupported plugins based on domains and not origin
588         https://bugs.webkit.org/show_bug.cgi?id=183384
589
590         Reviewed by Chris Dumez.
591
592         * WebCoreSupport/WebPluginInfoProvider.h:
593         * WebCoreSupport/WebPluginInfoProvider.mm:
594         (WebPluginInfoProvider::getPluginInfo):
595         (WebPluginInfoProvider::getWebVisiblePluginInfo):
596
597 2018-03-05  Andy Estes  <aestes@apple.com>
598
599         [Mac] Teach WebCore::Pasteboard about file promise drags
600         https://bugs.webkit.org/show_bug.cgi?id=183314
601         <rdar://problem/38105493>
602
603         Reviewed by Darin Adler.
604
605         Added a FIXME comment.
606
607         * WebView/WebView.mm:
608         (-[WebView performDragOperation:]):
609
610 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
611
612         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
613         https://bugs.webkit.org/show_bug.cgi?id=183312
614
615         Reviewed by Mark Lam.
616
617         Remove wtf/CurrentTime.h include pragma.
618
619         * WebView/WebFrame.mm:
620         * WebView/WebPDFView.mm:
621
622 2018-03-04  Tim Horton  <timothy_horton@apple.com>
623
624         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
625         https://bugs.webkit.org/show_bug.cgi?id=183283
626         <rdar://problem/38062148>
627
628         Reviewed by Sam Weinig.
629
630         * Configurations/FeatureDefines.xcconfig:
631
632 2018-02-28  Alex Christensen  <achristensen@webkit.org>
633
634         Reduce use of NetworkingContext in WebKit
635         https://bugs.webkit.org/show_bug.cgi?id=183213
636
637         Reviewed by Brady Eidson.
638
639         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
640         (WebKit::NetscapePluginInstanceProxy::getProxy):
641         * Plugins/WebNetscapePluginView.mm:
642         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
643
644 2018-02-17  Darin Adler  <darin@apple.com>
645
646         Prepare for ExtendedColor changes (first step)
647         https://bugs.webkit.org/show_bug.cgi?id=182904
648
649         Reviewed by Sam Weinig.
650
651         * Misc/WebKitNSStringExtras.mm:
652         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
653
654 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
655
656         Remove currentTime() / currentTimeMS()
657         https://bugs.webkit.org/show_bug.cgi?id=183052
658
659         Reviewed by Mark Lam.
660
661         * WebCoreSupport/WebFrameLoaderClient.h:
662         * WebCoreSupport/WebFrameLoaderClient.mm:
663         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
664
665 2018-02-16  Youenn Fablet  <youenn@apple.com>
666
667         Allow specifying which plug-ins are supported
668         https://bugs.webkit.org/show_bug.cgi?id=182748
669
670         Reviewed by Chris Dumez.
671
672         * WebCoreSupport/WebPluginInfoProvider.h:
673         * WebCoreSupport/WebPluginInfoProvider.mm:
674         (WebPluginInfoProvider::getPluginInfo):
675         (WebPluginInfoProvider::getWebVisiblePluginInfo):
676
677 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
678
679         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
680         https://bugs.webkit.org/show_bug.cgi?id=182882
681         <rdar://problem/35672661>
682
683         Reviewed by Dan Bernstein.
684
685         Make sure the smart pointer hold the collection of subviews lives at least as
686         long as the loop using it.
687
688         * WebView/WebHTMLView.mm:
689         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
690
691 2018-02-14  Daniel Bates  <dabates@apple.com>
692
693         Disallow cross-origin subresources from asking for credentials
694         https://bugs.webkit.org/show_bug.cgi?id=182579
695         <rdar://problem/36162271>
696
697         Reviewed by Andy Estes.
698
699         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
700         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
701
702         * WebView/WebPreferenceKeysPrivate.h:
703         * WebView/WebPreferences.mm:
704         (+[WebPreferences initialize]):
705         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
706         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
707         * WebView/WebPreferencesPrivate.h:
708         * WebView/WebView.mm:
709         (-[WebView _preferencesChanged:]):
710
711 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
712
713         Remove ForwardingHeaders directory from WebKitLegacy/mac.
714         https://bugs.webkit.org/show_bug.cgi?id=182738
715
716         Reviewed by Darin Adler.
717
718         * ForwardingHeaders/collector/handles/Global.h: Removed.
719         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
720         * ForwardingHeaders/runtime/Completion.h: Removed.
721         * ForwardingHeaders/runtime/Error.h: Removed.
722         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
723         * ForwardingHeaders/runtime/JSFunction.h: Removed.
724         * ForwardingHeaders/runtime/JSLock.h: Removed.
725         * ForwardingHeaders/runtime/JSObject.h: Removed.
726         * ForwardingHeaders/runtime/JSString.h: Removed.
727         * ForwardingHeaders/runtime/Protect.h: Removed.
728         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
729
730 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
731
732         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
733         https://bugs.webkit.org/show_bug.cgi?id=182641
734
735         Reviewed by Dan Bernstein.
736
737         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
738         https://trac.webkit.org/changeset/228308.
739
740         * WebView/WebVideoFullscreenController.h:
741         * WebView/WebVideoFullscreenHUDWindowController.mm:
742         * WebView/WebWindowAnimation.h:
743         * WebView/WebWindowAnimation.mm:
744         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
745         (WebCore::scaledRect): Deleted.
746         (WebCore::squaredDistance): Deleted.
747
748 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
749
750         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
751
752         * WebView/WebWindowAnimation.mm:
753         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
754
755 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
756
757         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
758         https://bugs.webkit.org/show_bug.cgi?id=182615
759
760         Reviewed by Eric Carlson.
761
762         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
763         Ideally, we should not reference NSApp in WebCore.
764
765         * WebView/WebFullScreenController.mm:
766         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
767         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
768         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
769         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
770         * WebView/WebView.mm:
771         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
772         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
773
774 2018-01-13  Darin Adler  <darin@apple.com>
775
776         Event improvements
777         https://bugs.webkit.org/show_bug.cgi?id=179591
778
779         Reviewed by Chris Dumez.
780
781         * DOM/DOMWheelEvent.mm:
782         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
783         Call initWebKitWheelEvent.
784
785         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
786         * WebCoreSupport/WebInspectorClient.mm: Ditto.
787         * WebView/WebFrame.mm: Ditto.
788
789         * WebView/WebHTMLView.mm:
790         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
791         underlyingPlatformEvent.
792         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
793
794         * WebView/WebScriptWorld.mm:
795         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
796
797         * WebView/WebView.mm: Removed include of ScriptValue.h.
798
799 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
800
801         Remove WebCore/ForwardingHeaders directory
802         https://bugs.webkit.org/show_bug.cgi?id=182347
803
804         Reviewed by Keith Miller.
805
806         * Carbon/CarbonWindowAdapter.mm:
807         * DOM/WebDOMOperations.mm:
808         * History/WebBackForwardList.mm:
809         * History/WebHistoryItem.mm:
810         * Misc/WebCache.mm:
811         * Misc/WebElementDictionary.mm:
812         * Misc/WebIconDatabase.mm:
813         * Misc/WebStringTruncator.mm:
814         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
815         * Plugins/Hosted/ProxyInstance.mm:
816         * Plugins/Hosted/ProxyRuntimeObject.mm:
817         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
818         * Plugins/WebBaseNetscapePluginView.mm:
819         * Plugins/WebBasePluginPackage.mm:
820         * Plugins/WebNetscapePluginStream.mm:
821         * Plugins/WebNetscapePluginView.mm:
822         * Plugins/WebPluginController.mm:
823         * WebCoreSupport/WebEditorClient.mm:
824         * WebCoreSupport/WebFrameLoaderClient.mm:
825         * WebCoreSupport/WebInspectorClient.h:
826         * WebCoreSupport/WebInspectorClient.mm:
827         * WebView/WebDataSource.mm:
828         * WebView/WebFrame.mm:
829         * WebView/WebHTMLRepresentation.mm:
830         * WebView/WebHTMLView.mm:
831         * WebView/WebPreferences.mm:
832         * WebView/WebScriptDebugDelegate.mm:
833         * WebView/WebScriptDebugger.h:
834         * WebView/WebTextIterator.mm:
835         * WebView/WebView.mm:
836         * WebView/WebViewData.mm:
837
838 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
839
840         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
841         https://bugs.webkit.org/show_bug.cgi?id=182312
842
843         Reviewed by Michael Catanzaro.
844
845         * WebKitPrefix.h:
846
847 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
848
849         [WebAuthN] Add a compile-time feature flag
850         https://bugs.webkit.org/show_bug.cgi?id=182211
851         <rdar://problem/36936365>
852
853         Reviewed by Brent Fulgham.
854
855         * Configurations/FeatureDefines.xcconfig:
856
857 2018-01-27  Dan Bernstein  <mitz@apple.com>
858
859         HaveInternalSDK includes should be "#include?"
860         https://bugs.webkit.org/show_bug.cgi?id=179670
861
862         * Configurations/Base.xcconfig:
863
864 2018-01-24  Alex Christensen  <achristensen@webkit.org>
865
866         Remove unused QTKit preference
867         https://bugs.webkit.org/show_bug.cgi?id=181968
868
869         Reviewed by Alexey Proskuryakov.
870
871         * WebView/WebPreferenceKeysPrivate.h:
872         * WebView/WebPreferences.mm:
873         (+[WebPreferences initialize]):
874         (-[WebPreferences setQTKitEnabled:]): Deleted.
875         (-[WebPreferences isQTKitEnabled]): Deleted.
876         * WebView/WebPreferencesPrivate.h:
877         * WebView/WebView.mm:
878         (-[WebView _preferencesChanged:]):
879
880 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
881
882         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
883         https://bugs.webkit.org/show_bug.cgi?id=182037
884         <rdar://problem/36747812>
885
886         Reviewed by Ryosuke Niwa.
887
888         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
889         for more details.
890
891         * WebView/WebHTMLRepresentation.mm:
892         (-[WebHTMLRepresentation elementWithName:inForm:]):
893         (-[WebHTMLRepresentation controlsInForm:]):
894
895 2018-01-23  Alex Christensen  <achristensen@webkit.org>
896
897         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
898         https://bugs.webkit.org/show_bug.cgi?id=181961
899
900         Reviewed by Michael Catanzaro.
901
902         * WebView/WebPreferences.mm:
903
904 2018-01-23  Commit Queue  <commit-queue@webkit.org>
905
906         Unreviewed, rolling out r227437.
907         https://bugs.webkit.org/show_bug.cgi?id=182011
908
909         broke build (Requested by alexchristensen on #webkit).
910
911         Reverted changeset:
912
913         "Remove unused QTKit preference"
914         https://bugs.webkit.org/show_bug.cgi?id=181968
915         https://trac.webkit.org/changeset/227437
916
917 2018-01-23  Alex Christensen  <achristensen@webkit.org>
918
919         Remove unused QTKit preference
920         https://bugs.webkit.org/show_bug.cgi?id=181968
921
922         Reviewed by Alexey Proskuryakov.
923
924         * WebView/WebPreferenceKeysPrivate.h:
925         * WebView/WebPreferences.mm:
926         (+[WebPreferences initialize]):
927         (-[WebPreferences setQTKitEnabled:]): Deleted.
928         (-[WebPreferences isQTKitEnabled]): Deleted.
929         * WebView/WebPreferencesPrivate.h:
930         * WebView/WebView.mm:
931         (-[WebView _preferencesChanged:]):
932
933 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
934
935         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
936         https://bugs.webkit.org/show_bug.cgi?id=181960
937         <rdar://problem/36431678>
938
939         Reviewed by Tim Horton.
940
941         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
942         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
943         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
944
945         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
946         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
947         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
948
949         * WebView/WebView.mm:
950         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
951
952 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
953
954         Turning off custom pasteboard data doesn't actually turn it off in WK2
955         https://bugs.webkit.org/show_bug.cgi?id=181920
956         <rdar://problem/36686429>
957
958         Reviewed by Wenson Hsieh.
959
960         Always disable custom pasteboard data in WebKit1. See r226156 for details.
961
962         * WebView/WebPreferences.mm:
963         (+[WebPreferences initialize]):
964         * WebView/WebView.mm:
965         (-[WebView _preferencesChanged:]):
966
967 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
968
969         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
970         https://bugs.webkit.org/show_bug.cgi?id=181918
971
972         Reviewed by Tim Horton.
973
974         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
975
976         * Configurations/FeatureDefines.xcconfig:
977
978 2018-01-20  Andy Estes  <aestes@apple.com>
979
980         [Apple Pay] Stop eagerly loading PassKit.framework
981         https://bugs.webkit.org/show_bug.cgi?id=181911
982         <rdar://problem/36555369>
983
984         Reviewed by Tim Horton.
985
986         * WebCoreSupport/WebPaymentCoordinatorClient.h:
987         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
988         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
989
990         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
991
992 2018-01-19  Dean Jackson  <dino@apple.com>
993
994         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
995         https://bugs.webkit.org/show_bug.cgi?id=181817
996         <rdar://problem/35274055>
997
998         Reviewed by Simon Fraser.
999
1000         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1001
1002         * Misc/WebKitVersionChecks.h:
1003         * WebView/WebView.mm:
1004         (-[WebView _commonInitializationWithFrameName:groupName:]):
1005
1006 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1007
1008         Remove unused WebViewPrivate _allowCookies
1009         https://bugs.webkit.org/show_bug.cgi?id=181812
1010
1011         Reviewed by Tim Horton.
1012
1013         * WebView/WebView.mm:
1014         (+[WebView _setAllowCookies:]): Deleted.
1015         (+[WebView _allowCookies]): Deleted.
1016         * WebView/WebViewPrivate.h:
1017
1018 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1019
1020         Build fix, remove a call to -[NSWindow setOneShot:]
1021         https://bugs.webkit.org/show_bug.cgi?id=181809
1022
1023         Reviewed by Tim Horton.
1024
1025         * WebView/WebTextCompletionController.mm:
1026         (-[WebTextCompletionController _buildUI]):
1027
1028 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1029
1030         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1031
1032         * Carbon/HIWebView.mm:
1033         (overrideCGContext):
1034         (restoreCGContext):
1035
1036 2018-01-18  Dan Bernstein  <mitz@apple.com>
1037
1038         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1039         https://bugs.webkit.org/show_bug.cgi?id=181803
1040
1041         Reviewed by Tim Horton.
1042
1043         * Configurations/Base.xcconfig: Updated.
1044         * Configurations/DebugRelease.xcconfig: Ditto.
1045         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1046         * Configurations/Version.xcconfig: Updated.
1047         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1048           useful for defining settings that depend on the target macOS version.
1049
1050 2018-01-17  Youenn Fablet  <youenn@apple.com>
1051
1052         Put fetch Request.keepalive behind a runtime flag
1053         https://bugs.webkit.org/show_bug.cgi?id=181592
1054
1055         Reviewed by Chris Dumez.
1056
1057         * WebView/WebPreferenceKeysPrivate.h:
1058         * WebView/WebPreferences.mm:
1059         (+[WebPreferences initialize]):
1060         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1061         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1062         * WebView/WebPreferencesPrivate.h:
1063         * WebView/WebView.mm:
1064         (-[WebView _preferencesChanged:]):
1065
1066 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1067
1068         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1069         https://bugs.webkit.org/show_bug.cgi?id=181637
1070         <rdar://problem/36508471>
1071
1072         Reviewed by Tim Horton.
1073
1074         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1075
1076         * WebCoreSupport/WebEditorClient.h:
1077         * WebCoreSupport/WebEditorClient.mm:
1078         (WebEditorClient::replacementURLForResource):
1079
1080 2018-01-11  Keith Miller  <keith_miller@apple.com>
1081
1082         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1083         https://bugs.webkit.org/show_bug.cgi?id=181573
1084
1085         Reviewed by Simon Fraser.
1086
1087         * Configurations/FeatureDefines.xcconfig:
1088
1089 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1090
1091         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1092         https://bugs.webkit.org/show_bug.cgi?id=181497
1093
1094         Reviewed by Tim Horton.
1095
1096         See other ChangeLogs for more detail.
1097
1098         * WebCoreSupport/WebDragClient.h:
1099
1100 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1101
1102         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1103         https://bugs.webkit.org/show_bug.cgi?id=181523
1104         <rdar://problem/28959131>
1105
1106         Reviewed by Alex Christensen.
1107
1108         * WebView/WebImmediateActionController.mm:
1109         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1110         Apply the change made in r216652 to WebKit1's immediate action controller.
1111
1112         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1113         the startContainer of the range is in an anonymous node.
1114
1115 2018-01-11  Youenn Fablet  <youenn@apple.com>
1116
1117         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1118         https://bugs.webkit.org/show_bug.cgi?id=181480
1119
1120         Reviewed by Eric Carlson.
1121
1122         * WebView/WebPreferences.mm:
1123         (+[WebPreferences initialize]):
1124
1125 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1126
1127         Fix check-webkit-style issues with WebNSDataExtras.mm
1128         <https://webkit.org/b/181369>
1129
1130         Reviewed by Alex Christensen.
1131
1132         * Misc/WebNSDataExtras.mm:
1133         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1134         (-[NSData _webkit_guessedMIMETypeForXML]):
1135         (-[NSData _webkit_guessedMIMEType]):
1136         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1137         (_findEOL):
1138         (-[NSData _webkit_parseRFC822HeaderFields]):
1139         (-[NSData _web_locationAfterFirstBlankLine]):
1140         - Fix all the check-webkit-style warnings.
1141
1142 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1143
1144         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1145         <https://webkit.org/b/181256>
1146         <rdar://problem/36281730>
1147
1148         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1149         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1150         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1151           to avoid warnings from casting CFStringRef to NPNSString*.
1152           Note that CFMutableStringRef is the same as CFStringRef
1153           without the const modifier, hence its use in the const_cast<>
1154           above.
1155
1156 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1157
1158         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1159         <https://webkit.org/b/181256>
1160         <rdar://problem/36281730>
1161
1162         * Carbon/HIWebView.mm:
1163         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1164         checked_cf_cast<CFRunLoopRef>() to fix warning.
1165
1166 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1167
1168         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1169         <https://webkit.org/b/181256>
1170         <rdar://problem/36281730>
1171
1172         Reviewed by Darin Adler.
1173
1174         * Carbon/CarbonUtils.m:
1175         (PoolCleaner):
1176         - Use #pragmas to ignore -Wcast-qual warnings when using a
1177           C-style cast from CFTypeRef to CFRunloopRef.
1178         * Carbon/CarbonWindowFrame.m:
1179         (-[CarbonWindowFrame title]):
1180         - Use #pragmas to ignore -Wcast-qual warnings when using a
1181           C-style cast from CFStringRef to NSString *.
1182         * Carbon/HIViewAdapter.m:
1183         (+[HIViewAdapter getHIViewForNSView:]):
1184         - Use #pragmas to ignore -Wcast-qual warnings when using a
1185           C-style cast from CFTypeRef to HIViewRef.
1186         * Configurations/Base.xcconfig:
1187         (WARNING_CFLAGS): Add -Wcast-qual.
1188         * Misc/WebElementDictionary.mm:
1189         (-[WebElementDictionary objectForKey:]):
1190         - Use static_cast<SEL>(const_cast<void*>()) to fix
1191           warning.
1192         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1193         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1194         (-[NSData _webkit_guessedMIMETypeForXML]):
1195         (-[NSData _webkit_guessedMIMEType]):
1196         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1197         (_findEOL):
1198         (-[NSData _webkit_parseRFC822HeaderFields]):
1199         (-[NSData _web_startsWithBlankLine]):
1200         (-[NSData _web_locationAfterFirstBlankLine]):
1201         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1202           type to Objective-C++.  This fixes the warnings about
1203           discarding the `const` modifier when casing from CFStringRef
1204           to NSString * because in older clang versions, -Wcast-qual was
1205           completely broken when compiling C++ and Objective-C++ source
1206           files.  In newer clang versions, discarding the `const`
1207           modifier for toll-free bridged types is ignored when compiling
1208           Objective-C++ source.
1209         - Update copyright and license header.
1210         - Use reinterpret_cast<> and static_cast<> to fix warnings
1211           unrelated to (NSString *) C-style casts.
1212         - Replace use of MIN() macro with std::min<> template functions.
1213         - Fix location of `*` for local variables modified above.
1214         * Plugins/Hosted/NetscapePluginHostManager.mm:
1215         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1216         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1217         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1218         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1219           warnings.
1220         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1221         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1222         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1223           to fix warning.
1224         * Plugins/Hosted/ProxyInstance.mm:
1225         (WebKit::ProxyInstance::invoke):
1226         - Use static_cast<char*>(const_cast<void*>()) to fix
1227           warning when using -[NSData bytes].
1228         (WebKit::ProxyInstance::fieldValue const):
1229         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1230           to fix warning when using CFDataGetBytePtr().
1231         * Plugins/Hosted/WebTextInputWindowController.m:
1232         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1233         - Use #pragma to ignore -Wcast-qual warning since there
1234           is not a good way to avoid this warning in Objective-C.
1235         * Plugins/WebNetscapePluginStream.mm:
1236         (WebNetscapePluginStream::deliverData):
1237         - Use const_cast<void*>() to fix warning when using
1238           -[NSData bytes].
1239         * Plugins/WebNetscapePluginView.mm:
1240         (-[WebNetscapePluginView _createPlugin]):
1241         - Change C-style cast to const_cast<char*>() to fix
1242           warning.
1243         * WebCoreSupport/WebChromeClient.mm:
1244         (WebChromeClient::wrapCryptoKey const):
1245         (WebChromeClient::unwrapCryptoKey const):
1246         - Change C-style cast to
1247           static_cast<uint8_t*>(const_cast<void*>() to fix
1248           warning.
1249         * WebView/WebPDFView.mm:
1250         (_applicationInfoForMIMEType):
1251         - Change local variable type from 'NSURL *' to
1252           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1253           when calling -[NSURL path].
1254
1255 2018-01-05  Dan Bernstein  <mitz@apple.com>
1256
1257         Fixed the build following AppKit API deprecations in a recent SDKs
1258
1259         * WebView/WebFullScreenController.mm:
1260         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1261         (-[WebFullScreenController exitFullScreen]): Ditto.
1262         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1263         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1264         * WebView/WebHTMLView.mm:
1265         (-[WebHTMLView drawRect:]): Ditto.
1266         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1267         (-[WebHTMLView knowsPageRange:]): Ditto.
1268         * WebView/WebView.mm:
1269         (LayerFlushController::flushLayers): Ditto.
1270
1271 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1272
1273         [Attachment Support] Create attachment elements when dropping files on iOS
1274         https://bugs.webkit.org/show_bug.cgi?id=181192
1275         <rdar://problem/36280945>
1276
1277         Reviewed by Tim Horton.
1278
1279         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1280
1281         * WebCoreSupport/WebPlatformStrategies.h:
1282         * WebCoreSupport/WebPlatformStrategies.mm:
1283         (WebPlatformStrategies::informationForItemAtIndex):
1284         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1285
1286 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1287
1288         [Attachment Support] Add plumbing for starting a drag with promised blob data
1289         https://bugs.webkit.org/show_bug.cgi?id=181201
1290
1291         Reviewed by Tim Horton.
1292
1293         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1294
1295         * WebCoreSupport/WebDragClient.h:
1296
1297 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1298
1299         Add a WebAuthentication runtime feature flag
1300         https://bugs.webkit.org/show_bug.cgi?id=181220
1301         <rdar://problem/36055305>
1302
1303         Reviewed by Brent Fulgham.
1304
1305         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1306
1307         * WebView/WebPreferenceKeysPrivate.h:
1308         * WebView/WebPreferences.mm:
1309         (+[WebPreferences initialize]):
1310         (-[WebPreferences webAuthenticationEnabled]):
1311         (-[WebPreferences setWebAuthenticationEnabled:]):
1312         (-[WebPreferences credentialManagementEnabled]): Deleted.
1313         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1314         * WebView/WebPreferencesPrivate.h:
1315         * WebView/WebView.mm:
1316         (-[WebView _preferencesChanged:]):
1317
1318 2017-12-22  Jeff Miller  <jeffm@apple.com>
1319
1320         Update user-visible copyright strings to include 2018
1321         https://bugs.webkit.org/show_bug.cgi?id=181141
1322
1323         Reviewed by Dan Bernstein.
1324
1325         * Info.plist:
1326
1327 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1328
1329         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1330         https://bugs.webkit.org/show_bug.cgi?id=181188
1331
1332         Reviewed by Dan Bernstein.
1333
1334         See WebCore/ChangeLog for more detail.
1335
1336         * WebCoreSupport/WebDragClient.h:
1337         * WebCoreSupport/WebDragClient.mm:
1338         (WebDragClient::declareAndWriteAttachment): Deleted.
1339         * WebView/WebHTMLView.mm:
1340         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1341
1342 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1343
1344         Unreviewed, continue to fix build failures due to AppKit API deprecation
1345
1346         Wraps more code in -Wdeprecated-declarations.
1347
1348         * Carbon/HIWebView.mm:
1349         (overrideCGContext):
1350
1351 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1352
1353         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1354
1355         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1356
1357         * Carbon/CarbonWindowAdapter.mm:
1358         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1359         * Plugins/WebNetscapePluginView.mm:
1360         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1361         (-[WebNetscapePluginView sendDrawRectEvent:]):
1362         (-[WebNetscapePluginView drawRect:]):
1363
1364 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1365
1366         Fix build failures due to using deprecated AppKit symbols
1367         https://bugs.webkit.org/show_bug.cgi?id=181110
1368         <rdar://problem/36162865>
1369
1370         Reviewed by Dan Bernstein and Tim Horton.
1371
1372         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1373
1374         * Misc/WebKitNSStringExtras.mm:
1375         (-[NSString _web_drawAtPoint:font:textColor:]):
1376         * Misc/WebNSPasteboardExtras.h:
1377         * Misc/WebNSPasteboardExtras.mm:
1378         (+[NSPasteboard _web_writableTypesForURL]):
1379         (_createWritableTypesForImageWithoutArchive):
1380         (_createWritableTypesForImageWithArchive):
1381         (+[NSPasteboard _web_dragTypesForURL]):
1382         (-[NSPasteboard _web_bestURL]):
1383         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1384         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1385         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1386         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1387         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1388         * Panels/WebAuthenticationPanel.m:
1389         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1390         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1391         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1392         (-[WebHostedNetscapePluginView drawRect:]):
1393         * WebInspector/WebNodeHighlightView.mm:
1394         (-[WebNodeHighlightView drawRect:]):
1395         * WebView/WebFrame.mm:
1396         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1397         (-[WebFrame _drawRect:contentsOnly:]):
1398         * WebView/WebHTMLView.mm:
1399         (kit):
1400         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1401         (-[WebHTMLView _plainTextFromPasteboard:]):
1402         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1403         (+[WebHTMLView _insertablePasteboardTypes]):
1404         (+[WebHTMLView _selectionPasteboardTypes]):
1405         (-[WebHTMLView pasteboard:provideDataForType:]):
1406         (-[WebHTMLView _writeSelectionToPasteboard:]):
1407         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1408         (-[WebHTMLView validRequestorForSendType:returnType:]):
1409         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1410         (createMenuItem):
1411         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1412         (-[WebHTMLView _colorAsString:]):
1413         (-[WebHTMLView copyFont:]):
1414         * WebView/WebPDFView.mm:
1415         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1416         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1417         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1418         (-[WebPDFView pasteboardTypesForSelection]):
1419         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1420         * WebView/WebView.h:
1421         * WebView/WebView.mm:
1422         (-[WebView performDragOperation:]):
1423         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1424         (-[WebView _searchWithGoogleFromMenu:]):
1425
1426 2017-12-21  Youenn Fablet  <youenn@apple.com>
1427
1428         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1429         https://bugs.webkit.org/show_bug.cgi?id=181000
1430
1431         Reviewed by Chris Dumez.
1432
1433         * Misc/WebCache.mm:
1434         (+[WebCache addImageToCache:forURL:forFrame:]):
1435
1436 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1437
1438         Update FULLSCREEN_API feature defines.
1439         https://bugs.webkit.org/show_bug.cgi?id=181015
1440
1441         Reviewed by Tim Horton.
1442
1443         Change enabled iphone sdk for FULLSCREEN_API.
1444
1445         * Configurations/FeatureDefines.xcconfig:
1446
1447 2017-12-21  Jer Noble  <jer.noble@apple.com>
1448
1449         Add initial DOM support for Media Capabilities
1450         https://bugs.webkit.org/show_bug.cgi?id=181064
1451
1452         Reviewed by Eric Carlson.
1453
1454         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1455
1456         * WebView/WebPreferenceKeysPrivate.h:
1457         * WebView/WebPreferences.mm:
1458         (+[WebPreferences initialize]):
1459         (-[WebPreferences mediaCapabilitiesEnabled]):
1460         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1461         * WebView/WebPreferencesPrivate.h:
1462         * WebView/WebView.mm:
1463         (-[WebView _preferencesChanged:]):
1464
1465 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1466
1467         Enable picture-in-picture from inline element on suspend.
1468         https://bugs.webkit.org/show_bug.cgi?id=180942
1469         rdar://problem/34745234
1470
1471         Reviewed by Jer Noble.
1472
1473         Update signature of enterVideoFullscreenForVideoElement().
1474
1475         * WebCoreSupport/WebChromeClient.h:
1476         * WebCoreSupport/WebChromeClient.mm:
1477         (WebChromeClient::enterVideoFullscreenForVideoElement):
1478
1479 2017-12-20  Daniel Bates  <dabates@apple.com>
1480
1481         Remove Alternative Presentation Button
1482         https://bugs.webkit.org/show_bug.cgi?id=180500
1483         <rdar://problem/35891047>
1484
1485         Reviewed by Simon Fraser.
1486
1487         We no longer need the alternative presentation button.
1488
1489         * Configurations/FeatureDefines.xcconfig:
1490
1491 2017-12-19  Jer Noble  <jer.noble@apple.com>
1492
1493         Playing media elements which call "pause(); play()" will have the play promise rejected.
1494         https://bugs.webkit.org/show_bug.cgi?id=180781
1495         <rdar://problem/33191377>
1496
1497         Reviewed by Eric Carlson.
1498
1499         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1500
1501         * WebView/WebView.mm:
1502         (shouldRequireUserGestureToLoadVideo):
1503
1504 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1505
1506         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1507         https://bugs.webkit.org/show_bug.cgi?id=180977
1508
1509         Reviewed by Tim Horton.
1510
1511         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1512         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1513         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1514
1515         * WebCoreSupport/WebEditorClient.mm:
1516         (attributesForAttributedStringConversion):
1517         * WebView/WebHTMLView.mm:
1518         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1519
1520 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1521
1522         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1523
1524         Attempt to fix the following warnings:
1525
1526             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1527
1528         For the following instance variables:
1529
1530             _borderView
1531             _contentView
1532             _frame
1533             _wFlags
1534
1535         * Carbon/CarbonWindowAdapter.mm:
1536         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1537         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1538         (-[CarbonWindowAdapter _termWindowIfOwner]):
1539         (-[CarbonWindowAdapter _windowMovedToRect:]):
1540         (-[CarbonWindowAdapter setContentView:]):
1541         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1542         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1543
1544 2017-12-16  Dan Bernstein  <mitz@apple.com>
1545
1546         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1547         https://bugs.webkit.org/show_bug.cgi?id=180613
1548         <rdar://problem/35946124>
1549
1550         Reviewed by Geoff Garen.
1551
1552         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1553           clients.
1554         * WebView/WebDynamicScrollBarsView.h: Ditto.
1555         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1556
1557 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1558
1559         Enable -Wstrict-prototypes for WebKit
1560         <https://webkit.org/b/180757>
1561         <rdar://problem/36024132>
1562
1563         Rubber-stamped by Joseph Pecoraro.
1564
1565         * Configurations/Base.xcconfig:
1566         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1567
1568 2017-12-14  John Wilander  <wilander@apple.com>
1569
1570         Storage Access API: Implement frame-specific access in the document.cookie layer
1571         https://bugs.webkit.org/show_bug.cgi?id=180682
1572         <rdar://problem/35982257>
1573
1574         Reviewed by Alex Christensen.
1575
1576         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1577         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1578         CookiesStrategy::getRawCookies() now take optional parameters for
1579         frameID and pageID to allow frame-specific scoping of cookies.
1580
1581         This change makes the return values of FrameLoaderClient::frameID()
1582         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1583         WebCore can call those getters and get the right return values in
1584         WebKit and std:nullopt in WebKitLegacy.
1585
1586         * WebCoreSupport/WebFrameLoaderClient.h:
1587         * WebCoreSupport/WebFrameLoaderClient.mm:
1588         (WebFrameLoaderClient::pageID const):
1589         (WebFrameLoaderClient::frameID const):
1590         * WebCoreSupport/WebPlatformStrategies.h:
1591         * WebCoreSupport/WebPlatformStrategies.mm:
1592         (WebPlatformStrategies::cookiesForDOM):
1593         (WebPlatformStrategies::setCookiesFromDOM):
1594         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1595         (WebPlatformStrategies::getRawCookies):
1596
1597 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1598
1599         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1600         https://bugs.webkit.org/show_bug.cgi?id=180689
1601
1602         Reviewed by Tim Horton.
1603
1604         Use sRGBColorSpaceRef() from WebCore.
1605
1606         * WebView/WebHTMLView.mm:
1607         (imageFromRect):
1608
1609 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1610
1611         Stop using deprecated target conditional for simulator builds
1612         https://bugs.webkit.org/show_bug.cgi?id=180662
1613         <rdar://problem/35136156>
1614
1615         Reviewed by Simon Fraser.
1616
1617         * postprocess-headers.sh:
1618
1619 2017-12-11  David Quesada  <david_quesada@apple.com>
1620
1621         Turn on ENABLE_APPLICATION_MANIFEST
1622         https://bugs.webkit.org/show_bug.cgi?id=180562
1623         rdar://problem/35924737
1624
1625         Reviewed by Geoffrey Garen.
1626
1627         * Configurations/FeatureDefines.xcconfig:
1628
1629 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1630
1631         Remove pthread_once in favor of dispatch_once
1632         https://bugs.webkit.org/show_bug.cgi?id=180591
1633
1634         Reviewed by Saam Barati.
1635
1636         * Misc/WebKitErrors.m:
1637         (+[NSError _registerWebKitErrors]):
1638         (registerErrors): Deleted.
1639         * Storage/WebStorageManager.mm:
1640         (+[WebStorageManager _storageDirectoryPath]):
1641         (initializeLocalStoragePath): Deleted.
1642
1643 2017-12-07  Darin Adler  <darin@apple.com>
1644
1645         Remove some unused code from WebKitLegacy
1646         https://bugs.webkit.org/show_bug.cgi?id=180567
1647
1648         Reviewed by Anders Carlsson.
1649
1650         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1651         macOS (back a few versions) and iOS and removed unused
1652         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1653         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1654         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1655         _webkit_stringByCollapsingNonPrintingCharacters,
1656         _webkit_stringByCollapsingWhitespaceCharacters,
1657         _web_stringWithData:textEncodingName:, and
1658         _webkit_localStorageDirectoryWithBundleIdentifier:.
1659
1660         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1661         this source file.
1662         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1663         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1664         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1665         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1666         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1667         handle font smoothing options.
1668         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1669         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1670         from header and made it a little clearer.
1671         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1672         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1673         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1674         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1675         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1676         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1677         implementation a bit and used whole words instead of abbreviations.
1678         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1679
1680         * Misc/WebNSFileManagerExtras.mm:
1681         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1682         filenameByFixingIllegalCharacters function from WebCore directly instead of
1683         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1684
1685         * Plugins/WebBaseNetscapePluginView.mm:
1686         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1687         string replacements instead of _web_stringByStrippingReturnCharacters
1688         and to use NSString methods instead of CFString functions.
1689
1690 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1691
1692         Ignore deprecation warnings.
1693
1694         * WebView/WebHTMLView.mm:
1695         (-[NSWindow _web_borderView]):
1696         (-[WebHTMLView _setAsideSubviews]):
1697         * WebView/WebView.mm:
1698         (-[WebView encodeWithCoder:]):
1699
1700 2017-12-02  Darin Adler  <darin@apple.com>
1701
1702         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1703         https://bugs.webkit.org/show_bug.cgi?id=180009
1704
1705         Reviewed by Alex Christensen.
1706
1707         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1708
1709         * Plugins/WebBaseNetscapePluginView.mm:
1710         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1711         of strcasecmp.
1712
1713         * WebView/WebPreferences.mm:
1714         (contains): Ditto. Also made this a template so it's easier to call on an array.
1715         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1716
1717 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1718
1719         Limit user agent versioning to an upper bound
1720         https://bugs.webkit.org/show_bug.cgi?id=180365
1721         <rdar://problem/34550617>
1722
1723         Reviewed by Joseph Pecoraro.
1724
1725         * WebView/WebView.mm:
1726         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1727         creating the User Agent string.
1728         (webKitBundleVersionString): Deleted.
1729
1730 2017-12-05  Andy Estes  <aestes@apple.com>
1731
1732         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1733         https://bugs.webkit.org/show_bug.cgi?id=180457
1734         <rdar://problem/35143007>
1735
1736         Reviewed by Tim Horton.
1737
1738         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1739         check for this macro during post-processing.
1740
1741         * postprocess-headers.sh:
1742
1743 2017-12-04  David Quesada  <david_quesada@apple.com>
1744
1745         Add a class for parsing application manifests
1746         https://bugs.webkit.org/show_bug.cgi?id=177973
1747         rdar://problem/34747949
1748
1749         Reviewed by Geoffrey Garen.
1750
1751         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1752
1753 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1754
1755         Make LegacyCustomProtocolManager optional for network process
1756         https://bugs.webkit.org/show_bug.cgi?id=176230
1757
1758         Reviewed by Alex Christensen.
1759
1760         * Configurations/FeatureDefines.xcconfig:
1761
1762 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1763
1764         Fix some NSOperationQueue leaks
1765         https://bugs.webkit.org/show_bug.cgi?id=180221
1766
1767         Reviewed by Wenson Hsieh.
1768
1769         * WebView/WebView.mm:
1770         (-[WebView performDragOperation:]):
1771
1772 2017-11-30  Darin Adler  <darin@apple.com>
1773
1774         [Mac] remove unneeded RetainPtr use introduced in r225142
1775         https://bugs.webkit.org/show_bug.cgi?id=180202
1776
1777         Reviewed by Tim Horton.
1778
1779         * WebView/WebImmediateActionController.mm:
1780         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1781         RetainPtr.
1782
1783 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1784
1785         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1786         https://bugs.webkit.org/show_bug.cgi?id=175595
1787
1788         Reviewed by Darin Adler.
1789
1790         * WebView/WebPreferences.mm:
1791
1792 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1793
1794         One too many zeroes in macOS version number in FeatureDefines
1795         https://bugs.webkit.org/show_bug.cgi?id=180011
1796
1797         Reviewed by Dan Bernstein.
1798
1799         * Configurations/FeatureDefines.xcconfig:
1800
1801 2017-11-23  Darin Adler  <darin@apple.com>
1802
1803         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1804         https://bugs.webkit.org/show_bug.cgi?id=179981
1805
1806         Reviewed by Sam Weinig.
1807
1808         * WebView/WebImmediateActionController.mm:
1809         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1810         * WebView/WebView.mm:
1811         (coreOptions): Use |= instead of | to build up FindOptions.
1812
1813 2017-11-23  Sam Weinig  <sam@webkit.org>
1814
1815         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1816         https://bugs.webkit.org/show_bug.cgi?id=179954
1817
1818         Reviewed by Darin Adler.
1819
1820         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1821         with direct calls to the corresponding UserGestureIndicator functions.
1822
1823         * Plugins/WebPluginController.mm:
1824         (-[WebPluginController processingUserGesture]):
1825         * WebView/WebView.mm:
1826         (-[WebView _isProcessingUserGesture]):
1827
1828 2017-11-23  Darin Adler  <darin@apple.com>
1829
1830         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1831         https://bugs.webkit.org/show_bug.cgi?id=179907
1832
1833         Reviewed by Sam Weinig.
1834
1835         * History/BinaryPropertyList.cpp:
1836         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1837         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1838         * WebView/WebHTMLRepresentation.mm:
1839         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1840         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1841
1842 2017-11-22  Ali Juma  <ajuma@chromium.org>
1843
1844         Implement VisualViewport API attributes
1845         https://bugs.webkit.org/show_bug.cgi?id=179385
1846
1847         Reviewed by Frédéric Wang.
1848
1849         Add a VisualViewportAPI preference.
1850
1851         * WebView/WebPreferenceKeysPrivate.h:
1852         * WebView/WebPreferences.mm:
1853         (+[WebPreferences initialize]):
1854         (-[WebPreferences visualViewportAPIEnabled]):
1855         (-[WebPreferences setVisualViewportAPIEnabled:]):
1856         * WebView/WebPreferencesPrivate.h:
1857         * WebView/WebView.mm:
1858         (-[WebView _preferencesChanged:]):
1859
1860 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1861
1862         WebCoreObjCExtras.h is being included in too many places
1863         https://bugs.webkit.org/show_bug.cgi?id=179931
1864
1865         Reviewed by Darin Adler.
1866
1867         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1868         * Plugins/WebBaseNetscapePluginView.mm:
1869         * Plugins/WebBasePluginPackage.mm:
1870         * Plugins/WebNetscapePluginStream.mm:
1871         * Plugins/WebNetscapePluginView.mm:
1872         * WebView/WebTextIterator.mm:
1873         * WebView/WebViewData.mm:
1874
1875 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1876
1877         Unreviewed, rolling out r225093.
1878         https://bugs.webkit.org/show_bug.cgi?id=179938
1879
1880         Compilation failed on WinCairo 64-bit Release (Requested by
1881         fredw on #webkit).
1882
1883         Reverted changeset:
1884
1885         "Implement VisualViewport API attributes"
1886         https://bugs.webkit.org/show_bug.cgi?id=179385
1887         https://trac.webkit.org/changeset/225093
1888
1889 2017-11-21  Ali Juma  <ajuma@chromium.org>
1890
1891         Implement VisualViewport API attributes
1892         https://bugs.webkit.org/show_bug.cgi?id=179385
1893
1894         Reviewed by Frédéric Wang.
1895
1896         Add a VisualViewportAPI preference.
1897
1898         * WebView/WebPreferenceKeysPrivate.h:
1899         * WebView/WebPreferences.mm:
1900         (+[WebPreferences initialize]):
1901         (-[WebPreferences visualViewportAPIEnabled]):
1902         (-[WebPreferences setVisualViewportAPIEnabled:]):
1903         * WebView/WebPreferencesPrivate.h:
1904         * WebView/WebView.mm:
1905         (-[WebView _preferencesChanged:]):
1906
1907 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1908
1909         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1910         https://bugs.webkit.org/show_bug.cgi?id=179504
1911
1912         Reviewed by Darin Adler.
1913
1914         * Misc/WebKitNSStringExtras.mm:
1915         * Plugins/Hosted/NetscapePluginHostManager.mm:
1916         * Plugins/WebBasePluginPackage.mm:
1917
1918 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1919
1920         Remove unused TOUCH_ICON_LOADING feature flag
1921         https://bugs.webkit.org/show_bug.cgi?id=179873
1922
1923         Reviewed by Simon Fraser.
1924
1925         * Configurations/FeatureDefines.xcconfig:
1926
1927 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1928
1929         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1930         https://bugs.webkit.org/show_bug.cgi?id=179872
1931
1932         Reviewed by Darin Adler.
1933
1934         * Configurations/FeatureDefines.xcconfig:
1935
1936 2017-11-16  Daniel Bates  <dabates@apple.com>
1937
1938         Add feature define for alternative presentation button element
1939         https://bugs.webkit.org/show_bug.cgi?id=179692
1940         Part of <rdar://problem/34917108>
1941
1942         Reviewed by Andy Estes.
1943
1944         Only enabled on Cocoa platforms by default.
1945
1946         * Configurations/FeatureDefines.xcconfig:
1947
1948 2017-11-14  Nan Wang  <n_wang@apple.com>
1949
1950         AX: AOM: Implement AccessibleNode class and support label and role attributes
1951         https://bugs.webkit.org/show_bug.cgi?id=179494
1952
1953         Reviewed by Ryosuke Niwa.
1954
1955         * WebView/WebPreferenceKeysPrivate.h:
1956         * WebView/WebPreferences.mm:
1957         (+[WebPreferences initialize]):
1958         (-[WebPreferences accessibilityObjectModelEnabled]):
1959         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1960         * WebView/WebPreferencesPrivate.h:
1961         * WebView/WebView.mm:
1962         (-[WebView _preferencesChanged:]):
1963
1964 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1965
1966         Remove Cocoa CFURLConnection loading code
1967         https://bugs.webkit.org/show_bug.cgi?id=179688
1968
1969         Reviewed by Antti Koivisto.
1970
1971         * Misc/WebDownload.mm:
1972         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1973         * Misc/WebDownloadInternal.h:
1974         * Plugins/WebBaseNetscapePluginView.mm:
1975         * WebCoreSupport/WebFrameLoaderClient.mm:
1976         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1977         * WebView/WebView.mm:
1978         (-[WebView scheduleInRunLoop:forMode:]):
1979         (-[WebView unscheduleFromRunLoop:forMode:]):
1980
1981 2017-11-14  Daniel Bates  <dabates@apple.com>
1982
1983         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1984         for feature defines
1985
1986         Following r195498 and r201917 the Visual Studio property files for feature defines have
1987         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1988         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1989         files.
1990
1991         * Configurations/FeatureDefines.xcconfig:
1992
1993 2017-11-14  Jer Noble  <jer.noble@apple.com>
1994
1995         Enable Modern EME tests in DumpRenderTree
1996         https://bugs.webkit.org/show_bug.cgi?id=179544
1997
1998         Reviewed by Alex Christensen.
1999
2000         Add a WebPreferences property to enable the (modern) EME API.
2001
2002         * WebView/WebPreferenceKeysPrivate.h:
2003         * WebView/WebPreferences.mm:
2004         (+[WebPreferences initialize]):
2005         (-[WebPreferences encryptedMediaAPIEnabled]):
2006         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2007         * WebView/WebPreferencesPrivate.h:
2008         * WebView/WebView.mm:
2009         (-[WebView _preferencesChanged:]):
2010
2011 2017-11-14  Antti Koivisto  <antti@apple.com>
2012
2013         Enable display:contents by default
2014         https://bugs.webkit.org/show_bug.cgi?id=179655
2015
2016         Reviewed by Sam Weinig.
2017
2018         * WebView/WebPreferences.mm:
2019         (+[WebPreferences initialize]):
2020
2021 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2022
2023         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2024         https://bugs.webkit.org/show_bug.cgi?id=178751
2025
2026         Reviewed by Brady Eidson.
2027
2028         * WebCoreSupport/WebFrameNetworkingContext.mm:
2029         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2030
2031 2017-11-08  Keith Miller  <keith_miller@apple.com>
2032
2033         Async iteration should only fetch the next method once and add feature flag
2034         https://bugs.webkit.org/show_bug.cgi?id=179451
2035
2036         Reviewed by Geoffrey Garen.
2037
2038         Add feature flag for Async iteration.
2039
2040         * Configurations/FeatureDefines.xcconfig:
2041
2042 2017-11-13  Mark Lam  <mark.lam@apple.com>
2043
2044         Add more overflow check book-keeping for MarkedArgumentBuffer.
2045         https://bugs.webkit.org/show_bug.cgi?id=179634
2046         <rdar://problem/35492517>
2047
2048         Reviewed by Saam Barati.
2049
2050         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2051         (WebKit::NetscapePluginInstanceProxy::invoke):
2052         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2053         (WebKit::NetscapePluginInstanceProxy::construct):
2054
2055 2017-11-12  Darin Adler  <darin@apple.com>
2056
2057         More is<> and downcast<>, less static_cast<>
2058         https://bugs.webkit.org/show_bug.cgi?id=179600
2059
2060         Reviewed by Chris Dumez.
2061
2062         * DOM/DOM.mm:
2063         (kit): Use is/downcast.
2064         * WebCoreSupport/WebEditorClient.mm:
2065         (WebEditorClient::handleKeyboardEvent): Ditto.
2066         (WebEditorClient::handleInputMethodKeydown): Ditto.
2067         * WebView/WebHTMLView.mm:
2068         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2069
2070 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2071
2072         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2073         https://bugs.webkit.org/show_bug.cgi?id=179397
2074
2075         Reviewed by Wenson Hsieh.
2076
2077         * DOM/DOMHTMLInputElement.mm:
2078         (-[DOMHTMLInputElement insertTextSuggestion:]):
2079
2080 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2081
2082         HTMLMediaElement should not use element fullscreen on iOS
2083         https://bugs.webkit.org/show_bug.cgi?id=179418
2084         rdar://problem/35409277
2085
2086         Reviewed by Eric Carlson.
2087
2088         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2089
2090         * Configurations/FeatureDefines.xcconfig:
2091
2092 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2093
2094         Make ResourceLoader::willSendRequestInternal asynchronous
2095         https://bugs.webkit.org/show_bug.cgi?id=179251
2096
2097         Reviewed by Andy Estes.
2098
2099         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2100         (WebKit::HostedNetscapePluginStream::start):
2101         * Plugins/WebNetscapePluginStream.mm:
2102         (WebNetscapePluginStream::start):
2103
2104 2017-11-01  Darin Adler  <darin@apple.com>
2105
2106         Simplify event dispatch code and make it a bit more consistent
2107         https://bugs.webkit.org/show_bug.cgi?id=178991
2108
2109         Reviewed by Chris Dumez.
2110
2111         * DOM/DOMEvent.mm:
2112         (-[DOMEvent srcElement]): Call target instead of srcElement.
2113
2114 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2115
2116         [Touch Bar Web API] Add support for menuitem tag
2117         https://bugs.webkit.org/show_bug.cgi?id=179020
2118
2119         Reviewed by Ryosuke Niwa.
2120
2121         Adds in properties and methods that allow the menuitem runtime feature
2122         to be enabled or disabled.
2123
2124         * WebView/WebPreferenceKeysPrivate.h:
2125         * WebView/WebPreferences.mm:
2126         (-[WebPreferences menuItemElementEnabled]):
2127         (-[WebPreferences setMenuItemElementEnabled:]):
2128         * WebView/WebPreferencesPrivate.h:
2129         * WebView/WebView.mm:
2130         (-[WebView _preferencesChanged:]):
2131
2132 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2133
2134         Use CompletionHandlers for redirects
2135         https://bugs.webkit.org/show_bug.cgi?id=179163
2136
2137         Reviewed by Tim Horton.
2138
2139         * Plugins/Hosted/HostedNetscapePluginStream.h:
2140         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2141         (WebKit::HostedNetscapePluginStream::willSendRequest):
2142         * Plugins/WebNetscapePluginStream.h:
2143         * Plugins/WebNetscapePluginStream.mm:
2144         (WebNetscapePluginStream::willSendRequest):
2145
2146 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2147
2148         Add a FileSystem namespace to FileSystem.cpp
2149         https://bugs.webkit.org/show_bug.cgi?id=179063
2150
2151         Reviewed by Darin Adler.
2152
2153         * Misc/WebNSFileManagerExtras.mm:
2154         * Storage/WebDatabaseProvider.mm:
2155
2156 2017-11-02  Frederic Wang  <fwang@igalia.com>
2157
2158         Add references to bug 179167 in FIXME comments
2159         https://bugs.webkit.org/show_bug.cgi?id=179168
2160
2161         Reviewed by Daniel Bates.
2162
2163         * Configurations/FeatureDefines.xcconfig:
2164
2165 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2166
2167         Implement WKFullscreenWindowController for iOS.
2168         https://bugs.webkit.org/show_bug.cgi?id=178924
2169         rdar://problem/34697120
2170
2171         Reviewed by Simon Fraser.
2172
2173         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2174
2175         * Configurations/FeatureDefines.xcconfig:
2176         * WebView/WebView.mm:
2177         (-[WebView fullScreenPlaceholderView]):
2178
2179 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2180
2181         Clean up some drag and drop feature flags
2182         https://bugs.webkit.org/show_bug.cgi?id=179082
2183
2184         Reviewed by Simon Fraser.
2185
2186         * Configurations/FeatureDefines.xcconfig:
2187
2188 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2189
2190         Make it possible to test rubber-banding in overflow scroll
2191         https://bugs.webkit.org/show_bug.cgi?id=179078
2192
2193         Reviewed by Sam Weinig.
2194
2195         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2196         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2197
2198         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2199         functions, since most callers want clamped.
2200
2201         * DOM/DOMHTML.mm:
2202         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2203
2204 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2205
2206         Fix up some content filtering feature flags
2207         https://bugs.webkit.org/show_bug.cgi?id=179079
2208
2209         Reviewed by Simon Fraser.
2210
2211         * Configurations/FeatureDefines.xcconfig:
2212
2213 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2214
2215         [FrameView::layout cleanup] Move core layout logic to a separate class.
2216         https://bugs.webkit.org/show_bug.cgi?id=178771
2217         <rdar://problem/35166542>
2218
2219         Reviewed by Simon Fraser.
2220
2221         Move layout code out from FrameView to LayoutContext.
2222
2223         * WebView/WebClipView.mm:
2224         (-[WebClipView _immediateScrollToPoint:]):
2225         * WebView/WebFrame.mm:
2226         (-[WebFrame layoutCount]):
2227
2228 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2229
2230         Fix issues with WebView subframe painting
2231         https://bugs.webkit.org/show_bug.cgi?id=178842
2232         rdar://problem/34072253
2233
2234         Reviewed by Daniel Bates.
2235         
2236         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2237         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2238         High Sierra, so match the new signature.
2239
2240         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2241
2242         * WebView/WebHTMLView.mm:
2243         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2244         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2245
2246 2017-10-25  Youenn Fablet  <youenn@apple.com>
2247
2248         Enable ServiceWorker to fetch resources
2249         https://bugs.webkit.org/show_bug.cgi?id=178673
2250
2251         Reviewed by Brady Eidson.
2252
2253         * WebCoreSupport/WebFrameLoaderClient.mm:
2254         (WebFrameLoaderClient::pageID const):
2255         (WebFrameLoaderClient::frameID const):
2256         (WebFrameLoaderClient::sessionID const):
2257
2258         Added implementation to the new getters.
2259         They are noop in the context of WK1.
2260
2261 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2262
2263         Web Inspector: Enable WebKit logging configuration and display
2264         https://bugs.webkit.org/show_bug.cgi?id=177027
2265         <rdar://problem/33964767>
2266
2267         Reviewed by Joseph Pecoraro.
2268
2269         * WebCoreSupport/WebChromeClient.mm:
2270         (stringForMessageSource): Deal with Media and WebRTC message sources.
2271
2272 2017-10-20  Antoine Quint  <graouts@apple.com>
2273
2274         [Web Animations] Provide basic timeline and animation interfaces
2275         https://bugs.webkit.org/show_bug.cgi?id=178526
2276
2277         Reviewed by Dean Jackson.
2278
2279         Remove the WEB_ANIMATIONS compile-time flag.
2280
2281         * Configurations/FeatureDefines.xcconfig:
2282         * WebView/WebPreferences.mm:
2283         (+[WebPreferences initialize]):
2284         * WebView/WebView.mm:
2285         (-[WebView _preferencesChanged:]):
2286
2287 2017-10-19  Sam Weinig  <sam@webkit.org>
2288
2289         [Settings] Move global settings into their own file
2290         https://bugs.webkit.org/show_bug.cgi?id=178512
2291
2292         Reviewed by Darin Adler.
2293
2294         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2295
2296         * WebCoreSupport/WebChromeClient.mm:
2297         (WebChromeClient::supportsVideoFullscreen):
2298         * WebView/WebDynamicScrollBarsView.mm:
2299         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2300         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2301         * WebView/WebPreferences.mm:
2302         (+[WebPreferences initialize]):
2303         * WebView/WebView.mm:
2304         (-[WebView _commonInitializationWithFrameName:groupName:]):
2305         (-[WebView _preferencesChanged:]):
2306         (+[WebView _doNotStartObservingNetworkReachability]):
2307
2308 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2309
2310         Replace some stack raw pointers with RefPtrs within WebCore/html
2311         https://bugs.webkit.org/show_bug.cgi?id=178201
2312         <rdar://problem/34841692>
2313
2314         Reviewed by Ryosuke Niwa.
2315
2316         * DOM/DOM.mm:
2317         (kit):
2318         Change the type of node as toNode() is changed to return RefPtr.
2319
2320 2017-10-18  Chris Dumez  <cdumez@apple.com>
2321
2322         [Service Worker] Add stubs for Client / WindowClient / Clients
2323         https://bugs.webkit.org/show_bug.cgi?id=178469
2324
2325         Reviewed by Youenn Fablet.
2326
2327         Rename PageVisiblityState to VisibilityState.
2328
2329         * WebView/WebView.mm:
2330         (kit):
2331
2332 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2333
2334         Unreviewed, rolling out r223291.
2335
2336         See WebCore ChangeLog for more detail.
2337
2338         Reverted changeset:
2339
2340         "Remove Editor::simplifyMarkup"
2341         https://bugs.webkit.org/show_bug.cgi?id=178271
2342         https://trac.webkit.org/changeset/223291
2343
2344 2017-10-17  Keith Miller  <keith_miller@apple.com>
2345
2346         Change WebCore sources to work with unified source builds
2347         https://bugs.webkit.org/show_bug.cgi?id=178229
2348
2349         Rubber stamped by Tim Horton.
2350
2351         * Configurations/FeatureDefines.xcconfig:
2352
2353 2017-10-16  Sam Weinig  <sam@webkit.org>
2354
2355         [Settings] Remove all custom code from Settings.h/cpp
2356         https://bugs.webkit.org/show_bug.cgi?id=178330
2357
2358         Reviewed by Simon Fraser.
2359
2360         * WebView/WebPreferences.mm:
2361         (+[WebPreferences initialize]):
2362         
2363             Update for naming changes of FrameFlattening now that it is an enum class.
2364
2365 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2366
2367         Remove Editor::simplifyMarkup
2368         https://bugs.webkit.org/show_bug.cgi?id=178271
2369
2370         Reviewed by Wenson Hsieh.
2371
2372         * WebView/WebView.mm:
2373         (-[WebView _simplifyMarkup:endNode:]):
2374
2375 2017-10-12  Chris Dumez  <cdumez@apple.com>
2376
2377         [Mac] Add support for MouseEvent.buttons
2378         https://bugs.webkit.org/show_bug.cgi?id=178214
2379
2380         Reviewed by Ryosuke Niwa.
2381
2382         * WebView/WebPDFView.mm:
2383         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2384
2385 2017-10-11  Sam Weinig  <sam@webkit.org>
2386
2387         Remove out-parameter variants of copyToVector
2388         https://bugs.webkit.org/show_bug.cgi?id=178155
2389
2390         Reviewed by Tim Horton.
2391
2392         * Plugins/WebNetscapePluginView.mm:
2393         (-[WebNetscapePluginView destroyPlugin]):
2394         * WebView/WebHTMLRepresentation.mm:
2395         (newArrayWithStrings):
2396
2397             Replace out-parameter based copyToVector, with one that returns a Vector.
2398
2399 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2400
2401         Sanitize URL in pasteboard for other applications and cross origin content
2402         https://bugs.webkit.org/show_bug.cgi?id=178060
2403         <rdar://problem/34874518>
2404
2405         Reviewed by Wenson Hsieh.
2406
2407         * WebCoreSupport/WebPlatformStrategies.h:
2408         * WebCoreSupport/WebPlatformStrategies.mm:
2409         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2410
2411 2017-10-11  Chris Dumez  <cdumez@apple.com>
2412
2413         Modernize Geolocation code
2414         https://bugs.webkit.org/show_bug.cgi?id=178148
2415
2416         Reviewed by Ryosuke Niwa.
2417
2418         * WebCoreSupport/WebGeolocationClient.h:
2419         * WebCoreSupport/WebGeolocationClient.mm:
2420         (WebGeolocationClient::lastPosition):
2421         * WebView/WebGeolocationPosition.mm:
2422         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2423         (core):
2424         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2425         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2426         * WebView/WebGeolocationPositionInternal.h:
2427
2428 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2429
2430         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2431         https://bugs.webkit.org/show_bug.cgi?id=178154
2432
2433         Reviewed by Wenson Hsieh.
2434
2435         Enable custom pasteboard data by default.
2436
2437         * WebView/WebPreferenceKeysPrivate.h:
2438         * WebView/WebPreferences.mm:
2439         (+[WebPreferences initialize]):
2440         (-[WebPreferences customPasteboardDataEnabled]): Added.
2441         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2442         * WebView/WebPreferencesPrivate.h:
2443         * WebView/WebView.mm:
2444         (-[WebView _preferencesChanged:]):
2445
2446 2017-10-10  Sam Weinig  <sam@webkit.org>
2447
2448         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2449         https://bugs.webkit.org/show_bug.cgi?id=178102
2450
2451         Reviewed by Tim Horton.
2452
2453         * History/WebHistory.mm:
2454         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2455         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2456         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2457         * WebCoreSupport/WebUserMediaClient.mm:
2458         (WebUserMediaClient::pageDestroyed):
2459
2460 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2461
2462         Make the names of the options consistent
2463         https://bugs.webkit.org/show_bug.cgi?id=177933
2464
2465         Reviewed by Saam Barati.
2466
2467         * WebView/WebFrame.h:
2468         * WebView/WebHTMLView.mm:
2469         (-[WebHTMLView setMarkedText:selectedRange:]):
2470         * WebView/WebView.h:
2471
2472 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2473
2474         [iOS] Tweak support for classifying form controls (followup to r222487)
2475         https://bugs.webkit.org/show_bug.cgi?id=177917
2476         <rdar://problem/34820122>
2477
2478         Reviewed by Dean Jackson.
2479
2480         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2481
2482         * DOM/DOMHTMLInputElement.mm:
2483         (-[DOMHTMLInputElement _autofillContext]):
2484         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2485         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2486
2487 2017-10-05  Keith Miller  <keith_miller@apple.com>
2488
2489         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2490
2491         * Configurations/WebKitLegacy.xcconfig:
2492
2493 2017-10-05  Jer Noble  <jer.noble@apple.com>
2494
2495         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2496         https://bugs.webkit.org/show_bug.cgi?id=177261
2497
2498         Reviewed by Eric Carlson.
2499
2500         * Configurations/FeatureDefines.xcconfig:
2501
2502 2017-10-05  Chris Dumez  <cdumez@apple.com>
2503
2504         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2505         https://bugs.webkit.org/show_bug.cgi?id=177957
2506
2507         Reviewed by Alex Christensen.
2508
2509         * WebCoreSupport/WebPlatformStrategies.h:
2510         * WebCoreSupport/WebPlatformStrategies.mm:
2511         (WebPlatformStrategies::cookiesEnabled):
2512
2513 2017-10-05  Youenn Fablet  <youenn@apple.com>
2514
2515         Make LibWebRTCProvider port agnostic
2516         https://bugs.webkit.org/show_bug.cgi?id=177747
2517
2518         Reviewed by Alex Christensen & Alex Garcia.
2519
2520         * WebView/WebView.mm:
2521         (-[WebView _commonInitializationWithFrameName:groupName:]):
2522         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2523
2524 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2525
2526         Stop linking with WebKitSystemInterface
2527         https://bugs.webkit.org/show_bug.cgi?id=177915
2528
2529         Reviewed by Antti Koivisto.
2530
2531         * Configurations/DebugRelease.xcconfig:
2532         * Configurations/WebKitLegacy.xcconfig:
2533
2534 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2535
2536         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2537         https://bugs.webkit.org/show_bug.cgi?id=177912
2538
2539         Reviewed by Saam Barati.
2540
2541         * Carbon/CarbonUtils.m:
2542         * Carbon/CarbonWindowAdapter.mm:
2543         * Carbon/HIWebView.mm:
2544         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2545         * Misc/WebNSFileManagerExtras.mm:
2546         * Misc/WebNSPasteboardExtras.mm:
2547         * Misc/WebNSURLExtras.mm:
2548         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2549         * Plugins/Hosted/NetscapePluginHostManager.mm:
2550         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2551         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2552         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2553         * Plugins/Hosted/WebTextInputWindowController.m:
2554         * Plugins/WebBaseNetscapePluginView.mm:
2555         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2556         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2557         * Plugins/WebNetscapePluginStream.mm:
2558         * Plugins/WebNetscapePluginView.mm:
2559         * Plugins/WebPluginDatabase.mm:
2560         * WebCoreSupport/PopupMenuMac.mm:
2561         * WebCoreSupport/WebChromeClient.mm:
2562         * WebCoreSupport/WebFrameLoaderClient.mm:
2563         * WebCoreSupport/WebInspectorClient.mm:
2564         * WebCoreSupport/WebPlatformStrategies.mm:
2565         * WebCoreSupport/WebSystemInterface.mm:
2566         * WebView/WebDynamicScrollBarsView.mm:
2567         * WebView/WebFrame.mm:
2568         * WebView/WebFrameView.mm:
2569         * WebView/WebFullScreenController.mm:
2570         * WebView/WebHTMLView.mm:
2571         * WebView/WebPreferences.mm:
2572         * WebView/WebView.mm:
2573
2574 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2575
2576         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2577         rdar://problem/34705779
2578
2579         Addressing review comments that I somehow landed without.
2580
2581         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2582
2583 2017-09-29  Chris Dumez  <cdumez@apple.com>
2584
2585         Split some logic out of VisitedLinkStore and make it reusable
2586         https://bugs.webkit.org/show_bug.cgi?id=177575
2587
2588         Reviewed by Alex Christensen.
2589
2590         * WebCoreSupport/WebVisitedLinkStore.h:
2591         * WebCoreSupport/WebVisitedLinkStore.mm:
2592         (WebVisitedLinkStore::addVisitedLink):
2593         (WebVisitedLinkStore::removeVisitedLink):
2594         (WebVisitedLinkStore::isLinkVisited):
2595         (WebVisitedLinkStore::addVisitedLinkHash):
2596
2597 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2598
2599         Build fix for High Sierra 32 bit Mac
2600         https://bugs.webkit.org/show_bug.cgi?id=177551
2601         <rdar://problem/34690283>
2602
2603         Reviewed by Alexey Proskuryakov.
2604
2605         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2606         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2607         also made.
2608
2609         * Carbon/CarbonWindowAdapter.mm:
2610         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2611         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2612         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2613         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2614         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2615         (-[CarbonWindowAdapter dealloc]):
2616         (-[CarbonWindowAdapter windowRef]):
2617         (-[CarbonWindowAdapter _hasWindowRef]):
2618         (-[CarbonWindowAdapter _managesWindowRef]):
2619         (-[CarbonWindowAdapter _removeWindowRef]):
2620         (-[CarbonWindowAdapter _carbonWindowClass]):
2621         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2622         (-[CarbonWindowAdapter sendSuperEvent:]):
2623         (-[CarbonWindowAdapter relinquishFocus]):
2624         (-[CarbonWindowAdapter _cancelKey:]):
2625         (-[CarbonWindowAdapter _commonAwake]):
2626         (-[CarbonWindowAdapter _destroyRealWindow:]):
2627         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2628         (-[CarbonWindowAdapter _termWindowIfOwner]):
2629         (-[CarbonWindowAdapter _windowMovedToRect:]):
2630         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2631         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2632         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2633         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2634         (-[CarbonWindowAdapter canBecomeMainWindow]):
2635         (-[CarbonWindowAdapter encodeWithCoder:]):
2636         (-[CarbonWindowAdapter initWithCoder:]):
2637         (-[CarbonWindowAdapter setContentView:]):
2638         (-[CarbonWindowAdapter worksWhenModal]):
2639         (-[CarbonWindowAdapter _setModalWindowLevel]):
2640         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2641         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2642         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2643         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2644         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2645         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2646         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2647         (NSCarbonWindowHandleEvent):
2648         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2649         (-[CarbonWindowAdapter _growBoxRect]):
2650         * Carbon/HIWebView.mm:
2651         (HIWebViewGetWebView):
2652         (HIWebViewConstructor):
2653         (HIWebViewDestructor):
2654         (HIWebViewRegisterClass):
2655         (GetBehaviors):
2656         (Draw):
2657         (HitTest):
2658         (GetRegion):
2659         (GetWindowRef):
2660         (CreateNSEventAdoptingCGEvent):
2661         (CopyEventCGEvent):
2662         (CreateNSEventWithCarbonClickEvent):
2663         (Click):
2664         (CreateNSEventWithCarbonEvent):
2665         (MouseUp):
2666         (CreateNSEventWithCarbonMouseMoveEvent):
2667         (MouseMoved):
2668         (MouseDragged):
2669         (MouseWheelMoved):
2670         (ContextMenuClick):
2671         (GetKind):
2672         (BoundsChanged):
2673         (OwningWindowChanged):
2674         (WindowHandler):
2675         (SyncFrame):
2676         (SetFocusPart):
2677         (AdvanceFocus):
2678         (RelinquishFocus):
2679         (ActiveStateChanged):
2680         (ProcessCommand):
2681         (UpdateCommandStatus):
2682         (_NSSelectorForHICommand):
2683         (HIWebViewEventHandler):
2684         (StartUpdateObserver):
2685         (StopUpdateObserver):
2686         (UpdateObserver):
2687
2688 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2689
2690         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2691         https://bugs.webkit.org/show_bug.cgi?id=172526
2692         <rdar://problem/32396081>
2693
2694         Reviewed by Ryosuke Niwa.
2695
2696         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2697
2698         * WebCoreSupport/WebPlatformStrategies.h:
2699         * WebCoreSupport/WebPlatformStrategies.mm:
2700         (WebPlatformStrategies::webExposedTypes):
2701         (WebPlatformStrategies::writeCustomData):
2702
2703 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2704
2705         Unreviewed, rolling out r222567.
2706
2707         This broke and internal build.
2708
2709         Reverted changeset:
2710
2711         "Build fix for High Sierra 32 bit Mac"
2712         https://bugs.webkit.org/show_bug.cgi?id=177551
2713         http://trac.webkit.org/changeset/222567
2714
2715 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2716
2717         Build fix for High Sierra 32 bit Mac
2718         https://bugs.webkit.org/show_bug.cgi?id=177551
2719         <rdar://problem/34690283>
2720
2721         Reviewed by Alexey Proskuryakov.
2722
2723         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2724         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2725         also made.
2726
2727         * Carbon/CarbonWindowAdapter.mm:
2728         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2729         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2730         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2731         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2732         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2733         (-[CarbonWindowAdapter dealloc]):
2734         (-[CarbonWindowAdapter windowRef]):
2735         (-[CarbonWindowAdapter _hasWindowRef]):
2736         (-[CarbonWindowAdapter _managesWindowRef]):
2737         (-[CarbonWindowAdapter _removeWindowRef]):
2738         (-[CarbonWindowAdapter _carbonWindowClass]):
2739         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2740         (-[CarbonWindowAdapter sendSuperEvent:]):
2741         (-[CarbonWindowAdapter relinquishFocus]):
2742         (-[CarbonWindowAdapter _cancelKey:]):
2743         (-[CarbonWindowAdapter _commonAwake]):
2744         (-[CarbonWindowAdapter _destroyRealWindow:]):
2745         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2746         (-[CarbonWindowAdapter _termWindowIfOwner]):
2747         (-[CarbonWindowAdapter _windowMovedToRect:]):
2748         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2749         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2750         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2751         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2752         (-[CarbonWindowAdapter canBecomeMainWindow]):
2753         (-[CarbonWindowAdapter encodeWithCoder:]):
2754         (-[CarbonWindowAdapter initWithCoder:]):
2755         (-[CarbonWindowAdapter setContentView:]):
2756         (-[CarbonWindowAdapter worksWhenModal]):
2757         (-[CarbonWindowAdapter _setModalWindowLevel]):
2758         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2759         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2760         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2761         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2762         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2763         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2764         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2765         (NSCarbonWindowHandleEvent):
2766         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2767         (-[CarbonWindowAdapter _growBoxRect]):
2768         * Carbon/HIWebView.mm:
2769         (HIWebViewGetWebView):
2770         (HIWebViewConstructor):
2771         (HIWebViewDestructor):
2772         (HIWebViewRegisterClass):
2773         (GetBehaviors):
2774         (Draw):
2775         (HitTest):
2776         (GetRegion):
2777         (GetWindowRef):
2778         (CreateNSEventAdoptingCGEvent):
2779         (CopyEventCGEvent):
2780         (CreateNSEventWithCarbonClickEvent):
2781         (Click):
2782         (CreateNSEventWithCarbonEvent):
2783         (MouseUp):
2784         (CreateNSEventWithCarbonMouseMoveEvent):
2785         (MouseMoved):
2786         (MouseDragged):
2787         (MouseWheelMoved):
2788         (ContextMenuClick):
2789         (GetKind):
2790         (BoundsChanged):
2791         (OwningWindowChanged):
2792         (WindowHandler):
2793         (SyncFrame):
2794         (SetFocusPart):
2795         (AdvanceFocus):
2796         (RelinquishFocus):
2797         (ActiveStateChanged):
2798         (ProcessCommand):
2799         (UpdateCommandStatus):
2800         (_NSSelectorForHICommand):
2801         (HIWebViewEventHandler):
2802         (StartUpdateObserver):
2803         (StopUpdateObserver):
2804         (UpdateObserver):
2805
2806 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2807
2808         Make PolicyAction an encodable enum class
2809         https://bugs.webkit.org/show_bug.cgi?id=177480
2810
2811         Reviewed by Antti Koivisto.
2812
2813         * Plugins/WebPluginContainerCheck.mm:
2814         (-[WebPluginContainerCheck _continueWithPolicy:]):
2815         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2816         * WebCoreSupport/WebFrameLoaderClient.mm:
2817         (-[WebFramePolicyListener invalidate]):
2818         (-[WebFramePolicyListener ignore]):
2819         (-[WebFramePolicyListener download]):
2820         (-[WebFramePolicyListener use]):
2821         (-[WebFramePolicyListener continue]):
2822         * WebView/WebPolicyDelegate.mm:
2823         (-[WebPolicyDecisionListener use]):
2824         (-[WebPolicyDecisionListener ignore]):
2825         (-[WebPolicyDecisionListener download]):
2826
2827 2017-09-25  Frederik Riedel  <riedel@apple.com>
2828
2829         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2830         https://bugs.webkit.org/show_bug.cgi?id=174394
2831         <rdar://problem/33183504>
2832
2833         Reviewed by Ryosuke Niwa.
2834
2835         * DOM/DOMHTMLInputElement.h:
2836         * DOM/DOMHTMLInputElement.mm:
2837         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2838         Determines if this HTMLInputElement is part of a login screen.
2839         (-[DOMHTMLInputElement representingPageUrl]):
2840         Returns the webpage's URL that is currently displayed in the Web View.
2841         (-[DOMHTMLInputElement insertTextSuggestion:]):
2842         Inserts login credentials into the Web View.
2843
2844 2017-09-25  Sam Weinig  <sam@webkit.org>
2845
2846         Remove unused EditorClient functions
2847         https://bugs.webkit.org/show_bug.cgi?id=177463
2848
2849         Reviewed by Alex Christensen.
2850
2851         Remove unused EditorClient functions.
2852
2853         * WebCoreSupport/WebEditorClient.h:
2854         * WebCoreSupport/WebEditorClient.mm:
2855         (WebEditorClient::canonicalizeURL): Deleted.
2856         (WebEditorClient::canonicalizeURLString): Deleted.
2857         (WebEditorClient::writeDataToPasteboard): Deleted.
2858         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2859         (WebEditorClient::readDataFromPasteboard): Deleted.
2860         (WebEditorClient::pasteboardChangeCount): Deleted.
2861
2862 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2863
2864         Stop using PolicyCallback
2865         https://bugs.webkit.org/show_bug.cgi?id=176088
2866
2867         Reviewed by Andy Estes.
2868
2869         * WebCoreSupport/WebFrameLoaderClient.mm:
2870         (-[WebFramePolicyListener invalidate]):
2871         (-[WebFramePolicyListener receivedPolicyDecision:]):
2872
2873 2017-09-25  Sam Weinig  <sam@webkit.org>
2874
2875         Remove unnecessary userVisibleString EditorClient function
2876         https://bugs.webkit.org/show_bug.cgi?id=177456
2877
2878         Reviewed by Dan Bernstein.
2879
2880         * WebCoreSupport/WebEditorClient.h:
2881         * WebCoreSupport/WebEditorClient.mm:
2882         (WebEditorClient::userVisibleString): Deleted.
2883
2884             Remove userVisibleString client function.
2885
2886 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2887
2888         Separate form submission from PolicyChecker infrastructure
2889         https://bugs.webkit.org/show_bug.cgi?id=177396
2890
2891         Reviewed by Geoffrey Garen.
2892
2893         * WebCoreSupport/WebFrameLoaderClient.h:
2894         * WebCoreSupport/WebFrameLoaderClient.mm:
2895         (WebFrameLoaderClient::dispatchWillSubmitForm):
2896
2897 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2898
2899         WeakPtrFactory should populate m_ref lazily.
2900         https://bugs.webkit.org/show_bug.cgi?id=177375
2901
2902         Reviewed by Geoffrey Garen.
2903
2904         * WebCoreSupport/WebEditorClient.mm:
2905         (WebEditorClient::WebEditorClient):
2906         (WebEditorClient::requestCandidatesForSelection):
2907
2908 2017-09-22  Chris Dumez  <cdumez@apple.com>
2909
2910         Use high resolution timestamp for event time
2911         https://bugs.webkit.org/show_bug.cgi?id=154246
2912         <rdar://problem/34333304>
2913
2914         Reviewed by Ryosuke Niwa.
2915
2916         Use WallTime / MonotonicTime instead of double type for clarity.
2917
2918         * DOM/DOMEvent.mm:
2919         (-[DOMEvent timeStamp]):
2920         * WebView/WebFrame.mm:
2921         (-[WebFrame _dragSourceEndedAt:operation:]):
2922         * WebView/WebPDFView.mm:
2923         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2924
2925 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2926
2927         Enable dataTransfer.items on macOS and iOS
2928         https://bugs.webkit.org/show_bug.cgi?id=177335
2929
2930         Reviewed by Sam Weinig.
2931
2932         * WebView/WebPreferences.mm:
2933         (+[WebPreferences initialize]):
2934
2935 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2936
2937         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2938         https://bugs.webkit.org/show_bug.cgi?id=177101
2939         <rdar://problem/34500648>
2940
2941         Reviewed by Brian Burg.
2942
2943         * WebInspector/WebNodeHighlight.mm:
2944         Ensure we close the window that we have just removed.
2945
2946 2017-09-20  Antti Koivisto  <antti@apple.com>
2947
2948         Remove DOM and styling support for CSS Regions
2949         https://bugs.webkit.org/show_bug.cgi?id=177221
2950
2951         Reviewed by Andreas Kling.
2952
2953         * Configurations/FeatureDefines.xcconfig:
2954         * DOM/DOMCSS.mm:
2955         (kitClass):
2956         * DOM/DOMElement.mm:
2957         (-[DOMElement webkitRegionOverset]): Deleted.
2958
2959 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2960
2961         Layering violation in Editor::createFragment
2962         https://bugs.webkit.org/show_bug.cgi?id=176123
2963
2964         Reviewed by Darin Adler.
2965
2966         * Misc/WebNSURLExtras.h:
2967         * Misc/WebNSURLExtras.mm:
2968         * WebView/WebFrame.mm:
2969         * WebView/WebHTMLView.mm:
2970         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2971
2972         * WebCoreSupport/WebEditorClient.mm:
2973         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2974         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2975         way to avoid exporting the symbol just on newer OSes.
2976
2977 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2978
2979         On iOS, getData can't get text set by setData during copy event
2980         https://bugs.webkit.org/show_bug.cgi?id=176980
2981         <rdar://problem/34453915>
2982
2983         Reviewed by Darin Adler.
2984
2985         * WebCoreSupport/WebPlatformStrategies.h:
2986         * WebCoreSupport/WebPlatformStrategies.mm:
2987         (WebPlatformStrategies::copy): Deleted.
2988
2989 2017-09-18  Andy Estes  <aestes@apple.com>
2990
2991         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2992         https://bugs.webkit.org/show_bug.cgi?id=177029
2993
2994         Reviewed by Alex Christensen.
2995
2996         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2997         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2998         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2999         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3000         * WebCoreSupport/PopupMenuMac.mm:
3001         (PopupMenuMac::show):
3002         * WebCoreSupport/WebSystemInterface.mm:
3003         (InitWebCoreSystemInterface):
3004         * WebView/WebHTMLView.mm:
3005         (-[WebHTMLView setDataSource:]):
3006         (-[WebHTMLView attachRootLayer:]):
3007         * WebView/WebView.mm:
3008         (-[WebView _needsAdobeFrameReloadingQuirk]):
3009         (-[WebView _needsLinkElementTextCSSQuirk]):
3010         (-[WebView _needsIsLoadingInAPISenseQuirk]):
3011         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
3012         (-[WebView _preferencesChanged:]):
3013
3014 2017-09-15  Andy Estes  <aestes@apple.com>
3015
3016         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
3017         https://bugs.webkit.org/show_bug.cgi?id=176953
3018
3019         Reviewed by Eric Carlson.
3020
3021         * WebCoreSupport/WebSystemInterface.mm:
3022         (InitWebCoreSystemInterface):
3023
3024 2017-09-14  Andy Estes  <aestes@apple.com>
3025
3026         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
3027         https://bugs.webkit.org/show_bug.cgi?id=176931
3028
3029         Reviewed by Joseph Pecoraro.
3030
3031         * WebCoreSupport/WebSystemInterface.mm:
3032         (InitWebCoreSystemInterface):
3033
3034 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3035
3036         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
3037         https://bugs.webkit.org/show_bug.cgi?id=176867
3038
3039         Reviewed by Sam Weinig.
3040
3041         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3042         (WebKit::NetscapePluginInstanceProxy::enumerate):
3043
3044 2017-09-13  Andy Estes  <aestes@apple.com>
3045
3046         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
3047         https://bugs.webkit.org/show_bug.cgi?id=176729
3048
3049         Reviewed by Alex Christensen.
3050
3051         * WebCoreSupport/WebSystemInterface.mm:
3052         (InitWebCoreSystemInterface):
3053         * WebView/WebView.mm:
3054         (+[WebView _setCacheModel:]):
3055
3056 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3057
3058         Refactor WebContentReader out of EditorMac and EditorIOS
3059         https://bugs.webkit.org/show_bug.cgi?id=176770
3060
3061         Reviewed by Sam Weinig.
3062
3063         * WebCoreSupport/WebEditorClient.mm:
3064
3065 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3066
3067         Dragging & dropping a file creates an attachment element even when it's disabled
3068         https://bugs.webkit.org/show_bug.cgi?id=176769
3069
3070         Reviewed by Tim Horton.
3071
3072         * WebView/WebView.mm:
3073         (-[WebView _preferencesChanged:]):
3074
3075 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3076
3077         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3078         https://bugs.webkit.org/show_bug.cgi?id=176721
3079         <rdar://problem/34373660>
3080
3081         Reviewed by Tim Horton.
3082
3083         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3084         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3085
3086         * WebView/WebView.mm:
3087         (-[WebView _startDrag:]):
3088         (-[WebView _draggedElementBounds]):
3089         (-[WebView _endedDataInteraction:global:]):
3090         * WebView/WebViewData.h:
3091
3092 2017-09-11  Andy Estes  <aestes@apple.com>
3093
3094         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3095         https://bugs.webkit.org/show_bug.cgi?id=176472
3096
3097         Reviewed by Eric Carlson.
3098
3099         * WebCoreSupport/WebSystemInterface.mm:
3100         (InitWebCoreSystemInterface):
3101
3102 2017-09-09  Mark Lam  <mark.lam@apple.com>
3103
3104         Avoid duplicate computations of ExecState::vm().
3105         https://bugs.webkit.org/show_bug.cgi?id=176647
3106
3107         Reviewed by Saam Barati.
3108
3109         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3110         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3111         (WebKit::NetscapePluginInstanceProxy::construct):
3112         (WebKit::NetscapePluginInstanceProxy::setProperty):
3113         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3114         (WebKit::NetscapePluginInstanceProxy::enumerate):
3115         * Plugins/Hosted/ProxyInstance.mm:
3116         (WebKit::ProxyRuntimeMethod::create):
3117
3118 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3119
3120         Unreviewed, rolling out r221773.
3121         https://bugs.webkit.org/show_bug.cgi?id=176614
3122
3123         This caused build failures. (Requested by mlewis13 on
3124         #webkit).
3125
3126         Reverted changeset:
3127
3128         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3129         https://bugs.webkit.org/show_bug.cgi?id=176472
3130         http://trac.webkit.org/changeset/221773
3131
3132 2017-09-07  Andy Estes  <aestes@apple.com>
3133
3134         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3135         https://bugs.webkit.org/show_bug.cgi?id=176472
3136
3137         Reviewed by Eric Carlson.
3138
3139         * WebCoreSupport/WebSystemInterface.mm:
3140         (InitWebCoreSystemInterface):
3141
3142 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3143
3144         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3145         https://bugs.webkit.org/show_bug.cgi?id=176561
3146
3147         Reviewed by Brent Fulgham.
3148
3149         * Misc/WebNSUserDefaultsExtras.mm:
3150
3151 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3152
3153         Modernize Geolocation code
3154         https://bugs.webkit.org/show_bug.cgi?id=176496
3155
3156         Reviewed by Andy Estes.
3157
3158         * WebCoreSupport/WebGeolocationClient.h:
3159         * WebCoreSupport/WebGeolocationClient.mm:
3160         (WebGeolocationClient::requestPermission):
3161         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3162         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3163         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3164         * WebView/WebView.mm:
3165         (-[WebView _commonInitializationWithFrameName:groupName:]):
3166         (-[WebView _geolocationDidFailWithMessage:]):
3167
3168 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3169
3170         Remove some unused bits of code and resources
3171         https://bugs.webkit.org/show_bug.cgi?id=176275
3172
3173         Reviewed by Dan Bernstein.
3174
3175         * Misc/WebNSFileManagerExtras.mm:
3176         Include FileSystem instead of FileSystemIOS.
3177
3178 2017-09-03  Darin Adler  <darin@apple.com>
3179
3180         [Cocoa] Tidy a few things in legacy WebHTMLView
3181         https://bugs.webkit.org/show_bug.cgi?id=176280
3182
3183         Reviewed by Dan Bernstein.
3184
3185         * WebCoreSupport/WebChromeClient.mm:
3186         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3187         methods it calls on WebHTMLView were doing nothing on iOS.
3188
3189         * WebView/WebFrame.mm:
3190         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3191         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3192
3193         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3194         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3195         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3196         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3197         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3198         Use RetainPtr instead of writing retain/release wherever possible.
3199         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3200         initialization for it. Removed various unused methods and declarations of methods.
3201         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3202         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3203         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3204         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3205         and remove CFRetain no longer needed since we don't support garbage collection any more.
3206         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3207         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3208         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3209         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3210         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3211         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3212         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3213         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3214         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3215         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3216         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3217         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3218         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3219         debug flag; we haven't used it for years and it's not clearly helpful.
3220         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3221         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3222         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3223         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3224         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3225         two additional methods in the WebPrivate category and still be called by the two
3226         methods in the WebInternal category that were already using it.
3227         (-[WebHTMLView didAddSubview:]): Deleted.
3228         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3229         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3230         place this was called, the close method.
3231         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3232         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3233         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3234         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3235         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3236         Added helper method to make the one below simpler.
3237         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3238         Compared pasteboard type strings using isEqualToString: rather than using == since
3239         we want to actually compare the string contents. Also updated to use modern for loop,
3240         renamed a local variable from "s" to "localSubresources", and factored out the handling
3241         of three image types to use the helper method above.
3242         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3243         _web_makePluginSubviewsPerformSelector:withObject: method.
3244         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3245         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3246         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3247         not call the -[NSView subviews] method to make this identical on both platforms and used
3248         a modern for loop.
3249         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3250         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3251         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3252         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3253         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3254         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3255         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3256         of it is Mac-only.
3257         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3258         method did was call itself on the main thread, and do nothing if called on main thread.
3259         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3260         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3261         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3262         half of this method.
3263         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3264         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3265         Simplified using a modern for loop and RetainPtr.
3266         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3267         (-[WebHTMLView keyDown:]): Ditto.
3268         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3269         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3270         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3271         (-[WebHTMLView complete:]): Ditto.
3272         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3273         now macOS-only.
3274         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3275         iOS since that is now macOS-only.
3276         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3277         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3278         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3279         and reorganized to use early return.
3280         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3281         on iOS, but kept there so we don't have to do #if at every call site.
3282         (-[WebHTMLView _pluginController]): Moved into internal category.
3283         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3284         there only for GC, using C++ initialization, removing obsolete comment.
3285         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3286         peculiar iOS-only comment.
3287         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3288
3289         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3290         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3291         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3292         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3293         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3294
3295         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3296         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3297         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3298         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3299         them at this time.
3300
3301 2017-09-03  Sam Weinig  <sam@webkit.org>
3302
3303         Remove CanvasProxy
3304         https://bugs.webkit.org/show_bug.cgi?id=176288
3305
3306         Reviewed by Yusuke Suzuki.
3307
3308         CanvasProxy does not appear to be in any current HTML spec
3309         and was disabled and unimplemented in our tree. Time to 
3310         get rid of it.
3311
3312         * Configurations/FeatureDefines.xcconfig:
3313
3314 2017-09-02  Andy Estes  <aestes@apple.com>
3315
3316         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3317         https://bugs.webkit.org/show_bug.cgi?id=176270
3318
3319         Reviewed by Tim Horton.
3320
3321         * Plugins/Hosted/NetscapePluginHostManager.mm:
3322         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3323         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3324         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3325         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3326         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3327         (WebKit::SoftwareCARenderer::context const):
3328         (WebKit::SoftwareCARenderer::renderContext const):
3329         (WebKit::SoftwareCARenderer::render):
3330         (-[WebHostedNetscapePluginView createPlugin]):
3331         (-[WebHostedNetscapePluginView createPluginLayer]):
3332         (-[WebHostedNetscapePluginView destroyPlugin]):
3333         (-[WebHostedNetscapePluginView drawRect:]):
3334         * WebCoreSupport/WebSystemInterface.mm:
3335         (InitWebCoreSystemInterface):
3336
3337 2017-09-01  Andy Estes  <aestes@apple.com>
3338
3339         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3340         https://bugs.webkit.org/show_bug.cgi?id=176200
3341
3342         Reviewed by Tim Horton.
3343
3344         * Carbon/HIWebView.mm:
3345         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3346         (overrideCGContext):
3347         (restoreCGContext):
3348         (Draw):
3349         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3350         (+[WebHostedNetscapePluginView initialize]):
3351         * Plugins/WebBaseNetscapePluginView.h:
3352         * Plugins/WebBaseNetscapePluginView.mm:
3353         (WebKit::sendUserChangeNotifications):
3354         * Plugins/WebNetscapePluginView.mm:
3355         (+[WebNetscapePluginView initialize]):
3356         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3357         * WebCoreSupport/WebSystemInterface.mm:
3358         (InitWebCoreSystemInterface):
3359         * WebView/WebFrame.mm:
3360         (-[WebFrame _paintBehaviorForDestinationContext:]):
3361         * WebView/WebFullScreenController.mm:
3362         (setClipRectForWindow):
3363         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3364         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3365         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3366         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3367
3368 2017-08-31  Andy Estes  <aestes@apple.com>
3369
3370         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3371         https://bugs.webkit.org/show_bug.cgi?id=176175
3372
3373         Reviewed by Brady Eidson.
3374
3375         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3376         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3377         * Plugins/Hosted/WebTextInputWindowController.m:
3378         (-[WebTextInputPanel init]):
3379         * WebCoreSupport/WebSystemInterface.mm:
3380         (InitWebCoreSystemInterface):
3381         * WebView/WebDynamicScrollBarsView.mm:
3382         (-[WebDynamicScrollBarsView scrollWheel:]):
3383         * WebView/WebHTMLView.mm:
3384         (-[WebHTMLView _removeWindowObservers]):
3385         (-[WebHTMLView addWindowObservers]):
3386         * WebView/WebView.mm:
3387         (-[WebView addWindowObserversForWindow:]):
3388         (-[WebView removeWindowObservers]):
3389         (-[WebView viewWillMoveToWindow:]):
3390
3391 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3392
3393         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3394         https://bugs.webkit.org/show_bug.cgi?id=175779
3395         <rdar://problem/22367975>
3396
3397         Reviewed by Tim Horton.
3398
3399         * WebCoreSupport/WebFrameLoaderClient.h:
3400         * WebCoreSupport/WebFrameLoaderClient.mm:
3401         (WebFrameLoaderClient::webGLPolicyForURL const):
3402         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3403
3404 2017-08-30  Andy Estes  <aestes@apple.com>
3405
3406         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3407         https://bugs.webkit.org/show_bug.cgi?id=176093
3408
3409         Reviewed by Eric Carlson.
3410
3411         * WebCoreSupport/WebSystemInterface.mm:
3412         (InitWebCoreSystemInterface):
3413
3414 2017-08-30  Andy Estes  <aestes@apple.com>
3415
3416         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3417         https://bugs.webkit.org/show_bug.cgi?id=176087
3418
3419         Reviewed by Alex Christensen.
3420
3421         * Carbon/CarbonUtils.m:
3422         (getNSAutoreleasePoolCount):
3423         (WebInitForCarbon):
3424         (PoolCleaner):
3425         * Carbon/CarbonWindowAdapter.mm:
3426         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3427         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3428         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3429         (-[CarbonWindowAdapter _windowMovedToRect:]):
3430         * Carbon/HIViewAdapter.m:
3431         * Carbon/HIWebView.mm:
3432         (Draw):
3433         (CreateNSEventAdoptingCGEvent):
3434         (CopyEventCGEvent):
3435         (CreateNSEventWithCarbonClickEvent):
3436         (Click):
3437         (CreateNSEventWithCarbonEvent):
3438         (MouseUp):
3439         (CreateNSEventWithCarbonMouseMoveEvent):
3440         (MouseMoved):
3441         (MouseDragged):
3442         (MouseWheelMoved):
3443         (WindowHandler):
3444         (HIWebViewEventHandler):
3445         * Misc/QuickDrawCompatibility.h: Removed.
3446         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3447         (getCarbonEvent):
3448         (WebNetscapePluginEventHandlerCarbon::keyDown):
3449         (WebNetscapePluginEventHandlerCarbon::keyUp):
3450         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3451         (WebNetscapePluginEventHandlerCocoa::keyDown):
3452         * Plugins/WebNetscapePluginView.mm:
3453         (-[WebNetscapePluginView tellQuickTimeToChill]):
3454
3455 2017-08-29  Andy Estes  <aestes@apple.com>
3456
3457         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3458         https://bugs.webkit.org/show_bug.cgi?id=176046
3459
3460         Reviewed by Alex Christensen.
3461
3462         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3463         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3464
3465         * Misc/WebNSFileManagerExtras.mm:
3466         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3467         (setMetaData): Deleted.
3468         * WebCoreSupport/WebSystemInterface.mm:
3469         (InitWebCoreSystemInterface):
3470
3471 2017-08-28  Andy Estes  <aestes@apple.com>
3472
3473         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3474         https://bugs.webkit.org/show_bug.cgi?id=176039
3475
3476         Reviewed by Alex Christensen.
3477
3478         * WebCoreSupport/WebSystemInterface.mm:
3479         (InitWebCoreSystemInterface):
3480         * WebView/WebPreferences.mm:
3481         (+[WebPreferences _systemCFStringEncoding]):
3482
3483 2017-08-28  Andy Estes  <aestes@apple.com>
3484
3485         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3486         https://bugs.webkit.org/show_bug.cgi?id=176032
3487
3488         Reviewed by Alex Christensen.
3489
3490         * WebCoreSupport/WebSystemInterface.mm:
3491         (InitWebCoreSystemInterface):
3492         * WebView/WebView.mm:
3493         (-[WebView _cachedResponseForURL:]):
3494
3495 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3496
3497         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3498         https://bugs.webkit.org/show_bug.cgi?id=175992
3499         <rdar://problem/34086613>
3500
3501         Reviewed by Daniel Bates.
3502
3503         * WebCoreSupport/WebPlatformStrategies.h:
3504         * WebCoreSupport/WebPlatformStrategies.mm:
3505         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3506         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3507         indicating if secure cookies were accessed.
3508
3509 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3510
3511         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3512         https://bugs.webkit.org/show_bug.cgi?id=170955
3513         <rdar://problem/31697653>
3514
3515         Reviewed by Ryosuke Niwa.
3516
3517         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3518         text is being replaced.
3519
3520         * WebView/WebHTMLView.mm:
3521         (-[WebHTMLView insertText:]):
3522
3523 2017-08-24  Chris Dumez  <cdumez@apple.com>
3524
3525         [Directory Upload] Add basic support for input.webkitdirectory
3526         https://bugs.webkit.org/show_bug.cgi?id=175950
3527         <rdar://problem/33951915>
3528
3529         Reviewed by Geoffrey Garen.
3530
3531         Add private API to toggle Directory Upload support on Mac WebKit1.
3532
3533         * WebView/WebPreferenceKeysPrivate.h:
3534         * WebView/WebPreferences.mm:
3535         (+[WebPreferences initialize]):
3536         (-[WebPreferences setDirectoryUploadEnabled:]):
3537         (-[WebPreferences directoryUploadEnabled]):
3538         * WebView/WebPreferencesPrivate.h:
3539         * WebView/WebView.mm:
3540         (-[WebView _preferencesChanged:]):
3541
3542 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3543
3544         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3545         https://bugs.webkit.org/show_bug.cgi?id=175370
3546         <rdar://problem/33799806>
3547
3548         Reviewed by Ryosuke Niwa.
3549
3550         Adjust WebEditorClient for interface changes.
3551
3552         * WebCoreSupport/WebEditorClient.h:
3553
3554 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3555
3556         Remove ChromeClient::scrollbarsModeDidChange
3557         https://bugs.webkit.org/show_bug.cgi?id=175805
3558
3559         Reviewed by Daniel Bates.
3560
3561         * WebCoreSupport/WebChromeClient.h:
3562
3563 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3564
3565         Remove ChromeClient::hasOpenedPopup
3566         https://bugs.webkit.org/show_bug.cgi?id=175804
3567
3568         Reviewed by Sam Weinig.
3569
3570         * WebCoreSupport/WebChromeClient.h:
3571         * WebCoreSupport/WebChromeClient.mm:
3572         (WebChromeClient::hasOpenedPopup const): Deleted.
3573
3574 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3575
3576         Disable access to secure cookies if an HTTPS site loads mixed content
3577         https://bugs.webkit.org/show_bug.cgi?id=157053
3578         <rdar://problem/11290808>
3579
3580         Reviewed by Dan Bates.
3581
3582         * WebCoreSupport/WebPlatformStrategies.h:
3583         * WebCoreSupport/WebPlatformStrategies.mm:
3584         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3585         indicating whether secure cookies should be included in the response.
3586
3587 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3588
3589         [PAL] Move spi/mac directory into PAL
3590         https://bugs.webkit.org/show_bug.cgi?id=175649
3591
3592         Reviewed by Myles C. Maxfield.
3593
3594         * Misc/WebSharingServicePickerController.h:
3595         * WebCoreSupport/WebContextMenuClient.mm:
3596         * WebCoreSupport/WebEditorClient.mm:
3597         * WebCoreSupport/WebSelectionServiceController.mm:
3598         * WebView/WebHTMLView.mm:
3599         * WebView/WebImmediateActionController.h:
3600         * WebView/WebImmediateActionController.mm:
3601         * WebView/WebView.mm:
3602
3603 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3604
3605         [PAL] Relocate SessionID to root
3606         https://bugs.webkit.org/show_bug.cgi?id=175684
3607
3608         Reviewed by Alex Christensen.
3609
3610         * WebCoreSupport/WebFrameNetworkingContext.mm:
3611
3612 2017-08-17  Andreas Kling  <akling@apple.com>
3613
3614         Disable CSS regions at compile time
3615         https://bugs.webkit.org/show_bug.cgi?id=175630
3616
3617         Reviewed by Antti Koivisto.
3618
3619         * Configurations/FeatureDefines.xcconfig:
3620
3621 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3622
3623         [PAL] Move SessionID into PAL
3624         https://bugs.webkit.org/show_bug.cgi?id=174192
3625
3626         Reviewed by Antti Koivisto.
3627
3628         * Misc/WebCache.mm:
3629         (+[WebCache imageForURL:]):
3630         * WebCoreSupport/WebFrameLoaderClient.h:
3631         * WebCoreSupport/WebFrameLoaderClient.mm:
3632         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3633         * WebCoreSupport/WebFrameNetworkingContext.mm:
3634         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3635         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3636         (WebFrameNetworkingContext::storageSession const):
3637         * WebCoreSupport/WebPlatformStrategies.h:
3638         * WebCoreSupport/WebPlatformStrategies.mm:
3639         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3640         * WebKitPrefix.h:
3641
3642 2017-08-16  Andy Estes  <aestes@apple.com>
3643
3644         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3645         https://bugs.webkit.org/show_bug.cgi?id=175648
3646
3647         Reviewed by Tim Horton.
3648
3649         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3650         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3651         (WebPaymentCoordinatorClient::showPaymentUI):
3652
3653 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3654
3655         [PAL] Move spi/ios and spi/win directories into PAL
3656         https://bugs.webkit.org/show_bug.cgi?id=175171
3657
3658         Reviewed by Antti Koivisto.
3659
3660         * WebCoreSupport/WebFrameLoaderClient.mm:
3661         * WebView/WebView.mm:
3662
3663 2017-08-16  Andy Estes  <aestes@apple.com>
3664
3665         [Payment Request] Add an ENABLE flag and an experimental feature preference
3666         https://bugs.webkit.org/show_bug.cgi?id=175622
3667
3668         Reviewed by Tim Horton.
3669
3670         * Configurations/FeatureDefines.xcconfig:
3671
3672 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3673
3674         [PAL] Move Sleep classes into PAL
3675         https://bugs.webkit.org/show_bug.cgi?id=175456
3676
3677         Reviewed by Ryosuke Niwa.
3678
3679         * WebView/WebFullScreenController.h:
3680
3681 2017-08-15  Youenn Fablet  <youenn@apple.com>
3682
3683         [Cache API] Adding generic support for CacheStorage and Cache methods
3684         https://bugs.webkit.org/show_bug.cgi?id=175455
3685
3686         Reviewed by Chris Dumez.
3687
3688         * WebView/WebView.mm:
3689         (-[WebView _commonInitializationWithFrameName:groupName:]):
3690
3691 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3692
3693         Remove Proximity Events and related code
3694         https://bugs.webkit.org/show_bug.cgi?id=175545
3695
3696         Reviewed by Daniel Bates.
3697
3698         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3699         and other related code.
3700
3701         * Configurations/FeatureDefines.xcconfig:
3702
3703 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3704
3705         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3706         https://bugs.webkit.org/show_bug.cgi?id=175504
3707
3708         Reviewed by Sam Weinig.
3709
3710         * Configurations/FeatureDefines.xcconfig:
3711         * DOM/DOMHTMLFormElement.mm:
3712         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3713         * WebCoreSupport/WebFrameLoaderClient.h:
3714
3715 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3716
3717         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3718         https://bugs.webkit.org/show_bug.cgi?id=175557
3719
3720         Reviewed by Jon Lee.
3721
3722         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3723
3724         * Configurations/FeatureDefines.xcconfig:
3725
3726 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3727
3728         Composition underline color is always black
3729         https://bugs.webkit.org/show_bug.cgi?id=174675
3730
3731         Reviewed by Ryosuke Niwa.
3732
3733         * WebView/WebHTMLView.mm:
3734         (extractUnderlines): If NSUnderlineColorAttributeName
3735         is not present use text color for composition underline.
3736         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3737         for composition underline in the plain text case.
3738
3739 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3740
3741         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3742         https://bugs.webkit.org/show_bug.cgi?id=175474
3743         <rdar://problem/33844628>
3744
3745         Reviewed by Wenson Hsieh.
3746
3747         Replaced the build flag by a runtime flag and disabled the feature by default.
3748
3749         * Configurations/FeatureDefines.xcconfig:
3750         * WebView/WebPreferenceKeysPrivate.h:
3751         * WebView/WebPreferences.mm:
3752         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3753         (-[WebPreferences dataTransferItemsEnabled]): Added.
3754         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3755         * WebView/WebPreferencesPrivate.h:
3756         * WebView/WebView.mm:
3757         (-[WebView _preferencesChanged:]):
3758
3759 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3760
3761         Remove ENABLE_GAMEPAD_DEPRECATED
3762         https://bugs.webkit.org/show_bug.cgi?id=175361
3763
3764         Reviewed by Carlos Garcia Campos.
3765
3766         * Configurations/FeatureDefines.xcconfig:
3767
3768 2017-08-09  Chris Dumez  <cdumez@apple.com>
3769
3770         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3771         https://bugs.webkit.org/show_bug.cgi?id=175401
3772
3773         Reviewed by Brady Eidson.
3774
3775         * WebView/WebPreferenceKeysPrivate.h:
3776         * WebView/WebPreferences.mm:
3777         (+[WebPreferences initialize]):
3778         (-[WebPreferences beaconAPIEnabled]): Deleted.
3779         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3780         * WebView/WebPreferencesPrivate.h:
3781         * WebView/WebView.mm:
3782         (-[WebView _preferencesChanged:]):
3783
3784 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3785
3786         [PAL] Move spi/cocoa and spi/cg directories into PAL
3787         https://bugs.webkit.org/show_bug.cgi?id=175175
3788
3789         Reviewed by Myles C. Maxfield.
3790
3791         * History/WebHistory.mm:
3792         * Misc/WebDownload.mm:
3793         * Misc/WebKitNSStringExtras.mm:
3794         * Plugins/Hosted/NetscapePluginHostManager.mm:
3795         * Plugins/WebPluginDatabase.mm:
3796         * WebCoreSupport/WebFrameLoaderClient.mm:
3797         * WebInspector/WebNodeHighlight.mm:
3798         * WebView/WebHTMLView.mm:
3799         * WebView/WebIndicateLayer.mm:
3800         * WebView/WebView.mm:
3801         * WebView/WebViewData.h:
3802
3803 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3804
3805         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3806         https://bugs.webkit.org/show_bug.cgi?id=175392
3807         <rdar://problem/33783207>
3808
3809         Reviewed by Tim Horton and Megan Gardner.
3810
3811         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3812
3813         * Configurations/FeatureDefines.xcconfig:
3814
3815 2017-08-09  Daniel Bates  <dabates@apple.com>
3816
3817         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3818         https://bugs.webkit.org/show_bug.cgi?id=175247
3819         <rdar://problem/33679804>
3820
3821         Reviewed by Brady Eidson.
3822
3823         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3824         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3825         clients that need to make use of this information at this time. If such a needs comes up
3826         then we can expose API/SPI similar to what we do for WebKit.
3827
3828         * WebCoreSupport/WebFrameLoaderClient.h:
3829         * WebCoreSupport/WebFrameLoaderClient.mm:
3830         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3831
3832 2017-08-08  Brady Eidson  <beidson@apple.com>
3833
3834         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3835         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3836
3837         Reviewed by Andy Estes.
3838
3839         * Misc/WebKitVersionChecks.h:
3840         * WebCoreSupport/WebFrameLoaderClient.mm:
3841         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3842           the app is linked against new WebKit with the new behavior.
3843
3844 2017-08-07  Devin Rousso  <drousso@apple.com>
3845
3846         Web Inspector: Preview Canvas path when viewing a recording
3847         https://bugs.webkit.org/show_bug.cgi?id=174967
3848
3849         Reviewed by Brian Burg.
3850
3851         * WebView/WebPreferenceKeysPrivate.h:
3852         * WebView/WebPreferences.mm:
3853         (+[WebPreferences initialize]):
3854         (-[WebPreferences inspectorAdditionsEnabled]):
3855         (-[WebPreferences setInspectorAdditionsEnabled:]):
3856         * WebView/WebPreferencesPrivate.h:
3857         * WebView/WebView.mm:
3858         (-[WebView _preferencesChanged:]):
3859         Add plumbing for new InspectorAdditions runtime flag.
3860
3861 2017-08-07  Brian Burg  <bburg@apple.com>
3862
3863         Remove CANVAS_PATH compilation guard
3864         https://bugs.webkit.org/show_bug.cgi?id=175207
3865
3866         Reviewed by Sam Weinig.
3867
3868         * Configurations/FeatureDefines.xcconfig:
3869
3870 2017-08-04  Youenn Fablet  <youenn@apple.com>
3871
3872         [Cache API] Add Cache and CacheStorage IDL definitions
3873         https://bugs.webkit.org/show_bug.cgi?id=175201
3874
3875         Reviewed by Brady Eidson.
3876
3877         * WebView/WebPreferenceKeysPrivate.h:
3878         * WebView/WebPreferences.mm:
3879         (+[WebPreferences initialize]):
3880         (-[WebPreferences cacheAPIEnabled]):
3881         (-[WebPreferences setCacheAPIEnabled:]):
3882         * WebView/WebPreferencesPrivate.h:
3883         * WebView/WebView.mm:
3884         (-[WebView _preferencesChanged:]):
3885
3886 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3887
3888         Unreviewed, rolling out r220271.
3889
3890         Rolling out due to Layout Test failing on iOS Simulator.
3891
3892         Reverted changeset:
3893
3894         "Remove STREAMS_API compilation guard"
3895         https://bugs.webkit.org/show_bug.cgi?id=175165
3896         http://trac.webkit.org/changeset/220271
3897
3898 2017-08-04  Youenn Fablet  <youenn@apple.com>
3899
3900         Remove STREAMS_API compilation guard
3901         https://bugs.webkit.org/show_bug.cgi?id=175165
3902
3903         Reviewed by Darin Adler.
3904
3905         * Configurations/FeatureDefines.xcconfig:
3906         * WebView/WebPreferences.mm:
3907         (+[WebPreferences initialize]):
3908         * WebView/WebView.mm:
3909         (-[WebView _preferencesChanged:]):
3910
3911 2017-08-03  Brian Burg  <bburg@apple.com>
3912
3913         Remove ENABLE(WEB_SOCKET) guards
3914         https://bugs.webkit.org/show_bug.cgi?id=167044
3915
3916         Reviewed by Joseph Pecoraro.
3917
3918         * Configurations/FeatureDefines.xcconfig:
3919         * WebView/WebPreferencesPrivate.h:
3920
3921 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3922
3923         [PAL] Move spi/cf directory into PAL
3924         https://bugs.webkit.org/show_bug.cgi?id=175057
3925
3926         Reviewed by Antti Koivisto.
3927
3928         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3929         * Plugins/WebNetscapePluginStream.mm:
3930         * WebCoreSupport/WebFrameNetworkingContext.mm:
3931         * WebView/WebPreferences.mm:
3932         * WebView/WebView.mm:
3933
3934 2017-08-03  Youenn Fablet  <youenn@apple.com>
3935
3936         Remove FETCH_API compilation guard
3937         https://bugs.webkit.org/show_bug.cgi?id=175154
3938
3939         Reviewed by Chris Dumez.
3940
3941         * Configurations/FeatureDefines.xcconfig:
3942         * WebView/WebPreferences.mm:
3943         (+[WebPreferences initialize]):
3944         * WebView/WebView.mm:
3945         (-[WebView _preferencesChanged:]):
3946
3947 2017-08-03  Brady Eidson  <beidson@apple.com>
3948
3949         Add SW IDLs and stub out basic functionality.
3950         https://bugs.webkit.org/show_bug.cgi?id=175115
3951
3952         Reviewed by Chris Dumez.
3953
3954         * Configurations/FeatureDefines.xcconfig:
3955
3956 2017-08-02  Sam Weinig  <sam@webkit.org>
3957
3958         [WebIDL] Convert MutationCallback to be a normal generated callback
3959         https://bugs.webkit.org/show_bug.cgi?id=174140
3960
3961         Reviewed by Darin Adler.
3962
3963         * DOM/DOMDocument.mm:
3964         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3965         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3966         Pass, now necessary, Document to NativeNodeFilter constructor.
3967
3968 2017-08-01  Chris Dumez  <cdumez@apple.com>
3969
3970         Add initial support for navigator.sendBeacon
3971         https://bugs.webkit.org/show_bug.cgi?id=175007
3972         <rdar://problem/33547728>
3973
3974         Reviewed by Sam Weinig.
3975
3976         Add setting to toggle support for the Beacon API (it is disabled by default).
3977
3978         * WebView/WebPreferenceKeysPrivate.h:
3979         * WebView/WebPreferences.mm:
3980         (+[WebPreferences initialize]):
3981         (-[WebPreferences beaconAPIEnabled]):
3982         (-[WebPreferences setBeaconAPIEnabled:]):
3983         * WebView/WebPreferencesPrivate.h:
3984         * WebView/WebView.mm:
3985         (-[WebView _preferencesChanged:]):
3986
3987 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3988
3989         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3990         https://bugs.webkit.org/show_bug.cgi?id=174437
3991
3992         Reviewed by Darin Adler.
3993
3994         Remove redundant Web- prefix from classes in WebKit namespace.
3995
3996         * WebView/WebView.mm:
3997         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3998         * WebView/WebViewData.h:
3999         * WebView/WebViewData.mm:
4000
4001 2017-07-26  Brian Burg  <bburg@apple.com>
4002
4003         Remove WEB_TIMING feature flag
4004         https://bugs.webkit.org/show_bug.cgi?id=174795
4005
4006         Reviewed by Alex Christensen.
4007
4008         * Configurations/FeatureDefines.xcconfig:
4009
4010 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
4011
4012         Async image decoding for large images should be disabled after the first time a tile is painted
4013         https://bugs.webkit.org/show_bug.cgi?id=174451
4014         <rdar://problem/31246421>
4015
4016         Reviewed by Simon Fraser.
4017
4018         * WebView/WebFrame.mm:
4019         (-[WebFrame _paintBehaviorForDestinationContext:]):
4020         (-[WebFrame _drawRect:contentsOnly:]):
4021         * WebView/WebHTMLView.mm:
4022         (imageFromRect):
4023
4024 2017-07-23  Darin Adler  <darin@apple.com>
4025
4026         More NeverDestroyed and related cleanup
4027         https://bugs.webkit.org/show_bug.cgi?id=174745
4028
4029         Reviewed by Alex Christensen.
4030
4031         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
4032         for names that aren't even used in this file.
4033         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
4034         -[NSArray arrayWithObject:].
4035         (-[DOMNode absoluteQuads]): Ditto.
4036         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
4037         of writing out various types.
4038         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
4039         syntax instea of -[NSArray arrayWithObject:].
4040         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
4041         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
4042         of writing out various types.
4043         (-[DOMHTMLImageElement mimeType]): Ditto.
4044
4045 2017-07-24  Chris Dumez  <cdumez@apple.com>
4046
4047         ExceptionCode enumeration should use modern exception names
4048         https://bugs.webkit.org/show_bug.cgi?id=174794
4049
4050         Reviewed by Geoffrey Garen.
4051
4052         * DOM/ExceptionHandlers.mm:
4053         (raiseNotSupportedErrorException):
4054
4055 2017-07-23  Chris Dumez  <cdumez@apple.com>
4056
4057         Drop ExceptionCodeDescription class
4058         https://bugs.webkit.org/show_bug.cgi?id=174757
4059
4060         Reviewed by Darin Adler.
4061
4062         Stop using ExceptionCodeDescription.
4063
4064         * DOM/ExceptionHandlers.mm:
4065         (raiseDOMErrorException):
4066
4067 2017-07-21  Andreas Kling  <akling@apple.com>
4068
4069         Use more references in event dispatch code
4070         https://bugs.webkit.org/show_bug.cgi?id=174681
4071
4072         Reviewed by Geoffrey Garen.
4073
4074         * DOM/ObjCEventListener.h:
4075         * DOM/ObjCEventListener.mm:
4076         (WebCore::ObjCEventListener::handleEvent):
4077         * WebCoreSupport/WebFrameLoaderClient.mm:
4078         (NetscapePluginWidget::handleEvent):
4079
4080 2017-07-21  Brady Eidson  <beidson@apple.com>
4081
4082         Get rid of WebCore IconDatabase code.
4083         https://bugs.webkit.org/show_bug.cgi?id=174700
4084
4085         Reviewed by Tim Horton.
4086
4087         * Misc/WebCoreStatistics.mm:
4088         (+[WebCoreStatistics iconPageURLMappingCount]):
4089         (+[WebCoreStatistics iconRetainedPageURLCount]):
4090         (+[WebCoreStatistics iconRecordCount]):
4091         (+[WebCoreStatistics iconsWithDataCount]):
4092         * WebCoreSupport/WebFrameLoaderClient.h:
4093         * WebCoreSupport/WebFrameLoaderClient.mm:
4094         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
4095         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
4096         * WebView/WebView.mm:
4097         (-[WebView mainFrameIconURL]):
4098
4099 2017-07-20  Chris Dumez  <cdumez@apple.com>
4100
4101         Drop legacy XPathException type
4102         https://bugs.webkit.org/show_bug.cgi?id=174679
4103
4104         Reviewed by Sam Weinig.
4105
4106         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
4107         no longer expose XPathException.
4108
4109         * DOM/ExceptionHandlers.mm:
4110         (raiseDOMErrorException):
4111
4112 2017-07-20  Chris Dumez  <cdumez@apple.com>
4113
4114         Unreviewed, rolling out r219706.
4115
4116         Broke iOS build
4117
4118         Reverted changeset:
4119
4120         "Drop legacy XPathException type"
4121         https://bugs.webkit.org/show_bug.cgi?id=174679
4122         http://trac.webkit.org/changeset/219706
4123
4124 2017-07-20  Chris Dumez  <cdumez@apple.com>
4125
4126         Drop legacy XPathException type
4127         https://bugs.webkit.org/show_bug.cgi?id=174679
4128
4129         Reviewed by Sam Weinig.
4130
4131         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
4132         no longer expose XPathException.
4133
4134         * DOM/ExceptionHandlers.mm:
4135         (raiseDOMErrorException):
4136         * WebKit.exp:
4137
4138 2017-07-20  Chris Dumez  <cdumez@apple.com>
4139
4140         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
4141         https://bugs.webkit.org/show_bug.cgi?id=174660
4142
4143         Reviewed by Geoffrey Garen.
4144
4145         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
4146         This essentially replaces a branch to figure out if the new size is less or greater than the
4147         current size by an assertion.
4148
4149         * Plugins/WebNetscapePluginView.mm:
4150         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
4151
4152 2017-07-20  Brady Eidson  <beidson@apple.com>
4153
4154         Deprecate WebIconDatabase in WebKitLegacy/mac.
4155         https://bugs.webkit.org/show_bug.cgi?id=174607
4156
4157         Reviewed by Alex Christensen.
4158
4159         This patch:
4160         1 - Formally deprecates WebIconDatabase (which was never API anyways)
4161         2 - Guts the class to where it can only return the default icon at the small size
4162         3 - Reworks other parts of WebKitLegacy that used it for anything to either
4163             use something else or to not do anything.
4164         
4165         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
4166         and that patch will remove all of the last remnants of WebIconDatabase.
4167         
4168         * History/WebHistoryItem.mm:
4169         (-[WebHistoryItem icon]):
4170
4171         * Misc/WebIconDatabase.h:
4172         * Misc/WebIconDatabase.mm:
4173         (-[WebIconDatabase init]):
4174         (-[WebIconDatabase iconForURL:withSize:cache:]):
4175         (-[WebIconDatabase iconForURL:withSize:]):
4176         (-[WebIconDatabase defaultIconWithSize:]):
4177         (-[WebIconDatabase defaultIconForURL:withSize:]):
4178         (-[WebIconDatabase iconURLForURL:]):
4179         (-[WebIconDatabase retainIconForURL:]):
4180         (-[WebIconDatabase releaseIconForURL:]):
4181         (+[WebIconDatabase delayDatabaseCleanup]):
4182         (+[WebIconDatabase allowDatabaseCleanup]):
4183         (-[WebIconDatabase setDelegate:]):
4184         (-[WebIconDatabase delegate]):
4185         (+[WebIconDatabase initialize]): Deleted.
4186         (-[WebIconDatabase isEnabled]): Deleted.
4187         (-[WebIconDatabase setEnabled:]): Deleted.
4188         (-[WebIconDatabase removeAllIcons]): Deleted.
4189         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
4190         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
4191         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
4192         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
4193         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
4194         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
4195         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
4196         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
4197         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
4198         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
4199         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
4200         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
4201         (-[WebIconDatabase _databaseDirectory]): Deleted.
4202         (webGetNSImage): Deleted.