0f5774dd4b014abf164725311133cb5b7decd302
[WebKit.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
2
3         Disable content filtering in minimal simulator mode
4         https://bugs.webkit.org/show_bug.cgi?id=185027
5         <rdar://problem/39736091>
6
7         Reviewed by Jer Noble.
8
9         * Configurations/FeatureDefines.xcconfig:
10
11 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
12
13         [INTL] Implement Intl.PluralRules
14         https://bugs.webkit.org/show_bug.cgi?id=184312
15
16         Reviewed by JF Bastien.
17
18         Added Intl.PluralRules feature flag.
19
20         * Configurations/FeatureDefines.xcconfig:
21
22 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
23
24         Remove access to keychain from the WebContent process
25         https://bugs.webkit.org/show_bug.cgi?id=184428
26         <rdar://problem/13150903>
27
28         Reviewed by Brent Fulgham.
29
30         This patch does the followings:
31         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
32         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
33         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
34
35         * WebCoreSupport/WebChromeClient.h:
36         * WebCoreSupport/WebChromeClient.mm:
37         (WebChromeClient::signedPublicKeyAndChallengeString const):
38         * WebView/WebUIDelegatePrivate.h:
39
40 2018-04-24  Jer Noble  <jer.noble@apple.com>
41
42         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
43         https://bugs.webkit.org/show_bug.cgi?id=184786
44
45         Reviewed by Tim Horton.
46
47         * Configurations/WebKitLegacy.xcconfig:
48         * MigrateHeaders.make:
49
50 2018-04-23  Daniel Bates  <dabates@apple.com>
51
52         Implement Same-Site cookies
53         https://bugs.webkit.org/show_bug.cgi?id=159464
54         <rdar://problem/27196358>
55
56         Reviewed by Brent Fulgham.
57
58         Pass the Same-Site info through the strategy.
59
60         * WebCoreSupport/WebPlatformStrategies.h:
61         * WebCoreSupport/WebPlatformStrategies.mm:
62         (WebPlatformStrategies::cookiesForDOM):
63         (WebPlatformStrategies::setCookiesFromDOM):
64         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
65         (WebPlatformStrategies::getRawCookies):
66
67 2018-04-23  Zalan Bujtas  <zalan@apple.com>
68
69         [LayoutFormattingContext] Initial commit.
70         https://bugs.webkit.org/show_bug.cgi?id=184896
71
72         Reviewed by Antti Koivisto.
73
74         * Configurations/FeatureDefines.xcconfig:
75
76 2018-04-23  Daniel Bates  <dabates@apple.com>
77
78         Implement Same-Site cookies
79         https://bugs.webkit.org/show_bug.cgi?id=159464
80         <rdar://problem/27196358>
81
82         Reviewed by Brent Fulgham.
83
84         Pass the Same-Site info through the strategy.
85
86         * WebCoreSupport/WebPlatformStrategies.h:
87         * WebCoreSupport/WebPlatformStrategies.mm:
88         (WebPlatformStrategies::cookiesForDOM):
89         (WebPlatformStrategies::setCookiesFromDOM):
90         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
91         (WebPlatformStrategies::getRawCookies):
92
93 2018-04-20  Timothy Hatcher  <timothy@apple.com>
94
95         NULL dereference crash sometimes under [super initWithCoder:] in WebView
96
97         https://bugs.webkit.org/show_bug.cgi?id=184851
98         rdar://problem/39611236
99
100         Reviewed by Tim Horton.
101
102         * WebView/WebView.mm:
103         (-[WebView _commonInitializationWithFrameName:groupName:]):
104         (-[WebView effectiveAppearanceDidChange]):
105         Added a null check and call the code later in initialization.
106
107 2018-04-20  Tim Horton  <timothy_horton@apple.com>
108
109         Adjust geolocation feature flag
110         https://bugs.webkit.org/show_bug.cgi?id=184856
111
112         Reviewed by Wenson Hsieh.
113
114         * Configurations/FeatureDefines.xcconfig:
115
116 2018-04-18  Jer Noble  <jer.noble@apple.com>
117
118         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
119         https://bugs.webkit.org/show_bug.cgi?id=184762
120
121         Reviewed by Dan Bernstein.
122
123         * Configurations/WebKitLegacy.xcconfig:
124
125 2018-04-20  Youenn Fablet  <youenn@apple.com>
126
127         Make PluginData cache its web visible plugins
128         https://bugs.webkit.org/show_bug.cgi?id=184421
129
130         Reviewed by Chris Dumez.
131
132         * WebCoreSupport/WebPluginInfoProvider.h:
133         * WebCoreSupport/WebPluginInfoProvider.mm:
134         (WebPluginInfoProvider::pluginInfo):
135         (WebPluginInfoProvider::webVisiblePluginInfo):
136
137 2018-04-19  Chris Dumez  <cdumez@apple.com>
138
139         Rename JSDOMWindowProxy to JSWindowProxy
140         https://bugs.webkit.org/show_bug.cgi?id=184797
141
142         Reviewed by Sam Weinig.
143
144         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
145
146         * DOM/DOMUtility.mm:
147         (createDOMWrapper):
148         * WebView/WebFrame.mm:
149         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
150
151 2018-04-19  David Kilzer  <ddkilzer@apple.com>
152
153         Enable Objective-C weak references
154         <https://webkit.org/b/184789>
155         <rdar://problem/39571716>
156
157         Reviewed by Dan Bernstein.
158
159         * Configurations/Base.xcconfig:
160         (CLANG_ENABLE_OBJC_WEAK): Enable.
161
162 2018-04-18  Chris Dumez  <cdumez@apple.com>
163
164         Rename WindowProxyController to WindowProxy
165         https://bugs.webkit.org/show_bug.cgi?id=184756
166
167         Reviewed by Sam Weinig.
168
169         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
170         needed use WindowProxyController type, which was a bit confusing.
171
172         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
173         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
174         * WebView/WebFrame.mm:
175         (-[WebFrame _attachScriptDebugger]):
176
177 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
178
179         Unreviewed rollout of r230632. Regression in memory usage.
180
181         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
182
183         * WebView/WebPreferences.mm:
184         (+[WebPreferences initialize]):
185
186 2018-04-17  Chris Dumez  <cdumez@apple.com>
187
188         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
189         https://bugs.webkit.org/show_bug.cgi?id=184678
190         <rdar://problem/39422122>
191
192         Reviewed by Alex Christensen.
193
194         Add new parameter to dispatchDecidePolicyForNavigationAction.
195
196         * WebCoreSupport/WebFrameLoaderClient.h:
197         * WebCoreSupport/WebFrameLoaderClient.mm:
198         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
199
200 2018-04-13  Chris Dumez  <cdumez@apple.com>
201
202         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
203         https://bugs.webkit.org/show_bug.cgi?id=184591
204
205         Reviewed by Sam Weinig.
206
207         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
208         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
209         This is work towards fixing Bug 184515.
210
211         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
212         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
213         * WebView/WebFrame.mm:
214         (-[WebFrame _attachScriptDebugger]):
215
216 2018-04-12  Antoine Quint  <graouts@apple.com>
217
218         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
219         https://bugs.webkit.org/show_bug.cgi?id=184569
220         <rdar://problem/38671301>
221
222         Reviewed by Jon Lee.
223
224         * WebView/WebPreferences.mm:
225
226 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
227
228         [WTF] Remove StaticLock
229         https://bugs.webkit.org/show_bug.cgi?id=184332
230
231         Reviewed by Mark Lam.
232
233         * DOM/DOMInternal.mm:
234         (getDOMWrapper):
235         (addDOMWrapper):
236         (removeDOMWrapper):
237
238 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
239
240         Failures from mach port reference handling should be fatal
241         https://bugs.webkit.org/show_bug.cgi?id=184202
242         <rdar://problem/37771114>
243
244         Reviewed by Anders Carlsson.
245
246         * Plugins/Hosted/NetscapePluginHostManager.mm:
247         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
248
249 2018-04-03  Andy Estes  <aestes@apple.com>
250
251         [Mac] Prioritize file promises over filenames during drag and drop
252         https://bugs.webkit.org/show_bug.cgi?id=184237
253         <rdar://problem/38278076>
254
255         Reviewed by Wenson Hsieh.
256
257         * WebView/WebView.mm:
258         (-[WebView performDragOperation:]):
259
260 2018-04-03  Chris Dumez  <cdumez@apple.com>
261
262         Drop MainFrame class
263         https://bugs.webkit.org/show_bug.cgi?id=184191
264
265         Reviewed by Darin Adler.
266
267         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
268         relationship between the Page and the MainFrame.
269
270         This is ground work for introducing LocalFrame / RemoteFrame concepts.
271
272         * WebCoreSupport/WebDragClient.mm:
273         * WebCoreSupport/WebFrameLoaderClient.mm:
274         * WebCoreSupport/WebInspectorClient.mm:
275         * WebCoreSupport/WebPlatformStrategies.mm:
276         * WebCoreSupport/WebPluginInfoProvider.mm:
277         * WebView/WebFrame.mm:
278         * WebView/WebFrameView.mm:
279         * WebView/WebHTMLView.mm:
280         * WebView/WebView.mm:
281
282 2018-04-02  Jer Noble  <jer.noble@apple.com>
283
284         Enable Legacy EME for all WebKit & WebKitLegacy clients
285         https://bugs.webkit.org/show_bug.cgi?id=184018
286         <rdar://problem/34887387>
287
288         Reviewed by Eric Carlson.
289
290         * WebView/WebPreferences.mm:
291         (+[WebPreferences initialize]):
292
293 2018-03-29  JF Bastien  <jfbastien@apple.com>
294
295         Use Forward.h instead of forward-declaring WTF::String
296         https://bugs.webkit.org/show_bug.cgi?id=184172
297         <rdar://problem/39026146>
298
299         Reviewed by Yusuke Suzuki.
300
301         As part of #184164 I'm changing WTF::String, and the forward
302         declarations are just wrong because I'm making it templated. We
303         should use Forward.h anyways, so do that instead.
304
305         * WebView/WebScriptDebugger.h:
306
307 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
308
309         Protect against invalid mach ports returned by mach_port_request_notification
310         https://bugs.webkit.org/show_bug.cgi?id=184106
311         <rdar://problem/37865316>
312
313         Reviewed by Chris Dumez.
314
315         * Plugins/Hosted/NetscapePluginHostProxy.mm:
316         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
317         and clean up if it experienced an error.
318         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
319
320 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
321
322         Avoid uninitialized mach ports
323         https://bugs.webkit.org/show_bug.cgi?id=184090
324         <rdar://problem/37261129>
325
326         Reviewed by Chris Dumez.
327
328         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
329         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
330         there is a potential for us to try to use invalid ports.
331
332         We should always check return values, and ensure that the mach port variables we seek to initialize are
333         kept in a valid state.
334
335         Reviewed by Chris Dumez.
336
337         * Plugins/Hosted/NetscapePluginHostManager.h:
338         * Plugins/Hosted/NetscapePluginHostManager.mm:
339         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
340         port is passed to an API function.
341         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
342         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
343         * Plugins/Hosted/NetscapePluginHostProxy.h:
344         * Plugins/Hosted/NetscapePluginHostProxy.mm:
345         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
346         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
347         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
348         (WKPCStatusText): Ditto.
349         (WKPCLoadURL): Ditto.
350         (WKPCCancelLoadURL): Ditto.
351         (WKPCInvalidateRect): Ditto.
352         (WKPCGetScriptableNPObjectReply): Ditto.
353         (WKPCBooleanReply): Ditto.
354         (WKPCBooleanAndDataReply): Ditto.
355         (WKPCInstantiatePluginReply): Ditto.
356         (WKPCGetWindowNPObject): Ditto.
357         (WKPCGetPluginElementNPObject): Ditto.
358         (WKPCForgetBrowserObject): Ditto.
359         (WKPCEvaluate): Ditto.
360         (WKPCGetStringIdentifier): Ditto.
361         (WKPCGetIntIdentifier): Ditto.
362         (WKPCInvoke): Ditto.
363         (WKPCInvokeDefault): Ditto.
364         (WKPCConstruct): Ditto.
365         (WKPCGetProperty): Ditto.
366         (WKPCSetProperty): Ditto.
367         (WKPCRemoveProperty): Ditto.
368         (WKPCHasProperty): Ditto.
369         (WKPCHasMethod): Ditto.
370         (WKPCIdentifierInfo): Ditto.
371         (WKPCEnumerate): Ditto.
372         (WKPCSetMenuBarVisible): Ditto.
373         (WKPCSetFullscreenWindowIsShowing): Ditto.
374         (WKPCSetModal): Ditto.
375         (WKPCGetCookies): Ditto.
376         (WKPCGetProxy): Ditto.
377         (WKPCSetCookies): Ditto.
378         (WKPCGetAuthenticationInfo): Ditto.
379         (WKPCConvertPoint): Ditto.
380         (WKPCLayerHostingModeChanged): Ditto.
381         (WKPCSetException): Ditto.
382
383 2018-03-26  Tim Horton  <timothy_horton@apple.com>
384
385         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
386         https://bugs.webkit.org/show_bug.cgi?id=184030
387         <rdar://problem/38895281>
388
389         Reviewed by Dan Bernstein.
390
391         * Configurations/Base.xcconfig:
392
393 2018-03-26  Chris Dumez  <cdumez@apple.com>
394
395         Use SecurityOriginData more consistently in Service Worker code
396         https://bugs.webkit.org/show_bug.cgi?id=183969
397
398         Reviewed by Darin Adler.
399
400         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
401
402         * Storage/WebDatabaseManager.mm:
403         (-[WebDatabaseManager databasesWithOrigin:]):
404         (-[WebDatabaseManager deleteOrigin:]):
405         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
406         * Storage/WebDatabaseQuotaManager.mm:
407         (-[WebDatabaseQuotaManager usage]):
408         (-[WebDatabaseQuotaManager quota]):
409         (-[WebDatabaseQuotaManager setQuota:]):
410         * Storage/WebStorageManager.mm:
411         (-[WebStorageManager deleteOrigin:]):
412         * WebCoreSupport/WebSecurityOrigin.mm:
413         (-[WebSecurityOrigin databaseIdentifier]):
414         (-[WebSecurityOrigin usage]):
415         (-[WebSecurityOrigin quota]):
416         (-[WebSecurityOrigin setQuota:]):
417
418 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
419
420         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
421         https://bugs.webkit.org/show_bug.cgi?id=183911
422         <rdar://problem/38762306>
423
424         Reviewed by Youenn Fablet.
425
426         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
427
428         * WebView/WebView.mm:
429         (+[WebView initialize]):
430
431 2018-03-26  Alex Christensen  <achristensen@webkit.org>
432
433         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
434         https://bugs.webkit.org/show_bug.cgi?id=183965
435
436         Reviewed by Chris Dumez.
437
438         * WebCoreSupport/WebFrameLoaderClient.h:
439         * WebCoreSupport/WebFrameLoaderClient.mm:
440         (WebFrameLoaderClient::willCacheResponse const):
441
442 2018-03-25  Commit Queue  <commit-queue@webkit.org>
443
444         Unreviewed, rolling out r229954.
445         https://bugs.webkit.org/show_bug.cgi?id=184000
446
447         Caused many layout tests to crash on Apple High Sierra,
448         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
449         by dydz on #webkit).
450
451         Reverted changeset:
452
453         "Use SecurityOriginData more consistently in Service Worker
454         code"
455         https://bugs.webkit.org/show_bug.cgi?id=183969
456         https://trac.webkit.org/changeset/229954
457
458 2018-03-24  Chris Dumez  <cdumez@apple.com>
459
460         Use SecurityOriginData more consistently in Service Worker code
461         https://bugs.webkit.org/show_bug.cgi?id=183969
462
463         Reviewed by Darin Adler.
464
465         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
466
467         * Storage/WebDatabaseManager.mm:
468         (-[WebDatabaseManager databasesWithOrigin:]):
469         (-[WebDatabaseManager deleteOrigin:]):
470         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
471         * Storage/WebDatabaseQuotaManager.mm:
472         (-[WebDatabaseQuotaManager usage]):
473         (-[WebDatabaseQuotaManager quota]):
474         (-[WebDatabaseQuotaManager setQuota:]):
475         * Storage/WebStorageManager.mm:
476         (-[WebStorageManager deleteOrigin:]):
477         * WebCoreSupport/WebSecurityOrigin.mm:
478         (-[WebSecurityOrigin databaseIdentifier]):
479         (-[WebSecurityOrigin usage]):
480         (-[WebSecurityOrigin quota]):
481         (-[WebSecurityOrigin setQuota:]):
482
483 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
484
485         Fix the build
486
487         * WebView/WebView.mm:
488
489 2018-03-23  Tim Horton  <timothy_horton@apple.com>
490
491         Fix the build with no pasteboard
492         https://bugs.webkit.org/show_bug.cgi?id=183973
493
494         Reviewed by Dan Bernstein.
495
496         * Configurations/FeatureDefines.xcconfig:
497         * WebView/WebView.mm:
498         (-[WebView _requestStartDataInteraction:globalPosition:]):
499         (-[WebView _getDataInteractionData]):
500         (-[WebView _dataOperationTextIndicator]):
501         (-[WebView _dragSourceAction]):
502         (-[WebView _draggedLinkTitle]):
503         (-[WebView _draggedLinkURL]):
504         (-[WebView _draggedElementBounds]):
505         (-[WebView _enteredDataInteraction:client:global:operation:]):
506         (-[WebView _updatedDataInteraction:client:global:operation:]):
507         (-[WebView _exitedDataInteraction:client:global:operation:]):
508         (-[WebView _performDataInteraction:client:global:operation:]):
509         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
510         (-[WebView _endedDataInteraction:global:]):
511         (-[WebView _dataInteractionCaretRect]):
512         * WebView/WebViewPrivate.h:
513
514 2018-03-23  Tim Horton  <timothy_horton@apple.com>
515
516         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
517         https://bugs.webkit.org/show_bug.cgi?id=183960
518         <rdar://problem/38812356>
519
520         Reviewed by Dan Bernstein.
521
522         * Configurations/WebKitLegacy.xcconfig:
523
524 2018-03-23  Tim Horton  <timothy_horton@apple.com>
525
526         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
527         https://bugs.webkit.org/show_bug.cgi?id=183954
528         <rdar://problem/38808858>
529
530         Reviewed by Dan Bernstein.
531
532         * WebView/WebPreferences.mm:
533         (-[WebPreferences setAudioSessionCategoryOverride:]):
534
535 2018-03-23  Tim Horton  <timothy_horton@apple.com>
536
537         Adopt WK_PLATFORM_NAME in WebKitLegacy
538         https://bugs.webkit.org/show_bug.cgi?id=183948
539         <rdar://problem/38803908>
540
541         Reviewed by Dan Bernstein.
542
543         * Configurations/WebKitLegacy.xcconfig:
544         * MigrateHeaders.make:
545         * postprocess-headers.sh:
546
547 2018-03-23  Brady Eidson  <beidson@apple.com>
548
549         Go to back/forward list items after a process-swapped navigation.
550         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
551
552         Reviewed by Andy Estes.
553
554         * WebView/WebView.mm:
555         (-[WebView _loadBackForwardListFromOtherView:]):
556         (-[WebView goToBackForwardItem:]):
557
558 2018-03-22  Tim Horton  <timothy_horton@apple.com>
559
560         Improve readability of WebCore's OTHER_LDFLAGS
561         https://bugs.webkit.org/show_bug.cgi?id=183909
562         <rdar://problem/38760992>
563
564         Reviewed by Dan Bernstein.
565
566         * Configurations/Base.xcconfig:
567         * Configurations/FeatureDefines.xcconfig:
568
569 2018-03-20  Tim Horton  <timothy_horton@apple.com>
570
571         Enable the minimal simulator feature flag when appropriate
572         https://bugs.webkit.org/show_bug.cgi?id=183807
573
574         Reviewed by Dan Bernstein.
575
576         * Configurations/FeatureDefines.xcconfig:
577
578 2018-03-20  Tim Horton  <timothy_horton@apple.com>
579
580         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
581         https://bugs.webkit.org/show_bug.cgi?id=183758
582         <rdar://problem/38017644>
583
584         Reviewed by Dan Bernstein.
585
586         * Configurations/FeatureDefines.xcconfig:
587
588 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
589
590         Clear style colors when setting default appearance
591         https://bugs.webkit.org/show_bug.cgi?id=183759
592
593         Reviewed by Tim Horton.
594
595         Colors are cached and need to be cleared and recalculated.
596         Refactor to do all style recalcs together.
597
598         * WebView/WebView.mm:
599         (-[WebView _setDefaultAppearanceAndClearStyle]):
600         (-[WebView _setUseSystemAppearance:]):
601         (-[WebView effectiveAppearanceDidChange]):
602
603 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
604
605         Unreviewed, another quick fix for r229699
606
607         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
608
609         * Configurations/FeatureDefines.xcconfig:
610
611 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
612
613         Ensure that style is updated when the effective appearance changes
614         https://bugs.webkit.org/show_bug.cgi?id=183690
615         <rdar://problem/38385900>
616
617         Reviewed by Tim Horton and Wenson Hsieh.
618
619         Respond to and respect the effective appearance changing.
620
621         * WebView/WebView.mm:
622         (-[WebView _setUseSystemAppearance:]):
623         (-[WebView effectiveAppearanceDidChange]):
624
625 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
626
627         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
628         https://bugs.webkit.org/show_bug.cgi?id=183677
629
630         Reviewed by Tim Horton.
631
632         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
633
634         * DOM/DOM.mm:
635         (-[DOMHTMLLinkElement _mediaQueryMatches]):
636
637 2018-03-14  Tim Horton  <timothy_horton@apple.com>
638
639         Fix the build after r229567
640
641         * Configurations/FeatureDefines.xcconfig:
642
643 2018-03-12  Tim Horton  <timothy_horton@apple.com>
644
645         Stop using SDK conditionals to control feature definitions
646         https://bugs.webkit.org/show_bug.cgi?id=183430
647         <rdar://problem/38251619>
648
649         Reviewed by Dan Bernstein.
650
651         * Configurations/FeatureDefines.xcconfig:
652         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
653
654 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
655
656         Runtime flag for link prefetch and remove link subresource.
657         https://bugs.webkit.org/show_bug.cgi?id=183540
658
659         Reviewed by Chris Dumez.
660
661         Remove the LINK_PREFETCH build time flag.
662
663         * Configurations/FeatureDefines.xcconfig:
664
665 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
666
667         Remove GridLayout runtime flag
668         https://bugs.webkit.org/show_bug.cgi?id=183484
669
670         Reviewed by Myles C. Maxfield.
671
672         The Grid Layout feature has been enabled by default for almost a
673         year, so I think it's time to remove the runtime flag and the
674
675         * WebView/WebPreferenceKeysPrivate.h:
676         * WebView/WebPreferences.mm:
677         (+[WebPreferences initialize]):
678         * WebView/WebPreferencesPrivate.h:
679         * WebView/WebView.mm:
680         (-[WebView _preferencesChanged:]):
681
682 2018-03-12  Antoine Quint  <graouts@apple.com>
683
684         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
685         https://bugs.webkit.org/show_bug.cgi?id=183504
686         <rdar://problem/38372965>
687
688         Reviewed by Dean Jackson and Jon Lee.
689
690         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
691         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
692
693         * WebView/WebPreferenceKeysPrivate.h:
694         * WebView/WebPreferences.mm:
695         (+[WebPreferences initialize]):
696         (-[WebPreferences setModernMediaControlsEnabled:]):
697         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
698         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
699         * WebView/WebPreferencesPrivate.h:
700         * WebView/WebView.mm:
701         (-[WebView _preferencesChanged:]):
702
703 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
704
705         Media query for default appearance
706         https://bugs.webkit.org/show_bug.cgi?id=183539
707         <rdar://problem/38326388>
708
709         Reviewed by Tim Horton.
710
711         Write a media query to evaluate appearance.
712
713         * WebView/WebView.mm:
714         (-[WebView _commonInitializationWithFrameName:groupName:]):
715         (-[WebView _setUseSystemAppearance:]):
716
717 2018-03-09  Andy Estes  <aestes@apple.com>
718
719         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
720         https://bugs.webkit.org/show_bug.cgi?id=183489
721         <rdar://problem/38267517>
722
723         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
724         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
725         to issue a sandbox extension for this directory, but for security reasons App Sandbox
726         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
727         block with a nil error and a valid file URL, but no file will actually exist at that URL.
728
729         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
730         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
731         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
732         drop destination.
733
734         Reviewed by Wenson Hsieh.
735
736         * WebView/WebView.mm:
737         (-[WebView performDragOperation:]):
738
739 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
740
741         Allow WebViews to disable system appearance
742         https://bugs.webkit.org/show_bug.cgi?id=183418
743         <rdar://problem/36975642>
744
745         Reviewed by Tim Horton.
746
747         Allow webviews to choose whether or not to follow the default system appearance.
748
749         * WebView/WebView.mm:
750         (-[WebView _setUseSystemAppearance:]):
751         (-[WebView _useSystemAppearance]):
752         * WebView/WebViewPrivate.h:
753
754 2018-03-08  Youenn Fablet  <youenn@apple.com>
755
756         libwebrtc update broke internal builds
757         https://bugs.webkit.org/show_bug.cgi?id=183454
758
759         Reviewed by Eric Carlson.
760
761         * Configurations/WebKitLegacy.xcconfig:
762
763 2018-03-08  Chris Dumez  <cdumez@apple.com>
764
765         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
766         https://bugs.webkit.org/show_bug.cgi?id=183455
767         <rdar://problem/38191749>
768
769         Reviewed by Youenn Fablet.
770
771         Add a null check for the page as we have evidence from crashes that it can be null.
772         Other functions in WebFrameNetworkingContext already null check the page as well,
773         not just the frame so this is consistent.
774
775         * WebCoreSupport/WebFrameNetworkingContext.mm:
776         (WebFrameNetworkingContext::storageSession const):
777
778 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
779
780         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
781         https://bugs.webkit.org/show_bug.cgi?id=183429
782
783         Reviewed by Mark Lam.
784
785         * DOM/DOM.mm:
786         (+[DOMNode _nodeFromJSWrapper:]):
787         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
788         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
789         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
790         * Plugins/Hosted/ProxyInstance.mm:
791         (WebKit::ProxyInstance::invokeMethod):
792         * WebView/WebView.mm:
793         (aeDescFromJSValue):
794
795 2018-03-08  Tim Horton  <timothy_horton@apple.com>
796
797         Stop linking ApplicationServices directly
798         https://bugs.webkit.org/show_bug.cgi?id=182867
799         <rdar://problem/38252142>
800
801         Reviewed by Alex Christensen.
802
803         The frameworks that we use that live inside ApplicationServices
804         have mostly moved out, so import them directly.
805
806         * Carbon/CarbonUtils.h:
807         * WebKitPrefix.h:
808         * WebView/WebHTMLView.mm:
809         * WebView/WebPDFView.mm:
810
811 2018-03-07  Tim Horton  <timothy_horton@apple.com>
812
813         Sort and separate FeatureDefines.xcconfig
814         https://bugs.webkit.org/show_bug.cgi?id=183427
815
816         Reviewed by Dan Bernstein.
817
818         * Configurations/FeatureDefines.xcconfig:
819         Sort and split FeatureDefines into paragraphs
820         (to make it easier to sort later).
821
822 2018-03-07  Youenn Fablet  <youenn@apple.com>
823
824         Match unsupported plugins based on domains and not origin
825         https://bugs.webkit.org/show_bug.cgi?id=183384
826
827         Reviewed by Chris Dumez.
828
829         * WebCoreSupport/WebPluginInfoProvider.h:
830         * WebCoreSupport/WebPluginInfoProvider.mm:
831         (WebPluginInfoProvider::getPluginInfo):
832         (WebPluginInfoProvider::getWebVisiblePluginInfo):
833
834 2018-03-05  Andy Estes  <aestes@apple.com>
835
836         [Mac] Teach WebCore::Pasteboard about file promise drags
837         https://bugs.webkit.org/show_bug.cgi?id=183314
838         <rdar://problem/38105493>
839
840         Reviewed by Darin Adler.
841
842         Added a FIXME comment.
843
844         * WebView/WebView.mm:
845         (-[WebView performDragOperation:]):
846
847 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
848
849         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
850         https://bugs.webkit.org/show_bug.cgi?id=183312
851
852         Reviewed by Mark Lam.
853
854         Remove wtf/CurrentTime.h include pragma.
855
856         * WebView/WebFrame.mm:
857         * WebView/WebPDFView.mm:
858
859 2018-03-04  Tim Horton  <timothy_horton@apple.com>
860
861         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
862         https://bugs.webkit.org/show_bug.cgi?id=183283
863         <rdar://problem/38062148>
864
865         Reviewed by Sam Weinig.
866
867         * Configurations/FeatureDefines.xcconfig:
868
869 2018-02-28  Alex Christensen  <achristensen@webkit.org>
870
871         Reduce use of NetworkingContext in WebKit
872         https://bugs.webkit.org/show_bug.cgi?id=183213
873
874         Reviewed by Brady Eidson.
875
876         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
877         (WebKit::NetscapePluginInstanceProxy::getProxy):
878         * Plugins/WebNetscapePluginView.mm:
879         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
880
881 2018-02-17  Darin Adler  <darin@apple.com>
882
883         Prepare for ExtendedColor changes (first step)
884         https://bugs.webkit.org/show_bug.cgi?id=182904
885
886         Reviewed by Sam Weinig.
887
888         * Misc/WebKitNSStringExtras.mm:
889         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
890
891 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
892
893         Remove currentTime() / currentTimeMS()
894         https://bugs.webkit.org/show_bug.cgi?id=183052
895
896         Reviewed by Mark Lam.
897
898         * WebCoreSupport/WebFrameLoaderClient.h:
899         * WebCoreSupport/WebFrameLoaderClient.mm:
900         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
901
902 2018-02-16  Youenn Fablet  <youenn@apple.com>
903
904         Allow specifying which plug-ins are supported
905         https://bugs.webkit.org/show_bug.cgi?id=182748
906
907         Reviewed by Chris Dumez.
908
909         * WebCoreSupport/WebPluginInfoProvider.h:
910         * WebCoreSupport/WebPluginInfoProvider.mm:
911         (WebPluginInfoProvider::getPluginInfo):
912         (WebPluginInfoProvider::getWebVisiblePluginInfo):
913
914 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
915
916         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
917         https://bugs.webkit.org/show_bug.cgi?id=182882
918         <rdar://problem/35672661>
919
920         Reviewed by Dan Bernstein.
921
922         Make sure the smart pointer hold the collection of subviews lives at least as
923         long as the loop using it.
924
925         * WebView/WebHTMLView.mm:
926         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
927
928 2018-02-14  Daniel Bates  <dabates@apple.com>
929
930         Disallow cross-origin subresources from asking for credentials
931         https://bugs.webkit.org/show_bug.cgi?id=182579
932         <rdar://problem/36162271>
933
934         Reviewed by Andy Estes.
935
936         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
937         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
938
939         * WebView/WebPreferenceKeysPrivate.h:
940         * WebView/WebPreferences.mm:
941         (+[WebPreferences initialize]):
942         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
943         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
944         * WebView/WebPreferencesPrivate.h:
945         * WebView/WebView.mm:
946         (-[WebView _preferencesChanged:]):
947
948 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
949
950         Remove ForwardingHeaders directory from WebKitLegacy/mac.
951         https://bugs.webkit.org/show_bug.cgi?id=182738
952
953         Reviewed by Darin Adler.
954
955         * ForwardingHeaders/collector/handles/Global.h: Removed.
956         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
957         * ForwardingHeaders/runtime/Completion.h: Removed.
958         * ForwardingHeaders/runtime/Error.h: Removed.
959         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
960         * ForwardingHeaders/runtime/JSFunction.h: Removed.
961         * ForwardingHeaders/runtime/JSLock.h: Removed.
962         * ForwardingHeaders/runtime/JSObject.h: Removed.
963         * ForwardingHeaders/runtime/JSString.h: Removed.
964         * ForwardingHeaders/runtime/Protect.h: Removed.
965         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
966
967 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
968
969         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
970         https://bugs.webkit.org/show_bug.cgi?id=182641
971
972         Reviewed by Dan Bernstein.
973
974         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
975         https://trac.webkit.org/changeset/228308.
976
977         * WebView/WebVideoFullscreenController.h:
978         * WebView/WebVideoFullscreenHUDWindowController.mm:
979         * WebView/WebWindowAnimation.h:
980         * WebView/WebWindowAnimation.mm:
981         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
982         (WebCore::scaledRect): Deleted.
983         (WebCore::squaredDistance): Deleted.
984
985 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
986
987         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
988
989         * WebView/WebWindowAnimation.mm:
990         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
991
992 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
993
994         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
995         https://bugs.webkit.org/show_bug.cgi?id=182615
996
997         Reviewed by Eric Carlson.
998
999         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
1000         Ideally, we should not reference NSApp in WebCore.
1001
1002         * WebView/WebFullScreenController.mm:
1003         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
1004         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
1005         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
1006         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
1007         * WebView/WebView.mm:
1008         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
1009         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
1010
1011 2018-01-13  Darin Adler  <darin@apple.com>
1012
1013         Event improvements
1014         https://bugs.webkit.org/show_bug.cgi?id=179591
1015
1016         Reviewed by Chris Dumez.
1017
1018         * DOM/DOMWheelEvent.mm:
1019         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
1020         Call initWebKitWheelEvent.
1021
1022         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
1023         * WebCoreSupport/WebInspectorClient.mm: Ditto.
1024         * WebView/WebFrame.mm: Ditto.
1025
1026         * WebView/WebHTMLView.mm:
1027         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
1028         underlyingPlatformEvent.
1029         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
1030
1031         * WebView/WebScriptWorld.mm:
1032         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
1033
1034         * WebView/WebView.mm: Removed include of ScriptValue.h.
1035
1036 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1037
1038         Remove WebCore/ForwardingHeaders directory
1039         https://bugs.webkit.org/show_bug.cgi?id=182347
1040
1041         Reviewed by Keith Miller.
1042
1043         * Carbon/CarbonWindowAdapter.mm:
1044         * DOM/WebDOMOperations.mm:
1045         * History/WebBackForwardList.mm:
1046         * History/WebHistoryItem.mm:
1047         * Misc/WebCache.mm:
1048         * Misc/WebElementDictionary.mm:
1049         * Misc/WebIconDatabase.mm:
1050         * Misc/WebStringTruncator.mm:
1051         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1052         * Plugins/Hosted/ProxyInstance.mm:
1053         * Plugins/Hosted/ProxyRuntimeObject.mm:
1054         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1055         * Plugins/WebBaseNetscapePluginView.mm:
1056         * Plugins/WebBasePluginPackage.mm:
1057         * Plugins/WebNetscapePluginStream.mm:
1058         * Plugins/WebNetscapePluginView.mm:
1059         * Plugins/WebPluginController.mm:
1060         * WebCoreSupport/WebEditorClient.mm:
1061         * WebCoreSupport/WebFrameLoaderClient.mm:
1062         * WebCoreSupport/WebInspectorClient.h:
1063         * WebCoreSupport/WebInspectorClient.mm:
1064         * WebView/WebDataSource.mm:
1065         * WebView/WebFrame.mm:
1066         * WebView/WebHTMLRepresentation.mm:
1067         * WebView/WebHTMLView.mm:
1068         * WebView/WebPreferences.mm:
1069         * WebView/WebScriptDebugDelegate.mm:
1070         * WebView/WebScriptDebugger.h:
1071         * WebView/WebTextIterator.mm:
1072         * WebView/WebView.mm:
1073         * WebView/WebViewData.mm:
1074
1075 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
1076
1077         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
1078         https://bugs.webkit.org/show_bug.cgi?id=182312
1079
1080         Reviewed by Michael Catanzaro.
1081
1082         * WebKitPrefix.h:
1083
1084 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
1085
1086         [WebAuthN] Add a compile-time feature flag
1087         https://bugs.webkit.org/show_bug.cgi?id=182211
1088         <rdar://problem/36936365>
1089
1090         Reviewed by Brent Fulgham.
1091
1092         * Configurations/FeatureDefines.xcconfig:
1093
1094 2018-01-27  Dan Bernstein  <mitz@apple.com>
1095
1096         HaveInternalSDK includes should be "#include?"
1097         https://bugs.webkit.org/show_bug.cgi?id=179670
1098
1099         * Configurations/Base.xcconfig:
1100
1101 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1102
1103         Remove unused QTKit preference
1104         https://bugs.webkit.org/show_bug.cgi?id=181968
1105
1106         Reviewed by Alexey Proskuryakov.
1107
1108         * WebView/WebPreferenceKeysPrivate.h:
1109         * WebView/WebPreferences.mm:
1110         (+[WebPreferences initialize]):
1111         (-[WebPreferences setQTKitEnabled:]): Deleted.
1112         (-[WebPreferences isQTKitEnabled]): Deleted.
1113         * WebView/WebPreferencesPrivate.h:
1114         * WebView/WebView.mm:
1115         (-[WebView _preferencesChanged:]):
1116
1117 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1118
1119         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
1120         https://bugs.webkit.org/show_bug.cgi?id=182037
1121         <rdar://problem/36747812>
1122
1123         Reviewed by Ryosuke Niwa.
1124
1125         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
1126         for more details.
1127
1128         * WebView/WebHTMLRepresentation.mm:
1129         (-[WebHTMLRepresentation elementWithName:inForm:]):
1130         (-[WebHTMLRepresentation controlsInForm:]):
1131
1132 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1133
1134         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
1135         https://bugs.webkit.org/show_bug.cgi?id=181961
1136
1137         Reviewed by Michael Catanzaro.
1138
1139         * WebView/WebPreferences.mm:
1140
1141 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1142
1143         Unreviewed, rolling out r227437.
1144         https://bugs.webkit.org/show_bug.cgi?id=182011
1145
1146         broke build (Requested by alexchristensen on #webkit).
1147
1148         Reverted changeset:
1149
1150         "Remove unused QTKit preference"
1151         https://bugs.webkit.org/show_bug.cgi?id=181968
1152         https://trac.webkit.org/changeset/227437
1153
1154 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1155
1156         Remove unused QTKit preference
1157         https://bugs.webkit.org/show_bug.cgi?id=181968
1158
1159         Reviewed by Alexey Proskuryakov.
1160
1161         * WebView/WebPreferenceKeysPrivate.h:
1162         * WebView/WebPreferences.mm:
1163         (+[WebPreferences initialize]):
1164         (-[WebPreferences setQTKitEnabled:]): Deleted.
1165         (-[WebPreferences isQTKitEnabled]): Deleted.
1166         * WebView/WebPreferencesPrivate.h:
1167         * WebView/WebView.mm:
1168         (-[WebView _preferencesChanged:]):
1169
1170 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1171
1172         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
1173         https://bugs.webkit.org/show_bug.cgi?id=181960
1174         <rdar://problem/36431678>
1175
1176         Reviewed by Tim Horton.
1177
1178         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
1179         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
1180         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
1181
1182         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
1183         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
1184         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
1185
1186         * WebView/WebView.mm:
1187         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1188
1189 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
1190
1191         Turning off custom pasteboard data doesn't actually turn it off in WK2
1192         https://bugs.webkit.org/show_bug.cgi?id=181920
1193         <rdar://problem/36686429>
1194
1195         Reviewed by Wenson Hsieh.
1196
1197         Always disable custom pasteboard data in WebKit1. See r226156 for details.
1198
1199         * WebView/WebPreferences.mm:
1200         (+[WebPreferences initialize]):
1201         * WebView/WebView.mm:
1202         (-[WebView _preferencesChanged:]):
1203
1204 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1205
1206         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1207         https://bugs.webkit.org/show_bug.cgi?id=181918
1208
1209         Reviewed by Tim Horton.
1210
1211         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1212
1213         * Configurations/FeatureDefines.xcconfig:
1214
1215 2018-01-20  Andy Estes  <aestes@apple.com>
1216
1217         [Apple Pay] Stop eagerly loading PassKit.framework
1218         https://bugs.webkit.org/show_bug.cgi?id=181911
1219         <rdar://problem/36555369>
1220
1221         Reviewed by Tim Horton.
1222
1223         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1224         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1225         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1226
1227         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1228
1229 2018-01-19  Dean Jackson  <dino@apple.com>
1230
1231         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1232         https://bugs.webkit.org/show_bug.cgi?id=181817
1233         <rdar://problem/35274055>
1234
1235         Reviewed by Simon Fraser.
1236
1237         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1238
1239         * Misc/WebKitVersionChecks.h:
1240         * WebView/WebView.mm:
1241         (-[WebView _commonInitializationWithFrameName:groupName:]):
1242
1243 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1244
1245         Remove unused WebViewPrivate _allowCookies
1246         https://bugs.webkit.org/show_bug.cgi?id=181812
1247
1248         Reviewed by Tim Horton.
1249
1250         * WebView/WebView.mm:
1251         (+[WebView _setAllowCookies:]): Deleted.
1252         (+[WebView _allowCookies]): Deleted.
1253         * WebView/WebViewPrivate.h:
1254
1255 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1256
1257         Build fix, remove a call to -[NSWindow setOneShot:]
1258         https://bugs.webkit.org/show_bug.cgi?id=181809
1259
1260         Reviewed by Tim Horton.
1261
1262         * WebView/WebTextCompletionController.mm:
1263         (-[WebTextCompletionController _buildUI]):
1264
1265 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1266
1267         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1268
1269         * Carbon/HIWebView.mm:
1270         (overrideCGContext):
1271         (restoreCGContext):
1272
1273 2018-01-18  Dan Bernstein  <mitz@apple.com>
1274
1275         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1276         https://bugs.webkit.org/show_bug.cgi?id=181803
1277
1278         Reviewed by Tim Horton.
1279
1280         * Configurations/Base.xcconfig: Updated.
1281         * Configurations/DebugRelease.xcconfig: Ditto.
1282         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1283         * Configurations/Version.xcconfig: Updated.
1284         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1285           useful for defining settings that depend on the target macOS version.
1286
1287 2018-01-17  Youenn Fablet  <youenn@apple.com>
1288
1289         Put fetch Request.keepalive behind a runtime flag
1290         https://bugs.webkit.org/show_bug.cgi?id=181592
1291
1292         Reviewed by Chris Dumez.
1293
1294         * WebView/WebPreferenceKeysPrivate.h:
1295         * WebView/WebPreferences.mm:
1296         (+[WebPreferences initialize]):
1297         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1298         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1299         * WebView/WebPreferencesPrivate.h:
1300         * WebView/WebView.mm:
1301         (-[WebView _preferencesChanged:]):
1302
1303 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1304
1305         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1306         https://bugs.webkit.org/show_bug.cgi?id=181637
1307         <rdar://problem/36508471>
1308
1309         Reviewed by Tim Horton.
1310
1311         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1312
1313         * WebCoreSupport/WebEditorClient.h:
1314         * WebCoreSupport/WebEditorClient.mm:
1315         (WebEditorClient::replacementURLForResource):
1316
1317 2018-01-11  Keith Miller  <keith_miller@apple.com>
1318
1319         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1320         https://bugs.webkit.org/show_bug.cgi?id=181573
1321
1322         Reviewed by Simon Fraser.
1323
1324         * Configurations/FeatureDefines.xcconfig:
1325
1326 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1327
1328         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1329         https://bugs.webkit.org/show_bug.cgi?id=181497
1330
1331         Reviewed by Tim Horton.
1332
1333         See other ChangeLogs for more detail.
1334
1335         * WebCoreSupport/WebDragClient.h:
1336
1337 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1338
1339         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1340         https://bugs.webkit.org/show_bug.cgi?id=181523
1341         <rdar://problem/28959131>
1342
1343         Reviewed by Alex Christensen.
1344
1345         * WebView/WebImmediateActionController.mm:
1346         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1347         Apply the change made in r216652 to WebKit1's immediate action controller.
1348
1349         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1350         the startContainer of the range is in an anonymous node.
1351
1352 2018-01-11  Youenn Fablet  <youenn@apple.com>
1353
1354         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1355         https://bugs.webkit.org/show_bug.cgi?id=181480
1356
1357         Reviewed by Eric Carlson.
1358
1359         * WebView/WebPreferences.mm:
1360         (+[WebPreferences initialize]):
1361
1362 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1363
1364         Fix check-webkit-style issues with WebNSDataExtras.mm
1365         <https://webkit.org/b/181369>
1366
1367         Reviewed by Alex Christensen.
1368
1369         * Misc/WebNSDataExtras.mm:
1370         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1371         (-[NSData _webkit_guessedMIMETypeForXML]):
1372         (-[NSData _webkit_guessedMIMEType]):
1373         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1374         (_findEOL):
1375         (-[NSData _webkit_parseRFC822HeaderFields]):
1376         (-[NSData _web_locationAfterFirstBlankLine]):
1377         - Fix all the check-webkit-style warnings.
1378
1379 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1380
1381         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1382         <https://webkit.org/b/181256>
1383         <rdar://problem/36281730>
1384
1385         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1386         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1387         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1388           to avoid warnings from casting CFStringRef to NPNSString*.
1389           Note that CFMutableStringRef is the same as CFStringRef
1390           without the const modifier, hence its use in the const_cast<>
1391           above.
1392
1393 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1394
1395         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1396         <https://webkit.org/b/181256>
1397         <rdar://problem/36281730>
1398
1399         * Carbon/HIWebView.mm:
1400         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1401         checked_cf_cast<CFRunLoopRef>() to fix warning.
1402
1403 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1404
1405         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1406         <https://webkit.org/b/181256>
1407         <rdar://problem/36281730>
1408
1409         Reviewed by Darin Adler.
1410
1411         * Carbon/CarbonUtils.m:
1412         (PoolCleaner):
1413         - Use #pragmas to ignore -Wcast-qual warnings when using a
1414           C-style cast from CFTypeRef to CFRunloopRef.
1415         * Carbon/CarbonWindowFrame.m:
1416         (-[CarbonWindowFrame title]):
1417         - Use #pragmas to ignore -Wcast-qual warnings when using a
1418           C-style cast from CFStringRef to NSString *.
1419         * Carbon/HIViewAdapter.m:
1420         (+[HIViewAdapter getHIViewForNSView:]):
1421         - Use #pragmas to ignore -Wcast-qual warnings when using a
1422           C-style cast from CFTypeRef to HIViewRef.
1423         * Configurations/Base.xcconfig:
1424         (WARNING_CFLAGS): Add -Wcast-qual.
1425         * Misc/WebElementDictionary.mm:
1426         (-[WebElementDictionary objectForKey:]):
1427         - Use static_cast<SEL>(const_cast<void*>()) to fix
1428           warning.
1429         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1430         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1431         (-[NSData _webkit_guessedMIMETypeForXML]):
1432         (-[NSData _webkit_guessedMIMEType]):
1433         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1434         (_findEOL):
1435         (-[NSData _webkit_parseRFC822HeaderFields]):
1436         (-[NSData _web_startsWithBlankLine]):
1437         (-[NSData _web_locationAfterFirstBlankLine]):
1438         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1439           type to Objective-C++.  This fixes the warnings about
1440           discarding the `const` modifier when casing from CFStringRef
1441           to NSString * because in older clang versions, -Wcast-qual was
1442           completely broken when compiling C++ and Objective-C++ source
1443           files.  In newer clang versions, discarding the `const`
1444           modifier for toll-free bridged types is ignored when compiling
1445           Objective-C++ source.
1446         - Update copyright and license header.
1447         - Use reinterpret_cast<> and static_cast<> to fix warnings
1448           unrelated to (NSString *) C-style casts.
1449         - Replace use of MIN() macro with std::min<> template functions.
1450         - Fix location of `*` for local variables modified above.
1451         * Plugins/Hosted/NetscapePluginHostManager.mm:
1452         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1453         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1454         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1455         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1456           warnings.
1457         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1458         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1459         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1460           to fix warning.
1461         * Plugins/Hosted/ProxyInstance.mm:
1462         (WebKit::ProxyInstance::invoke):
1463         - Use static_cast<char*>(const_cast<void*>()) to fix
1464           warning when using -[NSData bytes].
1465         (WebKit::ProxyInstance::fieldValue const):
1466         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1467           to fix warning when using CFDataGetBytePtr().
1468         * Plugins/Hosted/WebTextInputWindowController.m:
1469         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1470         - Use #pragma to ignore -Wcast-qual warning since there
1471           is not a good way to avoid this warning in Objective-C.
1472         * Plugins/WebNetscapePluginStream.mm:
1473         (WebNetscapePluginStream::deliverData):
1474         - Use const_cast<void*>() to fix warning when using
1475           -[NSData bytes].
1476         * Plugins/WebNetscapePluginView.mm:
1477         (-[WebNetscapePluginView _createPlugin]):
1478         - Change C-style cast to const_cast<char*>() to fix
1479           warning.
1480         * WebCoreSupport/WebChromeClient.mm:
1481         (WebChromeClient::wrapCryptoKey const):
1482         (WebChromeClient::unwrapCryptoKey const):
1483         - Change C-style cast to
1484           static_cast<uint8_t*>(const_cast<void*>() to fix
1485           warning.
1486         * WebView/WebPDFView.mm:
1487         (_applicationInfoForMIMEType):
1488         - Change local variable type from 'NSURL *' to
1489           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1490           when calling -[NSURL path].
1491
1492 2018-01-05  Dan Bernstein  <mitz@apple.com>
1493
1494         Fixed the build following AppKit API deprecations in a recent SDKs
1495
1496         * WebView/WebFullScreenController.mm:
1497         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1498         (-[WebFullScreenController exitFullScreen]): Ditto.
1499         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1500         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1501         * WebView/WebHTMLView.mm:
1502         (-[WebHTMLView drawRect:]): Ditto.
1503         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1504         (-[WebHTMLView knowsPageRange:]): Ditto.
1505         * WebView/WebView.mm:
1506         (LayerFlushController::flushLayers): Ditto.
1507
1508 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1509
1510         [Attachment Support] Create attachment elements when dropping files on iOS
1511         https://bugs.webkit.org/show_bug.cgi?id=181192
1512         <rdar://problem/36280945>
1513
1514         Reviewed by Tim Horton.
1515
1516         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1517
1518         * WebCoreSupport/WebPlatformStrategies.h:
1519         * WebCoreSupport/WebPlatformStrategies.mm:
1520         (WebPlatformStrategies::informationForItemAtIndex):
1521         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1522
1523 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1524
1525         [Attachment Support] Add plumbing for starting a drag with promised blob data
1526         https://bugs.webkit.org/show_bug.cgi?id=181201
1527
1528         Reviewed by Tim Horton.
1529
1530         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1531
1532         * WebCoreSupport/WebDragClient.h:
1533
1534 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1535
1536         Add a WebAuthentication runtime feature flag
1537         https://bugs.webkit.org/show_bug.cgi?id=181220
1538         <rdar://problem/36055305>
1539
1540         Reviewed by Brent Fulgham.
1541
1542         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1543
1544         * WebView/WebPreferenceKeysPrivate.h:
1545         * WebView/WebPreferences.mm:
1546         (+[WebPreferences initialize]):
1547         (-[WebPreferences webAuthenticationEnabled]):
1548         (-[WebPreferences setWebAuthenticationEnabled:]):
1549         (-[WebPreferences credentialManagementEnabled]): Deleted.
1550         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1551         * WebView/WebPreferencesPrivate.h:
1552         * WebView/WebView.mm:
1553         (-[WebView _preferencesChanged:]):
1554
1555 2017-12-22  Jeff Miller  <jeffm@apple.com>
1556
1557         Update user-visible copyright strings to include 2018
1558         https://bugs.webkit.org/show_bug.cgi?id=181141
1559
1560         Reviewed by Dan Bernstein.
1561
1562         * Info.plist:
1563
1564 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1565
1566         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1567         https://bugs.webkit.org/show_bug.cgi?id=181188
1568
1569         Reviewed by Dan Bernstein.
1570
1571         See WebCore/ChangeLog for more detail.
1572
1573         * WebCoreSupport/WebDragClient.h:
1574         * WebCoreSupport/WebDragClient.mm:
1575         (WebDragClient::declareAndWriteAttachment): Deleted.
1576         * WebView/WebHTMLView.mm:
1577         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1578
1579 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1580
1581         Unreviewed, continue to fix build failures due to AppKit API deprecation
1582
1583         Wraps more code in -Wdeprecated-declarations.
1584
1585         * Carbon/HIWebView.mm:
1586         (overrideCGContext):
1587
1588 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1589
1590         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1591
1592         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1593
1594         * Carbon/CarbonWindowAdapter.mm:
1595         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1596         * Plugins/WebNetscapePluginView.mm:
1597         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1598         (-[WebNetscapePluginView sendDrawRectEvent:]):
1599         (-[WebNetscapePluginView drawRect:]):
1600
1601 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1602
1603         Fix build failures due to using deprecated AppKit symbols
1604         https://bugs.webkit.org/show_bug.cgi?id=181110
1605         <rdar://problem/36162865>
1606
1607         Reviewed by Dan Bernstein and Tim Horton.
1608
1609         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1610
1611         * Misc/WebKitNSStringExtras.mm:
1612         (-[NSString _web_drawAtPoint:font:textColor:]):
1613         * Misc/WebNSPasteboardExtras.h:
1614         * Misc/WebNSPasteboardExtras.mm:
1615         (+[NSPasteboard _web_writableTypesForURL]):
1616         (_createWritableTypesForImageWithoutArchive):
1617         (_createWritableTypesForImageWithArchive):
1618         (+[NSPasteboard _web_dragTypesForURL]):
1619         (-[NSPasteboard _web_bestURL]):
1620         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1621         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1622         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1623         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1624         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1625         * Panels/WebAuthenticationPanel.m:
1626         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1627         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1628         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1629         (-[WebHostedNetscapePluginView drawRect:]):
1630         * WebInspector/WebNodeHighlightView.mm:
1631         (-[WebNodeHighlightView drawRect:]):
1632         * WebView/WebFrame.mm:
1633         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1634         (-[WebFrame _drawRect:contentsOnly:]):
1635         * WebView/WebHTMLView.mm:
1636         (kit):
1637         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1638         (-[WebHTMLView _plainTextFromPasteboard:]):
1639         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1640         (+[WebHTMLView _insertablePasteboardTypes]):
1641         (+[WebHTMLView _selectionPasteboardTypes]):
1642         (-[WebHTMLView pasteboard:provideDataForType:]):
1643         (-[WebHTMLView _writeSelectionToPasteboard:]):
1644         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1645         (-[WebHTMLView validRequestorForSendType:returnType:]):
1646         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1647         (createMenuItem):
1648         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1649         (-[WebHTMLView _colorAsString:]):
1650         (-[WebHTMLView copyFont:]):
1651         * WebView/WebPDFView.mm:
1652         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1653         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1654         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1655         (-[WebPDFView pasteboardTypesForSelection]):
1656         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1657         * WebView/WebView.h:
1658         * WebView/WebView.mm:
1659         (-[WebView performDragOperation:]):
1660         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1661         (-[WebView _searchWithGoogleFromMenu:]):
1662
1663 2017-12-21  Youenn Fablet  <youenn@apple.com>
1664
1665         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1666         https://bugs.webkit.org/show_bug.cgi?id=181000
1667
1668         Reviewed by Chris Dumez.
1669
1670         * Misc/WebCache.mm:
1671         (+[WebCache addImageToCache:forURL:forFrame:]):
1672
1673 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1674
1675         Update FULLSCREEN_API feature defines.
1676         https://bugs.webkit.org/show_bug.cgi?id=181015
1677
1678         Reviewed by Tim Horton.
1679
1680         Change enabled iphone sdk for FULLSCREEN_API.
1681
1682         * Configurations/FeatureDefines.xcconfig:
1683
1684 2017-12-21  Jer Noble  <jer.noble@apple.com>
1685
1686         Add initial DOM support for Media Capabilities
1687         https://bugs.webkit.org/show_bug.cgi?id=181064
1688
1689         Reviewed by Eric Carlson.
1690
1691         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1692
1693         * WebView/WebPreferenceKeysPrivate.h:
1694         * WebView/WebPreferences.mm:
1695         (+[WebPreferences initialize]):
1696         (-[WebPreferences mediaCapabilitiesEnabled]):
1697         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1698         * WebView/WebPreferencesPrivate.h:
1699         * WebView/WebView.mm:
1700         (-[WebView _preferencesChanged:]):
1701
1702 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1703
1704         Enable picture-in-picture from inline element on suspend.
1705         https://bugs.webkit.org/show_bug.cgi?id=180942
1706         rdar://problem/34745234
1707
1708         Reviewed by Jer Noble.
1709
1710         Update signature of enterVideoFullscreenForVideoElement().
1711
1712         * WebCoreSupport/WebChromeClient.h:
1713         * WebCoreSupport/WebChromeClient.mm:
1714         (WebChromeClient::enterVideoFullscreenForVideoElement):
1715
1716 2017-12-20  Daniel Bates  <dabates@apple.com>
1717
1718         Remove Alternative Presentation Button
1719         https://bugs.webkit.org/show_bug.cgi?id=180500
1720         <rdar://problem/35891047>
1721
1722         Reviewed by Simon Fraser.
1723
1724         We no longer need the alternative presentation button.
1725
1726         * Configurations/FeatureDefines.xcconfig:
1727
1728 2017-12-19  Jer Noble  <jer.noble@apple.com>
1729
1730         Playing media elements which call "pause(); play()" will have the play promise rejected.
1731         https://bugs.webkit.org/show_bug.cgi?id=180781
1732         <rdar://problem/33191377>
1733
1734         Reviewed by Eric Carlson.
1735
1736         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1737
1738         * WebView/WebView.mm:
1739         (shouldRequireUserGestureToLoadVideo):
1740
1741 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1742
1743         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1744         https://bugs.webkit.org/show_bug.cgi?id=180977
1745
1746         Reviewed by Tim Horton.
1747
1748         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1749         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1750         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1751
1752         * WebCoreSupport/WebEditorClient.mm:
1753         (attributesForAttributedStringConversion):
1754         * WebView/WebHTMLView.mm:
1755         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1756
1757 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1758
1759         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1760
1761         Attempt to fix the following warnings:
1762
1763             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1764
1765         For the following instance variables:
1766
1767             _borderView
1768             _contentView
1769             _frame
1770             _wFlags
1771
1772         * Carbon/CarbonWindowAdapter.mm:
1773         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1774         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1775         (-[CarbonWindowAdapter _termWindowIfOwner]):
1776         (-[CarbonWindowAdapter _windowMovedToRect:]):
1777         (-[CarbonWindowAdapter setContentView:]):
1778         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1779         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1780
1781 2017-12-16  Dan Bernstein  <mitz@apple.com>
1782
1783         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1784         https://bugs.webkit.org/show_bug.cgi?id=180613
1785         <rdar://problem/35946124>
1786
1787         Reviewed by Geoff Garen.
1788
1789         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1790           clients.
1791         * WebView/WebDynamicScrollBarsView.h: Ditto.
1792         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1793
1794 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1795
1796         Enable -Wstrict-prototypes for WebKit
1797         <https://webkit.org/b/180757>
1798         <rdar://problem/36024132>
1799
1800         Rubber-stamped by Joseph Pecoraro.
1801
1802         * Configurations/Base.xcconfig:
1803         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1804
1805 2017-12-14  John Wilander  <wilander@apple.com>
1806
1807         Storage Access API: Implement frame-specific access in the document.cookie layer
1808         https://bugs.webkit.org/show_bug.cgi?id=180682
1809         <rdar://problem/35982257>
1810
1811         Reviewed by Alex Christensen.
1812
1813         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1814         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1815         CookiesStrategy::getRawCookies() now take optional parameters for
1816         frameID and pageID to allow frame-specific scoping of cookies.
1817
1818         This change makes the return values of FrameLoaderClient::frameID()
1819         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1820         WebCore can call those getters and get the right return values in
1821         WebKit and std:nullopt in WebKitLegacy.
1822
1823         * WebCoreSupport/WebFrameLoaderClient.h:
1824         * WebCoreSupport/WebFrameLoaderClient.mm:
1825         (WebFrameLoaderClient::pageID const):
1826         (WebFrameLoaderClient::frameID const):
1827         * WebCoreSupport/WebPlatformStrategies.h:
1828         * WebCoreSupport/WebPlatformStrategies.mm:
1829         (WebPlatformStrategies::cookiesForDOM):
1830         (WebPlatformStrategies::setCookiesFromDOM):
1831         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1832         (WebPlatformStrategies::getRawCookies):
1833
1834 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1835
1836         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1837         https://bugs.webkit.org/show_bug.cgi?id=180689
1838
1839         Reviewed by Tim Horton.
1840
1841         Use sRGBColorSpaceRef() from WebCore.
1842
1843         * WebView/WebHTMLView.mm:
1844         (imageFromRect):
1845
1846 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1847
1848         Stop using deprecated target conditional for simulator builds
1849         https://bugs.webkit.org/show_bug.cgi?id=180662
1850         <rdar://problem/35136156>
1851
1852         Reviewed by Simon Fraser.
1853
1854         * postprocess-headers.sh:
1855
1856 2017-12-11  David Quesada  <david_quesada@apple.com>
1857
1858         Turn on ENABLE_APPLICATION_MANIFEST
1859         https://bugs.webkit.org/show_bug.cgi?id=180562
1860         rdar://problem/35924737
1861
1862         Reviewed by Geoffrey Garen.
1863
1864         * Configurations/FeatureDefines.xcconfig:
1865
1866 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1867
1868         Remove pthread_once in favor of dispatch_once
1869         https://bugs.webkit.org/show_bug.cgi?id=180591
1870
1871         Reviewed by Saam Barati.
1872
1873         * Misc/WebKitErrors.m:
1874         (+[NSError _registerWebKitErrors]):
1875         (registerErrors): Deleted.
1876         * Storage/WebStorageManager.mm:
1877         (+[WebStorageManager _storageDirectoryPath]):
1878         (initializeLocalStoragePath): Deleted.
1879
1880 2017-12-07  Darin Adler  <darin@apple.com>
1881
1882         Remove some unused code from WebKitLegacy
1883         https://bugs.webkit.org/show_bug.cgi?id=180567
1884
1885         Reviewed by Anders Carlsson.
1886
1887         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1888         macOS (back a few versions) and iOS and removed unused
1889         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1890         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1891         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1892         _webkit_stringByCollapsingNonPrintingCharacters,
1893         _webkit_stringByCollapsingWhitespaceCharacters,
1894         _web_stringWithData:textEncodingName:, and
1895         _webkit_localStorageDirectoryWithBundleIdentifier:.
1896
1897         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1898         this source file.
1899         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1900         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1901         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1902         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1903         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1904         handle font smoothing options.
1905         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1906         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1907         from header and made it a little clearer.
1908         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1909         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1910         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1911         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1912         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1913         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1914         implementation a bit and used whole words instead of abbreviations.
1915         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1916
1917         * Misc/WebNSFileManagerExtras.mm:
1918         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1919         filenameByFixingIllegalCharacters function from WebCore directly instead of
1920         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1921
1922         * Plugins/WebBaseNetscapePluginView.mm:
1923         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1924         string replacements instead of _web_stringByStrippingReturnCharacters
1925         and to use NSString methods instead of CFString functions.
1926
1927 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1928
1929         Ignore deprecation warnings.
1930
1931         * WebView/WebHTMLView.mm:
1932         (-[NSWindow _web_borderView]):
1933         (-[WebHTMLView _setAsideSubviews]):
1934         * WebView/WebView.mm:
1935         (-[WebView encodeWithCoder:]):
1936
1937 2017-12-02  Darin Adler  <darin@apple.com>
1938
1939         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1940         https://bugs.webkit.org/show_bug.cgi?id=180009
1941
1942         Reviewed by Alex Christensen.
1943
1944         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1945
1946         * Plugins/WebBaseNetscapePluginView.mm:
1947         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1948         of strcasecmp.
1949
1950         * WebView/WebPreferences.mm:
1951         (contains): Ditto. Also made this a template so it's easier to call on an array.
1952         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1953
1954 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1955
1956         Limit user agent versioning to an upper bound
1957         https://bugs.webkit.org/show_bug.cgi?id=180365
1958         <rdar://problem/34550617>
1959
1960         Reviewed by Joseph Pecoraro.
1961
1962         * WebView/WebView.mm:
1963         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1964         creating the User Agent string.
1965         (webKitBundleVersionString): Deleted.
1966
1967 2017-12-05  Andy Estes  <aestes@apple.com>
1968
1969         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1970         https://bugs.webkit.org/show_bug.cgi?id=180457
1971         <rdar://problem/35143007>
1972
1973         Reviewed by Tim Horton.
1974
1975         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1976         check for this macro during post-processing.
1977
1978         * postprocess-headers.sh:
1979
1980 2017-12-04  David Quesada  <david_quesada@apple.com>
1981
1982         Add a class for parsing application manifests
1983         https://bugs.webkit.org/show_bug.cgi?id=177973
1984         rdar://problem/34747949
1985
1986         Reviewed by Geoffrey Garen.
1987
1988         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1989
1990 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1991
1992         Make LegacyCustomProtocolManager optional for network process
1993         https://bugs.webkit.org/show_bug.cgi?id=176230
1994
1995         Reviewed by Alex Christensen.
1996
1997         * Configurations/FeatureDefines.xcconfig:
1998
1999 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
2000
2001         Fix some NSOperationQueue leaks
2002         https://bugs.webkit.org/show_bug.cgi?id=180221
2003
2004         Reviewed by Wenson Hsieh.
2005
2006         * WebView/WebView.mm:
2007         (-[WebView performDragOperation:]):
2008
2009 2017-11-30  Darin Adler  <darin@apple.com>
2010
2011         [Mac] remove unneeded RetainPtr use introduced in r225142
2012         https://bugs.webkit.org/show_bug.cgi?id=180202
2013
2014         Reviewed by Tim Horton.
2015
2016         * WebView/WebImmediateActionController.mm:
2017         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
2018         RetainPtr.
2019
2020 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
2021
2022         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
2023         https://bugs.webkit.org/show_bug.cgi?id=175595
2024
2025         Reviewed by Darin Adler.
2026
2027         * WebView/WebPreferences.mm:
2028
2029 2017-11-27  Tim Horton  <timothy_horton@apple.com>
2030
2031         One too many zeroes in macOS version number in FeatureDefines
2032         https://bugs.webkit.org/show_bug.cgi?id=180011
2033
2034         Reviewed by Dan Bernstein.
2035
2036         * Configurations/FeatureDefines.xcconfig:
2037
2038 2017-11-23  Darin Adler  <darin@apple.com>
2039
2040         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2041         https://bugs.webkit.org/show_bug.cgi?id=179981
2042
2043         Reviewed by Sam Weinig.
2044
2045         * WebView/WebImmediateActionController.mm:
2046         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
2047         * WebView/WebView.mm:
2048         (coreOptions): Use |= instead of | to build up FindOptions.
2049
2050 2017-11-23  Sam Weinig  <sam@webkit.org>
2051
2052         Remove unneeded ScriptController::processingUserGesture() forwarding functions
2053         https://bugs.webkit.org/show_bug.cgi?id=179954
2054
2055         Reviewed by Darin Adler.
2056
2057         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
2058         with direct calls to the corresponding UserGestureIndicator functions.
2059
2060         * Plugins/WebPluginController.mm:
2061         (-[WebPluginController processingUserGesture]):
2062         * WebView/WebView.mm:
2063         (-[WebView _isProcessingUserGesture]):
2064
2065 2017-11-23  Darin Adler  <darin@apple.com>
2066
2067         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2068         https://bugs.webkit.org/show_bug.cgi?id=179907
2069
2070         Reviewed by Sam Weinig.
2071
2072         * History/BinaryPropertyList.cpp:
2073         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
2074         (BinaryPropertyListSerializer::appendStringObject): Ditto.
2075         * WebView/WebHTMLRepresentation.mm:
2076         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
2077         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
2078
2079 2017-11-22  Ali Juma  <ajuma@chromium.org>
2080
2081         Implement VisualViewport API attributes
2082         https://bugs.webkit.org/show_bug.cgi?id=179385
2083
2084         Reviewed by Frédéric Wang.
2085
2086         Add a VisualViewportAPI preference.
2087
2088         * WebView/WebPreferenceKeysPrivate.h:
2089         * WebView/WebPreferences.mm:
2090         (+[WebPreferences initialize]):
2091         (-[WebPreferences visualViewportAPIEnabled]):
2092         (-[WebPreferences setVisualViewportAPIEnabled:]):
2093         * WebView/WebPreferencesPrivate.h:
2094         * WebView/WebView.mm:
2095         (-[WebView _preferencesChanged:]):
2096
2097 2017-11-22  Christopher Reid  <chris.reid@sony.com>
2098
2099         WebCoreObjCExtras.h is being included in too many places
2100         https://bugs.webkit.org/show_bug.cgi?id=179931
2101
2102         Reviewed by Darin Adler.
2103
2104         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2105         * Plugins/WebBaseNetscapePluginView.mm:
2106         * Plugins/WebBasePluginPackage.mm:
2107         * Plugins/WebNetscapePluginStream.mm:
2108         * Plugins/WebNetscapePluginView.mm:
2109         * WebView/WebTextIterator.mm:
2110         * WebView/WebViewData.mm:
2111
2112 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2113
2114         Unreviewed, rolling out r225093.
2115         https://bugs.webkit.org/show_bug.cgi?id=179938
2116
2117         Compilation failed on WinCairo 64-bit Release (Requested by
2118         fredw on #webkit).
2119
2120         Reverted changeset:
2121
2122         "Implement VisualViewport API attributes"
2123         https://bugs.webkit.org/show_bug.cgi?id=179385
2124         https://trac.webkit.org/changeset/225093
2125
2126 2017-11-21  Ali Juma  <ajuma@chromium.org>
2127
2128         Implement VisualViewport API attributes
2129         https://bugs.webkit.org/show_bug.cgi?id=179385
2130
2131         Reviewed by Frédéric Wang.
2132
2133         Add a VisualViewportAPI preference.
2134
2135         * WebView/WebPreferenceKeysPrivate.h:
2136         * WebView/WebPreferences.mm:
2137         (+[WebPreferences initialize]):
2138         (-[WebPreferences visualViewportAPIEnabled]):
2139         (-[WebPreferences setVisualViewportAPIEnabled:]):
2140         * WebView/WebPreferencesPrivate.h:
2141         * WebView/WebView.mm:
2142         (-[WebView _preferencesChanged:]):
2143
2144 2017-11-21  Christopher Reid  <chris.reid@sony.com>
2145
2146         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
2147         https://bugs.webkit.org/show_bug.cgi?id=179504
2148
2149         Reviewed by Darin Adler.
2150
2151         * Misc/WebKitNSStringExtras.mm:
2152         * Plugins/Hosted/NetscapePluginHostManager.mm:
2153         * Plugins/WebBasePluginPackage.mm:
2154
2155 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2156
2157         Remove unused TOUCH_ICON_LOADING feature flag
2158         https://bugs.webkit.org/show_bug.cgi?id=179873
2159
2160         Reviewed by Simon Fraser.
2161
2162         * Configurations/FeatureDefines.xcconfig:
2163
2164 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2165
2166         Remove unused LEGACY_VENDOR_PREFIXES feature flag
2167         https://bugs.webkit.org/show_bug.cgi?id=179872
2168
2169         Reviewed by Darin Adler.
2170
2171         * Configurations/FeatureDefines.xcconfig:
2172
2173 2017-11-16  Daniel Bates  <dabates@apple.com>
2174
2175         Add feature define for alternative presentation button element
2176         https://bugs.webkit.org/show_bug.cgi?id=179692
2177         Part of <rdar://problem/34917108>
2178
2179         Reviewed by Andy Estes.
2180
2181         Only enabled on Cocoa platforms by default.
2182
2183         * Configurations/FeatureDefines.xcconfig:
2184
2185 2017-11-14  Nan Wang  <n_wang@apple.com>
2186
2187         AX: AOM: Implement AccessibleNode class and support label and role attributes
2188         https://bugs.webkit.org/show_bug.cgi?id=179494
2189
2190         Reviewed by Ryosuke Niwa.
2191
2192         * WebView/WebPreferenceKeysPrivate.h:
2193         * WebView/WebPreferences.mm:
2194         (+[WebPreferences initialize]):
2195         (-[WebPreferences accessibilityObjectModelEnabled]):
2196         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
2197         * WebView/WebPreferencesPrivate.h:
2198         * WebView/WebView.mm:
2199         (-[WebView _preferencesChanged:]):
2200
2201 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2202
2203         Remove Cocoa CFURLConnection loading code
2204         https://bugs.webkit.org/show_bug.cgi?id=179688
2205
2206         Reviewed by Antti Koivisto.
2207
2208         * Misc/WebDownload.mm:
2209         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2210         * Misc/WebDownloadInternal.h:
2211         * Plugins/WebBaseNetscapePluginView.mm:
2212         * WebCoreSupport/WebFrameLoaderClient.mm:
2213         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2214         * WebView/WebView.mm:
2215         (-[WebView scheduleInRunLoop:forMode:]):
2216         (-[WebView unscheduleFromRunLoop:forMode:]):
2217
2218 2017-11-14  Daniel Bates  <dabates@apple.com>
2219
2220         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
2221         for feature defines
2222
2223         Following r195498 and r201917 the Visual Studio property files for feature defines have
2224         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2225         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2226         files.
2227
2228         * Configurations/FeatureDefines.xcconfig:
2229
2230 2017-11-14  Jer Noble  <jer.noble@apple.com>
2231
2232         Enable Modern EME tests in DumpRenderTree
2233         https://bugs.webkit.org/show_bug.cgi?id=179544
2234
2235         Reviewed by Alex Christensen.
2236
2237         Add a WebPreferences property to enable the (modern) EME API.
2238
2239         * WebView/WebPreferenceKeysPrivate.h:
2240         * WebView/WebPreferences.mm:
2241         (+[WebPreferences initialize]):
2242         (-[WebPreferences encryptedMediaAPIEnabled]):
2243         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2244         * WebView/WebPreferencesPrivate.h:
2245         * WebView/WebView.mm:
2246         (-[WebView _preferencesChanged:]):
2247
2248 2017-11-14  Antti Koivisto  <antti@apple.com>
2249
2250         Enable display:contents by default
2251         https://bugs.webkit.org/show_bug.cgi?id=179655
2252
2253         Reviewed by Sam Weinig.
2254
2255         * WebView/WebPreferences.mm:
2256         (+[WebPreferences initialize]):
2257
2258 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2259
2260         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2261         https://bugs.webkit.org/show_bug.cgi?id=178751
2262
2263         Reviewed by Brady Eidson.
2264
2265         * WebCoreSupport/WebFrameNetworkingContext.mm:
2266         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2267
2268 2017-11-08  Keith Miller  <keith_miller@apple.com>
2269
2270         Async iteration should only fetch the next method once and add feature flag
2271         https://bugs.webkit.org/show_bug.cgi?id=179451
2272
2273         Reviewed by Geoffrey Garen.
2274
2275         Add feature flag for Async iteration.
2276
2277         * Configurations/FeatureDefines.xcconfig:
2278
2279 2017-11-13  Mark Lam  <mark.lam@apple.com>
2280
2281         Add more overflow check book-keeping for MarkedArgumentBuffer.
2282         https://bugs.webkit.org/show_bug.cgi?id=179634
2283         <rdar://problem/35492517>
2284
2285         Reviewed by Saam Barati.
2286
2287         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2288         (WebKit::NetscapePluginInstanceProxy::invoke):
2289         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2290         (WebKit::NetscapePluginInstanceProxy::construct):
2291
2292 2017-11-12  Darin Adler  <darin@apple.com>
2293
2294         More is<> and downcast<>, less static_cast<>
2295         https://bugs.webkit.org/show_bug.cgi?id=179600
2296
2297         Reviewed by Chris Dumez.
2298
2299         * DOM/DOM.mm:
2300         (kit): Use is/downcast.
2301         * WebCoreSupport/WebEditorClient.mm:
2302         (WebEditorClient::handleKeyboardEvent): Ditto.
2303         (WebEditorClient::handleInputMethodKeydown): Ditto.
2304         * WebView/WebHTMLView.mm:
2305         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2306
2307 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2308
2309         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2310         https://bugs.webkit.org/show_bug.cgi?id=179397
2311
2312         Reviewed by Wenson Hsieh.
2313
2314         * DOM/DOMHTMLInputElement.mm:
2315         (-[DOMHTMLInputElement insertTextSuggestion:]):
2316
2317 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2318
2319         HTMLMediaElement should not use element fullscreen on iOS
2320         https://bugs.webkit.org/show_bug.cgi?id=179418
2321         rdar://problem/35409277
2322
2323         Reviewed by Eric Carlson.
2324
2325         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2326
2327         * Configurations/FeatureDefines.xcconfig:
2328
2329 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2330
2331         Make ResourceLoader::willSendRequestInternal asynchronous
2332         https://bugs.webkit.org/show_bug.cgi?id=179251
2333
2334         Reviewed by Andy Estes.
2335
2336         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2337         (WebKit::HostedNetscapePluginStream::start):
2338         * Plugins/WebNetscapePluginStream.mm:
2339         (WebNetscapePluginStream::start):
2340
2341 2017-11-01  Darin Adler  <darin@apple.com>
2342
2343         Simplify event dispatch code and make it a bit more consistent
2344         https://bugs.webkit.org/show_bug.cgi?id=178991
2345
2346         Reviewed by Chris Dumez.
2347
2348         * DOM/DOMEvent.mm:
2349         (-[DOMEvent srcElement]): Call target instead of srcElement.
2350
2351 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2352
2353         [Touch Bar Web API] Add support for menuitem tag
2354         https://bugs.webkit.org/show_bug.cgi?id=179020
2355
2356         Reviewed by Ryosuke Niwa.
2357
2358         Adds in properties and methods that allow the menuitem runtime feature
2359         to be enabled or disabled.
2360
2361         * WebView/WebPreferenceKeysPrivate.h:
2362         * WebView/WebPreferences.mm:
2363         (-[WebPreferences menuItemElementEnabled]):
2364         (-[WebPreferences setMenuItemElementEnabled:]):
2365         * WebView/WebPreferencesPrivate.h:
2366         * WebView/WebView.mm:
2367         (-[WebView _preferencesChanged:]):
2368
2369 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2370
2371         Use CompletionHandlers for redirects
2372         https://bugs.webkit.org/show_bug.cgi?id=179163
2373
2374         Reviewed by Tim Horton.
2375
2376         * Plugins/Hosted/HostedNetscapePluginStream.h:
2377         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2378         (WebKit::HostedNetscapePluginStream::willSendRequest):
2379         * Plugins/WebNetscapePluginStream.h:
2380         * Plugins/WebNetscapePluginStream.mm:
2381         (WebNetscapePluginStream::willSendRequest):
2382
2383 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2384
2385         Add a FileSystem namespace to FileSystem.cpp
2386         https://bugs.webkit.org/show_bug.cgi?id=179063
2387
2388         Reviewed by Darin Adler.
2389
2390         * Misc/WebNSFileManagerExtras.mm:
2391         * Storage/WebDatabaseProvider.mm:
2392
2393 2017-11-02  Frederic Wang  <fwang@igalia.com>
2394
2395         Add references to bug 179167 in FIXME comments
2396         https://bugs.webkit.org/show_bug.cgi?id=179168
2397
2398         Reviewed by Daniel Bates.
2399
2400         * Configurations/FeatureDefines.xcconfig:
2401
2402 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2403
2404         Implement WKFullscreenWindowController for iOS.
2405         https://bugs.webkit.org/show_bug.cgi?id=178924
2406         rdar://problem/34697120
2407
2408         Reviewed by Simon Fraser.
2409
2410         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2411
2412         * Configurations/FeatureDefines.xcconfig:
2413         * WebView/WebView.mm:
2414         (-[WebView fullScreenPlaceholderView]):
2415
2416 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2417
2418         Clean up some drag and drop feature flags
2419         https://bugs.webkit.org/show_bug.cgi?id=179082
2420
2421         Reviewed by Simon Fraser.
2422
2423         * Configurations/FeatureDefines.xcconfig:
2424
2425 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2426
2427         Make it possible to test rubber-banding in overflow scroll
2428         https://bugs.webkit.org/show_bug.cgi?id=179078
2429
2430         Reviewed by Sam Weinig.
2431
2432         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2433         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2434
2435         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2436         functions, since most callers want clamped.
2437
2438         * DOM/DOMHTML.mm:
2439         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2440
2441 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2442
2443         Fix up some content filtering feature flags
2444         https://bugs.webkit.org/show_bug.cgi?id=179079
2445
2446         Reviewed by Simon Fraser.
2447
2448         * Configurations/FeatureDefines.xcconfig:
2449
2450 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2451
2452         [FrameView::layout cleanup] Move core layout logic to a separate class.
2453         https://bugs.webkit.org/show_bug.cgi?id=178771
2454         <rdar://problem/35166542>
2455
2456         Reviewed by Simon Fraser.
2457
2458         Move layout code out from FrameView to LayoutContext.
2459
2460         * WebView/WebClipView.mm:
2461         (-[WebClipView _immediateScrollToPoint:]):
2462         * WebView/WebFrame.mm:
2463         (-[WebFrame layoutCount]):
2464
2465 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2466
2467         Fix issues with WebView subframe painting
2468         https://bugs.webkit.org/show_bug.cgi?id=178842
2469         rdar://problem/34072253
2470
2471         Reviewed by Daniel Bates.
2472         
2473         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2474         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2475         High Sierra, so match the new signature.
2476
2477         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2478
2479         * WebView/WebHTMLView.mm:
2480         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2481         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2482
2483 2017-10-25  Youenn Fablet  <youenn@apple.com>
2484
2485         Enable ServiceWorker to fetch resources
2486         https://bugs.webkit.org/show_bug.cgi?id=178673
2487
2488         Reviewed by Brady Eidson.
2489
2490         * WebCoreSupport/WebFrameLoaderClient.mm:
2491         (WebFrameLoaderClient::pageID const):
2492         (WebFrameLoaderClient::frameID const):
2493         (WebFrameLoaderClient::sessionID const):
2494
2495         Added implementation to the new getters.
2496         They are noop in the context of WK1.
2497
2498 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2499
2500         Web Inspector: Enable WebKit logging configuration and display
2501         https://bugs.webkit.org/show_bug.cgi?id=177027
2502         <rdar://problem/33964767>
2503
2504         Reviewed by Joseph Pecoraro.
2505
2506         * WebCoreSupport/WebChromeClient.mm:
2507         (stringForMessageSource): Deal with Media and WebRTC message sources.
2508
2509 2017-10-20  Antoine Quint  <graouts@apple.com>
2510
2511         [Web Animations] Provide basic timeline and animation interfaces
2512         https://bugs.webkit.org/show_bug.cgi?id=178526
2513
2514         Reviewed by Dean Jackson.
2515
2516         Remove the WEB_ANIMATIONS compile-time flag.
2517
2518         * Configurations/FeatureDefines.xcconfig:
2519         * WebView/WebPreferences.mm:
2520         (+[WebPreferences initialize]):
2521         * WebView/WebView.mm:
2522         (-[WebView _preferencesChanged:]):
2523
2524 2017-10-19  Sam Weinig  <sam@webkit.org>
2525
2526         [Settings] Move global settings into their own file
2527         https://bugs.webkit.org/show_bug.cgi?id=178512
2528
2529         Reviewed by Darin Adler.
2530
2531         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2532
2533         * WebCoreSupport/WebChromeClient.mm:
2534         (WebChromeClient::supportsVideoFullscreen):
2535         * WebView/WebDynamicScrollBarsView.mm:
2536         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2537         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2538         * WebView/WebPreferences.mm:
2539         (+[WebPreferences initialize]):
2540         * WebView/WebView.mm:
2541         (-[WebView _commonInitializationWithFrameName:groupName:]):
2542         (-[WebView _preferencesChanged:]):
2543         (+[WebView _doNotStartObservingNetworkReachability]):
2544
2545 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2546
2547         Replace some stack raw pointers with RefPtrs within WebCore/html
2548         https://bugs.webkit.org/show_bug.cgi?id=178201
2549         <rdar://problem/34841692>
2550
2551         Reviewed by Ryosuke Niwa.
2552
2553         * DOM/DOM.mm:
2554         (kit):
2555         Change the type of node as toNode() is changed to return RefPtr.
2556
2557 2017-10-18  Chris Dumez  <cdumez@apple.com>
2558
2559         [Service Worker] Add stubs for Client / WindowClient / Clients
2560         https://bugs.webkit.org/show_bug.cgi?id=178469
2561
2562         Reviewed by Youenn Fablet.
2563
2564         Rename PageVisiblityState to VisibilityState.
2565
2566         * WebView/WebView.mm:
2567         (kit):
2568
2569 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2570
2571         Unreviewed, rolling out r223291.
2572
2573         See WebCore ChangeLog for more detail.
2574
2575         Reverted changeset:
2576
2577         "Remove Editor::simplifyMarkup"
2578         https://bugs.webkit.org/show_bug.cgi?id=178271
2579         https://trac.webkit.org/changeset/223291
2580
2581 2017-10-17  Keith Miller  <keith_miller@apple.com>
2582
2583         Change WebCore sources to work with unified source builds
2584         https://bugs.webkit.org/show_bug.cgi?id=178229
2585
2586         Rubber stamped by Tim Horton.
2587
2588         * Configurations/FeatureDefines.xcconfig:
2589
2590 2017-10-16  Sam Weinig  <sam@webkit.org>
2591
2592         [Settings] Remove all custom code from Settings.h/cpp
2593         https://bugs.webkit.org/show_bug.cgi?id=178330
2594
2595         Reviewed by Simon Fraser.
2596
2597         * WebView/WebPreferences.mm:
2598         (+[WebPreferences initialize]):
2599         
2600             Update for naming changes of FrameFlattening now that it is an enum class.
2601
2602 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2603
2604         Remove Editor::simplifyMarkup
2605         https://bugs.webkit.org/show_bug.cgi?id=178271
2606
2607         Reviewed by Wenson Hsieh.
2608
2609         * WebView/WebView.mm:
2610         (-[WebView _simplifyMarkup:endNode:]):
2611
2612 2017-10-12  Chris Dumez  <cdumez@apple.com>
2613
2614         [Mac] Add support for MouseEvent.buttons
2615         https://bugs.webkit.org/show_bug.cgi?id=178214
2616
2617         Reviewed by Ryosuke Niwa.
2618
2619         * WebView/WebPDFView.mm:
2620         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2621
2622 2017-10-11  Sam Weinig  <sam@webkit.org>
2623
2624         Remove out-parameter variants of copyToVector
2625         https://bugs.webkit.org/show_bug.cgi?id=178155
2626
2627         Reviewed by Tim Horton.
2628
2629         * Plugins/WebNetscapePluginView.mm:
2630         (-[WebNetscapePluginView destroyPlugin]):
2631         * WebView/WebHTMLRepresentation.mm:
2632         (newArrayWithStrings):
2633
2634             Replace out-parameter based copyToVector, with one that returns a Vector.
2635
2636 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2637
2638         Sanitize URL in pasteboard for other applications and cross origin content
2639         https://bugs.webkit.org/show_bug.cgi?id=178060
2640         <rdar://problem/34874518>
2641
2642         Reviewed by Wenson Hsieh.
2643
2644         * WebCoreSupport/WebPlatformStrategies.h:
2645         * WebCoreSupport/WebPlatformStrategies.mm:
2646         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2647
2648 2017-10-11  Chris Dumez  <cdumez@apple.com>
2649
2650         Modernize Geolocation code
2651         https://bugs.webkit.org/show_bug.cgi?id=178148
2652
2653         Reviewed by Ryosuke Niwa.
2654
2655         * WebCoreSupport/WebGeolocationClient.h:
2656         * WebCoreSupport/WebGeolocationClient.mm:
2657         (WebGeolocationClient::lastPosition):
2658         * WebView/WebGeolocationPosition.mm:
2659         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2660         (core):
2661         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2662         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2663         * WebView/WebGeolocationPositionInternal.h:
2664
2665 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2666
2667         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2668         https://bugs.webkit.org/show_bug.cgi?id=178154
2669
2670         Reviewed by Wenson Hsieh.
2671
2672         Enable custom pasteboard data by default.
2673
2674         * WebView/WebPreferenceKeysPrivate.h:
2675         * WebView/WebPreferences.mm:
2676         (+[WebPreferences initialize]):
2677         (-[WebPreferences customPasteboardDataEnabled]): Added.
2678         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2679         * WebView/WebPreferencesPrivate.h:
2680         * WebView/WebView.mm:
2681         (-[WebView _preferencesChanged:]):
2682
2683 2017-10-10  Sam Weinig  <sam@webkit.org>
2684
2685         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2686         https://bugs.webkit.org/show_bug.cgi?id=178102
2687
2688         Reviewed by Tim Horton.
2689
2690         * History/WebHistory.mm:
2691         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2692         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2693         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2694         * WebCoreSupport/WebUserMediaClient.mm:
2695         (WebUserMediaClient::pageDestroyed):
2696
2697 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2698
2699         Make the names of the options consistent
2700         https://bugs.webkit.org/show_bug.cgi?id=177933
2701
2702         Reviewed by Saam Barati.
2703
2704         * WebView/WebFrame.h:
2705         * WebView/WebHTMLView.mm:
2706         (-[WebHTMLView setMarkedText:selectedRange:]):
2707         * WebView/WebView.h:
2708
2709 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2710
2711         [iOS] Tweak support for classifying form controls (followup to r222487)
2712         https://bugs.webkit.org/show_bug.cgi?id=177917
2713         <rdar://problem/34820122>
2714
2715         Reviewed by Dean Jackson.
2716
2717         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2718
2719         * DOM/DOMHTMLInputElement.mm:
2720         (-[DOMHTMLInputElement _autofillContext]):
2721         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2722         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2723
2724 2017-10-05  Keith Miller  <keith_miller@apple.com>
2725
2726         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2727
2728         * Configurations/WebKitLegacy.xcconfig:
2729
2730 2017-10-05  Jer Noble  <jer.noble@apple.com>
2731
2732         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2733         https://bugs.webkit.org/show_bug.cgi?id=177261
2734
2735         Reviewed by Eric Carlson.
2736
2737         * Configurations/FeatureDefines.xcconfig:
2738
2739 2017-10-05  Chris Dumez  <cdumez@apple.com>
2740
2741         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2742         https://bugs.webkit.org/show_bug.cgi?id=177957
2743
2744         Reviewed by Alex Christensen.
2745
2746         * WebCoreSupport/WebPlatformStrategies.h:
2747         * WebCoreSupport/WebPlatformStrategies.mm:
2748         (WebPlatformStrategies::cookiesEnabled):
2749
2750 2017-10-05  Youenn Fablet  <youenn@apple.com>
2751
2752         Make LibWebRTCProvider port agnostic
2753         https://bugs.webkit.org/show_bug.cgi?id=177747
2754
2755         Reviewed by Alex Christensen & Alex Garcia.
2756
2757         * WebView/WebView.mm:
2758         (-[WebView _commonInitializationWithFrameName:groupName:]):
2759         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2760
2761 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2762
2763         Stop linking with WebKitSystemInterface
2764         https://bugs.webkit.org/show_bug.cgi?id=177915
2765
2766         Reviewed by Antti Koivisto.
2767
2768         * Configurations/DebugRelease.xcconfig:
2769         * Configurations/WebKitLegacy.xcconfig:
2770
2771 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2772
2773         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2774         https://bugs.webkit.org/show_bug.cgi?id=177912
2775
2776         Reviewed by Saam Barati.
2777
2778         * Carbon/CarbonUtils.m:
2779         * Carbon/CarbonWindowAdapter.mm:
2780         * Carbon/HIWebView.mm:
2781         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2782         * Misc/WebNSFileManagerExtras.mm:
2783         * Misc/WebNSPasteboardExtras.mm:
2784         * Misc/WebNSURLExtras.mm:
2785         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2786         * Plugins/Hosted/NetscapePluginHostManager.mm:
2787         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2788         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2789         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2790         * Plugins/Hosted/WebTextInputWindowController.m:
2791         * Plugins/WebBaseNetscapePluginView.mm:
2792         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2793         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2794         * Plugins/WebNetscapePluginStream.mm:
2795         * Plugins/WebNetscapePluginView.mm:
2796         * Plugins/WebPluginDatabase.mm:
2797         * WebCoreSupport/PopupMenuMac.mm:
2798         * WebCoreSupport/WebChromeClient.mm:
2799         * WebCoreSupport/WebFrameLoaderClient.mm:
2800         * WebCoreSupport/WebInspectorClient.mm:
2801         * WebCoreSupport/WebPlatformStrategies.mm:
2802         * WebCoreSupport/WebSystemInterface.mm:
2803         * WebView/WebDynamicScrollBarsView.mm:
2804         * WebView/WebFrame.mm:
2805         * WebView/WebFrameView.mm:
2806         * WebView/WebFullScreenController.mm:
2807         * WebView/WebHTMLView.mm:
2808         * WebView/WebPreferences.mm:
2809         * WebView/WebView.mm:
2810
2811 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2812
2813         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2814         rdar://problem/34705779
2815
2816         Addressing review comments that I somehow landed without.
2817
2818         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2819
2820 2017-09-29  Chris Dumez  <cdumez@apple.com>
2821
2822         Split some logic out of VisitedLinkStore and make it reusable
2823         https://bugs.webkit.org/show_bug.cgi?id=177575
2824
2825         Reviewed by Alex Christensen.
2826
2827         * WebCoreSupport/WebVisitedLinkStore.h:
2828         * WebCoreSupport/WebVisitedLinkStore.mm:
2829         (WebVisitedLinkStore::addVisitedLink):
2830         (WebVisitedLinkStore::removeVisitedLink):
2831         (WebVisitedLinkStore::isLinkVisited):
2832         (WebVisitedLinkStore::addVisitedLinkHash):
2833
2834 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2835
2836         Build fix for High Sierra 32 bit Mac
2837         https://bugs.webkit.org/show_bug.cgi?id=177551
2838         <rdar://problem/34690283>
2839
2840         Reviewed by Alexey Proskuryakov.
2841
2842         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2843         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2844         also made.
2845
2846         * Carbon/CarbonWindowAdapter.mm:
2847         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2848         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2849         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2850         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2851         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2852         (-[CarbonWindowAdapter dealloc]):
2853         (-[CarbonWindowAdapter windowRef]):
2854         (-[CarbonWindowAdapter _hasWindowRef]):
2855         (-[CarbonWindowAdapter _managesWindowRef]):
2856         (-[CarbonWindowAdapter _removeWindowRef]):
2857         (-[CarbonWindowAdapter _carbonWindowClass]):
2858         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2859         (-[CarbonWindowAdapter sendSuperEvent:]):
2860         (-[CarbonWindowAdapter relinquishFocus]):
2861         (-[CarbonWindowAdapter _cancelKey:]):
2862         (-[CarbonWindowAdapter _commonAwake]):
2863         (-[CarbonWindowAdapter _destroyRealWindow:]):
2864         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2865         (-[CarbonWindowAdapter _termWindowIfOwner]):
2866         (-[CarbonWindowAdapter _windowMovedToRect:]):
2867         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2868         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2869         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2870         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2871         (-[CarbonWindowAdapter canBecomeMainWindow]):
2872         (-[CarbonWindowAdapter encodeWithCoder:]):
2873         (-[CarbonWindowAdapter initWithCoder:]):
2874         (-[CarbonWindowAdapter setContentView:]):
2875         (-[CarbonWindowAdapter worksWhenModal]):
2876         (-[CarbonWindowAdapter _setModalWindowLevel]):
2877         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2878         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2879         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2880         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2881         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2882         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2883         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2884         (NSCarbonWindowHandleEvent):
2885         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2886         (-[CarbonWindowAdapter _growBoxRect]):
2887         * Carbon/HIWebView.mm:
2888         (HIWebViewGetWebView):
2889         (HIWebViewConstructor):
2890         (HIWebViewDestructor):
2891         (HIWebViewRegisterClass):
2892         (GetBehaviors):
2893         (Draw):
2894         (HitTest):
2895         (GetRegion):
2896         (GetWindowRef):
2897         (CreateNSEventAdoptingCGEvent):
2898         (CopyEventCGEvent):
2899         (CreateNSEventWithCarbonClickEvent):
2900         (Click):
2901         (CreateNSEventWithCarbonEvent):
2902         (MouseUp):
2903         (CreateNSEventWithCarbonMouseMoveEvent):
2904         (MouseMoved):
2905         (MouseDragged):
2906         (MouseWheelMoved):
2907         (ContextMenuClick):
2908         (GetKind):
2909         (BoundsChanged):
2910         (OwningWindowChanged):
2911         (WindowHandler):
2912         (SyncFrame):
2913         (SetFocusPart):
2914         (AdvanceFocus):
2915         (RelinquishFocus):
2916         (ActiveStateChanged):
2917         (ProcessCommand):
2918         (UpdateCommandStatus):
2919         (_NSSelectorForHICommand):
2920         (HIWebViewEventHandler):
2921         (StartUpdateObserver):
2922         (StopUpdateObserver):
2923         (UpdateObserver):
2924
2925 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2926
2927         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2928         https://bugs.webkit.org/show_bug.cgi?id=172526
2929         <rdar://problem/32396081>
2930
2931         Reviewed by Ryosuke Niwa.
2932
2933         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2934
2935         * WebCoreSupport/WebPlatformStrategies.h:
2936         * WebCoreSupport/WebPlatformStrategies.mm:
2937         (WebPlatformStrategies::webExposedTypes):
2938         (WebPlatformStrategies::writeCustomData):
2939
2940 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2941
2942         Unreviewed, rolling out r222567.
2943
2944         This broke and internal build.
2945
2946         Reverted changeset:
2947
2948         "Build fix for High Sierra 32 bit Mac"
2949         https://bugs.webkit.org/show_bug.cgi?id=177551
2950         http://trac.webkit.org/changeset/222567
2951
2952 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2953
2954         Build fix for High Sierra 32 bit Mac
2955         https://bugs.webkit.org/show_bug.cgi?id=177551
2956         <rdar://problem/34690283>
2957
2958         Reviewed by Alexey Proskuryakov.
2959
2960         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2961         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2962         also made.
2963
2964         * Carbon/CarbonWindowAdapter.mm:
2965         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2966         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2967         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2968         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2969         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2970         (-[CarbonWindowAdapter dealloc]):
2971         (-[CarbonWindowAdapter windowRef]):
2972         (-[CarbonWindowAdapter _hasWindowRef]):
2973         (-[CarbonWindowAdapter _managesWindowRef]):
2974         (-[CarbonWindowAdapter _removeWindowRef]):
2975         (-[CarbonWindowAdapter _carbonWindowClass]):
2976         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2977         (-[CarbonWindowAdapter sendSuperEvent:]):
2978         (-[CarbonWindowAdapter relinquishFocus]):
2979         (-[CarbonWindowAdapter _cancelKey:]):
2980         (-[CarbonWindowAdapter _commonAwake]):
2981         (-[CarbonWindowAdapter _destroyRealWindow:]):
2982         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2983         (-[CarbonWindowAdapter _termWindowIfOwner]):
2984         (-[CarbonWindowAdapter _windowMovedToRect:]):
2985         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2986         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2987         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2988         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2989         (-[CarbonWindowAdapter canBecomeMainWindow]):
2990         (-[CarbonWindowAdapter encodeWithCoder:]):
2991         (-[CarbonWindowAdapter initWithCoder:]):
2992         (-[CarbonWindowAdapter setContentView:]):
2993         (-[CarbonWindowAdapter worksWhenModal]):
2994         (-[CarbonWindowAdapter _setModalWindowLevel]):
2995         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2996         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2997         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2998         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2999         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3000         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3001         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
3002         (NSCarbonWindowHandleEvent):
3003         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
3004         (-[CarbonWindowAdapter _growBoxRect]):
3005         * Carbon/HIWebView.mm:
3006         (HIWebViewGetWebView):
3007         (HIWebViewConstructor):
3008         (HIWebViewDestructor):
3009         (HIWebViewRegisterClass):
3010         (GetBehaviors):
3011         (Draw):
3012         (HitTest):
3013         (GetRegion):
3014         (GetWindowRef):
3015         (CreateNSEventAdoptingCGEvent):
3016         (CopyEventCGEvent):
3017         (CreateNSEventWithCarbonClickEvent):
3018         (Click):
3019         (CreateNSEventWithCarbonEvent):
3020         (MouseUp):
3021         (CreateNSEventWithCarbonMouseMoveEvent):
3022         (MouseMoved):
3023         (MouseDragged):
3024         (MouseWheelMoved):
3025         (ContextMenuClick):
3026         (GetKind):
3027         (BoundsChanged):
3028         (OwningWindowChanged):
3029         (WindowHandler):
3030         (SyncFrame):
3031         (SetFocusPart):
3032         (AdvanceFocus):
3033         (RelinquishFocus):
3034         (ActiveStateChanged):
3035         (ProcessCommand):
3036         (UpdateCommandStatus):
3037         (_NSSelectorForHICommand):
3038         (HIWebViewEventHandler):
3039         (StartUpdateObserver):
3040         (StopUpdateObserver):
3041         (UpdateObserver):
3042
3043 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3044
3045         Make PolicyAction an encodable enum class
3046         https://bugs.webkit.org/show_bug.cgi?id=177480
3047
3048         Reviewed by Antti Koivisto.
3049
3050         * Plugins/WebPluginContainerCheck.mm:
3051         (-[WebPluginContainerCheck _continueWithPolicy:]):
3052         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3053         * WebCoreSupport/WebFrameLoaderClient.mm:
3054         (-[WebFramePolicyListener invalidate]):
3055         (-[WebFramePolicyListener ignore]):
3056         (-[WebFramePolicyListener download]):
3057         (-[WebFramePolicyListener use]):
3058         (-[WebFramePolicyListener continue]):
3059         * WebView/WebPolicyDelegate.mm:
3060         (-[WebPolicyDecisionListener use]):
3061         (-[WebPolicyDecisionListener ignore]):
3062         (-[WebPolicyDecisionListener download]):
3063
3064 2017-09-25  Frederik Riedel  <riedel@apple.com>
3065
3066         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
3067         https://bugs.webkit.org/show_bug.cgi?id=174394
3068         <rdar://problem/33183504>
3069
3070         Reviewed by Ryosuke Niwa.
3071
3072         * DOM/DOMHTMLInputElement.h:
3073         * DOM/DOMHTMLInputElement.mm:
3074         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
3075         Determines if this HTMLInputElement is part of a login screen.
3076         (-[DOMHTMLInputElement representingPageUrl]):
3077         Returns the webpage's URL that is currently displayed in the Web View.
3078         (-[DOMHTMLInputElement insertTextSuggestion:]):
3079         Inserts login credentials into the Web View.
3080
3081 2017-09-25  Sam Weinig  <sam@webkit.org>
3082
3083         Remove unused EditorClient functions
3084         https://bugs.webkit.org/show_bug.cgi?id=177463
3085
3086         Reviewed by Alex Christensen.
3087
3088         Remove unused EditorClient functions.
3089
3090         * WebCoreSupport/WebEditorClient.h:
3091         * WebCoreSupport/WebEditorClient.mm:
3092         (WebEditorClient::canonicalizeURL): Deleted.
3093         (WebEditorClient::canonicalizeURLString): Deleted.
3094         (WebEditorClient::writeDataToPasteboard): Deleted.
3095         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
3096         (WebEditorClient::readDataFromPasteboard): Deleted.
3097         (WebEditorClient::pasteboardChangeCount): Deleted.
3098
3099 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3100
3101         Stop using PolicyCallback
3102         https://bugs.webkit.org/show_bug.cgi?id=176088
3103
3104         Reviewed by Andy Estes.
3105
3106         * WebCoreSupport/WebFrameLoaderClient.mm:
3107         (-[WebFramePolicyListener invalidate]):
3108         (-[WebFramePolicyListener receivedPolicyDecision:]):
3109
3110 2017-09-25  Sam Weinig  <sam@webkit.org>
3111
3112         Remove unnecessary userVisibleString EditorClient function
3113         https://bugs.webkit.org/show_bug.cgi?id=177456
3114
3115         Reviewed by Dan Bernstein.
3116
3117         * WebCoreSupport/WebEditorClient.h:
3118         * WebCoreSupport/WebEditorClient.mm:
3119         (WebEditorClient::userVisibleString): Deleted.
3120
3121             Remove userVisibleString client function.
3122
3123 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3124
3125         Separate form submission from PolicyChecker infrastructure
3126         https://bugs.webkit.org/show_bug.cgi?id=177396
3127
3128         Reviewed by Geoffrey Garen.
3129
3130         * WebCoreSupport/WebFrameLoaderClient.h:
3131         * WebCoreSupport/WebFrameLoaderClient.mm:
3132         (WebFrameLoaderClient::dispatchWillSubmitForm):
3133
3134 2017-09-22  Zalan Bujtas  <zalan@apple.com>
3135
3136         WeakPtrFactory should populate m_ref lazily.
3137         https://bugs.webkit.org/show_bug.cgi?id=177375
3138
3139         Reviewed by Geoffrey Garen.
3140
3141         * WebCoreSupport/WebEditorClient.mm:
3142         (WebEditorClient::WebEditorClient):
3143         (WebEditorClient::requestCandidatesForSelection):
3144
3145 2017-09-22  Chris Dumez  <cdumez@apple.com>
3146
3147         Use high resolution timestamp for event time
3148         https://bugs.webkit.org/show_bug.cgi?id=154246
3149         <rdar://problem/34333304>
3150
3151         Reviewed by Ryosuke Niwa.
3152
3153         Use WallTime / MonotonicTime instead of double type for clarity.
3154
3155         * DOM/DOMEvent.mm:
3156         (-[DOMEvent timeStamp]):
3157         * WebView/WebFrame.mm:
3158         (-[WebFrame _dragSourceEndedAt:operation:]):
3159         * WebView/WebPDFView.mm:
3160         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3161
3162 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3163
3164         Enable dataTransfer.items on macOS and iOS
3165         https://bugs.webkit.org/show_bug.cgi?id=177335
3166
3167         Reviewed by Sam Weinig.
3168
3169         * WebView/WebPreferences.mm:
3170         (+[WebPreferences initialize]):
3171
3172 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
3173
3174         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
3175         https://bugs.webkit.org/show_bug.cgi?id=177101
3176         <rdar://problem/34500648>
3177
3178         Reviewed by Brian Burg.
3179
3180         * WebInspector/WebNodeHighlight.mm:
3181         Ensure we close the window that we have just removed.
3182
3183 2017-09-20  Antti Koivisto  <antti@apple.com>
3184
3185         Remove DOM and styling support for CSS Regions
3186         https://bugs.webkit.org/show_bug.cgi?id=177221
3187
3188         Reviewed by Andreas Kling.
3189
3190         * Configurations/FeatureDefines.xcconfig:
3191         * DOM/DOMCSS.mm:
3192         (kitClass):
3193         * DOM/DOMElement.mm:
3194         (-[DOMElement webkitRegionOverset]): Deleted.
3195
3196 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
3197
3198         Layering violation in Editor::createFragment
3199         https://bugs.webkit.org/show_bug.cgi?id=176123
3200
3201         Reviewed by Darin Adler.
3202
3203         * Misc/WebNSURLExtras.h:
3204         * Misc/WebNSURLExtras.mm:
3205         * WebView/WebFrame.mm:
3206         * WebView/WebHTMLView.mm:
3207         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
3208
3209         * WebCoreSupport/WebEditorClient.mm:
3210         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
3211         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
3212         way to avoid exporting the symbol just on newer OSes.
3213
3214 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
3215
3216         On iOS, getData can't get text set by setData during copy event
3217         https://bugs.webkit.org/show_bug.cgi?id=176980
3218         <rdar://problem/34453915>
3219
3220         Reviewed by Darin Adler.
3221
3222         * WebCoreSupport/WebPlatformStrategies.h:
3223         * WebCoreSupport/WebPlatformStrategies.mm:
3224         (WebPlatformStrategies::copy): Deleted.
3225
3226 2017-09-18  Andy Estes  <aestes@apple.com>
3227
3228         [Mac] Upstream miscellaneous WebKitSystemInterface functions
3229         https://bugs.webkit.org/show_bug.cgi?id=177029
3230
3231         Reviewed by Alex Christensen.
3232
3233         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3234         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3235         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3236         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3237         * WebCoreSupport/PopupMenuMac.mm:
3238         (PopupMenuMac::show):
3239         * WebCoreSupport/WebSystemInterface.mm:
3240         (InitWebCoreSystemInterface):
3241         * WebView/WebHTMLView.mm:
3242         (-[WebHTMLView setDataSource:]):
3243         (-[WebHTMLView attachRootLayer:]):
3244         * WebView/WebView.mm:
3245         (-[WebView _needsAdobeFrameReloadingQuirk]):
3246         (-[WebView _needsLinkElementTextCSSQuirk]):
3247         (-[WebView _needsIsLoadingInAPISenseQuirk]):
3248         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
3249         (-[WebView _preferencesChanged:]):
3250
3251 2017-09-15  Andy Estes  <aestes@apple.com>
3252
3253         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
3254         https://bugs.webkit.org/show_bug.cgi?id=176953
3255
3256         Reviewed by Eric Carlson.
3257
3258         * WebCoreSupport/WebSystemInterface.mm:
3259         (InitWebCoreSystemInterface):
3260
3261 2017-09-14  Andy Estes  <aestes@apple.com>
3262
3263         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
3264         https://bugs.webkit.org/show_bug.cgi?id=176931
3265
3266         Reviewed by Joseph Pecoraro.
3267
3268         * WebCoreSupport/WebSystemInterface.mm:
3269         (InitWebCoreSystemInterface):
3270
3271 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3272
3273         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
3274         https://bugs.webkit.org/show_bug.cgi?id=176867
3275
3276         Reviewed by Sam Weinig.
3277
3278         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3279         (WebKit::NetscapePluginInstanceProxy::enumerate):
3280
3281 2017-09-13  Andy Estes  <aestes@apple.com>
3282
3283         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
3284         https://bugs.webkit.org/show_bug.cgi?id=176729
3285
3286         Reviewed by Alex Christensen.
3287
3288         * WebCoreSupport/WebSystemInterface.mm:
3289         (InitWebCoreSystemInterface):
3290         * WebView/WebView.mm:
3291         (+[WebView _setCacheModel:]):
3292
3293 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3294
3295         Refactor WebContentReader out of EditorMac and EditorIOS
3296         https://bugs.webkit.org/show_bug.cgi?id=176770
3297
3298         Reviewed by Sam Weinig.
3299
3300         * WebCoreSupport/WebEditorClient.mm:
3301
3302 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3303
3304         Dragging & dropping a file creates an attachment element even when it's disabled
3305         https://bugs.webkit.org/show_bug.cgi?id=176769
3306
3307         Reviewed by Tim Horton.
3308
3309         * WebView/WebView.mm:
3310         (-[WebView _preferencesChanged:]):
3311
3312 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3313
3314         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3315         https://bugs.webkit.org/show_bug.cgi?id=176721
3316         <rdar://problem/34373660>
3317
3318         Reviewed by Tim Horton.
3319
3320         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3321         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3322
3323         * WebView/WebView.mm:
3324         (-[WebView _startDrag:]):
3325         (-[WebView _draggedElementBounds]):
3326         (-[WebView _endedDataInteraction:global:]):
3327         * WebView/WebViewData.h:
3328
3329 2017-09-11  Andy Estes  <aestes@apple.com>
3330
3331         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3332         https://bugs.webkit.org/show_bug.cgi?id=176472
3333
3334         Reviewed by Eric Carlson.
3335
3336         * WebCoreSupport/WebSystemInterface.mm:
3337         (InitWebCoreSystemInterface):
3338
3339 2017-09-09  Mark Lam  <mark.lam@apple.com>
3340
3341         Avoid duplicate computations of ExecState::vm().
3342         https://bugs.webkit.org/show_bug.cgi?id=176647
3343
3344         Reviewed by Saam Barati.
3345
3346         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3347         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3348         (WebKit::NetscapePluginInstanceProxy::construct):
3349         (WebKit::NetscapePluginInstanceProxy::setProperty):
3350         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3351         (WebKit::NetscapePluginInstanceProxy::enumerate):
3352         * Plugins/Hosted/ProxyInstance.mm:
3353         (WebKit::ProxyRuntimeMethod::create):
3354
3355 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3356
3357         Unreviewed, rolling out r221773.
3358         https://bugs.webkit.org/show_bug.cgi?id=176614
3359
3360         This caused build failures. (Requested by mlewis13 on
3361         #webkit).
3362
3363         Reverted changeset:
3364
3365         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3366         https://bugs.webkit.org/show_bug.cgi?id=176472
3367         http://trac.webkit.org/changeset/221773
3368
3369 2017-09-07  Andy Estes  <aestes@apple.com>
3370
3371         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3372         https://bugs.webkit.org/show_bug.cgi?id=176472
3373
3374         Reviewed by Eric Carlson.
3375
3376         * WebCoreSupport/WebSystemInterface.mm:
3377         (InitWebCoreSystemInterface):
3378
3379 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3380
3381         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3382         https://bugs.webkit.org/show_bug.cgi?id=176561
3383
3384         Reviewed by Brent Fulgham.
3385
3386         * Misc/WebNSUserDefaultsExtras.mm:
3387
3388 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3389
3390         Modernize Geolocation code
3391         https://bugs.webkit.org/show_bug.cgi?id=176496
3392
3393         Reviewed by Andy Estes.
3394
3395         * WebCoreSupport/WebGeolocationClient.h:
3396         * WebCoreSupport/WebGeolocationClient.mm:
3397         (WebGeolocationClient::requestPermission):
3398         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3399         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3400         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3401         * WebView/WebView.mm:
3402         (-[WebView _commonInitializationWithFrameName:groupName:]):
3403         (-[WebView _geolocationDidFailWithMessage:]):
3404
3405 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3406
3407         Remove some unused bits of code and resources
3408         https://bugs.webkit.org/show_bug.cgi?id=176275
3409
3410         Reviewed by Dan Bernstein.
3411
3412         * Misc/WebNSFileManagerExtras.mm:
3413         Include FileSystem instead of FileSystemIOS.
3414
3415 2017-09-03  Darin Adler  <darin@apple.com>
3416
3417         [Cocoa] Tidy a few things in legacy WebHTMLView
3418         https://bugs.webkit.org/show_bug.cgi?id=176280
3419
3420         Reviewed by Dan Bernstein.
3421
3422         * WebCoreSupport/WebChromeClient.mm:
3423         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3424         methods it calls on WebHTMLView were doing nothing on iOS.
3425
3426         * WebView/WebFrame.mm:
3427         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3428         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3429
3430         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3431         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3432         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3433         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3434         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3435         Use RetainPtr instead of writing retain/release wherever possible.
3436         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3437         initialization for it. Removed various unused methods and declarations of methods.
3438         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3439         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3440         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3441         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3442         and remove CFRetain no longer needed since we don't support garbage collection any more.
3443         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3444         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3445         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3446         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3447         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3448         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3449         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3450         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3451         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3452         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3453         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3454         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3455         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3456         debug flag; we haven't used it for years and it's not clearly helpful.
3457         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3458         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3459         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3460         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3461         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3462         two additional methods in the WebPrivate category and still be called by the two
3463         methods in the WebInternal category that were already using it.
3464         (-[WebHTMLView didAddSubview:]): Deleted.
3465         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3466         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3467         place this was called, the close method.
3468         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3469         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3470         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3471         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3472         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3473         Added helper method to make the one below simpler.
3474         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3475         Compared pasteboard type strings using isEqualToString: rather than using == since
3476         we want to actually compare the string contents. Also updated to use modern for loop,
3477         renamed a local variable from "s" to "localSubresources", and factored out the handling
3478         of three image types to use the helper method above.
3479         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3480         _web_makePluginSubviewsPerformSelector:withObject: method.
3481         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3482         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3483         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3484         not call the -[NSView subviews] method to make this identical on both platforms and used
3485         a modern for loop.
3486         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3487         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3488         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3489         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3490         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3491         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3492         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3493         of it is Mac-only.
3494         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3495         method did was call itself on the main thread, and do nothing if called on main thread.
3496         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3497         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3498         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3499         half of this method.
3500         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3501         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3502         Simplified using a modern for loop and RetainPtr.
3503         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3504         (-[WebHTMLView keyDown:]): Ditto.
3505         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3506         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3507         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3508         (-[WebHTMLView complete:]): Ditto.
3509         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3510         now macOS-only.
3511         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3512         iOS since that is now macOS-only.
3513         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3514         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3515         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3516         and reorganized to use early return.
3517         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3518         on iOS, but kept there so we don't have to do #if at every call site.
3519         (-[WebHTMLView _pluginController]): Moved into internal category.
3520         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3521         there only for GC, using C++ initialization, removing obsolete comment.
3522         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3523         peculiar iOS-only comment.
3524         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3525
3526         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3527         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3528         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3529         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3530         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3531
3532         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3533         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3534         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3535         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3536         them at this time.
3537
3538 2017-09-03  Sam Weinig  <sam@webkit.org>
3539
3540         Remove CanvasProxy
3541         https://bugs.webkit.org/show_bug.cgi?id=176288
3542
3543         Reviewed by Yusuke Suzuki.
3544
3545         CanvasProxy does not appear to be in any current HTML spec
3546         and was disabled and unimplemented in our tree. Time to 
3547         get rid of it.
3548
3549         * Configurations/FeatureDefines.xcconfig:
3550
3551 2017-09-02  Andy Estes  <aestes@apple.com>
3552
3553         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3554         https://bugs.webkit.org/show_bug.cgi?id=176270
3555
3556         Reviewed by Tim Horton.
3557
3558         * Plugins/Hosted/NetscapePluginHostManager.mm:
3559         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3560         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3561         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3562         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3563         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3564         (WebKit::SoftwareCARenderer::context const):
3565         (WebKit::SoftwareCARenderer::renderContext const):
3566         (WebKit::SoftwareCARenderer::render):
3567         (-[WebHostedNetscapePluginView createPlugin]):
3568         (-[WebHostedNetscapePluginView createPluginLayer]):
3569         (-[WebHostedNetscapePluginView destroyPlugin]):
3570         (-[WebHostedNetscapePluginView drawRect:]):
3571         * WebCoreSupport/WebSystemInterface.mm:
3572         (InitWebCoreSystemInterface):
3573
3574 2017-09-01  Andy Estes  <aestes@apple.com>
3575
3576         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3577         https://bugs.webkit.org/show_bug.cgi?id=176200
3578
3579         Reviewed by Tim Horton.
3580
3581         * Carbon/HIWebView.mm:
3582         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3583         (overrideCGContext):
3584         (restoreCGContext):
3585         (Draw):
3586         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3587         (+[WebHostedNetscapePluginView initialize]):
3588         * Plugins/WebBaseNetscapePluginView.h:
3589         * Plugins/WebBaseNetscapePluginView.mm:
3590         (WebKit::sendUserChangeNotifications):
3591         * Plugins/WebNetscapePluginView.mm:
3592         (+[WebNetscapePluginView initialize]):
3593         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3594         * WebCoreSupport/WebSystemInterface.mm:
3595         (InitWebCoreSystemInterface):
3596         * WebView/WebFrame.mm:
3597         (-[WebFrame _paintBehaviorForDestinationContext:]):
3598         * WebView/WebFullScreenController.mm:
3599         (setClipRectForWindow):
3600         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3601         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3602         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3603         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3604
3605 2017-08-31  Andy Estes  <aestes@apple.com>
3606
3607         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3608         https://bugs.webkit.org/show_bug.cgi?id=176175
3609
3610         Reviewed by Brady Eidson.
3611
3612         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3613         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3614         * Plugins/Hosted/WebTextInputWindowController.m:
3615         (-[WebTextInputPanel init]):
3616         * WebCoreSupport/WebSystemInterface.mm:
3617         (InitWebCoreSystemInterface):
3618         * WebView/WebDynamicScrollBarsView.mm:
3619         (-[WebDynamicScrollBarsView scrollWheel:]):
3620         * WebView/WebHTMLView.mm:
3621         (-[WebHTMLView _removeWindowObservers]):
3622         (-[WebHTMLView addWindowObservers]):
3623         * WebView/WebView.mm:
3624         (-[WebView addWindowObserversForWindow:]):
3625         (-[WebView removeWindowObservers]):
3626         (-[WebView viewWillMoveToWindow:]):
3627
3628 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3629
3630         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3631         https://bugs.webkit.org/show_bug.cgi?id=175779
3632         <rdar://problem/22367975>
3633
3634         Reviewed by Tim Horton.
3635
3636         * WebCoreSupport/WebFrameLoaderClient.h:
3637         * WebCoreSupport/WebFrameLoaderClient.mm:
3638         (WebFrameLoaderClient::webGLPolicyForURL const):
3639         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3640
3641 2017-08-30  Andy Estes  <aestes@apple.com>
3642
3643         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3644         https://bugs.webkit.org/show_bug.cgi?id=176093
3645
3646         Reviewed by Eric Carlson.
3647
3648         * WebCoreSupport/WebSystemInterface.mm:
3649         (InitWebCoreSystemInterface):
3650
3651 2017-08-30  Andy Estes  <aestes@apple.com>
3652
3653         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3654         https://bugs.webkit.org/show_bug.cgi?id=176087
3655
3656         Reviewed by Alex Christensen.
3657
3658         * Carbon/CarbonUtils.m:
3659         (getNSAutoreleasePoolCount):
3660         (WebInitForCarbon):
3661         (PoolCleaner):
3662         * Carbon/CarbonWindowAdapter.mm:
3663         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3664         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3665         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3666         (-[CarbonWindowAdapter _windowMovedToRect:]):
3667         * Carbon/HIViewAdapter.m:
3668         * Carbon/HIWebView.mm:
3669         (Draw):
3670         (CreateNSEventAdoptingCGEvent):
3671         (CopyEventCGEvent):
3672         (CreateNSEventWithCarbonClickEvent):
3673         (Click):
3674         (CreateNSEventWithCarbonEvent):
3675         (MouseUp):
3676         (CreateNSEventWithCarbonMouseMoveEvent):
3677         (MouseMoved):
3678         (MouseDragged):
3679         (MouseWheelMoved):
3680         (WindowHandler):
3681         (HIWebViewEventHandler):
3682         * Misc/QuickDrawCompatibility.h: Removed.
3683         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3684         (getCarbonEvent):
3685         (WebNetscapePluginEventHandlerCarbon::keyDown):
3686         (WebNetscapePluginEventHandlerCarbon::keyUp):
3687         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3688         (WebNetscapePluginEventHandlerCocoa::keyDown):
3689         * Plugins/WebNetscapePluginView.mm:
3690         (-[WebNetscapePluginView tellQuickTimeToChill]):
3691
3692 2017-08-29  Andy Estes  <aestes@apple.com>
3693
3694         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3695         https://bugs.webkit.org/show_bug.cgi?id=176046
3696
3697         Reviewed by Alex Christensen.
3698
3699         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3700         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3701
3702         * Misc/WebNSFileManagerExtras.mm:
3703         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3704         (setMetaData): Deleted.
3705         * WebCoreSupport/WebSystemInterface.mm:
3706         (InitWebCoreSystemInterface):
3707
3708 2017-08-28  Andy Estes  <aestes@apple.com>
3709
3710         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3711         https://bugs.webkit.org/show_bug.cgi?id=176039
3712
3713         Reviewed by Alex Christensen.
3714
3715         * WebCoreSupport/WebSystemInterface.mm:
3716         (InitWebCoreSystemInterface):
3717         * WebView/WebPreferences.mm:
3718         (+[WebPreferences _systemCFStringEncoding]):
3719
3720 2017-08-28  Andy Estes  <aestes@apple.com>
3721
3722         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3723         https://bugs.webkit.org/show_bug.cgi?id=176032
3724
3725         Reviewed by Alex Christensen.
3726
3727         * WebCoreSupport/WebSystemInterface.mm:
3728         (InitWebCoreSystemInterface):
3729         * WebView/WebView.mm:
3730         (-[WebView _cachedResponseForURL:]):
3731
3732 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3733
3734         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3735         https://bugs.webkit.org/show_bug.cgi?id=175992
3736         <rdar://problem/34086613>
3737
3738         Reviewed by Daniel Bates.
3739
3740         * WebCoreSupport/WebPlatformStrategies.h:
3741         * WebCoreSupport/WebPlatformStrategies.mm:
3742         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3743         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3744         indicating if secure cookies were accessed.
3745
3746 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3747
3748         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3749         https://bugs.webkit.org/show_bug.cgi?id=170955
3750         <rdar://problem/31697653>
3751
3752         Reviewed by Ryosuke Niwa.
3753
3754         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3755         text is being replaced.
3756
3757         * WebView/WebHTMLView.mm:
3758         (-[WebHTMLView insertText:]):
3759
3760 2017-08-24  Chris Dumez  <cdumez@apple.com>
3761
3762         [Directory Upload] Add basic support for input.webkitdirectory
3763         https://bugs.webkit.org/show_bug.cgi?id=175950
3764         <rdar://problem/33951915>
3765
3766         Reviewed by Geoffrey Garen.
3767
3768         Add private API to toggle Directory Upload support on Mac WebKit1.
3769
3770         * WebView/WebPreferenceKeysPrivate.h:
3771         * WebView/WebPreferences.mm:
3772         (+[WebPreferences initialize]):
3773         (-[WebPreferences setDirectoryUploadEnabled:]):
3774         (-[WebPreferences directoryUploadEnabled]):
3775         * WebView/WebPreferencesPrivate.h:
3776         * WebView/WebView.mm:
3777         (-[WebView _preferencesChanged:]):
3778
3779 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3780
3781         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3782         https://bugs.webkit.org/show_bug.cgi?id=175370
3783         <rdar://problem/33799806>
3784
3785         Reviewed by Ryosuke Niwa.
3786
3787         Adjust WebEditorClient for interface changes.
3788
3789         * WebCoreSupport/WebEditorClient.h:
3790
3791 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3792
3793         Remove ChromeClient::scrollbarsModeDidChange
3794         https://bugs.webkit.org/show_bug.cgi?id=175805
3795
3796         Reviewed by Daniel Bates.
3797
3798         * WebCoreSupport/WebChromeClient.h:
3799
3800 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3801
3802         Remove ChromeClient::hasOpenedPopup
3803         https://bugs.webkit.org/show_bug.cgi?id=175804
3804
3805         Reviewed by Sam Weinig.
3806
3807         * WebCoreSupport/WebChromeClient.h:
3808         * WebCoreSupport/WebChromeClient.mm:
3809         (WebChromeClient::hasOpenedPopup const): Deleted.
3810
3811 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3812
3813         Disable access to secure cookies if an HTTPS site loads mixed content
3814         https://bugs.webkit.org/show_bug.cgi?id=157053
3815         <rdar://problem/11290808>
3816
3817         Reviewed by Dan Bates.
3818
3819         * WebCoreSupport/WebPlatformStrategies.h:
3820         * WebCoreSupport/WebPlatformStrategies.mm:
3821         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3822         indicating whether secure cookies should be included in the response.
3823
3824 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3825
3826         [PAL] Move spi/mac directory into PAL
3827         https://bugs.webkit.org/show_bug.cgi?id=175649
3828
3829         Reviewed by Myles C. Maxfield.
3830
3831         * Misc/WebSharingServicePickerController.h:
3832         * WebCoreSupport/WebContextMenuClient.mm:
3833         * WebCoreSupport/WebEditorClient.mm:
3834         * WebCoreSupport/WebSelectionServiceController.mm:
3835         * WebView/WebHTMLView.mm:
3836         * WebView/WebImmediateActionController.h:
3837         * WebView/WebImmediateActionController.mm:
3838         * WebView/WebView.mm:
3839
3840 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3841
3842         [PAL] Relocate SessionID to root
3843         https://bugs.webkit.org/show_bug.cgi?id=175684
3844
3845         Reviewed by Alex Christensen.
3846
3847         * WebCoreSupport/WebFrameNetworkingContext.mm:
3848
3849 2017-08-17  Andreas Kling  <akling@apple.com>
3850
3851         Disable CSS regions at compile time
3852         https://bugs.webkit.org/show_bug.cgi?id=175630
3853
3854         Reviewed by Antti Koivisto.
3855
3856         * Configurations/FeatureDefines.xcconfig:
3857
3858 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3859
3860         [PAL] Move SessionID into PAL
3861         https://bugs.webkit.org/show_bug.cgi?id=174192
3862
3863         Reviewed by Antti Koivisto.
3864
3865         * Misc/WebCache.mm:
3866         (+[WebCache imageForURL:]):
3867         * WebCoreSupport/WebFrameLoaderClient.h:
3868         * WebCoreSupport/WebFrameLoaderClient.mm:
3869         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3870         * WebCoreSupport/WebFrameNetworkingContext.mm:
3871         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3872         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3873         (WebFrameNetworkingContext::storageSession const):
3874         * WebCoreSupport/WebPlatformStrategies.h:
3875         * WebCoreSupport/WebPlatformStrategies.mm:
3876         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3877         * WebKitPrefix.h:
3878
3879 2017-08-16  Andy Estes  <aestes@apple.com>
3880
3881         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3882         https://bugs.webkit.org/show_bug.cgi?id=175648
3883
3884         Reviewed by Tim Horton.
3885
3886         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3887         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3888         (WebPaymentCoordinatorClient::showPaymentUI):
3889
3890 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3891
3892         [PAL] Move spi/ios and spi/win directories into PAL
3893         https://bugs.webkit.org/show_bug.cgi?id=175171
3894
3895         Reviewed by Antti Koivisto.
3896
3897         * WebCoreSupport/WebFrameLoaderClient.mm:
3898         * WebView/WebView.mm:
3899
3900 2017-08-16  Andy Estes  <aestes@apple.com>
3901
3902         [Payment Request] Add an ENABLE flag and an experimental feature preference
3903         https://bugs.webkit.org/show_bug.cgi?id=175622
3904
3905         Reviewed by Tim Horton.
3906
3907         * Configurations/FeatureDefines.xcconfig:
3908
3909 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3910
3911         [PAL] Move Sleep classes into PAL
3912         https://bugs.webkit.org/show_bug.cgi?id=175456
3913
3914         Reviewed by Ryosuke Niwa.
3915
3916         * WebView/WebFullScreenController.h:
3917
3918 2017-08-15  Youenn Fablet  <youenn@apple.com>
3919
3920         [Cache API] Adding generic support for CacheStorage and Cache methods
3921         https://bugs.webkit.org/show_bug.cgi?id=175455
3922
3923         Reviewed by Chris Dumez.
3924
3925         * WebView/WebView.mm:
3926         (-[WebView _commonInitializationWithFrameName:groupName:]):
3927
3928 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3929
3930         Remove Proximity Events and related code
3931         https://bugs.webkit.org/show_bug.cgi?id=175545
3932
3933         Reviewed by Daniel Bates.
3934
3935         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3936         and other related code.
3937
3938         * Configurations/FeatureDefines.xcconfig:
3939
3940 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3941
3942         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3943         https://bugs.webkit.org/show_bug.cgi?id=175504
3944
3945         Reviewed by Sam Weinig.
3946
3947         * Configurations/FeatureDefines.xcconfig:
3948         * DOM/DOMHTMLFormElement.mm:
3949         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3950         * WebCoreSupport/WebFrameLoaderClient.h:
3951
3952 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3953
3954         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3955         https://bugs.webkit.org/show_bug.cgi?id=175557
3956
3957         Reviewed by Jon Lee.
3958
3959         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3960
3961         * Configurations/FeatureDefines.xcconfig:
3962
3963 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3964
3965         Composition underline color is always black
3966         https://bugs.webkit.org/show_bug.cgi?id=174675
3967
3968         Reviewed by Ryosuke Niwa.
3969
3970         * WebView/WebHTMLView.mm:
3971         (extractUnderlines): If NSUnderlineColorAttributeName
3972         is not present use text color for composition underline.
3973         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3974         for composition underline in the plain text case.
3975
3976 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3977
3978         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3979         https://bugs.webkit.org/show_bug.cgi?id=175474
3980         <rdar://problem/33844628>
3981
3982         Reviewed by Wenson Hsieh.
3983
3984         Replaced the build flag by a runtime flag and disabled the feature by default.
3985
3986         * Configurations/FeatureDefines.xcconfig:
3987         * WebView/WebPreferenceKeysPrivate.h:
3988         * WebView/WebPreferences.mm:
3989         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3990         (-[WebPreferences dataTransferItemsEnabled]): Added.
3991         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3992         * WebView/WebPreferencesPrivate.h:
3993         * WebView/WebView.mm:
3994         (-[WebView _preferencesChanged:]):
3995
3996 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3997
3998         Remove ENABLE_GAMEPAD_DEPRECATED
3999         https://bugs.webkit.org/show_bug.cgi?id=175361
4000
4001         Reviewed by Carlos Garcia Campos.
4002
4003         * Configurations/FeatureDefines.xcconfig:
4004
4005 2017-08-09  Chris Dumez  <cdumez@apple.com>
4006
4007         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
4008         https://bugs.webkit.org/show_bug.cgi?id=175401
4009
4010         Reviewed by Brady Eidson.
4011
4012         * WebView/WebPreferenceKeysPrivate.h:
4013         * WebView/WebPreferences.mm:
4014         (+[WebPreferences initialize]):
4015         (-[WebPreferences beaconAPIEnabled]): Deleted.
4016         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
4017         * WebView/WebPreferencesPrivate.h:
4018         * WebView/WebView.mm:
4019         (-[WebView _preferencesChanged:]):
4020
4021 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
4022
4023         [PAL] Move spi/cocoa and spi/cg directories into PAL
4024         https://bugs.webkit.org/show_bug.cgi?id=175175
4025
4026         Reviewed by Myles C. Maxfield.
4027
4028         * History/WebHistory.mm:
4029         * Misc/WebDownload.mm:
4030         * Misc/WebKitNSStringExtras.mm:
4031         * Plugins/Hosted/NetscapePluginHostManager.mm:
4032         * Plugins/WebPluginDatabase.mm:
4033         * WebCoreSupport/WebFrameLoaderClient.mm:
4034         * WebInspector/WebNodeHighlight.mm:
4035         * WebView/WebHTMLView.mm:
4036         * WebView/WebIndicateLayer.mm:
4037         * WebView/WebView.mm:
4038         * WebView/WebViewData.h:
4039
4040 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
4041
4042         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
4043         https://bugs.webkit.org/show_bug.cgi?id=175392
4044         <rdar://problem/33783207>
4045
4046         Reviewed by Tim Horton and Megan Gardner.
4047
4048         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
4049
4050         * Configurations/FeatureDefines.xcconfig:
4051
4052 2017-08-09  Daniel Bates  <dabates@apple.com>
4053
4054         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
4055         https://bugs.webkit.org/show_bug.cgi?id=175247
4056         <rdar://problem/33679804>
4057
4058         Reviewed by Brady Eidson.
4059
4060         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
4061         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
4062         clients that need to make use of this information at this time. If such a needs comes up
4063         then we can expose API/SPI similar to what we do for WebKit.
4064
4065         * WebCoreSupport/WebFrameLoaderClient.h:
4066         * WebCoreSupport/WebFrameLoaderClient.mm:
4067         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
4068
4069 2017-08-08  Brady Eidson  <beidson@apple.com>
4070
4071         Don't enable default icon loading in WK1 for apps linked against old SDKs.
4072         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
4073
4074         Reviewed by Andy Estes.
4075
4076         * Misc/WebKitVersionChecks.h:
4077         * WebCoreSupport/WebFrameLoaderClient.mm:
4078         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
4079           the app is linked against new WebKit with the new behavior.
4080
4081 2017-08-07  Devin Rousso  <drousso@apple.com>
4082
4083         Web Inspector: Preview Canvas path when viewing a recording
4084         https://bugs.webkit.org/show_bug.cgi?id=174967
4085
4086         Reviewed by Brian Burg.
4087
4088         * WebView/WebPreferenceKeysPrivate.h:
4089         * WebView/WebPreferences.mm:
4090         (+[WebPreferences initialize]):
4091         (-[WebPreferences inspectorAdditionsEnabled]):
4092         (-[WebPreferences setInspectorAdditionsEnabled:]):
4093         * WebView/WebPreferencesPrivate.h:
4094         * WebView/WebView.mm:
4095         (-[WebView _preferencesChanged:]):
4096         Add plumbing for new InspectorAdditions runtime flag.
4097
4098 2017-08-07  Brian Burg  <bburg@apple.com>
4099
4100         Remove CANVAS_PATH compilation guard
4101         https://bugs.webkit.org/show_bug.cgi?id=175207
4102
4103         Reviewed by Sam Weinig.
4104
4105         * Configurations/FeatureDefines.xcconfig:
4106
4107 2017-08-04  Youenn Fablet  <youenn@apple.com>
4108
4109         [Cache API] Add Cache and CacheStorage IDL definitions
4110         https://bugs.webkit.org/show_bug.cgi?id=175201
4111
4112         Reviewed by Brady Eidson.
4113
4114         * WebView/WebPreferenceKeysPrivate.h:
4115         * WebView/WebPreferences.mm:
4116         (+[WebPreferences initialize]):
4117         (-[WebPreferences cacheAPIEnabled]):
4118         (-[WebPreferences setCacheAPIEnabled:]):
4119         * WebView/WebPreferencesPrivate.h:
4120         * WebView/WebView.mm:
4121         (-[WebView _preferencesChanged:]):
4122
4123 2017-08-04  Matt Lewis  <jlewis3@apple.com>
4124
4125         Unreviewed, rolling out r220271.
4126
4127         Rolling out due to Layout Test failing on iOS Simulator.
4128
4129         Reverted changeset:
4130
4131         "Remove STREAMS_API compilation guard"
4132         https://bugs.webkit.org/show_bug.cgi?id=175165
4133         http://trac.webkit.org/changeset/220271
4134
4135 2017-08-04  Youenn Fablet  <youenn@apple.com>
4136
4137         Remove STREAMS_API compilation guard
4138         https://bugs.webkit.org/show_bug.cgi?id=175165
4139
4140         Reviewed by Darin Adler.
4141
4142         * Configurations/FeatureDefines.xcconfig:
4143         * WebView/WebPreferences.mm:
4144         (+[WebPreferences initialize]):
4145         * WebView/WebView.mm:
4146         (-[WebView _preferencesChanged:]):
4147
4148 2017-08-03  Brian Burg  <bburg@apple.com>
4149
4150         Remove ENABLE(WEB_SOCKET) guards
4151         https://bugs.webkit.org/show_bug.cgi?id=167044
4152
4153         Reviewed by Joseph Pecoraro.
4154
4155         * Configurations/FeatureDefines.xcconfig:
4156         * WebView/WebPreferencesPrivate.h:
4157
4158 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
4159
4160         [PAL] Move spi/cf directory into PAL
4161         https://bugs.webkit.org/show_bug.cgi?id=175057
4162
4163         Reviewed by Antti Koivisto.
4164
4165         * Plugins/Hosted/HostedNetscapePluginStream.mm:
4166         * Plugins/WebNetscapePluginStream.mm:
4167         * WebCoreSupport/WebFrameNetworkingContext.mm:
4168         * WebView/WebPreferences.mm:
4169         * WebView/WebView.mm:
4170
4171 2017-08-03  Youenn Fablet  <youenn@apple.com>
4172
4173         Remove FETCH_API compilation guard
4174         https://bugs.webkit.org/show_bug.cgi?id=175154
4175
4176         Reviewed by Chris Dumez.
4177
4178         * Configurations/FeatureDefines.xcconfig:
4179         * WebView/WebPreferences.mm:
4180         (+[WebPreferences initialize]):
4181         * WebView/WebView.mm:
4182         (-[WebView _preferencesChanged:]):
4183
4184 2017-08-03  Brady Eidson  <beidson@apple.com>
4185
4186         Add SW IDLs and stub out basic functionality.
4187         https://bugs.webkit.org/show_bug.cgi?id=175115
4188
4189         Reviewed by Chris Dumez.
4190
4191         * Configurations/FeatureDefines.xcconfig:
4192
4193 2017-08-02  Sam Weinig  <sam@webkit.org>
4194
4195         [WebIDL] Convert MutationCallback to be a normal generated callback
4196         https://bugs.webkit.org/show_bug.cgi?id=174140
4197
4198         Reviewed by Darin Adler.
4199
4200         * DOM/DOMDocument.mm:
4201         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
4202         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
4203         Pass, now necessary, Document to NativeNodeFilter constructor.
4204
4205 2017-08-01  Chris Dumez  <cdumez@apple.com>
4206
4207         Add initial support for navigator.sendBeacon
4208         https://bugs.webkit.org/show_bug.cgi?id=175007
4209         <rdar://problem/33547728>
4210
4211         Reviewed by Sam Weinig.