[Settings] Remove all custom code from Settings.h/cpp
[WebKit.git] / Source / WebKitLegacy / mac / ChangeLog
1 2017-10-16  Sam Weinig  <sam@webkit.org>
2
3         [Settings] Remove all custom code from Settings.h/cpp
4         https://bugs.webkit.org/show_bug.cgi?id=178330
5
6         Reviewed by Simon Fraser.
7
8         * WebView/WebPreferences.mm:
9         (+[WebPreferences initialize]):
10         
11             Update for naming changes of FrameFlattening now that it is an enum class.
12
13 2017-10-13  Alex Christensen  <achristensen@webkit.org>
14
15         Remove Editor::simplifyMarkup
16         https://bugs.webkit.org/show_bug.cgi?id=178271
17
18         Reviewed by Wenson Hsieh.
19
20         * WebView/WebView.mm:
21         (-[WebView _simplifyMarkup:endNode:]):
22
23 2017-10-12  Chris Dumez  <cdumez@apple.com>
24
25         [Mac] Add support for MouseEvent.buttons
26         https://bugs.webkit.org/show_bug.cgi?id=178214
27
28         Reviewed by Ryosuke Niwa.
29
30         * WebView/WebPDFView.mm:
31         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
32
33 2017-10-11  Sam Weinig  <sam@webkit.org>
34
35         Remove out-parameter variants of copyToVector
36         https://bugs.webkit.org/show_bug.cgi?id=178155
37
38         Reviewed by Tim Horton.
39
40         * Plugins/WebNetscapePluginView.mm:
41         (-[WebNetscapePluginView destroyPlugin]):
42         * WebView/WebHTMLRepresentation.mm:
43         (newArrayWithStrings):
44
45             Replace out-parameter based copyToVector, with one that returns a Vector.
46
47 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
48
49         Sanitize URL in pasteboard for other applications and cross origin content
50         https://bugs.webkit.org/show_bug.cgi?id=178060
51         <rdar://problem/34874518>
52
53         Reviewed by Wenson Hsieh.
54
55         * WebCoreSupport/WebPlatformStrategies.h:
56         * WebCoreSupport/WebPlatformStrategies.mm:
57         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
58
59 2017-10-11  Chris Dumez  <cdumez@apple.com>
60
61         Modernize Geolocation code
62         https://bugs.webkit.org/show_bug.cgi?id=178148
63
64         Reviewed by Ryosuke Niwa.
65
66         * WebCoreSupport/WebGeolocationClient.h:
67         * WebCoreSupport/WebGeolocationClient.mm:
68         (WebGeolocationClient::lastPosition):
69         * WebView/WebGeolocationPosition.mm:
70         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
71         (core):
72         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
73         (-[WebGeolocationPosition initWithGeolocationPosition:]):
74         * WebView/WebGeolocationPositionInternal.h:
75
76 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
77
78         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
79         https://bugs.webkit.org/show_bug.cgi?id=178154
80
81         Reviewed by Wenson Hsieh.
82
83         Enable custom pasteboard data by default.
84
85         * WebView/WebPreferenceKeysPrivate.h:
86         * WebView/WebPreferences.mm:
87         (+[WebPreferences initialize]):
88         (-[WebPreferences customPasteboardDataEnabled]): Added.
89         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
90         * WebView/WebPreferencesPrivate.h:
91         * WebView/WebView.mm:
92         (-[WebView _preferencesChanged:]):
93
94 2017-10-10  Sam Weinig  <sam@webkit.org>
95
96         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
97         https://bugs.webkit.org/show_bug.cgi?id=178102
98
99         Reviewed by Tim Horton.
100
101         * History/WebHistory.mm:
102         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
103         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
104         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
105         * WebCoreSupport/WebUserMediaClient.mm:
106         (WebUserMediaClient::pageDestroyed):
107
108 2017-10-09  Robin Morisset  <rmorisset@apple.com>
109
110         Make the names of the options consistent
111         https://bugs.webkit.org/show_bug.cgi?id=177933
112
113         Reviewed by Saam Barati.
114
115         * WebView/WebFrame.h:
116         * WebView/WebHTMLView.mm:
117         (-[WebHTMLView setMarkedText:selectedRange:]):
118         * WebView/WebView.h:
119
120 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
121
122         [iOS] Tweak support for classifying form controls (followup to r222487)
123         https://bugs.webkit.org/show_bug.cgi?id=177917
124         <rdar://problem/34820122>
125
126         Reviewed by Dean Jackson.
127
128         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
129
130         * DOM/DOMHTMLInputElement.mm:
131         (-[DOMHTMLInputElement _autofillContext]):
132         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
133         (-[DOMHTMLInputElement representingPageURL]): Deleted.
134
135 2017-10-05  Keith Miller  <keith_miller@apple.com>
136
137         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
138
139         * Configurations/WebKitLegacy.xcconfig:
140
141 2017-10-05  Jer Noble  <jer.noble@apple.com>
142
143         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
144         https://bugs.webkit.org/show_bug.cgi?id=177261
145
146         Reviewed by Eric Carlson.
147
148         * Configurations/FeatureDefines.xcconfig:
149
150 2017-10-05  Chris Dumez  <cdumez@apple.com>
151
152         Drop unused parameters for CookiesStrategy::cookiesEnabled()
153         https://bugs.webkit.org/show_bug.cgi?id=177957
154
155         Reviewed by Alex Christensen.
156
157         * WebCoreSupport/WebPlatformStrategies.h:
158         * WebCoreSupport/WebPlatformStrategies.mm:
159         (WebPlatformStrategies::cookiesEnabled):
160
161 2017-10-05  Youenn Fablet  <youenn@apple.com>
162
163         Make LibWebRTCProvider port agnostic
164         https://bugs.webkit.org/show_bug.cgi?id=177747
165
166         Reviewed by Alex Christensen & Alex Garcia.
167
168         * WebView/WebView.mm:
169         (-[WebView _commonInitializationWithFrameName:groupName:]):
170         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
171
172 2017-10-04  Alex Christensen  <achristensen@webkit.org>
173
174         Stop linking with WebKitSystemInterface
175         https://bugs.webkit.org/show_bug.cgi?id=177915
176
177         Reviewed by Antti Koivisto.
178
179         * Configurations/DebugRelease.xcconfig:
180         * Configurations/WebKitLegacy.xcconfig:
181
182 2017-10-04  Alex Christensen  <achristensen@webkit.org>
183
184         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
185         https://bugs.webkit.org/show_bug.cgi?id=177912
186
187         Reviewed by Saam Barati.
188
189         * Carbon/CarbonUtils.m:
190         * Carbon/CarbonWindowAdapter.mm:
191         * Carbon/HIWebView.mm:
192         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
193         * Misc/WebNSFileManagerExtras.mm:
194         * Misc/WebNSPasteboardExtras.mm:
195         * Misc/WebNSURLExtras.mm:
196         * Plugins/Hosted/HostedNetscapePluginStream.mm:
197         * Plugins/Hosted/NetscapePluginHostManager.mm:
198         * Plugins/Hosted/NetscapePluginHostProxy.mm:
199         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
200         * Plugins/Hosted/WebHostedNetscapePluginView.h:
201         * Plugins/Hosted/WebTextInputWindowController.m:
202         * Plugins/WebBaseNetscapePluginView.mm:
203         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
204         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
205         * Plugins/WebNetscapePluginStream.mm:
206         * Plugins/WebNetscapePluginView.mm:
207         * Plugins/WebPluginDatabase.mm:
208         * WebCoreSupport/PopupMenuMac.mm:
209         * WebCoreSupport/WebChromeClient.mm:
210         * WebCoreSupport/WebFrameLoaderClient.mm:
211         * WebCoreSupport/WebInspectorClient.mm:
212         * WebCoreSupport/WebPlatformStrategies.mm:
213         * WebCoreSupport/WebSystemInterface.mm:
214         * WebView/WebDynamicScrollBarsView.mm:
215         * WebView/WebFrame.mm:
216         * WebView/WebFrameView.mm:
217         * WebView/WebFullScreenController.mm:
218         * WebView/WebHTMLView.mm:
219         * WebView/WebPreferences.mm:
220         * WebView/WebView.mm:
221
222 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
223
224         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
225         rdar://problem/34705779
226
227         Addressing review comments that I somehow landed without.
228
229         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
230
231 2017-09-29  Chris Dumez  <cdumez@apple.com>
232
233         Split some logic out of VisitedLinkStore and make it reusable
234         https://bugs.webkit.org/show_bug.cgi?id=177575
235
236         Reviewed by Alex Christensen.
237
238         * WebCoreSupport/WebVisitedLinkStore.h:
239         * WebCoreSupport/WebVisitedLinkStore.mm:
240         (WebVisitedLinkStore::addVisitedLink):
241         (WebVisitedLinkStore::removeVisitedLink):
242         (WebVisitedLinkStore::isLinkVisited):
243         (WebVisitedLinkStore::addVisitedLinkHash):
244
245 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
246
247         Build fix for High Sierra 32 bit Mac
248         https://bugs.webkit.org/show_bug.cgi?id=177551
249         <rdar://problem/34690283>
250
251         Reviewed by Alexey Proskuryakov.
252
253         Some assertions have been removed from the SDK. Replace these assertions with equivalent
254         WTF assert code.  Since the files in this patch are using tabs, some style changes were
255         also made.
256
257         * Carbon/CarbonWindowAdapter.mm:
258         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
259         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
260         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
261         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
262         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
263         (-[CarbonWindowAdapter dealloc]):
264         (-[CarbonWindowAdapter windowRef]):
265         (-[CarbonWindowAdapter _hasWindowRef]):
266         (-[CarbonWindowAdapter _managesWindowRef]):
267         (-[CarbonWindowAdapter _removeWindowRef]):
268         (-[CarbonWindowAdapter _carbonWindowClass]):
269         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
270         (-[CarbonWindowAdapter sendSuperEvent:]):
271         (-[CarbonWindowAdapter relinquishFocus]):
272         (-[CarbonWindowAdapter _cancelKey:]):
273         (-[CarbonWindowAdapter _commonAwake]):
274         (-[CarbonWindowAdapter _destroyRealWindow:]):
275         (-[CarbonWindowAdapter _oldPlaceWindow:]):
276         (-[CarbonWindowAdapter _termWindowIfOwner]):
277         (-[CarbonWindowAdapter _windowMovedToRect:]):
278         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
279         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
280         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
281         (-[CarbonWindowAdapter canBecomeKeyWindow]):
282         (-[CarbonWindowAdapter canBecomeMainWindow]):
283         (-[CarbonWindowAdapter encodeWithCoder:]):
284         (-[CarbonWindowAdapter initWithCoder:]):
285         (-[CarbonWindowAdapter setContentView:]):
286         (-[CarbonWindowAdapter worksWhenModal]):
287         (-[CarbonWindowAdapter _setModalWindowLevel]):
288         (-[CarbonWindowAdapter _clearModalWindowLevel]):
289         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
290         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
291         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
292         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
293         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
294         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
295         (NSCarbonWindowHandleEvent):
296         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
297         (-[CarbonWindowAdapter _growBoxRect]):
298         * Carbon/HIWebView.mm:
299         (HIWebViewGetWebView):
300         (HIWebViewConstructor):
301         (HIWebViewDestructor):
302         (HIWebViewRegisterClass):
303         (GetBehaviors):
304         (Draw):
305         (HitTest):
306         (GetRegion):
307         (GetWindowRef):
308         (CreateNSEventAdoptingCGEvent):
309         (CopyEventCGEvent):
310         (CreateNSEventWithCarbonClickEvent):
311         (Click):
312         (CreateNSEventWithCarbonEvent):
313         (MouseUp):
314         (CreateNSEventWithCarbonMouseMoveEvent):
315         (MouseMoved):
316         (MouseDragged):
317         (MouseWheelMoved):
318         (ContextMenuClick):
319         (GetKind):
320         (BoundsChanged):
321         (OwningWindowChanged):
322         (WindowHandler):
323         (SyncFrame):
324         (SetFocusPart):
325         (AdvanceFocus):
326         (RelinquishFocus):
327         (ActiveStateChanged):
328         (ProcessCommand):
329         (UpdateCommandStatus):
330         (_NSSelectorForHICommand):
331         (HIWebViewEventHandler):
332         (StartUpdateObserver):
333         (StopUpdateObserver):
334         (UpdateObserver):
335
336 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
337
338         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
339         https://bugs.webkit.org/show_bug.cgi?id=172526
340         <rdar://problem/32396081>
341
342         Reviewed by Ryosuke Niwa.
343
344         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
345
346         * WebCoreSupport/WebPlatformStrategies.h:
347         * WebCoreSupport/WebPlatformStrategies.mm:
348         (WebPlatformStrategies::webExposedTypes):
349         (WebPlatformStrategies::writeCustomData):
350
351 2017-09-27  Matt Lewis  <jlewis3@apple.com>
352
353         Unreviewed, rolling out r222567.
354
355         This broke and internal build.
356
357         Reverted changeset:
358
359         "Build fix for High Sierra 32 bit Mac"
360         https://bugs.webkit.org/show_bug.cgi?id=177551
361         http://trac.webkit.org/changeset/222567
362
363 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
364
365         Build fix for High Sierra 32 bit Mac
366         https://bugs.webkit.org/show_bug.cgi?id=177551
367         <rdar://problem/34690283>
368
369         Reviewed by Alexey Proskuryakov.
370
371         Some assertions have been removed from the SDK. Replace these assertions with equivalent
372         WTF assert code.  Since the files in this patch are using tabs, some style changes were
373         also made.
374
375         * Carbon/CarbonWindowAdapter.mm:
376         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
377         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
378         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
379         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
380         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
381         (-[CarbonWindowAdapter dealloc]):
382         (-[CarbonWindowAdapter windowRef]):
383         (-[CarbonWindowAdapter _hasWindowRef]):
384         (-[CarbonWindowAdapter _managesWindowRef]):
385         (-[CarbonWindowAdapter _removeWindowRef]):
386         (-[CarbonWindowAdapter _carbonWindowClass]):
387         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
388         (-[CarbonWindowAdapter sendSuperEvent:]):
389         (-[CarbonWindowAdapter relinquishFocus]):
390         (-[CarbonWindowAdapter _cancelKey:]):
391         (-[CarbonWindowAdapter _commonAwake]):
392         (-[CarbonWindowAdapter _destroyRealWindow:]):
393         (-[CarbonWindowAdapter _oldPlaceWindow:]):
394         (-[CarbonWindowAdapter _termWindowIfOwner]):
395         (-[CarbonWindowAdapter _windowMovedToRect:]):
396         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
397         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
398         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
399         (-[CarbonWindowAdapter canBecomeKeyWindow]):
400         (-[CarbonWindowAdapter canBecomeMainWindow]):
401         (-[CarbonWindowAdapter encodeWithCoder:]):
402         (-[CarbonWindowAdapter initWithCoder:]):
403         (-[CarbonWindowAdapter setContentView:]):
404         (-[CarbonWindowAdapter worksWhenModal]):
405         (-[CarbonWindowAdapter _setModalWindowLevel]):
406         (-[CarbonWindowAdapter _clearModalWindowLevel]):
407         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
408         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
409         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
410         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
411         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
412         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
413         (NSCarbonWindowHandleEvent):
414         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
415         (-[CarbonWindowAdapter _growBoxRect]):
416         * Carbon/HIWebView.mm:
417         (HIWebViewGetWebView):
418         (HIWebViewConstructor):
419         (HIWebViewDestructor):
420         (HIWebViewRegisterClass):
421         (GetBehaviors):
422         (Draw):
423         (HitTest):
424         (GetRegion):
425         (GetWindowRef):
426         (CreateNSEventAdoptingCGEvent):
427         (CopyEventCGEvent):
428         (CreateNSEventWithCarbonClickEvent):
429         (Click):
430         (CreateNSEventWithCarbonEvent):
431         (MouseUp):
432         (CreateNSEventWithCarbonMouseMoveEvent):
433         (MouseMoved):
434         (MouseDragged):
435         (MouseWheelMoved):
436         (ContextMenuClick):
437         (GetKind):
438         (BoundsChanged):
439         (OwningWindowChanged):
440         (WindowHandler):
441         (SyncFrame):
442         (SetFocusPart):
443         (AdvanceFocus):
444         (RelinquishFocus):
445         (ActiveStateChanged):
446         (ProcessCommand):
447         (UpdateCommandStatus):
448         (_NSSelectorForHICommand):
449         (HIWebViewEventHandler):
450         (StartUpdateObserver):
451         (StopUpdateObserver):
452         (UpdateObserver):
453
454 2017-09-25  Alex Christensen  <achristensen@webkit.org>
455
456         Make PolicyAction an encodable enum class
457         https://bugs.webkit.org/show_bug.cgi?id=177480
458
459         Reviewed by Antti Koivisto.
460
461         * Plugins/WebPluginContainerCheck.mm:
462         (-[WebPluginContainerCheck _continueWithPolicy:]):
463         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
464         * WebCoreSupport/WebFrameLoaderClient.mm:
465         (-[WebFramePolicyListener invalidate]):
466         (-[WebFramePolicyListener ignore]):
467         (-[WebFramePolicyListener download]):
468         (-[WebFramePolicyListener use]):
469         (-[WebFramePolicyListener continue]):
470         * WebView/WebPolicyDelegate.mm:
471         (-[WebPolicyDecisionListener use]):
472         (-[WebPolicyDecisionListener ignore]):
473         (-[WebPolicyDecisionListener download]):
474
475 2017-09-25  Frederik Riedel  <riedel@apple.com>
476
477         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
478         https://bugs.webkit.org/show_bug.cgi?id=174394
479         <rdar://problem/33183504>
480
481         Reviewed by Ryosuke Niwa.
482
483         * DOM/DOMHTMLInputElement.h:
484         * DOM/DOMHTMLInputElement.mm:
485         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
486         Determines if this HTMLInputElement is part of a login screen.
487         (-[DOMHTMLInputElement representingPageUrl]):
488         Returns the webpage's URL that is currently displayed in the Web View.
489         (-[DOMHTMLInputElement insertTextSuggestion:]):
490         Inserts login credentials into the Web View.
491
492 2017-09-25  Sam Weinig  <sam@webkit.org>
493
494         Remove unused EditorClient functions
495         https://bugs.webkit.org/show_bug.cgi?id=177463
496
497         Reviewed by Alex Christensen.
498
499         Remove unused EditorClient functions.
500
501         * WebCoreSupport/WebEditorClient.h:
502         * WebCoreSupport/WebEditorClient.mm:
503         (WebEditorClient::canonicalizeURL): Deleted.
504         (WebEditorClient::canonicalizeURLString): Deleted.
505         (WebEditorClient::writeDataToPasteboard): Deleted.
506         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
507         (WebEditorClient::readDataFromPasteboard): Deleted.
508         (WebEditorClient::pasteboardChangeCount): Deleted.
509
510 2017-09-25  Alex Christensen  <achristensen@webkit.org>
511
512         Stop using PolicyCallback
513         https://bugs.webkit.org/show_bug.cgi?id=176088
514
515         Reviewed by Andy Estes.
516
517         * WebCoreSupport/WebFrameLoaderClient.mm:
518         (-[WebFramePolicyListener invalidate]):
519         (-[WebFramePolicyListener receivedPolicyDecision:]):
520
521 2017-09-25  Sam Weinig  <sam@webkit.org>
522
523         Remove unnecessary userVisibleString EditorClient function
524         https://bugs.webkit.org/show_bug.cgi?id=177456
525
526         Reviewed by Dan Bernstein.
527
528         * WebCoreSupport/WebEditorClient.h:
529         * WebCoreSupport/WebEditorClient.mm:
530         (WebEditorClient::userVisibleString): Deleted.
531
532             Remove userVisibleString client function.
533
534 2017-09-25  Alex Christensen  <achristensen@webkit.org>
535
536         Separate form submission from PolicyChecker infrastructure
537         https://bugs.webkit.org/show_bug.cgi?id=177396
538
539         Reviewed by Geoffrey Garen.
540
541         * WebCoreSupport/WebFrameLoaderClient.h:
542         * WebCoreSupport/WebFrameLoaderClient.mm:
543         (WebFrameLoaderClient::dispatchWillSubmitForm):
544
545 2017-09-22  Zalan Bujtas  <zalan@apple.com>
546
547         WeakPtrFactory should populate m_ref lazily.
548         https://bugs.webkit.org/show_bug.cgi?id=177375
549
550         Reviewed by Geoffrey Garen.
551
552         * WebCoreSupport/WebEditorClient.mm:
553         (WebEditorClient::WebEditorClient):
554         (WebEditorClient::requestCandidatesForSelection):
555
556 2017-09-22  Chris Dumez  <cdumez@apple.com>
557
558         Use high resolution timestamp for event time
559         https://bugs.webkit.org/show_bug.cgi?id=154246
560         <rdar://problem/34333304>
561
562         Reviewed by Ryosuke Niwa.
563
564         Use WallTime / MonotonicTime instead of double type for clarity.
565
566         * DOM/DOMEvent.mm:
567         (-[DOMEvent timeStamp]):
568         * WebView/WebFrame.mm:
569         (-[WebFrame _dragSourceEndedAt:operation:]):
570         * WebView/WebPDFView.mm:
571         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
572
573 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
574
575         Enable dataTransfer.items on macOS and iOS
576         https://bugs.webkit.org/show_bug.cgi?id=177335
577
578         Reviewed by Sam Weinig.
579
580         * WebView/WebPreferences.mm:
581         (+[WebPreferences initialize]):
582
583 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
584
585         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
586         https://bugs.webkit.org/show_bug.cgi?id=177101
587         <rdar://problem/34500648>
588
589         Reviewed by Brian Burg.
590
591         * WebInspector/WebNodeHighlight.mm:
592         Ensure we close the window that we have just removed.
593
594 2017-09-20  Antti Koivisto  <antti@apple.com>
595
596         Remove DOM and styling support for CSS Regions
597         https://bugs.webkit.org/show_bug.cgi?id=177221
598
599         Reviewed by Andreas Kling.
600
601         * Configurations/FeatureDefines.xcconfig:
602         * DOM/DOMCSS.mm:
603         (kitClass):
604         * DOM/DOMElement.mm:
605         (-[DOMElement webkitRegionOverset]): Deleted.
606
607 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
608
609         Layering violation in Editor::createFragment
610         https://bugs.webkit.org/show_bug.cgi?id=176123
611
612         Reviewed by Darin Adler.
613
614         * Misc/WebNSURLExtras.h:
615         * Misc/WebNSURLExtras.mm:
616         * WebView/WebFrame.mm:
617         * WebView/WebHTMLView.mm:
618         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
619
620         * WebCoreSupport/WebEditorClient.mm:
621         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
622         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
623         way to avoid exporting the symbol just on newer OSes.
624
625 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
626
627         On iOS, getData can't get text set by setData during copy event
628         https://bugs.webkit.org/show_bug.cgi?id=176980
629         <rdar://problem/34453915>
630
631         Reviewed by Darin Adler.
632
633         * WebCoreSupport/WebPlatformStrategies.h:
634         * WebCoreSupport/WebPlatformStrategies.mm:
635         (WebPlatformStrategies::copy): Deleted.
636
637 2017-09-18  Andy Estes  <aestes@apple.com>
638
639         [Mac] Upstream miscellaneous WebKitSystemInterface functions
640         https://bugs.webkit.org/show_bug.cgi?id=177029
641
642         Reviewed by Alex Christensen.
643
644         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
645         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
646         * Plugins/Hosted/NetscapePluginHostProxy.mm:
647         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
648         * WebCoreSupport/PopupMenuMac.mm:
649         (PopupMenuMac::show):
650         * WebCoreSupport/WebSystemInterface.mm:
651         (InitWebCoreSystemInterface):
652         * WebView/WebHTMLView.mm:
653         (-[WebHTMLView setDataSource:]):
654         (-[WebHTMLView attachRootLayer:]):
655         * WebView/WebView.mm:
656         (-[WebView _needsAdobeFrameReloadingQuirk]):
657         (-[WebView _needsLinkElementTextCSSQuirk]):
658         (-[WebView _needsIsLoadingInAPISenseQuirk]):
659         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
660         (-[WebView _preferencesChanged:]):
661
662 2017-09-15  Andy Estes  <aestes@apple.com>
663
664         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
665         https://bugs.webkit.org/show_bug.cgi?id=176953
666
667         Reviewed by Eric Carlson.
668
669         * WebCoreSupport/WebSystemInterface.mm:
670         (InitWebCoreSystemInterface):
671
672 2017-09-14  Andy Estes  <aestes@apple.com>
673
674         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
675         https://bugs.webkit.org/show_bug.cgi?id=176931
676
677         Reviewed by Joseph Pecoraro.
678
679         * WebCoreSupport/WebSystemInterface.mm:
680         (InitWebCoreSystemInterface):
681
682 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
683
684         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
685         https://bugs.webkit.org/show_bug.cgi?id=176867
686
687         Reviewed by Sam Weinig.
688
689         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
690         (WebKit::NetscapePluginInstanceProxy::enumerate):
691
692 2017-09-13  Andy Estes  <aestes@apple.com>
693
694         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
695         https://bugs.webkit.org/show_bug.cgi?id=176729
696
697         Reviewed by Alex Christensen.
698
699         * WebCoreSupport/WebSystemInterface.mm:
700         (InitWebCoreSystemInterface):
701         * WebView/WebView.mm:
702         (+[WebView _setCacheModel:]):
703
704 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
705
706         Refactor WebContentReader out of EditorMac and EditorIOS
707         https://bugs.webkit.org/show_bug.cgi?id=176770
708
709         Reviewed by Sam Weinig.
710
711         * WebCoreSupport/WebEditorClient.mm:
712
713 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
714
715         Dragging & dropping a file creates an attachment element even when it's disabled
716         https://bugs.webkit.org/show_bug.cgi?id=176769
717
718         Reviewed by Tim Horton.
719
720         * WebView/WebView.mm:
721         (-[WebView _preferencesChanged:]):
722
723 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
724
725         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
726         https://bugs.webkit.org/show_bug.cgi?id=176721
727         <rdar://problem/34373660>
728
729         Reviewed by Tim Horton.
730
731         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
732         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
733
734         * WebView/WebView.mm:
735         (-[WebView _startDrag:]):
736         (-[WebView _draggedElementBounds]):
737         (-[WebView _endedDataInteraction:global:]):
738         * WebView/WebViewData.h:
739
740 2017-09-11  Andy Estes  <aestes@apple.com>
741
742         [Mac] Upstream QTKit-related WebKitSystemInterface functions
743         https://bugs.webkit.org/show_bug.cgi?id=176472
744
745         Reviewed by Eric Carlson.
746
747         * WebCoreSupport/WebSystemInterface.mm:
748         (InitWebCoreSystemInterface):
749
750 2017-09-09  Mark Lam  <mark.lam@apple.com>
751
752         Avoid duplicate computations of ExecState::vm().
753         https://bugs.webkit.org/show_bug.cgi?id=176647
754
755         Reviewed by Saam Barati.
756
757         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
758         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
759         (WebKit::NetscapePluginInstanceProxy::construct):
760         (WebKit::NetscapePluginInstanceProxy::setProperty):
761         (WebKit::NetscapePluginInstanceProxy::removeProperty):
762         (WebKit::NetscapePluginInstanceProxy::enumerate):
763         * Plugins/Hosted/ProxyInstance.mm:
764         (WebKit::ProxyRuntimeMethod::create):
765
766 2017-09-08  Commit Queue  <commit-queue@webkit.org>
767
768         Unreviewed, rolling out r221773.
769         https://bugs.webkit.org/show_bug.cgi?id=176614
770
771         This caused build failures. (Requested by mlewis13 on
772         #webkit).
773
774         Reverted changeset:
775
776         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
777         https://bugs.webkit.org/show_bug.cgi?id=176472
778         http://trac.webkit.org/changeset/221773
779
780 2017-09-07  Andy Estes  <aestes@apple.com>
781
782         [Mac] Upstream QTKit-related WebKitSystemInterface functions
783         https://bugs.webkit.org/show_bug.cgi?id=176472
784
785         Reviewed by Eric Carlson.
786
787         * WebCoreSupport/WebSystemInterface.mm:
788         (InitWebCoreSystemInterface):
789
790 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
791
792         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
793         https://bugs.webkit.org/show_bug.cgi?id=176561
794
795         Reviewed by Brent Fulgham.
796
797         * Misc/WebNSUserDefaultsExtras.mm:
798
799 2017-09-07  Alex Christensen  <achristensen@webkit.org>
800
801         Modernize Geolocation code
802         https://bugs.webkit.org/show_bug.cgi?id=176496
803
804         Reviewed by Andy Estes.
805
806         * WebCoreSupport/WebGeolocationClient.h:
807         * WebCoreSupport/WebGeolocationClient.mm:
808         (WebGeolocationClient::requestPermission):
809         (-[WebGeolocationPolicyListener initWithGeolocation:]):
810         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
811         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
812         * WebView/WebView.mm:
813         (-[WebView _commonInitializationWithFrameName:groupName:]):
814         (-[WebView _geolocationDidFailWithMessage:]):
815
816 2017-09-05  Tim Horton  <timothy_horton@apple.com>
817
818         Remove some unused bits of code and resources
819         https://bugs.webkit.org/show_bug.cgi?id=176275
820
821         Reviewed by Dan Bernstein.
822
823         * Misc/WebNSFileManagerExtras.mm:
824         Include FileSystem instead of FileSystemIOS.
825
826 2017-09-03  Darin Adler  <darin@apple.com>
827
828         [Cocoa] Tidy a few things in legacy WebHTMLView
829         https://bugs.webkit.org/show_bug.cgi?id=176280
830
831         Reviewed by Dan Bernstein.
832
833         * WebCoreSupport/WebChromeClient.mm:
834         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
835         methods it calls on WebHTMLView were doing nothing on iOS.
836
837         * WebView/WebFrame.mm:
838         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
839         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
840
841         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
842         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
843         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
844         order. Removed all sorts of unused things. Made more code and fields Mac-only where
845         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
846         Use RetainPtr instead of writing retain/release wherever possible.
847         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
848         initialization for it. Removed various unused methods and declarations of methods.
849         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
850         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
851         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
852         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
853         and remove CFRetain no longer needed since we don't support garbage collection any more.
854         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
855         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
856         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
857         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
858         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
859         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
860         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
861         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
862         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
863         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
864         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
865         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
866         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
867         debug flag; we haven't used it for years and it's not clearly helpful.
868         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
869         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
870         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
871         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
872         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
873         two additional methods in the WebPrivate category and still be called by the two
874         methods in the WebInternal category that were already using it.
875         (-[WebHTMLView didAddSubview:]): Deleted.
876         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
877         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
878         place this was called, the close method.
879         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
880         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
881         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
882         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
883         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
884         Added helper method to make the one below simpler.
885         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
886         Compared pasteboard type strings using isEqualToString: rather than using == since
887         we want to actually compare the string contents. Also updated to use modern for loop,
888         renamed a local variable from "s" to "localSubresources", and factored out the handling
889         of three image types to use the helper method above.
890         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
891         _web_makePluginSubviewsPerformSelector:withObject: method.
892         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
893         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
894         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
895         not call the -[NSView subviews] method to make this identical on both platforms and used
896         a modern for loop.
897         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
898         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
899         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
900         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
901         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
902         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
903         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
904         of it is Mac-only.
905         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
906         method did was call itself on the main thread, and do nothing if called on main thread.
907         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
908         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
909         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
910         half of this method.
911         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
912         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
913         Simplified using a modern for loop and RetainPtr.
914         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
915         (-[WebHTMLView keyDown:]): Ditto.
916         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
917         (-[WebHTMLView performKeyEquivalent:]): Ditto.
918         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
919         (-[WebHTMLView complete:]): Ditto.
920         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
921         now macOS-only.
922         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
923         iOS since that is now macOS-only.
924         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
925         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
926         a private one because it is not used or needed outside WebKit. Also made it macOS-only
927         and reorganized to use early return.
928         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
929         on iOS, but kept there so we don't have to do #if at every call site.
930         (-[WebHTMLView _pluginController]): Moved into internal category.
931         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
932         there only for GC, using C++ initialization, removing obsolete comment.
933         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
934         peculiar iOS-only comment.
935         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
936
937         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
938         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
939         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
940         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
941         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
942
943         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
944         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
945         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
946         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
947         them at this time.
948
949 2017-09-03  Sam Weinig  <sam@webkit.org>
950
951         Remove CanvasProxy
952         https://bugs.webkit.org/show_bug.cgi?id=176288
953
954         Reviewed by Yusuke Suzuki.
955
956         CanvasProxy does not appear to be in any current HTML spec
957         and was disabled and unimplemented in our tree. Time to 
958         get rid of it.
959
960         * Configurations/FeatureDefines.xcconfig:
961
962 2017-09-02  Andy Estes  <aestes@apple.com>
963
964         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
965         https://bugs.webkit.org/show_bug.cgi?id=176270
966
967         Reviewed by Tim Horton.
968
969         * Plugins/Hosted/NetscapePluginHostManager.mm:
970         (WebKit::NetscapePluginHostManager::spawnPluginHost):
971         * Plugins/Hosted/WebHostedNetscapePluginView.h:
972         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
973         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
974         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
975         (WebKit::SoftwareCARenderer::context const):
976         (WebKit::SoftwareCARenderer::renderContext const):
977         (WebKit::SoftwareCARenderer::render):
978         (-[WebHostedNetscapePluginView createPlugin]):
979         (-[WebHostedNetscapePluginView createPluginLayer]):
980         (-[WebHostedNetscapePluginView destroyPlugin]):
981         (-[WebHostedNetscapePluginView drawRect:]):
982         * WebCoreSupport/WebSystemInterface.mm:
983         (InitWebCoreSystemInterface):
984
985 2017-09-01  Andy Estes  <aestes@apple.com>
986
987         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
988         https://bugs.webkit.org/show_bug.cgi?id=176200
989
990         Reviewed by Tim Horton.
991
992         * Carbon/HIWebView.mm:
993         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
994         (overrideCGContext):
995         (restoreCGContext):
996         (Draw):
997         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
998         (+[WebHostedNetscapePluginView initialize]):
999         * Plugins/WebBaseNetscapePluginView.h:
1000         * Plugins/WebBaseNetscapePluginView.mm:
1001         (WebKit::sendUserChangeNotifications):
1002         * Plugins/WebNetscapePluginView.mm:
1003         (+[WebNetscapePluginView initialize]):
1004         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1005         * WebCoreSupport/WebSystemInterface.mm:
1006         (InitWebCoreSystemInterface):
1007         * WebView/WebFrame.mm:
1008         (-[WebFrame _paintBehaviorForDestinationContext:]):
1009         * WebView/WebFullScreenController.mm:
1010         (setClipRectForWindow):
1011         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1012         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1013         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1014         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1015
1016 2017-08-31  Andy Estes  <aestes@apple.com>
1017
1018         [Mac] Upstream AppKit-related WebKitSystemInterface functions
1019         https://bugs.webkit.org/show_bug.cgi?id=176175
1020
1021         Reviewed by Brady Eidson.
1022
1023         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1024         (WebKit::NetscapePluginInstanceProxy::keyEvent):
1025         * Plugins/Hosted/WebTextInputWindowController.m:
1026         (-[WebTextInputPanel init]):
1027         * WebCoreSupport/WebSystemInterface.mm:
1028         (InitWebCoreSystemInterface):
1029         * WebView/WebDynamicScrollBarsView.mm:
1030         (-[WebDynamicScrollBarsView scrollWheel:]):
1031         * WebView/WebHTMLView.mm:
1032         (-[WebHTMLView _removeWindowObservers]):
1033         (-[WebHTMLView addWindowObservers]):
1034         * WebView/WebView.mm:
1035         (-[WebView addWindowObserversForWindow:]):
1036         (-[WebView removeWindowObservers]):
1037         (-[WebView viewWillMoveToWindow:]):
1038
1039 2017-08-31  Alex Christensen  <achristensen@webkit.org>
1040
1041         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
1042         https://bugs.webkit.org/show_bug.cgi?id=175779
1043         <rdar://problem/22367975>
1044
1045         Reviewed by Tim Horton.
1046
1047         * WebCoreSupport/WebFrameLoaderClient.h:
1048         * WebCoreSupport/WebFrameLoaderClient.mm:
1049         (WebFrameLoaderClient::webGLPolicyForURL const):
1050         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
1051
1052 2017-08-30  Andy Estes  <aestes@apple.com>
1053
1054         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
1055         https://bugs.webkit.org/show_bug.cgi?id=176093
1056
1057         Reviewed by Eric Carlson.
1058
1059         * WebCoreSupport/WebSystemInterface.mm:
1060         (InitWebCoreSystemInterface):
1061
1062 2017-08-30  Andy Estes  <aestes@apple.com>
1063
1064         [Mac] Upstream Carbon-related WebKitSystemInterface functions
1065         https://bugs.webkit.org/show_bug.cgi?id=176087
1066
1067         Reviewed by Alex Christensen.
1068
1069         * Carbon/CarbonUtils.m:
1070         (getNSAutoreleasePoolCount):
1071         (WebInitForCarbon):
1072         (PoolCleaner):
1073         * Carbon/CarbonWindowAdapter.mm:
1074         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1075         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1076         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1077         (-[CarbonWindowAdapter _windowMovedToRect:]):
1078         * Carbon/HIViewAdapter.m:
1079         * Carbon/HIWebView.mm:
1080         (Draw):
1081         (CreateNSEventAdoptingCGEvent):
1082         (CopyEventCGEvent):
1083         (CreateNSEventWithCarbonClickEvent):
1084         (Click):
1085         (CreateNSEventWithCarbonEvent):
1086         (MouseUp):
1087         (CreateNSEventWithCarbonMouseMoveEvent):
1088         (MouseMoved):
1089         (MouseDragged):
1090         (MouseWheelMoved):
1091         (WindowHandler):
1092         (HIWebViewEventHandler):
1093         * Misc/QuickDrawCompatibility.h: Removed.
1094         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1095         (getCarbonEvent):
1096         (WebNetscapePluginEventHandlerCarbon::keyDown):
1097         (WebNetscapePluginEventHandlerCarbon::keyUp):
1098         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1099         (WebNetscapePluginEventHandlerCocoa::keyDown):
1100         * Plugins/WebNetscapePluginView.mm:
1101         (-[WebNetscapePluginView tellQuickTimeToChill]):
1102
1103 2017-08-29  Andy Estes  <aestes@apple.com>
1104
1105         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
1106         https://bugs.webkit.org/show_bug.cgi?id=176046
1107
1108         Reviewed by Alex Christensen.
1109
1110         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
1111         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
1112
1113         * Misc/WebNSFileManagerExtras.mm:
1114         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
1115         (setMetaData): Deleted.
1116         * WebCoreSupport/WebSystemInterface.mm:
1117         (InitWebCoreSystemInterface):
1118
1119 2017-08-28  Andy Estes  <aestes@apple.com>
1120
1121         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
1122         https://bugs.webkit.org/show_bug.cgi?id=176039
1123
1124         Reviewed by Alex Christensen.
1125
1126         * WebCoreSupport/WebSystemInterface.mm:
1127         (InitWebCoreSystemInterface):
1128         * WebView/WebPreferences.mm:
1129         (+[WebPreferences _systemCFStringEncoding]):
1130
1131 2017-08-28  Andy Estes  <aestes@apple.com>
1132
1133         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
1134         https://bugs.webkit.org/show_bug.cgi?id=176032
1135
1136         Reviewed by Alex Christensen.
1137
1138         * WebCoreSupport/WebSystemInterface.mm:
1139         (InitWebCoreSystemInterface):
1140         * WebView/WebView.mm:
1141         (-[WebView _cachedResponseForURL:]):
1142
1143 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
1144
1145         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
1146         https://bugs.webkit.org/show_bug.cgi?id=175992
1147         <rdar://problem/34086613>
1148
1149         Reviewed by Daniel Bates.
1150
1151         * WebCoreSupport/WebPlatformStrategies.h:
1152         * WebCoreSupport/WebPlatformStrategies.mm:
1153         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
1154         cookies should be included, and return a pair containing the resulting cookie string and a boolean
1155         indicating if secure cookies were accessed.
1156
1157 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1158
1159         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
1160         https://bugs.webkit.org/show_bug.cgi?id=170955
1161         <rdar://problem/31697653>
1162
1163         Reviewed by Ryosuke Niwa.
1164
1165         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
1166         text is being replaced.
1167
1168         * WebView/WebHTMLView.mm:
1169         (-[WebHTMLView insertText:]):
1170
1171 2017-08-24  Chris Dumez  <cdumez@apple.com>
1172
1173         [Directory Upload] Add basic support for input.webkitdirectory
1174         https://bugs.webkit.org/show_bug.cgi?id=175950
1175         <rdar://problem/33951915>
1176
1177         Reviewed by Geoffrey Garen.
1178
1179         Add private API to toggle Directory Upload support on Mac WebKit1.
1180
1181         * WebView/WebPreferenceKeysPrivate.h:
1182         * WebView/WebPreferences.mm:
1183         (+[WebPreferences initialize]):
1184         (-[WebPreferences setDirectoryUploadEnabled:]):
1185         (-[WebPreferences directoryUploadEnabled]):
1186         * WebView/WebPreferencesPrivate.h:
1187         * WebView/WebView.mm:
1188         (-[WebView _preferencesChanged:]):
1189
1190 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1191
1192         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
1193         https://bugs.webkit.org/show_bug.cgi?id=175370
1194         <rdar://problem/33799806>
1195
1196         Reviewed by Ryosuke Niwa.
1197
1198         Adjust WebEditorClient for interface changes.
1199
1200         * WebCoreSupport/WebEditorClient.h:
1201
1202 2017-08-22  Alex Christensen  <achristensen@webkit.org>
1203
1204         Remove ChromeClient::scrollbarsModeDidChange
1205         https://bugs.webkit.org/show_bug.cgi?id=175805
1206
1207         Reviewed by Daniel Bates.
1208
1209         * WebCoreSupport/WebChromeClient.h:
1210
1211 2017-08-22  Alex Christensen  <achristensen@webkit.org>
1212
1213         Remove ChromeClient::hasOpenedPopup
1214         https://bugs.webkit.org/show_bug.cgi?id=175804
1215
1216         Reviewed by Sam Weinig.
1217
1218         * WebCoreSupport/WebChromeClient.h:
1219         * WebCoreSupport/WebChromeClient.mm:
1220         (WebChromeClient::hasOpenedPopup const): Deleted.
1221
1222 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
1223
1224         Disable access to secure cookies if an HTTPS site loads mixed content
1225         https://bugs.webkit.org/show_bug.cgi?id=157053
1226         <rdar://problem/11290808>
1227
1228         Reviewed by Dan Bates.
1229
1230         * WebCoreSupport/WebPlatformStrategies.h:
1231         * WebCoreSupport/WebPlatformStrategies.mm:
1232         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
1233         indicating whether secure cookies should be included in the response.
1234
1235 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1236
1237         [PAL] Move spi/mac directory into PAL
1238         https://bugs.webkit.org/show_bug.cgi?id=175649
1239
1240         Reviewed by Myles C. Maxfield.
1241
1242         * Misc/WebSharingServicePickerController.h:
1243         * WebCoreSupport/WebContextMenuClient.mm:
1244         * WebCoreSupport/WebEditorClient.mm:
1245         * WebCoreSupport/WebSelectionServiceController.mm:
1246         * WebView/WebHTMLView.mm:
1247         * WebView/WebImmediateActionController.h:
1248         * WebView/WebImmediateActionController.mm:
1249         * WebView/WebView.mm:
1250
1251 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
1252
1253         [PAL] Relocate SessionID to root
1254         https://bugs.webkit.org/show_bug.cgi?id=175684
1255
1256         Reviewed by Alex Christensen.
1257
1258         * WebCoreSupport/WebFrameNetworkingContext.mm:
1259
1260 2017-08-17  Andreas Kling  <akling@apple.com>
1261
1262         Disable CSS regions at compile time
1263         https://bugs.webkit.org/show_bug.cgi?id=175630
1264
1265         Reviewed by Antti Koivisto.
1266
1267         * Configurations/FeatureDefines.xcconfig:
1268
1269 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
1270
1271         [PAL] Move SessionID into PAL
1272         https://bugs.webkit.org/show_bug.cgi?id=174192
1273
1274         Reviewed by Antti Koivisto.
1275
1276         * Misc/WebCache.mm:
1277         (+[WebCache imageForURL:]):
1278         * WebCoreSupport/WebFrameLoaderClient.h:
1279         * WebCoreSupport/WebFrameLoaderClient.mm:
1280         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1281         * WebCoreSupport/WebFrameNetworkingContext.mm:
1282         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1283         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
1284         (WebFrameNetworkingContext::storageSession const):
1285         * WebCoreSupport/WebPlatformStrategies.h:
1286         * WebCoreSupport/WebPlatformStrategies.mm:
1287         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1288         * WebKitPrefix.h:
1289
1290 2017-08-16  Andy Estes  <aestes@apple.com>
1291
1292         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
1293         https://bugs.webkit.org/show_bug.cgi?id=175648
1294
1295         Reviewed by Tim Horton.
1296
1297         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1298         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1299         (WebPaymentCoordinatorClient::showPaymentUI):
1300
1301 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1302
1303         [PAL] Move spi/ios and spi/win directories into PAL
1304         https://bugs.webkit.org/show_bug.cgi?id=175171
1305
1306         Reviewed by Antti Koivisto.
1307
1308         * WebCoreSupport/WebFrameLoaderClient.mm:
1309         * WebView/WebView.mm:
1310
1311 2017-08-16  Andy Estes  <aestes@apple.com>
1312
1313         [Payment Request] Add an ENABLE flag and an experimental feature preference
1314         https://bugs.webkit.org/show_bug.cgi?id=175622
1315
1316         Reviewed by Tim Horton.
1317
1318         * Configurations/FeatureDefines.xcconfig:
1319
1320 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
1321
1322         [PAL] Move Sleep classes into PAL
1323         https://bugs.webkit.org/show_bug.cgi?id=175456
1324
1325         Reviewed by Ryosuke Niwa.
1326
1327         * WebView/WebFullScreenController.h:
1328
1329 2017-08-15  Youenn Fablet  <youenn@apple.com>
1330
1331         [Cache API] Adding generic support for CacheStorage and Cache methods
1332         https://bugs.webkit.org/show_bug.cgi?id=175455
1333
1334         Reviewed by Chris Dumez.
1335
1336         * WebView/WebView.mm:
1337         (-[WebView _commonInitializationWithFrameName:groupName:]):
1338
1339 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1340
1341         Remove Proximity Events and related code
1342         https://bugs.webkit.org/show_bug.cgi?id=175545
1343
1344         Reviewed by Daniel Bates.
1345
1346         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
1347         and other related code.
1348
1349         * Configurations/FeatureDefines.xcconfig:
1350
1351 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1352
1353         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
1354         https://bugs.webkit.org/show_bug.cgi?id=175504
1355
1356         Reviewed by Sam Weinig.
1357
1358         * Configurations/FeatureDefines.xcconfig:
1359         * DOM/DOMHTMLFormElement.mm:
1360         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
1361         * WebCoreSupport/WebFrameLoaderClient.h:
1362
1363 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1364
1365         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
1366         https://bugs.webkit.org/show_bug.cgi?id=175557
1367
1368         Reviewed by Jon Lee.
1369
1370         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
1371
1372         * Configurations/FeatureDefines.xcconfig:
1373
1374 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
1375
1376         Composition underline color is always black
1377         https://bugs.webkit.org/show_bug.cgi?id=174675
1378
1379         Reviewed by Ryosuke Niwa.
1380
1381         * WebView/WebHTMLView.mm:
1382         (extractUnderlines): If NSUnderlineColorAttributeName
1383         is not present use text color for composition underline.
1384         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
1385         for composition underline in the plain text case.
1386
1387 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
1388
1389         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
1390         https://bugs.webkit.org/show_bug.cgi?id=175474
1391         <rdar://problem/33844628>
1392
1393         Reviewed by Wenson Hsieh.
1394
1395         Replaced the build flag by a runtime flag and disabled the feature by default.
1396
1397         * Configurations/FeatureDefines.xcconfig:
1398         * WebView/WebPreferenceKeysPrivate.h:
1399         * WebView/WebPreferences.mm:
1400         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
1401         (-[WebPreferences dataTransferItemsEnabled]): Added.
1402         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
1403         * WebView/WebPreferencesPrivate.h:
1404         * WebView/WebView.mm:
1405         (-[WebView _preferencesChanged:]):
1406
1407 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1408
1409         Remove ENABLE_GAMEPAD_DEPRECATED
1410         https://bugs.webkit.org/show_bug.cgi?id=175361
1411
1412         Reviewed by Carlos Garcia Campos.
1413
1414         * Configurations/FeatureDefines.xcconfig:
1415
1416 2017-08-09  Chris Dumez  <cdumez@apple.com>
1417
1418         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
1419         https://bugs.webkit.org/show_bug.cgi?id=175401
1420
1421         Reviewed by Brady Eidson.
1422
1423         * WebView/WebPreferenceKeysPrivate.h:
1424         * WebView/WebPreferences.mm:
1425         (+[WebPreferences initialize]):
1426         (-[WebPreferences beaconAPIEnabled]): Deleted.
1427         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
1428         * WebView/WebPreferencesPrivate.h:
1429         * WebView/WebView.mm:
1430         (-[WebView _preferencesChanged:]):
1431
1432 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1433
1434         [PAL] Move spi/cocoa and spi/cg directories into PAL
1435         https://bugs.webkit.org/show_bug.cgi?id=175175
1436
1437         Reviewed by Myles C. Maxfield.
1438
1439         * History/WebHistory.mm:
1440         * Misc/WebDownload.mm:
1441         * Misc/WebKitNSStringExtras.mm:
1442         * Plugins/Hosted/NetscapePluginHostManager.mm:
1443         * Plugins/WebPluginDatabase.mm:
1444         * WebCoreSupport/WebFrameLoaderClient.mm:
1445         * WebInspector/WebNodeHighlight.mm:
1446         * WebView/WebHTMLView.mm:
1447         * WebView/WebIndicateLayer.mm:
1448         * WebView/WebView.mm:
1449         * WebView/WebViewData.h:
1450
1451 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1452
1453         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
1454         https://bugs.webkit.org/show_bug.cgi?id=175392
1455         <rdar://problem/33783207>
1456
1457         Reviewed by Tim Horton and Megan Gardner.
1458
1459         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
1460
1461         * Configurations/FeatureDefines.xcconfig:
1462
1463 2017-08-09  Daniel Bates  <dabates@apple.com>
1464
1465         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
1466         https://bugs.webkit.org/show_bug.cgi?id=175247
1467         <rdar://problem/33679804>
1468
1469         Reviewed by Brady Eidson.
1470
1471         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
1472         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
1473         clients that need to make use of this information at this time. If such a needs comes up
1474         then we can expose API/SPI similar to what we do for WebKit.
1475
1476         * WebCoreSupport/WebFrameLoaderClient.h:
1477         * WebCoreSupport/WebFrameLoaderClient.mm:
1478         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1479
1480 2017-08-08  Brady Eidson  <beidson@apple.com>
1481
1482         Don't enable default icon loading in WK1 for apps linked against old SDKs.
1483         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
1484
1485         Reviewed by Andy Estes.
1486
1487         * Misc/WebKitVersionChecks.h:
1488         * WebCoreSupport/WebFrameLoaderClient.mm:
1489         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
1490           the app is linked against new WebKit with the new behavior.
1491
1492 2017-08-07  Devin Rousso  <drousso@apple.com>
1493
1494         Web Inspector: Preview Canvas path when viewing a recording
1495         https://bugs.webkit.org/show_bug.cgi?id=174967
1496
1497         Reviewed by Brian Burg.
1498
1499         * WebView/WebPreferenceKeysPrivate.h:
1500         * WebView/WebPreferences.mm:
1501         (+[WebPreferences initialize]):
1502         (-[WebPreferences inspectorAdditionsEnabled]):
1503         (-[WebPreferences setInspectorAdditionsEnabled:]):
1504         * WebView/WebPreferencesPrivate.h:
1505         * WebView/WebView.mm:
1506         (-[WebView _preferencesChanged:]):
1507         Add plumbing for new InspectorAdditions runtime flag.
1508
1509 2017-08-07  Brian Burg  <bburg@apple.com>
1510
1511         Remove CANVAS_PATH compilation guard
1512         https://bugs.webkit.org/show_bug.cgi?id=175207
1513
1514         Reviewed by Sam Weinig.
1515
1516         * Configurations/FeatureDefines.xcconfig:
1517
1518 2017-08-04  Youenn Fablet  <youenn@apple.com>
1519
1520         [Cache API] Add Cache and CacheStorage IDL definitions
1521         https://bugs.webkit.org/show_bug.cgi?id=175201
1522
1523         Reviewed by Brady Eidson.
1524
1525         * WebView/WebPreferenceKeysPrivate.h:
1526         * WebView/WebPreferences.mm:
1527         (+[WebPreferences initialize]):
1528         (-[WebPreferences cacheAPIEnabled]):
1529         (-[WebPreferences setCacheAPIEnabled:]):
1530         * WebView/WebPreferencesPrivate.h:
1531         * WebView/WebView.mm:
1532         (-[WebView _preferencesChanged:]):
1533
1534 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1535
1536         Unreviewed, rolling out r220271.
1537
1538         Rolling out due to Layout Test failing on iOS Simulator.
1539
1540         Reverted changeset:
1541
1542         "Remove STREAMS_API compilation guard"
1543         https://bugs.webkit.org/show_bug.cgi?id=175165
1544         http://trac.webkit.org/changeset/220271
1545
1546 2017-08-04  Youenn Fablet  <youenn@apple.com>
1547
1548         Remove STREAMS_API compilation guard
1549         https://bugs.webkit.org/show_bug.cgi?id=175165
1550
1551         Reviewed by Darin Adler.
1552
1553         * Configurations/FeatureDefines.xcconfig:
1554         * WebView/WebPreferences.mm:
1555         (+[WebPreferences initialize]):
1556         * WebView/WebView.mm:
1557         (-[WebView _preferencesChanged:]):
1558
1559 2017-08-03  Brian Burg  <bburg@apple.com>
1560
1561         Remove ENABLE(WEB_SOCKET) guards
1562         https://bugs.webkit.org/show_bug.cgi?id=167044
1563
1564         Reviewed by Joseph Pecoraro.
1565
1566         * Configurations/FeatureDefines.xcconfig:
1567         * WebView/WebPreferencesPrivate.h:
1568
1569 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1570
1571         [PAL] Move spi/cf directory into PAL
1572         https://bugs.webkit.org/show_bug.cgi?id=175057
1573
1574         Reviewed by Antti Koivisto.
1575
1576         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1577         * Plugins/WebNetscapePluginStream.mm:
1578         * WebCoreSupport/WebFrameNetworkingContext.mm:
1579         * WebView/WebPreferences.mm:
1580         * WebView/WebView.mm:
1581
1582 2017-08-03  Youenn Fablet  <youenn@apple.com>
1583
1584         Remove FETCH_API compilation guard
1585         https://bugs.webkit.org/show_bug.cgi?id=175154
1586
1587         Reviewed by Chris Dumez.
1588
1589         * Configurations/FeatureDefines.xcconfig:
1590         * WebView/WebPreferences.mm:
1591         (+[WebPreferences initialize]):
1592         * WebView/WebView.mm:
1593         (-[WebView _preferencesChanged:]):
1594
1595 2017-08-03  Brady Eidson  <beidson@apple.com>
1596
1597         Add SW IDLs and stub out basic functionality.
1598         https://bugs.webkit.org/show_bug.cgi?id=175115
1599
1600         Reviewed by Chris Dumez.
1601
1602         * Configurations/FeatureDefines.xcconfig:
1603
1604 2017-08-02  Sam Weinig  <sam@webkit.org>
1605
1606         [WebIDL] Convert MutationCallback to be a normal generated callback
1607         https://bugs.webkit.org/show_bug.cgi?id=174140
1608
1609         Reviewed by Darin Adler.
1610
1611         * DOM/DOMDocument.mm:
1612         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
1613         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
1614         Pass, now necessary, Document to NativeNodeFilter constructor.
1615
1616 2017-08-01  Chris Dumez  <cdumez@apple.com>
1617
1618         Add initial support for navigator.sendBeacon
1619         https://bugs.webkit.org/show_bug.cgi?id=175007
1620         <rdar://problem/33547728>
1621
1622         Reviewed by Sam Weinig.
1623
1624         Add setting to toggle support for the Beacon API (it is disabled by default).
1625
1626         * WebView/WebPreferenceKeysPrivate.h:
1627         * WebView/WebPreferences.mm:
1628         (+[WebPreferences initialize]):
1629         (-[WebPreferences beaconAPIEnabled]):
1630         (-[WebPreferences setBeaconAPIEnabled:]):
1631         * WebView/WebPreferencesPrivate.h:
1632         * WebView/WebView.mm:
1633         (-[WebView _preferencesChanged:]):
1634
1635 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
1636
1637         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
1638         https://bugs.webkit.org/show_bug.cgi?id=174437
1639
1640         Reviewed by Darin Adler.
1641
1642         Remove redundant Web- prefix from classes in WebKit namespace.
1643
1644         * WebView/WebView.mm:
1645         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1646         * WebView/WebViewData.h:
1647         * WebView/WebViewData.mm:
1648
1649 2017-07-26  Brian Burg  <bburg@apple.com>
1650
1651         Remove WEB_TIMING feature flag
1652         https://bugs.webkit.org/show_bug.cgi?id=174795
1653
1654         Reviewed by Alex Christensen.
1655
1656         * Configurations/FeatureDefines.xcconfig:
1657
1658 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
1659
1660         Async image decoding for large images should be disabled after the first time a tile is painted
1661         https://bugs.webkit.org/show_bug.cgi?id=174451
1662         <rdar://problem/31246421>
1663
1664         Reviewed by Simon Fraser.
1665
1666         * WebView/WebFrame.mm:
1667         (-[WebFrame _paintBehaviorForDestinationContext:]):
1668         (-[WebFrame _drawRect:contentsOnly:]):
1669         * WebView/WebHTMLView.mm:
1670         (imageFromRect):
1671
1672 2017-07-23  Darin Adler  <darin@apple.com>
1673
1674         More NeverDestroyed and related cleanup
1675         https://bugs.webkit.org/show_bug.cgi?id=174745
1676
1677         Reviewed by Alex Christensen.
1678
1679         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
1680         for names that aren't even used in this file.
1681         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
1682         -[NSArray arrayWithObject:].
1683         (-[DOMNode absoluteQuads]): Ditto.
1684         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
1685         of writing out various types.
1686         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
1687         syntax instea of -[NSArray arrayWithObject:].
1688         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
1689         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
1690         of writing out various types.
1691         (-[DOMHTMLImageElement mimeType]): Ditto.
1692
1693 2017-07-24  Chris Dumez  <cdumez@apple.com>
1694
1695         ExceptionCode enumeration should use modern exception names
1696         https://bugs.webkit.org/show_bug.cgi?id=174794
1697
1698         Reviewed by Geoffrey Garen.
1699
1700         * DOM/ExceptionHandlers.mm:
1701         (raiseNotSupportedErrorException):
1702
1703 2017-07-23  Chris Dumez  <cdumez@apple.com>
1704
1705         Drop ExceptionCodeDescription class
1706         https://bugs.webkit.org/show_bug.cgi?id=174757
1707
1708         Reviewed by Darin Adler.
1709
1710         Stop using ExceptionCodeDescription.
1711
1712         * DOM/ExceptionHandlers.mm:
1713         (raiseDOMErrorException):
1714
1715 2017-07-21  Andreas Kling  <akling@apple.com>
1716
1717         Use more references in event dispatch code
1718         https://bugs.webkit.org/show_bug.cgi?id=174681
1719
1720         Reviewed by Geoffrey Garen.
1721
1722         * DOM/ObjCEventListener.h:
1723         * DOM/ObjCEventListener.mm:
1724         (WebCore::ObjCEventListener::handleEvent):
1725         * WebCoreSupport/WebFrameLoaderClient.mm:
1726         (NetscapePluginWidget::handleEvent):
1727
1728 2017-07-21  Brady Eidson  <beidson@apple.com>
1729
1730         Get rid of WebCore IconDatabase code.
1731         https://bugs.webkit.org/show_bug.cgi?id=174700
1732
1733         Reviewed by Tim Horton.
1734
1735         * Misc/WebCoreStatistics.mm:
1736         (+[WebCoreStatistics iconPageURLMappingCount]):
1737         (+[WebCoreStatistics iconRetainedPageURLCount]):
1738         (+[WebCoreStatistics iconRecordCount]):
1739         (+[WebCoreStatistics iconsWithDataCount]):
1740         * WebCoreSupport/WebFrameLoaderClient.h:
1741         * WebCoreSupport/WebFrameLoaderClient.mm:
1742         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
1743         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
1744         * WebView/WebView.mm:
1745         (-[WebView mainFrameIconURL]):
1746
1747 2017-07-20  Chris Dumez  <cdumez@apple.com>
1748
1749         Drop legacy XPathException type
1750         https://bugs.webkit.org/show_bug.cgi?id=174679
1751
1752         Reviewed by Sam Weinig.
1753
1754         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
1755         no longer expose XPathException.
1756
1757         * DOM/ExceptionHandlers.mm:
1758         (raiseDOMErrorException):
1759
1760 2017-07-20  Chris Dumez  <cdumez@apple.com>
1761
1762         Unreviewed, rolling out r219706.
1763
1764         Broke iOS build
1765
1766         Reverted changeset:
1767
1768         "Drop legacy XPathException type"
1769         https://bugs.webkit.org/show_bug.cgi?id=174679
1770         http://trac.webkit.org/changeset/219706
1771
1772 2017-07-20  Chris Dumez  <cdumez@apple.com>
1773
1774         Drop legacy XPathException type
1775         https://bugs.webkit.org/show_bug.cgi?id=174679
1776
1777         Reviewed by Sam Weinig.
1778
1779         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
1780         no longer expose XPathException.
1781
1782         * DOM/ExceptionHandlers.mm:
1783         (raiseDOMErrorException):
1784         * WebKit.exp:
1785
1786 2017-07-20  Chris Dumez  <cdumez@apple.com>
1787
1788         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
1789         https://bugs.webkit.org/show_bug.cgi?id=174660
1790
1791         Reviewed by Geoffrey Garen.
1792
1793         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
1794         This essentially replaces a branch to figure out if the new size is less or greater than the
1795         current size by an assertion.
1796
1797         * Plugins/WebNetscapePluginView.mm:
1798         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1799
1800 2017-07-20  Brady Eidson  <beidson@apple.com>
1801
1802         Deprecate WebIconDatabase in WebKitLegacy/mac.
1803         https://bugs.webkit.org/show_bug.cgi?id=174607
1804
1805         Reviewed by Alex Christensen.
1806
1807         This patch:
1808         1 - Formally deprecates WebIconDatabase (which was never API anyways)
1809         2 - Guts the class to where it can only return the default icon at the small size
1810         3 - Reworks other parts of WebKitLegacy that used it for anything to either
1811             use something else or to not do anything.
1812         
1813         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
1814         and that patch will remove all of the last remnants of WebIconDatabase.
1815         
1816         * History/WebHistoryItem.mm:
1817         (-[WebHistoryItem icon]):
1818
1819         * Misc/WebIconDatabase.h:
1820         * Misc/WebIconDatabase.mm:
1821         (-[WebIconDatabase init]):
1822         (-[WebIconDatabase iconForURL:withSize:cache:]):
1823         (-[WebIconDatabase iconForURL:withSize:]):
1824         (-[WebIconDatabase defaultIconWithSize:]):
1825         (-[WebIconDatabase defaultIconForURL:withSize:]):
1826         (-[WebIconDatabase iconURLForURL:]):
1827         (-[WebIconDatabase retainIconForURL:]):
1828         (-[WebIconDatabase releaseIconForURL:]):
1829         (+[WebIconDatabase delayDatabaseCleanup]):
1830         (+[WebIconDatabase allowDatabaseCleanup]):
1831         (-[WebIconDatabase setDelegate:]):
1832         (-[WebIconDatabase delegate]):
1833         (+[WebIconDatabase initialize]): Deleted.
1834         (-[WebIconDatabase isEnabled]): Deleted.
1835         (-[WebIconDatabase setEnabled:]): Deleted.
1836         (-[WebIconDatabase removeAllIcons]): Deleted.
1837         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
1838         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
1839         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
1840         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
1841         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
1842         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
1843         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
1844         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
1845         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
1846         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
1847         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
1848         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
1849         (-[WebIconDatabase _databaseDirectory]): Deleted.
1850         (webGetNSImage): Deleted.
1851
1852         * Misc/WebIconDatabaseDelegate.h: Removed.
1853         * Misc/WebIconDatabaseInternal.h: Removed.
1854         * Misc/WebIconDatabasePrivate.h: Removed.
1855
1856         * WebCoreSupport/WebFrameLoaderClient.mm:
1857         (webGetNSImage):
1858
1859         * WebCoreSupport/WebIconDatabaseClient.mm:
1860         (WebIconDatabaseClient::didRemoveAllIcons):
1861         (WebIconDatabaseClient::didImportIconURLForPageURL):
1862
1863         * WebView/WebView.mm:
1864         (-[WebView setFrameLoadDelegate:]):
1865         (-[WebView mainFrameIcon]):
1866
1867 2017-07-18  Andy Estes  <aestes@apple.com>
1868
1869         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1870         https://bugs.webkit.org/show_bug.cgi?id=174631
1871
1872         Reviewed by Tim Horton.
1873
1874         * Configurations/Base.xcconfig:
1875
1876 2017-07-18  Andy Estes  <aestes@apple.com>
1877
1878         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1879         https://bugs.webkit.org/show_bug.cgi?id=174631
1880
1881         Reviewed by Sam Weinig.
1882
1883         * Configurations/Base.xcconfig:
1884
1885 2017-07-18  Andy Estes  <aestes@apple.com>
1886
1887         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
1888         https://bugs.webkit.org/show_bug.cgi?id=174631
1889
1890         Reviewed by Dan Bernstein.
1891
1892         * Configurations/Base.xcconfig:
1893
1894 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1895
1896         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
1897         https://bugs.webkit.org/show_bug.cgi?id=174640
1898         <rdar://problem/33297400>
1899
1900         Reviewed by Tim Horton.
1901
1902         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
1903         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
1904         web thread here, to match the other WebView drag and drop SPI methods.
1905
1906         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
1907         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
1908         should make this robust against future UIKit changes that could make this no longer the case.
1909
1910         * WebView/WebView.mm:
1911         (-[WebView _requestStartDataInteraction:globalPosition:]):
1912         (-[WebView _dataInteractionCaretRect]):
1913
1914 2017-07-18  Andy Estes  <aestes@apple.com>
1915
1916         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
1917         https://bugs.webkit.org/show_bug.cgi?id=174631
1918
1919         Reviewed by Darin Adler.
1920
1921         * Configurations/Base.xcconfig:
1922
1923 2017-07-17  Sam Weinig  <sam@webkit.org>
1924
1925         [WebIDL] Remove custom bindings that require non-caching JS strings
1926         https://bugs.webkit.org/show_bug.cgi?id=174552
1927
1928         Reviewed by Darin Adler.
1929
1930         * DOM/DOMHTMLCanvasElement.mm:
1931         (-[DOMHTMLCanvasElement toDataURL:]):
1932         Update to account for implementation now returning an UncachedString.
1933
1934 2017-07-17  Darin Adler  <darin@apple.com>
1935
1936         Improve use of NeverDestroyed
1937         https://bugs.webkit.org/show_bug.cgi?id=174348
1938
1939         Reviewed by Sam Weinig.
1940
1941         * Misc/WebStringTruncator.mm:
1942         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
1943         NeverDestroyed<RetainPtr> with just an NSFont * global.
1944
1945         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
1946         NeverDestroyed.h.
1947         * Storage/WebDatabaseManager.mm: Ditto.
1948         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
1949         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
1950
1951         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
1952         (aeDescFromJSValue): Removed double hashing by using the return value from
1953         add rather than calling contains before calling add.
1954
1955 2017-07-14  Jer Noble  <jer.noble@apple.com>
1956
1957         Allow clients to override their own hardware media requirements where no fallback media exists.
1958         https://bugs.webkit.org/show_bug.cgi?id=174426
1959         <rdar://problem/32537704>
1960
1961         Reviewed by Eric Carlson.
1962
1963         Add a new WebPreferences property to control WebCore's new
1964         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
1965
1966         * WebView/WebPreferenceKeysPrivate.h:
1967         * WebView/WebPreferences.mm:
1968         (+[WebPreferences initialize]):
1969         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
1970         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
1971         * WebView/WebPreferencesPrivate.h:
1972         * WebView/WebView.mm:
1973         (-[WebView _preferencesChanged:]):
1974
1975 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
1976
1977         Async image decoding for large images should be disabled by default
1978         https://bugs.webkit.org/show_bug.cgi?id=174432
1979
1980         Reviewed by Simon Fraser.
1981
1982         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
1983         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
1984         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
1985            a child view instead of propagating PaintBehaviorSnapshotting.
1986         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
1987            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
1988
1989         * WebView/WebFrame.mm:
1990         (-[WebFrame _paintBehaviorForDestinationContext:]):
1991         (-[WebFrame _drawRect:contentsOnly:]):
1992         * WebView/WebHTMLView.mm:
1993         (imageFromRect):
1994
1995 2017-07-12  Daniel Bates  <dabates@apple.com>
1996
1997         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
1998         https://bugs.webkit.org/show_bug.cgi?id=174427
1999
2000         Rubber-stamped by Brady Eidson.
2001
2002         * WebView/WebPDFView.mm:
2003         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2004
2005 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2006
2007         Unreviewed, rolling out r219401.
2008
2009         This revision rolled out the previous patch, but after talking
2010         with reviewer, a rebaseline is what was needed.Rolling back in
2011         before rebaseline.
2012
2013         Reverted changeset:
2014
2015         "Unreviewed, rolling out r219379."
2016         https://bugs.webkit.org/show_bug.cgi?id=174400
2017         http://trac.webkit.org/changeset/219401
2018
2019 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2020
2021         Unreviewed, rolling out r219379.
2022
2023         This revision caused a consistent failure in the test
2024         fast/dom/Window/property-access-on-cached-window-after-frame-
2025         removed.html.
2026
2027         Reverted changeset:
2028
2029         "Remove NAVIGATOR_HWCONCURRENCY"
2030         https://bugs.webkit.org/show_bug.cgi?id=174400
2031         http://trac.webkit.org/changeset/219379
2032
2033 2017-07-11  Dean Jackson  <dino@apple.com>
2034
2035         Remove NAVIGATOR_HWCONCURRENCY
2036         https://bugs.webkit.org/show_bug.cgi?id=174400
2037
2038         * Configurations/FeatureDefines.xcconfig:
2039
2040 2017-07-11  Dean Jackson  <dino@apple.com>
2041
2042         Rolling out r219372.
2043
2044         * Configurations/FeatureDefines.xcconfig:
2045
2046 2017-07-11  Dean Jackson  <dino@apple.com>
2047
2048         Remove NAVIGATOR_HWCONCURRENCY
2049         https://bugs.webkit.org/show_bug.cgi?id=174400
2050
2051         * Configurations/FeatureDefines.xcconfig:
2052
2053 2017-07-03  Brian Burg  <bburg@apple.com>
2054
2055         Web Replay: remove some unused code
2056         https://bugs.webkit.org/show_bug.cgi?id=173903
2057
2058         Rubber-stamped by Joseph Pecoraro.
2059
2060         * Configurations/FeatureDefines.xcconfig:
2061
2062 2017-07-09  Brady Eidson  <beidson@apple.com>
2063
2064         Remove some obsolete WebKitVersionChecks.
2065         https://bugs.webkit.org/show_bug.cgi?id=174294
2066
2067         Reviewed by Dan Bernstein.
2068
2069         * Misc/WebKitVersionChecks.h:
2070
2071         * WebView/WebHTMLView.mm:
2072         (-[WebHTMLView hitTest:]):
2073
2074         * WebView/WebView.mm:
2075         (shouldRespectPriorityInCSSAttributeSetters):
2076         (-[WebView _commonInitializationWithFrameName:groupName:]):
2077         (-[WebView _preferencesChanged:]):
2078         (shouldTransformsAffectOverflow): Deleted.
2079         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
2080
2081 2017-07-08  Brady Eidson  <beidson@apple.com>
2082
2083         Remove some obsolete RuntimeApplicationChecks.
2084         https://bugs.webkit.org/show_bug.cgi?id=174293
2085
2086         Reviewed by Dan Bernstein.
2087
2088         * Misc/WebKitVersionChecks.h:
2089         * WebView/WebView.mm:
2090         (+[WebView enableWebThread]):
2091         (-[WebView _needsPreHTML5ParserQuirks]):
2092
2093 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2094
2095         Drop NOSNIFF compile flag
2096         https://bugs.webkit.org/show_bug.cgi?id=174289
2097
2098         Reviewed by Michael Catanzaro.
2099
2100         * Configurations/FeatureDefines.xcconfig:
2101
2102 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2103
2104         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2105         https://bugs.webkit.org/show_bug.cgi?id=174150
2106
2107         Reviewed by Mark Lam.
2108
2109         * DOM/DOM.mm:
2110         (lookupElementClass):
2111
2112 2017-07-06  Brady Eidson  <beidson@apple.com>
2113
2114         Add logging to first attempt to use the WebIconDatabase class.
2115         https://bugs.webkit.org/show_bug.cgi?id=174190
2116
2117         Reviewed by Andy Estes.
2118
2119         * Misc/WebIconDatabase.mm:
2120         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
2121         * Misc/WebKitVersionChecks.h:
2122
2123 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2124
2125         Unreviewed, rolling out r219178.
2126
2127         This caused a consistent failure with the API test
2128         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2129
2130         Reverted changeset:
2131
2132         "[WTF] Clean up StringStatics.cpp by using
2133         LazyNeverDestroyed<> for Atoms"
2134         https://bugs.webkit.org/show_bug.cgi?id=174150
2135         http://trac.webkit.org/changeset/219178
2136
2137 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2138
2139         [WTF] Move SoftLinking.h into WTF
2140         https://bugs.webkit.org/show_bug.cgi?id=174000
2141
2142         Reviewed by Alex Christensen.
2143
2144         * Plugins/WebNetscapePluginView.mm:
2145         * Plugins/WebPluginController.mm:
2146         * WebCoreSupport/WebInspectorClient.mm:
2147         * WebView/WebFullScreenController.mm:
2148         * WebView/WebImmediateActionController.mm:
2149         * WebView/WebView.mm:
2150
2151 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2152
2153         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2154         https://bugs.webkit.org/show_bug.cgi?id=174150
2155
2156         Reviewed by Mark Lam.
2157
2158         * DOM/DOM.mm:
2159         (lookupElementClass):
2160
2161 2017-07-05  Brady Eidson  <beidson@apple.com>
2162
2163         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
2164         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
2165
2166         Reviewed by Alex Christensen.
2167
2168         Adopt to the new constructor for FrameLoadRequest.
2169
2170         * WebView/WebPDFView.mm:
2171         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2172
2173 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
2174
2175         Make WebKit's public headers on Mac and iOS C++ module safe
2176         https://bugs.webkit.org/show_bug.cgi?id=174175
2177
2178         Reviewed by Alex Christensen.
2179
2180         Fixed the header files.
2181
2182         * Misc/WebDownload.h:
2183         * Misc/WebKitErrors.h:
2184         * Plugins/WebPluginContainer.h:
2185         * WebView/WebResourceLoadDelegate.h:
2186
2187 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2188
2189         Remove copy of ICU headers from WebKit
2190         https://bugs.webkit.org/show_bug.cgi?id=116407
2191
2192         Reviewed by Alex Christensen.
2193
2194         Use WTF's copy of ICU headers.
2195
2196         * Configurations/WebKitLegacy.xcconfig:
2197         * icu/unicode/localpointer.h: Removed.
2198         * icu/unicode/parseerr.h: Removed.
2199         * icu/unicode/platform.h: Removed.
2200         * icu/unicode/ptypes.h: Removed.
2201         * icu/unicode/putil.h: Removed.
2202         * icu/unicode/uchar.h: Removed.
2203         * icu/unicode/uconfig.h: Removed.
2204         * icu/unicode/ucurr.h: Removed.
2205         * icu/unicode/uidna.h: Removed.
2206         * icu/unicode/uiter.h: Removed.
2207         * icu/unicode/umachine.h: Removed.
2208         * icu/unicode/unorm.h: Removed.
2209         * icu/unicode/unorm2.h: Removed.
2210         * icu/unicode/urename.h: Removed.
2211         * icu/unicode/uscript.h: Removed.
2212         * icu/unicode/ustring.h: Removed.
2213         * icu/unicode/utf.h: Removed.
2214         * icu/unicode/utf16.h: Removed.
2215         * icu/unicode/utf8.h: Removed.
2216         * icu/unicode/utf_old.h: Removed.
2217         * icu/unicode/utypes.h: Removed.
2218         * icu/unicode/uvernum.h: Removed.
2219         * icu/unicode/uversion.h: Removed.
2220
2221 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2222
2223         Add WebKitPrivateFrameworkStubs for iOS 11
2224         https://bugs.webkit.org/show_bug.cgi?id=173988
2225
2226         Reviewed by David Kilzer.
2227
2228         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
2229         use the same directory for private framework stubs.
2230
2231 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2232
2233         Unreviewed, rolling out r219103.
2234
2235         Caused multiple build failures.
2236
2237         Reverted changeset:
2238
2239         "Remove copy of ICU headers from WebKit"
2240         https://bugs.webkit.org/show_bug.cgi?id=116407
2241         http://trac.webkit.org/changeset/219103
2242
2243 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2244
2245         Remove copy of ICU headers from WebKit
2246         https://bugs.webkit.org/show_bug.cgi?id=116407
2247
2248         Reviewed by Alex Christensen.
2249
2250         Use WTF's copy of ICU headers.
2251
2252         * Configurations/WebKitLegacy.xcconfig:
2253         * icu/unicode/localpointer.h: Removed.
2254         * icu/unicode/parseerr.h: Removed.
2255         * icu/unicode/platform.h: Removed.
2256         * icu/unicode/ptypes.h: Removed.
2257         * icu/unicode/putil.h: Removed.
2258         * icu/unicode/uchar.h: Removed.
2259         * icu/unicode/uconfig.h: Removed.
2260         * icu/unicode/ucurr.h: Removed.
2261         * icu/unicode/uidna.h: Removed.
2262         * icu/unicode/uiter.h: Removed.
2263         * icu/unicode/umachine.h: Removed.
2264         * icu/unicode/unorm.h: Removed.
2265         * icu/unicode/unorm2.h: Removed.
2266         * icu/unicode/urename.h: Removed.
2267         * icu/unicode/uscript.h: Removed.
2268         * icu/unicode/ustring.h: Removed.
2269         * icu/unicode/utf.h: Removed.
2270         * icu/unicode/utf16.h: Removed.
2271         * icu/unicode/utf8.h: Removed.
2272         * icu/unicode/utf_old.h: Removed.
2273         * icu/unicode/utypes.h: Removed.
2274         * icu/unicode/uvernum.h: Removed.
2275         * icu/unicode/uversion.h: Removed.
2276
2277 2017-07-03  Brady Eidson  <beidson@apple.com>
2278
2279         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2280         https://bugs.webkit.org/show_bug.cgi?id=174073
2281
2282         Reviewed by Andy Estes.
2283
2284         WebView now keeps a direct copy of its main frame icon as a member variable.
2285         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
2286         
2287         This change causes a progression in KVO observation of the mainFrameIcon property as we now
2288         have both the old icon and new icon at the time it changes.
2289
2290         * WebCoreSupport/WebFrameLoaderClient.h:
2291         * WebCoreSupport/WebFrameLoaderClient.mm:
2292         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2293         (WebFrameLoaderClient::getLoadDecisionForIcons):
2294         (WebFrameLoaderClient::finishedLoadingIcon):
2295         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
2296         (WebFrameLoaderClient::registerForIconNotification): Deleted.
2297
2298         * WebView/WebView.mm:
2299         (+[WebView _setIconLoadingEnabled:]):
2300         (+[WebView _isIconLoadingEnabled]):
2301         (-[WebView mainFrameIcon]):
2302         (-[WebView _setMainFrameIcon:]):
2303         (-[WebView _receivedIconChangedNotification:]): Deleted.
2304         (-[WebView _registerForIconNotification:]): Deleted.
2305         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
2306         * WebView/WebViewData.h:
2307         * WebView/WebViewInternal.h:
2308         * WebView/WebViewPrivate.h:
2309
2310 2017-07-03  Sam Weinig  <sam@webkit.org>
2311
2312         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
2313         https://bugs.webkit.org/show_bug.cgi?id=174083
2314
2315         Reviewed by Alex Christensen.
2316
2317         * Configurations/FeatureDefines.xcconfig:
2318         Add ENABLE_NAVIGATOR_STANDALONE.
2319
2320 2017-07-03  Tim Horton  <timothy_horton@apple.com>
2321
2322         Expose unobscuredSafeAreaInsets on WebView
2323         https://bugs.webkit.org/show_bug.cgi?id=174075
2324         <rdar://problem/33096997>
2325
2326         Reviewed by Beth Dakin.
2327
2328         * WebView/WebView.mm:
2329         (-[WebView _setUnobscuredSafeAreaInsets:]):
2330         (-[WebView _unobscuredSafeAreaInsets]):
2331         * WebView/WebViewPrivate.h:
2332         Expose unobscuredSafeAreaInsets as a new private property on WebView,
2333         similar to how it is exposed in WebKit2.
2334
2335 2017-07-03  Andy Estes  <aestes@apple.com>
2336
2337         [Xcode] Add an experimental setting to build with ccache
2338         https://bugs.webkit.org/show_bug.cgi?id=173875
2339
2340         Reviewed by Tim Horton.
2341
2342         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2343
2344 2017-07-03  Tim Horton  <timothy_horton@apple.com>
2345
2346         Expose WebPreferences for viewport-fit and constant() properties
2347         https://bugs.webkit.org/show_bug.cgi?id=174072
2348         <rdar://problem/33096639>
2349
2350         Reviewed by Ryosuke Niwa.
2351
2352         * WebView/WebPreferenceKeysPrivate.h:
2353         * WebView/WebPreferences.mm:
2354         (-[WebPreferences viewportFitEnabled]):
2355         (-[WebPreferences setViewportFitEnabled:]):
2356         (-[WebPreferences constantPropertiesEnabled]):
2357         (-[WebPreferences setConstantPropertiesEnabled:]):
2358         * WebView/WebPreferencesPrivate.h:
2359         * WebView/WebView.mm:
2360         (-[WebView _preferencesChanged:]):
2361
2362 2017-07-01  Tim Horton  <timothy_horton@apple.com>
2363
2364         Expose viewport-fit value to UIKit via viewport arguments dictionary
2365         https://bugs.webkit.org/show_bug.cgi?id=174071
2366         <rdar://problem/33096620>
2367
2368         Reviewed by Wenson Hsieh.
2369
2370         * History/WebHistoryItem.mm:
2371         * History/WebHistoryItemPrivate.h:
2372         Add another dictionary key and three values.
2373
2374 2017-07-01  Dan Bernstein  <mitz@apple.com>
2375
2376         [iOS] Remove code only needed when building for iOS 9.x
2377         https://bugs.webkit.org/show_bug.cgi?id=174068
2378
2379         Reviewed by Tim Horton.
2380
2381         * Configurations/FeatureDefines.xcconfig:
2382
2383 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
2384
2385         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
2386         https://bugs.webkit.org/show_bug.cgi?id=174004
2387
2388         Reviewed by Simon Fraser.
2389
2390         * WebCoreSupport/WebPluginInfoProvider.mm:
2391
2392 2017-07-01  Dan Bernstein  <mitz@apple.com>
2393
2394         [macOS] Remove code only needed when building for OS X Yosemite
2395         https://bugs.webkit.org/show_bug.cgi?id=174067
2396
2397         Reviewed by Tim Horton.
2398
2399         * Configurations/Base.xcconfig:
2400         * Configurations/DebugRelease.xcconfig:
2401         * Configurations/FeatureDefines.xcconfig:
2402         * Configurations/Version.xcconfig:
2403         * Plugins/WebBasePluginPackage.mm:
2404         (-[WebBasePluginPackage getPluginInfoFromPLists]):
2405         * WebCoreSupport/PopupMenuMac.mm:
2406         (PopupMenuMac::show):
2407         * WebCoreSupport/WebInspectorClient.mm:
2408         (WebInspectorFrontendClient::startWindowDrag):
2409         (-[WebInspectorWindowController window]):
2410         * WebView/WebView.mm:
2411         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2412
2413 2017-06-30  Daniel Bates  <dabates@apple.com>
2414
2415         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2416         https://bugs.webkit.org/show_bug.cgi?id=165160
2417         <rdar://problem/29451999>
2418
2419         Reviewed by Brady Eidson.
2420
2421         Pass the document that is requesting the load to the loader.
2422
2423         * WebView/WebPDFView.mm:
2424         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2425
2426 2017-06-29  Jer Noble  <jer.noble@apple.com>
2427
2428         Make Legacy EME API controlled by RuntimeEnabled setting.
2429         https://bugs.webkit.org/show_bug.cgi?id=173994
2430
2431         Reviewed by Sam Weinig.
2432
2433         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
2434
2435         * Configurations/FeatureDefines.xcconfig:
2436         * WebView/WebPreferenceKeysPrivate.h:
2437         * WebView/WebPreferences.mm:
2438         (+[WebPreferences initialize]):
2439         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
2440         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
2441         * WebView/WebPreferencesPrivate.h:
2442         * WebView/WebView.mm:
2443         (-[WebView _preferencesChanged:]):
2444
2445 2017-06-30  Chris Dumez  <cdumez@apple.com>
2446
2447         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
2448         https://bugs.webkit.org/show_bug.cgi?id=174013
2449
2450         Reviewed by Brent Fulgham.
2451
2452         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
2453         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
2454
2455         * WebView/WebView.mm:
2456         (-[WebView _commonInitializationWithFrameName:groupName:]):
2457
2458 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2459
2460         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2461         https://bugs.webkit.org/show_bug.cgi?id=174017
2462         <rdar://problem/32959782>
2463
2464         Reviewed by Simon Fraser.
2465
2466         Use root view coordinates when computing the drag caret rect.
2467
2468         * WebView/WebView.mm:
2469         (-[WebView _dataInteractionCaretRect]):
2470
2471 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2472
2473         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
2474         https://bugs.webkit.org/show_bug.cgi?id=173899
2475         rdar://problem/32994474
2476
2477         Reviewed by Tim Horton.
2478
2479         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
2480         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
2481         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
2482
2483         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
2484         documentView is a WebHTMLView.
2485
2486         * WebView/WebFrame.mm:
2487         (-[WebFrame _webHTMLDocumentView]):
2488         (-[WebFrame _paintBehaviorForDestinationContext:]):
2489         (-[WebFrame _drawRect:contentsOnly:]):
2490         (-[WebFrame setTimeoutsPaused:]):
2491         (-[WebFrame prepareForPause]):
2492         (-[WebFrame resumeFromPause]):
2493         (-[WebFrame resetTextAutosizingBeforeLayout]):
2494         * WebView/WebHTMLView.mm:
2495         (-[WebHTMLView drawLayer:inContext:]):
2496         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
2497         * WebView/WebHTMLViewInternal.h:
2498
2499 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2500
2501         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
2502         https://bugs.webkit.org/show_bug.cgi?id=173854
2503         <rdar://problem/32236827>
2504
2505         Reviewed by Ryosuke Niwa and Tim Horton.
2506
2507         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
2508         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
2509
2510         * WebView/WebView.mm:
2511         (-[WebView _startDrag:]):
2512         (-[WebView _dragSourceAction]):
2513         (-[WebView _draggedLinkTitle]):
2514         (-[WebView _draggedLinkURL]):
2515         (-[WebView _draggedElementBounds]):
2516         (-[WebView _endedDataInteraction:global:]):
2517         * WebView/WebViewData.h:
2518         * WebView/WebViewPrivate.h:
2519
2520 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2521
2522         Refactor drag start codepaths to plumb a DragItem to client layers
2523         https://bugs.webkit.org/show_bug.cgi?id=173832
2524         Work towards <rdar://problem/32236827>
2525
2526         Reviewed by Ryosuke Niwa and Tim Horton.
2527
2528         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
2529         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
2530         to _startDrag: to match logic used to start a drag on other platforms.
2531
2532         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
2533         through the DragItem struct.
2534
2535         * WebCoreSupport/WebDragClient.h:
2536         * WebCoreSupport/WebDragClient.mm:
2537         (WebDragClient::startDrag):
2538         (WebDragClient::dragSourceActionMaskForPoint):
2539         (WebDragClient::willPerformDragSourceAction):
2540         (WebDragClient::beginDrag):
2541         * WebView/WebView.mm:
2542         (-[WebView _startDrag:]):
2543         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
2544         * WebView/WebViewInternal.h:
2545
2546 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
2547
2548         Remove excessive headers from JavaScriptCore
2549         https://bugs.webkit.org/show_bug.cgi?id=173812
2550
2551         Reviewed by Darin Adler.
2552
2553         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2554         * WebView/WebView.mm:
2555
2556 2017-06-23  Tim Horton  <timothy_horton@apple.com>
2557
2558         Remove an unused typedef from WebFrameLoaderClient
2559         https://bugs.webkit.org/show_bug.cgi?id=173795
2560
2561         Reviewed by Simon Fraser.
2562
2563         * WebCoreSupport/WebFrameLoaderClient.h:
2564         This unused typedef in the global namespace conflicts with one in a macOS system header.
2565         Also... it's unused.
2566         Remove it.
2567
2568 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
2569
2570         Remove excessive headers from WebCore/{bindings,css,dom}
2571         https://bugs.webkit.org/show_bug.cgi?id=173766
2572
2573         Reviewed by Simon Fraser.
2574
2575         * DOM/DOMInternal.mm:
2576
2577 2017-06-22  Daniel Bates  <dabates@apple.com>
2578
2579         Make FrameLoadRequest a move-only type
2580         https://bugs.webkit.org/show_bug.cgi?id=173682
2581
2582         Reviewed by Alex Christensen and Darin Adler.
2583
2584         A FrameLoadRequest groups together the information to perform a load into a single object
2585         that is more manageable to pass around than its constituent parts. Code that receives a
2586         FrameLoadRequest is expected to extract out the information it needs to complete its task.
2587         And it does not make sense to re-use the same FrameLoadRequest object for more than one
2588         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
2589
2590         * Plugins/WebPluginController.mm:
2591         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
2592         * WebView/WebPDFView.mm:
2593         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2594
2595 2017-06-21  Antoine Quint  <graouts@apple.com>
2596
2597         Ensure DRT always logs rAF suspension debugging code
2598         https://bugs.webkit.org/show_bug.cgi?id=173681
2599
2600         Reviewed by Tim "Mr. T" Horton.
2601
2602         * WebView/WebPreferenceKeysPrivate.h:
2603         * WebView/WebPreferences.mm:
2604         (+[WebPreferences initialize]):
2605         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
2606         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
2607         * WebView/WebPreferencesPrivate.h:
2608         * WebView/WebView.mm:
2609         (-[WebView _preferencesChanged:]):
2610
2611 2017-06-21  Daniel Bates  <dabates@apple.com>
2612
2613         Cleanup FrameLoadRequest
2614         https://bugs.webkit.org/show_bug.cgi?id=173564
2615         <rdar://problem/32903570>
2616
2617         Reviewed by Brent Fulgham.
2618
2619         * WebView/WebPDFView.mm:
2620         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
2621         into a local variable and use C++11 brace initialization syntax to make it easier to identify
2622         the arguments passed to FrameLoader::loadFrameRequest().
2623
2624 2017-06-21  Antoine Quint  <graouts@apple.com>
2625
2626         Add logging to identify when the Page suspends scripted animations
2627         https://bugs.webkit.org/show_bug.cgi?id=173626
2628
2629         Reviewed by Tim Horton.
2630
2631         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
2632         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
2633
2634         * WebView/WebPreferenceKeysPrivate.h:
2635         * WebView/WebPreferences.mm:
2636         (+[WebPreferences initialize]):
2637         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
2638         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
2639         * WebView/WebPreferencesPrivate.h:
2640         * WebView/WebView.mm:
2641         (-[WebView _preferencesChanged:]):
2642
2643 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
2644
2645         Disable font variations on macOS Sierra and iOS 10
2646         https://bugs.webkit.org/show_bug.cgi?id=173618
2647         <rdar://problem/32879164>
2648
2649         Reviewed by Jon Lee.
2650
2651         * Configurations/FeatureDefines.xcconfig:
2652
2653 2017-06-20  Daniel Bates  <dabates@apple.com>
2654
2655         Have FrameLoadRequest takes a Frame& instead of a Frame*
2656         https://bugs.webkit.org/show_bug.cgi?id=173614
2657         <rdar://problem/32884890>
2658
2659         Reviewed by Brent Fulgham.
2660
2661         * Plugins/WebPluginController.mm:
2662         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
2663         * WebView/WebFrame.mm:
2664         (-[WebFrame loadRequest:]):
2665         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
2666
2667 2017-06-19  Frederic Wang  <fwang@igalia.com>
2668
2669         [Mac] Add an experimental feature setting for async frame scrolling
2670         https://bugs.webkit.org/show_bug.cgi?id=173359
2671
2672         Reviewed by Simon Fraser.
2673
2674         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
2675         * WebView/WebPreferences.mm:
2676         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
2677         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
2678         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
2679         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
2680         * WebView/WebView.mm:
2681         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
2682         scrolling.
2683
2684 2017-06-19  Chris Dumez  <cdumez@apple.com>
2685
2686         Use WTF::Function instead of std::function in more places in WebCore/
2687         https://bugs.webkit.org/show_bug.cgi?id=173535
2688
2689         Reviewed by Antti Koivisto.
2690
2691         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
2692
2693         * WebCoreSupport/WebFrameLoaderClient.h:
2694         * WebCoreSupport/WebFrameLoaderClient.mm:
2695         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2696         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2697         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2698         (WebFrameLoaderClient::dispatchWillSubmitForm):
2699         (WebFrameLoaderClient::setUpPolicyListener):
2700         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
2701         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
2702
2703 2017-05-14 Frederic Wang  <fwang@igalia.com>
2704
2705         Add heuristic to avoid flattening "fullscreen" iframes
2706         https://bugs.webkit.org/show_bug.cgi?id=171914
2707
2708         Reviewed by Simon Fraser.
2709
2710         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
2711
2712         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
2713         * WebView/WebPreferences.mm:
2714         (+[WebPreferences initialize]): Handle frame flattening as an enum.
2715         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
2716         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
2717         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
2718         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
2719         * WebView/WebPreferencesPrivate.h: Ditto.
2720         * WebView/WebView.mm:
2721         (-[WebView _preferencesChanged:]): Ditto.
2722         * WebView/WebPreferencesPrivate.h: Add new enum definition.
2723
2724 2017-06-17  Chris Dumez  <cdumez@apple.com>
2725
2726         Use WTF::Function instead of std::function in WebKit2/
2727         https://bugs.webkit.org/show_bug.cgi?id=173504
2728
2729         Reviewed by Darin Adler.
2730
2731         Use WTF::Function instead of std::function in WebKit2/ to avoid
2732         unnecessary copying.
2733
2734         * Plugins/Hosted/HostedNetscapePluginStream.h:
2735         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2736         (WebKit::HostedNetscapePluginStream::willSendRequest):
2737         * Plugins/WebNetscapePluginStream.h:
2738         * Plugins/WebNetscapePluginStream.mm:
2739         (WebNetscapePluginStream::willSendRequest):
2740         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2741         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2742         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
2743         (WebPaymentCoordinatorClient::openPaymentSetup):
2744
2745 2017-06-16  Sam Weinig  <sam@webkit.org>
2746
2747         [WebIDL] Remove custom bindings for HTMLDocument
2748         https://bugs.webkit.org/show_bug.cgi?id=173444
2749
2750         Reviewed by Darin Adler.
2751
2752         * DOM/DOMHTMLDocument.mm:
2753         (-[DOMHTMLDocument linkColor]):
2754         (-[DOMHTMLDocument setLinkColor:]):
2755         (-[DOMHTMLDocument write:]):
2756         (-[DOMHTMLDocument writeln:]):
2757         Update for new signature of write/writeln and rename of linkColor to linkColorForBindings.
2758
2759 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2760
2761         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
2762         https://bugs.webkit.org/show_bug.cgi?id=173366
2763         <rdar://problem/32767014>
2764
2765         Reviewed by Tim Horton.
2766
2767         Move pieces of iOS WebKit1 drag and drop implementation into OpenSource. No change in behavior.
2768
2769         * Configurations/FeatureDefines.xcconfig:
2770         * WebCoreSupport/WebDragClient.mm:
2771         (WebDragClient::useLegacyDragClient):
2772         (WebDragClient::willPerformDragDestinationAction):
2773         (WebDragClient::dragSourceActionMaskForPoint):
2774         (WebDragClient::willPerformDragSourceAction):
2775         (WebDragClient::startDrag):
2776         (WebDragClient::beginDrag):
2777         (WebDragClient::declareAndWriteDragImage):
2778         (WebDragClient::declareAndWriteAttachment):
2779         (WebDragClient::didConcludeEditDrag):
2780         * WebView/WebView.mm:
2781         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
2782         (-[WebView _getDataInteractionData]):
2783         (-[WebView dragDataForSession:client:global:operation:]):
2784         (-[WebView _enteredDataInteraction:client:global:operation:]):
2785         (-[WebView _updatedDataInteraction:client:global:operation:]):
2786         (-[WebView _exitedDataInteraction:client:global:operation:]):
2787         (-[WebView _performDataInteraction:client:global:operation:]):
2788         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
2789         (-[WebView _endedDataInteraction:global:]):
2790         (-[WebView _didConcludeEditDataInteraction]):
2791         (floatRectsForCGRectArray): Deleted.
2792         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]): Deleted.
2793         * WebView/WebViewData.h:
2794         * WebView/WebViewData.mm:
2795         (-[WebViewPrivate dealloc]):
2796         * WebView/WebViewPrivate.h:
2797
2798 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2799
2800         [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default
2801         https://bugs.webkit.org/show_bug.cgi?id=173454
2802         <rdar://problem/31720671>
2803
2804         Reviewed by Tim Horton.
2805
2806         Adds -webView:dragDestinationActionMaskForSession: as SPI to WebUIDelegate.
2807         If unimplemented, the default UI delegate allows all actions except for URL loading.
2808
2809         * DefaultDelegates/WebDefaultUIDelegate.mm:
2810         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForSession:]):
2811         * WebView/WebUIDelegatePrivate.h:
2812         * WebView/WebView.mm:
2813         (-[WebView dragDestinationActionMaskForSession:]):
2814
2815 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2816
2817         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
2818         https://bugs.webkit.org/show_bug.cgi?id=173338
2819         <rdar://problem/32777720>
2820
2821         Reviewed by Tim Horton.
2822
2823         Rename updatePreferredTypeIdentifiers to updateSupportedTypeIdentifiers.
2824
2825         * WebCoreSupport/WebPlatformStrategies.h:
2826         * WebCoreSupport/WebPlatformStrategies.mm:
2827         (WebPlatformStrategies::updateSupportedTypeIdentifiers):
2828         (WebPlatformStrategies::updatePreferredTypeIdentifiers): Deleted.
2829
2830 2017-06-13  Daniel Bates  <dabates@apple.com>
2831
2832         Implement W3C Secure Contexts Draft Specification
2833         https://bugs.webkit.org/show_bug.cgi?id=158121
2834         <rdar://problem/26012994>
2835
2836         Reviewed by Brent Fulgham.
2837
2838         Part 4
2839
2840         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
2841
2842         * WebView/WebPreferenceKeysPrivate.h:
2843         * WebView/WebPreferences.mm:
2844         (+[WebPreferences initialize]):
2845         (-[WebPreferences isSecureContextAttributeEnabled]):
2846         (-[WebPreferences setIsSecureContextAttributeEnabled:]):
2847         * WebView/WebPreferencesPrivate.h:
2848         * WebView/WebView.mm:
2849         (-[WebView _preferencesChanged:]):
2850
2851 2017-06-13  Sam Weinig  <sam@webkit.org>
2852
2853         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
2854         https://bugs.webkit.org/show_bug.cgi?id=80733
2855
2856         Reviewed by Chris Dumez.
2857
2858         * DOM/DOMUtility.mm:
2859         (createDOMWrapper):
2860         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2861         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2862         * WebView/WebFrame.mm:
2863         (-[WebFrame _attachScriptDebugger]):
2864         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2865
2866 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
2867
2868         [WebCrypto] Remove experimental feature flag of SubtleCrypto
2869         https://bugs.webkit.org/show_bug.cgi?id=173197
2870         <rdar://problem/32688148>
2871
2872         Reviewed by Brent Fulgham.
2873
2874         * WebView/WebPreferences.mm:
2875         (+[WebPreferences initialize]):
2876         (-[WebPreferences subtleCryptoEnabled]): Deleted.
2877         (-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
2878         * WebView/WebPreferencesPrivate.h:
2879         * WebView/WebView.mm:
2880         (-[WebView _preferencesChanged:]):
2881
2882 2017-06-10  Dan Bernstein  <mitz@apple.com>
2883
2884         Reverted r218056 because it made the IDE reindex constantly.
2885
2886         * Configurations/DebugRelease.xcconfig:
2887
2888 2017-06-10  Dan Bernstein  <mitz@apple.com>
2889
2890         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
2891         https://bugs.webkit.org/show_bug.cgi?id=173223
2892
2893         Reviewed by Sam Weinig.
2894
2895         The rebuilds were happening due to a difference in the compiler options that the IDE and
2896         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
2897         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
2898         specify an appropriate path in CLANG_INDEX_STORE_PATH.
2899
2900         * Configurations/DebugRelease.xcconfig:
2901
2902 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2903
2904         [iOS DnD] Add a hook to perform two-step drops in editable content
2905         https://bugs.webkit.org/show_bug.cgi?id=172992
2906         <rdar://problem/32590174>
2907
2908         Reviewed by Tim Horton.
2909
2910         Adds a new SPI to WebUIKitDelegate to allow WK1 clients to override default drop behavior. Returning YES from
2911         -performTwoStepDrop:atDestination:isMove: will prevent content from being inserted on drop in WebKit; otherwise,
2912         returning NO will continue with default WebKit behavior.
2913
2914         * WebCoreSupport/WebEditorClient.h:
2915         * WebCoreSupport/WebEditorClient.mm:
2916         (WebEditorClient::performTwoStepDrop):
2917
2918 2017-06-08  Jer Noble  <jer.noble@apple.com>
2919
2920         Clients of the WK2 C-API don't have their mediaContentTypesRequiringHardwareSupport setting initialized correctly.
2921         https://bugs.webkit.org/show_bug.cgi?id=173091
2922
2923         Reviewed by Eric Carlson.
2924
2925         * WebView/WebPreferences.mm:
2926         (+[WebPreferences initialize]):
2927
2928 2017-06-07  Jer Noble  <jer.noble@apple.com>
2929
2930         Clean-up: RenderElement.h includes headers it doesn't use
2931         https://bugs.webkit.org/show_bug.cgi?id=173046
2932
2933         Reviewed by Andy Estes.
2934
2935         * WebView/WebImmediateActionController.mm:
2936
2937 2017-06-07  Zalan Bujtas  <zalan@apple.com>
2938
2939         [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
2940         https://bugs.webkit.org/show_bug.cgi?id=173044
2941         <rdar://problem/32449338>
2942
2943         Reviewed by Tim Horton.
2944
2945         Cache the current device orientation so that we don't have to lift the WebThread lock
2946         to collect it.
2947
2948         * WebView/WebFrame.mm:
2949         (-[WebFrame deviceOrientationChanged]):
2950         * WebView/WebView.mm:
2951         (-[WebView _commonInitializationWithFrameName:groupName:]):
2952         (-[WebView _setDeviceOrientation:]):
2953         (-[WebView _deviceOrientation]):
2954         * WebView/WebViewData.h:
2955         * WebView/WebViewInternal.h:
2956
2957 2017-06-06  Jer Noble  <jer.noble@apple.com>
2958
2959         [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
2960         https://bugs.webkit.org/show_bug.cgi?id=173008
2961
2962         Reviewed by Eric Carlson.
2963
2964         Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
2965
2966         * WebView/WebPreferenceKeysPrivate.h:
2967         * WebView/WebPreferences.mm:
2968         (+[WebPreferences initialize]):
2969         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
2970         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
2971         * WebView/WebPreferencesPrivate.h:
2972         * WebView/WebView.mm:
2973         (-[WebView _preferencesChanged:]):
2974
2975 2017-06-06  Youenn Fablet  <youenn@apple.com>
2976
2977         Add an option to disable getUserMedia prompt in case of mock capture sources
2978         https://bugs.webkit.org/show_bug.cgi?id=172981
2979         <rdar://problem/32580325>
2980
2981         Reviewed by Eric Carlson.
2982
2983         Defining the option, getter and setter.
2984
2985         * WebView/WebPreferences.mm:
2986         (+[WebPreferences initialize]):
2987         (-[WebPreferences mockCaptureDevicesPromptEnabled]):
2988         (-[WebPreferences setMockCaptureDevicesPromptEnabled:]):
2989         * WebView/WebPreferencesPrivate.h:
2990
2991 2017-06-05  Dan Bernstein  <mitz@apple.com>
2992
2993         Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.
2994
2995         * WebView/WebView.mm:
2996         (-[WebView updateMediaTouchBar]):
2997         * WebView/WebViewData.h:
2998
2999 2017-06-03  Darin Adler  <darin@apple.com>
3000
3001         Streamline handling of attributes, using references as much as possible
3002         https://bugs.webkit.org/show_bug.cgi?id=172899
3003
3004         Reviewed by Chris Dumez.
3005
3006         * WebView/WebHTMLRepresentation.mm:
3007         (matchLabelsAgainstElement): Added handling of nullptr since nothing guarantees the
3008         passed in element can't be null. Removed unnecessary conversion from NSString to String
3009         and then back to NSString.
3010
3011 2017-06-01  Andy Estes  <aestes@apple.com>
3012
3013         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
3014         https://bugs.webkit.org/show_bug.cgi?id=172828
3015
3016         Reviewed by Beth Dakin.
3017
3018         * Configurations/FeatureDefines.xcconfig:
3019
3020 2017-05-31  Andy Estes  <aestes@apple.com>
3021
3022         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
3023         https://bugs.webkit.org/show_bug.cgi?id=172366
3024
3025         Reviewed by Daniel Bates.
3026
3027         * Configurations/FeatureDefines.xcconfig:
3028
3029 2017-05-30  Ryosuke Niwa  <rniwa@webkit.org>
3030
3031         Only include DataDetectorsUI headers in iOS
3032         https://bugs.webkit.org/show_bug.cgi?id=172633
3033
3034         Reviewed by David Kilzer.
3035
3036         Enable data detectors only on iOS and not other variants of iOS.
3037
3038         * WebCoreSupport/WebFrameLoaderClient.mm:
3039
3040 2017-05-30  Alex Christensen  <achristensen@webkit.org>
3041
3042         Update libwebrtc configuration
3043         https://bugs.webkit.org/show_bug.cgi?id=172727
3044
3045         Reviewed by Geoffrey Garen.
3046
3047         * Configurations/FeatureDefines.xcconfig:
3048
3049 2017-05-28  Dan Bernstein  <mitz@apple.com>
3050
3051         [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
3052         https://bugs.webkit.org/show_bug.cgi?id=172691
3053
3054         Reviewed by Tim Horton.
3055
3056         * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
3057
3058 2017-05-26  Brent Fulgham  <bfulgham@apple.com>
3059
3060         [WK2] Address thread safety issues with ResourceLoadStatistics
3061         https://bugs.webkit.org/show_bug.cgi?id=172519
3062         <rdar://problem/31707642>
3063
3064         Reviewed by Chris Dumez.
3065
3066         Create a new WorkQueue for the ResourceLoadStatistics store to use for processing data.
3067
3068         * WebView/WebView.mm:
3069         (WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Pass WorkQueue to the observer.
3070
3071 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
3072
3073         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
3074         https://bugs.webkit.org/show_bug.cgi?id=172554
3075         <rdar://problem/31247133>
3076
3077         Reviewed by Simon Fraser.
3078
3079         Update an overridden internal AppKit function to the new signature.
3080
3081         * WebView/WebHTMLView.mm:
3082         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
3083         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
3084         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
3085         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
3086
3087 2017-05-24  Jer Noble  <jer.noble@apple.com>
3088
3089         Rename DisplaySleepDisabler -> SleepDisabler
3090         https://bugs.webkit.org/show_bug.cgi?id=172478
3091
3092         Reviewed by Sam Weinig.
3093
3094         * WebView/WebFullScreenController.h:
3095
3096 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
3097
3098         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
3099         https://bugs.webkit.org/show_bug.cgi?id=172522
3100         rdar://problem/31071812
3101
3102         Reviewed by Tim Horton.
3103
3104         There's no need to consult -[NSWindow viewsNeedDisplay] on newer OSes. It was
3105         added in r58623, and modified in r61204 for Carbon apps, but with more recent AppKit
3106         versions this synchronization is no longer required.
3107
3108         * WebView/WebView.mm:
3109         (LayerFlushController::flushLayers):
3110
3111 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
3112
3113         Snapshotting via -renderInContext: should do synchronous image decodes
3114         https://bugs.webkit.org/show_bug.cgi?id=172485
3115         rdar://problem/32276146
3116
3117         Reviewed by Tim Horton.
3118
3119         Remove the _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap: SPI that no longer
3120         has any callers.
3121
3122         * Plugins/WebBaseNetscapePluginView.h:
3123         * Plugins/WebBaseNetscapePluginView.mm:
3124         (-[WebBaseNetscapePluginView inFlatteningPaint]): Deleted.
3125         * WebView/WebFrame.mm:
3126         (-[WebFrame _paintBehaviorForDestinationContext:]):
3127         (-[WebFrame _drawRect:contentsOnly:]):
3128         (-[WebFrame _shouldFlattenCompositingLayers:]): Deleted.
3129         * WebView/WebHTMLView.mm:
3130         (imageFromRect):
3131         * WebView/WebView.mm:
3132         (-[WebView _commonInitializationWithFrameName:groupName:]):
3133         (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): Deleted.
3134         (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]): Deleted.
3135         * WebView/WebViewData.h:
3136         * WebView/WebViewPrivate.h:
3137
3138 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
3139
3140         Remove dead ENABLE(FONT_LOAD_EVENTS) code
3141         https://bugs.webkit.org/show_bug.cgi?id=172517
3142
3143         Rubber-stamped by Simon Fraser.
3144
3145         * Configurations/FeatureDefines.xcconfig:
3146
3147 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
3148
3149         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
3150         https://bugs.webkit.org/show_bug.cgi?id=171984
3151
3152         Reviewed by Antti Koivisto.
3153
3154         * WebView/WebPreferenceKeysPrivate.h:
3155         * WebView/WebPreferences.mm:
3156         (+[WebPreferences initialize]):
3157         (-[WebPreferences displayContentsEnabled]):
3158         (-[WebPreferences setDisplayContentsEnabled:]):
3159         * WebView/WebPreferencesPrivate.h:
3160         * WebView/WebView.mm:
3161         (-[WebView _preferencesChanged:]):
3162
3163 2017-05-22  Youenn Fablet  <youenn@apple.com>
3164
3165         Remove AVAudioCaptureSource
3166         https://bugs.webkit.org/show_bug.cgi?id=172360
3167
3168         Reviewed by Sam Weinig.
3169
3170         Removing the handling of AVAudio/CoreAudio capture source dynamic switch.
3171
3172         * WebView/WebPreferenceKeysPrivate.h:
3173         * WebView/WebPreferences.mm:
3174         (+[WebPreferences initialize]):
3175         (-[WebPreferences useAVFoundationAudioCapture]): Deleted.
3176         (-[WebPreferences setUseAVFoundationAudioCapture:]): Deleted.
3177         * WebView/WebPreferencesPrivate.h:
3178         * WebView/WebView.mm:
3179         (-[WebView _preferencesChanged:]):
3180
3181 2017-05-22  Sam Weinig  <sam@webkit.org>
3182
3183         [WebIDL] Support callbacks with arbitrary return types
3184         https://bugs.webkit.org/show_bug.cgi?id=172407
3185
3186         Reviewed by Chris Dumez.
3187
3188         * DOM/DOM.mm:
3189         (-[DOMNodeFilter acceptNode:]):
3190         Update for CallbackResult adoption in the base class.
3191
3192         * DOM/DOMNodeIterator.mm:
3193         * DOM/DOMTreeWalker.mm:
3194         Update to account for new WebCore implementation return types. We return nil
3195         if there was an exception, since retains the existing behavior if a javascript
3196         NodeFilter had been used (an exception would cause all nodes to be rejected,
3197         thus returning nullptr).
3198
3199         * DOM/ObjCNodeFilterCondition.h:
3200         * DOM/ObjCNodeFilterCondition.mm:
3201         Update to match new interface of NodeFilterCondition.
3202
3203 2017-05-18  Sam Weinig  <sam@webkit.org>
3204
3205         [WebIDL] Remove the need for the generator to know about native type mapping
3206         https://bugs.webkit.org/show_bug.cgi?id=172310
3207
3208         Reviewed by Darin Adler.
3209
3210         * DOM/DOM.mm:
3211         (-[DOMNodeFilter acceptNode:]):
3212         Update to pass Node by reference.
3213
3214 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3215
3216         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
3217         https://bugs.webkit.org/show_bug.cgi?id=172098
3218
3219         Reviewed by Saam Barati.
3220
3221         * Plugins/Hosted/ProxyInstance.mm:
3222         * Plugins/Hosted/ProxyRuntimeObject.mm:
3223
3224 2017-05-18  Andy Estes  <aestes@apple.com>
3225
3226         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
3227         https://bugs.webkit.org/show_bug.cgi?id=172305
3228
3229         Reviewed by Anders Carlsson.
3230
3231         * Configurations/FeatureDefines.xcconfig:
3232
3233 2017-05-18  Commit Queue  <commit-queue@webkit.org>
3234
3235         Unreviewed, rolling out r217031, r217032, and r217037.
3236         https://bugs.webkit.org/show_bug.cgi?id=172293
3237
3238         cause linking errors in Windows (Requested by yusukesuzuki on
3239         #webkit).
3240
3241         Reverted changesets:
3242
3243         "[JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass"
3244         https://bugs.webkit.org/show_bug.cgi?id=172098
3245         http://trac.webkit.org/changeset/217031
3246
3247         "Unreviewed, rebaseline for newly added ClassInfo"
3248         https://bugs.webkit.org/show_bug.cgi?id=172098
3249         http://trac.webkit.org/changeset/217032
3250
3251         "Unreviewed, fix debug and non-JIT build"
3252         https://bugs.webkit.org/show_bug.cgi?id=172098
3253         http://trac.webkit.org/changeset/217037
3254
3255 2017-05-16  Yusuke Suzuki  <utatane.tea@gmail.com>
3256
3257         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
3258         https://bugs.webkit.org/show_bug.cgi?id=172098
3259
3260         Reviewed by Saam Barati.
3261
3262         * Plugins/Hosted/ProxyInstance.mm:
3263         * Plugins/Hosted/ProxyRuntimeObject.mm:
3264
3265 2017-05-17  Matt Lewis  <jlewis3@apple.com>
3266
3267         Unreviewed, rolling out r216974.
3268
3269         Revision caused consistent timeouts on all platforms.
3270
3271         Reverted changeset:
3272
3273         "Add a RuntimeEnabledFeature for display: contents, defaulted
3274         to false."
3275         https://bugs.webkit.org/show_bug.cgi?id=171984
3276         http://trac.webkit.org/changeset/216974
3277
3278 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
3279
3280         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
3281         https://bugs.webkit.org/show_bug.cgi?id=171984
3282
3283         Reviewed by Antti Koivisto.
3284
3285         * WebView/WebPreferenceKeysPrivate.h:
3286         * WebView/WebPreferences.mm:
3287         (+[WebPreferences initialize]):
3288         (-[WebPreferences displayContentsEnabled]):
3289         (-[WebPreferences setDisplayContentsEnabled:]):
3290         * WebView/WebPreferencesPrivate.h:
3291         * WebView/WebView.mm:
3292         (-[WebView _preferencesChanged:]):
3293
3294 2017-05-16  Sam Weinig  <sam@webkit.org>
3295
3296         Bring Notification.idl up to spec
3297         https://bugs.webkit.org/show_bug.cgi?id=172156
3298
3299         Reviewed by Chris Dumez.
3300
3301         * WebCoreSupport/WebNotificationClient.h:
3302         * WebCoreSupport/WebNotificationClient.mm:
3303         (generateNotificationID):
3304         (WebNotificationClient::show):
3305         (WebNotificationClient::cancel):
3306         (WebNotificationClient::clearNotifications):
3307         (WebNotificationClient::notificationObjectDestroyed):
3308         (WebNotificationClient::requestPermission):
3309         (WebNotificationClient::hasPendingPermissionRequests):
3310         (WebNotificationClient::checkPermission):
3311         (-[WebNotificationPolicyListener allow]):
3312         (-[WebNotificationPolicyListener deny]):
3313         * WebView/WebNotification.mm:
3314         (-[WebNotification iconURL]):
3315         (-[WebNotification dir]):
3316         Simplify #ifdefs and update for enum vs String usage.
3317
3318 2017-05-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
3319
3320         Do not delete asynchronously decoded frames for large images if their clients are in the viewport
3321         https://bugs.webkit.org/show_bug.cgi?id=170640
3322
3323         Reviewed by Simon Fraser.
3324
3325         Enable the async decoding for large images.
3326
3327         * WebView/WebView.mm:
3328         (-[WebView _preferencesChanged:]):
3329
3330 2017-05-15  Jer Noble  <jer.noble@apple.com>
3331
3332         Add experimental setting to allow document gesture interaction to fulfill media playback gesture requirement
3333         https://bugs.webkit.org/show_bug.cgi?id=172131
3334
3335         Reviewed by Eric Carlson.
3336
3337         * WebView/WebPreferenceKeysPrivate.h:
3338         * WebView/WebPreferences.mm:
3339         (+[WebPreferences initialize]):
3340         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
3341         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
3342         * WebView/WebPreferencesPrivate.h:
3343
3344 2017-05-12  Chris Dumez  <cdumez@apple.com>
3345
3346         Drop uses of PassRefPtr in WebKit/mac
3347         https://bugs.webkit.org/show_bug.cgi?id=172066
3348
3349         Reviewed by Sam Weinig.
3350
3351         * History/WebBackForwardListInternal.h:
3352         * History/WebHistoryItem.mm:
3353         (kit):
3354         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
3355         * History/WebHistoryItemInternal.h:
3356         * Plugins/Hosted/HostedNetscapePluginStream.h:
3357         (WebKit::HostedNetscapePluginStream::create):
3358         * Plugins/Hosted/NetscapePluginHostManager.h:
3359         * Plugins/Hosted/NetscapePluginHostManager.mm:
3360         (WebKit::NetscapePluginHostManager::instantiatePlugin):
3361         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3362         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3363         (WebKit::NetscapePluginInstanceProxy::PluginRequest::create):
3364         (WebKit::NetscapePluginInstanceProxy::create):
3365         (WebKit::NetscapePluginInstanceProxy::setManualStream):
3366         * Plugins/Hosted/ProxyInstance.h:
3367         (WebKit::ProxyInstance::create):
3368         * Plugins/Hosted/ProxyInstance.mm:
3369         (WebKit::ProxyInstance::ProxyInstance):
3370         (WebKit::ProxyInstance::newRuntimeObject):
3371         * Plugins/Hosted/ProxyRuntimeObject.h:
3372         (WebKit::ProxyRuntimeObject::create):
3373         * Plugins/Hosted/ProxyRuntimeObject.mm:
3374         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
3375         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3376         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3377         (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
3378         * Plugins/WebBaseNetscapePluginView.h:
3379         * Plugins/WebBaseNetscapePluginView.mm:
3380         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
3381         * Plugins/WebNetscapePluginStream.h:
3382         (WebNetscapePluginStream::create):
3383         * Plugins/WebNetscapePluginView.h:
3384         * Plugins/WebNetscapePluginView.mm:
3385         (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
3386         * WebCoreSupport/WebChromeClient.mm:
3387         * WebCoreSupport/WebEditorClient.mm:
3388         * WebCoreSupport/WebNotificationClient.mm:
3389         (WebNotificationClient::requestPermission):
3390         (-[WebNotificationPolicyListener initWithCallback:]):
3391         * WebCoreSupport/WebOpenPanelResultListener.mm:
3392         * WebCoreSupport/WebUserMediaClient.mm:
3393         (WebUserMediaClient::requestUserMediaAccess):
3394         (WebUserMediaClient::enumerateMediaDevices):
3395         (-[WebUserMediaPolicyListener initWithUserMediaRequest:]):
3396         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
3397         * WebView/WebArchive.mm:
3398         (-[WebArchivePrivate initWithCoreArchive:]):
3399         (-[WebArchivePrivate setCoreArchive:]):
3400         (-[WebArchive initWithData:]):
3401         (-[WebArchive subframeArchives]):
3402         (-[WebArchive _initWithCoreLegacyWebArchive:]):
3403         * WebView/WebArchiveInternal.h:
3404         * WebView/WebDataSource.mm:
3405         (WebDataSourcePrivate::WebDataSourcePrivate):
3406         (WebDataSourcePrivate::~WebDataSourcePrivate):
3407         (-[WebDataSource _initWithDocumentLoader:]):
3408         * WebView/WebDataSourceInternal.h:
3409         * WebView/WebDeviceOrientation.mm:
3410         (-[WebDeviceOrientation initWithCoreDeviceOrientation:]):
3411         * WebView/WebDeviceOrientationInternal.h:
3412         * WebView/WebFrame.mm:
3413         (-[WebFrame _convertToDOMRange:]):
3414         (-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
3415         * WebView/WebFrameInternal.h:
3416         * WebView/WebFullScreenController.h:
3417         * WebView/WebFullScreenController.mm:
3418         (-[WebFullScreenController setElement:]):
3419         * WebView/WebGeolocationPosition.mm:
3420         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
3421         (-[WebGeolocationPosition initWithGeolocationPosition:]):
3422         * WebView/WebHTMLView.mm:
3423         (currentKeyboardEvent):
3424         * WebView/WebResource.mm:
3425         * WebView/WebScriptWorld.mm:
3426         (-[WebScriptWorld initWithWorld:]):
3427         (+[WebScriptWorld standardWorld]):
3428         (+[WebScriptWorld findOrCreateWorld:]):
3429         * WebView/WebViewData.h:
3430         (LayerFlushController::create):
3431
3432 2017-05-11  Chris Dumez  <cdumez@apple.com>
3433
3434         Drop remaining uses of PassRefPtr in WebCore
3435         https://bugs.webkit.org/show_bug.cgi?id=172013
3436
3437         Reviewed by Yusuke Suzuki.
3438
3439         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3440         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3441         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
3442         (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
3443         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3444         (-[WebHostedNetscapePluginView createPluginBindingsInstance:]):
3445
3446 2017-05-11  Tim Horton  <timothy_horton@apple.com>
3447
3448         Mail spins launching spell checker when typing
3449         https://bugs.webkit.org/show_bug.cgi?id=171986
3450         <rdar://problem/26305327>
3451
3452         Reviewed by Beth Dakin.
3453
3454         * WebView/WebView.mm:
3455         (-[WebView setEditable:]):
3456         Asynchronously pre-warm the spell checker when a WebView becomes editable.
3457
3458 2017-05-09  Sam Weinig  <sam@webkit.org>
3459
3460         Remove support for legacy Notifications
3461         https://bugs.webkit.org/show_bug.cgi?id=171487
3462
3463         Reviewed by Jon Lee.
3464
3465         * Configurations/FeatureDefines.xcconfig:
3466         * WebCoreSupport/WebNotificationClient.h:
3467         * WebCoreSupport/WebNotificationClient.mm:
3468         * WebView/WebNotification.mm:
3469         * WebView/WebNotificationInternal.h:
3470         * WebView/WebView.mm:
3471         (-[WebView _commonInitializationWithFrameName:groupName:]):
3472         (-[WebView _notificationIDForTesting:]):
3473         Remove legacy notification specific code.
3474
3475 2017-05-10  Chris Dumez  <cdumez@apple.com>
3476
3477         Simplify relationship between Attr and Element now that Attr is childless
3478         https://bugs.webkit.org/show_bug.cgi?id=171909
3479
3480         Reviewed by Ryosuke Niwa.
3481
3482         Build fix.
3483
3484         * DOM/DOMAttr.mm:
3485         (-[DOMAttr value]):
3486         (-[DOMAttr setValue:]):
3487
3488 2017-05-08  Chris Dumez  <cdumez@apple.com>
3489
3490         Move 'style' from Element to HTMLElement / SVGElement and make it settable
3491         https://bugs.webkit.org/show_bug.cgi?id=171795
3492
3493         Reviewed by Alex Christensen.
3494
3495         Build fix.
3496
3497         * DOM/DOMElement.mm:
3498         (-[DOMElement style]):
3499         * WebCoreSupport/WebEditorClient.mm:
3500         (WebEditorClient::shouldApplyStyle):
3501         * WebView/WebFrame.mm:
3502         (-[WebFrame _typingStyle]):
3503
3504 2017-05-06  Chris Dumez  <cdumez@apple.com>
3505
3506         Align our IDL files with the latest DOM specification
3507         https://bugs.webkit.org/show_bug.cgi?id=171777
3508
3509         Reviewed by Sam Weinig.
3510
3511         Build fix.
3512
3513         * DOM/DOMDocument.mm:
3514         (-[DOMDocument readyState]):
3515
3516 2017-05-05  Jeremy Jones  <jeremyj@apple.com>
3517
3518         REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
3519         https://bugs.webkit.org/show_bug.cgi?id=171610
3520         <rdar://problem/31976820>
3521
3522         Reviewed by Eric Carlson.
3523
3524         Fullscreen state gets confused because WK1 WebChromeClient doesn't implement exitVideoFullscreenToModeWithoutAnimation.
3525
3526         * WebCoreSupport/WebChromeClient.h:
3527         * WebCoreSupport/WebChromeClient.mm:
3528         (WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):
3529
3530 2017-05-04  Commit Queue  <commit-queue@webkit.org>
3531
3532         Unreviewed, rolling out r216206.
3533         https://bugs.webkit.org/show_bug.cgi?id=171714
3534
3535         Multiple LayoutTests crashing in Document::page() (Requested
3536         by ap on #webkit).
3537
3538         Reverted changeset:
3539
3540         "Remove support for legacy Notifications"
3541         https://bugs.webkit.org/show_bug.cgi?id=171487
3542         http://trac.webkit.org/changeset/216206
3543
3544 2017-05-04  Jeremy Jones  <jeremyj@apple.com>
3545
3546         UIColor +whiteColor and +clearColor are ambiguous and need to be casted when soft linked.
3547         https://bugs.webkit.org/show_bug.cgi?id=171704
3548
3549         Reviewed by Jer Noble.
3550
3551         Fix build by casting result of +whiteColor to UIColor.
3552
3553         * WebView/WebView.mm:
3554         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
3555
3556 2017-05-04  Sam Weinig  <sam@webkit.org>
3557
3558         Remove support for legacy Notifications
3559         https://bugs.webkit.org/show_bug.cgi?id=171487
3560
3561         Reviewed by Jon Lee.
3562