2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
[WebKit.git] / Source / WebKit / mac / ChangeLog
1 2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>
2
3         Reviewed by Pavel Feldman.
4
5         Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
6         https://bugs.webkit.org/show_bug.cgi?id=58883
7
8         * WebCoreSupport/WebFrameLoaderClient.h:
9         * WebCoreSupport/WebFrameLoaderClient.mm:
10         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
11
12 2011-04-18  Jia Pu  <jpu@apple.com>
13
14         Reviewed by Mark Rowe.
15
16         WebKit needs to stop importing <AppKit/NSTextChecker.h>
17         https://bugs.webkit.org/show_bug.cgi?id=58798
18         <rdar://problem/9294938>
19
20         Use public header <AppKit/NSSpellChecker.h> instead.
21
22         * WebCoreSupport/CorrectionPanel.h:
23         * WebCoreSupport/CorrectionPanel.mm:
24         (correctionIndicatorType):
25         (CorrectionPanel::show):
26         (CorrectionPanel::dismissInternal):
27         (CorrectionPanel::handleAcceptedReplacement):
28         * WebCoreSupport/WebEditorClient.mm:
29         * WebView/WebView.mm:
30
31 2011-04-17  Cameron Zwarich  <zwarich@apple.com>
32
33         Reviewed by Timothy Hatcher.
34
35         Stop using -[NSString initWithContentsOfFile:]
36         https://bugs.webkit.org/show_bug.cgi?id=58763
37
38         -[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.
39
40         * WebView/WebView.mm:
41         (leakMailQuirksUserScriptContents):
42         (leakOutlookQuirksUserScriptContents):
43
44 2011-04-17  David Kilzer  <ddkilzer@apple.com>
45
46         <http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
47         <rdar://problem/9268729>
48
49         Reviewed by Dan Bernstein.
50
51         This replaces support for the WebKitEnableHTTPPipelining user
52         default with methods on the WebCore::ResourceRequest class in
53         WebCore, the WebView class in WebKit1, and the WebContext class
54         in WebKit2.  It also removes support for the
55         WebKitForceHTTPPipeliningPriorityHigh user default which was not
56         needed.
57
58         * WebView/WebView.mm:
59         (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added.
60         (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added.
61         * WebView/WebViewPrivate.h:
62         (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration.
63         (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration.
64
65 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
66
67         Reviewed by Dan Bernstein.
68
69         Assign to self in WebInspectorWindowController constructors
70         https://bugs.webkit.org/show_bug.cgi?id=58749
71
72         * WebCoreSupport/WebInspectorClient.mm:
73         (-[WebInspectorWindowController init]):
74         (-[WebInspectorWindowController initWithInspectedWebView:]):
75
76 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
77
78         Reviewed by Timothy Hatcher.
79
80         Move WebNodeHighlighter into its own file
81         https://bugs.webkit.org/show_bug.cgi?id=58746
82
83         Extract this class into its own file alongside the
84         other WebNodeHighlight files. In doing so do some
85         cleanup on WebInspectorClient removing some methods
86         that were never called.
87
88         * WebCoreSupport/WebInspectorClient.mm:
89         (WebInspectorClient::WebInspectorClient): style fix.
90         * WebInspector/WebNodeHighlighter.h: Added.
91         * WebInspector/WebNodeHighlighter.mm: Added.
92         (-[WebNodeHighlighter initWithInspectedWebView:]): call super init.
93         (-[WebNodeHighlighter dealloc]):
94         (-[WebNodeHighlighter highlightNode:]):
95         (-[WebNodeHighlighter hideHighlight]):
96         (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
97         (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
98
99 2011-04-15  Jia Pu  <jpu@apple.com>
100
101         Reviewed by Dan Bernstein.
102
103         [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
104         https://bugs.webkit.org/show_bug.cgi?id=58717
105
106         Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.
107
108         * WebCoreSupport/CorrectionPanel.mm:
109         (CorrectionPanel::show):
110
111 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
112
113         Reviewed by James Robinson.
114
115         Add a flag to guard Page Visibility API changes.
116         https://bugs.webkit.org/show_bug.cgi?id=58464
117
118         * Configurations/FeatureDefines.xcconfig:
119
120 2011-04-15  Oliver Hunt  <oliver@apple.com>
121
122         GC allocate Structure
123         https://bugs.webkit.org/show_bug.cgi?id=58483
124
125         Rolling r83894 r83827 r83810 r83809 r83808 back in with
126         a workaround for the gcc bug seen by the gtk bots
127
128         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
129         * Plugins/Hosted/ProxyInstance.mm:
130         (WebKit::ProxyRuntimeMethod::createStructure):
131         * Plugins/Hosted/ProxyRuntimeObject.h:
132         (WebKit::ProxyRuntimeObject::createStructure):
133
134 2011-04-14  Alexey Proskuryakov  <ap@apple.com>
135
136         Reviewed by Dan Bernstein.
137
138         WebKit2: Password field input does not switch to ASCII-compatible source
139         https://bugs.webkit.org/show_bug.cgi?id=58583
140         <rdar://problem/9059651>
141
142         Now that WebCore doesn't set secure input mode, WebKit has to. Happily, it already has the
143         necessary logic, needed to return a nil text input context when in password fields.
144
145         * WebView/WebHTMLView.mm:
146         (-[WebHTMLView close]): If the view is still enforcing secure event mode, stop.
147         (-[WebHTMLView windowDidBecomeKey:]): Call _updateSecureInputState.
148         (-[WebHTMLView windowDidResignKey:]): Ditto.
149         (-[WebHTMLView becomeFirstResponder]): Call _updateSecureInputState. It's a bit tricky
150         because the first responder is still different an this point, so set a boolean variable to
151         let _updateSecureInputState know what's going on.
152         (-[WebHTMLView resignFirstResponder]): Disable secure event mode if it's on.
153         (-[WebHTMLView _updateSecureInputState]): Update HIToolbox secure event input state and
154         allowed input sources accorsing to current selection.
155         (-[WebHTMLView _updateSelectionForInputManager]): Call _updateSecureInputState.
156
157 2011-04-15  Sam Weinig  <sam@webkit.org>
158
159         Reviewed by Maciej Stachowiak.
160
161         Make mac WebKit1 use the default localization strategy
162         https://bugs.webkit.org/show_bug.cgi?id=58628
163
164         * WebCoreSupport/WebPlatformStrategies.h:
165         * WebCoreSupport/WebPlatformStrategies.mm:
166         Remove the localization strategy code. The equivalent is now
167         in WebCore/platform/DefaultLocalizationStrategy.cpp.
168
169 2011-04-15  Anna Cavender  <annacc@chromium.org>
170
171         Reviewed by Eric Carlson.
172
173         Renaming TRACK feature define to VIDEO_TRACK
174         https://bugs.webkit.org/show_bug.cgi?id=53556
175
176         * Configurations/FeatureDefines.xcconfig:
177
178 2011-04-14  Pratik Solanki  <psolanki@apple.com>
179
180         Reviewed by David Kilzer.
181
182         Set minimum priority for fast lane connections
183         https://bugs.webkit.org/show_bug.cgi?id=58353
184
185         * WebCoreSupport/WebSystemInterface.mm:
186         (InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
187
188 2011-04-13  Sam Weinig  <sam@webkit.org>
189
190         Reviewed by Gavin Barraclough.
191
192         WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
193         <rdar://problem/9260518>
194
195         * WebCoreSupport/WebSystemInterface.mm:
196         (InitWebCoreSystemInterface):
197         Initialize new WKSI functions.
198
199 2011-04-13  David Kilzer  <ddkilzer@apple.com>
200
201         <http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm
202
203         Reviewed by Anders Carlsson.
204
205         Fixes the following warning with -Wcast-align enabled:
206
207             Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]
208                          archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));
209                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
210
211         * Plugins/WebBasePluginPackage.mm:
212         (-[WebBasePluginPackage isNativeLibraryData:]): Added
213         COMPILE_ASSERT() to make sure our pointer math is valid.
214         Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
215         by sizeof(uint32_t) to fix the pointer math.  Replaced C-style
216         casts with reinterpret_cast.
217
218 2011-04-12  Enrica Casucci  <enrica@apple.com>
219
220         Reviewed by Alexey Proskuryakov.
221
222         Infinite recursion in WebHTMLView executeSavedKeypressCommands.
223         https://bugs.webkit.org/show_bug.cgi?id=58382
224         <rdar://problem/9239370>
225
226         Execution of some editing commands could trigger a call to selectedRange that
227         internally calls executeSavedKeypressCommands creating an infinite recursion.
228
229         * WebView/WebHTMLView.mm:
230         (-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
231         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.
232
233 2011-04-12  Alice Liu  <alice.liu@apple.com>
234
235         Reviewed by Sam Weinig.
236
237         https://bugs.webkit.org/show_bug.cgi?id=58292
238         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
239
240         * WebView/WebPreferenceKeysPrivate.h: Add preference key.
241         * WebView/WebPreferences.mm:
242         (+[WebPreferences initialize]): Initialize to false.
243         (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
244         (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.
245         * WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
246         * WebView/WebView.mm:
247         (-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes. 
248
249 2011-04-11  Alexey Proskuryakov  <ap@apple.com>
250
251         Reviewed by Maciej Stachowiak.
252
253         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
254         https://bugs.webkit.org/show_bug.cgi?id=58175
255         <rdar://problem/9060555>
256
257         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
258         should be changed to match WebKit2.
259
260 2011-04-06  Timothy Hatcher  <timothy@apple.com>
261
262         Fix a bug where the context menu does not show in PDF documents if there is no
263         UI delegate or the UI delegate does not respond to the context menu selector.
264
265         https://webkit.org/b/57958
266
267         Reviewed by Darin Adler.
268
269         * WebView/WebView.mm:
270         (-[WebView _menuForElement:defaultItems:]): CallUIDelegate returns nil
271         if UIDelegate is nil or doesn't respond to the selector. So check that
272         here to distinguish between using defaultMenuItems or the delegate
273         really returning nil to say "no context menu".
274
275 2011-04-11  Jer Noble  <jer.noble@apple.com>
276
277         Unreviewed; roll out unintentional change to WebFullScreenController.mm.
278
279         * WebView/WebFullScreenController.mm:
280         (-[WebFullScreenController enterFullscreen:]):
281
282 2011-04-08  Geoffrey Garen  <ggaren@apple.com>
283
284         Reviewed by Oliver Hunt.
285
286         A few heap-related renames and file moves.
287         
288         WeakGCPtr<T> => Weak<T>
289         Global<T> => Strong<T>
290         collector/ => heap/
291         collector/* => heap/*
292         runtime/WeakGCPtr.h => heap/Weak.h
293         
294         (Eventually, even more files should move into the heap directory. Like
295         Heap.h and Heap.cpp, for example.)
296
297         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
298         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
299         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
300         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
301         (WebKit::NetscapePluginInstanceProxy::evaluate):
302         * WebView/WebScriptDebugger.h:
303
304 2011-04-08  Alexey Proskuryakov  <ap@apple.com>
305
306         Reviewed by Darin Adler.
307
308         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
309         https://bugs.webkit.org/show_bug.cgi?id=58175
310         <rdar://problem/9060555>
311
312         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
313         should be changed to match WebKit2.
314
315 2011-04-08  Alpha Lam  <hclam@chromium.org>
316
317         Unreviewed, rolling out r83335.
318         http://trac.webkit.org/changeset/83335
319         https://bugs.webkit.org/show_bug.cgi?id=53556
320
321         GTK and QT bots are broken
322
323         * Configurations/FeatureDefines.xcconfig:
324
325 2011-04-07  Anna Cavender  <annacc@chromium.org>
326
327         Reviewed by Eric Carlson.
328
329         Setup ENABLE(TRACK) feature define
330         https://bugs.webkit.org/show_bug.cgi?id=53556
331
332         * Configurations/FeatureDefines.xcconfig:
333
334 2011-04-08  Maciej Stachowiak  <mjs@apple.com>
335
336         Reviewed by Darin Adler.
337
338         -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
339         https://bugs.webkit.org/show_bug.cgi?id=58128
340         <rdar://problem/9244553>
341         
342         The root of the problem here was an O(N^2) issue - each WebView,
343         upon having its preferences initialized, would broadcast a
344         notification that was listened to by all other WebViews sharing
345         its preferences.
346         
347         To maintain the API contract, I split the notification into two,
348         one that is for public API consumption, and the other which is for
349         internal use only. Changes that don't need to be picked up by
350         other WebViews broadcast the public notification only. And we
351         avoid WebView broadcasting a notification just to get itself to
352         update.
353
354         * Misc/WebIconDatabase.mm:
355         (-[WebIconDatabase _startUpIconDatabase]):
356         (-[WebIconDatabase _shutDownIconDatabase]):
357         * Plugins/WebBaseNetscapePluginView.mm:
358         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
359         (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
360         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
361         (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
362         * WebView/WebPreferences.mm:
363         (-[WebPreferences initWithIdentifier:]):
364         (-[WebPreferences _setStringValue:forKey:]):
365         (-[WebPreferences _setIntegerValue:forKey:]):
366         (-[WebPreferences _setFloatValue:forKey:]):
367         (-[WebPreferences _setBoolValue:forKey:]):
368         (-[WebPreferences _setLongLongValue:forKey:]):
369         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
370         (-[WebPreferences _postPreferencesChangedNotification]):
371         (-[WebPreferences _postPreferencesChangedAPINotification]):
372         * WebView/WebPreferencesPrivate.h:
373         * WebView/WebView.mm:
374         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
375         (-[WebView _preferencesChangedNotification:]):
376         (-[WebView _preferencesChanged:]):
377         (-[WebView setUsesPageCache:]):
378         (+[WebView initialize]):
379         (-[WebView setPreferences:]):
380         (-[WebView _keyboardUIMode]):
381         * WebView/WebViewInternal.h:
382
383 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
384
385         Revert ENABLE_TRACK patch due to compile failures.
386
387         * Configurations/FeatureDefines.xcconfig:
388
389 2011-04-07  Alexey Proskuryakov  <ap@apple.com>
390
391         Reviewed by Anders Carlsson.
392
393         REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
394         https://bugs.webkit.org/show_bug.cgi?id=58066
395         <rdar://problem/8965302>
396
397         * WebView/WebHTMLRepresentation.mm:
398         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
399         * WebView/WebHTMLView.mm:
400         (-[WebHTMLView attributedSubstringFromRange:]):
401         (-[WebHTMLView attributedString]):
402         (-[WebHTMLView selectedAttributedString]):
403         Updated for editingAttributedStringFromRange: now taking a WebCore::Range instead of DOMRange.
404
405 2011-04-07  Andy Estes  <aestes@apple.com>
406
407         Reviewed by Darin Adler.
408
409         REGRESSION (r64712): Microsoft Outlook 2011: original message contents
410         not included when replying to an email.
411         https://bugs.webkit.org/show_bug.cgi?id=57794
412         
413         Outlook populates a reply message by creating an empty WebView and
414         using DOM API to populate the WebView's empty document with content
415         from the original message. It expects the initial empty document to
416         simply be "<html></html>", and it proceeds to dynamically create and
417         append a BODY node and add the original message content as a child of
418         that node. Outlook then takes the innerHTML of the frame's first body
419         element and copies it into a *new* document that is displayed and
420         edited in the reply message window.
421         
422         Due to implementing the HTML5 tree building algorithm in r64712,
423         initial empty documents went from being "<html></html>" to being
424         "<html><head></head><body></body></html>". Outlook still dynamically
425         creates a BODY node to parent the original message content, but this
426         BODY node duplicates the one created by the tree builder. When Outlook
427         then takes the innerHTML of the first body element to populate the
428         reply message window it gets the empty body element created by the
429         parser, not the one it created with the original message content.
430         
431         Fix this by injecting a user script into the initial empty document
432         that removes the HEAD and BODY nodes created by the parser. This
433         ensures that the BODY created by Outlook is the only BODY in the
434         document.
435
436         * Misc/OutlookQuirksUserScript.js: Added.
437         * WebView/WebView.mm:
438         (leakMailQuirksUserScriptContents):
439         (-[WebView _injectMailQuirksScript]):
440         (needsOutlookQuirksScript):
441         (leakOutlookQuirksUserScriptContents):
442         (-[WebView _injectOutlookQuirksScript]):
443         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
444
445 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
446
447         Reviewed by David Levin.
448
449         Add QUOTA build flag for unified quota API
450         https://bugs.webkit.org/show_bug.cgi?id=57918
451
452         * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
453
454 2011-04-06  Robert Sesek  <rsesek@chromium.org>
455
456         Reviewed by Alexey Proskuryakov.
457
458         Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
459         https://bugs.webkit.org/show_bug.cgi?id=54969
460
461         * WebView/WebFrame.mm:
462         (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
463         (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
464
465 2011-04-05  Alexey Proskuryakov  <ap@apple.com>
466
467         Reviewed by Darin Adler.
468
469         Move attributedStringFromRange down to WebCore
470         https://bugs.webkit.org/show_bug.cgi?id=57905
471
472         * Misc/WebNSAttributedStringExtras.h: Removed.
473         * Misc/WebNSAttributedStringExtras.mm: Removed.
474         * WebView/WebHTMLRepresentation.mm:
475         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
476         * WebView/WebHTMLView.mm:
477         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
478         (-[WebHTMLView attributedSubstringFromRange:]):
479         (-[WebHTMLView attributedString]):
480         (-[WebHTMLView selectedAttributedString]):
481         * WebView/WebPDFView.mm:
482         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
483
484 2011-04-04  MORITA Hajime  <morrita@google.com>
485
486         Reviewed by Ryosuke Niwa.
487
488         [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
489         https://bugs.webkit.org/show_bug.cgi?id=56085
490
491         Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
492         NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
493         for requestCheckingOfString method.
494         
495         * WebCoreSupport/WebEditorClient.h:
496         * WebCoreSupport/WebEditorClient.mm:
497         (toCoreTextCheckingResults):
498         (WebEditorClient::checkTextOfParagraph):
499         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]):
500         (-[WebEditorSpellCheckResponder perform]):
501         (WebEditorClient::requestCheckingOfString):
502         * WebView/WebFrame.mm:
503         (-[WebFrame markersForSelectionStartAsText]):
504         * WebView/WebFramePrivate.h:
505
506 2011-04-05  Anders Carlsson  <andersca@apple.com>
507
508         Didn't mean to land this.
509
510         * Plugins/WebNetscapePluginView.mm:
511         (-[WebNetscapePluginView getVariable:value:]):
512
513 2011-04-04  David Kilzer  <ddkilzer@apple.com>
514
515         <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
516
517         Reviewed by Alexey Proskuryakov.
518
519         * WebCoreSupport/WebSystemInterface.mm:
520         (InitWebCoreSystemInterface): Added initialization for
521         wkSetHTTPPipeliningMaximumPriority().
522
523 2011-04-04  Alexey Proskuryakov  <ap@apple.com>
524
525         Reviewed by Dan Bernstein.
526
527         REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
528         https://bugs.webkit.org/show_bug.cgi?id=51230
529         <rdar://problem/8780989>
530
531         * WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Moved Caps Lock handling from
532         WebKits to WebCore, because WebKit shouldn't be smart.
533
534 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
535
536         Reviewed by Darin Adler.
537
538         REGRESSION: Assertion failure when executing a complex custom key binding
539         https://bugs.webkit.org/show_bug.cgi?id=57681
540
541         * WebView/WebHTMLView.mm: (-[WebHTMLView hasMarkedText]): There is no need to execute saved
542         commands when they can't possibly change the result.
543
544 2011-04-01  Anders Carlsson  <andersca@apple.com>
545
546         Reviewed by Sam Weinig.
547
548         Shockwave plug-in doesn't accept mouse events
549         https://bugs.webkit.org/show_bug.cgi?id=57653
550         <rdar://problem/8483273>
551
552         Fix an unrelated bug found by the added test.
553
554         * Plugins/WebBaseNetscapePluginView.mm:
555         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
556         Make sure to always set destX and destY.
557
558 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
559
560         Reviewed by Darin Adler.
561
562         Make WebKit2 text input handling more like WebKit1
563         https://bugs.webkit.org/show_bug.cgi?id=57649
564
565         * WebView/WebFrameInternal.h: Expose _convertToDOMRange for use in WebHTMLView.
566         * WebView/WebHTMLView.mm:
567         (-[WebHTMLView _executeSavedKeypressCommands]): Renamed, since these are not editor commands.
568         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for the renamed _executeSavedKeypressCommands.
569         (-[WebHTMLView characterIndexForPoint:]): Ditto.
570         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
571         (-[WebHTMLView selectedRange]): Ditto.
572         (-[WebHTMLView markedRange]): Ditto.
573         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
574         (-[WebHTMLView hasMarkedText]): Ditto.
575         (-[WebHTMLView unmarkText]): Ditto.
576         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. Changed the comment about the argument
577         type into an assertion. Removed resetting interpretKeyEventsParameters to 0, as we shouldn't
578         be able to call text input protocol methods from here (and we didn't even reset it back on
579         return). Changed to retrieve all data before starting to apply actions to better match WK2 code.
580         (-[WebHTMLView insertText:]): Ditto.
581
582 2011-04-01  Timothy Hatcher  <timothy@apple.com>
583
584         Make momentum scroll event latching work in WebKit2 on Mac.
585
586         <rdar://problem/8751861>
587
588         Reviewed by Darin Adler.
589
590         * WebCoreSupport/WebSystemInterface.mm:
591         (InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.
592         * WebView/WebDynamicScrollBarsView.mm:
593         (-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent.
594
595 2011-03-31  Darin Adler  <darin@apple.com>
596
597         Reviewed by Anders Carlsson.
598
599         Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]
600         https://bugs.webkit.org/show_bug.cgi?id=26667
601
602         * WebView/WebHTMLView.mm:
603         (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is
604         nil rather than asserting that it is non-nil. One case where WebView will be nil
605         is when the frame is closed, but in any case where it is nil, the correct thing
606         to do is to not try to handle the style key.
607
608 2011-03-31  Alexey Proskuryakov  <ap@apple.com>
609
610         Patch by John Harvey, reviewed and tweaked by me.
611
612         <rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.
613
614         * Plugins/Hosted/WebTextInputWindowController.m:
615         (-[WebTextInputPanel _interpretKeyEvent:string:]):
616
617 2011-03-31  Evan Martin  <evan@chromium.org>
618
619         Reviewed by Eric Seidel.
620
621         <title> should support dir attribute
622         https://bugs.webkit.org/show_bug.cgi?id=50961
623
624         Update to new FrameLoaderClient interface.
625
626         * WebCoreSupport/WebFrameLoaderClient.h:
627         * WebCoreSupport/WebFrameLoaderClient.mm:
628         (WebFrameLoaderClient::dispatchDidReceiveTitle):
629         (WebFrameLoaderClient::setTitle):
630
631 2011-03-30  Dominic Cooney  <dominicc@google.com>
632
633         Reviewed by Dimitri Glazkov.
634
635         Adds layoutTestController.shadowRoot accessor to Mac DRT.
636         https://bugs.webkit.org/show_bug.cgi?id=57415
637
638         * DOM/WebDOMOperations.mm:
639         (-[DOMElement _shadowRoot:]):
640         * DOM/WebDOMOperationsPrivate.h:
641
642 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
643
644         Reviewed by Darin Adler.
645
646         WebHTMLView shouldn't resend noop: commands
647         https://bugs.webkit.org/show_bug.cgi?id=57504
648         <rdar://problem/9209390>
649
650         * WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs,
651         which we get e.g. when handling Cmd-key combos.
652
653 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
654
655         Reviewed by Darin Adler.
656
657         REGRESSION (r82320): Spacebar no longer pages down
658         https://bugs.webkit.org/show_bug.cgi?id=57423
659         <rdar://problem/9207702>
660
661         Also includes some unrelated cleanup that I had in my tree.
662
663         * WebView/WebHTMLView.mm:
664         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is
665         being dispatched to the right frame.
666         (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL.
667         (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=".
668         Even if this specific command hasn't been handled, that doesn't nullify side effects from
669         previous commands.
670         (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the
671         bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for
672         another WebHTMLView NSTextInput method to be called from within insertText:, so no one is
673         going to look at it.
674
675 2011-03-30  Sam Weinig  <sam@webkit.org>
676
677         Reviewed by Brady Eidson.
678
679         WebKit2: Attempting to view css file from url causes it to download
680         <rdar://problem/9102611>
681         https://bugs.webkit.org/show_bug.cgi?id=57501
682
683         * WebView/WebHTMLRepresentation.h:
684         * WebView/WebHTMLRepresentation.mm:
685         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
686         * WebView/WebHTMLView.mm:
687         (+[WebHTMLView unsupportedTextMIMETypes]):
688         Re-factor unsupportedTextMIMETypes to pull from WebCore's
689         MIMETypeRegistry, so that the list can be shared with WebKit2.
690
691 2011-03-29  Beth Dakin  <bdakin@apple.com>
692
693         Reviewed by Maciej Stachowiak.
694
695         Fix for https://bugs.webkit.org/show_bug.cgi?id=57408 
696         webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard 
697         -and corresponding-
698         <rdar://problem/8665411>
699
700         * Misc/WebNSControlExtras.m:
701         (-[NSControl sizeToFitAndAdjustWindowHeight]):
702         * WebCoreSupport/WebChromeClient.mm:
703         (WebChromeClient::scaleFactor):
704         * WebView/WebHTMLView.mm:
705         (-[WebHTMLView viewDidMoveToWindow]):
706         (-[WebHTMLView attachRootLayer:]):
707
708 2011-03-29  Kent Tamura  <tkent@chromium.org>
709
710         Reviewed by Dimitri Glazkov.
711
712         Make validation message bubble testable
713         https://bugs.webkit.org/show_bug.cgi?id=57290
714
715         * WebView/WebView.mm:
716         (-[WebView _preferencesChangedNotification:]): Copy the private value of
717           the timer magnification to WebCore::Settings.
718         (-[WebView validationMessageTimerMagnification]): Added.
719         (-[WebView setValidationMessageTimerMagnification:]): Added.
720         * WebView/WebViewData.h: Declare a member for the timer magnification.
721         * WebView/WebViewData.mm:
722         (-[WebViewPrivate init]): Initialize the timer magnification.
723         * WebView/WebViewPrivate.h:
724           Declare a setter and a getter for the timer magnification.
725
726 2011-03-29  Kent Tamura  <tkent@chromium.org>
727
728         Reviewed by Dimitri Glazkov.
729
730         [Mac] Enable interactive-validation tests on Mac DRT
731         https://bugs.webkit.org/show_bug.cgi?id=57308
732
733         * WebView/WebView.mm:
734         (-[WebView _preferencesChangedNotification:]):
735           Convey a WebView flag for interactive validation to WebCore::Settings.
736         (-[WebView interactiveFormValidationEnabled]): Added.
737         (-[WebView setInteractiveFormValidationEnabled:]): Added.
738         * WebView/WebViewData.h: Add interactiveFormValidationEnabled.
739         * WebView/WebViewData.mm:
740         (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled.
741         * WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled.
742
743 2011-03-29  Timothy Hatcher  <timothy@apple.com>
744
745         Update the order of the context menu to better match AppKit on Mac.
746
747         <rdar://problem/9054893>
748
749         Reviewed by John Sullivan.
750
751         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
752         (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items.
753         * WebCoreSupport/WebPlatformStrategies.h:
754         * WebCoreSupport/WebPlatformStrategies.mm:
755         (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
756
757 2011-03-29  Alexey Proskuryakov  <ap@apple.com>
758
759         Reviewed by Darin Adler.
760
761         https://bugs.webkit.org/show_bug.cgi?id=57379
762         Clean up WK1 key event handling logic
763
764         No bugs knowingly fixed, but this makes the code more consistent.
765
766         * WebView/WebHTMLView.mm:
767         (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to
768         eventInterpretationHadSideEffects, because "handled" doesn't really mean much.
769         (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use
770         from other functions. We need to execute saved commands when an input method asks for current
771         state, because providing stale state could confuse it.
772         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other
773         changes.
774         (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise,
775         the answer would be stale.
776         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
777         (-[WebHTMLView selectedRange]): Ditto.
778         (-[WebHTMLView markedRange]): Ditto.
779         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
780         (-[WebHTMLView hasMarkedText]): Ditto.
781         (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be
782         operating on stale data. Also, updated for eventWasHandled renaming.
783         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
784         (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that
785         it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also
786         fragile, because there is no guarantee about when noop: is sent (also, a custom key binding
787         could have a noop: as one of its commands, although that's hardly practical).
788         Added the same "from input method" logic that we have in insertText: - I don't know of any
789         IMs that call this method, but we clearly need to execute it as part of IM processing when
790         there is marked text.
791         (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set
792         eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times
793         if current selection isn't editable. This is different from doCommandBySelector:, where we
794         need to give super class a chance to handle the event if our processing fails.
795         Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the
796         return value of _interpretKeyEvent is computed differently.
797
798 2011-03-28  Adele Peterson  <adele@apple.com>
799
800         Reviewed by Eric Seidel.
801
802         Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
803         https://bugs.webkit.org/show_bug.cgi?id=57173
804
805         * WebView/WebFrame.mm:
806         (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
807         (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
808         * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.
809
810 2011-03-28  Alexey Proskuryakov  <ap@apple.com>
811
812         Reviewed by Darin Adler.
813
814         https://bugs.webkit.org/show_bug.cgi?id=57260
815         Clean up text input code a little
816
817         * WebCoreSupport/WebEditorClient.mm:
818         (WebEditorClient::handleKeyboardEvent):
819         (WebEditorClient::handleInputMethodKeydown):
820         * WebView/WebHTMLViewInternal.h:
821         Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
822         anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
823         and also possibly saves resulting commands for later execution.
824
825         * WebView/WebHTMLView.mm:
826         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
827         return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
828         WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
829         handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
830         because the first call resulted in no saved commands, becasue it's confusing and apparently
831         useless (I couldn't find any broken behavior).
832         (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
833         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
834         (-[WebHTMLView doCommandBySelector:]): Ditto.
835         (-[WebHTMLView insertText:]): Ditto.
836
837         * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
838         method on WebView.
839
840 2011-03-27  Jer Noble  <jer.noble@apple.com>
841
842         Reviewed by Maciej Stachowiak.
843
844         Full Screen: disable keyboard access by default
845         https://bugs.webkit.org/show_bug.cgi?id=56684
846
847         Take into account whether keyboard access was requested when deciding whether full
848         screen mode is supported.
849
850         * WebCoreSupport/WebChromeClient.h:
851         * WebCoreSupport/WebChromeClient.mm:
852         (WebChromeClient::supportsFullScreenForElement):
853         * WebView/WebView.mm:
854         (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
855         * WebView/WebViewInternal.h:
856
857 2011-03-26  Jer Noble  <jer.noble@apple.com>
858
859         Reviewed by Eric Carlson.
860
861         Enable the Full Screen API by default in WebKit/mac and WebKit2
862         https://bugs.webkit.org/show_bug.cgi?id=56956
863
864         * WebView/WebPreferences.mm:
865         (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.
866
867 2011-03-25  Andy Estes  <aestes@apple.com>
868
869         Reviewed by Adele Peterson.
870
871         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
872         https://bugs.webkit.org/show_bug.cgi?id=49016
873
874         Update objectContentType() implementation to handle the
875         shouldPreferPlugInsForImages flag.
876
877         * WebCoreSupport/WebFrameLoaderClient.h:
878         * WebCoreSupport/WebFrameLoaderClient.mm:
879         (WebFrameLoaderClient::objectContentType):
880
881 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
882
883         Unreviewed, rolling out r81939.
884         http://trac.webkit.org/changeset/81939
885         https://bugs.webkit.org/show_bug.cgi?id=57084
886
887         Rolling out 81939, as it's causing a number of app cache test
888         failures. (Requested by jernoble on #webkit).
889
890         * WebView/WebView.mm:
891         (-[WebView _preferencesChangedNotification:]):
892
893 2011-03-23  Jer Noble  <jer.noble@apple.com>
894
895         Reviewed by Maciej Stachowiak.
896
897         Application Cache should save audio/ and video/ mime types as flat files
898         https://bugs.webkit.org/show_bug.cgi?id=53784
899         <rdar://problem/8932473>
900
901         No new tests.
902
903         Initialize the AppCache Total size quotas with the values for WebKitPreferences
904         upon startup.
905
906         * WebView/WebView.mm:
907         (-[WebView _preferencesChangedNotification:]):
908
909 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
910
911         Unreviewed, rolling out r81916 and r81917.
912         http://trac.webkit.org/changeset/81916
913         http://trac.webkit.org/changeset/81917
914         https://bugs.webkit.org/show_bug.cgi?id=57071
915
916         broke a test on platforms that do not have QuickTime installed
917         (Requested by estes on #webkit).
918
919         * WebCoreSupport/WebFrameLoaderClient.h:
920         * WebCoreSupport/WebFrameLoaderClient.mm:
921         (WebFrameLoaderClient::objectContentType):
922
923 2011-03-24  Andy Estes  <aestes@apple.com>
924
925         Reviewed by Darin Adler.
926
927         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
928         https://bugs.webkit.org/show_bug.cgi?id=49016
929
930         Update objectContentType() implementation to handle the
931         shouldPreferPlugInsForImages flag.
932
933         * WebCoreSupport/WebFrameLoaderClient.h:
934         * WebCoreSupport/WebFrameLoaderClient.mm:
935         (WebFrameLoaderClient::objectContentType):
936
937 2011-03-24  Geoffrey Garen  <ggaren@apple.com>
938
939         Reviewed by Oliver Hunt.
940
941         Ensure that all compilation takes place within a dynamic global object scope
942         https://bugs.webkit.org/show_bug.cgi?id=57054
943
944         * WebView/WebScriptDebugDelegate.mm:
945         (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change.
946
947 2011-03-24  Jia Pu  <jpu@apple.com>
948
949         Reviewed by Darin Adler.
950
951         Dismissed reversion suggestion is incorrectly learned.
952         https://bugs.webkit.org/show_bug.cgi?id=57039
953
954         CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
955         [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
956         is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
957         incorrect automatic learning.
958
959         * WebCoreSupport/CorrectionPanel.mm:
960         (CorrectionPanel::dismissInternal):
961
962 2011-03-24  David Kilzer  <ddkilzer@apple.com>
963
964         <http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X
965
966         Reviewed by Joseph Pecoraro.
967
968         * Plugins/WebPluginContainerPrivate.h: Changed value of
969         ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.
970
971 2011-03-23  Jia Pu  <jpu@apple.com>
972
973         Reviewed by Darin Adler.
974
975         Hook up new AppKit autocorrection UI with WK2.
976         https://bugs.webkit.org/show_bug.cgi?id=56055
977         <rdar://problem/8947463>
978
979         Please see WebCore/ChangeLog for detail.
980
981         * WebCoreSupport/CorrectionPanel.h: Added.
982         (CorrectionPanel::isShowing):
983         * WebCoreSupport/CorrectionPanel.mm: Added.
984         (correctionBubbleType):
985         (CorrectionPanel::CorrectionPanel):
986         (CorrectionPanel::~CorrectionPanel):
987         (CorrectionPanel::show):
988         (CorrectionPanel::dismiss):
989         (CorrectionPanel::dismissSoon):
990         (CorrectionPanel::dismissInternal):
991         (CorrectionPanel::recordAutocorrectionResponse):
992         * WebCoreSupport/WebEditorClient.h:
993         * WebCoreSupport/WebEditorClient.mm:
994         (WebEditorClient::WebEditorClient):
995         (WebEditorClient::showCorrectionPanel):
996         (WebEditorClient::dismissCorrectionPanel):
997         (WebEditorClient::dismissCorrectionPanelSoon):
998         (WebEditorClient::recordAutocorrectionResponse):
999         * WebView/WebView.mm:
1000         (-[WebView handleCorrectionPanelResult:]):
1001         * WebView/WebViewPrivate.h:
1002
1003 2011-03-23  Enrica Casucci  <enrica@apple.com>
1004
1005         Reviewed by Alexey Proskuryakov.
1006
1007         Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
1008         https://bugs.webkit.org/show_bug.cgi?id=56974
1009         <rdar://problem/8284642>
1010
1011         This fixes a regression introduced by http://trac.webkit.org/changeset/61794
1012         where readSelectionFromPasteboard was accidentally removed.
1013         This method and writeSelectionToPasteboard are needed to support Mac OS X
1014         services.
1015         
1016         * WebView/WebHTMLView.mm:
1017         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
1018         (-[WebHTMLView readSelectionFromPasteboard:]): Added.
1019
1020 2011-03-23  Brady Eidson  <beidson@apple.com>
1021
1022         Reviewed by Sam Weinig.
1023
1024         Change IconDatabase opening to allow for arbitrary filenames
1025         https://bugs.webkit.org/show_bug.cgi?id=56977
1026
1027         * Misc/WebIconDatabase.mm:
1028         (-[WebIconDatabase _startUpIconDatabase]):
1029
1030 2011-03-22  Anton D'Auria  <adauria@apple.com>
1031
1032         Reviewed by Alexey Proskuryakov.
1033
1034         Add +[WebApplicationCache getOriginsWithCache]
1035         https://bugs.webkit.org/show_bug.cgi?id=56722
1036
1037         Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.
1038
1039         * WebCoreSupport/WebApplicationCache.h:
1040         * WebCoreSupport/WebApplicationCache.mm:
1041         (+[WebApplicationCache originsWithCache]):
1042
1043 2011-03-22  Anders Carlsson  <andersca@apple.com>
1044
1045         Reviewed by Sam Weinig.
1046
1047         OBJECT element with DivX source is always downloaded
1048         https://bugs.webkit.org/show_bug.cgi?id=56879
1049
1050         * Plugins/WebBasePluginPackage.mm:
1051         (-[WebBasePluginPackage getPluginInfoFromPLists]):
1052         Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in
1053         specifies multiple file extensions in a single element.
1054
1055 2011-03-22  Brady Eidson  <beidson@apple.com>
1056
1057         Reviewed by Sam Weinig.
1058
1059         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
1060         WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
1061
1062         Note that while the new client calls always come through on the main thread, our mechanisms to
1063         route dispatches to the main thread are still valid and will still work.
1064
1065         Update to the new IconDatabaseClient interface:
1066         * WebCoreSupport/WebIconDatabaseClient.h:
1067         * WebCoreSupport/WebIconDatabaseClient.mm:
1068         (WebIconDatabaseClient::didRemoveAllIcons):
1069         (WebIconDatabaseClient::didImportIconURLForPageURL):
1070         (WebIconDatabaseClient::didImportIconDataForPageURL):
1071         (WebIconDatabaseClient::didChangeIconForPageURL):
1072         (WebIconDatabaseClient::didFinishURLImport):
1073
1074 2011-03-22  Matthew Delaney  <mdelaney@apple.com>
1075
1076         Reviewed by Simon Fraser.
1077
1078         Have WebKit push acceleratedDrawing preferences to settings
1079         https://bugs.webkit.org/show_bug.cgi?id=56792
1080
1081         * WebView/WebView.mm:
1082
1083 2011-03-21  Nate Chapin  <japhet@chromium.org>
1084
1085         Reviewed by Brady Eidson.
1086
1087         Expose a preference to use caching quirks for QuickLook,
1088         and use it if the QuickLook framework is loaded.
1089
1090         https://bugs.webkit.org/show_bug.cgi?id=38690
1091
1092         * WebView/WebPreferenceKeysPrivate.h:
1093         * WebView/WebPreferences.mm:
1094         (useQuickLookQuirks):
1095         (+[WebPreferences initialize]):
1096         (-[WebPreferences useQuickLookResourceCachingQuirks]):
1097         * WebView/WebPreferencesPrivate.h:
1098         * WebView/WebView.mm:
1099         (-[WebView _preferencesChangedNotification:]):
1100
1101 2011-03-21  Chris Fleizach  <cfleizach@apple.com>
1102
1103         Reviewed by Darin Adler.
1104
1105         AX: showContextMenu not working in WK2
1106         https://bugs.webkit.org/show_bug.cgi?id=56734
1107
1108         Implement showContextMenu() so accessibility related code can call this
1109         independent of whether WK1 or WK2 is running.
1110
1111         * WebCoreSupport/WebChromeClient.h:
1112         * WebCoreSupport/WebChromeClient.mm:
1113         (WebChromeClient::showContextMenu):
1114
1115 2011-03-21  Chang Shu  <cshu@webkit.org>
1116
1117         Reviewed by Alexey Proskuryakov.
1118
1119         REGRESSION (r79953): Can't type in MS Outlook 2011
1120         https://bugs.webkit.org/show_bug.cgi?id=56665
1121
1122         r79953 removed the WebView level editablity which is persistent no matter whether
1123         underlying document itself is changed and editability gets lost. The resolution is to
1124         set this WebView editable value to WebCore. This avoids the callback from WebCore to
1125         WebKit which was the main goal in r79953 to improve performance.
1126
1127         * WebView/WebView.mm:
1128         (-[WebView setEditable:]):
1129         (-[WebView isEditable]):
1130
1131 2011-03-19  Anton D'Auria  <adauria@apple.com>
1132
1133         Reviewed by Alexey Proskuryakov.
1134
1135         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
1136         https://bugs.webkit.org/show_bug.cgi?id=56415
1137         
1138         Use new ApplicationCache API to delete all cache for an origin.
1139
1140         * WebCoreSupport/WebApplicationCache.h:
1141         * WebCoreSupport/WebApplicationCache.mm:
1142         (+[WebApplicationCache deleteOrigin:]):
1143
1144 2011-03-17  Brady Eidson  <beidson@apple.com>
1145
1146         Reviewed by Sam Weinig.
1147
1148         https://bugs.webkit.org/show_bug.cgi?id=56425
1149         More groundwork for WebKit2 IconDatabase
1150
1151         Update already-used function names:
1152         * Misc/WebIconDatabase.mm:
1153         (-[WebIconDatabase iconForURL:withSize:cache:]):
1154         (-[WebIconDatabase iconURLForURL:]):
1155         * WebView/WebView.mm:
1156         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
1157
1158 2011-03-18  Pavel Podivilov  <podivilov@chromium.org>
1159
1160         Reviewed by Yury Semikhatsky.
1161
1162         Web Inspector: implement inspector session storage.
1163         https://bugs.webkit.org/show_bug.cgi?id=56643
1164
1165         * WebCoreSupport/WebInspectorClient.h:
1166         * WebCoreSupport/WebInspectorClient.mm:
1167         (WebInspectorClient::saveSessionSetting):
1168         (WebInspectorClient::loadSessionSetting):
1169         (WebInspectorFrontendClient::saveSessionSetting):
1170         (WebInspectorFrontendClient::loadSessionSetting):
1171         (-[WebInspectorWindowController inspectorClient]):
1172
1173 2011-03-17  Geoffrey Garen  <ggaren@apple.com>
1174
1175         Reviewed by Oliver Hunt.
1176
1177         Fixed a leak seen on the buildbot.
1178
1179         * WebCoreSupport/WebInspectorClient.mm:
1180         (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
1181
1182 2011-03-16  Jeff Johnson  <github@lapcatsoftware.com>
1183
1184         Reviewed by Alexey Proskuryakov.
1185
1186         Logic error in -[WebHTMLView close]
1187         https://bugs.webkit.org/show_bug.cgi?id=56445
1188
1189         Page is always nil at this point, because [self _webView] is nil,
1190         so the conditional code is never run.
1191
1192         * WebView/WebHTMLView.mm:
1193         (-[WebHTMLView close]):
1194
1195 2011-03-16  Chris Fleizach  <cfleizach@apple.com>
1196
1197         Reviewed by Darin Adler.
1198
1199         WK2: Need to propagate enhanced accessibility flag from UI -> web process
1200         https://bugs.webkit.org/show_bug.cgi?id=56379
1201
1202         * WebView/WebFrame.mm:
1203         (-[WebFrame accessibilityRoot]):
1204
1205 2011-03-15  Oliver Hunt  <oliver@apple.com>
1206
1207         Reviewed by Geoffrey Garen.
1208
1209         Make Structure creation require a JSGlobalData
1210         https://bugs.webkit.org/show_bug.cgi?id=56438
1211
1212         Mechanical change to make all Structure creation use a JSGlobalData&
1213
1214         * Plugins/Hosted/ProxyInstance.mm:
1215         (WebKit::ProxyRuntimeMethod::createStructure):
1216         * Plugins/Hosted/ProxyRuntimeObject.h:
1217         (WebKit::ProxyRuntimeObject::createStructure):
1218
1219 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
1220
1221         Forgot to save a modification to this file when committing.
1222
1223         * WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
1224
1225 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
1226
1227         Reviewed by Darin Adler.
1228
1229         REGRESSION (WebKit2): keygen element doesn't work
1230         https://bugs.webkit.org/show_bug.cgi?id=56402
1231         <rdar://problem/9006545>
1232
1233         * WebCoreSupport/WebKeyGenerator.h:
1234         * WebCoreSupport/WebKeyGenerator.m: Removed.
1235         * WebCoreSupport/WebKeyGenerator.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.m.
1236         (+[WebKeyGenerator sharedGenerator]):
1237         (toWebCertificateParseResult):
1238         WebCore no longer needs WebKeyGenerator. Safari still does need a part of it, so keeping
1239         this misnamed and misplaced code for now.
1240
1241         * WebCoreSupport/WebPlatformStrategies.h:
1242         * WebCoreSupport/WebPlatformStrategies.mm:
1243         (WebPlatformStrategies::keygenMenuItem512):
1244         (WebPlatformStrategies::keygenMenuItem1024):
1245         (WebPlatformStrategies::keygenMenuItem2048):
1246         (WebPlatformStrategies::keygenKeychainItemName):
1247         Added strings used by keygen.
1248
1249         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WebCore
1250         pointer to a function used by keygen.
1251
1252         * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): WebKeyGenerator can be lazily
1253         initialized now.
1254
1255 2011-03-15  Beth Dakin  <bdakin@apple.com>
1256
1257         Reviewed by Simon Fraser.
1258
1259         WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
1260
1261         New WebKitystemInterface function to force the scrollbars to flash
1262         * WebCoreSupport/WebSystemInterface.mm:
1263         (InitWebCoreSystemInterface):
1264
1265 2011-03-15  Ilya Sherman  <isherman@chromium.org>
1266
1267         Reviewed by Tony Chang.
1268
1269         Autofilled form elements are assigned fixed background color but not text color
1270         https://bugs.webkit.org/show_bug.cgi?id=48382
1271
1272         * DOM/WebDOMOperations.mm:
1273         (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
1274         * DOM/WebDOMOperationsPrivate.h:
1275
1276 2011-03-15  Adam Roben  <aroben@apple.com>
1277
1278         Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin
1279
1280         Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in
1281         WebStorageTrackerClient::dispatchDidModifyOrigin
1282
1283         Reviewed by Antti Koivisto.
1284
1285         * Storage/WebStorageTrackerClient.mm:
1286         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed
1287         to us by dispatchDidModifyOrigin.
1288         (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an
1289         unnecessary cast.
1290
1291 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1292
1293         Reviewed by Darin Adler.
1294
1295         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
1296         info into the headers rather than in export symbol definition files, but disable it on 
1297         all platforms initially so we can deal with port build issues one port at a time.
1298         
1299         https://bugs.webkit.org/show_bug.cgi?id=27551
1300
1301         * WebKitPrefix.h:
1302
1303 2011-03-14  Brady Eidson  <beidson@apple.com>
1304
1305         Reviewed by Anders Carlsson.
1306
1307         https://bugs.webkit.org/show_bug.cgi?id=56320
1308         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
1309
1310         * History/WebHistoryItem.mm:
1311         (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.
1312
1313 2011-03-13  Pratik Solanki  <psolanki@apple.com>
1314
1315         Reviewed by Brady Eidson.
1316
1317         Make adjustMIMETypeIfNecessary use CFNetwork directly
1318         https://bugs.webkit.org/show_bug.cgi?id=55912
1319
1320         * WebCoreSupport/WebSystemInterface.mm:
1321         (InitWebCoreSystemInterface): Support for new WKSI functions.
1322
1323 2011-03-12  Mark Rowe  <mrowe@apple.com>
1324
1325         Fix the 32-bit build.
1326
1327         * Carbon/CarbonWindowAdapter.mm:
1328         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
1329         (-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
1330
1331 2011-03-11  Brady Eidson  <beidson@apple.com>
1332
1333         Reviewed by Anders Carlsson
1334
1335         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
1336         Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
1337
1338         * Misc/WebIconDatabase.mm:
1339         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
1340         (-[WebIconDatabase _startUpIconDatabase]): Ditto.
1341         (importToWebCoreFormat):
1342
1343 2011-03-11  Anton D'Auria  <adauria@apple.com>
1344
1345         Reviewed and landed by Brady Eidson.
1346
1347         https://bugs.webkit.org/show_bug.cgi?id=51878
1348         Add WebKit1 API to view and delete local storage
1349
1350         * Storage/WebStorageManager.mm: Added.
1351         (+[WebStorageManager sharedWebStorageManager]):
1352         (-[WebStorageManager origins]):
1353         (-[WebStorageManager deleteAllOrigins]):
1354         (-[WebStorageManager deleteOrigin:]):
1355         (-[WebStorageManager syncLocalStorage]):
1356         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
1357         (storageDirectoryPath):
1358         (WebKitInitializeStorageIfNecessary):
1359         * Storage/WebStorageManagerInternal.h: Added.
1360         * Storage/WebStorageManagerPrivate.h: Added.
1361         * Storage/WebStorageTrackerClient.h: Added.
1362         * Storage/WebStorageTrackerClient.mm: Added.
1363         (WebStorageTrackerClient::sharedWebStorageTrackerClient):
1364         (WebStorageTrackerClient::WebStorageTrackerClient):
1365         (WebStorageTrackerClient::~WebStorageTrackerClient):
1366         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
1367         (WebStorageTrackerClient::dispatchDidModifyOrigin):
1368         * WebCoreSupport/WebSecurityOrigin.mm:
1369         (-[WebSecurityOrigin protocol]):
1370         (-[WebSecurityOrigin host]):
1371         (-[WebSecurityOrigin databaseIdentifier]):
1372         (-[WebSecurityOrigin domain]):
1373         (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
1374         * WebCoreSupport/WebSecurityOriginPrivate.h:
1375         * WebKit.exp:
1376         * WebView/WebView.mm:
1377         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1378
1379 2011-03-10  Anders Carlsson  <andersca@apple.com>
1380
1381         Reviewed by Sam Weinig.
1382
1383         <rdar://problem/9117047>
1384         Don't paint more than 60 times per second even when scrolling
1385
1386         * WebView/WebClipView.mm:
1387         (-[WebClipView _immediateScrollToPoint:]):
1388
1389 2011-03-09  Matthew Delaney  <mdelaney@apple.com>
1390
1391         Reviewed by Simon Fraser.
1392
1393         Plumb through settings for accelerated drawing for canvas
1394         https://bugs.webkit.org/show_bug.cgi?id=56039
1395
1396         * WebView/WebPreferenceKeysPrivate.h:
1397         * WebView/WebPreferences.mm:
1398         * WebView/WebPreferencesPrivate.h:
1399
1400 2011-03-10  Ryosuke Niwa  <rniwa@webkit.org>
1401
1402         Reviewed by Tony Chang.
1403
1404         VisiblePosition's next and previous should take an enum instead of a boolean
1405         https://bugs.webkit.org/show_bug.cgi?id=56135
1406
1407         SelectionController::isAll now takes EditingBoundaryCrossingRule instead of
1408         StayInEditableContent.
1409
1410         * WebView/WebView.mm:
1411         (-[WebView _selectionIsAll]):
1412
1413 2011-03-09  Jessie Berlin  <jberlin@apple.com>
1414
1415         Reviewed by Adam Roben.
1416
1417         Use the Cookie Storage from the Private Browsing Storage Session directly
1418         https://bugs.webkit.org/show_bug.cgi?id=55986
1419
1420         * WebCoreSupport/WebSystemInterface.mm:
1421         (InitWebCoreSystemInterface):
1422
1423 2011-03-08  Darin Adler  <darin@apple.com>
1424
1425         Reviewed by Timothy Hatcher.
1426
1427         Promote a method used outside WebKit from internal to private
1428         https://bugs.webkit.org/show_bug.cgi?id=55949
1429
1430         * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
1431         Minor tweak, not directly related to the rest of this patch.
1432
1433         * WebView/WebFrame.mm:
1434         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
1435         this method from the internal category into the private category.
1436         Streamlined the code a bit.
1437
1438         * WebView/WebFrameInternal.h: Removed _computePageRects method.
1439         * WebView/WebFramePrivate.h: Added _computePageRects method.
1440
1441 2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
1442
1443         Reviewed by Darin Adler.
1444
1445         selectionHasStyle and selectionStartHasStyle should use EditingStyle
1446         https://bugs.webkit.org/show_bug.cgi?id=55902
1447
1448         selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
1449
1450         * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
1451         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
1452
1453 2011-03-07  Dan Bernstein  <mitz@apple.com>
1454
1455         LLVM Compiler build fix.
1456
1457         * WebCoreSupport/WebEditorClient.mm:
1458         (WebEditorClient::checkGrammarOfString):
1459
1460 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
1461
1462         Reviewed by Beth Dakin.
1463
1464         AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
1465         https://bugs.webkit.org/show_bug.cgi?id=55706
1466
1467         Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
1468         returns the scroll bar objects).
1469         Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
1470         will expect that as its child, instead of the WebCore ScrollView object.
1471
1472         * WebView/WebDynamicScrollBarsView.mm:
1473         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
1474         * WebView/WebFrame.mm:
1475         (-[WebFrame accessibilityRoot]):
1476
1477 2011-03-07  Sam Weinig  <sam@webkit.org>
1478
1479         Reviewed by Anders Carlsson.
1480
1481         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
1482         https://bugs.webkit.org/show_bug.cgi?id=55827
1483
1484         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
1485         and pass the entire response, instead of just the MIMEType.
1486
1487         * WebCoreSupport/WebFrameLoaderClient.h:
1488         * WebCoreSupport/WebFrameLoaderClient.mm:
1489         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1490
1491 2011-03-06  Dan Bernstein  <mitz@apple.com>
1492
1493         LLVM Compiler build fix.
1494
1495         * DOM/WebDOMOperations.mm:
1496         (-[DOMHTMLInputElement _setValueForUser:]):
1497
1498 2011-03-06  Jessie Berlin  <jberlin@apple.com>
1499
1500         Reviewed by Sam Weinig.
1501
1502         WebKit2: Use CFNetwork Sessions API.
1503         https://bugs.webkit.org/show_bug.cgi?id=55435.
1504
1505         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
1506         Private Browsing Storage Session.
1507
1508         * WebCoreSupport/WebSystemInterface.mm:
1509         (InitWebCoreSystemInterface):
1510         Add support for using the new WKSI functions in WebCore.
1511
1512 2011-03-05  Ilya Sherman  <isherman@chromium.org>
1513
1514         Reviewed by Darin Adler.
1515
1516         HTMLInputElement::setValue() should schedule change event when the element is focused
1517         In service of https://code.google.com/p/chromium/issues/detail?id=42716
1518         https://bugs.webkit.org/show_bug.cgi?id=53160
1519
1520         * DOM/WebDOMOperations.mm:
1521         (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
1522         * DOM/WebDOMOperationsPrivate.h:
1523         * WebView/WebViewInternal.h:
1524
1525 2011-03-04  Jia Pu  <jpu@apple.com>
1526
1527         Reviewed by Darin Adler.
1528
1529         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
1530         https://bugs.webkit.org/show_bug.cgi?id=55717
1531         <rdar://problem/9018127>
1532
1533         With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
1534         is already in window coordinate. We don't need to do further conversion anymore.
1535
1536         * WebCoreSupport/WebEditorClient.mm:
1537         (WebEditorClient::showCorrectionPanel):
1538
1539 2011-03-04  Jessie Berlin  <jberlin@apple.com>
1540
1541         Reviewed by Maciej Stachowiak.
1542
1543         WebKit2: Use CFNetwork Sessions API.
1544         https://bugs.webkit.org/show_bug.cgi?id=55435.
1545
1546         When Private Browsing is enabled, get the cached url response from the cache associated with
1547         the Private Browsing Storage Session.
1548
1549         * WebView/WebView.mm:
1550         (-[WebView _cachedResponseForURL:]):
1551
1552 2011-03-03  Anders Carlsson  <andersca@apple.com>
1553
1554         Reviewed by Sam Weinig.
1555
1556         Get rid of Page::globalHistoryItem
1557         https://bugs.webkit.org/show_bug.cgi?id=55738
1558
1559         * WebCoreSupport/WebFrameLoaderClient.h:
1560         * WebCoreSupport/WebFrameLoaderClient.mm:
1561         (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
1562         Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
1563     
1564         * WebView/WebView.mm:
1565         (-[WebView _globalHistoryItem]):
1566         (-[WebView _setGlobalHistoryItem:]):
1567         Set _globalHistoryItem ivar.
1568
1569         * WebView/WebViewData.h:
1570         * WebView/WebViewData.mm:
1571         Add _globalHistoryItem ivar.
1572
1573 2011-03-03  Brady Eidson  <beidson@apple.com>
1574
1575         Reviewed by Darin Adler.
1576
1577         https://bugs.webkit.org/show_bug.cgi?id=55721
1578         Global IconDatabase should be returned by reference, not as a pointer
1579
1580         * Misc/WebCoreStatistics.mm:
1581         (+[WebCoreStatistics iconPageURLMappingCount]):
1582         (+[WebCoreStatistics iconRetainedPageURLCount]):
1583         (+[WebCoreStatistics iconRecordCount]):
1584         (+[WebCoreStatistics iconsWithDataCount]):
1585         * Misc/WebIconDatabase.mm:
1586         (-[WebIconDatabase init]):
1587         (-[WebIconDatabase iconForURL:withSize:cache:]):
1588         (-[WebIconDatabase iconURLForURL:]):
1589         (-[WebIconDatabase defaultIconWithSize:]):
1590         (-[WebIconDatabase retainIconForURL:]):
1591         (-[WebIconDatabase releaseIconForURL:]):
1592         (-[WebIconDatabase isEnabled]):
1593         (-[WebIconDatabase setEnabled:]):
1594         (-[WebIconDatabase removeAllIcons]):
1595         (+[WebIconDatabase _checkIntegrityBeforeOpening]):
1596         (-[WebIconDatabase _startUpIconDatabase]):
1597         (-[WebIconDatabase _applicationWillTerminate:]):
1598         (-[WebIconDatabase _resetCachedWebPreferences:]):
1599         (importToWebCoreFormat):
1600         * WebView/WebView.mm:
1601         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
1602
1603 2011-03-03  Jessie Berlin  <jberlin@apple.com>
1604
1605         Reviewed by Adam Roben.
1606
1607         WebKit2: Use CFNetwork Sessions API.
1608         https://bugs.webkit.org/show_bug.cgi?id=55435.
1609
1610         Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
1611
1612         * WebCoreSupport/WebSystemInterface.mm:
1613         (InitWebCoreSystemInterface):
1614         Support using WKCopyRequestWithStorageSession in WebCore.
1615
1616 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
1617
1618         Reviewed by Darin Adler.
1619
1620         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
1621         https://bugs.webkit.org/show_bug.cgi?id=55633
1622         <rdar://problem/8963023>
1623
1624         * WebCoreSupport/WebChromeClient.h:
1625         * WebCoreSupport/WebChromeClient.mm:
1626         Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode().
1627
1628         * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1629         Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't
1630         require both bits to be set. The rest of the comment might be wrong too, but I'm not sure,
1631         so I've preserved it.
1632
1633 2011-03-02  Jessie Berlin  <jberlin@apple.com>
1634
1635         Rubber-stamped by Dan Bernstein.
1636
1637         Fix crashes in private browsing tests in WK1 on Snow Leopard.
1638
1639         * WebCoreSupport/WebSystemInterface.mm:
1640         (InitWebCoreSystemInterface):
1641         Put the INIT call for wkCreatePrivateStorageSession outside of the
1642         #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
1643         guards.
1644
1645 2011-03-02  Jessie Berlin  <jberlin@apple.com>
1646
1647         Reviewed by Adam Roben.
1648
1649         WebKit2: Use CFNetwork Sessions API.
1650         https://bugs.webkit.org/show_bug.cgi?id=55435.
1651
1652         Add the ability to create a Private Browsing Storage Session.
1653
1654         * WebCoreSupport/WebSystemInterface.mm:
1655         (InitWebCoreSystemInterface):
1656         Support calling wkCreatePrivateStorageSession from WebCore.
1657
1658 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
1659
1660         Reviewed by David Levin.
1661
1662         Add feature define for data transfer items
1663         https://bugs.webkit.org/show_bug.cgi?id=55510
1664
1665         * Configurations/FeatureDefines.xcconfig:
1666
1667 2011-03-02  Sam Weinig  <sam@webkit.org>
1668
1669         Reviewed by Anders Carlsson.
1670
1671         Fix remaining localization issues by piping all localized strings through WebCore's
1672         localization bottleneck.
1673         <rdar://problem/8728860>
1674
1675         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1676         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
1677         * Misc/WebKitErrors.m:
1678         * Misc/WebLocalizableStringsInternal.h: Added.
1679         * Misc/WebLocalizableStringsInternal.mm: Added.
1680         (WebLocalizedStringInternal):
1681         * Panels/WebAuthenticationPanel.m:
1682         (-[WebAuthenticationPanel setUpForChallenge:]):
1683         * Plugins/Hosted/NetscapePluginHostManager.mm:
1684         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1685         * WebCoreSupport/WebEditorClient.mm:
1686         (undoNameForEditAction):
1687         * WebCoreSupport/WebInspectorClient.mm:
1688         (WebInspectorFrontendClient::updateWindowTitle):
1689         (-[WebInspectorWindowController validateUserInterfaceItem:]):
1690         * WebCoreSupport/WebKeyGenerator.m:
1691         (-[WebKeyGenerator strengthMenuItemTitles]):
1692         (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
1693         * WebCoreSupport/WebPlatformStrategies.mm:
1694         * WebView/WebHTMLView.mm:
1695         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1696         * WebView/WebPDFView.mm:
1697         (-[WebPDFView menuForEvent:]):
1698
1699 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
1700
1701         Reviewed by Adam Roben.
1702
1703         Part of WebKit2: Need a way to send notifications to client when cookies change
1704         https://bugs.webkit.org/show_bug.cgi?id=55427
1705         <rdar://problem/9056027>
1706         
1707         Add stubs for CookiesStrategy on Mac WebKit1.
1708
1709         * WebCoreSupport/WebPlatformStrategies.h:
1710         * WebCoreSupport/WebPlatformStrategies.mm:
1711         (WebPlatformStrategies::createCookiesStrategy):
1712         (WebPlatformStrategies::notifyCookiesChanged):
1713
1714 2011-03-01  Philippe Normand  <pnormand@igalia.com>
1715
1716         Reviewed by Eric Carlson.
1717
1718         [GStreamer] support in mac video fullscreen controller
1719         https://bugs.webkit.org/show_bug.cgi?id=52280
1720
1721         Factored the code to configure the video overlay in a new private
1722         method of the controller and added GStreamer support to it.
1723
1724         * WebView/WebVideoFullscreenController.h:
1725         * WebView/WebVideoFullscreenController.mm:
1726         (-[WebVideoFullscreenController setupVideoOverlay:]):
1727         (-[WebVideoFullscreenController windowDidLoad]):
1728         (-[WebVideoFullscreenController setMediaElement:WebCore::]):
1729         (-[WebVideoFullscreenController windowDidExitFullscreen]):
1730
1731 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
1732
1733         Reviewed by Timothy Hatcher.
1734
1735         All Console Messages should be passed to ChromeClients.
1736         https://bugs.webkit.org/show_bug.cgi?id=54926
1737
1738         Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
1739         which supersedes -webView:addMessageToConsole if it exists. The new delegate
1740         does not filter to only JavaScript originated console messages. The old
1741         delegate is left around for clients that expect filtered messages, like
1742         DashCode and older versions of Safari.
1743
1744         The dictionary message passed to the delegate now includes more information
1745         about the message source, type, and level.
1746
1747         * WebCoreSupport/WebChromeClient.mm:
1748         (stringForMessageSource):
1749         (stringForMessageType):
1750         (stringForMessageLevel):
1751         (WebChromeClient::addMessageToConsole):
1752         * WebView/WebUIDelegatePrivate.h:
1753
1754 2011-03-01  Levi Weintraub  <leviw@chromium.org>
1755
1756         Reviewed by Ryosuke Niwa.
1757
1758         Stop instantiating legacy editing Positions in VisiblePosition
1759         https://bugs.webkit.org/show_bug.cgi?id=52919
1760
1761         Changing usage of legacy VisiblePosition constructor. Since we were dealing
1762         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
1763
1764         * WebView/WebFrame.mm:
1765         (-[WebFrame _caretRectAtPosition:affinity:]):
1766         * WebView/WebFrameInternal.h:
1767         * WebView/WebTextCompletionController.mm:
1768         (-[WebTextCompletionController doCompletion]):
1769
1770 2011-03-01  Sam Weinig  <sam@webkit.org>
1771
1772         Reviewed by Timothy Hatcher.
1773
1774         WebKit2 needs to be made localizable
1775         https://bugs.webkit.org/show_bug.cgi?id=55483
1776
1777         * WebCoreSupport/WebPlatformStrategies.mm:
1778         Use WebCore's localizedString function instead of WebLocalizableStrings
1779         since WebCore is now responsible for localization.
1780
1781 2011-02-25 Steve Block <steveblock@google.com>
1782
1783         Reviewed by Jeremy Orlow.
1784
1785         Bridge.h should not include BridgeJSC.h
1786         https://bugs.webkit.org/show_bug.cgi?id=55212
1787
1788         Include BridgeJSC.h directly instead.
1789
1790         * Plugins/Hosted/ProxyInstance.h:
1791         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1792
1793 2011-02-28  Chang Shu  <cshu@webkit.org>
1794
1795         Reviewed by Ryosuke Niwa.
1796
1797         Remove the support of Frame::isContentEditable and its dependencies.
1798         https://bugs.webkit.org/show_bug.cgi?id=54292
1799
1800         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
1801
1802         * WebCoreSupport/WebEditorClient.h:
1803         * WebCoreSupport/WebEditorClient.mm:
1804         * WebView/WebView.mm:
1805         (-[WebView setEditable:]):
1806         (-[WebView isEditable]):
1807         * WebView/WebViewData.h:
1808
1809 2011-02-28  Oliver Hunt  <oliver@apple.com>
1810
1811         Reviewed by Gavin Barraclough.
1812
1813         Make ScopeChainNode GC allocated
1814         https://bugs.webkit.org/show_bug.cgi?id=55283
1815
1816         More updates for the absence of the ScopeChain class
1817
1818         * WebView/WebScriptDebugDelegate.mm:
1819         (-[WebScriptCallFrame scopeChain]):
1820
1821 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
1822
1823         Reviewed by Pavel Feldman.
1824
1825         DumpRenderTree should reset frame opener between tests.
1826         https://bugs.webkit.org/show_bug.cgi?id=54874
1827
1828         Added clearOpener method to WebFramePrivate.
1829
1830         * WebView/WebFrame.mm:
1831         (-[WebFrame _clearOpener]):
1832         * WebView/WebFramePrivate.h:
1833
1834 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1835
1836         Unreviewed, rolling out r79764.
1837         http://trac.webkit.org/changeset/79764
1838         https://bugs.webkit.org/show_bug.cgi?id=55295
1839
1840         "broke Chromium builds" (Requested by rniwa on #webkit).
1841
1842         * WebView/WebFrame.mm:
1843         * WebView/WebFramePrivate.h:
1844
1845 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
1846
1847         Reviewed by David Kilzer.
1848
1849         https://bugs.webkit.org/show_bug.cgi?id=48781
1850
1851         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
1852
1853         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
1854         should paint the default broken image when an image fails to load or decode.  The method also passes the
1855         URL of the failed image.
1856
1857         * WebCoreSupport/WebFrameLoaderClient.h:
1858         * WebCoreSupport/WebFrameLoaderClient.mm:
1859         (WebFrameLoaderClient::shouldPaintBrokenImage):
1860         * WebView/WebDelegateImplementationCaching.h:
1861         * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
1862         (CallResourceLoadDelegateReturningBoolean):
1863         * WebView/WebResourceLoadDelegatePrivate.h:
1864         * WebView/WebView.mm:
1865         (-[WebView _cacheResourceLoadDelegateImplementations]):
1866
1867 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
1868
1869         Reviewed by Pavel Feldman.
1870
1871         DumpRenderTree should reset frame opener between tests.
1872         https://bugs.webkit.org/show_bug.cgi?id=54874
1873
1874         Added clearOpener method to WebFramePrivate.
1875
1876         * WebView/WebFrame.mm:
1877         (-[WebFrame _clearOpener]):
1878         * WebView/WebFramePrivate.h:
1879
1880 2011-02-25  Mark Rowe  <mrowe@apple.com>
1881
1882         <rdar://problem/8902546> Build fix.
1883
1884         * Misc/QuickDrawCompatibility.h:
1885
1886 2011-02-24  Anders Carlsson  <andersca@apple.com>
1887
1888         Fix clang build.
1889
1890         * WebCoreSupport/WebKeyGenerator.m:
1891         (toWebCertificateParseResult):
1892         (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
1893         * WebView/WebTextCompletionController.mm:
1894
1895 2011-02-24  Peter Kasting  <pkasting@google.com>
1896
1897         Reviewed by Eric Seidel.
1898
1899         Drop the "U; " encryption level from the User Agent string.
1900         https://bugs.webkit.org/show_bug.cgi?id=54566
1901
1902         * WebView/WebView.mm:
1903         (+[WebView _standardUserAgentWithApplicationName:]):
1904
1905 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
1906
1907         Unreviewed, rolling out r79570.
1908         http://trac.webkit.org/changeset/79570
1909         https://bugs.webkit.org/show_bug.cgi?id=54874
1910
1911         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
1912         was not updated
1913
1914         * WebView/WebFrame.mm:
1915         * WebView/WebFramePrivate.h:
1916
1917 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
1918
1919         Reviewed by Alexey Proskuryakov.
1920
1921         DumpRenderTree should reset frame opener between tests.
1922         https://bugs.webkit.org/show_bug.cgi?id=54874
1923
1924         Added clearOpener method to WebFramePrivate.
1925
1926         * WebView/WebFrame.mm:
1927         (-[WebFrame _clearOpener]):
1928         * WebView/WebFramePrivate.h:
1929
1930 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1931
1932         Reviewed by Alexey Proskuryakov.
1933
1934         Drop the language tag part from the User Agent string
1935         https://bugs.webkit.org/show_bug.cgi?id=54560
1936
1937         * WebView/WebView.mm:
1938         (+[WebView _standardUserAgentWithApplicationName:]): Drop the
1939         language tag part.
1940
1941 2011-02-22  Brady Eidson  <beidson@apple.com>
1942
1943         Reviewed by Anders Carlsson.
1944
1945         Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
1946         API to view and delete Application Cache data by origin.
1947
1948         * WebCoreSupport/WebApplicationCache.mm:
1949         (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
1950
1951 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
1952
1953         Reviewed by Kent Tamura.
1954
1955         Rename Position::node() to Position::deprecatedNode()
1956         https://bugs.webkit.org/show_bug.cgi?id=54622
1957
1958         * WebView/WebFrame.mm:
1959         (-[WebFrame _smartDeleteRangeForProposedRange:]):
1960
1961 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
1962
1963         Reviewed by Kent Tamura.
1964
1965         Rename Position::node() to Position::deprecatedNode()
1966         https://bugs.webkit.org/show_bug.cgi?id=54622
1967         
1968         Done the rename.
1969
1970         * WebView/WebFrame.mm:
1971         (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
1972         use containerNode() and offsetInContainerNode() instead of deprecated member functions.
1973
1974 2011-02-18  Gavin Barraclough  <barraclough@apple.com>
1975
1976         Reviewed by Sam Weinig.
1977
1978         Bug 54786 - Devirtualize JSCell::classInfo()
1979
1980         Instead of making a virtual function call, add a pointer to the ClassInfo
1981         onto Structure.
1982
1983         This removes a virtual function call, and paves the way towards removing all
1984         the createStructure methods, and StructureFlags/AnonymousSlotCount properties
1985         (these should be able to move onto ClassInfo).
1986
1987         Calls to Structure::create must now pass a pointer to the ClassInfo for the
1988         structure. All objects now have a ClassInfo pointer, non-object cell types
1989         still do not.
1990
1991         Changes are most mechanical, involving three steps:
1992             * Remove virtual classInfo() methods.
1993             * Add &s_info parameter to calls to Structure::create.
1994             * Rename ClassInfo static members on classes from 'info' to 's_info',
1995               for consistency.
1996
1997         * Plugins/Hosted/ProxyInstance.mm:
1998         (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
1999         (WebKit::ProxyRuntimeMethod::createStructure):
2000         * Plugins/Hosted/ProxyRuntimeObject.h:
2001         (WebKit::ProxyRuntimeObject::createStructure):
2002         * Plugins/Hosted/ProxyRuntimeObject.mm:
2003         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
2004         * WebView/WebView.mm:
2005         (aeDescFromJSValue):
2006
2007 2011-02-19  Brian Ryner  <bryner@chromium.org>
2008
2009         Reviewed by Adam Barth.
2010
2011         Add missing #include of DocumentLoader.h, needed since the transitive
2012         include through Document.h is removed.
2013         https://bugs.webkit.org/show_bug.cgi?id=50489
2014
2015         * WebView/WebFrame.mm:
2016
2017 2011-02-19  Charlie Reis  <creis@chromium.org>
2018
2019         Reviewed by Mihai Parparita.
2020
2021         Ensure loading has stopped in HistoryController::goToItem
2022         https://bugs.webkit.org/show_bug.cgi?id=54517
2023
2024         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
2025
2026         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
2027
2028         * WebCoreSupport/WebFrameLoaderClient.mm:
2029         (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
2030         * WebCoreSupport/WebFrameLoaderClient.h:
2031
2032 2011-02-16  David Hyatt  <hyatt@apple.com>
2033
2034         Reviewed by Dan Bernstein.
2035
2036         https://bugs.webkit.org/show_bug.cgi?id=54244
2037         
2038         Convert the line box tree to floating point and eliminate font rounding hacks.  This patch removes all of the rounding
2039         hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
2040         
2041         The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
2042         been changed as well.
2043         
2044         In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
2045         
2046         Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
2047         
2048         Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
2049         still have a precise floating point position.
2050
2051         Justification will now allow subpixel positioning to occur as well.  Platforms that don't support subpixel positioning should already
2052         be rounding justification spacing in their font code.
2053
2054         Many layout test results change on Mac, since rounding hacks were used there and are now gone.
2055
2056         * Misc/WebKitNSStringExtras.mm:
2057         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2058         (-[NSString _web_widthWithFont:]):
2059
2060 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
2061
2062         Reviewed by Adam Roben.
2063
2064         HTML5 <details> and <summary>: localized text
2065         https://bugs.webkit.org/show_bug.cgi?id=54260
2066
2067         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
2068         provide the default label to be used by a <details> tag that has no <summary> child.
2069
2070         * WebCoreSupport/WebPlatformStrategies.h:
2071         * WebCoreSupport/WebPlatformStrategies.mm:
2072         (WebPlatformStrategies::defaultDetailsSummaryText):
2073
2074 2011-02-16  Matthew Delaney  <mdelaney@apple.com>
2075
2076         Reviewed by Simon Fraser.
2077
2078         Allow acceleratesDrawing for WebKit2
2079         https://bugs.webkit.org/show_bug.cgi?id=54511
2080
2081         Plumb through preference for accelerated drawing.
2082         
2083         * WebView/WebPreferenceKeysPrivate.h:
2084         * WebView/WebPreferences.mm:
2085         (+[WebPreferences initialize]):
2086         (-[WebPreferences acceleratedDrawingEnabled]):
2087         (-[WebPreferences setAcceleratedDrawingEnabled:]):
2088         * WebView/WebPreferencesPrivate.h:
2089
2090 2011-02-15  David Kilzer  <ddkilzer@apple.com>
2091
2092         <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
2093
2094         Reviewed by Darin Adler.
2095
2096         * WebView/WebDynamicScrollBarsView.h:
2097         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
2098         declaration.
2099         * WebView/WebDynamicScrollBarsView.mm:
2100         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
2101         implementation into correct category.
2102         * WebView/WebDynamicScrollBarsViewInternal.h:
2103         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
2104         declaration.
2105         * WebView/WebHTMLView.mm: Included
2106         WebDynamicScrollBarsViewInternal.h instead of
2107         WebDynamicScrollBarsView.h.
2108
2109 2011-02-14  Oliver Hunt  <oliver@apple.com>
2110
2111         Reviewed by Gavin Barraclough and Geoff Garen.
2112
2113         Refactor handles and weak pointers to become nicer and more automatic
2114         https://bugs.webkit.org/show_bug.cgi?id=54415
2115
2116         Update to use Global<> instead of ProtectedPtr, and refactored slightly
2117         to get global data to places it's needed for when we're assigning to
2118         Global<>s
2119
2120         * ForwardingHeaders/collector/handles/Global.h: Added.
2121         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2122         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2123         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
2124         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
2125         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
2126         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2127         (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
2128         (WebKit::NetscapePluginInstanceProxy::evaluate):
2129         (WebKit::NetscapePluginInstanceProxy::invoke):
2130         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2131         (WebKit::NetscapePluginInstanceProxy::construct):
2132         (WebKit::NetscapePluginInstanceProxy::addValueToArray):
2133         * WebView/WebScriptDebugger.h:
2134         * WebView/WebScriptDebugger.mm:
2135         (WebScriptDebugger::WebScriptDebugger):
2136
2137 2011-02-15  Jia Pu  <jpu@apple.com>
2138
2139         Reviewed by Darin Adler.
2140
2141         Autocorrection should respect undo.
2142         https://bugs.webkit.org/show_bug.cgi?id=52221
2143         <rdar://problem/8663399>
2144
2145         Please see WebCore/ChangeLog for detailed description.
2146
2147         * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
2148
2149         * WebCoreSupport/WebEditorClient.mm:
2150         (WebEditorClient::recordAutocorrectionResponse): Ditto.
2151
2152         * WebView/WebFrame.mm:
2153         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2154              Adopted new signature of ReplaceSelectionCommand::create().
2155
2156 2011-02-15  David Kilzer  <ddkilzer@apple.com>
2157
2158         <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
2159
2160         Reviewed by Darin Adler.
2161
2162         * WebView/WebDynamicScrollBarsView.h:
2163         * WebView/WebDynamicScrollBarsView.mm:
2164         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
2165         -inProgramaticScroll.
2166         * WebView/WebHTMLView.mm:
2167         (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
2168
2169 2011-02-15  Kenneth Russell  <kbr@google.com>
2170
2171         Reviewed by Darin Fisher.
2172
2173         Allow controlling minimum DOMTimer interval on a per-page basis
2174         https://bugs.webkit.org/show_bug.cgi?id=54312
2175
2176         Added needed methods to implement LayoutTestController's new
2177         setMinimumTimerInterval method.
2178
2179         * WebView/WebView.mm:
2180         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2181         (+[WebView _defaultMinimumTimerInterval]):
2182         (-[WebView _setMinimumTimerInterval:]):
2183         * WebView/WebViewPrivate.h:
2184
2185 2011-02-11  Geoffrey Garen  <ggaren@apple.com>
2186
2187         Reviewed by Oliver Hunt.
2188
2189         A little more encapsulation for the heap: Removed CollectorHeapIterator
2190         https://bugs.webkit.org/show_bug.cgi?id=54298
2191
2192         * Misc/WebCoreStatistics.mm:
2193         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
2194         (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
2195
2196 2011-02-10  Nate Chapin  <japhet@chromium.org>
2197
2198         Reviewed by Adam Barth.
2199
2200         Update calls to DocumentWriter.
2201         https://bugs.webkit.org/show_bug.cgi?id=50489
2202
2203         * WebView/WebFrame.mm:
2204         (-[WebFrame _canProvideDocumentSource]):
2205
2206 2011-02-10  Chris Fleizach  <cfleizach@apple.com>
2207
2208         Reviewed by Anders Carlsson.
2209
2210         AX: AX needs to stop using WebCoreViewFactory
2211         https://bugs.webkit.org/show_bug.cgi?id=54153
2212
2213         * WebCoreSupport/WebSystemInterface.mm:
2214         (InitWebCoreSystemInterface):
2215
2216 2011-02-10  Peter Varga  <pvarga@webkit.org>
2217
2218         Reviewed by Csaba Osztrogonác.
2219
2220         Remove PCRE source from trunk
2221         https://bugs.webkit.org/show_bug.cgi?id=54188
2222
2223         * ForwardingHeaders/pcre/pcre.h: Removed.
2224
2225 2011-02-09  Pavel Feldman  <pfeldman@chromium.org>
2226
2227         Reviewed by Yury Semikhatsky.
2228
2229         Web Inspector: follow up on InspectorAgent split -
2230         removing unnecessary methods from InspectorController.
2231         https://bugs.webkit.org/show_bug.cgi?id=54093
2232
2233         * WebInspector/WebInspector.mm:
2234         (-[WebInspector showConsole:]):
2235         (-[WebInspector stopProfilingJavaScript:]):
2236
2237 2011-02-08  Dan Bernstein  <mitz@apple.com>
2238
2239         Reviewed by Jon Honeycutt and Maciej Stachowiak.
2240
2241         <rdar://problem/8959420> Find in Mail no longer cycles around
2242
2243         * WebView/WebHTMLView.mm:
2244         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
2245         the wrap option according to the flag.
2246
2247 2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2248
2249         Unreviewed, rolling out r77980.
2250         http://trac.webkit.org/changeset/77980
2251         https://bugs.webkit.org/show_bug.cgi?id=54043
2252
2253         "Crashes on Windows and Linux..." (Requested by leviw on
2254         #webkit).
2255
2256         * WebView/WebFrame.mm:
2257         (-[WebFrame _caretRectAtNode:offset:affinity:]):
2258         * WebView/WebFrameInternal.h:
2259         * WebView/WebTextCompletionController.mm:
2260         (-[WebTextCompletionController doCompletion]):
2261
2262 2011-02-08  Levi Weintraub  <leviw@chromium.org>
2263
2264         Reviewed by Ryosuke Niwa.
2265
2266         Stop instantiating legacy editing Positions in VisiblePosition
2267         https://bugs.webkit.org/show_bug.cgi?id=52919
2268
2269         Changing usage of legacy VisiblePosition constructor. Since we were dealing
2270         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
2271
2272         * WebView/WebFrame.mm:
2273         (-[WebFrame _caretRectAtPosition:affinity:]):
2274         * WebView/WebFrameInternal.h:
2275         * WebView/WebTextCompletionController.mm:
2276         (-[WebTextCompletionController doCompletion]):
2277
2278 2011-02-08  Adam Barth  <abarth@webkit.org>
2279
2280         Reviewed by Eric Seidel.
2281
2282         Remove orphan code from old parser
2283         https://bugs.webkit.org/show_bug.cgi?id=53984
2284
2285         * WebCoreSupport/WebChromeClient.h:
2286
2287 2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>
2288
2289         Reviewed by Yury Semikhatsky.
2290
2291         Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
2292
2293         https://bugs.webkit.org/show_bug.cgi?id=53169
2294
2295         Minor change enforced by major changes in WebCore/inspector/InspectorController.
2296
2297         * WebInspector/WebInspector.mm:
2298         (-[WebInspector isTimelineProfilingEnabled]):
2299
2300 2011-02-07  Enrica Casucci  <enrica@apple.com>
2301
2302         Reviewed Adam Roben and Darin Adler.
2303
2304         WebKit2: drag and drop support on Windows.
2305         https://bugs.webkit.org/show_bug.cgi?id=52775
2306
2307         Removed createDragImageForLink from DragClient.
2308
2309         * WebCoreSupport/WebDragClient.h:
2310         * WebCoreSupport/WebDragClient.mm:
2311         (WebDragClient::startDrag):
2312
2313 2011-02-03  Yury Semikhatsky  <yurys@chromium.org>
2314
2315         Reviewed by Pavel Feldman.
2316
2317         Web Inspector: remove settings related methods from InspectorClient
2318         https://bugs.webkit.org/show_bug.cgi?id=53686
2319
2320         * WebCoreSupport/WebInspectorClient.h:
2321         * WebCoreSupport/WebInspectorClient.mm:
2322         (WebInspectorClient::openInspectorFrontend):
2323         (WebInspectorFrontendClient::WebInspectorFrontendClient):
2324
2325 2011-02-03  James Kozianski  <koz@chromium.org>
2326
2327         Reviewed by Dimitri Glazkov.
2328
2329         Add navigator.registerProtocolHandler behind a flag.
2330         https://bugs.webkit.org/show_bug.cgi?id=52609
2331
2332         * Configurations/FeatureDefines.xcconfig:
2333
2334 2011-02-03  Adam Langley  <agl@chromium.org>
2335
2336         Reviewed by Adam Barth.
2337
2338         Plumb mixed script URL to FrameLoaderClient
2339         https://bugs.webkit.org/show_bug.cgi?id=52384
2340
2341         Regressions covered by http/tests/security/mixedContent/*
2342
2343         * WebCoreSupport/WebFrameLoaderClient.h:
2344         * WebCoreSupport/WebFrameLoaderClient.mm:
2345         (WebFrameLoaderClient::didRunInsecureContent):
2346
2347 2011-02-03  Beth Dakin  <bdakin@apple.com>
2348
2349         Reviewed by Sam Weinig.
2350
2351         Fix for <rdar://problem/8944544> Ability to animate track
2352         for WKPainter scrollers
2353
2354         * WebCoreSupport/WebSystemInterface.mm:
2355         (InitWebCoreSystemInterface):
2356
2357 2011-02-02  Mark Rowe  <mrowe@apple.com>
2358
2359         Reviewed by Beth Dakin.
2360
2361         <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
2362
2363         * WebCoreSupport/WebSystemInterface.mm:
2364         (InitWebCoreSystemInterface): Add some missing initializers.
2365
2366 2011-02-02  Steve Lacey  <sjl@chromium.org>
2367
2368         Reviewed by Eric Carlson.
2369
2370         Implement basic media statistics on media elements.
2371         https://bugs.webkit.org/show_bug.cgi?id=53322
2372
2373         * Configurations/FeatureDefines.xcconfig:
2374
2375 2011-02-01  Sam Weinig  <sam@webkit.org>
2376
2377         Reviewed by Beth Dakin.
2378
2379         Part 2 for <rdar://problem/8492788>
2380         Adopt WKScrollbarPainterController
2381
2382         Use header detection to define scrollbar painting controller #define.
2383
2384         * WebCoreSupport/WebSystemInterface.mm:
2385         (InitWebCoreSystemInterface):
2386
2387 2011-02-01  David Hyatt  <hyatt@apple.com>
2388
2389         Reviewed by Oliver Hunt.
2390
2391         https://bugs.webkit.org/show_bug.cgi?id=53520
2392         
2393         Remove the physical terminology from IntRect and FloatRect.
2394         
2395         Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
2396         we need to update our terminology to be more accurate.
2397
2398         I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
2399         renaming right() and bottom() to maxX() and maxY().  These terms remain accurate
2400         even for flipped rectangles.
2401
2402         * WebView/WebHTMLView.mm:
2403         (setNeedsDisplayInRect):
2404
2405 2011-02-01  Beth Dakin  <bdakin@apple.com>
2406
2407         Reviewed by Sam Weinig.
2408
2409         Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
2410
2411         * WebCoreSupport/WebSystemInterface.mm:
2412         (InitWebCoreSystemInterface):
2413
2414 2011-02-01  Dave Hyatt  <hyatt@apple.com>
2415
2416         Reviewed by Darin Adler.
2417
2418         https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
2419         with vertical text.
2420
2421         Change printing functions to check writing-mode and properly swap width and height
2422         as needed.
2423
2424         * WebView/WebDynamicScrollBarsView.mm:
2425         (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
2426         * WebView/WebFrame.mm:
2427         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
2428         * WebView/WebFrameInternal.h:
2429         * WebView/WebHTMLView.mm:
2430         (-[WebHTMLView _web_setPrintingModeRecursive]):
2431         (-[WebHTMLView _web_clearPrintingModeRecursive]):
2432         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
2433         (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
2434         (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
2435         (-[WebHTMLView _endPrintMode]):
2436         (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
2437         (-[WebHTMLView _endScreenPaginationMode]):
2438         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
2439         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
2440         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
2441         (-[WebHTMLView _scaleFactorForPrintOperation:]):
2442         (-[WebHTMLView setPageWidthForPrinting:]):
2443         (-[WebHTMLView knowsPageRange:]):
2444
2445 2011-01-31  Oliver Hunt  <oliver@apple.com>
2446
2447         Convert markstack to a slot visitor API
2448         https://bugs.webkit.org/show_bug.cgi?id=53219
2449
2450         rolling r77098, r77099, r77100, r77109, and
2451         r77111 back in, along with a few more Qt fix attempts.
2452
2453         * WebView/WebScriptDebugDelegate.mm:
2454         (-[WebScriptCallFrame scopeChain]):
2455
2456 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
2457
2458         Unreviewed, rolling out r77098, r77099, r77100, r77109, and
2459         r77111.
2460         http://trac.webkit.org/changeset/77098
2461         http://trac.webkit.org/changeset/77099
2462         http://trac.webkit.org/changeset/77100
2463         http://trac.webkit.org/changeset/77109
2464         http://trac.webkit.org/changeset/77111
2465         https://bugs.webkit.org/show_bug.cgi?id=53219
2466
2467         Qt build is broken
2468
2469         * WebView/WebScriptDebugDelegate.mm:
2470         (-[WebScriptCallFrame scopeChain]):
2471
2472 2011-01-30  Oliver Hunt  <oliver@apple.com>
2473
2474         Convert markstack to a slot visitor API
2475         https://bugs.webkit.org/show_bug.cgi?id=53219
2476
2477         rolling r77006 and r77020 back in.
2478
2479         * WebView/WebScriptDebugDelegate.mm:
2480         (-[WebScriptCallFrame scopeChain]):
2481
2482 2011-01-28  Geoffrey Garen  <ggaren@apple.com>
2483
2484         Reviewed by Maciej Stachowiak.
2485
2486         Some more Heap cleanup.
2487         https://bugs.webkit.org/show_bug.cgi?id=53357
2488
2489         Updated for JavaScriptCore changes.
2490
2491         * Misc/WebCoreStatistics.mm:
2492         (+[WebCoreStatistics memoryStatistics]):
2493
2494 2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2495
2496         Unreviewed, rolling out r77006 and r77020.
2497         http://trac.webkit.org/changeset/77006
2498         http://trac.webkit.org/changeset/77020
2499         https://bugs.webkit.org/show_bug.cgi?id=53360
2500
2501         "Broke Windows tests" (Requested by rniwa on #webkit).
2502
2503         * WebView/WebScriptDebugDelegate.mm:
2504         (-[WebScriptCallFrame scopeChain]):
2505
2506 2011-01-27  Oliver Hunt  <oliver@apple.com>
2507
2508         Reviewed by Geoffrey Garen.
2509
2510         Convert markstack to a slot visitor API
2511         https://bugs.webkit.org/show_bug.cgi?id=53219
2512
2513         Update to new marking api
2514
2515         * WebView/WebScriptDebugDelegate.mm:
2516         (-[WebScriptCallFrame scopeChain]):
2517
2518 2011-01-28  Dan Bernstein  <mitz@apple.com>
2519
2520         Reviewed by Sam Weinig.
2521
2522         <select> can't display right-to-left (rtl) languages
2523         https://bugs.webkit.org/show_bug.cgi?id=19785
2524
2525         * WebCoreSupport/WebChromeClient.h:
2526         * WebCoreSupport/WebChromeClient.mm:
2527         (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
2528         (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
2529
2530 2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2531
2532         Unreviewed, rolling out r76891.
2533         http://trac.webkit.org/changeset/76891
2534         https://bugs.webkit.org/show_bug.cgi?id=53280
2535
2536         Makes every layout test crash (Requested by othermaciej on
2537         #webkit).
2538
2539         * Misc/WebIconDatabase.mm:
2540         (-[ThreadEnabler threadEnablingSelector:]):
2541         (importToWebCoreFormat):
2542
2543 2011-01-27  Nate Chapin  <japhet@chromium.org>
2544
2545         Reviewed by Adam Barth.
2546
2547         Use Document::url() instead of FrameLoader::url().
2548         https://bugs.webkit.org/show_bug.cgi?id=41165
2549
2550         * WebView/WebView.mm:
2551         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
2552
2553 2011-01-27  Dan Bernstein  <mitz@apple.com>
2554
2555         Rubber-stamped by Anders Carlsson.
2556
2557         Reverted an accidental change in r76561.
2558
2559         * WebView/WebHTMLView.mm:
2560
2561 2011-01-26  David Kilzer  <ddkilzer@apple.com>
2562
2563         <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
2564         <rdar://problem/8821760>
2565
2566         Reviewed by Antti Koivisto.
2567
2568         * WebCoreSupport/WebSystemInterface.mm:
2569         (InitWebCoreSystemInterface): Added initialization for
2570         GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
2571
2572 2011-01-26  Beth Dakin  <bdakin@apple.com>
2573
2574         Reviewed by Darin Adler.
2575
2576         Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics 
2577         when using WKScrollbars.
2578
2579         * WebCoreSupport/WebSystemInterface.mm:
2580         (InitWebCoreSystemInterface):
2581
2582 2011-01-25  Darin Adler  <darin@apple.com>
2583
2584         Reviewed by Anders Carlsson.
2585
2586         WebKit is using CSBackupSetItemExcluded incorrectly
2587         https://bugs.webkit.org/show_bug.cgi?id=53095
2588         rdar://problem/8790540
2589
2590         * Misc/WebIconDatabase.mm:
2591         (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
2592         It was incorrect, and this responsibility has been moved to WebCore.
2593
2594 2011-01-24  Chris Marrin  <cmarrin@apple.com>
2595
2596         Reviewed by Eric Seidel.
2597
2598         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
2599         https://bugs.webkit.org/show_bug.cgi?id=53041
2600
2601         * Configurations/FeatureDefines.xcconfig:
2602
2603 2011-01-25  Yury Semikhatsky  <yurys@chromium.org>
2604
2605         Reviewed by Pavel Feldman.
2606
2607         Web Inspector: remove "attached" state related methods from InspectorAgent
2608         https://bugs.webkit.org/show_bug.cgi?id=53086
2609
2610         * WebCoreSupport/WebInspectorClient.h:
2611         * WebCoreSupport/WebInspectorClient.mm:
2612         (-[WebInspectorWindowController showWindow:]):
2613         (-[WebInspectorWindowController attach]):
2614         (-[WebInspectorWindowController detach]):
2615
2616 2011-01-23  Dan Bernstein  <mitz@apple.com>
2617
2618         Reviewed by John Sullivan.
2619
2620         <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
2621
2622         * WebCoreSupport/WebChromeClient.mm:
2623         (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
2624
2625 2011-01-22  Alexey Proskuryakov  <ap@apple.com>
2626
2627         Reviewed by Darin Adler.
2628
2629         https://bugs.webkit.org/show_bug.cgi?id=52473
2630         Auto-scaling to avoid orphans is broken, remove dysfunctional code
2631
2632         * WebView/WebHTMLView.mm:
2633         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
2634         (-[WebHTMLView _scaleFactorForPrintOperation:]):
2635         (-[WebHTMLView knowsPageRange:]):
2636
2637 2011-01-21  Mark Rowe  <mrowe@apple.com>
2638
2639         Rubber-stamped by Jon Honeycutt.
2640
2641         Fix the build when using Clang by removing some unused variables.
2642
2643         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2644         (-[WebHostedNetscapePluginView updateAndSetWindow]):
2645         * WebView/WebFullScreenController.mm:
2646         (-[WebFullScreenController enterFullscreen:]):
2647         (-[WebFullScreenController exitFullscreen]):
2648
2649 2011-01-21  Chris Rogers  <crogers@google.com>
2650
2651         Reviewed by Darin Fisher.
2652
2653         Add run-time enable support for the web audio API
2654         https://bugs.webkit.org/show_bug.cgi?id=52741
2655
2656         * WebView/WebPreferenceKeysPrivate.h:
2657         * WebView/WebPreferences.mm:
2658         (-[WebPreferences webAudioEnabled]):
2659         (-[WebPreferences setWebAudioEnabled:]):
2660         * WebView/WebPreferencesPrivate.h:
2661         * WebView/WebView.mm:
2662         (-[WebView _preferencesChangedNotification:]):
2663
2664 2011-01-20  John Sullivan  <sullivan@apple.com>
2665
2666         Reviewed by Mark Rowe.
2667
2668         Shift-tab doesn't cycle through fields in http authentication panel
2669         https://bugs.webkit.org/show_bug.cgi?id=52850
2670
2671         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
2672         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
2673         Re-wired the key loop so that there aren't two views with the same nextKeyView.
2674
2675 2011-01-20  Beth Dakin  <bdakin@apple.com>
2676
2677         Reviewed by Geoffrey Garen.
2678
2679         Fix for <rdar://problem/8890255>
2680
2681         Allow WebKitSystemInterface to draw scrollbars 
2682         when appropriate.
2683         * WebCoreSupport/WebSystemInterface.mm:
2684         (InitWebCoreSystemInterface):
2685
2686 2011-01-19  Simon Fraser  <simon.fraser@apple.com>
2687
2688         Reviewed by Sam Weinig.
2689
2690         GraphicsLayers in subframes can get sync'd multiple times
2691         https://bugs.webkit.org/show_bug.cgi?id=52489
2692
2693         * WebView/WebView.mm:
2694         (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
2695         was renamed to syncCompositingStateIncludingSubframes().
2696
2697 2011-01-19  Darin Adler  <darin@apple.com>
2698
2699         Reviewed by Sam Weinig.
2700
2701         Would like script debugging protocol method to differentiate between caught and uncaught exceptions
2702         https://bugs.webkit.org/show_bug.cgi?id=52104
2703         rdar://problem/8704226
2704
2705         * WebView/WebDelegateImplementationCaching.h:
2706         Fix type of second integer in CallScriptDebugDelegate function overload
2707         to be int to match the actual Objective-C method. Added a new overload
2708         that includes a BOOL in the right place. Added a boolean named
2709         exceptionWasRaisedExpectsHasHandlerFlag.
2710
2711         * WebView/WebDelegateImplementationCaching.mm:
2712         (CallDelegate): Added overloads as above.
2713         (CallScriptDebugDelegate): Ditto.
2714
2715         * WebView/WebScriptDebugDelegate.h: Added new method with the additional
2716         boolean argument. Marked the old method informally deprecated.
2717
2718         * WebView/WebScriptDebugger.mm:
2719         (WebScriptDebugger::exception): Added code to call with or without the
2720         boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
2721
2722         * WebView/WebView.mm:
2723         (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
2724         exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
2725         guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
2726
2727 2011-01-19  Tony Gentilcore  <tonyg@chromium.org>
2728
2729         Reviewed by Mihai Parparita.
2730
2731         Perform some forward declaration
2732         https://bugs.webkit.org/show_bug.cgi?id=52522
2733
2734         * Misc/WebKitNSStringExtras.mm:
2735
2736 2011-01-19  Pavel Podivilov  <podivilov@chromium.org>
2737
2738         Reviewed by Yury Semikhatsky.
2739
2740         Web Inspector: [JSC] scripts have incorrect starting line (always 1).
2741         https://bugs.webkit.org/show_bug.cgi?id=52721
2742
2743         * WebView/WebScriptDebugger.h:
2744         * WebView/WebScriptDebugger.mm:
2745         (toNSString):
2746         (WebScriptDebugger::sourceParsed):
2747
2748 2011-01-19  Levi Weintraub  <leviw@google.com>
2749
2750         Reviewed by Ryosuke Niwa.
2751
2752         Updating to use Position::parentAnchoredEquivalent instead of
2753         the old htmlediting rangeCompliantEquivalent.
2754
2755         remove rangeCompliantEquivalent and replace it with Position methods
2756         https://bugs.webkit.org/show_bug.cgi?id=25057
2757
2758         * WebView/WebFrame.mm:
2759         (-[WebFrame _smartDeleteRangeForProposedRange:]):
2760
2761 2011-01-18  Chris Fleizach  <cfleizach@apple.com>
2762
2763         Reviewed by Darin Adler.
2764
2765         REGRESSION: A problem with Voiceover and finding links
2766         https://bugs.webkit.org/show_bug.cgi?id=52324
2767
2768         * WebView/WebDynamicScrollBarsView.mm:
2769         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
2770
2771 2011-01-17  David Kilzer  <ddkilzer@apple.com>
2772
2773         <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
2774
2775         Reviewed by Dan Bernstein.
2776
2777         * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
2778         DOMDocumentPrivate.h to the PrivateHeaders directory.
2779
2780 2011-01-17  Enrica Casucci  <enrica@apple.com>
2781
2782         Reviewed by Alexey Proskuryakov.
2783
2784         Drag and drop support: refactoring of image from link and image from selection
2785         https://bugs.webkit.org/show_bug.cgi?id=52496
2786
2787         This work cleans up the Mac code and makes it more similar to the Windows implementation,
2788         avoiding the use of an NSView when the FrameView can be used.
2789         The refactoring is a necessary step towards the complete support of drag and drop
2790         in WebKit2.
2791
2792         * WebCoreSupport/WebDragClient.mm:
2793         (WebDragClient::createDragImageForLink): Added.
2794         * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
2795         * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
2796
2797 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
2798
2799         Reviewed by Yury Semikhatsky.
2800
2801         Web Inspector: simplify debugger enabling routine.
2802         https://bugs.webkit.org/show_bug.cgi?id=52472
2803
2804         * WebInspector/WebInspector.mm:
2805         (-[WebInspector startDebuggingJavaScript:]):
2806
2807 2011-01-16  Dan Bernstein  <mitz@apple.com>
2808
2809         Reviewed by Simon Fraser.
2810
2811         Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
2812         https://bugs.webkit.org/show_bug.cgi?id=52550
2813
2814         * Plugins/WebNetscapePluginView.mm:
2815         (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
2816         that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
2817
2818 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
2819
2820         Reviewed by Dan Bernstein.
2821
2822         Issues with iframes and plugins when the WebView is scaled.
2823         <rdar://problem/6213380>
2824         
2825         When _scaleWebView has been called on a WebView, iframes
2826         in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
2827         This is caused by AppKit NSViews not playing nicely with the scale
2828         applied through style.
2829         
2830         Work around most of these issues by adjusting the bounds size
2831         of widgets to allow iframe contents to paint with the correct scale,
2832         and fix various places in the code where we relied on coordinate
2833         transforms via NSViews (which ignore CSS transforms).
2834
2835         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2836         (-[WebHostedNetscapePluginView updateAndSetWindow]):
2837         * WebView/WebFrameView.mm:
2838         (-[WebFrameView setBoundsSize:]):
2839
2840 2011-01-16  Beth Dakin  <bdakin@apple.com>
2841
2842         Reviewed by Kevin Decker.
2843
2844         Fix for <rdar://problem/8871204>
2845
2846         Don't try to save elasticity state. Just rely on
2847         NSScrollElasticityAutomatic to restore the correct state.
2848         * WebCoreSupport/WebFrameLoaderClient.h:
2849         * WebCoreSupport/WebFrameLoaderClient.mm:
2850         (WebFrameLoaderClient::WebFrameLoaderClient):
2851         (WebFrameLoaderClient::dispatchDidFirstLayout):
2852         (WebFrameLoaderClient::provisionalLoadStarted):
2853
2854 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
2855
2856         Reviewed by Dan Bernstein.
2857
2858         Plugins render incorrectly with transformed ancestors
2859         https://bugs.webkit.org/show_bug.cgi?id=52507
2860         
2861         -[NSView visibleRect] gives the wrong answer if there are CSS transforms
2862         in the ancestor chain of a plugin.
2863         
2864         So use of this method with calls to -actualVisibleRectInWindow, which
2865         maps rects through the render tree to compute the correct rect,
2866         clipping via windowClipRect() if necessary.
2867         
2868         Not testable, because doing so relies on the behavior of some
2869         plugins, which stop rendering if setWindow passes an empty rect.
2870
2871         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2872         (-[WebHostedNetscapePluginView updateAndSetWindow]):
2873         * Plugins/WebBaseNetscapePluginView.h:
2874         * Plugins/WebBaseNetscapePluginView.mm:
2875         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
2876         * Plugins/WebNetscapePluginView.mm:
2877         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2878
2879 2011-01-14  Yuzo Fujishima  <yuzo@google.com>
2880
2881         Reviewed by Antti Koivisto.
2882
2883         Rename cache() to memoryCache()
2884         https://bugs.webkit.org/show_bug.cgi?id=52433
2885
2886         * Misc/WebCache.mm:
2887         (+[WebCache statistics]):
2888         (+[WebCache setDisabled:]):
2889         (+[WebCache isDisabled]):
2890         * WebView/WebView.mm:
2891         (+[WebView _setCacheModel:]):
2892
2893 2011-01-13  Geoffrey Garen  <ggaren@apple.com>
2894
2895         Reviewed by Oliver Hunt.
2896
2897         Split out a MarkedSpace strategy object from Heap.
2898         https://bugs.webkit.org/show_bug.cgi?id=52421
2899
2900         * Misc/WebCoreStatistics.mm:
2901         (+[WebCoreStatistics memoryStatistics]): Updated for class move.
2902
2903 2011-01-14  Dan Bernstein  <mitz@apple.com>
2904
2905         Reviewed by Simon Fraser.
2906
2907         WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
2908
2909         * WebView/WebHTMLView.mm:
2910         (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
2911         to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
2912         that the NSView tree doesn’t change from under AppKit as it traverses it.
2913
2914 2011-01-14  Beth Dakin  <bdakin@apple.com>
2915
2916         Reviewed by Mark Rowe.
2917
2918         Fix for <rdar://problem/7793902> Artifacts when scrolling
2919         page in Safari while page is loading
2920
2921         Call setDrawsBackground:YES on the scrollView in 
2922         dispatchDidFirstLayout() rather than waiting until
2923         frameLoadCompleted(). Also suspend scrolling elasticity
2924         between provisionalLoadStarted() and dispatchDidFirstLayout()
2925         * WebCoreSupport/WebFrameLoaderClient.h:
2926         * WebCoreSupport/WebFrameLoaderClient.mm:
2927         (WebFrameLoaderClient::WebFrameLoaderClient):
2928         (WebFrameLoaderClient::dispatchDidFirstLayout):
2929         (WebFrameLoaderClient::provisionalLoadStarted):
2930
2931 2011-01-12  Enrica Casucci  <enrica@apple.com>
2932
2933         Reviewed by Darin Adler.
2934
2935         WebKit2: Add support for drag and drop
2936         https://bugs.webkit.org/show_bug.cgi?id=52343
2937         <rdar://problem/7660558>
2938         
2939         The DragData class has been extended to provide
2940         additional context from the application (keyboard state, modal windows, etc.)
2941         as well as information of the drag pasteboard being used.
2942         These are the changes to align the behavior for WebKit.
2943
2944         * WebView/WebView.mm:
2945         (-[WebView applicationFlags:]): Added.
2946         (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
2947         (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
2948         (-[WebView draggingExited:]): Added parameter to the DragData constructor.
2949         (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
2950
2951 2011-01-12  Beth Dakin  <bdakin@apple.com>
2952
2953         Reviewed by Anders Carlsson.
2954
2955         Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309 
2956         Expose fixed layout through WebKit SPI
2957         -and corresponding-
2958         <rdar://problem/8844464>
2959
2960         And now with getters!
2961         * WebView/WebView.mm:
2962         (-[WebView _useFixedLayout]):
2963         (-[WebView _fixedLayoutSize]):
2964         * WebView/WebViewPrivate.h:
2965
2966 2011-01-12  Beth Dakin  <bdakin@apple.com>
2967
2968         Reviewed by Anders Carlsson.
2969
2970         Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
2971         fixed layout through WebKit SPI
2972         -and corresponding-
2973         <rdar://problem/8844464>
2974
2975         * WebView/WebView.mm:
2976         (-[WebView _setUseFixedLayout:]):
2977         (-[WebView _setFixedLayoutSize:]):
2978         * WebView/WebViewPrivate.h:
2979
2980 2011-01-07  Enrica Casucci  <enrica@apple.com>
2981
2982         Reviewed by Alexey Proskuryakov.
2983
2984         Paste and drag and drop use different code paths to interact with the pasteboard.
2985         https://bugs.webkit.org/show_bug.cgi?id=52093
2986         The change consists in a refactoring of the code to have only one class that
2987         deals with the pasteboard on Mac.
2988
2989         * WebCoreSupport/WebEditorClient.h:
2990         * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
2991         exposed by NSURLExtras.
2992         (WebEditorClient::canonicalizeURL):
2993         (WebEditorClient::canonicalizeURLString):
2994         * WebCoreSupport/WebPasteboardHelper.h: Removed.
2995         * WebCoreSupport/WebPasteboardHelper.mm: Removed.
2996         * WebView/WebHTMLView.mm: Removed comment.
2997         * WebView/WebView.mm: The following methods have been changed to use the new DragData
2998         constructor that doesn't use the WebPasteboardHelper reference.
2999         (-[WebView draggingEntered:]):
3000         (-[WebView draggingUpdated:]):
3001         (-[WebView draggingExited:]):
3002         (-[WebView performDragOperation:]):
3003
3004 2011-01-09  Tony Gentilcore  <tonyg@chromium.org>
3005
3006         Reviewed by Alexey Proskuryakov.
3007
3008         Forward declare some headers where possible
3009         https://bugs.webkit.org/show_bug.cgi?id=52133
3010
3011         * WebView/WebFrame.mm:
3012
3013 2011-01-09  Xianzhu Wang <phnixwxz@gmail.com>
3014
3015         Reviewed by Darin Fisher.
3016
3017         https://bugs.webkit.org/show_bug.cgi?id=41441
3018         createWindow method should only do window-creating without URL navigation
3019
3020         * WebCoreSupport/WebChromeClient.mm:
3021         (WebChromeClient::createWindow):
3022
3023 2011-01-08  Dan Bernstein  <mitz@apple.com>
3024
3025         Try to fix the Leopard build.
3026
3027         * WebView/WebFullScreenController.mm:
3028
3029 2011-01-07  Jer Noble  <jer.noble@apple.com>
3030
3031         Yet another Leopard build fix: NSRect and CGRect are not inter-
3032         changable in 32-bit.  
3033         
3034         * WebView/WebFullScreenController.mm:
3035         (-[WebFullScreenController exitFullscreen]):
3036
3037 2011-01-07  Jer Noble  <jer.noble@apple.com>
3038
3039         Fix the Leopard build: Replace CoreAnimation SL-only functions
3040         with Leopard equivalents.
3041
3042         * WebView/WebFullScreenController.mm:
3043         (+[CATransaction setDisableActions:]):
3044         (+[CATransaction setAnimationDuration:]):
3045         (-[WebFullScreenController _animationDuration]):
3046         (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
3047
3048 2010-12-21  Jer Noble  <jer.noble@apple.com>
3049
3050         Reviewed by Simon Fraser.
3051
3052         Implement WebKit Full Screen support.
3053         https://bugs.webkit.org/show_bug.cgi?id=49481
3054         rdar://problem/8247444
3055
3056         Support the new fullscreen Chrome client requests.  WebView will pass
3057         through these requests to a WebFullscreenController.
3058
3059         * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
3060         * WebView/WebView.mm:
3061         (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
3062         (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
3063         (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
3064         (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
3065         * WebView/WebViewData.h: Add ivar newFullscreenController.
3066
3067 2010-12-17  Jer Noble  <jer@kokode.apple.com>
3068
3069         Reviewed by Simon Fraser.
3070
3071         Implement WebKit Full Screen support.
3072         https://bugs.webkit.org/show_bug.cgi?id=49481
3073         rdar://problem/8247444
3074         
3075         This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
3076         Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
3077         window, and a custom CAAnimation animates that layer between the initial screen rect of the
3078         full screen element, to its final value. WebFullscreenController will swap the WebView out of
3079         its original window, and into the fullscreen window. The controller will replace the WebView
3080         with a placeholder view, so that if the placeholder moves or resized while the WebView is
3081         absent, the WebView will move back to the correct location when exiting fullscreen.
3082
3083         * WebView/WebFullscreenController.h: Added.
3084         * WebView/WebFullscreenController.mm: Added.
3085         (-[WebFullscreenController windowDidExitFullscreen:]):  Close the fullscreen window.
3086         (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window. 
3087         (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
3088         (-[WebFullscreenController applicationDidResignActive:]):
3089         (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
3090             the new screen parameters.
3091         (-[WebFullscreenController enterFullscreen:]):  Set up the animation that will take the fullscreen element
3092             from its original screen rect into fullscreen.
3093         (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
3094             Set up the animation that will take the fullscreen element back into its original screen
3095             rect.
3096         (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine 
3097             whether to disable screensaver and sleep.
3098         (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
3099             looking for HTMLVideoElements; returns whether any are found to be playing.
3100         (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
3101             and shift keys.
3102         (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
3103         (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
3104         (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
3105         (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
3106         (-[WebFullscreenWindow setRendererLayer:]): Ditto.
3107         (-[WebFullscreenWindow backgroundLayer]): Ditto.
3108         (-[WebFullscreenWindow animationView]): Ditto.
3109         (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
3110         (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
3111         
3112 2011-01-07  James Robinson  <jamesr@chromium.org>
3113
3114         Revert "Implement mozilla's animationTime property"
3115         https://bugs.webkit.org/show_bug.cgi?id=51952
3116
3117         This approach isn't quite right.
3118
3119         * WebView/WebHTMLView.mm:
3120         (-[WebHTMLView drawRect:]):
3121         * WebView/WebView.mm:
3122         (layerSyncRunLoopObserverCallBack):
3123
3124 2011-01-06  Gavin Barraclough  <barraclough@apple.com>
3125
3126         Reviewed by Geoff Garen.
3127
3128         Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
3129
3130         The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
3131         destructor early, in order to release wrappers once we know we no longer intend to use them.
3132         Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
3133         lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
3134         A sequence of events that triggers the bug would look like this:
3135
3136         (1) Create a DOMWrapperWorld.
3137         (2) Register a timer in the world.
3138         (3) Call unregisterWorld() on the world.
3139         (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
3140         (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
3141             called forgetWorld() none exists.
3142         (6) Attempt to add a wrapper to a NULL map.
3143
3144         Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
3145
3146         * WebView/WebScriptWorld.mm:
3147         (-[WebScriptWorld unregisterWorld]):
3148
3149 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3150
3151         Reviewed by Sam Weinig.
3152
3153         WK2: Support Accessibility
3154         https://bugs.webkit.org/show_bug.cgi?id=51859
3155
3156         Use rootObject() method to get top of AX tree.
3157
3158         * WebCoreSupport/WebFrameLoaderClient.h:
3159         (WebFrameLoaderClient::accessibilityRemoteObject):
3160         * WebView/WebFrame.mm:
3161         (-[WebFrame setAccessibleName:]):
3162         (-[WebFrame accessibilityRoot]):
3163         * WebView/WebFrameInternal.h:
3164         * WebView/WebFramePrivate.h:
3165         * WebView/WebHTMLView.mm:
3166         (-[WebHTMLView accessibilityAttributeValue:]):
3167         (-[WebHTMLView accessibilityFocusedUIElement]):
3168         (-[WebHTMLView accessibilityHitTest:]):
3169         (-[WebHTMLView _accessibilityParentForSubview:]):
3170
3171 2011-01-04  David Kilzer  <ddkilzer@apple.com>
3172
3173         <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
3174
3175         Reviewed by Eric Carlson.
3176
3177         This originally broke in r61581.  It is inside an
3178         ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
3179         build then.
3180
3181         * WebCoreSupport/WebFrameLoaderClient.mm: Call
3182         (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
3183         use WebCore::PluginInfo.name instead of
3184         -[WebBasePluginPackage name].
3185
3186 2011-01-02  Dan Bernstein  <mitz@apple.com>
3187
3188         Rubber-stamped by Simon Fraser.
3189
3190         <rdar://problem/8812159> Update copyright strings
3191
3192         * Info.plist:
3193
3194 2010-12-29  Dan Bernstein  <mitz@apple.com>
3195
3196         Reviewed by Ada Chan.
3197
3198         <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
3199         https://bugs.webkit.org/show_bug.cgi?id=51717
3200
3201         Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
3202         protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
3203
3204         * WebView/WebDocumentInternal.h:
3205         * WebView/WebHTMLView.mm:
3206         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3207         (-[WebHTMLView _findString:options:]):
3208         * WebView/WebView.mm:
3209         (findString):
3210
3211 2010-12-28  Daniel Bates  <dbates@rim.com>
3212
3213         Reviewed by Sam Weinig.
3214
3215         Substitute // MARK: for compiler-specific #pragma mark
3216         https://bugs.webkit.org/show_bug.cgi?id=51657
3217
3218         For consistency, we should substitute "// MARK:" for compiler-
3219         specific "#pragma mark" in the source files for the Mac port.
3220
3221         * History/WebHistory.mm:
3222         * Plugins/WebBaseNetscapePluginView.mm:
3223         * Plugins/WebNetscapePluginView.mm:
3224         * WebCoreSupport/WebInspectorClient.mm:
3225         * WebCoreSupport/WebSecurityOrigin.mm:
3226         * WebView/WebPDFView.mm:
3227         * WebView/WebVideoFullscreenController.mm:
3228         * WebView/WebVideoFullscreenHUDWindowController.mm:
3229
3230 2010-12-23  Yongjun Zhang  <yongjun_zhang@apple.com>
3231
3232         Reviewed by Darin Adler.
3233
3234         WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
3235         https://bugs.webkit.org/show_bug.cgi?id=38535
3236
3237         WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram.  As a result,
3238         if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
3239         WebScriptDebugger's callframe stack is wrong from this point.  That could cause crash if we trying to access the top
3240         call frame from this stack when an exception throws because the saved top frame could be invalid.
3241
3242         To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
3243         callEvent and returnEvent.
3244
3245         * WebView/WebScriptDebugger.mm:
3246         (WebScriptDebugger::willExecuteProgram):
3247         (WebScriptDebugger::didExecuteProgram):
3248
3249 2010-12-22  Sam Weinig  <sam@webkit.org>
3250
3251         Reviewed by Darin Adler.
3252
3253         WebKit2 needs to mirror the frame tree in the UIProcess
3254         https://bugs.webkit.org/show_bug.cgi?id=51546
3255
3256         - Add client functions to notify that a frame has been added or
3257           removed from the page cache.
3258
3259         * WebCoreSupport/WebFrameLoaderClient.h:
3260         * WebCoreSupport/WebFrameLoaderClient.mm:
3261         (WebFrameLoaderClient::didSaveToPageCache):
3262         (WebFrameLoaderClient::didRestoreFromPageCache):
3263
3264 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3265
3266         Reviewed by Eric Seidel.
3267
3268         Editor.h doesn't need to include SelectionController.h
3269         https://bugs.webkit.org/show_bug.cgi?id=51441
3270
3271         Renamed SelectionController::EDirection to SelectionDirection.
3272
3273         * WebView/WebFrame.mm:
3274         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
3275         Takes SelectionDirection instead of SelectionController::EDirection.
3276         * WebView/WebFrameInternal.h:
3277         * WebView/WebTextCompletionController.mm:
3278         (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
3279
3280 2010-12-22  Simon Fraser  <simon.fraser@apple.com>
3281
3282         Reviewed by Darin Adler.
3283
3284         Cache snapshots of plug-ins before painting, to avoid script running during painting
3285         https://bugs.webkit.org/show_bug.cgi?id=51493
3286
3287         When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
3288         or when printing), plug-ins which otherwise use the CA rendering model
3289         are sent a paint event. Some plug-ins may run script while handling this event,
3290         or out of process plug-ins may process queued requests at this time. Running
3291         script while inside layout or painting can have bad consequences, because it
3292         can result in arbitrary changes to the render tree.
3293         
3294         This patch avoids sending plug-ins paint events inside of painting. Instead,
3295         we ask the plug-ins to cache a snapshot before we paint, and then the software
3296         paint simply draws that snapshot.
3297
3298         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3299         (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
3300         draw it. Also only send the snapshot message to the plugin proxy if we
3301         know we're snapshotting, since even if creating the snapshot image failed,
3302         we still don't want to call to the plug-in.
3303
3304         * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
3305         * Plugins/WebBaseNetscapePluginView.mm:
3306         (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
3307         (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
3308
3309         * Plugins/WebNetscapePluginView.mm:
3310         (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
3311         * WebCoreSupport/WebFrameLoaderClient.mm:
3312         (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
3313         to cache and clear the snapshots.
3314
3315 2010-12-21  Cameron Zwarich  <zwarich@apple.com>
3316
3317         Reviewed by Darin Adler.
3318
3319         -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
3320         https://bugs.webkit.org/show_bug.cgi?id=51431
3321         <rdar://problem/8791757>
3322
3323         * Plugins/WebBasePluginPackage.mm:
3324         (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
3325         it doesn't underflow.
3326
3327 2010-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3328
3329         Reviewed by Cameron Zwarich.
3330
3331         REGRESSION(r74172): 125 java tests fail on Mac
3332         https://bugs.webkit.org/show_bug.cgi?id=51214
3333
3334         The regression was caused by an incorrectly adding sizeof(struct fat_header)
3335         to a pointer for uint32_t as supposed to uint8_t.
3336
3337         Fixed the bug by explicitly casting it to uint8_t* before the addition.
3338
3339         * Plugins/WebBasePluginPackage.mm:
3340         (-[WebBasePluginPackage isNativeLibraryData:]):
3341
3342 2010-12-15  Cameron Zwarich  <zwarich@apple.com>
3343
3344         Reviewed by Darin Adler.
3345
3346         Clang -Wcast-align gives an error in WebBasePluginPackage.mm
3347         https://bugs.webkit.org/show_bug.cgi?id=51144
3348
3349         Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
3350         we were calling it on a byte array 32 bits at a time. While this is okay in practice,
3351         since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
3352         inline storage is at the beginning of the Vector, it is still better to fix this
3353         and silence the warning.
3354
3355         * Plugins/WebBasePluginPackage.mm:
3356         (swapIntsInHeader):
3357         (-[WebBasePluginPackage isNativeLibraryData:]):
3358
3359 2010-12-14  Mark Rowe  <mrowe@apple.com>
3360
3361         Reviewed by Sam Weinig.
3362
3363         <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>
3364
3365         * History/WebHistoryItem.mm:
3366         (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
3367         always including the target in the output.
3368
3369 2010-12-13  Alexey Proskuryakov  <ap@apple.com>
3370
3371         Reviewed by Adam Barth.
3372
3373         https://bugs.webkit.org/show_bug.cgi?id=50953
3374         DNS Prefetch should be an opt-in feature
3375
3376         * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false.
3377
3378 2010-12-13  Mike Thole  <mthole@apple.com>
3379
3380         Rubber-stamped by John Sullivan.
3381
3382         https://bugs.webkit.org/show_bug.cgi?id=50956
3383         WebAuthenticationPanel.nib appears to have a cut-off sentence
3384         
3385         Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
3386         The contents of this text field are updated dynamically before the sheet is displayed.
3387
3388         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
3389         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
3390
3391 2010-12-13  Antti Koivisto  <antti@apple.com>
3392
3393         Reviewed by Alexey Proskuryakov.
3394
3395         https://bugs.webkit.org/show_bug.cgi?id=50758
3396         <rdar://problem/8722094> 
3397         Defer loading print stylesheets
3398         
3399         Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.
3400
3401         * WebView/WebView.mm:
3402         (+[WebView _setLoadResourcesSerially:forHost:]):
3403         * WebView/WebViewPrivate.h:
3404
3405 2010-12-09  Matthew Delaney  <mdelaney@apple.com>
3406
3407         Reviewed by Simon Fraser.
3408
3409         Adopt new CG API for canvas
3410         https://bugs.webkit.org/show_bug.cgi?id=50591
3411
3412         * WebCoreSupport/WebSystemInterface.mm:
3413
3414 2010-10-28  MORITA Hajime  <morrita@google.com>
3415
3416         Reviewed by Ojan Vafai.
3417
3418         spellcheck does not check pasted text
3419         https://bugs.webkit.org/show_bug.cgi?id=40092
3420
3421         Added asynchronous spell checking API to WebEditorClient using
3422         -[NSSpellChecker requestCheckingOfString].
3423         Note that WebEditorSpellCheckResponder is a small class to receive
3424         requested spell-checking result. Note that this feature is
3425         disabled at default.
3426         
3427         Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to 
3428         enable the feature from LayoutTestController.
3429
3430         * WebCoreSupport/WebEditorClient.h:
3431         * WebCoreSupport/WebEditorClient.mm:
3432         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
3433         (-[WebEditorSpellCheckResponder perform]):
3434         (toCoreSpellingResult):
3435         (-[WebEditorSpellCheckResponder WTF::WebCore::]):
3436         (WebEditorClient::requestCheckingOfString):
3437         * WebView/WebPreferenceKeysPrivate.h:
3438         * WebView/WebPreferences.mm:
3439         (+[WebPreferences initialize]):
3440         (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
3441         (-[WebPreferences asynchronousSpellCheckingEnabled]):
3442         * WebView/WebPreferencesPrivate.h:
3443         * WebView/WebView.mm:
3444         (-[WebView _preferencesChangedNotification:]):
3445
3446 2010-12-09  Anders Carlsson  <andersca@apple.com>
3447
3448         Fix a bug uncovered by clang++.
3449
3450         * WebView/WebHTMLView.mm:
3451         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3452
3453 2010-12-09  Anders Carlsson  <andersca@apple.com>
3454
3455         Clang++ build fixes.
3456
3457         Silence a couple of warnings.
3458
3459         * WebView/WebFrame.mm:
3460         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
3461         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3462         * WebView/WebTextCompletionController.mm:
3463         (-[WebTextCompletionController filterKeyDown:]):
3464
3465 2010-12-09  David Hyatt  <hyatt@apple.com>
3466
3467         Reviewed by Dan Bernstein.
3468
3469         https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
3470         writing-mode.  This first part of the patch just patches Mac WebKit 1 views.
3471
3472         * WebView/WebFrameView.mm:
3473         (-[WebFrameView _isVerticalDocument]):
3474         (-[WebFrameView _isFlippedDocument]):
3475         (-[WebFrameView _scrollToEndOfDocument]):
3476         (-[WebFrameView _pageInBlockProgressionDirection:]):
3477         (-[WebFrameView scrollPageUp:]):
3478         (-[WebFrameView scrollPageDown:]):
3479
3480 2010-12-08  Andy Estes  <aestes@apple.com>
3481
3482         Reviewed by Darin Adler.
3483
3484         Enable pre-HTML5 parser quirks for Apple Mail.app
3485         https://bugs.webkit.org/show_bug.cgi?id=50727
3486
3487         * WebView/WebView.mm:
3488         (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
3489         application is Mail.app.
3490
3491 2010-12-08  Brian Weinstein  <bweinstein@apple.com>
3492
3493         Reviewed by John Sullivan.
3494
3495         REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
3496         https://bugs.webkit.org/show_bug.cgi?id=50683
3497         
3498         If our context menu item already has an action, don't overwrite the action with the context menu
3499         forwarder.
3500
3501         * WebView/WebHTMLView.mm:
3502         (setMenuItemTarget):
3503
3504 2010-12-08  Anders Carlsson  <andersca@apple.com>
3505
3506         Remove an unused variable.
3507
3508         * WebView/WebDynamicScrollBarsView.mm:
3509         (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
3510
3511 2010-12-07  Brian Weinstein  <bweinstein@apple.com>
3512
3513         Reviewed by John Sullivan.
3514
3515         Layering Violation in ContextMenu - member variable of type HitTestResult
3516         https://bugs.webkit.org/show_bug.cgi?id=50586
3517         
3518         Update users of ContextMenu and ContextMenuController to match where the new functions 
3519         are located.
3520
3521         * WebCoreSupport/WebContextMenuClient.mm:
3522         (WebContextMenuClient::getCustomMenuFromDefaultItems):
3523         (WebContextMenuClient::contextMenuItemSelected):
3524         * WebView/WebHTMLView.mm:
3525         (-[WebMenuTarget validateMenuItem:]):
3526
3527 2010-12-07  Brian Weinstein  <bweinstein@apple.com>
3528
3529         Reviewed by John Sullivan.
3530
3531         Part of Layering Violation in ContextMenu
3532         https://bugs.webkit.org/show_bug.cgi?id=50586
3533         
3534         Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
3535         was a layering violation. Also, make sure we set the menu item targets for all menu
3536         items before showing them, because the ContextMenu constructor doesn't do that anymore.
3537
3538         * WebView/WebHTMLView.mm:
3539         (+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
3540         (-[WebMenuTarget WebCore::]): Ditto.
3541         (-[WebMenuTarget setMenuController:WebCore::]): Ditto.
3542         (-[WebMenuTarget forwardContextMenuAction:]): Ditto.
3543         (-[WebMenuTarget validateMenuItem:]): Ditto.
3544
3545         (setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
3546         (setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including
3547             submenus), and calls setMenuItemTarget on them.
3548         (-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding
3549             them to the menu.
3550
3551 2010-12-06  Darin Adler  <darin@apple.com>
3552
3553         Reviewed by Sam Weinig.
3554
3555         Pass security origin to make local file decision correctly
3556         https://bugs.webkit.org/show_bug.cgi?id=48603
3557
3558         * WebView/WebPDFView.mm:
3559         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.
3560
3561 2010-12-07  Martin Robinson  <mrobinson@igalia.com>
3562
3563         Unreviewed, rolling out r73392.
3564         http://trac.webkit.org/changeset/73392
3565         https://bugs.webkit.org/show_bug.cgi?id=50489
3566
3567         This commit caused crashes on the GTK+ bots
3568
3569         * WebView/WebFrame.mm:
3570         (-[WebFrame _canProvideDocumentSource]):
3571
3572 2010-12-07  Kenichi Ishibashi  <bashi@google.com>
3573
3574         Reviewed by Kent Tamura.
3575
3576         Let HTMLObjectElement be a form associated element
3577         https://bugs.webkit.org/show_bug.cgi?id=48821
3578
3579         Modified to use FormAssociatedElement instead of HTMLFormControlElement.
3580
3581         * WebView/WebHTMLRepresentation.mm:
3582         (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
3583         FormAssociatedElement instead of HTMLFormControlElement.
3584         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3585
3586 2010-12-06  Nate Chapin  <japhet@chromium.org>
3587
3588         Reviewed by Adam Barth.
3589
3590         Update calls to DocumentWriter.
3591         https://bugs.webkit.org/show_bug.cgi?id=50489
3592
3593         * WebView/WebFrame.mm:
3594         (-[WebFrame _canProvideDocumentSource]):
3595
3596 2010-12-06  Chris Marrin  <cmarrin@apple.com>
3597
3598         Reviewed by Simon Fraser.
3599
3600         Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
3601         https://bugs.webkit.org/show_bug.cgi?id=49388
3602
3603         Got rid of GraphicsLayer::nativeLayer() call, replacing it with 
3604         GraphicsLayer::platformLayer().
3605
3606         * WebCoreSupport/WebChromeClient.mm:
3607       &nbs