Expand font-weight and font-stretch to take any number
[WebKit.git] / Source / WebKit / mac / ChangeLog
1 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         Expand font-weight and font-stretch to take any number
4         https://bugs.webkit.org/show_bug.cgi?id=168889
5
6         Reviewed by Simon Fraser.
7
8         Migrate off old enum types.
9
10         * WebCoreSupport/PopupMenuMac.mm:
11         (PopupMenuMac::populate):
12         * WebView/WebHTMLView.mm:
13         (fontNameForDescription):
14         * WebView/WebView.mm:
15         (-[WebView updateTextTouchBar]):
16
17 2017-03-03  Dean Jackson  <dino@apple.com>
18
19         Add WebGPU compile flag and experimental feature flag
20         https://bugs.webkit.org/show_bug.cgi?id=169161
21         <rdar://problem/30846689>
22
23         Reviewed by Tim Horton.
24
25         Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
26         and an InternalSetting.
27
28         * Configurations/FeatureDefines.xcconfig:
29         * WebView/WebPreferenceKeysPrivate.h:
30         * WebView/WebPreferences.mm:
31         (+[WebPreferences initialize]):
32         (-[WebPreferences webGPUEnabled]):
33         (-[WebPreferences setWebGPUEnabled:]):
34         * WebView/WebPreferencesPrivate.h:
35         * WebView/WebView.mm:
36         (-[WebView _preferencesChanged:]):
37
38 2017-03-03  Alexey Proskuryakov  <ap@apple.com>
39
40         Build fix
41         rdar://problem/30825660
42
43         Suggested by Dan Bernstein.
44
45         * Configurations/WebKitLegacy.xcconfig:
46
47 2017-03-02  Sam Weinig  <sam@webkit.org>
48
49         Rename htmlediting.h/cpp to Editing.h/cpp
50         https://bugs.webkit.org/show_bug.cgi?id=169103
51
52         Reviewed by Alex Christensen.
53
54         * DOM/DOMUIKitExtensions.mm:
55         * WebView/WebFrame.mm:
56         * WebView/WebView.mm:
57
58 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
59
60         Fix 32-bit
61         https://bugs.webkit.org/show_bug.cgi?id=169114
62
63         Reviewed by Alex Christensen.
64
65         * WebView/WebView.mm:
66
67 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
68
69         More guard fixing
70         https://bugs.webkit.org/show_bug.cgi?id=169112
71
72         Reviewed by Alex Christensen.
73
74         Fixed an internal build.
75
76         * WebView/WebView.mm:
77         * WebView/WebViewPrivate.h:
78
79 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
80
81         Data Interaction build fixes
82         https://bugs.webkit.org/show_bug.cgi?id=169096
83
84         Reviewed by Tim Horton.
85
86         Guards weren't all correct, also missed a selector name change.
87
88         * WebView/WebView.mm:
89         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
90         * WebView/WebViewData.h:
91         * WebView/WebViewData.mm:
92         (-[WebViewPrivate dealloc]):
93
94 2017-03-02  Alex Christensen  <achristensen@webkit.org>
95
96         Continue enabling WebRTC
97         https://bugs.webkit.org/show_bug.cgi?id=169056
98
99         Reviewed by Jon Lee.
100
101         * Configurations/FeatureDefines.xcconfig:
102
103 2017-03-01  Megan Gardner  <megan_gardner@apple.com>
104
105         Data interaction support for WK1
106         https://bugs.webkit.org/show_bug.cgi?id=169062
107
108         Reviewed by Wenson Hsieh.
109
110         Support for data interaction in WebKit1
111
112         * WebCoreSupport/WebDragClient.mm:
113         * WebView/WebView.mm:
114         (-[WebUITextIndicatorData initWithImage:TextIndicatorData:scale:]):
115         (-[WebUITextIndicatorData initWithImage:scale:]):
116         (-[WebUITextIndicatorData dealloc]):
117         (-[WebView _requestStartDataInteraction:globalPosition:]):
118         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
119         (-[WebView _getDataInteractionData]):
120         * WebView/WebViewData.h:
121         * WebView/WebViewData.mm:
122         (-[WebViewPrivate dealloc]):
123         * WebView/WebViewInternal.h:
124         * WebView/WebViewPrivate.h:
125
126 2017-03-02  Youenn Fablet  <youenn@apple.com>
127
128         [WebRTC] Activate ICE candidate privacy policy
129         https://bugs.webkit.org/show_bug.cgi?id=168975
130
131         Reviewed by Alex Christensen.
132
133         * WebView/WebPreferenceKeysPrivate.h:
134         * WebView/WebPreferences.mm:
135         (-[WebPreferences enumeratingAllNetworkInterfacesEnabled]):
136         (-[WebPreferences setEnumeratingAllNetworkInterfacesEnabled:]):
137         (-[WebPreferences iceCandidateFilteringEnabled]):
138         (-[WebPreferences setIceCandidateFilteringEnabled:]):
139         * WebView/WebPreferencesPrivate.h:
140
141 2017-03-01  Alex Christensen  <achristensen@webkit.org>
142
143         Unreviewed, rolling out r213259.
144
145         Broke an internal build
146
147         Reverted changeset:
148
149         "Continue enabling WebRTC"
150         https://bugs.webkit.org/show_bug.cgi?id=169056
151         http://trac.webkit.org/changeset/213259
152
153 2017-03-01  Alex Christensen  <achristensen@webkit.org>
154
155         Continue enabling WebRTC
156         https://bugs.webkit.org/show_bug.cgi?id=169056
157
158         Reviewed by Jon Lee.
159
160         * Configurations/FeatureDefines.xcconfig:
161
162 2017-02-27  Alex Christensen  <achristensen@webkit.org>
163
164         Begin enabling WebRTC on 64-bit
165         https://bugs.webkit.org/show_bug.cgi?id=168915
166
167         Reviewed by Eric Carlson.
168
169         * Configurations/FeatureDefines.xcconfig:
170
171 2017-02-27  Aakash Jain  <aakash_jain@apple.com>
172
173         Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
174         https://bugs.webkit.org/show_bug.cgi?id=168919
175
176         Reviewed by Tim Horton.
177
178         * Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
179         * migrate-headers.sh: Run the migrate-headers script for installapi phase.
180
181 2017-02-27  Alex Christensen  <achristensen@webkit.org>
182
183         [libwebrtc] Enable WebRTC in some Production Builds
184         https://bugs.webkit.org/show_bug.cgi?id=168858
185
186         * Configurations/FeatureDefines.xcconfig:
187
188 2017-02-26  Alexey Proskuryakov  <ap@apple.com>
189
190         Don't import RetainPtr in WebNotification.h
191         https://bugs.webkit.org/show_bug.cgi?id=168876
192
193         Reviewed by Dan Bernstein.
194
195         This is an Objective-C SPI header.
196
197         * WebView/WebNotification.h:
198         * WebView/WebNotification.mm:
199         (-[WebNotification initWithCoreNotification:notificationID:]):
200         (-[WebNotification dealloc]):
201
202 2017-02-26  Aakash Jain  <aakash_jain@apple.com>
203
204         Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
205         https://bugs.webkit.org/show_bug.cgi?id=168819
206
207         Reviewed by Dan Bernstein.
208
209         * Configurations/WebKitLegacy.xcconfig:
210
211 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
212
213         Export Objective-C symbols for variables in Webkit SPI
214         https://bugs.webkit.org/show_bug.cgi?id=168758
215
216         Reviewed by Alexey Proskuryakov.
217
218         * Configurations/WebKitLegacy.xcconfig: using separate .exp file for i386.
219         * WebKit.exp: Added various Objective-C symbols.
220
221 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
222
223         Move instance members from WKQuadObject to implementation file
224         https://bugs.webkit.org/show_bug.cgi?id=168740
225
226         Reviewed by Tim Horton.
227
228         * DOM/DOM.mm: Moving instance member to implementation file.
229         * DOM/DOMExtensions.h: Ditto.
230
231 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
232
233         Move iOS specific symbols to WebKit.ios.exp
234         https://bugs.webkit.org/show_bug.cgi?id=168726
235
236         Reviewed by Alexey Proskuryakov.
237
238         * WebKit.exp:
239
240 2017-02-21  Youenn Fablet  <youenn@apple.com>
241
242         [WebRTC][Mac] Activate libwebrtc
243         https://bugs.webkit.org/show_bug.cgi?id=167293
244         <rdar://problem/30401864>
245
246         Reviewed by Alex Christensen.
247
248         * Configurations/FeatureDefines.xcconfig:
249
250 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
251
252         Export various NSString symbols from WebFramePrivate.h
253         https://bugs.webkit.org/show_bug.cgi?id=168702
254
255         Reviewed by Alexey Proskuryakov.
256
257         * WebKit.exp:
258
259 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
260
261         Export various NSString symbols from WebPreferencesPrivate.h
262         https://bugs.webkit.org/show_bug.cgi?id=168701
263
264         Reviewed by Alexey Proskuryakov.
265
266         * WebKit.exp:
267
268 2017-02-21  Joseph Pecoraro  <pecoraro@apple.com>
269
270         Add missing WebConsoleMessage string key
271         https://bugs.webkit.org/show_bug.cgi?id=168690
272
273         Reviewed by Alexey Proskuryakov.
274
275         * WebKit.exp:
276         * WebView/WebUIDelegatePrivate.h:
277         This key has an implementation but was not extern / exported like the others.
278
279 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
280
281         Export various NSString symbols from WebViewPrivate.h
282         https://bugs.webkit.org/show_bug.cgi?id=168689
283
284         Reviewed by Alexey Proskuryakov.
285
286         * WebKit.exp:
287
288 2017-02-21  Commit Queue  <commit-queue@webkit.org>
289
290         Unreviewed, rolling out r212768.
291         https://bugs.webkit.org/show_bug.cgi?id=168698
292
293         Rolling out since this would break other projects. (Requested
294         by aakashjain on #webkit).
295
296         Reverted changeset:
297
298         "[iOS] Remove old WebKit1 MemoryMeasure helper."
299         https://bugs.webkit.org/show_bug.cgi?id=168675
300         http://trac.webkit.org/changeset/212768
301
302 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
303
304         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
305         https://bugs.webkit.org/show_bug.cgi?id=168620
306         <rdar://problem/30617772>
307
308         Reviewed by Tim Horton.
309
310         * WebView/WebPreferenceKeysPrivate.h:
311         * WebView/WebPreferences.mm:
312         (+[WebPreferences initialize]):
313         (-[WebPreferences subpixelAntialiasedLayerTextEnabled]):
314         (-[WebPreferences setSubpixelAntialiasedLayerTextEnabled:]):
315         * WebView/WebPreferencesPrivate.h:
316
317 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
318
319         Export various NSString symbols from WebUIDelegatePrivate.h
320         https://bugs.webkit.org/show_bug.cgi?id=168679
321
322         Reviewed by Joseph Pecoraro.
323
324         * WebKit.exp:
325
326 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
327
328         Export symbols for various classes present in webkit SPI
329         https://bugs.webkit.org/show_bug.cgi?id=168674
330
331         Reviewed by Dan Bernstein.
332
333         * WebKit.exp:
334
335 2017-02-21  Andreas Kling  <akling@apple.com>
336
337         [iOS] Remove old WebKit1 MemoryMeasure helper.
338         <https://webkit.org/b/168675>
339
340         Reviewed by Sam Weinig.
341
342         * Configurations/WebKitLegacy.xcconfig:
343         * Misc/WebCache.mm:
344         (+[WebCache emptyInMemoryResources]):
345         * WebView/WebView.mm:
346
347 2017-02-21  Andreas Kling  <akling@apple.com>
348
349         [iOS] WebKit1 should use shared memory pressure handler code.
350         <https://webkit.org/b/168653>
351
352         Reviewed by Antti Koivisto.
353
354         Register a WebThread-aware memory callback with the shared MemoryPressureHandler
355         and get rid of the old iOS WebKit1 specific implementation. Some of it was even
356         dead code since MobileSafari has been using WebKit2 for quite a while.
357
358         * WebView/WebView.h:
359         * WebView/WebView.mm:
360         (WebInstallMemoryPressureHandler):
361         (+[WebView _handleMemoryWarning]): Deleted.
362         (+[WebView registerForMemoryNotifications]): Deleted.
363         (+[WebView releaseFastMallocMemoryOnCurrentThread]): Deleted.
364         (+[WebView garbageCollectNow]): Deleted.
365         (+[WebView purgeInactiveFontData]): Deleted.
366         (+[WebView drainLayerPool]): Deleted.
367         (+[WebView discardAllCompiledCode]): Deleted.
368         (+[WebView _clearMemoryPressure]): Deleted.
369         (+[WebView _shouldWaitForMemoryClearMessage]): Deleted.
370         * WebView/WebViewPrivate.h:
371
372 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
373
374         Stop exporting interface WebCoreScrollView on iOS
375         https://bugs.webkit.org/show_bug.cgi?id=168536
376
377         Reviewed by Dan Bernstein.
378
379         * WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
380         * WebKit.mac.exp: Ditto.
381         * WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.
382
383 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
384
385         Exclude various mac-specific header files from iOS build
386         https://bugs.webkit.org/show_bug.cgi?id=168621
387
388         Reviewed by Dan Bernstein.
389
390         * Configurations/WebKitLegacy.xcconfig:
391
392 2017-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
393
394         Add plumbing to the UI process for TextIndicatorData when computing the drag image
395         https://bugs.webkit.org/show_bug.cgi?id=168583
396         Work towards <rdar://problem/30313681>
397
398         Accounts for changes in WebCore -- see Source/WebCore/ChangeLog for more details.
399
400         Reviewed by Tim Horton.
401
402         * WebView/WebHTMLView.mm:
403         (-[WebHTMLView _selectionDraggingImage]):
404         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
405
406 2017-02-17  Anders Carlsson  <andersca@apple.com>
407
408         Add a new drag code path and use it for dragging plain text
409         https://bugs.webkit.org/show_bug.cgi?id=168534
410
411         Reviewed by Geoffrey Garen.
412
413         * WebCoreSupport/WebDragClient.h:
414         Add new members.
415
416         * WebCoreSupport/WebDragClient.mm:
417         (WebDragClient::useLegacyDragClient):
418         Return false here.
419
420         (WebDragClient::beginDrag):
421         New client member function. Create an NSDraggingItem and use it to begin a dragging session.
422
423         * WebView/WebHTMLView.mm:
424         (-[WebHTMLView draggingSession:sourceOperationMaskForDraggingContext:]):
425         Get the source operation mask from WebCore.
426
427         (-[WebHTMLView draggingSession:endedAtPoint:operation:]):
428         Send a fake mouse up event.
429
430         * WebView/WebHTMLViewInternal.h:
431         Declare that WebHTMLView conforms to NSDraggingSource.
432
433 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
434
435         List of WebCore symbols to re-export from WebKitLegacy should be built automatically
436         https://bugs.webkit.org/show_bug.cgi?id=168342
437         rdar://problem/26182266
438
439         Reviewed by Tim Horton.
440
441         * MigrateHeaders.make: On iOS only, process re-exported headers to build a list of
442         symbols to re-export.
443
444 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
445
446         Stop exporting DOMTokenList from WebKit
447         https://bugs.webkit.org/show_bug.cgi?id=168544
448
449         Reviewed by Alexey Proskuryakov.
450
451         * WebKit.exp:
452
453 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
454
455         Clean up how WebKit exports _WebCreateFragment
456         https://bugs.webkit.org/show_bug.cgi?id=168579
457
458         Reviewed by Dan Bernstein.
459
460         * WebCoreSupport/WebCreateFragmentInternal.h: Added a private header.
461         * WebCoreSupport/WebEditorClient.mm: Include the new header that declares _WebCreateFragment.
462
463 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
464
465         Stop exporting DOMNodeFilter
466         https://bugs.webkit.org/show_bug.cgi?id=168542
467
468         Reviewed by Alexey Proskuryakov.
469
470         * WebKit.exp:
471
472 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
473
474         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
475         https://bugs.webkit.org/show_bug.cgi?id=167693
476
477         Reviewed by Sergio Villar Senin.
478
479         * Configurations/FeatureDefines.xcconfig:
480         * WebView/WebPreferences.mm:
481         (+[WebPreferences initialize]):
482         * WebView/WebView.mm:
483         (-[WebView _preferencesChanged:]):
484
485 2017-02-15  Brady Eidson  <beidson@apple.com>
486
487         Stop backing up localStorage databases to iCloud by default.
488         <rdar://problem/29045531> and https://bugs.webkit.org/show_bug.cgi?id=168388
489
490         Reviewed by Geoffrey Garen.
491
492         * Misc/WebKitVersionChecks.h:
493         * Misc/WebKitVersionChecks.mm: Renamed from Source/WebKit/mac/Misc/WebKitVersionChecks.m.
494         (WebKitLinkedOnOrAfter):
495         (setWebKitLinkTimeVersion):
496         (WebKitLinkTimeVersion):
497         (linkedOnOrAfter):
498
499         * Storage/WebStorageManager.mm:
500         (WebKitInitializeStorageIfNecessary):
501
502 2017-02-16  Daniel Bates  <dabates@apple.com>
503
504         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
505         https://bugs.webkit.org/show_bug.cgi?id=168417
506         <rdar://problem/30541748>
507
508         Reviewed by Brent Fulgham.
509
510         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
511         Widget* as it is always called with a valid Widget.
512
513         * WebCoreSupport/WebFrameLoaderClient.h:
514         * WebCoreSupport/WebFrameLoaderClient.mm:
515         (WebFrameLoaderClient::redirectDataToPlugin):
516         * WebKit.order: Remove symbol for WebFrameLoaderClient::redirectDataToPlugin() that took a Widget*
517         as it no longer exists. I am unclear if this file is still meaningful as it was last modified in
518         r180570 (2 years ago) though Xcode still references this ordering file (why?).
519
520 2017-02-16  Yusuke Suzuki  <utatane.tea@gmail.com>
521
522         [JSC] Drop PassRefPtr in inspector/
523         https://bugs.webkit.org/show_bug.cgi?id=168420
524
525         Reviewed by Alex Christensen.
526
527         * WebView/WebScriptDebugger.mm:
528         (WebScriptDebugger::handlePause):
529
530 2017-02-16  Simon Fraser  <simon.fraser@apple.com>
531
532         Clean up use of some CALayer-related SPI
533         https://bugs.webkit.org/show_bug.cgi?id=168401
534
535         Reviewed by Tim Horton.
536
537         Include CALayer.h not CATiledLayer.h.
538
539         * WebInspector/WebNodeHighlight.h:
540
541 2017-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
542
543         Fix the build after r212379
544
545         Rubber-stamped by Anders Carlsson.
546
547         * WebCoreSupport/WebDragClient.mm:
548         (WebDragClient::startDrag):
549
550 2017-02-15  Anders Carlsson  <andersca@apple.com>
551
552         Modernize DragClient::startDrag somewhat
553         https://bugs.webkit.org/show_bug.cgi?id=168379
554
555         Reviewed by Tim Horton.
556
557         Update for WebCore changes.
558
559         * WebCoreSupport/WebDragClient.h:
560         * WebCoreSupport/WebDragClient.mm:
561         (WebDragClient::startDrag):
562
563 2017-02-14  Dean Jackson  <dino@apple.com>
564
565         Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
566         https://bugs.webkit.org/show_bug.cgi?id=168339
567
568         Reviewed by Simon Fraser.
569
570         Use a better name.
571
572         * WebView/WebPreferenceKeysPrivate.h:
573         * WebView/WebPreferences.mm:
574         (+[WebPreferences initialize]):
575         (-[WebPreferences forceLowPowerGPUForWebGL]):
576         (-[WebPreferences setForceLowPowerGPUForWebGL:]):
577         (-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
578         (-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.
579         * WebView/WebPreferencesPrivate.h:
580         * WebView/WebView.mm:
581         (-[WebView _preferencesChanged:]):
582
583 2017-02-14  Chris Dumez  <cdumez@apple.com>
584
585         HTML Form Validation bubble should take minimum font size setting into consideration
586         https://bugs.webkit.org/show_bug.cgi?id=168271
587         <rdar://problem/29869869>
588
589         Reviewed by Simon Fraser.
590
591         * WebView/WebView.mm:
592         (-[WebView _contentsOfUserInterfaceItem:]):
593         Return font size used in the validation bubble.
594
595         (-[WebView showFormValidationMessage:withAnchorRect:]):
596         Pass minimum font size setting when constructing the validation bubble.
597
598 2017-02-14  Anders Carlsson  <andersca@apple.com>
599
600         Remove an unused delegate method
601         https://bugs.webkit.org/show_bug.cgi?id=168328
602
603         Reviewed by Wenson Hsieh.
604
605         * DefaultDelegates/WebDefaultUIDelegate.m:
606         (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.
607
608 2017-02-14  Alexey Proskuryakov  <ap@apple.com>
609
610         WebCore shouldn't export SystemMemory.h
611         https://bugs.webkit.org/show_bug.cgi?id=168285
612
613         Reviewed by Alex Christensen.
614
615         * MigrateHeaders.make: And WebKit shouldn't re-export it.
616
617 2017-02-13  Alexey Proskuryakov  <ap@apple.com>
618
619         WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
620         https://bugs.webkit.org/show_bug.cgi?id=168282
621
622         Reviewed by Dan Bernstein.
623
624         * MigrateHeaders.make:
625
626 2017-02-12  Dan Bernstein  <mitz@apple.com>
627
628         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
629
630         * WebView/WebHTMLView.mm:
631         (createShareMenuItem): Use non-deprecated method.
632
633 2017-02-12  Dan Bernstein  <mitz@apple.com>
634
635         [Cocoa] Some -respondsToSelector: checks are unnecessary
636         https://bugs.webkit.org/show_bug.cgi?id=168183
637
638         Reviewed by Tim Horton.
639
640         * WebView/WebFullScreenController.mm:
641         (-[WebFullScreenController applicationDidResignActive:]): Removed check whether NSWindow
642           responds to -isOnActiveSpace.
643         (-[WebFullScreenController exitFullScreen]): Ditto.
644         (-[WebFullScreenController _updateMenuAndDockForFullScreen]): Removed check whether
645           NSApplication responds to -setPresentationOptions.
646
647         * WebView/WebHTMLView.mm:
648         (createShareMenuItem): Removed unnecessary -respondsToSelector: check.
649         (-[WebHTMLView otherMouseDown:]): Ditto.
650
651         * WebView/WebImmediateActionController.mm:
652         (-[WebImmediateActionController _clearImmediateActionState]): Ditto.
653         (-[WebImmediateActionController _animationControllerForDataDetectedText]): Ditto.
654
655         * WebView/WebView.mm:
656         (-[WebView _didStartProvisionalLoadForFrame:]): Removed redundant nil check.
657         (+[WebView _setCacheModel:]): Removed unnecessary -respondsToSelector: check.
658
659 2017-02-10  Daniel Bates  <dabates@apple.com>
660
661         Detach frame from document when entering page cache
662         https://bugs.webkit.org/show_bug.cgi?id=166774
663         <rdar://problem/29904368>
664
665         Reviewed by Chris Dumez.
666
667         * WebView/WebPreferenceKeysPrivate.h:
668         * WebView/WebPreferences.mm:
669         (+[WebPreferences initialize]):
670         (-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
671         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
672         * WebView/WebPreferencesPrivate.h:
673         * WebView/WebView.mm:
674         (-[WebView _preferencesChanged:]):
675
676 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
677
678         [Resource Timing] Enable Resource Timing by default in Tests
679         https://bugs.webkit.org/show_bug.cgi?id=168145
680
681         Reviewed by Ryosuke Niwa.
682
683         * WebView/WebPreferenceKeysPrivate.h:
684         * WebView/WebPreferences.mm:
685         (+[WebPreferences initialize]):
686         (-[WebPreferences resourceTimingEnabled]):
687         (-[WebPreferences setResourceTimingEnabled:]):
688         * WebView/WebPreferencesPrivate.h:
689         * WebView/WebView.mm:
690         (-[WebView _preferencesChanged:]):
691
692 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
693
694         cleanup WebLocalizableStrings.
695         https://bugs.webkit.org/show_bug.cgi?id=168078
696
697         Reviewed by Alexey Proskuryakov.
698
699         * Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle 
700         as it's for each framework's own consumption, and never needs to be exported.
701
702 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
703
704         WebResourceLoadDelegatePrivate.h cannot be imported standalone
705         https://bugs.webkit.org/show_bug.cgi?id=168096
706
707         Reviewed by Alexey Proskuryakov.
708
709         * WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger. 
710
711 2017-02-09  Antti Koivisto  <antti@apple.com>
712
713         Remove most cases of #if ENABLE(CACHE_PARTITIONING)
714         https://bugs.webkit.org/show_bug.cgi?id=167990
715
716         Reviewed by Sam Weinig.
717
718         * Misc/WebCache.mm:
719         (+[WebCache addImageToCache:forURL:forFrame:]):
720         (+[WebCache removeImageFromCacheForURL:forFrame:]):
721         * WebCoreSupport/WebSystemInterface.mm:
722         (InitWebCoreSystemInterface):
723
724 2017-02-07  Alexey Proskuryakov  <ap@apple.com>
725
726         Don't migrate WebKit DOM headers in MigrateHeaders.make
727         https://bugs.webkit.org/show_bug.cgi?id=167608
728
729         Reviewed by Darin Adler.
730
731         Stop migrating DOM headers that are now in WebKit.
732
733         * DOM/DOMDOMImplementation.h: Removed.
734         * DOM/DOMDOMImplementation.mm: Removed.
735         * DOM/DOMDOMImplementationInternal.h: Removed.
736         * DOM/DOMDOMTokenList.h: Removed.
737         * DOM/DOMDOMTokenList.mm: Removed.
738         * DOM/DOMDOMTokenListInternal.h: Removed.
739         * DOM/DOMImplementation.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.h.
740         * DOM/DOMImplementation.mm: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.mm.
741         * DOM/DOMImplementationInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementationInternal.h.
742         * DOM/DOMTokenList.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.h.
743         * DOM/DOMTokenList.mm: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.mm.
744         * DOM/DOMTokenListInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenListInternal.h.
745         As the files are not in WebCore any more, there is no need to differentiate from
746         WebCore internal headers with the same name. This makes it possible to make these
747         headers private using Xcode mechanisms, as opposed to copying with a shell script.
748
749         * DOM/DOMElement.mm: Removed "using namespace WebCore". Other DOM implementation
750         files don't have it.
751
752         * DOM/DOMCore.h:
753         * DOM/DOMDocument.mm:
754         * DOM/DOMHTMLAnchorElement.mm:
755         * DOM/DOMHTMLAreaElement.mm:
756         * DOM/DOMHTMLLinkElement.mm:
757         * DOM/DOMUtility.mm:
758         No more "DOMDOM".
759
760         * WebKit.exp:
761         No more "DOMDOM". DOMDOMTokenList was not directly exposed via an SPI header, so
762         renaming it is likely to be safe.
763
764         * MigrateHeaders.make: Don't migrate WebKit headers.
765
766         * Configurations/WebKitLegacy.xcconfig: Don't include two iOS specific SPI headers
767         on macOS.
768
769 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
770
771         Don't re-export PluginData.h from WebKit
772         https://bugs.webkit.org/show_bug.cgi?id=168020
773
774         Reviewed by Alexey Proskuryakov.
775
776         * MigrateHeaders.make: Removed PluginData.h
777
778 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
779
780         Don't re-export WKUtilities.h from WebKit
781         https://bugs.webkit.org/show_bug.cgi?id=167977
782
783         Reviewed by Alexey Proskuryakov.
784
785         * MigrateHeaders.make: Removed WKUtilities.h
786
787 2017-02-06  Alex Christensen  <achristensen@webkit.org>
788
789         credentials should be partitioned by main document domain
790         https://bugs.webkit.org/show_bug.cgi?id=166998
791         rdar://problem/22901123
792
793         Reviewed by Brady Eidson.
794
795         * Misc/WebDownload.mm:
796         * Plugins/WebBaseNetscapePluginView.mm:
797         (WebKit::getAuthenticationInfo):
798         Don't use partitioned credentials for WebKit1 plugins or downloads.
799         Downloads should be authenticated before becoming a download anyways.
800
801 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
802
803         Rename AnimationController to CSSAnimationController
804         https://bugs.webkit.org/show_bug.cgi?id=167829
805
806         Reviewed by Simon Fraser.
807
808         * WebView/WebFrame.mm:
809         * WebView/WebView.mm:
810
811 2017-02-03  Chris Dumez  <cdumez@apple.com>
812
813         Dismiss HTML form validation popover when pressing Escape key
814         https://bugs.webkit.org/show_bug.cgi?id=167716
815         <rdar://problem/29872943>
816
817         Reviewed by Simon Fraser.
818
819         Override ValidationMessageClient::hideAnyValidationMessage().
820
821         * WebCoreSupport/WebValidationMessageClient.h:
822         * WebCoreSupport/WebValidationMessageClient.mm:
823         (WebValidationMessageClient::hideAnyValidationMessage):
824
825 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
826
827         Drag images should be anchored to the mouse location
828         https://bugs.webkit.org/show_bug.cgi?id=167690
829         <rdar://problem/30295261>
830
831         Reviewed by Enrica Casucci.
832
833         Adds some plumbing for the anchor point in the WK1 client layer.
834
835         * WebCoreSupport/WebDragClient.h:
836         * WebCoreSupport/WebDragClient.mm:
837         (WebDragClient::startDrag):
838
839 2017-02-02  Chris Dumez  <cdumez@apple.com>
840
841         Rename Node::inDocument() to isConnected()
842         https://bugs.webkit.org/show_bug.cgi?id=167743
843
844         Reviewed by Sam Weinig.
845
846         Rename Node::inDocument() to isConnected() to match the DOM specification more closely:
847         - https://dom.spec.whatwg.org/#connected
848
849         * DOM/DOMNode.mm:
850         (-[DOMNode isConnected]):
851         * WebView/WebFrame.mm:
852         (-[WebFrame selectNSRange:onElement:]):
853
854 2017-02-02  Chris Dumez  <cdumez@apple.com>
855
856         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
857         https://bugs.webkit.org/show_bug.cgi?id=167738
858         <rdar://problem/30229990>
859
860         Reviewed by Andreas Kling.
861
862         The BackForwardClient no longer needs to worry about removing HistoryItems
863         from the PageCache now that WebCore takes care of it.
864
865         * History/BackForwardList.mm:
866         (BackForwardList::close):
867
868 2017-02-02  Yongjun Zhang  <yongjun_zhang@apple.com>
869
870         In iOS, we should take background assertion when accessing localstorage databases.
871         https://bugs.webkit.org/show_bug.cgi?id=165478
872
873         Move database transaction background task handling code from WebDatabaseManager to
874         WebCore's WebSQLiteDatabaseTrackerClient.
875
876         Reviewed by Brady Eidson.
877
878         * Storage/WebDatabaseManager.mm:
879         * Storage/WebDatabaseManagerInternal.h: Remove a category for background task handling.
880         * WebCoreSupport/WebApplicationCache.mm:
881         (+[WebApplicationCache initializeWithBundleIdentifier:]): Use WebCore::WebSQLiteDatabaseTrackerClient.
882         * WebView/WebView.mm:
883         (-[WebView _commonInitializationWithFrameName:groupName:]): Ditto.
884
885 2017-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
886
887         [WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
888         https://bugs.webkit.org/show_bug.cgi?id=167695
889         <rdar://problem/30305390>
890
891         Reviewed by Sam Weinig.
892
893         Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
894         exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
895         is destroyed.
896
897         * WebView/WebView.mm:
898         (-[WebView _commonInitializationWithFrameName:groupName:]):
899
900 2017-01-31  Joseph Pecoraro  <pecoraro@apple.com>
901
902         ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category
903         https://bugs.webkit.org/show_bug.cgi?id=167684
904
905         Reviewed by Dan Bernstein.
906
907         * DOM/DOMHTML.mm:
908         (-[DOMHTMLInputElement _isAutofilled]): Deleted.
909         (-[DOMHTMLInputElement _setAutofilled:]): Deleted.
910         Consolidate in the WebDOMOperationsPrivate category.
911
912         * DOM/DOMPrivate.h:
913         Include WebDOMOperationsPrivate header to get other DOM Private categories.
914
915         * DOM/WebDOMOperations.mm:
916         (-[DOMHTMLInputElement _isAutofilled]):
917         * DOM/WebDOMOperationsPrivate.h:
918         Include getter alongside the setter.
919
920 2017-01-31  Jessie Berlin  <jberlin@webkit.org>
921
922         Build fix.
923
924         * Misc/WebNSPasteboardExtras.mm:
925         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
926         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
927         * WebView/WebHTMLView.mm:
928         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
929         (-[WebHTMLView copyFont:]):
930
931 2017-01-30  Andy Estes  <aestes@apple.com>
932
933         [QuickLook] FrameLoaderClient should return the new QuickLookHandleClient it creates
934         https://bugs.webkit.org/show_bug.cgi?id=167625
935
936         Reviewed by Andreas Kling.
937
938         * WebCoreSupport/WebFrameLoaderClient.h: Declared createQuickLookHandleClient().
939         * WebCoreSupport/WebFrameLoaderClient.mm:
940         (WebFrameLoaderClient::createQuickLookHandleClient): Renamed from didCreateQuickLookHandle().
941         (WebFrameLoaderClient::didCreateQuickLookHandle): Renamed to createQuickLookHandleClient().
942
943 2017-01-30  Chris Dumez  <cdumez@apple.com>
944
945         Drop legacy Attributes.isId attribute
946         https://bugs.webkit.org/show_bug.cgi?id=167603
947
948         Reviewed by Ryosuke Niwa.
949
950         Keep Attr.isId in ObjC bindings.
951
952         * DOM/DOMAttr.mm:
953         (-[DOMAttr isId]):
954
955 2017-01-30  Andreas Kling  <akling@apple.com>
956
957         [macOS] WebHTMLView has an internal retain cycle with its flagsChangedEventMonitor.
958         <https://webkit.org/b/167580>
959
960         Reviewed by Antti Koivisto.
961
962         Avoid the implicit strong capture of self by keeping it in a __block variable.
963         Also add code to dealloc to unregister the event monitor, since it will otherwise leak.
964         This fixes huge WebHTMLView leaks seen on the leaks bot.
965
966         * WebView/WebHTMLView.mm:
967         (-[WebHTMLViewPrivate dealloc]):
968         (-[WebHTMLView viewDidMoveToWindow]):
969
970 2017-01-29  Andy Estes  <aestes@apple.com>
971
972         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
973         https://bugs.webkit.org/show_bug.cgi?id=167563
974         <rdar://problem/30253207>
975
976         Reviewed by Andreas Kling.
977
978         Instead of only saving QuickLook documents to a temporary file when the client is
979         MobileSafari, base this decision on a WebPreference that clients can choose to enable.
980
981         This also changes the SPI for accessing the temporary file path and UTI. Instead of
982         -[WebView quickLookContentForURL:], which requires the client to pass the response URL of
983         the frame that saved the QuickLook document, the content dictionary is now stored as a
984         property of WebDataSource.
985
986         This also removes the manual lifetime management of the QLPreviewConverter from
987         QuickLookDocumentWriter. The QLPreviewConverter is kept alive by DocumentLoader these days,
988         which ensures it lives long enough to respond to subresource requests.
989
990         New API test: QuickLook.LegacyQuickLookContent
991
992         * WebCoreSupport/WebFrameLoaderClient.mm:
993         (WebFrameLoaderClient::didCreateQuickLookHandle): Moved the logic of deciding whether to
994         write a temporary file to here from the QuickLookDocumentWriter constructor.
995         * WebView/WebDataSource.mm: Declared _quickLookContent.
996         (-[WebDataSource _quickLookContent]):
997         (-[WebDataSource _setQuickLookContent:]):
998         * WebView/WebDataSourceInternal.h: Overrode _quickLookContent as a read/write property.
999         * WebView/WebDataSourcePrivate.h: Declared _quickLookContent as a readonly property.
1000         * WebView/WebPreferenceKeysPrivate.h: Defined WebKitQuickLookDocumentSavingPreferenceKey.
1001         * WebView/WebPreferences.mm:
1002         (-[WebPreferences quickLookDocumentSavingEnabled]):
1003         (-[WebPreferences setQuickLookDocumentSavingEnabled:]):
1004         * WebView/WebPreferencesPrivate.h: Declared property quickLookDocumentSavingEnabled.
1005         * WebView/WebView.mm:
1006         (-[WebView quickLookContentForURL:]): Changed to always return nil.
1007         * WebView/WebViewPrivate.h: Added a comment stating that clients should use
1008         -[WebDataSource _quickLookContent] instead.
1009
1010 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1011
1012         Add Link Preload as an off-by-default experimental feature menu item.
1013         https://bugs.webkit.org/show_bug.cgi?id=167201
1014
1015         Reviewed by Ryosuke Niwa.
1016
1017         * WebView/WebPreferenceKeysPrivate.h:
1018         * WebView/WebPreferences.mm:
1019         (-[WebPreferences linkPreloadEnabled]):
1020         (-[WebPreferences setLinkPreloadEnabled:]):
1021         * WebView/WebPreferencesPrivate.h:
1022         * WebView/WebView.mm:
1023         (-[WebView _preferencesChanged:]):
1024
1025 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1026
1027         Add User Timing Experimental Feature
1028         https://bugs.webkit.org/show_bug.cgi?id=167542
1029         <rdar://problem/22746307>
1030
1031         Reviewed by Ryosuke Niwa.
1032
1033         * WebView/WebPreferenceKeysPrivate.h:
1034         * WebView/WebPreferences.mm:
1035         (+[WebPreferences initialize]):
1036         (-[WebPreferences userTimingEnabled]):
1037         (-[WebPreferences setUserTimingEnabled:]):
1038         * WebView/WebPreferencesPrivate.h:
1039         * WebView/WebView.mm:
1040         (-[WebView _preferencesChanged:]):
1041         Add setting for User Timing runtime enabled feature.
1042
1043 2017-01-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1044
1045         [WK1] Do not prevent the drag client from initializing on Mac
1046         https://bugs.webkit.org/show_bug.cgi?id=167541
1047
1048         Reviewed by Dan Bernstein.
1049
1050         Fixes fallout from r211192. To ensure compability with WebKit clients, we need to ensure that WebDragClient is
1051         initialized everywhere when creating a WebView. Stub out method implementations as no-ops for non-Mac platforms.
1052         This caused certain clients, such as Mail, to crash when a webView closes due to  null dereference.
1053
1054         * WebCoreSupport/WebDragClient.mm:
1055         (WebDragClient::WebDragClient):
1056         (WebDragClient::actionMaskForDrag):
1057         (WebDragClient::willPerformDragDestinationAction):
1058         (WebDragClient::dragSourceActionMaskForPoint):
1059         (WebDragClient::willPerformDragSourceAction):
1060         (WebDragClient::startDrag):
1061         (WebDragClient::declareAndWriteDragImage):
1062         (WebDragClient::declareAndWriteAttachment):
1063         * WebView/WebView.mm:
1064         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1065
1066 2017-01-26  Chris Dumez  <cdumez@apple.com>
1067
1068         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1069         https://bugs.webkit.org/show_bug.cgi?id=167421
1070         <rdar://problem/30188490>
1071
1072         Reviewed by Darin Adler.
1073
1074         Add a new setting allowing layout tests to enable PageCache in a window
1075         that has an opener, for convenience.
1076
1077         * WebView/WebPreferenceKeysPrivate.h:
1078         * WebView/WebPreferences.mm:
1079         (+[WebPreferences initialize]):
1080         (-[WebPreferences allowsPageCacheWithWindowOpener]):
1081         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]):
1082         * WebView/WebPreferencesPrivate.h:
1083         * WebView/WebView.mm:
1084         (-[WebView _preferencesChanged:]):
1085
1086 2017-01-26  Keith Miller  <keith_miller@apple.com>
1087
1088         classInfo should take a VM so it is not materialized from the object on each call
1089         https://bugs.webkit.org/show_bug.cgi?id=167424
1090
1091         Rubber Stamped by Michael Saboff.
1092
1093         Previously, classInfo() would get the VM from the target's
1094         MarkedBlock.  Most callers already have a VM on hand, so it is
1095         wasteful to compute the VM from the marked block every time. This
1096         patch refactors some of the most common callers of classInfo(),
1097         jsDynamicCast and inherits to take a VM as well.
1098
1099         * DOM/DOM.mm:
1100         (+[DOMNode _nodeFromJSWrapper:]):
1101         * DOM/DOMUtility.mm:
1102         (createDOMWrapper):
1103         * DOM/WebDOMOperations.mm:
1104         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1105         (WebKit::getObjectID):
1106         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
1107         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
1108         * Plugins/Hosted/ProxyInstance.mm:
1109         (WebKit::ProxyRuntimeMethod::finishCreation):
1110         (WebKit::ProxyInstance::invokeMethod):
1111         * Plugins/Hosted/ProxyRuntimeObject.mm:
1112         (WebKit::ProxyRuntimeObject::finishCreation):
1113         * WebView/WebFrame.mm:
1114         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
1115         * WebView/WebView.mm:
1116         (+[WebView _reportException:inContext:]):
1117         (aeDescFromJSValue):
1118         (-[WebView _notificationIDForTesting:]):
1119
1120 2017-01-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1121
1122         REGRESSION (r207483): Touch Bar: Lists and BIU Buttons Missing from Touch Bar in HTML Notes
1123         https://bugs.webkit.org/show_bug.cgi?id=167472
1124         <rdar://problem/30149809>
1125
1126         Reviewed by Beth Dakin.
1127
1128         Revision 207483 caused the touch bar to stop showing up in HTML Notes due to -updateTextTouchBar not
1129         initializing the text touch bar and causing -makeTouchBar to return nil while processing a mouse click. The
1130         purpose of bailing out of the update was to prevent the text touch bar from thrashing during a selection drag.
1131         If the text touch bar doesn't exist yet, we don't have to worry about its appearance flickering from a different
1132         previous state, so we should just allow the touch bar to update instead.
1133
1134         * WebView/WebView.mm:
1135         (-[WebView updateTextTouchBar]):
1136
1137 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1138
1139         Crash when setting custom scale factor.
1140         https://bugs.webkit.org/show_bug.cgi?id=167369
1141
1142         Reviewed by Sam Weinig.
1143
1144         Add null pointer check.
1145
1146         * WebView/WebView.mm:
1147         (-[WebView _setCustomBackingScaleFactor:]):
1148
1149 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1150
1151         Refactor drag and drop implementation on Mac
1152         https://bugs.webkit.org/show_bug.cgi?id=167427
1153
1154         Reviewed by Enrica Casucci.
1155
1156         Refactor some WebKit1 code on the Mac pertaining to drag and drop. See WebCore ChangeLog for more details.
1157
1158         * Misc/WebNSPasteboardExtras.h:
1159         * WebCoreSupport/WebDragClient.mm:
1160         * WebView/WebFrame.mm:
1161         * WebView/WebFrameInternal.h:
1162         * WebView/WebHTMLView.mm:
1163         * WebView/WebView.mm:
1164         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1165
1166 2017-01-24  Youenn Fablet  <youennf@gmail.com>
1167
1168         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
1169         https://bugs.webkit.org/show_bug.cgi?id=167294
1170
1171         Reviewed by Alex Christensen.
1172
1173         * WebView/WebView.mm:
1174         (-[WebView _commonInitializationWithFrameName:groupName:]):
1175
1176 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1177
1178         Add support for named pasteboards, pasteboard strategies and platform pasteboards
1179         https://bugs.webkit.org/show_bug.cgi?id=167404
1180
1181         Reviewed by Enrica Casucci.
1182
1183         Adds pasteboard name as an argument to pasteboard-related WebPlatformStrategy methods.
1184
1185         * WebCoreSupport/WebPlatformStrategies.h:
1186         * WebCoreSupport/WebPlatformStrategies.mm:
1187         (WebPlatformStrategies::writeToPasteboard):
1188         (WebPlatformStrategies::getPasteboardItemsCount):
1189         (WebPlatformStrategies::readBufferFromPasteboard):
1190         (WebPlatformStrategies::readURLFromPasteboard):
1191         (WebPlatformStrategies::readStringFromPasteboard):
1192
1193 2017-01-25  Aakash Jain  <aakash_jain@apple.com>
1194
1195         LoadWebLocalizedStrings method should be moved in correct file
1196         https://bugs.webkit.org/show_bug.cgi?id=167393
1197
1198         Reviewed by Alexey Proskuryakov.
1199
1200         * Misc/WebLocalizableStrings.h: Deleted LoadWebLocalizedStrings method.
1201         * Misc/WebLocalizableStrings.mm:
1202         (LoadWebLocalizedStringsTimerCallback): Deleted, moved to WebUIKitSupport.mm
1203         (LoadWebLocalizedStrings): Deleted, moved to WebUIKitSupport.mm
1204
1205 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1206
1207         Add simple line layout toggle to MiniBrowser
1208         https://bugs.webkit.org/show_bug.cgi?id=167405
1209
1210         Reviewed by Andreas Kling.
1211
1212         * WebView/WebPreferenceKeysPrivate.h:
1213         * WebView/WebPreferences.mm:
1214         (+[WebPreferences initialize]):
1215         (-[WebPreferences simpleLineLayoutEnabled]):
1216         (-[WebPreferences setSimpleLineLayoutEnabled:]):
1217         * WebView/WebPreferencesPrivate.h:
1218         * WebView/WebView.mm:
1219         (-[WebView _preferencesChanged:]):
1220
1221 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1222
1223         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1224         https://bugs.webkit.org/show_bug.cgi?id=167394
1225
1226         Reviewed by Ryosuke Niwa.
1227
1228         * Configurations/FeatureDefines.xcconfig:
1229
1230 2017-01-23  Chris Dumez  <cdumez@apple.com>
1231
1232         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
1233         https://bugs.webkit.org/show_bug.cgi?id=167308
1234         <rdar://problem/30144964>
1235
1236         Unreviewed, do a partial revert of r211033 to fix assertion.
1237
1238         * WebCoreSupport/WebChromeClient.h:
1239         * WebCoreSupport/WebChromeClient.mm:
1240         (WebChromeClient::exitFullScreenForElement):
1241
1242 2017-01-23  Joseph Pecoraro  <pecoraro@apple.com>
1243
1244         Remove allowWindowOpenWithoutUserGesture setting
1245         https://bugs.webkit.org/show_bug.cgi?id=167301
1246
1247         Reviewed by Darin Adler.
1248
1249         * WebView/WebView.mm:
1250         (-[WebView _preferencesChanged:]):
1251         Use the equivalent existing setting.
1252
1253 2017-01-20  Darin Adler  <darin@apple.com>
1254
1255         Remove PassRefPtr from "page" directory of WebCore, also deploy references
1256         https://bugs.webkit.org/show_bug.cgi?id=167224
1257
1258         Reviewed by Chris Dumez.
1259
1260         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
1261         (-[WebApplicationCacheQuotaManager quota]): Pass reference.
1262
1263         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
1264         * WebCoreSupport/WebChromeClient.mm:
1265         (WebChromeClient::focusedElementChanged): Ditto.
1266         (WebChromeClient::createWindow): Ditto.
1267         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
1268         (WebChromeClient::runJavaScriptAlert): Ditto.
1269         (WebChromeClient::runJavaScriptConfirm): Ditto.
1270         (WebChromeClient::runJavaScriptPrompt): Ditto.
1271         (WebChromeClient::contentsSizeChanged): Ditto.
1272         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
1273         (WebChromeClient::print): Ditto.
1274         (WebChromeClient::exceededDatabaseQuota): Ditto.
1275         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
1276         (WebChromeClient::createColorChooser): Ditto.
1277         (WebChromeClient::elementDidFocus): Ditto.
1278         (WebChromeClient::elementDidBlur): Ditto.
1279         (WebChromeClient::createPopupMenu): Ditto.
1280         (WebChromeClient::createSearchPopupMenu): Ditto.
1281         (WebChromeClient::attachRootGraphicsLayer): Ditto.
1282         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
1283         (WebChromeClient::supportsFullScreenForElement): Ditto.
1284         (WebChromeClient::enterFullScreenForElement): Ditto.
1285         (WebChromeClient::exitFullScreenForElement): Ditto.
1286
1287         * WebView/WebFrame.mm:
1288         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
1289         Updated for change to the appendChild function.
1290
1291 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
1292
1293         Remove -[WebFrame sendOrientationChangeEvent:] which is unused
1294         https://bugs.webkit.org/show_bug.cgi?id=167276
1295
1296         Reviewed by Alex Christensen.
1297         
1298         It was usurped by -deviceOrientationChanged in 2014.
1299
1300         * WebView/WebFrame.mm:
1301         (-[WebFrame sendOrientationChangeEvent:]): Deleted.
1302         * WebView/WebFramePrivate.h:
1303
1304 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
1305
1306         Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
1307         https://bugs.webkit.org/show_bug.cgi?id=167271
1308
1309         Reviewed by Alex Christensen.
1310         
1311         -_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
1312         overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),
1313
1314         * WebView/WebView.mm:
1315         (-[WebView _contentsSizeRespectingOverflow]): Deleted.
1316         * WebView/WebViewPrivate.h:
1317
1318 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1319
1320         Remove never changing IndexedDB RuntimeEnabledFeature
1321         https://bugs.webkit.org/show_bug.cgi?id=167278
1322
1323         Reviewed by Darin Adler.
1324
1325         * WebView/WebView.mm:
1326         (-[WebView _preferencesChanged:]):
1327
1328 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1329
1330         Cleanup RuntimeEnabledFeatures
1331         https://bugs.webkit.org/show_bug.cgi?id=167228
1332
1333         Reviewed by Simon Fraser.
1334
1335         * WebView/WebView.mm:
1336         (-[WebView _preferencesChanged:]):
1337
1338 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1339
1340         Remove outdated ENABLE(CSP_NEXT) build flag
1341         https://bugs.webkit.org/show_bug.cgi?id=167252
1342
1343         Reviewed by Brent Fulgham.
1344
1345         * Configurations/FeatureDefines.xcconfig:
1346
1347 2017-01-20  Antoine Quint  <graouts@apple.com>
1348
1349         [Modern Media Controls] Turn modern media controls on by default
1350         https://bugs.webkit.org/show_bug.cgi?id=165668
1351
1352         Reviewed by Dean Jackson.
1353
1354         Enabled modern media controls by default in WK1.
1355
1356         * WebView/WebPreferences.mm:
1357         (+[WebPreferences initialize]):
1358
1359 2017-01-19  Chris Dumez  <cdumez@apple.com>
1360
1361         iterable<> should be enabled on WK1
1362         https://bugs.webkit.org/show_bug.cgi?id=167221
1363         <rdar://problem/30108531>
1364
1365         Reviewed by Youenn Fablet.
1366
1367         * WebView/WebPreferenceKeysPrivate.h:
1368         * WebView/WebPreferences.mm:
1369         (-[WebPreferences setCustomElementsEnabled:]):
1370         (-[WebPreferences DOMIteratorEnabled]): Deleted.
1371         (-[WebPreferences setDOMIteratorEnabled:]): Deleted.
1372         * WebView/WebPreferencesPrivate.h:
1373         * WebView/WebView.mm:
1374         (-[WebView _preferencesChanged:]):
1375
1376 2017-01-19  Chris Dumez  <cdumez@apple.com>
1377
1378         Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached
1379         https://bugs.webkit.org/show_bug.cgi?id=167215
1380         <rdar://problem/29885052>
1381
1382         Reviewed by Andreas Kling.
1383
1384         Make sure HTML validation bubble gets dismissed when its associated
1385         element's frame gets detached and that we do not crash.
1386
1387         * WebCoreSupport/WebValidationMessageClient.h:
1388         * WebCoreSupport/WebValidationMessageClient.mm:
1389         (WebValidationMessageClient::documentDetached):
1390
1391 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1392
1393         [Cocoa] Variation fonts are erroneously disabled on iOS
1394         https://bugs.webkit.org/show_bug.cgi?id=167172
1395
1396         Reviewed by Simon Fraser.
1397
1398         OpenSource builders don't seem to understand sdk=embedded*.
1399
1400         * Configurations/FeatureDefines.xcconfig:
1401
1402 2017-01-19  Andreas Kling  <akling@apple.com>
1403
1404         ScriptExecutionContext::topOrigin() should return a reference.
1405         <https://webkit.org/b/167190>
1406
1407         Reviewed by Sam Weinig.
1408
1409         * Misc/WebCache.mm:
1410         (+[WebCache addImageToCache:forURL:forFrame:]):
1411         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1412
1413 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1414
1415         Unreviewed fix for the macOS build.
1416
1417         * Carbon/CarbonWindowAdapter.mm:
1418         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1419
1420 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1421
1422         Unreviewed, rolling out r210848.
1423
1424         This change introduced media-related LayoutTest failures and
1425         crashes on macOS.
1426
1427         Reverted changeset:
1428
1429         "[Modern Media Controls] Turn modern media controls on by
1430         default"
1431         https://bugs.webkit.org/show_bug.cgi?id=165668
1432         http://trac.webkit.org/changeset/210848
1433
1434 2017-01-18  Andreas Kling  <akling@apple.com>
1435
1436         Document::securityOrigin() should return a reference.
1437         <https://webkit.org/b/167124>
1438
1439         Reviewed by Sam Weinig.
1440
1441         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1442         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1443         * Plugins/WebNetscapePluginStream.mm:
1444         (WebNetscapePluginStream::WebNetscapePluginStream):
1445         * Plugins/WebNetscapePluginView.mm:
1446         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1447         * Plugins/WebPluginContainerCheck.mm:
1448         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
1449         * WebCoreSupport/WebChromeClient.mm:
1450         (WebChromeClient::exceededDatabaseQuota):
1451         * WebCoreSupport/WebFrameLoaderClient.h:
1452         * WebCoreSupport/WebFrameLoaderClient.mm:
1453         (WebFrameLoaderClient::didRunInsecureContent):
1454         * WebCoreSupport/WebGeolocationClient.mm:
1455         (WebGeolocationClient::requestPermission):
1456         (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
1457         * WebView/WebFrame.mm:
1458         (-[WebFrame _allowsFollowingLink:]):
1459
1460 2017-01-18  Antoine Quint  <graouts@apple.com>
1461
1462         [Modern Media Controls] Turn modern media controls on by default
1463         https://bugs.webkit.org/show_bug.cgi?id=165668
1464
1465         Reviewed by Dean Jackson.
1466
1467         Enabled modern media controls by default in WK1. 
1468
1469         * WebView/WebPreferences.mm:
1470         (+[WebPreferences initialize]):
1471
1472 2017-01-15  Darin Adler  <darin@apple.com>
1473
1474         Remove PassRefPtr from "loader" directory of WebCore
1475         https://bugs.webkit.org/show_bug.cgi?id=167055
1476
1477         Reviewed by Alex Christensen.
1478
1479         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
1480         Also made class final and most functions private and final.
1481         * WebCoreSupport/WebChromeClient.mm:
1482         (WebChromeClient::runOpenPanel): Updated to take references.
1483
1484         * WebCoreSupport/WebEditorClient.h: Updated for changes to EditorClient.
1485         * WebCoreSupport/WebEditorClient.mm:
1486         (-[WebUndoStep initWithUndoStep:]): Take reference instead of PassRefPtr.
1487         (+[WebUndoStep stepWithUndoStep:]): Ditto.
1488         (-[WebUndoStep step]): Return reference instead of pointer.
1489         (-[WebEditorUndoTarget undoEditing:]): Updated for the above.
1490         (-[WebEditorUndoTarget redoEditing:]): Ditto.
1491         (WebEditorClient::registerUndoOrRedoStep): Take reference instead of
1492         PassRefPtr.
1493         (WebEditorClient::registerUndoStep): Ditto.
1494         (WebEditorClient::registerRedoStep): Ditto.
1495
1496         * WebCoreSupport/WebFrameLoaderClient.h: Updated for changes to
1497         FrameLoaderClient, marked functions final instead of override.
1498         * WebCoreSupport/WebFrameLoaderClient.mm:
1499         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Take
1500         pointer instead of PassRefPtr.
1501         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
1502         (makeFormFieldValuesDictionary): Take a reference.
1503         (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Take Ref&& instead
1504         of PassRefPtr.
1505         (WebFrameLoaderClient::dispatchWillSubmitForm): Take a reference instead
1506         of PassRefPtr.
1507         (WebFrameLoaderClient::actionDictionary): Take a pointer instead of PassRePtr.
1508         (WebFrameLoaderClient::createFrame): Take a reference instead of a pointer.
1509         (WebFrameLoaderClient::createPlugin): Ditto.
1510         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
1511         (WebFrameLoaderClient::createNetworkingContext): Ditto.
1512         (WebFrameLoaderClient::didCreateQuickLookHandle): Pass a reference.
1513
1514         * WebCoreSupport/WebFrameNetworkingContext.h: Use Ref instead of PassRefPtr.
1515         * WebCoreSupport/WebFrameNetworkingContext.mm: Tweak style a bit.
1516
1517         * WebCoreSupport/WebOpenPanelResultListener.h: Take a reference instead of
1518         PassRefPtr. Use RefPtr for class field.
1519         * WebCoreSupport/WebOpenPanelResultListener.mm:
1520         (-[WebOpenPanelResultListener dealloc]): Deleted. Compiler will now do it
1521         correctly without us declaring anything explicitly.
1522         (-[WebOpenPanelResultListener cancel]): Get rid of hand-written deref code,
1523         and let RefPtr do the work.
1524         (-[WebOpenPanelResultListener chooseFilename:]): Ditto.
1525         (-[WebOpenPanelResultListener chooseFilenames:]): Ditto.
1526         (-[WebOpenPanelResultListener chooseFilenames:displayString:iconImage:]):
1527         Rewrote to use a modern Objective-C for loop, reserveInitialCapacity,
1528         and uncheckedAppend.
1529
1530         * WebView/WebArchive.mm:
1531         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
1532         Updated for changes to LegacyWebArchive.
1533         (-[WebArchive mainResource]): Ditto.
1534         (-[WebArchive subresources]): Ditto.
1535         (-[WebArchive subframeArchives]): Ditto.
1536
1537         * WebView/WebDataSource.mm:
1538         (-[WebDataSource _addSubframeArchives:]): Use a modern Objective-C for loop
1539         instead of NSEnumerator.
1540         (-[WebDataSource _fileWrapperForURL:]): Use auto.
1541         (-[WebDataSource _documentFragmentWithArchive:]): Pass a reference.
1542         (-[WebDataSource mainResource]): Ditto.
1543         (-[WebDataSource subresources]): Ditto.
1544         (-[WebDataSource subresourceForURL:]): Ditto.
1545         (-[WebDataSource addSubresource:]): Ditto.
1546
1547         * WebView/WebResource.mm:
1548         (-[WebResourcePrivate initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
1549         (-[WebResourcePrivate dealloc]): Remove explicit deref since RefPtr will now take
1550         care of it
1551         (-[WebResource initWithCoder:]): Pass a reference.
1552         (-[WebResource encodeWithCoder:]): Updated since coreResource is now RefPtr.
1553         (-[WebResource _initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
1554         (-[WebResource _coreResource]): Return reference rather than pointer.
1555         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1556         Added code to handle the null case and pass a reference rather than a pointer.
1557         * WebView/WebResourceInternal.h: Updated for the above.
1558
1559 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1560
1561         Unreviewed, rolling out r210834
1562         https://bugs.webkit.org/show_bug.cgi?id=165668
1563
1564         It introduced dozens of test timeouts.
1565
1566         Reverted changeset:
1567         "[Modern Media Controls] Turn modern media controls on by default"
1568         https://bugs.webkit.org/show_bug.cgi?id=165668
1569         http://trac.webkit.org/changeset/210834
1570
1571 2017-01-17  Antoine Quint  <graouts@apple.com>
1572
1573         [Modern Media Controls] Turn modern media controls on by default
1574         https://bugs.webkit.org/show_bug.cgi?id=165668
1575
1576         Reviewed by Dean Jackson.
1577
1578         Enabled modern media controls by default in WK1. 
1579
1580         * WebView/WebPreferences.mm:
1581         (+[WebPreferences initialize]):
1582
1583 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1584
1585         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
1586         https://bugs.webkit.org/show_bug.cgi?id=116551
1587         <rdar://problem/13949830>
1588
1589         Reviewed by Alex Christensen.
1590
1591         * Configurations/FeatureDefines.xcconfig:
1592
1593 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1594
1595         Crash when closing tab with debugger paused
1596         https://bugs.webkit.org/show_bug.cgi?id=161746
1597         <rdar://problem/15607819>
1598
1599         Reviewed by Brian Burg and Brent Fulgham.
1600
1601         * WebView/WebView.mm:
1602         (WebKit::DeferredPageDestructor::createDeferredPageDestructor):
1603         (WebKit::DeferredPageDestructor::DeferredPageDestructor):
1604         (WebKit::DeferredPageDestructor::tryDestruction):
1605         (-[WebView _close]):
1606         Defer destruction of the Page if we are in a nested runloop.
1607
1608 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
1609
1610         Remove the REQUEST_ANIMATION_FRAME flag
1611         https://bugs.webkit.org/show_bug.cgi?id=156980
1612         <rdar://problem/25906849>
1613
1614         Reviewed by Simon Fraser.
1615
1616         * Configurations/FeatureDefines.xcconfig:
1617
1618 2017-01-16  Andy Estes  <aestes@apple.com>
1619
1620         [QuickLook] Do some cleanup in QuickLookHandle
1621         https://bugs.webkit.org/show_bug.cgi?id=166864
1622
1623         Reviewed by Darin Adler.
1624
1625         * WebCoreSupport/WebFrameLoaderClient.mm:
1626         (WebFrameLoaderClient::didCreateQuickLookHandle): Changed to pass a
1627         Ref<QuickLookHandleClient>&& to QuickLookHandle::setClient().
1628
1629 2017-01-15  Tim Horton  <timothy_horton@apple.com>
1630
1631         De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm
1632         https://bugs.webkit.org/show_bug.cgi?id=167063
1633
1634         Reviewed by Dan Bernstein.
1635
1636         * WebView/WebHTMLView.mm:
1637         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
1638         (-[WebHTMLView _updateFontPanel]):
1639         * WebView/WebView.mm:
1640         (-[WebView typingAttributes]):
1641         Adjust to fontAttributesForSelectionStart returning a RetainPtr.
1642
1643 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
1644
1645         Remove ENABLE(DETAILS_ELEMENT) guards
1646         https://bugs.webkit.org/show_bug.cgi?id=167042
1647
1648         Reviewed by Alex Christensen.
1649
1650         * Configurations/FeatureDefines.xcconfig:
1651
1652 2017-01-11  Darin Adler  <darin@apple.com>
1653
1654         Remove PassRefPtr from more of "platform"
1655         https://bugs.webkit.org/show_bug.cgi?id=166809
1656
1657         Reviewed by Sam Weinig.
1658
1659         * WebCoreSupport/WebFrameLoaderClient.mm:
1660         (NetscapePluginWidget::handleEvent): Pass a reference.
1661         * WebView/WebView.mm:
1662         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
1663         Updated since the children set now contains Ref instead of RefPtr.
1664
1665 2017-01-13  Sam Weinig  <sam@webkit.org>
1666
1667         [WebIDL] Remove custom bindings for DeviceMotionEvent and DeviceOrientationEvent
1668         https://bugs.webkit.org/show_bug.cgi?id=167006
1669
1670         Reviewed by Geoffrey Garen.
1671
1672         * WebView/WebDeviceOrientation.mm:
1673         (convert):
1674         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1675         Update for new use of std::optional.
1676
1677 2017-01-12  Joseph Pecoraro  <pecoraro@apple.com>
1678
1679         Remove unnecessary includes of Page.h
1680         https://bugs.webkit.org/show_bug.cgi?id=166996
1681
1682         Reviewed by Yusuke Suzuki.
1683
1684         * DOM/DOMHTML.mm:
1685         * History/WebBackForwardList.mm:
1686         * Plugins/WebPluginController.mm:
1687         * WebCoreSupport/WebNotificationClient.mm:
1688         * WebCoreSupport/WebPlatformStrategies.mm:
1689         * WebCoreSupport/WebUserMediaClient.mm:
1690         * WebView/WebFullScreenController.mm:
1691
1692 2017-01-12  Chris Dumez  <cdumez@apple.com>
1693
1694         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1695         https://bugs.webkit.org/show_bug.cgi?id=166995
1696
1697         Reviewed by Jer Noble.
1698
1699         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1700         as some people are having trouble building without it.
1701
1702         * Configurations/FeatureDefines.xcconfig:
1703
1704 2017-01-12  Chris Dumez  <cdumez@apple.com>
1705
1706         HTML form validation popover sometimes does not go away
1707         https://bugs.webkit.org/show_bug.cgi?id=166990
1708         <rdar://problem/29985957>
1709
1710         Reviewed by Tim Horton.
1711
1712         Update code using ValidationBubble now that it is RefCounted.
1713
1714         * WebView/WebView.mm:
1715         (-[WebView showFormValidationMessage:withAnchorRect:]):
1716
1717 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1718
1719         Remove pointerLockElement from DOMDocumentPrivate.h
1720         https://bugs.webkit.org/show_bug.cgi?id=166882
1721
1722         Reviewed by Simon Fraser.
1723
1724         Removed pointerLockElement declaration that was supposed to be removed in r209637.
1725
1726         * DOM/DOMDocumentPrivate.h:
1727
1728 2017-01-06  Darin Adler  <darin@apple.com>
1729
1730         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
1731         https://bugs.webkit.org/show_bug.cgi?id=166797
1732
1733         Reviewed by Alex Christensen.
1734
1735         * WebCoreSupport/WebEditorClient.h: Updated to take a reference.
1736         * WebCoreSupport/WebEditorClient.mm:
1737         (WebEditorClient::requestCheckingOfString): Take a reference
1738         instead of a PassRefPtr.
1739
1740 2017-01-05  Chris Dumez  <cdumez@apple.com>
1741
1742         Turn preferLowPowerWebGLRendering setting on by default
1743         https://bugs.webkit.org/show_bug.cgi?id=166737
1744         <rdar://problem/29870033>
1745
1746         Reviewed by Dean Jackson.
1747
1748         Temporarily turn preferLowPowerWebGLRendering setting on by default until
1749         we deal better with WebGL content in background tabs.
1750
1751         * WebView/WebPreferences.mm:
1752         (+[WebPreferences initialize]):
1753
1754 2017-01-05  Enrica Casucci  <enrica@apple.com>
1755
1756         Support File Promise during drag for macOS.
1757         https://bugs.webkit.org/show_bug.cgi?id=165204
1758         rdar://problem/19595567
1759
1760         Reviewed by Tim Horton.
1761
1762         Adds support for dropping a File Promise in a WebView.
1763         The implementation uses new File Promise API available in Sierra.
1764
1765         * Misc/WebNSPasteboardExtras.mm:
1766         (+[NSPasteboard _web_dragTypesForURL]):
1767         * WebView/WebView.mm:
1768         (-[WebView performDragOperation:]):
1769
1770 2017-01-05  Andreas Kling  <akling@apple.com>
1771
1772         Remove ChromeClient::needTouchEvents().
1773         <https://webkit.org/b/166723>
1774
1775         Rubber-stamped by Antti Koivisto.
1776
1777         * WebCoreSupport/WebChromeClient.h:
1778
1779 2017-01-04  Darin Adler  <darin@apple.com>
1780
1781         Remove PassRefPtr use from the "html" directory, other improvements
1782         https://bugs.webkit.org/show_bug.cgi?id=166635
1783
1784         Reviewed by Alex Christensen.
1785
1786         * WebCoreSupport/WebChromeClient.h:
1787         * WebCoreSupport/WebChromeClient.mm:
1788         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
1789
1790 2017-01-04  Ryan Haddad  <ryanhaddad@apple.com>
1791
1792         Unreviewed, rolling out r210287.
1793
1794         This change caused editing test failures on macOS.
1795
1796         Reverted changeset:
1797
1798         "Support File Promise during drag for macOS."
1799         https://bugs.webkit.org/show_bug.cgi?id=165204
1800         http://trac.webkit.org/changeset/210287
1801
1802 2017-01-04  Enrica Casucci  <enrica@apple.com>
1803
1804         Support File Promise during drag for macOS.
1805         https://bugs.webkit.org/show_bug.cgi?id=165204
1806         rdar://problem/19595567
1807
1808         Reviewed by Tim Horton.
1809
1810         Adds support for dropping a File Promise in a WebView.
1811         The implementation uses new File Promise API available in Sierra.
1812
1813         * Misc/WebNSPasteboardExtras.mm:
1814         (+[NSPasteboard _web_dragTypesForURL]):
1815         * WebView/WebView.mm:
1816         (-[WebView performDragOperation:]):
1817
1818 2017-01-04  Tim Horton  <timothy_horton@apple.com>
1819
1820         Provide a setting for clients to always prefer low-power WebGL
1821         https://bugs.webkit.org/show_bug.cgi?id=166675
1822         <rdar://problem/29834093>
1823
1824         Reviewed by Dan Bernstein.
1825
1826         * WebView/WebPreferenceKeysPrivate.h:
1827         * WebView/WebPreferences.mm:
1828         (+[WebPreferences initialize]):
1829         (-[WebPreferences preferLowPowerWebGLRendering]):
1830         (-[WebPreferences setPreferLowPowerWebGLRendering:]):
1831         * WebView/WebPreferencesPrivate.h:
1832         * WebView/WebView.mm:
1833         (-[WebView _preferencesChanged:]):
1834         Expose a new private preferLowPowerWebGLRendering WebKit1 preference.
1835
1836 2017-01-03  Tim Horton  <timothy_horton@apple.com>
1837
1838         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
1839         https://bugs.webkit.org/show_bug.cgi?id=166450
1840         <rdar://problem/29447824>
1841
1842         Reviewed by Darin Adler.
1843
1844         * WebCoreSupport/CorrectionPanel.h:
1845         * WebCoreSupport/CorrectionPanel.mm:
1846         (CorrectionPanel::recordAutocorrectionResponse):
1847         (CorrectionPanel::handleAcceptedReplacement):
1848         * WebCoreSupport/WebAlternativeTextClient.mm:
1849         (toCorrectionResponse):
1850         (WebAlternativeTextClient::recordAutocorrectionResponse):
1851         Funnel all calls to recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
1852         through recordAutocorrectionResponse, for debugging's sake.
1853         Drop the NSView parameter because we don't need it, just the tag.
1854         Convert the new AutocorrectionResponseType value to its corresponding
1855         NSCorrectionResponse value.
1856
1857 2017-01-01  Jeff Miller  <jeffm@apple.com>
1858
1859         Update user-visible copyright strings to include 2017
1860         https://bugs.webkit.org/show_bug.cgi?id=166278
1861
1862         Reviewed by Dan Bernstein.
1863
1864         * Info.plist:
1865
1866 2016-12-30  Darin Adler  <darin@apple.com>
1867
1868         Remove PassRefPtr use from the "dom" directory, related cleanup
1869         https://bugs.webkit.org/show_bug.cgi?id=166569
1870
1871         Reviewed by Alex Christensen.
1872
1873         * WebCoreSupport/WebFrameLoaderClient.mm:
1874         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated to use struct.
1875         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
1876         (WebFrameLoaderClient::setTitle): Ditto.
1877         (WebFrameLoaderClient::transitionToCommittedForNewPage): Ditto.
1878         * WebView/WebFrame.mm:
1879         (-[WebFrame _dispatchDidReceiveTitle:]): Use aggregate-style syntax for StringWithDirection.
1880         Not needed now, but useful later if we ever can get rid of the explicit constructors.
1881         (-[WebFrame loadArchive:]): Pass a reference to loadArchive.
1882         * WebView/WebHTMLRepresentation.mm:
1883         (-[WebHTMLRepresentation title]): Updated to use struct.
1884
1885 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
1886
1887         Propagate the source origin as much as possible
1888         https://bugs.webkit.org/show_bug.cgi?id=166348
1889
1890         Reviewed by Darin Adler.
1891
1892         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1893         (WebKit::NetscapePluginInstanceProxy::evaluate):
1894
1895 2016-12-23  Andy Estes  <aestes@apple.com>
1896
1897         [iOS] DumpRenderTree triggers an assertion failure when calling +[WebPreferences _switchNetworkLoaderToNewTestingSession]
1898         https://bugs.webkit.org/show_bug.cgi?id=166471
1899
1900         Reviewed by Andreas Kling.
1901
1902         When DumpRenderTree starts up, it calls
1903         +[WebPreferences _switchNetworkLoaderToNewTestingSession] from the main thread. In Debug
1904         builds, this triggers the ASSERT(isMainThread()) in
1905         NetworkStorageSession::defaultNetworkStorageSession() because the Web thread has already
1906         started, we are on the main thread, and we are not holding the Web thread lock. This is
1907         causing all layout tests to crash in the iOS WK1 Debug configuration.
1908
1909         * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1910         Take the Web thread lock before calling NetworkStorageSession::switchToNewTestingSession().
1911
1912 2016-12-22  Andy Estes  <aestes@apple.com>
1913
1914         Make WebCore::EditorInsertAction an enum class
1915         https://bugs.webkit.org/show_bug.cgi?id=166424
1916
1917         Reviewed by Brent Fulgham.
1918
1919         * WebCoreSupport/WebEditorClient.mm:
1920         (kit):
1921
1922 2016-12-21  Beth Dakin  <bdakin@apple.com>
1923
1924         Holding down on candidates in the TouchBar should show panel on screen
1925         https://bugs.webkit.org/show_bug.cgi?id=166367
1926         -and corresponding-
1927         <rdar://problem/28479236>
1928
1929         Reviewed by Tim Horton.
1930
1931         Stray whitespace.
1932         * WebCoreSupport/WebEditorClient.mm:
1933         (WebEditorClient::handleRequestedCandidates):
1934
1935         Call the version of setCandidates: that takes a rect. We need to keep the helper 
1936         function in WK1 (unlike WK2) since we also use it for testing.
1937         * WebView/WebView.mm:
1938         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
1939
1940 2016-12-20  Dean Jackson  <dino@apple.com>
1941
1942         Remove INDIE_UI
1943         https://bugs.webkit.org/show_bug.cgi?id=165881
1944         <rdar://problem/29672532>
1945
1946         Reviewed by Simon Fraser.
1947
1948         The Indie UI work has been discontinued.
1949
1950         * Configurations/FeatureDefines.xcconfig:
1951
1952 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1953
1954         [ES6] Enable ES6 Modules
1955         https://bugs.webkit.org/show_bug.cgi?id=165849
1956
1957         Reviewed by Geoffrey Garen.
1958
1959         * WebView/WebPreferenceKeysPrivate.h:
1960         * WebView/WebPreferences.mm:
1961         (+[WebPreferences initialize]):
1962         (-[WebPreferences es6ModulesEnabled]): Deleted.
1963         (-[WebPreferences setES6ModulesEnabled:]): Deleted.
1964         * WebView/WebPreferencesPrivate.h:
1965         * WebView/WebView.mm:
1966         (-[WebView _preferencesChanged:]):
1967
1968 2016-12-16  Dave Hyatt  <hyatt@apple.com>
1969
1970         [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
1971         https://bugs.webkit.org/show_bug.cgi?id=165968
1972
1973         Reviewed by Andreas Kling.
1974
1975         * DOM/DOMCSS.mm:
1976         (kitClass):
1977         * DOM/DOMCSSPrimitiveValue.mm:
1978         (-[DOMCSSPrimitiveValue getCounterValue]):
1979         (-[DOMCSSPrimitiveValue getRectValue]):
1980         (kit):
1981         * DOM/DOMCSSPrimitiveValueInternal.h:
1982         * DOM/DOMCSSStyleDeclaration.mm:
1983         * DOM/DOMCSSValue.mm:
1984         (kit):
1985         * DOM/DOMCSSValueInternal.h:
1986         * DOM/DOMCSSValueList.mm:
1987         * DOM/DOMCounter.mm:
1988         (kit):
1989         * DOM/DOMCounterInternal.h:
1990         * DOM/DOMRGBColor.mm:
1991         (kit):
1992         * DOM/DOMRGBColorInternal.h:
1993         * DOM/DOMRect.mm:
1994         (kit):
1995         * DOM/DOMRectInternal.h:
1996         * DOM/DOMUtility.mm:
1997         (createDOMWrapper):
1998
1999 2016-12-16  Chris Dumez  <cdumez@apple.com>
2000
2001         HTML form validation bubble should be dismissed on navigation
2002         https://bugs.webkit.org/show_bug.cgi?id=165960
2003         <rdar://problem/29668086>
2004
2005         Reviewed by Simon Fraser.
2006
2007         Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
2008
2009         * WebView/WebView.mm:
2010         (-[WebView _didStartProvisionalLoadForFrame:]):
2011
2012 2016-12-15  Darin Adler  <darin@apple.com>
2013
2014         Use asString instead of toWTFString, toString, or getString when we already checked isString
2015         https://bugs.webkit.org/show_bug.cgi?id=165895
2016
2017         Reviewed by Yusuke Suzuki.
2018
2019         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2020         (WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
2021         toWTFString.
2022         * WebView/WebView.mm:
2023         (aeDescFromJSValue): Use asString/value instead of getString.
2024
2025 2016-12-15  Chris Dumez  <cdumez@apple.com>
2026
2027         Make sure HTML validation bubble's state is updated after layout
2028         https://bugs.webkit.org/show_bug.cgi?id=165922
2029         <rdar://problem/29694730>
2030
2031         Reviewed by Simon Fraser.
2032
2033         Make sure HTML validation bubble's state is updated after layout.
2034         In particular, if the validation bubble's associated element has
2035         moved or is no longer visible, we now hide the bubble.
2036
2037         * WebCoreSupport/WebValidationMessageClient.h:
2038         * WebCoreSupport/WebValidationMessageClient.mm:
2039         (WebValidationMessageClient::showValidationMessage):
2040         (WebValidationMessageClient::hideValidationMessage):
2041         (WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
2042
2043 2016-12-15  Chris Dumez  <cdumez@apple.com>
2044
2045         Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
2046         https://bugs.webkit.org/show_bug.cgi?id=165904
2047
2048         Reviewed by Sam Weinig.
2049
2050         Update ObjC bindings so they keep building.
2051
2052         * DOM/DOMUIEvent.mm:
2053         (-[DOMUIEvent keyCode]):
2054         (-[DOMUIEvent charCode]):
2055
2056 2016-12-15  Andreas Kling  <akling@apple.com>
2057
2058         Always clear RenderLayer backing stores when going into page cache.
2059         <https://webkit.org/b/165901>
2060
2061         Reviewed by Simon Fraser.
2062
2063         * WebView/WebView.mm:
2064         (+[WebView _setCacheModel:]):
2065
2066 2016-12-12  Alex Christensen  <achristensen@webkit.org>
2067
2068         Remove unused workaround for Silverlight
2069         https://bugs.webkit.org/show_bug.cgi?id=165773
2070
2071         Reviewed by Dean Jackson.
2072
2073         * Plugins/WebNetscapePluginView.mm:
2074         (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): Deleted.
2075         This code was introduced in January 2010.  Microsoft fixed their bug shortly thereafter.
2076         Allowing 6 years for users to update Silverlight is more than enough.
2077         Safari doesn't even use WebKit1 for this any more.
2078         I need this to be removed because this is the only non-WebGL code that needs to link against
2079         the OpenGL framework, and I'm changing how that is done to link only through ANGLE instead.
2080
2081 2016-12-12  Chris Dumez  <cdumez@apple.com>
2082
2083         Document.visibilityState should use an IDL string enumeration
2084         https://bugs.webkit.org/show_bug.cgi?id=165774
2085
2086         Reviewed by Daniel Bates.
2087
2088         * DOM/DOMDocument.mm:
2089         (-[DOMDocument visibilityState]):
2090         * WebView/WebView.mm:
2091         (kit):
2092
2093 2016-12-12  Jer Noble  <jer.noble@apple.com>
2094
2095         Remove implementation of legacy Mozilla-based Fullscreen API.
2096         https://bugs.webkit.org/show_bug.cgi?id=165689
2097         <rdar://problem/29603053>
2098
2099         Reviewed by Eric Carlson.
2100
2101         * DOM/DOMElement.mm:
2102         (-[DOMElement webkitRequestFullScreen:]):
2103
2104 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
2105
2106         The DOM should have an advancing wavefront opaque root barrier
2107         https://bugs.webkit.org/show_bug.cgi?id=165712
2108
2109         Reviewed by Yusuke Suzuki.
2110         
2111         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
2112
2113         * Misc/WebCoreStatistics.mm:
2114         (+[WebCoreStatistics javaScriptObjectsCount]):
2115         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
2116         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
2117         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
2118         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
2119         (+[WebCoreStatistics javaScriptObjectTypeCounts]):
2120         (+[WebCoreStatistics shouldPrintExceptions]):
2121         (+[WebCoreStatistics setShouldPrintExceptions:]):
2122         (+[WebCoreStatistics memoryStatistics]):
2123         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
2124         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2125         (identifierFromIdentifierRep):
2126         * Plugins/Hosted/ProxyInstance.mm:
2127         (WebKit::ProxyInstance::getPropertyNames):
2128         * Plugins/WebNetscapePluginStream.mm:
2129         (WebNetscapePluginStream::wantsAllStreams):
2130         * Plugins/WebNetscapePluginView.mm:
2131         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2132         (-[WebNetscapePluginView privateBrowsingModeDidChange]):
2133         (-[WebNetscapePluginView setWindowIfNecessary]):
2134         (-[WebNetscapePluginView createPluginScriptableObject]):
2135         (-[WebNetscapePluginView getFormValue:]):
2136         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
2137         (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
2138         (-[WebNetscapePluginView loadPluginRequest:]):
2139         (-[WebNetscapePluginView _printedPluginBitmap]):
2140         * Plugins/WebPluginController.mm:
2141         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2142         (-[WebPluginController stopOnePlugin:]):
2143         (-[WebPluginController stopOnePluginForPageCache:]):
2144         (-[WebPluginController destroyOnePlugin:]):
2145         (-[WebPluginController startAllPlugins]):
2146         (-[WebPluginController addPlugin:]):
2147
2148 2016-12-09  Dave Hyatt  <hyatt@apple.com>
2149
2150         [CSS Parser] Remove the old CSS Parser
2151         https://bugs.webkit.org/show_bug.cgi?id=165645
2152
2153         Reviewed by Daniel Bates.
2154
2155         * DOM/DOMCSS.mm:
2156         (kitClass):
2157         * DOM/DOMCSSRule.h:
2158
2159 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
2160
2161         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
2162         https://bugs.webkit.org/show_bug.cgi?id=165251
2163
2164         Reviewed by Dean Jackson.
2165
2166         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
2167
2168         * WebView/WebPreferenceKeysPrivate.h: Add MediaStream and PeerConnection preferences.
2169         * WebView/WebPreferences.mm:
2170         (+[WebPreferences initialize]):
2171         (-[WebPreferences mediaStreamEnabled]):
2172         (-[WebPreferences setMediaStreamEnabled:]):
2173         (-[WebPreferences peerConnectionEnabled]):
2174         (-[WebPreferences setPeerConnectionEnabled:]):
2175         * WebView/WebPreferencesPrivate.h:
2176         * WebView/WebView.mm:
2177         (-[WebView _preferencesChanged:]):
2178
2179 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
2180
2181         Don’t expose pointer lock in WebKit1 Objective-C API
2182         https://bugs.webkit.org/show_bug.cgi?id=165692
2183
2184         Reviewed by Simon Fraser.
2185
2186         * DOM/DOMDocument.mm:
2187         (-[DOMDocument pointerLockElement]): Deleted.
2188         (-[DOMDocument exitPointerLock]): Deleted.
2189         * DOM/DOMElement.mm:
2190         (-[DOMElement requestPointerLock]): Deleted.
2191         * DOM/DOMMouseEvent.mm:
2192         (-[DOMMouseEvent movementX]): Deleted.
2193         (-[DOMMouseEvent movementY]): Deleted.
2194
2195 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
2196
2197         document.webkitFullscreenElement leaks elements inside a shadow tree
2198         https://bugs.webkit.org/show_bug.cgi?id=158471
2199
2200         Reviewed by Chris Dumez.
2201
2202         Use the API for bindings to avoid exposing nodes inside a shadow tree.
2203
2204         * DOM/DOMDocument.mm:
2205         (-[DOMDocument webkitCurrentFullScreenElement]):
2206         (-[DOMDocument webkitFullscreenElement]):
2207
2208 2016-12-09  Beth Dakin  <bdakin@apple.com>
2209
2210         Password fields should not show the emoji button in TouchBar
2211         https://bugs.webkit.org/show_bug.cgi?id=165673
2212         -and corresponding-
2213         rdar://problem/29235739
2214
2215         Reviewed by Wenson Hsieh.
2216
2217         This patch adds a new ivar for the password touch bar and password 
2218         candidateListTouchBarItem. Since this TouchBar will actually have a different set 
2219         of identifiers than the plain text TouchBar, it should just have its own variable.
2220
2221         The candidate list should be the only item for passwords.
2222         * WebView/WebView.mm:
2223         (-[WebView _passwordTextTouchBarDefaultItemIdentifiers]):
2224
2225         Account for _passwordTextTouchBar.
2226         (-[WebView didChangeAutomaticTextCompletion:]):
2227         (-[WebView setUpTextTouchBar:]):
2228         (-[WebView textTouchBar]):
2229
2230         The empty candidates array is not needed. We can just set @[ ] as the candidates 
2231         for the _passwordTextCandidateListTouchBarItem. Safe guards already exist in the 
2232         other parts of the code to prevent us from requesting or setting other candidates 
2233         when in a password field. 
2234         (-[WebView updateTextTouchBar]):
2235
2236         Account for _passwordTextTouchBar.
2237         (-[WebView candidateList]):
2238         * WebView/WebViewData.h:
2239
2240 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
2241
2242         Enable SharedArrayBuffer, remove the flag
2243         https://bugs.webkit.org/show_bug.cgi?id=165614
2244
2245         Rubber stamped by Geoffrey Garen.
2246
2247         * WebView/WebPreferencesPrivate.h:
2248
2249 2016-12-07  Dean Jackson  <dino@apple.com>
2250
2251         Remove runtime toggle for pointer-lock
2252         https://bugs.webkit.org/show_bug.cgi?id=165577
2253         <rdar://problems/29566996>
2254
2255         Reviewed by Jon Lee.
2256
2257         Remove any runtime calls to check if pointer-lock is enabled. It's
2258         either compiled in or out.
2259
2260         * WebView/WebPreferenceKeysPrivate.h:
2261         * WebView/WebPreferences.mm:
2262         (-[WebPreferences pointerLockEnabled]): Deleted.
2263         (-[WebPreferences setPointerLockEnabled:]): Deleted.
2264         * WebView/WebPreferencesPrivate.h:
2265         * WebView/WebView.mm:
2266         (-[WebView _preferencesChanged:]):
2267
2268 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
2269
2270         Correct SDKROOT values in xcconfig files
2271         https://bugs.webkit.org/show_bug.cgi?id=165487
2272         rdar://problem/29539209
2273
2274         Reviewed by Dan Bernstein.
2275
2276         Fix suggested by Dan Bernstein.
2277
2278         * Configurations/DebugRelease.xcconfig:
2279
2280 2016-12-05  Simon Fraser  <simon.fraser@apple.com>
2281
2282         Improve the behavior of scroll-into-view when the target is inside position:fixed
2283         https://bugs.webkit.org/show_bug.cgi?id=165354
2284
2285         Reviewed by Zalan Bujtas.
2286
2287         Plumb through 'insideFixed'. We don't get compute it, so behavior from
2288         these call sites won't change.
2289
2290         * WebView/WebFrame.mm:
2291         (-[WebFrame _scrollDOMRangeToVisible:]):
2292         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
2293
2294 2016-12-06  Simon Fraser  <simon.fraser@apple.com>
2295
2296         Enable visual viewports by default on Mac, and iOS Wk2
2297         https://bugs.webkit.org/show_bug.cgi?id=165452
2298
2299         Reviewed by Zalan Bujtas.
2300
2301         Turn visual viewports on by default for WK1 on Mac.
2302
2303         * WebView/WebPreferences.mm:
2304         (+[WebPreferences initialize]):
2305
2306 2016-12-05  Dean Jackson  <dino@apple.com>
2307
2308         pointer lock needs to be feature detectable
2309         https://bugs.webkit.org/show_bug.cgi?id=165426
2310         <rdar://problem/29486715>
2311
2312         Reviewed by Antoine Quint.
2313
2314         Set the RuntimeEnabledFeature as preferences
2315         change.
2316
2317         * WebView/WebView.mm:
2318         (-[WebView _preferencesChanged:]):
2319
2320 2016-12-05  Ryan Haddad  <ryanhaddad@apple.com>
2321
2322         Unreviewed, rolling out r209299.
2323
2324         This change appears to have caused LayoutTest failures on
2325         Sierra WK1.
2326
2327         Reverted changeset:
2328
2329         "Improve the behavior of scroll-into-view when the target is
2330         inside position:fixed"
2331         https://bugs.webkit.org/show_bug.cgi?id=165354
2332         http://trac.webkit.org/changeset/209299
2333
2334 2016-12-02  Simon Fraser  <simon.fraser@apple.com>
2335
2336         Improve the behavior of scroll-into-view when the target is inside position:fixed
2337         https://bugs.webkit.org/show_bug.cgi?id=165354
2338
2339         Reviewed by Zalan Bujtas.
2340
2341         Plumb through 'insideFixed'. We don't get compute it, so behavior from
2342         these call sites won't change.
2343
2344         * WebView/WebFrame.mm:
2345         (-[WebFrame _scrollDOMRangeToVisible:]):
2346         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
2347
2348 2016-12-02  Andy Estes  <aestes@apple.com>
2349
2350         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
2351         https://bugs.webkit.org/show_bug.cgi?id=164492
2352
2353         Reviewed by Dan Bernstein.
2354
2355         * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
2356         com.apple.$(PRODUCT_NAME:rfc1034identifier).
2357         * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
2358         ${PRODUCT_BUNDLE_IDENTIFIER}.
2359
2360 2016-12-02  Chris Dumez  <cdumez@apple.com>
2361
2362         Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
2363         https://bugs.webkit.org/show_bug.cgi?id=165328
2364
2365         Reviewed by Simon Fraser.
2366
2367         Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
2368
2369         * WebView/WebViewData.mm:
2370         (-[WebViewPrivate init]):
2371
2372 2016-12-02  Chris Dumez  <cdumez@apple.com>
2373
2374         [Mac][WK1] Implement new HTML interactive form validation user interface
2375         https://bugs.webkit.org/show_bug.cgi?id=164483
2376
2377         Reviewed by Simon Fraser.
2378
2379         Implement new HTML interactive form validation user interface on Mac
2380         WK1 and enable it by default.
2381
2382         * WebCoreSupport/WebValidationMessageClient.h: Added.
2383         * WebCoreSupport/WebValidationMessageClient.mm: Added.
2384         (WebValidationMessageClient::WebValidationMessageClient):
2385         (WebValidationMessageClient::~WebValidationMessageClient):
2386         (WebValidationMessageClient::showValidationMessage):
2387         (WebValidationMessageClient::hideValidationMessage):
2388         (WebValidationMessageClient::isValidationMessageVisible):
2389         * WebView/WebHTMLView.mm:
2390         (-[WebHTMLView _frameOrBoundsChanged]):
2391         * WebView/WebView.mm:
2392         (-[WebView _commonInitializationWithFrameName:groupName:]):
2393         (-[WebView _willStartScrollingOrZooming]):
2394         (-[WebView _contentsOfUserInterfaceItem:]):
2395         (-[WebView _scaleWebView:atOrigin:]):
2396         (-[WebView _didScrollDocumentInFrameView:]):
2397         (-[WebView _setZoomMultiplier:isTextOnly:]):
2398         (-[WebView showFormValidationMessage:withAnchorRect:]):
2399         (-[WebView hideFormValidationMessage]):
2400         * WebView/WebViewData.h:
2401         * WebView/WebViewData.mm:
2402         (-[WebViewPrivate init]):
2403         * WebView/WebViewInternal.h:
2404         * WebView/WebViewPrivate.h:
2405
2406 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
2407
2408         Add a runtime flag for SubtleCrypto
2409         https://bugs.webkit.org/show_bug.cgi?id=164982
2410
2411         Reviewed by Brent Fulgham.
2412
2413         * WebView/WebPreferenceKeysPrivate.h:
2414         * WebView/WebPreferences.mm:
2415         (+[WebPreferences initialize]):
2416         (-[WebPreferences subtleCryptoEnabled]):
2417         (-[WebPreferences setSubtleCryptoEnabled:]):
2418         * WebView/WebPreferencesPrivate.h:
2419         * WebView/WebView.mm:
2420         (-[WebView _preferencesChanged:]):
2421
2422 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
2423
2424         Add separate settings and preferences to enable/disable async decoding for large images and animated images
2425         https://bugs.webkit.org/show_bug.cgi?id=165177
2426
2427         Reviewed by Simon Fraser.
2428         
2429         Hook up the async image decoding settings for WebKit1.
2430
2431         * WebView/WebPreferenceKeysPrivate.h:
2432         * WebView/WebPreferences.mm:
2433         (+[WebPreferences initialize]):
2434         (-[WebPreferences largeImageAsyncDecodingEnabled]):
2435         (-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
2436         (-[WebPreferences animatedImageAsyncDecodingEnabled]):
2437         (-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
2438         (-[WebPreferences asyncImageDecodingEnabled]): Deleted.
2439         (-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.
2440         * WebView/WebPreferencesPrivate.h:
2441         * WebView/WebView.mm:
2442         (-[WebView _preferencesChanged:]):
2443
2444 2016-11-29  Andy Estes  <aestes@apple.com>
2445
2446         [Cocoa] Enable two clang warnings recommended by Xcode
2447         https://bugs.webkit.org/show_bug.cgi?id=164498
2448
2449         Reviewed by Mark Lam.
2450
2451         * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
2452
2453 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2454
2455         [WTF] Import std::optional reference implementation as WTF::Optional
2456         https://bugs.webkit.org/show_bug.cgi?id=164199
2457
2458         Reviewed by Saam Barati and Sam Weinig.
2459
2460         Use WTF::Optional::value_or.
2461
2462         * DOM/DOMHTMLOptionsCollection.mm:
2463         (-[DOMHTMLOptionsCollection add:index:]):
2464         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2465         (WebKit::NetscapePluginInstanceProxy::evaluate):
2466         * Plugins/WebNetscapePluginView.mm:
2467         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2468         * WebCoreSupport/WebFrameLoaderClient.h:
2469         * WebCoreSupport/WebFrameLoaderClient.mm:
2470         (WebFrameLoaderClient::dispatchDidCommitLoad):
2471         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2472         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2473         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
2474         (WebPaymentCoordinatorClient::completeShippingContactSelection):
2475         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
2476         * WebCoreSupport/WebSecurityOrigin.mm:
2477         (-[WebSecurityOrigin port]):
2478         * WebView/WebHTMLView.mm:
2479         (toAction):
2480         (toTag):
2481
2482 2016-11-26  Sam Weinig  <sam@webkit.org>
2483
2484         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
2485         https://bugs.webkit.org/show_bug.cgi?id=164965
2486
2487         Reviewed by Simon Fraser.
2488
2489         * WebView/WebPreferenceKeysPrivate.h:
2490         * WebView/WebPreferences.mm:
2491         (-[WebPreferences intersectionObserverEnabled]):
2492         (-[WebPreferences setIntersectionObserverEnabled:]):
2493         * WebView/WebPreferencesPrivate.h:
2494         * WebView/WebView.mm:
2495         (-[WebView _preferencesChanged:]):
2496         Add a preference, defaulting to off, for enabling IntersectionObserver.
2497
2498 2016-11-22  Dan Bernstein  <mitz@apple.com>
2499
2500         [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
2501         https://bugs.webkit.org/show_bug.cgi?id=165036
2502         <rdar://problem/5708580>
2503
2504         Reviewed by Alexey Proskuryakov.
2505
2506         * WebView/WebHTMLView.mm:
2507         (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
2508           similarly to what we do in -keyDown: and to what WKWebView does with all key events.
2509
2510 2016-11-21  Alex Christensen  <achristensen@webkit.org>
2511
2512         Fix Sierra CMake build after r208452
2513         https://bugs.webkit.org/show_bug.cgi?id=164437
2514
2515         * WebView/WebView.mm:
2516         (-[WebView updateMediaTouchBar]):
2517         I haven't enabled VIDEO_PRESENTATION_MODE in the CMake build yet.
2518         It's needed for playbackSessionInterface to exist.
2519
2520 2016-11-18  Enrica Casucci  <enrica@apple.com>
2521
2522         Refactor drag and drop for WebKit2 to encode DragData message exchange.
2523         https://bugs.webkit.org/show_bug.cgi?id=164945
2524
2525         Reviewed by Tim Horton.
2526
2527         * WebCoreSupport/WebDragClient.h:
2528         * WebCoreSupport/WebDragClient.mm:
2529         (WebDragClient::actionMaskForDrag):
2530         (WebDragClient::willPerformDragDestinationAction):
2531
2532 2016-11-18  Jeremy Jones  <jeremyj@apple.com>
2533
2534         Add runtime flag to enable pointer lock. Enable pointer lock feature for mac.
2535         https://bugs.webkit.org/show_bug.cgi?id=163801
2536
2537         Reviewed by Simon Fraser.
2538
2539         Plumb through PointerLockEnabled setting.
2540
2541         * Configurations/FeatureDefines.xcconfig:
2542         * WebCoreSupport/WebChromeClient.mm:
2543         (WebChromeClient::requestPointerUnlock):
2544         * WebView/WebPreferenceKeysPrivate.h:
2545         * WebView/WebPreferences.mm:
2546         (-[WebPreferences pointerLockEnabled]):
2547         (-[WebPreferences setPointerLockEnabled:]):
2548         * WebView/WebPreferencesPrivate.h:
2549         * WebView/WebView.mm:
2550         (-[WebView _preferencesChanged:]):
2551
2552 2016-11-17  Dan Bernstein  <mitz@apple.com>
2553
2554         Try to fix some non-macOS builds.
2555
2556         * WebView/WebView.mm:
2557
2558 2016-11-16  Dave Hyatt  <hyatt@apple.com>
2559
2560         [CSS Parser] Add @supports, @keyframe and media query parsing options
2561         https://bugs.webkit.org/show_bug.cgi?id=164821
2562
2563         Reviewed by Sam Weinig and Zalan Bujtas.
2564
2565         Fix up the create call now that fallback descriptor syntax is gone.
2566
2567         * DOM/DOM.mm:
2568         (-[DOMHTMLLinkElement _mediaQueryMatches]):
2569
2570 2016-11-17  Saam Barati  <sbarati@apple.com>
2571
2572         Remove async/await compile time flag and enable tests
2573         https://bugs.webkit.org/show_bug.cgi?id=164828
2574         <rdar://problem/28639334>
2575
2576         Reviewed by Yusuke Suzuki.
2577
2578         * Configurations/FeatureDefines.xcconfig:
2579
2580 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2581
2582         [JSC] WTF::TemporaryChange with WTF::SetForScope
2583         https://bugs.webkit.org/show_bug.cgi?id=164761
2584
2585         Reviewed by Saam Barati.
2586
2587         * WebView/WebView.mm:
2588         (-[WebView updateTextTouchBar]):
2589
2590 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2591
2592         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
2593         https://bugs.webkit.org/show_bug.cgi?id=164827
2594
2595         Reviewed by Ryosuke Niwa.
2596
2597         * Configurations/FeatureDefines.xcconfig:
2598         * WebView/WebPreferenceKeysPrivate.h:
2599         * WebView/WebPreferences.mm:
2600         (+[WebPreferences initialize]):
2601         (-[WebPreferences es6ModulesEnabled]):
2602         (-[WebPreferences setES6ModulesEnabled:]):
2603         * WebView/WebPreferencesPrivate.h:
2604         * WebView/WebView.mm:
2605         (-[WebView _preferencesChanged:]):
2606
2607 2016-11-14  Alex Christensen  <achristensen@webkit.org>
2608
2609         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
2610         https://bugs.webkit.org/show_bug.cgi?id=164720
2611
2612         Reviewed by Brady Eidson.
2613
2614         * Storage/WebDatabaseManager.mm:
2615         (-[WebDatabaseManager origins]):
2616         (-[WebDatabaseManager databasesWithOrigin:]):
2617         (-[WebDatabaseManager deleteOrigin:]):
2618         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
2619         * Storage/WebDatabaseManagerClient.h:
2620         * Storage/WebDatabaseManagerClient.mm:
2621         (DidModifyOriginData::dispatchToMainThread):
2622         (DidModifyOriginData::DidModifyOriginData):
2623         (WebDatabaseManagerClient::dispatchDidModifyOrigin):
2624         (WebDatabaseManagerClient::dispatchDidModifyDatabase):
2625         * Storage/WebDatabaseQuotaManager.mm:
2626         (-[WebDatabaseQuotaManager usage]):
2627         (-[WebDatabaseQuotaManager quota]):
2628         (-[WebDatabaseQuotaManager setQuota:]):
2629         * Storage/WebStorageManager.mm:
2630         (-[WebStorageManager origins]):
2631         (-[WebStorageManager deleteOrigin:]):
2632         * Storage/WebStorageTrackerClient.h:
2633         * Storage/WebStorageTrackerClient.mm:
2634         (WebStorageTrackerClient::dispatchDidModifyOrigin):
2635         * WebCoreSupport/WebSecurityOrigin.mm:
2636         (-[WebSecurityOrigin usage]):
2637         (-[WebSecurityOrigin quota]):
2638         (-[WebSecurityOrigin setQuota:]):
2639
2640 2016-11-13  Darin Adler  <darin@apple.com>
2641
2642         Fix exception handling in SQL database code, streamline and update code
2643         https://bugs.webkit.org/show_bug.cgi?id=164685
2644
2645         Reviewed by Sam Weinig.
2646
2647         * Storage/WebDatabaseManager.mm:
2648         (-[WebDatabaseManager origins]): Updated to use DatabaseTracker and pass
2649         a reference.
2650         (-[WebDatabaseManager databasesWithOrigin:]): Ditto.
2651         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Pass reference,
2652         but continue to use DatabaseManager.
2653         (-[WebDatabaseManager deleteOrigin:]): Use DatabaseTracker and pass a
2654         reference.
2655         (-[WebDatabaseManager deleteDatabase:withOrigin:]): Ditto.
2656
2657         * Storage/WebDatabaseManagerClient.h: Updated to take references.
2658         * Storage/WebDatabaseManagerClient.mm:
2659         (WebDatabaseManagerClient::WebDatabaseManagerClient): Initialize data
2660         members in the class definition.
2661         (DidModifyOriginData::dispatchToMainThread): Take references.
2662         (DidModifyOriginData::DidModifyOriginData): Ditto.
2663         (WebDatabaseManagerClient::dispatchDidModifyOrigin): Ditto.
2664         (WebDatabaseManagerClient::dispatchDidModifyDatabase): Ditto.
2665         (WebDatabaseManagerClient::dispatchDidAddNewOrigin): Ditto. Also use
2666         DatabaseTracker::singleton instead of tracker.
2667
2668         * Storage/WebDatabaseQuotaManager.mm:
2669         (-[WebDatabaseQuotaManager initWithOrigin:]): Reject nil pointer argument.
2670         (-[WebDatabaseQuotaManager usage]): Use reference instead of pointer.
2671         (-[WebDatabaseQuotaManager quota]): Ditto.
2672         (-[WebDatabaseQuotaManager setQuota:]): Ditto.
2673         * WebCoreSupport/WebSecurityOrigin.mm:
2674         (-[WebSecurityOrigin initWithURL:]): Tweaked code a bit.
2675         (-[WebSecurityOrigin usage]): Use DatabaseTracker and pass a reference.
2676         (-[WebSecurityOrigin quota]): Ditto.
2677         (-[WebSecurityOrigin setQuota:]): Ditto.
2678         * WebView/WebFrame.mm:
2679         (-[WebFrame _cacheabilityDictionary]): Pass a reference.
2680
2681 2016-11-12  Darin Adler  <darin@apple.com>
2682
2683         Remove a few assorted uses of ExceptionCode
2684         https://bugs.webkit.org/show_bug.cgi?id=164683
2685
2686         Reviewed by Chris Dumez.
2687
2688         * DOM/DOMDOMImplementation.mm:
2689         (-[DOMImplementation createDocumentType:publicId:systemId:]):
2690         Use raiseOnDOMError instead of much longer hand written equivalent.
2691         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2692
2693         * DOM/DOMDocument.mm:
2694         (-[DOMDocument createEntityReference:]): Use raiseNotSupportedErrorException
2695         so we are not using a specific exception code.
2696
2697         * DOM/DOMHTMLOptionsCollection.mm:
2698         (-[DOMHTMLOptionsCollection add:index:]): Use raiseOnDOMError instead of
2699         much longer hand written equivalent.
2700         * DOM/DOMHTMLSelectElement.mm:
2701         (-[DOMHTMLSelectElement add:before:]): Ditto. Also removed unneeded return
2702         statement after calling a "no return" function.
2703
2704         * DOM/ExceptionHandlers.h: Removed overloads of raiseDOMException and
2705         raiseOnDOMError functions that take ExceptionCode; keep the ones that take
2706         Exception and ExceptionOr. Renamed the other overload of raiseDOMException
2707         to raiseDOMErrorException; it is only used as the non-inline implementation
2708         part of the inline raiseOnDOMError function.
2709         * DOM/ExceptionHandlers.mm:
2710         (raiseDOMErrorException): Renamed. Made the ExceptionCode overload be local
2711         to this source file instead of in the header.
2712         (raiseTypeErrorException): Updated for name change.
2713         (raiseNotSupportedErrorException): Added.
2714
2715 2016-11-11  Ryosuke Niwa  <rniwa@webkit.org>
2716
2717         Hovering over a slotted Text node clears hover state
2718         https://bugs.webkit.org/show_bug.cgi?id=164002
2719         <rdar://problem/29040471>
2720
2721         Reviewed by Simon Fraser.
2722
2723         * WebView/WebImmediateActionController.mm:
2724         (-[WebImmediateActionController performHitTestAtPoint:]):
2725
2726 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2727
2728         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
2729         https://bugs.webkit.org/show_bug.cgi?id=164538
2730         <rdar://problem/8418711>
2731
2732         Reviewed by Ryosuke Niwa.
2733
2734         Account for renaming HTMLElement::autocorrect to HTMLElement::shouldAutocorrect, as well as moving
2735         WebAutocapitalizeType to WebKit from WebCore. Additionally, moves the -autocorrect and -autocapitalize SPIs out
2736         of HTML(Input|Form|TextArea)ElementPrivate.h and into HTMLElementPrivate.h. This also means removing redundant
2737         code for interfacing with the unwrapped HTMLElement's autocorrect and autocapitalize attributes.
2738
2739         * DOM/DOMHTML.mm:
2740         (webAutocapitalizeType):
2741         (-[DOMHTMLInputElement _autocapitalizeType]):
2742         (-[DOMHTMLTextAreaElement _autocapitalizeType]):
2743         * DOM/DOMHTMLElement.mm:
2744         (-[DOMHTMLElement autocorrect]):
2745         (-[DOMHTMLElement setAutocorrect:]):
2746         (-[DOMHTMLElement autocapitalize]):
2747         (-[DOMHTMLElement setAutocapitalize:]):
2748         * DOM/DOMHTMLElementPrivate.h: Copied from Source/WebCore/html/Autocapitalize.h.
2749         * DOM/DOMHTMLFormElement.mm:
2750         (-[DOMHTMLFormElement autocorrect]): Deleted.
2751         (-[DOMHTMLFormElement setAutocorrect:]): Deleted.
2752         (-[DOMHTMLFormElement autocapitalize]): Deleted.
2753         (-[DOMHTMLFormElement setAutocapitalize:]): Deleted.
2754         * DOM/DOMHTMLInputElement.mm:
2755         (-[DOMHTMLInputElement autocorrect]): Deleted.
2756         (-[DOMHTMLInputElement setAutocorrect:]): Deleted.
2757         (-[DOMHTMLInputElement autocapitalize]): Deleted.
2758         (-[DOMHTMLInputElement setAutocapitalize:]): Deleted.
2759         * DOM/DOMHTMLInputElementPrivate.h:
2760         * DOM/DOMHTMLTextAreaElement.mm:
2761         (-[DOMHTMLTextAreaElement autocorrect]): Deleted.
2762         (-[DOMHTMLTextAreaElement setAutocorrect:]): Deleted.
2763         (-[DOMHTMLTextAreaElement autocapitalize]): Deleted.
2764         (-[DOMHTMLTextAreaElement setAutocapitalize:]): Deleted.
2765         * DOM/DOMHTMLTextAreaElementPrivate.h:
2766
2767         We need to import DOMHTMLElementPrivate.h here to avoid breaking UIKit. We should follow this up with a UIKit
2768         change to import DOMHTMLElementPrivate.h directly.
2769
2770         * DOM/DOMPrivate.h:
2771         * DOM/WebAutocapitalizeTypes.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h.
2772         * MigrateHeaders.make:
2773
2774 2016-11-11  Beth Dakin  <bdakin@apple.com>
2775
2776         Move to modern TouchBar methods
2777         https://bugs.webkit.org/show_bug.cgi?id=164655
2778         -and corresponding-
2779         rdar://problem/29226911
2780
2781         Reviewed by Wenson Hsieh.
2782
2783         customizationDefaultItemIdentifiers -> defaultItemIdentifiers
2784         itemIdentifiers -> defaultItemIdentifiers
2785         defaultItems -> templateItems
2786
2787         * WebView/WebView.mm:
2788         (-[WebView _plainTextTouchBarDefaultItemIdentifiers]):
2789         (-[WebView _richTextTouchBarDefaultItemIdentifiers]):
2790         (-[WebView setUpTextTouchBar:]):
2791         (-[WebView updateTextTouchBar]):
2792         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
2793         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
2794
2795 2016-11-11  Darin Adler  <darin@apple.com>
2796
2797         Move Node from ExceptionCode to ExceptionOr
2798         https://bugs.webkit.org/show_bug.cgi?id=164515
2799
2800         Reviewed by Sam Weinig.
2801
2802         * DOM/DOMHTMLSelectElement.mm:
2803         (-[DOMHTMLSelectElement remove:]): Call remove instead of removeByIndex
2804         now that it was renamed.
2805         * DOM/DOMNode.mm:
2806         (-[DOMNode setNodeValue:]): Updated exception handling.
2807         (-[DOMNode setPrefix:]): Ditto.
2808         (-[DOMNode setTextContent:]): Ditto.
2809         (-[DOMNode insertBefore:refChild:]): Ditto.
2810         (-[DOMNode replaceChild:oldChild:]): Ditto.
2811         (-[DOMNode removeChild:]): Ditto.
2812         (-[DOMNode appendChild:]): Ditto.
2813         (-[DOMNode cloneNode:]): Ditto.
2814
2815 2016-11-11  Beth Dakin  <bdakin@apple.com>
2816
2817         Get touch bar code building for open source builds
2818         https://bugs.webkit.org/show_bug.cgi?id=164610
2819
2820         Reviewed by Wenson Hsieh.
2821
2822         * WebKitPrefix.h:
2823
2824 2016-11-10  Alex Christensen  <achristensen@webkit.org>
2825
2826         Fix assertion after r208534.
2827         https://bugs.webkit.org/show_bug.cgi?id=160497
2828
2829         * WebView/WebView.mm:
2830         (-[WebView _commonInitializationWithFrameName:groupName:]):
2831         (WebInstallMemoryPressureHandler):
2832         WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
2833         When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
2834         only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.
2835
2836 2016-11-10  Alex Christensen  <achristensen@webkit.org>
2837
2838         Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
2839         https://bugs.webkit.org/show_bug.cgi?id=164573
2840
2841         Reviewed by Brady Eidson.
2842
2843         * WebCoreSupport/WebSecurityOrigin.mm:
2844         (-[WebSecurityOrigin databaseIdentifier]):
2845
2846 2016-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2847
2848         MemoryPressureHandler shouldn't know how to release WebCore memory
2849         https://bugs.webkit.org/show_bug.cgi?id=160497
2850
2851         Reviewed by Michael Catanzaro.
2852
2853         Set the low memory handler before installing the memory pressure handler.
2854
2855         * WebView/WebView.mm:
2856         (-[WebView _commonInitializationWithFrameName:groupName:]):
2857
2858 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
2859
2860         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
2861         https://bugs.webkit.org/show_bug.cgi?id=164501
2862         <rdar://problem/29152282>
2863
2864         Reviewed by Sam Weinig.
2865
2866         Align what [WebHTMLView attributedString] returns to what would be used on copy & paste by using HTMLConverter
2867         instead of _initWithDOMRange in [WebHTMLView _attributeStringFromDOMRange].
2868
2869         * WebView/WebHTMLView.mm:
2870         (-[WebHTMLView _attributedStringFromDOMRange:]): Renamed from _attributeStringFromDOMRange.
2871         (-[WebHTMLView attributedString]):
2872         (-[WebHTMLView selectedAttributedString]):
2873         (-[WebHTMLView selectedString]): Moved to reduce the number of occurrences of the if-defs.
2874
2875 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
2876
2877         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
2878         https://bugs.webkit.org/show_bug.cgi?id=155185
2879         <rdar://problem/11101440>
2880
2881         Reviewed by Brady Eidson.
2882
2883         Provide SPI to access the new quirk for localStorage. The quirk defaults to 'on'. When active, this
2884         quirk says that localStorage access should be granted, without needing to grant universal file access.
2885
2886         If the quirk is turned off, then localStorage is blocked unless the WebKit client explicitly
2887         grants universal file access.
2888
2889         * WebView/WebPreferenceKeysPrivate.h:
2890         * WebView/WebPreferences.mm:
2891         (-[WebPreferences needsLocalStorageQuirk]): Added.
2892         (-[WebPreferences setNeedsLocalStorageQuirk:]): Added.
2893         * WebView/WebPreferencesPrivate.h:
2894         * WebView/WebView.mm:
2895         (-[WebView _preferencesChanged:]): Honor the new localStorage quirk.
2896
2897 2016-11-09  Alex Christensen  <achristensen@webkit.org>
2898
2899         Clean up Storage code
2900         https://bugs.webkit.org/show_bug.cgi?id=164562
2901
2902         Reviewed by Brady Eidson.
2903
2904         * Storage/WebStorageManager.mm:
2905         (-[WebStorageManager origins]):
2906         (-[WebStorageManager deleteAllOrigins]):
2907         (-[WebStorageManager deleteOrigin:]):
2908         (-[WebStorageManager diskUsageForOrigin:]):
2909         (-[WebStorageManager syncLocalStorage]):
2910         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
2911         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
2912         (+[WebStorageManager closeIdleLocalStorageDatabases]):
2913         (WebKitInitializeStorageIfNecessary):
2914         * WebView/WebView.mm:
2915         (+[WebView _applicationWillTerminate]):
2916
2917 2016-11-09  Beth Dakin  <bdakin@apple.com>
2918
2919         Another attempted build fix.
2920
2921         * WebView/WebView.mm:
2922
2923 2016-11-09  Beth Dakin  <bdakin@apple.com>
2924
2925         Attempted build fix.
2926
2927         * WebView/WebView.mm:
2928
2929 2016-11-09  Darin Adler  <darin@apple.com>
2930
2931         Move Range from ExceptionCode to ExceptionOr
2932         https://bugs.webkit.org/show_bug.cgi?id=164457
2933
2934         Reviewed by Alex Christensen.
2935
2936         * DOM/DOMRange.mm:
2937         (-[DOMRange setStart:offset:]): Updated exception handling.
2938         (-[DOMRange setEnd:offset:]): Ditto.
2939         (-[DOMRange setStartBefore:]): Ditto.
2940         (-[DOMRange setStartAfter:]): Ditto.
2941         (-[DOMRange setEndBefore:]): Ditto.
2942         (-[DOMRange setEndAfter:]): Ditto.
2943         (-[DOMRange selectNode:]): Ditto.
2944         (-[DOMRange selectNodeContents:]): Ditto.
2945         (-[DOMRange compareBoundaryPoints:sourceRange:]): Ditto.
2946         (-[DOMRange deleteContents]): Ditto.
2947         (-[DOMRange extractContents]): Ditto.
2948         (-[DOMRange cloneContents]): Ditto.
2949         (-[DOMRange insertNode:]): Ditto.
2950         (-[DOMRange surroundContents:]): Ditto.
2951         (-[DOMRange createContextualFragment:]): Ditto.
2952         (-[DOMRange compareNode:]): Ditto.
2953         (-[DOMRange intersectsNode:]): Ditto.
2954         (-[DOMRange comparePoint:offset:]): Ditto.
2955         (-[DOMRange isPointInRange:offset:]): Ditto.
2956         (-[DOMRange expand:]): Ditto.
2957         * WebView/WebFrame.mm:
2958         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
2959         (-[WebFrame _smartDeleteRangeForProposedRange:]): Deleted.
2960         This function was incorrectly implemented (set both start and end of
2961         the range to the computed start), not declared in any header file,
2962         not used anywhere inside WebKit, and I also could not find a use of it
2963         in outside-WebKit Apple code.
2964         * mac/DOM/DOMUIKitExtensions.mm:
2965         (-[DOMRange move:inDirection:]): Ditto.
2966         (-[DOMRange extend:inDirection:]): Ditto.
2967
2968 2016-11-09  Darin Adler  <darin@apple.com>
2969
2970         Move EventTarget from ExceptionCode to ExceptionOr
2971         https://bugs.webkit.org/show_bug.cgi?id=164465
2972
2973         Reviewed by Youenn Fablet.
2974
2975         * DOM/DOMNode.mm:
2976         (-[DOMNode dispatchEvent:]): Updated exception handling.
2977
2978 2016-11-09  Chris Dumez  <cdumez@apple.com>
2979
2980         [Mac] Stop using deprecated AppKit enumeration values
2981         https://bugs.webkit.org/show_bug.cgi?id=164494
2982
2983         Reviewed by Darin Adler.
2984
2985         Stop using deprecated AppKit enumeration values.
2986
2987         * Carbon/CarbonWindowAdapter.mm:
2988         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2989         (-[CarbonWindowAdapter sendSuperEvent:]):
2990         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2991         (WebKit::NetscapePluginHostProxy::beginModal):
2992         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2993         (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
2994         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2995         (-[WebHostedNetscapePluginView drawRect:]):
2996         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2997         (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
2998         * WebCoreSupport/PopupMenuMac.mm:
2999         (PopupMenuMac::populate):
3000         (PopupMenuMac::show):
3001         * WebCoreSupport/WebContextMenuClient.mm:
3002         (WebContextMenuClient::showContextMenu):
3003         * WebCoreSupport/WebFrameLoaderClient.mm:
3004         (WebFrameLoaderClient::actionDictionary):
3005         * WebCoreSupport/WebInspectorClient.mm:
3006         (WebInspectorFrontendClient::canAttach):
3007         (-[WebInspectorWindowController window]):
3008         * WebInspector/WebNodeHighlight.mm:
3009         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
3010         * WebView/WebFrameView.mm:
3011         (-[WebFrameView keyDown:keyDown:]):
3012         * WebView/WebFullScreenController.mm:
3013         (-[WebFullScreenController init]):
3014         (createBackgroundFullscreenWindow):
3015         * WebView/WebHTMLView.mm:
3016         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
3017         (-[WebHTMLView _setMouseDownEvent:_setMouseDownEvent:]):
3018         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3019         (isQuickLookEvent):
3020         (-[WebHTMLView hitTest:]):
3021         (-[WebHTMLView _sendToolTipMouseExited]):
3022         (-[WebHTMLView _sendToolTipMouseEntered]):
3023         (mouseEventIsPartOfClickOrDrag):
3024         (-[WebHTMLView _updateMouseoverWithEvent:]):
3025         (-[WebHTMLView _autoscroll]):
3026         (-[WebHTMLView acceptsFirstResponder]):
3027         (-[WebHTMLView viewDidMoveToWindow]):
3028         (-[WebHTMLView mouseDown:mouseDown:]):
3029         (currentKeyboardEvent):
3030         (-[WebHTMLView _handleStyleKeyEquivalent:]):
3031         (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
3032         * WebView/WebPDFView.mm:
3033         (-[WebPDFView hitTest:]):
3034         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3035         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
3036         * WebView/WebTextCompletionController.mm:
3037         (-[WebTextCompletionController _buildUI]):
3038         (-[WebTextCompletionController _placePopupWindow:]):
3039         * WebView/WebView.mm:
3040         (-[WebView applicationFlags:]):
3041
3042 2016-11-09  Beth Dakin  <bdakin@apple.com>
3043
3044         Support TouchBar in WebKit
3045         https://bugs.webkit.org/show_bug.cgi?id=164437
3046         -and corresponding-
3047         rdar://problem/28876524
3048
3049         Reviewed by Darin Adler.
3050
3051         * WebCoreSupport/WebEditorClient.mm:
3052         (WebEditorClient::respondToChangedSelection):
3053         (WebEditorClient::updateEditorStateAfterLayoutIfEditabilityChanged):
3054         * WebView/WebHTMLView.mm:
3055         (-[WebHTMLView candidateListTouchBarItem]):
3056         * WebView/WebView.mm:
3057         (-[_WebTextListTouchBarViewController initWithWebView:]):
3058         (-[_WebTextListTouchBarViewController _selectList:]):
3059         (-[_WebTextListTouchBarViewController setCurrentListType:]):
3060         (-[WebTextTouchBarItemController initWithWebView:]):
3061         (-[WebTextTouchBarItemController itemForIdentifier:]):
3062         (-[WebTextTouchBarItemController webTextListTouchBarViewController]):
3063         (-[WebTextTouchBarItemController setTextIsBold:]):
3064         (-[WebTextTouchBarItemController setTextIsItalic:]):
3065         (-[WebTextTouchBarItemController setTextIsUnderlined:]):
3066         (-[WebTextTouchBarItemController _webChangeTextStyle:]):
3067         (-[WebTextTouchBarItemController setCurrentTextAlignment:]):
3068         (-[WebTextTouchBarItemController _webChangeTextAlignment:]):
3069         (-[WebTextTouchBarItemController textColor]):
3070         (-[WebTextTouchBarItemController setTextColor:]):
3071         (-[WebTextTouchBarItemController _webChangeColor:]):
3072         (-[WebTextTouchBarItemController textListViewController]):
3073         (-[WebView _commonInitializationWithFrameName:groupName:]):
3074         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
3075         (-[WebView shouldRequestCandidates]):
3076         (-[WebView forceRequestCandidatesForTesting]):
3077         (-[WebView makeTouchBar]):
3078         (-[WebView touchBar:makeItemForIdentifier:]):
3079         (textCheckingResultFromNSTextCheckingResult):
3080         (-[WebView candidateListTouchBarItem:endSelectingCandidateAtIndex:]):
3081         (-[WebView candidateListTouchBarItem:changedCandidateListVisibility:]):
3082         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3083         (-[WebView _clearPlaybackControlsManager]):
3084         (-[WebView _dismissTextTouchBarPopoverItemWithIdentifier:]):
3085         (-[WebView _textTouchBarCustomizationAllowedIdentifiers]):
3086         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]):
3087         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]):
3088         (-[WebView touchBarDidExitCustomization:]):
3089         (-[WebView touchBarWillEnterCustomization:]):
3090         (-[WebView didChangeAutomaticTextCompletion:]):
3091         (-[WebView setUpTextTouchBar:]):
3092         (-[WebView _isRichlyEditable]):
3093         (-[WebView textTouchBar]):
3094         (-[WebView updateTextTouchBar]):
3095         (-[WebView updateMediaTouchBar]):
3096         (-[WebView updateTouchBar]):
3097         (-[WebView prepareForMouseDown]):
3098         (-[WebView prepareForMouseUp]):
3099         (-[WebView webViewAdditionsWillDestroyView]):
3100         (-[WebView candidateList]):
3101         (-[WebView updateWebViewAdditions]): Deleted.
3102         * WebView/WebViewData.h:
3103         * WebView/WebViewInternal.h:
3104         * WebView/WebViewPrivate.h:
3105
3106 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3107
3108         Safari does not emit composition end if blurred for dead key / Japanese IME
3109         https://bugs.webkit.org/show_bug.cgi?id=164369
3110         <rdar://problem/29050439>
3111
3112         Reviewed by Ryosuke Niwa.
3113
3114         When canceling a composition, make sure that we clear the system IME state.
3115
3116         * WebCoreSupport/WebEditorClient.h:
3117         * WebCoreSupport/WebEditorClient.mm:
3118         (WebEditorClient::canceledComposition):
3119
3120 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
3121
3122         Add a setting and preferences to enable/disable async image decoding
3123         https://bugs.webkit.org/show_bug.cgi?id=164417
3124
3125         Reviewed by Simon Fraser.
3126
3127         Hook up the asyncImageDecodingEnabled setting for WebKit1.
3128
3129         * WebView/WebPreferenceKeysPrivate.h:
3130         * WebView/WebPreferences.mm:
3131         (+[WebPreferences initialize]):
3132         (-[WebPreferences asyncImageDecodingEnabled]):
3133         (-[WebPreferences setAsyncImageDecodingEnabled:]):
3134         * WebView/WebPreferencesPrivate.h:
3135         * WebView/WebView.mm:
3136         (-[WebView _preferencesChanged:]):
3137
3138 2016-11-01  Alex Christensen  <achristensen@webkit.org>
3139
3140         Remove PassRefPtr from DumpRenderTree
3141         https://bugs.webkit.org/show_bug.cgi?id=164307
3142
3143         Reviewed by Sam Weinig.
3144
3145         * WebView/WebGeolocationPosition.mm:
3146         (-[WebGeolocationPosition initWithGeolocationPosition:]):
3147
3148 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
3149
3150         [Readable Streams API] Enable creation of ReadableByteStreamController
3151         https://bugs.webkit.org/show_bug.cgi?id=164014
3152
3153         Reviewed by Youenn Fablet.
3154
3155         Added flag for the byte stream part of Readable Streams API.
3156
3157         * Configurations/FeatureDefines.xcconfig:
3158
3159 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
3160
3161         Remove CUSTOM_ELEMENTS build flag
3162         https://bugs.webkit.org/show_bug.cgi?id=164267
3163
3164         Reviewed by Antti Koivisto.
3165
3166         Removed the build flag.
3167
3168         * Configurations/FeatureDefines.xcconfig:
3169         * WebView/WebPreferences.mm:
3170         (+[WebPreferences initialize]):
3171         * WebView/WebView.mm:
3172         (-[WebView _preferencesChanged:]):
3173
3174 2016-11-01  Eric Carlson  <eric.carlson@apple.com>
3175
3176         [MediaStream] restrict media capture secure connections
3177         https://bugs.webkit.org/show_bug.cgi?id=164234
3178         <rdar://problem/28944906>
3179
3180         Reviewed by Alex Christensen.
3181
3182         * WebView/WebPreferenceKeysPrivate.h:
3183         * WebView/WebPreferences.mm:
3184         (+[WebPreferences initialize]): Initialize WebKitMediaCaptureRequiresSecureConnectionPreferenceKey.
3185         (-[WebPreferences mediaCaptureRequiresSecureConnection]): New.
3186         (-[WebPreferences setMediaCaptureRequiresSecureConnection:]): New.
3187         * WebView/WebPreferencesPrivate.h:
3188
3189         * WebView/WebView.mm:
3190         (-[WebView _preferencesChanged:]): Sync mediaCaptureRequiresSecureConnection.
3191
3192 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
3193
3194         JSC should support SharedArrayBuffer
3195         https://bugs.webkit.org/show_bug.cgi?id=163986
3196
3197         Reviewed by Keith Miller.
3198         
3199         Support the RuntimeFlag.
3200
3201         * WebView/WebPreferencesPrivate.h:
3202
3203 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
3204
3205         [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
3206         https://bugs.webkit.org/show_bug.cgi?id=164236
3207         <rdar://problem/28747712>
3208
3209         Reviewed by Beth Dakin.
3210
3211         See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
3212         dictionary lookup.
3213
3214         * WebCoreSupport/WebEditorClient.mm:
3215         (WebEditorClient::respondToChangedSelection):
3216         * WebView/WebImmediateActionController.mm:
3217         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3218
3219 2016-10-31  Darin Adler  <darin@apple.com>
3220
3221         Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
3222         https://bugs.webkit.org/show_bug.cgi?id=164214
3223
3224         Reviewed by Alex Christensen.
3225
3226         * DOM/DOMCSSPrimitiveValue.mm:
3227         (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
3228         is a reference now.
3229         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
3230
3231         * DOM/DOMDocument.mm:
3232         (-[DOMDocument querySelector:]): Updated exception handling.
3233         (-[DOMDocument querySelectorAll:]): Ditto.
3234         * DOM/DOMDocumentFragment.mm:
3235         (-[DOMDocumentFragment querySelector:]): Ditto.
3236         (-[DOMDocumentFragment querySelectorAll:]): Ditto.
3237         * DOM/DOMElement.mm:
3238         (-[DOMElement querySelector:]): Ditto.
3239         (-[DOMElement querySelectorAll:]): Ditto.
3240
3241 2016-10-31  Darin Adler  <darin@apple.com>
3242
3243         Convert Document from ExceptionCode to Exception
3244         https://bugs.webkit.org/show_bug.cgi?id=164212
3245
3246         Reviewed by Alex Christensen.
3247
3248         * DOM/DOMDocument.mm:
3249         (-[DOMDocument setXmlVersion:]): Updated exception handling.
3250         (-[DOMDocument cookie]): Ditto.
3251         (-[DOMDocument setCookie:]): Ditto.
3252         (-[DOMDocument setBody:]): Ditto.
3253         (-[DOMDocument createElement:]): Ditto.
3254         (-[DOMDocument createCDATASection:]): Ditto.
3255         (-[DOMDocument createProcessingInstruction:data:]): Ditto.
3256         (-[DOMDocument createAttribute:]): Ditto.
3257         (-[DOMDocument createEntityReference:]): Ditto.
3258         (-[DOMDocument importNode:deep:]): Ditto.
3259         (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
3260         (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
3261         (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
3262         (-[DOMDocument adoptNode:]): Ditto.
3263         (-[DOMDocument createEvent:]): Ditto.
3264
3265 2016-10-30  Darin Adler  <darin@apple.com>
3266
3267         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
3268         https://bugs.webkit.org/show_bug.cgi?id=164206
3269
3270         Reviewed by Chris Dumez.
3271
3272         * DOM/DOMElement.mm:
3273         (-[DOMElement setInnerHTML:]): Updated exception handling.
3274         (-[DOMElement setOuterHTML:]): Ditto.
3275         (-[DOMElement setAttribute:value:]): Ditto.
3276         (-[DOMElement setAttributeNode:]): Ditto.
3277         (-[DOMElement removeAttributeNode:]): Ditto.
3278         (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
3279         (-[DOMElement setAttributeNodeNS:]): Ditto.
3280         (-[DOMElement matches:]): Ditto.
3281         (-[DOMElement closest:]): Ditto.
3282         (-[DOMElement webkitMatchesSelector:]): Ditto.
3283         * DOM/DOMHTMLElement.mm:
3284         (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
3285         (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
3286         (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
3287         * DOM/DOMNamedNodeMap.mm:
3288         (-[DOMNamedNodeMap setNamedItem:]): Ditto.
3289         (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
3290         (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
3291         (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
3292
3293 2016-10-29  Darin Adler  <darin@apple.com>
3294
3295         Convert more of DOM from ExceptionCode to Exception
3296         https://bugs.webkit.org/show_bug.cgi?id=164173
3297
3298         Reviewed by Ryosuke Niwa.
3299
3300         * DOM/DOMCharacterData.mm:
3301         (-[DOMCharacterData substringData:length:]): Updated since this
3302         now uses ExceptionOr.
3303         (-[DOMCharacterData insertData:data:]): Ditto.
3304         (-[DOMCharacterData deleteData:length:]): Ditto.
3305         (-[DOMCharacterData replaceData:length:data:]): Ditto.
3306         * DOM/DOMText.mm:
3307         (-[DOMText splitText:]): Ditto.
3308         (-[DOMText replaceWholeText:]): Removed unneeded exception code
3309         handling from function that does not throw an exception.
3310
3311 2016-10-28  Darin Adler  <darin@apple.com>
3312
3313         Move all classes in the HTML directory from ExceptionCode to Exception
3314         https://bugs.webkit.org/show_bug.cgi?id=163876
3315
3316         Reviewed by Sam Weinig.
3317
3318         * DOM/DOMCharacterData.mm:
3319         (-[DOMCharacterData remove]): Updated exception handling.
3320         * DOM/DOMDOMTokenList.mm:
3321         (-[DOMDOMTokenList toggle:force:]): Ditto.
3322         * DOM/DOMDocumentType.mm:
3323         (-[DOMDocumentType remove]): Ditto.
3324         * DOM/DOMElement.mm:
3325         (-[DOMElement remove]): Ditto.
3326         * DOM/DOMHTML.mm:
3327         (-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.
3328         * DOM/DOMHTMLCanvasElement.mm:
3329         (-[DOMHTMLCanvasElement toDataURL:]): Ditto.
3330         * DOM/DOMHTMLElement.mm:
3331         (-[DOMHTMLElement setInnerText:]): Ditto.
3332         (-[DOMHTMLElement setOuterText:]): Ditto.
3333         (-[DOMHTMLElement setContentEditable:]): Ditto.
3334         * DOM/DOMHTMLInputElement.mm:
3335         (-[DOMHTMLInputElement setMaxLength:]): Ditto.
3336         (-[DOMHTMLInputElement setValueAsDate:]): Ditto.
3337         (-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
3338         (-[DOMHTMLInputElement stepUp:]): Ditto.
3339         (-[DOMHTMLInputElement stepDown:]): Ditto.
3340         (-[DOMHTMLInputElement setRangeText:]): Ditto.
3341         (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.
3342         * DOM/DOMHTMLMarqueeElement.mm:
3343         (-[DOMHTMLMarqueeElement setLoop:]): Ditto.
3344         * DOM/DOMHTMLMediaElement.mm:
3345         (-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
3346         (-[DOMHTMLMediaElement setVolume:]): Ditto.
3347         * DOM/DOMHTMLOptionsCollection.mm:
3348         (-[DOMHTMLOptionsCollection setLength:]): Ditto.
3349         * DOM/DOMHTMLTableElement.mm:
3350         (-[DOMHTMLTableElement setCaption:]): Ditto.
3351         (-[DOMHTMLTableElement setTHead:]): Ditto.
3352         (-[DOMHTMLTableElement setTFoot:]): Ditto.
3353         (-[DOMHTMLTableElement insertRow:]): Ditto.
3354         (-[DOMHTMLTableElement deleteRow:]): Ditto.
3355         * DOM/DOMHTMLTableRowElement.mm:
3356         (-[DOMHTMLTableRowElement insertCell:]): Ditto.
3357         (-[DOMHTMLTableRowElement deleteCell:]): Ditto.
3358         * DOM/DOMHTMLTableSectionElement.mm:
3359         (-[DOMHTMLTableSectionElement insertRow:]): Ditto.
3360         (-[DOMHTMLTableSectionElement deleteRow:]): Ditto.
3361         * DOM/DOMHTMLTextAreaElement.mm:
3362         (-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
3363         (-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
3364         (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.
3365         * DOM/DOMHTMLVideoElement.mm:
3366         (-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
3367         (-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
3368         version (lowercase S) instead of repeating the logic from that method.
3369         (-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.
3370         * DOM/DOMTimeRanges.mm:
3371         (-[DOMTimeRanges start:]): Updated exception handling.
3372         (-[DOMTimeRanges end:]): Ditto.
3373
3374 2016-10-27  Chris Dumez  <cdumez@apple.com>
3375
3376         Regression(r203601): Caused crashes in iBooks
3377         https://bugs.webkit.org/show_bug.cgi?id=164093
3378         <rdar://problem/28745634>
3379
3380         Reviewed by Darin Adler.
3381
3382         Restore pre-r203601 behavior when calling [DOMNode compareDocumentPosition:nil],
3383         which was to return Node::DOCUMENT_POSITION_DISCONNECTED.
3384
3385         * DOM/DOMNode.mm:
3386         (-[DOMNode compareDocumentPosition:]):
3387
3388 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3389
3390         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
3391         https://bugs.webkit.org/show_bug.cgi?id=163948
3392         <rdar://problem/28921433>
3393
3394         Reviewed by Darin Adler.
3395
3396         Add support for new drag and drop-related EditAction enum values.
3397
3398         * WebCoreSupport/WebEditorClient.mm:
3399         (undoNameForEditAction):
3400
3401 2016-10-27  Dan Bernstein  <mitz@apple.com>
3402
3403         Reapplied the configuration changes from r207934 without breaking iOS builds.
3404
3405         * Configurations/Base.xcconfig:
3406         * Configurations/WebKitLegacy.xcconfig:
3407
3408 2016-10-27  Dan Bernstein  <mitz@apple.com>
3409
3410         Reverted the configuration changes from r207934 because they broke iOS builds not using the Apple-internal SDK.
3411
3412         * Configurations/Base.xcconfig:
3413         * Configurations/WebKitLegacy.xcconfig:
3414
3415 2016-10-26  Dan Bernstein  <mitz@apple.com>
3416
3417         [Xcode] WebKit fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
3418         https://bugs.webkit.org/show_bug.cgi?id=164048
3419
3420         Reviewed by Tim Horton.
3421
3422         * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS.
3423         * Configurations/WebKitLegacy.xcconfig: Made the compiler treat the icu headers as system
3424           headers.
3425
3426         * History/WebBackForwardList.h: Fixed parameter name in @param entry.
3427         * Misc/WebDownload.h: Removed empty entries.
3428         * Misc/WebIconDatabase.h: Remove incorrect @param entries.
3429         * Misc/WebQuotaManager.h: Added missing parameter names in @param entries.
3430         * WebView/WebFrameLoadDelegate.h: Corrected parameter names in @param entries.
3431         * WebView/WebFrameViewPrivate.h: Changed incorrect @result to @abstract.
3432         * WebView/WebPolicyDelegate.h: Fixed parameter name and removed incorrect @param entries.
3433         * WebView/WebPreferences.h: Changed @method to @property in a couple of places.
3434         * WebView/WebResourceLoadDelegate.h: Fixed parameter names.
3435         * WebView/WebUIDelegate.h: Filled in two empty @param entries. Added missing parameter name,
3436           Fixed a typo and removed empty @discussion entry. Fixed some parameter names.
3437         * WebView/WebUIDelegatePrivate.h: Fixed parameter names.
3438         * WebView/WebView.h: Changed @method to @property in a couple of places.
3439         * WebView/WebViewPrivate.h: Fixed parameter names, changed incorrect @result to @abstract.
3440
3441 2016-10-26  Brian Burg  <bburg@apple.com>
3442
3443         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
3444         https://bugs.webkit.org/show_bug.cgi?id=164046
3445
3446         Reviewed by Joseph Pecoraro.
3447
3448         * WebCoreSupport/WebInspectorClient.h:
3449
3450 2016-10-21  Alex Christensen  <achristensen@webkit.org>
3451
3452         URL::port should return Optional<uint16_t>
3453         https://bugs.webkit.org/show_bug.cgi?id=163806
3454
3455         Reviewed by Darin Adler.
3456
3457         * WebCoreSupport/WebSecurityOrigin.mm:
3458         (-[WebSecurityOrigin port]):
3459
3460 2016-10-24  Dave Hyatt  <hyatt@apple.com>
3461
3462         Remove CSSCharsetRule from the CSS OM
3463         https://bugs.webkit.org/show_bug.cgi?id=163891
3464
3465         Reviewed by Darin Adler.
3466
3467         * DOM/DOMCSSCharsetRule.mm:
3468         (-[DOMCSSCharsetRule encoding]):
3469
3470 2016-10-24  Youenn Fablet  <youenn@apple.com>
3471
3472         Activate WEB_RTC compilation flags for Mac bots
3473         https://bugs.webkit.org/show_bug.cgi?id=163886
3474
3475         Reviewed by Eric Carlson.
3476
3477         * Configurations/FeatureDefines.xcconfig:
3478
3479 2016-10-23  Chris Dumez  <cdumez@apple.com>
3480
3481         addEventListener() / removeEventListener() should use a union for last parameter
3482         https://bugs.webkit.org/show_bug.cgi?id=163863
3483
3484         Reviewed by Darin Adler.
3485
3486         Cast BOOL to bool to help to compiler construct the new variant-type parameter.
3487
3488         * DOM/DOMNode.mm:
3489         (-[DOMNode addEventListener:listener:useCapture:]):
3490         (-[DOMNode addEventListener:::]):
3491         (-[DOMNode removeEventListener:listener:useCapture:]):
3492         (-[DOMNode removeEventListener:::]):
3493
3494 2016-10-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3495
3496         Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents
3497         https://bugs.webkit.org/show_bug.cgi?id=163460
3498         <rdar://problem/28784142>
3499
3500         Reviewed by Darin Adler.
3501
3502         Handle new EditAction types for inserting/deleting pending/final compositions.
3503
3504         * WebCoreSupport/WebEditorClient.mm:
3505         (undoNameForEditAction):
3506
3507 2016-10-21  Jeremy Jones  <jeremyj@apple.com>
3508
3509         Implement basic pointer lock behavior for WebKit and WebKit2.
3510         https://bugs.webkit.org/show_bug.cgi?id=162745
3511
3512         Reviewed by Simon Fraser.
3513
3514         Add basic pointer lock functionality. User permission is not yet implemented.
3515
3516         * WebCoreSupport/WebChromeClient.h:
3517         * WebCoreSupport/WebChromeClient.mm:
3518         (WebChromeClient::requestPointerLock):
3519         (WebChromeClient::requestPointerUnlock):
3520
3521 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
3522
3523         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
3524         https://bugs.webkit.org/show_bug.cgi?id=163374
3525
3526         Reviewed by Darin Adler.
3527
3528         * Configurations/FeatureDefines.xcconfig:
3529
3530 2016-10-19  Alex Christensen  <achristensen@webkit.org>
3531
3532         Revert r207151
3533         https://bugs.webkit.org/show_bug.cgi?id=163675
3534
3535         Reviewed by Brent Fulgham.
3536
3537         * Misc/WebDownload.mm:
3538         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
3539         * Misc/WebDownloadInternal.h:
3540         * WebCoreSupport/WebFrameLoaderClient.mm:
3541         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3542         * WebView/WebPreferences.mm:
3543         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
3544         * WebView/WebView.mm:
3545         (-[WebView scheduleInRunLoop:forMode:]):
3546         (-[WebView unscheduleFromRunLoop:forMode:]):
3547
3548 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
3549
3550         Unreviewed, rolling out r207557.
3551
3552         This change caused animations/font-variations tests to time
3553         out on pre-Sierra Macs.
3554
3555         Reverted changeset:
3556
3557         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
3558         iOS 9"
3559         https://bugs.webkit.org/show_bug.cgi?id=163374
3560         http://trac.webkit.org/changeset/207557
3561
3562 2016-10-19  Chris Dumez  <cdumez@apple.com>
3563
3564         Move HTML Interactive Form Validation behind an experimental flag
3565         https://bugs.webkit.org/show_bug.cgi?id=163673
3566
3567         Reviewed by Daniel Bates.
3568
3569         Re-disable HTML Interactive Form Validation by default on Mac WK1.
3570
3571         * WebView/WebViewData.mm:
3572         (-[WebViewPrivate init]):
3573
3574 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
3575
3576         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
3577         https://bugs.webkit.org/show_bug.cgi?id=163374
3578
3579         Reviewed by Darin Adler.
3580
3581         * Configurations/FeatureDefines.xcconfig:
3582
3583 2016-10-19  Simon Fraser  <simon.fraser@apple.com>
3584
3585         WebView needs to initialize the visualViewportEnabled Setting from WebKit preferences
3586         https://bugs.webkit.org/show_bug.cgi?id=163680
3587
3588         Reviewed by Dean Jackson.
3589
3590         Add code to set the Setting from WebKit prefs. This code is a mess and needs to be autogenerated.
3591
3592         * WebView/WebView.mm:
3593         (-[WebView _preferencesChanged:]):
3594
3595 2016-10-19  Darin Adler  <darin@apple.com>
3596
3597         Move XPath from ExceptionCode to Exception
3598         https://bugs.webkit.org/show_bug.cgi?id=163656
3599
3600         Reviewed by Chris Dumez.
3601
3602         * DOM/DOMDocument.mm:
3603         (wrap): Added. Helper function for wrapping a resolver.
3604         (-[DOMDocument createExpression:resolver:]): Use raiseOnDOMError.
3605         (-[DOMDocument evaluate:contextNode:resolver:type:inResult:]): Ditto.
3606         * DOM/DOMXPathExpression.mm:
3607         (-[DOMXPathExpression evaluate:type:inResult:]): Ditto.
3608         * DOM/DOMXPathResult.mm:
3609         (-[DOMXPathResult numberValue]): Ditto.
3610         (-[DOMXPathResult stringValue]): Ditto.
3611         (-[DOMXPathResult booleanValue]): Ditto.
3612         (-[DOMXPathResult singleNodeValue]): Ditto.
3613         (-[DOMXPathResult snapshotLength]): Ditto.
3614         (-[DOMXPathResult iterateNext]): Ditto.
3615         (-[DOMXPathResult snapshotItem:]): Ditto.
3616
3617 2016-10-18  Sam Weinig  <sam@webkit.org>
3618
3619         Replace std::experimental::variant with WTF::Variant (or similar)
3620         https://bugs.webkit.org/show_bug.cgi?id=163626
3621
3622         Reviewed by Chris Dumez.
3623
3624         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
3625         into the WTF namespace.
3626
3627         * DOM/DOMHTMLSelectElement.mm:
3628         (-[DOMHTMLSelectElement add:before:]):
3629
3630 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
3631
3632         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
3633         https://bugs.webkit.org/show_bug.cgi?id=163627
3634
3635         Reviewed by Dean Jackson.
3636
3637         Add an explanatory comment about viewScaleFactor not really being viewScaleFactor.
3638