1 2011-01-21 Mark Rowe <mrowe@apple.com>
3 Rubber-stamped by Jon Honeycutt.
5 Fix the build when using Clang by removing some unused variables.
7 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
8 (-[WebHostedNetscapePluginView updateAndSetWindow]):
9 * WebView/WebFullScreenController.mm:
10 (-[WebFullScreenController enterFullscreen:]):
11 (-[WebFullScreenController exitFullscreen]):
13 2011-01-21 Chris Rogers <crogers@google.com>
15 Reviewed by Darin Fisher.
17 Add run-time enable support for the web audio API
18 https://bugs.webkit.org/show_bug.cgi?id=52741
20 * WebView/WebPreferenceKeysPrivate.h:
21 * WebView/WebPreferences.mm:
22 (-[WebPreferences webAudioEnabled]):
23 (-[WebPreferences setWebAudioEnabled:]):
24 * WebView/WebPreferencesPrivate.h:
26 (-[WebView _preferencesChangedNotification:]):
28 2011-01-20 John Sullivan <sullivan@apple.com>
30 Reviewed by Mark Rowe.
32 Shift-tab doesn't cycle through fields in http authentication panel
33 https://bugs.webkit.org/show_bug.cgi?id=52850
35 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
36 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
37 Re-wired the key loop so that there aren't two views with the same nextKeyView.
39 2011-01-20 Beth Dakin <bdakin@apple.com>
41 Reviewed by Geoffrey Garen.
43 Fix for <rdar://problem/8890255>
45 Allow WebKitSystemInterface to draw scrollbars
47 * WebCoreSupport/WebSystemInterface.mm:
48 (InitWebCoreSystemInterface):
50 2011-01-19 Simon Fraser <simon.fraser@apple.com>
52 Reviewed by Sam Weinig.
54 GraphicsLayers in subframes can get sync'd multiple times
55 https://bugs.webkit.org/show_bug.cgi?id=52489
58 (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
59 was renamed to syncCompositingStateIncludingSubframes().
61 2011-01-19 Darin Adler <darin@apple.com>
63 Reviewed by Sam Weinig.
65 Would like script debugging protocol method to differentiate between caught and uncaught exceptions
66 https://bugs.webkit.org/show_bug.cgi?id=52104
67 rdar://problem/8704226
69 * WebView/WebDelegateImplementationCaching.h:
70 Fix type of second integer in CallScriptDebugDelegate function overload
71 to be int to match the actual Objective-C method. Added a new overload
72 that includes a BOOL in the right place. Added a boolean named
73 exceptionWasRaisedExpectsHasHandlerFlag.
75 * WebView/WebDelegateImplementationCaching.mm:
76 (CallDelegate): Added overloads as above.
77 (CallScriptDebugDelegate): Ditto.
79 * WebView/WebScriptDebugDelegate.h: Added new method with the additional
80 boolean argument. Marked the old method informally deprecated.
82 * WebView/WebScriptDebugger.mm:
83 (WebScriptDebugger::exception): Added code to call with or without the
84 boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
87 (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
88 exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
89 guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
91 2011-01-19 Tony Gentilcore <tonyg@chromium.org>
93 Reviewed by Mihai Parparita.
95 Perform some forward declaration
96 https://bugs.webkit.org/show_bug.cgi?id=52522
98 * Misc/WebKitNSStringExtras.mm:
100 2011-01-19 Pavel Podivilov <podivilov@chromium.org>
102 Reviewed by Yury Semikhatsky.
104 Web Inspector: [JSC] scripts have incorrect starting line (always 1).
105 https://bugs.webkit.org/show_bug.cgi?id=52721
107 * WebView/WebScriptDebugger.h:
108 * WebView/WebScriptDebugger.mm:
110 (WebScriptDebugger::sourceParsed):
112 2011-01-19 Levi Weintraub <leviw@google.com>
114 Reviewed by Ryosuke Niwa.
116 Updating to use Position::parentAnchoredEquivalent instead of
117 the old htmlediting rangeCompliantEquivalent.
119 remove rangeCompliantEquivalent and replace it with Position methods
120 https://bugs.webkit.org/show_bug.cgi?id=25057
122 * WebView/WebFrame.mm:
123 (-[WebFrame _smartDeleteRangeForProposedRange:]):
125 2011-01-18 Chris Fleizach <cfleizach@apple.com>
127 Reviewed by Darin Adler.
129 REGRESSION: A problem with Voiceover and finding links
130 https://bugs.webkit.org/show_bug.cgi?id=52324
132 * WebView/WebDynamicScrollBarsView.mm:
133 (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
135 2011-01-17 David Kilzer <ddkilzer@apple.com>
137 <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
139 Reviewed by Dan Bernstein.
141 * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
142 DOMDocumentPrivate.h to the PrivateHeaders directory.
144 2011-01-17 Enrica Casucci <enrica@apple.com>
146 Reviewed by Alexey Proskuryakov.
148 Drag and drop support: refactoring of image from link and image from selection
149 https://bugs.webkit.org/show_bug.cgi?id=52496
151 This work cleans up the Mac code and makes it more similar to the Windows implementation,
152 avoiding the use of an NSView when the FrameView can be used.
153 The refactoring is a necessary step towards the complete support of drag and drop
156 * WebCoreSupport/WebDragClient.mm:
157 (WebDragClient::createDragImageForLink): Added.
158 * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
159 * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
161 2011-01-17 Pavel Feldman <pfeldman@chromium.org>
163 Reviewed by Yury Semikhatsky.
165 Web Inspector: simplify debugger enabling routine.
166 https://bugs.webkit.org/show_bug.cgi?id=52472
168 * WebInspector/WebInspector.mm:
169 (-[WebInspector startDebuggingJavaScript:]):
171 2011-01-16 Dan Bernstein <mitz@apple.com>
173 Reviewed by Simon Fraser.
175 Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
176 https://bugs.webkit.org/show_bug.cgi?id=52550
178 * Plugins/WebNetscapePluginView.mm:
179 (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
180 that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
182 2011-01-16 Simon Fraser <simon.fraser@apple.com>
184 Reviewed by Dan Bernstein.
186 Issues with iframes and plugins when the WebView is scaled.
187 <rdar://problem/6213380>
189 When _scaleWebView has been called on a WebView, iframes
190 in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
191 This is caused by AppKit NSViews not playing nicely with the scale
192 applied through style.
194 Work around most of these issues by adjusting the bounds size
195 of widgets to allow iframe contents to paint with the correct scale,
196 and fix various places in the code where we relied on coordinate
197 transforms via NSViews (which ignore CSS transforms).
199 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
200 (-[WebHostedNetscapePluginView updateAndSetWindow]):
201 * WebView/WebFrameView.mm:
202 (-[WebFrameView setBoundsSize:]):
204 2011-01-16 Beth Dakin <bdakin@apple.com>
206 Reviewed by Kevin Decker.
208 Fix for <rdar://problem/8871204>
210 Don't try to save elasticity state. Just rely on
211 NSScrollElasticityAutomatic to restore the correct state.
212 * WebCoreSupport/WebFrameLoaderClient.h:
213 * WebCoreSupport/WebFrameLoaderClient.mm:
214 (WebFrameLoaderClient::WebFrameLoaderClient):
215 (WebFrameLoaderClient::dispatchDidFirstLayout):
216 (WebFrameLoaderClient::provisionalLoadStarted):
218 2011-01-14 Simon Fraser <simon.fraser@apple.com>
220 Reviewed by Dan Bernstein.
222 Plugins render incorrectly with transformed ancestors
223 https://bugs.webkit.org/show_bug.cgi?id=52507
225 -[NSView visibleRect] gives the wrong answer if there are CSS transforms
226 in the ancestor chain of a plugin.
228 So use of this method with calls to -actualVisibleRectInWindow, which
229 maps rects through the render tree to compute the correct rect,
230 clipping via windowClipRect() if necessary.
232 Not testable, because doing so relies on the behavior of some
233 plugins, which stop rendering if setWindow passes an empty rect.
235 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
236 (-[WebHostedNetscapePluginView updateAndSetWindow]):
237 * Plugins/WebBaseNetscapePluginView.h:
238 * Plugins/WebBaseNetscapePluginView.mm:
239 (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
240 * Plugins/WebNetscapePluginView.mm:
241 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
243 2011-01-14 Yuzo Fujishima <yuzo@google.com>
245 Reviewed by Antti Koivisto.
247 Rename cache() to memoryCache()
248 https://bugs.webkit.org/show_bug.cgi?id=52433
251 (+[WebCache statistics]):
252 (+[WebCache setDisabled:]):
253 (+[WebCache isDisabled]):
254 * WebView/WebView.mm:
255 (+[WebView _setCacheModel:]):
257 2011-01-13 Geoffrey Garen <ggaren@apple.com>
259 Reviewed by Oliver Hunt.
261 Split out a MarkedSpace strategy object from Heap.
262 https://bugs.webkit.org/show_bug.cgi?id=52421
264 * Misc/WebCoreStatistics.mm:
265 (+[WebCoreStatistics memoryStatistics]): Updated for class move.
267 2011-01-14 Dan Bernstein <mitz@apple.com>
269 Reviewed by Simon Fraser.
271 WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
273 * WebView/WebHTMLView.mm:
274 (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
275 to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
276 that the NSView tree doesn’t change from under AppKit as it traverses it.
278 2011-01-14 Beth Dakin <bdakin@apple.com>
280 Reviewed by Mark Rowe.
282 Fix for <rdar://problem/7793902> Artifacts when scrolling
283 page in Safari while page is loading
285 Call setDrawsBackground:YES on the scrollView in
286 dispatchDidFirstLayout() rather than waiting until
287 frameLoadCompleted(). Also suspend scrolling elasticity
288 between provisionalLoadStarted() and dispatchDidFirstLayout()
289 * WebCoreSupport/WebFrameLoaderClient.h:
290 * WebCoreSupport/WebFrameLoaderClient.mm:
291 (WebFrameLoaderClient::WebFrameLoaderClient):
292 (WebFrameLoaderClient::dispatchDidFirstLayout):
293 (WebFrameLoaderClient::provisionalLoadStarted):
295 2011-01-12 Enrica Casucci <enrica@apple.com>
297 Reviewed by Darin Adler.
299 WebKit2: Add support for drag and drop
300 https://bugs.webkit.org/show_bug.cgi?id=52343
301 <rdar://problem/7660558>
303 The DragData class has been extended to provide
304 additional context from the application (keyboard state, modal windows, etc.)
305 as well as information of the drag pasteboard being used.
306 These are the changes to align the behavior for WebKit.
308 * WebView/WebView.mm:
309 (-[WebView applicationFlags:]): Added.
310 (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
311 (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
312 (-[WebView draggingExited:]): Added parameter to the DragData constructor.
313 (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
315 2011-01-12 Beth Dakin <bdakin@apple.com>
317 Reviewed by Anders Carlsson.
319 Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309
320 Expose fixed layout through WebKit SPI
322 <rdar://problem/8844464>
324 And now with getters!
325 * WebView/WebView.mm:
326 (-[WebView _useFixedLayout]):
327 (-[WebView _fixedLayoutSize]):
328 * WebView/WebViewPrivate.h:
330 2011-01-12 Beth Dakin <bdakin@apple.com>
332 Reviewed by Anders Carlsson.
334 Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
335 fixed layout through WebKit SPI
337 <rdar://problem/8844464>
339 * WebView/WebView.mm:
340 (-[WebView _setUseFixedLayout:]):
341 (-[WebView _setFixedLayoutSize:]):
342 * WebView/WebViewPrivate.h:
344 2011-01-07 Enrica Casucci <enrica@apple.com>
346 Reviewed by Alexey Proskuryakov.
348 Paste and drag and drop use different code paths to interact with the pasteboard.
349 https://bugs.webkit.org/show_bug.cgi?id=52093
350 The change consists in a refactoring of the code to have only one class that
351 deals with the pasteboard on Mac.
353 * WebCoreSupport/WebEditorClient.h:
354 * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
355 exposed by NSURLExtras.
356 (WebEditorClient::canonicalizeURL):
357 (WebEditorClient::canonicalizeURLString):
358 * WebCoreSupport/WebPasteboardHelper.h: Removed.
359 * WebCoreSupport/WebPasteboardHelper.mm: Removed.
360 * WebView/WebHTMLView.mm: Removed comment.
361 * WebView/WebView.mm: The following methods have been changed to use the new DragData
362 constructor that doesn't use the WebPasteboardHelper reference.
363 (-[WebView draggingEntered:]):
364 (-[WebView draggingUpdated:]):
365 (-[WebView draggingExited:]):
366 (-[WebView performDragOperation:]):
368 2011-01-09 Tony Gentilcore <tonyg@chromium.org>
370 Reviewed by Alexey Proskuryakov.
372 Forward declare some headers where possible
373 https://bugs.webkit.org/show_bug.cgi?id=52133
375 * WebView/WebFrame.mm:
377 2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>
379 Reviewed by Darin Fisher.
381 https://bugs.webkit.org/show_bug.cgi?id=41441
382 createWindow method should only do window-creating without URL navigation
384 * WebCoreSupport/WebChromeClient.mm:
385 (WebChromeClient::createWindow):
387 2011-01-08 Dan Bernstein <mitz@apple.com>
389 Try to fix the Leopard build.
391 * WebView/WebFullScreenController.mm:
393 2011-01-07 Jer Noble <jer.noble@apple.com>
395 Yet another Leopard build fix: NSRect and CGRect are not inter-
398 * WebView/WebFullScreenController.mm:
399 (-[WebFullScreenController exitFullscreen]):
401 2011-01-07 Jer Noble <jer.noble@apple.com>
403 Fix the Leopard build: Replace CoreAnimation SL-only functions
404 with Leopard equivalents.
406 * WebView/WebFullScreenController.mm:
407 (+[CATransaction setDisableActions:]):
408 (+[CATransaction setAnimationDuration:]):
409 (-[WebFullScreenController _animationDuration]):
410 (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
412 2010-12-21 Jer Noble <jer.noble@apple.com>
414 Reviewed by Simon Fraser.
416 Implement WebKit Full Screen support.
417 https://bugs.webkit.org/show_bug.cgi?id=49481
418 rdar://problem/8247444
420 Support the new fullscreen Chrome client requests. WebView will pass
421 through these requests to a WebFullscreenController.
423 * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
424 * WebView/WebView.mm:
425 (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
426 (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
427 (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
428 (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
429 * WebView/WebViewData.h: Add ivar newFullscreenController.
431 2010-12-17 Jer Noble <jer@kokode.apple.com>
433 Reviewed by Simon Fraser.
435 Implement WebKit Full Screen support.
436 https://bugs.webkit.org/show_bug.cgi?id=49481
437 rdar://problem/8247444
439 This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
440 Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
441 window, and a custom CAAnimation animates that layer between the initial screen rect of the
442 full screen element, to its final value. WebFullscreenController will swap the WebView out of
443 its original window, and into the fullscreen window. The controller will replace the WebView
444 with a placeholder view, so that if the placeholder moves or resized while the WebView is
445 absent, the WebView will move back to the correct location when exiting fullscreen.
447 * WebView/WebFullscreenController.h: Added.
448 * WebView/WebFullscreenController.mm: Added.
449 (-[WebFullscreenController windowDidExitFullscreen:]): Close the fullscreen window.
450 (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window.
451 (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
452 (-[WebFullscreenController applicationDidResignActive:]):
453 (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
454 the new screen parameters.
455 (-[WebFullscreenController enterFullscreen:]): Set up the animation that will take the fullscreen element
456 from its original screen rect into fullscreen.
457 (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
458 Set up the animation that will take the fullscreen element back into its original screen
460 (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine
461 whether to disable screensaver and sleep.
462 (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
463 looking for HTMLVideoElements; returns whether any are found to be playing.
464 (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
466 (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
467 (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
468 (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
469 (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
470 (-[WebFullscreenWindow setRendererLayer:]): Ditto.
471 (-[WebFullscreenWindow backgroundLayer]): Ditto.
472 (-[WebFullscreenWindow animationView]): Ditto.
473 (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
474 (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
476 2011-01-07 James Robinson <jamesr@chromium.org>
478 Revert "Implement mozilla's animationTime property"
479 https://bugs.webkit.org/show_bug.cgi?id=51952
481 This approach isn't quite right.
483 * WebView/WebHTMLView.mm:
484 (-[WebHTMLView drawRect:]):
485 * WebView/WebView.mm:
486 (layerSyncRunLoopObserverCallBack):
488 2011-01-06 Gavin Barraclough <barraclough@apple.com>
490 Reviewed by Geoff Garen.
492 Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
494 The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
495 destructor early, in order to release wrappers once we know we no longer intend to use them.
496 Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
497 lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
498 A sequence of events that triggers the bug would look like this:
500 (1) Create a DOMWrapperWorld.
501 (2) Register a timer in the world.
502 (3) Call unregisterWorld() on the world.
503 (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
504 (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
505 called forgetWorld() none exists.
506 (6) Attempt to add a wrapper to a NULL map.
508 Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
510 * WebView/WebScriptWorld.mm:
511 (-[WebScriptWorld unregisterWorld]):
513 2011-01-04 Chris Fleizach <cfleizach@apple.com>
515 Reviewed by Sam Weinig.
517 WK2: Support Accessibility
518 https://bugs.webkit.org/show_bug.cgi?id=51859
520 Use rootObject() method to get top of AX tree.
522 * WebCoreSupport/WebFrameLoaderClient.h:
523 (WebFrameLoaderClient::accessibilityRemoteObject):
524 * WebView/WebFrame.mm:
525 (-[WebFrame setAccessibleName:]):
526 (-[WebFrame accessibilityRoot]):
527 * WebView/WebFrameInternal.h:
528 * WebView/WebFramePrivate.h:
529 * WebView/WebHTMLView.mm:
530 (-[WebHTMLView accessibilityAttributeValue:]):
531 (-[WebHTMLView accessibilityFocusedUIElement]):
532 (-[WebHTMLView accessibilityHitTest:]):
533 (-[WebHTMLView _accessibilityParentForSubview:]):
535 2011-01-04 David Kilzer <ddkilzer@apple.com>
537 <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
539 Reviewed by Eric Carlson.
541 This originally broke in r61581. It is inside an
542 ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
545 * WebCoreSupport/WebFrameLoaderClient.mm: Call
546 (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
547 use WebCore::PluginInfo.name instead of
548 -[WebBasePluginPackage name].
550 2011-01-02 Dan Bernstein <mitz@apple.com>
552 Rubber-stamped by Simon Fraser.
554 <rdar://problem/8812159> Update copyright strings
558 2010-12-29 Dan Bernstein <mitz@apple.com>
560 Reviewed by Ada Chan.
562 <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
563 https://bugs.webkit.org/show_bug.cgi?id=51717
565 Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
566 protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
568 * WebView/WebDocumentInternal.h:
569 * WebView/WebHTMLView.mm:
570 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
571 (-[WebHTMLView _findString:options:]):
572 * WebView/WebView.mm:
575 2010-12-28 Daniel Bates <dbates@rim.com>
577 Reviewed by Sam Weinig.
579 Substitute // MARK: for compiler-specific #pragma mark
580 https://bugs.webkit.org/show_bug.cgi?id=51657
582 For consistency, we should substitute "// MARK:" for compiler-
583 specific "#pragma mark" in the source files for the Mac port.
585 * History/WebHistory.mm:
586 * Plugins/WebBaseNetscapePluginView.mm:
587 * Plugins/WebNetscapePluginView.mm:
588 * WebCoreSupport/WebInspectorClient.mm:
589 * WebCoreSupport/WebSecurityOrigin.mm:
590 * WebView/WebPDFView.mm:
591 * WebView/WebVideoFullscreenController.mm:
592 * WebView/WebVideoFullscreenHUDWindowController.mm:
594 2010-12-23 Yongjun Zhang <yongjun_zhang@apple.com>
596 Reviewed by Darin Adler.
598 WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
599 https://bugs.webkit.org/show_bug.cgi?id=38535
601 WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram. As a result,
602 if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
603 WebScriptDebugger's callframe stack is wrong from this point. That could cause crash if we trying to access the top
604 call frame from this stack when an exception throws because the saved top frame could be invalid.
606 To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
607 callEvent and returnEvent.
609 * WebView/WebScriptDebugger.mm:
610 (WebScriptDebugger::willExecuteProgram):
611 (WebScriptDebugger::didExecuteProgram):
613 2010-12-22 Sam Weinig <sam@webkit.org>
615 Reviewed by Darin Adler.
617 WebKit2 needs to mirror the frame tree in the UIProcess
618 https://bugs.webkit.org/show_bug.cgi?id=51546
620 - Add client functions to notify that a frame has been added or
621 removed from the page cache.
623 * WebCoreSupport/WebFrameLoaderClient.h:
624 * WebCoreSupport/WebFrameLoaderClient.mm:
625 (WebFrameLoaderClient::didSaveToPageCache):
626 (WebFrameLoaderClient::didRestoreFromPageCache):
628 2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
630 Reviewed by Eric Seidel.
632 Editor.h doesn't need to include SelectionController.h
633 https://bugs.webkit.org/show_bug.cgi?id=51441
635 Renamed SelectionController::EDirection to SelectionDirection.
637 * WebView/WebFrame.mm:
638 (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
639 Takes SelectionDirection instead of SelectionController::EDirection.
640 * WebView/WebFrameInternal.h:
641 * WebView/WebTextCompletionController.mm:
642 (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
644 2010-12-22 Simon Fraser <simon.fraser@apple.com>
646 Reviewed by Darin Adler.
648 Cache snapshots of plug-ins before painting, to avoid script running during painting
649 https://bugs.webkit.org/show_bug.cgi?id=51493
651 When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
652 or when printing), plug-ins which otherwise use the CA rendering model
653 are sent a paint event. Some plug-ins may run script while handling this event,
654 or out of process plug-ins may process queued requests at this time. Running
655 script while inside layout or painting can have bad consequences, because it
656 can result in arbitrary changes to the render tree.
658 This patch avoids sending plug-ins paint events inside of painting. Instead,
659 we ask the plug-ins to cache a snapshot before we paint, and then the software
660 paint simply draws that snapshot.
662 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
663 (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
664 draw it. Also only send the snapshot message to the plugin proxy if we
665 know we're snapshotting, since even if creating the snapshot image failed,
666 we still don't want to call to the plug-in.
668 * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
669 * Plugins/WebBaseNetscapePluginView.mm:
670 (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
671 (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
673 * Plugins/WebNetscapePluginView.mm:
674 (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
675 * WebCoreSupport/WebFrameLoaderClient.mm:
676 (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
677 to cache and clear the snapshots.
679 2010-12-21 Cameron Zwarich <zwarich@apple.com>
681 Reviewed by Darin Adler.
683 -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
684 https://bugs.webkit.org/show_bug.cgi?id=51431
685 <rdar://problem/8791757>
687 * Plugins/WebBasePluginPackage.mm:
688 (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
689 it doesn't underflow.
691 2010-12-16 Ryosuke Niwa <rniwa@webkit.org>
693 Reviewed by Cameron Zwarich.
695 REGRESSION(r74172): 125 java tests fail on Mac
696 https://bugs.webkit.org/show_bug.cgi?id=51214
698 The regression was caused by an incorrectly adding sizeof(struct fat_header)
699 to a pointer for uint32_t as supposed to uint8_t.
701 Fixed the bug by explicitly casting it to uint8_t* before the addition.
703 * Plugins/WebBasePluginPackage.mm:
704 (-[WebBasePluginPackage isNativeLibraryData:]):
706 2010-12-15 Cameron Zwarich <zwarich@apple.com>
708 Reviewed by Darin Adler.
710 Clang -Wcast-align gives an error in WebBasePluginPackage.mm
711 https://bugs.webkit.org/show_bug.cgi?id=51144
713 Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
714 we were calling it on a byte array 32 bits at a time. While this is okay in practice,
715 since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
716 inline storage is at the beginning of the Vector, it is still better to fix this
717 and silence the warning.
719 * Plugins/WebBasePluginPackage.mm:
721 (-[WebBasePluginPackage isNativeLibraryData:]):
723 2010-12-14 Mark Rowe <mrowe@apple.com>
725 Reviewed by Sam Weinig.
727 <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>
729 * History/WebHistoryItem.mm:
730 (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
731 always including the target in the output.
733 2010-12-13 Alexey Proskuryakov <ap@apple.com>
735 Reviewed by Adam Barth.
737 https://bugs.webkit.org/show_bug.cgi?id=50953
738 DNS Prefetch should be an opt-in feature
740 * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false.
742 2010-12-13 Mike Thole <mthole@apple.com>
744 Rubber-stamped by John Sullivan.
746 https://bugs.webkit.org/show_bug.cgi?id=50956
747 WebAuthenticationPanel.nib appears to have a cut-off sentence
749 Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
750 The contents of this text field are updated dynamically before the sheet is displayed.
752 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
753 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
755 2010-12-13 Antti Koivisto <antti@apple.com>
757 Reviewed by Alexey Proskuryakov.
759 https://bugs.webkit.org/show_bug.cgi?id=50758
760 <rdar://problem/8722094>
761 Defer loading print stylesheets
763 Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.
765 * WebView/WebView.mm:
766 (+[WebView _setLoadResourcesSerially:forHost:]):
767 * WebView/WebViewPrivate.h:
769 2010-12-09 Matthew Delaney <mdelaney@apple.com>
771 Reviewed by Simon Fraser.
773 Adopt new CG API for canvas
774 https://bugs.webkit.org/show_bug.cgi?id=50591
776 * WebCoreSupport/WebSystemInterface.mm:
778 2010-10-28 MORITA Hajime <morrita@google.com>
780 Reviewed by Ojan Vafai.
782 spellcheck does not check pasted text
783 https://bugs.webkit.org/show_bug.cgi?id=40092
785 Added asynchronous spell checking API to WebEditorClient using
786 -[NSSpellChecker requestCheckingOfString].
787 Note that WebEditorSpellCheckResponder is a small class to receive
788 requested spell-checking result. Note that this feature is
791 Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
792 enable the feature from LayoutTestController.
794 * WebCoreSupport/WebEditorClient.h:
795 * WebCoreSupport/WebEditorClient.mm:
796 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
797 (-[WebEditorSpellCheckResponder perform]):
798 (toCoreSpellingResult):
799 (-[WebEditorSpellCheckResponder WTF::WebCore::]):
800 (WebEditorClient::requestCheckingOfString):
801 * WebView/WebPreferenceKeysPrivate.h:
802 * WebView/WebPreferences.mm:
803 (+[WebPreferences initialize]):
804 (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
805 (-[WebPreferences asynchronousSpellCheckingEnabled]):
806 * WebView/WebPreferencesPrivate.h:
807 * WebView/WebView.mm:
808 (-[WebView _preferencesChangedNotification:]):
810 2010-12-09 Anders Carlsson <andersca@apple.com>
812 Fix a bug uncovered by clang++.
814 * WebView/WebHTMLView.mm:
815 (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
817 2010-12-09 Anders Carlsson <andersca@apple.com>
821 Silence a couple of warnings.
823 * WebView/WebFrame.mm:
824 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
825 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
826 * WebView/WebTextCompletionController.mm:
827 (-[WebTextCompletionController filterKeyDown:]):
829 2010-12-09 David Hyatt <hyatt@apple.com>
831 Reviewed by Dan Bernstein.
833 https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
834 writing-mode. This first part of the patch just patches Mac WebKit 1 views.
836 * WebView/WebFrameView.mm:
837 (-[WebFrameView _isVerticalDocument]):
838 (-[WebFrameView _isFlippedDocument]):
839 (-[WebFrameView _scrollToEndOfDocument]):
840 (-[WebFrameView _pageInBlockProgressionDirection:]):
841 (-[WebFrameView scrollPageUp:]):
842 (-[WebFrameView scrollPageDown:]):
844 2010-12-08 Andy Estes <aestes@apple.com>
846 Reviewed by Darin Adler.
848 Enable pre-HTML5 parser quirks for Apple Mail.app
849 https://bugs.webkit.org/show_bug.cgi?id=50727
851 * WebView/WebView.mm:
852 (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
853 application is Mail.app.
855 2010-12-08 Brian Weinstein <bweinstein@apple.com>
857 Reviewed by John Sullivan.
859 REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
860 https://bugs.webkit.org/show_bug.cgi?id=50683
862 If our context menu item already has an action, don't overwrite the action with the context menu
865 * WebView/WebHTMLView.mm:
868 2010-12-08 Anders Carlsson <andersca@apple.com>
870 Remove an unused variable.
872 * WebView/WebDynamicScrollBarsView.mm:
873 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
875 2010-12-07 Brian Weinstein <bweinstein@apple.com>
877 Reviewed by John Sullivan.
879 Layering Violation in ContextMenu - member variable of type HitTestResult
880 https://bugs.webkit.org/show_bug.cgi?id=50586
882 Update users of ContextMenu and ContextMenuController to match where the new functions
885 * WebCoreSupport/WebContextMenuClient.mm:
886 (WebContextMenuClient::getCustomMenuFromDefaultItems):
887 (WebContextMenuClient::contextMenuItemSelected):
888 * WebView/WebHTMLView.mm:
889 (-[WebMenuTarget validateMenuItem:]):
891 2010-12-07 Brian Weinstein <bweinstein@apple.com>
893 Reviewed by John Sullivan.
895 Part of Layering Violation in ContextMenu
896 https://bugs.webkit.org/show_bug.cgi?id=50586
898 Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
899 was a layering violation. Also, make sure we set the menu item targets for all menu
900 items before showing them, because the ContextMenu constructor doesn't do that anymore.
902 * WebView/WebHTMLView.mm:
903 (+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
904 (-[WebMenuTarget WebCore::]): Ditto.
905 (-[WebMenuTarget setMenuController:WebCore::]): Ditto.
906 (-[WebMenuTarget forwardContextMenuAction:]): Ditto.
907 (-[WebMenuTarget validateMenuItem:]): Ditto.
909 (setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
910 (setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including
911 submenus), and calls setMenuItemTarget on them.
912 (-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding
915 2010-12-06 Darin Adler <darin@apple.com>
917 Reviewed by Sam Weinig.
919 Pass security origin to make local file decision correctly
920 https://bugs.webkit.org/show_bug.cgi?id=48603
922 * WebView/WebPDFView.mm:
923 (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.
925 2010-12-07 Martin Robinson <mrobinson@igalia.com>
927 Unreviewed, rolling out r73392.
928 http://trac.webkit.org/changeset/73392
929 https://bugs.webkit.org/show_bug.cgi?id=50489
931 This commit caused crashes on the GTK+ bots
933 * WebView/WebFrame.mm:
934 (-[WebFrame _canProvideDocumentSource]):
936 2010-12-07 Kenichi Ishibashi <bashi@google.com>
938 Reviewed by Kent Tamura.
940 Let HTMLObjectElement be a form associated element
941 https://bugs.webkit.org/show_bug.cgi?id=48821
943 Modified to use FormAssociatedElement instead of HTMLFormControlElement.
945 * WebView/WebHTMLRepresentation.mm:
946 (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
947 FormAssociatedElement instead of HTMLFormControlElement.
948 (-[WebHTMLRepresentation controlsInForm:]): Ditto.
950 2010-12-06 Nate Chapin <japhet@chromium.org>
952 Reviewed by Adam Barth.
954 Update calls to DocumentWriter.
955 https://bugs.webkit.org/show_bug.cgi?id=50489
957 * WebView/WebFrame.mm:
958 (-[WebFrame _canProvideDocumentSource]):
960 2010-12-06 Chris Marrin <cmarrin@apple.com>
962 Reviewed by Simon Fraser.
964 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
965 https://bugs.webkit.org/show_bug.cgi?id=49388
967 Got rid of GraphicsLayer::nativeLayer() call, replacing it with
968 GraphicsLayer::platformLayer().
970 * WebCoreSupport/WebChromeClient.mm:
971 (WebChromeClient::attachRootGraphicsLayer):
973 2010-12-04 Dan Bernstein <mitz@apple.com>
975 Reviewed by Sam Weinig.
977 WebKit part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
978 https://bugs.webkit.org/show_bug.cgi?id=50530
980 * WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches:
981 * WebView/WebHTMLView.mm:
982 (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter,
983 which is passed through to WebCore.
984 * WebView/WebPDFView.mm:
985 (isFrameInRange): Added this helper function.
986 (-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and
987 a check if the frame is in the range.
988 * WebView/WebView.mm:
989 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version.
990 (-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange
991 parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:.
992 * WebView/WebViewPrivate.h:
994 2010-12-03 Sam Weinig <sam@webkit.org>
996 Reviewed by Maciej Stachowiak.
998 Enable <a ping> for Mac/Windows/WebKit2 builds
999 <rdar://problem/8504473>
1000 https://bugs.webkit.org/show_bug.cgi?id=50488
1002 * WebView/WebPreferences.mm:
1003 (+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.
1005 2010-12-03 Jia Pu <jpu@apple.com>
1007 Reviewed by Darin Adler.
1009 Need to move all code that applies correction into correction panel callback.
1010 https://bugs.webkit.org/show_bug.cgi?id=50426
1011 <rdar://problem/8720832>
1013 * WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel.
1015 * WebCoreSupport/WebEditorClient.mm:
1016 (WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel.
1017 (WebEditorClient::showCorrectionPanel): Added more user dictionary learning code.
1018 (WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel.
1020 2010-12-02 Simon Fraser <simon.fraser@apple.com>
1022 Revert r73217 and r73227 because of continued bustage.
1024 * WebCoreSupport/WebChromeClient.mm:
1025 (WebChromeClient::attachRootGraphicsLayer):
1027 2010-12-02 Chris Marrin <cmarrin@apple.com>
1029 Reviewed by Simon Fraser.
1031 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
1032 https://bugs.webkit.org/show_bug.cgi?id=49388
1034 Got rid of GraphicsLayer::nativeLayer() call, replacing it with
1035 GraphicsLayer::platformLayer().
1037 * WebCoreSupport/WebChromeClient.mm:
1038 (WebChromeClient::attachRootGraphicsLayer):
1040 2010-12-02 Mark Rowe <mrowe@apple.com>
1042 Reviewed by Beth Dakin.
1044 <rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool
1046 * Misc/WebNSFileManagerExtras.m:
1047 (setMetaData): Create an autorelease pool for the duration of the thread body.
1049 2010-12-02 John Knottenbelt <jknotten@chromium.org>
1051 Reviewed by Steve Block.
1053 Move requestGeolocationPermissionForFrame to GeolocationClient
1054 https://bugs.webkit.org/show_bug.cgi?id=50061
1056 This change facilitates client-based geolocation implementation by
1057 bringing together permission control into the geolocation client
1060 Move method ChromeClient::requestGeolocationPermissionForFrame to
1061 GeolocationClient::requestPermission, and supporting class
1062 WebGeolocationPolicyListener. The moved code is unchanged except
1063 that requestPermission now takes only one argument (Geolocation*)
1064 and the Frame parameter is retrieved from the Geolocation object.
1066 * WebCoreSupport/WebChromeClient.h:
1067 * WebCoreSupport/WebChromeClient.mm:
1068 * WebCoreSupport/WebGeolocationClient.h:
1069 (WebGeolocationClient::cancelPermissionRequest):
1070 * WebCoreSupport/WebGeolocationClient.mm:
1071 (WebGeolocationClient::requestPermission):
1072 (-[WebGeolocationPolicyListener initWithGeolocation:]):
1073 (-[WebGeolocationPolicyListener allow]):
1074 (-[WebGeolocationPolicyListener deny]):
1076 2010-12-02 Joseph Pecoraro <joepeck@webkit.org>
1078 Reviewed by Eric Carlson.
1080 Style Fixes in WebPluginController
1081 https://bugs.webkit.org/show_bug.cgi?id=50397
1083 * Plugins/WebPluginController.mm:
1084 (-[WebPluginController startAllPlugins]):
1085 (-[WebPluginController stopAllPlugins]):
1087 2010-12-02 John Sullivan <sullivan@apple.com>
1089 Reviewed by Adam Roben.
1091 Slightly speculative fix for:
1093 <rdar://problem/8712674>
1094 <https://bugs.webkit.org/show_bug.cgi?id=50393>
1095 setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]
1097 * Panels/WebAuthenticationPanel.m:
1098 (-[WebAuthenticationPanel setUpForChallenge:]):
1099 If the realm is nil, use @"" instead.
1101 2010-12-01 Jia Pu <jpu@apple.com>
1103 Reviewed by Darin Adler.
1105 Support multiple correction candidates panel for misspelled word on Mac OS X.
1106 https://bugs.webkit.org/show_bug.cgi?id=50137
1107 <rdar://problem/8568059>
1109 This patch is for supporting multiple correction suggestion panel on Mac OS X.
1110 The behavior and implementation is similar to that of reversion candiate panel.
1112 * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
1114 * WebCoreSupport/WebEditorClient.mm: Adopted new signatures defined in base class.
1115 Added code to handle new multiple suggestion canidate panel type.
1116 (WebEditorClient::showCorrectionPanel):
1117 (WebEditorClient::getGuessesForWord):
1119 2010-12-01 David Hyatt <hyatt@apple.com>
1121 Reviewed by Darin Adler.
1123 https://bugs.webkit.org/show_bug.cgi?id=46645
1125 Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
1126 recently added for horizontal RTL documents and applies it to writing modes as well. Now the
1127 scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.
1129 This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
1130 makes them behave the same as the cross-platform code (allowing for cross-platform results to be
1133 * WebView/WebDynamicScrollBarsView.mm:
1134 (-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
1135 (-[WebDynamicScrollBarsView updateScrollers]):
1136 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
1137 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
1138 (-[WebDynamicScrollBarsView scrollOrigin]):
1139 * WebView/WebFrameView.mm:
1140 (-[WebFrameView _scrollToBeginningOfDocument]):
1141 (-[WebFrameView _scrollToEndOfDocument]):
1143 2010-11-29 Dan Bernstein <mitz@apple.com>
1145 Reviewed by Darin Adler.
1147 WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
1148 https://bugs.webkit.org/show_bug.cgi?id=50038
1149 Based on a patch from Darin Adler.
1151 * WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and
1152 replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based
1153 method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options:
1154 method. Made WebHTMLView conform to the new protocol.
1155 * WebView/WebHTMLView.mm:
1156 (coreOptions): Added. Converts WebFindOptions to WebCore FindOptions.
1157 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use
1158 -findString:options:.
1159 (-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
1160 (-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString().
1161 * WebView/WebPDFView.mm:
1162 (-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
1163 * WebView/WebView.mm:
1164 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to
1165 -countMatchesForText:options:highlight:limit:markMatches.
1166 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto.
1167 (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to
1168 -findString:options:.
1169 (incrementFrame): Changed to use WebFindOptions.
1170 (findString): Added this helper method that performs the search using the best supported
1171 method for the document view.
1172 (-[WebView findString:options:]): Changed -searchFor::::: into this.
1173 (-[WebView canMarkAllTextMatches]):
1174 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use
1176 (-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame.
1177 (-[WebView rectsForTextMatches]): Ditto.
1178 * WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version
1179 of countMatchesForText:.
1181 2010-11-29 Jeremy Moskovich <jeremy@chromium.org>
1183 Reviewed by David Hyatt.
1185 Right-to-left pages should be scrollable to reveal left overflow.
1186 https://bugs.webkit.org/show_bug.cgi?id=23556
1188 Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
1189 Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
1190 pages with a left overflow.
1192 * WebView/WebDynamicScrollBarsView.h:
1193 * WebView/WebDynamicScrollBarsView.mm:
1194 (-[WebDynamicScrollBarsView inProgramaticScroll]):
1195 (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]):
1196 (-[WebDynamicScrollBarsView updateScrollers]):
1197 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
1198 (-[WebDynamicScrollBarsView setScrollOriginX:]):
1199 (-[WebDynamicScrollBarsView scrollOriginX]):
1200 * WebView/WebFrameView.mm:
1201 (-[WebFrameView _scrollToBeginningOfDocument]):
1202 (-[WebFrameView _scrollToEndOfDocument]):
1203 * WebView/WebHTMLView.mm:
1204 (-[WebHTMLView _frameOrBoundsChanged]):
1206 2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
1208 Reviewed by Tony Chang.
1210 SelectionController::typingStyle() should return EditingStyle*
1211 https://bugs.webkit.org/show_bug.cgi?id=49813
1213 Changed the return value of SelectionController::typingStyle() to EditingStyle*.
1214 Also added SelectionController::copyTypingStyle() to copy the typing style
1215 as an instance of CSSMutableStyleDeclaration.
1217 No tests are added since this is no behavioral change.
1219 * WebView/WebFrame.mm:
1220 (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()
1222 2010-11-19 Michael Saboff <msaboff@apple.com>
1224 Reviewed by Sam Weinig
1226 Remove DOMSVGAnimatedPathData.h from all: target to fix build.
1228 * MigrateHeaders.make:
1230 2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
1232 Reviewed by Dirk Schulze.
1234 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
1235 https://bugs.webkit.org/show_bug.cgi?id=49580
1237 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
1239 2010-11-18 Mark Rowe <mrowe@apple.com>
1241 Rubber-stamped by Adam Roben.
1243 <rdar://problem/8602509&8602717&8602724> Enable compaction support.
1245 * Configurations/WebKit.xcconfig:
1247 2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>
1249 Unreviewed, rolling out r72288.
1250 http://trac.webkit.org/changeset/72288
1251 https://bugs.webkit.org/show_bug.cgi?id=49730
1253 'krit attempted to do that, but revert got stuck' (Requested
1254 by antonm on #webkit).
1256 * WebView/WebRenderLayer.mm:
1258 2010-11-17 Nikolas Zimmermann <nzimmermann@rim.com>
1260 Reviewed by Dirk Schulze.
1262 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
1263 https://bugs.webkit.org/show_bug.cgi?id=49580
1265 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
1267 2010-11-16 Stephanie Lewis <slewis@apple.com>
1269 Reviewed by Geoff Garen.
1271 <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
1273 Make a static provider for WebDeviceOrientationProviderMock. The old code allocated a new WebDeviceOrientationProviderMock for
1274 every WebView, and the WebKit API doesn't support that ownership model.
1276 * WebView/WebDeviceOrientationProviderMock.h:
1277 * WebView/WebDeviceOrientationProviderMock.mm:
1278 (+[WebDeviceOrientationProviderMock shared]):
1280 2010-11-16 Dave Hyatt <hyatt@apple.com>
1282 Reviewed by Dan Bernstein.
1284 https://bugs.webkit.org/show_bug.cgi?id=11004
1286 font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
1287 Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
1288 since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
1289 of the constructor rather than using [NSFont pointSize].
1291 https://bugs.webkit.org/show_bug.cgi?id=49582
1293 Negative leading is not handled correctly. There are two bugs here. The first is that
1294 maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
1295 set them before so that we can allow them to be < 0.
1297 The second issue is that we should understand where fonts will end up relative to
1298 our baseline (excluding line height), and only allow those boxes to impact ascent and
1299 descent if the actual font box (without factoring in line height) is above or below the
1300 root line box baseline.
1302 Added fast/css/negative-leading.html
1304 These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
1306 * Misc/WebKitNSStringExtras.mm:
1307 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1308 (-[NSString _web_widthWithFont:]):
1309 * Misc/WebStringTruncator.mm:
1311 * WebView/WebPreferences.mm:
1312 (+[WebPreferences initialize]):
1314 2010-11-16 Anders Carlsson <andersca@apple.com>
1318 * WebCoreSupport/WebFrameLoaderClient.mm:
1320 2010-11-14 Kent Tamura <tkent@chromium.org>
1322 Reviewed by Andreas Kling.
1324 KeyboardEvent::keyIdentifier() should return "const String&"
1325 https://bugs.webkit.org/show_bug.cgi?id=49426
1327 * WebCoreSupport/WebEditorClient.mm:
1328 (selectorForKeyEvent):
1329 Change the type of a variable to have keyIdentifier(); String -> const String&
1331 2010-11-12 John Knottenbelt <jknotten@chromium.org>
1333 Reviewed by Steve Block.
1335 Rename GeolocationControllerClient to GeolocationClient.
1336 https://bugs.webkit.org/show_bug.cgi?id=49259
1338 * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h.
1339 (WebGeolocationClient::webView):
1340 (WebGeolocationClient::setEnableHighAccuracy):
1341 * WebCoreSupport/WebGeolocationClient.mm: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm.
1342 (WebGeolocationClient::WebGeolocationClient):
1343 (WebGeolocationClient::geolocationDestroyed):
1344 (WebGeolocationClient::startUpdating):
1345 (WebGeolocationClient::stopUpdating):
1346 (WebGeolocationClient::lastPosition):
1348 * WebView/WebView.mm:
1349 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1351 2010-11-10 Beth Dakin <bdakin@apple.com>
1353 Reviewed by Simon Fraser.
1355 Fix for https://bugs.webkit.org/show_bug.cgi?id=49356
1356 -[WebView _scaleWebView:] should take and origin and scroll the
1359 <rdar://problem/8643921>
1361 * WebView/WebView.mm:
1362 (-[WebView _scaleWebView:atOrigin:]):
1363 * WebView/WebViewPrivate.h:
1365 2010-11-10 Csaba Osztrogonác <ossy@webkit.org>
1367 Reviewed by David Hyatt.
1369 HTML5 Ruby support should be mandatory feature
1370 https://bugs.webkit.org/show_bug.cgi?id=49272
1372 Remove Ruby as optional feature.
1374 * Configurations/FeatureDefines.xcconfig:
1376 2010-11-08 Ned Holbrook <nholbrook@apple.com>
1378 Reviewed by Adam Barth.
1380 Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
1381 https://bugs.webkit.org/show_bug.cgi?id=48886
1383 * WebCoreSupport/WebSystemInterface.mm:
1384 (InitWebCoreSystemInterface):
1386 2010-11-08 Nate Chapin <japhet@chromium.org>
1388 Unreviewed, build fix.
1390 Clumsy typo in r71562.
1392 * Plugins/Hosted/HostedNetscapePluginStream.mm:
1393 (WebKit::HostedNetscapePluginStream::start):
1395 2010-11-08 Nate Chapin <japhet@chromium.org>
1397 Reviewed by Alexey Proskuryakov.
1399 Interface changes in https://bugs.webkit.org/show_bug.cgi?id=27165
1401 * Plugins/Hosted/HostedNetscapePluginStream.mm:
1402 (WebKit::HostedNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
1403 * Plugins/WebNetscapePluginStream.mm:
1404 (WebNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
1405 * WebView/WebView.mm:
1406 (-[WebView _dispatchPendingLoadRequests]): Use resourceLoadScheduler() instead of cache()->loader().
1408 2010-11-08 Anders Carlsson <andersca@apple.com>
1410 Reviewed by Dan Bernstein.
1412 Plug-in views should not assume that plugins are RenderEmbeddedObjects
1413 https://bugs.webkit.org/show_bug.cgi?id=49196
1414 <rdar://problem/8638467>
1416 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1417 (-[WebHostedNetscapePluginView pluginHostDied]):
1419 2010-11-08 Alexey Proskuryakov <ap@apple.com>
1421 Reviewed by Darin Adler.
1423 https://bugs.webkit.org/show_bug.cgi?id=48685
1424 Notify UI process about focused frame
1426 Added an empty implementation of the new ChromeClient method.
1428 * WebCoreSupport/WebChromeClient.h:
1429 * WebCoreSupport/WebChromeClient.mm:
1430 (WebChromeClient::focusedFrameChanged):
1432 2010-11-08 Anders Carlsson <andersca@apple.com>
1436 * MigrateHeaders.make:
1438 2010-11-08 Anders Carlsson <andersca@apple.com>
1440 Reviewed by Adam Roben.
1442 Remove use of HIGetScaleFactor
1443 https://bugs.webkit.org/show_bug.cgi?id=49186
1444 <rdar://problem/8618410>
1446 Scale factors can vary on a display-by-display basis and it doesn't make sense
1447 to compute scale factor event coordinates like this.
1449 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1452 2010-11-08 Simon Fraser <simon.fraser@apple.com>
1454 Reviewed by Sam Weinig.
1456 Allow applets to participate in accelerated compositing
1457 https://bugs.webkit.org/show_bug.cgi?id=49117
1458 <rdar://problem/8625819>
1460 If Java is being loaded via the Netscape Plugin API, create a
1461 NetscapePluginWidget so that it has an implementation of platformLayer().
1463 Also clean up by using early returns.
1465 * WebCoreSupport/WebFrameLoaderClient.mm:
1467 2010-11-07 Adam Barth <abarth@webkit.org>
1469 Reviewed by Eric Seidel.
1471 Rename Cache to MemoryCache
1472 https://bugs.webkit.org/show_bug.cgi?id=49159
1475 (+[WebCache statistics]):
1476 * WebCoreSupport/WebDeviceOrientationClient.mm:
1477 (WebDeviceOrientationClient::setController):
1478 * WebView/WebView.mm:
1480 2010-11-05 Alexey Proskuryakov <ap@apple.com>
1482 Reviewed by Darin Adler.
1484 https://bugs.webkit.org/show_bug.cgi?id=49100
1485 ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers]
1487 * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]):
1488 Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive
1489 (see bug comments), and there seems to be no harm in executing this function in that case.
1491 2010-11-05 Chris Marrin <cmarrin@apple.com>
1493 Reviewed by Simon Fraser.
1495 Move resumeAnimations/suspendAnimations from Frame to AnimationController.
1496 https://bugs.webkit.org/show_bug.cgi?id=49073
1498 * WebView/WebFrame.mm:
1499 (-[WebFrame _suspendAnimations]):
1500 (-[WebFrame _resumeAnimations]):
1502 2010-11-04 Alexey Proskuryakov <ap@apple.com>
1504 Reviewed by Darin Adler.
1506 https://bugs.webkit.org/show_bug.cgi?id=49008
1507 <rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp
1509 Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during
1510 the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be
1511 deleted during wait:
1513 - plugin was stopped (e.g. due to a DOM modification performed by another reply that came in
1516 We didn't recognize the latter.
1518 * Plugins/Hosted/NetscapePluginHostProxy.mm:
1519 (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
1520 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1521 (WebKit::NetscapePluginInstanceProxy::waitForReply):
1522 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1523 (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
1525 2010-11-05 Chris Marrin <cmarrin@apple.com>
1527 Reviewed by Simon Fraser.
1529 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
1530 https://bugs.webkit.org/show_bug.cgi?id=46945
1532 * WebView/WebFrame.mm:
1533 (-[WebFrame _suspendAnimations]):
1534 (-[WebFrame _resumeAnimations]):
1536 2010-11-04 Jia Pu <jpu@apple.com>
1538 Reviewed by Dan Bernstein.
1540 reversion bubble in WebViews
1541 https://bugs.webkit.org/show_bug.cgi?id=47630
1542 <rdar://problem/8530960>
1544 This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.
1546 * WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
1547 * WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code
1548 change to use new reversion API in AppKit.
1549 (WebEditorClient::WebEditorClient):
1550 (WebEditorClient::~WebEditorClient):
1551 (WebEditorClient::respondToChangedSelection):
1552 (WebEditorClient::showCorrectionPanel):
1553 (WebEditorClient::dismissCorrectionPanel):
1554 (WebEditorClient::isShowingCorrectionPanel):
1556 2010-11-04 Mike Thole <mthole@apple.com>
1558 Reviewed by Dan Bernstein.
1560 Title for images should use localized numerals
1561 https://bugs.webkit.org/show_bug.cgi?id=49017
1563 * WebCoreSupport/WebPlatformStrategies.mm:
1564 (WebPlatformStrategies::imageTitle): Use localized numerals on Snow Leopard or newer.
1566 2010-11-02 Daniel Bates <dbates@rim.com>
1568 Reviewed by Adam Barth.
1570 For unnamed frames, window.name returns a generated name
1571 https://bugs.webkit.org/show_bug.cgi?id=6751
1575 Substitute FrameTree::uniqueName() for FrameTree::name() in the Mac port.
1577 * WebView/WebFrame.mm:
1580 2010-11-01 Brady Eidson <beidson@apple.com>
1582 Reviewed by Anders Carlsson.
1584 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
1585 Context menu support for WebKit 2.
1587 * WebCoreSupport/WebChromeClient.h:
1588 (WebChromeClient::showContextMenu):
1590 2010-10-29 Daniel Bates <dbates@rim.com>
1592 No review, rolling out 70971.
1593 http://trac.webkit.org/changeset/70971
1594 https://bugs.webkit.org/show_bug.cgi?id=6751
1596 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
1597 it caused layout test failures on all bots. In particular, the
1598 child count in a generated frame name differs after this patch. We need
1599 to look into this further.
1601 * WebView/WebFrame.mm:
1604 2010-10-28 Antonio Gomes <agomes@rim.com>
1606 Reviewed by Ojan Vafai.
1608 Needs a "LinuxEditingBehavior", perhaps with a better name
1609 https://bugs.webkit.org/show_bug.cgi?id=36627
1611 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
1613 * WebView/WebFrame.mm:
1615 * WebView/WebPreferencesPrivate.h:
1617 2010-10-29 Daniel Bates <dbates@rim.com>
1619 Reviewed by Adam Barth.
1621 For unnamed frames, window.name returns a generated name
1622 https://bugs.webkit.org/show_bug.cgi?id=6751
1624 Modified Mac-port to use FrameTree::uniqueName().
1626 * WebView/WebFrame.mm:
1629 2010-10-29 Darin Adler <darin@apple.com>
1631 Reviewed by Sam Weinig.
1633 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
1634 https://bugs.webkit.org/show_bug.cgi?id=48574
1636 * History/WebBackForwardList.mm:
1637 Use BackForwardListImpl.
1639 2010-10-29 Alexey Proskuryakov <ap@apple.com>
1641 Rubber-stamped by Sam Weinig.
1643 Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do
1644 create views for subframes.
1646 * WebView/WebViewData.h: Double negation is better than a lie.
1648 2010-10-27 Jer Noble <jer.noble@apple.com>
1650 Reviewed by Darin Adler.
1652 Full screen video in Safari (still) exits full-screen if you switch to another
1653 app on a multi-display system.
1654 https://bugs.webkit.org/show_bug.cgi?id=47364
1655 <rdar://problem/8382299>
1657 The FullScreen window does not technically close when it deactivates, but the
1658 two NSWindows that make up the FullScreen feature should not hide when deactivated.
1660 * WebView/WebVideoFullscreenController.mm:
1661 (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate.
1662 (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
1663 * WebView/WebVideoFullscreenHUDWindowController.mm:
1664 (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
1666 2010-10-29 Alexey Proskuryakov <ap@apple.com>
1668 Reviewed by Darin Adler.
1670 https://bugs.webkit.org/show_bug.cgi?id=48576
1671 Let WebKit2 client know when a frame is a frameset
1673 Added a blank implementation of the new FrameLoaderClient method.
1675 * WebCoreSupport/WebFrameLoaderClient.h:
1676 * WebCoreSupport/WebFrameLoaderClient.mm:
1677 (WebFrameLoaderClient::dispatchDidBecomeFrameset):
1679 2010-10-29 Csaba Osztrogonác <ossy@webkit.org>
1681 Reviewed by Adam Roben and David Kilzer.
1683 Fix and cleanup of build systems
1684 https://bugs.webkit.org/show_bug.cgi?id=48342
1686 * Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX.
1688 2010-10-28 Dan Bernstein <mitz@apple.com>
1690 Reviewed by Mark Rowe.
1692 LLVM compiler build fix
1694 * Misc/WebDownload.mm:
1695 (-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to
1696 id<NSURLDownloadDelegate> to match the method signature in NSURLDownload.
1698 2010-10-28 Ivan Krstić <ike@apple.com>
1700 Reviewed by Mark Rowe.
1702 Remove unused experimental proxied panel interface.
1703 <rdar://problem/7237059>
1705 * Plugins/Hosted/NetscapePluginHostManager.h:
1706 * Plugins/Hosted/NetscapePluginHostManager.mm:
1707 (WebKit::NetscapePluginHostManager::hostForPlugin):
1708 (WebKit::NetscapePluginHostManager::spawnPluginHost):
1709 (WebKit::NetscapePluginHostManager::instantiatePlugin):
1710 * Plugins/Hosted/NetscapePluginHostProxy.mm:
1711 * Plugins/Hosted/WebKitPluginClient.defs:
1712 * Plugins/Hosted/WebKitPluginHost.defs:
1713 * WebCoreSupport/WebSystemInterface.mm:
1714 (InitWebCoreSystemInterface):
1715 * WebView/WebPreferenceKeysPrivate.h:
1716 * WebView/WebPreferences.mm:
1717 (+[WebPreferences initialize]):
1718 * WebView/WebPreferencesPrivate.h:
1720 2010-10-27 Pratik Solanki <psolanki@apple.com>
1722 Reviewed by Darin Adler.
1724 Improve memSize calculation in [WebView _setCacheModel]
1725 https://bugs.webkit.org/show_bug.cgi?id=48484
1727 * WebView/WebView.mm:
1728 (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2.
1729 (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next
1730 bigger power of 2. Also update WebCore cache settings.
1732 2010-10-26 Darin Adler <darin@apple.com>
1734 Reviewed by Sam Weinig.
1736 WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
1737 https://bugs.webkit.org/show_bug.cgi?id=42322
1738 rdar://problem/8193631
1740 WebKitTestRunner needs to support layoutTestController.clearBackForwardList
1741 https://bugs.webkit.org/show_bug.cgi?id=42333
1742 rdar://problem/8193643
1744 * History/WebBackForwardList.mm:
1745 (core): Return BackForwardListImpl.
1746 (kit): Take BackForwardListImpl.
1747 (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl.
1748 (-[WebBackForwardList dealloc]): Ditto.
1749 (-[WebBackForwardList finalize]): Ditto.
1750 (-[WebBackForwardList description]): Ditto.
1751 (-[WebBackForwardList setPageCacheSize:]): Ditto.
1752 (-[WebBackForwardList pageCacheSize]): Ditto.
1753 * History/WebBackForwardListInternal.h: Ditto.
1754 * WebView/WebFrameView.mm:
1755 (-[WebFrameView keyDown:]): Ditto.
1756 * WebView/WebView.mm:
1757 (-[WebView initWithCoder:]): Ditto.
1758 (-[WebView encodeWithCoder:]): Ditto.
1759 (-[WebView backForwardList]): Ditto.
1760 (-[WebView setMaintainsBackForwardList:]): Ditto.
1762 2010-10-27 Chris Rogers <crogers@google.com>
1764 Reviewed by Chris Marrin.
1766 Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
1767 https://bugs.webkit.org/show_bug.cgi?id=48279
1769 * Configurations/FeatureDefines.xcconfig:
1771 2010-10-27 Beth Dakin <bdakin@apple.com>
1773 Reviewed by Darin Adler.
1775 Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit
1776 SPI to scale a WebView
1778 <rdar://problem/8107667>
1780 This patch adds SPI to Mac WebKit that scales the page by the given
1783 * WebView/WebView.mm:
1784 (-[WebView _scaleWebView:]):
1785 (-[WebView _viewScaleFactor]):
1786 * WebView/WebViewPrivate.h:
1788 2010-10-27 Dan Bernstein <mitz@apple.com>
1790 Reviewed by Darin Adler.
1792 REGRESSION (r70335): Incorrect article layout in Safari Reader
1793 https://bugs.webkit.org/show_bug.cgi?id=48436
1795 * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS.
1796 * WebView/WebView.mm:
1797 (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against
1798 versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules().
1799 (-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled()
1802 2010-10-18 Jer Noble <jer.noble@apple.com>
1804 Reviewed by Eric Carlson.
1806 Safari fullscreen media element tickles when it should not.
1808 https://bugs.webkit.org/show_bug.cgi?id=47861
1810 * WebView/WebVideoFullscreenController.mm:
1811 (-[WebVideoFullscreenController updatePowerAssertions]):
1813 2010-10-26 Jenn Braithwaite <jennb@chromium.org>
1815 Reviewed by Dmitry Titov.
1817 Resource tracking failure when trying to move a frame between documents
1818 https://bugs.webkit.org/show_bug.cgi?id=44713
1820 * WebCoreSupport/WebFrameLoaderClient.h:
1821 * WebCoreSupport/WebFrameLoaderClient.mm:
1822 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
1824 (WebFrameLoaderClient::transferLoadingResourceFromPage):
1825 Update resource tracking for a resource load that has been transferred
1828 2010-10-25 Oliver Hunt <oliver@apple.com>
1830 Reviewed by Gavin Barraclough.
1832 Remove exec and globalData arguments from jsNumber
1833 https://bugs.webkit.org/show_bug.cgi?id=48270
1835 Mechanical removal of exec parameter to jsNumber
1837 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1838 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
1839 * Plugins/Hosted/ProxyInstance.mm:
1840 (WebKit::ProxyInstance::numberValue):
1842 2010-10-24 Dan Bernstein <mitz@apple.com>
1844 Reviewed by Anders Carlsson.
1846 Expose HitTestResult::absoluteMediaURL() via WebKit API
1847 https://bugs.webkit.org/show_bug.cgi?id=48219
1849 * Misc/WebElementDictionary.mm:
1850 (+[WebElementDictionary initializeLookupTable]): Map WebElementMediaURLKey to
1852 (-[WebElementDictionary _absoluteMediaURL]): Added. Returns absoluteMediaURL().
1853 * WebKit.exp: Export WebElementMediaURLKey.
1854 * WebView/WebView.mm: Define WebElementMediaURLKey.
1855 * WebView/WebViewPrivate.h: Declare WebElementMediaURLKey.
1857 2010-10-24 Dan Bernstein <mitz@apple.com>
1859 Reviewed by Simon Fraser.
1861 Removed deprecated methods from the WebHTMLHighlighter private protocol.
1863 * WebCoreSupport/WebChromeClient.mm:
1864 (WebChromeClient::customHighlightRect): Call -highlightRectForLine:representedNode:
1866 (WebChromeClient::paintCustomHighlight): Call
1867 -paintHighlightForBox:onLine:behindText:entireLine:representedNode: unconditionally.
1868 * WebView/WebHTMLViewPrivate.h:
1870 2010-10-23 Xan Lopez <xlopez@igalia.com>
1872 Reviewed by Sam Weinig.
1874 Unify globalData APIs
1875 https://bugs.webkit.org/show_bug.cgi?id=47969
1877 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1878 (WebKit::NetscapePluginInstanceProxy::evaluate):
1879 (WebKit::NetscapePluginInstanceProxy::invoke):
1880 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1881 (WebKit::NetscapePluginInstanceProxy::construct):
1882 * WebView/WebScriptDebugDelegate.mm:
1883 (-[WebScriptCallFrame evaluateWebScript:]):
1885 2010-10-23 David Kilzer <ddkilzer@apple.com>
1887 <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
1889 Reviewed by Sam Weinig.
1891 The only method defined in WebHTMLRepresentationInternal.h is
1892 also defined in WebHTMLRepresentation.h, so use that instead.
1894 * WebView/WebHTMLRepresentationInternal.h: Removed.
1896 2010-10-23 Alexey Proskuryakov <ap@apple.com>
1898 Reviewed by Anders Carlsson.
1900 https://bugs.webkit.org/show_bug.cgi?id=48083
1901 <rdar://problem/8489082> Need WebKit2 API for private browsing (48083)
1903 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize the new method.
1905 2010-10-22 Sam Weinig <sam@webkit.org>
1907 Reviewed by Anders Carlsson.
1909 WebKit2 needs to pass the current event modifier flags when requesting a new window
1910 https://bugs.webkit.org/show_bug.cgi?id=48140
1912 * WebCoreSupport/WebChromeClient.h:
1913 * WebCoreSupport/WebChromeClient.mm:
1914 (WebChromeClient::createWindow):
1915 * WebCoreSupport/WebFrameLoaderClient.h:
1916 * WebCoreSupport/WebFrameLoaderClient.mm:
1917 (WebFrameLoaderClient::dispatchCreatePage):
1918 Add NavigationAction parameter.
1920 2010-10-21 Andy Estes <aestes@apple.com>
1922 Reviewed by Eric Carlson.
1924 WebKit shouldn't load a plug-in based on file extension if a MIME type
1926 https://bugs.webkit.org/show_bug.cgi?id=48046
1928 If a MIME type is specified in an object or embed element, and that MIME
1929 type isn't supported by an installed plug-in, WebKit shouldn't attempt
1930 to find a plug-in based on the file extension of the url attribute.
1931 Doing so can lead to cases where a plug-in is loaded that can't handle
1932 resources of the MIME type specified by the author.
1934 * WebCoreSupport/WebFrameLoaderClient.mm:
1935 (WebFrameLoaderClient::createPlugin): Only check for a pluginPackage by
1936 extension if MIME type is the empty string.
1938 2010-10-20 Simon Fraser <simon.fraser@apple.com>
1940 Reviewed by Dan Bernstein.
1942 Composited elements drawn twice when WebView is layer-backed
1943 https://bugs.webkit.org/show_bug.cgi?id=48024
1944 <rdar://problem/7916580>
1946 When drawing content in a layer-backed WebView, WebFrame's test
1947 for drawing to a bitmap succeeded, causing us to paint flattened
1948 compositing layers into the view. They would also be rendered
1949 by the normal compositing path, resulting in double rendering.
1951 Fix this by detecting when the WebHTMLView is being drawn into
1952 a layer, and avoiding flattening in that case.
1954 * WebView/WebFrame.mm:
1955 (-[WebFrame _showFlattenedCompositingLayers:]):
1956 (-[WebFrame _drawRect:contentsOnly:]):
1957 * WebView/WebHTMLView.mm:
1958 (-[WebHTMLView drawLayer:inContext:]):
1959 (-[WebHTMLView _web_isDrawingIntoLayer]):
1960 * WebView/WebHTMLViewInternal.h:
1962 2010-10-20 Dumitru Daniliuc <dumi@chromium.org>
1964 Reviewed by David Levin.
1966 Repost the DatabaseTracker notifications to the main thread, if needed.
1967 https://bugs.webkit.org/show_bug.cgi?id=40655
1969 * Storage/WebDatabaseTrackerClient.mm:
1970 (DidModifyOriginData::dispatchToMainThread):
1971 (DidModifyOriginData::DidModifyOriginData):
1972 (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
1973 (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
1974 (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
1976 2010-10-20 Simon Fraser <simon.fraser@apple.com>
1978 Reviewed by Darin Adler.
1980 REGRESSION(r67568-r67643): Some HTML/CSS renders upside down and backwards on Leopard
1981 https://bugs.webkit.org/show_bug.cgi?id=47369
1983 r46947 added code that limits the size of the layer-backed view on Leopard when
1984 the page height exceeds 4096px (later adjusted to 2048px in r48401).
1986 Later, r67576 altered the geometry flipping behavior to push the geometry flipping
1987 down into WebKit. However, the code that adjusts the hosting layer's sublayer transform
1988 to account for layer-backed view size-limiting was not fixed at the same time.
1989 This change corrects that.
1991 * WebView/WebHTMLView.mm:
1992 (-[WebHTMLView _updateLayerHostingViewPosition]):
1994 2010-10-19 Simon Fraser <simon.fraser@apple.com>
1996 Reviewed by Dan Bernstein.
1998 <rdar://problem/8508422> Compositing layers aren't always displayed correctly in layer-backed WebViews
2000 AppKit has some special code to prevent it meddling with view's layers
2001 under layer-backed WebViews. When a layer-backed WebView became composited,
2002 this caused our layer to remain zero-sized. Fix this by manually
2003 setting the geometry for our layer, if the WebHTMLView has a layer.
2005 This does not seem to be a problem if the WebView becomes layer-backed, or
2006 stops being layer-backed after the WebView starts using compositing.
2008 * WebView/WebHTMLView.mm:
2009 (-[WebHTMLView attachRootLayer:]):
2011 2010-10-20 Dirk Schulze <krit@webkit.org>
2013 Reviewed by Nikolas Zimmermann.
2015 Merge ColorSpace and ImageColorSpace enums
2016 https://bugs.webkit.org/show_bug.cgi?id=47922
2018 Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
2019 to follow webkit style rules.
2021 * Misc/WebKitNSStringExtras.mm:
2022 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2024 2010-10-19 Alexey Proskuryakov <ap@apple.com>
2026 Reviewed by Anders Carlsson.
2028 https://bugs.webkit.org/show_bug.cgi?id=47933
2029 <rdar://problem/8494337> navigator.language doesn't work in WebKit2
2031 * Misc/WebNSUserDefaultsExtras.mm: Moved code for computing default language to WebCore.
2032 We need to keep _webkit_preferredLanguageCode for Safari.
2034 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
2035 Initialize wkCopyCFLocalizationPreferredName.
2037 * WebCoreSupport/WebViewFactory.mm: Removed defaultLanguage. WebCore was the only caller.
2039 2010-10-18 Alexey Proskuryakov <ap@apple.com>
2041 Reviewed by David Kilzer.
2043 https://bugs.webkit.org/show_bug.cgi?id=47864
2044 Convert WebNSUserDefaultsExtras.m to .mm
2046 Also, fixed some issues in the process:
2047 - removed locking, which was only necessary when this code was in Foundation;
2048 - fixed notification center observer to actually work (previously, it picked up changes
2049 when application preferences changed, not when system language did);
2050 - removed unused NSString category;
2053 * Misc/WebNSUserDefaultsExtras.m: Removed.
2054 * Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m.
2055 (createHTTPStyleLanguageCode):
2056 (+[NSUserDefaults _webkit_defaultsDidChange]):
2057 (addLanguageChangeObserver):
2058 (+[NSUserDefaults _webkit_preferredLanguageCode]):
2060 2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
2062 Reviewed by Eric Seidel.
2064 Switch to using the new Carbon NPAPI event declarations, and remove
2067 https://bugs.webkit.org/show_bug.cgi?id=40784
2069 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2070 (WebNetscapePluginEventHandlerCarbon::mouseEntered):
2071 (WebNetscapePluginEventHandlerCarbon::mouseExited):
2072 (WebNetscapePluginEventHandlerCarbon::mouseMoved):
2073 (WebNetscapePluginEventHandlerCarbon::focusChanged):
2075 2010-10-18 Pavel Podivilov <podivilov@chromium.org>
2077 Reviewed by Timothy Hatcher.
2079 Web Inspector: disable private browsing for inspector
2080 https://bugs.webkit.org/show_bug.cgi?id=47827
2082 * WebCoreSupport/WebInspectorClient.mm:
2083 (-[WebInspectorWindowController init]):
2085 2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
2087 Reviewed by Pavel Feldman.
2089 Web Inspector: inspector settings/properties/states management
2090 should be extracted into separate class.
2092 We have a lot of flags/values in InspectorController.
2093 Some flags are persisting into profile.
2094 Others are part of inspector state for frontend.
2095 All these flags should keep their values after navigation.
2096 It'd be better to extract these flags/values into separate
2097 class which will care about theirs lifetime.
2099 https://bugs.webkit.org/show_bug.cgi?id=47275
2101 * WebCoreSupport/WebInspectorClient.mm:
2102 (-[WebInspectorWindowController showWindow:]):
2103 (-[WebInspectorWindowController attach]):
2104 (-[WebInspectorWindowController detach]):
2106 2010-10-13 Gavin Barraclough <barraclough@apple.com>
2108 Reviewed by Oliver Hunt.
2110 https://bugs.webkit.org/show_bug.cgi?id=43987
2111 Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
2112 to construct their internal result string. Remove ScriptString (this is now
2115 * WebCoreSupport/WebFrameLoaderClient.mm:
2117 2010-10-12 Andy Estes <aestes@apple.com>
2119 Rubber-stamped by Darin Adler.
2121 Check in some cleanup from the previous commit.
2123 * WebView/WebView.mm:
2124 (leakMailQuirksUserScriptPath): Renamed to indicate that this function
2126 (-[WebView _injectMailQuirksScript]): Moved a static initialization from
2127 a separate class method into the only method that used it and removed
2128 the now-unnecessary class method.
2130 2010-10-12 Eric Seidel <eric@webkit.org>
2132 Reviewed by Darin Adler.
2134 REGRESSION (new parser): Leopard/Tiger Mail <head>/<body> quirk is gone
2135 https://bugs.webkit.org/show_bug.cgi?id=45693
2137 Re-implement this former WebCore parser quirk as a
2138 Mac-only userscript-based quirk. As far as I can tell
2139 from Darin's description this should satisfy Mail's needs.
2141 * Misc/MailQuirksUserScript.js: Added.
2142 * WebView/WebView.mm:
2143 (+[WebView _mailQuirksUserScript]):
2144 (-[WebView _injectMailQuirksScript]):
2145 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2147 2010-10-12 Simon Fraser <simon.fraser@apple.com>
2149 Reviewed by Sam Weinig.
2151 Add 'didDraw' callback for framerate tracking
2152 https://bugs.webkit.org/show_bug.cgi?id=47478
2154 Add a callback at the end of -[WebHTMLView drawRect:] so
2155 a delegate can get notified when a draw happens.
2157 * WebView/WebHTMLView.mm:
2158 (-[WebHTMLView drawRect:]):
2159 * WebView/WebUIDelegatePrivate.h:
2161 2010-10-11 Anders Carlsson <andersca@apple.com>
2163 Reviewed by Darin Adler.
2165 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
2166 https://bugs.webkit.org/show_bug.cgi?id=47523
2168 Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
2170 * Misc/WebIconFetcher.h: Removed.
2171 * Misc/WebIconFetcher.mm: Removed.
2172 * Misc/WebIconFetcherInternal.h: Removed.
2173 * WebView/WebFrame.mm:
2174 * WebView/WebFramePrivate.h:
2176 2010-10-11 Jessie Berlin <jberlin@apple.com>
2178 Reviewed by Darin Adler.
2180 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
2181 representation of a WebKit1 WebSerializedJSValue.
2182 https://bugs.webkit.org/show_bug.cgi?id=47439
2184 * WebView/WebSerializedJSValue.mm:
2185 (-[WebSerializedJSValue internalRepresentation]):
2186 * WebView/WebSerializedJSValuePrivate.h:
2188 2010-10-07 Jessie Berlin <jberlin@apple.com>
2190 Reviewed by Sam Weinig.
2192 Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
2193 representation of a WebKit2 WebSerializedScriptValue.
2194 https://bugs.webkit.org/show_bug.cgi?id=47390
2196 * WebView/WebSerializedJSValue.mm:
2197 (-[WebSerializedJSValue initWithInternalRepresentation:]):
2198 Set the WebSerializedJSValuePrivate's WebCore::SerializedScriptValue to be the passed in
2199 internal representation.
2200 * WebView/WebSerializedJSValuePrivate.h: Added.
2202 2010-10-07 Antonio Gomes <agomes@rim.com>
2204 Reviewed by Simon Fraser.
2206 [Mac] [DRT] implement setSpatialNavigationEnabled
2207 https://bugs.webkit.org/show_bug.cgi?id=47291
2209 Added the needed bits to make it possible to enabled spatial navigation
2210 for the Mac port. For now it is being only used by DRT.
2212 * WebView/WebPreferenceKeysPrivate.h:
2213 * WebView/WebPreferences.mm:
2214 (+[WebPreferences initialize]):
2215 (-[WebPreferences isSpatialNavigationEnabled]):
2216 (-[WebPreferences setSpatialNavigationEnabled:]):
2217 * WebView/WebPreferencesPrivate.h:
2218 * WebView/WebView.mm:
2219 (-[WebView _preferencesChangedNotification:]):
2221 2010-10-07 Jer Noble <jer.noble@apple.com>
2223 Fix the Leopard 64-bit build.
2225 * Configurations/WebKit.xcconfig: Add CoreServices.framework/Frameworks to the
2226 framework search path.
2227 * WebView/WebVideoFullscreenController.mm: Explicitly import <OSStatus/Power.h>.
2229 2010-10-06 Jer Noble <jer.noble@apple.com>
2231 Reviewed by Darin Adler.
2233 Screensaver starts while watching fullscreen playback.
2234 https://bugs.webkit.org/show_bug.cgi?id=47299
2235 <rdar://problem/8478956>
2237 To disable the Screen Saver, we need to periodically call UpdateSystemActivity().
2239 * WebView/WebVideoFullscreenController.h: Added _tickleTimer.
2240 * WebView/WebVideoFullscreenController.mm:
2241 (-[WebVideoFullscreenController dealloc]): Invalidate _tickleTimer.
2242 (-[WebVideoFullscreenController _enableTickleTimer]): Create _tickleTimer.
2243 (-[WebVideoFullscreenController _disableTickleTimer]): Invalidate _tickleTimer.
2244 (-[WebVideoFullscreenController _tickleTimerFired]): Call UpdateSystemActivity().
2245 (-[WebVideoFullscreenController updatePowerAssertions]): Call _enableTickleTimer
2246 or _disableTickleTimer.
2248 2010-10-05 Philippe Normand <pnormand@igalia.com>
2250 Reviewed by Martin Robinson.
2252 check for ENABLE(GLIB_SUPPORT) in WebView
2253 https://bugs.webkit.org/show_bug.cgi?id=46788
2255 Use ENABLE(GLIB_SUPPORT) in WebView to guard the glib runloop observer.
2257 * WebView/WebView.mm:
2258 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2259 (-[WebView _close]):
2260 * WebView/WebViewData.h:
2261 * WebView/WebViewInternal.h:
2263 2010-10-01 Anders Carlsson <andersca@apple.com>
2265 Fix Snow Leopard build.
2267 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2268 (WebKit::NetscapePluginInstanceProxy::getProxy):
2270 2010-10-01 Anders Carlsson <andersca@apple.com>
2272 Reviewed by Dan Bernstein.
2274 Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
2275 https://bugs.webkit.org/show_bug.cgi?id=47022
2276 <rdar://problem/8504712>
2278 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2279 (WebKit::NetscapePluginInstanceProxy::getProxy):
2280 * Plugins/WebBaseNetscapePluginView.h:
2281 * Plugins/WebBaseNetscapePluginView.mm:
2282 * Plugins/WebNetscapePluginView.mm:
2283 (-[WebNetscapePluginView getVariable:forURL:value:length:]):
2285 2010-09-30 Darin Adler <darin@apple.com>
2287 Reviewed by Sam Weinig.
2289 Remove remaining calls to deprecatedParseURL
2290 https://bugs.webkit.org/show_bug.cgi?id=26599
2292 * DOM/WebDOMOperations.mm:
2293 (-[DOMDocument URLWithAttributeString:]):
2294 * WebCoreSupport/WebFrameLoaderClient.mm:
2295 (WebFrameLoaderClient::createPlugin):
2296 Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
2298 2010-09-30 Anders Carlsson <andersca@apple.com>
2300 Reviewed by Darin Adler.
2302 -[DOMDocument _documentRange] throws an exception if there is no document element
2303 https://bugs.webkit.org/show_bug.cgi?id=46934
2304 <rdar://problem/8169260>
2306 If there is no document element, just return an empty range. Otherwise we'll try to call
2307 Range::selectNode with a null Node which will throw a NOT_FOUND exception.
2309 * DOM/WebDOMOperations.mm:
2310 (-[DOMDocument _documentRange]):
2312 2010-09-30 Chris Marrin <cmarrin@apple.com>
2314 Reviewed by Simon Fraser.
2316 Make 2D accelerated canvas rendering build on Mac
2317 https://bugs.webkit.org/show_bug.cgi?id=46007
2319 Added ACCELERATED_2D_CANVAS to FeatureDefines
2321 * Configurations/FeatureDefines.xcconfig:
2323 2010-09-30 Dan Bernstein <mitz@apple.com>
2325 Reviewed by John Sullivan.
2327 Add printing SPI allowing full control over shrink-to-fit
2328 https://bugs.webkit.org/show_bug.cgi?id=46877
2330 * WebView/WebHTMLView.mm:
2331 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added.
2332 * WebView/WebHTMLViewPrivate.h:
2334 2010-09-28 Johnny Ding <jnd@chromium.org>
2336 Reviewed by Adam Barth.
2338 https://bugs.webkit.org/show_bug.cgi?id=41292
2339 Some windowed plugins did not handle events through EventHandler, so we
2340 never set right gesture state for those events.
2341 This change is to set right allowPopupsFromPlugin flag to current
2342 execution frame, so WeKit can always get right gesture state on Mac.
2343 From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
2344 process, that process passes the allowPopupsFromPlugin flag to
2345 WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
2346 NetscapePluginInstanceProxy::evaluate.
2348 * Plugins/WebNetscapePluginView.mm:
2349 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2351 2010-09-28 Jenn Braithwaite <jennb@chromium.org>
2353 Reviewed by Dmitry Titov.
2355 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
2356 https://bugs.webkit.org/show_bug.cgi?id=46663
2358 * WebCoreSupport/WebFrameLoaderClient.h:
2359 * WebCoreSupport/WebFrameLoaderClient.mm:
2360 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
2362 2010-09-26 Antonio Gomes <agomes@rim.com>
2364 Reviewed by Kenneth Rohde Christiansen.
2366 DRT/Mac nodesFromRect support
2368 [Mac][DRT] Implement LayoutTestController::nodesFromRect
2369 https://bugs.webkit.org/show_bug.cgi?id=46580
2371 Implement nodesFromRect as a private method to access non-exposed Document
2372 methods, similarly to computedStyleIncludingVisitedInfo.
2374 * WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list.
2375 These headers makes it possible to:
2376 1) Get a Document off of a JSDocument;
2377 2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList>
2378 gotten from Document::nodesFromRect to JS bindings.
2379 (-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]):
2380 * WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the
2381 Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo.
2383 2010-09-24 Jia Pu <jpu@apple.com>
2385 Reviewed by Dan Bernstein.
2387 automaticSpellingCorrectionEnabled isn't updated.
2388 https://bugs.webkit.org/show_bug.cgi?id=46486
2389 <rdar://problem/8475212>
2391 * WebView/WebView.mm:
2392 (+[WebView initialize]): Should update "automaticSpellingCorrectionEnabled"
2393 instead of "automaticTextReplacementEnabled".
2395 2010-09-23 Alexey Proskuryakov <ap@apple.com>
2397 Reviewed by Darin Adler.
2399 https://bugs.webkit.org/show_bug.cgi?id=46380
2400 REGRESSION: Crash when downloading a file
2402 Downloading cannot be tested in DRT.
2404 * Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2405 Don't copy null strings.
2407 2010-09-24 Ilya Tikhonovsky <loislo@chromium.org>
2409 Reviewed by Yury Semikhatsky.
2411 Web Inspector: CRASH at node highlight on MAC Safari.
2412 1) run-safari --debug
2414 3) open elements panel
2415 4) hover mouse over elements panel items multiple times
2417 Looks like it is a race condition. WebNodeHighlightView doesn't check
2418 the pointer to WebNodeHighligh object and it can be nil.
2420 https://bugs.webkit.org/show_bug.cgi?id=46261
2422 * WebInspector/WebNodeHighlightView.mm:
2423 (-[WebNodeHighlightView drawRect:]):
2425 2010-09-23 Andy Estes <aestes@apple.com>
2427 Reviewed by Darin Adler.
2429 REGRESSION (r61285): some Dashboard widgets are always invisible due to
2430 HTML parser changes.
2431 https://bugs.webkit.org/show_bug.cgi?id=46435
2433 Enable pre-HTML5 parser quirks if Dashboard is in backward compatibility
2436 * WebView/WebView.mm:
2437 (-[WebView _needsPreHTML5ParserQuirks]): Renamed from
2438 shouldUsePreHTML5ParserQuirks(). Return true if
2439 WebCore::Settings::usesDashboardCompatibilityMode() is true.
2440 (-[WebView _preferencesChangedNotification:]):
2441 (-[WebView _setDashboardBehavior:to:]): Enable pre-HTML5 parser quirks
2442 if Dashboard behavior is set to backward compatibility mode.
2444 2010-09-23 Matthew Delaney <mdelaney@apple.com>
2446 Reviewed by Simon Fraser.
2448 Reduce minimum DOMTimer interval
2449 https://bugs.webkit.org/show_bug.cgi?id=45362
2451 * WebView/WebView.mm:
2452 Updating set interval call to use Settings' static version inside
2453 one time init block.
2455 2010-09-22 Andy Estes <aestes@apple.com>
2457 Reviewed by Darin Adler.
2459 REGRESSION (r61285): Microsoft Entourage 2008 does not invoke My Day window
2460 https://bugs.webkit.org/show_bug.cgi?id=46334
2462 Microsoft My Day loads scripts using self-closing script tags, markup
2463 which is incompatible with the HTML5 parser. Enable parser quirks for
2466 * WebView/WebView.mm:
2467 (shouldUsePreHTML5ParserQuirks): Return true if the application is
2468 Microsoft My Day and was linked against a version of WebKit prior to the
2469 introduction of the HTML5 parser.
2471 2010-09-23 Nate Chapin <japhet@chromium.org>
2473 Reviewed by Darin Fisher.
2475 Add hyperlink auditing settings (i.e., <a ping>).
2476 https://bugs.webkit.org/show_bug.cgi?id=30458
2478 * WebView/WebPreferenceKeysPrivate.h:
2479 * WebView/WebPreferences.mm:
2480 (+[WebPreferences initialize]):
2481 (-[WebPreferences setMemoryInfoEnabled:]):
2482 (-[WebPreferences hyperlinkAuditingEnabled]):
2483 (-[WebPreferences setHyperlinkAuditingEnabled:]):
2484 * WebView/WebPreferencesPrivate.h:
2485 * WebView/WebView.mm:
2486 (-[WebView _preferencesChangedNotification:]):
2488 2010-09-22 Alexey Proskuryakov <ap@apple.com>
2490 Reviewed by Anders Carlsson.
2492 https://bugs.webkit.org/show_bug.cgi?id=43667
2493 ASSERT failure in NetscapePluginInstanceProxy::disconnectStream
2495 Test: plugins/get-javascript-url.html
2497 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2498 (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Add the stream to m_streams, just
2501 2010-09-21 Darin Adler <darin@apple.com>
2503 Reviewed by Anders Carlsson.
2505 Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release
2506 https://bugs.webkit.org/show_bug.cgi?id=46220
2508 * Misc/WebNSFileManagerExtras.m:
2509 (setMetaData): Use CFRelease instead of HardRelease.
2510 (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Use CFStringCreateCopy
2511 instead of -[NSObject copy] combined with HardRetainWithNSRelease.
2513 2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
2515 Reviewed by Kenneth Rohde Christiansen.
2517 PluginStrategy should satisfy the needs of Qt
2518 https://bugs.webkit.org/show_bug.cgi?id=45857
2519 No new functionality so no new tests.
2521 * WebCoreSupport/WebPlatformStrategies.h:
2522 * WebCoreSupport/WebPlatformStrategies.mm:
2523 (WebPlatformStrategies::getPluginInfo):
2525 2010-09-22 Paul Knight <pknight@apple.com>
2527 Reviewed by Simon Fraser.
2529 -[WebView _scheduleCompositingLayerSync] should wake the run loop
2530 https://bugs.webkit.org/show_bug.cgi?id=46226
2532 Call CFRunLoopWakeUp to make sure the run loop is not sleeping, which could delay layer painting.
2534 * WebView/WebView.mm:
2535 (-[WebView _scheduleCompositingLayerSync]):
2537 2010-09-21 Andy Estes <aestes@apple.com>
2539 Reviewed by Darin Adler.
2541 REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
2542 https://bugs.webkit.org/show_bug.cgi?id=46134
2544 AIM clients linked against versions of WebKit prior to the introduction
2545 of the HTML5 parser contain markup incompatible with the new parser.
2546 Enable parser quirks in this case to remain compatible with these
2549 * WebView/WebView.mm:
2550 (shouldUsePreHTML5ParserQuirks): Returns true if the embedding
2551 application is AIM and was linked against a version of WebKit prior to
2552 the introduction of the HTML5 parser, or if the
2553 WebKitPreHTML5ParserQuirks WebPreference is enabled.
2554 (-[WebView _preferencesChangedNotification:]): Call
2555 WebCore::Settings::setUsePreHTML5ParserQuirks().
2557 2010-09-21 Steve Block <steveblock@google.com>
2559 Reviewed by Jeremy Orlow.
2561 DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
2562 https://bugs.webkit.org/show_bug.cgi?id=45891
2564 Implements WebDeviceOrientationClient::deviceOrientationControllerDestroyed to delete the client.
2566 * WebCoreSupport/WebDeviceOrientationClient.h:
2567 * WebCoreSupport/WebDeviceOrientationClient.mm:
2568 (WebDeviceOrientationClient::deviceOrientationControllerDestroyed):
2570 2010-09-20 Philippe Normand <pnormand@igalia.com>
2572 Reviewed by Eric Carlson.
2574 [GTK] enhanced context menu for media elements
2575 https://bugs.webkit.org/show_bug.cgi?id=45021
2577 New localized strings for the media element context-menu.
2579 * WebCoreSupport/WebPlatformStrategies.h:
2580 * WebCoreSupport/WebPlatformStrategies.mm:
2581 (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
2582 (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
2583 (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
2584 (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
2585 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
2586 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
2587 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
2588 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
2589 (WebPlatformStrategies::contextMenuItemTagMediaPause):
2590 (WebPlatformStrategies::contextMenuItemTagMediaMute):
2592 2010-09-20 Andy Estes <aestes@apple.com>
2594 Reviewed by Adam Barth.
2596 REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
2597 https://bugs.webkit.org/show_bug.cgi?id=40961
2599 Implement WebKitUsePreHTML5ParserQuirks preference.
2601 * WebView/WebPreferenceKeysPrivate.h:
2602 * WebView/WebPreferences.mm:
2603 (+[WebPreferences initialize]): Default WebKitUsePreHTML5ParserQuirks to
2605 (-[WebPreferences usePreHTML5ParserQuirks]):
2606 (-[WebPreferences setUsePreHTML5ParserQuirks:]):
2607 * WebView/WebPreferencesPrivate.h:
2608 * WebView/WebView.mm:
2609 (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings
2610 with the value of WebKitUsePreHTML5ParserQuirks when a preference
2613 2010-09-20 Enrica Casucci <enrica@apple.com>
2615 Reviewed by Sam Weinig.
2617 Pasteboard doesn't work in WebKit2.
2618 https://bugs.webkit.org/show_bug.cgi?id=42317
2619 <rdar://problem/7660537>
2621 Some changes to fix style inconsistencies.
2622 Added OBJC 2.0 style enumeration.
2624 * WebCoreSupport/WebEditorClient.h:
2625 * WebCoreSupport/WebEditorClient.mm:
2626 (WebEditorClient::userVisibleString):
2627 (createExcludedElementsForAttributedStringConversion):
2628 (WebEditorClient::documentFragmentFromAttributedString): Changed parameter to be
2630 (WebEditorClient::setInsertionPasteboard):
2631 (WebEditorClient::pasteboardTypesForSelection):
2633 2010-09-17 David Hyatt <hyatt@apple.com>
2635 Reviewed by Simon Fraser.
2637 https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.
2639 Make printing store the page height in the RenderView and push that into the layout state to
2640 use the new pagination model. The old pagination model is retained because it is still used
2641 for embedded WebViews.
2643 * WebView/WebHTMLView.mm:
2644 (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2646 2010-09-17 Darin Adler <darin@apple.com>
2648 Reviewed by Sam Weinig.
2650 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
2651 https://bugs.webkit.org/show_bug.cgi?id=42863
2653 * WebView/WebView.mm:
2654 (-[WebView _setZoomMultiplier:isTextOnly:]):
2655 Call functions on Frame instead of FrameView.
2657 2010-09-17 Matthew Delaney <mdelaney@apple.com>
2659 Reviewed by Simon Fraser.
2661 Reduce minimum DOMTimer interval
2662 https://bugs.webkit.org/show_bug.cgi?id=45362
2664 * WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.
2666 2010-09-17 Chris Marrin <cmarrin@apple.com>
2668 Reviewed by Simon Fraser.
2670 Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
2671 https://bugs.webkit.org/show_bug.cgi?id=45911
2673 * WebView/WebPreferenceKeysPrivate.h:
2674 * WebView/WebPreferences.mm:
2675 (+[WebPreferences initialize]):
2676 (-[WebPreferences accelerated2dCanvasEnabled]):
2677 (-[WebPreferences setAccelerated2dCanvasEnabled:]):
2678 * WebView/WebPreferencesPrivate.h:
2679 * WebView/WebView.mm:
2680 (-[WebView _preferencesChangedNotification:]):
2682 2010-09-17 Jia Pu <jpu@apple.com>
2684 Reviewed by Dan Bernstein.
2686 WebKit should use system wide spell checking preference when application specific one isn't set.
2687 https://bugs.webkit.org/show_bug.cgi?id=45789
2688 <rdar://problem/8416041>
2690 * WebView/WebView.mm:
2691 (+[WebView initialize]): Use system wide autocorrection and text substitution preferences
2692 when the application level preferences are not set.
2694 2010-09-16 John Sullivan <sullivan@apple.com>
2696 Reviewed by Darin Adler.
2698 <rdar://problem/8395558>
2699 https://bugs.webkit.org/show_bug.cgi?id=45938
2700 _web_makePluginViewsPerformSelector:: mutates subviews array while iterating it
2702 * WebView/WebHTMLView.mm:
2703 (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
2704 Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
2705 was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
2706 this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
2707 before enumerating it, to ensure that the selector can't mutate the array being enumerated.
2708 (-[WebHTMLView viewWillMoveToHostWindow:]):
2709 Updated for _web_makePluginSubviewsPerformSelector:: signature change.
2710 (-[WebHTMLView viewDidMoveToHostWindow]):
2713 2010-09-16 Darin Adler <darin@apple.com>
2715 Reviewed by Andreas Kling.
2717 Reduce use of HTMLInputElement::inputType so we can remove it later
2718 https://bugs.webkit.org/show_bug.cgi?id=45903
2720 * WebView/WebHTMLRepresentation.mm:
2721 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Use isPasswordField.
2722 (-[WebHTMLRepresentation elementIsPassword:]): Use isPasswordField.
2724 2010-09-16 Patrick Gansterer <paroga@paroga.com>
2726 Reviewed by Darin Adler.
2728 Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
2729 https://bugs.webkit.org/show_bug.cgi?id=41510
2731 This prevents usage of nil value, which would cause an uncaught exception.
2733 * WebView/WebPreferences.mm:
2734 (-[WebPreferences setUserStyleSheetLocation:]):
2736 2010-09-16 Dan Bernstein <mitz@apple.com>
2738 Reverted the previous change because r67628 has been reverted.
2740 * WebCoreSupport/WebPlatformStrategies.h:
2741 * WebCoreSupport/WebPlatformStrategies.mm:
2743 2010-09-16 Dan Bernstein <mitz@apple.com>
2745 Build fix after r67628. Added context menu item localizable strings for the items
2746 added in r67628, following equivalent menu items in Mac OS X when possible. However,
2747 this set of menu items does not make much sense for Mac OS X, and this should be
2748 addressed separately.
2750 * WebCoreSupport/WebPlatformStrategies.h:
2751 * WebCoreSupport/WebPlatformStrategies.mm:
2752 (WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow):
2753 (WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard):
2754 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
2755 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
2756 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
2757 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
2758 (WebPlatformStrategies::contextMenuItemTagMediaPause):
2759 (WebPlatformStrategies::contextMenuItemTagMediaMute):
2760 (WebPlatformStrategies::contextMenuItemTagMediaUnMute):
2762 2010-09-16 Eric Uhrhane <ericu@chromium.org>
2764 Reviewed by Jian Li.
2766 Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
2767 https://bugs.webkit.org/show_bug.cgi?id=45798
2769 * Configurations/FeatureDefines.xcconfig:
2771 2010-09-15 Simon Fraser <simon.fraser@apple.com>
2773 Reviewed by Adam Roben.
2775 https://bugs.webkit.org/show_bug.cgi?id=44715
2776 maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac
2778 Move geometry flipping to platform-specific code.
2780 * WebView/WebHTMLView.mm:
2781 (-[WebHTMLView attachRootLayer:]):
2783 2010-09-14 Jia Pu <jpu@apple.com>
2785 Reviewed by Dan Bernstein.
2787 Only intercept ESC key press when autocorrection UI is visible.
2788 https://bugs.webkit.org/show_bug.cgi?id=45071
2790 * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
2791 which provides an inteface to query whether autocorrection panel is shown.
2793 * WebCoreSupport/WebEditorClient.mm:
2794 (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
2795 for invalid correction panel tag. Replaced -1 with this constant.
2796 (WebEditorClient::dismissCorrectionPanel): Ditto
2797 (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
2799 2010-09-14 Mark Rowe <mrowe@apple.com>
2801 Reviewed by John Sullivan.
2803 Part of <rdar://problem/8420003>. Make it possible to override the version number used in linked-in-or-after checks.
2805 * Misc/WebKitVersionChecks.h: Remove two unused functions from the header and add a method to set the overriden version.
2806 * Misc/WebKitVersionChecks.m:
2807 (WebKitLinkedOnOrAfter):
2808 (setWebKitLinkTimeVersion): Set the overridden version.
2809 (WebKitLinkTimeVersion): Return the overridden version if set, otherwise do the old thing.
2810 * WebView/WebPreferences.mm:
2811 (+[WebPreferences setWebKitLinkTimeVersion:]): Call through to set the overridden version.
2812 * WebView/WebPreferencesPrivate.h:
2814 2010-09-14 Eric Seidel <eric@webkit.org>
2816 Unreviewed, reverting changes r67451 and r67451.
2817 Broke lots of builders.
2819 Only intercept ESC key press when autocorrection UI is visible.
2820 https://bugs.webkit.org/show_bug.cgi?id=45071
2822 * WebCoreSupport/WebEditorClient.h:
2823 * WebCoreSupport/WebEditorClient.mm:
2824 (WebEditorClient::WebEditorClient):
2825 (WebEditorClient::dismissCorrectionPanel):
2827 2010-09-14 Jia Pu <jpu@apple.com>
2829 Reviewed by Dan Bernstein.
2831 Only intercept ESC key press when autocorrection UI is visible.
2832 https://bugs.webkit.org/show_bug.cgi?id=45071
2834 * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
2835 which provides an inteface to query whether autocorrection panel is shown.
2837 * WebCoreSupport/WebEditorClient.mm:
2838 (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
2839 for invalid correction panel tag. Replaced -1 with this constant.
2840 (WebEditorClient::dismissCorrectionPanel): Ditto
2841 (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
2843 2010-09-13 Darin Adler <darin@apple.com>
2845 Reviewed by Adam Barth.
2847 Preparation for eliminating deprecatedParseURL
2848 https://bugs.webkit.org/show_bug.cgi?id=45695
2850 * DOM/WebDOMOperations.mm:
2851 (-[DOMDocument webFrame]): Get rid of unneeded local variable.
2852 (-[DOMDocument URLWithAttributeString:]): Remove unhelpful comment.
2854 2010-09-13 Enrica Casucci <enrica@apple.com>
2856 Reviewed by Sam Weinig.
2858 Paste should be implemented in WebCore like Copy and Cut for Mac also.
2859 https://bugs.webkit.org/show_bug.cgi?id=45494
2860 <rdar://problem/7660537>
2862 On the Mac platform, the implementation of the paste operation is all done
2863 at the WebKit level. In order to support it on WebKit2 it is necessary to
2864 refactor the code and move this functionality at the level of WebCore like
2865 we already have on Windows.
2866 The original code relies on some in AppKit functions that call back into
2867 WebKit causing problems in WebKit2. All this functionality has been moved
2868 at the level of the editor client where it can be dealt with appropriately.
2870 * WebCoreSupport/WebEditorClient.h:
2871 * WebCoreSupport/WebEditorClient.mm:
2872 (excludedElementsForAttributedStringConversion):
2873 (WebEditorClient::documentFragmentFromAttributedString): Added.
2874 (WebEditorClient::setInsertionPasteboard):
2875 * WebCoreSupport/WebFrameLoaderClient.h:
2876 * WebCoreSupport/WebFrameLoaderClient.mm:
2877 (WebFrameLoaderClient::canShowMIMETypeAsHTML): Re-implemented at the level
2878 of the editor client.
2879 * WebView/WebHTMLView.mm: Removed paste method.
2881 2010-09-13 John Sullivan <sullivan@apple.com>
2883 Reviewed by Adam Roben.
2885 https://bugs.webkit.org/show_bug.cgi?id=45677
2886 [WebView canMarkAllTextMatches] can crash if called after [WebView close]
2888 <rdar://problem/8404890>
2890 * WebView/WebView.mm:
2891 (-[WebView canMarkAllTextMatches]):
2892 Return NO immediately if the webview has already been closed. This was an overlooked
2893 case from the fix for 45175.
2895 2010-09-10 MORITA Hajime <morrita@google.com>
2897 Reviewed by Tony Chang.
2899 [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
2900 https://bugs.webkit.org/show_bug.cgi?id=45441
2902 Moved the actual logic of hasSpellingMarker into WebCore to share
2903 it with other ports.
2905 * WebView/WebFrame.mm:
2906 (-[WebFrame hasSpellingMarker:length:]):
2908 2010-09-11 Adam Barth <abarth@webkit.org>
2910 Reviewed by Sam Weinig.
2912 Make SecurityOrigin::canDisplay an instance function
2913 https://bugs.webkit.org/show_bug.cgi?id=45219
2915 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2916 (WebKit::NetscapePluginInstanceProxy::loadRequest):
2917 * Plugins/WebNetscapePluginStream.mm:
2918 (WebNetscapePluginStream::WebNetscapePluginStream):
2919 * Plugins/WebNetscapePluginView.mm:
2920 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2921 * Plugins/WebPluginContainerCheck.mm:
2922 (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2923 * WebView/WebFrame.mm:
2924 (-[WebFrame _allowsFollowingLink:]):
2926 2010-09-10 Sam Weinig <sam@webkit.org>
2928 Reviewed by Darin Adler.
2930 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
2931 Precursor to <rdar://problem/7660657>
2932 https://bugs.webkit.org/show_bug.cgi?id=45522
2934 * WebView/WebView.mm:
2935 (-[WebView _preferencesChangedNotification:]):
2936 (-[WebView _setZoomMultiplier:isTextOnly:]):
2937 (-[WebView _realZoomMultiplierIsTextOnly]):
2938 * WebView/WebViewData.h:
2939 * WebView/WebViewData.mm:
2940 (-[WebViewPrivate init]):
2941 Move tracking of text only zoom here from WebCore.
2943 2010-09-10 Stephanie Lewis <slewis@apple.com>
2945 Reviewed by Alexey Proskuryakov.
2947 Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know about the JIT and
2948 other implementation details of JavaScriptCore. Necessary to fix PPC build.
2950 https://bugs.webkit.org/show_bug.cgi?id=45528
2952 * Misc/WebCoreStatistics.mm:
2953 (+[WebCoreStatistics memoryStatistics]):
2955 2010-09-10 Darin Adler <darin@apple.com>
2957 Reviewed by Sam Weinig.
2959 Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
2960 https://bugs.webkit.org/show_bug.cgi?id=45582
2962 * MigrateHeaders.make: Removed WebDashboardRegion.h from the set of header to copy.
2964 * WebCoreSupport/WebChromeClient.mm:
2965 (WebChromeClient::dashboardRegionsChanged): Changed this to call
2966 -[WebView _dashboardRegions] so we don't have two copies of that code.
2968 * WebView/WebDashboardRegion.h: Copied from WebCore/page/mac/WebDashboardRegion.h.
2969 * WebView/WebDashboardRegion.mm: Copied from WebCore/page/mac/WebDashboardRegion.m.
2971 * WebView/WebView.mm:
2972 (-[WebView _dashboardRegions]): Moved the code from Frame::dashboardRegions here.
2974 2010-09-10 Adam Barth <abarth@webkit.org>
2976 Reviewed by Darin Fisher.
2978 Move code from WebKit-layer to DocumentLoader
2979 https://bugs.webkit.org/show_bug.cgi?id=45569
2981 This code is the most confused, but now should be a bit cleaner.
2982 There's still a magical fake-setting for creating renderers that needs
2983 to be cleaned up, but we can do that in a separate patch.
2985 * WebView/WebFrame.mm:
2986 (-[WebFrame _commitData:]):
2987 * WebView/WebFrameInternal.h:
2988 * WebView/WebHTMLRepresentation.mm:
2989 (-[WebHTMLRepresentation receivedData:withDataSource:]):
2990 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
2992 2010-09-09 Darin Adler <darin@apple.com>
2994 Reviewed by Adam Barth.
2996 Move functions from Frame to SelectionController as planned
2997 https://bugs.webkit.org/show_bug.cgi?id=45508
2999 * WebView/WebFrame.mm:
3000 (-[WebFrame _selectionGranularity]):
3001 (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
3002 (-[WebFrame _typingStyle]):
3003 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3004 * WebView/WebHTMLRepresentation.mm:
3005 (-[WebHTMLRepresentation currentForm]):
3006 * WebView/WebHTMLView.mm:
3007 (-[WebHTMLView jumpToSelection:]):
3008 (-[WebHTMLView centerSelectionInVisibleArea:]):
3009 (-[WebHTMLView _canSmartCopyOrDelete]):
3010 (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3011 (-[WebHTMLView selectionRect]):
3012 (-[WebHTMLView selectionTextRects]):
3013 (-[WebHTMLView selectionImageRect]):
3014 * WebView/WebView.mm:
3015 (-[WebView setEditable:]):
3016 Call functions on selection().
3018 2010-09-10 Adam Barth <abarth@webkit.org>
3020 Reviewed by Eric Seidel.
3022 Main resource bytes shouldn't bounce through FrameLoader
3023 https://bugs.webkit.org/show_bug.cgi?id=45496
3025 Now return the bytes to the DocumentLoader.
3027 Previously, we were checking the document for null. However, Frame can
3028 never have a null document, so this check is no longer needed.
3030 * WebView/WebFrame.mm:
3031 (-[WebFrame _addData:]):
3033 2010-09-09 John Therrell <jtherrell@apple.com>
3035 Reviewed by Alexey Proskuryakov.
3037 Added statistics sampling and reporting for JavaScriptCore's RegisterFile and ExecutableAllocator classes
3038 https://bugs.webkit.org/show_bug.cgi?id=45134
3040 Added ability to enable new JavaScriptCore statistics sampling and reporting for RegisterFile
3041 and ExecutableAllocator classes. Added reporting of JavaScriptCore's stack committed memory
3042 and JIT code committed memory statistics to WebCoreStatistics memoryStatistics.
3044 * Misc/WebCoreStatistics.mm:
3045 (+[WebCoreStatistics memoryStatistics]):
3046 Added statistics reporting for JSC RegisterFile and ExecutableAllocator.
3048 2010-09-09 Jer Noble <jer.noble@apple.com>
3050 Reviewed by Mark Rowe.
3052 Use of ENABLE macro in WebUIDelegatePrivate.h breaks use from outside WebKit
3053 <rdar://problem/8412657>
3055 * WebView/WebUIDelegatePrivate.h: Use ENABLE_FULLSCREEN_API instead of ENABLE(FULLSCREEN_API)
3057 2010-09-08 Darin Adler <darin@apple.com>
3059 Reviewed by Adam Barth.
3061 Move functions from Frame to Editor as planned
3062 https://bugs.webkit.org/show_bug.cgi?id=45218
3064 * WebView/WebFrame.mm:
3065 (-[WebFrame _selectedString]):
3066 (-[WebFrame _firstRectForDOMRange:]):
3067 (-[WebFrame _markDOMRange]):
3068 (-[WebFrame _setTypingStyle:withUndoAction:]):
3069 * WebView/WebHTMLRepresentation.mm:
3070 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
3071 * WebView/WebHTMLView.mm:
3072 (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3073 (-[WebHTMLView toggleBaseWritingDirection:]):
3074 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3075 (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
3076 (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
3077 (-[WebHTMLView markedTextMatchesAreHighlighted]):
3078 * WebView/WebView.mm:
3079 (-[WebView setEditable:]):
3080 Changed call sites to use editor().
3082 2010-09-08 MORITA Hajime <morrita@google.com>
3084 Reviewed by Ojan Vafai.
3086 spellcheck does not check pasted text
3087 https://bugs.webkit.org/show_bug.cgi?id=40092
3089 Implemented async spell-check APIs on WebEditorClient.
3090 The implementations are using [NSSpellChecker requestCheckingOfString]
3091 which is available only on Mac OS 10.6 or later.
3093 Note that [NSSpellChecker requestCheckingOfString] could invoke
3094 the callback block on on of their worker thread, so we need to
3095 return the result to the main thread where WebCore is running.
3096 For that purpose, we made WebEditorSpellCheckResponder class.
3098 Test: editing/spelling/spellcheck-pasted-text-001.html
3100 * WebCoreSupport/WebEditorClient.h:
3101 * WebCoreSupport/WebEditorClient.mm:
3102 (WebEditorClient::isAsynchronousSpellCheckingEnabled): Added.
3103 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]): Added.
3104 (-[WebEditorSpellCheckResponder perform]): Added.
3105 (WebEditorClient::requestCheckingOfString): Added.
3106 * WebView/WebFramePrivate.h:
3108 2010-09-08 MORITA Hajime <morrita@google.com>
3110 Reviewed by Tony Chang.
3112 spelling underline gets lost on backspace
3113 https://bugs.webkit.org/show_bug.cgi?id=41423
3115 Switched to use a anchorNode of the selection instead of a focused
3116 node for finer control of node selection in spellingNode():
3117 With the focused node, we cannot select other nodes but the first
3118 child of that node. In some case, we need to inspect these.
3120 The API is only for LayoutTests, and the change is compatible for
3121 existing test cases.
3123 * WebView/WebFrame.mm:
3126 2010-09-08 Adam Barth <abarth@webkit.org>
3128 Rubber-stamped by Eric Seidel.
3130 Rename DocLoader to CachedResourceLoader because that's what it does.
3132 * WebView/WebFrame.mm:
3134 2010-09-07 Anders Carlsson <andersca@apple.com>
3136 Reviewed by Oliver Hunt.
3140 * Misc/WebLocalizableStrings.h:
3141 Fix a struct/tag mismatch.
3143 * WebView/WebDeviceOrientationProviderMock.mm:
3144 (-[WebDeviceOrientationProviderMock init]):
3145 Remove stray semicolon.
3147 * WebView/WebViewData.h:
3148 Remove unused class forward declaration.
3150 2010-09-07 Anders Carlsson <andersca@apple.com>
3152 Reviewed by Darin Adler.
3154 <rdar://problem/8381749> -Wcast-align warning emitted when building with clang
3156 Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.
3158 * Configurations/Base.xcconfig:
3160 2010-09-06 Adam Barth <abarth@webkit.org>
3162 Reviewed by Darin Adler.
3164 Rename SecurityOrigin::canLoad to canDisplay
3165 https://bugs.webkit.org/show_bug.cgi?id=45214
3167 Propagate name change.
3169 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3170 (WebKit::NetscapePluginInstanceProxy::loadRequest):
3171 * Plugins/WebNetscapePluginStream.mm:
3172 (WebNetscapePluginStream::WebNetscapePluginStream):
3173 * Plugins/WebNetscapePluginView.mm:
3174 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3175 * Plugins/WebPluginContainerCheck.mm:
3176 (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3177 * WebView/WebFrame.mm:
3178 (-[WebFrame _allowsFollowingLink:]):
3180 2010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
3182 Reviewed by Darin Adler.
3184 Add NetworkingContext to avoid layer violations
3185 https://bugs.webkit.org/show_bug.cgi?id=42292
3187 Add Mac's specific implementation of FrameNetworkingContext.
3189 * WebCoreSupport/WebFrameLoaderClient.h:
3190 * WebCoreSupport/WebFrameLoaderClient.mm:
3191 * WebCoreSupport/WebFrameNetworkingContext.mm:
3192 (WebFrameNetworkingContext::needsSiteSpecificQuirks):
3193 (WebFrameNetworkingContext::localFileContentSniffingEnabled):
3194 (WebFrameNetworkingContext::scheduledRunLoopPairs):
3195 (WebFrameNetworkingContext::blockedError):
3197 2010-09-03 John Sullivan <sullivan@apple.com>
3199 Reviewed by Dan Bernstein.
3201 https://bugs.webkit.org/show_bug.cgi?id=45175
3202 [WebView unmarkAllTextMatches] will crash if the webview is already closed
3204 Made this and related methods robust against being called when the WebView is closed.
3206 * WebView/WebView.mm:
3207 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
3208 Bail out if the WebView is closed.
3209 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
3211 (-[WebView unmarkAllTextMatches]):
3213 (-[WebView rectsForTextMatches]):
3216 2010-09-03 Hironori Bono <hbono@chromium.org>
3218 Reviewed by Kent Tamura.
3220 Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
3221 and implements it for Mac.
3222 https://bugs.webkit.org/show_bug.cgi?id=41832
3224 * WebView/WebFrame.mm: Implemented [WebFrame hasSpellingMarker:length:].
3226 (-[WebFrame hasSpellingMarker:length:]):
3227 * WebView/WebFramePrivate.h: Added [WebFrame hasSpellingMarker:length:] so TextInputController can use it.
3229 2010-09-02 Yury Semikhatsky <yurys@chromium.org>
3231 Reviewed by Pavel Feldman.
3233 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
3234 https://bugs.webkit.org/show_bug.cgi?id=44230
3236 * WebCoreSupport/WebInspectorClient.h:
3237 * WebCoreSupport/WebInspectorClient.mm:
3238 (WebInspectorFrontendClient::closeWindow):
3239 (WebInspectorFrontendClient::disconnectFromBackend):
3240 (-[WebInspectorWindowController windowShouldClose:]):
3241 (-[WebInspectorWindowController destroyInspectorView:]):
3243 2010-09-02 Steve Block <steveblock@google.com>
3245 Reviewed by Adam Barth.
3247 Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
3248 https://bugs.webkit.org/show_bug.cgi?id=43181
3250 This patch hooks up the mock device orientation client on Mac for use
3253 The patch adds a new WebDeviceOrientationClient for Mac. This client acts
3254 as a proxy to either a real or mock device orientation provider, both of
3255 which implement a new WebDeviceOrientationProvider interface.
3257 The provider is created by the embedder and passed to the WebView, from
3258 where WebDeviceOrientationClient can access it.
3260 The mock provider, WebDeviceOrientationProviderMock, is a wrapper around
3261 the existing WebCore mock.
3263 * WebCoreSupport/WebDeviceOrientationClient.h: Added.
3264 * WebCoreSupport/WebDeviceOrientationClient.mm: Added.
3265 (WebDeviceOrientationClient::WebDeviceOrientationClient):
3266 (WebDeviceOrientationClient::setController):
3267 (WebDeviceOrientationClient::startUpdating):
3268 (WebDeviceOrientationClient::stopUpdating):
3269 (WebDeviceOrientationClient::lastOrientation):
3271 * WebView/WebDeviceOrientation.h: Added.
3272 * WebView/WebDeviceOrientation.mm: Added.
3273 (-[WebDeviceOrientation initWithCoreDeviceOrientation:WebCore::]):
3275 (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
3276 (-[WebDeviceOrientation dealloc]):
3277 * WebView/WebDeviceOrientationInternal.h: Added.
3278 * WebView/WebDeviceOrientationProvider.h: Added.
3279 * WebView/WebDeviceOrientationProviderMock.h: Added.
3280 * WebView/WebDeviceOrientationProviderMock.mm: Added.
3281 (-[WebDeviceOrientationProviderMockInternal setOrientation:]):
3282 (-[WebDeviceOrientationProviderMockInternal setController:]):
3283 (-[WebDeviceOrientationProviderMockInternal startUpdating]):
3284 (-[WebDeviceOrientationProviderMockInternal stopUpdating]):
3285 (-[WebDeviceOrientationProviderMockInternal lastOrientation]):
3286 (-[WebDeviceOrientationProviderMock init]):
3287 (-[WebDeviceOrientationProviderMock dealloc]):
3288 (-[WebDeviceOrientationProviderMock setOrientation:]):
3289 (-[WebDeviceOrientationProviderMock setController:]):
3290 (-[WebDeviceOrientationProviderMock startUpdating]):
3291 (-[WebDeviceOrientationProviderMock stopUpdating]):
3292 (-[WebDeviceOrientationProviderMock lastOrientation]):
3293 * WebView/WebDeviceOrientationProviderMockInternal.h: Added.
3294 * WebView/WebView.mm:
3295 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3296 (-[WebView _setDeviceOrientationProvider:]):
3297 (-[WebView _deviceOrientationProvider]):
3298 * WebView/WebViewData.h:
3299 * WebView/WebViewPrivate.h:
3301 2010-09-01 Jia Pu <jpu@apple.com>
3303 Reviewed by Dan Bernstein.
3305 Add support for autocorrection UI on Mac OS X.
3306 https://bugs.webkit.org/show_bug.cgi?id=44958
3307 <rdar://problem/7326847>
3309 See detailed high level description in WebCore/ChangeLog.
3311 * WebCoreSupport/WebEditorClient.h: Added new member methods declared in
3312 EditorClient. Added m_correctionPanelTag to store the ID of current autocorrection UI object.
3314 * WebCoreSupport/WebEditorClient.mm:
3315 (WebEditorClient::WebEditorClient): Initialize m_correctionPanelTag.
3316 (WebEditorClient::~WebEditorClient): Make sure the autocorrection UI is
3317 dismissed before destroying the object.
3318 (WebEditorClient::respondToChangedSelection): Dismiss autocorrection UI whenever the selection changes.
3319 (WebEditorClient::showCorrectionPanel): Show autocorrection UI.
3320 (WebEditorClient::dismissCorrectionPanel): Dismiss autocorrection UI.
3322 2010-09-01 Mark Rowe <mrowe@apple.com>
3324 Reviewed by Adam Roben.
3326 <rdar://problem/8374711> WebKit needs to compile without access to QuickDraw private headers.
3328 * Carbon/HIViewAdapter.m:
3329 * Carbon/HIWebView.mm:
3330 * Misc/QuickDrawCompatibility.h: Added.
3331 * Plugins/WebNetscapePluginView.mm:
3333 2010-08-31 Dave Hyatt <hyatt@apple.com>
3335 Reviewed by Sam Weinig.
3337 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
3338 the former can occur in more places without having to do the latter.
3340 Eliminate Mac-specific code for style re-application and recursive layout/style updating in
3341 favor of the cross-platform code that all the other ports use.
3343 * Carbon/HIWebView.mm:
3345 * WebCoreSupport/WebFrameLoaderClient.mm:
3346 (WebFrameLoaderClient::forceLayout):
3347 * WebView/WebHTMLView.mm:
3348 (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]):
3349 (-[WebHTMLView viewWillDraw]):
3350 (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3351 (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3352 (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3353 (-[WebHTMLView reapplyStyles]):
3354 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
3355 (-[WebHTMLView setNeedsToApplyStyles:]):
3356 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
3357 (-[WebHTMLView _layoutIfNeeded]):
3358 (-[WebHTMLView _web_updateLayoutAndStyleIfNeededRecursive]):
3359 * WebView/WebHTMLViewInternal.h:
3360 * WebView/WebView.mm:
3361 (-[WebView _viewWillDrawInternal]):
3363 2010-08-31 Sam Weinig <sam@webkit.org>
3365 Reviewed by Darin Adler.
3367 Add ability to count text matches without marking
3368 https://bugs.webkit.org/show_bug.cgi?id=43996
3370 Safari needs to be able to count text matches without triggering lots of repainting.
3371 Rename markAllMatchesForText: to countMatchesForText: and add a markMatches:
3372 parameter. For backwards compatibility markAllMatchesForText: calls
3373 countMatchesForText: and passes YES for markMatches:.
3375 * WebView/WebDocumentInternal.h:
3376 * WebView/WebHTMLView.mm:
3377 (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
3378 (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
3379 * WebView/WebPDFView.mm:
3380 (-[WebPDFView markAllMatchesForText:caseSensitive:limit:]):
3381 (-[WebPDFView countMatchesForText:caseSensitive:limit:markMatches:]):
3382 * WebView/WebView.mm:
3383 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
3384 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
3385 * WebView/WebViewPrivate.h:
3387 2010-08-31 Darin Adler <darin@apple.com>
3389 Reviewed by Anders Carlsson.
3391 * WebInspector/WebInspectorFrontend.mm:
3392 (-[WebInspectorFrontend initWithFrontendClient:]): Remove a stray semicolon.
3394 2010-08-30 Mark Rowe <mrowe@apple.com>
3396 Reviewed by Darin Adler.
3398 <rdar://problem/8369736> WebKit build fails.
3400 Temporarily add some extra includes in order to get things building again until <rdar://problem/8374711> is addressed.
3402 * Carbon/HIViewAdapter.m:
3403 * Carbon/HIWebView.mm:
3404 * Plugins/WebNetscapePluginView.mm:
3406 2010-08-30 Andy Estes <aestes@apple.com>
3408 Reviewed by Darin Adler.
3410 REGRESSION (r66156): Sites using AppleConnect for authentication fail to log in.
3411 https://bugs.webkit.org/show_bug.cgi?id=44865
3413 After http://trac.webkit.org/changeset/66156, sites using the AppleConnect plug-in
3414 for authentication fail to log in. This is due to a bug in AppleConnect that r66156
3415 exposed, but since this will have a significant impact on users of WebKit nightly
3416 builds, a plugin-specific hack should be added while the underlying issue is being
3419 * WebCoreSupport/WebFrameLoaderClient.mm:
3420 (WebFrameLoaderClient::createPlugin): Convert plug-in parameter names to lowercase
3421 if the plugin is of type 'application/x-snkp'.
3423 2010-08-27 Jer Noble <jer.noble@apple.com>
3425 Reviewed by Eric Carlson.
3427 text/plain non-video files cause <video> to hang (while reading them?)
3428 https://bugs.webkit.org/show_bug.cgi?id=44212
3430 Add the new WebKitSystemInterface function WKQTMovieDisableComponent to
3431 the initialization routine.
3433 * WebCoreSupport/WebSystemInterface.mm:
3434 (InitWebCoreSystemInterface): Initialize WKQTMovieDisableComponent.
3436 2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
3438 Unreviewed, rolling out r66198.
3439 http://trac.webkit.org/changeset/66198
3440 https://bugs.webkit.org/show_bug.cgi?id=44856
3442 It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
3444 * WebCoreSupport/WebInspectorClient.h:
3445 * WebCoreSupport/WebInspectorClient.mm:
3446 (WebInspectorFrontendClient::closeWindow):
3447 (-[WebInspectorWindowController windowShouldClose:]):
3448 (-[WebInspectorWindowController destroyInspectorView]):
3450 2010-08-28 Darin Adler <darin@apple.com>
3452 Reviewed by Sam Weinig.
3454 Make an internal method used by Apple Mail into SPI
3455 https://bugs.webkit.org/show_bug.cgi?id=44832
3456 rdar://problem/5748951
3458 * WebView/WebFrame.mm:
3459 (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Moved this method
3460 from the internal section to the private section.
3461 * WebView/WebFrameInternal.h: Moved the method declaration out of here.
3462 * WebView/WebFramePrivate.h: Moved the method declaration in here.
3464 2010-08-27 Jer Noble <jer.noble@apple.com>
3466 Reviewed by Eric Carlson.
3468 Add JavaScript API to allow a page to go fullscreen.
3469 rdar://problem/6867795
3471 Added chrome client overrides which support entering and exiting full screen. A new preference has
3472 been added (setFullScreenEnabled:) to control at runtime whether full screen support is enabled
3473 (defaults to disabled). Added a new WebKitFullScreenListener callback object which notifies WebCore
3474 when the chrome has started/finished its full screen animation.
3476 * Configurations/FeatureDefines.xcconfig:
3477 * WebCoreSupport/WebChromeClient.h:
3478 * WebCoreSupport/WebChromeClient.mm:
3479 (WebChromeClient::supportsFullscreenForElement):
3480 (WebChromeClient::enterFullscreenForElement):
3481 (WebChromeClient::exitFullscreenForElement):
3482 (-[WebKitFullScreenListener initWithElement:]):
3483 (-[WebKitFullScreenListener webkitWillEnterFullScreen]):
3484 (-[WebKitFullScreenListener webkitDidEnterFullScreen]):
3485 (-[WebKitFullScreenListener webkitWillExitFullScreen]):
3486 (-[WebKitFullScreenListener webkitDidExitFullScreen]):
3487 * WebView/WebPreferenceKeysPrivate.h:
3488 * WebView/WebPreferences.h:
3489 * WebView/WebPreferences.mm:
3490 (+[WebPreferences initialize]):
3491 (-[WebPreferences setFullScreenEnabled:]):
3492 (-[WebPreferences fullScreenEnabled]):
3493 * WebView/WebUIDelegatePrivate.h:
3494 * WebView/WebView.mm:
3495 (-[WebView _preferencesChangedNotification:]):
3497 2010-08-27 David Hyatt <hyatt@apple.com>
3499 Reviewed by Simon Fraser.
3501 https://bugs.webkit.org/show_bug.cgi?id=44788, implement HTML5-compliant doctype switching.
3503 Rename the various modes to match the HTML5 specification:
3504 ParseMode -> CompatibilityMode
3505 CompatMode -> QuirksMode
3506 AlmostStrictMode -> LimitedQuirksMode
3507 StrictMode -> NoQuirksMode
3509 Remove the htmlHacks() accessor from RenderStyle and make rendering code just go to the document
3510 instead. This makes switching modes avoid forcing all RenderStyles to detect as changed.
3512 Clean up user stylesheets to minimize style recalculation when the mode is switched.
3514 Fix bugs with the propagation of correct modes in the HTML5 parser. Make sure the
3515 dummy document created for fragment parsing properly inherits the real document's CompatibilityMode.
3516 Make sure the tree builder properly changes the insertion mode to "BeforeHTML" after handling
3519 determineParseMode -> setCompatibilityModeFromDoctype, and it now implements the HTML5 algorithm
3522 * WebView/WebView.mm:
3523 (-[WebView _preferencesChangedNotification:]):
3525 2010-08-27 Yury Semikhatsky <yurys@chromium.org>
3527 Reviewed by Pavel Feldman.
3529 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
3530 https://bugs.webkit.org/show_bug.cgi?id=44230
3532 * WebCoreSupport/WebInspectorClient.h:
3533 * WebCoreSupport/WebInspectorClient.mm:
3534 (WebInspectorFrontendClient::closeWindow):
3535 (WebInspectorFrontendClient::disconnectFromBackend):
3536 (-[WebInspectorWindowController windowShouldClose:]):
3537 (-[WebInspectorWindowController destroyInspectorView:]):
3539 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
3541 Unreviewed. Revert r66103 since Qt tests are failing.
3543 * WebCoreSupport/WebInspectorClient.h:
3544 * WebCoreSupport/WebInspectorClient.mm:
3545 (WebInspectorFrontendClient::closeWindow):
3546 (-[WebInspectorWindowController windowShouldClose:]):
3547 (-[WebInspectorWindowController destroyInspectorView]):
3549 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
3551 Reviewed by Pavel Feldman.
3553 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
3554 https://bugs.webkit.org/show_bug.cgi?id=44230
3556 * WebCoreSupport/WebInspectorClient.h:
3557 * WebCoreSupport/WebInspectorClient.mm:
3558 (WebInspectorFrontendClient::closeWindow):
3559 (WebInspectorFrontendClient::disconnectFromBackend):
3560 (-[WebInspectorWindowController windowShouldClose:]):
3561 (-[WebInspectorWindowController destroyInspectorView:]):
3563 2010-08-24 Eric Seidel <eric@webkit.org>
3565 Reviewed by Adam Barth.
3567 Remove HTML5 parser testing infrastructure now that we don't need it
3568 https://bugs.webkit.org/show_bug.cgi?id=44581
3570 * WebView/WebPreferenceKeysPrivate.h:
3571 * WebView/WebPreferences.mm:
3572 (+[WebPreferences initialize]):
3573 * WebView/WebPreferencesPrivate.h:
3574 * WebView/WebView.mm:
3575 (-[WebView _preferencesChangedNotification:]):
3577 2010-08-24 Sam Weinig <sam@webkit.org>
3579 Reviewed by Oliver Hunt.
3581 Paste event fires twice for mac WebKit
3582 <rdar://problem/8094611>
3583 https://bugs.webkit.org/show_bug.cgi?id=44535
3585 The mac implementation of paste in WebKit was accidentally calling
3586 Editor::tryDHTMLPaste twice, once in -[WebHTMLView paste:] and once
3587 in Editor::pasteAsPlainText (which is called -[WebHTMLView paste:]).