f95c1427171c2474ed6295a6954aa63fe90df44b
[WebKit.git] / Source / WebCore / ChangeLog
1 2011-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r86016.
4         http://trac.webkit.org/changeset/86016
5         https://bugs.webkit.org/show_bug.cgi?id=60445
6
7         caused crashes on the WK2 Windows bots (Requested by
8         jessieberlin on #webkit).
9
10         * platform/network/ResourceHandle.h:
11         * platform/network/cf/CookieStorageCFNet.cpp:
12         (WebCore::currentCookieStorage):
13         (WebCore::defaultCookieStorage):
14         * platform/network/cf/ResourceHandleCFNet.cpp:
15         (WebCore::willSendRequest):
16         (WebCore::makeFinalRequest):
17         (WebCore::ResourceHandle::willSendRequest):
18         * platform/network/cf/ResourceRequestCFNet.cpp:
19         (WebCore::ResourceRequest::doUpdatePlatformRequest):
20
21 2011-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>
22
23         Unreviewed, rolling out r85974.
24         http://trac.webkit.org/changeset/85974
25         https://bugs.webkit.org/show_bug.cgi?id=60444
26
27         broke browser tests (Requested by inferno-sec on #webkit).
28
29         * platform/network/chromium/ResourceResponse.cpp:
30         (WebCore::ResourceResponse::doPlatformCopyData):
31         (WebCore::ResourceResponse::doPlatformAdopt):
32         * platform/network/chromium/ResourceResponse.h:
33         (WebCore::ResourceResponse::downloadFilePath):
34         (WebCore::ResourceResponse::setDownloadFilePath):
35
36 2011-05-07  Jessie Berlin  <jberlin@apple.com>
37
38         Reviewed by Steve Falkenburg.
39
40         [Windows WebKit2] Use cookies set in WebKit1
41         https://bugs.webkit.org/show_bug.cgi?id=60274
42
43         Share the default storage session between the UI and Web Processes.
44
45         * platform/network/cf/CookieStorageCFNet.cpp:
46         (WebCore::defaultSessionCookieStorage):
47         Keep track of the default storage session cookie storage.
48         (WebCore::currentCookieStorage):
49         Call defaultCookieStorage to get the default cookie storage.
50         (WebCore::defaultCookieStorage):
51         If there is a default storage session cookie storage, prefer that over getting the default
52         cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
53         without specifying a storage session will not get the cookie storage being shared by the UI
54         and Web Processes.
55
56         * platform/network/ResourceHandle.h:
57         * platform/network/cf/ResourceHandleCFNet.cpp:
58         (WebCore::willSendRequest):
59         Make sure to set the current storage session on any requests used by the Web
60         Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
61         doing anything with the Web Process's default storage session (which is not the one shared
62         with the UI Process).
63         (WebCore::makeFinalRequest):
64         Ditto.
65         (WebCore::ResourceHandle::willSendRequest):
66         Ditto.
67         (WebCore::ResourceHandle::currentStorageSession):
68         If there is a Private Browsing storage session, return that.
69         If not, on Windows return the default storage session that is being shared with the UI
70         Process and on Mac return 0.
71         (WebCore::defaultCFURLStorageSession):
72         (WebCore::ResourceHandle::setDefaultStorageSession):
73         (WebCore::ResourceHandle::defaultStorageSession):
74
75         * platform/network/cf/ResourceRequestCFNet.cpp:
76         (WebCore::ResourceRequest::doUpdatePlatformRequest):
77         Make sure to set the current storage session on any requests used by the Web
78         Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
79         doing anything with the Web Process's default storage session (which is not the one shared
80         with the UI Process).
81
82 2011-05-07  Joe Mason  <jmason@rim.com>
83
84         Reviewed by Daniel Bates.
85
86         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
87         https://bugs.webkit.org/show_bug.cgi?id=52211
88
89         Create a UserGestureIndicator when calling the clientRedirected callback.
90
91         * loader/NavigationScheduler.cpp:
92         (WebCore::ScheduledURLNavigation::didStartTimer):
93         (WebCore::ScheduledURLNavigation::didStopTimer):
94         (WebCore::ScheduledFormSubmission::didStartTimer):
95         (WebCore::ScheduledFormSubmission::didStopTimer):
96
97 2011-05-06  Jon Lee  <jonlee@apple.com>
98
99         Reviewed by Alice Liu.
100
101         Crash when sending a wheel event to a node with no shadow ancestor node
102         https://bugs.webkit.org/show_bug.cgi?id=60429
103         <rdar://problem/9389619>
104
105         * page/EventHandler.cpp:
106         (WebCore::EventHandler::handleWheelEvent):add check to see if the shadow ancestor node of the node that was under the mouse exists before trying to dispatch the wheel event to it.
107
108 2011-05-06  Kent Tamura  <tkent@chromium.org>
109
110         Reviewed by Ryosuke Niwa.
111
112         Eliminate WebCore/dom/InputElement.{cpp,h}
113         https://bugs.webkit.org/show_bug.cgi?id=60262
114
115         - Fold in all of the code of InputElement.{cpp,h} into HTMLInputElement
116           and TextFieldInputType.
117         - Change the return type of Node::toInputElement():
118           InputElement* -> HTMLInputElement*
119
120         No new tests. This change should not change the existing behaviour.
121
122         * CMakeLists.txt: Remove InpuntElement.cpp and/or InputElement.h.
123         * GNUmakefile.list.am: ditto.
124         * WebCore.exp.in: Add symbols of functions exposed to WebKit.
125         * WebCore.gypi: Remove InpuntElement.cpp and/or InputElement.h.
126         * WebCore.pro: ditto.
127         * WebCore.vcproj/WebCore.vcproj: ditto.
128         * WebCore.xcodeproj/project.pbxproj: ditto.
129         * accessibility/AXObjectCache.cpp:
130         (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
131           Follow the return type change of Node::toInputElement().
132         * accessibility/AccessibilityRenderObject.cpp:
133         (WebCore::AccessibilityRenderObject::isPasswordField): ditto.
134         (WebCore::AccessibilityRenderObject::isIndeterminate): ditto.
135         (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio): ditto.
136         (WebCore::AccessibilityRenderObject::isChecked): ditto.
137         * css/CSSStyleSelector.cpp:
138         (WebCore::CSSStyleSelector::canShareStyleWithElement): ditto.
139         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto.
140         * dom/CheckedRadioButtons.cpp:
141         (WebCore::CheckedRadioButtons::removeButton): ditto.
142         * dom/DOMAllInOne.cpp: Remove InputElement.h.
143         * dom/InputElement.cpp: Removed.
144         * dom/InputElement.h: Removed.
145         * dom/Node.cpp:
146         (WebCore::Node::toInputElement):
147           Change the return type from InputElement* to HTMLInputElement*.
148         * dom/Node.h: ditto.
149         * html/HTMLInputElement.cpp:
150         (WebCore::HTMLInputElement::HTMLInputElement):
151         (WebCore::HTMLInputElement::formControlName):
152         (WebCore::HTMLInputElement::tooLong):
153         (WebCore::HTMLInputElement::updateFocusAppearance):
154         (WebCore::HTMLInputElement::aboutToUnload):
155         (WebCore::HTMLInputElement::handleFocusEvent):
156         (WebCore::HTMLInputElement::handleBlurEvent):
157         (WebCore::HTMLInputElement::updateType):
158         (WebCore::HTMLInputElement::parseMappedAttribute):
159         (WebCore::HTMLInputElement::size):
160         (WebCore::HTMLInputElement::copyNonAttributeProperties):
161         (WebCore::HTMLInputElement::value):
162         (WebCore::HTMLInputElement::suggestedValue):
163         (WebCore::HTMLInputElement::setSuggestedValue):
164         (WebCore::HTMLInputElement::setValue):
165         (WebCore::HTMLInputElement::setValueFromRenderer):
166         (WebCore::HTMLInputElement::setFileListFromRenderer):
167         (WebCore::HTMLInputElement::setDefaultName):
168         (WebCore::HTMLInputElement::maxLength):
169         (WebCore::HTMLInputElement::cacheSelection):
170         (WebCore::formatCodes): Moved from InputElement.
171         (WebCore::cursorPositionToMaskIndex): ditto.
172         (WebCore::HTMLInputElement::isConformToInputMask): ditto.
173         (WebCore::HTMLInputElement::validateInputMask): ditto.
174         (WebCore::HTMLInputElement::setWapInputFormat): ditto.
175         (WebCore::HTMLInputElement::notifyFormStateChanged): ditto.
176         (WebCore::HTMLInputElement::parseMaxLengthAttribute): ditto.
177         (WebCore::HTMLInputElement::updateValueIfNeeded):ditto.
178         * html/HTMLInputElement.h:
179           - Add data members which were defined in InputElementData.
180           - Make some functions public because the public interface InputElement is removed.
181           - Make some functions non-virtual because they don't override
182             corresponding virtual functions of InputElement anymore.
183         (WebCore::HTMLInputElement::toInputElement):
184           Follow the return type change of Node::toInputElement().
185         (WebCore::HTMLInputElement::isIndeterminate):
186         (WebCore::HTMLInputElement::isAutofilled):
187         (WebCore::HTMLInputElement::supportsMaxLength):
188         (WebCore::HTMLInputElement::cachedSelectionStart):
189         (WebCore::HTMLInputElement::cachedSelectionEnd):
190         * html/HTMLTextAreaElement.cpp: Remove unused InputElement.h.
191         * html/InputType.cpp:
192         (WebCore::InputType::handleBeforeTextInsertedEvent): Remove the code.
193         * html/InputType.h: Update for the above.
194         * html/TextFieldInputType.cpp:
195         (WebCore::replaceEOLAndLimitLength): Moved from InputElement.cpp.
196         (WebCore::TextFieldInputType::sanitizeValue): Implement with replaceEOLAndLimitLength().
197         (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
198           Move the code from InputElement::handleBeforeTextInsertedEvent().
199         * html/TextFieldInputType.h: Update declarations.
200         * rendering/RenderTextControlSingleLine.cpp:
201           - Remove ASSERT(node()->isHTMLElement()) because it is checked in the constructor.
202           - Follow the return type change of inputElement().
203         (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
204           Make sure node() is an HTMLInputElement instance.
205         (WebCore::RenderTextControlSingleLine::addSearchResult):
206         (WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
207         (WebCore::RenderTextControlSingleLine::showPopup):
208         (WebCore::RenderTextControlSingleLine::hidePopup):
209         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
210         (WebCore::RenderTextControlSingleLine::updateFromElement):
211         (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
212         (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
213         (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
214         (WebCore::RenderTextControlSingleLine::createInnerSpinButtonStyle):
215         (WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
216         (WebCore::RenderTextControlSingleLine::createSpeechButtonStyle):
217         (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
218         (WebCore::RenderTextControlSingleLine::startSearchEventTimer):
219         (WebCore::RenderTextControlSingleLine::searchEventTimerFired):
220         (WebCore::RenderTextControlSingleLine::valueChanged):
221         (WebCore::RenderTextControlSingleLine::setTextFromItem):
222         (WebCore::RenderTextControlSingleLine::inputElement):
223         * rendering/RenderTextControlSingleLine.h:
224           Change the return type of inputElement(): InputElement* -> HTMLInputElement*.
225         * rendering/RenderTheme.cpp:
226         (WebCore::RenderTheme::isChecked):
227           Follow the return type change of Node::toInputElement().
228         (WebCore::RenderTheme::isIndeterminate): ditto.
229         (WebCore::RenderTheme::shouldHaveSpinButton):
230           Change the parameter type: InputElement* -> HTMLInputElement*.
231         * rendering/RenderTheme.h: ditto.
232
233 2011-05-06  Adam Barth  <abarth@webkit.org>
234
235         Reviewed by Eric Seidel.
236
237         Implement "Report-Only" mode for CSP
238         https://bugs.webkit.org/show_bug.cgi?id=60402
239
240         This mode lets web sites try out CSP by getting violation reports (and
241         console spam) without actually changing the behavior of their web sites.
242
243         Test: http/tests/security/contentSecurityPolicy/report-only.html
244
245         * dom/Document.cpp:
246         (WebCore::Document::processHttpEquiv):
247         * loader/FrameLoader.cpp:
248         (WebCore::FrameLoader::didBeginDocument):
249         * page/ContentSecurityPolicy.cpp:
250         (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
251         (WebCore::ContentSecurityPolicy::didReceiveHeader):
252         (WebCore::ContentSecurityPolicy::reportViolation):
253         (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation):
254         (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation):
255         (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
256         (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
257         * page/ContentSecurityPolicy.h:
258
259 2011-05-06  Beth Dakin  <bdakin@apple.com>
260
261         Reviewed by Darin Adler.
262
263         https://bugs.webkit.org/show_bug.cgi?id=60421
264         Custom scrollbars nested inside an overlay scrollbar overflow region end up 
265         painting twice
266         -and corresponding-
267         <rdar://problem/9389072>
268
269         Be sure not to paint custom css scrollbars during the special overlay-scrollbar 
270         painting pass.
271         * rendering/RenderLayer.cpp:
272         (WebCore::RenderLayer::paintOverflowControls):
273
274 2011-05-06  Cary Clark  <caryclark@google.com>
275
276         Reviewed by Eric Seidel.
277
278         Add utility for converting SkCanvas to CGContext
279         https://bugs.webkit.org/show_bug.cgi?id=59808
280
281         Skia on Mac uses Skia to render WebKit, and CG 
282         to render UI elements. The CG elements need a 
283         transcribed graphics context that preserves the 
284         canvas matrix, and the canvas clip. 
285
286         The BitLockerSkia utility class sets up a CGContext 
287         from the SkCanvas, locks the bitmap's bits, and 
288         releases the lock when the class goes out of scope. 
289
290         Each time the CGContext is retrieved, it is rebuilt. 
291         This permits the caller to modify the same canvas 
292         between calls. 
293
294         This change adds utilities but does not modify any 
295         existing code. For now, there are no callers to these 
296         utilities, so there is no functional change.
297
298         No new tests.
299
300         * platform/graphics/skia/BitLockerSkia.cpp: Added.
301         (WebCore::SkMatrixToCGAffineTransform): Conversion utility.
302         (WebCore::BitLockerSkia::BitLockerSkia): Takes SkCanvas.
303         (WebCore::BitLockerSkia::~BitLockerSkia): Unlocks, cleans up.
304         (WebCore::BitLockerSkia::release): Internal private helper.
305         (WebCore::BitLockerSkia::cgContext): Returns CGContextRef.
306         * platform/graphics/skia/BitLockerSkia.h: Added.
307
308 2011-05-06  Martin Robinson  <mrobinson@igalia.com>
309
310         Reviewed by Xan Lopez.
311
312         [GTK] [WebKit2] WebView::windowToScreen needs an implementation
313         https://bugs.webkit.org/show_bug.cgi?id=55960
314
315         Abstract coordinate system translation code from WebKit into WebCore.
316         This will allow the code to be shared between WebKit and WebKit2. The code
317         now lives in a new GtkUtilities.cpp helper file.
318
319         * GNUmakefile.list.am: Added GtkUtilities to the source list.
320         * platform/gtk/GtkUtilities.cpp: Added.
321         (WebCore::convertWidgetRectToScreenRect):
322         * platform/gtk/GtkUtilities.h: Added.
323
324 2011-05-06  Martin Robinson  <mrobinson@igalia.com>
325
326         Reviewed by Xan Lopez.
327
328         Remove some unnecessary static methods in ResourceHandleSoup.
329
330         No new tests. This is only a small cleanup.
331
332         * platform/network/soup/ResourceHandleSoup.cpp:
333         (WebCore::restartedCallback): Call ResourceResponse::updateFromSoupMessage directly.
334         (WebCore::gotHeadersCallback):Ditto.
335         (WebCore::contentSniffedCallback):Ditto.
336         (WebCore::sendRequestCallback):Ditto.
337         (WebCore::ResourceHandle::defaultSession): Create the soup session directly.
338
339 2011-05-06  Martin Robinson  <mrobinson@igalia.com>
340
341         Reviewed by Xan Lopez.
342
343         [Soup] ResourceHandles are leaked on 304 responses
344         https://bugs.webkit.org/show_bug.cgi?id=60413
345
346         Always call cleanupSoupRequestOperation, even when the request was not
347         canceled. Before the code would call didFinishLoading and then never clean up
348         the request.
349
350         No new tests. This simply fixes a memory leak.
351
352         * platform/network/soup/ResourceHandleSoup.cpp:
353         (WebCore::sendRequestCallback):
354
355 2011-05-06  Adam Barth  <abarth@webkit.org>
356
357         Reviewed by Eric Seidel.
358
359         Add disable-javascript-urls CSP directive
360         https://bugs.webkit.org/show_bug.cgi?id=60301
361
362         This CSP directive is not in the CSP spec.  This patch is somewhat of
363         an experiment to see whether this feature is useful.  Based on our
364         implementation experience, we will coordinate with folks via the W3C to
365         see if this makes sense to add to the spec.
366
367         Test: http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html
368
369         * page/ContentSecurityPolicy.cpp:
370         (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
371         (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
372         (WebCore::ContentSecurityPolicy::addDirective):
373         * page/ContentSecurityPolicy.h:
374
375 2011-05-06  Brett Wilson  <brettw@chromium.org>
376
377         Reviewed by Adam Barth.
378
379         Use a File object to store the downloaded file reference rather than
380         just the path. This keeps the file and permissions in scope (using the
381         already-existing blob system) so the browser won't delete the file
382         when the load is complete. Instead, the file will be cleaned up when
383         the request objects are deleted.
384         https://bugs.webkit.org/show_bug.cgi?id=60281
385
386         * platform/network/chromium/ResourceResponse.cpp:
387         (WebCore::ResourceResponse::doPlatformCopyData):
388         (WebCore::ResourceResponse::doPlatformAdopt):
389         * platform/network/chromium/ResourceResponse.h:
390         (WebCore::ResourceResponse::downloadedFile):
391         (WebCore::ResourceResponse::setDownloadedFile):
392
393 2011-05-06  Alexis Menard  <alexis.menard@openbossa.org>
394
395         Reviewed by Darin Adler.
396
397         Fix two warnings of unused variables.
398         https://bugs.webkit.org/show_bug.cgi?id=60370
399
400         Remove two unused local variable from the code.
401
402         No new tests, the existing ones should cover.
403
404         * rendering/RenderFlexibleBox.cpp:
405         (WebCore::RenderFlexibleBox::layoutVerticalBox):
406         * svg/animation/SVGSMILElement.cpp:
407         (WebCore::SVGSMILElement::calculateNextProgressTime):
408
409 2011-05-06  Adam Barth  <abarth@webkit.org>
410
411         Reviewed by Eric Seidel.
412
413         Wire up CSP's eval blocking to V8's new API
414         https://bugs.webkit.org/show_bug.cgi?id=60384
415
416         * bindings/v8/ScriptController.cpp:
417         (WebCore::ScriptController::disableEval):
418
419 2011-05-06  David Hyatt  <hyatt@apple.com>
420
421         Reviewed by Dan Bernstein.
422
423         https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
424         REGRESSION (r81684?): cox.com sign in button is missing
425         
426         Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
427         This restores the original behavior before the refactoring messed it up.
428
429         Added fast/inline/nested-top-alignment.html
430
431         * rendering/InlineFlowBox.cpp:
432         (WebCore::InlineFlowBox::computeLogicalBoxHeights):
433
434 2011-05-06  David Hyatt  <hyatt@apple.com>
435
436         Reviewed by Dan Bernstein.
437
438         https://bugs.webkit.org/show_bug.cgi?id=60390 (<rdar://problem/9364449>)
439         REGRESSION (r81992): portions of ticketmaster site render blank
440
441         Make simplified layout skip from a positioned object out to its containing block.  There is no
442         need to dirty the intermediate inlines, and in this case it's actively harmful, since the
443         block responsible for the layout of the positioned object doesn't get m_posChildNeedsLayout set.
444
445         Added fast/block/positioning/hiding-inside-relpositioned-inline.html
446
447         * rendering/RenderObject.h:
448         (WebCore::RenderObject::markContainingBlocksForLayout):
449
450 2011-05-06  Pavel Feldman  <pfeldman@chromium.org>
451
452         Not reviewed: move selection test into the text area branch.
453
454         * inspector/front-end/TextViewer.js:
455         (WebInspector.TextViewer.prototype._contextMenu):
456
457 2011-05-04  Adrienne Walker  <enne@google.com>
458
459         Reviewed by James Robinson.
460
461         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
462         https://bugs.webkit.org/show_bug.cgi?id=59020
463
464         Allow for empty scissor rects, which implies scissoring to the render
465         surface. The previous code and previous patch on this bug both didn't
466         take into account that the scissor rect should be the render surface
467         and not the projection of the layer itself, because child layers
468         aren't necessarily contained within the bounds of their superlayer.
469
470         Test: compositing/flat-with-transformed-child.html
471
472         * platform/graphics/chromium/LayerRendererChromium.cpp:
473         (WebCore::LayerRendererChromium::paintLayerContents):
474         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
475         (WebCore::LayerRendererChromium::drawLayer):
476         (WebCore::LayerRendererChromium::setScissorToRect):
477
478 2011-05-06  Simon Fraser  <simon.fraser@apple.com>
479
480         Reviewed by Sam Weinig.
481
482         Lazily allocate ScrollAnimator in ScrollableArea
483         https://bugs.webkit.org/show_bug.cgi?id=60327
484
485         Avoid allocating the ScrollAnimator up-front, because we
486         create lots of ScrollableAreas via RenderLayer, and we should
487         only need the animator when scrolling.
488
489         * platform/ScrollableArea.cpp:
490         (WebCore::ScrollableArea::ScrollableArea):
491         (WebCore::ScrollableArea::scrollAnimator):
492         (WebCore::ScrollableArea::scroll):
493         (WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
494         (WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
495         (WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
496         (WebCore::ScrollableArea::handleWheelEvent):
497         (WebCore::ScrollableArea::handleGestureEvent):
498         * platform/ScrollableArea.h:
499
500 2011-05-06  Eric Carlson  <eric.carlson@apple.com>
501
502         Reviewed by Darin Adler.
503
504         REGRESSION (r77954): HTTP Live Streams have incorrect controller UI
505         https://bugs.webkit.org/show_bug.cgi?id=60304
506         <rdar://problem/9392609>
507
508         Don't assume that the only time the media controls UI may need to change is on a 
509         network state change, readyState changes can be significant as well.
510
511         Tested manually because we don't have any live streams to test in DRT.
512
513         * html/HTMLMediaElement.cpp:
514         (WebCore::HTMLMediaElement::setNetworkState): changedNetworkState -> updateStatusDisplay.
515         (WebCore::HTMLMediaElement::setReadyState): Call updateStatusDisplay.
516
517         * html/shadow/MediaControlRootElement.cpp:
518         (WebCore::MediaControlRootElement::reset): changedNetworkState -> updateStatusDisplay.
519         (WebCore::MediaControlRootElement::updateStatusDisplay): Ditto.
520         * html/shadow/MediaControlRootElement.h:
521
522         * html/shadow/MediaControlRootElementChromium.cpp:
523         (WebCore::MediaControlRootElementChromium::reset): Ditto.
524         (WebCore::MediaControlRootElementChromium::updateStatusDisplay): Ditto.
525         * html/shadow/MediaControlRootElementChromium.h:
526         * html/shadow/MediaControls.h:
527
528 2011-05-06  Andreas Kling  <andreas.kling@nokia.com>
529
530         Unreviewed Qt 4.8 build fix.
531
532         * WebCore.pro: Don't set HAVE_QRAWFONT yet. Left a FIXME so we can
533         enable it after the 4.8 bots are updated with the full QRawFont APIs.
534
535 2011-05-06  Alexander Pavlov  <apavlov@chromium.org>
536
537         Reviewed by Yury Semikhatsky.
538
539         Web Inspector: editing CSS in the Resources panel and not committing does not revert the change.
540         https://bugs.webkit.org/show_bug.cgi?id=60319
541
542         * inspector/front-end/ResourceView.js:
543         (WebInspector.ResourceSourceFrame.prototype.cancelEditing):
544
545 2011-05-06  Joe Mason  <jmason@rim.com>
546
547         Reviewed by Adam Barth.
548
549         WebSocket urls should always be encoded as UTF-8.
550         https://bugs.webkit.org/show_bug.cgi?id=57138
551
552         Change WebSocket::connect to take the raw URL string and parse it
553         internally using the simple KURL constructor, which expects an absolute
554         UTF-8 encoded URL.  This ensures that all code that creates a WebSocket
555         goes through this method instead of completeURL.
556
557         Test: http/tests/websocket/tests/url-with-nonascii-query.html
558
559         * bindings/js/JSWebSocketCustom.cpp:
560         (WebCore::JSWebSocketConstructor::constructJSWebSocket): Pass String instead of KURL to WebSocket::connect().
561         * websockets/WebSocket.cpp:
562         (WebCore::WebSocket::connect): Now takes a String instead of a KURL and parses it using UTF-8.
563         * websockets/WebSocket.h:
564
565 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
566
567         Reviewed by Eric Seidel.
568
569         Make CSSStyleSelector::applyProperty() CSSPropertyWebkitColorCorrection case use appropriate macro.
570         https://bugs.webkit.org/show_bug.cgi?id=60339
571
572         No tests added as no functionality changed.
573
574         * css/CSSStyleSelector.cpp:
575         (WebCore::CSSStyleSelector::applyProperty):
576         Use correct macro for CSSPropertySpeak.
577         * rendering/style/RenderStyle.h:
578         (WebCore::InheritedFlags::initialColorSpace):
579         Add initialColorSpace() static method.
580
581 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
582
583         Reviewed by Eric Seidel.
584
585         Make RenderStyle::setPageBreakInside() reject unsupported enum values.
586         https://bugs.webkit.org/show_bug.cgi?id=60235
587
588         No tests added as no functionality changed.
589
590         * css/CSSStyleSelector.cpp:
591         (WebCore::CSSStyleSelector::applyProperty):
592         Remove special-case code and use appropriate macro.
593         * rendering/style/RenderStyle.h:
594         (WebCore::InheritedFlags::setPageBreakInside):
595         Assert that only supported values are used.
596
597 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
598
599         Reviewed by Eric Seidel.
600
601         Move burden of checking for BJustify box alignment into RenderStyle
602         https://bugs.webkit.org/show_bug.cgi?id=60246
603
604         No new tests added as no functionality changed.
605
606         * css/CSSStyleSelector.cpp:
607         (WebCore::CSSStyleSelector::applyProperty):
608         Remove special-case logic checking for BJUSTIFY and use existing macro.
609         * rendering/style/RenderStyle.h:
610         (WebCore::InheritedFlags::setBoxAlign):
611         Assert valid values are used.
612
613 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
614
615         Reviewed by Eric Seidel.
616
617         Make CSSStyleSelector::applyProperty() CSSPropertyPointerEvents use the correct macro.
618         https://bugs.webkit.org/show_bug.cgi?id=60338
619
620         No tests added as no functionality changed.
621
622         * css/CSSStyleSelector.cpp:
623         (WebCore::CSSStyleSelector::applyProperty):
624         Use correct macro for CSSPropertySpeak.
625
626 2011-05-06  Alexis Menard  <alexis.menard@openbossa.org>
627
628         Reviewed by Alexey Proskuryakov.
629
630         Build fix with gcc 4.6 and c++0x support.
631         https://bugs.webkit.org/show_bug.cgi?id=60284
632
633         When enabling support of c++0x the compilation fails because of an
634         ambiguous overload error. In this code when constructing the pair
635         we use the new c++0x rvalue reference feature (&&). It means we are
636         calling String(const WTF::AtomicString&) which becomes ambiguous because
637         it has an overload WTF::String::String(const WTF::String&) and usually one
638         with the native port string type (e.g. QString). In this code we want the
639         String version because the pair store Strings.
640
641         No new tests, build fix.
642
643         * loader/FormSubmission.cpp:
644         (WebCore::FormSubmission::create):
645
646 2011-05-06  Cris Neckar  <cdn@chromium.org>
647
648         Reviewed by Dirk Schulze.
649
650         Tests for crash when a transform is applied to certain filters.
651         https://bugs.webkit.org/show_bug.cgi?id=59551
652
653         Test: svg/filters/filter-after-transform-crash.svg
654
655         * platform/graphics/filters/FEComposite.cpp:
656         (WebCore::FEComposite::determineAbsolutePaintRect):
657         * platform/graphics/filters/FEConvolveMatrix.h:
658         (WebCore::FEConvolveMatrix::determineAbsolutePaintRect):
659         * platform/graphics/filters/FEDisplacementMap.h:
660         (WebCore::FEDisplacementMap::determineAbsolutePaintRect):
661         * platform/graphics/filters/FEFlood.h:
662         (WebCore::FEFlood::determineAbsolutePaintRect):
663         * platform/graphics/filters/FELighting.h:
664         (WebCore::FELighting::determineAbsolutePaintRect):
665         * platform/graphics/filters/FETile.h:
666         (WebCore::FETile::determineAbsolutePaintRect):
667         * platform/graphics/filters/FETurbulence.h:
668         (WebCore::FETurbulence::determineAbsolutePaintRect):
669         * platform/graphics/filters/FilterEffect.cpp:
670         (WebCore::isFilterSizeValid):
671         (WebCore::FilterEffect::determineAbsolutePaintRect):
672         (WebCore::FilterEffect::asUnmultipliedImage):
673         (WebCore::FilterEffect::asPremultipliedImage):
674         (WebCore::FilterEffect::copyUnmultipliedImage):
675         (WebCore::FilterEffect::copyPremultipliedImage):
676         (WebCore::FilterEffect::createUnmultipliedImageResult):
677         (WebCore::FilterEffect::createPremultipliedImageResult):
678         * platform/graphics/filters/FilterEffect.h:
679         (WebCore::FilterEffect::maxEffectRect):
680         (WebCore::FilterEffect::setMaxEffectRect):
681         * rendering/svg/RenderSVGResourceFilter.cpp:
682         * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
683         (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
684
685 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
686
687         Reviewed by Eric Seidel.
688
689         Use cast to convert primitive value to FontSmoothingMode.
690         https://bugs.webkit.org/show_bug.cgi?id=60242
691
692         No tests added as no functionality changed.
693
694         * css/CSSStyleSelector.cpp:
695         (WebCore::CSSStyleSelector::applyProperty):
696         Use cast to convert primitive value to FontSmoothingMode.
697
698 2011-05-05  Luke Macpherson   <macpherson@chromium.org>
699
700         Reviewed by Eric Seidel.
701
702         Make CSSPropertySpeak use the correct macro.
703         https://bugs.webkit.org/show_bug.cgi?id=60335
704
705         No tests added as no functionality changed.
706
707         * css/CSSStyleSelector.cpp:
708         (WebCore::CSSStyleSelector::applyProperty):
709         Use correct macro for CSSPropertySpeak.
710
711 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
712
713         Reviewed by Maciej Stachowiak.
714
715         <rdar://problem/9390864>
716         https://bugs.webkit.org/show_bug.cgi?id=60343
717         Crash on Recovery System when trying to load page that includes media element
718
719         Automated test not possible, tested manually.
720
721         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
722         (WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable): Only return true if
723             AVFoundation and CoreMedia are installed.
724
725         * platform/mac/SoftLinking.h: Define SOFT_LINK_FRAMEWORK_OPTIONAL, identical to 
726             SOFT_LINK_FRAMEWORK except that it doesn't ASSERT if the framework doesn't exist.
727
728 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
729
730         Reviewed by Darin Adler.
731
732         Live streams sometimes won't play with AVFoundation backend
733         https://bugs.webkit.org/show_bug.cgi?id=58961
734         rdar://problem/9284748
735
736         Tested manually because we don't have any live streams to test in DRT.
737
738         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
739         (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Don't special case seeking, assume
740             AVFoundation will notify us when internal states change.
741
742         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Make m_timeObserver
743             a RetainPtr
744         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
745         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Ditto.
746         (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
747
748 2011-05-05  Jay Civelli  <jcivelli@chromium.org>
749
750         Reviewed by Adam Barth.
751
752         Adding quoted-printable encoding/decoding capabilities.
753         This is needed for MHTML support.
754         https://bugs.webkit.org/show_bug.cgi?id=59834
755
756         * CMakeLists.txt:
757         * GNUmakefile.list.am:
758         * WebCore.gypi:
759         * WebCore.pro:
760         * WebCore.vcproj/WebCore.vcproj:
761         * WebCore.xcodeproj/project.pbxproj:
762         * platform/text/QuotedPrintable.cpp: Added.
763         * platform/text/QuotedPrintable.h: Added.
764
765 2011-05-05  Andy Estes  <aestes@apple.com>
766
767         Reviewed by Eric Seidel.
768
769         Implement document.innerHTML
770         https://bugs.webkit.org/show_bug.cgi?id=60316
771
772         ASSERT that contextElement is non-0 when constructing a HTMLTreeBuilder
773         for fragment parsing. This assertion will become invalid when
774         document.innerHTML is implemented, which is the only case where HTML5
775         specifies that a fragment will not have a context element.
776
777         * html/parser/HTMLTreeBuilder.cpp:
778         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
779
780 2011-05-05  Kevin Ollivier  <kevino@theolliviers.com>
781
782         [wx] Unreviewed build fix. Include ApplicationServices for wx port.
783
784         * platform/graphics/GlyphBuffer.h:
785         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
786
787 2011-05-05  Dan Bernstein  <mitz@apple.com>
788
789         Reviewed by Simon Fraser.
790
791         WebCore part of <rdar://problem/9155590> Broken animation in iAd producer
792
793         * WebCore.exp.in: Export wkExecutableWasLinkedOnOrBeforeSnowLeopard.
794         * platform/graphics/ca/GraphicsLayerCA.cpp:
795         (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): Account for the binary-compatiblity
796         check in Core Animation.
797         * platform/mac/WebCoreSystemInterface.h: Added wkExecutableWasLinkedOnOrBeforeSnowLeopard.
798         * platform/mac/WebCoreSystemInterface.mm: Ditto.
799
800 2011-05-05  Sam Weinig  <sam@webkit.org>
801
802         Reviewed by Anders Carlsson.
803
804         WebKit2 (Mac): Background tabs/windows can force themselves to the front
805         <rdar://problem/9386346>
806         https://bugs.webkit.org/show_bug.cgi?id=60315
807
808         * platform/mac/WidgetMac.mm:
809         (WebCore::Widget::setFocus):
810         It is incorrect for us to call Chrome::focus() here, which could bring a window/tab
811         to the front. Calling focusNSView() was only necessary because in WebKit we must inform
812         the platform widget that the focus has changed. WebKit2 Mac now matches other ports.
813
814 2011-05-05  Justin Novosad  <junov@chromium.org>
815
816         Reviewed by Kenneth Russell.
817
818         [Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
819         https://bugs.webkit.org/show_bug.cgi?id=60173
820
821         * page/Page.cpp:
822         (WebCore::Page::sharedGraphicsContext3D):
823         Flipping the switch to make Skia the default for the accelerated 2d canvas
824
825 2011-05-05  Tony Gentilcore  <tonyg@chromium.org>
826
827         Reviewed by Adam Barth.
828
829         ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
830         https://bugs.webkit.org/show_bug.cgi?id=60101
831
832         Test: fast/parser/close-while-stopping.html
833
834         * dom/Document.cpp:
835         (WebCore::Document::close): According to http://www.whatwg.org/specs/web-apps/current-work/#dom-document-close,
836         the close() steps should be aborted if there is no script-created parser
837         associated with the document. Our parser lives throughout
838         http://www.whatwg.org/specs/web-apps/current-work/#the-end, but it seems
839         the spec doesn't consider the parser active any more. So to properly
840         respect this, we need to check that the parser is still parsing.
841
842 2011-04-28  Evan Martin  <evan@chromium.org>
843
844         Reviewed by Ojan Vafai.
845
846         REGRESSION: backspace should not go back on Linux
847         https://bugs.webkit.org/show_bug.cgi?id=59731
848
849         Add a new EditingBehavior, shouldNavigateBackOnBackspace, which is false on
850         Linux, and test for it in the default backspace handler.
851
852         * editing/EditingBehavior.h:
853         (WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
854         * page/EventHandler.cpp:
855         (WebCore::EventHandler::defaultBackspaceEventHandler):
856
857 2011-05-05  Igor Oliveira  <igor.oliveira@openbossa.org>
858
859         Reviewed by Kenneth Russell.
860
861         Framebuffer object is being created twice
862         https://bugs.webkit.org/show_bug.cgi?id=60207
863
864         Does not create more than one opengl framebuffer
865
866         * platform/graphics/gpu/mac/DrawingBufferMac.mm:
867         (WebCore::DrawingBuffer::DrawingBuffer):
868         * platform/graphics/gpu/qt/DrawingBufferQt.cpp:
869         (WebCore::DrawingBuffer::DrawingBuffer):
870         * platform/graphics/gtk/DrawingBufferGtk.cpp:
871         (WebCore::DrawingBuffer::DrawingBuffer):
872
873 2011-05-05  Simon Fraser  <simon.fraser@apple.com>
874
875         Reviewed by Beth Dakin.
876
877         Every RenderLayer registers itself as a ScrollableArea
878         https://bugs.webkit.org/show_bug.cgi?id=59650
879
880         Rather than registering every RenderLayer as a ScrollableArea
881         on layer creation, only register RenderLayers which are overflow-
882         scrollable. Use the m_scrollableAreaPage pointer to keep track
883         of whether we've registered to avoid excess work.
884
885         * rendering/RenderLayer.cpp:
886         (WebCore::RenderLayer::RenderLayer):
887         (WebCore::RenderLayer::scrollsOverflow):
888         (WebCore::RenderLayer::styleChanged):
889         * rendering/RenderLayer.h:
890
891 2011-05-05  Jer Noble  <jer.noble@apple.com>
892
893         Reviewed by Steve Falkenburg.
894
895         Workaround iTunes' incorrect registry entry for .m4a extensions.
896         https://bugs.webkit.org/show_bug.cgi?id=60229
897
898         No new tests, as a test already exits for .m4a support (LayoutTests/media/audio-mpeg4-supported.html).
899         The test failed to catch this regression because the build bots haven't installed iTunes.
900         
901         Add a hard-coded MIME type mapping for 'm4a' -> 'audio/x-m4a'.
902
903         * platform/win/MIMETypeRegistryWin.cpp:
904         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
905
906 2011-05-05  Abhishek Arya  <inferno@chromium.org>
907
908         Reviewed by Dave Hyatt.
909
910         When style changes for a RenderBlock and we lose our ability to intrude into
911         floats in the next siblings block (e.g a position change), make sure to mark
912         our childs with floats for layout and iterate through our next sibling block
913         chain to see which ones contain the float that also exists in our floating
914         objects list and clear those using markAllDescendantsWithFloatsForLayout.
915         https://bugs.webkit.org/show_bug.cgi?id=56299
916
917         Tests: fast/block/float/float-not-removed-from-next-sibling-crash.html
918                fast/block/float/float-not-removed-from-next-sibling.html
919                fast/block/float/float-not-removed-from-next-sibling2.html
920                fast/block/float/float-not-removed-from-next-sibling3.html
921                fast/block/float/float-not-removed-from-next-sibling4.html
922
923         * rendering/RenderBlock.cpp:
924         (WebCore::RenderBlock::styleWillChange):
925         (WebCore::RenderBlock::styleDidChange):
926         (WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
927         * rendering/RenderBlock.h:
928
929 2011-05-05  Brian Weinstein  <bweinstein@apple.com>
930
931         Reviewed by Timothy Hatcher.
932
933         WebKit2: Docking Web Inspector doesn't respect maximum inspector size
934         https://bugs.webkit.org/show_bug.cgi?id=60294
935         <rdar://problem/9388518>
936
937         Make a needed function public and export it.
938
939         * WebCore.exp.in: Export constrainedAttaechedWindowHeight.
940         * inspector/InspectorFrontendClientLocal.h: Make constrainedAttaechedWindowHeight public.
941
942 2011-05-05  Tony Gentilcore  <tonyg@chromium.org>
943
944         Reviewed by Nate Chapin.
945
946         [Navigation Timing] navigationStart should always be available
947         https://bugs.webkit.org/show_bug.cgi?id=59448
948
949         * page/PerformanceTiming.cpp:
950         (WebCore::PerformanceTiming::navigationStart):
951
952 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
953
954         Reviewed by Adam Roben.
955
956         Block callbacks delivered during destruction
957         https://bugs.webkit.org/show_bug.cgi?id=60291
958         <rdar://problem/9382942>
959
960         No new tests, tested by existing tests.
961
962         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
963         (WebCore::MediaPlayerPrivateAVFoundation::~MediaPlayerPrivateAVFoundation): Call 
964             setIgnoreLoadStateChanges(true) to cancel all callbacks.
965         (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Return immediately if 
966             m_ignoreLoadStateChanges is true.
967         (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): loadStateChanged -> updateStates.
968             Don't call updateStates after calling loadedTimeRangesChanged, it already does it.
969         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
970
971 2011-05-05  David Hyatt  <hyatt@apple.com>
972
973         Reviewed by Darin Adler.
974
975         <rdar://problem/9354979> REGRESSION (r83070-r83126): Conversation takes 10 seconds to load and makes mail unresponsive
976
977         Culled inlines were triggering some pathological line box tree groveling that isn't even necessary.
978         Removed the ancient code (that used to be in RenderFlow), since it made no sense in the RenderBlock case
979         (it was running for inline blocks, which was definitely not even the intent) or in the RenderInline case
980         (the object being removed has no effect on any lines).
981         
982         Also tweaked culledInlineFirstLineBox and culledInlineLastLineBox to avoid bailing if the first replaced object that
983         is encountered has a null inlineBoxWrapper().  Just a slight speed optimization to avoid an extra null check.
984         
985         * rendering/RenderBlock.cpp:
986         (WebCore::RenderBlock::destroy):
987         * rendering/RenderInline.cpp:
988         (WebCore::RenderInline::destroy):
989         (WebCore::RenderInline::culledInlineFirstLineBox):
990         (WebCore::RenderInline::culledInlineLastLineBox):
991
992 2011-05-05  Bharathwaaj Srinivasan  <bharathwaaj.s@gmail.com>
993
994         Reviewed by Holger Freyther.
995
996         Fix build-webkit --minimal.
997         https://bugs.webkit.org/show_bug.cgi?id=60257
998
999         No new tests. This is just a build fix.
1000
1001         * bindings/js/JSDOMBinding.cpp:
1002
1003 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
1004
1005         Reviewed by Adam Roben.
1006
1007         The preload attribute of the video tag is not completely implemented
1008         https://bugs.webkit.org/show_bug.cgi?id=43673
1009         <rdar://problem/9369746>
1010
1011         This change implements "preload=metadata" for the AVFoundation backend.
1012         Tested manually with manual-tests/media-elements/video-preload.html.
1013
1014         * html/HTMLMediaElement.cpp:
1015         (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay.
1016         (WebCore::HTMLMediaElement::prepareForLoad): Ditto.
1017         (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play.
1018         (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'auto'
1019             because we need to have media data loaded to seek.
1020         (WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.
1021         * html/HTMLMediaElement.h:
1022
1023         * manual-tests/media-elements/video-preload.html: Make changing urls work. 
1024
1025         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
1026         (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):  Remove 
1027             m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.
1028         (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
1029         (WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn. 
1030             Move all preload logic to setPreload, call it from here.
1031         (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to 
1032             setPreload, call it.
1033         (WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is
1034             unlikely to be correct and isn't worth caching. Use invalidTime() function.
1035         (WebCore::MediaPlayerPrivateAVFoundation::seeking): Use invalidTime() function.
1036         (WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Add logging.
1037         (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus
1038             to AssetStatus. Always create a AVPlayerItem for live streams because they can't be inspected
1039             without one. Set networkState to 'idle' when the playback buffer is full because that is
1040             a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA' 
1041             when the first frame is available.
1042         (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache
1043             width, height, hasVideo, etc.
1044         (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Use invalidTime() function.
1045         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): Ditto.
1046         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
1047         (WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done
1048             in derived classes.
1049         (WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create
1050             AVAsset and AVPlayerItem here.
1051         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
1052
1053         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
1054         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
1055         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
1056             m_videoFrameHasDrawn.
1057         (WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from
1058             videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
1059             if we have painted a frame to the context.
1060         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset
1061             if necessary.
1062         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
1063         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
1064         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
1065         (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
1066         (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when
1067             the buffer is full.
1068         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the
1069             AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
1070             when we only have metadata.
1071         (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
1072         (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
1073         (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset
1074             when when we haven't allocated the AVPlayerItem yet so that we can report attributes
1075             when we only have metadata.
1076         (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before
1077             we have allocated the AVPlayerItem.
1078
1079 2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
1080
1081         Reviewed by Eric Seidel.
1082
1083         Rename SelectionController to FrameSelection
1084         https://bugs.webkit.org/show_bug.cgi?id=60234
1085
1086         * CMakeLists.txt:
1087         * GNUmakefile.list.am:
1088         * WebCore.exp.in:
1089         * WebCore.gypi:
1090         * WebCore.pro:
1091         * WebCore.vcproj/WebCore.vcproj:
1092         * WebCore.xcodeproj/project.pbxproj:
1093         * accessibility/AccessibilityObject.cpp:
1094         * accessibility/AccessibilityRenderObject.cpp:
1095         (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
1096         * accessibility/mac/AccessibilityObjectWrapper.mm:
1097         * bindings/objc/ExceptionHandlers.h:
1098         * css/CSSStyleSelector.cpp:
1099         * dom/ContainerNode.cpp:
1100         (WebCore::ContainerNode::cloneChildNodes):
1101         * dom/Document.cpp:
1102         * dom/InputElement.cpp:
1103         * editing/DeleteButtonController.cpp:
1104         * editing/EditCommand.cpp:
1105         * editing/EditingAllInOne.cpp:
1106         * editing/EditingStyle.cpp:
1107         * editing/Editor.cpp:
1108         (WebCore::Editor::canCopy):
1109         (WebCore::Editor::canDelete):
1110         (WebCore::Editor::markMisspellingsAfterTypingToWord):
1111         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
1112         (WebCore::Editor::changeSelectionAfterCommand):
1113         (WebCore::Editor::respondToChangedSelection):
1114         * editing/Editor.h:
1115         * editing/EditorCommand.cpp:
1116         (WebCore::executeDeleteToMark):
1117         (WebCore::executeMoveBackward):
1118         (WebCore::executeMoveBackwardAndModifySelection):
1119         (WebCore::executeMoveDown):
1120         (WebCore::executeMoveDownAndModifySelection):
1121         (WebCore::executeMoveForward):
1122         (WebCore::executeMoveForwardAndModifySelection):
1123         (WebCore::executeMoveLeft):
1124         (WebCore::executeMoveLeftAndModifySelection):
1125         (WebCore::executeMovePageDown):
1126         (WebCore::executeMovePageDownAndModifySelection):
1127         (WebCore::executeMovePageUp):
1128         (WebCore::executeMovePageUpAndModifySelection):
1129         (WebCore::executeMoveRight):
1130         (WebCore::executeMoveRightAndModifySelection):
1131         (WebCore::executeMoveToBeginningOfDocument):
1132         (WebCore::executeMoveToBeginningOfDocumentAndModifySelection):
1133         (WebCore::executeMoveToBeginningOfLine):
1134         (WebCore::executeMoveToBeginningOfLineAndModifySelection):
1135         (WebCore::executeMoveToBeginningOfParagraph):
1136         (WebCore::executeMoveToBeginningOfParagraphAndModifySelection):
1137         (WebCore::executeMoveToBeginningOfSentence):
1138         (WebCore::executeMoveToBeginningOfSentenceAndModifySelection):
1139         (WebCore::executeMoveToEndOfDocument):
1140         (WebCore::executeMoveToEndOfDocumentAndModifySelection):
1141         (WebCore::executeMoveToEndOfSentence):
1142         (WebCore::executeMoveToEndOfSentenceAndModifySelection):
1143         (WebCore::executeMoveToEndOfLine):
1144         (WebCore::executeMoveToEndOfLineAndModifySelection):
1145         (WebCore::executeMoveToEndOfParagraph):
1146         (WebCore::executeMoveToEndOfParagraphAndModifySelection):
1147         (WebCore::executeMoveParagraphBackwardAndModifySelection):
1148         (WebCore::executeMoveParagraphForwardAndModifySelection):
1149         (WebCore::executeMoveUp):
1150         (WebCore::executeMoveUpAndModifySelection):
1151         (WebCore::executeMoveWordBackward):
1152         (WebCore::executeMoveWordBackwardAndModifySelection):
1153         (WebCore::executeMoveWordForward):
1154         (WebCore::executeMoveWordForwardAndModifySelection):
1155         (WebCore::executeMoveWordLeft):
1156         (WebCore::executeMoveWordLeftAndModifySelection):
1157         (WebCore::executeMoveWordRight):
1158         (WebCore::executeMoveWordRightAndModifySelection):
1159         (WebCore::executeMoveToLeftEndOfLine):
1160         (WebCore::executeMoveToLeftEndOfLineAndModifySelection):
1161         (WebCore::executeMoveToRightEndOfLine):
1162         (WebCore::executeMoveToRightEndOfLineAndModifySelection):
1163         * editing/FrameSelection.cpp: Copied from Source/WebCore/editing/SelectionController.cpp.
1164         (WebCore::FrameSelection::FrameSelection):
1165         (WebCore::FrameSelection::moveTo):
1166         (WebCore::FrameSelection::setSelection):
1167         (WebCore::FrameSelection::nodeWillBeRemoved):
1168         (WebCore::FrameSelection::respondToNodeModification):
1169         (WebCore::FrameSelection::textWillBeReplaced):
1170         (WebCore::FrameSelection::setIsDirectional):
1171         (WebCore::FrameSelection::directionOfEnclosingBlock):
1172         (WebCore::FrameSelection::willBeModified):
1173         (WebCore::FrameSelection::positionForPlatform):
1174         (WebCore::FrameSelection::startForPlatform):
1175         (WebCore::FrameSelection::endForPlatform):
1176         (WebCore::FrameSelection::modifyExtendingRight):
1177         (WebCore::FrameSelection::modifyExtendingForward):
1178         (WebCore::FrameSelection::modifyMovingRight):
1179         (WebCore::FrameSelection::modifyMovingForward):
1180         (WebCore::FrameSelection::modifyExtendingLeft):
1181         (WebCore::FrameSelection::modifyExtendingBackward):
1182         (WebCore::FrameSelection::modifyMovingLeft):
1183         (WebCore::FrameSelection::modifyMovingBackward):
1184         (WebCore::FrameSelection::modify):
1185         (WebCore::FrameSelection::xPosForVerticalArrowNavigation):
1186         (WebCore::FrameSelection::clear):
1187         (WebCore::FrameSelection::setStart):
1188         (WebCore::FrameSelection::setEnd):
1189         (WebCore::FrameSelection::setBase):
1190         (WebCore::FrameSelection::setExtent):
1191         (WebCore::FrameSelection::setCaretRectNeedsUpdate):
1192         (WebCore::FrameSelection::updateCaretRect):
1193         (WebCore::FrameSelection::caretRenderer):
1194         (WebCore::FrameSelection::localCaretRect):
1195         (WebCore::FrameSelection::absoluteBoundsForLocalRect):
1196         (WebCore::FrameSelection::absoluteCaretBounds):
1197         (WebCore::FrameSelection::caretRepaintRect):
1198         (WebCore::FrameSelection::recomputeCaretRect):
1199         (WebCore::FrameSelection::shouldRepaintCaret):
1200         (WebCore::FrameSelection::invalidateCaretRect):
1201         (WebCore::FrameSelection::paintCaret):
1202         (WebCore::FrameSelection::debugRenderer):
1203         (WebCore::FrameSelection::contains):
1204         (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
1205         (WebCore::FrameSelection::selectAll):
1206         (WebCore::FrameSelection::setSelectedRange):
1207         (WebCore::FrameSelection::isInPasswordField):
1208         (WebCore::FrameSelection::caretRendersInsideNode):
1209         (WebCore::FrameSelection::focusedOrActiveStateChanged):
1210         (WebCore::FrameSelection::pageActivationChanged):
1211         (WebCore::FrameSelection::updateSecureKeyboardEntryIfActive):
1212         (WebCore::FrameSelection::setUseSecureKeyboardEntry):
1213         (WebCore::FrameSelection::setFocused):
1214         (WebCore::FrameSelection::isFocusedAndActive):
1215         (WebCore::FrameSelection::updateAppearance):
1216         (WebCore::FrameSelection::setCaretVisible):
1217         (WebCore::FrameSelection::clearCaretRectIfNeeded):
1218         (WebCore::FrameSelection::caretBlinkTimerFired):
1219         (WebCore::FrameSelection::notifyRendererOfSelectionChange):
1220         (WebCore::FrameSelection::setFocusedNodeIfNeeded):
1221         (WebCore::FrameSelection::paintDragCaret):
1222         (WebCore::FrameSelection::copyTypingStyle):
1223         (WebCore::FrameSelection::shouldDeleteSelection):
1224         (WebCore::FrameSelection::bounds):
1225         (WebCore::FrameSelection::getClippedVisibleTextRectangles):
1226         (WebCore::FrameSelection::currentForm):
1227         (WebCore::FrameSelection::revealSelection):
1228         (WebCore::FrameSelection::setSelectionFromNone):
1229         (WebCore::FrameSelection::shouldChangeSelection):
1230         (WebCore::FrameSelection::formatForDebugger):
1231         (WebCore::FrameSelection::showTreeForThis):
1232         (showTree):
1233         * editing/FrameSelection.h: Copied from Source/WebCore/editing/SelectionController.h.
1234         (WebCore::FrameSelection::typingStyle):
1235         (WebCore::FrameSelection::clearTypingStyle):
1236         (WebCore::FrameSelection::setTypingStyle):
1237         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
1238         * editing/ModifySelectionListLevel.cpp:
1239         * editing/RemoveFormatCommand.cpp:
1240         * editing/ReplaceSelectionCommand.cpp:
1241         * editing/SelectionController.cpp: Removed.
1242         * editing/SelectionController.h: Removed.
1243         * editing/SetSelectionCommand.cpp:
1244         (WebCore::SetSelectionCommand::SetSelectionCommand):
1245         (WebCore::SetSelectionCommand::doApply):
1246         (WebCore::SetSelectionCommand::doUnapply):
1247         * editing/SetSelectionCommand.h:
1248         (WebCore::SetSelectionCommand::create):
1249         * editing/SpellingCorrectionCommand.cpp:
1250         (WebCore::SpellingCorrectionCommand::doApply):
1251         * editing/SpellingCorrectionController.cpp:
1252         (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
1253         * editing/TypingCommand.cpp:
1254         (WebCore::TypingCommand::deleteKeyPressed):
1255         (WebCore::TypingCommand::forwardDeleteKeyPressed):
1256         * editing/chromium/FrameSelectionChromium.cpp: Copied from Source/WebCore/editing/chromium/SelectionControllerChromium.cpp.
1257         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
1258         * editing/chromium/SelectionControllerChromium.cpp: Removed.
1259         * editing/gtk/FrameSelectionGtk.cpp: Copied from Source/WebCore/editing/gtk/SelectionControllerGtk.cpp.
1260         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
1261         * editing/gtk/SelectionControllerGtk.cpp: Removed.
1262         * editing/mac/EditorMac.mm:
1263         (WebCore::Editor::canCopyExcludingStandaloneImages):
1264         * editing/mac/FrameSelectionMac.mm: Copied from Source/WebCore/editing/mac/SelectionControllerMac.mm.
1265         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
1266         * editing/mac/SelectionControllerMac.mm: Removed.
1267         * editing/qt/EditorQt.cpp:
1268         * loader/archive/cf/LegacyWebArchive.cpp:
1269         * page/ContextMenuController.cpp:
1270         (WebCore::ContextMenuController::populate):
1271         * page/DOMSelection.cpp:
1272         (WebCore::DOMSelection::type):
1273         (WebCore::DOMSelection::modify):
1274         (WebCore::DOMSelection::addRange):
1275         (WebCore::DOMSelection::deleteFromDocument):
1276         (WebCore::DOMSelection::containsNode):
1277         * page/DragController.cpp:
1278         (WebCore::DragController::dragIsMove):
1279         * page/DragController.h:
1280         * page/EventHandler.cpp:
1281         (WebCore::setSelectionIfNeeded):
1282         (WebCore::setNonDirectionalSelectionIfNeeded):
1283         (WebCore::EventHandler::sendContextMenuEventForKey):
1284         (WebCore::EventHandler::handleKeyboardSelectionMovement):
1285         * page/EventHandler.h:
1286         * page/FocusController.cpp:
1287         (WebCore::clearSelectionIfNeeded):
1288         * page/Frame.cpp:
1289         (WebCore::Frame::Frame):
1290         * page/Frame.h:
1291         (WebCore::Frame::selection):
1292         * page/Page.cpp:
1293         (WebCore::Page::Page):
1294         * page/Page.h:
1295         (WebCore::Page::dragCaretController):
1296         * page/chromium/DragControllerChromium.cpp:
1297         * page/chromium/EventHandlerChromium.cpp:
1298         * page/win/DragControllerWin.cpp:
1299         * page/win/EventHandlerWin.cpp:
1300         * rendering/HitTestResult.cpp:
1301         * rendering/RenderBlock.cpp:
1302         (WebCore::RenderBlock::destroy):
1303         (WebCore::RenderBlock::paintCaret):
1304         * rendering/RenderImage.cpp:
1305         * rendering/RenderInline.cpp:
1306         (WebCore::RenderInline::destroy):
1307         * rendering/RenderLayer.cpp:
1308         * rendering/RenderListBox.cpp:
1309         * rendering/RenderObjectChildList.cpp:
1310         (WebCore::RenderObjectChildList::removeChildNode):
1311         * rendering/RenderTextControl.cpp:
1312         * rendering/RenderTextControlSingleLine.cpp:
1313         * rendering/RenderTheme.cpp:
1314         * rendering/RenderTreeAsText.cpp:
1315         * svg/SVGSVGElement.cpp:
1316         * svg/SVGTextContentElement.cpp:
1317         (WebCore::SVGTextContentElement::selectSubString):
1318
1319 2011-05-05  Brent Fulgham  <bfulgham@webkit.org>
1320
1321         [WinCairo] unreviewed build correction.
1322
1323         * platform/network/curl/ResourceRequest.h:
1324         Stub out the new pipelined http logic for cURL.
1325
1326 2011-05-05  Pavel Feldman  <pfeldman@chromium.org>
1327
1328         Reviewed by Yury Semikhatsky.
1329
1330         Web Inspector: searching for node does not result in bringToFront call.
1331         https://bugs.webkit.org/show_bug.cgi?id=60222
1332
1333         * inspector/front-end/ElementsPanel.js:
1334         (WebInspector.ElementsPanel.prototype.updateFocusedNode):
1335
1336 2011-05-05  Andreas Kling  <andreas.kling@nokia.com>
1337
1338         Reviewed by Simon Hausmann.
1339
1340         [Qt] Implement the fast font path for Qt.
1341         https://bugs.webkit.org/show_bug.cgi?id=51106
1342
1343         Use the new QRawFont and QGlyphs APIs in Qt 4.8 to implement the fast paths for
1344         rendering and measurement of simple text.
1345
1346         Since this is still unreleased API, it's guarded by HAVE(QRAWFONT) until the new
1347         classes are fully integrated into the Qt 4.8 release branch.
1348
1349         * WebCore.pro: Add HAVE_QRAWFONT define (for Qt >= 4.8) and new files to build.
1350
1351         * platform/graphics/Font.cpp:
1352         (WebCore::Font::drawText): Disable fast font path for stroked text, and when
1353         painting text with a shadow. (Qt-only)
1354         (WebCore::Font::codePath): Try to use fast font path in more cases.
1355
1356         * platform/graphics/qt/FontCacheQt.cpp:
1357         (WebCore::rawFontForCharacters): Helper function, returns a suitable QRawFont
1358         to use for rendering a given string. Goes through QTextLayout to find the best
1359         font based on the original QFont query.
1360         (WebCore::FontCache::getFontDataForCharacters): Implemented using helper above.
1361
1362         * platform/graphics/qt/FontPlatformData.h:
1363         (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
1364         (WebCore::FontPlatformData::FontPlatformData):
1365         (WebCore::FontPlatformData::rawFont):
1366         * platform/graphics/qt/FontPlatformDataQt.cpp:
1367         (WebCore::FontPlatformData::FontPlatformData): Add a QRawFont member to FontPlatformData.
1368
1369         * platform/graphics/qt/FontQt.cpp:
1370         (WebCore::fillPenForContext):
1371         (WebCore::strokePenForContext):
1372         (WebCore::drawTextCommon): Factored QPen creation out of drawTextCommon
1373         to share code between complex and simple font rendering paths.
1374         (WebCore::Font::drawGlyphs): Implemented using QPainter::drawGlyphs().
1375
1376         * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
1377         (WebCore::GlyphPage::fill): Implemented using QRawFont::glyphIndexesForString().
1378
1379         * platform/graphics/qt/SimpleFontDataQt.cpp:
1380         (WebCore::SimpleFontData::determinePitch): Return false when using QRawFont since we
1381         have no way of knowing the pitch.
1382         (WebCore::SimpleFontData::containsCharacters): Implemented using QRawFont::supportsCharacter().
1383         (WebCore::SimpleFontData::platformWidthForGlyph): Implemented using QRawFont::advancesForGlyphIndexes().
1384         (WebCore::SimpleFontData::scaledFontData): Added, based on other ports.
1385         (WebCore::SimpleFontData::smallCapsFontData): Ditto.
1386         (WebCore::SimpleFontData::emphasisMarkFontData): Ditto.
1387         (WebCore::SimpleFontData::platformBoundsForGlyph): Stub.
1388         (WebCore::SimpleFontData::platformInit): Use QRawFont APIs to retrieve font metrics.
1389         (WebCore::SimpleFontData::platformCharWidthInit): Ditto.
1390
1391 2011-05-05  Alexis Menard  <alexis.menard@openbossa.org>
1392
1393         Reviewed by Andreas Kling.
1394
1395         [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
1396         https://bugs.webkit.org/show_bug.cgi?id=60224
1397
1398         We should use nullptr rather than 0. nullptr will be added in the new C++ standard
1399         but WebKit already has a nullptr class if there is no c++0x support.
1400
1401         * platform/qt/RenderThemeQt.cpp:
1402         (WebCore::RenderThemeQt::adjustProgressBarStyle):
1403         (WebCore::RenderThemeQt::adjustSliderTrackStyle):
1404         (WebCore::RenderThemeQt::adjustSliderThumbStyle):
1405
1406 2011-05-05  Ilya Tikhonovsky  <loislo@chromium.org>
1407
1408         Reviewed by Yury Semikhatsky.
1409
1410         Web Inspector: rename BrowserDebugger to DOMDebugger.
1411
1412         https://bugs.webkit.org/show_bug.cgi?id=60256
1413         InspectorBrowserDebuggerAgent => InspectorDOMDebuggerAgent
1414         browserDebugger => domDebugger
1415
1416         * CMakeLists.txt:
1417         * GNUmakefile.list.am:
1418         * WebCore.gypi:
1419         * WebCore.pro:
1420         * WebCore.vcproj/WebCore.vcproj:
1421         * WebCore.xcodeproj/project.pbxproj:
1422         * inspector/CodeGeneratorInspector.pm:
1423         * inspector/InspectorAgent.cpp:
1424         (WebCore::InspectorAgent::InspectorAgent):
1425         (WebCore::InspectorAgent::inspectedPageDestroyed):
1426         (WebCore::InspectorAgent::disconnectFrontend):
1427         * inspector/InspectorAgent.h:
1428         (WebCore::InspectorAgent::DOMDebuggerAgent):
1429         * inspector/InspectorController.cpp:
1430         (WebCore::InspectorController::connectFrontend):
1431         * inspector/InspectorDOMDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp.
1432         (WebCore::InspectorDOMDebuggerAgent::create):
1433         (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
1434         (WebCore::InspectorDOMDebuggerAgent::~InspectorDOMDebuggerAgent):
1435         (WebCore::InspectorDOMDebuggerAgent::debuggerWasEnabled):
1436         (WebCore::InspectorDOMDebuggerAgent::debuggerWasDisabled):
1437         (WebCore::InspectorDOMDebuggerAgent::disable):
1438         (WebCore::InspectorDOMDebuggerAgent::clearFrontend):
1439         (WebCore::InspectorDOMDebuggerAgent::discardBindings):
1440         (WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
1441         (WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
1442         (WebCore::InspectorDOMDebuggerAgent::didInsertDOMNode):
1443         (WebCore::InspectorDOMDebuggerAgent::didRemoveDOMNode):
1444         (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
1445         (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
1446         (WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
1447         (WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
1448         (WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
1449         (WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
1450         (WebCore::InspectorDOMDebuggerAgent::hasBreakpoint):
1451         (WebCore::InspectorDOMDebuggerAgent::updateSubtreeBreakpoints):
1452         (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
1453         (WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
1454         (WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
1455         (WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
1456         (WebCore::InspectorDOMDebuggerAgent::clear):
1457         * inspector/InspectorDOMDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h.
1458         * inspector/InspectorInstrumentation.cpp:
1459         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
1460         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
1461         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
1462         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
1463         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
1464         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
1465         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
1466         * inspector/InstrumentingAgents.h:
1467         (WebCore::InstrumentingAgents::InstrumentingAgents):
1468         (WebCore::InstrumentingAgents::inspectorDOMDebuggerAgent):
1469         (WebCore::InstrumentingAgents::setInspectorDOMDebuggerAgent):
1470         * inspector/WorkerInspectorController.cpp:
1471         (WebCore::WorkerInspectorController::connectFrontend):
1472
1473 2011-05-04  Yury Semikhatsky  <yurys@chromium.org>
1474
1475         Reviewed by Pavel Feldman.
1476
1477         Web Inspector: show only Console and Scripts panels in worker inspector front-end
1478         https://bugs.webkit.org/show_bug.cgi?id=60159
1479
1480         * inspector/front-end/WorkerManager.js:
1481         (WebInspector.WorkerManager.isWorkerFrontend):
1482         * inspector/front-end/inspector.js: show only Scripts and Console panels in the worker inspector front-end.
1483
1484 2011-05-03  Hans Wennborg  <hans@chromium.org>
1485
1486         Reviewed by Steve Block.
1487
1488         IndexedDB: Unit tests for LevelDB key coding functions
1489         https://bugs.webkit.org/show_bug.cgi?id=59692
1490
1491         Fix some embarrassing bugs uncovered by unit tests.
1492
1493         No new functionality, but this is now covered by unit tests in the Chromium WebKit port.
1494
1495         * storage/IDBLevelDBCoding.cpp:
1496         (WebCore::IDBLevelDBCoding::decodeInt):
1497         (WebCore::IDBLevelDBCoding::decodeVarInt):
1498
1499 2011-05-05  Young Han Lee  <joybro@company100.net>
1500
1501         Reviewed by Csaba Osztrogonác.
1502
1503         [Texmap][Qt] Enable strict OwnPtr for Qt with texmap enabled.
1504         https://bugs.webkit.org/show_bug.cgi?id=60251
1505
1506         No new tests. Build fix.
1507
1508         * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
1509         (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
1510
1511 2011-05-04  Jay Civelli  <jcivelli@chromium.org>
1512
1513         Reviewed by Adam Barth.
1514
1515         Adding a utility class to read a SharedBuffer line by line.
1516         https://bugs.webkit.org/show_bug.cgi?id=59946
1517
1518         * CMakeLists.txt:
1519         * GNUmakefile.list.am:
1520         * WebCore.gypi:
1521         * WebCore.pro:
1522         * WebCore.vcproj/WebCore.vcproj:
1523         * WebCore.xcodeproj/project.pbxproj:
1524         * platform/SharedBufferCRLFLineReader.cpp: Added.
1525         * platform/SharedBufferCRLFLineReader.h: Added.
1526
1527 2011-05-04  Sheriff Bot  <webkit.review.bot@gmail.com>
1528
1529         Unreviewed, rolling out r85788.
1530         http://trac.webkit.org/changeset/85788
1531         https://bugs.webkit.org/show_bug.cgi?id=60250
1532
1533         svg/text/text-block-child-crash.xhtml asserts (Requested by
1534         Ossy on #webkit).
1535
1536         * css/CSSStyleSelector.cpp:
1537         (WebCore::CSSStyleSelector::applyProperty):
1538
1539 2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>
1540
1541         Reviewed by Eric Seidel.
1542
1543         Make more member functions in EventHandler private
1544         https://bugs.webkit.org/show_bug.cgi?id=60200
1545
1546         Reduced the number of public member functions in EventHandler.
1547
1548         * WebCore.exp.in:
1549         * page/EventHandler.cpp:
1550         (WebCore::EventHandler::handleAutoscroll):
1551         (WebCore::EventHandler::autoscrollTimerFired):
1552         (WebCore::EventHandler::stopAutoscrollTimer):
1553         (WebCore::EventHandler::handleMousePressEvent):
1554         (WebCore::EventHandler::handleMouseMoveEvent):
1555         (WebCore::EventHandler::keyEvent):
1556         (WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):
1557         * page/EventHandler.h:
1558         (WebCore::EventHandler::mouseDownMayStartSelect):
1559
1560 2011-05-04  James Robinson  <jamesr@chromium.org>
1561
1562         Reviewed by Kenneth Russell.
1563
1564         [chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
1565         https://bugs.webkit.org/show_bug.cgi?id=60202
1566
1567         In r85136 I accidentally transposed two lines in GraphicsLayerChromium when adding a null check.  This switches
1568         the order back and adds a regression test.
1569
1570         Test: compositing/repaint/transform-style-change.html
1571
1572         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1573         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1574
1575 2011-05-04  Cris Neckar  <cdn@chromium.org>
1576
1577         Reviewed by Adam Barth.
1578
1579         Expose WebView directly through ChromeClient.
1580         https://bugs.webkit.org/show_bug.cgi?id=49902
1581
1582         Test: fast/media/media-svg-crash.html
1583
1584         * loader/EmptyClients.h:
1585         (WebCore::EmptyChromeClient::webView):
1586         * page/ChromeClient.h:
1587         * page/brew/ChromeClientBrew.h:
1588         (WebCore::ChromeClientBrew::webView):
1589
1590 2011-05-04  Joseph Pecoraro  <joepeck@webkit.org>
1591
1592         Reviewed by Darin Adler.
1593
1594         Unable to Paste After Deleting Text from Input due to -webkit-user-select
1595         https://bugs.webkit.org/show_bug.cgi?id=60219
1596
1597         When deleting all the text inside the input a placeholder <br>
1598         element was inserted for the selection point. However, when
1599         pasting, the test run computes the -webkit-user-select for the
1600         <br> element, instead of what would be the text inside the
1601         <input> and incorrectly disallows selection and prevented
1602         the paste.
1603
1604         Test: editing/pasteboard/paste-placeholder-input.html
1605
1606         * editing/ReplaceSelectionCommand.cpp:
1607         (WebCore::ReplacementFragment::insertFragmentForTestRendering): skip
1608         <br> elements above us as those are likely placeholder elements.
1609
1610 2011-05-04  Fridrich Strba  <fridrich.strba@bluewin.ch>
1611
1612         Reviewed by Martin Robinson.
1613
1614         Windows build of WebKit GTK needs to be able to find SystemInfo.h
1615         https://bugs.webkit.org/show_bug.cgi?id=60221
1616
1617         * GNUmakefile.am: add Source/WebCore/platform/win to the paths searched
1618         for headers, since Source/WebCore/platform/win/SystemInfo.h
1619         header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp
1620         on Windows.
1621
1622 2011-05-04  Vangelis Kokkevis  <vangelis@chromium.org>
1623
1624         Reviewed by Kenneth Russell.
1625
1626         [chromium] Improve sorting of layers in hierarchies that preserve-3d
1627         by testing for overlapping regions between layer pairs and doing a
1628         topological sort to determine the right order.
1629         https://bugs.webkit.org/show_bug.cgi?id=59255
1630
1631         Test: platform/chromium/compositing/perpendicular-layer-sorting.html
1632
1633         * WebCore.gypi:
1634         * platform/graphics/chromium/LayerRendererChromium.cpp:
1635         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1636         * platform/graphics/chromium/LayerRendererChromium.h:
1637         * platform/graphics/chromium/cc/CCLayerImpl.h:
1638         (WebCore::CCLayerImpl::clearRenderSurface):
1639         * platform/graphics/chromium/cc/CCLayerSorter.cpp: Added.
1640         (WebCore::perpProduct):
1641         (WebCore::innerProduct):
1642         (WebCore::pointInColinearEdge):
1643         (WebCore::edgeEdgeTest):
1644         (WebCore::CCLayerSorter::LayerIntersector::LayerIntersector):
1645         (WebCore::CCLayerSorter::LayerIntersector::go):
1646         (WebCore::CCLayerSorter::LayerIntersector::edgeTriangleTest):
1647         (WebCore::CCLayerSorter::LayerIntersector::triangleTriangleTest):
1648         (WebCore::CCLayerSorter::LayerIntersector::checkZDiff):
1649         (WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint):
1650         (WebCore::CCLayerSorter::CCLayerSorter):
1651         (WebCore::CCLayerSorter::checkOverlap):
1652         (WebCore::CCLayerSorter::createGraphNodes):
1653         (WebCore::CCLayerSorter::createGraphEdges):
1654         (WebCore::CCLayerSorter::removeEdgeFromList):
1655         (WebCore::CCLayerSorter::sort):
1656         * platform/graphics/chromium/cc/CCLayerSorter.h: Added.
1657         (WebCore::CCLayerSorter::GraphNode::GraphNode):
1658         (WebCore::CCLayerSorter::GraphEdge::GraphEdge):
1659
1660 2011-05-03  Jer Noble  <jer.noble@apple.com>
1661
1662         Reviewed by Antti Koivisto.
1663
1664         Safari: Video at apple.com cannot play at full screen mode with layout distortion
1665         https://bugs.webkit.org/show_bug.cgi?id=60140
1666
1667         Because a fullscreen element may be in a stacking context with a lower z-index than
1668         a sibling stacking context, those higher contexts would sometimes "pop" through the 
1669         full screen renderer. To facilitate eliminating all the stacking contexts aside from
1670         the full screen renderer, added a new pseudo-class specific to video or audio full
1671         screen elements. Then, added a new UA rule which resets the z-index and opacities of 
1672         all elements under said pseudo-class to auto and 1 respectively. To facilitate quick
1673         identity checking of HTMLMediaElements, added isMediaElement() virtual function to 
1674         Element and HTMLMediaElement. 
1675
1676         Test: fullscreen/full-screen-stacking-context.html
1677
1678         * css/CSSSelector.cpp:
1679         (WebCore::CSSSelector::pseudoId): Support PseudoFullScreenMediaDocument.
1680         (WebCore::nameToPseudoTypeMap): Support fullScreenMediaDocument.
1681         (WebCore::CSSSelector::extractPseudoType): Support PseudoFullScreenMediaDocument.
1682         * css/CSSSelector.h: Add PseudoFullScreenMediaDocument.
1683         * css/CSSStyleSelector.cpp:
1684         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Support PseudoFullScreenMediaDocument.
1685         * css/fullscreen.css:
1686         (:root:-webkit-full-screen-document:not(:-webkit-full-screen)): Corrected these names, 
1687             which were missing the -webkit prefix.
1688         (:root:-webkit-full-screen-media-document *:not(-webkit-full-screen)): Added.
1689         * dom/Element.h:
1690         (WebCore::Element::isMediaElement): Added, returns false.
1691         * html/HTMLMediaElement.h:
1692         (WebCore::HTMLMediaElement::isMediaElement): Added, returns true.
1693         * rendering/style/RenderStyleConstants.h: Added FULL_SCREEN_MEDIA_DOCUMENT.
1694
1695 2011-05-04  Levi Weintraub  <leviw@chromium.org>
1696
1697         Reviewed by Eric Seidel.
1698
1699         Split findNextLineBreak into a LineBreaker class
1700         https://bugs.webkit.org/show_bug.cgi?id=60209
1701
1702         Breaking findNextLineBreak into a new class inside RenderBlock. Currently it's tracking
1703         nearly no state, but subsequent patches will move some of the local variables used throughout
1704         the nextLineBreak function into member variables to simplify breaking off helper functions from
1705         the bloated function.
1706
1707         No new tests since this is just moving code around.
1708
1709         * WebCore.xcodeproj/project.pbxproj:
1710         * rendering/RenderBlock.h:
1711         (WebCore::RenderBlock::LineBreaker::LineBreaker):
1712         (WebCore::RenderBlock::LineBreaker::lineWasHyphenated): Accessor.
1713         (WebCore::RenderBlock::LineBreaker::positionedObjects): Ditto.
1714         (WebCore::RenderBlock::LineBreaker::clear): Ditto.
1715         * rendering/RenderBlockLineLayout.cpp:
1716         (WebCore::RenderBlock::layoutRunsAndFloats):
1717         (WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace):
1718         (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
1719         (WebCore::RenderBlock::LineBreaker::reset):
1720         (WebCore::RenderBlock::LineBreaker::nextLineBreak):
1721
1722 2011-05-04  Fridrich Strba  <fridrich.strba@bluewin.ch>
1723
1724         Reviewed by Adam Barth.
1725
1726         Add COMPILER(MINGW) to the compilers using the Microsoft C Runtime's vsnprintf.
1727         The vsnprintf is part of Microsoft C runtime used also by MinGW (GCC) toolchain.
1728         https://bugs.webkit.org/show_bug.cgi?id=58579
1729
1730         * dom/XMLDocumentParserLibxml2.cpp:
1731         (WebCore::XMLDocumentParser::error):
1732
1733 2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>
1734
1735         Unreviewed warning fix.
1736
1737         The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
1738         a warning in Release build.
1739
1740         * dom/Node.cpp:
1741         (WebCore::Node::removeEventListener):
1742         * platform/DateComponents.cpp:
1743         (WebCore::DateComponents::parseTime):
1744         * rendering/RenderLayer.cpp:
1745         (WebCore::RenderLayer::convertToLayerCoords):
1746         * storage/StorageMap.cpp:
1747         (WebCore::StorageMap::importItem):
1748         * svg/SVGUseElement.cpp:
1749         (WebCore::SVGUseElement::buildShadowTree):
1750         (WebCore::SVGUseElement::expandUseElementsInShadowTree):
1751
1752 2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>
1753
1754         Unreviewed warning fix.
1755
1756         The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
1757         a warning in Release build.
1758
1759         * accessibility/AccessibilityRenderObject.cpp:
1760         (WebCore::lastChildConsideringContinuation):
1761
1762 2011-05-04  Dimitri Glazkov  <dglazkov@chromium.org>
1763
1764         Sort xcodeproj files.
1765
1766         The WebCore.xcodeproj got out of sorts again.
1767
1768         * WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
1769
1770 2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>
1771
1772         Reviewed by Adam Barth.
1773
1774         Warning fix.
1775
1776         * bindings/js/DOMObjectHashTableMap.h:
1777         (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
1778
1779 2011-05-04  Rob Buis  <rbuis@rim.com>
1780
1781         Reviewed by Darin Adler.
1782
1783         NULL deref when SVG elements have table styles 
1784         https://bugs.webkit.org/show_bug.cgi?id=45561
1785
1786         Restrict computed CSS values for SVG display property to block, inline or none.
1787
1788         Tests: svg/custom/display-table-caption-foreignObject.svg
1789                svg/custom/display-table-caption-inherit-foreignObject.xhtml
1790                svg/custom/display-table-caption-inherit-text.xhtml
1791                svg/custom/display-table-caption-text.svg
1792
1793         * css/CSSStyleSelector.cpp:
1794         (WebCore::CSSStyleSelector::applyProperty):
1795
1796 2011-05-04  Tao Bai  <michaelbai@chromium.org>
1797
1798         Reviewed by David Kilzer.
1799
1800         Populate touch-icon url to FrameLoaderClient
1801         https://bugs.webkit.org/show_bug.cgi?id=59143
1802         
1803         Parsed and populated apple-touch-icon url to FrameLoaderClient.
1804         Changed favicon to be a type of icon.
1805
1806         * CMakeLists.txt:
1807         * Configurations/FeatureDefines.xcconfig:
1808         * GNUmakefile.am:
1809         * GNUmakefile.list.am:
1810         * WebCore.gypi:
1811         * WebCore.vcproj/WebCore.vcproj:
1812         * WebCore.xcodeproj/project.pbxproj:
1813         * dom/Document.cpp:
1814         (WebCore::Document::iconURL):
1815         (WebCore::Document::setIconURL):
1816         * dom/Document.h:
1817         * dom/IconURL.cpp: Added.
1818         (WebCore::toIconIndex):
1819         * dom/IconURL.h: Added.
1820         (WebCore::IconURL::IconURL):
1821         * features.pri:
1822         * html/HTMLLinkElement.cpp:
1823         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
1824         (WebCore::HTMLLinkElement::process):
1825         (WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
1826         * html/HTMLLinkElement.h:
1827         (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
1828         (WebCore::HTMLLinkElement::isEnabledViaScript):
1829         * html/parser/HTMLPreloadScanner.cpp:
1830         (WebCore::HTMLNames::PreloadTask::relAttributeIsStyleSheet):
1831         * loader/DocumentLoader.cpp:
1832         (WebCore::DocumentLoader::iconURL):
1833         (WebCore::DocumentLoader::setIconURL):
1834         * loader/DocumentLoader.h:
1835         * loader/EmptyClients.h:
1836         (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
1837         * loader/FrameLoader.cpp:
1838         (WebCore::FrameLoader::iconURL):
1839         (WebCore::FrameLoader::iconURLs):
1840         (WebCore::FrameLoader::fillIconURL):
1841         (WebCore::FrameLoader::getDefaultIconURL):
1842         (WebCore::FrameLoader::setIconURL):
1843         (WebCore::FrameLoader::didChangeIcons):
1844         * loader/FrameLoader.h:
1845         * loader/FrameLoaderClient.h:
1846
1847 2011-05-04  Chris Marrin  <cmarrin@apple.com>
1848
1849         Reviewed by Simon Fraser.
1850
1851         Crash in PlatformCALayer ::replaceSublayer when layer has not superlayer
1852         https://bugs.webkit.org/show_bug.cgi?id=60191
1853
1854         Skip replaceSublayer when there is no superlayer rather than asserting.
1855         This is probably not a problem and happens when restructuring the layer
1856         tree. Avoiding this crash will allow us to get more testing.
1857
1858         * platform/graphics/ca/GraphicsLayerCA.cpp:
1859         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
1860
1861 2011-05-04  Martin Robinson  <mrobinson@igalia.com>
1862
1863         Reviewed by Gustavo Noronha Silva.
1864
1865         Fix the GTK+ 2.x build for Windows. Instead of making getStockIcon a RenderTheme
1866         method, just use extern declarations to avoid having to declare it in the header.
1867         This will prevent having to include glib.h in RenderThemeGtk.h, which is included
1868         in many C++ files.
1869
1870         No new tests. This is just a build fix.
1871
1872         * platform/gtk/RenderThemeGtk.cpp: Update getStockIcon calls to say getStockIconForWidgetType.
1873         (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
1874         (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
1875         (WebCore::RenderThemeGtk::paintCapsLockIndicator):
1876         (WebCore::RenderThemeGtk::paintMediaButton):
1877         * platform/gtk/RenderThemeGtk.h: Removed getStockIcon declaration. Make gtkContainer() and
1878         gtkEntry() public because they are now accessed externally from getStockIcon().
1879         * platform/gtk/RenderThemeGtk2.cpp: Update getStockIcon calls.
1880         (WebCore::getStockIconForWidgetType):
1881         * platform/gtk/RenderThemeGtk3.cpp: Ditto.
1882         (WebCore::getStockIconForWidgetType):
1883
1884 2011-05-04  Mark Pilgrim  <pilgrim@chromium.org>
1885
1886         Reviewed by Tony Chang.
1887
1888         IndexedDB open (database) should fail if name is null
1889         https://bugs.webkit.org/show_bug.cgi?id=60022
1890
1891         Test: storage/indexeddb/mozilla/open-database-null-name.html
1892
1893         Combination problem: Bug in IDL didn't pass null values to .cpp layer,
1894         then .cpp layer didn't check for null value anyway.
1895
1896         * storage/IDBFactory.cpp:
1897         (WebCore::IDBFactory::open): check for null name
1898         * storage/IDBFactory.idl: pass null name as null
1899
1900 2011-05-04  Jer Noble  <jer.noble@apple.com>
1901
1902         Reviewed by Darin Adler.
1903
1904         Entering full screen fails >= second time on Vimeo.com.
1905         https://bugs.webkit.org/show_bug.cgi?id=60143
1906
1907         Force the RenderFullScreen's layer backing to be recreated when setAnimating() is called.
1908         Previously, the RenderLayerCompositor would fail to reparent the RenderFullScreen's layer
1909         at the end of an animation, if it determined that the RenderFullScreen would still require
1910         a layer even when not animating.
1911
1912         * rendering/RenderFullScreen.cpp:
1913         (RenderFullScreen::setAnimating): Clear the renderer's layer.
1914
1915 2011-05-04  Simon Fraser  <simon.fraser@apple.com>
1916
1917         Reviewed by Darin Adler.
1918
1919         Avoid allocating a new image buffer in ~CanvasRenderingContext2D()
1920         https://bugs.webkit.org/show_bug.cgi?id=59849
1921
1922         When attempting to unwind the graphics state stack in the
1923         CanvasRenderingContext2D destructor, don't allow HTMLCanvasElement
1924         to create a new ImageBuffer.
1925
1926         * html/HTMLCanvasElement.cpp:
1927         (WebCore::HTMLCanvasElement::existingDrawingContext):
1928         * html/HTMLCanvasElement.h:
1929         * html/canvas/CanvasRenderingContext2D.cpp:
1930         (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
1931
1932 2011-05-04  Andrey Kosyakov  <caseq@chromium.org>
1933
1934         Reviewed by Yury Semikhatsky.
1935
1936         Web Inspector: expose shadow DOM in the Elements panel
1937         https://bugs.webkit.org/show_bug.cgi?id=60160
1938
1939         Test: inspector/elements/shadow-dom.html
1940
1941         * dom/Element.cpp:
1942         (WebCore::Element::ensureShadowRoot):
1943         (WebCore::Element::removeShadowRoot):
1944         * inspector/Inspector.json:
1945         * inspector/InspectorDOMAgent.cpp:
1946         (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
1947         (WebCore::InspectorDOMAgent::buildObjectForNode):
1948         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1949         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1950         (WebCore::InspectorDOMAgent::isContainerNode):
1951         * inspector/InspectorDOMAgent.h:
1952         * inspector/front-end/DOMAgent.js:
1953         (WebInspector.DOMNode):
1954         (WebInspector.DOMNode.prototype.inShadowTree):
1955         (WebInspector.DOMNode.prototype._setShadowRootPayload):
1956         (WebInspector.DOMNode.prototype._renumber):
1957         (WebInspector.DOMAgent.prototype._bindNodes):
1958         (WebInspector.DOMAgent.prototype.querySelectorAll):
1959         (WebInspector.DOMAgent.prototype._shadowRootUpdated):
1960         (WebInspector.DOMDispatcher.prototype.searchResults):
1961         (WebInspector.DOMDispatcher.prototype.shadowRootUpdated):
1962         * inspector/front-end/ElementsPanel.js:
1963         (WebInspector.ElementsPanel):
1964         (WebInspector.ElementsPanel.prototype._nodeUpdated):
1965         (WebInspector.ElementsPanel.prototype._attributesUpdated):
1966         (WebInspector.ElementsPanel.prototype._nodeRemoved):
1967         (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
1968         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
1969         * inspector/front-end/ElementsTreeOutline.js:
1970         (WebInspector.ElementsTreeElement):
1971         (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
1972         (WebInspector.ElementsTreeElement.prototype._updateChildren):
1973         ():
1974         * inspector/front-end/inspector.css:
1975         (#elements-content .dom-shadow-root):
1976         (.outline-disclosure li .webkit-html-tag.shadow):
1977         * inspector/front-end/utilities.js:
1978
1979 2011-05-03  Adam Roben  <aroben@apple.com>
1980
1981         Remove an unnecessary OwnPtr equality check in XSLT code
1982
1983         Fixes <http://webkit.org/b/60053> Testing OwnPtrs for equality should cause a compiler error
1984
1985         Reviewed by Anders Carlsson and Antti Koivisto.
1986
1987         * dom/Document.cpp:
1988         (WebCore::Document::setTransformSource): No need to check for equality. If the pointers are
1989         equal, we're screwed anyway. (And the caller always passes in a newly-allocated object, so
1990         we're safe.)
1991
1992 2011-05-04  Leandro Gracia Gil  <leandrogracia@chromium.org>
1993
1994         Reviewed by Tony Gentilcore.
1995
1996         Media Stream API: add the skeleton of the frame and page controllers and the embedder client.
1997         https://bugs.webkit.org/show_bug.cgi?id=56922
1998
1999         Add the basic outlines of the page controller, the per-frame controller and the embedder
2000         client interface for the Media Stream API. Provide methods to handle the situations
2001         where a frame is detached from the page or transferred between pages.
2002
2003         Tests for the Media Stream API will be provided by the bug 56587.
2004
2005         * CMakeLists.txt:
2006         * GNUmakefile.list.am:
2007         * WebCore.gypi:
2008         * WebCore.pro:
2009         * WebCore.vcproj/WebCore.vcproj:
2010         * WebCore.xcodeproj/project.pbxproj:
2011         * page/Frame.cpp:
2012         (WebCore::Frame::Frame):
2013         (WebCore::Frame::~Frame):
2014         (WebCore::Frame::pageDestroyed):
2015         (WebCore::Frame::transferChildFrameToNewDocument):
2016         * page/Frame.h:
2017         (WebCore::Frame::mediaStreamFrameController):
2018         * page/MediaStreamClient.h: Added.
2019         (WebCore::MediaStreamClient::~MediaStreamClient):
2020         * page/MediaStreamController.cpp: Added.
2021         (WebCore::MediaStreamController::Request::Request):
2022         (WebCore::MediaStreamController::Request::localId):
2023         (WebCore::MediaStreamController::Request::frameController):
2024         (WebCore::MediaStreamController::MediaStreamController):
2025         (WebCore::MediaStreamController::~MediaStreamController):
2026         (WebCore::MediaStreamController::unregisterFrameController):
2027         (WebCore::MediaStreamController::registerRequest):
2028         * page/MediaStreamController.h: Added.
2029         * page/MediaStreamFrameController.cpp: Added.
2030         (WebCore::MediaStreamFrameController::Request::Request):
2031         (WebCore::MediaStreamFrameController::Request::~Request):
2032         (WebCore::MediaStreamFrameController::Request::scriptExecutionContext):
2033         (WebCore::MediaStreamFrameController::Request::isGenerateStreamRequest):
2034         (WebCore::MediaStreamFrameController::Request::isRecordedDataRequest):
2035         (WebCore::MediaStreamFrameController::RequestMap::abort):
2036         (WebCore::MediaStreamFrameController::RequestMap::abortAll):
2037         (WebCore::MediaStreamFrameController::MediaStreamFrameController):
2038         (WebCore::MediaStreamFrameController::~MediaStreamFrameController):
2039         (WebCore::MediaStreamFrameController::securityOrigin):
2040         (WebCore::MediaStreamFrameController::scriptExecutionContext):
2041         (WebCore::MediaStreamFrameController::pageController):
2042         (WebCore::MediaStreamFrameController::enterDetachedState):
2043         (WebCore::MediaStreamFrameController::disconnectPage):
2044         (WebCore::MediaStreamFrameController::disconnectFrame):
2045         (WebCore::MediaStreamFrameController::transferToNewPage):
2046         * page/MediaStreamFrameController.h: Added.
2047         * page/Page.cpp:
2048         (WebCore::Page::Page):
2049         (WebCore::Page::PageClients::PageClients):
2050         * page/Page.h:
2051         (WebCore::Page::mediaStreamController):
2052
2053 2011-05-04  Alexander Pavlov  <apavlov@chromium.org>
2054
2055         Reviewed by Yury Semikhatsky.
2056
2057         Web Inspector: Double-click in a read-only style rule results in a non-editable blank property
2058         https://bugs.webkit.org/show_bug.cgi?id=60150
2059
2060         * inspector/front-end/StylesSidebarPane.js:
2061         (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):
2062
2063 2011-05-04  Dominic Battre  <battre@chromium.org>
2064
2065         Reviewed by Tony Gentilcore.
2066
2067         Fix missing header in case SVG is disabled
2068         https://bugs.webkit.org/show_bug.cgi?id=60153
2069
2070         * dom/EventDispatcher.cpp:
2071
2072 2011-05-04  Luke Macpherson   <macpherson@chromium.org>
2073
2074         Reviewed by Eric Seidel.
2075
2076         Rename CSSStyleApplyProperty::propertyValue and setPropertyValue.
2077         https://bugs.webkit.org/show_bug.cgi?id=60006
2078
2079         No new tests as no functionality added. Simple rename only.
2080
2081         * css/CSSStyleApplyProperty.cpp:
2082         Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
2083         * css/CSSStyleApplyProperty.h:
2084         Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
2085
2086 2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>
2087
2088         Reviewed by Eric Seidel.
2089
2090         Cleanup conditionals in findNextLineBreak
2091         https://bugs.webkit.org/show_bug.cgi?id=60117
2092
2093         Simplified conditional statements in findNextLineBreak.
2094
2095         * rendering/RenderBlockLineLayout.cpp:
2096         (WebCore::RenderBlock::findNextLineBreak):
2097
2098 2011-05-04  Luke Macpherson   <macpherson@chromium.org>
2099
2100         Reviewed by Eric Seidel.
2101
2102         Make CSSStyleSelector::applyProperty() CSSPropertyWebkitHyphens case use appropriate macro.
2103         https://bugs.webkit.org/show_bug.cgi?id=60114
2104
2105         No new tests as no functionality changes.
2106
2107         * css/CSSStyleSelector.cpp:
2108         (WebCore::CSSStyleSelector::applyProperty):
2109         Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to remove code duplication.
2110
2111 2011-05-04  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2112
2113         Reviewed by Andreas Kling.
2114
2115         [Qt] Fix QNetworkReplyWrapper to not depend on QNetworkReply::isFinished() method
2116         https://bugs.webkit.org/show_bug.cgi?id=59070
2117
2118         Applications using our API and our autotests subclass QNetworkReply as part of providing a
2119         custom QNetworkAccessManager. But there's an API limitation in Qt 4.7, that makes
2120         QNetworkReply::isFinished() always be false for these custom replies. This was fixed in Qt
2121         4.8, see http://bugreports.qt.nokia.com/browse/QTBUG-11737.
2122
2123         The consequence is that QtWebKit cannot rely on this function. So now QNetworkReplyWrapper
2124         watches for the finished() signal and set a dynamic property "_q_isFinished" on the reply
2125         indicating that it is finished. When there's no finished signal (synchronous) we set the
2126         dynamic property once we get the reply.
2127
2128         This fixes tst_QWebFrame::requestedUrl(), that was breaking because sniffer was not
2129         emitting its own finished() signal, causing QWebFrame::loadFinished() to not be emitted.
2130
2131         * platform/network/qt/QNetworkReplyHandler.cpp:
2132         (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
2133         Connect the finished signal to the new setFinished() slot.
2134
2135         (WebCore::QNetworkReplyWrapper::synchronousLoad):
2136         Since we don't get the finished signal for synchronous loads, set the dynamic property
2137         before processing it.
2138
2139         (WebCore::QNetworkReplyWrapper::resetConnections):
2140         Do not reset the connection to setFinished().
2141
2142         (WebCore::QNetworkReplyWrapper::setFinished):
2143         Set the dynamic property in the reply.
2144
2145         (WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
2146         (WebCore::QNetworkReplyHandler::start):
2147         Change to use wrapper's isFinished() instead of asking the reply directly.
2148
2149         * platform/network/qt/QNetworkReplyHandler.h:
2150         (WebCore::QNetworkReplyWrapper::isFinished):
2151         Checks the dynamic property of the reply.
2152
2153         * platform/network/qt/QtMIMETypeSniffer.cpp:
2154         (QtMIMETypeSniffer::sniff):
2155         Use the dynamic property to check if the reply is finished.
2156
2157 2011-05-04  Eric Seidel  <eric@webkit.org>
2158
2159         Reviewed by Ryosuke Niwa.
2160
2161         Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
2162         https://bugs.webkit.org/show_bug.cgi?id=60080
2163
2164         No functional change, just moving code.
2165
2166         * rendering/RenderBlock.h:
2167         * rendering/RenderBlockLineLayout.cpp:
2168         (WebCore::RenderBlock::createLineBoxesFromBidiRuns):
2169         (WebCore::RenderBlock::layoutRunsAndFloats):
2170
2171 2011-05-04  Andreas Kling  <andreas.kling@nokia.com>
2172
2173         Reviewed by Kenneth Rohde Christiansen.
2174
2175         [Qt] Remove unused function FontPlatformData::pixelSize()
2176         https://bugs.webkit.org/show_bug.cgi?id=60156
2177
2178         * platform/graphics/qt/FontPlatformData.h:
2179         (WebCore::FontPlatformData::pixelSize): Removed.
2180
2181 2011-05-04  Luke Macpherson   <macpherson@chromium.org>
2182
2183         Reviewed by Darin Adler.
2184
2185         Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty()
2186         https://bugs.webkit.org/show_bug.cgi?id=60011
2187
2188         No new tests added as no functionality changed.
2189
2190         * css/CSSStyleSelector.cpp:
2191         (WebCore::CSSStyleSelector::applyProperty):
2192         Remove reundant check for auto table layout.
2193
2194 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
2195
2196         Reviewed by Darin Adler.
2197
2198         Remove double-free checks for bug 56124
2199         https://bugs.webkit.org/show_bug.cgi?id=60037
2200
2201         Antti's speculative fix for bug 56124 (r84151) appears to have worked,
2202         these CRASH() calls are not triggering anymore.
2203
2204         * css/CSSSelector.h:
2205         (WebCore::CSSSelector::CSSSelector):
2206         (WebCore::CSSSelector::~CSSSelector):
2207         * css/CSSSelectorList.cpp:
2208         (WebCore::CSSSelectorList::deleteSelectors):
2209
2210 2011-05-04  Satish Sampath  <satish@chromium.org>
2211
2212         Reviewed by Tony Gentilcore.
2213
2214         Layout the speech input button to the left of outer spin button properly.
2215         https://bugs.webkit.org/show_bug.cgi?id=59742
2216
2217         * rendering/RenderTextControlSingleLine.cpp:
2218         (WebCore::RenderTextControlSingleLine::layout):
2219
2220 2011-05-04  Yury Semikhatsky  <yurys@chromium.org>
2221
2222         Unreviewed. Build fix.
2223
2224         * bindings/js/JSInjectedScriptHostCustom.cpp: fix includes declaration
2225
2226 2011-05-03  Yury Semikhatsky  <yurys@chromium.org>
2227
2228         Reviewed by Pavel Feldman.
2229
2230         Web Inspector: can't inspect element in an iframe when element originates from non-frame document
2231         https://bugs.webkit.org/show_bug.cgi?id=60031
2232         
2233         Inspected object type evaluation has moved into native bindings. This way it doesn't
2234         depend on the current JS context.
2235
2236         Test: inspector/elements/elements-inspect-iframe-from-different-domain.html
2237
2238         * bindings/js/JSInjectedScriptHostCustom.cpp:
2239         (WebCore::JSInjectedScriptHost::isHTMLAllCollection): this method helps distinguish
2240         real undefined values from HTMLAllCollection
2241         (WebCore::JSInjectedScriptHost::type): method that returns presice type of the passed
2242         value
2243         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2244         (WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
2245         (WebCore::V8InjectedScriptHost::typeCallback):
2246         * inspector/InjectedScriptHost.idl:
2247         * inspector/InjectedScriptSource.js:
2248         (.):
2249
2250 2011-05-03  Pratik Solanki  <psolanki@apple.com>
2251
2252         Reviewed by Antti Koivisto.
2253
2254         Part of WebCore should use CFNetwork-based loader on Mac
2255         https://bugs.webkit.org/show_bug.cgi?id=51836
2256
2257         Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one. Clean
2258         up some warnings and #if USE(CFNETWORK) around code.
2259
2260         * platform/mac/CookieJar.mm:
2261         * platform/network/CookieStorage.h:
2262         * platform/network/cf/CookieStorageCFNet.cpp:
2263         (WebCore::privateBrowsingCookieStorage):
2264         (WebCore::currentCookieStorage):
2265         (WebCore::setCurrentCookieStorage):
2266         (WebCore::setCookieStoragePrivateBrowsingEnabled):
2267         (WebCore::notifyCookiesChangedOnMainThread):
2268         (WebCore::notifyCookiesChanged):
2269         * platform/network/cf/CookieStorageCFNet.h:
2270         * platform/network/mac/CookieStorageMac.mm:
2271
2272 2011-05-03  Justin Novosad  <junov@chromium.org>
2273
2274         Reviewed by Kenneth Russell.
2275
2276         [Chromium] Make accelerated 2d canvas enabled by default with skia
2277         https://bugs.webkit.org/show_bug.cgi?id=59929
2278
2279         No new tests. Covered by existing layout tests
2280
2281         * html/canvas/CanvasRenderingContext2D.cpp:
2282         (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
2283         Initialized for accelerated canvas if either the accelerated2dCanvas
2284         or the legacyAccelerated2dCanvas flags are enabled
2285         * page/Page.cpp:
2286         (WebCore::Page::sharedGraphicsContext3D):
2287         This is where the code goes to implement the functionality for the
2288         legacy vs current acceleration paths for the 2D canvas. Currently,
2289         this is a no-op, and always select the legacy path.  This is temporary
2290         until we are ready to sort the GPU layout tests (rebasline vs. bug)
2291         * page/Settings.cpp:  Added new flage for legacyAccelerated2dCanvas
2292         (WebCore::Settings::Settings):
2293         (WebCore::Settings::setLegacyAccelerated2dCanvasEnabled):
2294         * page/Settings.h:
2295         (WebCore::Settings::legacyAccelerated2dCanvasEnabled):
2296
2297 2011-04-29  Jer Noble  <jer.noble@apple.com>
2298
2299         Reviewed by Eric Seidel.
2300
2301         Implement FULLSCREEN_API on Windows, Part 4: Enable it
2302         https://bugs.webkit.org/show_bug.cgi?id=59798
2303
2304         * WebCore.vcproj/WebCore.vcproj: Add missing full screen related
2305             files to the project.
2306
2307 2011-05-03  Alpha Lam  <hclam@chromium.org>
2308
2309         Not reviewed. Build fix.
2310
2311         More places from 0 to nullptr.
2312
2313         * bindings/v8/V8Proxy.cpp:
2314         (WebCore::V8Proxy::precompileScript):
2315         * platform/graphics/chromium/LayerTilerChromium.cpp:
2316         (WebCore::LayerTilerChromium::create):
2317         * platform/graphics/gpu/BicubicShader.cpp:
2318         (WebCore::BicubicShader::create):
2319         * platform/graphics/gpu/ConvolutionShader.cpp:
2320         (WebCore::ConvolutionShader::create):
2321         * platform/graphics/gpu/LoopBlinnSolidFillShader.cpp:
2322         (WebCore::LoopBlinnSolidFillShader::create):
2323         * platform/graphics/gpu/SolidFillShader.cpp:
2324         (WebCore::SolidFillShader::create):
2325         * platform/graphics/gpu/TexShader.cpp:
2326         (WebCore::TexShader::create):
2327         * platform/graphics/skia/PlatformContextSkia.cpp:
2328         (WebCore::PlatformContextSkia::~PlatformContextSkia):
2329         * platform/leveldb/LevelDBDatabase.cpp:
2330         (WebCore::LevelDBDatabase::createIterator):
2331         * platform/text/LocalizedNumberICU.cpp:
2332         (WebCore::createFormatterForCurrentLocale):
2333
2334 2011-05-03  Alpha Lam  <hclam@chromium.org>
2335
2336         Not reviewed. Build fix.
2337
2338         Using nullptr instead of 0. This makes visual studio happy.
2339
2340         * storage/IDBTransactionBackendInterface.h:
2341
2342 2011-05-03  Luke Macpherson   <macpherson@chromium.org>
2343
2344         Reviewed by Dimitri Glazkov.
2345
2346         Add template parameter to ApplyPropertyColor to improve clarity by removing constructor parameter side effects.
2347         https://bugs.webkit.org/show_bug.cgi?id=59774
2348
2349         No new tests required as on new functionality.
2350
2351         * css/CSSStyleApplyProperty.cpp:
2352         (WebCore::ApplyPropertyColor::applyValue):
2353         Added template parameter "inheritColorFromParent = false".
2354         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2355         Use template parameter where appropriate.
2356
2357 2011-05-03  Dan Bernstein  <mitz@apple.com>
2358
2359         Reviewed by Darin Adler.
2360
2361         <rdar://problem/9313186> Make the fix for <rdar://problem/9190108> more robust.
2362
2363         Added a pointer from FloatingObject to its originating line, if there is one, and made sure to
2364         dirty the line when the float is removed, instead of relying on the float always intersecting
2365         its originating line.
2366
2367         * rendering/RenderBlock.cpp:
2368         (WebCore::RenderBlock::removeFloatingObject):
2369         (WebCore::RenderBlock::removeFloatingObjectsBelow):
2370         (WebCore::RenderBlock::clearFloats):
2371         * rendering/RenderBlock.h:
2372         (WebCore::RenderBlock::FloatingObject::FloatingObject):
2373         * rendering/RenderBlockLineLayout.cpp:
2374         (WebCore::RenderBlock::appendFloatingObjectToLastLine):
2375         (WebCore::RenderBlock::layoutRunsAndFloats):
2376         (WebCore::RenderBlock::determineStartPosition):
2377
2378 2011-05-02  Jer Noble  <jer.noble@apple.com>
2379
2380         Reviewed by Adam Roben.
2381
2382         Implement FULLSCREEN_API on Windows, Part 3: WebKit2
2383         https://bugs.webkit.org/show_bug.cgi?id=59845
2384
2385         Move WebFullScreenController into WebCore to facilitate code sharing between WebKit
2386         and WebKit2.  WebFullScreenController now uses a Client class to request work on its
2387         behalf by WebKit and WebKit2.  MediaPlayerPrivateFullscreenWindow now only creates a 
2388         CALayerHost once a root layer is set, as the CALayerHost was causing child window drawing
2389         problems, and because a CALayerHost is overkill if the window is only drawing black to
2390         its client area.
2391
2392         * WebCore.vcproj/WebCore.vcproj:
2393         * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
2394         (WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow): Do not create 
2395             m_layerHost in the constructor.
2396         (WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): NULL check m_layerHost.
2397         (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Lazily instantiate m_layerHost.
2398         (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): NULL check m_layerHost; if a root layer is
2399             not present, fill the window with black in WM_PAINT.
2400         * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
2401         * platform/graphics/win/FullScreenController.cpp: Renamed from Source/WebKit/win/WebFullScreenController.cpp.
2402         * platform/graphics/win/FullScreenController.h: Renamed from Source/WebKit/win/WebFullScreenController.h.
2403         * platform/graphics/win/FullScreenControllerClient.h: Split out from FullScreenController.h
2404         (WebCore::FullScreenControllerClient::~FullScreenControllerClient):
2405
2406 2011-05-03  Brady Eidson  <beidson@apple.com>
2407
2408         Reviewed by Sam Weinig.
2409
2410         https://bugs.webkit.org/show_bug.cgi?id=60087 and <rdar://problem/9373182>
2411         WK2 Icon Database should provide access to all image representations in the icon.
2412
2413         Add an accessor for CG platforms to get a CFArrayRef of all the CGImageRefs represented:
2414         * platform/graphics/BitmapImage.h:
2415         * platform/graphics/Image.h:
2416         (WebCore::Image::getCGImageArray):
2417         * platform/graphics/cg/ImageCG.cpp:
2418         (WebCore::BitmapImage::getCGImageArray):
2419
2420 2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>
2421
2422         Reviewed by Eric Seidel.
2423
2424         findNextLineBreak splits InlineIterator into 3 pieces
2425         https://bugs.webkit.org/show_bug.cgi?id=60082
2426
2427         Avoid splitting InlineIterator into 3 variables with inter-dependencies.
2428
2429         * rendering/InlineIterator.h:
2430         (WebCore::InlineIterator::fastIncrementInTextNode): Added.
2431         (WebCore::InlineIterator::previousInSameNode): Added.
2432         * rendering/RenderBlockLineLayout.cpp:
2433         (WebCore::RenderBlock::findNextLineBreak):
2434
2435 2011-05-03  Dean Jackson  <dino@apple.com>
2436
2437         Reviewed by Simon Fraser.
2438
2439         Interrupted transitions are not correctly removed
2440         https://bugs.webkit.org/show_bug.cgi?id=60062
2441
2442         CompositeAnimation was replacing any existing
2443         transition as a new one was created. However, it wasn't
2444         clearing the lists in AnimationControllerPrivate that
2445         signal when a hardware animation starts. Rather than
2446         simple removing the existing transition, we now tell
2447         AnimationControllerPrivate that is has gone.
2448
2449         Test: transitions/3d/interrupted-transition.html
2450
2451         * page/animation/CompositeAnimation.cpp:
2452         (WebCore::CompositeAnimation::updateTransitions):
2453
2454 2011-05-03  Enrica Casucci  <enrica@apple.com>
2455
2456         Reviewed by Ryosuke Niwa.
2457
2458         Crash in SpellingCorrectionController::respondToChangedSelection.
2459         https://bugs.webkit.org/show_bug.cgi?id=60071
2460         <rdar://problem/9358190>
2461
2462         Creating a Visible position could trigger a layout and there is no
2463         guarantee that the selection is still valid after that.
2464
2465         Tests: editing/selection/undo-crash.html
2466
2467         * editing/SpellingCorrectionController.cpp:
2468         (WebCore::SpellingCorrectionController::respondToChangedSelection):
2469
2470 2011-05-03  Levi Weintraub  <leviw@chromium.org>
2471
2472         Reviewed by Eric Seidel.
2473
2474         Refactor computeInlineDirectionPositionsForLine into smaller functions
2475         https://bugs.webkit.org/show_bug.cgi?id=60072
2476
2477         Split three functions off from computeInlineDirectionPositionsForLine
2478         to improve its readability.
2479
2480         No new tests since this is just moving code around.
2481
2482         * rendering/RenderBlock.h:
2483         * rendering/RenderBlockLineLayout.cpp:
2484         (WebCore::RenderBlock::setMarginsForRubyRun):
2485         (WebCore::setLogicalWidthForTextRun):
2486         (WebCore::computeExpansionForJustifiedText):
2487         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
2488
2489 2011-05-03  David Kilzer  <ddkilzer@apple.com>
2490
2491         <http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
2492
2493         Reviewed by Antti Koivisto.
2494
2495         * platform/network/cf/ResourceRequestCFNet.cpp:
2496         (WebCore::ResourceRequest::doUpdatePlatformRequest): Set the
2497         priority on the request if HTTP pipelining is enabled.
2498         (WebCore::ResourceRequest::doUpdateResourceRequest): Read the
2499         priority from the request if HTTP pipelining is enabled.
2500         (readBooleanPreference): Enable code when compiling with
2501         USE(CFNETWORK).
2502         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Ditto.
2503         Comment out setting the minimum fast lane priority on Windows
2504         since it's not currently available.
2505
2506 2011-05-03  Simon Fraser  <simon.fraser@apple.com>
2507
2508         Reviewed by Dan Bernstein.
2509
2510         <rdar://problem/9278296> Flicker zooming on Google Maps satellite view with accelerated compositing turned on
2511
2512         Conditionalize compositing tiled layer size-constraining logic to older
2513         OSes.
2514
2515         * platform/graphics/ca/GraphicsLayerCA.cpp:
2516         (WebCore::GraphicsLayerCA::constrainedSize):
2517
2518 2011-05-03  Roland Steiner  <rolandsteiner@chromium.org>
2519
2520         Reviewed by Dimitri Glazkov.
2521
2522         Allow access keys to be used in shadow DOM
2523         https://bugs.webkit.org/show_bug.cgi?id=59979
2524
2525         Move access key methods and members back to Document from TreeScope.
2526         Also traverse into shadow trees when building the access key map.
2527
2528         No new tests. (refactoring)
2529
2530         * dom/Document.cpp:
2531         (WebCore::Document::Document):
2532         (WebCore::Document::getElementByAccessKey):
2533         (WebCore::Document::buildAccessKeyMap):
2534         (WebCore::Document::invalidateAccessKeyMap):
2535         * dom/Document.h:
2536         * dom/TreeScope.cpp:
2537         (WebCore::TreeScope::TreeScope):
2538         (WebCore::TreeScope::destroyTreeScopeData):
2539         * dom/TreeScope.h:
2540
2541 2011-05-03  Dan Bernstein  <mitz@apple.com>
2542
2543         Reviewed by Darin Adler.
2544
2545         <rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical or flipped text
2546         https://bugs.webkit.org/show_bug.cgi?id=60067
2547
2548         No test because this code path is only used by the Objective-C API, which is not testable from DumpRenderTree.
2549
2550         * rendering/RenderText.cpp:
2551         (WebCore::RenderText::absoluteRectsForRange): Use width/height instead of logicalWidth/logicalHeight here,
2552         and perform the local-to-absolute mapping on the rects rather than their origin, in order to get the right
2553         results for flipped writing modes.
2554
2555 2011-05-03  Anton Muhin  <antonm@chromium.org>
2556
2557         Reviewed by Yury Semikhatsky.
2558
2559         [v8] remove an ASSERT from grouping logic
2560         https://bugs.webkit.org/show_bug.cgi?id=60024
2561
2562         This ASSERT was exploratory.  Alas, right now I am aware of no easy way to
2563         repro it.  Removing for now for greener bots.
2564
2565         No new tests, only an ASSERT removal.
2566
2567         * bindings/v8/V8GCController.cpp:
2568         (WebCore::calculateGroupId):
2569
2570 2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>
2571
2572         Reviewed by Darin Adler.
2573
2574         WebKit allows selection that crosses the shadow boundary of a readonly input element
2575         https://bugs.webkit.org/show_bug.cgi?id=60000
2576
2577         The bug was caused by VisibleSelection's not validating shadow DOM boundaries.
2578         Fixed the bug by adding an extra adjustment, adjustSelectionToAvoidCrossingShadowBoundaries,
2579         in its validation process.
2580
2581         Tests: editing/selection/select-across-readonly-input-1.html
2582                editing/selection/select-across-readonly-input-2.html
2583                editing/selection/select-across-readonly-input-3.html
2584                editing/selection/select-across-readonly-input-4.html
2585                editing/selection/select-across-readonly-input-5.html
2586
2587         * editing/VisibleSelection.cpp:
2588         (WebCore::VisibleSelection::validate): Calls adjustSelectionToAvoidCrossingShadowBoundaries.
2589         (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Added.
2590         * editing/VisibleSelection.h:
2591
2592 2011-05-03  Eric Seidel  <eric@webkit.org>
2593
2594         Reviewed by Ryosuke Niwa.
2595
2596         Split out layoutRunsAndFloats from layoutInlineChildren
2597         https://bugs.webkit.org/show_bug.cgi?id=60052
2598
2599         No new tests, just moving code here.  There should be
2600         no change in behavior.
2601
2602         * rendering/RenderBlock.h:
2603         * rendering/RenderBlockLineLayout.cpp:
2604         (WebCore::RenderBlock::layoutRunsAndFloats):
2605         (WebCore::RenderBlock::layoutInlineChildren):
2606
2607 2011-05-03  James Robinson  <jamesr@chromium.org>
2608
2609         Reviewed by Kenneth Russell.
2610
2611         [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
2612         https://bugs.webkit.org/show_bug.cgi?id=59965
2613
2614         Fixes a few bugs leading to a crash if a canvas already being composited was resized to huge dimensions.
2615
2616         Test: fast/canvas/canvas-resize-after-paint.html
2617
2618         * html/canvas/CanvasRenderingContext2D.cpp:
2619         (WebCore::CanvasRenderingContext2D::reset):
2620             Mark the canvas's layer as needing a synthetic style recalculation when creating or destroying the backing
2621             DrawingBuffer so that we exit compositing mode properly if we can't handle the canvas dimensions.
2622         * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
2623         (WebCore::Canvas2DLayerChromium::setLayerRenderer):
2624             Add a null check for m_drawingBuffer
2625         * platform/graphics/gpu/DrawingBuffer.cpp:
2626         (WebCore::DrawingBuffer::clear):
2627             Avoid clearing the m_context pointer in reset() - we destroy the DrawingBuffer whenever reset() fails, so
2628             this is unnecessary.
2629
2630 2011-05-03  Adam Roben  <aroben@apple.com>
2631
2632         Fix most strict PassOwnPtr violations on Windows
2633
2634         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
2635         enabled
2636
2637         Reviewed by Anders Carlsson.
2638
2639         * loader/EmptyClients.h:
2640         * platform/GeolocationService.cpp:
2641         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
2642         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
2643         * platform/mock/GeolocationServiceMock.cpp:
2644         * rendering/RenderTheme.cpp:
2645         * rendering/RenderThemeSafari.cpp:
2646
2647 2011-05-03  Levi Weintraub  <leviw@chromium.org>
2648
2649         Reviewed by Eric Seidel.
2650
2651         Extract LineInfo class
2652         https://bugs.webkit.org/show_bug.cgi?id=60044
2653
2654         Created a LineInfo class in RenderBlockLineLayout.cpp that brings together the relevant
2655         layout information about a line. This simplifies function signatures and clears up initialization.
2656
2657         No new tests as this is refactoring.
2658
2659         * rendering/RenderBlock.h: Updated internal layout function signatures to use LineInfo.
2660         * rendering/RenderBlockLineLayout.cpp:
2661         (WebCore::LineInfo::LineInfo):
2662         (WebCore::LineInfo::isFirstLine):
2663         (WebCore::LineInfo::isLastLine):
2664         (WebCore::LineInfo::isEmpty):
2665         (WebCore::LineInfo::previousLineBrokeCleanly):
2666         (WebCore::LineInfo::setFirstLine):
2667         (WebCore::LineInfo::setLastLine):
2668         (WebCore::LineInfo::setEmpty):
2669         (WebCore::LineInfo::setPreviousLineBrokeCleanly):
2670         (WebCore::RenderBlock::createLineBoxes):
2671         (WebCore::RenderBlock::constructLine):
2672         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
2673         (WebCore::RenderBlock::layoutInlineChildren):
2674         (WebCore::RenderBlock::determineStartPosition):
2675         (WebCore::skipNonBreakingSpace):
2676         (WebCore::shouldCollapseWhiteSpace):
2677         (WebCore::requiresLineBox): Moved from RenderBlock.h and made it locally scoped to RenderBlockLineLayout.cpp
2678         (WebCore::RenderBlock::generatesLineBoxesForInlineChild):
2679         (WebCore::RenderBlock::skipTrailingWhitespace):
2680         (WebCore::RenderBlock::skipLeadingWhitespace):
2681         (WebCore::RenderBlock::findNextLineBreak):
2682
2683 2011-05-03  Roland Steiner  <rolandsteiner@chromium.org>
2684
2685         Reviewed by Dimitri Glazkov.
2686
2687         Update node list cache count on the containing TreeScope rather than the Document
2688         https://bugs.webkit.org/show_bug.cgi?id=59983
2689
2690         Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
2691         Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
2692         Make setDocument() and setDocumentRecursively() private.
2693
2694         No new tests. (refactoring)
2695
2696         * dom/ContainerNode.cpp:
2697         (WebCore::ContainerNode::childrenChanged):
2698         * dom/Node.cpp:
2699         (WebCore::Node::~Node):
2700         (WebCore::Node::setDocument):
2701         (WebCore::Node::setTreeScopeRecursively):
2702         (WebCore::Node::childNodes):
2703         (WebCore::Node::registerDynamicNodeList):
2704         (WebCore::Node::unregisterDynamicNodeList):
2705         (WebCore::Node::notifyLocalNodeListsAttributeChanged):
2706         (WebCore::Node::notifyLocalNodeListsChildrenChanged):
2707         (WebCore::Node::getElementsByTagName):
2708         (WebCore::Node::getElementsByTagNameNS):
2709         (WebCore::Node::getElementsByName):
2710         (WebCore::Node::getElementsByClassName):
2711         * dom/Node.h:
2712         * html/HTMLFormControlElement.cpp:
2713         (WebCore::HTMLFormControlElement::labels):
2714
2715 2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>
2716
2717         Reviewed by Eric Seidel.
2718
2719         Bundle trailingSpaceObject and trailingPositionedBoxes in findNextLineBreak as a class
2720         https://bugs.webkit.org/show_bug.cgi?id=60046
2721
2722         Extracted TrailingObjects that encapsulates trailingSpaceObject and trailingPositionedBoxes.
2723
2724         * rendering/RenderBlockLineLayout.cpp:
2725         (WebCore::TrailingObjects::TrailingObjects):
2726         (WebCore::TrailingObjects::setTrailingWhitespace):
2727         (WebCore::TrailingObjects::clear):
2728         (WebCore::TrailingObjects::appendBoxIfNeeded):
2729         (WebCore::TrailingObjects::addMidpoints):
2730         (WebCore::RenderBlock::findNextLineBreak):
2731
2732 2011-05-03  Igor Oliveira  <igor.oliveira@openbossa.org>
2733
2734         Reviewed by Eric Seidel.
2735
2736         [Qt] Implement initial support to DataTransferItems
2737         https://bugs.webkit.org/show_bug.cgi?id=58448
2738
2739         Implement initial support to DataTransferItems. DataTransferItems are used to 
2740         hold data for drag and drop operations. DataTransferItems hold a list of 
2741         DataTransferItem objects each of which holds an item being dragged.
2742
2743         * WebCore.pro:
2744         * dom/DataTransferItems.idl:
2745         * editing/qt/EditorQt.cpp:
2746         (WebCore::Editor::newGeneralClipboard):
2747         * page/qt/EventHandlerQt.cpp:
2748         (WebCore::EventHandler::createDraggingClipboard):
2749         * platform/chromium/DataTransferItemsChromium.h:
2750         * platform/qt/ClipboardQt.cpp:
2751         (WebCore::Clipboard::create):
2752         (WebCore::ClipboardQt::ClipboardQt):
2753         (WebCore::ClipboardQt::items):
2754         * platform/qt/ClipboardQt.h:
2755         (WebCore::ClipboardQt::create):
2756         * platform/qt/DataTransferItemQt.cpp: Added.
2757         (WebCore::DataTransferItem::create):
2758         (WebCore::DataTransferItemQt::createFromPasteboard):
2759         (WebCore::DataTransferItemQt::create):
2760         (WebCore::DataTransferItemQt::DataTransferItemQt):
2761         (WebCore::DataTransferItemQt::getAsString):
2762         (WebCore::DataTransferItemQt::getAsFile):
2763         * platform/qt/DataTransferItemQt.h: Added.
2764         * platform/qt/DataTransferItemsQt.cpp: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
2765         (WebCore::DataTransferItemsQt::create):
2766         (WebCore::DataTransferItemsQt::DataTransferItemsQt):
2767         (WebCore::DataTransferItemsQt::addPasteboardItem):
2768         * platform/qt/DataTransferItemsQt.h: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
2769
2770 2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>
2771
2772         Reviewed by Dimitri Glazkov.
2773
2774         Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
2775         https://bugs.webkit.org/show_bug.cgi?id=58703
2776
2777         No new tests, refactoring only.
2778
2779         * dom/Element.cpp:
2780         (WebCore::Element::copyNonAttributeProperties):
2781         (WebCore::Element::insertedIntoDocument):
2782         (WebCore::Element::removedFromDocument):
2783         (WebCore::Element::insertedIntoTree):
2784         (WebCore::Element::removedFromTree):
2785         (WebCore::Element::attach):
2786         (WebCore::Element::detach):
2787         (WebCore::Element::recalcStyle):
2788         (WebCore::Element::shadowRoot):
2789         (WebCore::Element::ensureShadowRoot):
2790         (WebCore::Element::childrenChanged):
2791         * dom/Node.cpp:
2792         (WebCore::Node::setTreeScopeRecursively):
2793         (WebCore::shadowRoot):
2794         (WebCore::Node::setDocumentRecursively):
2795         (WebCore::NodeRendererFactory::findVisualParent):
2796         Updated all the call sites for shadowRoot and ensureShadowRoot in the 2
2797         previous classes.
2798
2799         * dom/Element.h: Updated 2 methods' signature to return a ShadowRoot*.
2800
2801         * dom/ShadowRoot.h: Removed toShadowRoot as it is not used anymore.
2802
2803         * html/HTMLDetailsElement.cpp:
2804         * html/HTMLSummaryElement.cpp:
2805         Added #include for ShadowRoot.h.
2806
2807 2011-05-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2808
2809         Reviewed by Kenneth Rohde Christiansen.
2810
2811         [EFL] Implement mediaSliderTrack
2812         https://bugs.webkit.org/show_bug.cgi?id=59998
2813
2814         Implement paintMediaSliderTrack.
2815
2816         * platform/efl/RenderThemeEfl.cpp:
2817         (WebCore::RenderThemeEfl::RenderThemeEfl):
2818         (WebCore::RenderThemeEfl::paintMediaSliderTrack):
2819         * platform/efl/RenderThemeEfl.h:
2820
2821 2011-05-03  Mikhail Naganov  <mnaganov@chromium.org>
2822
2823         Reviewed by Pavel Feldman.
2824
2825         WebInspector: [Chromium] Fix slowness of Summary view nodes expansion in detailed heap profiles.
2826         https://bugs.webkit.org/show_bug.cgi?id=60023
2827
2828         * inspector/front-end/DetailedHeapshotGridNodes.js:
2829         (WebInspector.HeapSnapshotConstructorNode):
2830         (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
2831         * inspector/front-end/HeapSnapshot.js:
2832         (WebInspector.HeapSnapshot.prototype.dispose):
2833         (WebInspector.HeapSnapshot.prototype.aggregates):
2834         (WebInspector.HeapSnapshot.prototype._buildAggregates):
2835         (WebInspector.HeapSnapshot.prototype._sortAggregateIndexes):
2836         (WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):
2837         (WebInspector.HeapSnapshotFilteredOrderedIterator):
2838         (WebInspector.HeapSnapshotNodesProvider):
2839         * inspector/front-end/HeapSnapshotProxy.js:
2840         (WebInspector.HeapSnapshotProxy.prototype.aggregates):
2841         (WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForClass):
2842
2843 2011-05-03  Mikhail Naganov  <mnaganov@chromium.org>
2844
2845         Reviewed by Pavel Feldman.
2846
2847         WebInspector: [Chromium] Hint user that to display retaining paths, an object entry must be clicked.
2848         https://bugs.webkit.org/show_bug.cgi?id=60029
2849
2850         * English.lproj/localizedStrings.js:
2851         * inspector/front-end/DetailedHeapshotView.js:
2852         (WebInspector.HeapSnapshotRetainingPathsList.prototype.reset):
2853         (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):
2854
2855 2011-05-03  Beth Dakin  <bdakin@apple.com>
2856
2857         Reviewed by Dan Bernstein.
2858
2859         https://bugs.webkit.org/show_bug.cgi?id=60045
2860         Scrollbar thumb sometimes leaves artifacts in the track after scrolling
2861         -and corresponding-
2862         <rdar://problem/9015376>
2863
2864         When we're using WK_SCROLLBAR_PAINTER, the AppleScrollBarVariant default should 
2865         always be ignored.
2866         * platform/mac/ScrollbarThemeMac.mm:
2867         (WebCore::updateArrowPlacement):
2868
2869 2011-05-03  David Hyatt  <hyatt@apple.com>
2870
2871         Reviewed by Dan Bernstein.
2872
2873         https://bugs.webkit.org/show_bug.cgi?id=60040
2874         <rdar://problem/9261591>
2875
2876         Links broken at iplanwebsites.com. Make sure that culledInlineAbsoluteQuads still does
2877         a translation of a 0,0 point to absolute coordinates so that the top left position is
2878         accurate.
2879
2880         Added fast/inline/skipped-whitespace-client-rect.html
2881         
2882         * rendering/RenderInline.cpp:
2883         (WebCore::RenderInline::culledInlineAbsoluteQuads):
2884
2885 2011-05-03  Sam Weinig  <sam@webkit.org>
2886
2887         Fix chromium build.
2888
2889         * page/Settings.cpp:
2890
2891 2011-05-02  Roland Steiner  <rolandsteiner@chromium.org>
2892
2893         Reviewed by Dimitri Glazkov.
2894
2895         Bug 59974 - Update image map on the containing TreeScope rather than the Document
2896         https://bugs.webkit.org/show_bug.cgi?id=59974
2897
2898         No new tests. (reefactoring)
2899
2900         * html/HTMLMapElement.cpp:
2901         (WebCore::HTMLMapElement::parseMappedAttribute):
2902         (WebCore::HTMLMapElement::insertedIntoDocument):
2903         (WebCore::HTMLMapElement::removedFromDocument):
2904         * rendering/RenderImage.cpp:
2905         (WebCore::RenderImage::imageMap):
2906
2907 2011-05-03  Sam Weinig  <sam@webkit.org>
2908
2909         Fix chromium build.
2910
2911         * loader/HistoryController.cpp:
2912
2913 2011-05-02  Roland Steiner  <rolandsteiner@chromium.org>
2914
2915         Reviewed by Dimitri Glazkov.
2916
2917         Bug 59966 - Update ID hash on the containing TreeScope rather than the Document
2918         https://bugs.webkit.org/show_bug.cgi?id=59966
2919
2920         No new tests. (refactoring)
2921
2922         * accessibility/AccessibilityRenderObject.cpp:
2923         (WebCore::AccessibilityRenderObject::elementsFromAttribute):
2924         (WebCore::AccessibilityRenderObject::activeDescendant):
2925         * accessibility/AccessibilityRenderObject.h:
2926         (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
2927         * css/CSSCursorImageValue.cpp:
2928         (WebCore::resourceReferencedByCursorElement):
2929         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
2930         (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
2931         (WebCore::CSSCursorImageValue::cachedImage):
2932         * dom/DynamicNodeList.cpp:
2933         (WebCore::DynamicNodeList::itemWithName):
2934         * dom/Element.h:
2935         (WebCore::Element::updateId):
2936         * dom/Node.cpp:
2937         (WebCore::Node::querySelector):
2938         * html/FormAssociatedElement.cpp:
2939         (WebCore::FormAssociatedElement::insertedIntoTree):
2940         (WebCore::FormAssociatedElement::resetFormOwner):
2941         * html/HTMLInputElement.cpp:
2942         (WebCore::HTMLInputElement::dataList):
2943         * html/HTMLLabelElement.cpp:
2944         (WebCore::HTMLLabelElement::control):
2945         * rendering/svg/RenderSVGTextPath.cpp:
2946         (WebCore::RenderSVGTextPath::layoutPath):
2947         * svg/SVGAElement.cpp:
2948         (WebCore::SVGAElement::defaultEventHandler):
2949         * svg/SVGAltGlyphElement.cpp:
2950         (WebCore::SVGAltGlyphElement::glyphElement):
2951         * svg/SVGFEImageElement.cpp:
2952         (WebCore::SVGFEImageElement::requestImageResource):
2953         (WebCore::SVGFEImageElement::build):
2954         * svg/SVGLinearGradientElement.cpp:
2955         (WebCore::SVGLinearGradientElement::collectGradientAttributes):
2956         * svg/SVGMPathElement.cpp:
2957         (WebCore::SVGMPathElement::pathElement):
2958         * svg/SVGPatternElement.cpp:
2959         (WebCore::SVGPatternElement::collectPatternAttributes):
2960         * svg/SVGRadialGradientElement.cpp:
2961         (WebCore::SVGRadialGradientElement::collectGradientAttributes):
2962         * svg/SVGSVGElement.cpp:
2963         (WebCore::SVGSVGElement::getElementById):
2964         * svg/SVGTRefElement.cpp:
2965         (WebCore::SVGTRefElement::updateReferencedText):
2966         * svg/SVGTextPathElement.cpp:
2967         (WebCore::SVGTextPathElement::insertedIntoDocument):
2968         * svg/SVGUseElement.cpp:
2969         (WebCore::SVGUseElement::buildPendingResource):
2970         (WebCore::SVGUseElement::hasCycleUseReferencing):
2971         (WebCore::SVGUseElement::expandUseElementsInShadowTree):
2972         * svg/SVGViewSpec.cpp:
2973         (WebCore::SVGViewSpec::viewTarget):
2974         * svg/animation/SVGSMILElement.cpp:
2975         (WebCore::SVGSMILElement::eventBaseFor):
2976         (WebCore::SVGSMILElement::connectConditions):
2977         (WebCore::SVGSMILElement::targetElement):
2978         * xml/XPathFunctions.cpp:
2979         (WebCore::XPath::FunId::evaluate):
2980
2981 2011-05-03  Sam Weinig  <sam@webkit.org>
2982
2983         Fix chromium build.
2984
2985         * css/StyleMedia.cpp:
2986
2987 2011-05-03  Sam Weinig  <sam@webkit.org>
2988
2989         Reviewed by Anders Carlsson.
2990
2991         Prune #includes from FrameView.h (Part 1)
2992         https://bugs.webkit.org/show_bug.cgi?id=59957
2993
2994         * page/FrameView.h:
2995         Prune #includes.
2996
2997         * accessibility/chromium/AXObjectCacheChromium.cpp:
2998         * page/win/FrameCGWin.cpp:
2999         * platform/Scrollbar.cpp:
3000         Add not necessary #includes.
3001
3002         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
3003         Add now necessary forward declaration.
3004
3005 2011-05-03  Andrey Kosyakov  <caseq@chromium.org>
3006
3007         Reviewed by Dimitri Glazkov.
3008
3009         [Chromium] toV8(Node*) will enter infinite recursion when called with a node of type SHADOW_ROOT_NODE
3010         https://bugs.webkit.org/show_bug.cgi?id=60026
3011
3012         Return a wrapper for Node in toV8(Node*) when called with a node of type
3013         SHADOW_ROOT_NODE instead of entering infinite recursion.
3014
3015         * bindings/v8/custom/V8NodeCustom.cpp:
3016         (WebCore::toV8Slow):
3017
3018 2011-05-02  Adam Roben  <aroben@apple.com>
3019
3020         Take advantage of implicit conversion from nullptr_t to PassOwnPtr
3021
3022         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
3023         doesn't work, but should
3024
3025         Reviewed by Adam Barth.
3026
3027         * bindings/js/ScheduledAction.cpp:
3028         * css/CSSStyleSelector.cpp:
3029         * css/MediaList.cpp:
3030         * css/MediaQueryMatcher.cpp:
3031         * css/SVGCSSStyleSelector.cpp:
3032         * dom/MessagePort.cpp:
3033         * html/InputType.cpp:
3034         * html/canvas/WebGLRenderingContext.cpp:
3035         * inspector/InspectorStyleSheet.cpp:
3036         * page/ContextMenuController.cpp:
3037         * page/Page.cpp:
3038         * platform/PlatformGestureRecognizer.cpp:
3039         * platform/PurgeableBuffer.h:
3040         * platform/graphics/ImageBuffer.h:
3041         * platform/leveldb/LevelDBDatabase.cpp:
3042         * platform/mac/PurgeableBufferMac.cpp:
3043         * platform/text/RegularExpression.cpp:
3044         * rendering/RenderTheme.cpp:
3045         * rendering/RenderThemeMac.mm:
3046         * rendering/style/RenderStyle.h:
3047         * rendering/style/SVGRenderStyleDefs.cpp:
3048         * rendering/style/ShadowData.cpp:
3049         * rendering/style/StyleRareInheritedData.cpp:
3050         * rendering/style/StyleRareNonInheritedData.cpp:
3051         * rendering/svg/RenderSVGResourcePattern.cpp:
3052
3053 2011-05-03  Pavel Feldman  <pfeldman@google.com>
3054
3055         Not reviewed: fix inspector status bar image glyph reference in network panel.
3056
3057         * inspector/front-end/networkPanel.css:
3058         (.network-larger-resources-status-bar-item .glyph):
3059
3060 2011-05-03  Pavel Feldman  <pfeldman@google.com>
3061
3062         Reviewed by Yury Semikhatsky.
3063
3064         Web Inspector: rename BrowserDebugger agent to DOMDebugger.
3065         https://bugs.webkit.org/show_bug.cgi?id=60019
3066
3067         * inspector/CodeGeneratorInspector.pm:
3068         * inspector/Inspector.json:
3069         * inspector/InspectorController.cpp:
3070         (WebCore::InspectorController::connectFrontend):
3071         * inspector/front-end/BreakpointsSidebarPane.js:
3072         (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
3073         (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
3074         (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
3075         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
3076         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
3077         * inspector/generate-inspector-idl:
3078
3079 2011-05-03  Yury Semikhatsky  <yurys@chromium.org>
3080
3081         Reviewed by Pavel Feldman.
3082
3083         Web Inspector: remove special logic for type of document.__proto__
3084         https://bugs.webkit.org/show_bug.cgi?id=60014
3085
3086         Test: inspector/console/console-log-document-proto.html
3087
3088         * inspector/InjectedScriptSource.js: removed unnecessary check nodeType === undefined
3089
3090 2011-05-03  Pavel Feldman  <pfeldman@google.com>
3091
3092         Not reviewed: fixed typo in inspector style.
3093
3094         * inspector/front-end/inspector.css:
3095         (.status-bar-item > .glyph):
3096
3097 2011-05-03  Pavel Feldman  <pfeldman@chromium.org>
3098
3099         Reviewed by Yury Semikhatsky.
3100
3101         Web Inspector: revision history storage is too slow.
3102         https://bugs.webkit.org/show_bug.cgi?id=59939
3103
3104         It turns out that iterating localStorage keys is very
3105         expensive (results in slow inspector start), refactor revision
3106         history in order not to rely upon that operation.
3107
3108         * inspector/front-end/Resource.js:
3109         (WebInspector.Resource):
3110         (WebInspector.Resource._resourceRevisionRegistry):
3111         (WebInspector.Resource.restoreRevisions.persist):
3112         (WebInspector.Resource.restoreRevisions):
3113         (WebInspector.Resource.persistRevision):
3114         (WebInspector.Resource.prototype._persistRevision):
3115         * inspector/front-end/ResourceTreeModel.js:
3116         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
3117         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
3118
3119 2011-05-03  Pavel Feldman  <pfeldman@chromium.org>
3120
3121         Reviewed by Yury Semikhatsky.
3122
3123         Web Inspector: combine toolbar icon images.
3124         https://bugs.webkit.org/show_bug.cgi?id=59931
3125
3126         * WebCore.gypi:
3127         * inspector/front-end/Images/auditsIcon.png: Removed.
3128         * inspector/front-end/Images/consoleIcon.png: Removed.
3129         * inspector/front-end/Images/elementsIcon.png: Removed.
3130         * inspector/front-end/Images/networkIcon.png: Removed.
3131         * inspector/front-end/Images/profilesIcon.png: Removed.
3132         * inspector/front-end/Images/resourcesIcon.png: Removed.
3133         * inspector/front-end/Images/scriptsIcon.png: Removed.
3134         * inspector/front-end/Images/timelineIcon.png: Removed.
3135         * inspector/front-end/Images/toolbarIcons.png: Added.
3136         * inspector/front-end/Images/toolbarIconsSmall.png: Added.
3137         * inspector/front-end/WebKit.qrc:
3138         * inspector/front-end/inspector.css:
3139         (.toolbar-icon):
3140         (#toolbar-dropdown .toolbar-icon):
3141         (.toolbar-item:active .toolbar-icon):
3142         (#toolbar-dropdown .toolbar-item:active .toolbar-icon):
3143         (.toolbar-item.elements .toolbar-icon):
3144         (.toolbar-item.resources .toolbar-icon):
3145         (#toolbar-dropdown .toolbar-item.resources .toolbar-icon):
3146         (.toolbar-item.network .toolbar-icon):
3147         (#toolbar-dropdown .toolbar-item.network .toolbar-icon):
3148         (.toolbar-item.scripts .toolbar-icon):
3149         (#toolbar-dropdown .toolbar-item.scripts .toolbar-icon):
3150         (.toolbar-item.timeline .toolbar-icon):
3151         (#toolbar-dropdown .toolbar-item.timeline .toolbar-icon):
3152         (.toolbar-item.profiles .toolbar-icon):
3153         (#toolbar-dropdown .toolbar-item.profiles .toolbar-icon):
3154         (.toolbar-item.audits .toolbar-icon):
3155         (#toolbar-dropdown .toolbar-item.audits .toolbar-icon):
3156         (.toolbar-item.console .toolbar-icon):
3157         (#toolbar-dropdown .toolbar-item.console .toolbar-icon):
3158         (.status-bar-item > .glyph):
3159
3160 2011-05-03  Pavel Feldman  <pfeldman@chromium.org>
3161
3162         Reviewed by Yury Semikhatsky.
3163
3164         Web Inspector: combine status bar button glyphs.
3165         https://bugs.webkit.org/show_bug.cgi?id=59885
3166
3167         * WebCore.gypi:
3168         * inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Removed.
3169         * inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Removed.
3170         * inspector/front-end/Images/clearConsoleButtonGlyph.png: Removed.
3171         * inspector/front-end/Images/consoleButtonGlyph.png: Removed.
3172         * inspector/front-end/Images/dockButtonGlyph.png: Removed.
3173         * inspector/front-end/Images/enableOutlineButtonGlyph.png: Removed.
3174         * inspector/front-end/Images/enableSolidButtonGlyph.png: Removed.
3175         * inspector/front-end/Images/excludeButtonGlyph.png: Removed.
3176         * inspector/front-end/Images/focusButtonGlyph.png: Removed.
3177         * inspector/front-end/Images/garbageCollectButtonGlyph.png: Removed.
3178         * inspector/front-end/Images/gearButtonGlyph.png: Removed.
3179         * inspector/front-end/Images/helpButtonGlyph.png: Removed.
3180         * inspector/front-end/Images/largerResourcesButtonGlyph.png: Removed.
3181         * inspector/front-end/Images/nodeSearchButtonGlyph.png: Removed.
3182         * inspector/front-end/Images/pauseOnExceptionButtonGlyph.png: Removed.
3183         * inspector/front-end/Images/percentButtonGlyph.png: Removed.
3184         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Removed.
3185         * inspector/front-end/Images/recordButtonGlyph.png: Removed.
3186         * inspector/front-end/Images/recordToggledButtonGlyph.png: Removed.
3187         * inspector/front-end/Images/reloadButtonGlyph.png: Removed.
3188         * inspector/front-end/Images/statusBarButtonGlyphs.png: Added.
3189         * inspector/front-end/Images/undockButtonGlyph.png: Removed.
3190         * inspector/front-end/WebKit.qrc:
3191         * inspector/front-end/inspector.css:
3192         (.status-bar-item > .glyph):
3193         (#dock-status-bar-item .glyph):
3194         (body.detached #dock-status-bar-item .glyph):
3195         (#console-status-bar-item .glyph):
3196         (.clear-status-bar-item .glyph):
3197         (button.enable-toggle-status-bar-item .glyph):
3198         (button.enable-toggle-status-bar-item.toggled-on .glyph):
3199         (.scripts-pause-on-exceptions-status-bar-item .glyph):
3200         (.scripts-toggle-pretty-print-status-bar-item .glyph):
3201         (.toggle-breakpoints .glyph):
3202         (.toggle-breakpoints.toggled-on .glyph):
3203         (.resources-larger-resources-status-bar-item .glyph):
3204         (.timeline-filter-status-bar-item .glyph):
3205         (.garbage-collect-status-bar-item .glyph):
3206         (.record-profile-status-bar-item .glyph):
3207         (.record-profile-status-bar-item.toggled-on .glyph):
3208         (.heap-snapshot-status-bar-item .glyph):
3209         (.node-search-status-bar-item .glyph):
3210         (.percent-time-status-bar-item .glyph):
3211         (.focus-profile-node-status-bar-item .glyph):
3212         (.exclude-profile-node-status-bar-item .glyph):
3213         (.reset-profile-status-bar-item .glyph):
3214         (.delete-storage-status-bar-item .glyph):
3215         (.refresh-storage-status-bar-item .glyph):
3216         * inspector/front-end/inspector.js:
3217
3218 2011-05-02  Simon Fraser  <simon.fraser@apple.com>
3219
3220         Reviewed by Dan Bernstein.
3221
3222         Possible crash when removing elements with reflections
3223         https://bugs.webkit.org/show_bug.cgi?id=60009
3224         
3225         RenderLayer's destructor deleted its z-order list Vector pointers
3226         before removing the reflection layer. However, the reflection cleanup
3227         code could call back into the RenderLayer to dirty z-order lists,
3228         so move reflection cleanup to before z-order vector deletion.
3229         
3230         The test crashes when run manually a few times with MallocScribble enabled,
3231         but I was not able to create a test that crashed reliably.
3232
3233         Test: fast/reflections/remove-reflection-crash.html
3234
3235         * rendering/RenderLayer.cpp:
3236         (WebCore::RenderLayer::~RenderLayer):
3237
3238 2011-05-02  Ian Henderson  <ianh@apple.com>
3239
3240         Reviewed by Dan Bernstein.
3241
3242         CSS !important not respected by JavaScript
3243         https://bugs.webkit.org/show_bug.cgi?id=60007
3244
3245         The addParsedProperty and addParsedProperties methods were subtly
3246         different.  The former did not check for !important before setting the
3247         given property.
3248
3249         Change addParsedProperties to call addParsedProperty and move the
3250         relevant code.  The one other caller of this method, in
3251         editing/markup.cpp, probably wanted this behavior anyway.
3252
3253         Test: fast/css/important-js-override.html
3254
3255         * css/CSSMutableStyleDeclaration.cpp:
3256         (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
3257         (WebCore::CSSMutableStyleDeclaration::addParsedProperty):
3258
3259 2011-05-02  Ben Wells  <benwells@chromium.org>
3260
3261         Reviewed by Simon Fraser.
3262
3263         Cleanup variable usage in RenderObject.cpp paintOutline()
3264         https://bugs.webkit.org/show_bug.cgi?id=59911
3265
3266         No new tests for this, there should be no change in behaviour.
3267
3268         * rendering/RenderObject.cpp:
3269         (WebCore::RenderObject::paintOutline):
3270
3271 2011-05-02  Ryosuke Niwa  <rniwa@webkit.org>
3272
3273         Reviewed by James Robinson.
3274
3275         REGRESSION(r84672): showTree doesn't work for input/textarea elements
3276         https://bugs.webkit.org/show_bug.cgi?id=60001
3277
3278         When shadow is null, try retrieving the inner element of a render text control.
3279
3280         * dom/Node.cpp:
3281         (WebCore::traverseTreeAndMark):
3282
3283 2011-05-02  Joseph Pecoraro  <joepeck@webkit.org>
3284
3285         Reviewed by David Kilzer.
3286
3287         Respect fixed text-indent on ::-webkit-input-placeholder
3288         https://bugs.webkit.org/show_bug.cgi?id=59825
3289
3290         Test: fast/forms/input-placeholder-text-indent.html
3291
3292         * rendering/RenderTextControl.cpp:
3293         (WebCore::RenderTextControl::paintPlaceholder): indent by
3294         a fixed text-indent size specified on the placeholder style.
3295
3296 2011-05-02  Eric Uhrhane  <ericu@chromium.org>
3297
3298         Reviewed by Eric Seidel.
3299
3300         Some FileWriter progress events should be queued
3301         https://bugs.webkit.org/show_bug.cgi?id=50846
3302
3303         * fileapi/FileWriter.cpp:
3304         * fileapi/FileWriter.h:
3305         Create a new asynchronous Task [FileWriterCompletionEventTask] that will set readyState to DONE and fire off the right events.
3306
3307 2011-05-02  Jia Pu  <jpu@apple.com>
3308
3309         Reviewed by Alexey Proskuryakov.
3310
3311         [Mac] Need to truncate the string sent to "Look Up … " menu item, if it's too long.
3312         https://bugs.webkit.org/show_bug.cgi?id=59836
3313         <rdar://problem/9275983>
3314
3315         * platform/DefaultLocalizationStrategy.cpp:
3316         (WebCore::truncatedStringForLookupMenuItem):
3317         (WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):
3318
3319 2011-05-02  Brady Eidson  <beidson@apple.com>
3320
3321         Reviewed by Anders Carlsson.
3322
3323         <rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
3324         In Aperture, a WebView might be dealloc'ed before it finishes loading.
3325
3326         * WebCore.exp.in:
3327         * platform/RuntimeApplicationChecks.cpp:
3328         (WebCore::applicationIsAperture): Perform a com.apple.Aperture bundle check.
3329         * platform/RuntimeApplicationChecks.h:
3330
3331 2011-05-02  Simon Fraser  <simon.fraser@apple.com>
3332
3333         Reviewed by Dan Bernstein.
3334
3335         Avoid wasted cycles updating paths when popping the context stack
3336         https://bugs.webkit.org/show_bug.cgi?id=59967
3337
3338         CanvasRenderingContext2D has to map the current path through
3339         transforms whenever the context stack is popped, which creates
3340         a lot of platform path objects. Avoid extra work here when the
3341         path is empty, or when the transform is identity.
3342
3343         * platform/graphics/cg/PathCG.cpp:
3344         (WebCore::Path::transform):
3345
3346 2011-05-02  Enrica Casucci  <enrica@apple.com>
3347
3348         Reviewed by Dan Bernstein.
3349
3350         Text does not split on white space when typing to the edge of window.
3351         https://bugs.webkit.org/show_bug.cgi?id=59968
3352         <rdar://problem/9112683>
3353
3354         Test: editing/inserting/typing-at-end-of-line.html
3355
3356         This is a regression introduced when we converted the line box tree to
3357         floating point in r78846. In findNextLineBreak, there was still one place where
3358         the character width was treated as int and truncated and we were inconsistent
3359         in the way we treated a character that did not fit entirely in the line.
3360
3361         * rendering/RenderBlockLineLayout.cpp:
3362         (WebCore::RenderBlock::findNextLineBreak):
3363
3364 2011-04-19  Adrienne Walker  <enne@google.com>
3365
3366         Reviewed by James Robinson.
3367
3368         [chromium] Don't unnecessarily resize skia/cg canvases when painting in compositor
3369         https://bugs.webkit.org/show_bug.cgi?id=58907
3370
3371         Additionally, move the context save/restore logic to a place where it
3372         will reset the translation added in LayerTilerChromium.
3373
3374         Test: compositing/repaint/same-size-invalidation.html
3375
3376         * platform/graphics/chromium/ContentLayerChromium.cpp:
3377         (WebCore::ContentLayerPainter::paint):
3378         * platform/graphics/chromium/PlatformCanvas.cpp:
3379         (WebCore::PlatformCanvas::resize):
3380         (WebCore::PlatformCanvas::Painter::Painter):
3381         (WebCore::PlatformCanvas::Painter::~Painter):
3382         * platform/graphics/chromium/PlatformCanvas.h:
3383
3384 2011-05-02  Csaba Osztrogonác  <ossy@webkit.org>
3385
3386         Enable strict OwnPtr for Qt
3387         https://bugs.webkit.org/show_bug.cgi?id=59667
3388
3389         Unreviewed buildfix after r85343.
3390
3391         * platform/graphics/qt/GraphicsContext3DQt.cpp:
3392         (WebCore::GraphicsContext3D::GraphicsContext3D):
3393
3394 2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3395
3396         Unreviewed, rolling out r85483.
3397         http://trac.webkit.org/changeset/85483
3398         https://bugs.webkit.org/show_bug.cgi?id=59958
3399
3400         Causes media test failures. (Requested by eric_carlson on
3401         #webkit).
3402
3403         * html/HTMLMediaElement.cpp:
3404         (WebCore::HTMLMediaElement::HTMLMediaElement):
3405         (WebCore::HTMLMediaElement::prepareForLoad):
3406         (WebCore::HTMLMediaElement::seek):
3407         (WebCore::HTMLMediaElement::updatePlayState):
3408         * html/HTMLMediaElement.h:
3409         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
3410         (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
3411         (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad):
3412         (WebCore::MediaPlayerPrivateAVFoundation::load):
3413         (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay):
3414         (WebCore::MediaPlayerPrivateAVFoundation::paint):
3415         (WebCore::MediaPlayerPrivateAVFoundation::duration):
3416         (WebCore::MediaPlayerPrivateAVFoundation::seeking):
3417         (WebCore::MediaPlayerPrivateAVFoundation::updateStates):
3418         (WebCore::MediaPlayerPrivateAVFoundation::hasAvailableVideoFrame):
3419         (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded):
3420         (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged):
3421         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
3422         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
3423         (WebCore::MediaPlayerPrivateAVFoundation::repaint):
3424         (WebCore::MediaPlayerPrivateAVFoundation::setPreload):
3425         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
3426         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
3427         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
3428         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
3429         (WebCore::MediaPlayerPrivateAVFoundationObjC::videoLayerIsReadyToDisplay):
3430         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL):
3431         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForCacheResource):
3432         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
3433         (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata):
3434         (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
3435         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
3436         (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus):
3437         (WebCore::MediaPlayerPrivateAVFoundationObjC::paint):
3438         (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
3439         (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
3440
3441 2011-05-02  Adam Barth  <abarth@webkit.org>
3442
3443         Reviewed by David Levin.
3444
3445         PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
3446         https://bugs.webkit.org/show_bug.cgi?id=59924
3447
3448         * css/CSSGrammar.y:
3449         * platform/graphics/mac/SimpleFontDataMac.mm:
3450             - Memory management for the font cache is somewhat... complext.
3451               This will require some careful thought to sort out.
3452
3453 2011-05-02  Levi Weintraub  <leviw@chromium.org>
3454
3455         Reviewed by Eric Seidel.
3456
3457         showLineTree/showLineTreeForThis would make working with the line box tree easier
3458         https://bugs.webkit.org/show_bug.cgi?id=59662
3459
3460         Adding a showLineTree/showLineTreeForThis method to help visualize and debug
3461         the line tree. Also adding a missing showRenderTreeForThis method to RenderObject.
3462
3463         No new tests since this is a debugging feature only and not compiled in release.
3464
3465         * rendering/InlineBox.cpp:
3466         (WebCore::InlineBox::showLineTreeForThis):
3467         (WebCore::InlineBox::showLineTreeAndMark):
3468         (WebCore::InlineBox::showBox):
3469         (showLineTree):
3470         * rendering/InlineBox.h:
3471         * rendering/InlineFlowBox.cpp:
3472         (WebCore::InlineFlowBox::showLineTreeAndMark):
3473         * rendering/InlineFlowBox.h:
3474         * rendering/InlineTextBox.cpp:
3475         (WebCore::InlineTextBox::showBox):
3476         * rendering/InlineTextBox.h:
3477         * rendering/RenderBlock.cpp:
3478         (WebCore::RenderBlock::showLineTreeAndMark):
3479         * rendering/RenderBlock.h:
3480         * rendering/RenderObject.cpp:
3481         (WebCore::RenderObject::showRenderTreeForThis):
3482         (WebCore::RenderObject::showLineTreeForThis):
3483         (showTree):
3484         (showLineTree):
3485         * rendering/RenderObject.h:
3486
3487 2011-05-02  Dimitri Glazkov  <dglazkov@chromium.org>
3488
3489         Reviewed by Eric Carlson.
3490
3491         REGRESSIONS (r71934): In standalone media documents, (double-)clicking the media element doesn’t play/pause
3492         https://bugs.webkit.org/show_bug.cgi?id=59917
3493
3494         Since default event handlers are not retargeted, we should always attempt ancestor
3495         traversal to find out whether the event.
3496
3497         * html/MediaDocument.cpp:
3498         (WebCore::ancestorVideoElement): Added ancestor-traversing helper.
3499         (WebCore::MediaDocument::defaultEventHandler): Changed to use ancestorVideoElement.
3500
3501 2011-05-02  Sam Weinig  <sam@webkit.org>
3502
3503         Attempt to fix the Leopard build.
3504
3505         * platform/graphics/FontPlatformData.h:
3506         * platform/graphics/mac/ComplexTextController.h:
3507         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
3508         * platform/mac/WebCoreSystemInterface.h:
3509
3510 2011-05-02  Tony Chang  <tony@chromium.org>
3511
3512         Reviewed by Kent Tamura.
3513
3514         convert manual-tests/bugzilla-6821.html to a layout test
3515         https://bugs.webkit.org/show_bug.cgi?id=59404
3516
3517         Test: fast/css/hover-update.html
3518
3519         * manual-tests/bugzilla-6821.html: Removed.
3520
3521 2011-05-02  Sam Weinig  <sam@webkit.org>
3522
3523         Reviewed by Anders Carlsson.
3524
3525         Prune ApplicationServices.h out of the headers
3526         https://bugs.webkit.org/show_bug.cgi?id=59952
3527
3528         More forward declares are better.
3529
3530         * html/canvas/CanvasRenderingContext2D.cpp:
3531         * html/canvas/CanvasRenderingContext2D.h:
3532         * platform/graphics/GlyphBuffer.h:
3533         * platform/graphics/cg/ImageBufferCG.cpp:
3534         * platform/graphics/cg/PDFDocumentImage.cpp:
3535         * platform/graphics/cg/PDFDocumentImage.h:
3536         * platform/graphics/mac/ComplexTextController.h:
3537         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
3538         * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
3539         * platform/mac/ScrollAnimatorMac.h:
3540         * platform/mac/ScrollAnimatorMac.mm:
3541         * platform/mac/ScrollbarThemeMac.h:
3542         * platform/mac/ScrollbarThemeMac.mm:
3543         * platform/mac/WebCoreNSStringExtras.h:
3544         * platform/mac/WebCoreSystemInterface.h:
3545
3546 2011-05-02  Dan Bernstein  <mitz@apple.com>
3547
3548         Reviewed by Simon Fraser.
3549
3550         <rdar://problem/7972529> Images with percentage based height/max-height are missing when they are inside blocks inside tables
3551         https://bugs.webkit.org/show_bug.cgi?id=58006
3552
3553         * rendering/RenderBox.cpp:
3554         (WebCore::RenderBox::computeReplacedLogicalHeightUsing): Expanded the scope of the fix for
3555         <http://webkit.org/b/15359> from r29039 to cover not just the case of a auto-or-percent-height
3556         table cell as the immediate containing block, but any case where all containing block ancestors
3557         up to and including a table cell are auto-or-percent height.
3558
3559 2011-05-02  Daniel Bates  <dbates@webkit.org>
3560
3561         Reviewed by Sam Weinig.
3562
3563         Convert manual test onblur-remove.html to a DRT test; onblur-remove.html fails
3564         https://bugs.webkit.org/show_bug.cgi?id=59379
3565
3566         Move manual test onblur-remove.html to LayoutTests/fast/events.
3567
3568         Test: fast/events/onblur-remove.html
3569
3570         * manual-tests/onblur-remove.html: Removed.
3571
3572 2011-05-02  Sailesh Agrawal  <sail@chromium.org>
3573
3574         Reviewed by Dimitri Glazkov.
3575
3576         Chromium Mac: Add scrollbar overlay drawing functions
3577         https://bugs.webkit.org/show_bug.cgi?id=59741
3578
3579         These functions are simply copied from WebCoreSystemInterface. These will be used to implement overlay scrollbars for Chromium Mac.
3580
3581         No new tests, since this code is only enabled on future versions of Mac OS X.
3582
3583         * WebCore.gypi:
3584         * platform/chromium/ScrollbarOverlayUtilitiesMac.h: Added.
3585         * platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Added.
3586         (LookUpNSScrollerImpClass):
3587         (LookUpNSScrollerImpPairClass):
3588         (ScrollbarControlSizeToNSControlSize):
3589         (wkScrollbarPainterUsesOverlayScrollers):
3590         (wkScrollbarPainterIsHorizontal):
3591         (wkScrollbarPainterKnobAlpha):
3592         (wkScrollbarPainterSetOverlayState):
3593         (wkScrollbarPainterPaint):
3594         (wkScrollbarMinimumThumbLength):
3595         (wkScrollbarPainterSetDelegate):
3596         (wkScrollbarPainterTrackAlpha):
3597         (wkMakeScrollbarPainter):
3598         (wkScrollbarThickness):
3599         (wkScrollbarMinimumTotalLengthNeededForThumb):
3600         (wkVerticalScrollbarPainterForController):
3601         (wkHorizontalScrollbarPainterForController):
3602         (wkMakeScrollbarReplacementPainter):
3603         (wkSetPainterForPainterController):
3604         (wkSetScrollbarPainterControllerStyle):
3605         (wkScrollbarPainterKnobRect):
3606         (wkSetScrollbarPainterKnobAlpha):
3607         (wkSetScrollbarPainterTrackAlpha):
3608         (wkSetScrollbarPainterKnobStyle):
3609         (wkMakeScrollbarPainterController):
3610         (wkContentAreaScrolled):
3611         (wkContentAreaWillPaint):
3612         (wkMouseEnteredContentArea):
3613         (wkMouseExitedContentArea):
3614         (wkMouseMovedInContentArea):
3615         (wkWillStartLiveResize):
3616         (wkContentAreaResized):
3617         (wkWillEndLiveResize):
3618         (wkContentAreaDidShow):
3619         (wkContentAreaDidHide):
3620         (wkDidBeginScrollGesture):
3621         (wkDidEndScrollGesture):
3622         (wkScrollbarPainterForceFlashScrollers):
3623         (IsScrollbarOverlayAPIAvailable):
3624
3625 2011-05-02  Luke Macpherson   <macpherson@chromium.org>
3626
3627         Reviewed by Dimitri Glazkov.
3628
3629         Implement Length based CSS properties in CSSStyleApplyProperty
3630         https://bugs.webkit.org/show_bug.cgi?id=59314
3631
3632         No new tests as no functionality changed.
3633
3634         * css/CSSStyleApplyProperty.cpp:
3635         (WebCore::ApplyPropertyLength::ApplyPropertyLength):
3636         Added this class to handle all length types.
3637         Property specific behavior is handled through set of boolean parameters.
3638         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
3639         Added calls to set up entries for the newly added length properties.
3640         * css/CSSStyleSelector.cpp:
3641         (WebCore::CSSStyleSelector::applyProperty):
3642         Remove property implementations mow implemented in CSSStyleApplyProperty.
3643         * css/CSSStyleSelector.h:
3644         (WebCore::CSSStyleSelector::rootElementStyle):
3645         Expose m_rootElementStyle via getter.
3646
3647 2011-05-02  Eric Carlson  <eric.carlson@apple.com>
3648
3649         Reviewed by Eric Seidel.
3650
3651         HTMLMediaElement should not seek to time 0 when readyState reaches HAVE_METADATA
3652         https://bugs.webkit.org/show_bug.cgi?id=59828
3653
3654         No new tests required, no functional change because seeking to time zero before playback
3655         begins has no effect.
3656
3657         * html/HTMLMediaElement.cpp:
3658         (WebCore::HTMLMediaElement::setReadyState): Don't seek to time 0 when readyState reaches
3659             HAVE_METADATA.
3660
3661 2011-05-02  Sam Weinig  <sam@webkit.org>
3662
3663         Reviewed by Gavin Barraclough.
3664
3665         Fix extra whitespace in license in FocusDirection.h.
3666
3667         * page/FocusDirection.h:
3668
3669 2011-05-02  Sam Weinig  <sam@webkit.org>
3670
3671         Reviewed by Adam Barth.
3672
3673         Prune some #includes from DOMWindow.h
3674         https://bugs.webkit.org/show_bug.cgi?id=59907
3675
3676         * page/DOMWindow.cpp:
3677         (WebCore::DOMWindow::setSecurityOrigin):
3678         * page/DOMWindow.h:
3679         Remove #includes of SecurityOrigin and MessagePort by forward declaring
3680         and moving the SecurityOrigin setter to the .cpp file. Also adds EventTarget
3681         #include that was getting added by MessagePort.h.
3682
3683         * bindings/js/JSCustomVoidCallback.cpp:
3684         * bindings/js/JSCustomXPathNSResolver.cpp:
3685         * bindings/js/JSDOMWindowCustom.h:
3686         * bindings/js/JSHistoryCustom.cpp:
3687         * bindings/js/ScriptController.h:
3688         * html/HTMLAnchorElement.cpp:
3689         * html/HTMLMediaElement.cpp:
3690         * html/parser/XSSFilter.cpp:
3691         * inspector/InspectorDOMStorageResource.cpp:
3692         * loader/MainResourceLoader.cpp:
3693         * page/DragController.cpp:
3694         * page/EventSource.cpp:
3695         * page/Location.cpp:
3696         * websockets/WebSocket.cpp:
3697         * xml/XSLTProcessorLibxslt.cpp:
3698         Add now missing SecurityOrigin.h #includes.
3699
3700 2011-05-02  Eric Carlson  <eric.carlson@apple.com>
3701
3702         Reviewed by Brady Eidson.
3703
3704         The preload attribute of the video tag is not completely implemented
3705         https://bugs.webkit.org/show_bug.cgi?id=43673
3706         <rdar://problem/7508322>
3707
3708         Tested manually with manual-tests/media-elements/video-preload.html.
3709
3710         * html/HTMLMediaElement.cpp:
3711         (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay.
3712         (WebCore::HTMLMediaElement::prepareForLoad): Ditto.
3713         (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play.
3714         (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'metadata'
3715             because we need to have media data loaded to seek.
3716         (WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.
3717         * html/HTMLMediaElement.h:
3718
3719         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
3720         (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):  Remove 
3721             m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.
3722         (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
3723         (WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn. 
3724             Move all preload logic to setPreload, call it from here.
3725         (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to 
3726             setPreload, call it.
3727         (WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is
3728             unlikely to be correct and isn't worth caching.
3729         (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus
3730             to AssetStatus. Create the AVPlayer once we know an asset is playable but preload is
3731             'metadata'. Set networkState to 'idle' when the playback buffer is full because that is
3732             a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA' 
3733             when the first frame is available.
3734         (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache
3735             width, height, hasVideo, etc.
3736         (WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done
3737             in derived classes.
3738         (WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create
3739             AVAsset and AVPlayerItem here.
3740         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
3741
3742         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
3743         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
3744         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
3745             m_videoFrameHasDrawn.
3746         (WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from
3747             videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
3748             if we have painted a frame to the context.
3749         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset
3750             if necessary.
3751         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
3752         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
3753         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
3754         (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
3755         (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when
3756             the buffer is full.
3757         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the
3758             AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
3759             when we only have metadata.
3760         (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
3761         (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
3762         (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset
3763             when when we haven't allocated the AVPlayerItem yet so that we can report attributes
3764             when we only have metadata.
3765         (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before
3766             we have allocated the AVPlayerItem.
3767
3768 2011-05-02  Philippe Normand  <pnormand@igalia.com>
3769
3770         Reviewed by Martin Robinson.
3771
3772         [GTK] gdk_drawable_get_size() shouldn't be used with GTK+ >= 2.24
3773         https://bugs.webkit.org/show_bug.cgi?id=59932
3774
3775         Use gdk_window_get_width() and gdk_window_get_height() if
3776         available, instead of the deprecated gdk_drawable_get_size().
3777
3778         No new tests, build fix only.
3779
3780         * platform/gtk/WidgetRenderingContext.cpp:
3781         (WebCore::WidgetRenderingContext::WidgetRenderingContext):
3782
3783 2011-05-02  Eric Carlson  <eric.carlson@apple.com>
3784
3785         Reviewed by Brady Eidson.
3786
3787         The preload attribute of the video tag is not completely implemented
3788         https://bugs.webkit.org/show_bug.cgi?id=43673
3789         <rdar://problem/7508322>
3790
3791         Test manually with manual-tests/media-elements/video-preload.html.
3792
3793         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
3794         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
3795         (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Add new "limit read-ahead"
3796             attribute when preload is not "auto".
3797         (WebCore::MediaPlayerPrivateQTKit::resumeLoad): Remove m_delayingLoad, we don't need it.
3798         (WebCore::MediaPlayerPrivateQTKit::load): Correct comment.
3799         (WebCore::MediaPlayerPrivateQTKit::prepareToPlay): Call setPreload('auto').
3800         (WebCore::MediaPlayerPrivateQTKit::setPreload): Set new attribue if we already have
3801             a QTMovie.
3802
3803 2011-05-02  Eric Carlson  <eric.carlson@apple.com>
3804
3805         Reviewed by Brady Eidson.
3806
3807         The preload attribute of the video tag is not completely implemented
3808         https://bugs.webkit.org/show_bug.cgi?id=43673
3809         <rdar://problem/7508322>
3810
3811         Manual test manual-tests/media-elements/video-preload.html added.
3812
3813         * manual-tests/media-elements/video-preload.html: Added. New manual test for media element 
3814             'preload' attribute because it is not possible to detect if a media engine supports 
3815             "preload=metadata" in a way that lets us have per-platform layout test results.
3816
3817 2011-05-01  Abhishek Arya  <inferno@chromium.org>
3818
3819         Reviewed by Eric Carlson.
3820
3821         Regression(r74787): Media document mouse click and double-click
3822         events should be checked on target node only and not its descendants.
3823         https://bugs.webkit.org/show_bug.cgi?id=59886
3824
3825         * html/MediaDocument.cpp:
3826         (WebCore::MediaDocument::defaultEventHandler):
3827
3828 2011-05-01  Adam Barth  <abarth@webkit.org>
3829
3830         Reviewed by Eric Seidel.
3831
3832         Polish CSP host and port matching
3833         https://bugs.webkit.org/show_bug.cgi?id=59899
3834
3835         Finish last two details of host and port matching.  I don't think the
3836         default port handling is testable with our current testing
3837         infrastructure.
3838
3839         Tests: http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html
3840                http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html
3841
3842         * page/ContentSecurityPolicy.cpp:
3843         (WebCore::CSPSource::hostMatches):
3844         (WebCore::CSPSource::portMatches):
3845
3846 2011-05-01  Adam Barth  <abarth@webkit.org>
3847
3848         Reviewed by Eric Seidel.
3849
3850         CSP default-src is missing
3851         https://bugs.webkit.org/show_bug.cgi?id=58641
3852
3853         Add support for default-src.  The default-src provides a default policy
3854         for every directive that sends in "-src".  If the more-specific
3855         directive is present, it takes precedence.  I also took this
3856         opportunity to refactor the internals of ContentSecurityPolicy a bit to
3857         reduce duplicate code.
3858
3859         Tests: http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html
3860                http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html
3861                http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html
3862
3863         * page/ContentSecurityPolicy.cpp:
3864         (WebCore::ContentSecurityPolicy::didReceiveHeader):
3865         (WebCore::ContentSecurityPolicy::checkEval):
3866         (WebCore::ContentSecurityPolicy::operativeDirective):
3867         (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation):
3868         (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation):
3869         (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
3870         (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
3871         (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
3872         (WebCore::ContentSecurityPolicy::allowInlineScript):
3873         (WebCore::ContentSecurityPolicy::allowInlineStyle):
3874         (WebCore::ContentSecurityPolicy::allowEval):
3875         (WebCore::ContentSecurityPolicy::allowScriptFromSource):
3876         (WebCore::ContentSecurityPolicy::allowObjectFromSource):
3877         (WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
3878         (WebCore::ContentSecurityPolicy::allowImageFromSource):
3879         (WebCore::ContentSecurityPolicy::allowStyleFromSource):
3880         (WebCore::ContentSecurityPolicy::allowFontFromSource):
3881         (WebCore::ContentSecurityPolicy::allowMediaFromSource):
3882         (WebCore::ContentSecurityPolicy::addDirective):
3883         * page/ContentSecurityPolicy.h:
3884
3885 2011-05-01  Sam Weinig  <sam@webkit.org>
3886
3887         Reviewed by Anders Carlsson.
3888
3889         Prune some unnecessary #includes
3890         https://bugs.webkit.org/show_bug.cgi?id=59895
3891
3892         Start getting rid of unnecessary #includes and forward declares.
3893
3894         * bindings/js/JSDOMBinding.h:
3895         * bindings/js/JSDOMWindowBase.h:
3896         * bindings/js/JSDOMWindowShell.h:
3897         * bindings/js/ScheduledAction.cpp:
3898         * bindings/js/ScriptController.cpp:
3899         * bindings/js/ScriptController.h:
3900         * bindings/js/ScriptDebugServer.cpp:
3901         * editing/Editor.h:
3902         * inspector/InspectorClient.cpp:
3903         * loader/FrameLoader.h:
3904         * loader/NavigationScheduler.h:
3905         * page/Console.cpp:
3906         * xml/XMLTreeViewer.cpp:
3907         * xml/XMLTreeViewer.h:
3908
3909 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3910
3911         [WIN] Unreviewed buildfix after r85434.
3912
3913         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3914         (WebCore::MediaPlayerPrivate::createLayerForMovie):
3915
3916 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3917
3918         [WIN] Unreviewed buildfix after r85434.
3919
3920         * platform/graphics/win/QTMovieVisualContext.cpp:
3921         (QTMovieVisualContext::QTMovieVisualContext): Added missing header.
3922
3923 2011-05-01  Justin Schuh  <jschuh@chromium.org>
3924
3925         Reviewed by Adam Barth.
3926
3927         History::stateObjectAdded should check origin via SecurityOrigin::canRequest
3928         https://bugs.webkit.org/show_bug.cgi?id=59840
3929
3930         Tests: fast/loader/stateobjects/pushstate-in-data-url-denied.html
3931                http/tests/navigation/replacestate-base-illegal.html
3932                http/tests/navigation/replacestate-base-legal.html
3933
3934         * page/History.cpp:
3935         (WebCore::History::stateObjectAdded):
3936
3937 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3938
3939         [WIN] Unreviewed buildfix after r85434.
3940
3941         * platform/graphics/win/QTMovieVisualContext.cpp:
3942         (QTMovieVisualContext::QTMovieVisualContext):
3943
3944 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3945
3946         Reviewed by Adam Barth.
3947
3948         [WINCE] Fix OwnPtr strict issues
3949         https://bugs.webkit.org/show_bug.cgi?id=59898
3950
3951         * page/wince/FrameWinCE.cpp:
3952         (WebCore::imageFromSelection):
3953         * platform/graphics/wince/FontPlatformData.cpp:
3954         (WebCore::FixedSizeFontData::create):
3955         (WebCore::FontPlatformPrivateData::FontPlatformData::hfont):
3956         (WebCore::FontPlatformPrivateData::FontPlatformData::getScaledFontHandle):
3957         (WebCore::FontPlatformPrivateData::FontPlatformData::discardFontHandle):
3958         * platform/graphics/wince/GraphicsContextWinCE.cpp:
3959         (WebCore::GraphicsContext::strokeArc):
3960         (WebCore::GraphicsContext::fillRect):
3961         (WebCore::GraphicsContext::clip):
3962         (WebCore::GraphicsContext::fillRoundedRect):
3963         (WebCore::GraphicsContext::drawRoundCorner):
3964         (WebCore::GraphicsContext::drawText):
3965         * platform/graphics/wince/ImageBufferWinCE.cpp:
3966         (WebCore::ImageBuffer::ImageBuffer):
3967         * platform/graphics/wince/ImageWinCE.cpp:
3968         (WebCore::BitmapImage::getHBITMAPOfSize):
3969         * platform/graphics/wince/SharedBitmap.cpp:
3970         (WebCore::SharedBitmap::SharedBitmap):
3971
3972 2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>
3973
3974         Reviewed by Eric Seidel.
3975
3976         Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
3977         https://bugs.webkit.org/show_bug.cgi?id=59837
3978
3979         Removed EventHandler::sendContextMenuEvent(NSEvent*) and EventHandler::eventMayStartDrag(NSEvent*)
3980
3981         * WebCore.exp.in:
3982         * page/EventHandler.h:
3983         * page/mac/EventHandlerMac.mm:
3984
3985 2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>
3986
3987         Reviewed by Eric Seidel.
3988
3989         Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
3990         https://bugs.webkit.org/show_bug.cgi?id=59835
3991
3992         Moved currentKeyboardEvent.
3993
3994         * WebCore.exp.in:
3995         * page/EventHandler.h:
3996         * page/mac/EventHandlerMac.mm:
3997
3998 2011-05-01  ojab  <ojab@ojab.ru>
3999
4000         Reviewed by Eric Seidel.
4001
4002         Fix build with --disable-video --enable-fullscreen-api
4003         https://bugs.webkit.org/show_bug.cgi?id=59698
4004
4005         * rendering/RenderTheme.h:
4006         (WebCore::RenderTheme::extraFullScreenStyleSheet):
4007
4008 2011-05-01  Jeff Timanus  <twiz@chromium.org>
4009
4010         Reviewed by Eric Seidel.
4011
4012         Add solid-color checking to BitmapImage::checkForSolidColour in the skia port.
4013         https://bugs.webkit.org/show_bug.cgi?id=59041
4014
4015         Test:css2.1/t140201-c533-bgimage-00-a.html
4016
4017         * platform/graphics/Image.cpp:
4018         (WebCore::Image::drawTiled): Removal of macro exclusion of assert for Skia path.
4019         * platform/graphics/skia/ImageSkia.cpp:
4020         (WebCore::BitmapImage::checkForSolidColor):
4021
4022 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
4023
4024         Reviewed by Adam Barth.
4025
4026         Fix OwnPtr strict issues in windows build
4027         https://bugs.webkit.org/show_bug.cgi?id=59878
4028
4029         * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
4030         (WebCore::getDirtyRects):
4031         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
4032         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
4033         * platform/graphics/win/WKCAImageQueue.cpp:
4034         (WebCore::WKCAImageQueue::WKCAImageQueue):
4035         * platform/win/CursorWin.cpp:
4036         (WebCore::createSharedCursor):
4037         * platform/win/PasteboardWin.cpp:
4038         (WebCore::Pasteboard::writeImage):
4039
4040 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
4041
4042         Reviewed by Eric Seidel.
4043
4044         Use PassOwnPtr as return value of GraphicsContext::createWindowsBitmap
4045         https://bugs.webkit.org/show_bug.cgi?id=59876
4046
4047         Also pass the size "as reference" instead of "as value".
4048
4049         * platform/graphics/GraphicsContext.h:
4050         * platform/graphics/win/FontCGWin.cpp:
4051         (WebCore::drawGDIGlyphs):
4052         * platform/graphics/win/GraphicsContextWin.cpp:
4053         (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap):
4054         (WebCore::GraphicsContext::createWindowsBitmap):
4055         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
4056         (WebCore::MediaPlayerPrivate::paint):
4057
4058 2011-05-01  Emil A Eklund  <eae@chromium.org>
4059
4060         Reviewed by Eric Seidel.
4061
4062         getComputedStyle() returns unitless values for some properties that require units
4063         https://bugs.webkit.org/show_bug.cgi?id=55111
4064
4065         Change getComputedStyle to return value with unit for -webkit-column-width, -webkit-column-gap and -webkit-perspective
4066
4067         Test: fast/css/getComputedStyle/getComputedStyle-length-unit.html
4068
4069         * css/CSSComputedStyleDeclaration.cpp:
4070         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
4071
4072 2011-05-01  Young Han Lee  <joybro@company100.net>
4073
4074         Reviewed by Eric Seidel.
4075
4076         Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
4077         https://bugs.webkit.org/show_bug.cgi?id=59608
4078
4079         TEXMAP_OPENGL_ES2 is a wrong name. TEXMAP_OPENGL_ES_2 is already defined in TextureMapper.h
4080
4081         No new functionality, no new tests.
4082
4083         * platform/graphics/opengl/TextureMapperGL.cpp:
4084         (WebCore::TextureMapperGL::TextureMapperGL):
4085
4086 2011-05-01  Yael Aharon  <yael.aharon@nokia.com>
4087
4088         Reviewed by Eric Seidel.
4089
4090         CSS3 nth-child(n) selector fails
4091         https://bugs.webkit.org/show_bug.cgi?id=56943
4092
4093         Regression from r75158.
4094         "n" is a valid parameter to nth() and should be allowed.
4095
4096         Test: fast/css/nth-child-n.html
4097
4098         * css/CSSParser.cpp:
4099         (WebCore::isValidNthToken):
4100
4101 2011-05-01  Pavel Feldman  <pfeldman@chromium.org>
4102
4103         Not reviewed: address stack frame scriptName -> url rename in timeline panel.
4104
4105         * inspector/front-end/TimelinePanel.js:
4106         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
4107         (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
4108
4109 2011-05-01  Chris Fleizach  <cfleizach@apple.com>
4110
4111         Reviewed by Maciej Stachowiak.
4112
4113         Crash in AccessibilityRenderObject while viewing PDFs in iframes
4114         https://bugs.webkit.org/show_bug.cgi?id=59629
4115
4116         Could not reproduce this crash, but it's quite clear how it could happen.
4117  
4118         * accessibility/AccessibilityRenderObject.cpp:
4119         (WebCore::AccessibilityRenderObject::accessibilityHitTest):
4120
4121 2011-05-01  Nikolas Zimmermann  <nzimmermann@rim.com>
4122
4123         Reviewed by Dirk Schulze.
4124
4125         LEAK: SVGElement leaks when detaching it in a pending resource state
4126         https://bugs.webkit.org/show_bug.cgi?id=59072
4127
4128         Make the pending resources set non-refcounted again. We made it refcounted a while ago
4129         to fix a security bug, as we had dangling pointers in the set in SVGDocumentExtensions.
4130         Fix the underlying problem, by removing all pending resources referencing to a particular
4131         SVGElement, upon its destruction or upon removing it from the document.
4132
4133         Example: <rect fill="url(#foo)" id="rect">
4134         When we try to render the rect, the foo paint server can't be found and thus "foo" will be
4135         added to the pending resource set, with "rect" as client. When "foo" appears, it would remove
4136         itself from the pending resource set, and a ref count to the "rect" would be released.
4137         If "foo" never appears, SVGDocumentExtensions still holds a ref to the <rect>, thus keeping
4138         it and the associated document alive.
4139
4140         Tests: svg/custom/pending-resource-leak-2.svg
4141                svg/custom/pending-resource-leak-3.svg
4142                svg/custom/pending-resource-leak.svg
4143
4144         These tests cover several scenarios where we used to leak. Should fix several SVG*Element leaks on the bots.
4145         I manually tested reloading above testcases dozens of times, before the leak count was incremented by 2 nodes on every reload, that's gone now.
4146
4147         * rendering/svg/RenderSVGResourceContainer.cpp:
4148         (WebCore::RenderSVGResourceContainer::registerResource):
4149         * rendering/svg/RenderSVGShadowTreeRootContainer.cpp:
4150         (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
4151         * rendering/svg/SVGResources.cpp:
4152         (WebCore::registerPendingResource):
4153         * svg/SVGDocumentExtensions.cpp:
4154         (WebCore::SVGDocumentExtensions::addPendingResource):
4155         (WebCore::SVGDocumentExtensions::hasPendingResources):
4156         (WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
4157         (WebCore::SVGDocumentExtensions::removePendingResource):
4158         * svg/SVGDocumentExtensions.h:
4159         * svg/SVGElement.cpp:
4160         * svg/SVGElement.h:
4161         * svg/SVGElementRareData.h:
4162         (WebCore::SVGElementRareData::SVGElementRareData):
4163         (WebCore::SVGElementRareData::hasPendingResources):
4164         (WebCore::SVGElementRareData::setHasPendingResources):
4165         * svg/SVGStyledElement.cpp:
4166         (WebCore::SVGStyledElement::~SVGStyledElement):
4167         (WebCore::SVGStyledElement::insertedIntoDocument):
4168         (WebCore::SVGStyledElement::removedFromDocument):
4169         (WebCore::SVGStyledElement::hasPendingResources):
4170         (WebCore::SVGStyledElement::setHasPendingResources):
4171         * svg/SVGStyledElement.h:
4172         (WebCore::SVGStyledElement::needsPendingResourceHandling):
4173         (WebCore::SVGStyledElement::buildPendingResource):
4174         * svg/SVGUseElement.cpp:
4175         (WebCore::SVGUseElement::SVGUseElement):
4176         (WebCore::SVGUseElement::insertedIntoDocument):
4177         (WebCore::SVGUseElement::svgAttributeChanged):
4178         (WebCore::SVGUseElement::buildPendingResource):
4179         * svg/SVGUseElement.h:
4180
4181 2011-05-01  Rafael Brandao  <rafael.lobo@openbossa.org>
4182
4183         Reviewed by Csaba Osztrogonác.
4184
4185         [Qt] build-webkit warning Inspector.idl is missing
4186         https://bugs.webkit.org/show_bug.cgi?id=59047
4187         
4188         Added variable_out to pipe output from one compiler to another,
4189         and then forced the output to be added to the sources.
4190
4191         * CodeGenerators.pri:
4192
4193 2011-05-01  Dan Bernstein  <mitz@apple.com>
4194
4195         Reviewed by Anders Carlsson.
4196
4197         <rdar://problem/9155067> REGRESSION (float-based line boxes): Gaps and overlaps in selection highlight<