HTMLMetaElement: Don't cache "http-equiv" and "content" attributes.
[WebKit.git] / Source / WebCore / ChangeLog
1 2011-08-26  Andreas Kling  <kling@webkit.org>
2
3         HTMLMetaElement: Don't cache "http-equiv" and "content" attributes.
4         https://bugs.webkit.org/show_bug.cgi?id=67040
5
6         Reviewed by Darin Adler.
7
8         * html/HTMLMetaElement.h: Remove m_equiv and m_content members,
9         shrinking HTMLMetaElement by 16 bytes (on 64-bit.)
10         * html/HTMLMetaElement.cpp:
11         (WebCore::HTMLMetaElement::parseMappedAttribute):
12         (WebCore::HTMLMetaElement::process): Implemented using fastGetAttribute().
13
14 2011-08-26  Pavel Feldman  <pfeldman@google.com>
15
16         Web Inspector: [REGRESSION] No way to expand hovered objects while debugging.
17         https://bugs.webkit.org/show_bug.cgi?id=67039
18
19         Reviewed by Yury Semikhatsky.
20
21         * inspector/front-end/Popover.js:
22         (WebInspector.Popover):
23         (WebInspector.Popover.prototype.show):
24         (WebInspector.PopoverHelper.prototype._mouseDown):
25         (WebInspector.PopoverHelper.prototype._hidePopover):
26         (WebInspector.PopoverHelper.prototype._mouseHover):
27         (WebInspector.PopoverHelper.prototype._killHidePopoverTimer):
28
29 2011-08-26  Pavel Podivilov  <podivilov@chromium.org>
30
31         Unreviewed, rolling out r93870.
32         http://trac.webkit.org/changeset/93870
33         https://bugs.webkit.org/show_bug.cgi?id=65203
34
35         Broke i18n chromium tests
36
37         * platform/graphics/chromium/FontChromiumWin.cpp:
38         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
39         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
40         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
41         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
42         (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
43         (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
44         (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
45         (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
46         (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
47         (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
48         (WebCore::drawGlyphsWin):
49         (WebCore::Font::drawComplexText):
50         * platform/graphics/chromium/UniscribeHelper.cpp:
51         (WebCore::UniscribeHelper::draw):
52         * platform/graphics/skia/PlatformContextSkia.cpp:
53         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
54         * platform/graphics/skia/PlatformContextSkia.h:
55         * platform/graphics/skia/SkiaFontWin.cpp:
56         (WebCore::windowsCanHandleDrawTextShadow):
57         (WebCore::windowsCanHandleTextDrawing):
58         (WebCore::windowsCanHandleTextDrawingWithoutShadow):
59         * platform/graphics/skia/SkiaFontWin.h:
60
61 2011-08-26  Alexei Svitkine  <asvitkine@chromium.org>
62
63         Chromium Mac: Use a custom pattern image for rubber banding overhang area
64         https://bugs.webkit.org/show_bug.cgi?id=66707
65
66         Also roll Chromium revision to 98101, to include dependency: http://codereview.chromium.org/7714036/
67
68         Reviewed by Dimitri Glazkov.
69
70         No new tests since its just changing the Chromium-specific overhang pattern.
71
72         * platform/chromium/ScrollbarThemeChromiumMac.mm:
73         (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
74         (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
75
76 2011-08-26  Eric Carlson  <eric.carlson@apple.com>
77
78         <video> playlist can not advance when playing in background tab
79         https://bugs.webkit.org/show_bug.cgi?id=66978
80
81         Reviewed by Darin Adler.
82
83         No new tests added because it isn't possible to simulate a background tab in DRT.
84
85         * html/HTMLMediaElement.cpp:
86         (WebCore::HTMLMediaElement::HTMLMediaElement): Set RequirePageConsentToLoadMedia restriction.
87         (WebCore::HTMLMediaElement::loadInternal): Don't consider page->canStartMedia if it has ever
88             allowed a file to load.
89         * html/HTMLMediaElement.h:
90         (WebCore::HTMLMediaElement::requirePageConsentToLoadMedia): New.
91         (WebCore::HTMLMediaElement::removeBehaviorRestriction): New.
92
93 2011-08-26  Andreas Kling  <kling@webkit.org>
94
95         [Qt] Path::boundingRect() is unnecessarily slow.
96         https://bugs.webkit.org/show_bug.cgi?id=66854
97
98         Reviewed by Benjamin Poulain.
99
100         * html/canvas/CanvasRenderingContext2D.cpp:
101         (WebCore::CanvasRenderingContext2D::stroke): Remove Qt-specific optimization
102         since calling Path::boundingRect() will now do exactly the same thing.
103         * platform/graphics/qt/PathQt.cpp:
104         (WebCore::Path::boundingRect): Return QPainterPath::controlPointRect() since
105         that is much faster than computing the (precise) QPainterPath::boundingRect()
106         and Path::boundingRect() is not expected to be 100% precise anyway.
107
108 2011-08-26  Gavin Peters  <gavinp@chromium.org>
109
110         add a state enumeration to track down cause of null CachedScript execution
111         https://bugs.webkit.org/show_bug.cgi?id=66939
112
113         Reviewed by Alexey Proskuryakov.
114
115         Over in http://code.google.com/p/chromium/issues/detail?id=75604 I
116         have a bug I cannot reproduce.  I added an earlier crash in
117         https://bugs.webkit.org/show_bug.cgi?id=65563 , and we've since
118         gotten many good stacks, all coming in through a failed request that
119         eventually calls notifyFinished() on a ScriptElement with a NULL
120         m_cachedScript.
121
122         I'd like to know how this got NULL.  This enumeration should let
123         me find that in stack dumps from reproductions.
124
125         No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.
126
127         * dom/ScriptElement.cpp:
128         (WebCore::ScriptElement::ScriptElement):
129         (WebCore::ScriptElement::requestScript):
130         (WebCore::ScriptElement::stopLoadRequest):
131         (WebCore::ScriptElement::notifyFinished):
132         * dom/ScriptElement.h:
133
134 2011-08-26  Mike Reed  <reed@google.com>
135
136         [skia] never draw with GDI, so that all text can be gpu-accelerated
137         https://bugs.webkit.org/show_bug.cgi?id=65203
138
139         Reviewed by Kenneth Russell.
140
141         * platform/graphics/chromium/FontChromiumWin.cpp:
142         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
143         (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
144         (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
145         (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
146         (WebCore::drawGlyphsWin):
147         (WebCore::Font::drawComplexText):
148         * platform/graphics/chromium/UniscribeHelper.cpp:
149         (WebCore::UniscribeHelper::draw):
150         * platform/graphics/skia/PlatformContextSkia.cpp:
151         * platform/graphics/skia/PlatformContextSkia.h:
152         * platform/graphics/skia/SkiaFontWin.cpp:
153         * platform/graphics/skia/SkiaFontWin.h:
154
155 2011-08-26  Ilya Tikhonovsky  <loislo@chromium.org>
156
157         Web Inspector: in some cases Popover code is failing to calculate popover box position.
158         https://bugs.webkit.org/show_bug.cgi?id=67029
159
160         Reviewed by Yury Semikhatsky.
161
162         * inspector/front-end/Popover.js:
163         (WebInspector.Popover.prototype._positionElement):
164
165 2011-08-26  Nikolas Zimmermann  <nzimmermann@rim.com>
166
167         [Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
168         https://bugs.webkit.org/show_bug.cgi?id=65969
169
170         Reviewed by Zoltan Herczeg.
171
172         Fix intrinsic size negotiation flakiness, most visible on the Qt port.
173
174         The http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm testcase triggered
175         an assertion on a Qt debug build indicating that the HashSet updateLayoutAndStyleIfNeededRecursive()
176         operates on is mutated while its iterated, leading to an assertion/crash. Due the new forceLayoutParentViewIfNeeded()
177         logic it's no longer safe to directly use the children() HashSet in that method - we have to make a copy first.
178
179         The second part of the fix is to stop entering forceLayoutParentViewIfNeeded(), if the origin of that call
180         is forceLayoutParentViewIfNeeded() itself. Set m_inLayoutParentView to true before calling FrameView::layout()
181         on our parent frame view - this is only an optimization to avoid doing layout() twice.
182
183         The third part of the fix is to call updateWidgetPositions() on the parent FrameView, _before_ calling layout()
184         on the parent view itself, as the SVG document needs to report the correct intrinsic size (which can depend
185         on the host object/embed/iframe) when we're running RenderReplaced::layout() on the host renderer.
186
187         * page/FrameView.cpp:
188         (WebCore::FrameView::FrameView):
189         (WebCore::collectFrameViewChildren):
190         (WebCore::FrameView::forceLayoutParentViewIfNeeded):
191         (WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
192         * page/FrameView.h:
193
194 2011-08-26  Mikhail Naganov  <mnaganov@chromium.org>
195
196         Web Inspector: [Chromium] Double clicking on numbers in Count & size columns doesn't toggle between values and percents in the Heap Snapshot.
197         https://bugs.webkit.org/show_bug.cgi?id=66988
198
199         Reviewed by Pavel Feldman.
200
201         * inspector/front-end/DetailedHeapshotView.js:
202         (WebInspector.DetailedHeapshotView.prototype._mouseClickInContentsGrid):
203         (WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):
204
205 2011-08-26  Shinya Kawanaka  <shinyak@google.com>
206
207         REGRESSION(r93390): Empty or invalid maxlength of an input tag should be ignored.
208         https://bugs.webkit.org/show_bug.cgi?id=67015
209
210         Reviewed by Kent Tamura.
211
212         * html/HTMLInputElement.cpp:
213         (WebCore::HTMLInputElement::parseMaxLengthAttribute):
214           Checks the validity of maxlength attribute when converting it to integer.
215
216 2011-08-25  Yuta Kitamura  <yutak@chromium.org>
217
218         WebSocket: Fix indentation of WebSocket header files
219         https://bugs.webkit.org/show_bug.cgi?id=67018
220
221         Reviewed by Kent Tamura.
222
223         No new tests. Style fix only.
224
225         * websockets/WebSocket.h:
226         (WebCore::WebSocket::create):
227         (WebCore::WebSocket::toWebSocket):
228         (WebCore::WebSocket::refEventTarget):
229         (WebCore::WebSocket::derefEventTarget):
230         * websockets/WebSocketChannel.h:
231         Removed formal parameter name of resumeTimerFired().
232         (WebCore::WebSocketChannel::create):
233         (WebCore::WebSocketChannel::refThreadableWebSocketChannel):
234         (WebCore::WebSocketChannel::derefThreadableWebSocketChannel):
235         (WebCore::WebSocketChannel::isNonControlOpCode):
236         (WebCore::WebSocketChannel::isControlOpCode):
237         (WebCore::WebSocketChannel::isReservedOpCode):
238         * websockets/WebSocketHandshake.h:
239         Removed formal parameter name of setClientProtocol().
240
241 2011-08-25  Martin Robinson  <mrobinson@igalia.com>
242
243         Touch GtkVersioning.c so that the release bot rebuilds it. This
244         is necessary because of the switch to GTK+ 3.x.
245
246         * platform/gtk/GtkVersioning.c: Touch this file.
247
248 2011-08-25  Ben Wells  <benwells@chromium.org>
249
250         Use PATH_BASED_BORDER_RADIUS_DRAWING for skia
251         https://bugs.webkit.org/show_bug.cgi?id=65583
252
253         This change brings in the new border rendering for Skia. To support this without aliasing the skia
254         graphics context has been updated to support anti-aliased clipping around convex polygons and also
255         anti-aliased clipping outside a path.
256
257         Reviewed by James Robinson.
258
259         * platform/graphics/skia/GraphicsContextSkia.cpp:
260         (WebCore::GraphicsContext::clipOut):
261         (WebCore::GraphicsContext::clipConvexPolygon):
262         * platform/graphics/skia/PlatformContextSkia.cpp:
263         (WebCore::PlatformContextSkia::clipPathAntiAliased):
264         * rendering/RenderObject.h:
265
266 2011-08-25  Luke Macpherson   <macpherson@chromium.org>
267
268         Implement animation and transition properties in CSSStyleApplyProperty.
269         https://bugs.webkit.org/show_bug.cgi?id=66126
270
271         Reviewed by Dean Jackson.
272
273         No new tests. This is essentially a refactoring of the HANDLE_ANIMATION* and HANDLE_TRANSITION* macros in CSSStyleSelector.cpp.
274         The only functional change is to iterate correctly over the lists instead of setting only the first element. See bug 66118 for details on that.
275
276         * css/CSSStyleApplyProperty.cpp:
277         Added new class ApplyPropertyAnimation to handle animation and transition properties.
278         (WebCore::ApplyPropertyAnimation::ApplyPropertyAnimation):
279         (WebCore::ApplyPropertyAnimation::applyInheritValue):
280         (WebCore::ApplyPropertyAnimation::applyInitialValue):
281         (WebCore::ApplyPropertyAnimation::applyValue):
282         (WebCore::ApplyPropertyAnimation::setValue):
283         (WebCore::ApplyPropertyAnimation::value):
284         (WebCore::ApplyPropertyAnimation::test):
285         (WebCore::ApplyPropertyAnimation::clear):
286         (WebCore::ApplyPropertyAnimation::initial):
287         (WebCore::ApplyPropertyAnimation::map):
288         (WebCore::ApplyPropertyAnimation::accessAnimations):
289         (WebCore::ApplyPropertyAnimation::animations):
290         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
291         * css/CSSStyleSelector.cpp:
292         Removed animation and transition macros (celebrate!)
293         (WebCore::CSSStyleSelector::applyProperty):
294         Removed old implementations of animation and transition properties.
295         * platform/animation/Animation.h:
296         Changed return types of initial values to match the setters and getters.
297         (WebCore::Animation::initialAnimationDelay):
298         (WebCore::Animation::initialAnimationName):
299         (WebCore::Animation::initialAnimationTimingFunction):
300
301 2011-08-25  Julien Chaffraix  <jchaffraix@webkit.org>
302
303         Concentrate RenderLayer repaint rects updates
304         https://bugs.webkit.org/show_bug.cgi?id=64993
305
306         Reviewed by David Hyatt.
307
308         The change moves the update of the repaint rects to 2 methods
309         (computeRepaintRects and clearRepaintRects) to better track
310         those changes.
311
312         No new test, refactoring covered by the existing test cases.
313
314         * rendering/RenderLayer.cpp:
315         (WebCore::RenderLayer::updateLayerPositions): Reverse the logic and
316         calculate the new bounds upfront. This should have no impact as none
317         of the methods rely on the internal value.
318
319         (WebCore::RenderLayer::computeRepaintRects): Added the cachedOffset parameter
320         to avoid breaking the performance optimization in updateLayerPositions. Added
321         some ASSERTS.
322
323         (WebCore::RenderLayer::clearRepaintRects): Added some ASSERTs here.
324         (WebCore::RenderLayer::updateRepaintRectsAfterScroll): Added a FIXME as this
325         method could use the cachedOffset trick too.
326
327         (WebCore::RenderLayer::setHasVisibleContent): Changed the code to use
328         computeRepaintRects.
329
330         * rendering/RenderLayer.h: Updated the signature of computeRepaintRects and moved
331         those 2 methods into the private section of the class.
332
333 2011-08-25  Van Lam  <vanlam@google.com>
334
335         Remove use of magic number -1 in WebCore/editing/visible_units.cpp
336         https://bugs.webkit.org/show_bug.cgi?id=66980
337
338         Reviewed by Ryosuke Niwa.
339
340         Replaced use of magic number -1 with constant offsetNotFound.
341
342         * editing/visible_units.cpp:
343         (WebCore::greatestOffsetUnder):
344         (WebCore::smallestOffsetAbove):
345
346 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
347
348         Rollout r93799: Caused bad clipping on the bottom of tall glyphs inside a button label
349
350         * rendering/RenderBlockLineLayout.cpp:
351         (WebCore::RenderBlock::layoutInlineChildren):
352         * rendering/RenderBox.cpp:
353         * rendering/RenderBox.h:
354         (WebCore::RenderBox::hasControlClip):
355         (WebCore::RenderBox::controlClipRect):
356         * rendering/RenderButton.cpp:
357         (WebCore::RenderButton::setupInnerStyle):
358
359 2011-08-25  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
360
361         [Qt] Enable password echo on Symbian builds
362         https://bugs.webkit.org/show_bug.cgi?id=66954
363
364         Reviewed by Chang Shu.
365
366         No tests, as this is just a build change.
367
368         * config.h:
369
370 2011-08-25  Nate Chapin  <japhet@chromium.org>
371
372         Windows build fix after r93811.
373
374         * loader/cf/ResourceLoaderCFNet.cpp:
375         (WebCore::ResourceLoader::shouldCacheResponse):
376
377 2011-08-25  Nate Chapin  <japhet@chromium.org>
378
379         Split some of the variables out of ThreadableLoaderOptions
380         into a superclass, ResourceLoaderOptions. Use ResourceLoaderOptions
381         all the way down to ResourceLoader.
382         https://bugs.webkit.org/show_bug.cgi?id=63301
383
384         Reviewed by David Levin.
385
386         No new tests, refractor only.
387
388         * GNUmakefile.list.am:
389         * WebCore.gypi:
390         * WebCore.vcproj/WebCore.vcproj:
391         * WebCore.xcodeproj/project.pbxproj:
392         * loader/DocumentThreadableLoader.cpp:
393         * loader/MainResourceLoader.cpp:
394         * loader/NetscapePlugInStreamLoader.cpp:
395         * loader/ResourceLoadScheduler.cpp:
396         * loader/ResourceLoadScheduler.h:
397         * loader/ResourceLoader.cpp:
398         * loader/ResourceLoader.h:
399         * loader/ResourceLoaderOptions.h: Added.
400         * loader/SubresourceLoader.cpp:
401         * loader/SubresourceLoader.h:
402         * loader/ThreadableLoader.h:
403         * loader/cache/CachedResourceRequest.cpp:
404         * loader/mac/ResourceLoaderMac.mm:
405
406 2011-08-25  Adam Klein  <adamk@chromium.org>
407
408         use strict in CodeGeneratorJS and CodeGeneratorV8
409         https://bugs.webkit.org/show_bug.cgi?id=66915
410
411         Reviewed by Darin Adler.
412
413         Making these files "use strict" makes changing them less
414         time-consuming and error-prone, and helps avoid accidentally
415         adding dead code (added a FIXME for one such case).
416
417         No expected change in behavior.
418
419         * bindings/scripts/CodeGeneratorJS.pm:
420         (AddIncludesForType):
421         (GenerateParametersCheckExpression):
422         (GenerateFunctionParametersCheck):
423         (GenerateImplementation):
424         (GenerateImplementationFunctionCall):
425         (NativeToJSValue):
426         (GenerateHashValue):
427         * bindings/scripts/CodeGeneratorV8.pm:
428         (AddIncludesForType):
429         (GenerateHeaderNamedAndIndexedPropertyAccessors):
430         (GenerateNormalAttrSetter):
431         (GetFunctionTemplateCallbackName):
432         (GenerateNewFunctionTemplate):
433         (GenerateParametersCheckExpression):
434         (GenerateFunctionParametersCheck):
435         (GenerateImplementation):
436         ():
437
438 2011-08-25  Dean Jackson  <dino@apple.com>
439
440         https://bugs.webkit.org/show_bug.cgi?id=21586
441         Apply CSS animations and transitions to SVG properties
442
443         Reviewed by Simon Fraser.
444
445         Expose the applicable SVG properties from SVGRenderStyle to
446         RenderStyle and add them to the list of animatable
447         properties. There aren't many SVG properties that are
448         animatable directly. SVGPaint (used in "fill" and "stroke")
449         is supported only when both ends of the animation are
450         a Color. Also updated SVGLength to have some methods
451         for converting to and from user space units.
452
453         Test: transitions/svg-transitions.html
454
455         * page/animation/AnimationBase.cpp:
456         (WebCore::blendFunc):
457             Calls the blend method on SVGLength
458         (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
459             New property wrapper type for SVGPaint
460         (WebCore::PropertyWrapperSVGPaint::equals):
461         (WebCore::PropertyWrapperSVGPaint::blend):
462         (WebCore::AnimationBase::ensurePropertyMap):
463         * rendering/style/RenderStyle.h:
464         (WebCore::InheritedFlags::fillPaintType):
465         (WebCore::InheritedFlags::fillPaintColor):
466         (WebCore::InheritedFlags::setFillPaintColor):
467         (WebCore::InheritedFlags::strokePaintType):
468         (WebCore::InheritedFlags::strokePaintColor):
469         (WebCore::InheritedFlags::setStrokePaintColor):
470         (WebCore::InheritedFlags::strokeWidth):
471         (WebCore::InheritedFlags::setStrokeWidth):
472         (WebCore::InheritedFlags::strokeDashOffset):
473         (WebCore::InheritedFlags::setStrokeDashOffset):
474         (WebCore::InheritedFlags::strokeMiterLimit):
475         (WebCore::InheritedFlags::setStrokeMiterLimit):
476         (WebCore::InheritedFlags::stopOpacity):
477         (WebCore::InheritedFlags::setStopOpacity):
478         (WebCore::InheritedFlags::setStopColor):
479         (WebCore::InheritedFlags::setFloodColor):
480         (WebCore::InheritedFlags::setLightingColor):
481         (WebCore::InheritedFlags::baselineShiftValue):
482         (WebCore::InheritedFlags::setBaselineShiftValue):
483         (WebCore::InheritedFlags::kerning):
484         (WebCore::InheritedFlags::setKerning):
485         (WebCore::InheritedFlags::stopColor):
486         (WebCore::InheritedFlags::floodColor):
487         (WebCore::InheritedFlags::lightingColor):
488         * rendering/style/SVGRenderStyle.h:
489         (WebCore::SVGRenderStyle::stopColor):
490         (WebCore::SVGRenderStyle::floodColor):
491         (WebCore::SVGRenderStyle::lightingColor):
492         * svg/SVGLength.cpp:
493         (WebCore::SVGLength::value):
494         (WebCore::SVGLength::setValue):
495         (WebCore::SVGLength::convertValueFromUserUnits):
496         (WebCore::SVGLength::convertValueToUserUnits):
497             New conversion functions used when setting and getting values
498         * svg/SVGLength.h:
499         (WebCore::SVGLength::isZero):
500         (WebCore::SVGLength::blend):
501             Custom blend function that takes into account
502             whether the units of a length can be converted
503             in an animation, where you don't necessarily have
504             an SVGElement for context.
505
506 2011-08-25  Kent Tamura  <tkent@chromium.org>
507
508         REGRESSION(r90971): Fix an assertion failure with textarea placeholder.
509         https://bugs.webkit.org/show_bug.cgi?id=66164
510
511         Reviewed by Dave Hyatt.
512          
513         Minor patch nits addressed by inferno@chromium.org, on Hyatt's
514         review.
515
516         Test: fast/forms/textarea-placeholder-relayout-assertion.html
517
518         * rendering/RenderTextControl.cpp:
519         (WebCore::RenderTextControl::layoutSpecialExcludedChild):
520         Pass 'false' to the 'markParents' argument of setChildNeedsLayout().
521         We don't need to propagate needsLayout for ancestors because
522         layoutSpecialExcludedChild() is called from layout() of the
523         parent.
524
525 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
526
527         Text-overflow is broken for button elements
528         https://bugs.webkit.org/show_bug.cgi?id=53438
529
530         Fix text-overflow for button elements. Make the element inside
531         the button inherit the button controlClip.
532
533         Reviewed by David Hyatt.
534
535         Test: fast/css/button-overflow-ellipsis.html
536
537         * rendering/RenderBlockLineLayout.cpp:
538         (WebCore::RenderBlock::layoutInlineChildren):
539         * rendering/RenderBox.cpp:
540         (WebCore::RenderBox::controlClipRect):
541         * rendering/RenderBox.h:
542         (WebCore::RenderBox::hasControlClip):
543         * rendering/RenderButton.cpp:
544         (WebCore::RenderButton::setupInnerStyle):
545
546 2011-08-24  Adrienne Walker  <enne@google.com>
547
548         [chromium] Update VideoLayerChromium to not access GC3D on the main thread
549         https://bugs.webkit.org/show_bug.cgi?id=66434
550
551         Reviewed by James Robinson.
552
553         Covered by existing tests.
554
555         This change allows the main thread VideoLayerChromium to not depend on
556         compositor thread resources (GC3D, LayerRendererChromium). The texture
557         allocation in VideoLayerChromium was changed to use ManagedTexture so
558         that textures can now be evicted when there is texture memory pressure
559         and so that destruction can be automatically deferred until a GC3D is
560         available.
561
562         * platform/graphics/chromium/LayerRendererChromium.cpp:
563         * platform/graphics/chromium/LayerRendererChromium.h:
564         * platform/graphics/chromium/ManagedTexture.cpp:
565         * platform/graphics/chromium/ManagedTexture.h:
566         (WebCore::ManagedTexture::size):
567         (WebCore::ManagedTexture::format):
568         * platform/graphics/chromium/VideoLayerChromium.cpp:
569         (WebCore::VideoLayerChromium::VideoLayerChromium):
570         (WebCore::VideoLayerChromium::~VideoLayerChromium):
571         (WebCore::VideoLayerChromium::cleanupResources):
572         (WebCore::VideoLayerChromium::updateCompositorResources):
573         (WebCore::VideoLayerChromium::pushPropertiesTo):
574         (WebCore::VideoLayerChromium::setLayerTreeHost):
575         (WebCore::VideoLayerChromium::determineTextureFormat):
576         (WebCore::VideoLayerChromium::reserveTextures):
577         (WebCore::VideoLayerChromium::updateTexture):
578         (WebCore::VideoLayerChromium::releaseCurrentFrame):
579         * platform/graphics/chromium/VideoLayerChromium.h:
580         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
581         (WebCore::CCLayerTreeHost::contentsTextureManager):
582         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
583         * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
584         (WebCore::CCVideoLayerImpl::setTexture):
585         (WebCore::CCVideoLayerImpl::drawYUV):
586         (WebCore::CCVideoLayerImpl::drawRGBA):
587         * platform/graphics/chromium/cc/CCVideoLayerImpl.h:
588
589 2011-08-25  Abhishek Arya  <inferno@chromium.org>
590
591         Incorrect layout of :before and :after content, with display
592         table, table-row and table-cell.
593         https://bugs.webkit.org/show_bug.cgi?id=66699
594
595         Reviewed by David Hyatt.
596
597         Tests: fast/table/table-after-child-in-table.html
598                fast/table/table-before-child-in-table.html
599                fast/table/table-cell-after-child-in-block.html
600                fast/table/table-cell-after-child-in-table.html
601                fast/table/table-cell-before-child-in-block.html
602                fast/table/table-cell-before-child-in-table.html
603                fast/table/table-row-after-child-in-block.html
604                fast/table/table-row-after-child-in-table.html
605                fast/table/table-row-before-child-in-block.html
606                fast/table/table-row-before-child-in-table.html
607
608         * rendering/RenderBlock.cpp:
609         (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
610         Fix the looping condition to detect :after child correctly.
611         isAnonymousBlock() does not apply to tables, instead
612         using isAnonymous().
613         * rendering/RenderTableRow.cpp:
614         (WebCore::RenderTableRow::addChild): Don't add the new child
615         in the generatedContainer with :before, :after content.
616         * rendering/RenderTableSection.cpp:
617         (WebCore::RenderTableSection::addChild): Don't add the new child
618         in the generatedContainer with :before, :after content.
619
620 2011-08-25  Sam Weinig  <sam@webkit.org>
621
622         JSHTMLImageElement (and associated Node) is abandoned when image load is canceled via beforeload
623         <rdar://problem/9925630>
624         https://bugs.webkit.org/show_bug.cgi?id=66906
625
626         Reviewed by Darin Adler.
627
628         * loader/ImageLoader.cpp:
629         (WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
630         Very similar fix to the one in r93717 except this patches the case where the image load was
631         canceled via beforeload.
632
633 2011-08-25  John Bates  <jbates@google.com>
634
635         [chromium] Leaking SkBitmaps for background images
636         https://bugs.webkit.org/show_bug.cgi?id=66488
637
638         Reviewed by Stephen White.
639
640         This patch simply changes NativeImageSkia to have a SkBitmap instead of
641         deriving from SkBitmap. All dependent code updated to access the member
642         instead of calling SkBitmap methods on NativeImageSkia objects. This
643         may or may not fix the memory leak, but it's definitely a bug that could
644         cause memory leaks.
645
646         * platform/chromium/DragImageChromiumSkia.cpp:
647         (WebCore::createDragImageFromImage):
648         * platform/graphics/chromium/PlatformImage.cpp:
649         (WebCore::PlatformImage::updateFromImage):
650         * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
651         (WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):
652         (WebCore::BitmapImageSingleFrameSkia::size):
653         (WebCore::BitmapImageSingleFrameSkia::notSolidColor):
654         * platform/graphics/skia/GraphicsContext3DSkia.cpp:
655         (WebCore::GraphicsContext3D::getImageData):
656         * platform/graphics/skia/ImageSkia.cpp:
657         (WebCore::paintSkBitmap):
658         (WebCore::Image::drawPattern):
659         (WebCore::BitmapImage::checkForSolidColor):
660         * platform/graphics/skia/NativeImageSkia.cpp:
661         (WebCore::NativeImageSkia::NativeImageSkia):
662         (WebCore::NativeImageSkia::decodedSize):
663         (WebCore::NativeImageSkia::resizedBitmap):
664         * platform/graphics/skia/NativeImageSkia.h:
665         (WebCore::NativeImageSkia::bitmap):
666         * platform/graphics/skia/PatternSkia.cpp:
667         (WebCore::Pattern::platformPattern):
668         * platform/image-decoders/ImageDecoder.h:
669         (WebCore::ImageFrame::getAddr):
670         * platform/image-decoders/skia/ImageDecoderSkia.cpp:
671         (WebCore::ImageFrame::operator=):
672         (WebCore::ImageFrame::clearPixelData):
673         (WebCore::ImageFrame::zeroFillPixelData):
674         (WebCore::ImageFrame::copyBitmapData):
675         (WebCore::ImageFrame::setSize):
676         (WebCore::ImageFrame::hasAlpha):
677         (WebCore::ImageFrame::setHasAlpha):
678         (WebCore::ImageFrame::width):
679         (WebCore::ImageFrame::height):
680
681 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
682
683         Unreviewed, rolling out r93774.
684         http://trac.webkit.org/changeset/93774
685         https://bugs.webkit.org/show_bug.cgi?id=66945
686
687         It broke 26 tests on the Qt bot (Requested by ossy on
688         #webkit).
689
690         * html/canvas/CanvasRenderingContext2D.cpp:
691         (WebCore::CanvasRenderingContext2D::stroke):
692         * platform/graphics/qt/PathQt.cpp:
693         (WebCore::Path::boundingRect):
694
695 2011-08-25  Andrey Kosyakov  <caseq@chromium.org>
696
697         Web Inspector: [refactoring] use PopoverHelper to implement popup in the SourceFrame
698         https://bugs.webkit.org/show_bug.cgi?id=66858
699
700         Reviewed by Pavel Feldman.
701
702         * inspector/front-end/DetailedHeapshotView.js:
703         (WebInspector.DetailedHeapshotView.prototype._showStringContentPopover):
704         * inspector/front-end/NetworkPanel.js:
705         (WebInspector.NetworkLogView.prototype.initializeView):
706         (WebInspector.NetworkLogView.prototype.willHide):
707         (WebInspector.NetworkLogView.prototype._reset):
708         (WebInspector.NetworkLogView.prototype.switchToBriefView):
709         (WebInspector.NetworkLogView.prototype._showPopover):
710         * inspector/front-end/Popover.js:
711         (WebInspector.Popover):
712         (WebInspector.Popover.prototype.show):
713         (WebInspector.Popover.prototype.dispose):
714         (WebInspector.PopoverHelper):
715         (WebInspector.PopoverHelper.prototype._mouseMove.doHide):
716         (WebInspector.PopoverHelper.prototype._mouseMove):
717         (WebInspector.PopoverHelper.prototype.hidePopover):
718         (WebInspector.PopoverHelper.prototype._hidePopover):
719         (WebInspector.PopoverHelper.prototype._mouseHover):
720         (WebInspector.PopoverHelper.prototype._killHidePopupTimer):
721         * inspector/front-end/SourceFrame.js:
722         (WebInspector.SourceFrame.prototype.willHide):
723         (WebInspector.SourceFrame.prototype._initializeTextViewer):
724         (WebInspector.SourceFrame.prototype._scroll):
725         (WebInspector.SourceFrame.prototype._mouseDown):
726         (WebInspector.SourceFrame.prototype._onHidePopover):
727         (WebInspector.SourceFrame.prototype._shouldShowPopover):
728         (WebInspector.SourceFrame.prototype._getPopoverAnchor):
729         (WebInspector.SourceFrame.prototype._highlightExpression):
730         (WebInspector.SourceFrame.prototype._onShowPopover.showObjectPopover):
731         (WebInspector.SourceFrame.prototype._onShowPopover):
732         * inspector/front-end/TimelinePanel.js:
733         (WebInspector.TimelinePanel):
734         (WebInspector.TimelinePanel.prototype._showPopover):
735         (WebInspector.TimelinePanel.prototype._closeRecordDetails):
736
737 2011-08-25  Pavel Feldman  <pfeldman@google.com>
738
739         [Qt] REGRESSION(93769): inspector/console/console-tests.html fails
740         https://bugs.webkit.org/show_bug.cgi?id=66930
741
742         Reviewed by Yury Semikhatsky.
743
744         Test: inspector/console/console-repeat-count.html
745
746         * inspector/front-end/ConsoleModel.js:
747         (WebInspector.ConsoleModel):
748         (WebInspector.ConsoleModel.prototype.addMessage):
749         (WebInspector.ConsoleModel.prototype.clearMessages):
750         (WebInspector.ConsoleModel.prototype.interruptRepeatCount):
751         (WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
752         (WebInspector.ConsoleDispatcher.prototype.messageRepeatCountUpdated):
753         * inspector/front-end/ConsoleView.js:
754         (WebInspector.ConsoleView.prototype._consoleMessageAdded):
755         * inspector/front-end/inspector.js:
756
757 2011-08-25  Mikhail Naganov  <mnaganov@chromium.org>
758
759         Chromium: expose MemoryCache::prune and FontCache::purgeInactiveFontData.
760         https://bugs.webkit.org/show_bug.cgi?id=66132
761
762         Reviewed by Tony Gentilcore.
763
764         * loader/cache/MemoryCache.cpp:
765         (WebCore::MemoryCache::prune):
766         (WebCore::MemoryCache::pruneToPercentage):
767         * loader/cache/MemoryCache.h: Methods moved from .h to .cpp to work around compilation problem with the Win Chromium port.
768
769 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
770
771         Unreviewed, rolling out r93771.
772         http://trac.webkit.org/changeset/93771
773         https://bugs.webkit.org/show_bug.cgi?id=66933
774
775         Broke css3/font-feature-settings-rendering.html on chromium
776         mac 10.5 (Requested by podivilov on #webkit).
777
778         * platform/graphics/mac/FontCustomPlatformData.cpp:
779         (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
780         (WebCore::createFontCustomPlatformData):
781         * platform/graphics/mac/FontCustomPlatformData.h:
782         (WebCore::FontCustomPlatformData::FontCustomPlatformData):
783
784 2011-08-23  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
785
786         [Qt][WK2] Drive tiling from the WebProcess and reuse TiledBackingStore.
787         https://bugs.webkit.org/show_bug.cgi?id=66771
788
789         Reviewed by Tor Arne Vestbø.
790
791         We need the tiling logic to be moved to the web process to allow invalidated tile rects to be
792         rendered with the same layout. This also allows the web process to render tiles into
793         buffers readable directly by the GPU (on supported platforms). We also take the opportunity
794         to use the TiledBackingStore in WebCore to have only one tiling implementation.
795
796         Before this patch:
797         - TiledDrawingAreaProxy manages tiles from the UI process.
798         - TiledDrawingArea received rendering requests for a rect and returns the result
799           to the proxy through shared memory.
800
801         After this patch:
802         - TiledDrawingArea uses a TiledBackingStore to manage tiles from the web process.
803         - TiledBackingStoreRemoteTile forwards tile creations, update and removals to the proxy.
804         - TiledDrawingAreaProxy updates the scene graph directly from requests.
805
806         It also implements tile buffer swapping correctly in SGTileNode, triggered by the DidRenderFrame message.
807         Render throttling is implemented by waiting in TiledDrawingArea for the UI process to
808         notify us when the last rendered frame is ready to make it to the screen.
809         TiledDrawingAreaTileSets have been replaced by using two instances of TiledBackingStore instead.
810
811         * platform/graphics/TiledBackingStore.cpp:
812         (WebCore::TiledBackingStore::updateTileBuffers):
813         (WebCore::TiledBackingStore::coverageRatio):
814         (WebCore::TiledBackingStore::startTileBufferUpdateTimer):
815         * platform/graphics/TiledBackingStore.h:
816         * platform/graphics/TiledBackingStoreClient.h:
817         (WebCore::TiledBackingStoreClient::tiledBackingStoreIsUpdatingAllowed):
818
819 2011-08-23  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
820
821         TiledBackingStore: Untie the tile implementation from the platform.
822         https://bugs.webkit.org/show_bug.cgi?id=66760
823
824         Reviewed by Kenneth Rohde Christiansen.
825
826         Make the Tile class polymorphic and introduce TiledBackingStoreBackend as a Tile factory.
827
828         * platform/graphics/Tile.h:
829         (WebCore::Tile::~Tile):
830         * platform/graphics/TiledBackingStore.cpp:
831         (WebCore::TiledBackingStore::TiledBackingStore):
832         (WebCore::TiledBackingStore::paint):
833         (WebCore::TiledBackingStore::createTiles):
834         * platform/graphics/TiledBackingStore.h:
835         (WebCore::TiledBackingStore::client):
836         * platform/graphics/TiledBackingStoreBackend.h: Added.
837         (WebCore::TiledBackingStoreBackend::create):
838         (WebCore::TiledBackingStoreBackend::~TiledBackingStoreBackend):
839         (WebCore::TiledBackingStoreBackend::TiledBackingStoreBackend):
840         * platform/graphics/qt/TileQt.cpp:
841         (WebCore::TileQt::TileQt):
842         (WebCore::TileQt::~TileQt):
843         (WebCore::TileQt::isDirty):
844         (WebCore::TileQt::isReadyToPaint):
845         (WebCore::TileQt::invalidate):
846         (WebCore::TileQt::updateBackBuffer):
847         (WebCore::TileQt::swapBackBufferToFront):
848         (WebCore::TileQt::paint):
849         (WebCore::TiledBackingStoreBackend::paintCheckerPattern):
850         (WebCore::TiledBackingStoreBackend::createTile):
851         * platform/graphics/qt/TileQt.h: Copied from Source/WebCore/platform/graphics/Tile.h.
852         (WebCore::TileQt::create):
853         (WebCore::TileQt::coordinate):
854         (WebCore::TileQt::rect):
855
856 2011-08-25  Andreas Kling  <kling@webkit.org>
857
858         [Qt] Path::boundingRect() is unnecessarily slow.
859         https://bugs.webkit.org/show_bug.cgi?id=66854
860
861         Reviewed by Benjamin Poulain.
862
863         * html/canvas/CanvasRenderingContext2D.cpp:
864         (WebCore::CanvasRenderingContext2D::stroke): Remove Qt-specific optimization
865         since calling Path::boundingRect() will now do exactly the same thing.
866         * platform/graphics/qt/PathQt.cpp:
867         (WebCore::Path::boundingRect): Return QPainterPath::controlPointRect() since
868         that is much faster than computing the (precise) QPainterPath::boundingRect()
869         and Path::boundingRect() is not expected to be 100% precise anyway.
870
871 2011-08-25  Yuta Kitamura  <yutak@chromium.org>
872
873         WebSocket: Queue messages to be sent
874         https://bugs.webkit.org/show_bug.cgi?id=66298
875
876         Reviewed by Kent Tamura.
877
878         Blobs must be read asynchronously and thus cannot be sent immediately. Therefore, we need to
879         create a queue of messages to be sent in order to handle pending requests.
880
881         No new tests. Strictly speaking, there is a small change in behavior but it is hard to
882         reproduce in tests. See description of WebSocketChannel::send below.
883
884         * websockets/WebSocketChannel.cpp:
885         (WebCore::WebSocketChannel::WebSocketChannel):
886         (WebCore::WebSocketChannel::send):
887         Now, this function always returns true if hybi-10 protocol is selected. The impact of this change
888         should be minimum, because the current WebSocket API defines the return type of WebSocket.send()
889         is void (see also bug 65850).
890         It's hard to make SocketStreamHandle::send() fail deliberately, therefore it's difficult to write
891         a test to detect this behavior change.
892         (WebCore::WebSocketChannel::didCloseSocketStream):
893         (WebCore::WebSocketChannel::startClosingHandshake):
894         (WebCore::WebSocketChannel::processFrame):
895         (WebCore::WebSocketChannel::enqueueTextFrame):
896         (WebCore::WebSocketChannel::enqueueRawFrame):
897         (WebCore::WebSocketChannel::processOutgoingFrameQueue):
898         (WebCore::WebSocketChannel::abortOutgoingFrameQueue):
899         * websockets/WebSocketChannel.h:
900
901 2011-08-24  Alexander Pavlov  <apavlov@chromium.org>
902
903         Web Inspector: Directional arrow on element info box looks terrible
904         https://bugs.webkit.org/show_bug.cgi?id=66819
905
906         Beautify the tooltip arrow, give it a better alignment in some edge cases,
907         and fix the tooltip font on Macs.
908
909         Reviewed by Pavel Feldman.
910
911         * inspector/DOMNodeHighlighter.cpp:
912
913 2011-08-25  Jeremy Moskovich  <jeremy@chromium.org>
914
915         Remove ATSFont*() functions in favor of CGFont in FontCustomPlatformData.cpp
916         https://bugs.webkit.org/show_bug.cgi?id=66629
917
918         As of r72774 and dropping support for OS X 10.4, we can safely
919         remove the ATS APIs from FontCustomPlatformData.cpp in favor of just the
920         CGFont code.
921
922         This change is motivated by a bug in ATSFontDeactivite() on 10.7 which
923         affects the Chromium port, due to its compiling once against the 10.5
924         SDK for all platforms - See crbug.com/93191 or rdar://9976774 .
925
926         Reviewed by Dan Bernstein.
927
928         No new tests - covered by existing tests.
929
930         * platform/graphics/mac/FontCustomPlatformData.cpp:
931         (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
932         (WebCore::createFontCustomPlatformData):
933         * platform/graphics/mac/FontCustomPlatformData.h:
934         (WebCore::FontCustomPlatformData::FontCustomPlatformData):
935
936 2011-08-25  Pavel Feldman  <pfeldman@google.com>
937
938         Not reviewed: rollout r93768 for breaking build.
939
940         * inspector/DOMNodeHighlighter.cpp:
941
942 2011-08-24  Pavel Feldman  <pfeldman@google.com>
943
944         Web Inspector: split ConsoleView into the View and the Model.
945         https://bugs.webkit.org/show_bug.cgi?id=66861
946
947         Reviewed by Yury Semikhatsky.
948
949         * WebCore.gypi:
950         * WebCore.vcproj/WebCore.vcproj:
951         * inspector/compile-front-end.sh:
952         * inspector/front-end/BreakpointManager.js:
953         * inspector/front-end/ConsoleMessage.js:
954         (WebInspector.ConsoleMessage.prototype._format):
955         * inspector/front-end/ConsoleModel.js: Added.
956         (WebInspector.ConsoleModel):
957         (WebInspector.ConsoleModel.prototype._setConsoleMessageExpiredCount):
958         (WebInspector.ConsoleModel.prototype.addMessage):
959         (WebInspector.ConsoleModel.prototype._incrementErrorWarningCount):
960         (WebInspector.ConsoleModel.prototype.requestClearMessages):
961         (WebInspector.ConsoleModel.prototype.clearMessages):
962         (WebInspector.ConsoleDispatcher):
963         (WebInspector.ConsoleDispatcher.prototype.messageAdded):
964         (WebInspector.ConsoleDispatcher.prototype.messageRepeatCountUpdated):
965         * inspector/front-end/ConsolePanel.js:
966         (WebInspector.ConsolePanel):
967         (WebInspector.ConsolePanel.prototype.performSearch):
968         * inspector/front-end/ConsoleView.js:
969         (WebInspector.ConsoleView):
970         (WebInspector.ConsoleView.prototype._consoleMessageAdded):
971         (WebInspector.ConsoleView.prototype._appendConsoleCommand):
972         (WebInspector.ConsoleView.prototype._appendConsoleCommandResult):
973         (WebInspector.ConsoleView.prototype._appendConsoleMessage):
974         (WebInspector.ConsoleView.prototype._consoleCleared):
975         (WebInspector.ConsoleView.prototype._registerShortcuts):
976         (WebInspector.ConsoleView.prototype._requestClearMessages):
977         * inspector/front-end/DebuggerModel.js:
978         * inspector/front-end/DebuggerPresentationModel.js:
979         (WebInspector.DebuggerPresentationModel):
980         (WebInspector.DebuggerPresentationModel.prototype.addSourceMappingListener):
981         (WebInspector.DebuggerPresentationModel.prototype.removeSourceMappingListener):
982         * inspector/front-end/NetworkLog.js: Copied from Source/WebCore/inspector/front-end/externs.js.
983         (WebInspector.NetworkLog):
984         (WebInspector.NetworkLog.prototype.get resources):
985         (WebInspector.NetworkLog.prototype._frameNavigated):
986         (WebInspector.NetworkLog.prototype._onResourceStarted):
987         * inspector/front-end/NetworkManager.js:
988         (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
989         (WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):
990         * inspector/front-end/Resource.js:
991         (WebInspector.Resource.prototype.set finished):
992         * inspector/front-end/ResourceTreeModel.js:
993         (WebInspector.ResourceTreeModel):
994         * inspector/front-end/SourceFile.js:
995         (WebInspector.RawSourceCode.prototype._scriptForRawLocation):
996         (WebInspector.ScriptContentProvider.prototype.requestContent):
997         (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
998         (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
999         * inspector/front-end/UISourceCode.js:
1000         (WebInspector.ContentProvider):
1001         (WebInspector.ContentProvider.prototype.requestContent):
1002         * inspector/front-end/WatchExpressionsSidebarPane.js:
1003         (WebInspector.WatchExpressionsSection.prototype.update):
1004         * inspector/front-end/WebKit.qrc:
1005         * inspector/front-end/externs.js:
1006         (WebInspector.linkifyURLAsNode):
1007         (WebInspector.formatLinkText):
1008         * inspector/front-end/inspector.html:
1009         * inspector/front-end/inspector.js:
1010         (WebInspector._createGlobalStatusBarItems):
1011         (WebInspector._updateErrorAndWarningCounts):
1012         (WebInspector.showConsole):
1013
1014 2011-08-24  Alexander Pavlov  <apavlov@chromium.org>
1015
1016         Web Inspector: Directional arrow on element info box looks terrible
1017         https://bugs.webkit.org/show_bug.cgi?id=66819
1018
1019         Beautify the tooltip arrow, give it a better alignment in some edge cases,
1020         and fix the tooltip font on Macs.
1021
1022         Reviewed by Pavel Feldman.
1023
1024         * inspector/DOMNodeHighlighter.cpp:
1025
1026 2011-08-25  Yuta Kitamura  <yutak@chromium.org>
1027
1028         Let MessageEvent.data hold SerializedScriptValue or String selectively
1029         https://bugs.webkit.org/show_bug.cgi?id=66841
1030
1031         Reviewed by Adam Barth.
1032
1033         MessageEvent from WebSocket contains a String in its "data" attribute, but it does not have
1034         to be serialized.
1035
1036         No new tests are added, because this is refactoring and the behavior should not change.
1037
1038         * bindings/js/JSMessageEventCustom.cpp:
1039         (WebCore::JSMessageEvent::data):
1040         To call putAnonymousValue(), "this" needs to be converted to non-const using const_cast<>.
1041         (WebCore::JSMessageEvent::initMessageEvent):
1042         Update the cache value as well.
1043         * bindings/v8/custom/V8MessageEventCustom.cpp:
1044         (WebCore::V8MessageEvent::dataAccessorGetter):
1045         ForceSet() is used to cache a value. This is the same as what the code generated by
1046         CodeGeneratorV8 does.
1047         (WebCore::V8MessageEvent::initMessageEventCallback):
1048         * dom/MessageEvent.cpp:
1049         (WebCore::MessageEvent::MessageEvent):
1050         (WebCore::MessageEvent::initMessageEvent):
1051         (WebCore::MessageEvent::data):
1052         This is only used within the Objective-C bindings (JSC and V8 have the custom functions).
1053         Since Objective-C code generator does not support [CustomGetter] IDL attribute, there is
1054         no good way to return a variant value for Objective-C bindings.
1055         * dom/MessageEvent.h:
1056         (WebCore::MessageEvent::create):
1057         (WebCore::MessageEvent::dataType):
1058         (WebCore::MessageEvent::dataAsSerializedScriptValue):
1059         (WebCore::MessageEvent::dataAsString):
1060         * dom/MessageEvent.idl:
1061         * websockets/WebSocket.cpp:
1062         (WebCore::WebSocket::didReceiveMessage):
1063         Construct a MessageEvent without serializing the received message.
1064
1065 2011-08-25  MORITA Hajime  <morrita@google.com>
1066
1067         Unreviewed, rolling out r93762.
1068         http://trac.webkit.org/changeset/93762
1069         https://bugs.webkit.org/show_bug.cgi?id=66756
1070
1071         IndexedDb tests crash
1072
1073         * WebCore.gypi:
1074         * WebCore.pro:
1075         * bindings/generic/EventConstructors.h: Removed.
1076         * bindings/v8/OptionsObject.cpp:
1077         * bindings/v8/OptionsObject.h:
1078         * bindings/v8/custom/V8EventConstructors.cpp: Removed.
1079         * dom/Event.cpp:
1080         * dom/Event.h:
1081         (WebCore::Event::create):
1082         * dom/Event.idl:
1083
1084 2011-08-24  Kentaro Hara  <haraken@google.com>
1085
1086         Implement an Event constructor.
1087         https://bugs.webkit.org/show_bug.cgi?id=66756
1088
1089         Reviewed by Adam Barth.
1090
1091         The spec of the Event constructor is here:
1092         http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-event-constructor.
1093         This patch added the Event constructor to EventConstructors.h using
1094         JavaScript implementation-independent macros. This patch also added the V8
1095         implementation of these macros to V8EventConstructors.cpp.
1096
1097         The bug 63878 has been implementing the Event constructors for JSC.
1098         Our plan is to first implement all the Event constructors for V8
1099         using EventConstructors.h proposed in the JSC patch, and then merge
1100         the JSC patch with these V8 patches. In any case, we are going to split
1101         the patches for V8 and those for JSC in order to avoid hard regression.
1102
1103         Test: fast/events/event-constructors.html
1104
1105         * WebCore.gypi: Added V8EventConstructors.cpp.
1106         * WebCore.pro: Added V8EventConstructors.cpp.
1107         * bindings/generic/EventConstructors.h: Added. The Event constructor. This is written using JavaScript implementation-independent macros. The V8 implementation of these macros is written in bindings/v8/custom/V8EventConstructors.cpp.
1108         * bindings/v8/OptionsObject.cpp:
1109         (WebCore::OptionsObject::getKeyDouble): Returns the value of a given key of type double.
1110         (WebCore::OptionsObject::getKey): Returns true whenever the given key is found, even if the value is null or undefined.
1111         * bindings/v8/OptionsObject.h:
1112         (WebCore::OptionsObject::getKeyValue): Returns the value of the given key. We need to overload getKeyValue() for all types required to EventConfiguration members.
1113         * bindings/v8/custom/V8EventConstructors.cpp: Added. Implemented macros used in EventConstructors.h.
1114         (WebCore::constructV8Event): The Event constructor.
1115         * dom/Event.cpp:
1116         (WebCore::EventConfiguration::EventConfiguration): A constructor of EventConfiguration.
1117         (WebCore::Event::Event): A constructor of the Event class.
1118         * dom/Event.h: Added EventConfiguration, which manages attributes of the Event class.
1119         (WebCore::Event::create): A factory method of the Event class with EventConfiguration.
1120         * dom/Event.idl: Added 'CanBeConstructed' and 'V8CustomConstructor'.
1121
1122 2011-08-24  Philippe Normand  <pnormand@igalia.com>
1123
1124         [GTK] bump GStreamer requirement to 0.10.30
1125         https://bugs.webkit.org/show_bug.cgi?id=66860
1126
1127         Reviewed by Martin Robinson.
1128
1129         Use fast element linking by default.
1130
1131         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
1132         (WebCore::GStreamerGWorld::enterFullscreen):
1133         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1134         (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
1135
1136 2011-08-24  James Robinson  <jamesr@chromium.org>
1137
1138         Some layerTreeAsText compositing tests are flaky
1139         https://bugs.webkit.org/show_bug.cgi?id=66913
1140
1141         Reviewed by Simon Fraser.
1142
1143         Remove compositingLayerUpdatePending() and unconditionally update compositing layers when
1144         RenderLayerCompositor::layerTreeAsText().  compositingLayerUpdatePending() was only used by test code and is
1145         unreliable.
1146
1147         Covered by compositing/ layerTreeAsText tests.
1148
1149         * rendering/RenderLayerCompositor.cpp:
1150         (WebCore::RenderLayerCompositor::layerTreeAsText):
1151         * rendering/RenderLayerCompositor.h:
1152
1153 2011-08-24  Kentaro Hara  <haraken@google.com>
1154
1155         Implement a keypath parser strictly following the specification
1156         https://bugs.webkit.org/show_bug.cgi?id=62288
1157
1158         Reviewed by Tony Chang.
1159
1160         Implemented a keypath parser that accepts either an empty string, a JavaScript
1161         identifier, or multiple JavaScript identifiers separated by periods.
1162         We fixed createObjectStore() and createIndex() so that they parse and check
1163         their |keypath| argument and return an appropriate exception if the |keypath|
1164         is not valid. We also added unit tests for the new keypath parser in keypath-basics.html.
1165
1166         Tests: storage/indexeddb/keypath-fetch-key.html
1167                storage/indexeddb/keypath-basics.html
1168
1169         * bindings/v8/IDBBindingUtilities.cpp:
1170         (WebCore::createIDBKeyFromSerializedValueAndKeyPath): Replaced IDBKeyPathElement with String
1171         (WebCore::injectIDBKeyIntoSerializedValue): Replaced IDBKeyPathElement with String
1172         * bindings/v8/IDBBindingUtilities.h:
1173         * bindings/v8/OptionsObject.cpp:
1174         (WebCore::OptionsObject::getKeyStringWithUndefinedOrNullCheck): Returns false when a given value is null or undefined
1175         (WebCore::OptionsObject::getKey): Removed undefined check
1176         * storage/IDBDatabase.cpp:
1177         (WebCore::IDBDatabase::createObjectStore): Checks if a |keypath| argument is valid, and returns a NON_TRANSIENT_ERR if it is not valid
1178         * storage/IDBDatabaseBackendImpl.cpp:
1179         (WebCore::IDBDatabaseBackendImpl::createObjectStore): Removed null check of a keypath
1180         * storage/IDBKeyPath.cpp:
1181         (WebCore::IDBKeyPathLexer::currentElement): Part of the keypath parser
1182         (WebCore::IDBKeyPathLexer::lex): Part of the keypath parser
1183         (WebCore::IDBKeyPathLexer::lexIdentifier): Part of the keypath parser
1184         (WebCore::IDBIsValidKeyPath): Checks if a keypath is valid
1185         (WebCore::IDBParseKeyPath): Part of the keypath parser
1186         * storage/IDBKeyPath.h: Replaced IDBKeyPathElement with String
1187         * storage/IDBObjectStore.cpp:
1188         (WebCore::IDBObjectStore::createIndex): Checks if a |keypath| argument is valid, and returns a NON_TRANSIENT_ERR if it is not valid
1189         * storage/IDBObjectStore.idl:
1190
1191 2011-08-24  Eric Uhrhane  <ericu@chromium.org>
1192
1193         Reviewed by Adam Barth.
1194
1195         [filesystem/Chromium] Filesystem paths need proper URL escaping
1196         https://bugs.webkit.org/show_bug.cgi?id=62811
1197
1198         Fix http://code.google.com/p/chromium/issues/detail?id=78860 by making
1199         KURLChromium.cpp's escaping code actually work.
1200
1201         Make encodeWithURLEscapeSequences call into googleurl to do proper
1202         escaping.  Tested in WebKit/chromium/tests/KURLTest.cpp.
1203         * platform/KURLGoogle.cpp:
1204         (WebCore::encodeWithURLEscapeSequences):
1205
1206 2011-08-24  Chris Palmer  <palmer@google.com>
1207
1208         Resolve potential integer overflow in memory allocation, and ensure
1209         that allocation succeeds.
1210
1211         Reviewed by Kenneth Russell.
1212
1213         * platform/audio/AudioArray.h:
1214         (WebCore::AudioArray::allocate): Check for integer overflow.
1215         (WebCore::AudioArray::at): Document the safety assertion.
1216         (WebCore::AudioArray::zero): Document the safety assertion.
1217         (WebCore::AudioArray::zeroRange): Document the safety assertion.
1218         (WebCore::AudioArray::copyToRange): Document the safety assertion.
1219
1220 2011-08-24  Raphael Kubo da Costa  <kubo@profusion.mobi>
1221
1222         [EFL] Fix build with ENABLE_GEOLOCATION.
1223         https://bugs.webkit.org/show_bug.cgi?id=66881
1224
1225         Use adoptPtr() to create a new GeolocationService instance, otherwise
1226         the build will fail when creating the PassOwnPtr object.
1227
1228         * platform/efl/GeolocationServiceEfl.cpp:
1229         (WebCore::GeolocationServiceEfl::create):
1230
1231 2011-08-24  Raphael Kubo da Costa  <kubo@profusion.mobi>
1232
1233         [CMake] Fix build with ENABLE_BLOB or ENABLE_FILE_SYSTEM.
1234         https://bugs.webkit.org/show_bug.cgi?id=66880
1235
1236         Generate and build some additional files required by these options.
1237
1238         No new tests, as this is a build fix for some build options.
1239
1240         * CMakeLists.txt:
1241
1242 2011-08-24  Iain Merrick  <husky@google.com>
1243
1244         [chromium] Don't call glDeleteTexture(0) in TextureManager
1245         https://bugs.webkit.org/show_bug.cgi?id=66862
1246
1247         Delete(0) is allowed in standard OpenGL, but not in Chrome.
1248         See http://code.google.com/p/chromium/issues/detail?id=85268
1249
1250         Reviewed by James Robinson.
1251
1252         * platform/graphics/chromium/TextureManager.cpp:
1253         (WebCore::TextureManager::deleteEvictedTextures):
1254
1255 2011-08-24  Adrienne Walker  <enne@google.com>
1256
1257         [chromium] Properly initialize CCTiledLayerImpl::m_skipsDraw
1258         https://bugs.webkit.org/show_bug.cgi?id=66889
1259
1260         Reviewed by James Robinson.
1261
1262         * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
1263         (WebCore::CCTiledLayerImpl::CCTiledLayerImpl):
1264
1265 2011-08-24  Tom Sepez  <tsepez@chromium.org>
1266
1267         chromium WebFrameImpl - don't load javascript URLs against chrome internal
1268         pages.  Adds a mechanism for registering sensitive schemes which should 
1269         not be subject to manipulation by javascript urls typed into a location bar
1270         or, more importantly, their bookmarklet equivalents.
1271         https://bugs.webkit.org/show_bug.cgi?id=66720
1272
1273         Reviewed by Adam Barth.
1274
1275         Test: Chromium WebKit API unit test in chromium specific directory.
1276         
1277         * platform/SchemeRegistry.cpp:
1278         (WebCore::notAllowingJavascriptURLsSchemes):
1279         (WebCore::SchemeRegistry::registerURLSchemeAsNotAllowingJavascriptURLs):
1280         (WebCore::SchemeRegistry::shouldTreatURLSchemeAsNotAllowingJavascriptURLs):
1281         * platform/SchemeRegistry.h:
1282
1283 2011-08-24  Alexandru Chiculita  <achicu@adobe.com>
1284
1285         [CSSRegions] Fix Element::getBoundingClientRect and Element::getClientRects for content flow
1286         https://bugs.webkit.org/show_bug.cgi?id=66641
1287
1288         Original author of the patch is Mihnea Ovidenie <mihnea@adobe.com>.
1289
1290         Redirected the mapLocalToContainer method to the appropriate RenderRegion.
1291
1292         Note: RenderObject::absoluteQuads method needs some refactor to support multiple regions,
1293         will do that in a separate bug.
1294
1295         Reviewed by David Hyatt.
1296
1297         Tests: fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html
1298                fast/regions/flowed-content-bounding-client-rect-vertical-rl.html
1299                fast/regions/flowed-content-bounding-client-rect-vertical.html
1300                fast/regions/flowed-content-bounding-client-rect.html
1301                fast/regions/flowed-content-transform-bounding-client-rect.html
1302
1303         * rendering/RenderBox.cpp:
1304         (WebCore::RenderBox::mapLocalToContainer):
1305         * rendering/RenderFlowThread.cpp:
1306         (WebCore::RenderFlowThread::renderRegionForLine):
1307         (WebCore::RenderFlowThread::mapFromFlowToRegion):
1308         * rendering/RenderFlowThread.h:
1309
1310 2011-08-24  Alok Priyadarshi  <alokp@chromium.org>
1311
1312         [chromium] Root layer is not updated when only a portion of tile is updated
1313         https://bugs.webkit.org/show_bug.cgi?id=66506
1314
1315         This only happened in the accelerated path which changes stencil state.
1316         Incorrect stencil state was used to draw the root layer.
1317
1318         Reviewed by James Robinson.
1319
1320         Test: compositing/overflow/overflow-scroll.html (existing)
1321
1322         * platform/graphics/chromium/LayerRendererChromium.cpp:
1323         (WebCore::LayerRendererChromium::drawLayersInternal):
1324         * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
1325         (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
1326
1327 2011-08-24  Nate Chapin  <japhet@chromium.org>
1328
1329         Fix an intermittent crash in EventSource, when a
1330         reconnect timer triggers after a navigation
1331         away from the current page begins.
1332         https://bugs.webkit.org/show_bug.cgi?id=45202
1333
1334         Reviewed by Alexey Proskuryakov.
1335
1336         Test: http/tests/eventsource/eventsource-reconnect-during-navigate-crash.html
1337
1338         * page/EventSource.cpp:
1339         (WebCore::EventSource::connect): Don't set m_requestInFlight
1340             to true if ThreadableLoader::create() failed.
1341
1342 2011-08-24  Mike Reed  <reed@google.com>
1343
1344         Change clip routine to promote the clipbounds up to (local) floats and then perform the intersection,
1345         rather than rounding the srcRect down to integers.
1346         https://bugs.webkit.org/show_bug.cgi?id=66810
1347
1348         Reviewed by Kenneth Russell.
1349
1350         No new tests. Existing tests that resize images will exercise this code path
1351
1352         * platform/graphics/skia/SkiaUtils.cpp:
1353         (WebCore::ClipRectToCanvas):
1354
1355 2011-08-24  Alexandru Chiculita  <achicu@adobe.com>
1356
1357         [CSSRegions] RenderRegion is not used if there's another renderer after it
1358         https://bugs.webkit.org/show_bug.cgi?id=66844
1359
1360         There was no call to attachRegion in RenderObjectChildList::insertChildNode, so
1361         the region was not added to the RenderFlowThread.
1362
1363         Reviewed by David Hyatt.
1364
1365         Test: fast/regions/content-flowed-into-regions-dynamically-inserted.html
1366
1367         * rendering/RenderObjectChildList.cpp:
1368         (WebCore::RenderObjectChildList::insertChildNode):
1369
1370 2011-08-24  Sam Weinig  <sam@webkit.org>
1371
1372         JSHTMLImageElement (and associated Node) is abandoned when image load is canceled
1373         <rdar://problem/9925630>
1374         https://bugs.webkit.org/show_bug.cgi?id=66864
1375
1376         Reviewed by Anders Carlsson.
1377
1378         In the JSC bindings, we use HTMLImageElement::hasPendingActivity() (which in turn calls
1379         HTMLImageLoader::haveFiredLoadEvent()) to reason about the liveness of JSHTMLImageElements.
1380         In the case that an image load is canceled, the haveFiredLoadEvent never true, so the
1381         JSHTMLImageElement is kept alive forever (and since it references the global object, it
1382         keeps the entire graph alive as well).
1383
1384         * loader/ImageLoader.cpp:
1385         (WebCore::ImageLoader::notifyFinished):
1386         Set m_firedLoad to true in the case of a canceled load, to reset the state back to
1387         its initial values.
1388
1389 2011-08-24  Tommy Widenflycht  <tommyw@google.com>
1390
1391         MediaStream API: add createObjectURL functionality
1392         https://bugs.webkit.org/show_bug.cgi?id=65925
1393
1394         This patch introduces the functionality for generating the url associated with a MediaStream,
1395         which can then be assigned to the src attribute of the <video> tag for example.
1396
1397         Reviewed by Adam Barth.
1398
1399         * CMakeLists.txt:
1400         * GNUmakefile.list.am:
1401         * WebCore.gypi:
1402         * WebCore.pro:
1403         * WebCore.vcproj/WebCore.vcproj:
1404         * WebCore.xcodeproj/project.pbxproj:
1405         * dom/ScriptExecutionContext.cpp:
1406         (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
1407         (WebCore::ScriptExecutionContext::createPublicBlobURL):
1408         (WebCore::ScriptExecutionContext::revokePublicBlobURL):
1409         * dom/ScriptExecutionContext.h:
1410         * html/DOMURL.cpp:
1411         (WebCore::DOMURL::createObjectURL):
1412         * html/DOMURL.h:
1413         * html/DOMURL.idl:
1414         * platform/MediaStreamRegistry.cpp: Added.
1415         (WebCore::MediaStreamRegistry::registry):
1416         (WebCore::MediaStreamRegistry::registerMediaStreamURL):
1417         (WebCore::MediaStreamRegistry::unregisterMediaStreamURL):
1418         (WebCore::MediaStreamRegistry::mediaStream):
1419         * platform/MediaStreamRegistry.h: Copied from Source/WebCore/html/DOMURL.h.
1420
1421         Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.
1422
1423 2011-08-23  David Levin  <levin@chromium.org>
1424
1425         MessageEvent.ports shouldn't ever be null.
1426         https://bugs.webkit.org/show_bug.cgi?id=66789
1427
1428         Reviewed by Darin Adler.
1429
1430         * bindings/js/JSMessageEventCustom.cpp:
1431         (WebCore::JSMessageEvent::ports): Never return null.
1432         * bindings/v8/custom/V8MessageEventCustom.cpp:
1433         (WebCore::V8MessageEvent::portsAccessorGetter): Ditto.
1434
1435 2011-08-24  Alexandru Chiculita  <achicu@adobe.com>
1436
1437         https://bugs.webkit.org/show_bug.cgi?id=66799
1438         RenderFlowThread creates a list of child elements, so that it can search
1439         the insertion point of a new element without searching the whole DOM.
1440         The issue is that it used addChild/removeChild, but that wasn't taking care of
1441         elements added in anonymous blocks created inside the RenderFlowThread.
1442
1443         Reviewed by David Hyatt.
1444
1445         Test: fast/regions/flow-anonymous-children.html
1446
1447         * rendering/RenderFlowThread.cpp:
1448         (WebCore::RenderFlowThread::nextRendererForNode):
1449         (WebCore::RenderFlowThread::previousRendererForNode):
1450         (WebCore::RenderFlowThread::addFlowChild):
1451         (WebCore::RenderFlowThread::removeFlowChild):
1452         * rendering/RenderFlowThread.h:
1453         * rendering/RenderObjectChildList.cpp:
1454         (WebCore::renderFlowThreadContainer):
1455         (WebCore::RenderObjectChildList::removeChildNode):
1456         (WebCore::RenderObjectChildList::appendChildNode):
1457         (WebCore::RenderObjectChildList::insertChildNode):
1458
1459 2011-08-24  Pavel Feldman  <pfeldman@google.com>
1460
1461         Web Inspector: Add 9 more javascript files to the compilation.
1462         https://bugs.webkit.org/show_bug.cgi?id=66847
1463
1464         Reviewed by Yury Semikhatsky.
1465
1466         * WebCore.gypi:
1467         * WebCore.vcproj/WebCore.vcproj:
1468         * inspector/compile-front-end.sh:
1469         * inspector/front-end/BreakpointManager.js:
1470         * inspector/front-end/CSSStyleModel.js:
1471         * inspector/front-end/Checkbox.js:
1472         * inspector/front-end/ConsoleMessage.js: Added.
1473         (WebInspector.ConsoleStackFrame):
1474         (WebInspector.ConsoleMessage):
1475         (WebInspector.ConsoleMessage.createTextMessage):
1476         (WebInspector.ConsoleMessage.prototype.get stackTrace):
1477         * inspector/front-end/ConsoleView.js:
1478         (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
1479         (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):
1480         * inspector/front-end/CookieParser.js:
1481         * inspector/front-end/DOMAgent.js:
1482         * inspector/front-end/DOMStorage.js:
1483         * inspector/front-end/Database.js:
1484         * inspector/front-end/DebuggerModel.js:
1485         * inspector/front-end/DebuggerPresentationModel.js:
1486         * inspector/front-end/InspectorFrontendHostStub.js:
1487         (WebInspector.isMac):
1488         * inspector/front-end/NetworkManager.js:
1489         * inspector/front-end/RemoteObject.js:
1490         (WebInspector.RemoteObject.prototype.setPropertyValue):
1491         * inspector/front-end/Resource.js:
1492         (WebInspector.Resource):
1493         (WebInspector.Resource.Type.Document.0.Stylesheet.1.Image.2.Font.3.Script.4.XHR.5.WebSocket.7.Other.8.isTextType):
1494         (WebInspector.Resource.Type.toUIString):
1495         (WebInspector.Resource.Type.toString):
1496         (WebInspector.Resource.prototype._checkWarnings):
1497         (WebInspector.ResourceDomainModelBinding):
1498         (WebInspector.ResourceDomainModelBinding.prototype.canSetContent):
1499         (WebInspector.ResourceDomainModelBinding.prototype.setContent):
1500         * inspector/front-end/ResourceCategory.js:
1501         (WebInspector.ResourceCategory):
1502         (WebInspector.ResourceCategory.prototype.toString):
1503         (WebInspector.ResourceCategory.prototype.get title):
1504         * inspector/front-end/ResourceTreeModel.js:
1505         * inspector/front-end/ScriptFormatter.js:
1506         (WebInspector.ScriptFormatter.prototype._didFormatContent):
1507         (WebInspector.FormatterMappingPayload):
1508         * inspector/front-end/TimelineManager.js:
1509         * inspector/front-end/WebKit.qrc:
1510         * inspector/front-end/externs.js:
1511         (console.assert):
1512         (WebInspector.linkifyURLAsNode):
1513         (WebInspector.linkifyStringAsFragment):
1514         (WebInspector.UIString):
1515         (Element.prototype.scrollIntoViewIfNeeded):
1516         * inspector/front-end/inspector.html:
1517         * inspector/front-end/inspector.js:
1518         (WebInspector.UIString):
1519         * inspector/front-end/treeoutline.js:
1520         * inspector/front-end/utilities.js:
1521         * inspector/generate-protocol-externs:
1522
1523 2011-08-24  Pavel Feldman  <pfeldman@google.com>
1524
1525         Web Inspector: extract ConsoleMessage into a separate file.
1526         https://bugs.webkit.org/show_bug.cgi?id=66853
1527
1528         Reviewed by Yury Semikhatsky.
1529
1530         * WebCore.gypi:
1531         * WebCore.vcproj/WebCore.vcproj:
1532         * inspector/front-end/ConsoleMessage.js: Added.
1533         (WebInspector.ConsoleMessage):
1534         (WebInspector.ConsoleMessage.createTextMessage):
1535         (WebInspector.ConsoleMessage.prototype._formatMessage):
1536         (WebInspector.ConsoleMessage.prototype._linkifyLocation):
1537         (WebInspector.ConsoleMessage.prototype._linkifyCallFrame):
1538         (WebInspector.ConsoleMessage.prototype.isErrorOrWarning):
1539         (WebInspector.ConsoleMessage.prototype._format):
1540         (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.valueFormatter):
1541         (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append):
1542         (WebInspector.ConsoleMessage.prototype.clearHighlight):
1543         (WebInspector.ConsoleMessage.prototype.highlightSearchResults):
1544         (WebInspector.ConsoleMessage.prototype.matchesRegex):
1545         (WebInspector.ConsoleMessage.prototype.toMessageElement):
1546         (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
1547         (WebInspector.ConsoleMessage.prototype._updateRepeatCount):
1548         (WebInspector.ConsoleMessage.prototype.toString):
1549         (WebInspector.ConsoleMessage.prototype.isEqual):
1550         (WebInspector.ConsoleMessage.prototype.get stackTrace):
1551         * inspector/front-end/ConsoleView.js:
1552         * inspector/front-end/WebKit.qrc:
1553
1554 2011-08-24  Tatiana Meshkova  <tatiana.meshkova@nokia.com>
1555
1556         Paint SliderTrack and SliderThumb independently.
1557         https://bugs.webkit.org/show_bug.cgi?id=50453
1558         Also fixes https://bugs.webkit.org/show_bug.cgi?id=65456 crash.
1559
1560         Reviewed by Kenneth Rohde Christiansen.
1561
1562         RenderSlider works only with <input type=range>. Nowadays RenderTheme
1563         supports painting of SliderTrack and SliderThumb without range input.
1564         In order to be in sync with other platforms this patch gets rid of
1565         upcasting in RenderThemeQt::paintSliderTrack and allows to paint
1566         SliderTrack and SliderThumb independently.
1567
1568         Test: platform/qt/fast/forms/range/slider-crash.html
1569
1570         * platform/qt/RenderThemeQt.cpp:
1571         (WebCore::RenderThemeQt::paintSliderTrack): Draw SC_SliderGroove.
1572         Allow paintSliderThumb() to care about SC_SliderHandle. We don't need
1573         to setup value and position anymore, since handle is drawn separately.
1574         Draw focus explicitly, since QStyleOptionSlider doesn't allow to focus
1575         on CC_Slider without handle subcontrol.
1576         (WebCore::RenderThemeQt::paintSliderThumb): Draw SC_SliderHandle.
1577
1578 2011-08-23  Pavel Feldman  <pfeldman@google.com>
1579
1580         Web Inspector: annotate and prepare for compilation first 14 JavaScript files within 4 modules.
1581         https://bugs.webkit.org/show_bug.cgi?id=66776
1582
1583         Reviewed by Yury Semikhatsky.
1584
1585         * inspector/compile-front-end.sh:
1586         * inspector/front-end/ContextMenu.js:
1587         * inspector/front-end/DOMAgent.js:
1588         (WebInspector.DOMAgent.prototype._loadNodeAttributes):
1589         (WebInspector.DOMAgent.prototype._childNodeRemoved):
1590         (WebInspector.DOMAgent.prototype._inspectElementRequested):
1591         (WebInspector.DOMDispatcher.prototype.inspectElementRequested):
1592         * inspector/front-end/DebuggerModel.js:
1593         (WebInspector.DebuggerModel.Location):
1594         * inspector/front-end/ElementsPanel.js:
1595         (WebInspector.ElementsPanel):
1596         (WebInspector.ElementsPanel.prototype._inspectElementRequested):
1597         * inspector/front-end/InspectorFrontendHostStub.js:
1598         * inspector/front-end/KeyboardShortcut.js:
1599         * inspector/front-end/Object.js:
1600         (WebInspector.Object.prototype.addEventListener):
1601         (WebInspector.Object.prototype.removeEventListener):
1602         (WebInspector.Object.prototype.hasEventListeners):
1603         * inspector/front-end/Panel.js:
1604         (WebInspector.Panel):
1605         * inspector/front-end/Placard.js:
1606         * inspector/front-end/Popover.js:
1607         (WebInspector.Popover.prototype.show):
1608         * inspector/front-end/ResourcesPanel.js:
1609         (WebInspector.ResourcesPanel):
1610         (WebInspector.StorageCategoryTreeElement):
1611         * inspector/front-end/Script.js:
1612         (WebInspector.Script.prototype.editSource):
1613         * inspector/front-end/ScriptsPanel.js:
1614         * inspector/front-end/Settings.js:
1615         (WebInspector.Settings):
1616         (WebInspector.Settings.prototype.createSetting):
1617         * inspector/front-end/SoftContextMenu.js:
1618         (.WebInspector.SoftContextMenu.prototype._menuItemMouseUp):
1619         (.WebInspector.SoftContextMenu.prototype._triggerAction):
1620         (.WebInspector.SoftContextMenu.prototype._menuKeyDown):
1621         * inspector/front-end/TabbedPane.js:
1622         * inspector/front-end/TextPrompt.js:
1623         * inspector/front-end/UserMetrics.js:
1624         * inspector/front-end/View.js:
1625         * inspector/front-end/externs.js:
1626         (JSON.parse):
1627         (JSON.stringify):
1628         * inspector/front-end/inspector.js:
1629         ():
1630         * inspector/generate-protocol-externs:
1631
1632 2011-08-24  Andreas Kling  <kling@webkit.org>
1633
1634         SelectElementData: Reorder members to reduce memory usage.
1635         https://bugs.webkit.org/show_bug.cgi?id=66787
1636
1637         Reviewed by Darin Adler.
1638
1639         Reduced the size of SelectElementData by 24 bytes on 64-bit by rearranging
1640         its data members.
1641
1642         Also added missing initialization of m_userDrivenChange.
1643
1644         * dom/SelectElement.cpp:
1645         (WebCore::SelectElementData::SelectElementData):
1646         * dom/SelectElement.h:
1647
1648 2011-08-24  Pavel Feldman  <pfeldman@google.com>
1649
1650         Web Inspector: clearPseudoState should retain Element while clearing
1651         its state.
1652         https://bugs.webkit.org/show_bug.cgi?id=66790
1653
1654         Reviewed by Yury Semikhatsky.
1655
1656         * inspector/InspectorCSSAgent.cpp:
1657         (WebCore::InspectorCSSAgent::clearPseudoState):
1658
1659 2011-08-23  Mark Hahnenberg  <mhahnenberg@apple.com>
1660
1661         Add checks to ensure allocation does not take place during initialization of GC-managed objects
1662         https://bugs.webkit.org/show_bug.cgi?id=65288
1663
1664         Reviewed by Darin Adler.
1665
1666         No new tests.
1667
1668         Adding the new validation functionality.  In its current state, it will performs checks, 
1669         but they don't fail unless you do allocation in the arguments to the parent constructor in the 
1670         initialization list of a class.  The allocateCell() method turns on the global flag disallowing any new 
1671         allocations, and the constructorBody() method in JSCell turns it off.  This way, allocation is still 
1672         allowed in constructor bodies while other refactoring efforts continue.
1673
1674         * bindings/js/JSDOMWindowShell.cpp:
1675         (WebCore::JSDOMWindowShell::operator new):
1676         * bindings/js/JSDOMWindowShell.h:
1677
1678 2011-08-23  Scott Byer  <scottbyer@chromium.org>
1679
1680         ScrollAnimatorNone coasting implementation
1681         https://bugs.webkit.org/show_bug.cgi?id=66258
1682
1683         Increase the animation time based on the velocity of the scroll, up to a
1684         maximum amount. Fix bugs found by additional unit testing.
1685
1686         Reviewed by James Robinson.
1687
1688         Additional tests in ScrollAnimatorNoneTest: CurveMathQuartic, CurveMathCoast,
1689         ScrollOnceQuartic, ScrollTwiceCubic, ScrollLotsCubic, ScrollLotsCubicSmoothed,
1690         ScrollUpToBumperCoast, ScrollDownToBumperCoast, VaryingInputsEquivalency,
1691         VaryingInputsEquivalencyCoast, VaryingInputsEquivalencyCoastLarge,
1692         VaryingInputsEquivalencyCoastSteep
1693
1694         * platform/ScrollAnimatorNone.cpp:
1695         (WebCore::ScrollAnimatorNone::Parameters::Parameters):
1696         (WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
1697         (WebCore::ScrollAnimatorNone::PerAxisData::coastCurve):
1698         (WebCore::ScrollAnimatorNone::PerAxisData::curveIntegralAt):
1699         (WebCore::ScrollAnimatorNone::PerAxisData::attackArea):
1700         (WebCore::ScrollAnimatorNone::PerAxisData::releaseArea):
1701         (WebCore::ScrollAnimatorNone::PerAxisData::PerAxisData):
1702         (WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
1703         (WebCore::ScrollAnimatorNone::PerAxisData::updateVisibleLength):
1704         (WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
1705         (WebCore::ScrollAnimatorNone::scroll):
1706         (WebCore::ScrollAnimatorNone::willEndLiveResize):
1707         (WebCore::ScrollAnimatorNone::didAddVerticalScrollbar):
1708         (WebCore::ScrollAnimatorNone::didAddHorizontalScrollbar):
1709         (WebCore::ScrollAnimatorNone::updateVisibleLengths):
1710         * platform/ScrollAnimatorNone.h:
1711
1712 2011-08-23  James Robinson  <jamesr@chromium.org>
1713
1714         [chromium] Need a way to test lost compositor context recovery
1715         https://bugs.webkit.org/show_bug.cgi?id=66820
1716
1717         Reviewed by Kenneth Russell.
1718
1719         Adds support for recreating a context as if it was lost, and fixes
1720         compositeAndReadback() to attempt context recovery.
1721
1722         Test: platform/chromium/compositing/lost-compositor-context.html
1723
1724         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
1725         (WebCore::CCLayerTreeHost::compositeAndReadback):
1726         (WebCore::CCLayerTreeHost::loseCompositorContext):
1727         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
1728
1729 2011-08-23  Nat Duca  <nduca@chromium.org>
1730
1731         [chromium] Implement CCThread in terms of WebThread
1732         https://bugs.webkit.org/show_bug.cgi?id=66610
1733
1734         Reviewed by Darin Fisher.
1735
1736         * WebCore.gypi:
1737         * platform/graphics/chromium/cc/CCCompletionEvent.h:
1738         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
1739         (WebCore::CCLayerTreeHost::client):
1740         * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
1741         (WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy):
1742         * platform/graphics/chromium/cc/CCThread.h:
1743         (WebCore::CCThread::~CCThread):
1744
1745 2011-08-23  Iain Merrick  <husky@google.com>
1746
1747         [chromium] Renderer crashes when about:gpucrash is loaded
1748         https://bugs.webkit.org/show_bug.cgi?id=66814
1749
1750         WebViewImpl::didRecreateGraphicsContext() was calling
1751         setRootLayer() on the CC layer tree, but the root layer 
1752         doesn't actually change and the code wasn't defensive        
1753         against this. This CL adds some asserts to catch tree
1754         corruption and removes the unnecessary calls.
1755
1756         Reviewed by James Robinson.
1757
1758         * platform/graphics/GraphicsLayer.cpp:
1759         (WebCore::GraphicsLayer::setParent):
1760         * platform/graphics/GraphicsLayer.h:
1761         * platform/graphics/chromium/LayerChromium.cpp:
1762         (WebCore::LayerChromium::setParent):
1763         (WebCore::LayerChromium::hasAncestor):
1764         * platform/graphics/chromium/LayerChromium.h:
1765
1766 2011-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1767
1768         Unreviewed, rolling out r93645.
1769         http://trac.webkit.org/changeset/93645
1770         https://bugs.webkit.org/show_bug.cgi?id=66828
1771
1772         Broke webkit_unit_tests on chromium mac (Requested by jamesr
1773         on #webkit).
1774
1775         * platform/chromium/ScrollbarThemeChromiumMac.mm:
1776         (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
1777         (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
1778
1779 2011-08-23  Beth Dakin  <bdakin@apple.com>
1780
1781         https://bugs.webkit.org/show_bug.cgi?id=66244
1782         Cached pages don't fully update when going back after changing the display scale 
1783         factor
1784         -and corresponding-
1785         <rdar://problem/9955656>
1786
1787         Reviewed by Darin Adler.
1788
1789         This patch adds a generalized concept of needing a full style recalc to the 
1790         BackForwardController. So when the display scale factor is changed, the 
1791         BackForwardController can be informed that all pages will need a full style recalc 
1792         when they come out of the cache. This same mechanism is also used to fix a long-
1793         standing bug with full-page/text zoom.
1794
1795         Iterate through the HistoryItems and mark all CachedPages as needing a full style 
1796         recalc.
1797         * history/BackForwardController.cpp:
1798         (WebCore::BackForwardController::markPagesForFullStyleRecalc):
1799         * history/BackForwardController.h:
1800
1801         ChachedPage has a new bool -- m_needsFullStyleRecalc -- to track whether a full 
1802         style recalc is needed when the CachedPage is restored.
1803         * history/CachedPage.cpp:
1804         (WebCore::CachedPage::CachedPage):
1805         (WebCore::CachedPage::restore):
1806         (WebCore::CachedPage::clear):
1807         * history/CachedPage.h:
1808         (WebCore::CachedPage::markForFullStyleRecalc):
1809
1810         HistoryItem actually takes care of calling into CachedPage.
1811         * history/HistoryItem.cpp:
1812         (WebCore::HistoryItem::markForFullStyleRecalc):
1813         * history/HistoryItem.h:
1814
1815         Fix style recalc issues for full-page/text zoom by calling our new function on 
1816         PageCache.
1817         * page/Frame.cpp:
1818         (WebCore::Frame::setPageAndTextZoomFactors):
1819
1820         Fix style recalc issues for display scale factor changes by calling our new 
1821         function on PageCache.
1822         * page/Page.cpp:
1823         (WebCore::Page::setDeviceScaleFactor):
1824
1825 2011-08-23  Anders Carlsson  <andersca@apple.com>
1826
1827         Fix build.
1828
1829         * inspector/InstrumentingAgents.cpp:
1830
1831 2011-08-23  Chang Shu  <cshu@webkit.org>
1832
1833         Added support for momentarily revealing last typed character in password input.
1834         Code change was partially based on Apple's iOS code and Samuel Nevala's work.
1835         https://bugs.webkit.org/show_bug.cgi?id=32509
1836
1837         Reviewed by Alexey Proskuryakov.
1838
1839         * editing/InsertIntoTextNodeCommand.cpp:
1840         (WebCore::InsertIntoTextNodeCommand::doApply):
1841         * rendering/RenderText.cpp:
1842         (WebCore::SecureTextTimer::SecureTextTimer):
1843         (WebCore::SecureTextTimer::restartWithNewText):
1844         (WebCore::SecureTextTimer::invalidate):
1845         (WebCore::SecureTextTimer::lastTypedCharacterOffset):
1846         (WebCore::SecureTextTimer::fired):
1847         (WebCore::RenderText::willBeDestroyed):
1848         (WebCore::RenderText::setTextInternal):
1849         (WebCore::RenderText::secureText):
1850         (WebCore::RenderText::momentarilyRevealLastTypedCharacter):
1851         * rendering/RenderText.h:
1852         (WebCore::RenderText::isSecure):
1853         * testing/Internals.cpp:
1854         (WebCore::Internals::setPasswordEchoEnabled): Fixed some silly coding in Internals.
1855         (WebCore::Internals::setPasswordEchoDurationInSeconds):
1856         (WebCore::Internals::reset):
1857
1858 2011-08-23  Dmitry Lomov  <Dmitry Lomov (dslomov@google.com)>
1859
1860         https://bugs.webkit.org/show_bug.cgi?id=66751 
1861         [Chromium]WebWorkerClientImpl should always invoke
1862         InspectorIntrumentation on main thread.
1863         The fix moves calls to InspectorInstrumentation from
1864         WebWorkerClientImpl to unedrlying WorkerMessagingProxy.
1865
1866         Reviewed by Pavel Feldman.
1867
1868         Covered by existing tests.
1869
1870         * inspector/InstrumentingAgents.cpp:
1871         (WebCore::instrumentationForPage):
1872         * workers/WorkerMessagingProxy.cpp:
1873         (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
1874         (WebCore::WorkerMessagingProxy::terminateWorkerContext):
1875
1876 2011-08-23  Misha Tyutyunik  <michael.tyutyunik@nokia.com>
1877
1878         [Qt] Button text is invisible when mobile theme is in use and application palette set to use light text color.
1879         https://bugs.webkit.org/show_bug.cgi?id=66635
1880
1881         When mobile theme is in use and application palette is using light 
1882         color to display text button text becomes invisible. The reason for 
1883         that is that in RenderThemeQt::systemFont() we are using application 
1884         pallete while when are painting buttons lightGrayPalette is used.
1885         Calling setPaletteFromPageClientIfExists() takes care of the issue.
1886         
1887         Reviewed by Andreas Kling.
1888
1889         Covered by existing tests.
1890
1891         * platform/qt/RenderThemeQt.cpp:
1892         (WebCore::RenderThemeQt::systemColor):
1893
1894 2011-08-23  Tony Chang  <tony@chromium.org>
1895
1896         Add handling of mix-width and max-width for flexitems
1897         https://bugs.webkit.org/show_bug.cgi?id=66723
1898
1899         Reviewed by David Hyatt.
1900
1901         If we flex past a min/max width value, we need to mark the flexitem as
1902         a fixed width and re-start the flexing algorithm.  We use a HashMap to
1903         keep track of fixed width items.
1904
1905         This patch also split out the size computation from the actual layout
1906         to avoid unnecessary layouts caused by restarting the flexing algorithm.
1907
1908         Test: css3/flexbox/003.html
1909
1910         * rendering/RenderFlexibleBox.cpp:
1911         (WebCore::RenderFlexibleBox::layoutHorizontalBlock):
1912         (WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):
1913         * rendering/RenderFlexibleBox.h:
1914
1915 2011-08-23  Pratik Solanki  <psolanki@apple.com>
1916
1917         ResourceRequest::setStorageSession should update NSURLRequest as well
1918         https://bugs.webkit.org/show_bug.cgi?id=66811
1919
1920         Reviewed by Darin Adler.
1921
1922         * platform/network/cf/ResourceRequestCFNet.cpp:
1923         (WebCore::ResourceRequest::setStorageSession): Update the m_nsRequest field as well since we
1924         have a new CFURLRequestRef.
1925
1926 2011-08-23  James Robinson  <jamesr@chromium.org>
1927
1928         [chromium] Remove obsolete child context list from LayerRendererChromium
1929         https://bugs.webkit.org/show_bug.cgi?id=66743
1930
1931         Reviewed by Kenneth Russell.
1932
1933         Before we had proper semantics for flush() in the command buffer, we
1934         used a scheme of latches across contexts to ensure consistent frames
1935         were presented for WebGL and canvas. We no longer have latches and
1936         flush is a proper synchronization primative, so the child context list
1937         no longer does anything. Canvas2DLayerChromium and
1938         WebGLLayerChromium's implementations of updateCompositorResources() do
1939         flushes on the appropriate context already - canvas layers via
1940         DrawingBuffer::publishToPlatformLayer(), and WebGL layers via the call
1941         to prepareTexture().
1942
1943         No new tests since the code being removed doesn't do anything.
1944
1945         * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
1946         (WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
1947         (WebCore::Canvas2DLayerChromium::setDrawingBuffer):
1948         * platform/graphics/chromium/Canvas2DLayerChromium.h:
1949         * platform/graphics/chromium/LayerRendererChromium.cpp:
1950         (WebCore::LayerRendererChromium::drawLayers):
1951         * platform/graphics/chromium/LayerRendererChromium.h:
1952         * platform/graphics/chromium/WebGLLayerChromium.cpp:
1953         (WebCore::WebGLLayerChromium::~WebGLLayerChromium):
1954         (WebCore::WebGLLayerChromium::setContext):
1955         * platform/graphics/chromium/WebGLLayerChromium.h:
1956
1957 2011-08-23  Alexei Svitkine  <asvitkine@chromium.org>
1958
1959         Chromium Mac: Use a custom pattern image for rubber banding overhang area
1960         https://bugs.webkit.org/show_bug.cgi?id=66707
1961
1962         Reviewed by Dimitri Glazkov.
1963
1964         No new tests since its just changing the Chromium-specific overhang pattern.
1965
1966         * platform/chromium/ScrollbarThemeChromiumMac.mm:
1967         (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
1968         (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
1969
1970 2011-08-23  Tatiana Meshkova  <tatiana.meshkova@nokia.com>
1971
1972         Prepare to paint slider thumb separately.
1973         Provide proper size values for vertical SliderThumb.
1974         https://bugs.webkit.org/show_bug.cgi?id=66732
1975
1976         Reviewed by Kenneth Rohde Christiansen.
1977
1978         * platform/qt/RenderThemeQt.cpp:
1979         (WebCore::RenderThemeQt::adjustSliderThumbSize):
1980         Swap length and thickness for sliderthumb-vertical.
1981
1982 2011-08-23  Adrienne Walker  <enne@google.com>
1983
1984         [chromium] Fix potential nullptr deref in TiledLayerChromium::pushPropertiesTo
1985         https://bugs.webkit.org/show_bug.cgi?id=66808
1986
1987         Reviewed by James Robinson.
1988
1989         * platform/graphics/chromium/TiledLayerChromium.cpp:
1990         (WebCore::TiledLayerChromium::pushPropertiesTo):
1991         * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
1992         (WebCore::CCTiledLayerImpl::draw):
1993
1994 2011-08-23  Peter Kasting  <pkasting@google.com>
1995
1996         Unreviewed, rolling out r93452.
1997         http://trac.webkit.org/changeset/93452
1998         https://bugs.webkit.org/show_bug.cgi?id=66423
1999
2000         Broke Leopard, Snowleopard, and Chromium bots
2001
2002         * xml/parser/XMLDocumentParserLibxml2.cpp:
2003         (WebCore::XMLDocumentParser::XMLDocumentParser):
2004
2005 2011-08-23  Ahmad Sharif  <asharif@chromium.org>
2006
2007         Fixed warnings produced by gcc-4.6.0.
2008         https://bugs.webkit.org/show_bug.cgi?id=62168
2009
2010         Reviewed by Adam Barth.
2011
2012         * dom/Element.cpp:
2013         (WebCore::Element::recalcStyle):
2014         * platform/ScrollAnimatorNone.cpp:
2015         (WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
2016         (WebCore::ScrollAnimatorNone::PerAxisData::curveDerivativeAt):
2017         * thirdparty: Copied from Source/WebCore/thirdparty.
2018
2019 2011-08-23  Alexandru Chiculita  <achicu@adobe.com>
2020
2021         Text overlaps with the floats
2022         https://bugs.webkit.org/show_bug.cgi?id=66671
2023
2024         The problem was that LineWidth::fitBelowFloats is not updating the m_left and m_right fields. 
2025         Next time LineWidth::shrinkAvailableWidthForNewFloatIfNeeded was called the width was recalculated 
2026         using the old values, making the line bigger.
2027
2028         Reviewed by David Hyatt.
2029
2030         Test: fast/block/float/fit_line_below_floats.html
2031
2032         * rendering/RenderBlockLineLayout.cpp:
2033         (WebCore::LineWidth::fitBelowFloats):
2034
2035 2011-08-23  Alexandru Chiculita  <achicu@adobe.com>
2036
2037         [CSSRegions] RenderFlowThread layout should use the attached region sizes
2038         https://bugs.webkit.org/show_bug.cgi?id=66143
2039
2040         When RenderFlowThread is doing the layout it also sets the current RenderFlowThread on
2041         the RenderView. RenderFlowThread cannot be nested inside a single RenderView, so there's no 
2042         need to put that on the LayoutState.
2043
2044         The right offset used to layout the inlines inside a RenderFlowThread
2045         is now adjusted to fit inside the current region.
2046
2047         Reviewed by David Hyatt.
2048
2049         Tests: fast/regions/webkit-flow-floats-inside-regions-bounds.html
2050                fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html
2051                fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html
2052                fast/regions/webkit-flow-inlines-inside-regions-bounds.html
2053
2054         * rendering/LayoutState.cpp:
2055         (WebCore::LayoutState::LayoutState):
2056         * rendering/RenderBlock.cpp:
2057         (WebCore::RenderBlock::layoutBlock):
2058         (WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
2059         (WebCore::RenderBlock::logicalRightOffsetForLine):
2060         * rendering/RenderBlock.h:
2061         * rendering/RenderFlowThread.cpp:
2062         (WebCore::RenderFlowThread::RenderFlowThread):
2063         (WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
2064         (WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
2065         (WebCore::RenderFlowThread::layout):
2066         (WebCore::RenderFlowThread::renderRegionForLine):
2067         (WebCore::RenderFlowThread::regionLogicalWidthForLine):
2068         * rendering/RenderFlowThread.h:
2069         (WebCore::RegionFittingDisabler::RegionFittingDisabler):
2070         (WebCore::RegionFittingDisabler::~RegionFittingDisabler):
2071         * rendering/RenderRegion.cpp:
2072         (WebCore::RenderRegion::layout):
2073         * rendering/RenderRegion.h:
2074         * rendering/RenderView.cpp:
2075         (WebCore::RenderView::RenderView):
2076         * rendering/RenderView.h:
2077         (WebCore::RenderView::hasRenderFlowThread):
2078         (WebCore::RenderView::currentRenderFlowThread):
2079         (WebCore::RenderView::setCurrentRenderFlowThread):
2080         (WebCore::RenderView::pushLayoutState):
2081
2082 2011-08-23  Alexandru Chiculita  <achicu@adobe.com>
2083
2084         Text-indent and floats push the text out of the container box
2085         https://bugs.webkit.org/show_bug.cgi?id=66662
2086
2087         Text indent was not propagated when a new float was pushed on the line.
2088         It was only calculated when the logicalLeft/RightOffsetForLine was called.
2089         Because of that RenderBlock::LineBreaker::nextLineBreak used a bigger width
2090         than actually available and made the line render on top of the borders.
2091
2092         Reviewed by David Hyatt.
2093
2094         Tests: fast/block/float/floats-and-text-indent-rl.html
2095                fast/block/float/floats-and-text-indent.html
2096
2097         * rendering/RenderBlock.cpp:
2098         (WebCore::RenderBlock::textIndentOffset):
2099         (WebCore::RenderBlock::logicalLeftOffsetForLine):
2100         (WebCore::RenderBlock::logicalRightOffsetForLine):
2101         * rendering/RenderBlock.h:
2102         * rendering/RenderBlockLineLayout.cpp:
2103         (WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
2104
2105 2011-08-23  Al Patrick  <apatrick@chromium.org>
2106
2107         Add shareResources flag to 3D graphics context attributes
2108         https://bugs.webkit.org/show_bug.cgi?id=66516
2109
2110         Reviewed by James Robinson.
2111
2112         * html/canvas/WebGLRenderingContext.cpp:
2113         (WebCore::WebGLRenderingContext::create):
2114         * platform/graphics/GraphicsContext3D.h:
2115         (WebCore::GraphicsContext3D::Attributes::Attributes):
2116         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
2117         (WebCore::SharedGraphicsContext3D::create):
2118
2119 2011-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2120
2121         Unreviewed, rolling out r93616.
2122         http://trac.webkit.org/changeset/93616
2123         https://bugs.webkit.org/show_bug.cgi?id=66796
2124
2125         "causes fast/css/absolute-child-with-percent-height-inside-
2126         relative-parent.html to fail" (Requested by mwenge2 on
2127         #webkit).
2128
2129         * rendering/RenderBlock.cpp:
2130         (WebCore::RenderBlock::adjustPositionedBlock):
2131         * rendering/RenderBlock.h:
2132         * rendering/RenderBlockLineLayout.cpp:
2133         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
2134         (WebCore::setStaticPositions):
2135         (WebCore::RenderBlock::LineBreaker::nextLineBreak):
2136
2137 2011-07-25  Robert Hogan  <robert@webkit.org>
2138
2139         div align="center" rendering problem
2140         https://bugs.webkit.org/show_bug.cgi?id=4860
2141
2142         Reviewed by David Hyatt.
2143
2144         Tests: fast/inline/absolute-positioned-block-in-centred-block.html
2145                fast/inline/absolute-positioned-inline-in-centred-block.html
2146
2147         When an element with absolute position was the sole or first child of a render block with
2148         centred alignment, it wasn't obeying its parent's alignment. However it would obey the
2149         alignment if it was preceded by some text. The problem was that the element's render object
2150         was getting skipped as leading white space, so it was not included in a normal line block in
2151         a bidi run. Instead, its position was getting set by RenderBlockLineLayout::setStaticPositions()
2152         which does not pay attention to alignment. Preceding the element with some text allowed the object
2153         to get included in a Bidi run and so get a linebox which would get properly aligned.
2154
2155         The fix is to get RenderBlockLineLayout::setStaticPositions() to obey the alignment specified by
2156         the object's container. This allows WebKit to get the same result on the test as Firefox and IE.
2157         Opera has the same bug as unpatched WebKit.
2158
2159         * rendering/RenderBlock.cpp:
2160         (WebCore::RenderBlock::adjustPositionedBlock): use startAlignedOffsetForBlock
2161         * rendering/RenderBlock.h:
2162         * rendering/RenderBlockLineLayout.cpp:
2163         (WebCore::RenderBlock::updateLogicalWidthForAlignment):
2164         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
2165         (WebCore::setStaticPositions): use startAlignedOffsetForLine and use startAlignedOffsetForBlock
2166         (WebCore::RenderBlock::LineBreaker::nextLineBreak): use startAlignedOffsetForLine
2167         (WebCore::RenderBlock::startAlignedOffsetForBlock): New function, find the aligned offset using updateLogicalWidthForAlignment
2168         (WebCore::RenderBlock::startAlignedOffsetForLine): ditto
2169
2170         * rendering/RenderBlock.h:
2171         * rendering/RenderBlockLineLayout.cpp:
2172         (WebCore::RenderBlock::updateLogicalWidthForAlignment):
2173         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
2174         (WebCore::setStaticPositions): use startAlignedOffsetForLine.
2175         (WebCore::RenderBlock::startAlignedOffsetForLine): New function, find the aligned offset using updateLogicalWidthForAlignment
2176
2177 2011-08-23  Adrienne Walker  <enne@google.com>
2178
2179         [chromium] Remove LayerRendererChromium references from TiledLayerChromium
2180         https://bugs.webkit.org/show_bug.cgi?id=66433
2181
2182         Reviewed by James Robinson.
2183
2184         Covered by existing tests.
2185
2186         Updated TiledLayerChromium and the texture updater classes to not
2187         access LayerRendererChromium or cache GraphicsContext3D. Some settings
2188         like max texture size were moved from LayerRendererChromium to
2189         CCLayerTreeHost in order to facilitate this refactoring.
2190
2191         LayerTextureUpdaterSkPicture has been #ifdef'd to only work when the
2192         compositor is not threaded. It will need to be refactored more in
2193         order to not own graphics resources from the main thread.
2194
2195         * platform/graphics/chromium/ContentLayerChromium.cpp:
2196         (WebCore::ContentLayerChromium::paintContentsIfDirty):
2197         (WebCore::ContentLayerChromium::createTextureUpdater):
2198         * platform/graphics/chromium/ContentLayerChromium.h:
2199         * platform/graphics/chromium/ImageLayerChromium.cpp:
2200         (WebCore::ImageLayerTextureUpdater::create):
2201         (WebCore::ImageLayerTextureUpdater::updateTextureRect):
2202         (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater):
2203         (WebCore::ImageLayerChromium::paintContentsIfDirty):
2204         (WebCore::ImageLayerChromium::createTextureUpdater):
2205         * platform/graphics/chromium/ImageLayerChromium.h:
2206         * platform/graphics/chromium/LayerChromium.cpp:
2207         (WebCore::LayerChromium::setLayerRenderer):
2208         (WebCore::LayerChromium::setLayerTreeHost):
2209         * platform/graphics/chromium/LayerChromium.h:
2210         * platform/graphics/chromium/LayerRendererChromium.cpp:
2211         * platform/graphics/chromium/LayerRendererChromium.h:
2212         * platform/graphics/chromium/LayerTextureUpdater.h:
2213         (WebCore::LayerTextureUpdater::LayerTextureUpdater):
2214         * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
2215         (WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
2216         (WebCore::LayerTextureUpdaterBitmap::create):
2217         (WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
2218         (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
2219         (WebCore::LayerTextureUpdaterSkPicture::create):
2220         (WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
2221         (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
2222         * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
2223         (WebCore::LayerTextureUpdaterSkPicture::context):
2224         * platform/graphics/chromium/TiledLayerChromium.cpp:
2225         (WebCore::TiledLayerChromium::setLayerTreeHost):
2226         (WebCore::TiledLayerChromium::updateCompositorResources):
2227         (WebCore::TiledLayerChromium::invalidateRect):
2228         (WebCore::TiledLayerChromium::prepareToUpdate):
2229         * platform/graphics/chromium/TiledLayerChromium.h:
2230         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
2231         (WebCore::CCLayerTreeHost::CCLayerTreeHost):
2232         (WebCore::CCLayerTreeHost::initialize):
2233         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
2234         (WebCore::CCLayerTreeHost::layerRenderer):
2235         (WebCore::CCLayerTreeHost::contextSupportsMapSub):
2236         (WebCore::CCLayerTreeHost::maxTextureSize):
2237         (WebCore::CCLayerTreeHost::bestTextureFormat):
2238
2239 2011-08-23  Julien Chaffraix  <jchaffraix@webkit.org>
2240
2241         Reduce the amount of RenderLayer rectangles' update when scrolling
2242         https://bugs.webkit.org/show_bug.cgi?id=66618
2243
2244         Reviewed by David Hyatt.
2245
2246         This patch avoids recomputing the RenderLayers rectangles if not needed.
2247
2248         The current code path for scrolling would update RenderLayers' repaint rectangles
2249         twice. However we do need to update only children of a fixed element as they are
2250         the only type of layers that move during a scroll.
2251
2252         We just change a call to updateLayerPositions for a call to updateLayerPositionsAfterScroll.
2253         updateLayerPositions being pessimist about the layer's state - because it is called after layout -
2254         it is missing some optimization that can be done during scrolling.
2255
2256         Tests: fast/repaint/scroll-absolute-layer-with-reflection.html
2257                fast/repaint/scroll-fixed-layer-with-reflection.html
2258                fast/repaint/scroll-fixed-layer-with-transformed-parent-layer.html
2259                fast/repaint/scroll-fixed-reflected-layer.html
2260                fast/repaint/scroll-in-clipped-layer.html
2261                fast/repaint/scroll-in-fixed-layer.html
2262                fast/repaint/scroll-in-transformed-layer.html
2263                fast/repaint/scroll-with-transformed-parent-layer.html
2264
2265         * rendering/RenderLayer.h:
2266         * page/FrameView.cpp:
2267         (WebCore::FrameView::repaintFixedElementsAfterScrolling):
2268         Updated those 2 call sites after updateRepaintRectsAfterScroll renaming.
2269
2270         * rendering/RenderLayer.cpp:
2271         (WebCore::RenderLayer::updateLayerPositionsAfterScroll): Beefed up the method
2272         to take care of also updating the layer's position (that sounded like a bug in
2273         the previous code that is covered by the tests above). Note that we don't care
2274         if one of our ancestor has a fixed position as we are scrolling *inside* this
2275         ancestor.
2276
2277         (WebCore::RenderLayer::scrollTo): Call updateLayerPositionsAfterScroll instead of
2278         updateLayerPositions.
2279
2280 2011-08-23  Jeffrey Pfau  <jpfau@apple.com>
2281
2282         New XML parser: pretty XML tree viewer
2283         https://bugs.webkit.org/show_bug.cgi?id=66489
2284
2285         Reviewed by Adam Barth.
2286
2287         * xml/parser/NewXMLDocumentParser.cpp:
2288         (WebCore::NewXMLDocumentParser::finish):
2289
2290 2011-08-23  Jessie Berlin  <jberlin@apple.com>
2291
2292         Build fix.
2293
2294         * inspector/InspectorDOMAgent.h:
2295         HighlightData is a struct, not a class.
2296
2297 2011-08-23  Andrey Kosyakov  <caseq@chromium.org>
2298
2299         Web Inspector: [Extensions API] provide access to page resources
2300         https://bugs.webkit.org/show_bug.cgi?id=66767
2301
2302         Reviewed by Pavel Feldman.
2303
2304         Test: inspector/extensions/extensions-resources.html
2305
2306         * inspector/front-end/ExtensionAPI.js:
2307         (WebInspector.injectedExtensionAPI.EventSinkImpl.prototype.addListener):
2308         (WebInspector.injectedExtensionAPI):
2309         (WebInspector.injectedExtensionAPI.RequestImpl.prototype.getContent):
2310         (WebInspector.injectedExtensionAPI.InspectedWindow.resourceDispatch):
2311         (WebInspector.injectedExtensionAPI.InspectedWindow.resourceContentDispatch):
2312         (WebInspector.injectedExtensionAPI.InspectedWindow):
2313         (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.eval):
2314         (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.getResources):
2315         (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.getResources.callbackWrapper):
2316         (WebInspector.injectedExtensionAPI.ResourceImpl.prototype.get url):
2317         (WebInspector.injectedExtensionAPI.ResourceImpl.prototype.get type):
2318         (WebInspector.injectedExtensionAPI.ResourceImpl.prototype.getContent):
2319         (WebInspector.injectedExtensionAPI.ResourceImpl.prototype.setContent):
2320         * inspector/front-end/ExtensionServer.js:
2321         (WebInspector.ExtensionServer):
2322         (WebInspector.ExtensionServer.prototype._notifyResourceAdded):
2323         (WebInspector.ExtensionServer.prototype.notifyResourceContentCommitted):
2324         (WebInspector.ExtensionServer.prototype._makeResource):
2325         (WebInspector.ExtensionServer.prototype._onGetPageResources):
2326         (WebInspector.ExtensionServer.prototype._getResourceContent):
2327         (WebInspector.ExtensionServer.prototype._onGetRequestContent):
2328         (WebInspector.ExtensionServer.prototype._onGetResourceContent):
2329         (WebInspector.ExtensionServer.prototype._onSetResourceContent):
2330         (WebInspector.ExtensionServer.prototype.initExtensions):
2331         * inspector/front-end/Resource.js:
2332         (WebInspector.Resource.prototype.addRevision):
2333
2334 2011-08-23  Pavel Feldman  <pfeldman@google.com>
2335
2336         Not reviewed: fixing build. One line drive-by typo fix in the inspector shortcut (Esc -> Backspace).
2337
2338         * inspector/InspectorDOMAgent.cpp:
2339         (WebCore::InspectorDOMAgent::highlightFrame):
2340         * inspector/front-end/treeoutline.js:
2341         (TreeOutline.prototype._treeKeyDown):
2342
2343 2011-08-23  Alexander Pavlov  <apavlov@chromium.org>
2344
2345         Web Inspector: differentiate element highlight colors for margin and padding
2346         https://bugs.webkit.org/show_bug.cgi?id=37768
2347
2348         The highlighting WIP API is slightly changed: clients will specify colors for certain elements of the highlighted objects,
2349         rather than a generic "highlighting mode". This allows to:
2350         - use entirely custom colors for highlighting (and vary them over time);
2351         - display any combination of fill/outline for the highlighted area;
2352         - highlight any combinations of element parts.
2353
2354         Reviewed by Pavel Feldman.
2355
2356         * inspector/DOMNodeHighlighter.cpp:
2357         (WebCore::DOMNodeHighlighter::drawHighlight):
2358         * inspector/DOMNodeHighlighter.h:
2359         * inspector/Inspector.json:
2360         * inspector/InspectorDOMAgent.cpp:
2361         (WebCore::parseColor):
2362         (WebCore::parseConfigColor):
2363         (WebCore::InspectorDOMAgent::~InspectorDOMAgent):
2364         (WebCore::InspectorDOMAgent::clearFrontend):
2365         (WebCore::InspectorDOMAgent::highlightedNode):
2366         (WebCore::InspectorDOMAgent::handleMousePress):
2367         (WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
2368         (WebCore::InspectorDOMAgent::setSearchingForNode):
2369         (WebCore::InspectorDOMAgent::setInspectModeEnabled):
2370         (WebCore::InspectorDOMAgent::setHighlightDataFromConfig):
2371         (WebCore::InspectorDOMAgent::highlight):
2372         (WebCore::InspectorDOMAgent::highlightRect):
2373         (WebCore::InspectorDOMAgent::highlightNode):
2374         (WebCore::InspectorDOMAgent::highlightFrame):
2375         (WebCore::InspectorDOMAgent::hideHighlight):
2376         (WebCore::InspectorDOMAgent::drawHighlight):
2377         * inspector/InspectorDOMAgent.h:
2378         * inspector/front-end/Color.js:
2379         (WebInspector.Color.fromRGBA):
2380         (WebInspector.Color.prototype.toProtocolRGBA):
2381         * inspector/front-end/ElementsPanel.js:
2382         (WebInspector.ElementsPanel.prototype.setSearchingForNode):
2383         * inspector/front-end/MetricsSidebarPane.js:
2384         (WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.handleMouseOver):
2385         (WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.handleMouseOut):
2386         (WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):
2387         * inspector/front-end/ResourcesPanel.js:
2388         (WebInspector.FrameTreeElement.prototype.set hovered):
2389         * inspector/front-end/TimelinePanel.js:
2390         (WebInspector.TimelinePanel.prototype._highlightRect):
2391         * inspector/front-end/inspector.css:
2392         * inspector/front-end/inspector.js:
2393         (WebInspector.buildHighlightConfig):
2394         (WebInspector.highlightDOMNode):
2395
2396 2011-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2397
2398         Unreviewed, rolling out r93579.
2399         http://trac.webkit.org/changeset/93579
2400         https://bugs.webkit.org/show_bug.cgi?id=66774
2401
2402         "ASSERTION FAILED: m_purgePreventCount" (Requested by tonyg-cr
2403         on #webkit).
2404
2405         * platform/graphics/chromium/FontCacheLinux.cpp:
2406         (WebCore::FontCache::getFontDataForCharacters):
2407
2408 2011-08-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2409
2410         [Qt] Fix build on Lion
2411
2412         https://bugs.webkit.org/show_bug.cgi?id=66770
2413
2414         Reviewed by Andreas Kling.
2415
2416         We were mistakenly picking up mac/WebCoreSystemInterface.h instead of
2417         the Qt one, and building on Lion revealed this when a typedef for
2418         IOSurfaceRef was wrapped in PLATFORM(MAC).
2419
2420         For now we fix this by including WebCoreSystemInterface using
2421         brackets, so that we'll pick up the right file based on the
2422         include paths. This also means exposing a few missing enums
2423         in our own version of the file, so those were added.
2424
2425         Lasty, we need to link against the right system interface library
2426         on Lion.
2427
2428         * platform/mac/WebVideoFullscreenHUDWindowController.mm:
2429         * platform/qt/WebCoreSystemInterface.h:
2430
2431 2011-08-23  Steve Block  <steveblock@google.com>
2432
2433         Remove last occurrences of PLATFORM(ANDROID)
2434         https://bugs.webkit.org/show_bug.cgi?id=66763
2435
2436         Reviewed by Tony Gentilcore.
2437
2438         No new tests, removing dead code only.
2439
2440         * bindings/v8/V8GCController.cpp:
2441         (WebCore::V8GCController::checkMemoryUsage):
2442
2443 2011-08-23  Steve Block  <steveblock@google.com>
2444
2445         Remove Android-specific modifications to non-client-based Geolocation
2446         https://bugs.webkit.org/show_bug.cgi?id=66759
2447
2448         Reviewed by Tony Gentilcore.
2449
2450         No new tests, removing dead code only.
2451
2452         * page/Geolocation.cpp:
2453         * page/Geolocation.h:
2454         * platform/GeolocationService.h:
2455         * platform/efl/GeolocationServiceEfl.cpp:
2456         * platform/efl/GeolocationServiceEfl.h:
2457         * platform/gtk/GeolocationServiceGtk.cpp:
2458         * platform/gtk/GeolocationServiceGtk.h:
2459
2460 2011-08-19  Pavel Podivilov  <podivilov@chromium.org>
2461
2462         Web Inspector: switch to using BreakpointManager.
2463         https://bugs.webkit.org/show_bug.cgi?id=66225
2464
2465         Reviewed by Pavel Feldman.
2466
2467         * inspector/front-end/DebuggerPresentationModel.js:
2468         (WebInspector.DebuggerPresentationModel):
2469         (WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
2470         (WebInspector.DebuggerPresentationModel.prototype._addScript):
2471         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
2472         (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
2473         (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
2474         (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
2475         (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
2476         (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
2477         (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
2478         (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
2479         (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
2480         (WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
2481         (WebInspector.PresentationBreakpoint.prototype.loadSnippet):
2482         * inspector/front-end/SourceFile.js:
2483         (WebInspector.RawSourceCode):
2484
2485 2011-08-23  Steve Block  <steveblock@google.com>
2486
2487         Remove all mention of removed Android files from build scripts
2488         https://bugs.webkit.org/show_bug.cgi?id=66755
2489
2490         Reviewed by Tony Gentilcore.
2491
2492         No new tests, removing dead code only.
2493
2494         * WebCore.gyp/WebCore.gyp:
2495         * WebCore.gypi:
2496         * gyp/WebCore.gyp:
2497
2498 2011-08-23  Mikhail Naganov  <mnaganov@chromium.org>
2499
2500         Web Inspector: [Chromium] Fix handling of aggregate names in profiler.
2501         https://bugs.webkit.org/show_bug.cgi?id=66753
2502
2503         Reviewed by Pavel Feldman.
2504
2505         * inspector/front-end/HeapSnapshot.js:
2506         (WebInspector.HeapSnapshot.prototype._buildAggregates):
2507
2508 2011-08-23  Adam Barth  <abarth@webkit.org>
2509
2510         Remove WebCore/editing/android and other Android-specific directories
2511         https://bugs.webkit.org/show_bug.cgi?id=66739
2512
2513         Reviewed by Steve Block.
2514
2515         Now that Android shares more code with Chromium, we don't need these
2516         Android-specific files.
2517
2518         * editing/android: Removed.
2519         * editing/android/EditorAndroid.cpp: Removed.
2520         * history/android: Removed.
2521         * history/android/AndroidWebHistoryBridge.h: Removed.
2522         * history/android/HistoryItemAndroid.cpp: Removed.
2523         * page/android: Removed.
2524         * page/android/DragControllerAndroid.cpp: Removed.
2525         * page/android/EventHandlerAndroid.cpp: Removed.
2526         * platform/network/android: Removed.
2527         * platform/network/android/AuthenticationChallenge.h: Removed.
2528         * platform/network/android/CookieJarAndroid.cpp: Removed.
2529         * platform/network/android/ProxyServerAndroid.cpp: Removed.
2530         * platform/network/android/ResourceError.h: Removed.
2531         * platform/network/android/ResourceHandleAndroid.cpp: Removed.
2532         * platform/network/android/ResourceLoaderAndroid.h: Removed.
2533         * platform/network/android/ResourceRequest.h: Removed.
2534         * platform/network/android/ResourceRequestAndroid.cpp: Removed.
2535         * platform/network/android/ResourceResponse.h: Removed.
2536         * platform/text/android: Removed.
2537         * platform/text/android/HyphenationAndroid.cpp: Removed.
2538         * platform/text/android/TextBreakIteratorInternalICU.cpp: Removed.
2539
2540 2011-08-23  Adam Barth  <abarth@webkit.org>
2541
2542         Remove WebCore/platform/android
2543         https://bugs.webkit.org/show_bug.cgi?id=66734
2544
2545         Reviewed by Steve Block.
2546
2547         This directory is not needed now that Android shares more code with
2548         Chromium.
2549
2550         * platform/android: Removed.
2551         * platform/android/ClipboardAndroid.cpp: Removed.
2552         * platform/android/ClipboardAndroid.h: Removed.
2553         * platform/android/CursorAndroid.cpp: Removed.
2554         * platform/android/DragDataAndroid.cpp: Removed.
2555         * platform/android/EventLoopAndroid.cpp: Removed.
2556         * platform/android/FileSystemAndroid.cpp: Removed.
2557         * platform/android/GeolocationServiceAndroid.cpp: Removed.
2558         * platform/android/GeolocationServiceAndroid.h: Removed.
2559         * platform/android/GeolocationServiceBridge.cpp: Removed.
2560         * platform/android/GeolocationServiceBridge.h: Removed.
2561         * platform/android/KeyEventAndroid.cpp: Removed.
2562         * platform/android/LanguageAndroid.cpp: Removed.
2563         * platform/android/LocalizedStringsAndroid.cpp: Removed.
2564         * platform/android/PlatformBridge.h: Removed.
2565         * platform/android/PlatformTouchEventAndroid.cpp: Removed.
2566         * platform/android/PlatformTouchPointAndroid.cpp: Removed.
2567         * platform/android/PopupMenuAndroid.cpp: Removed.
2568         * platform/android/RenderThemeAndroid.cpp: Removed.
2569         * platform/android/RenderThemeAndroid.h: Removed.
2570         * platform/android/SSLKeyGeneratorAndroid.cpp: Removed.
2571         * platform/android/ScreenAndroid.cpp: Removed.
2572         * platform/android/ScrollViewAndroid.cpp: Removed.
2573         * platform/android/SearchPopupMenuAndroid.cpp: Removed.
2574         * platform/android/SharedTimerAndroid.cpp: Removed.
2575         * platform/android/SoundAndroid.cpp: Removed.
2576         * platform/android/SystemTimeAndroid.cpp: Removed.
2577         * platform/android/TemporaryLinkStubs.cpp: Removed.
2578         * platform/android/WidgetAndroid.cpp: Removed.
2579
2580 2011-08-23  Pavel Feldman  <pfeldman@google.com>
2581
2582         Not reviewed. Adding a file that slipped from r93586.
2583
2584         * inspector/generate-protocol-externs: Added.
2585
2586 2011-08-22  Pavel Feldman  <pfeldman@google.com>
2587
2588         Web Inspector: generate protocol externs API for the front-end compilation.
2589         https://bugs.webkit.org/show_bug.cgi?id=66677
2590
2591         Reviewed by Tony Gentilcore.
2592
2593         * inspector/Inspector.json:
2594         * inspector/InspectorDOMAgent.cpp:
2595         (WebCore::InspectorDOMAgent::setAttributesText):
2596         * inspector/InspectorDOMAgent.h:
2597         * inspector/InspectorDebuggerAgent.cpp:
2598         (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
2599         * inspector/InspectorDebuggerAgent.h:
2600         * inspector/compile-front-end.sh: Added.
2601         * inspector/front-end/DOMAgent.js:
2602         (WebInspector.DOMNode.prototype.setAttribute):
2603         * inspector/front-end/DebuggerModel.js:
2604         (WebInspector.DebuggerModel.prototype.setBreakpoint):
2605         * inspector/front-end/externs.js: Added.
2606         (console.warn):
2607
2608 2011-08-22  Pavel Feldman  <pfeldman@google.com>
2609
2610         Web Inspector: Prepare utilities.js for compilation.
2611         https://bugs.webkit.org/show_bug.cgi?id=66656
2612
2613         Removes "this" usage in functions, does not define getters for offsets.
2614
2615         Reviewed by Tony Gentilcore.
2616
2617         * inspector/front-end/ConsoleView.js:
2618         (WebInspector.ConsoleMessage.prototype._format):
2619         (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.valueFormatter):
2620         * inspector/front-end/DOMAgent.js:
2621         (WebInspector.DOMNode.prototype.appropriateSelectorFor):
2622         (WebInspector.DOMNode.prototype.isAncestor):
2623         (WebInspector.DOMNode.prototype.isDescendant):
2624         (WebInspector.DOMNode.prototype.isWhitespace):
2625         * inspector/front-end/DataGrid.js:
2626         (WebInspector.DataGrid.prototype._resizerDragging):
2627         (WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):
2628         * inspector/front-end/Drawer.js:
2629         (WebInspector.Drawer.prototype.get savedHeight):
2630         (WebInspector.Drawer.prototype.onResize):
2631         (WebInspector.Drawer.prototype._startStatusBarDragging):
2632         (WebInspector.Drawer.prototype._statusBarDragging):
2633         * inspector/front-end/ElementsPanel.js:
2634         (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
2635         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
2636         (WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.crumbsAreSmallerThanContainer):
2637         * inspector/front-end/ElementsTreeOutline.js:
2638         (WebInspector.ElementsTreeOutline.prototype.findTreeElement):
2639         (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
2640         ():
2641         * inspector/front-end/RemoteObject.js:
2642         (WebInspector.RemoteObject):
2643         * inspector/front-end/ResourceTimingView.js:
2644         (WebInspector.ResourceTimingView.createTimingTable):
2645         * inspector/front-end/ResourcesPanel.js:
2646         (WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):
2647         * inspector/front-end/ScriptsPanel.js:
2648         (WebInspector.ScriptsPanel.prototype._startSidebarResizeDrag):
2649         * inspector/front-end/SoftContextMenu.js:
2650         (.WebInspector.SoftContextMenu.prototype.show):
2651         * inspector/front-end/Toolbar.js:
2652         (WebInspector.ToolbarDropdown.prototype.show):
2653         * inspector/front-end/WatchExpressionsSidebarPane.js:
2654         (WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):
2655         * inspector/front-end/inspector.js:
2656         (Number.secondsToString):
2657         (Number.bytesToString):
2658         * inspector/front-end/treeoutline.js:
2659         (TreeElement.prototype.isEventWithinDisclosureTriangle):
2660         * inspector/front-end/utilities.js:
2661         (setupPrototypeUtilities.Element.prototype.totalOffsetLeft):
2662         (setupPrototypeUtilities.Element.prototype.totalOffsetTop):
2663         (setupPrototypeUtilities.Element.prototype.offsetRelativeToWindow):
2664         (setupPrototypeUtilities):
2665         (setupPrototypeUtilities.):
2666         ():
2667
2668 2011-08-22  John Bates  <jbates@google.com>
2669
2670         Implemented skia support for caching resizes of cropped images.
2671         https://bugs.webkit.org/show_bug.cgi?id=65587
2672
2673         Reviewed by Darin Fisher.
2674
2675         Previously, resizes of cropped images would not be cached. This causes various websites to have janky CSS animations in software compositing mode.
2676
2677         * platform/graphics/skia/ImageSkia.cpp:
2678         (WebCore::drawResampledBitmap): Changed to use new APIs for subset caching.
2679         (WebCore::Image::drawPattern): Added allowCaching parameter.
2680         * platform/graphics/skia/NativeImageSkia.cpp:
2681         (WebCore::NativeImageSkia::NativeImageSkia):
2682         (WebCore::NativeImageSkia::CachedImageInfo::CachedImageInfo):
2683         (WebCore::NativeImageSkia::CachedImageInfo::isEqual):
2684         (WebCore::NativeImageSkia::CachedImageInfo::set):
2685         (WebCore::NativeImageSkia::hasResizedBitmap): Changed this method so that it does not modify caching data. Added a second version used for cropped image resizes.
2686         (WebCore::NativeImageSkia::resizedBitmap): Added parameter to let caller specify whether caching is allowed.
2687         (WebCore::NativeImageSkia::shouldCacheResampling): Added a second version used for cropped image resizes.
2688         (WebCore::NativeImageSkia::shouldCacheResamplingInternal): Both shouldCacheResampling methods call down to this for the shared logic.
2689         * platform/graphics/skia/NativeImageSkia.h: Added CachedImageInfo to uniquely identify the cached or requested image resize operation.
2690
2691 2011-08-22  Tony Gentilcore  <tonyg@chromium.org>
2692
2693         [chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
2694         https://bugs.webkit.org/show_bug.cgi?id=66673
2695
2696         Reviewed by James Robinson.
2697
2698         This was fixed for other ports in http://trac.webkit.org/changeset/88260.
2699         However, it was missed in FontCacheLinux likely due to similar param in the nested call to getCachedFontPlatformData().
2700
2701         No new tests because no directly observable change in behavior.
2702
2703         * platform/graphics/chromium/FontCacheLinux.cpp:
2704         (WebCore::FontCache::getFontDataForCharacters):
2705
2706 2011-08-22  Sheriff Bot  <webkit.review.bot@gmail.com>
2707
2708         Unreviewed, rolling out r93565.
2709         http://trac.webkit.org/changeset/93565
2710         https://bugs.webkit.org/show_bug.cgi?id=66745
2711
2712         Breaks layout tests (Requested by koz2 on #webkit).
2713
2714         * accessibility/AccessibilityRenderObject.cpp:
2715         (WebCore::AccessibilityRenderObject::ariaLabeledByElements):
2716         (WebCore::AccessibilityRenderObject::ariaLabeledByAttribute):
2717         (WebCore::AccessibilityRenderObject::title):
2718         (WebCore::AccessibilityRenderObject::hasTextAlternative):
2719         * accessibility/AccessibilityRenderObject.h:
2720
2721 2011-08-22  Alice Boxhall  <aboxhall@chromium.org>
2722
2723         Range::setEnd(const Position&, ExceptionCode) calls setStart() instead of setEnd()
2724         https://bugs.webkit.org/show_bug.cgi?id=66638
2725
2726         Reviewed by Ryosuke Niwa.
2727
2728         Relevant layout test coming in a future patch (see https://bugs.webkit.org/show_bug.cgi?id=65900)
2729
2730         * dom/Range.cpp:
2731         (WebCore::Range::setEnd):
2732
2733 2011-08-22  Adam Barth  <abarth@webkit.org>
2734
2735         Remove PLATFORM(ANDROID)
2736         https://bugs.webkit.org/show_bug.cgi?id=66741
2737
2738         Reviewed by Darin Adler.
2739
2740         PLATFORM(CHROMIUM) && OS(ANDROID) is the new hotness.  These special
2741         cases can be removed now that Android shares more code with Chromium.
2742
2743         * bindings/js/JSDOMWindowBase.cpp:
2744         (WebCore::JSDOMWindowBase::supportsRichSourceInfo):
2745         * bindings/v8/ScriptCachedFrameData.cpp:
2746         * bindings/v8/ScriptCachedFrameData.h:
2747         * bindings/v8/V8GCController.cpp:
2748         * bridge/jni/jsc/JavaInstanceJSC.cpp:
2749         (JavaInstance::invokeMethod):
2750         * history/HistoryItem.cpp:
2751         (WebCore::HistoryItem::~HistoryItem):
2752         (WebCore::HistoryItem::setDocumentState):
2753         (WebCore::HistoryItem::clearDocumentState):
2754         (WebCore::HistoryItem::setIsTargetItem):
2755         (WebCore::HistoryItem::addChildItem):
2756         (WebCore::HistoryItem::setFormInfoFromRequest):
2757         * history/HistoryItem.h:
2758         * loader/cache/CachedFont.cpp:
2759         * platform/DragImage.h:
2760         * platform/PlatformTouchEvent.h:
2761         * platform/PlatformTouchPoint.h:
2762         (WebCore::PlatformTouchPoint::PlatformTouchPoint):
2763         * platform/Widget.h:
2764         * platform/network/NetworkStateNotifier.cpp:
2765         * platform/network/NetworkStateNotifier.h:
2766         * platform/network/NetworkingContext.h:
2767         * platform/network/ResourceHandle.h:
2768         * platform/network/ResourceHandleInternal.h:
2769         * platform/network/ResourceRequestBase.cpp:
2770
2771 2011-08-22  Adrienne Walker  <enne@google.com>
2772
2773         [chromium] Remove compositing assertions about creating layers when painting
2774         https://bugs.webkit.org/show_bug.cgi?id=66731
2775
2776         Reviewed by James Robinson.
2777
2778         The trigger for this assertion would cause a real rendering issue, but
2779         it is both intermittent and in the wrong place in the codebase to
2780         catch the source of the problem.
2781
2782         * platform/graphics/chromium/LayerChromium.cpp:
2783         (WebCore::LayerChromium::LayerChromium):
2784         (WebCore::LayerChromium::~LayerChromium):
2785         * platform/graphics/chromium/LayerRendererChromium.cpp:
2786         (WebCore::LayerRendererChromium::updateLayers):
2787         * platform/graphics/chromium/LayerRendererChromium.h:
2788
2789 2011-08-22  Alexey Proskuryakov  <ap@apple.com>
2790
2791         showModalDialog does not correctly return the defined returnValue in case domain relaxing is used
2792         https://bugs.webkit.org/show_bug.cgi?id=53191
2793         <rdar://problem/8629478>
2794
2795         Reviewed by Geoff Garen.
2796
2797         Cannot test domain relaxing, we only have 127.0.0.1 and localhost.
2798
2799         * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot):
2800         Added a FIXME about a difference with Firefox.
2801
2802         (WebCore::DialogHandler::DialogHandler):
2803         (WebCore::DialogHandler::dialogCreated):
2804         (WebCore::DialogHandler::returnValue):
2805         Changed to fetch returnValue from the global object that's in the frame when the dialog is
2806         dismissed. A dialog can navigate itself, and it also creates a new JSDOMWindow on first load
2807         if the origin doesn't match opener origin (which the case with domain relaxing).
2808         Re-added a security check for returnValue that got lost in r73829, so that we don't send the
2809         result across origins. This matches Firefox.
2810
2811         * bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow): Added an assertion
2812         against a very confusing case that should no longer occur.
2813
2814         * page/Frame.cpp: (WebCore::Frame::pageDestroyed): Don't clear the window shell, it doesn't
2815         seem necessary, but prevents DialogHandler from fetching the return value. Added a keepAlive
2816         call to avoid changing life support timer behavior in this patch.
2817
2818 2011-08-22  Alice Boxhall  <aboxhall@chromium.org>
2819
2820         Reviewed by Chris Fleizach.
2821
2822         aria-labelledby should be used in preference to aria-labeledby
2823         https://bugs.webkit.org/show_bug.cgi?id=62351
2824
2825         Test: accessibility/aria-labelledby-overrides-aria-labeledby.html
2826
2827         * accessibility/AccessibilityRenderObject.cpp:
2828         (WebCore::AccessibilityRenderObject::ariaLabelledByElements): Renamed from ariaLabeledByElements.
2829         (WebCore::AccessibilityRenderObject::ariaLabelledByAttribute): Renamed from ariaLabeledByAttribute,
2830         and re-ordered to prefer the standard spelling.
2831         (WebCore::AccessibilityRenderObject::title):
2832         (WebCore::AccessibilityRenderObject::hasTextAlternative):
2833         * accessibility/AccessibilityRenderObject.h:
2834
2835 2011-08-22  Nat Duca  <nduca@chromium.org>
2836
2837         Make GraphicsContext3D::isResourceSafe a function and, on Chromium, determine its value lazily
2838         https://bugs.webkit.org/show_bug.cgi?id=66708
2839
2840         Reviewed by Kenneth Russell.
2841
2842         * platform/graphics/GraphicsContext3D.cpp:
2843         (WebCore::GraphicsContext3D::texImage2DResourceSafe):
2844         * platform/graphics/GraphicsContext3D.h:
2845         * platform/graphics/gtk/GraphicsContext3DGtk.cpp:
2846         (WebCore::GraphicsContext3D::GraphicsContext3D):
2847         * platform/graphics/mac/GraphicsContext3DMac.mm:
2848         (WebCore::GraphicsContext3D::GraphicsContext3D):
2849         * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
2850         (WebCore::GraphicsContext3D::isResourceSafe):
2851         * platform/graphics/qt/GraphicsContext3DQt.cpp:
2852         (WebCore::GraphicsContext3D::GraphicsContext3D):
2853
2854 2011-08-22  Adam Barth  <abarth@webkit.org>
2855
2856         HTMLSourceTracker crashes when network packets break poorly
2857         https://bugs.webkit.org/show_bug.cgi?id=66728
2858
2859         Reviewed by Darin Adler.
2860
2861         If there is a network packet boundary in the middle of an attribute
2862         that begins with the letters "on", then the HTMLSourceTracker will get
2863         confused and try to extract too many characters from future input.  If
2864         the future input is small enough, that will walk off the end of the
2865         input and crash.
2866
2867         Test: http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html
2868
2869         * html/parser/HTMLSourceTracker.cpp:
2870         (WebCore::HTMLSourceTracker::sourceForToken):
2871
2872 2011-08-22  Eric Seidel  <eric@webkit.org>
2873
2874         Attempt to clean up bidiNext usage
2875         https://bugs.webkit.org/show_bug.cgi?id=66721
2876
2877         Reviewed by Ryosuke Niwa.
2878
2879         bidiNext and bidiFirst are horribly confusing.
2880         Even worse is that bidiNext takes a bunch of mutually exclusive options.
2881         It appears that there is a "return me every inline, even if its empty"
2882         mode which is only used for simplified inline layout in RenderBlock.cpp.
2883         To support that mode, there is a endOfInline pointer which keeps track
2884         of if we just returned at the end of an inline to so we don't get stuck in
2885         and empty inline (unable to distinguish the start from the finish).
2886
2887         The actual bidi/line-layout code uses bidiNext/bidiFirst in a "skip empty inlines"
2888         mode.  (Since empty inlines do not participate in the Unicode Bidi Algorithm.)
2889
2890         This change renames bidiNext to bidiNextShared (still a horrible name) and moves
2891         all callers to explicitly calling bidiNextSkippingEmptyInlines or bidiNextIncludingEmptyInlines.
2892         It becomes obvious which code uses which.
2893
2894         In reviewing this code be aware that the previous bidiNext default was to "skip empty inlines" (skipInlines = true).
2895         Thus any caller who didn't pass true/false should now be calling bidiNextSkippingEmptyInlines instead.
2896
2897         No functional change, thus no tests.
2898
2899         * rendering/InlineIterator.h:
2900         (WebCore::bidiNextShared):
2901         (WebCore::bidiNextSkippingEmptyInlines):
2902         (WebCore::bidiNextIncludingEmptyInlines):
2903         (WebCore::bidiFirstSkippingEmptyInlines):
2904         (WebCore::bidiFirstIncludingEmptyInlines):
2905         (WebCore::InlineWalker::InlineWalker):
2906         (WebCore::InlineWalker::advance):
2907         (WebCore::InlineIterator::increment):
2908         (WebCore::InlineBidiResolver::appendRun):
2909         * rendering/RenderBlockLineLayout.cpp:
2910         (WebCore::RenderBlock::determineStartPosition):
2911         (WebCore::shouldSkipWhitespaceAfterStartObject):
2912         (WebCore::RenderBlock::LineBreaker::nextLineBreak):
2913
2914 2011-08-22  David Levin  <levin@chromium.org>
2915
2916         Fix usage of PassRefPtr in postMessage and structured clone code.
2917         https://bugs.webkit.org/show_bug.cgi?id=66725
2918
2919         Reviewed by Darin Adler.
2920
2921         No new functionality exposed so no new tests.
2922
2923         * bindings/js/JSDOMWindowCustom.cpp:
2924         (WebCore::JSDOMWindow::postMessage): Changed PassRefPtr to RefPtr and added release when handed off.
2925         * bindings/js/JSMessageEventCustom.cpp:
2926         (WebCore::JSMessageEvent::initMessageEvent): Ditto.
2927         * bindings/js/JSMessagePortCustom.h:
2928         (WebCore::handlePostMessage): Ditto.
2929         * bindings/js/SerializedScriptValue.cpp:
2930         (WebCore::SerializedScriptValue::create): Ditto.
2931         * workers/SharedWorkerContext.cpp:
2932         (WebCore::createConnectEvent): Added release() when a RefPtr is returned.
2933
2934 2011-08-22  Luke Macpherson   <macpherson@chromium.org>
2935
2936         Implement cast between CSSPrimitiveValue and EBackfaceVisibility, use in CSSStyleSelector::applyProperty.
2937         https://bugs.webkit.org/show_bug.cgi?id=66648
2938
2939         Reviewed by Dan Bernstein.
2940
2941         No new tests / no functionality changed.
2942
2943         * css/CSSPrimitiveValueMappings.h:
2944         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2945         Support cast from EBackfaceVisibility.
2946         (WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
2947         Support cast from EBackfaceVisibility.
2948         * css/CSSStyleSelector.cpp:
2949         (WebCore::CSSStyleSelector::applyProperty):
2950         Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro.
2951
2952 2011-08-22  Peter Kasting  <pkasting@google.com>
2953
2954         Unreviewed, rolling out r93538.
2955         http://trac.webkit.org/changeset/93538
2956         https://bugs.webkit.org/show_bug.cgi?id=66143
2957
2958         Broke Leopard, SnowLeopard, and Chromium Mac bots
2959
2960         * rendering/LayoutState.cpp:
2961         (WebCore::LayoutState::LayoutState):
2962         * rendering/RenderBlock.cpp:
2963         (WebCore::RenderBlock::layoutBlock):
2964         (WebCore::RenderBlock::logicalRightOffsetForLine):
2965         * rendering/RenderBlock.h:
2966         * rendering/RenderFlowThread.cpp:
2967         (WebCore::RenderFlowThread::RenderFlowThread):
2968         (WebCore::RenderFlowThread::layout):
2969         (WebCore::RenderFlowThread::repaintRectangleInRegions):
2970         * rendering/RenderFlowThread.h:
2971         * rendering/RenderRegion.cpp:
2972         * rendering/RenderRegion.h:
2973         * rendering/RenderView.cpp:
2974         (WebCore::RenderView::RenderView):
2975         * rendering/RenderView.h:
2976         (WebCore::RenderView::pushLayoutState):
2977
2978 2011-08-22  Tony Chang  <tony@chromium.org>
2979
2980         Add CSS parsing of -webkit-flex-pack
2981         https://bugs.webkit.org/show_bug.cgi?id=66701
2982
2983         Reviewed by Eric Seidel.
2984
2985         * css/CSSComputedStyleDeclaration.cpp:
2986         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2987         * css/CSSParser.cpp:
2988         (WebCore::CSSParser::parseValue):
2989         * css/CSSPrimitiveValueMappings.h:
2990         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2991         (WebCore::CSSPrimitiveValue::operator EFlexPack):
2992         * css/CSSPropertyNames.in:
2993         * css/CSSStyleApplyProperty.cpp:
2994         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2995         * css/CSSStyleSelector.cpp:
2996         (WebCore::CSSStyleSelector::applyProperty):
2997         * rendering/style/RenderStyle.h:
2998         (WebCore::InheritedFlags::flexPack):
2999         (WebCore::InheritedFlags::setFlexPack):
3000         (WebCore::InheritedFlags::initialFlexPack):
3001         * rendering/style/RenderStyleConstants.h:
3002         * rendering/style/StyleFlexibleBoxData.cpp:
3003         (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
3004         (WebCore::StyleFlexibleBoxData::operator==):
3005         * rendering/style/StyleFlexibleBoxData.h:
3006
3007 2011-08-22  Tony Chang  <tony@chromium.org>
3008
3009         handle child margin values when flexing
3010         https://bugs.webkit.org/show_bug.cgi?id=65887
3011
3012         Reviewed by David Hyatt.
3013
3014         Test: css3/flexbox/002.html
3015
3016         * rendering/RenderBox.cpp:
3017         (WebCore::RenderBox::computeLogicalWidth):
3018         * rendering/RenderFlexibleBox.cpp:
3019         (WebCore::RenderFlexibleBox::layoutHorizontalBlock):
3020         (WebCore::RenderFlexibleBox::computePreferredSize): If the margin is
3021             auto, treat it as flex(1 0 0).
3022         * rendering/RenderObject.cpp:
3023         (WebCore::RenderObject::isFlexibleBoxIncludingDeprecated): Added.
3024
3025 2011-08-22  Nat Duca  <nduca@chromium.org>
3026
3027         [chromium] Make compositor context current before querying for extensions
3028         https://bugs.webkit.org/show_bug.cgi?id=66696
3029
3030         Reviewed by James Robinson.
3031
3032         * platform/graphics/chromium/LayerRendererChromium.cpp:
3033         (WebCore::LayerRendererChromium::initialize):
3034
3035 2011-08-22  Cary Clark  <caryclark@google.com>
3036
3037         Webkit Mac10.6 Builder-Tester (Skia)(deps)(dbg) has compile failures
3038         https://bugs.webkit.org/show_bug.cgi?id=66703
3039
3040         This error was detected by the debug build of the Chromium WebKit
3041         Canary.
3042
3043         Reviewed by James Robinson.
3044
3045         No new tests. This change suppresses a compile-time warning
3046         but does not affect the generated code. 
3047
3048         * platform/graphics/mac/FontCustomPlatformData.h:
3049         Replaced struct with class in a forward reference.
3050
3051 2011-08-22  Alexandru Chiculita  <achicu@adobe.com>
3052
3053         [CSSRegions] RenderFlowThread layout should use the attached region sizes
3054         https://bugs.webkit.org/show_bug.cgi?id=66143
3055
3056         When RenderFlowThread is doing the layout it also sets the current RenderFlowThread on
3057         the RenderView. RenderFlowThread cannot be nested inside a single RenderView, so there's no 
3058         need to put that on the LayoutState.
3059
3060         The right offset used to layout the inlines inside a RenderFlowThread
3061         is now adjusted to fit inside the current region.
3062
3063         Reviewed by David Hyatt.
3064
3065         Tests: fast/regions/webkit-flow-floats-inside-regions-bounds.html
3066                fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html
3067                fast/regions/webkit-flow-inlines-inside-regions-bounds.html
3068
3069         * rendering/LayoutState.cpp:
3070         (WebCore::LayoutState::LayoutState):
3071         * rendering/RenderBlock.cpp:
3072         (WebCore::RenderBlock::layoutBlock):
3073         (WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
3074         (WebCore::RenderBlock::logicalRightOffsetForLine):
3075         * rendering/RenderBlock.h:
3076         * rendering/RenderFlowThread.cpp:
3077         (WebCore::RenderFlowThread::RenderFlowThread):
3078         (WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
3079         (WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
3080         (WebCore::RenderFlowThread::layout):
3081         (WebCore::RenderFlowThread::renderRegionForLine):
3082         (WebCore::RenderFlowThread::regionLogicalWidthForLine):
3083         * rendering/RenderFlowThread.h:
3084         (WebCore::RegionFittingDisabler::RegionFittingDisabler):
3085         (WebCore::RegionFittingDisabler::~RegionFittingDisabler):
3086         * rendering/RenderRegion.cpp:
3087         (WebCore::RenderRegion::layout):
3088         * rendering/RenderRegion.h:
3089         * rendering/RenderView.cpp:
3090         (WebCore::RenderView::RenderView):
3091         * rendering/RenderView.h:
3092         (WebCore::RenderView::hasRenderFlowThread):
3093         (WebCore::RenderView::currentRenderFlowThread):
3094         (WebCore::RenderView::setCurrentRenderFlowThread):
3095         (WebCore::RenderView::pushLayoutState):
3096
3097 2011-08-22  Peter Kasting  <pkasting@google.com>
3098
3099         Unreviewed, rolling out r93517.
3100         http://trac.webkit.org/changeset/93517
3101         https://bugs.webkit.org/show_bug.cgi?id=63553
3102
3103         Breaks GTK Linux and Chromium Win
3104
3105         * svg/animation/SVGSMILElement.cpp:
3106         (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
3107
3108 2011-08-22  Wyatt Carss  <wcarss@chromium.org>
3109
3110         FrameSelection::setNonDirectionalSelectionIfNeeded should not have a FrameSelection passed to it
3111         https://bugs.webkit.org/show_bug.cgi?id=66636
3112
3113         Reviewed by Darin Adler.
3114
3115         setNonDirectionalSelection was moved into FrameSelection in r93134 for 
3116         bug 60529, and still took a FrameSelection as an argument, which has been removed.
3117
3118         * editing/FrameSelection.cpp:
3119         (WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
3120
3121 2011-08-22  Tony Chang  <tony@chromium.org>
3122
3123         Add CSS parsing of -webkit-flex-order
3124         https://bugs.webkit.org/show_bug.cgi?id=65384
3125
3126         The property is an int described here:
3127         http://dev.w3.org/csswg/css3-flexbox/#flex-order
3128
3129         Doesn't do anything yet, just hooking it up.
3130
3131         Reviewed by Ojan Vafai.
3132
3133         * css/CSSComputedStyleDeclaration.cpp:
3134         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3135         * css/CSSParser.cpp:
3136         (WebCore::CSSParser::parseValue):
3137         * css/CSSPropertyNames.in:
3138         * css/CSSStyleApplyProperty.cpp:
3139         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
3140         * css/CSSStyleSelector.cpp:
3141         (WebCore::CSSStyleSelector::applyProperty):
3142         * rendering/style/RenderStyle.h:
3143         (WebCore::InheritedFlags::flexOrder):
3144         (WebCore::InheritedFlags::setFlexOrder):
3145         (WebCore::InheritedFlags::initialFlexOrder):
3146         * rendering/style/StyleFlexibleBoxData.cpp:
3147         (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
3148         (WebCore::StyleFlexibleBoxData::operator==):
3149         * rendering/style/StyleFlexibleBoxData.h:
3150
3151 2011-08-22  Adrienne Walker  <enne@google.com>
3152
3153         [chromium] Fix nullptr deref when switching composited tabs
3154         https://bugs.webkit.org/show_bug.cgi?id=66691
3155
3156         Reviewed by James Robinson.
3157
3158         * platform/graphics/chromium/TiledLayerChromium.cpp:
3159         (WebCore::TiledLayerChromium::protectTileTextures):
3160
3161 2011-08-22  James Robinson  <jamesr@chromium.org>
3162
3163         [chromium] Content and render surface textures not freed when compositor context destroyed
3164         https://bugs.webkit.org/show_bug.cgi?id=66589
3165
3166         Reviewed by Kenneth Russell.
3167
3168         Explicitly delete all managed textures when destroying the compositor
3169         context.  This regressed due to a combination of using share groups
3170         (so destroying a context no longer implicitly releases all resources
3171         in that context) and switching the TextureManager over to support
3172         deferred texture destruction.
3173
3174         We sadly don't have a way to construct automated tests for resource
3175         leaks currently.
3176
3177         * platform/graphics/chromium/LayerRendererChromium.cpp:
3178         (WebCore::LayerRendererChromium::cleanupSharedObjects):
3179
3180 2011-08-22  Nate Chapin  <japhet@chromium.org>
3181
3182         Unload events can crash us when they blank out
3183         a parent frame.
3184         https://bugs.webkit.org/show_bug.cgi?id=64741
3185
3186         Reviewed by Adam Barth.
3187
3188         Test: fast/loader/document-destruction-within-unload.html
3189
3190         * loader/FrameLoader.cpp:
3191         (WebCore::FrameLoader::stopLoading): Prevent unload events
3192             from going into infinite recursion.
3193         (WebCore::FrameLoader::setDocumentLoader): Ensure we don't
3194             let set m_documentLoader to a DocumentLoader with a null Frame*.
3195         (WebCore::FrameLoader::detachChildren): Save off a vector of
3196             children to detach, rather than doing it inline.
3197
3198 2011-08-22  Young Han Lee  <joybro@company100.net>
3199
3200         Reviewed by Dirk Schulze.
3201
3202         SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end
3203         https://bugs.webkit.org/show_bug.cgi?id=63553
3204
3205         calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever
3206         elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be in the middle
3207         of the animation duration. (e.g. begin="0s" end="2s" dur="3s")
3208
3209         This change makes the function return the animations's true progress instead of 100%
3210         when the animation ends.
3211
3212         Test: svg/animations/animate-end-attribute.html
3213
3214         * svg/animation/SVGSMILElement.cpp:
3215         (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
3216
3217 2011-08-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3218
3219         Fix build error when inspector is disabled.
3220         https://bugs.webkit.org/show_bug.cgi?id=66644
3221
3222         Reviewed by Darin Adler.
3223
3224         * inspector/InspectorDatabaseResource.h: Add ENABLE(INSPECTOR) macro.
3225
3226 2011-08-22  Abhishek Arya  <inferno@chromium.org>
3227
3228         Crash in FocusController::advanceFocusInDocumentOrder
3229         https://bugs.webkit.org/show_bug.cgi?id=66678
3230
3231         RefPtr the focusable node to prevent getting deleted by mutation
3232         event.
3233
3234         Reviewed by Dave Hyatt.
3235
3236         Test: fast/frames/focus-controller-crash-change-event.html
3237
3238         * page/FocusController.cpp:
3239         (WebCore::FocusController::advanceFocusInDocumentOrder):
3240
3241 2011-08-22  Justin Novosad  <junov@chromium.org>
3242
3243         [Chromium] Crash when allocation of very large canvas fails
3244         https://bugs.webkit.org/show_bug.cgi?id=66563
3245         Replacing the crash with a more graceful failure: canvas
3246         will not render.
3247
3248         Reviewed by Stephen White.
3249
3250         * platform/graphics/skia/ImageBufferSkia.cpp:
3251         (WebCore::ImageBuffer::ImageBuffer):
3252         Invoking TryCreateBitmapCanvas instead of CreateBitmapCanvas
3253         This is the non-crashing version of the factory function.
3254         It returns NULL if allocation fails.  Code for handling
3255         NULL pointer was already in place.
3256
3257 2011-08-22  Ilya Tikhonovsky  <loislo@chromium.org>
3258
3259         Web Inspector: bind registerDomainDispatcher to domain names.
3260         https://bugs.webkit.org/show_bug.cgi?id=66670
3261
3262         jscompiler can't be used for validating domain events dispatchers because registerDomainDispatcher is too generic.
3263         I'd like to introduce named versions per each domain.
3264
3265         Reviewed by Pavel Feldman.
3266
3267         * inspector/CodeGeneratorInspector.pm:
3268         (GenerateInterface):
3269         (generateBackendStubJS):
3270         * inspector/front-end/ApplicationCacheItemsView.js:
3271         * inspector/front-end/ConsoleView.js:
3272         * inspector/front-end/DOMAgent.js:
3273         (WebInspector.DOMAgent):
3274         * inspector/front-end/DOMStorage.js:
3275         * inspector/front-end/Database.js:
3276         * inspector/front-end/DebuggerModel.js:
3277         (WebInspector.DebuggerModel):
3278         * inspector/front-end/NetworkManager.js:
3279         (WebInspector.NetworkDispatcher):
3280         * inspector/front-end/ProfilesPanel.js:
3281         * inspector/front-end/ResourceTreeModel.js:
3282         (WebInspector.ResourceTreeModel):
3283         * inspector/front-end/TimelineManager.js:
3284         (WebInspector.TimelineDispatcher):
3285         * inspector/front-end/WorkerManager.js:
3286         (WebInspector.WorkerManager):
3287         * inspector/front-end/inspector.js:
3288
3289 2011-08-22  Benjamin Poulain  <benjamin@webkit.org>
3290
3291         Fix generate-inspector-idl for Python3 after r93396
3292         https://bugs.webkit.org/show_bug.cgi?id=66663
3293
3294         Reviewed by Andreas Kling.
3295
3296         In Python3, print is a function instead of a language keyword. Using parentheses
3297         around the argument ensures the code works for both Python 2 and 3.
3298
3299         * inspector/generate-inspector-idl:
3300
3301 2011-08-22  Keishi Hattori  <keishi@webkit.org>
3302
3303         Chrome::setSelectedColorInColorChooser shouldn't be called when color chooser sets a new color
3304         https://bugs.webkit.org/show_bug.cgi?id=66658
3305
3306         Reviewed by Kent Tamura.
3307
3308         * html/ColorInputType.cpp:
3309         (WebCore::ColorInputType::colorSelected): Call setValueFromRenderer instead of setValue.
3310         * html/ColorInputType.h:
3311
3312 2011-08-18  Pavel Podivilov  <podivilov@chromium.org>
3313
3314         Web Inspector: extract breakpoint management code to a separate class and add tests.
3315         https://bugs.webkit.org/show_bug.cgi?id=66224
3316
3317         Reviewed by Pavel Feldman.
3318
3319         Test: inspector/debugger/breakpoint-manager.html
3320
3321         * WebCore.gypi:
3322         * WebCore.vcproj/WebCore.vcproj:
3323         * inspector/front-end/BreakpointManager.js: Added.
3324         (WebInspector.BreakpointManager):
3325         (WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
3326         (WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
3327         (WebInspector.BreakpointManager.prototype.setBreakpoint):
3328         (WebInspector.BreakpointManager.prototype.removeBreakpoint):
3329         (WebInspector.BreakpointManager.prototype._materializeBreakpoint):
3330         (WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
3331         (WebInspector.BreakpointManager.prototype._addBreakpointToUI):
3332         (WebInspector.BreakpointManager.prototype._deleteBreakpointFromUI):
3333         (WebInspector.BreakpointManager.prototype._moveBreakpointInUI):
3334         (WebInspector.BreakpointManager.prototype._breakpoints):
3335         (WebInspector.BreakpointManager.prototype._breakpoint):
3336         (WebInspector.BreakpointManager.prototype._forEachBreakpoint):
3337         (WebInspector.BreakpointManager.prototype._setBreakpointInDebugger):
3338         (WebInspector.BreakpointManager.prototype._removeBreakpointFromDebugger):
3339         (WebInspector.BreakpointManager.prototype._breakpointResolved):
3340         (WebInspector.BreakpointManager.prototype.serializeBreakpoints):
3341         (WebInspector.BreakpointManager.prototype.reset):
3342         (WebInspector.BreakpointManager.prototype.debuggerReset):
3343         (WebInspector.Breakpoint):
3344         (WebInspector.Breakpoint.prototype.serialize):
3345         (WebInspector.Breakpoint.deserialize):
3346         * inspector/front-end/DebuggerModel.js:
3347         (WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):
3348         * inspector/front-end/SourceFile.js:
3349         (WebInspector.RawSourceCode.prototype.get rawSourceCode):
3350         * inspector/front-end/WebKit.qrc:
3351         * inspector/front-end/inspector.html:
3352
3353 2011-08-21  Martin Robinson  <mrobinson@igalia.com>
3354
3355         Fix 'make dist' for WebKitGTK+.
3356
3357         * GNUmakefile.am: Add a missing file to the EXTRA_DIST list.
3358         * GNUmakefile.list.am: Update the sources list to reflect reality.
3359
3360 2011-08-20  Nebojsa Ciric  <cira@chromium.org>
3361
3362         Point build system and #include headers to v8-i18n library instead of v8 library.
3363         We forked a new code.google.com/p/v8-i18n project from v8/extensions/experimental.
3364         https://bugs.webkit.org/show_bug.cgi?id=66573
3365
3366         Reviewed by Kent Tamura.
3367
3368         Covered by existing tests, and no code was changed.
3369
3370         * WebCore.gyp/WebCore.gyp:
3371         * bindings/v8/V8DOMWindowShell.cpp:
3372         (WebCore::V8DOMWindowShell::createNewContext):
3373
3374 2011-08-20  Tom Zakrajsek  <tomz@codeaurora.org>
3375
3376         instanceof HTMLSourceElement Fails
3377         https://bugs.webkit.org/show_bug.cgi?id=65013
3378
3379         Reviewed by Eric Carlson.
3380
3381         Add HTMLSourceElement to DOMWindow.idl for consistency.  Constructors for
3382         all elements should be available on DOMWindow.
3383
3384         * bindings/generic/RuntimeEnabledFeatures.cpp:
3385         (WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):
3386         * bindings/generic/RuntimeEnabledFeatures.h:
3387         * page/DOMWindow.idl:
3388
3389 2011-08-20  Darin Adler  <darin@apple.com>
3390
3391         If Range::insertNode is passed an empty document fragment, it creates a broken DOM tree
3392         https://bugs.webkit.org/show_bug.cgi?id=65015
3393
3394         Reviewed by Alexey Proskuryakov.
3395
3396         Test: fast/dom/Range/insertNode-empty-fragment-crash.html
3397
3398         * dom/Range.cpp: (WebCore::Range::insertNode): Don't adjust the range after insertion
3399         if we didn't add anything. Otherwise the code will put a wrong "child before" value into
3400         the range end boundary point.
3401
3402 2011-08-20  Ken Buchanan  <kenrb@chromium.org>
3403
3404         OOB Read in WebCore::SVGAnimationElement
3405         https://bugs.webkit.org/show_bug.cgi?id=65858
3406
3407         Reviewed by Nikolas Zimmermann.
3408
3409         Potential crash resulting from incorrect keySpline array lengths. This fix validates the length in startedActiveInterval.
3410
3411         Test: svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml
3412
3413         * svg/SVGAnimationElement.cpp:
3414         (WebCore::SVGAnimationElement::parseMappedAttribute):
3415         (WebCore::SVGAnimationElement::calculateKeyTimesIndex):
3416
3417 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3418
3419         Unreviewed, rolling out r93415.
3420         http://trac.webkit.org/changeset/93415
3421         https://bugs.webkit.org/show_bug.cgi?id=66623
3422
3423         Introduces failing test (Requested by pfeldman on #webkit).
3424
3425         * WebCore.gypi:
3426         * WebCore.vcproj/WebCore.vcproj:
3427         * inspector/front-end/BreakpointManager.js: Removed.
3428         * inspector/front-end/DebuggerModel.js:
3429         * inspector/front-end/SourceFile.js:
3430         * inspector/front-end/WebKit.qrc:
3431         * inspector/front-end/inspector.html:
3432
3433 2011-08-19  Chris Fleizach  <cfleizach@apple.com>
3434
3435         AX WK2 Regression: WebKit outputs incorrect AX position in frames/iframes
3436         https://bugs.webkit.org/show_bug.cgi?id=61289
3437
3438         Update the code to determine the position of accessibility elements on Mac for WK2,
3439         so that elements within iframes are positioned correctly.
3440
3441         Reviewed by Darin Adler..
3442
3443         * accessibility/AccessibilityObject.cpp:
3444         (WebCore::AccessibilityObject::page):
3445         * accessibility/AccessibilityObject.h:
3446         * accessibility/mac/AccessibilityObjectWrapper.mm:
3447         (-[AccessibilityObjectWrapper position]):
3448
3449 2011-08-19  Jeffrey Pfau  <jpfau@apple.com>
3450
3451         New XML parser: text nodes outside of root element not created for document fragments
3452         https://bugs.webkit.org/show_bug.cgi?id=66604
3453
3454         When intializing a fragment parser, declare that the first element has been seen. Also, flush the text nodes when finishing parsing a document.
3455
3456         Reviewed by Darin Adler.
3457
3458         * xml/parser/NewXMLDocumentParser.cpp:
3459         (WebCore::NewXMLDocumentParser::finish):
3460         * xml/parser/XMLTreeBuilder.cpp:
3461         (WebCore::XMLTreeBuilder::XMLTreeBuilder):
3462         (WebCore::XMLTreeBuilder::processToken):
3463         (WebCore::XMLTreeBuilder::finish):
3464         * xml/parser/XMLTreeBuilder.h:
3465
3466 2011-08-19  Jeff Miller  <jeffm@apple.com>
3467
3468         MediaPlayerPrivateAVFoundationCF should use AVCFURLAssetCopyAudiovisualMIMETypes() to get list of supported MIME types
3469         https://bugs.webkit.org/show_bug.cgi?id=66612
3470
3471         Reviewed by Darin Adler.
3472
3473         No new tests, should be covered by existing media tests.
3474
3475         * platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added AVCFURLAssetCopyAudiovisualMIMETypes().
3476         * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
3477         (WebCore::mimeTypeCache): Use AVCFURLAssetCopyAudiovisualMIMETypes() to build the cache of supported MIME types.
3478
3479 2011-08-19  Adrienne Walker  <enne@google.com>
3480
3481         [chromium] Regression: Fix clang errors from r93424
3482         https://bugs.webkit.org/show_bug.cgi?id=66609
3483
3484         Reviewed by James Robinson.
3485
3486         The invalidateRect function does not appear to be used anywhere
3487         because the setNeedsDisplay function is used instead. Fix the Clang
3488         error by just removing this unused vestigial base class function.
3489
3490         * platform/graphics/chromium/LayerChromium.h:
3491
3492 2011-08-19  Anders Carlsson  <andersca@apple.com>
3493
3494         Add new enums to npapi.h
3495         https://bugs.webkit.org/show_bug.cgi?id=66608
3496
3497         Reviewed by Sam Weinig.
3498
3499         * bridge/npapi.h:
3500
3501 2011-08-19  Jeffrey Pfau  <jpfau@apple.com>
3502
3503         libxml2 fragment parser loses prefix namespaces
3504         https://bugs.webkit.org/show_bug.cgi?id=66423
3505
3506         This makes the loop over the elements outside of the context actually update the element it's processing.
3507
3508         Reviewed by Darin Adler.
3509
3510         Test: fast/parser/innerhtml-with-prefixed-elements.xhtml
3511
3512         * xml/parser/XMLDocumentParserLibxml2.cpp:
3513         (WebCore::XMLDocumentParser::XMLDocumentParser):
3514
3515 2011-08-19  Beth Dakin  <bdakin@apple.com>
3516
3517         https://bugs.webkit.org/show_bug.cgi?id=66590
3518         Re-name scrollbar painter types
3519
3520         Reviewed by Sam Weinig.
3521
3522         Names changed to remove references to WebKitSystemInterface since the 
3523         implementation is now in WebCore. And the type names changed to be more Objective-
3524         Cish instead of C++ish
3525         WTF_USE_WK_SCROLLBAR_PAINTER -> WTF_USE_SCROLLBAR_PAINTER
3526         WKScrollbarPainterRef -> ScrollbarPainter
3527         WKScrollbarPainterControllerRef -> ScrollbarPainterController
3528
3529         * platform/mac/NSScrollerImpDetails.h:
3530         * platform/mac/ScrollAnimatorMac.h:
3531         * platform/mac/ScrollAnimatorMac.mm:
3532         (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
3533         (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
3534         (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
3535         (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
3536         (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
3537         (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
3538         (WebCore::ScrollAnimatorMac::notifyPositionChanged):
3539         (WebCore::ScrollAnimatorMac::contentAreaWillPaint):
3540         (WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
3541         (WebCore::ScrollAnimatorMac::mouseExitedContentArea):
3542         (WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
3543         (WebCore::ScrollAnimatorMac::willStartLiveResize):
3544         (WebCore::ScrollAnimatorMac::contentsResized):
3545         (WebCore::ScrollAnimatorMac::willEndLiveResize):