Reverted unintended changes in r86024
[WebKit.git] / Source / WebCore / ChangeLog
1 2011-05-07  Dan Bernstein  <mitz@apple.com>
2
3         Reviewed by Maciej Stachowiak.
4
5         <rdar://problem/9403055> REGRESSION (r85499): Inline images in iChat overflow their chat bubbles
6         https://bugs.webkit.org/show_bug.cgi?id=60443
7
8         Test: fast/replaced/table-percent-height-positioned.html
9
10         * rendering/RenderBox.cpp:
11         (WebCore::RenderBox::computeReplacedLogicalHeightUsing): Do not apply the logic to prevent precent-height
12         replaced elements from being squeezed by table cells when the replaced element is positioned (and thus
13         doesn’t affect the table cell’s height).
14
15 2011-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>
16
17         Unreviewed, rolling out r86016.
18         http://trac.webkit.org/changeset/86016
19         https://bugs.webkit.org/show_bug.cgi?id=60445
20
21         caused crashes on the WK2 Windows bots (Requested by
22         jessieberlin on #webkit).
23
24         * platform/network/ResourceHandle.h:
25         * platform/network/cf/CookieStorageCFNet.cpp:
26         (WebCore::currentCookieStorage):
27         (WebCore::defaultCookieStorage):
28         * platform/network/cf/ResourceHandleCFNet.cpp:
29         (WebCore::willSendRequest):
30         (WebCore::makeFinalRequest):
31         (WebCore::ResourceHandle::willSendRequest):
32         * platform/network/cf/ResourceRequestCFNet.cpp:
33         (WebCore::ResourceRequest::doUpdatePlatformRequest):
34
35 2011-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>
36
37         Unreviewed, rolling out r85974.
38         http://trac.webkit.org/changeset/85974
39         https://bugs.webkit.org/show_bug.cgi?id=60444
40
41         broke browser tests (Requested by inferno-sec on #webkit).
42
43         * platform/network/chromium/ResourceResponse.cpp:
44         (WebCore::ResourceResponse::doPlatformCopyData):
45         (WebCore::ResourceResponse::doPlatformAdopt):
46         * platform/network/chromium/ResourceResponse.h:
47         (WebCore::ResourceResponse::downloadFilePath):
48         (WebCore::ResourceResponse::setDownloadFilePath):
49
50 2011-05-07  Jessie Berlin  <jberlin@apple.com>
51
52         Reviewed by Steve Falkenburg.
53
54         [Windows WebKit2] Use cookies set in WebKit1
55         https://bugs.webkit.org/show_bug.cgi?id=60274
56
57         Share the default storage session between the UI and Web Processes.
58
59         * platform/network/cf/CookieStorageCFNet.cpp:
60         (WebCore::defaultSessionCookieStorage):
61         Keep track of the default storage session cookie storage.
62         (WebCore::currentCookieStorage):
63         Call defaultCookieStorage to get the default cookie storage.
64         (WebCore::defaultCookieStorage):
65         If there is a default storage session cookie storage, prefer that over getting the default
66         cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
67         without specifying a storage session will not get the cookie storage being shared by the UI
68         and Web Processes.
69
70         * platform/network/ResourceHandle.h:
71         * platform/network/cf/ResourceHandleCFNet.cpp:
72         (WebCore::willSendRequest):
73         Make sure to set the current storage session on any requests used by the Web
74         Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
75         doing anything with the Web Process's default storage session (which is not the one shared
76         with the UI Process).
77         (WebCore::makeFinalRequest):
78         Ditto.
79         (WebCore::ResourceHandle::willSendRequest):
80         Ditto.
81         (WebCore::ResourceHandle::currentStorageSession):
82         If there is a Private Browsing storage session, return that.
83         If not, on Windows return the default storage session that is being shared with the UI
84         Process and on Mac return 0.
85         (WebCore::defaultCFURLStorageSession):
86         (WebCore::ResourceHandle::setDefaultStorageSession):
87         (WebCore::ResourceHandle::defaultStorageSession):
88
89         * platform/network/cf/ResourceRequestCFNet.cpp:
90         (WebCore::ResourceRequest::doUpdatePlatformRequest):
91         Make sure to set the current storage session on any requests used by the Web
92         Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
93         doing anything with the Web Process's default storage session (which is not the one shared
94         with the UI Process).
95
96 2011-05-07  Joe Mason  <jmason@rim.com>
97
98         Reviewed by Daniel Bates.
99
100         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
101         https://bugs.webkit.org/show_bug.cgi?id=52211
102
103         Create a UserGestureIndicator when calling the clientRedirected callback.
104
105         * loader/NavigationScheduler.cpp:
106         (WebCore::ScheduledURLNavigation::didStartTimer):
107         (WebCore::ScheduledURLNavigation::didStopTimer):
108         (WebCore::ScheduledFormSubmission::didStartTimer):
109         (WebCore::ScheduledFormSubmission::didStopTimer):
110
111 2011-05-06  Jon Lee  <jonlee@apple.com>
112
113         Reviewed by Alice Liu.
114
115         Crash when sending a wheel event to a node with no shadow ancestor node
116         https://bugs.webkit.org/show_bug.cgi?id=60429
117         <rdar://problem/9389619>
118
119         * page/EventHandler.cpp:
120         (WebCore::EventHandler::handleWheelEvent):add check to see if the shadow ancestor node of the node that was under the mouse exists before trying to dispatch the wheel event to it.
121
122 2011-05-06  Kent Tamura  <tkent@chromium.org>
123
124         Reviewed by Ryosuke Niwa.
125
126         Eliminate WebCore/dom/InputElement.{cpp,h}
127         https://bugs.webkit.org/show_bug.cgi?id=60262
128
129         - Fold in all of the code of InputElement.{cpp,h} into HTMLInputElement
130           and TextFieldInputType.
131         - Change the return type of Node::toInputElement():
132           InputElement* -> HTMLInputElement*
133
134         No new tests. This change should not change the existing behaviour.
135
136         * CMakeLists.txt: Remove InpuntElement.cpp and/or InputElement.h.
137         * GNUmakefile.list.am: ditto.
138         * WebCore.exp.in: Add symbols of functions exposed to WebKit.
139         * WebCore.gypi: Remove InpuntElement.cpp and/or InputElement.h.
140         * WebCore.pro: ditto.
141         * WebCore.vcproj/WebCore.vcproj: ditto.
142         * WebCore.xcodeproj/project.pbxproj: ditto.
143         * accessibility/AXObjectCache.cpp:
144         (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
145           Follow the return type change of Node::toInputElement().
146         * accessibility/AccessibilityRenderObject.cpp:
147         (WebCore::AccessibilityRenderObject::isPasswordField): ditto.
148         (WebCore::AccessibilityRenderObject::isIndeterminate): ditto.
149         (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio): ditto.
150         (WebCore::AccessibilityRenderObject::isChecked): ditto.
151         * css/CSSStyleSelector.cpp:
152         (WebCore::CSSStyleSelector::canShareStyleWithElement): ditto.
153         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto.
154         * dom/CheckedRadioButtons.cpp:
155         (WebCore::CheckedRadioButtons::removeButton): ditto.
156         * dom/DOMAllInOne.cpp: Remove InputElement.h.
157         * dom/InputElement.cpp: Removed.
158         * dom/InputElement.h: Removed.
159         * dom/Node.cpp:
160         (WebCore::Node::toInputElement):
161           Change the return type from InputElement* to HTMLInputElement*.
162         * dom/Node.h: ditto.
163         * html/HTMLInputElement.cpp:
164         (WebCore::HTMLInputElement::HTMLInputElement):
165         (WebCore::HTMLInputElement::formControlName):
166         (WebCore::HTMLInputElement::tooLong):
167         (WebCore::HTMLInputElement::updateFocusAppearance):
168         (WebCore::HTMLInputElement::aboutToUnload):
169         (WebCore::HTMLInputElement::handleFocusEvent):
170         (WebCore::HTMLInputElement::handleBlurEvent):
171         (WebCore::HTMLInputElement::updateType):
172         (WebCore::HTMLInputElement::parseMappedAttribute):
173         (WebCore::HTMLInputElement::size):
174         (WebCore::HTMLInputElement::copyNonAttributeProperties):
175         (WebCore::HTMLInputElement::value):
176         (WebCore::HTMLInputElement::suggestedValue):
177         (WebCore::HTMLInputElement::setSuggestedValue):
178         (WebCore::HTMLInputElement::setValue):
179         (WebCore::HTMLInputElement::setValueFromRenderer):
180         (WebCore::HTMLInputElement::setFileListFromRenderer):
181         (WebCore::HTMLInputElement::setDefaultName):
182         (WebCore::HTMLInputElement::maxLength):
183         (WebCore::HTMLInputElement::cacheSelection):
184         (WebCore::formatCodes): Moved from InputElement.
185         (WebCore::cursorPositionToMaskIndex): ditto.
186         (WebCore::HTMLInputElement::isConformToInputMask): ditto.
187         (WebCore::HTMLInputElement::validateInputMask): ditto.
188         (WebCore::HTMLInputElement::setWapInputFormat): ditto.
189         (WebCore::HTMLInputElement::notifyFormStateChanged): ditto.
190         (WebCore::HTMLInputElement::parseMaxLengthAttribute): ditto.
191         (WebCore::HTMLInputElement::updateValueIfNeeded):ditto.
192         * html/HTMLInputElement.h:
193           - Add data members which were defined in InputElementData.
194           - Make some functions public because the public interface InputElement is removed.
195           - Make some functions non-virtual because they don't override
196             corresponding virtual functions of InputElement anymore.
197         (WebCore::HTMLInputElement::toInputElement):
198           Follow the return type change of Node::toInputElement().
199         (WebCore::HTMLInputElement::isIndeterminate):
200         (WebCore::HTMLInputElement::isAutofilled):
201         (WebCore::HTMLInputElement::supportsMaxLength):
202         (WebCore::HTMLInputElement::cachedSelectionStart):
203         (WebCore::HTMLInputElement::cachedSelectionEnd):
204         * html/HTMLTextAreaElement.cpp: Remove unused InputElement.h.
205         * html/InputType.cpp:
206         (WebCore::InputType::handleBeforeTextInsertedEvent): Remove the code.
207         * html/InputType.h: Update for the above.
208         * html/TextFieldInputType.cpp:
209         (WebCore::replaceEOLAndLimitLength): Moved from InputElement.cpp.
210         (WebCore::TextFieldInputType::sanitizeValue): Implement with replaceEOLAndLimitLength().
211         (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
212           Move the code from InputElement::handleBeforeTextInsertedEvent().
213         * html/TextFieldInputType.h: Update declarations.
214         * rendering/RenderTextControlSingleLine.cpp:
215           - Remove ASSERT(node()->isHTMLElement()) because it is checked in the constructor.
216           - Follow the return type change of inputElement().
217         (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
218           Make sure node() is an HTMLInputElement instance.
219         (WebCore::RenderTextControlSingleLine::addSearchResult):
220         (WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
221         (WebCore::RenderTextControlSingleLine::showPopup):
222         (WebCore::RenderTextControlSingleLine::hidePopup):
223         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
224         (WebCore::RenderTextControlSingleLine::updateFromElement):
225         (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
226         (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
227         (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
228         (WebCore::RenderTextControlSingleLine::createInnerSpinButtonStyle):
229         (WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
230         (WebCore::RenderTextControlSingleLine::createSpeechButtonStyle):
231         (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
232         (WebCore::RenderTextControlSingleLine::startSearchEventTimer):
233         (WebCore::RenderTextControlSingleLine::searchEventTimerFired):
234         (WebCore::RenderTextControlSingleLine::valueChanged):
235         (WebCore::RenderTextControlSingleLine::setTextFromItem):
236         (WebCore::RenderTextControlSingleLine::inputElement):
237         * rendering/RenderTextControlSingleLine.h:
238           Change the return type of inputElement(): InputElement* -> HTMLInputElement*.
239         * rendering/RenderTheme.cpp:
240         (WebCore::RenderTheme::isChecked):
241           Follow the return type change of Node::toInputElement().
242         (WebCore::RenderTheme::isIndeterminate): ditto.
243         (WebCore::RenderTheme::shouldHaveSpinButton):
244           Change the parameter type: InputElement* -> HTMLInputElement*.
245         * rendering/RenderTheme.h: ditto.
246
247 2011-05-06  Adam Barth  <abarth@webkit.org>
248
249         Reviewed by Eric Seidel.
250
251         Implement "Report-Only" mode for CSP
252         https://bugs.webkit.org/show_bug.cgi?id=60402
253
254         This mode lets web sites try out CSP by getting violation reports (and
255         console spam) without actually changing the behavior of their web sites.
256
257         Test: http/tests/security/contentSecurityPolicy/report-only.html
258
259         * dom/Document.cpp:
260         (WebCore::Document::processHttpEquiv):
261         * loader/FrameLoader.cpp:
262         (WebCore::FrameLoader::didBeginDocument):
263         * page/ContentSecurityPolicy.cpp:
264         (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
265         (WebCore::ContentSecurityPolicy::didReceiveHeader):
266         (WebCore::ContentSecurityPolicy::reportViolation):
267         (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation):
268         (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation):
269         (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
270         (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
271         * page/ContentSecurityPolicy.h:
272
273 2011-05-06  Beth Dakin  <bdakin@apple.com>
274
275         Reviewed by Darin Adler.
276
277         https://bugs.webkit.org/show_bug.cgi?id=60421
278         Custom scrollbars nested inside an overlay scrollbar overflow region end up 
279         painting twice
280         -and corresponding-
281         <rdar://problem/9389072>
282
283         Be sure not to paint custom css scrollbars during the special overlay-scrollbar 
284         painting pass.
285         * rendering/RenderLayer.cpp:
286         (WebCore::RenderLayer::paintOverflowControls):
287
288 2011-05-06  Cary Clark  <caryclark@google.com>
289
290         Reviewed by Eric Seidel.
291
292         Add utility for converting SkCanvas to CGContext
293         https://bugs.webkit.org/show_bug.cgi?id=59808
294
295         Skia on Mac uses Skia to render WebKit, and CG 
296         to render UI elements. The CG elements need a 
297         transcribed graphics context that preserves the 
298         canvas matrix, and the canvas clip. 
299
300         The BitLockerSkia utility class sets up a CGContext 
301         from the SkCanvas, locks the bitmap's bits, and 
302         releases the lock when the class goes out of scope. 
303
304         Each time the CGContext is retrieved, it is rebuilt. 
305         This permits the caller to modify the same canvas 
306         between calls. 
307
308         This change adds utilities but does not modify any 
309         existing code. For now, there are no callers to these 
310         utilities, so there is no functional change.
311
312         No new tests.
313
314         * platform/graphics/skia/BitLockerSkia.cpp: Added.
315         (WebCore::SkMatrixToCGAffineTransform): Conversion utility.
316         (WebCore::BitLockerSkia::BitLockerSkia): Takes SkCanvas.
317         (WebCore::BitLockerSkia::~BitLockerSkia): Unlocks, cleans up.
318         (WebCore::BitLockerSkia::release): Internal private helper.
319         (WebCore::BitLockerSkia::cgContext): Returns CGContextRef.
320         * platform/graphics/skia/BitLockerSkia.h: Added.
321
322 2011-05-06  Martin Robinson  <mrobinson@igalia.com>
323
324         Reviewed by Xan Lopez.
325
326         [GTK] [WebKit2] WebView::windowToScreen needs an implementation
327         https://bugs.webkit.org/show_bug.cgi?id=55960
328
329         Abstract coordinate system translation code from WebKit into WebCore.
330         This will allow the code to be shared between WebKit and WebKit2. The code
331         now lives in a new GtkUtilities.cpp helper file.
332
333         * GNUmakefile.list.am: Added GtkUtilities to the source list.
334         * platform/gtk/GtkUtilities.cpp: Added.
335         (WebCore::convertWidgetRectToScreenRect):
336         * platform/gtk/GtkUtilities.h: Added.
337
338 2011-05-06  Martin Robinson  <mrobinson@igalia.com>
339
340         Reviewed by Xan Lopez.
341
342         Remove some unnecessary static methods in ResourceHandleSoup.
343
344         No new tests. This is only a small cleanup.
345
346         * platform/network/soup/ResourceHandleSoup.cpp:
347         (WebCore::restartedCallback): Call ResourceResponse::updateFromSoupMessage directly.
348         (WebCore::gotHeadersCallback):Ditto.
349         (WebCore::contentSniffedCallback):Ditto.
350         (WebCore::sendRequestCallback):Ditto.
351         (WebCore::ResourceHandle::defaultSession): Create the soup session directly.
352
353 2011-05-06  Martin Robinson  <mrobinson@igalia.com>
354
355         Reviewed by Xan Lopez.
356
357         [Soup] ResourceHandles are leaked on 304 responses
358         https://bugs.webkit.org/show_bug.cgi?id=60413
359
360         Always call cleanupSoupRequestOperation, even when the request was not
361         canceled. Before the code would call didFinishLoading and then never clean up
362         the request.
363
364         No new tests. This simply fixes a memory leak.
365
366         * platform/network/soup/ResourceHandleSoup.cpp:
367         (WebCore::sendRequestCallback):
368
369 2011-05-06  Adam Barth  <abarth@webkit.org>
370
371         Reviewed by Eric Seidel.
372
373         Add disable-javascript-urls CSP directive
374         https://bugs.webkit.org/show_bug.cgi?id=60301
375
376         This CSP directive is not in the CSP spec.  This patch is somewhat of
377         an experiment to see whether this feature is useful.  Based on our
378         implementation experience, we will coordinate with folks via the W3C to
379         see if this makes sense to add to the spec.
380
381         Test: http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html
382
383         * page/ContentSecurityPolicy.cpp:
384         (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
385         (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
386         (WebCore::ContentSecurityPolicy::addDirective):
387         * page/ContentSecurityPolicy.h:
388
389 2011-05-06  Brett Wilson  <brettw@chromium.org>
390
391         Reviewed by Adam Barth.
392
393         Use a File object to store the downloaded file reference rather than
394         just the path. This keeps the file and permissions in scope (using the
395         already-existing blob system) so the browser won't delete the file
396         when the load is complete. Instead, the file will be cleaned up when
397         the request objects are deleted.
398         https://bugs.webkit.org/show_bug.cgi?id=60281
399
400         * platform/network/chromium/ResourceResponse.cpp:
401         (WebCore::ResourceResponse::doPlatformCopyData):
402         (WebCore::ResourceResponse::doPlatformAdopt):
403         * platform/network/chromium/ResourceResponse.h:
404         (WebCore::ResourceResponse::downloadedFile):
405         (WebCore::ResourceResponse::setDownloadedFile):
406
407 2011-05-06  Alexis Menard  <alexis.menard@openbossa.org>
408
409         Reviewed by Darin Adler.
410
411         Fix two warnings of unused variables.
412         https://bugs.webkit.org/show_bug.cgi?id=60370
413
414         Remove two unused local variable from the code.
415
416         No new tests, the existing ones should cover.
417
418         * rendering/RenderFlexibleBox.cpp:
419         (WebCore::RenderFlexibleBox::layoutVerticalBox):
420         * svg/animation/SVGSMILElement.cpp:
421         (WebCore::SVGSMILElement::calculateNextProgressTime):
422
423 2011-05-06  Adam Barth  <abarth@webkit.org>
424
425         Reviewed by Eric Seidel.
426
427         Wire up CSP's eval blocking to V8's new API
428         https://bugs.webkit.org/show_bug.cgi?id=60384
429
430         * bindings/v8/ScriptController.cpp:
431         (WebCore::ScriptController::disableEval):
432
433 2011-05-06  David Hyatt  <hyatt@apple.com>
434
435         Reviewed by Dan Bernstein.
436
437         https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
438         REGRESSION (r81684?): cox.com sign in button is missing
439         
440         Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
441         This restores the original behavior before the refactoring messed it up.
442
443         Added fast/inline/nested-top-alignment.html
444
445         * rendering/InlineFlowBox.cpp:
446         (WebCore::InlineFlowBox::computeLogicalBoxHeights):
447
448 2011-05-06  David Hyatt  <hyatt@apple.com>
449
450         Reviewed by Dan Bernstein.
451
452         https://bugs.webkit.org/show_bug.cgi?id=60390 (<rdar://problem/9364449>)
453         REGRESSION (r81992): portions of ticketmaster site render blank
454
455         Make simplified layout skip from a positioned object out to its containing block.  There is no
456         need to dirty the intermediate inlines, and in this case it's actively harmful, since the
457         block responsible for the layout of the positioned object doesn't get m_posChildNeedsLayout set.
458
459         Added fast/block/positioning/hiding-inside-relpositioned-inline.html
460
461         * rendering/RenderObject.h:
462         (WebCore::RenderObject::markContainingBlocksForLayout):
463
464 2011-05-06  Pavel Feldman  <pfeldman@chromium.org>
465
466         Not reviewed: move selection test into the text area branch.
467
468         * inspector/front-end/TextViewer.js:
469         (WebInspector.TextViewer.prototype._contextMenu):
470
471 2011-05-04  Adrienne Walker  <enne@google.com>
472
473         Reviewed by James Robinson.
474
475         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
476         https://bugs.webkit.org/show_bug.cgi?id=59020
477
478         Allow for empty scissor rects, which implies scissoring to the render
479         surface. The previous code and previous patch on this bug both didn't
480         take into account that the scissor rect should be the render surface
481         and not the projection of the layer itself, because child layers
482         aren't necessarily contained within the bounds of their superlayer.
483
484         Test: compositing/flat-with-transformed-child.html
485
486         * platform/graphics/chromium/LayerRendererChromium.cpp:
487         (WebCore::LayerRendererChromium::paintLayerContents):
488         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
489         (WebCore::LayerRendererChromium::drawLayer):
490         (WebCore::LayerRendererChromium::setScissorToRect):
491
492 2011-05-06  Simon Fraser  <simon.fraser@apple.com>
493
494         Reviewed by Sam Weinig.
495
496         Lazily allocate ScrollAnimator in ScrollableArea
497         https://bugs.webkit.org/show_bug.cgi?id=60327
498
499         Avoid allocating the ScrollAnimator up-front, because we
500         create lots of ScrollableAreas via RenderLayer, and we should
501         only need the animator when scrolling.
502
503         * platform/ScrollableArea.cpp:
504         (WebCore::ScrollableArea::ScrollableArea):
505         (WebCore::ScrollableArea::scrollAnimator):
506         (WebCore::ScrollableArea::scroll):
507         (WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
508         (WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
509         (WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
510         (WebCore::ScrollableArea::handleWheelEvent):
511         (WebCore::ScrollableArea::handleGestureEvent):
512         * platform/ScrollableArea.h:
513
514 2011-05-06  Eric Carlson  <eric.carlson@apple.com>
515
516         Reviewed by Darin Adler.
517
518         REGRESSION (r77954): HTTP Live Streams have incorrect controller UI
519         https://bugs.webkit.org/show_bug.cgi?id=60304
520         <rdar://problem/9392609>
521
522         Don't assume that the only time the media controls UI may need to change is on a 
523         network state change, readyState changes can be significant as well.
524
525         Tested manually because we don't have any live streams to test in DRT.
526
527         * html/HTMLMediaElement.cpp:
528         (WebCore::HTMLMediaElement::setNetworkState): changedNetworkState -> updateStatusDisplay.
529         (WebCore::HTMLMediaElement::setReadyState): Call updateStatusDisplay.
530
531         * html/shadow/MediaControlRootElement.cpp:
532         (WebCore::MediaControlRootElement::reset): changedNetworkState -> updateStatusDisplay.
533         (WebCore::MediaControlRootElement::updateStatusDisplay): Ditto.
534         * html/shadow/MediaControlRootElement.h:
535
536         * html/shadow/MediaControlRootElementChromium.cpp:
537         (WebCore::MediaControlRootElementChromium::reset): Ditto.
538         (WebCore::MediaControlRootElementChromium::updateStatusDisplay): Ditto.
539         * html/shadow/MediaControlRootElementChromium.h:
540         * html/shadow/MediaControls.h:
541
542 2011-05-06  Andreas Kling  <andreas.kling@nokia.com>
543
544         Unreviewed Qt 4.8 build fix.
545
546         * WebCore.pro: Don't set HAVE_QRAWFONT yet. Left a FIXME so we can
547         enable it after the 4.8 bots are updated with the full QRawFont APIs.
548
549 2011-05-06  Alexander Pavlov  <apavlov@chromium.org>
550
551         Reviewed by Yury Semikhatsky.
552
553         Web Inspector: editing CSS in the Resources panel and not committing does not revert the change.
554         https://bugs.webkit.org/show_bug.cgi?id=60319
555
556         * inspector/front-end/ResourceView.js:
557         (WebInspector.ResourceSourceFrame.prototype.cancelEditing):
558
559 2011-05-06  Joe Mason  <jmason@rim.com>
560
561         Reviewed by Adam Barth.
562
563         WebSocket urls should always be encoded as UTF-8.
564         https://bugs.webkit.org/show_bug.cgi?id=57138
565
566         Change WebSocket::connect to take the raw URL string and parse it
567         internally using the simple KURL constructor, which expects an absolute
568         UTF-8 encoded URL.  This ensures that all code that creates a WebSocket
569         goes through this method instead of completeURL.
570
571         Test: http/tests/websocket/tests/url-with-nonascii-query.html
572
573         * bindings/js/JSWebSocketCustom.cpp:
574         (WebCore::JSWebSocketConstructor::constructJSWebSocket): Pass String instead of KURL to WebSocket::connect().
575         * websockets/WebSocket.cpp:
576         (WebCore::WebSocket::connect): Now takes a String instead of a KURL and parses it using UTF-8.
577         * websockets/WebSocket.h:
578
579 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
580
581         Reviewed by Eric Seidel.
582
583         Make CSSStyleSelector::applyProperty() CSSPropertyWebkitColorCorrection case use appropriate macro.
584         https://bugs.webkit.org/show_bug.cgi?id=60339
585
586         No tests added as no functionality changed.
587
588         * css/CSSStyleSelector.cpp:
589         (WebCore::CSSStyleSelector::applyProperty):
590         Use correct macro for CSSPropertySpeak.
591         * rendering/style/RenderStyle.h:
592         (WebCore::InheritedFlags::initialColorSpace):
593         Add initialColorSpace() static method.
594
595 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
596
597         Reviewed by Eric Seidel.
598
599         Make RenderStyle::setPageBreakInside() reject unsupported enum values.
600         https://bugs.webkit.org/show_bug.cgi?id=60235
601
602         No tests added as no functionality changed.
603
604         * css/CSSStyleSelector.cpp:
605         (WebCore::CSSStyleSelector::applyProperty):
606         Remove special-case code and use appropriate macro.
607         * rendering/style/RenderStyle.h:
608         (WebCore::InheritedFlags::setPageBreakInside):
609         Assert that only supported values are used.
610
611 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
612
613         Reviewed by Eric Seidel.
614
615         Move burden of checking for BJustify box alignment into RenderStyle
616         https://bugs.webkit.org/show_bug.cgi?id=60246
617
618         No new tests added as no functionality changed.
619
620         * css/CSSStyleSelector.cpp:
621         (WebCore::CSSStyleSelector::applyProperty):
622         Remove special-case logic checking for BJUSTIFY and use existing macro.
623         * rendering/style/RenderStyle.h:
624         (WebCore::InheritedFlags::setBoxAlign):
625         Assert valid values are used.
626
627 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
628
629         Reviewed by Eric Seidel.
630
631         Make CSSStyleSelector::applyProperty() CSSPropertyPointerEvents use the correct macro.
632         https://bugs.webkit.org/show_bug.cgi?id=60338
633
634         No tests added as no functionality changed.
635
636         * css/CSSStyleSelector.cpp:
637         (WebCore::CSSStyleSelector::applyProperty):
638         Use correct macro for CSSPropertySpeak.
639
640 2011-05-06  Alexis Menard  <alexis.menard@openbossa.org>
641
642         Reviewed by Alexey Proskuryakov.
643
644         Build fix with gcc 4.6 and c++0x support.
645         https://bugs.webkit.org/show_bug.cgi?id=60284
646
647         When enabling support of c++0x the compilation fails because of an
648         ambiguous overload error. In this code when constructing the pair
649         we use the new c++0x rvalue reference feature (&&). It means we are
650         calling String(const WTF::AtomicString&) which becomes ambiguous because
651         it has an overload WTF::String::String(const WTF::String&) and usually one
652         with the native port string type (e.g. QString). In this code we want the
653         String version because the pair store Strings.
654
655         No new tests, build fix.
656
657         * loader/FormSubmission.cpp:
658         (WebCore::FormSubmission::create):
659
660 2011-05-06  Cris Neckar  <cdn@chromium.org>
661
662         Reviewed by Dirk Schulze.
663
664         Tests for crash when a transform is applied to certain filters.
665         https://bugs.webkit.org/show_bug.cgi?id=59551
666
667         Test: svg/filters/filter-after-transform-crash.svg
668
669         * platform/graphics/filters/FEComposite.cpp:
670         (WebCore::FEComposite::determineAbsolutePaintRect):
671         * platform/graphics/filters/FEConvolveMatrix.h:
672         (WebCore::FEConvolveMatrix::determineAbsolutePaintRect):
673         * platform/graphics/filters/FEDisplacementMap.h:
674         (WebCore::FEDisplacementMap::determineAbsolutePaintRect):
675         * platform/graphics/filters/FEFlood.h:
676         (WebCore::FEFlood::determineAbsolutePaintRect):
677         * platform/graphics/filters/FELighting.h:
678         (WebCore::FELighting::determineAbsolutePaintRect):
679         * platform/graphics/filters/FETile.h:
680         (WebCore::FETile::determineAbsolutePaintRect):
681         * platform/graphics/filters/FETurbulence.h:
682         (WebCore::FETurbulence::determineAbsolutePaintRect):
683         * platform/graphics/filters/FilterEffect.cpp:
684         (WebCore::isFilterSizeValid):
685         (WebCore::FilterEffect::determineAbsolutePaintRect):
686         (WebCore::FilterEffect::asUnmultipliedImage):
687         (WebCore::FilterEffect::asPremultipliedImage):
688         (WebCore::FilterEffect::copyUnmultipliedImage):
689         (WebCore::FilterEffect::copyPremultipliedImage):
690         (WebCore::FilterEffect::createUnmultipliedImageResult):
691         (WebCore::FilterEffect::createPremultipliedImageResult):
692         * platform/graphics/filters/FilterEffect.h:
693         (WebCore::FilterEffect::maxEffectRect):
694         (WebCore::FilterEffect::setMaxEffectRect):
695         * rendering/svg/RenderSVGResourceFilter.cpp:
696         * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
697         (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
698
699 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
700
701         Reviewed by Eric Seidel.
702
703         Use cast to convert primitive value to FontSmoothingMode.
704         https://bugs.webkit.org/show_bug.cgi?id=60242
705
706         No tests added as no functionality changed.
707
708         * css/CSSStyleSelector.cpp:
709         (WebCore::CSSStyleSelector::applyProperty):
710         Use cast to convert primitive value to FontSmoothingMode.
711
712 2011-05-05  Luke Macpherson   <macpherson@chromium.org>
713
714         Reviewed by Eric Seidel.
715
716         Make CSSPropertySpeak use the correct macro.
717         https://bugs.webkit.org/show_bug.cgi?id=60335
718
719         No tests added as no functionality changed.
720
721         * css/CSSStyleSelector.cpp:
722         (WebCore::CSSStyleSelector::applyProperty):
723         Use correct macro for CSSPropertySpeak.
724
725 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
726
727         Reviewed by Maciej Stachowiak.
728
729         <rdar://problem/9390864>
730         https://bugs.webkit.org/show_bug.cgi?id=60343
731         Crash on Recovery System when trying to load page that includes media element
732
733         Automated test not possible, tested manually.
734
735         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
736         (WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable): Only return true if
737             AVFoundation and CoreMedia are installed.
738
739         * platform/mac/SoftLinking.h: Define SOFT_LINK_FRAMEWORK_OPTIONAL, identical to 
740             SOFT_LINK_FRAMEWORK except that it doesn't ASSERT if the framework doesn't exist.
741
742 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
743
744         Reviewed by Darin Adler.
745
746         Live streams sometimes won't play with AVFoundation backend
747         https://bugs.webkit.org/show_bug.cgi?id=58961
748         rdar://problem/9284748
749
750         Tested manually because we don't have any live streams to test in DRT.
751
752         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
753         (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Don't special case seeking, assume
754             AVFoundation will notify us when internal states change.
755
756         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Make m_timeObserver
757             a RetainPtr
758         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
759         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Ditto.
760         (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
761
762 2011-05-05  Jay Civelli  <jcivelli@chromium.org>
763
764         Reviewed by Adam Barth.
765
766         Adding quoted-printable encoding/decoding capabilities.
767         This is needed for MHTML support.
768         https://bugs.webkit.org/show_bug.cgi?id=59834
769
770         * CMakeLists.txt:
771         * GNUmakefile.list.am:
772         * WebCore.gypi:
773         * WebCore.pro:
774         * WebCore.vcproj/WebCore.vcproj:
775         * WebCore.xcodeproj/project.pbxproj:
776         * platform/text/QuotedPrintable.cpp: Added.
777         * platform/text/QuotedPrintable.h: Added.
778
779 2011-05-05  Andy Estes  <aestes@apple.com>
780
781         Reviewed by Eric Seidel.
782
783         Implement document.innerHTML
784         https://bugs.webkit.org/show_bug.cgi?id=60316
785
786         ASSERT that contextElement is non-0 when constructing a HTMLTreeBuilder
787         for fragment parsing. This assertion will become invalid when
788         document.innerHTML is implemented, which is the only case where HTML5
789         specifies that a fragment will not have a context element.
790
791         * html/parser/HTMLTreeBuilder.cpp:
792         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
793
794 2011-05-05  Kevin Ollivier  <kevino@theolliviers.com>
795
796         [wx] Unreviewed build fix. Include ApplicationServices for wx port.
797
798         * platform/graphics/GlyphBuffer.h:
799         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
800
801 2011-05-05  Dan Bernstein  <mitz@apple.com>
802
803         Reviewed by Simon Fraser.
804
805         WebCore part of <rdar://problem/9155590> Broken animation in iAd producer
806
807         * WebCore.exp.in: Export wkExecutableWasLinkedOnOrBeforeSnowLeopard.
808         * platform/graphics/ca/GraphicsLayerCA.cpp:
809         (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): Account for the binary-compatiblity
810         check in Core Animation.
811         * platform/mac/WebCoreSystemInterface.h: Added wkExecutableWasLinkedOnOrBeforeSnowLeopard.
812         * platform/mac/WebCoreSystemInterface.mm: Ditto.
813
814 2011-05-05  Sam Weinig  <sam@webkit.org>
815
816         Reviewed by Anders Carlsson.
817
818         WebKit2 (Mac): Background tabs/windows can force themselves to the front
819         <rdar://problem/9386346>
820         https://bugs.webkit.org/show_bug.cgi?id=60315
821
822         * platform/mac/WidgetMac.mm:
823         (WebCore::Widget::setFocus):
824         It is incorrect for us to call Chrome::focus() here, which could bring a window/tab
825         to the front. Calling focusNSView() was only necessary because in WebKit we must inform
826         the platform widget that the focus has changed. WebKit2 Mac now matches other ports.
827
828 2011-05-05  Justin Novosad  <junov@chromium.org>
829
830         Reviewed by Kenneth Russell.
831
832         [Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
833         https://bugs.webkit.org/show_bug.cgi?id=60173
834
835         * page/Page.cpp:
836         (WebCore::Page::sharedGraphicsContext3D):
837         Flipping the switch to make Skia the default for the accelerated 2d canvas
838
839 2011-05-05  Tony Gentilcore  <tonyg@chromium.org>
840
841         Reviewed by Adam Barth.
842
843         ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
844         https://bugs.webkit.org/show_bug.cgi?id=60101
845
846         Test: fast/parser/close-while-stopping.html
847
848         * dom/Document.cpp:
849         (WebCore::Document::close): According to http://www.whatwg.org/specs/web-apps/current-work/#dom-document-close,
850         the close() steps should be aborted if there is no script-created parser
851         associated with the document. Our parser lives throughout
852         http://www.whatwg.org/specs/web-apps/current-work/#the-end, but it seems
853         the spec doesn't consider the parser active any more. So to properly
854         respect this, we need to check that the parser is still parsing.
855
856 2011-04-28  Evan Martin  <evan@chromium.org>
857
858         Reviewed by Ojan Vafai.
859
860         REGRESSION: backspace should not go back on Linux
861         https://bugs.webkit.org/show_bug.cgi?id=59731
862
863         Add a new EditingBehavior, shouldNavigateBackOnBackspace, which is false on
864         Linux, and test for it in the default backspace handler.
865
866         * editing/EditingBehavior.h:
867         (WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
868         * page/EventHandler.cpp:
869         (WebCore::EventHandler::defaultBackspaceEventHandler):
870
871 2011-05-05  Igor Oliveira  <igor.oliveira@openbossa.org>
872
873         Reviewed by Kenneth Russell.
874
875         Framebuffer object is being created twice
876         https://bugs.webkit.org/show_bug.cgi?id=60207
877
878         Does not create more than one opengl framebuffer
879
880         * platform/graphics/gpu/mac/DrawingBufferMac.mm:
881         (WebCore::DrawingBuffer::DrawingBuffer):
882         * platform/graphics/gpu/qt/DrawingBufferQt.cpp:
883         (WebCore::DrawingBuffer::DrawingBuffer):
884         * platform/graphics/gtk/DrawingBufferGtk.cpp:
885         (WebCore::DrawingBuffer::DrawingBuffer):
886
887 2011-05-05  Simon Fraser  <simon.fraser@apple.com>
888
889         Reviewed by Beth Dakin.
890
891         Every RenderLayer registers itself as a ScrollableArea
892         https://bugs.webkit.org/show_bug.cgi?id=59650
893
894         Rather than registering every RenderLayer as a ScrollableArea
895         on layer creation, only register RenderLayers which are overflow-
896         scrollable. Use the m_scrollableAreaPage pointer to keep track
897         of whether we've registered to avoid excess work.
898
899         * rendering/RenderLayer.cpp:
900         (WebCore::RenderLayer::RenderLayer):
901         (WebCore::RenderLayer::scrollsOverflow):
902         (WebCore::RenderLayer::styleChanged):
903         * rendering/RenderLayer.h:
904
905 2011-05-05  Jer Noble  <jer.noble@apple.com>
906
907         Reviewed by Steve Falkenburg.
908
909         Workaround iTunes' incorrect registry entry for .m4a extensions.
910         https://bugs.webkit.org/show_bug.cgi?id=60229
911
912         No new tests, as a test already exits for .m4a support (LayoutTests/media/audio-mpeg4-supported.html).
913         The test failed to catch this regression because the build bots haven't installed iTunes.
914         
915         Add a hard-coded MIME type mapping for 'm4a' -> 'audio/x-m4a'.
916
917         * platform/win/MIMETypeRegistryWin.cpp:
918         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
919
920 2011-05-05  Abhishek Arya  <inferno@chromium.org>
921
922         Reviewed by Dave Hyatt.
923
924         When style changes for a RenderBlock and we lose our ability to intrude into
925         floats in the next siblings block (e.g a position change), make sure to mark
926         our childs with floats for layout and iterate through our next sibling block
927         chain to see which ones contain the float that also exists in our floating
928         objects list and clear those using markAllDescendantsWithFloatsForLayout.
929         https://bugs.webkit.org/show_bug.cgi?id=56299
930
931         Tests: fast/block/float/float-not-removed-from-next-sibling-crash.html
932                fast/block/float/float-not-removed-from-next-sibling.html
933                fast/block/float/float-not-removed-from-next-sibling2.html
934                fast/block/float/float-not-removed-from-next-sibling3.html
935                fast/block/float/float-not-removed-from-next-sibling4.html
936
937         * rendering/RenderBlock.cpp:
938         (WebCore::RenderBlock::styleWillChange):
939         (WebCore::RenderBlock::styleDidChange):
940         (WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
941         * rendering/RenderBlock.h:
942
943 2011-05-05  Brian Weinstein  <bweinstein@apple.com>
944
945         Reviewed by Timothy Hatcher.
946
947         WebKit2: Docking Web Inspector doesn't respect maximum inspector size
948         https://bugs.webkit.org/show_bug.cgi?id=60294
949         <rdar://problem/9388518>
950
951         Make a needed function public and export it.
952
953         * WebCore.exp.in: Export constrainedAttaechedWindowHeight.
954         * inspector/InspectorFrontendClientLocal.h: Make constrainedAttaechedWindowHeight public.
955
956 2011-05-05  Tony Gentilcore  <tonyg@chromium.org>
957
958         Reviewed by Nate Chapin.
959
960         [Navigation Timing] navigationStart should always be available
961         https://bugs.webkit.org/show_bug.cgi?id=59448
962
963         * page/PerformanceTiming.cpp:
964         (WebCore::PerformanceTiming::navigationStart):
965
966 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
967
968         Reviewed by Adam Roben.
969
970         Block callbacks delivered during destruction
971         https://bugs.webkit.org/show_bug.cgi?id=60291
972         <rdar://problem/9382942>
973
974         No new tests, tested by existing tests.
975
976         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
977         (WebCore::MediaPlayerPrivateAVFoundation::~MediaPlayerPrivateAVFoundation): Call 
978             setIgnoreLoadStateChanges(true) to cancel all callbacks.
979         (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Return immediately if 
980             m_ignoreLoadStateChanges is true.
981         (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): loadStateChanged -> updateStates.
982             Don't call updateStates after calling loadedTimeRangesChanged, it already does it.
983         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
984
985 2011-05-05  David Hyatt  <hyatt@apple.com>
986
987         Reviewed by Darin Adler.
988
989         <rdar://problem/9354979> REGRESSION (r83070-r83126): Conversation takes 10 seconds to load and makes mail unresponsive
990
991         Culled inlines were triggering some pathological line box tree groveling that isn't even necessary.
992         Removed the ancient code (that used to be in RenderFlow), since it made no sense in the RenderBlock case
993         (it was running for inline blocks, which was definitely not even the intent) or in the RenderInline case
994         (the object being removed has no effect on any lines).
995         
996         Also tweaked culledInlineFirstLineBox and culledInlineLastLineBox to avoid bailing if the first replaced object that
997         is encountered has a null inlineBoxWrapper().  Just a slight speed optimization to avoid an extra null check.
998         
999         * rendering/RenderBlock.cpp:
1000         (WebCore::RenderBlock::destroy):
1001         * rendering/RenderInline.cpp:
1002         (WebCore::RenderInline::destroy):
1003         (WebCore::RenderInline::culledInlineFirstLineBox):
1004         (WebCore::RenderInline::culledInlineLastLineBox):
1005
1006 2011-05-05  Bharathwaaj Srinivasan  <bharathwaaj.s@gmail.com>
1007
1008         Reviewed by Holger Freyther.
1009
1010         Fix build-webkit --minimal.
1011         https://bugs.webkit.org/show_bug.cgi?id=60257
1012
1013         No new tests. This is just a build fix.
1014
1015         * bindings/js/JSDOMBinding.cpp:
1016
1017 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
1018
1019         Reviewed by Adam Roben.
1020
1021         The preload attribute of the video tag is not completely implemented
1022         https://bugs.webkit.org/show_bug.cgi?id=43673
1023         <rdar://problem/9369746>
1024
1025         This change implements "preload=metadata" for the AVFoundation backend.
1026         Tested manually with manual-tests/media-elements/video-preload.html.
1027
1028         * html/HTMLMediaElement.cpp:
1029         (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay.
1030         (WebCore::HTMLMediaElement::prepareForLoad): Ditto.
1031         (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play.
1032         (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'auto'
1033             because we need to have media data loaded to seek.
1034         (WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.
1035         * html/HTMLMediaElement.h:
1036
1037         * manual-tests/media-elements/video-preload.html: Make changing urls work. 
1038
1039         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
1040         (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):  Remove 
1041             m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.
1042         (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
1043         (WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn. 
1044             Move all preload logic to setPreload, call it from here.
1045         (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to 
1046             setPreload, call it.
1047         (WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is
1048             unlikely to be correct and isn't worth caching. Use invalidTime() function.
1049         (WebCore::MediaPlayerPrivateAVFoundation::seeking): Use invalidTime() function.
1050         (WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Add logging.
1051         (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus
1052             to AssetStatus. Always create a AVPlayerItem for live streams because they can't be inspected
1053             without one. Set networkState to 'idle' when the playback buffer is full because that is
1054             a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA' 
1055             when the first frame is available.
1056         (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache
1057             width, height, hasVideo, etc.
1058         (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Use invalidTime() function.
1059         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): Ditto.
1060         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
1061         (WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done
1062             in derived classes.
1063         (WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create
1064             AVAsset and AVPlayerItem here.
1065         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
1066
1067         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
1068         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
1069         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
1070             m_videoFrameHasDrawn.
1071         (WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from
1072             videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
1073             if we have painted a frame to the context.
1074         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset
1075             if necessary.
1076         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
1077         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
1078         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
1079         (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
1080         (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when
1081             the buffer is full.
1082         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the
1083             AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
1084             when we only have metadata.
1085         (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
1086         (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
1087         (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset
1088             when when we haven't allocated the AVPlayerItem yet so that we can report attributes
1089             when we only have metadata.
1090         (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before
1091             we have allocated the AVPlayerItem.
1092
1093 2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
1094
1095         Reviewed by Eric Seidel.
1096
1097         Rename SelectionController to FrameSelection
1098         https://bugs.webkit.org/show_bug.cgi?id=60234
1099
1100         * CMakeLists.txt:
1101         * GNUmakefile.list.am:
1102         * WebCore.exp.in:
1103         * WebCore.gypi:
1104         * WebCore.pro:
1105         * WebCore.vcproj/WebCore.vcproj:
1106         * WebCore.xcodeproj/project.pbxproj:
1107         * accessibility/AccessibilityObject.cpp:
1108         * accessibility/AccessibilityRenderObject.cpp:
1109         (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
1110         * accessibility/mac/AccessibilityObjectWrapper.mm:
1111         * bindings/objc/ExceptionHandlers.h:
1112         * css/CSSStyleSelector.cpp:
1113         * dom/ContainerNode.cpp:
1114         (WebCore::ContainerNode::cloneChildNodes):
1115         * dom/Document.cpp:
1116         * dom/InputElement.cpp:
1117         * editing/DeleteButtonController.cpp:
1118         * editing/EditCommand.cpp:
1119         * editing/EditingAllInOne.cpp:
1120         * editing/EditingStyle.cpp:
1121         * editing/Editor.cpp:
1122         (WebCore::Editor::canCopy):
1123         (WebCore::Editor::canDelete):
1124         (WebCore::Editor::markMisspellingsAfterTypingToWord):
1125         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
1126         (WebCore::Editor::changeSelectionAfterCommand):
1127         (WebCore::Editor::respondToChangedSelection):
1128         * editing/Editor.h:
1129         * editing/EditorCommand.cpp:
1130         (WebCore::executeDeleteToMark):
1131         (WebCore::executeMoveBackward):
1132         (WebCore::executeMoveBackwardAndModifySelection):
1133         (WebCore::executeMoveDown):
1134         (WebCore::executeMoveDownAndModifySelection):
1135         (WebCore::executeMoveForward):
1136         (WebCore::executeMoveForwardAndModifySelection):
1137         (WebCore::executeMoveLeft):
1138         (WebCore::executeMoveLeftAndModifySelection):
1139         (WebCore::executeMovePageDown):
1140         (WebCore::executeMovePageDownAndModifySelection):
1141         (WebCore::executeMovePageUp):
1142         (WebCore::executeMovePageUpAndModifySelection):
1143         (WebCore::executeMoveRight):
1144         (WebCore::executeMoveRightAndModifySelection):
1145         (WebCore::executeMoveToBeginningOfDocument):
1146         (WebCore::executeMoveToBeginningOfDocumentAndModifySelection):
1147         (WebCore::executeMoveToBeginningOfLine):
1148         (WebCore::executeMoveToBeginningOfLineAndModifySelection):
1149         (WebCore::executeMoveToBeginningOfParagraph):
1150         (WebCore::executeMoveToBeginningOfParagraphAndModifySelection):
1151         (WebCore::executeMoveToBeginningOfSentence):
1152         (WebCore::executeMoveToBeginningOfSentenceAndModifySelection):
1153         (WebCore::executeMoveToEndOfDocument):
1154         (WebCore::executeMoveToEndOfDocumentAndModifySelection):
1155         (WebCore::executeMoveToEndOfSentence):
1156         (WebCore::executeMoveToEndOfSentenceAndModifySelection):
1157         (WebCore::executeMoveToEndOfLine):
1158         (WebCore::executeMoveToEndOfLineAndModifySelection):
1159         (WebCore::executeMoveToEndOfParagraph):
1160         (WebCore::executeMoveToEndOfParagraphAndModifySelection):
1161         (WebCore::executeMoveParagraphBackwardAndModifySelection):
1162         (WebCore::executeMoveParagraphForwardAndModifySelection):
1163         (WebCore::executeMoveUp):
1164         (WebCore::executeMoveUpAndModifySelection):
1165         (WebCore::executeMoveWordBackward):
1166         (WebCore::executeMoveWordBackwardAndModifySelection):
1167         (WebCore::executeMoveWordForward):
1168         (WebCore::executeMoveWordForwardAndModifySelection):
1169         (WebCore::executeMoveWordLeft):
1170         (WebCore::executeMoveWordLeftAndModifySelection):
1171         (WebCore::executeMoveWordRight):
1172         (WebCore::executeMoveWordRightAndModifySelection):
1173         (WebCore::executeMoveToLeftEndOfLine):
1174         (WebCore::executeMoveToLeftEndOfLineAndModifySelection):
1175         (WebCore::executeMoveToRightEndOfLine):
1176         (WebCore::executeMoveToRightEndOfLineAndModifySelection):
1177         * editing/FrameSelection.cpp: Copied from Source/WebCore/editing/SelectionController.cpp.
1178         (WebCore::FrameSelection::FrameSelection):
1179         (WebCore::FrameSelection::moveTo):
1180         (WebCore::FrameSelection::setSelection):
1181         (WebCore::FrameSelection::nodeWillBeRemoved):
1182         (WebCore::FrameSelection::respondToNodeModification):
1183         (WebCore::FrameSelection::textWillBeReplaced):
1184         (WebCore::FrameSelection::setIsDirectional):
1185         (WebCore::FrameSelection::directionOfEnclosingBlock):
1186         (WebCore::FrameSelection::willBeModified):
1187         (WebCore::FrameSelection::positionForPlatform):
1188         (WebCore::FrameSelection::startForPlatform):
1189         (WebCore::FrameSelection::endForPlatform):
1190         (WebCore::FrameSelection::modifyExtendingRight):
1191         (WebCore::FrameSelection::modifyExtendingForward):
1192         (WebCore::FrameSelection::modifyMovingRight):
1193         (WebCore::FrameSelection::modifyMovingForward):
1194         (WebCore::FrameSelection::modifyExtendingLeft):
1195         (WebCore::FrameSelection::modifyExtendingBackward):
1196         (WebCore::FrameSelection::modifyMovingLeft):
1197         (WebCore::FrameSelection::modifyMovingBackward):
1198         (WebCore::FrameSelection::modify):
1199         (WebCore::FrameSelection::xPosForVerticalArrowNavigation):
1200         (WebCore::FrameSelection::clear):
1201         (WebCore::FrameSelection::setStart):
1202         (WebCore::FrameSelection::setEnd):
1203         (WebCore::FrameSelection::setBase):
1204         (WebCore::FrameSelection::setExtent):
1205         (WebCore::FrameSelection::setCaretRectNeedsUpdate):
1206         (WebCore::FrameSelection::updateCaretRect):
1207         (WebCore::FrameSelection::caretRenderer):
1208         (WebCore::FrameSelection::localCaretRect):
1209         (WebCore::FrameSelection::absoluteBoundsForLocalRect):
1210         (WebCore::FrameSelection::absoluteCaretBounds):
1211         (WebCore::FrameSelection::caretRepaintRect):
1212         (WebCore::FrameSelection::recomputeCaretRect):
1213         (WebCore::FrameSelection::shouldRepaintCaret):
1214         (WebCore::FrameSelection::invalidateCaretRect):
1215         (WebCore::FrameSelection::paintCaret):
1216         (WebCore::FrameSelection::debugRenderer):
1217         (WebCore::FrameSelection::contains):
1218         (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
1219         (WebCore::FrameSelection::selectAll):
1220         (WebCore::FrameSelection::setSelectedRange):
1221         (WebCore::FrameSelection::isInPasswordField):
1222         (WebCore::FrameSelection::caretRendersInsideNode):
1223         (WebCore::FrameSelection::focusedOrActiveStateChanged):
1224         (WebCore::FrameSelection::pageActivationChanged):
1225         (WebCore::FrameSelection::updateSecureKeyboardEntryIfActive):
1226         (WebCore::FrameSelection::setUseSecureKeyboardEntry):
1227         (WebCore::FrameSelection::setFocused):
1228         (WebCore::FrameSelection::isFocusedAndActive):
1229         (WebCore::FrameSelection::updateAppearance):
1230         (WebCore::FrameSelection::setCaretVisible):
1231         (WebCore::FrameSelection::clearCaretRectIfNeeded):
1232         (WebCore::FrameSelection::caretBlinkTimerFired):
1233         (WebCore::FrameSelection::notifyRendererOfSelectionChange):
1234         (WebCore::FrameSelection::setFocusedNodeIfNeeded):
1235         (WebCore::FrameSelection::paintDragCaret):
1236         (WebCore::FrameSelection::copyTypingStyle):
1237         (WebCore::FrameSelection::shouldDeleteSelection):
1238         (WebCore::FrameSelection::bounds):
1239         (WebCore::FrameSelection::getClippedVisibleTextRectangles):
1240         (WebCore::FrameSelection::currentForm):
1241         (WebCore::FrameSelection::revealSelection):
1242         (WebCore::FrameSelection::setSelectionFromNone):
1243         (WebCore::FrameSelection::shouldChangeSelection):
1244         (WebCore::FrameSelection::formatForDebugger):
1245         (WebCore::FrameSelection::showTreeForThis):
1246         (showTree):
1247         * editing/FrameSelection.h: Copied from Source/WebCore/editing/SelectionController.h.
1248         (WebCore::FrameSelection::typingStyle):
1249         (WebCore::FrameSelection::clearTypingStyle):
1250         (WebCore::FrameSelection::setTypingStyle):
1251         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
1252         * editing/ModifySelectionListLevel.cpp:
1253         * editing/RemoveFormatCommand.cpp:
1254         * editing/ReplaceSelectionCommand.cpp:
1255         * editing/SelectionController.cpp: Removed.
1256         * editing/SelectionController.h: Removed.
1257         * editing/SetSelectionCommand.cpp:
1258         (WebCore::SetSelectionCommand::SetSelectionCommand):
1259         (WebCore::SetSelectionCommand::doApply):
1260         (WebCore::SetSelectionCommand::doUnapply):
1261         * editing/SetSelectionCommand.h:
1262         (WebCore::SetSelectionCommand::create):
1263         * editing/SpellingCorrectionCommand.cpp:
1264         (WebCore::SpellingCorrectionCommand::doApply):
1265         * editing/SpellingCorrectionController.cpp:
1266         (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
1267         * editing/TypingCommand.cpp:
1268         (WebCore::TypingCommand::deleteKeyPressed):
1269         (WebCore::TypingCommand::forwardDeleteKeyPressed):
1270         * editing/chromium/FrameSelectionChromium.cpp: Copied from Source/WebCore/editing/chromium/SelectionControllerChromium.cpp.
1271         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
1272         * editing/chromium/SelectionControllerChromium.cpp: Removed.
1273         * editing/gtk/FrameSelectionGtk.cpp: Copied from Source/WebCore/editing/gtk/SelectionControllerGtk.cpp.
1274         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
1275         * editing/gtk/SelectionControllerGtk.cpp: Removed.
1276         * editing/mac/EditorMac.mm:
1277         (WebCore::Editor::canCopyExcludingStandaloneImages):
1278         * editing/mac/FrameSelectionMac.mm: Copied from Source/WebCore/editing/mac/SelectionControllerMac.mm.
1279         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
1280         * editing/mac/SelectionControllerMac.mm: Removed.
1281         * editing/qt/EditorQt.cpp:
1282         * loader/archive/cf/LegacyWebArchive.cpp:
1283         * page/ContextMenuController.cpp:
1284         (WebCore::ContextMenuController::populate):
1285         * page/DOMSelection.cpp:
1286         (WebCore::DOMSelection::type):
1287         (WebCore::DOMSelection::modify):
1288         (WebCore::DOMSelection::addRange):
1289         (WebCore::DOMSelection::deleteFromDocument):
1290         (WebCore::DOMSelection::containsNode):
1291         * page/DragController.cpp:
1292         (WebCore::DragController::dragIsMove):
1293         * page/DragController.h:
1294         * page/EventHandler.cpp:
1295         (WebCore::setSelectionIfNeeded):
1296         (WebCore::setNonDirectionalSelectionIfNeeded):
1297         (WebCore::EventHandler::sendContextMenuEventForKey):
1298         (WebCore::EventHandler::handleKeyboardSelectionMovement):
1299         * page/EventHandler.h:
1300         * page/FocusController.cpp:
1301         (WebCore::clearSelectionIfNeeded):
1302         * page/Frame.cpp:
1303         (WebCore::Frame::Frame):
1304         * page/Frame.h:
1305         (WebCore::Frame::selection):
1306         * page/Page.cpp:
1307         (WebCore::Page::Page):
1308         * page/Page.h:
1309         (WebCore::Page::dragCaretController):
1310         * page/chromium/DragControllerChromium.cpp:
1311         * page/chromium/EventHandlerChromium.cpp:
1312         * page/win/DragControllerWin.cpp:
1313         * page/win/EventHandlerWin.cpp:
1314         * rendering/HitTestResult.cpp:
1315         * rendering/RenderBlock.cpp:
1316         (WebCore::RenderBlock::destroy):
1317         (WebCore::RenderBlock::paintCaret):
1318         * rendering/RenderImage.cpp:
1319         * rendering/RenderInline.cpp:
1320         (WebCore::RenderInline::destroy):
1321         * rendering/RenderLayer.cpp:
1322         * rendering/RenderListBox.cpp:
1323         * rendering/RenderObjectChildList.cpp:
1324         (WebCore::RenderObjectChildList::removeChildNode):
1325         * rendering/RenderTextControl.cpp:
1326         * rendering/RenderTextControlSingleLine.cpp:
1327         * rendering/RenderTheme.cpp:
1328         * rendering/RenderTreeAsText.cpp:
1329         * svg/SVGSVGElement.cpp:
1330         * svg/SVGTextContentElement.cpp:
1331         (WebCore::SVGTextContentElement::selectSubString):
1332
1333 2011-05-05  Brent Fulgham  <bfulgham@webkit.org>
1334
1335         [WinCairo] unreviewed build correction.
1336
1337         * platform/network/curl/ResourceRequest.h:
1338         Stub out the new pipelined http logic for cURL.
1339
1340 2011-05-05  Pavel Feldman  <pfeldman@chromium.org>
1341
1342         Reviewed by Yury Semikhatsky.
1343
1344         Web Inspector: searching for node does not result in bringToFront call.
1345         https://bugs.webkit.org/show_bug.cgi?id=60222
1346
1347         * inspector/front-end/ElementsPanel.js:
1348         (WebInspector.ElementsPanel.prototype.updateFocusedNode):
1349
1350 2011-05-05  Andreas Kling  <andreas.kling@nokia.com>
1351
1352         Reviewed by Simon Hausmann.
1353
1354         [Qt] Implement the fast font path for Qt.
1355         https://bugs.webkit.org/show_bug.cgi?id=51106
1356
1357         Use the new QRawFont and QGlyphs APIs in Qt 4.8 to implement the fast paths for
1358         rendering and measurement of simple text.
1359
1360         Since this is still unreleased API, it's guarded by HAVE(QRAWFONT) until the new
1361         classes are fully integrated into the Qt 4.8 release branch.
1362
1363         * WebCore.pro: Add HAVE_QRAWFONT define (for Qt >= 4.8) and new files to build.
1364
1365         * platform/graphics/Font.cpp:
1366         (WebCore::Font::drawText): Disable fast font path for stroked text, and when
1367         painting text with a shadow. (Qt-only)
1368         (WebCore::Font::codePath): Try to use fast font path in more cases.
1369
1370         * platform/graphics/qt/FontCacheQt.cpp:
1371         (WebCore::rawFontForCharacters): Helper function, returns a suitable QRawFont
1372         to use for rendering a given string. Goes through QTextLayout to find the best
1373         font based on the original QFont query.
1374         (WebCore::FontCache::getFontDataForCharacters): Implemented using helper above.
1375
1376         * platform/graphics/qt/FontPlatformData.h:
1377         (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
1378         (WebCore::FontPlatformData::FontPlatformData):
1379         (WebCore::FontPlatformData::rawFont):
1380         * platform/graphics/qt/FontPlatformDataQt.cpp:
1381         (WebCore::FontPlatformData::FontPlatformData): Add a QRawFont member to FontPlatformData.
1382
1383         * platform/graphics/qt/FontQt.cpp:
1384         (WebCore::fillPenForContext):
1385         (WebCore::strokePenForContext):
1386         (WebCore::drawTextCommon): Factored QPen creation out of drawTextCommon
1387         to share code between complex and simple font rendering paths.
1388         (WebCore::Font::drawGlyphs): Implemented using QPainter::drawGlyphs().
1389
1390         * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
1391         (WebCore::GlyphPage::fill): Implemented using QRawFont::glyphIndexesForString().
1392
1393         * platform/graphics/qt/SimpleFontDataQt.cpp:
1394         (WebCore::SimpleFontData::determinePitch): Return false when using QRawFont since we
1395         have no way of knowing the pitch.
1396         (WebCore::SimpleFontData::containsCharacters): Implemented using QRawFont::supportsCharacter().
1397         (WebCore::SimpleFontData::platformWidthForGlyph): Implemented using QRawFont::advancesForGlyphIndexes().
1398         (WebCore::SimpleFontData::scaledFontData): Added, based on other ports.
1399         (WebCore::SimpleFontData::smallCapsFontData): Ditto.
1400         (WebCore::SimpleFontData::emphasisMarkFontData): Ditto.
1401         (WebCore::SimpleFontData::platformBoundsForGlyph): Stub.
1402         (WebCore::SimpleFontData::platformInit): Use QRawFont APIs to retrieve font metrics.
1403         (WebCore::SimpleFontData::platformCharWidthInit): Ditto.
1404
1405 2011-05-05  Alexis Menard  <alexis.menard@openbossa.org>
1406
1407         Reviewed by Andreas Kling.
1408
1409         [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
1410         https://bugs.webkit.org/show_bug.cgi?id=60224
1411
1412         We should use nullptr rather than 0. nullptr will be added in the new C++ standard
1413         but WebKit already has a nullptr class if there is no c++0x support.
1414
1415         * platform/qt/RenderThemeQt.cpp:
1416         (WebCore::RenderThemeQt::adjustProgressBarStyle):
1417         (WebCore::RenderThemeQt::adjustSliderTrackStyle):
1418         (WebCore::RenderThemeQt::adjustSliderThumbStyle):
1419
1420 2011-05-05  Ilya Tikhonovsky  <loislo@chromium.org>
1421
1422         Reviewed by Yury Semikhatsky.
1423
1424         Web Inspector: rename BrowserDebugger to DOMDebugger.
1425
1426         https://bugs.webkit.org/show_bug.cgi?id=60256
1427         InspectorBrowserDebuggerAgent => InspectorDOMDebuggerAgent
1428         browserDebugger => domDebugger
1429
1430         * CMakeLists.txt:
1431         * GNUmakefile.list.am:
1432         * WebCore.gypi:
1433         * WebCore.pro:
1434         * WebCore.vcproj/WebCore.vcproj:
1435         * WebCore.xcodeproj/project.pbxproj:
1436         * inspector/CodeGeneratorInspector.pm:
1437         * inspector/InspectorAgent.cpp:
1438         (WebCore::InspectorAgent::InspectorAgent):
1439         (WebCore::InspectorAgent::inspectedPageDestroyed):
1440         (WebCore::InspectorAgent::disconnectFrontend):
1441         * inspector/InspectorAgent.h:
1442         (WebCore::InspectorAgent::DOMDebuggerAgent):
1443         * inspector/InspectorController.cpp:
1444         (WebCore::InspectorController::connectFrontend):
1445         * inspector/InspectorDOMDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp.
1446         (WebCore::InspectorDOMDebuggerAgent::create):
1447         (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
1448         (WebCore::InspectorDOMDebuggerAgent::~InspectorDOMDebuggerAgent):
1449         (WebCore::InspectorDOMDebuggerAgent::debuggerWasEnabled):
1450         (WebCore::InspectorDOMDebuggerAgent::debuggerWasDisabled):
1451         (WebCore::InspectorDOMDebuggerAgent::disable):
1452         (WebCore::InspectorDOMDebuggerAgent::clearFrontend):
1453         (WebCore::InspectorDOMDebuggerAgent::discardBindings):
1454         (WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
1455         (WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
1456         (WebCore::InspectorDOMDebuggerAgent::didInsertDOMNode):
1457         (WebCore::InspectorDOMDebuggerAgent::didRemoveDOMNode):
1458         (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
1459         (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
1460         (WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
1461         (WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
1462         (WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
1463         (WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
1464         (WebCore::InspectorDOMDebuggerAgent::hasBreakpoint):
1465         (WebCore::InspectorDOMDebuggerAgent::updateSubtreeBreakpoints):
1466         (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
1467         (WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
1468         (WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
1469         (WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
1470         (WebCore::InspectorDOMDebuggerAgent::clear):
1471         * inspector/InspectorDOMDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h.
1472         * inspector/InspectorInstrumentation.cpp:
1473         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
1474         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
1475         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
1476         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
1477         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
1478         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
1479         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
1480         * inspector/InstrumentingAgents.h:
1481         (WebCore::InstrumentingAgents::InstrumentingAgents):
1482         (WebCore::InstrumentingAgents::inspectorDOMDebuggerAgent):
1483         (WebCore::InstrumentingAgents::setInspectorDOMDebuggerAgent):
1484         * inspector/WorkerInspectorController.cpp:
1485         (WebCore::WorkerInspectorController::connectFrontend):
1486
1487 2011-05-04  Yury Semikhatsky  <yurys@chromium.org>
1488
1489         Reviewed by Pavel Feldman.
1490
1491         Web Inspector: show only Console and Scripts panels in worker inspector front-end
1492         https://bugs.webkit.org/show_bug.cgi?id=60159
1493
1494         * inspector/front-end/WorkerManager.js:
1495         (WebInspector.WorkerManager.isWorkerFrontend):
1496         * inspector/front-end/inspector.js: show only Scripts and Console panels in the worker inspector front-end.
1497
1498 2011-05-03  Hans Wennborg  <hans@chromium.org>
1499
1500         Reviewed by Steve Block.
1501
1502         IndexedDB: Unit tests for LevelDB key coding functions
1503         https://bugs.webkit.org/show_bug.cgi?id=59692
1504
1505         Fix some embarrassing bugs uncovered by unit tests.
1506
1507         No new functionality, but this is now covered by unit tests in the Chromium WebKit port.
1508
1509         * storage/IDBLevelDBCoding.cpp:
1510         (WebCore::IDBLevelDBCoding::decodeInt):
1511         (WebCore::IDBLevelDBCoding::decodeVarInt):
1512
1513 2011-05-05  Young Han Lee  <joybro@company100.net>
1514
1515         Reviewed by Csaba Osztrogonác.
1516
1517         [Texmap][Qt] Enable strict OwnPtr for Qt with texmap enabled.
1518         https://bugs.webkit.org/show_bug.cgi?id=60251
1519
1520         No new tests. Build fix.
1521
1522         * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
1523         (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
1524
1525 2011-05-04  Jay Civelli  <jcivelli@chromium.org>
1526
1527         Reviewed by Adam Barth.
1528
1529         Adding a utility class to read a SharedBuffer line by line.
1530         https://bugs.webkit.org/show_bug.cgi?id=59946
1531
1532         * CMakeLists.txt:
1533         * GNUmakefile.list.am:
1534         * WebCore.gypi:
1535         * WebCore.pro:
1536         * WebCore.vcproj/WebCore.vcproj:
1537         * WebCore.xcodeproj/project.pbxproj:
1538         * platform/SharedBufferCRLFLineReader.cpp: Added.
1539         * platform/SharedBufferCRLFLineReader.h: Added.
1540
1541 2011-05-04  Sheriff Bot  <webkit.review.bot@gmail.com>
1542
1543         Unreviewed, rolling out r85788.
1544         http://trac.webkit.org/changeset/85788
1545         https://bugs.webkit.org/show_bug.cgi?id=60250
1546
1547         svg/text/text-block-child-crash.xhtml asserts (Requested by
1548         Ossy on #webkit).
1549
1550         * css/CSSStyleSelector.cpp:
1551         (WebCore::CSSStyleSelector::applyProperty):
1552
1553 2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>
1554
1555         Reviewed by Eric Seidel.
1556
1557         Make more member functions in EventHandler private
1558         https://bugs.webkit.org/show_bug.cgi?id=60200
1559
1560         Reduced the number of public member functions in EventHandler.
1561
1562         * WebCore.exp.in:
1563         * page/EventHandler.cpp:
1564         (WebCore::EventHandler::handleAutoscroll):
1565         (WebCore::EventHandler::autoscrollTimerFired):
1566         (WebCore::EventHandler::stopAutoscrollTimer):
1567         (WebCore::EventHandler::handleMousePressEvent):
1568         (WebCore::EventHandler::handleMouseMoveEvent):
1569         (WebCore::EventHandler::keyEvent):
1570         (WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):
1571         * page/EventHandler.h:
1572         (WebCore::EventHandler::mouseDownMayStartSelect):
1573
1574 2011-05-04  James Robinson  <jamesr@chromium.org>
1575
1576         Reviewed by Kenneth Russell.
1577
1578         [chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
1579         https://bugs.webkit.org/show_bug.cgi?id=60202
1580
1581         In r85136 I accidentally transposed two lines in GraphicsLayerChromium when adding a null check.  This switches
1582         the order back and adds a regression test.
1583
1584         Test: compositing/repaint/transform-style-change.html
1585
1586         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1587         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1588
1589 2011-05-04  Cris Neckar  <cdn@chromium.org>
1590
1591         Reviewed by Adam Barth.
1592
1593         Expose WebView directly through ChromeClient.
1594         https://bugs.webkit.org/show_bug.cgi?id=49902
1595
1596         Test: fast/media/media-svg-crash.html
1597
1598         * loader/EmptyClients.h:
1599         (WebCore::EmptyChromeClient::webView):
1600         * page/ChromeClient.h:
1601         * page/brew/ChromeClientBrew.h:
1602         (WebCore::ChromeClientBrew::webView):
1603
1604 2011-05-04  Joseph Pecoraro  <joepeck@webkit.org>
1605
1606         Reviewed by Darin Adler.
1607
1608         Unable to Paste After Deleting Text from Input due to -webkit-user-select
1609         https://bugs.webkit.org/show_bug.cgi?id=60219
1610
1611         When deleting all the text inside the input a placeholder <br>
1612         element was inserted for the selection point. However, when
1613         pasting, the test run computes the -webkit-user-select for the
1614         <br> element, instead of what would be the text inside the
1615         <input> and incorrectly disallows selection and prevented
1616         the paste.
1617
1618         Test: editing/pasteboard/paste-placeholder-input.html
1619
1620         * editing/ReplaceSelectionCommand.cpp:
1621         (WebCore::ReplacementFragment::insertFragmentForTestRendering): skip
1622         <br> elements above us as those are likely placeholder elements.
1623
1624 2011-05-04  Fridrich Strba  <fridrich.strba@bluewin.ch>
1625
1626         Reviewed by Martin Robinson.
1627
1628         Windows build of WebKit GTK needs to be able to find SystemInfo.h
1629         https://bugs.webkit.org/show_bug.cgi?id=60221
1630
1631         * GNUmakefile.am: add Source/WebCore/platform/win to the paths searched
1632         for headers, since Source/WebCore/platform/win/SystemInfo.h
1633         header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp
1634         on Windows.
1635
1636 2011-05-04  Vangelis Kokkevis  <vangelis@chromium.org>
1637
1638         Reviewed by Kenneth Russell.
1639
1640         [chromium] Improve sorting of layers in hierarchies that preserve-3d
1641         by testing for overlapping regions between layer pairs and doing a
1642         topological sort to determine the right order.
1643         https://bugs.webkit.org/show_bug.cgi?id=59255
1644
1645         Test: platform/chromium/compositing/perpendicular-layer-sorting.html
1646
1647         * WebCore.gypi:
1648         * platform/graphics/chromium/LayerRendererChromium.cpp:
1649         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1650         * platform/graphics/chromium/LayerRendererChromium.h:
1651         * platform/graphics/chromium/cc/CCLayerImpl.h:
1652         (WebCore::CCLayerImpl::clearRenderSurface):
1653         * platform/graphics/chromium/cc/CCLayerSorter.cpp: Added.
1654         (WebCore::perpProduct):
1655         (WebCore::innerProduct):
1656         (WebCore::pointInColinearEdge):
1657         (WebCore::edgeEdgeTest):
1658         (WebCore::CCLayerSorter::LayerIntersector::LayerIntersector):
1659         (WebCore::CCLayerSorter::LayerIntersector::go):
1660         (WebCore::CCLayerSorter::LayerIntersector::edgeTriangleTest):
1661         (WebCore::CCLayerSorter::LayerIntersector::triangleTriangleTest):
1662         (WebCore::CCLayerSorter::LayerIntersector::checkZDiff):
1663         (WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint):
1664         (WebCore::CCLayerSorter::CCLayerSorter):
1665         (WebCore::CCLayerSorter::checkOverlap):
1666         (WebCore::CCLayerSorter::createGraphNodes):
1667         (WebCore::CCLayerSorter::createGraphEdges):
1668         (WebCore::CCLayerSorter::removeEdgeFromList):
1669         (WebCore::CCLayerSorter::sort):
1670         * platform/graphics/chromium/cc/CCLayerSorter.h: Added.
1671         (WebCore::CCLayerSorter::GraphNode::GraphNode):
1672         (WebCore::CCLayerSorter::GraphEdge::GraphEdge):
1673
1674 2011-05-03  Jer Noble  <jer.noble@apple.com>
1675
1676         Reviewed by Antti Koivisto.
1677
1678         Safari: Video at apple.com cannot play at full screen mode with layout distortion
1679         https://bugs.webkit.org/show_bug.cgi?id=60140
1680
1681         Because a fullscreen element may be in a stacking context with a lower z-index than
1682         a sibling stacking context, those higher contexts would sometimes "pop" through the 
1683         full screen renderer. To facilitate eliminating all the stacking contexts aside from
1684         the full screen renderer, added a new pseudo-class specific to video or audio full
1685         screen elements. Then, added a new UA rule which resets the z-index and opacities of 
1686         all elements under said pseudo-class to auto and 1 respectively. To facilitate quick
1687         identity checking of HTMLMediaElements, added isMediaElement() virtual function to 
1688         Element and HTMLMediaElement. 
1689
1690         Test: fullscreen/full-screen-stacking-context.html
1691
1692         * css/CSSSelector.cpp:
1693         (WebCore::CSSSelector::pseudoId): Support PseudoFullScreenMediaDocument.
1694         (WebCore::nameToPseudoTypeMap): Support fullScreenMediaDocument.
1695         (WebCore::CSSSelector::extractPseudoType): Support PseudoFullScreenMediaDocument.
1696         * css/CSSSelector.h: Add PseudoFullScreenMediaDocument.
1697         * css/CSSStyleSelector.cpp:
1698         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Support PseudoFullScreenMediaDocument.
1699         * css/fullscreen.css:
1700         (:root:-webkit-full-screen-document:not(:-webkit-full-screen)): Corrected these names, 
1701             which were missing the -webkit prefix.
1702         (:root:-webkit-full-screen-media-document *:not(-webkit-full-screen)): Added.
1703         * dom/Element.h:
1704         (WebCore::Element::isMediaElement): Added, returns false.
1705         * html/HTMLMediaElement.h:
1706         (WebCore::HTMLMediaElement::isMediaElement): Added, returns true.
1707         * rendering/style/RenderStyleConstants.h: Added FULL_SCREEN_MEDIA_DOCUMENT.
1708
1709 2011-05-04  Levi Weintraub  <leviw@chromium.org>
1710
1711         Reviewed by Eric Seidel.
1712
1713         Split findNextLineBreak into a LineBreaker class
1714         https://bugs.webkit.org/show_bug.cgi?id=60209
1715
1716         Breaking findNextLineBreak into a new class inside RenderBlock. Currently it's tracking
1717         nearly no state, but subsequent patches will move some of the local variables used throughout
1718         the nextLineBreak function into member variables to simplify breaking off helper functions from
1719         the bloated function.
1720
1721         No new tests since this is just moving code around.
1722
1723         * WebCore.xcodeproj/project.pbxproj:
1724         * rendering/RenderBlock.h:
1725         (WebCore::RenderBlock::LineBreaker::LineBreaker):
1726         (WebCore::RenderBlock::LineBreaker::lineWasHyphenated): Accessor.
1727         (WebCore::RenderBlock::LineBreaker::positionedObjects): Ditto.
1728         (WebCore::RenderBlock::LineBreaker::clear): Ditto.
1729         * rendering/RenderBlockLineLayout.cpp:
1730         (WebCore::RenderBlock::layoutRunsAndFloats):
1731         (WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace):
1732         (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
1733         (WebCore::RenderBlock::LineBreaker::reset):
1734         (WebCore::RenderBlock::LineBreaker::nextLineBreak):
1735
1736 2011-05-04  Fridrich Strba  <fridrich.strba@bluewin.ch>
1737
1738         Reviewed by Adam Barth.
1739
1740         Add COMPILER(MINGW) to the compilers using the Microsoft C Runtime's vsnprintf.
1741         The vsnprintf is part of Microsoft C runtime used also by MinGW (GCC) toolchain.
1742         https://bugs.webkit.org/show_bug.cgi?id=58579
1743
1744         * dom/XMLDocumentParserLibxml2.cpp:
1745         (WebCore::XMLDocumentParser::error):
1746
1747 2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>
1748
1749         Unreviewed warning fix.
1750
1751         The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
1752         a warning in Release build.
1753
1754         * dom/Node.cpp:
1755         (WebCore::Node::removeEventListener):
1756         * platform/DateComponents.cpp:
1757         (WebCore::DateComponents::parseTime):
1758         * rendering/RenderLayer.cpp:
1759         (WebCore::RenderLayer::convertToLayerCoords):
1760         * storage/StorageMap.cpp:
1761         (WebCore::StorageMap::importItem):
1762         * svg/SVGUseElement.cpp:
1763         (WebCore::SVGUseElement::buildShadowTree):
1764         (WebCore::SVGUseElement::expandUseElementsInShadowTree):
1765
1766 2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>
1767
1768         Unreviewed warning fix.
1769
1770         The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
1771         a warning in Release build.
1772
1773         * accessibility/AccessibilityRenderObject.cpp:
1774         (WebCore::lastChildConsideringContinuation):
1775
1776 2011-05-04  Dimitri Glazkov  <dglazkov@chromium.org>
1777
1778         Sort xcodeproj files.
1779
1780         The WebCore.xcodeproj got out of sorts again.
1781
1782         * WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
1783
1784 2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>
1785
1786         Reviewed by Adam Barth.
1787
1788         Warning fix.
1789
1790         * bindings/js/DOMObjectHashTableMap.h:
1791         (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
1792
1793 2011-05-04  Rob Buis  <rbuis@rim.com>
1794
1795         Reviewed by Darin Adler.
1796
1797         NULL deref when SVG elements have table styles 
1798         https://bugs.webkit.org/show_bug.cgi?id=45561
1799
1800         Restrict computed CSS values for SVG display property to block, inline or none.
1801
1802         Tests: svg/custom/display-table-caption-foreignObject.svg
1803                svg/custom/display-table-caption-inherit-foreignObject.xhtml
1804                svg/custom/display-table-caption-inherit-text.xhtml
1805                svg/custom/display-table-caption-text.svg
1806
1807         * css/CSSStyleSelector.cpp:
1808         (WebCore::CSSStyleSelector::applyProperty):
1809
1810 2011-05-04  Tao Bai  <michaelbai@chromium.org>
1811
1812         Reviewed by David Kilzer.
1813
1814         Populate touch-icon url to FrameLoaderClient
1815         https://bugs.webkit.org/show_bug.cgi?id=59143
1816         
1817         Parsed and populated apple-touch-icon url to FrameLoaderClient.
1818         Changed favicon to be a type of icon.
1819
1820         * CMakeLists.txt:
1821         * Configurations/FeatureDefines.xcconfig:
1822         * GNUmakefile.am:
1823         * GNUmakefile.list.am:
1824         * WebCore.gypi:
1825         * WebCore.vcproj/WebCore.vcproj:
1826         * WebCore.xcodeproj/project.pbxproj:
1827         * dom/Document.cpp:
1828         (WebCore::Document::iconURL):
1829         (WebCore::Document::setIconURL):
1830         * dom/Document.h:
1831         * dom/IconURL.cpp: Added.
1832         (WebCore::toIconIndex):
1833         * dom/IconURL.h: Added.
1834         (WebCore::IconURL::IconURL):
1835         * features.pri:
1836         * html/HTMLLinkElement.cpp:
1837         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
1838         (WebCore::HTMLLinkElement::process):
1839         (WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
1840         * html/HTMLLinkElement.h:
1841         (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
1842         (WebCore::HTMLLinkElement::isEnabledViaScript):
1843         * html/parser/HTMLPreloadScanner.cpp:
1844         (WebCore::HTMLNames::PreloadTask::relAttributeIsStyleSheet):
1845         * loader/DocumentLoader.cpp:
1846         (WebCore::DocumentLoader::iconURL):
1847         (WebCore::DocumentLoader::setIconURL):
1848         * loader/DocumentLoader.h:
1849         * loader/EmptyClients.h:
1850         (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
1851         * loader/FrameLoader.cpp:
1852         (WebCore::FrameLoader::iconURL):
1853         (WebCore::FrameLoader::iconURLs):
1854         (WebCore::FrameLoader::fillIconURL):
1855         (WebCore::FrameLoader::getDefaultIconURL):
1856         (WebCore::FrameLoader::setIconURL):
1857         (WebCore::FrameLoader::didChangeIcons):
1858         * loader/FrameLoader.h:
1859         * loader/FrameLoaderClient.h:
1860
1861 2011-05-04  Chris Marrin  <cmarrin@apple.com>
1862
1863         Reviewed by Simon Fraser.
1864
1865         Crash in PlatformCALayer ::replaceSublayer when layer has not superlayer
1866         https://bugs.webkit.org/show_bug.cgi?id=60191
1867
1868         Skip replaceSublayer when there is no superlayer rather than asserting.
1869         This is probably not a problem and happens when restructuring the layer
1870         tree. Avoiding this crash will allow us to get more testing.
1871
1872         * platform/graphics/ca/GraphicsLayerCA.cpp:
1873         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
1874
1875 2011-05-04  Martin Robinson  <mrobinson@igalia.com>
1876
1877         Reviewed by Gustavo Noronha Silva.
1878
1879         Fix the GTK+ 2.x build for Windows. Instead of making getStockIcon a RenderTheme
1880         method, just use extern declarations to avoid having to declare it in the header.
1881         This will prevent having to include glib.h in RenderThemeGtk.h, which is included
1882         in many C++ files.
1883
1884         No new tests. This is just a build fix.
1885
1886         * platform/gtk/RenderThemeGtk.cpp: Update getStockIcon calls to say getStockIconForWidgetType.
1887         (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
1888         (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
1889         (WebCore::RenderThemeGtk::paintCapsLockIndicator):
1890         (WebCore::RenderThemeGtk::paintMediaButton):
1891         * platform/gtk/RenderThemeGtk.h: Removed getStockIcon declaration. Make gtkContainer() and
1892         gtkEntry() public because they are now accessed externally from getStockIcon().
1893         * platform/gtk/RenderThemeGtk2.cpp: Update getStockIcon calls.
1894         (WebCore::getStockIconForWidgetType):
1895         * platform/gtk/RenderThemeGtk3.cpp: Ditto.
1896         (WebCore::getStockIconForWidgetType):
1897
1898 2011-05-04  Mark Pilgrim  <pilgrim@chromium.org>
1899
1900         Reviewed by Tony Chang.
1901
1902         IndexedDB open (database) should fail if name is null
1903         https://bugs.webkit.org/show_bug.cgi?id=60022
1904
1905         Test: storage/indexeddb/mozilla/open-database-null-name.html
1906
1907         Combination problem: Bug in IDL didn't pass null values to .cpp layer,
1908         then .cpp layer didn't check for null value anyway.
1909
1910         * storage/IDBFactory.cpp:
1911         (WebCore::IDBFactory::open): check for null name
1912         * storage/IDBFactory.idl: pass null name as null
1913
1914 2011-05-04  Jer Noble  <jer.noble@apple.com>
1915
1916         Reviewed by Darin Adler.
1917
1918         Entering full screen fails >= second time on Vimeo.com.
1919         https://bugs.webkit.org/show_bug.cgi?id=60143
1920
1921         Force the RenderFullScreen's layer backing to be recreated when setAnimating() is called.
1922         Previously, the RenderLayerCompositor would fail to reparent the RenderFullScreen's layer
1923         at the end of an animation, if it determined that the RenderFullScreen would still require
1924         a layer even when not animating.
1925
1926         * rendering/RenderFullScreen.cpp:
1927         (RenderFullScreen::setAnimating): Clear the renderer's layer.
1928
1929 2011-05-04  Simon Fraser  <simon.fraser@apple.com>
1930
1931         Reviewed by Darin Adler.
1932
1933         Avoid allocating a new image buffer in ~CanvasRenderingContext2D()
1934         https://bugs.webkit.org/show_bug.cgi?id=59849
1935
1936         When attempting to unwind the graphics state stack in the
1937         CanvasRenderingContext2D destructor, don't allow HTMLCanvasElement
1938         to create a new ImageBuffer.
1939
1940         * html/HTMLCanvasElement.cpp:
1941         (WebCore::HTMLCanvasElement::existingDrawingContext):
1942         * html/HTMLCanvasElement.h:
1943         * html/canvas/CanvasRenderingContext2D.cpp:
1944         (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
1945
1946 2011-05-04  Andrey Kosyakov  <caseq@chromium.org>
1947
1948         Reviewed by Yury Semikhatsky.
1949
1950         Web Inspector: expose shadow DOM in the Elements panel
1951         https://bugs.webkit.org/show_bug.cgi?id=60160
1952
1953         Test: inspector/elements/shadow-dom.html
1954
1955         * dom/Element.cpp:
1956         (WebCore::Element::ensureShadowRoot):
1957         (WebCore::Element::removeShadowRoot):
1958         * inspector/Inspector.json:
1959         * inspector/InspectorDOMAgent.cpp:
1960         (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
1961         (WebCore::InspectorDOMAgent::buildObjectForNode):
1962         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1963         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1964         (WebCore::InspectorDOMAgent::isContainerNode):
1965         * inspector/InspectorDOMAgent.h:
1966         * inspector/front-end/DOMAgent.js:
1967         (WebInspector.DOMNode):
1968         (WebInspector.DOMNode.prototype.inShadowTree):
1969         (WebInspector.DOMNode.prototype._setShadowRootPayload):
1970         (WebInspector.DOMNode.prototype._renumber):
1971         (WebInspector.DOMAgent.prototype._bindNodes):
1972         (WebInspector.DOMAgent.prototype.querySelectorAll):
1973         (WebInspector.DOMAgent.prototype._shadowRootUpdated):
1974         (WebInspector.DOMDispatcher.prototype.searchResults):
1975         (WebInspector.DOMDispatcher.prototype.shadowRootUpdated):
1976         * inspector/front-end/ElementsPanel.js:
1977         (WebInspector.ElementsPanel):
1978         (WebInspector.ElementsPanel.prototype._nodeUpdated):
1979         (WebInspector.ElementsPanel.prototype._attributesUpdated):
1980         (WebInspector.ElementsPanel.prototype._nodeRemoved):
1981         (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
1982         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
1983         * inspector/front-end/ElementsTreeOutline.js:
1984         (WebInspector.ElementsTreeElement):
1985         (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
1986         (WebInspector.ElementsTreeElement.prototype._updateChildren):
1987         ():
1988         * inspector/front-end/inspector.css:
1989         (#elements-content .dom-shadow-root):
1990         (.outline-disclosure li .webkit-html-tag.shadow):
1991         * inspector/front-end/utilities.js:
1992
1993 2011-05-03  Adam Roben  <aroben@apple.com>
1994
1995         Remove an unnecessary OwnPtr equality check in XSLT code
1996
1997         Fixes <http://webkit.org/b/60053> Testing OwnPtrs for equality should cause a compiler error
1998
1999         Reviewed by Anders Carlsson and Antti Koivisto.
2000
2001         * dom/Document.cpp:
2002         (WebCore::Document::setTransformSource): No need to check for equality. If the pointers are
2003         equal, we're screwed anyway. (And the caller always passes in a newly-allocated object, so
2004         we're safe.)
2005
2006 2011-05-04  Leandro Gracia Gil  <leandrogracia@chromium.org>
2007
2008         Reviewed by Tony Gentilcore.
2009
2010         Media Stream API: add the skeleton of the frame and page controllers and the embedder client.
2011         https://bugs.webkit.org/show_bug.cgi?id=56922
2012
2013         Add the basic outlines of the page controller, the per-frame controller and the embedder
2014         client interface for the Media Stream API. Provide methods to handle the situations
2015         where a frame is detached from the page or transferred between pages.
2016
2017         Tests for the Media Stream API will be provided by the bug 56587.
2018
2019         * CMakeLists.txt:
2020         * GNUmakefile.list.am:
2021         * WebCore.gypi:
2022         * WebCore.pro:
2023         * WebCore.vcproj/WebCore.vcproj:
2024         * WebCore.xcodeproj/project.pbxproj:
2025         * page/Frame.cpp:
2026         (WebCore::Frame::Frame):
2027         (WebCore::Frame::~Frame):
2028         (WebCore::Frame::pageDestroyed):
2029         (WebCore::Frame::transferChildFrameToNewDocument):
2030         * page/Frame.h:
2031         (WebCore::Frame::mediaStreamFrameController):
2032         * page/MediaStreamClient.h: Added.
2033         (WebCore::MediaStreamClient::~MediaStreamClient):
2034         * page/MediaStreamController.cpp: Added.
2035         (WebCore::MediaStreamController::Request::Request):
2036         (WebCore::MediaStreamController::Request::localId):
2037         (WebCore::MediaStreamController::Request::frameController):
2038         (WebCore::MediaStreamController::MediaStreamController):
2039         (WebCore::MediaStreamController::~MediaStreamController):
2040         (WebCore::MediaStreamController::unregisterFrameController):
2041         (WebCore::MediaStreamController::registerRequest):
2042         * page/MediaStreamController.h: Added.
2043         * page/MediaStreamFrameController.cpp: Added.
2044         (WebCore::MediaStreamFrameController::Request::Request):
2045         (WebCore::MediaStreamFrameController::Request::~Request):
2046         (WebCore::MediaStreamFrameController::Request::scriptExecutionContext):
2047         (WebCore::MediaStreamFrameController::Request::isGenerateStreamRequest):
2048         (WebCore::MediaStreamFrameController::Request::isRecordedDataRequest):
2049         (WebCore::MediaStreamFrameController::RequestMap::abort):
2050         (WebCore::MediaStreamFrameController::RequestMap::abortAll):
2051         (WebCore::MediaStreamFrameController::MediaStreamFrameController):
2052         (WebCore::MediaStreamFrameController::~MediaStreamFrameController):
2053         (WebCore::MediaStreamFrameController::securityOrigin):
2054         (WebCore::MediaStreamFrameController::scriptExecutionContext):
2055         (WebCore::MediaStreamFrameController::pageController):
2056         (WebCore::MediaStreamFrameController::enterDetachedState):
2057         (WebCore::MediaStreamFrameController::disconnectPage):
2058         (WebCore::MediaStreamFrameController::disconnectFrame):
2059         (WebCore::MediaStreamFrameController::transferToNewPage):
2060         * page/MediaStreamFrameController.h: Added.
2061         * page/Page.cpp:
2062         (WebCore::Page::Page):
2063         (WebCore::Page::PageClients::PageClients):
2064         * page/Page.h:
2065         (WebCore::Page::mediaStreamController):
2066
2067 2011-05-04  Alexander Pavlov  <apavlov@chromium.org>
2068
2069         Reviewed by Yury Semikhatsky.
2070
2071         Web Inspector: Double-click in a read-only style rule results in a non-editable blank property
2072         https://bugs.webkit.org/show_bug.cgi?id=60150
2073
2074         * inspector/front-end/StylesSidebarPane.js:
2075         (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):
2076
2077 2011-05-04  Dominic Battre  <battre@chromium.org>
2078
2079         Reviewed by Tony Gentilcore.
2080
2081         Fix missing header in case SVG is disabled
2082         https://bugs.webkit.org/show_bug.cgi?id=60153
2083
2084         * dom/EventDispatcher.cpp:
2085
2086 2011-05-04  Luke Macpherson   <macpherson@chromium.org>
2087
2088         Reviewed by Eric Seidel.
2089
2090         Rename CSSStyleApplyProperty::propertyValue and setPropertyValue.
2091         https://bugs.webkit.org/show_bug.cgi?id=60006
2092
2093         No new tests as no functionality added. Simple rename only.
2094
2095         * css/CSSStyleApplyProperty.cpp:
2096         Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
2097         * css/CSSStyleApplyProperty.h:
2098         Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
2099
2100 2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>
2101
2102         Reviewed by Eric Seidel.
2103
2104         Cleanup conditionals in findNextLineBreak
2105         https://bugs.webkit.org/show_bug.cgi?id=60117
2106
2107         Simplified conditional statements in findNextLineBreak.
2108
2109         * rendering/RenderBlockLineLayout.cpp:
2110         (WebCore::RenderBlock::findNextLineBreak):
2111
2112 2011-05-04  Luke Macpherson   <macpherson@chromium.org>
2113
2114         Reviewed by Eric Seidel.
2115
2116         Make CSSStyleSelector::applyProperty() CSSPropertyWebkitHyphens case use appropriate macro.
2117         https://bugs.webkit.org/show_bug.cgi?id=60114
2118
2119         No new tests as no functionality changes.
2120
2121         * css/CSSStyleSelector.cpp:
2122         (WebCore::CSSStyleSelector::applyProperty):
2123         Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to remove code duplication.
2124
2125 2011-05-04  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2126
2127         Reviewed by Andreas Kling.
2128
2129         [Qt] Fix QNetworkReplyWrapper to not depend on QNetworkReply::isFinished() method
2130         https://bugs.webkit.org/show_bug.cgi?id=59070
2131
2132         Applications using our API and our autotests subclass QNetworkReply as part of providing a
2133         custom QNetworkAccessManager. But there's an API limitation in Qt 4.7, that makes
2134         QNetworkReply::isFinished() always be false for these custom replies. This was fixed in Qt
2135         4.8, see http://bugreports.qt.nokia.com/browse/QTBUG-11737.
2136
2137         The consequence is that QtWebKit cannot rely on this function. So now QNetworkReplyWrapper
2138         watches for the finished() signal and set a dynamic property "_q_isFinished" on the reply
2139         indicating that it is finished. When there's no finished signal (synchronous) we set the
2140         dynamic property once we get the reply.
2141
2142         This fixes tst_QWebFrame::requestedUrl(), that was breaking because sniffer was not
2143         emitting its own finished() signal, causing QWebFrame::loadFinished() to not be emitted.
2144
2145         * platform/network/qt/QNetworkReplyHandler.cpp:
2146         (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
2147         Connect the finished signal to the new setFinished() slot.
2148
2149         (WebCore::QNetworkReplyWrapper::synchronousLoad):
2150         Since we don't get the finished signal for synchronous loads, set the dynamic property
2151         before processing it.
2152
2153         (WebCore::QNetworkReplyWrapper::resetConnections):
2154         Do not reset the connection to setFinished().
2155
2156         (WebCore::QNetworkReplyWrapper::setFinished):
2157         Set the dynamic property in the reply.
2158
2159         (WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
2160         (WebCore::QNetworkReplyHandler::start):
2161         Change to use wrapper's isFinished() instead of asking the reply directly.
2162
2163         * platform/network/qt/QNetworkReplyHandler.h:
2164         (WebCore::QNetworkReplyWrapper::isFinished):
2165         Checks the dynamic property of the reply.
2166
2167         * platform/network/qt/QtMIMETypeSniffer.cpp:
2168         (QtMIMETypeSniffer::sniff):
2169         Use the dynamic property to check if the reply is finished.
2170
2171 2011-05-04  Eric Seidel  <eric@webkit.org>
2172
2173         Reviewed by Ryosuke Niwa.
2174
2175         Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
2176         https://bugs.webkit.org/show_bug.cgi?id=60080
2177
2178         No functional change, just moving code.
2179
2180         * rendering/RenderBlock.h:
2181         * rendering/RenderBlockLineLayout.cpp:
2182         (WebCore::RenderBlock::createLineBoxesFromBidiRuns):
2183         (WebCore::RenderBlock::layoutRunsAndFloats):
2184
2185 2011-05-04  Andreas Kling  <andreas.kling@nokia.com>
2186
2187         Reviewed by Kenneth Rohde Christiansen.
2188
2189         [Qt] Remove unused function FontPlatformData::pixelSize()
2190         https://bugs.webkit.org/show_bug.cgi?id=60156
2191
2192         * platform/graphics/qt/FontPlatformData.h:
2193         (WebCore::FontPlatformData::pixelSize): Removed.
2194
2195 2011-05-04  Luke Macpherson   <macpherson@chromium.org>
2196
2197         Reviewed by Darin Adler.
2198
2199         Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty()
2200         https://bugs.webkit.org/show_bug.cgi?id=60011
2201
2202         No new tests added as no functionality changed.
2203
2204         * css/CSSStyleSelector.cpp:
2205         (WebCore::CSSStyleSelector::applyProperty):
2206         Remove reundant check for auto table layout.
2207
2208 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
2209
2210         Reviewed by Darin Adler.
2211
2212         Remove double-free checks for bug 56124
2213         https://bugs.webkit.org/show_bug.cgi?id=60037
2214
2215         Antti's speculative fix for bug 56124 (r84151) appears to have worked,
2216         these CRASH() calls are not triggering anymore.
2217
2218         * css/CSSSelector.h:
2219         (WebCore::CSSSelector::CSSSelector):
2220         (WebCore::CSSSelector::~CSSSelector):
2221         * css/CSSSelectorList.cpp:
2222         (WebCore::CSSSelectorList::deleteSelectors):
2223
2224 2011-05-04  Satish Sampath  <satish@chromium.org>
2225
2226         Reviewed by Tony Gentilcore.
2227
2228         Layout the speech input button to the left of outer spin button properly.
2229         https://bugs.webkit.org/show_bug.cgi?id=59742
2230
2231         * rendering/RenderTextControlSingleLine.cpp:
2232         (WebCore::RenderTextControlSingleLine::layout):
2233
2234 2011-05-04  Yury Semikhatsky  <yurys@chromium.org>
2235
2236         Unreviewed. Build fix.
2237
2238         * bindings/js/JSInjectedScriptHostCustom.cpp: fix includes declaration
2239
2240 2011-05-03  Yury Semikhatsky  <yurys@chromium.org>
2241
2242         Reviewed by Pavel Feldman.
2243
2244         Web Inspector: can't inspect element in an iframe when element originates from non-frame document
2245         https://bugs.webkit.org/show_bug.cgi?id=60031
2246         
2247         Inspected object type evaluation has moved into native bindings. This way it doesn't
2248         depend on the current JS context.
2249
2250         Test: inspector/elements/elements-inspect-iframe-from-different-domain.html
2251
2252         * bindings/js/JSInjectedScriptHostCustom.cpp:
2253         (WebCore::JSInjectedScriptHost::isHTMLAllCollection): this method helps distinguish
2254         real undefined values from HTMLAllCollection
2255         (WebCore::JSInjectedScriptHost::type): method that returns presice type of the passed
2256         value
2257         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2258         (WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
2259         (WebCore::V8InjectedScriptHost::typeCallback):
2260         * inspector/InjectedScriptHost.idl:
2261         * inspector/InjectedScriptSource.js:
2262         (.):
2263
2264 2011-05-03  Pratik Solanki  <psolanki@apple.com>
2265
2266         Reviewed by Antti Koivisto.
2267
2268         Part of WebCore should use CFNetwork-based loader on Mac
2269         https://bugs.webkit.org/show_bug.cgi?id=51836
2270
2271         Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one. Clean
2272         up some warnings and #if USE(CFNETWORK) around code.
2273
2274         * platform/mac/CookieJar.mm:
2275         * platform/network/CookieStorage.h:
2276         * platform/network/cf/CookieStorageCFNet.cpp:
2277         (WebCore::privateBrowsingCookieStorage):
2278         (WebCore::currentCookieStorage):
2279         (WebCore::setCurrentCookieStorage):
2280         (WebCore::setCookieStoragePrivateBrowsingEnabled):
2281         (WebCore::notifyCookiesChangedOnMainThread):
2282         (WebCore::notifyCookiesChanged):
2283         * platform/network/cf/CookieStorageCFNet.h:
2284         * platform/network/mac/CookieStorageMac.mm:
2285
2286 2011-05-03  Justin Novosad  <junov@chromium.org>
2287
2288         Reviewed by Kenneth Russell.
2289
2290         [Chromium] Make accelerated 2d canvas enabled by default with skia
2291         https://bugs.webkit.org/show_bug.cgi?id=59929
2292
2293         No new tests. Covered by existing layout tests
2294
2295         * html/canvas/CanvasRenderingContext2D.cpp:
2296         (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
2297         Initialized for accelerated canvas if either the accelerated2dCanvas
2298         or the legacyAccelerated2dCanvas flags are enabled
2299         * page/Page.cpp:
2300         (WebCore::Page::sharedGraphicsContext3D):
2301         This is where the code goes to implement the functionality for the
2302         legacy vs current acceleration paths for the 2D canvas. Currently,
2303         this is a no-op, and always select the legacy path.  This is temporary
2304         until we are ready to sort the GPU layout tests (rebasline vs. bug)
2305         * page/Settings.cpp:  Added new flage for legacyAccelerated2dCanvas
2306         (WebCore::Settings::Settings):
2307         (WebCore::Settings::setLegacyAccelerated2dCanvasEnabled):
2308         * page/Settings.h:
2309         (WebCore::Settings::legacyAccelerated2dCanvasEnabled):
2310
2311 2011-04-29  Jer Noble  <jer.noble@apple.com>
2312
2313         Reviewed by Eric Seidel.
2314
2315         Implement FULLSCREEN_API on Windows, Part 4: Enable it
2316         https://bugs.webkit.org/show_bug.cgi?id=59798
2317
2318         * WebCore.vcproj/WebCore.vcproj: Add missing full screen related
2319             files to the project.
2320
2321 2011-05-03  Alpha Lam  <hclam@chromium.org>
2322
2323         Not reviewed. Build fix.
2324
2325         More places from 0 to nullptr.
2326
2327         * bindings/v8/V8Proxy.cpp:
2328         (WebCore::V8Proxy::precompileScript):
2329         * platform/graphics/chromium/LayerTilerChromium.cpp:
2330         (WebCore::LayerTilerChromium::create):
2331         * platform/graphics/gpu/BicubicShader.cpp:
2332         (WebCore::BicubicShader::create):
2333         * platform/graphics/gpu/ConvolutionShader.cpp:
2334         (WebCore::ConvolutionShader::create):
2335         * platform/graphics/gpu/LoopBlinnSolidFillShader.cpp:
2336         (WebCore::LoopBlinnSolidFillShader::create):
2337         * platform/graphics/gpu/SolidFillShader.cpp:
2338         (WebCore::SolidFillShader::create):
2339         * platform/graphics/gpu/TexShader.cpp:
2340         (WebCore::TexShader::create):
2341         * platform/graphics/skia/PlatformContextSkia.cpp:
2342         (WebCore::PlatformContextSkia::~PlatformContextSkia):
2343         * platform/leveldb/LevelDBDatabase.cpp:
2344         (WebCore::LevelDBDatabase::createIterator):
2345         * platform/text/LocalizedNumberICU.cpp:
2346         (WebCore::createFormatterForCurrentLocale):
2347
2348 2011-05-03  Alpha Lam  <hclam@chromium.org>
2349
2350         Not reviewed. Build fix.
2351
2352         Using nullptr instead of 0. This makes visual studio happy.
2353
2354         * storage/IDBTransactionBackendInterface.h:
2355
2356 2011-05-03  Luke Macpherson   <macpherson@chromium.org>
2357
2358         Reviewed by Dimitri Glazkov.
2359
2360         Add template parameter to ApplyPropertyColor to improve clarity by removing constructor parameter side effects.
2361         https://bugs.webkit.org/show_bug.cgi?id=59774
2362
2363         No new tests required as on new functionality.
2364
2365         * css/CSSStyleApplyProperty.cpp:
2366         (WebCore::ApplyPropertyColor::applyValue):
2367         Added template parameter "inheritColorFromParent = false".
2368         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2369         Use template parameter where appropriate.
2370
2371 2011-05-03  Dan Bernstein  <mitz@apple.com>
2372
2373         Reviewed by Darin Adler.
2374
2375         <rdar://problem/9313186> Make the fix for <rdar://problem/9190108> more robust.
2376
2377         Added a pointer from FloatingObject to its originating line, if there is one, and made sure to
2378         dirty the line when the float is removed, instead of relying on the float always intersecting
2379         its originating line.
2380
2381         * rendering/RenderBlock.cpp:
2382         (WebCore::RenderBlock::removeFloatingObject):
2383         (WebCore::RenderBlock::removeFloatingObjectsBelow):
2384         (WebCore::RenderBlock::clearFloats):
2385         * rendering/RenderBlock.h:
2386         (WebCore::RenderBlock::FloatingObject::FloatingObject):
2387         * rendering/RenderBlockLineLayout.cpp:
2388         (WebCore::RenderBlock::appendFloatingObjectToLastLine):
2389         (WebCore::RenderBlock::layoutRunsAndFloats):
2390         (WebCore::RenderBlock::determineStartPosition):
2391
2392 2011-05-02  Jer Noble  <jer.noble@apple.com>
2393
2394         Reviewed by Adam Roben.
2395
2396         Implement FULLSCREEN_API on Windows, Part 3: WebKit2
2397         https://bugs.webkit.org/show_bug.cgi?id=59845
2398
2399         Move WebFullScreenController into WebCore to facilitate code sharing between WebKit
2400         and WebKit2.  WebFullScreenController now uses a Client class to request work on its
2401         behalf by WebKit and WebKit2.  MediaPlayerPrivateFullscreenWindow now only creates a 
2402         CALayerHost once a root layer is set, as the CALayerHost was causing child window drawing
2403         problems, and because a CALayerHost is overkill if the window is only drawing black to
2404         its client area.
2405
2406         * WebCore.vcproj/WebCore.vcproj:
2407         * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
2408         (WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow): Do not create 
2409             m_layerHost in the constructor.
2410         (WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): NULL check m_layerHost.
2411         (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Lazily instantiate m_layerHost.
2412         (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): NULL check m_layerHost; if a root layer is
2413             not present, fill the window with black in WM_PAINT.
2414         * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
2415         * platform/graphics/win/FullScreenController.cpp: Renamed from Source/WebKit/win/WebFullScreenController.cpp.
2416         * platform/graphics/win/FullScreenController.h: Renamed from Source/WebKit/win/WebFullScreenController.h.
2417         * platform/graphics/win/FullScreenControllerClient.h: Split out from FullScreenController.h
2418         (WebCore::FullScreenControllerClient::~FullScreenControllerClient):
2419
2420 2011-05-03  Brady Eidson  <beidson@apple.com>
2421
2422         Reviewed by Sam Weinig.
2423
2424         https://bugs.webkit.org/show_bug.cgi?id=60087 and <rdar://problem/9373182>
2425         WK2 Icon Database should provide access to all image representations in the icon.
2426
2427         Add an accessor for CG platforms to get a CFArrayRef of all the CGImageRefs represented:
2428         * platform/graphics/BitmapImage.h:
2429         * platform/graphics/Image.h:
2430         (WebCore::Image::getCGImageArray):
2431         * platform/graphics/cg/ImageCG.cpp:
2432         (WebCore::BitmapImage::getCGImageArray):
2433
2434 2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>
2435
2436         Reviewed by Eric Seidel.
2437
2438         findNextLineBreak splits InlineIterator into 3 pieces
2439         https://bugs.webkit.org/show_bug.cgi?id=60082
2440
2441         Avoid splitting InlineIterator into 3 variables with inter-dependencies.
2442
2443         * rendering/InlineIterator.h:
2444         (WebCore::InlineIterator::fastIncrementInTextNode): Added.
2445         (WebCore::InlineIterator::previousInSameNode): Added.
2446         * rendering/RenderBlockLineLayout.cpp:
2447         (WebCore::RenderBlock::findNextLineBreak):
2448
2449 2011-05-03  Dean Jackson  <dino@apple.com>
2450
2451         Reviewed by Simon Fraser.
2452
2453         Interrupted transitions are not correctly removed
2454         https://bugs.webkit.org/show_bug.cgi?id=60062
2455
2456         CompositeAnimation was replacing any existing
2457         transition as a new one was created. However, it wasn't
2458         clearing the lists in AnimationControllerPrivate that
2459         signal when a hardware animation starts. Rather than
2460         simple removing the existing transition, we now tell
2461         AnimationControllerPrivate that is has gone.
2462
2463         Test: transitions/3d/interrupted-transition.html
2464
2465         * page/animation/CompositeAnimation.cpp:
2466         (WebCore::CompositeAnimation::updateTransitions):
2467
2468 2011-05-03  Enrica Casucci  <enrica@apple.com>
2469
2470         Reviewed by Ryosuke Niwa.
2471
2472         Crash in SpellingCorrectionController::respondToChangedSelection.
2473         https://bugs.webkit.org/show_bug.cgi?id=60071
2474         <rdar://problem/9358190>
2475
2476         Creating a Visible position could trigger a layout and there is no
2477         guarantee that the selection is still valid after that.
2478
2479         Tests: editing/selection/undo-crash.html
2480
2481         * editing/SpellingCorrectionController.cpp:
2482         (WebCore::SpellingCorrectionController::respondToChangedSelection):
2483
2484 2011-05-03  Levi Weintraub  <leviw@chromium.org>
2485
2486         Reviewed by Eric Seidel.
2487
2488         Refactor computeInlineDirectionPositionsForLine into smaller functions
2489         https://bugs.webkit.org/show_bug.cgi?id=60072
2490
2491         Split three functions off from computeInlineDirectionPositionsForLine
2492         to improve its readability.
2493
2494         No new tests since this is just moving code around.
2495
2496         * rendering/RenderBlock.h:
2497         * rendering/RenderBlockLineLayout.cpp:
2498         (WebCore::RenderBlock::setMarginsForRubyRun):
2499         (WebCore::setLogicalWidthForTextRun):
2500         (WebCore::computeExpansionForJustifiedText):
2501         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
2502
2503 2011-05-03  David Kilzer  <ddkilzer@apple.com>
2504
2505         <http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
2506
2507         Reviewed by Antti Koivisto.
2508
2509         * platform/network/cf/ResourceRequestCFNet.cpp:
2510         (WebCore::ResourceRequest::doUpdatePlatformRequest): Set the
2511         priority on the request if HTTP pipelining is enabled.
2512         (WebCore::ResourceRequest::doUpdateResourceRequest): Read the
2513         priority from the request if HTTP pipelining is enabled.
2514         (readBooleanPreference): Enable code when compiling with
2515         USE(CFNETWORK).
2516         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Ditto.
2517         Comment out setting the minimum fast lane priority on Windows
2518         since it's not currently available.
2519
2520 2011-05-03  Simon Fraser  <simon.fraser@apple.com>
2521
2522         Reviewed by Dan Bernstein.
2523
2524         <rdar://problem/9278296> Flicker zooming on Google Maps satellite view with accelerated compositing turned on
2525
2526         Conditionalize compositing tiled layer size-constraining logic to older
2527         OSes.
2528
2529         * platform/graphics/ca/GraphicsLayerCA.cpp:
2530         (WebCore::GraphicsLayerCA::constrainedSize):
2531
2532 2011-05-03  Roland Steiner  <rolandsteiner@chromium.org>
2533
2534         Reviewed by Dimitri Glazkov.
2535
2536         Allow access keys to be used in shadow DOM
2537         https://bugs.webkit.org/show_bug.cgi?id=59979
2538
2539         Move access key methods and members back to Document from TreeScope.
2540         Also traverse into shadow trees when building the access key map.
2541
2542         No new tests. (refactoring)
2543
2544         * dom/Document.cpp:
2545         (WebCore::Document::Document):
2546         (WebCore::Document::getElementByAccessKey):
2547         (WebCore::Document::buildAccessKeyMap):
2548         (WebCore::Document::invalidateAccessKeyMap):
2549         * dom/Document.h:
2550         * dom/TreeScope.cpp:
2551         (WebCore::TreeScope::TreeScope):
2552         (WebCore::TreeScope::destroyTreeScopeData):
2553         * dom/TreeScope.h:
2554
2555 2011-05-03  Dan Bernstein  <mitz@apple.com>
2556
2557         Reviewed by Darin Adler.
2558
2559         <rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical or flipped text
2560         https://bugs.webkit.org/show_bug.cgi?id=60067
2561
2562         No test because this code path is only used by the Objective-C API, which is not testable from DumpRenderTree.
2563
2564         * rendering/RenderText.cpp:
2565         (WebCore::RenderText::absoluteRectsForRange): Use width/height instead of logicalWidth/logicalHeight here,
2566         and perform the local-to-absolute mapping on the rects rather than their origin, in order to get the right
2567         results for flipped writing modes.
2568
2569 2011-05-03  Anton Muhin  <antonm@chromium.org>
2570
2571         Reviewed by Yury Semikhatsky.
2572
2573         [v8] remove an ASSERT from grouping logic
2574         https://bugs.webkit.org/show_bug.cgi?id=60024
2575
2576         This ASSERT was exploratory.  Alas, right now I am aware of no easy way to
2577         repro it.  Removing for now for greener bots.
2578
2579         No new tests, only an ASSERT removal.
2580
2581         * bindings/v8/V8GCController.cpp:
2582         (WebCore::calculateGroupId):
2583
2584 2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>
2585
2586         Reviewed by Darin Adler.
2587
2588         WebKit allows selection that crosses the shadow boundary of a readonly input element
2589         https://bugs.webkit.org/show_bug.cgi?id=60000
2590
2591         The bug was caused by VisibleSelection's not validating shadow DOM boundaries.
2592         Fixed the bug by adding an extra adjustment, adjustSelectionToAvoidCrossingShadowBoundaries,
2593         in its validation process.
2594
2595         Tests: editing/selection/select-across-readonly-input-1.html
2596                editing/selection/select-across-readonly-input-2.html
2597                editing/selection/select-across-readonly-input-3.html
2598                editing/selection/select-across-readonly-input-4.html
2599                editing/selection/select-across-readonly-input-5.html
2600
2601         * editing/VisibleSelection.cpp:
2602         (WebCore::VisibleSelection::validate): Calls adjustSelectionToAvoidCrossingShadowBoundaries.
2603         (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Added.
2604         * editing/VisibleSelection.h:
2605
2606 2011-05-03  Eric Seidel  <eric@webkit.org>
2607
2608         Reviewed by Ryosuke Niwa.
2609
2610         Split out layoutRunsAndFloats from layoutInlineChildren
2611         https://bugs.webkit.org/show_bug.cgi?id=60052
2612
2613         No new tests, just moving code here.  There should be
2614         no change in behavior.
2615
2616         * rendering/RenderBlock.h:
2617         * rendering/RenderBlockLineLayout.cpp:
2618         (WebCore::RenderBlock::layoutRunsAndFloats):
2619         (WebCore::RenderBlock::layoutInlineChildren):
2620
2621 2011-05-03  James Robinson  <jamesr@chromium.org>
2622
2623         Reviewed by Kenneth Russell.
2624
2625         [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
2626         https://bugs.webkit.org/show_bug.cgi?id=59965
2627
2628         Fixes a few bugs leading to a crash if a canvas already being composited was resized to huge dimensions.
2629
2630         Test: fast/canvas/canvas-resize-after-paint.html
2631
2632         * html/canvas/CanvasRenderingContext2D.cpp:
2633         (WebCore::CanvasRenderingContext2D::reset):
2634             Mark the canvas's layer as needing a synthetic style recalculation when creating or destroying the backing
2635             DrawingBuffer so that we exit compositing mode properly if we can't handle the canvas dimensions.
2636         * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
2637         (WebCore::Canvas2DLayerChromium::setLayerRenderer):
2638             Add a null check for m_drawingBuffer
2639         * platform/graphics/gpu/DrawingBuffer.cpp:
2640         (WebCore::DrawingBuffer::clear):
2641             Avoid clearing the m_context pointer in reset() - we destroy the DrawingBuffer whenever reset() fails, so
2642             this is unnecessary.
2643
2644 2011-05-03  Adam Roben  <aroben@apple.com>
2645
2646         Fix most strict PassOwnPtr violations on Windows
2647
2648         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
2649         enabled
2650
2651         Reviewed by Anders Carlsson.
2652
2653         * loader/EmptyClients.h:
2654         * platform/GeolocationService.cpp:
2655         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
2656         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
2657         * platform/mock/GeolocationServiceMock.cpp:
2658         * rendering/RenderTheme.cpp:
2659         * rendering/RenderThemeSafari.cpp:
2660
2661 2011-05-03  Levi Weintraub  <leviw@chromium.org>
2662
2663         Reviewed by Eric Seidel.
2664
2665         Extract LineInfo class
2666         https://bugs.webkit.org/show_bug.cgi?id=60044
2667
2668         Created a LineInfo class in RenderBlockLineLayout.cpp that brings together the relevant
2669         layout information about a line. This simplifies function signatures and clears up initialization.
2670
2671         No new tests as this is refactoring.
2672
2673         * rendering/RenderBlock.h: Updated internal layout function signatures to use LineInfo.
2674         * rendering/RenderBlockLineLayout.cpp:
2675         (WebCore::LineInfo::LineInfo):
2676         (WebCore::LineInfo::isFirstLine):
2677         (WebCore::LineInfo::isLastLine):
2678         (WebCore::LineInfo::isEmpty):
2679         (WebCore::LineInfo::previousLineBrokeCleanly):
2680         (WebCore::LineInfo::setFirstLine):
2681         (WebCore::LineInfo::setLastLine):
2682         (WebCore::LineInfo::setEmpty):
2683         (WebCore::LineInfo::setPreviousLineBrokeCleanly):
2684         (WebCore::RenderBlock::createLineBoxes):
2685         (WebCore::RenderBlock::constructLine):
2686         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
2687         (WebCore::RenderBlock::layoutInlineChildren):
2688         (WebCore::RenderBlock::determineStartPosition):
2689         (WebCore::skipNonBreakingSpace):
2690         (WebCore::shouldCollapseWhiteSpace):
2691         (WebCore::requiresLineBox): Moved from RenderBlock.h and made it locally scoped to RenderBlockLineLayout.cpp
2692         (WebCore::RenderBlock::generatesLineBoxesForInlineChild):
2693         (WebCore::RenderBlock::skipTrailingWhitespace):
2694         (WebCore::RenderBlock::skipLeadingWhitespace):
2695         (WebCore::RenderBlock::findNextLineBreak):
2696
2697 2011-05-03  Roland Steiner  <rolandsteiner@chromium.org>
2698
2699         Reviewed by Dimitri Glazkov.
2700
2701         Update node list cache count on the containing TreeScope rather than the Document
2702         https://bugs.webkit.org/show_bug.cgi?id=59983
2703
2704         Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
2705         Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
2706         Make setDocument() and setDocumentRecursively() private.
2707
2708         No new tests. (refactoring)
2709
2710         * dom/ContainerNode.cpp:
2711         (WebCore::ContainerNode::childrenChanged):
2712         * dom/Node.cpp:
2713         (WebCore::Node::~Node):
2714         (WebCore::Node::setDocument):
2715         (WebCore::Node::setTreeScopeRecursively):
2716         (WebCore::Node::childNodes):
2717         (WebCore::Node::registerDynamicNodeList):
2718         (WebCore::Node::unregisterDynamicNodeList):
2719         (WebCore::Node::notifyLocalNodeListsAttributeChanged):
2720         (WebCore::Node::notifyLocalNodeListsChildrenChanged):
2721         (WebCore::Node::getElementsByTagName):
2722         (WebCore::Node::getElementsByTagNameNS):
2723         (WebCore::Node::getElementsByName):
2724         (WebCore::Node::getElementsByClassName):
2725         * dom/Node.h:
2726         * html/HTMLFormControlElement.cpp:
2727         (WebCore::HTMLFormControlElement::labels):
2728
2729 2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>
2730
2731         Reviewed by Eric Seidel.
2732
2733         Bundle trailingSpaceObject and trailingPositionedBoxes in findNextLineBreak as a class
2734         https://bugs.webkit.org/show_bug.cgi?id=60046
2735
2736         Extracted TrailingObjects that encapsulates trailingSpaceObject and trailingPositionedBoxes.
2737
2738         * rendering/RenderBlockLineLayout.cpp:
2739         (WebCore::TrailingObjects::TrailingObjects):
2740         (WebCore::TrailingObjects::setTrailingWhitespace):
2741         (WebCore::TrailingObjects::clear):
2742         (WebCore::TrailingObjects::appendBoxIfNeeded):
2743         (WebCore::TrailingObjects::addMidpoints):
2744         (WebCore::RenderBlock::findNextLineBreak):
2745
2746 2011-05-03  Igor Oliveira  <igor.oliveira@openbossa.org>
2747
2748         Reviewed by Eric Seidel.
2749
2750         [Qt] Implement initial support to DataTransferItems
2751         https://bugs.webkit.org/show_bug.cgi?id=58448
2752
2753         Implement initial support to DataTransferItems. DataTransferItems are used to 
2754         hold data for drag and drop operations. DataTransferItems hold a list of 
2755         DataTransferItem objects each of which holds an item being dragged.
2756
2757         * WebCore.pro:
2758         * dom/DataTransferItems.idl:
2759         * editing/qt/EditorQt.cpp:
2760         (WebCore::Editor::newGeneralClipboard):
2761         * page/qt/EventHandlerQt.cpp:
2762         (WebCore::EventHandler::createDraggingClipboard):
2763         * platform/chromium/DataTransferItemsChromium.h:
2764         * platform/qt/ClipboardQt.cpp:
2765         (WebCore::Clipboard::create):
2766         (WebCore::ClipboardQt::ClipboardQt):
2767         (WebCore::ClipboardQt::items):
2768         * platform/qt/ClipboardQt.h:
2769         (WebCore::ClipboardQt::create):
2770         * platform/qt/DataTransferItemQt.cpp: Added.
2771         (WebCore::DataTransferItem::create):
2772         (WebCore::DataTransferItemQt::createFromPasteboard):
2773         (WebCore::DataTransferItemQt::create):
2774         (WebCore::DataTransferItemQt::DataTransferItemQt):
2775         (WebCore::DataTransferItemQt::getAsString):
2776         (WebCore::DataTransferItemQt::getAsFile):
2777         * platform/qt/DataTransferItemQt.h: Added.
2778         * platform/qt/DataTransferItemsQt.cpp: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
2779         (WebCore::DataTransferItemsQt::create):
2780         (WebCore::DataTransferItemsQt::DataTransferItemsQt):
2781         (WebCore::DataTransferItemsQt::addPasteboardItem):
2782         * platform/qt/DataTransferItemsQt.h: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
2783
2784 2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>
2785
2786         Reviewed by Dimitri Glazkov.
2787
2788         Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
2789         https://bugs.webkit.org/show_bug.cgi?id=58703
2790
2791         No new tests, refactoring only.
2792
2793         * dom/Element.cpp:
2794         (WebCore::Element::copyNonAttributeProperties):
2795         (WebCore::Element::insertedIntoDocument):
2796         (WebCore::Element::removedFromDocument):
2797         (WebCore::Element::insertedIntoTree):
2798         (WebCore::Element::removedFromTree):
2799         (WebCore::Element::attach):
2800         (WebCore::Element::detach):
2801         (WebCore::Element::recalcStyle):
2802         (WebCore::Element::shadowRoot):
2803         (WebCore::Element::ensureShadowRoot):
2804         (WebCore::Element::childrenChanged):
2805         * dom/Node.cpp:
2806         (WebCore::Node::setTreeScopeRecursively):
2807         (WebCore::shadowRoot):
2808         (WebCore::Node::setDocumentRecursively):
2809         (WebCore::NodeRendererFactory::findVisualParent):
2810         Updated all the call sites for shadowRoot and ensureShadowRoot in the 2
2811         previous classes.
2812
2813         * dom/Element.h: Updated 2 methods' signature to return a ShadowRoot*.
2814
2815         * dom/ShadowRoot.h: Removed toShadowRoot as it is not used anymore.
2816
2817         * html/HTMLDetailsElement.cpp:
2818         * html/HTMLSummaryElement.cpp:
2819         Added #include for ShadowRoot.h.
2820
2821 2011-05-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2822
2823         Reviewed by Kenneth Rohde Christiansen.
2824
2825         [EFL] Implement mediaSliderTrack
2826         https://bugs.webkit.org/show_bug.cgi?id=59998
2827
2828         Implement paintMediaSliderTrack.
2829
2830         * platform/efl/RenderThemeEfl.cpp:
2831         (WebCore::RenderThemeEfl::RenderThemeEfl):
2832         (WebCore::RenderThemeEfl::paintMediaSliderTrack):
2833         * platform/efl/RenderThemeEfl.h:
2834
2835 2011-05-03  Mikhail Naganov  <mnaganov@chromium.org>
2836
2837         Reviewed by Pavel Feldman.
2838
2839         WebInspector: [Chromium] Fix slowness of Summary view nodes expansion in detailed heap profiles.
2840         https://bugs.webkit.org/show_bug.cgi?id=60023
2841
2842         * inspector/front-end/DetailedHeapshotGridNodes.js:
2843         (WebInspector.HeapSnapshotConstructorNode):
2844         (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
2845         * inspector/front-end/HeapSnapshot.js:
2846         (WebInspector.HeapSnapshot.prototype.dispose):
2847         (WebInspector.HeapSnapshot.prototype.aggregates):
2848         (WebInspector.HeapSnapshot.prototype._buildAggregates):
2849         (WebInspector.HeapSnapshot.prototype._sortAggregateIndexes):
2850         (WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):
2851         (WebInspector.HeapSnapshotFilteredOrderedIterator):
2852         (WebInspector.HeapSnapshotNodesProvider):
2853         * inspector/front-end/HeapSnapshotProxy.js:
2854         (WebInspector.HeapSnapshotProxy.prototype.aggregates):
2855         (WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForClass):
2856
2857 2011-05-03  Mikhail Naganov  <mnaganov@chromium.org>
2858
2859         Reviewed by Pavel Feldman.
2860
2861         WebInspector: [Chromium] Hint user that to display retaining paths, an object entry must be clicked.
2862         https://bugs.webkit.org/show_bug.cgi?id=60029
2863
2864         * English.lproj/localizedStrings.js:
2865         * inspector/front-end/DetailedHeapshotView.js:
2866         (WebInspector.HeapSnapshotRetainingPathsList.prototype.reset):
2867         (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):
2868
2869 2011-05-03  Beth Dakin  <bdakin@apple.com>
2870
2871         Reviewed by Dan Bernstein.
2872
2873         https://bugs.webkit.org/show_bug.cgi?id=60045
2874         Scrollbar thumb sometimes leaves artifacts in the track after scrolling
2875         -and corresponding-
2876         <rdar://problem/9015376>
2877
2878         When we're using WK_SCROLLBAR_PAINTER, the AppleScrollBarVariant default should 
2879         always be ignored.
2880         * platform/mac/ScrollbarThemeMac.mm:
2881         (WebCore::updateArrowPlacement):
2882
2883 2011-05-03  David Hyatt  <hyatt@apple.com>
2884
2885         Reviewed by Dan Bernstein.
2886
2887         https://bugs.webkit.org/show_bug.cgi?id=60040
2888         <rdar://problem/9261591>
2889
2890         Links broken at iplanwebsites.com. Make sure that culledInlineAbsoluteQuads still does
2891         a translation of a 0,0 point to absolute coordinates so that the top left position is
2892         accurate.
2893
2894         Added fast/inline/skipped-whitespace-client-rect.html
2895         
2896         * rendering/RenderInline.cpp:
2897         (WebCore::RenderInline::culledInlineAbsoluteQuads):
2898
2899 2011-05-03  Sam Weinig  <sam@webkit.org>
2900
2901         Fix chromium build.
2902
2903         * page/Settings.cpp:
2904
2905 2011-05-02  Roland Steiner  <rolandsteiner@chromium.org>
2906
2907         Reviewed by Dimitri Glazkov.
2908
2909         Bug 59974 - Update image map on the containing TreeScope rather than the Document
2910         https://bugs.webkit.org/show_bug.cgi?id=59974
2911
2912         No new tests. (reefactoring)
2913
2914         * html/HTMLMapElement.cpp:
2915         (WebCore::HTMLMapElement::parseMappedAttribute):
2916         (WebCore::HTMLMapElement::insertedIntoDocument):
2917         (WebCore::HTMLMapElement::removedFromDocument):
2918         * rendering/RenderImage.cpp:
2919         (WebCore::RenderImage::imageMap):
2920
2921 2011-05-03  Sam Weinig  <sam@webkit.org>
2922
2923         Fix chromium build.
2924
2925         * loader/HistoryController.cpp:
2926
2927 2011-05-02  Roland Steiner  <rolandsteiner@chromium.org>
2928
2929         Reviewed by Dimitri Glazkov.
2930
2931         Bug 59966 - Update ID hash on the containing TreeScope rather than the Document
2932         https://bugs.webkit.org/show_bug.cgi?id=59966
2933
2934         No new tests. (refactoring)
2935
2936         * accessibility/AccessibilityRenderObject.cpp:
2937         (WebCore::AccessibilityRenderObject::elementsFromAttribute):
2938         (WebCore::AccessibilityRenderObject::activeDescendant):
2939         * accessibility/AccessibilityRenderObject.h:
2940         (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
2941         * css/CSSCursorImageValue.cpp:
2942         (WebCore::resourceReferencedByCursorElement):
2943         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
2944         (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
2945         (WebCore::CSSCursorImageValue::cachedImage):
2946         * dom/DynamicNodeList.cpp:
2947         (WebCore::DynamicNodeList::itemWithName):
2948         * dom/Element.h:
2949         (WebCore::Element::updateId):
2950         * dom/Node.cpp:
2951         (WebCore::Node::querySelector):
2952         * html/FormAssociatedElement.cpp:
2953         (WebCore::FormAssociatedElement::insertedIntoTree):
2954         (WebCore::FormAssociatedElement::resetFormOwner):
2955         * html/HTMLInputElement.cpp:
2956         (WebCore::HTMLInputElement::dataList):
2957         * html/HTMLLabelElement.cpp:
2958         (WebCore::HTMLLabelElement::control):
2959         * rendering/svg/RenderSVGTextPath.cpp:
2960         (WebCore::RenderSVGTextPath::layoutPath):
2961         * svg/SVGAElement.cpp:
2962         (WebCore::SVGAElement::defaultEventHandler):
2963         * svg/SVGAltGlyphElement.cpp:
2964         (WebCore::SVGAltGlyphElement::glyphElement):
2965         * svg/SVGFEImageElement.cpp:
2966         (WebCore::SVGFEImageElement::requestImageResource):
2967         (WebCore::SVGFEImageElement::build):
2968         * svg/SVGLinearGradientElement.cpp:
2969         (WebCore::SVGLinearGradientElement::collectGradientAttributes):
2970         * svg/SVGMPathElement.cpp:
2971         (WebCore::SVGMPathElement::pathElement):
2972         * svg/SVGPatternElement.cpp:
2973         (WebCore::SVGPatternElement::collectPatternAttributes):
2974         * svg/SVGRadialGradientElement.cpp:
2975         (WebCore::SVGRadialGradientElement::collectGradientAttributes):
2976         * svg/SVGSVGElement.cpp:
2977         (WebCore::SVGSVGElement::getElementById):
2978         * svg/SVGTRefElement.cpp:
2979         (WebCore::SVGTRefElement::updateReferencedText):
2980         * svg/SVGTextPathElement.cpp:
2981         (WebCore::SVGTextPathElement::insertedIntoDocument):
2982         * svg/SVGUseElement.cpp:
2983         (WebCore::SVGUseElement::buildPendingResource):
2984         (WebCore::SVGUseElement::hasCycleUseReferencing):
2985         (WebCore::SVGUseElement::expandUseElementsInShadowTree):
2986         * svg/SVGViewSpec.cpp:
2987         (WebCore::SVGViewSpec::viewTarget):
2988         * svg/animation/SVGSMILElement.cpp:
2989         (WebCore::SVGSMILElement::eventBaseFor):
2990         (WebCore::SVGSMILElement::connectConditions):
2991         (WebCore::SVGSMILElement::targetElement):
2992         * xml/XPathFunctions.cpp:
2993         (WebCore::XPath::FunId::evaluate):
2994
2995 2011-05-03  Sam Weinig  <sam@webkit.org>
2996
2997         Fix chromium build.
2998
2999         * css/StyleMedia.cpp:
3000
3001 2011-05-03  Sam Weinig  <sam@webkit.org>
3002
3003         Reviewed by Anders Carlsson.
3004
3005         Prune #includes from FrameView.h (Part 1)
3006         https://bugs.webkit.org/show_bug.cgi?id=59957
3007
3008         * page/FrameView.h:
3009         Prune #includes.
3010
3011         * accessibility/chromium/AXObjectCacheChromium.cpp:
3012         * page/win/FrameCGWin.cpp:
3013         * platform/Scrollbar.cpp:
3014         Add not necessary #includes.
3015
3016         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
3017         Add now necessary forward declaration.
3018
3019 2011-05-03  Andrey Kosyakov  <caseq@chromium.org>
3020
3021         Reviewed by Dimitri Glazkov.
3022
3023         [Chromium] toV8(Node*) will enter infinite recursion when called with a node of type SHADOW_ROOT_NODE
3024         https://bugs.webkit.org/show_bug.cgi?id=60026
3025
3026         Return a wrapper for Node in toV8(Node*) when called with a node of type
3027         SHADOW_ROOT_NODE instead of entering infinite recursion.
3028
3029         * bindings/v8/custom/V8NodeCustom.cpp:
3030         (WebCore::toV8Slow):
3031
3032 2011-05-02  Adam Roben  <aroben@apple.com>
3033
3034         Take advantage of implicit conversion from nullptr_t to PassOwnPtr
3035
3036         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
3037         doesn't work, but should
3038
3039         Reviewed by Adam Barth.
3040
3041         * bindings/js/ScheduledAction.cpp:
3042         * css/CSSStyleSelector.cpp:
3043         * css/MediaList.cpp:
3044         * css/MediaQueryMatcher.cpp:
3045         * css/SVGCSSStyleSelector.cpp:
3046         * dom/MessagePort.cpp:
3047         * html/InputType.cpp:
3048         * html/canvas/WebGLRenderingContext.cpp:
3049         * inspector/InspectorStyleSheet.cpp:
3050         * page/ContextMenuController.cpp:
3051         * page/Page.cpp:
3052         * platform/PlatformGestureRecognizer.cpp:
3053         * platform/PurgeableBuffer.h:
3054         * platform/graphics/ImageBuffer.h:
3055         * platform/leveldb/LevelDBDatabase.cpp:
3056         * platform/mac/PurgeableBufferMac.cpp:
3057         * platform/text/RegularExpression.cpp:
3058         * rendering/RenderTheme.cpp:
3059         * rendering/RenderThemeMac.mm:
3060         * rendering/style/RenderStyle.h:
3061         * rendering/style/SVGRenderStyleDefs.cpp:
3062         * rendering/style/ShadowData.cpp:
3063         * rendering/style/StyleRareInheritedData.cpp:
3064         * rendering/style/StyleRareNonInheritedData.cpp:
3065         * rendering/svg/RenderSVGResourcePattern.cpp:
3066
3067 2011-05-03  Pavel Feldman  <pfeldman@google.com>
3068
3069         Not reviewed: fix inspector status bar image glyph reference in network panel.
3070
3071         * inspector/front-end/networkPanel.css:
3072         (.network-larger-resources-status-bar-item .glyph):
3073
3074 2011-05-03  Pavel Feldman  <pfeldman@google.com>
3075
3076         Reviewed by Yury Semikhatsky.
3077
3078         Web Inspector: rename BrowserDebugger agent to DOMDebugger.
3079         https://bugs.webkit.org/show_bug.cgi?id=60019
3080
3081         * inspector/CodeGeneratorInspector.pm:
3082         * inspector/Inspector.json:
3083         * inspector/InspectorController.cpp:
3084         (WebCore::InspectorController::connectFrontend):
3085         * inspector/front-end/BreakpointsSidebarPane.js:
3086         (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
3087         (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
3088         (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
3089         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
3090         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
3091         * inspector/generate-inspector-idl:
3092
3093 2011-05-03  Yury Semikhatsky  <yurys@chromium.org>
3094
3095         Reviewed by Pavel Feldman.
3096
3097         Web Inspector: remove special logic for type of document.__proto__
3098         https://bugs.webkit.org/show_bug.cgi?id=60014
3099
3100         Test: inspector/console/console-log-document-proto.html
3101
3102         * inspector/InjectedScriptSource.js: removed unnecessary check nodeType === undefined
3103
3104 2011-05-03  Pavel Feldman  <pfeldman@google.com>
3105
3106         Not reviewed: fixed typo in inspector style.
3107
3108         * inspector/front-end/inspector.css:
3109         (.status-bar-item > .glyph):
3110
3111 2011-05-03  Pavel Feldman  <pfeldman@chromium.org>
3112
3113         Reviewed by Yury Semikhatsky.
3114
3115         Web Inspector: revision history storage is too slow.
3116         https://bugs.webkit.org/show_bug.cgi?id=59939
3117
3118         It turns out that iterating localStorage keys is very
3119         expensive (results in slow inspector start), refactor revision
3120         history in order not to rely upon that operation.
3121
3122         * inspector/front-end/Resource.js:
3123         (WebInspector.Resource):
3124         (WebInspector.Resource._resourceRevisionRegistry):
3125         (WebInspector.Resource.restoreRevisions.persist):
3126         (WebInspector.Resource.restoreRevisions):
3127         (WebInspector.Resource.persistRevision):
3128         (WebInspector.Resource.prototype._persistRevision):
3129         * inspector/front-end/ResourceTreeModel.js:
3130         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
3131         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
3132
3133 2011-05-03  Pavel Feldman  <pfeldman@chromium.org>
3134
3135         Reviewed by Yury Semikhatsky.
3136
3137         Web Inspector: combine toolbar icon images.
3138         https://bugs.webkit.org/show_bug.cgi?id=59931
3139
3140         * WebCore.gypi:
3141         * inspector/front-end/Images/auditsIcon.png: Removed.
3142         * inspector/front-end/Images/consoleIcon.png: Removed.
3143         * inspector/front-end/Images/elementsIcon.png: Removed.
3144         * inspector/front-end/Images/networkIcon.png: Removed.
3145         * inspector/front-end/Images/profilesIcon.png: Removed.
3146         * inspector/front-end/Images/resourcesIcon.png: Removed.
3147         * inspector/front-end/Images/scriptsIcon.png: Removed.
3148         * inspector/front-end/Images/timelineIcon.png: Removed.
3149         * inspector/front-end/Images/toolbarIcons.png: Added.
3150         * inspector/front-end/Images/toolbarIconsSmall.png: Added.
3151         * inspector/front-end/WebKit.qrc:
3152         * inspector/front-end/inspector.css:
3153         (.toolbar-icon):
3154         (#toolbar-dropdown .toolbar-icon):
3155         (.toolbar-item:active .toolbar-icon):
3156         (#toolbar-dropdown .toolbar-item:active .toolbar-icon):
3157         (.toolbar-item.elements .toolbar-icon):
3158         (.toolbar-item.resources .toolbar-icon):
3159         (#toolbar-dropdown .toolbar-item.resources .toolbar-icon):
3160         (.toolbar-item.network .toolbar-icon):
3161         (#toolbar-dropdown .toolbar-item.network .toolbar-icon):
3162         (.toolbar-item.scripts .toolbar-icon):
3163         (#toolbar-dropdown .toolbar-item.scripts .toolbar-icon):
3164         (.toolbar-item.timeline .toolbar-icon):
3165         (#toolbar-dropdown .toolbar-item.timeline .toolbar-icon):
3166         (.toolbar-item.profiles .toolbar-icon):
3167         (#toolbar-dropdown .toolbar-item.profiles .toolbar-icon):
3168         (.toolbar-item.audits .toolbar-icon):
3169         (#toolbar-dropdown .toolbar-item.audits .toolbar-icon):
3170         (.toolbar-item.console .toolbar-icon):
3171         (#toolbar-dropdown .toolbar-item.console .toolbar-icon):
3172         (.status-bar-item > .glyph):
3173
3174 2011-05-03  Pavel Feldman  <pfeldman@chromium.org>
3175
3176         Reviewed by Yury Semikhatsky.
3177
3178         Web Inspector: combine status bar button glyphs.
3179         https://bugs.webkit.org/show_bug.cgi?id=59885
3180
3181         * WebCore.gypi:
3182         * inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Removed.
3183         * inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Removed.
3184         * inspector/front-end/Images/clearConsoleButtonGlyph.png: Removed.
3185         * inspector/front-end/Images/consoleButtonGlyph.png: Removed.
3186         * inspector/front-end/Images/dockButtonGlyph.png: Removed.
3187         * inspector/front-end/Images/enableOutlineButtonGlyph.png: Removed.
3188         * inspector/front-end/Images/enableSolidButtonGlyph.png: Removed.
3189         * inspector/front-end/Images/excludeButtonGlyph.png: Removed.
3190         * inspector/front-end/Images/focusButtonGlyph.png: Removed.
3191         * inspector/front-end/Images/garbageCollectButtonGlyph.png: Removed.
3192         * inspector/front-end/Images/gearButtonGlyph.png: Removed.
3193         * inspector/front-end/Images/helpButtonGlyph.png: Removed.
3194         * inspector/front-end/Images/largerResourcesButtonGlyph.png: Removed.
3195         * inspector/front-end/Images/nodeSearchButtonGlyph.png: Removed.
3196         * inspector/front-end/Images/pauseOnExceptionButtonGlyph.png: Removed.
3197         * inspector/front-end/Images/percentButtonGlyph.png: Removed.
3198         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Removed.
3199         * inspector/front-end/Images/recordButtonGlyph.png: Removed.
3200         * inspector/front-end/Images/recordToggledButtonGlyph.png: Removed.
3201         * inspector/front-end/Images/reloadButtonGlyph.png: Removed.
3202         * inspector/front-end/Images/statusBarButtonGlyphs.png: Added.
3203         * inspector/front-end/Images/undockButtonGlyph.png: Removed.
3204         * inspector/front-end/WebKit.qrc:
3205         * inspector/front-end/inspector.css:
3206         (.status-bar-item > .glyph):
3207         (#dock-status-bar-item .glyph):
3208         (body.detached #dock-status-bar-item .glyph):
3209         (#console-status-bar-item .glyph):
3210         (.clear-status-bar-item .glyph):
3211         (button.enable-toggle-status-bar-item .glyph):
3212         (button.enable-toggle-status-bar-item.toggled-on .glyph):
3213         (.scripts-pause-on-exceptions-status-bar-item .glyph):
3214         (.scripts-toggle-pretty-print-status-bar-item .glyph):
3215         (.toggle-breakpoints .glyph):
3216         (.toggle-breakpoints.toggled-on .glyph):
3217         (.resources-larger-resources-status-bar-item .glyph):
3218         (.timeline-filter-status-bar-item .glyph):
3219         (.garbage-collect-status-bar-item .glyph):
3220         (.record-profile-status-bar-item .glyph):
3221         (.record-profile-status-bar-item.toggled-on .glyph):
3222         (.heap-snapshot-status-bar-item .glyph):
3223         (.node-search-status-bar-item .glyph):
3224         (.percent-time-status-bar-item .glyph):
3225         (.focus-profile-node-status-bar-item .glyph):
3226         (.exclude-profile-node-status-bar-item .glyph):
3227         (.reset-profile-status-bar-item .glyph):
3228         (.delete-storage-status-bar-item .glyph):
3229         (.refresh-storage-status-bar-item .glyph):
3230         * inspector/front-end/inspector.js:
3231
3232 2011-05-02  Simon Fraser  <simon.fraser@apple.com>
3233
3234         Reviewed by Dan Bernstein.
3235
3236         Possible crash when removing elements with reflections
3237         https://bugs.webkit.org/show_bug.cgi?id=60009
3238         
3239         RenderLayer's destructor deleted its z-order list Vector pointers
3240         before removing the reflection layer. However, the reflection cleanup
3241         code could call back into the RenderLayer to dirty z-order lists,
3242         so move reflection cleanup to before z-order vector deletion.
3243         
3244         The test crashes when run manually a few times with MallocScribble enabled,
3245         but I was not able to create a test that crashed reliably.
3246
3247         Test: fast/reflections/remove-reflection-crash.html
3248
3249         * rendering/RenderLayer.cpp:
3250         (WebCore::RenderLayer::~RenderLayer):
3251
3252 2011-05-02  Ian Henderson  <ianh@apple.com>
3253
3254         Reviewed by Dan Bernstein.
3255
3256         CSS !important not respected by JavaScript
3257         https://bugs.webkit.org/show_bug.cgi?id=60007
3258
3259         The addParsedProperty and addParsedProperties methods were subtly
3260         different.  The former did not check for !important before setting the
3261         given property.
3262
3263         Change addParsedProperties to call addParsedProperty and move the
3264         relevant code.  The one other caller of this method, in
3265         editing/markup.cpp, probably wanted this behavior anyway.
3266
3267         Test: fast/css/important-js-override.html
3268
3269         * css/CSSMutableStyleDeclaration.cpp:
3270         (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
3271         (WebCore::CSSMutableStyleDeclaration::addParsedProperty):
3272
3273 2011-05-02  Ben Wells  <benwells@chromium.org>
3274
3275         Reviewed by Simon Fraser.
3276
3277         Cleanup variable usage in RenderObject.cpp paintOutline()
3278         https://bugs.webkit.org/show_bug.cgi?id=59911
3279
3280         No new tests for this, there should be no change in behaviour.
3281
3282         * rendering/RenderObject.cpp:
3283         (WebCore::RenderObject::paintOutline):
3284
3285 2011-05-02  Ryosuke Niwa  <rniwa@webkit.org>
3286
3287         Reviewed by James Robinson.
3288
3289         REGRESSION(r84672): showTree doesn't work for input/textarea elements
3290         https://bugs.webkit.org/show_bug.cgi?id=60001
3291
3292         When shadow is null, try retrieving the inner element of a render text control.
3293
3294         * dom/Node.cpp:
3295         (WebCore::traverseTreeAndMark):
3296
3297 2011-05-02  Joseph Pecoraro  <joepeck@webkit.org>
3298
3299         Reviewed by David Kilzer.
3300
3301         Respect fixed text-indent on ::-webkit-input-placeholder
3302         https://bugs.webkit.org/show_bug.cgi?id=59825
3303
3304         Test: fast/forms/input-placeholder-text-indent.html
3305
3306         * rendering/RenderTextControl.cpp:
3307         (WebCore::RenderTextControl::paintPlaceholder): indent by
3308         a fixed text-indent size specified on the placeholder style.
3309
3310 2011-05-02  Eric Uhrhane  <ericu@chromium.org>
3311
3312         Reviewed by Eric Seidel.
3313
3314         Some FileWriter progress events should be queued
3315         https://bugs.webkit.org/show_bug.cgi?id=50846
3316
3317         * fileapi/FileWriter.cpp:
3318         * fileapi/FileWriter.h:
3319         Create a new asynchronous Task [FileWriterCompletionEventTask] that will set readyState to DONE and fire off the right events.
3320
3321 2011-05-02  Jia Pu  <jpu@apple.com>
3322
3323         Reviewed by Alexey Proskuryakov.
3324
3325         [Mac] Need to truncate the string sent to "Look Up … " menu item, if it's too long.
3326         https://bugs.webkit.org/show_bug.cgi?id=59836
3327         <rdar://problem/9275983>
3328
3329         * platform/DefaultLocalizationStrategy.cpp:
3330         (WebCore::truncatedStringForLookupMenuItem):
3331         (WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):
3332
3333 2011-05-02  Brady Eidson  <beidson@apple.com>
3334
3335         Reviewed by Anders Carlsson.
3336
3337         <rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
3338         In Aperture, a WebView might be dealloc'ed before it finishes loading.
3339
3340         * WebCore.exp.in:
3341         * platform/RuntimeApplicationChecks.cpp:
3342         (WebCore::applicationIsAperture): Perform a com.apple.Aperture bundle check.
3343         * platform/RuntimeApplicationChecks.h:
3344
3345 2011-05-02  Simon Fraser  <simon.fraser@apple.com>
3346
3347         Reviewed by Dan Bernstein.
3348
3349         Avoid wasted cycles updating paths when popping the context stack
3350         https://bugs.webkit.org/show_bug.cgi?id=59967
3351
3352         CanvasRenderingContext2D has to map the current path through
3353         transforms whenever the context stack is popped, which creates
3354         a lot of platform path objects. Avoid extra work here when the
3355         path is empty, or when the transform is identity.
3356
3357         * platform/graphics/cg/PathCG.cpp:
3358         (WebCore::Path::transform):
3359
3360 2011-05-02  Enrica Casucci  <enrica@apple.com>
3361
3362         Reviewed by Dan Bernstein.
3363
3364         Text does not split on white space when typing to the edge of window.
3365         https://bugs.webkit.org/show_bug.cgi?id=59968
3366         <rdar://problem/9112683>
3367
3368         Test: editing/inserting/typing-at-end-of-line.html
3369
3370         This is a regression introduced when we converted the line box tree to
3371         floating point in r78846. In findNextLineBreak, there was still one place where
3372         the character width was treated as int and truncated and we were inconsistent
3373         in the way we treated a character that did not fit entirely in the line.
3374
3375         * rendering/RenderBlockLineLayout.cpp:
3376         (WebCore::RenderBlock::findNextLineBreak):
3377
3378 2011-04-19  Adrienne Walker  <enne@google.com>
3379
3380         Reviewed by James Robinson.
3381
3382         [chromium] Don't unnecessarily resize skia/cg canvases when painting in compositor
3383         https://bugs.webkit.org/show_bug.cgi?id=58907
3384
3385         Additionally, move the context save/restore logic to a place where it
3386         will reset the translation added in LayerTilerChromium.
3387
3388         Test: compositing/repaint/same-size-invalidation.html
3389
3390         * platform/graphics/chromium/ContentLayerChromium.cpp:
3391         (WebCore::ContentLayerPainter::paint):
3392         * platform/graphics/chromium/PlatformCanvas.cpp:
3393         (WebCore::PlatformCanvas::resize):
3394         (WebCore::PlatformCanvas::Painter::Painter):
3395         (WebCore::PlatformCanvas::Painter::~Painter):
3396         * platform/graphics/chromium/PlatformCanvas.h:
3397
3398 2011-05-02  Csaba Osztrogonác  <ossy@webkit.org>
3399
3400         Enable strict OwnPtr for Qt
3401         https://bugs.webkit.org/show_bug.cgi?id=59667
3402
3403         Unreviewed buildfix after r85343.
3404
3405         * platform/graphics/qt/GraphicsContext3DQt.cpp:
3406         (WebCore::GraphicsContext3D::GraphicsContext3D):
3407
3408 2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3409
3410         Unreviewed, rolling out r85483.
3411         http://trac.webkit.org/changeset/85483
3412         https://bugs.webkit.org/show_bug.cgi?id=59958
3413
3414         Causes media test failures. (Requested by eric_carlson on
3415         #webkit).
3416
3417         * html/HTMLMediaElement.cpp:
3418         (WebCore::HTMLMediaElement::HTMLMediaElement):
3419         (WebCore::HTMLMediaElement::prepareForLoad):
3420         (WebCore::HTMLMediaElement::seek):
3421         (WebCore::HTMLMediaElement::updatePlayState):
3422         * html/HTMLMediaElement.h:
3423         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
3424         (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
3425         (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad):
3426         (WebCore::MediaPlayerPrivateAVFoundation::load):
3427         (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay):
3428         (WebCore::MediaPlayerPrivateAVFoundation::paint):
3429         (WebCore::MediaPlayerPrivateAVFoundation::duration):
3430         (WebCore::MediaPlayerPrivateAVFoundation::seeking):
3431         (WebCore::MediaPlayerPrivateAVFoundation::updateStates):
3432         (WebCore::MediaPlayerPrivateAVFoundation::hasAvailableVideoFrame):
3433         (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded):
3434         (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged):
3435         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
3436         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
3437         (WebCore::MediaPlayerPrivateAVFoundation::repaint):
3438         (WebCore::MediaPlayerPrivateAVFoundation::setPreload):
3439         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
3440         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
3441         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
3442         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
3443         (WebCore::MediaPlayerPrivateAVFoundationObjC::videoLayerIsReadyToDisplay):
3444         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL):
3445         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForCacheResource):
3446         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
3447         (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata):
3448         (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
3449         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
3450         (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus):
3451         (WebCore::MediaPlayerPrivateAVFoundationObjC::paint):
3452         (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
3453         (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
3454
3455 2011-05-02  Adam Barth  <abarth@webkit.org>
3456
3457         Reviewed by David Levin.
3458
3459         PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
3460         https://bugs.webkit.org/show_bug.cgi?id=59924
3461
3462         * css/CSSGrammar.y:
3463         * platform/graphics/mac/SimpleFontDataMac.mm:
3464             - Memory management for the font cache is somewhat... complext.
3465               This will require some careful thought to sort out.
3466
3467 2011-05-02  Levi Weintraub  <leviw@chromium.org>
3468
3469         Reviewed by Eric Seidel.
3470
3471         showLineTree/showLineTreeForThis would make working with the line box tree easier
3472         https://bugs.webkit.org/show_bug.cgi?id=59662
3473
3474         Adding a showLineTree/showLineTreeForThis method to help visualize and debug
3475         the line tree. Also adding a missing showRenderTreeForThis method to RenderObject.
3476
3477         No new tests since this is a debugging feature only and not compiled in release.
3478
3479         * rendering/InlineBox.cpp:
3480         (WebCore::InlineBox::showLineTreeForThis):
3481         (WebCore::InlineBox::showLineTreeAndMark):
3482         (WebCore::InlineBox::showBox):
3483         (showLineTree):
3484         * rendering/InlineBox.h:
3485         * rendering/InlineFlowBox.cpp:
3486         (WebCore::InlineFlowBox::showLineTreeAndMark):
3487         * rendering/InlineFlowBox.h:
3488         * rendering/InlineTextBox.cpp:
3489         (WebCore::InlineTextBox::showBox):
3490         * rendering/InlineTextBox.h:
3491         * rendering/RenderBlock.cpp:
3492         (WebCore::RenderBlock::showLineTreeAndMark):
3493         * rendering/RenderBlock.h:
3494         * rendering/RenderObject.cpp:
3495         (WebCore::RenderObject::showRenderTreeForThis):
3496         (WebCore::RenderObject::showLineTreeForThis):
3497         (showTree):
3498         (showLineTree):
3499         * rendering/RenderObject.h:
3500
3501 2011-05-02  Dimitri Glazkov  <dglazkov@chromium.org>
3502
3503         Reviewed by Eric Carlson.
3504
3505         REGRESSIONS (r71934): In standalone media documents, (double-)clicking the media element doesn’t play/pause
3506         https://bugs.webkit.org/show_bug.cgi?id=59917
3507
3508         Since default event handlers are not retargeted, we should always attempt ancestor
3509         traversal to find out whether the event.
3510
3511         * html/MediaDocument.cpp:
3512         (WebCore::ancestorVideoElement): Added ancestor-traversing helper.
3513         (WebCore::MediaDocument::defaultEventHandler): Changed to use ancestorVideoElement.
3514
3515 2011-05-02  Sam Weinig  <sam@webkit.org>
3516
3517         Attempt to fix the Leopard build.
3518
3519         * platform/graphics/FontPlatformData.h:
3520         * platform/graphics/mac/ComplexTextController.h:
3521         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
3522         * platform/mac/WebCoreSystemInterface.h:
3523
3524 2011-05-02  Tony Chang  <tony@chromium.org>
3525
3526         Reviewed by Kent Tamura.
3527
3528         convert manual-tests/bugzilla-6821.html to a layout test
3529         https://bugs.webkit.org/show_bug.cgi?id=59404
3530
3531         Test: fast/css/hover-update.html
3532
3533         * manual-tests/bugzilla-6821.html: Removed.
3534
3535 2011-05-02  Sam Weinig  <sam@webkit.org>
3536
3537         Reviewed by Anders Carlsson.
3538
3539         Prune ApplicationServices.h out of the headers
3540         https://bugs.webkit.org/show_bug.cgi?id=59952
3541
3542         More forward declares are better.
3543
3544         * html/canvas/CanvasRenderingContext2D.cpp:
3545         * html/canvas/CanvasRenderingContext2D.h:
3546         * platform/graphics/GlyphBuffer.h:
3547         * platform/graphics/cg/ImageBufferCG.cpp:
3548         * platform/graphics/cg/PDFDocumentImage.cpp:
3549         * platform/graphics/cg/PDFDocumentImage.h:
3550         * platform/graphics/mac/ComplexTextController.h:
3551         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
3552         * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
3553         * platform/mac/ScrollAnimatorMac.h:
3554         * platform/mac/ScrollAnimatorMac.mm:
3555         * platform/mac/ScrollbarThemeMac.h:
3556         * platform/mac/ScrollbarThemeMac.mm:
3557         * platform/mac/WebCoreNSStringExtras.h:
3558         * platform/mac/WebCoreSystemInterface.h:
3559
3560 2011-05-02  Dan Bernstein  <mitz@apple.com>
3561
3562         Reviewed by Simon Fraser.
3563
3564         <rdar://problem/7972529> Images with percentage based height/max-height are missing when they are inside blocks inside tables