From eb20b132446f690d25c8dd838478c242159059fd Mon Sep 17 00:00:00 2001 From: "rniwa@webkit.org" Date: Sun, 26 May 2013 02:57:51 +0000 Subject: [PATCH] Teach webkitbot and WKR how to respond to yt? https://bugs.webkit.org/show_bug.cgi?id=116775 Reviewed by Andreas Kling. * Scripts/webkitpy/tool/bot/irc_command.py: (Hi): Fixed the usage string. (Hi.execute): Made it more generic so that it works in WKR. (YouThere): Added. (YouThere.execute): Added. * Scripts/webkitpy/tool/commands/newcommitbot.py: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150701 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Tools/ChangeLog | 14 ++++++++++++++ Tools/Scripts/webkitpy/tool/bot/irc_command.py | 13 +++++++++++-- .../Scripts/webkitpy/tool/commands/newcommitbot.py | 2 ++ 3 files changed, 27 insertions(+), 2 deletions(-) diff --git a/Tools/ChangeLog b/Tools/ChangeLog index 2bfa10e8b531..1fae3099fe4b 100644 --- a/Tools/ChangeLog +++ b/Tools/ChangeLog @@ -1,3 +1,17 @@ +2013-05-25 Ryosuke Niwa + + Teach webkitbot and WKR how to respond to yt? + https://bugs.webkit.org/show_bug.cgi?id=116775 + + Reviewed by Andreas Kling. + + * Scripts/webkitpy/tool/bot/irc_command.py: + (Hi): Fixed the usage string. + (Hi.execute): Made it more generic so that it works in WKR. + (YouThere): Added. + (YouThere.execute): Added. + * Scripts/webkitpy/tool/commands/newcommitbot.py: + 2013-05-25 Simon Fraser Try to fix the EFL build. diff --git a/Tools/Scripts/webkitpy/tool/bot/irc_command.py b/Tools/Scripts/webkitpy/tool/bot/irc_command.py index 00da84451790..979fcff06b0f 100644 --- a/Tools/Scripts/webkitpy/tool/bot/irc_command.py +++ b/Tools/Scripts/webkitpy/tool/bot/irc_command.py @@ -111,10 +111,10 @@ class Help(IRCCommand): class Hi(IRCCommand): usage_string = "hi" - help_string = "Retrieves a random quip from Bugzilla." + help_string = "Responds with hi." def execute(self, nick, args, tool, sheriff): - if len(args) and re.match(r'webkitbot_*\s*!\s*', ' '.join(args)): + if len(args) and re.match(sheriff.name() + r'_*\s*!\s*', ' '.join(args)): return "%s: hi %s!" % (nick, nick) quips = tool.bugs.quips() quips.append('"Only you can prevent forest fires." -- Smokey the Bear') @@ -129,6 +129,14 @@ class PingPong(IRCCommand): return nick + ": pong" +class YouThere(IRCCommand): + usage_string = "yt?" + help_string = "Responds with yes." + + def execute(self, nick, args, tool, sheriff): + return "%s: yes" % nick + + class Restart(IRCCommand): usage_string = "restart" help_string = "Restarts sherrifbot. Will update its WebKit checkout, and re-join the channel momentarily." @@ -298,6 +306,7 @@ visible_commands = { "roll-chromium-deps": RollChromiumDEPS, "rollout": Rollout, "whois": Whois, + "yt?": YouThere, } # Add revert as an "easter egg" command. Why? diff --git a/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py b/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py index b65b0c331f30..b098cb3c3df0 100644 --- a/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py +++ b/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py @@ -37,6 +37,7 @@ from webkitpy.tool.bot.irc_command import Help from webkitpy.tool.bot.irc_command import Hi from webkitpy.tool.bot.irc_command import PingPong from webkitpy.tool.bot.irc_command import Restart +from webkitpy.tool.bot.irc_command import YouThere from webkitpy.tool.bot.ircbot import IRCBot from webkitpy.tool.commands.queues import AbstractQueue from webkitpy.tool.commands.stepsequence import StepSequenceErrorHandler @@ -52,6 +53,7 @@ class NewCommitBot(AbstractQueue, StepSequenceErrorHandler): "hi": Hi, "ping": PingPong, "restart": Restart, + "yt?": YouThere, } _maximum_number_of_revisions_to_avoid_spamming_irc = 10 -- 2.36.0