From d293adbd6ac778d77304dea22852b3e5598bc7d9 Mon Sep 17 00:00:00 2001 From: "abarth@webkit.org" Date: Fri, 27 Nov 2009 18:09:36 +0000 Subject: [PATCH] 2009-11-27 Adam Barth Reviewed by Eric Seidel. [bzt] unit test ApplyPatches and ApplyAttachment https://bugs.webkit.org/show_bug.cgi?id=31935 * Scripts/modules/commands/download.py: * Scripts/modules/commands/download_unittest.py: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51443 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- WebKitTools/ChangeLog | 10 ++++++++++ WebKitTools/Scripts/modules/commands/download.py | 2 -- .../Scripts/modules/commands/download_unittest.py | 12 ++++++++++++ 3 files changed, 22 insertions(+), 2 deletions(-) diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog index ce5e4022182e..c92e3519891b 100644 --- a/WebKitTools/ChangeLog +++ b/WebKitTools/ChangeLog @@ -1,3 +1,13 @@ +2009-11-27 Adam Barth + + Reviewed by Eric Seidel. + + [bzt] unit test ApplyPatches and ApplyAttachment + https://bugs.webkit.org/show_bug.cgi?id=31935 + + * Scripts/modules/commands/download.py: + * Scripts/modules/commands/download_unittest.py: + 2009-11-27 Adam Barth Reviewed by Eric Seidel. diff --git a/WebKitTools/Scripts/modules/commands/download.py b/WebKitTools/Scripts/modules/commands/download.py index 365b4079a2b4..31af13387fea 100644 --- a/WebKitTools/Scripts/modules/commands/download.py +++ b/WebKitTools/Scripts/modules/commands/download.py @@ -79,7 +79,6 @@ class Build(Command): sequence.run_and_handle_errors() -# FIXME: Requires unit test. Blocking issue: WebKitApplyingScripts class ApplyAttachment(Command): name = "apply-attachment" show_in_main_help = True @@ -95,7 +94,6 @@ class ApplyAttachment(Command): WebKitApplyingScripts.apply_patches_with_options(tool.scm(), [attachment], options) -# FIXME: Requires unit test. Blocking issue: WebKitApplyingScripts class ApplyPatches(Command): name = "apply-patches" show_in_main_help = True diff --git a/WebKitTools/Scripts/modules/commands/download_unittest.py b/WebKitTools/Scripts/modules/commands/download_unittest.py index d0fff6e78a25..a1ed41a5b3b4 100644 --- a/WebKitTools/Scripts/modules/commands/download_unittest.py +++ b/WebKitTools/Scripts/modules/commands/download_unittest.py @@ -49,6 +49,18 @@ class DownloadCommandsTest(CommandsTest): def test_build(self): self.assert_execute_outputs(Build(), [], options=self._default_options()) + def test_apply_attachment(self): + options = self._default_options() + options.update = True + options.local_commit = True + self.assert_execute_outputs(ApplyAttachment(), [197], options=options) + + def test_apply_patches(self): + options = self._default_options() + options.update = True + options.local_commit = True + self.assert_execute_outputs(ApplyPatches(), [42], options=options) + def test_land_diff(self): self.assert_execute_outputs(LandDiff(), [42], options=self._default_options()) -- 2.36.0