From c7e31929fde64042347f4c56d63d71a83c86f97c Mon Sep 17 00:00:00 2001 From: "dglazkov@chromium.org" Date: Sun, 1 Mar 2009 05:28:31 +0000 Subject: [PATCH 1/1] 2009-02-28 Dimitri Glazkov Reviewed by Darin Fisher. https://bugs.webkit.org/show_bug.cgi?id=24261 Fix V8 custom binding scrubbing error. Test: fast/dom/TreeWalker/TreeWalker-currentNode.html Test: traversal/exception-forwarding.html TesT: traversal/stay-within-root.html * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: * bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8): Replace v8::Undefined() return value with v8::Null(). * bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8): Ditto. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41325 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- WebCore/ChangeLog | 17 +++++++++++++++++ .../bindings/v8/custom/V8NodeIteratorCustom.cpp | 2 +- .../bindings/v8/custom/V8TreeWalkerCustom.cpp | 2 +- 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog index 1161fe32aa76..a4350e099e75 100644 --- a/WebCore/ChangeLog +++ b/WebCore/ChangeLog @@ -1,3 +1,20 @@ +2009-02-28 Dimitri Glazkov + + Reviewed by Darin Fisher. + + https://bugs.webkit.org/show_bug.cgi?id=24261 + Fix V8 custom binding scrubbing error. + + Test: fast/dom/TreeWalker/TreeWalker-currentNode.html + Test: traversal/exception-forwarding.html + TesT: traversal/stay-within-root.html + + * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: + * bindings/v8/custom/V8NodeIteratorCustom.cpp: + (WebCore::toV8): Replace v8::Undefined() return value with v8::Null(). + * bindings/v8/custom/V8TreeWalkerCustom.cpp: + (WebCore::toV8): Ditto. + 2009-02-28 Dimitri Glazkov Reviewed by Darin Fisher. diff --git a/WebCore/bindings/v8/custom/V8NodeIteratorCustom.cpp b/WebCore/bindings/v8/custom/V8NodeIteratorCustom.cpp index 85269f3470a7..48e6b8f7bf19 100644 --- a/WebCore/bindings/v8/custom/V8NodeIteratorCustom.cpp +++ b/WebCore/bindings/v8/custom/V8NodeIteratorCustom.cpp @@ -51,7 +51,7 @@ static inline v8::Handle toV8(PassRefPtr object, ExceptionCode return throwError(state->exception()); if (!object) - return v8::Undefined(); + return v8::Null(); return V8Proxy::NodeToV8Object(object.get()); } diff --git a/WebCore/bindings/v8/custom/V8TreeWalkerCustom.cpp b/WebCore/bindings/v8/custom/V8TreeWalkerCustom.cpp index 08fd66bcb28f..baf49c0370b3 100644 --- a/WebCore/bindings/v8/custom/V8TreeWalkerCustom.cpp +++ b/WebCore/bindings/v8/custom/V8TreeWalkerCustom.cpp @@ -49,7 +49,7 @@ static inline v8::Handle toV8(PassRefPtr object, ScriptState* s return throwError(state->exception()); if (!object) - return v8::Undefined(); + return v8::Null(); return V8Proxy::NodeToV8Object(object.get()); } -- 2.36.0