From a6d53484680949b435c1ed50f3115887e30e7d79 Mon Sep 17 00:00:00 2001 From: darin Date: Fri, 5 May 2006 04:29:22 +0000 Subject: [PATCH] LayoutTests: Reviewed by Darin. - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8594 REGRESSION: Exception on closing a page containing (just) an mp3 * plugins/pluginDocumentView-deallocated-dataSource-expected.txt: Added. * plugins/pluginDocumentView-deallocated-dataSource.html: Added. * plugins/resources: Added. * plugins/resources/orange.mov: Added. WebKit: Reviewed by Darin. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8594 REGRESSION: Exception on closing a page containing (just) an mp3 Test: plugins/pluginDocumentView-deallocated-dataSource.html * Plugins/WebPluginDocumentView.m: (-[WebPluginDocumentView dealloc]): Release the dataSource. (-[WebPluginDocumentView setDataSource:]): Retain the dataSource. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14201 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- LayoutTests/ChangeLog | 12 +++++ ...ntView-deallocated-dataSource-expected.txt | 5 ++ ...inDocumentView-deallocated-dataSource.html | 45 ++++++++++++++++++ LayoutTests/plugins/resources/orange.mov | Bin 0 -> 875 bytes WebKit/ChangeLog | 13 +++++ WebKit/Plugins/WebPluginDocumentView.m | 3 +- 6 files changed, 77 insertions(+), 1 deletion(-) create mode 100644 LayoutTests/plugins/pluginDocumentView-deallocated-dataSource-expected.txt create mode 100644 LayoutTests/plugins/pluginDocumentView-deallocated-dataSource.html create mode 100644 LayoutTests/plugins/resources/orange.mov diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index 08d3dea3a8d3..bd0e73ce2cd0 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,15 @@ +2006-05-04 Mitz Pettel + + Reviewed by Darin. + + - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8594 + REGRESSION: Exception on closing a page containing (just) an mp3 + + * plugins/pluginDocumentView-deallocated-dataSource-expected.txt: Added. + * plugins/pluginDocumentView-deallocated-dataSource.html: Added. + * plugins/resources: Added. + * plugins/resources/orange.mov: Added. + 2006-05-04 Justin Garcia Reviewed by harrison diff --git a/LayoutTests/plugins/pluginDocumentView-deallocated-dataSource-expected.txt b/LayoutTests/plugins/pluginDocumentView-deallocated-dataSource-expected.txt new file mode 100644 index 000000000000..080d2e6a47fa --- /dev/null +++ b/LayoutTests/plugins/pluginDocumentView-deallocated-dataSource-expected.txt @@ -0,0 +1,5 @@ +Test for regression against http://bugzilla.opendarwin.org/show_bug.cgi?id=8594 REGRESSION: Exception on closing a page containing (just) an mp3. + +No crash (or exception) means PASS. + + diff --git a/LayoutTests/plugins/pluginDocumentView-deallocated-dataSource.html b/LayoutTests/plugins/pluginDocumentView-deallocated-dataSource.html new file mode 100644 index 000000000000..1af9c2491e2b --- /dev/null +++ b/LayoutTests/plugins/pluginDocumentView-deallocated-dataSource.html @@ -0,0 +1,45 @@ + + + + + +

+ Test for regression against http://bugzilla.opendarwin.org/show_bug.cgi?id=8594 + REGRESSION: Exception on closing a page containing (just) an mp3. +

+ No crash (or exception) means PASS. +

+ + + diff --git a/LayoutTests/plugins/resources/orange.mov b/LayoutTests/plugins/resources/orange.mov new file mode 100644 index 0000000000000000000000000000000000000000..a17e81b02be06d4037b6c05c9b2b6a9962788ac6 GIT binary patch literal 875 zcmZ`%Jxc>Y5S>jFQbb~rB1(!aEXCRngajo;a)D@t&vzruvM_Nu(Pta z6}0vT2$uGi);hDhXEf-$o9xV+**7=40RSGDUgyYg&PVe=EBr$4BZ}iLQab9kB&8mE z>V*s-w{499;5)#t0O_H)HmLl|%b{jy5^;#hU2|xAmayNG>zS!h?;#BJ$tts|8aX9z z02LhzI}gzgR$xj=lVV&|IyHlY?`KQcLnK3iIUdP>&ctn;Z%Lhy8?|)O4W$yDjvgn1 zvGa*K28wSY9rJaCio7Y>QY+lScA~HyU|qQz*$#~5`#=w3E>o4LDs-57Rfek96{lL) zp-B0%Fh4|LN;=W1OcaR|XrLmAc>gUmdm8<-)TG(*P)++F3^=X?dkECjg(GyVC1_$q zMqv4s)rNEb`7JoUkF|aHw4gO`-&IMCy#y+vZfN!bs`yp=L?S%@y_PX|>QXS{^T_ST zp2Pb5BKpN+X@uu0-Y;&gZ7jhg;3yV_AW;gv!U^6Eu8l|v`ZHuPP>dta&Iua5|7k}E ZV48Ll1G%xwtGnm-((TRt>%{?sg)ejujK=@~ literal 0 HcmV?d00001 diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog index ee261488da1d..8a97238e7777 100644 --- a/WebKit/ChangeLog +++ b/WebKit/ChangeLog @@ -1,3 +1,16 @@ +2006-05-04 Mitz Pettel + + Reviewed by Darin. + + - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8594 + REGRESSION: Exception on closing a page containing (just) an mp3 + + Test: plugins/pluginDocumentView-deallocated-dataSource.html + + * Plugins/WebPluginDocumentView.m: + (-[WebPluginDocumentView dealloc]): Release the dataSource. + (-[WebPluginDocumentView setDataSource:]): Retain the dataSource. + 2006-05-04 Tim Omernick Reviewed by Darin. diff --git a/WebKit/Plugins/WebPluginDocumentView.m b/WebKit/Plugins/WebPluginDocumentView.m index c3d43e3fee86..1ccacefe29d5 100644 --- a/WebKit/Plugins/WebPluginDocumentView.m +++ b/WebKit/Plugins/WebPluginDocumentView.m @@ -60,6 +60,7 @@ [plugin release]; [pluginController destroyAllPlugins]; [pluginController release]; + [_dataSource release]; [super dealloc]; } @@ -84,7 +85,7 @@ if (![self superview]) return; - _dataSource = dataSource; + _dataSource = [dataSource retain]; [pluginController setDataSource:dataSource]; dataSourceHasBeenSet = YES; -- 2.36.0