From 936d9030e7352c1bcc672a1e7bb0ae2f97ea0fe4 Mon Sep 17 00:00:00 2001 From: rjw Date: Tue, 5 Oct 2004 21:38:13 +0000 Subject: [PATCH] Fixed binding layer needs to convert NSNumber-bools to js type boolean not number Reviewed by Ken. * bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@7771 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- JavaScriptCore/ChangeLog | 9 +++++++++ JavaScriptCore/bindings/objc/objc_utility.mm | 6 ++++++ 2 files changed, 15 insertions(+) diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog index 46c83c367d29..021d7206e3d8 100644 --- a/JavaScriptCore/ChangeLog +++ b/JavaScriptCore/ChangeLog @@ -1,3 +1,12 @@ +2004-10-05 Richard Williamson + + Fixed binding layer needs to convert NSNumber-bools to js type boolean not number + + Reviewed by Ken. + + * bindings/objc/objc_utility.mm: + (KJS::Bindings::convertObjcValueToValue): + 2004-10-04 Darin Adler Reviewed by Ken. diff --git a/JavaScriptCore/bindings/objc/objc_utility.mm b/JavaScriptCore/bindings/objc/objc_utility.mm index 5ee5f7dcaa44..b902929bc0f6 100644 --- a/JavaScriptCore/bindings/objc/objc_utility.mm +++ b/JavaScriptCore/bindings/objc/objc_utility.mm @@ -204,6 +204,12 @@ Value KJS::Bindings::convertObjcValueToValue (KJS::ExecState *exec, void *buffer WebScriptObject *jsobject = (WebScriptObject *)*obj; aValue = Object([jsobject _imp]); } + else if ((CFBooleanRef)*obj == kCFBooleanTrue) { + aValue = Boolean(true); + } + else if ((CFBooleanRef)*obj == kCFBooleanFalse) { + aValue = Boolean(false); + } else if (*obj == 0) { return Undefined(); } -- 2.36.0