From 86d9449a0d8978b512fb01cdb0c76d43becee7e3 Mon Sep 17 00:00:00 2001 From: "commit-queue@webkit.org" Date: Wed, 4 Sep 2013 16:39:53 +0000 Subject: [PATCH] [Coordinated Graphics] Remove unused method in CoordinatedGraphicsLayer https://bugs.webkit.org/show_bug.cgi?id=120664 Patch by Jae Hyun Park on 2013-09-04 Reviewed by Darin Adler. CoordinatedGraphicsLayer::hasPendingVisibleChanges is not used as of r148952. * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155045 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebCore/ChangeLog | 13 ++++++++++++ .../coordinated/CoordinatedGraphicsLayer.cpp | 21 ------------------- .../coordinated/CoordinatedGraphicsLayer.h | 1 - 3 files changed, 13 insertions(+), 22 deletions(-) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 1bf3c7bd2ef7..8d94573e4294 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,16 @@ +2013-09-04 Jae Hyun Park + + [Coordinated Graphics] Remove unused method in CoordinatedGraphicsLayer + https://bugs.webkit.org/show_bug.cgi?id=120664 + + Reviewed by Darin Adler. + + CoordinatedGraphicsLayer::hasPendingVisibleChanges is not used as of + r148952. + + * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: + * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h: + 2013-09-04 Hans Muller [CSS Shapes] Revise the ShapeInterval set operations' implementation diff --git a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp index 77dc0e1e9b50..83305e0c02fe 100644 --- a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp +++ b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp @@ -1069,27 +1069,6 @@ void CoordinatedGraphicsLayer::setNeedsVisibleRectAdjustment() m_pendingVisibleRectAdjustment = true; } -bool CoordinatedGraphicsLayer::hasPendingVisibleChanges() -{ - if (opacity() < 0.01 && !m_animations.hasActiveAnimationsOfType(AnimatedPropertyOpacity)) - return false; - - for (size_t i = 0; i < children().size(); ++i) { - if (toCoordinatedGraphicsLayer(children()[i])->hasPendingVisibleChanges()) - return true; - } - - bool shouldSyncCanvas = false; -#if USE(GRAPHICS_SURFACE) - shouldSyncCanvas = m_pendingCanvasOperation & SyncCanvas; -#endif - - if (!m_shouldSyncLayerState && !m_shouldSyncChildren && !m_shouldSyncFilters && !m_shouldSyncImageBacking && !m_shouldSyncAnimations && !shouldSyncCanvas) - return false; - - return tiledBackingStoreVisibleRect().intersects(tiledBackingStoreContentsRect()); -} - static inline bool isIntegral(float value) { return static_cast(value) == value; diff --git a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h index cfbc2135d844..6105e2311de3 100644 --- a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h +++ b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h @@ -149,7 +149,6 @@ public: void setNeedsVisibleRectAdjustment(); void purgeBackingStores(); - bool hasPendingVisibleChanges(); static void setShouldSupportContentsTiling(bool); CoordinatedGraphicsLayer* findFirstDescendantWithContentsRecursively(); -- 2.36.0