From 5baa655fdacf3002c83b627ee14eba5d6600cca0 Mon Sep 17 00:00:00 2001 From: "oliver@apple.com" Date: Thu, 20 Dec 2007 23:39:39 +0000 Subject: [PATCH] Slight logic reordering in JSImmediate::from(double) Reviewed by Geoff. This gives a 0.1% improvement in SunSpider. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28916 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- JavaScriptCore/ChangeLog | 11 +++++++++++ JavaScriptCore/kjs/JSImmediate.h | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog index 4b52650c64e2..94a13e9d848d 100644 --- a/JavaScriptCore/ChangeLog +++ b/JavaScriptCore/ChangeLog @@ -1,3 +1,14 @@ +2007-12-20 Oliver Hunt + + Reviewed by Geoff. + + Slight logic reordering in JSImmediate::from(double) + + This gives a 0.1% improvement in SunSpider. + + * kjs/JSImmediate.h: + (KJS::JSImmediate::from): + 2007-12-20 Eric Seidel Reviewed by Geoff, then re-rubber-stamped by Geoff after final search/replace and testing. diff --git a/JavaScriptCore/kjs/JSImmediate.h b/JavaScriptCore/kjs/JSImmediate.h index 049b4c71704c..bc0cb161e8c0 100644 --- a/JavaScriptCore/kjs/JSImmediate.h +++ b/JavaScriptCore/kjs/JSImmediate.h @@ -234,7 +234,7 @@ ALWAYS_INLINE JSValue* JSImmediate::from(double d) return 0; // Check for data loss from conversion to int. - if ((intVal != d) || (signbit(d) && !intVal)) + if ((intVal != d) || (!intVal && signbit(d))) return 0; return tag(intVal << 2, NumberType); -- 2.36.0