From 5b249b1fab9947ad26aafb8bdc7b3ae89dd44745 Mon Sep 17 00:00:00 2001 From: "cpugh@apple.com" Date: Tue, 17 Oct 2017 23:38:26 +0000 Subject: [PATCH] [iOS] Don't turn fields yellow after filling credentials https://bugs.webkit.org/show_bug.cgi?id=178411 Reviewed by Wenson Hsieh. * editing/ios/AutofillElements.cpp: (WebCore::AutofillElements::autofill): We don't want to turn fields yellow when filling the user name and password. Remove the code that was causing that to happen. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223585 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebCore/ChangeLog | 11 +++++++++++ Source/WebCore/editing/ios/AutofillElements.cpp | 8 ++------ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index d7e46e6d433b..74d1d12a926b 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,14 @@ +2017-10-17 Chelsea Pugh + + [iOS] Don't turn fields yellow after filling credentials + https://bugs.webkit.org/show_bug.cgi?id=178411 + + Reviewed by Wenson Hsieh. + + * editing/ios/AutofillElements.cpp: + (WebCore::AutofillElements::autofill): We don't want to turn fields yellow when filling the user name + and password. Remove the code that was causing that to happen. + 2017-10-16 Andy Estes [Apple Pay] Add subLocality and subAdministrativeArea to ApplePayPaymentContact and ApplePayError diff --git a/Source/WebCore/editing/ios/AutofillElements.cpp b/Source/WebCore/editing/ios/AutofillElements.cpp index 9ba8a44c596d..75b1a04d4721 100644 --- a/Source/WebCore/editing/ios/AutofillElements.cpp +++ b/Source/WebCore/editing/ios/AutofillElements.cpp @@ -119,14 +119,10 @@ std::optional AutofillElements::computeAutofillElements(RefsetValueForUser(username); - m_username->setAutoFilled(); - } - if (m_password) { + if (m_password) m_password->setValueForUser(password); - m_password->setAutoFilled(); - } } } // namespace WebCore -- 2.36.0