From 3a99fffb9ab98ba600a62c122a03f3f57e53de3b Mon Sep 17 00:00:00 2001 From: "commit-queue@webkit.org" Date: Fri, 19 Aug 2011 23:24:51 +0000 Subject: [PATCH] Unreviewed, rolling out r93426. http://trac.webkit.org/changeset/93426 https://bugs.webkit.org/show_bug.cgi?id=66607 Broke the Mac build by not building gtest.framework anymore (Requested by andersca on #webkit). Patch by Sheriff Bot on 2011-08-19 Source/ThirdParty: * gtest/README.WebKit: * gtest/include/gtest/internal/gtest-port.h: * gtest/msvc/gtest-md.vcproj: * gtest/xcode/Config/General.xcconfig: * gtest/xcode/gtest.xcodeproj/project.pbxproj: Tools: * TestWebKitAPI/Tests/WTF/StringOperators.cpp: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93451 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/ThirdParty/ChangeLog | 15 + Source/ThirdParty/gtest/README.WebKit | 5 - .../gtest/include/gtest/internal/gtest-port.h | 18 - Source/ThirdParty/gtest/msvc/gtest-md.vcproj | 8 +- .../gtest/xcode/Config/General.xcconfig | 2 - .../xcode/gtest.xcodeproj/project.pbxproj | 504 +++++++++++++++++- Tools/ChangeLog | 11 + .../Tests/WTF/StringOperators.cpp | 1 + 8 files changed, 525 insertions(+), 39 deletions(-) diff --git a/Source/ThirdParty/ChangeLog b/Source/ThirdParty/ChangeLog index 175afedf172c..8010090c2be0 100644 --- a/Source/ThirdParty/ChangeLog +++ b/Source/ThirdParty/ChangeLog @@ -1,3 +1,18 @@ +2011-08-19 Sheriff Bot + + Unreviewed, rolling out r93426. + http://trac.webkit.org/changeset/93426 + https://bugs.webkit.org/show_bug.cgi?id=66607 + + Broke the Mac build by not building gtest.framework anymore + (Requested by andersca on #webkit). + + * gtest/README.WebKit: + * gtest/include/gtest/internal/gtest-port.h: + * gtest/msvc/gtest-md.vcproj: + * gtest/xcode/Config/General.xcconfig: + * gtest/xcode/gtest.xcodeproj/project.pbxproj: + 2011-08-18 Dmitry Lomov TestWebKitAPI breaks on Windows due to fast malloc incompatibility. diff --git a/Source/ThirdParty/gtest/README.WebKit b/Source/ThirdParty/gtest/README.WebKit index 8d7cd47ffe69..ddf21844d0ba 100644 --- a/Source/ThirdParty/gtest/README.WebKit +++ b/Source/ThirdParty/gtest/README.WebKit @@ -2,10 +2,5 @@ GTest v.1.5.0 http://googletest.googlecode.com/svn/tags/release-1.5.0/ -2011-08-19 Dmitry Lomov (dslomov@google.com) - - WebKit port of gtest uses universal "new" and "delete" operators from JavaScriptCore. - - removed all dynamic targets from gtest.xcodeproject (we only build static libgtest.a - and statically-linked gtest unit-test runner). - 2011-05-06 Dmitry Lomov (dslomov@google.com) gtest-md.vcproj upgraded to VS 2005 (8.0) format to match the rest of WebKit diff --git a/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h b/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h index 4bab8df9631c..7924437a9f7f 100644 --- a/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h +++ b/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h @@ -177,24 +177,6 @@ #include #endif // !_WIN32_WCE -#include - -#if !PLATFORM(CHROMIUM) && OS(WINDOWS) && !defined(BUILDING_WX__) && !COMPILER(GCC) -#define JS_EXPORTDATA __declspec(dllimport) -#define WEBKIT_EXPORTDATA __declspec(dllimport) -#define WTF_EXPORT_PRIVATE -#define JS_EXPORT_PRIVATE -#define JS_EXPORTCLASS JS_EXPORTDATA -#else -#define JS_EXPORTDATA -#define JS_EXPORTCLASS -#define WEBKIT_EXPORTDATA -#define WTF_EXPORT_PRIVATE -#define JS_EXPORT_PRIVATE -#endif - -#include - #include // NOLINT #include // NOLINT #include // NOLINT diff --git a/Source/ThirdParty/gtest/msvc/gtest-md.vcproj b/Source/ThirdParty/gtest/msvc/gtest-md.vcproj index 6c987e9c3a81..d88d001a97e3 100644 --- a/Source/ThirdParty/gtest/msvc/gtest-md.vcproj +++ b/Source/ThirdParty/gtest/msvc/gtest-md.vcproj @@ -20,7 +20,7 @@ OutputDirectory="$(ConfigurationBuildDir)\lib" IntermediateDirectory="$(ConfigurationBuildDir)\obj\$(ProjectName)" ConfigurationType="4" - InheritedPropertySheets=""$(ProjectDir)\..\..\..\..\WebKitLibraries\win\tools\vsprops\common.vsprops"" + InheritedPropertySheets="$(ProjectDir)\..\..\..\..\WebKitLibraries\win\tools\vsprops\common.vsprops" CharacterSet="2" > + + Unreviewed, rolling out r93426. + http://trac.webkit.org/changeset/93426 + https://bugs.webkit.org/show_bug.cgi?id=66607 + + Broke the Mac build by not building gtest.framework anymore + (Requested by andersca on #webkit). + + * TestWebKitAPI/Tests/WTF/StringOperators.cpp: + 2011-08-19 James Robinson [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker diff --git a/Tools/TestWebKitAPI/Tests/WTF/StringOperators.cpp b/Tools/TestWebKitAPI/Tests/WTF/StringOperators.cpp index db3243a9a701..985964be747c 100644 --- a/Tools/TestWebKitAPI/Tests/WTF/StringOperators.cpp +++ b/Tools/TestWebKitAPI/Tests/WTF/StringOperators.cpp @@ -23,6 +23,7 @@ * THE POSSIBILITY OF SUCH DAMAGE. */ +#define JS_EXPORTDATA #define WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() (++wtfStringCopyCount) static int wtfStringCopyCount; -- 2.36.0