From 31d43ffea5c928beb6170b071b67cbd981db83de Mon Sep 17 00:00:00 2001 From: darin Date: Wed, 10 May 2006 05:43:14 +0000 Subject: [PATCH 1/1] LayoutTests: - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8781 REGRESSION: image maps with "poly" areas, including one at lisp.geek.nz, don't work * fast/replaced/image-map.html: Added. * fast/replaced/image-map-expected.txt: Added. WebCore: Reviewed by Hyatt. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8781 REGRESSION: image maps with "poly" areas, including one at lisp.geek.nz, don't work * html/html_imageimpl.cpp: (WebCore::HTMLAreaElement::getRegion): Remove extra Path definition that was shadowing the real one. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14275 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- LayoutTests/ChangeLog | 8 ++++++++ .../fast/replaced/image-map-expected.txt | 3 +++ LayoutTests/fast/replaced/image-map.html | 17 +++++++++++++++++ WebCore/ChangeLog | 10 ++++++++++ WebCore/html/html_imageimpl.cpp | 1 - 5 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 LayoutTests/fast/replaced/image-map-expected.txt create mode 100644 LayoutTests/fast/replaced/image-map.html diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index f122261f8446..c5f6b3594687 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,11 @@ +2006-05-09 Darin Adler + + - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8781 + REGRESSION: image maps with "poly" areas, including one at lisp.geek.nz, don't work + + * fast/replaced/image-map.html: Added. + * fast/replaced/image-map-expected.txt: Added. + 2006-05-09 Darin Adler - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6310 diff --git a/LayoutTests/fast/replaced/image-map-expected.txt b/LayoutTests/fast/replaced/image-map-expected.txt new file mode 100644 index 000000000000..7de563c89463 --- /dev/null +++ b/LayoutTests/fast/replaced/image-map-expected.txt @@ -0,0 +1,3 @@ + +area clicked + diff --git a/LayoutTests/fast/replaced/image-map.html b/LayoutTests/fast/replaced/image-map.html new file mode 100644 index 000000000000..2edc91f4eab0 --- /dev/null +++ b/LayoutTests/fast/replaced/image-map.html @@ -0,0 +1,17 @@ + + + + +

+ +

no area click seen yet

+ diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog index 1b3cf7ba7b47..96bf0bc3c0b7 100644 --- a/WebCore/ChangeLog +++ b/WebCore/ChangeLog @@ -1,3 +1,13 @@ +2006-05-09 Darin Adler + + Reviewed by Hyatt. + + - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8781 + REGRESSION: image maps with "poly" areas, including one at lisp.geek.nz, don't work + + * html/html_imageimpl.cpp: (WebCore::HTMLAreaElement::getRegion): Remove extra Path + definition that was shadowing the real one. + 2006-05-09 Darin Adler - fix build diff --git a/WebCore/html/html_imageimpl.cpp b/WebCore/html/html_imageimpl.cpp index 858807403872..6ba00f5c8305 100644 --- a/WebCore/html/html_imageimpl.cpp +++ b/WebCore/html/html_imageimpl.cpp @@ -597,7 +597,6 @@ Path HTMLAreaElement::getRegion(int width, int height) const switch (shape) { case Poly: if (m_coordsLen >= 6) { - Path path; int numPoints = m_coordsLen / 2; path.moveTo(FloatPoint(m_coords[0].calcMinValue(width), m_coords[1].calcMinValue(height))); for (int i = 1; i < numPoints; ++i) -- 2.36.0