From 2ab06f63b3cec422c6985a9ad4312055dd606209 Mon Sep 17 00:00:00 2001 From: "mrowe@apple.com" Date: Tue, 21 Dec 2010 00:06:47 +0000 Subject: [PATCH] Don't install header files in to the Resources directory. Reviewed by Dan Bernstein. Tools: * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the Resources directory. WebCore: * WebCore.xcodeproj/project.pbxproj: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74375 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Tools/ChangeLog | 9 +++++++++ Tools/Scripts/check-for-inappropriate-files-in-framework | 2 +- WebCore/ChangeLog | 8 ++++++++ WebCore/WebCore.xcodeproj/project.pbxproj | 2 -- 4 files changed, 18 insertions(+), 3 deletions(-) diff --git a/Tools/ChangeLog b/Tools/ChangeLog index 80a05d1c21da..009f05b41ab5 100644 --- a/Tools/ChangeLog +++ b/Tools/ChangeLog @@ -1,3 +1,12 @@ +2010-12-20 Mark Rowe + + Reviewed by Dan Bernstein. + + Don't install header files in to the Resources directory. + + * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the + Resources directory. + 2010-12-20 Eric Seidel Reviewed by Adam Barth. diff --git a/Tools/Scripts/check-for-inappropriate-files-in-framework b/Tools/Scripts/check-for-inappropriate-files-in-framework index a323bc4174a6..1ab71b222eb0 100755 --- a/Tools/Scripts/check-for-inappropriate-files-in-framework +++ b/Tools/Scripts/check-for-inappropriate-files-in-framework @@ -27,7 +27,7 @@ base_directory = ENV['TARGET_BUILD_DIR'] or throw "Unable to find TARGET_BUILD_D project_name = ENV['PROJECT_NAME'] or throw "Unable to find PROJECT_NAME in the environment!" is_shallow_bundle = (ENV['SHALLOW_BUNDLE'] || "NO").upcase == "YES" -$INAPPROPRIATE_FILES = { "WebCore" => { "Resources" => ["*.css", "*.in", "*.idl"] } } +$INAPPROPRIATE_FILES = { "WebCore" => { "Resources" => ["*.css", "*.in", "*.idl", "*.h"] } } Dir.chdir base_directory diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog index 8e99e663bf5b..186e56c0306e 100644 --- a/WebCore/ChangeLog +++ b/WebCore/ChangeLog @@ -1,3 +1,11 @@ +2010-12-20 Mark Rowe + + Reviewed by Dan Bernstein. + + Don't install header files in to the Resources directory. + + * WebCore.xcodeproj/project.pbxproj: + 2010-12-20 Andrei Popescu Reviewed by Jeremy Orlow. diff --git a/WebCore/WebCore.xcodeproj/project.pbxproj b/WebCore/WebCore.xcodeproj/project.pbxproj index fcf300935f25..3052fc1b1ba2 100644 --- a/WebCore/WebCore.xcodeproj/project.pbxproj +++ b/WebCore/WebCore.xcodeproj/project.pbxproj @@ -5414,7 +5414,6 @@ E1284BD61044A01E00EAEB52 /* DOMPageTransitionEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = E1284BD41044A01E00EAEB52 /* DOMPageTransitionEvent.h */; }; E12EDB7B0B308A78002704B6 /* EventTarget.h in Headers */ = {isa = PBXBuildFile; fileRef = E12EDB7A0B308A78002704B6 /* EventTarget.h */; settings = {ATTRIBUTES = (Private, ); }; }; E12EDBEA0B308E0B002704B6 /* EventTarget.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E12EDBE90B308E0B002704B6 /* EventTarget.cpp */; }; - E13F01EB1270E10D00DFBA71 /* CookieStorage.h in Resources */ = {isa = PBXBuildFile; fileRef = E13F01EA1270E10D00DFBA71 /* CookieStorage.h */; }; E13F01F11270E19000DFBA71 /* CookieStorageMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = E13F01F01270E19000DFBA71 /* CookieStorageMac.mm */; }; E15A36D71104572000B7B639 /* XMLNSNames.h in Headers */ = {isa = PBXBuildFile; fileRef = E15A36D61104572000B7B639 /* XMLNSNames.h */; }; E15A36D91104572700B7B639 /* XMLNSNames.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E15A36D81104572700B7B639 /* XMLNSNames.cpp */; }; @@ -22310,7 +22309,6 @@ 46F9D5DD0B0D60170028EE36 /* aliasCursor.png in Resources */, 46D4F2490AF97E810035385A /* cellCursor.png in Resources */, 46D4F24A0AF97E810035385A /* contextMenuCursor.png in Resources */, - E13F01EB1270E10D00DFBA71 /* CookieStorage.h in Resources */, 4614A1FE0B23A8D600446E1C /* copyCursor.png in Resources */, 464EA2730B8A350B00A8E6E3 /* crossHairCursor.png in Resources */, 1C14E76C0AD8C81C00B6158B /* deleteButton.tiff in Resources */, -- 2.36.0