From 0604899c8e3eddf18fd3d21d79598877e8922736 Mon Sep 17 00:00:00 2001 From: "ojan@chromium.org" Date: Tue, 22 Feb 2011 03:59:52 +0000 Subject: [PATCH] 2011-02-21 Ojan Vafai Reviewed by Adam Barth. [codereviewtool] focus comment on accept https://bugs.webkit.org/show_bug.cgi?id=54930 * code-review.js: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79283 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Websites/bugs.webkit.org/ChangeLog | 9 +++++++++ Websites/bugs.webkit.org/code-review.js | 7 +++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog index b6823481d8f3..0746ba28cbde 100644 --- a/Websites/bugs.webkit.org/ChangeLog +++ b/Websites/bugs.webkit.org/ChangeLog @@ -1,3 +1,12 @@ +2011-02-21 Ojan Vafai + + Reviewed by Adam Barth. + + [codereviewtool] focus comment on accept + https://bugs.webkit.org/show_bug.cgi?id=54930 + + * code-review.js: + 2011-02-20 Ojan Vafai Reviewed by Adam Barth. diff --git a/Websites/bugs.webkit.org/code-review.js b/Websites/bugs.webkit.org/code-review.js index b3917450b783..00efb367459c 100644 --- a/Websites/bugs.webkit.org/code-review.js +++ b/Websites/bugs.webkit.org/code-review.js @@ -1352,7 +1352,8 @@ var CODE_REVIEW_UNITTEST; } function acceptComment(comment) { - freezeComment(comment); + var frozen_comment = freezeComment(comment); + focusOn(frozen_comment); saveDraftComments(); } @@ -1375,7 +1376,9 @@ var CODE_REVIEW_UNITTEST; } var line_id = comment_textarea.attr('data-comment-for'); var line = $('#' + line_id) - findCommentBlockFor(line).hide().after($('
').text(comment_textarea.val())); + var frozen_comment = $('
').text(comment_textarea.val()); + findCommentBlockFor(line).hide().after(frozen_comment); + return frozen_comment; } function focusOn(node) { -- 2.36.0