WebKit-https.git
10 years agoFixed Layout Mode should be adjustable from layoutTestController for testing on Chrom...
fsamuel@chromium.org [Thu, 8 Sep 2011 19:20:27 +0000 (19:20 +0000)]
Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
https://bugs.webkit.org/show_bug.cgi?id=67723

Reviewed by Adam Barth.

Tools:

* DumpRenderTree/chromium/EventSender.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::enableFixedLayoutMode):
(LayoutTestController::setFixedLayoutSize):
* DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

* platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added.
* platform/chromium/fast/repaint/fixed-layout-360x240-expected.txt: Added.
* platform/chromium/fast/repaint/fixed-layout-360x240.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactor hyphen measurement
commit-queue@webkit.org [Thu, 8 Sep 2011 19:18:43 +0000 (19:18 +0000)]
Refactor hyphen measurement
https://bugs.webkit.org/show_bug.cgi?id=67728

Patch by Ned Holbrook <nholbrook@apple.com> on 2011-09-08
Reviewed by Darin Adler.

No new tests, purely refactoring.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::measureHyphenWidth): Added.
(WebCore::setLogicalWidthForTextRun): Use measureHyphenWidth().
(WebCore::tryHyphenating): Ditto.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove LayoutStateDisabler instances from RenderLayer
jchaffraix@webkit.org [Thu, 8 Sep 2011 18:54:33 +0000 (18:54 +0000)]
Remove LayoutStateDisabler instances from RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=66896

Reviewed by Simon Fraser.

As part of r93614, scrollTo does not call updateLayerPositions anymore.
This means that we don't need to disable LayoutState from the scrolling code
in RenderLayer.

This change is covered by the existing tests.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions): Updated the comment
that was not accurate anymore. Also explained what is wrong with
LayoutState vs RenderLayer now. Note that the ASSERT is still
valid and will not trigger as the remaining calls to updateLayerPositions
are done *outside* layout() where LayoutState is not set (thus disabled).

(WebCore::RenderLayer::updateScrollInfoAfterLayout): Removed
2 LayoutStateDisabler surrounding scrollToOffset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFactor out the code to get the first non-null RenderTableSection in RenderTable
jchaffraix@webkit.org [Thu, 8 Sep 2011 18:53:02 +0000 (18:53 +0000)]
Factor out the code to get the first non-null RenderTableSection in RenderTable
https://bugs.webkit.org/show_bug.cgi?id=66972

Reviewed by Darin Adler.

Refactoring only, covered by existing tests.

* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::cellForColumnAndRow):
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::rowIndexRange):
Updated those for the signature change in sectionBelow. Also added
a FIXME where topSection should be used instead of iterating
over the section (and likely missing some corner cases).

* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::outerBorderBefore):
(WebCore::RenderTable::sectionAbove):
(WebCore::RenderTable::sectionBelow):
(WebCore::RenderTable::firstLineBoxBaseline):
Updated all those functions to use the newly added functions. Also changed
the variable names to match the functions.

(WebCore::RenderTable::layout):
(WebCore::RenderTable::topNonEmptySection): Newly added function
that returns the top non null section of the table that has at least a
row.

(WebCore::RenderTable::cellAbove):
(WebCore::RenderTable::cellBelow):
Update the signature of those 2 functions to take an enum as it makes the
rest of the code more readable.

* rendering/RenderTable.h:
(WebCore::RenderTable::topSection): Newly added function to return
the top non null section in the table.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Ryosuke Niwa.
eric@webkit.org [Thu, 8 Sep 2011 18:46:01 +0000 (18:46 +0000)]
Reviewed by Ryosuke Niwa.

[BiDi] [CSS3] MASTER: Add support for the unicode-bidi:isolate CSS property
https://bugs.webkit.org/show_bug.cgi?id=50912

Source/WebCore:

This patch adds support for CSS3 unicode-bidi: isolate property, under the -webkit- vendor prefix.
Parsing support was added in a previous patch, this wires up the RenderStyle values
to code changes in the BidiResolver.

The effect of this patch is that it makes it possible to "isolate" runs of text
so that their RTL-ness or LTR-ness does not bleed out into the rest of your text
and effect layout.  This is important because many unicode characters (like parenthesis, ':', '-', etc.)
do not have intrinsic directionality and are affected by whatever characters come before/after.
If you have usernames which include RTL text, if you inject those usernames in your page
you might end up with nearby characters moving!
(like 'RTL USERNAME - my awesome site' as a title, could end up as
'my awesome site - USERNAME RTL' when correct would be 'USERNAME RTL - my awesome site'.)
This patch makes it possible to wrap sections of text in isolated spans, so that
they correctly order all their RTL/LTR contents, but also correctly participate in the
larger RTL/LTR ordering without affecting nearby characters.

Because much of this code is old and rarely touched, I've included extra background
information in hopes of expanding my set of potential reviewers:

WebKit uses the standard "Unicode Bidi Algorithm" henceforth known as the UBA.
The UBA is defined at http://unicode.org/reports/tr9/ for those not faint of heart.

Text layout is done per-block (<div>, <p>, etc), and begins with a string of text
(which in our case comes from the rendering tree) and a specified width.
First:  Text is measured and wrapped into lines.
Second: The UBA is run over the lines of text.
Third:  WebKit builds InlineBoxes (its linebox tree) and eventually render the text.

This patch modifies our UBA to ignore all text content inside "isolated" inlines (treating them as neutral characters)
and then adds another step after running the UBA, where we run the UBA recursively on any
previously identified "isolated" content.

The result of the UBA is an ordered list of "runs" of text with the RTL runs
correctly RTL and the LTR runs LTR.

The UBA does three things:
1.  It assigns a "class" to each character in a text stream (like neutral, strongly-RTL, strongly-LTR, etc.)
2.  Divides the text stream up into "runs" of characters of the same directionality (all RTL, all LTR).
3.  Re-orders those runs.

The UBA in WebKit is implemented by BidiResolver<T> in BidiResolver.h

The InlineBidiResolver (BidiResolver specialization which knows about the rendering tree)
walks along its InlineIterators, looking at each character and running the
Unicode Bidi Algorithm (UBA).  It walks through the rendering tree subtree under
a block, using a (poorly named) bidiNext function which returns the next inline object.
Each inline object (or text character there-in) has a corresponding meaning in the UBA
such as a "strong RTL" character or a "neutral" character.  The UBA reads these sequence
of characters, and figures out what direction (RTL or LTR) to assign to any neutral
characters it encounters, based on surrounding characters.

As the InlineBidiResolver is walking the rendering tree, the InlineIterator::advance()
function calls bidiNext(), which in turn can call notifyObserverEnteredObject/notifyObserverWillExitObject
notifying InlineBidiResolver that it is entering or exiting an "isolated"
span, at which point it will either start or stop ignoring the stream of characters
from the InlineIterator.  When the InlineBidiResolver is ignoring the stream of
characters, instead of creating separate BidiRuns at each RTL/LTR boundary
as it normally would, it instead creates one "fake" run for the entire
isolated span.  These fake runs participate in the normal UBA run ordering process,
but after the main UBA, a second pass is made where we examine
the list of isolatedRuns() and run the UBA on each of them, replacing the fake
run we previously inserted, with the resulting list of runs from that inner UBA run.
The way it "ignores" characters is by treating them all as neutral when inside an isolate.
Thus all the characters end up grouped in a single run, but their directionality (as a group)
is correctly affected by any surrounding strong characters.

If you understood that last paragraph, than the rest of the change is just plumbing.

I added a huge number of FIXMEs to this code, because this code has a variety of
design choices (or lack there of) which make some of this very difficult.

For example the bidiNext iterator function has two sets of mutually exclusive
parameters and can be used optionally with or without an observer.  Prior to this
change there was only ever one object which cared about observing a walk over inlines
and that was InlineBidiResolver.  This patch (regretfully) templatizes bidiNext
to support a new Observer type.  The correct fix would be to rip bidiNext into
multiple functions and rip need for observation out of InlineBidiResolver.
Unfortunately I've tried both in separate bugs and failed.  This code is very very
old and very poorly understood.  We're slowly moving forward, this is another tiny step.

This is my fourth iteration of this patch (I'm happy to do more!), but I believe
it's a good compromise between fixing all of the design gotcha's of our bidi
system and doing the minimum amount to add this killer CSS feature.

I ran the PLT.  (It averaged 0.2% faster with this change, but I attribute that to noise).

Test: css3/unicode-bidi-isolate-basic.html and css3/unicode-bidi-isolate-aharon.html

* platform/text/BidiResolver.h:
(WebCore::BidiCharacterRun::setNext):
 - Needed by the new replaceRunWithRuns function.
(WebCore::BidiResolver::BidiResolver):
(WebCore::BidiResolver::~BidiResolver):
(WebCore::BidiResolver::enterIsolate):
(WebCore::BidiResolver::exitIsolate):
(WebCore::BidiResolver::inIsolate):
(WebCore::BidiResolver::isolatedRuns):
 - Used to track isolated spans of text as they're encoutered.
   They're stuffed away here to be processed recursively
   after the main UBA has done its thang.
(WebCore::::appendRun):
(WebCore::::embed):
(WebCore::::commitExplicitEmbedding):
(WebCore::::createBidiRunsForLine):
* platform/text/BidiRunList.h:
(WebCore::::replaceRunWithRuns):
 - This effectively takes all the runs from one runlist and adds them to
   this one, replacing the fake run we inserted during a previous pass of the UBA.
 - This RunList now owns the runs, so we call clear() on the other RunList
   so that we don't end up double-freeing the runs.
(WebCore::::clear):
 - This allows us to "take" runs from another run list and then clear it.
* rendering/BidiRun.h:
(WebCore::BidiRun::object):
* rendering/InlineIterator.h:
(WebCore::InlineIterator::object):
(WebCore::InlineIterator::offset):
(WebCore::notifyObserverEnteredObject): Mostly just renaming and adding a FIXME about plaintext.
(WebCore::notifyObserverWillExitObject): Mostly just renaming.
(WebCore::addPlaceholderRunForIsolatedInline):
(WebCore::isIsolatedInline):
(WebCore::InlineBidiResolver::appendRun):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::statusWithDirection):
(WebCore::constructBidiRuns):
 - This is the heavy-lifting of this change.  This function
   runs the UBA recursively on all the previously identified isolated spans.
 - If we encounter more isolated spans in our run, we just add them to the
   main list an keep going.  Because the runs are linked lists and we have
   direct pointers to our placeholder objects, we don't care what order
   we process the placeholders in, so long as when we're done, they're all processed.
(WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

Two new tests for testing unicode-bidi: isolate behavior.
Note that the test from Aharon Lanin has one failing subtest
I've asked him if the test might have a typo in:
https://bugs.webkit.org/show_bug.cgi?id=50912#c30

* css3/unicode-bidi-isolate-aharon.html: Added.
 - Some various unicode-bidi: isolate tests from Aharon.
* css3/unicode-bidi-isolate-basic.html: Added.
 - This test tries all possible orderings of strong-LTR, strong-RTL and neutral characters
   across unicode-bidi: isolate spans to make sure that we match expected rendering.
 - A little red bleeds through the test, but that appears to be from anti-aliasing
   and possible automatic font kerning, not layout failures.
* platform/mac/css3/unicode-bidi-isolate-aharon-expected.png: Added.
* platform/mac/css3/unicode-bidi-isolate-aharon-expected.txt: Added.
* platform/mac/css3/unicode-bidi-isolate-basic-expected.png: Added.
* platform/mac/css3/unicode-bidi-isolate-basic-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove getUInt32 from JSCell
commit-queue@webkit.org [Thu, 8 Sep 2011 18:41:55 +0000 (18:41 +0000)]
Remove getUInt32 from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67691

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-08
Reviewed by Oliver Hunt.

 We don't use JSCell::getUInt32 anymore, so it has been removed.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSCell.cpp:
* runtime/JSCell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate tests for inherit and initial values for -webkit-columns and related CSS prope...
macpherson@chromium.org [Thu, 8 Sep 2011 18:38:13 +0000 (18:38 +0000)]
Update tests for inherit and initial values for -webkit-columns and related CSS properties.
https://bugs.webkit.org/show_bug.cgi?id=67685

Reviewed by Eric Seidel.

* fast/multicol/inherit-column-values-expected.txt:
* fast/multicol/inherit-column-values.html:
* fast/multicol/initial-column-values-expected.txt:
* fast/multicol/initial-column-values.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSplit Tap gesture detection into TapDown and Tap.
commit-queue@webkit.org [Thu, 8 Sep 2011 18:30:40 +0000 (18:30 +0000)]
Split Tap gesture detection into TapDown and Tap.
We need this distinction to highlight links when they are first touched. The link is
followed only if the tap is completed, otherwise, if a scroll is detected, the highlight
goes away.
https://bugs.webkit.org/show_bug.cgi?id=67645

Patch by Varun Jain <varunjain@google.com> on 2011-09-08
Reviewed by Dimitri Glazkov.

*  Source/WebCore/page/EventHandler.cpp:
*  Source/WebCore/platform/PlatformGestureEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement a ProgressEvent constructor for JSC
commit-queue@webkit.org [Thu, 8 Sep 2011 18:28:42 +0000 (18:28 +0000)]
Implement a ProgressEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=67537

Patch by Kentaro Hara <haraken@google.com> on 2011-09-08
Reviewed by Sam Weinig.

Source/WebCore:

The spec for the ProgressEvent constructor is here:
http://www.w3.org/TR/progress-events/#interface-progressevent

Test: fast/events/constructors/progress-event-constructor.html

* bindings/generic/EventConstructors.h: Added a definition for the ProgressEvent constructor.
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Converts an ECMA-262 Number into an IDL unsigned long long value. Spec: http://www.w3.org/TR/WebIDL/#es-unsigned-long-long
* bindings/js/JSEventConstructors.cpp: Added #includes for ProgressEvent.
* dom/ProgressEvent.cpp:
(WebCore::ProgressEventInit::ProgressEventInit):
(WebCore::ProgressEvent::ProgressEvent):
* dom/ProgressEvent.h: Added a definition for ProgressEventInit.
(WebCore::ProgressEvent::create):
* dom/ProgressEvent.idl: Makes ProgressEvent constructible.

LayoutTests:

* fast/events/constructors/progress-event-constructor-expected.txt: Added.
* fast/events/constructors/progress-event-constructor.html: Added. Checks the behavior of the ProgressEvent constructor.
* platform/chromium/test_expectations.txt: Skipped progress-event-constructor.html, since V8 does not yet have the ProgressEvent constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-08 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 8 Sep 2011 18:22:11 +0000 (18:22 +0000)]
2011-09-08  Nate Chapin  <japhet@chromium.org>

        Rebaseline svg/W3C-SVG-1.1-SE/filters-image-05-f.svg text for chromium win/linux.

        * platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Removed.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTest how animation methods react to too few arguments
commit-queue@webkit.org [Thu, 8 Sep 2011 18:18:57 +0000 (18:18 +0000)]
Test how animation methods react to too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66539

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-09-08
Reviewed by Darin Adler.

* fast/animation/request-animation-frame-missing-arguments-expected.txt: Added.
* fast/animation/request-animation-frame-missing-arguments.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a layout test for the case where an accesskey is defined in shadow DOM.
hayato@chromium.org [Thu, 8 Sep 2011 18:14:59 +0000 (18:14 +0000)]
Add a layout test for the case where an accesskey is defined in shadow DOM.

https://bugs.webkit.org/show_bug.cgi?id=67096

Reviewed by Dimitri Glazkov.

* fast/dom/shadow/access-key-expected.txt: Added.
* fast/dom/shadow/access-key.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome file-url-mimetypes subtests fail on rare extensions
ap@apple.com [Thu, 8 Sep 2011 18:05:05 +0000 (18:05 +0000)]
Some file-url-mimetypes subtests fail on rare extensions
https://bugs.webkit.org/show_bug.cgi?id=67679

Reviewed by Darin Adler.

* platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
* platform/mac/fast/loader/file-url-mimetypes-2.html:
* platform/mac/fast/loader/file-url-mimetypes-expected.txt:
* platform/mac/fast/loader/file-url-mimetypes.html:
It doesn't appear important to investigate why a few subtests fail on some machines, so
just removing those.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake bindings tests quiet after r94701.
rniwa@webkit.org [Thu, 8 Sep 2011 17:41:48 +0000 (17:41 +0000)]
Make bindings tests quiet after r94701.

* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObjPrototype::JSTestObjPrototype):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Some cookie related tests fail on Lion
ap@apple.com [Thu, 8 Sep 2011 17:18:32 +0000 (17:18 +0000)]
    Some cookie related tests fail on Lion
        https://bugs.webkit.org/show_bug.cgi?id=67674

        Reviewed by Mark Rowe.

        Use private browsing mode to work around a CFNetwork issue where these tests can affect each
        other's results. This should not affect their behavior in any other way.

        * http/tests/security/cookies/third-party-cookie-blocking-main-frame.html:
        * http/tests/security/cookies/third-party-cookie-blocking-user-action.html:
        * http/tests/security/cookies/third-party-cookie-blocking.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline filters-image-05-f.svg expected output (text) for SnowLeopard.
rniwa@webkit.org [Thu, 8 Sep 2011 17:09:31 +0000 (17:09 +0000)]
Rebaseline filters-image-05-f.svg expected output (text) for SnowLeopard.
https://bugs.webkit.org/show_bug.cgi?id=67781

Unreviewed rebaseline for Mac.

* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-08 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 8 Sep 2011 16:56:06 +0000 (16:56 +0000)]
2011-09-08  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium expectations tweaks.

        * platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: get rid of RawSourceCode.createSourceMappingIfNeeded.
podivilov@chromium.org [Thu, 8 Sep 2011 16:38:22 +0000 (16:38 +0000)]
Web Inspector: get rid of RawSourceCode.createSourceMappingIfNeeded.
https://bugs.webkit.org/show_bug.cgi?id=67717

Source/WebCore:

Listen to SourceMappingUpdated event instead of using createSourceMappingIfNeeded.

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._createPresentationMessage):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.messagesForUISourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationCallFrame.prototype.sourceLine.sourceMappingUpdated):
(WebInspector.PresentationCallFrame.prototype.sourceLine):
* inspector/front-end/SourceFile.js:

LayoutTests:

Merge source-file.html into raw-source-code.html.

Reviewed by Yury Semikhatsky.

* inspector/debugger/raw-source-code.html:
* inspector/debugger/source-file.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; removed one erroneous baseline (Skia on Mac)
caryclark@google.com [Thu, 8 Sep 2011 16:03:40 +0000 (16:03 +0000)]
Unreviewed; removed one erroneous baseline (Skia on Mac)

* platform/chromium-mac/fast/frames/lots-of-objects-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: do not re-create RawSourceCode when toggling pretty-print mode.
podivilov@chromium.org [Thu, 8 Sep 2011 15:05:35 +0000 (15:05 +0000)]
Web Inspector: do not re-create RawSourceCode when toggling pretty-print mode.
https://bugs.webkit.org/show_bug.cgi?id=67647

1) Implement RawSourceCode.setFormatted that allows toggling pretty-print mode on the fly without resetting everything.
2) Add RawSourceCode unit tests.
3) Remove source mapping listeners and console messages from presentation model (they live in RawSourceCode now).

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/raw-source-code.html

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):

LayoutTests:

* inspector/debugger/raw-source-code-expected.txt: Added.
* inspector/debugger/raw-source-code.html: Added.
* inspector/debugger/script-formatter.html:
* inspector/debugger/source-file.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; new baselines (Skia on Mac, next chunk of files)
caryclark@google.com [Thu, 8 Sep 2011 14:46:01 +0000 (14:46 +0000)]
Unreviewed; new baselines (Skia on Mac, next chunk of files)
Updated newer tests with reference images.
Deleted images with correct fallbacks.

* platform/chromium-mac/http/tests/eventsource: Added.
(remaining files omitted for brevity)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: [REGRESSION] Clear console shortcut Ctrl + L broken
apavlov@chromium.org [Thu, 8 Sep 2011 13:58:27 +0000 (13:58 +0000)]
Web Inspector: [REGRESSION] Clear console shortcut Ctrl + L broken
https://bugs.webkit.org/show_bug.cgi?id=67711

Reviewed by Yury Semikhatsky.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._registerShortcuts):
(WebInspector.ConsoleView.prototype._promptKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Build fails with strict compiler
abecsi@webkit.org [Thu, 8 Sep 2011 13:52:04 +0000 (13:52 +0000)]
[Qt] Build fails with strict compiler
https://bugs.webkit.org/show_bug.cgi?id=67778

Reviewed by Csaba Osztrogonác.

Source/ThirdParty/ANGLE:

* src/compiler/glslang_lex.cpp: Regenerate with generate_glslang_lexer.sh using a newer flex
to suppress warning and fix the build when using [-Werror=unused-result]

Source/WebCore:

No new tests needed.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::resizeEdgeTiles): Remove unused contentsRect variable
which's usage was removed in r94681 to fix the build with [-Werror=unused-but-set-variable].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][Mac] Unreviewed gardening.
ossy@webkit.org [Thu, 8 Sep 2011 13:44:19 +0000 (13:44 +0000)]
[Qt][Mac] Unreviewed gardening.

* platform/qt-mac/Skipped: Skip a new failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r94695.
commit-queue@webkit.org [Thu, 8 Sep 2011 12:58:17 +0000 (12:58 +0000)]
Unreviewed, rolling out r94695.
http://trac.webkit.org/changeset/94695
https://bugs.webkit.org/show_bug.cgi?id=67776

Hitting an assertion on Snow Leopard, Qt, GTK (Requested by
Zoltan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-08

Source/WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionedFloatsNeedRelayout):
(WebCore::RenderBlock::layoutPositionedObjects):

LayoutTests:

* fast/block/positioning/absolute-layout-after-image-load-expected.txt: Removed.
* fast/block/positioning/absolute-layout-after-image-load.html: Removed.
* fast/block/positioning/positioned-float-layout-after-image-load-expected.txt: Removed.
* fast/block/positioning/positioned-float-layout-after-image-load.html: Removed.
* fast/block/positioning/resources/absolute-layout-after-image-load-2.html: Removed.
* fast/block/positioning/resources/positioned-float-layout-after-image-load-2.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, strip trailing whitespace in the Web Inspector frontend (*.js and *.css).
apavlov@chromium.org [Thu, 8 Sep 2011 12:15:53 +0000 (12:15 +0000)]
Unreviewed, strip trailing whitespace in the Web Inspector frontend (*.js and *.css).

* inspector/front-end/ApplicationCacheItemsView.js:
* inspector/front-end/AuditResultView.js:
* inspector/front-end/BinarySearch.js:
* inspector/front-end/CSSStyleModel.js:
* inspector/front-end/ConsoleMessage.js:
* inspector/front-end/ConsoleModel.js:
* inspector/front-end/ConsoleView.js:
* inspector/front-end/CookieItemsView.js:
* inspector/front-end/CookieParser.js:
* inspector/front-end/DOMAgent.js:
* inspector/front-end/DOMStorage.js:
* inspector/front-end/DOMStorageItemsView.js:
* inspector/front-end/DataGrid.js:
* inspector/front-end/Database.js:
* inspector/front-end/DatabaseQueryView.js:
* inspector/front-end/DetailedHeapshotGridNodes.js:
* inspector/front-end/DetailedHeapshotView.js:
* inspector/front-end/ElementsTreeOutline.js:
* inspector/front-end/EmptyView.js:
* inspector/front-end/EventListenersSidebarPane.js:
* inspector/front-end/ExtensionCommon.js:
* inspector/front-end/GoToLineDialog.js:
* inspector/front-end/HeapSnapshot.js:
* inspector/front-end/HeapSnapshotProxy.js:
* inspector/front-end/HeapSnapshotWorkerDispatcher.js:
* inspector/front-end/ImageView.js:
* inspector/front-end/InjectedFakeWorker.js:
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/MetricsSidebarPane.js:
* inspector/front-end/NetworkManager.js:
* inspector/front-end/NetworkPanel.js:
* inspector/front-end/ObjectPropertiesSection.js:
* inspector/front-end/PartialQuickSort.js:
* inspector/front-end/ProfileView.js:
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/RemoteObject.js:
* inspector/front-end/Resource.js:
* inspector/front-end/ResourceCategory.js:
* inspector/front-end/ResourceHTMLView.js:
* inspector/front-end/ResourceHeadersView.js:
* inspector/front-end/ResourceJSONView.js:
* inspector/front-end/ResourceTimingView.js:
* inspector/front-end/ResourceTreeModel.js:
* inspector/front-end/ResourceView.js:
* inspector/front-end/ResourcesPanel.js:
* inspector/front-end/SearchController.js:
* inspector/front-end/SettingsScreen.js:
* inspector/front-end/ShortcutsScreen.js:
* inspector/front-end/SourceCSSTokenizer.js:
* inspector/front-end/SourceHTMLTokenizer.js:
* inspector/front-end/SourceJavaScriptTokenizer.js:
* inspector/front-end/StatusBarButton.js:
* inspector/front-end/TextEditorModel.js:
* inspector/front-end/TimelineGrid.js:
* inspector/front-end/View.js:
* inspector/front-end/heapProfiler.css:
* inspector/front-end/inspector.css:
* inspector/front-end/inspector.js:
* inspector/front-end/inspectorSyntaxHighlight.css:
* inspector/front-end/networkPanel.css:
* inspector/front-end/treeoutline.js:
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared...
ossy@webkit.org [Thu, 8 Sep 2011 12:07:06 +0000 (12:07 +0000)]
[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

* platform/qt/Skipped: Skip svg/W3C-SVG-1.1-SE/filters-image-05-f.svg, because it fails on 64 bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-08 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Thu, 8 Sep 2011 11:36:55 +0000 (11:36 +0000)]
2011-09-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed rebaseline for chromium.

        * platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
        * platform/chromium-cg-mac/svg/custom/feComponentTransfer-Table-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] fast/css/line-after-floating-div.html fails
ossy@webkit.org [Thu, 8 Sep 2011 10:16:49 +0000 (10:16 +0000)]
[Qt] fast/css/line-after-floating-div.html fails
https://bugs.webkit.org/show_bug.cgi?id=67772

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-08
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped: Skip it until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGardening: add missing result after: r94710.
ossy@webkit.org [Thu, 8 Sep 2011 10:11:26 +0000 (10:11 +0000)]
Gardening: add missing result after: r94710.
https://bugs.webkit.org/show_bug.cgi?id=67768

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-08
Reviewed by Zoltan Herczeg.

* platform/qt/fast/text/hyphenate-limit-lines-expected.png: Added.
* platform/qt/fast/text/hyphenate-limit-lines-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-07 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Thu, 8 Sep 2011 08:55:43 +0000 (08:55 +0000)]
2011-09-07  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: trying to scroll mouse wheel when in TextViewer's gutter pane causes EventException::DISPATCH_REQUEST_ERR
        https://bugs.webkit.org/show_bug.cgi?id=67715

        Reviewed by Yury Semikhatsky.

        - avoid exception on attempt to dispatch an event that is being dispatched by cloning the event.

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.forwardWheelEvent):
        (WebInspector.TextViewer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-08 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Thu, 8 Sep 2011 08:55:32 +0000 (08:55 +0000)]
2011-09-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Rebaselines for chromium.

        * platform/chromium-cg-mac-leopard/fast/css/line-after-floating-div-expected.png: Added.
        * platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.png:
        * platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.txt: Removed.
        * platform/chromium-cg-mac/fast/text/hyphenate-limit-lines-expected.png: Added.
        * platform/chromium-linux/fast/css/line-after-floating-div-expected.png:
        * platform/chromium-linux/fast/text/hyphenate-limit-lines-expected.png: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
        * platform/chromium-win/fast/css/line-after-floating-div-expected.png:
        * platform/chromium-win/fast/css/line-after-floating-div-expected.txt:
        * platform/chromium-win/fast/text/hyphenate-limit-lines-expected.png: Added.
        * platform/chromium-win/fast/text/hyphenate-limit-lines-expected.txt: Added.
        * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd standalone script that filters the output of build-webkit to be more human-readable
mdelaney@apple.com [Thu, 8 Sep 2011 07:05:15 +0000 (07:05 +0000)]
Add standalone script that filters the output of build-webkit to be more human-readable
https://bugs.webkit.org/show_bug.cgi?id=44081

Reviewed by Daniel Bates.

* Scripts/filter-build-webkit: Added. Just need to feed it the output of
a build script (e.g. build-webkit) and it spits out a prettier version.
* Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
* Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd myself to committers.py
noel.gordon@gmail.com [Thu, 8 Sep 2011 04:31:48 +0000 (04:31 +0000)]
Add myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=67696

Reviewed by Kent Tamura.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix typo in test_expectations introduced with r94725
rniwa@webkit.org [Thu, 8 Sep 2011 04:03:13 +0000 (04:03 +0000)]
Fix typo in test_expectations introduced with r94725
https://bugs.webkit.org/show_bug.cgi?id=67758

image-makering.html -> image-color-matching.html

Patch by Ben Wells <benwells@chromium.org> on 2011-09-07
Reviewed by Ryosuke Niwa.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded Snow Leopard results for this new test.
mitz@apple.com [Thu, 8 Sep 2011 03:39:35 +0000 (03:39 +0000)]
Added Snow Leopard results for this new test.

* platform/mac-snowleopard/fast/text/hyphenate-limit-lines-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r94674 and r94689.
commit-queue@webkit.org [Thu, 8 Sep 2011 03:00:31 +0000 (03:00 +0000)]
Unreviewed, rolling out r94674 and r94689.
http://trac.webkit.org/changeset/94674
http://trac.webkit.org/changeset/94689
https://bugs.webkit.org/show_bug.cgi?id=67754

Broke inspector/debugger/script-formatter.html (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/WebCore:

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.addSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.removeSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.get rawSourceCode):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype.requestContent):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):

LayoutTests:

* inspector/debugger/raw-source-code-expected.txt: Removed.
* inspector/debugger/raw-source-code.html: Removed.
* inspector/debugger/script-formatter.html:
* inspector/debugger/source-file.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agooffsetFromRoot optimization is disabled after r93837
jchaffraix@webkit.org [Thu, 8 Sep 2011 01:38:22 +0000 (01:38 +0000)]
offsetFromRoot optimization is disabled after r93837
https://bugs.webkit.org/show_bug.cgi?id=67677

Reviewed by Simon Fraser.

Unfortunately not covered by any test as it does not change updateLayerPosition complexity (it is still O(n^2)
because of clippedOverflowRectForRepaint). However it is a noticeable slowdown on some use cases but we don't
have a good test harness to cover such slowdown.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions): Pass offsetFromRoot as not doing so means that we miss
the optimization altogether.

(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
* rendering/RenderLayer.h:
Renamed |cachedOffset| to |offsetFromRoot| to be consistent with our latest renaming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix my commit per darin's suggestion.
rniwa@webkit.org [Thu, 8 Sep 2011 01:31:26 +0000 (01:31 +0000)]
Fix my commit per darin's suggestion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix after r94737.
rniwa@webkit.org [Thu, 8 Sep 2011 01:27:06 +0000 (01:27 +0000)]
Windows build fix after r94737.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustRectForColumns):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved hyphenation function implementations for an usupported build configuration.
mitz@apple.com [Thu, 8 Sep 2011 00:55:20 +0000 (00:55 +0000)]
Removed hyphenation function implementations for an usupported build configuration.

Reviewed by Sam Weinig.

* platform/text/cf/HyphenationCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=67739
hyatt@apple.com [Thu, 8 Sep 2011 00:50:24 +0000 (00:50 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67739

adjustRectForColumns is O(# of columns) when it can be O(1). Fix the slow performance of this
function by removing the loop and just computing the start and end column for a repaint rect
and uniting everything in between.

Reviewed by Dan Bernstein.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustRectForColumns):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate baselines for svg/as-background-image. These results all appear
abarth@webkit.org [Thu, 8 Sep 2011 00:26:51 +0000 (00:26 +0000)]
Update baselines for svg/as-background-image.  These results all appear
correct and test_expectations indicates that they just need new
baselines.

* platform/chromium-cg-mac/svg/as-background-image/svg-as-background-5-expected.png: Added.
* platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png:
* platform/chromium-win-vista/svg/as-background-image: Added.
* platform/chromium-win-vista/svg/as-background-image/svg-as-background-1-expected.png: Added.
* platform/chromium-win-vista/svg/as-background-image/svg-as-background-3-expected.png: Added.
* platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium/test_expectations.txt:
* platform/gtk/svg/as-background-image/animated-svg-as-background-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
* svg/as-background-image/animated-svg-as-background-expected.txt: Added.
* svg/as-background-image/svg-as-background-1-expected.txt: Added.
* svg/as-background-image/svg-as-background-3-expected.txt: Added.
* svg/as-background-image/svg-as-background-5-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThese tests just differ in how JSC and V8 report error messages.
abarth@webkit.org [Thu, 8 Sep 2011 00:18:52 +0000 (00:18 +0000)]
These tests just differ in how JSC and V8 report error messages.

* platform/chromium-cg-mac-leopard/http/tests/security: Added.
* platform/chromium-cg-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.
* platform/chromium-cg-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
* platform/chromium/http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOur results here reflect an intentional difference between GURL and
abarth@webkit.org [Thu, 8 Sep 2011 00:13:28 +0000 (00:13 +0000)]
Our results here reflect an intentional difference between GURL and
KURL.  KURL doesn't handle non-ASCII characters in the fragment in the
same was as IE whereas GURL does.

* platform/chromium/http/tests/uri: Added.
* platform/chromium/http/tests/uri/resolve-encoding-relative-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOur behavior is correct with respect to the new cookie RFC. I'm told
abarth@webkit.org [Thu, 8 Sep 2011 00:01:47 +0000 (00:01 +0000)]
Our behavior is correct with respect to the new cookie RFC.  I'm told
that CFNetwork is going to change this behavior to match every other
browser.

* platform/chromium/http/tests/cookies: Added.
* platform/chromium/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r94714 and r94723.
commit-queue@webkit.org [Wed, 7 Sep 2011 23:51:15 +0000 (23:51 +0000)]
Unreviewed, rolling out r94714 and r94723.
http://trac.webkit.org/changeset/94714
http://trac.webkit.org/changeset/94723
https://bugs.webkit.org/show_bug.cgi?id=67746

breaks gtk-linux tests with assertion failure (Requested by
thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/WebCore:

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::inTransparencyLayer):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::drawGDIGlyphs):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::releaseWindowsContext):
* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::GraphicsContext::releaseWindowsContext):
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::getWindowsContext):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::paintTrackPiece):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::ScrollbarThemeWin::paintThumb):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paint):
* rendering/RenderThemeWin.cpp:
(WebCore::drawControl):

LayoutTests:

* platform/chromium-linux/svg/custom/simple-text-double-shadow.png: Removed.
* platform/chromium-mac/svg/custom/simple-text-double-shadow.png: Removed.
* platform/chromium-win/svg/custom/simple-text-double-shadow.png: Removed.
* platform/mac/svg/custom/simple-text-double-shadow-expected.png: Removed.
* platform/mac/svg/custom/simple-text-double-shadow-expected.txt: Removed.
* svg/custom/simple-text-double-shadow.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPPC build fix.
fpizlo@apple.com [Wed, 7 Sep 2011 23:48:54 +0000 (23:48 +0000)]
PPC build fix.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate results. The actual results are only off by a fraction of a
abarth@webkit.org [Wed, 7 Sep 2011 23:48:13 +0000 (23:48 +0000)]
Update results.  The actual results are only off by a fraction of a
pixel around the curve in the zero.

* platform/chromium-cg-mac/media/audio-repaint-expected.txt: Removed.
* platform/chromium-mac/media/audio-repaint-expected.txt: Removed.
* platform/chromium-win-xp/media: Removed.
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium/media/audio-repaint-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThese results are also off by just factional pixels.
abarth@webkit.org [Wed, 7 Sep 2011 23:43:25 +0000 (23:43 +0000)]
These results are also off by just factional pixels.

* platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThese results all differ only in less than one pixel border or text rendering.
abarth@webkit.org [Wed, 7 Sep 2011 23:38:03 +0000 (23:38 +0000)]
These results all differ only in less than one pixel border or text rendering.

* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug82946-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug22019-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug28341-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2886-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2947-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug6674-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug22019-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2886-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2947-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug6674-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Mac baseline for the test added by r94331.
rniwa@webkit.org [Wed, 7 Sep 2011 23:35:07 +0000 (23:35 +0000)]
Add Mac baseline for the test added by r94331.

* platform/mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline for r94710.
rniwa@webkit.org [Wed, 7 Sep 2011 23:26:58 +0000 (23:26 +0000)]
Rebaseline for r94710.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 23:25:28 +0000 (23:25 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium svg/ rebaselines.

        * platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
        * platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-cg-mac-leopard/svg/batik/filters/feTile-expected.png:
        * platform/chromium-cg-mac-leopard/svg/batik/text/textFeatures-expected.png:
        * platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/chromium-cg-mac-leopard/svg/filters/filterRes-expected.png:
        * platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
        * platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
        * platform/chromium-cg-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-cg-mac/svg/batik/filters/feTile-expected.png:
        * platform/chromium-cg-mac/svg/batik/text/textFeatures-expected.png:
        * platform/chromium-cg-mac/svg/css/getComputedStyle-basic-expected.txt: Added.
        * platform/chromium-cg-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/chromium-cg-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/chromium-cg-mac/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/chromium-cg-mac/svg/custom/simple-text-double-shadow-expected.png: Added.
        * platform/chromium-cg-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/chromium-cg-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/chromium-cg-mac/svg/filters/filterRes-expected.png:
        * platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Removed.
        * platform/chromium-linux/svg/custom/simple-text-double-shadow-expected.png: Added.
        * platform/chromium-win-vista/svg/filters: Removed.
        * platform/chromium-win-xp/svg/css: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
        * platform/chromium-win/svg/custom/simple-text-double-shadow-expected.png: Added.
        * platform/chromium-win/svg/custom/simple-text-double-shadow-expected.txt: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/chromium-win/svg/filters/filterRes-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocss2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
rniwa@webkit.org [Wed, 7 Sep 2011 23:16:08 +0000 (23:16 +0000)]
css2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
https://bugs.webkit.org/show_bug.cgi?id=67725

Reviewed by Dan Bernstein.

Revert the script fix in t090204-display-change-01-b-ao.html and css2.1 test suite and
replace line-after-floating-div.html by the fixed version.

Also move the expected result for line-after-floating-div.html from fast/css as it is platform dependent.

* css2.1/t090204-display-change-01-b-ao.html:
* fast/css/line-after-floating-div-expected.png: Removed.
* fast/css/line-after-floating-div-expected.txt: Removed.
* fast/css/line-after-floating-div.html:
* platform/mac/css2.1/t090204-display-change-01-b-ao-expected.png:
* platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt:
* platform/mac/fast/css/line-after-floating-div-expected.png: Copied from
LayoutTests/fast/css/line-after-floating-div-expected.png.
* platform/mac/fast/css/line-after-floating-div-expected.txt: Copied from
LayoutTests/fast/css/line-after-floating-div-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, Chromium baselines for svg/custom/simple-text-double-shadow
timothy_horton@apple.com [Wed, 7 Sep 2011 23:10:21 +0000 (23:10 +0000)]
Unreviewed, Chromium baselines for svg/custom/simple-text-double-shadow

* platform/chromium-linux/svg/custom/simple-text-double-shadow.png: Added.
* platform/chromium-mac/svg/custom/simple-text-double-shadow.png: Added.
* platform/chromium-win/svg/custom/simple-text-double-shadow.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agorebaseline button in garden-o-matic details view should work
abarth@webkit.org [Wed, 7 Sep 2011 23:08:18 +0000 (23:08 +0000)]
rebaseline button in garden-o-matic details view should work
https://bugs.webkit.org/show_bug.cgi?id=67738

Reviewed by Dimitri Glazkov.

This patch wires up the rebaseline button in garden-o-matic results
details view.  The button is current per-test, so there isn't a way to
rebaseline individual bots.  This is a place to start.  If we decide we
want per-bot rebaselining, we'll need to think of some better UI.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFrameLoader::addExtraFieldsToRequest can crash when called from or after FrameLoader...
abarth@webkit.org [Wed, 7 Sep 2011 22:54:48 +0000 (22:54 +0000)]
FrameLoader::addExtraFieldsToRequest can crash when called from or after FrameLoader::detachFromParent
https://bugs.webkit.org/show_bug.cgi?id=61810

Reviewed by Eric Seidel.

Fix this crash as suggested by Darin Fisher in
https://bugs.webkit.org/show_bug.cgi?id=61810#c21.  This patch does not
include the test requested by Alexey Proskuryakov in
https://bugs.webkit.org/show_bug.cgi?id=61810#c6.  I would really much
rather include a test with this patch, but my attempts to write a test
have failed.  :(

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::loadFrameRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 22:49:37 +0000 (22:49 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium fast/css/ rebaslines.

        * platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-expected.txt: Added.
        * platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
        * platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.png: Added.
        * platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.txt: Added.
        * platform/chromium-linux/fast/css/getComputedStyle: Removed.
        * platform/chromium-linux/fast/css/line-after-floating-div-expected.png: Added.
        * platform/chromium-win-vista/fast/css/getComputedStyle: Removed.
        * platform/chromium-win-xp/fast/css/getComputedStyle: Removed.
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/chromium-win/fast/css/line-after-floating-div-expected.png: Added.
        * platform/chromium-win/fast/css/line-after-floating-div-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 22:23:19 +0000 (22:23 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, patch up some chromium gpu expectations
        that are failing on the cg mac builds.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTeach the PortFactory object how to pass along executive/user/filesystem to port...
eric@webkit.org [Wed, 7 Sep 2011 22:19:14 +0000 (22:19 +0000)]
Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
https://bugs.webkit.org/show_bug.cgi?id=67737

Reviewed by Adam Barth.

I got a little over-eager when deprecating host.port_factory in the previous commit.
Turns out that Host.port_factory was already the "modern" port/factory.py
it was just the Module object.  I un-deprecated the variable, and changed it from
being the module to being an actual PortFactory, passing it a host object.
I also taught PortFactory how to set user/executive/filesystem in the kwargs
when instantiating a new Port object.
This magically fixed the test_rebaseline test, since its now no longer talking
to the real filesystem.

* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a new PortFactory class for creating new-style ports and deprecate the old PortFa...
eric@webkit.org [Wed, 7 Sep 2011 21:44:49 +0000 (21:44 +0000)]
Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
https://bugs.webkit.org/show_bug.cgi?id=67734

Reviewed by Adam Barth.

Right now every place that creates a Port object has to be very careful
to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
The correct fix is for port/factory.py (which creates most port objects)
to know how to pass these in automatically.  However, currently all port/factory.py
functions are free functions instead of being on an object.  This patch
adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.

In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
pass along the proper scm/user/filesystem to the Port object.

* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChanges to aria-hidden don't change VO navigation
cfleizach@apple.com [Wed, 7 Sep 2011 21:42:02 +0000 (21:42 +0000)]
Changes to aria-hidden don't change VO navigation
https://bugs.webkit.org/show_bug.cgi?id=67722

Reviewed by Darin Adler.

Source/WebCore:

When altering aria-hidden, WebCore needs to update the children caches of
affected elements. However, for elements that were children, but ignored, their
caches did not get updated, and stale information would be propagated.

The fix is to always clearChildren() when a parent is asking for children. This
ensures information is always up to date when the parent itself is asking for new data.

Test: accessibility/aria-hidden-updates-alldescendants.html

* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaIsHidden):
(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::addChildren):

LayoutTests:

* accessibility/aria-hidden-updates-alldescendants-expected.txt: Added.
* accessibility/aria-hidden-updates-alldescendants.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 21:39:32 +0000 (21:39 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, upstream some chromium expected failure after skia roll,
        and rebaseline 2 tests for leopard cg.

        * platform/chromium-cg-mac-leopard/fast/borders/border-image-scaled-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/borders/border-image-side-reduction-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoText rendered with a simple (i.e. 0px blur) shadow inside a transparency layer has...
timothy_horton@apple.com [Wed, 7 Sep 2011 21:35:03 +0000 (21:35 +0000)]
Text rendered with a simple (i.e. 0px blur) shadow inside a transparency layer has a double shadow
https://bugs.webkit.org/show_bug.cgi?id=67543
<rdar://problem/10070536>

Reviewed by Simon Fraser.

Generalize (begin|end)TransparencyLayer, which now forward
through to (begin|end)PlatformTransparencyLayer, so that
isInTransparencyLayer can exist on every platform.

Make use of isInTransparencyLayer in FontMac to disable
"simple" shadow drawing when the text is being rendered
into a transparency layer.

Test: svg/custom/simple-text-double-shadow.svg

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::isInTransparencyLayer):
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::isInTransparencyLayer):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::drawGDIGlyphs):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::releaseWindowsContext):
* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::GraphicsContext::releaseWindowsContext):
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::getWindowsContext):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/win/ScrollbarThemeWin.cpp:
* plugins/win/PluginViewWin.cpp:
* rendering/RenderThemeWin.cpp:

Add a test ensuring that text with 0px blur CSS shadow doesn't get rendered
with a second shadow when inside a transparency layer.

* platform/mac/svg/custom/simple-text-double-shadow-expected.png: Added.
* platform/mac/svg/custom/simple-text-double-shadow-expected.txt: Added.
* svg/custom/simple-text-double-shadow.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 21:04:47 +0000 (21:04 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium expectations update.
        Make the WONTFIX WIN LINUX for platform/chromium/rubberbanding/
        FAIL instead of IMAGE, so it's less likely to flake out.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd the forgotten expected results for r94696.
rniwa@webkit.org [Wed, 7 Sep 2011 21:01:11 +0000 (21:01 +0000)]
Add the forgotten expected results for r94696.

* fast/css/line-after-floating-div-expected.png: Added.
* fast/css/line-after-floating-div-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8881922> Support the hyphenate-limit-lines property
mitz@apple.com [Wed, 7 Sep 2011 20:59:39 +0000 (20:59 +0000)]
<rdar://problem/8881922> Support the hyphenate-limit-lines property
https://bugs.webkit.org/show_bug.cgi?id=67730

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/css/parsing-hyphenate-limit-lines.html
       fast/text/hyphenate-limit-lines.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added hyphenate-limit-lines.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Ditto. Valid values are non-negative integers and the keyword
"no-limit".
* css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-lines.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Added hyphenate-limit-lines.
* css/CSSValueKeywords.in: Added the "no-limit" value keyword.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats): Count the number of consecutive hyphenated lines
before the start line and pass it to layoutRunsAndFloatsInRange().
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Keep track of the number of consecutive
hyphenated lines before the current line and pass it to LineBreaker::nextLineBreak().
(WebCore::tryHyphenating): Added parameters for the number of consecutive hyphenated lines before
the current line and the limit on consecutive hyphenated lines, and an early return if the limit
has been reached.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Added a parameter for the number of consecutive
hyphenated lines before the current line, which is passed through to tryHyphenating, along with
the value of hyphenate-limit-lines.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::isHyphenated): Added. Returns true if the line was hyphenated.
* rendering/RootInlineBox.h:
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hyphenationLimitLines): Added this getter.
(WebCore::InheritedFlags::setHyphenationLimitLines): Added this setter.
(WebCore::InheritedFlags::initialHyphenationLimitLines): Added. The initial value is -1,
corresponding to "no-limit".
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize new member variable.
(WebCore::StyleRareInheritedData::operator==): Compare new member variable.
* rendering/style/StyleRareInheritedData.h:

LayoutTests:

* fast/css/parsing-hyphenate-limit-lines-expected.txt: Added.
* fast/css/parsing-hyphenate-limit-lines.html: Added.
* fast/text/hyphenate-limit-lines.html: Added.
* platform/mac/fast/text/hyphenate-limit-lines-expected.png: Added.
* platform/mac/fast/text/hyphenate-limit-lines-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening after r94697.
ossy@webkit.org [Wed, 7 Sep 2011 20:58:49 +0000 (20:58 +0000)]
[Qt] Unreviewed gardening after r94697.

* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 20:56:32 +0000 (20:56 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium expectations update.

        * platform/chromium-cg-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
        * platform/chromium-cg-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
        * platform/chromium-win-xp/svg/transforms: Removed.
        * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r94441.
commit-queue@webkit.org [Wed, 7 Sep 2011 20:56:05 +0000 (20:56 +0000)]
Unreviewed, rolling out r94441.
http://trac.webkit.org/changeset/94441
https://bugs.webkit.org/show_bug.cgi?id=67731

"MacEWSes are backed up due to new machines not able to reach
git.webkit.org.  Disabling tests for now" (Requested by
eseidel2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agosplit overrideSize into overrideHeight and overrideWidth
ojan@chromium.org [Wed, 7 Sep 2011 20:18:14 +0000 (20:18 +0000)]
split overrideSize into overrideHeight and overrideWidth
https://bugs.webkit.org/show_bug.cgi?id=67550

Reviewed by Sam Weinig.

All uses of overrideSize only set one of the width or the height.
This change removes a bool from RenderObject and removes some
flexbox specific logic from RenderBox.

The only downside is that we have two global maps where we used
to have one.

No functional changes so existing tests are sufficient.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::hasOverrideHeight):
(WebCore::RenderBox::hasOverrideWidth):
(WebCore::RenderBox::setOverrideHeight):
(WebCore::RenderBox::setOverrideWidth):
(WebCore::RenderBox::clearOverrideSize):
(WebCore::RenderBox::overrideWidth):
(WebCore::RenderBox::overrideHeight):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
* rendering/RenderBox.h:
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenHorizontal):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
* rendering/RenderObject.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::setOverrideHeightFromRowHeight):
* rendering/RenderTableCell.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd test infrastructure to test rubber-banding overhang drawing along with layout...
commit-queue@webkit.org [Wed, 7 Sep 2011 20:13:34 +0000 (20:13 +0000)]
Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.
https://bugs.webkit.org/show_bug.cgi?id=67511

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-07
Reviewed by Dimitri Glazkov.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Tests: platform/chromium-mac/rubberbanding/overhang-e.html
       platform/chromium-mac/rubberbanding/overhang-n.html
       platform/chromium-mac/rubberbanding/overhang-ne.html
       platform/chromium-mac/rubberbanding/overhang-nw.html
       platform/chromium-mac/rubberbanding/overhang-s.html
       platform/chromium-mac/rubberbanding/overhang-se.html
       platform/chromium-mac/rubberbanding/overhang-sw.html
       platform/chromium-mac/rubberbanding/overhang-w.html

* WebCore.exp.in:
* platform/ScrollableArea.h:
* testing/Internals.cpp:
(WebCore::Internals::setScrollViewPosition):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* platform/chromium-mac/rubberbanding: Added.
* platform/chromium-mac/rubberbanding/overhang-e-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-e-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-e.html: Added.
* platform/chromium-mac/rubberbanding/overhang-n-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-n-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-n.html: Added.
* platform/chromium-mac/rubberbanding/overhang-ne-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-ne-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-ne.html: Added.
* platform/chromium-mac/rubberbanding/overhang-nw-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-nw-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-nw.html: Added.
* platform/chromium-mac/rubberbanding/overhang-s-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-s-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-s.html: Added.
* platform/chromium-mac/rubberbanding/overhang-se-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-se-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-se.html: Added.
* platform/chromium-mac/rubberbanding/overhang-sw-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-sw-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-sw.html: Added.
* platform/chromium-mac/rubberbanding/overhang-w-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-w-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-w.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRelease mode build fix.
oliver@apple.com [Wed, 7 Sep 2011 20:06:12 +0000 (20:06 +0000)]
Release mode build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Render surface anti-aliasing.
commit-queue@webkit.org [Wed, 7 Sep 2011 20:00:58 +0000 (20:00 +0000)]
[Chromium] Render surface anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=66437

Patch by David Reveman <reveman@chromium.org> on 2011-09-07
Reviewed by James Robinson.

Source/WebCore:

Add CCLayerQuad class and CCLayerQuad::Edge subclass to allow
edge computations to be shared between tiled layers and render
surfaces. Move isCCW utility function to FloatQuad class and
add to2dTransform method to TransformationMatrix class. Add
necessary anti-aliasing shaders for render surfaces and use them
to avoid aliased edges.

Tests: compositing/reflections/nested-reflection-transformed.html (existing)

* WebCore.gypi:
* platform/graphics/FloatQuad.cpp:
(WebCore::FloatQuad::isCounterclockwise):
* platform/graphics/FloatQuad.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::drawTexturedQuad):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgramAA):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzle):
(WebCore::LayerRendererChromium::canvasLayerProgram):
(WebCore::LayerRendererChromium::pluginLayerProgram):
(WebCore::LayerRendererChromium::videoLayerRGBAProgram):
(WebCore::LayerRendererChromium::videoLayerYUVProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::sharedGeometryQuad):
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderQuad::VertexShaderQuad):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderQuad::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaAA::FragmentShaderRGBATexAlphaAA):
(WebCore::FragmentShaderRGBATexAlphaAA::init):
(WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
(WebCore::FragmentTexClampAlphaAABinding::FragmentTexClampAlphaAABinding):
(WebCore::FragmentTexClampAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexClampAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampSwizzleAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::FragmentShaderRGBATexAlphaMaskAA):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):
* platform/graphics/chromium/ShaderChromium.h:
(WebCore::VertexShaderQuad::matrixLocation):
(WebCore::VertexShaderQuad::pointLocation):
(WebCore::FragmentShaderRGBATexAlphaAA::alphaLocation):
(WebCore::FragmentShaderRGBATexAlphaAA::samplerLocation):
(WebCore::FragmentShaderRGBATexAlphaAA::edgeLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::alphaLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::samplerLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::maskSamplerLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::edgeLocation):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCLayerQuad.cpp: Added.
(WebCore::CCLayerQuad::Edge::Edge):
(WebCore::CCLayerQuad::CCLayerQuad):
(WebCore::CCLayerQuad::floatQuad):
(WebCore::CCLayerQuad::toFloatArray):
* platform/graphics/chromium/cc/CCLayerQuad.h: Added.
(WebCore::CCLayerQuad::Edge::Edge):
(WebCore::CCLayerQuad::Edge::x):
(WebCore::CCLayerQuad::Edge::y):
(WebCore::CCLayerQuad::Edge::z):
(WebCore::CCLayerQuad::Edge::setX):
(WebCore::CCLayerQuad::Edge::setY):
(WebCore::CCLayerQuad::Edge::setZ):
(WebCore::CCLayerQuad::Edge::set):
(WebCore::CCLayerQuad::Edge::moveX):
(WebCore::CCLayerQuad::Edge::moveY):
(WebCore::CCLayerQuad::Edge::moveZ):
(WebCore::CCLayerQuad::Edge::move):
(WebCore::CCLayerQuad::Edge::scaleX):
(WebCore::CCLayerQuad::Edge::scaleY):
(WebCore::CCLayerQuad::Edge::scaleZ):
(WebCore::CCLayerQuad::Edge::scale):
(WebCore::CCLayerQuad::Edge::intersect):
(WebCore::CCLayerQuad::CCLayerQuad):
(WebCore::CCLayerQuad::left):
(WebCore::CCLayerQuad::top):
(WebCore::CCLayerQuad::right):
(WebCore::CCLayerQuad::bottom):
(WebCore::CCLayerQuad::inflateX):
(WebCore::CCLayerQuad::inflateY):
(WebCore::CCLayerQuad::inflate):
(WebCore::CCLayerQuad::inflateAntiAliasingDistance):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::draw):
(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):
* platform/graphics/chromium/cc/CCRenderSurface.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::drawTiles):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):
* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::to2dTransform):
* platform/graphics/transforms/TransformationMatrix.h:

LayoutTests:

Update expected results.

* platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.png:
* platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.png:
* platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.png:
* platform/chromium-gpu-linux/compositing/scaling/tiled-layer-recursion-expected.png:
* platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
* platform/chromium-gpu-linux/media/video-transformed-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline after r93935.
xji@chromium.org [Wed, 7 Sep 2011 19:51:24 +0000 (19:51 +0000)]
Rebaseline after r93935.

* platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove JSObjectWithGlobalObject
oliver@apple.com [Wed, 7 Sep 2011 19:40:41 +0000 (19:40 +0000)]
Remove JSObjectWithGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=67689

Reviewed by Geoff Garen.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Remove JSObjectWithGlobalObject, and update code to stop using anonymous
storage to access the global object that a JSObject comes from.  Largely
mechanical change to remove the use of anonymous storage and JSObjectWithGlobalObject.

* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
(JSC::JSCallbackConstructor::finishCreation):
* API/JSCallbackConstructor.h:
* API/JSCallbackObject.cpp:
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::create):
* API/JSCallbackObjectFunctions.h:
(JSC::::JSCallbackObject):
(JSC::::finishCreation):
(JSC::::staticFunctionGetter):
* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
* API/JSObjectRef.cpp:
(JSObjectMake):
(JSObjectGetPrivate):
(JSObjectSetPrivate):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):
* API/JSValueRef.cpp:
(JSValueIsObjectOfClass):
* API/JSWeakObjectMapRefPrivate.cpp:
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchGetMethodFast):
(JSC::DFG::tryCacheGetMethod):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateJSFunction):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/DatePrototype.cpp:
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
(JSC::InternalFunction::finishCreation):
* runtime/InternalFunction.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::finishCreation):
* runtime/JSFunction.h:
(JSC::JSFunction::create):
(JSC::JSFunction::createStructure):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
(JSC::JSONObject::finishCreation):
* runtime/JSONObject.h:
* runtime/JSObject.h:
(JSC::JSObject::globalObject):
* runtime/JSObjectWithGlobalObject.cpp: Removed.
* runtime/JSObjectWithGlobalObject.h: Removed.
* runtime/JSValue.cpp:
(JSC::JSValue::isValidCallee):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
(JSC::MathObject::finishCreation):
* runtime/MathObject.h:
* runtime/NumberPrototype.cpp:
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::finishCreation):
* runtime/RegExpObject.h:
* runtime/Structure.cpp:
(JSC::Structure::Structure):
* runtime/Structure.h:
(JSC::Structure::create):
(JSC::Structure::globalObject):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Remove use of anonymous storage and JSObjectWithGlobalObject for
accessing a JSObject's global object now that they're available
on the object's structure.

* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::JSDOMWrapper):
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initScript):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(JSC::Bindings::ObjcFallbackObjectImp::finishCreation):
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::RuntimeObject):
(JSC::Bindings::RuntimeObject::finishCreation):
* bridge/runtime_object.h:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebKit2:

Remove JSObjectWithGlobalObject usage.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::finishCreation):
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTools: filter test_expectations properly for chromium-mac vs chromium-cg-mac
commit-queue@webkit.org [Wed, 7 Sep 2011 19:31:48 +0000 (19:31 +0000)]
Tools: filter test_expectations properly for chromium-mac vs chromium-cg-mac
https://bugs.webkit.org/show_bug.cgi?id=67324

Patch by Elliot Poger <epoger@google.com> on 2011-09-07
Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:

LayoutTests: now that layout tests distinguish between Core Graphics and Skia
expectations, update test_expectations accordingly.
https://bugs.webkit.org/show_bug.cgi?id=67324

Patch by Elliot Poger <epoger@google.com> on 2011-09-07
Reviewed by Dirk Pranke.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac build fix after r94694.
rniwa@webkit.org [Wed, 7 Sep 2011 19:29:30 +0000 (19:29 +0000)]
Mac build fix after r94694.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFELighting is using width instead of height to determine skip for parallel(n>2) case
timothy_horton@apple.com [Wed, 7 Sep 2011 19:27:36 +0000 (19:27 +0000)]
FELighting is using width instead of height to determine skip for parallel(n>2) case
https://bugs.webkit.org/show_bug.cgi?id=67719
<rdar://problem/10086178>

Reviewed by Dirk Schulze.

No new tests, because the bug only exhibits under conditions which are currently
impossible by default (using more than 2 cores) on some platforms.

* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGeneric):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEliminate motion jitter in animated, blurred SVG image
wjmaclean@chromium.org [Wed, 7 Sep 2011 19:20:13 +0000 (19:20 +0000)]
Eliminate motion jitter in animated, blurred SVG image
https://bugs.webkit.org/show_bug.cgi?id=67503

Fixes filter shear-free transform applied to SVG images.

Source/WebCore:

In applyResource() the shearFreeAbsoluteTransform is applied to the drawing region,
which is based on the object bounding box (which doesn't move). For a rotation
around the centre of the box, this should really just be the identity matrix,
since the BB should neither change size nor location. So really, we're just interested
in the scale change of the BB here, and not in moving it.

This impacts how slices are extracted, and affects the {x|y}Mid and {x|y}Max extractions
for vertical and horizontal slices, so the test verifies these.

Reviewed by Dirk Schulze.

Test: svg/W3C-SVG-1.1-SE/filters-image-05-f.svg

* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):

LayoutTests:

Reviewed by Dirk Schulze.

* platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
* platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
* platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-linux/svg/filters/filterRes-expected.png:
* platform/chromium-linux/svg/filters/filterRes-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
* svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
* svg/W3C-SVG-1.1-SE/filters-image-05-f.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocss2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
rniwa@webkit.org [Wed, 7 Sep 2011 19:14:30 +0000 (19:14 +0000)]
css2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
https://bugs.webkit.org/show_bug.cgi?id=67725

Reviewed by David Hyatt.

Fixed the test to properly attach load event listener on window instead of document.

Since this broken test also caught a bug fixed in r94693, I made a copy of this version in fast/css.

* css2.1/t090204-display-change-01-b-ao.html:
* fast/css/line-after-floating-div.html: Copied from LayoutTests/css2.1/t090204-display-change-01-b-ao.html.
* platform/mac/css2.1/t090204-display-change-01-b-ao-expected.png:
* platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoElements with position:absolute don't move to correct position after images load
robert@webkit.org [Wed, 7 Sep 2011 18:59:55 +0000 (18:59 +0000)]
Elements with position:absolute don't move to correct position after images load
https://bugs.webkit.org/show_bug.cgi?id=54611

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/block/positioning/absolute-layout-after-image-load.html
      fast/block/positioning/positioned-float-layout-after-image-load.html

In the test the 'label' block is an absolutely positioned child of an inline flow. So during layout,
this RenderBlock::layoutPositionedObjects fails to dirty it for rendering because it requires
the parent to be a BlockFlow. The code to do this was introduced in http://trac.webkit.org/changeset/8284.
There doesn't seem to be a good reason for requiring a BlockFlow, so remove the check. Do the same
for positioned floats in RenderBlock::positionedFloatsNeedRelayout(), although currently layoutPositionedObjects()
takes care of it this at least ensures no regression in future.

Note: Although the issue is encountered only on first load without a fragment identifier, it
happens reliably when you include the fragment identifier in the url (#Footnote_1). This is so
because scrolling to the fragment always happens before the image has loaded, rendering the page
and clearing the initial dirty bits in the positioned element's renderer. When the image finally
loads in this scenario, the positioned element is otherwise clean and relies on the above code to get
re-rendered.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutPositionedObjects): remove the check for r->parent()->isBlockFlow() when
                                                 deciding whether to mark children for layout
(WebCore::RenderBlock::positionedFloatsNeedRelayout): ditto

LayoutTests:

* fast/block/positioning/absolute-layout-after-image-load-expected.txt: Added.
* fast/block/positioning/absolute-layout-after-image-load.html: Added.
* fast/block/positioning/resources/absolute-layout-after-image-load-2.html: Added.
* fast/block/positioning/positioned-float-layout-after-image-load-expected.txt: Added.
* fast/block/positioning/positioned-float-layout-after-image-load.html: Added.
* fast/block/positioning/resources/positioned-float-layout-after-image-load-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMoving platform/track to html/track to avoid layering violation.
commit-queue@webkit.org [Wed, 7 Sep 2011 18:50:35 +0000 (18:50 +0000)]
Moving platform/track to html/track to avoid layering violation.
https://bugs.webkit.org/show_bug.cgi?id=67680

Patch by Anna Cavender <annacc@chromium.org> on 2011-09-07
Reviewed by Adam Barth.

No new tests. No new functionality.

* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* html/track/CueParser.cpp: Renamed from Source/WebCore/platform/track/CueParser.cpp.
* html/track/CueParser.h: Renamed from Source/WebCore/platform/track/CueParser.h.
* html/track/CueParserPrivate.h: Renamed from Source/WebCore/platform/track/CueParserPrivate.h.
* html/track/WebVTTParser.cpp: Renamed from Source/WebCore/platform/track/WebVTTParser.cpp.
* html/track/WebVTTParser.h: Renamed from Source/WebCore/platform/track/WebVTTParser.h.
* html/track/WebVTTToken.h: Renamed from Source/WebCore/platform/track/WebVTTToken.h.
* html/track/WebVTTTokenizer.cpp: Renamed from Source/WebCore/platform/track/WebVTTTokenizer.cpp.
* html/track/WebVTTTokenizer.h: Renamed from Source/WebCore/platform/track/WebVTTTokenizer.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=67286
hyatt@apple.com [Wed, 7 Sep 2011 18:48:07 +0000 (18:48 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67286

REGRESSION: css2.1/t090204-display-change-01-b-ao.html fails after r94084.

Make sure that the trailing floats line box explicitly sets the line top with leading and line bottom with
leading to just be the block height.

Reviewed by Dan Bernstein.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::linkToEndLineIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
abarth@webkit.org [Wed, 7 Sep 2011 18:32:35 +0000 (18:32 +0000)]
[Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
https://bugs.webkit.org/show_bug.cgi?id=66800

Patch by Eric Boren <borenet@gmail.com> on 2011-09-07
Reviewed by Darin Fisher.

Source/WebKit/chromium:

* public/WebInputEvent.h:
(WebKit::WebTouchEvent::WebTouchEvent):
* public/WebTouchPoint.h:
(WebKit::WebTouchPoint::WebTouchPoint):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
* src/WebInputEventConversion.h:

Tools:

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::sendCurrentTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNull owningRenderer crash in RenderScrollbar::updateScrollbarParts.
inferno@chromium.org [Wed, 7 Sep 2011 18:15:12 +0000 (18:15 +0000)]
Null owningRenderer crash in RenderScrollbar::updateScrollbarParts.
https://bugs.webkit.org/show_bug.cgi?id=67669

Reviewed by James Robinson.

Owning renderer can be cleared for custom scrollbars in clearOwningRenderer()
call. We need a null check in updateScrollbarParts, so that we do not crash.

No tests since issue seen in crash reports only and I donot know a way to
reproduce.

* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarParts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-07 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 7 Sep 2011 18:14:50 +0000 (18:14 +0000)]
2011-09-07  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, build fix after r94674.

        * inspector/debugger/script-formatter.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactor JIT checks for ObjectType into helper functions.
barraclough@apple.com [Wed, 7 Sep 2011 17:55:50 +0000 (17:55 +0000)]
Refactor JIT checks for ObjectType into helper functions.

Rubber stamped by Sam Weinig.

* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::branchIfNotObject):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.h:
* jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_ret_object_or_this):
* jit/JITInlineMethods.h:
(JSC::JIT::emitJumpIfNotObject):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_this):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_this):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip media/media-controls-invalid-url.html on Mac for now because it has been failing.
rniwa@webkit.org [Wed, 7 Sep 2011 17:55:18 +0000 (17:55 +0000)]
Skip media/media-controls-invalid-url.html on Mac for now because it has been failing.
The failure is tracked by the bug 67716.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFinally, Mac rebaseline for r93237.
rniwa@webkit.org [Wed, 7 Sep 2011 17:41:46 +0000 (17:41 +0000)]
Finally, Mac rebaseline for r93237.

* platform/mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Copied from
LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-2-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Make TiledDrawingArea request tiles only in the direction the viewport...
jocelyn.turcotte@nokia.com [Wed, 7 Sep 2011 17:35:21 +0000 (17:35 +0000)]
[Qt][WK2] Make TiledDrawingArea request tiles only in the direction the viewport is panned to.
https://bugs.webkit.org/show_bug.cgi?id=67606

Source/WebCore:

Reviewed by Noam Rosenthal.

TiledBackingStore previously used different values for horizontal and vertial multiplication
to calculate the cover area.
This patch replaces this mechanism, used to give a bigger panning range to vertical panning,
with the possibility to use the motion vector of the viewport to request tiles ahead instead.
This allows economies on rendering resources as tiles won't be rendered beside the trajectory
of the viewport.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::setKeepAndCoverAreaMultipliers):
(WebCore::TiledBackingStore::setCoverAreaFocusVector):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::calculateKeepRect):
(WebCore::TiledBackingStore::calculateCoverRect):
* platform/graphics/TiledBackingStore.h:
(WebCore::TiledBackingStore::getKeepAndCoverAreaMultipliers):

Source/WebKit/qt:

TiledBackingStore previously used different values for horizontal and vertial multiplication
to calculate the cover area.
This patch replaces this mechanism, used to give a bigger panning range to vertical panning,
with the possibility to use the motion vector of the viewport to request tiles ahead instead.
This allows economies on rendering resources as tiles won't be rendered beside the trajectory
of the viewport.

* Api/qwebpage.cpp:
(QWebPagePrivate::dynamicPropertyChangeEvent):

Source/WebKit2:

TiledBackingStore previously used different values for horizontal and vertial multiplication
to calculate the cover area.
This patch replaces this mechanism, used to give a bigger panning range to vertical panning,
with the possibility to use the motion vector of the viewport to request tiles ahead instead.
This allows economies on rendering resources as tiles won't be rendered beside the trajectory
of the viewport.

* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::_q_viewportMotionVectorChanged):
* UIProcess/API/qt/qtouchwebview.h:
* UIProcess/API/qt/qtouchwebview_p.h:
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::setVisibleContentRectMotionVector):
* UIProcess/TiledDrawingAreaProxy.h:
* UIProcess/qt/ViewportInteractionEngine.cpp:
(WebKit::ViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::ViewportInteractionEngine::panGestureEnded):
(WebKit::ViewportInteractionEngine::pinchGestureStarted):
* UIProcess/qt/ViewportInteractionEngine.h:
* UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::setVisibleContentRectMotionVector):
* UIProcess/qt/qtouchwebpageproxy.h:
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setVisibleContentRectMotionVector):
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::setVisibleContentRectMotionVector):
* WebProcess/WebPage/TiledDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix my accidental svn mv (instead of cp) in r94680.
rniwa@webkit.org [Wed, 7 Sep 2011 17:34:28 +0000 (17:34 +0000)]
Fix my accidental svn mv (instead of cp) in r94680.

* fast/dom/call-a-constructor-as-a-function-expected.txt: Copied from
LayoutTests/platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] TiledBackingStore: Import the resizeEdgeTiles logic from TiledDrawindAreaProxy.
jocelyn.turcotte@nokia.com [Wed, 7 Sep 2011 17:19:36 +0000 (17:19 +0000)]
[Qt] TiledBackingStore: Import the resizeEdgeTiles logic from TiledDrawindAreaProxy.
https://bugs.webkit.org/show_bug.cgi?id=67416

Reviewed by Kenneth Rohde Christiansen.

Original code by Antti Koivisto.
With the current code, when the page is layouted during load, edge tiles will
get removed instead of continuing to show their front buffer while the tile
is being rendered for the new size.

Source/WebCore:

* platform/graphics/Tile.h:
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::resizeEdgeTiles):
* platform/graphics/TiledBackingStore.h:
* platform/graphics/qt/TileQt.cpp:
(WebCore::TileQt::resize):
* platform/graphics/qt/TileQt.h:

Source/WebKit2:

* WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
(WebKit::TiledBackingStoreRemoteTile::resize):
* WebProcess/WebPage/TiledBackingStoreRemoteTile.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGTK+ rebaseline after r94357. GTK+ port apparently implements PeerConnection.
rniwa@webkit.org [Wed, 7 Sep 2011 17:17:38 +0000 (17:17 +0000)]
GTK+ rebaseline after r94357. GTK+ port apparently implements PeerConnection.

* fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
* platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt: Copied from
LayoutTests/fast/dom/call-a-constructor-as-a-function-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't round-trip through TransformationMatrix in SVGImageBufferTools::clearAffineTran...
timothy_horton@apple.com [Wed, 7 Sep 2011 17:17:21 +0000 (17:17 +0000)]
Don't round-trip through TransformationMatrix in SVGImageBufferTools::clearAffineTransform2DRotation
https://bugs.webkit.org/show_bug.cgi?id=67242
<rdar://problem/10069770>

Reviewed by Dirk Schulze.

No new tests, minor performance improvement.

* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::blend):
(WebCore::AffineTransform::decompose):
(WebCore::AffineTransform::recompose):
* platform/graphics/transforms/AffineTransform.h:
* rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::clear2DRotation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTiledDrawingArea: Fix issues where the tiles of the previous scale would be removed...
jocelyn.turcotte@nokia.com [Wed, 7 Sep 2011 17:07:38 +0000 (17:07 +0000)]
TiledDrawingArea: Fix issues where the tiles of the previous scale would be removed too early.
https://bugs.webkit.org/show_bug.cgi?id=67390

Reviewed by Tor Arne Vestbø.

The two issues addresssed are:
- The previous instance of the tile backing store would be destroyed in createTile which
  would send removeTile messages for all its tiles before the DidRenderFrame message is sent for the new tiles.
- When quickly changing the scale a second time after a scale change, the previous tile set would
  be replaced by the current incomplete tile set which may contain no tiles at all.
* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::setVisibleContentRectAndScale):
(WebKit::TiledDrawingArea::tiledBackingStorePaintEnd):
(WebKit::TiledDrawingArea::createTile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip accessibility/textbox-role-reports-selection.html on GTK+ bots because it has...
rniwa@webkit.org [Wed, 7 Sep 2011 17:05:41 +0000 (17:05 +0000)]
Skip accessibility/textbox-role-reports-selection.html on GTK+ bots because it has been failing.
The failure is tracked by the bug 67713.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResou...
ossy@webkit.org [Wed, 7 Sep 2011 17:04:22 +0000 (17:04 +0000)]
[Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=67254

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-07
Reviewed by Csaba Osztrogonác.

Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
derived from the running location of DumpRenderTree binary.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::pathToLocalResource):
(LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] The scene graph is rendered continuously even when the page is idle.
jocelyn.turcotte@nokia.com [Wed, 7 Sep 2011 16:43:19 +0000 (16:43 +0000)]
[Qt][WK2] The scene graph is rendered continuously even when the page is idle.
https://bugs.webkit.org/show_bug.cgi?id=67195

Reviewed by Tor Arne Vestbø.

Since tiledBackingStorePaintEnd is called even when no tile is dirty, the TiledDrawingArea
and its proxy are looping over DidRenderFrame and RenderNextFrame messages.
This causes QSGItem::update() to be called and consumes a lot of useless CPU cycles on the UI process.

Introduce a bool to send DidRenderFrame only when dirty content was rendered.

* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::TiledDrawingArea):
(WebKit::TiledDrawingArea::tiledBackingStorePaint):
(WebKit::TiledDrawingArea::tiledBackingStorePaintEnd):
* WebProcess/WebPage/TiledDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94675 268f45cc-cd09-0410-ab3c-d52691b4dbfc